1. 10 May, 2013 30 commits
    • zandobersek@gmail.com's avatar
      [Cairo] Remove the unnecessary CSSParser.h include in GradientCairo.cpp · 5bfa9073
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115910
      
      Reviewed by Laszlo Gombos.
      
      No new tests - no new functionality.
      
      * platform/graphics/cairo/GradientCairo.cpp: Remove the CSSParser.h include
      as the included declarations are not used anywhere.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bfa9073
    • dino@apple.com's avatar
      Include tab character as a word end for kerning · d0b89257
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115915
      <rdar://problem/13861491>
      
      Reviewed by Enrica Casucci.
      
      This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=112507
      which only looked for a space character as a word end. It should
      look for tab characters too.
      
      Source/WebCore:
      
      Test: fast/text/word-space-with-kerning-4.html
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::setLogicalWidthForTextRun): Look for '\t'.
      
      LayoutTests:
      
      * fast/text/word-space-with-kerning-4-expected.html: Added.
      * fast/text/word-space-with-kerning-4.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0b89257
    • akling@apple.com's avatar
      I accidentally the Java testing. · 3075fca7
      akling@apple.com authored
      * Scripts/webkitpy/port/mac.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3075fca7
    • andersca@apple.com's avatar
      Remove EventTracer · 3895cc0e
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115916
      
      Reviewed by Sam Weinig.
      
      EventTracer is dead code, remove it.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/EventTracer.cpp: Removed.
      * platform/EventTracer.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3895cc0e
    • zandobersek@gmail.com's avatar
      [GTK] Generated files are regenerated always · 7eaaf7be
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115908
      
      Reviewed by Carlos Garcia Campos.
      
      No new tests - no change in functionality.
      
      * GNUmakefile.am: Don't treat the window constructors IDL file as a dependency of the JavaScriptCore bindings.
      The file is generated during the IDL preprocessing, and the JSC bindings already depend on that step through
      the idl_supplemental_dependencies file. Because of that the window constructors IDL file has a phony target
      which seems to confuse the bindings generation rule into thinking that a complete regeration of the bindings is required.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eaaf7be
    • akling@apple.com's avatar
      Caching of generated images in CSS should be smarter. · f7adfcf4
      akling@apple.com authored
      <http://webkit.org/b/115902>
      <rdar://problem/13542727>
      
      Reviewed by Antti Koivisto.
      
      Add an IntSize => GeneratorGeneratedImage cache at the CSSImageGeneratorValue level.
      
      CSSGradientValue is currently the only CSSImageGeneratorValue subclass that makes use of the cache.
      Generated images are kept for 3 seconds after last use.
      
      The main problem with the previous approach was that background renderers (e.g <body>, <tr>, etc)
      would be passed to multiple CSSImageGeneratorValue::getImage() calls with different sizes requested
      for each of the descendent renderers that inherit their background from the same parent.
      The cache wasn't smart enough for this, it just thought the background renderer was changing size
      a lot, and would regenerate the image over and over.
      
      We already had caching of intermediate image buffers for GeneratorGeneratedImage::drawPattern().
      This removes the eviction timer from that cache so that the intermediate images can live a bit longer.
      
      (WebCore::CSSImageGeneratorValue::cachedImageForSize):
      (WebCore::CSSImageGeneratorValue::saveCachedImageForSize):
      
          Renamed from getImage() and putImage().
      
      (WebCore::CSSImageGeneratorValue::evictCachedGeneratedImage):
      (WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):
      (WebCore::CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired):
      
          Let the CachedGeneratedImage throw itself out from cache when the timer fires.
      
      * css/CSSImageGeneratorValue.h:
      (CachedGeneratedImage):
      
          Exactly what it sounds like. These go into CSSImageGeneratorValue::m_images with the size
          as the hash key.
      
      * platform/graphics/GeneratorGeneratedImage.cpp:
      (WebCore::GeneratorGeneratedImage::drawPattern):
      * platform/graphics/GeneratorGeneratedImage.h:
      (WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage):
      (WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):
      
          Keep the intermediate image for drawPattern() until destruction instead of dropping it on
          a timer. These objects are now evicted by the CSSImageGeneratorValue's image cache
          after 3 seconds of disuse rather than kept for the lifetime of the renderer.
      
      * css/CSSCanvasValue.cpp:
      (WebCore::CSSCanvasValue::canvasChanged):
      (WebCore::CSSCanvasValue::canvasResized):
      * css/CSSCrossfadeValue.cpp:
      (WebCore::CSSCrossfadeValue::crossfadeChanged):
      * rendering/style/StyleGeneratedImage.cpp:
      (WebCore::StyleGeneratedImage::addClient):
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::addClient):
      (WebCore::CSSImageGeneratorValue::removeClient):
      
          CSSImageGeneratorValue::m_clients is now a HashCountedSet<RenderObject*>, tweak accordingly.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7adfcf4
    • jer.noble@apple.com's avatar
      REGRESSION (r149439): Video turns blank upon entering full screen for the first time · ce8b7504
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115617
      
      Reviewed by Eric Carlson.
      
      Partially revert the change introduced in r149439 for OS X 10.8 and previous. On these
      platforms, create a window with a NSZeroSize initial frame, which fixes the "blank"
      first-full screen behavior.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView createFullScreenWindow]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce8b7504
    • zandobersek@gmail.com's avatar
      [WK2] Make the WebSoupRequestManager a supplement to the WebProcess · 01c50313
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115717
      
      Reviewed by Andreas Kling.
      
      WebSoupRequestManager should inherit from WebProcessSupplement and should be used as such
      by the WebProcess. This removes the need for the m_soupRequestManager member variable in
      the WebProcess class and brings the WebSoupRequestManager in line with other manager classes
      of which instances are controlled by the WebProcess class.
      
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::WebProcess): Add  the WebSoupRequestManager as a supplement.
      * WebProcess/WebProcess.h:
      (WebProcess): Remove the m_soupRequestManager member variable and its getter method.
      * WebProcess/soup/WebKitSoupRequestGeneric.cpp:
      (webkitSoupRequestGenericSendAsync): Access the WebSoupRequestManager as a supplement.
      (webkitSoupRequestGenericSendFinish): Ditto.
      * WebProcess/soup/WebProcessSoup.cpp:
      (WebKit::WebProcess::platformInitializeWebProcess): Access the WebSoupRequestManager as a supplement.
      * WebProcess/soup/WebSoupRequestManager.cpp:
      (WebKit::WebSoupRequestManager::supplementName): Specify the supplement's name.
      * WebProcess/soup/WebSoupRequestManager.h:
      (WebSoupRequestManager): Inherit from the WebProcessSupplement interface.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01c50313
    • commit-queue@webkit.org's avatar
      [GTK] Module Cairo fails to build under jhbuild · 25f2be0a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115854
      
      Patch by Brian Holt <brian.holt@samsung.com> on 2013-05-10
      Reviewed by Martin Robinson.
      
      Make cairo depend on glib in jhbuild.modules.
      
      * gtk/jhbuild.modules:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25f2be0a
    • andersca@apple.com's avatar
      Remove MemoryUsageSupport class · 526c552a
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115913
      
      Reviewed by Andreas Kling.
      
      MemoryUsageSupport was just used by a single call site in InspectorTimelineAgent,
      and the function called always returns zero on all platforms! Remove it.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * inspector/InspectorMemoryAgent.cpp:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore):
      (WebCore::InspectorTimelineAgent::setNativeHeapStatistics):
      * platform/MemoryUsageSupport.cpp: Removed.
      * platform/MemoryUsageSupport.h: Removed.
      * platform/qt/MemoryUsageSupportQt.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      526c552a
    • rniwa@webkit.org's avatar
      REGRESSION (r149652): Videos do not play on cnn.com, just black box · b9e8c3fd
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115887
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      The bug was caused by window and document named item maps counting the same element twice
      when it has the same id and name attribute values. Fixed the bug by avoiding to add or remove
      an element per id and name attribute updates when it had already been added or removed by
      name and id attribute updates respectively.
      
      We do this by checking whether the other attribute affects the element's precense in window
      and document named item maps and avoiding to add or remove the attribute when they do and
      the other attribute is present in updateId and updateName.
      
      Consider a scenario when an object element has id "foo", and name attribute is about to be also
      set to "foo". If the id attribute doesn't affect element's presense in window or document
      named item maps, we're done. If it does, then the maps already have this element so we don't
      want to add it again. Conversely, if the element already has id and name attributes set to
      "foo", and we're moving the id attribute, then we want to remove the element from the maps only
      if the id doesn't affect the presence of the element in the maps.
      
      Unfortuntely, this logic doesn't work when we're inserting or removing an element on its entirely
      because updateId and updateName are called when both id and name attributes are present so skip
      this step (AlwaysUpdateHTMLDocumentNamedItemMaps) for the id attribute to break the symmetry.
      
      Test: fast/dom/HTMLDocument/image-with-same-id-and-name.html
            fast/dom/HTMLDocument/object-with-same-id-and-name.html
      
      * dom/Element.cpp:
      (WebCore::Element::insertedInto): Call updateId and updateName with
      AlwaysUpdateHTMLDocumentNamedItemMaps.
      (WebCore::Element::removedFrom): Ditto.
      (WebCore::Element::updateName): Don't add or remove this element if the id attribute has already
      done so except when we're inserting, removing, or cloning an element.
      (WebCore::Element::updateId): Ditto for the name attribute.
      (WebCore::Element::cloneAttributesFromElement): Added a comment and assert that we never call this
      function when this element is in the document. We can't update window and documemt named item
      maps here because image element's id attribute value, for example, is present in the document's
      named item map if it has a name attribute. Since this function calls updateId and updateName
      before updating attributes, this check is going to fail in DocumentNameCollection's
      nodeMatchesIfIdAttributeMatch and bad things will happen.
      
      * dom/Element.h:
      
      * editing/ReplaceNodeWithSpanCommand.cpp:
      (WebCore::swapInNodePreservingAttributesAndChildren): Clone children and attributes before
      inserting the swapped span to avoid hitting the assertion in cloneAttributesFromElement we added.
      
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::parseAttribute):
      
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::updateDocNamedItem):
      
      LayoutTests:
      
      Add regression tests.
      
      * fast/dom/HTMLDocument/image-with-same-id-and-name-expected.txt: Added.
      * fast/dom/HTMLDocument/image-with-same-id-and-name.html: Added.
      * fast/dom/HTMLDocument/object-with-same-id-and-name-expected.txt: Added.
      * fast/dom/HTMLDocument/object-with-same-id-and-name.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9e8c3fd
    • dino@apple.com's avatar
      Don't trust character widths for internal OS X fonts in form controls · 643f50c9
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115883
      <rdar://problem/13817757>
      
      Reviewed by Darin Adler.
      
      We ignore the character width for a bunch of fonts when predicting
      the width of a form control. Some of the internal fonts in OS X are
      not in the ignored list. Rather than add them, simply test for
      fonts whose family begins with a period character ".".
      
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::hasValidAvgCharWidth): Return false for
          any family that starts with "."
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      643f50c9
    • carlosgc@webkit.org's avatar
      [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs · 8e515664
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115904
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      * bindings/gobject/WebKitDOMEventTarget.cpp:
      * platform/gtk/GtkVersioning.c:
      * platform/gtk/GtkVersioning.h:
      
      Source/WebKit2:
      
      * UIProcess/API/gtk/tests/TestInspectorServer.cpp:
      (startTestServerMonitor):
      * UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:
      (startTestServerMonitor):
      
      Source/WTF:
      
      * wtf/gobject/GRefPtr.cpp:
      
      Tools:
      
      * ImageDiff/gtk/ImageDiff.cpp:
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e515664
    • zarvai@inf.u-szeged.hu's avatar
      Unreviewed. Fix the ENABLE(SHARED_WORKERS) build after r149864. · 788840c1
      zarvai@inf.u-szeged.hu authored
      * workers/SharedWorkerThread.cpp: include "SecurityOrigin.h"
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      788840c1
    • kbalazs@webkit.org's avatar
      Add my new address to contributors.json. (Unreviewed) · e50ae476
      kbalazs@webkit.org authored
      * Scripts/webkitpy/common/config/contributors.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e50ae476
    • csaavedra@igalia.com's avatar
      Fix build after r149864. · b07d3c90
      csaavedra@igalia.com authored
      Unreviewed build fix.
      
      * loader/ThreadableLoader.h: include <wtf/text/AtomicString.h>
      when building with RESOURCE_TIMING enabled.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b07d3c90
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed. Move myself to the reviewers list. · 08a0eb62
      ch.dumez@sisa.samsung.com authored
      * Scripts/webkitpy/common/config/contributors.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08a0eb62
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed EFL gardening. · c542c685
      ch.dumez@sisa.samsung.com authored
      Rebaseline fast/dom/Range/getClientRects.html for EFL port.
      Skip accessibility/poorly-formed-aria-table.html introduced in
      r149858 but failing on EFL port.
      
      * platform/efl/TestExpectations:
      * platform/efl/fast/dom/Range/getClientRects-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c542c685
    • andersca@apple.com's avatar
      Fix build. · a7b0c739
      andersca@apple.com authored
      * bindings/js/ScriptController.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7b0c739
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · e34a2bbd
      zarvai@inf.u-szeged.hu authored
      * platform/qt/fast/js/global-constructors-attributes-expected.txt: Rebaselining after r149845.
      * platform/qt/inspector/console/command-line-api-expected.txt: Added after r149829.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e34a2bbd
    • andersca@apple.com's avatar
      Remove ScriptInstance.h · c9e8eb3f
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115900
      
      Reviewed by Andreas Kling.
      
      Remove yet another abstraction now that we don't support V8.
      
      * GNUmakefile.list.am:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/ScriptController.h:
      (Bindings):
      (ScriptController):
      * bindings/js/ScriptControllerMac.mm:
      (WebCore::ScriptController::createScriptInstanceForWidget):
      * bindings/js/ScriptInstance.h: Removed.
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::getInstance):
      * html/HTMLPlugInElement.h:
      (Bindings):
      (HTMLPlugInElement):
      * platform/graphics/wince/MediaPlayerProxy.h:
      (WebMediaPlayerProxy):
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9e8eb3f
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed EFL gardening. · 63fdfa78
      ch.dumez@sisa.samsung.com authored
      Skip several remaining shadow dom tests and rebaseline a few others.
      
      * platform/efl/TestExpectations:
      * platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Added.
      * platform/efl/fast/js/dom-static-property-for-in-iteration-expected.txt:
      * platform/efl/inspector/console/command-line-api-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63fdfa78
    • andersca@apple.com's avatar
      Unreviewed, rolling out r149866. · 7c4df494
      andersca@apple.com authored
      http://trac.webkit.org/changeset/149866
      https://bugs.webkit.org/show_bug.cgi?id=115898
      
      Broke tests
      
      * dom/Document.cpp:
      (WebCore::Document::setDomain):
      (WebCore::Document::initSecurityContext):
      * page/SecurityOrigin.cpp:
      (WebCore::SecurityOrigin::SecurityOrigin):
      (WebCore::SecurityOrigin::isolatedCopy):
      (WebCore::SecurityOrigin::setDomainFromDOM):
      (WebCore::SecurityOrigin::grantUniversalAccess):
      * page/SecurityOrigin.h:
      (SecurityOrigin):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c4df494
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed. Add my email to a few watchlists. · 3ff2f019
      ch.dumez@sisa.samsung.com authored
      * Scripts/webkitpy/common/config/watchlist:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ff2f019
    • abucur@adobe.com's avatar
      Remove overflow dead code · 3ec40ce7
      abucur@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115893
      
      Reviewed by Antti Koivisto.
      
      The patch removes unused public overflow accesor functions from RenderOverflow and InlineFlowBox.
      
      Tests: no tests, code cleanup.
      
      * rendering/InlineFlowBox.h: Removed logicalLeftLayoutOverflow and logicalRightLayoutOverflow.
      * rendering/RenderOverflow.h: Removed setMinYLayoutOverflow, setMaxYLayoutOverflow,
          setMinXLayoutOverflow, setMaxXLayoutOverflow, setMinYVisualOverflow, setMaxYVisualOverflow,
          setMinXVisualOverflow and setMaxXVisualOverflow.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ec40ce7
    • andersca@apple.com's avatar
      Begin making SecurityOrigin immutable · dfff6ca2
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115898
      
      Reviewed by Andreas Kling.
      
      Replace SecurityOrigin::setDomainFromDOM and SecurityOrigin::grantUniversalAccess with
      member functions that return new SecurityOrigin objects.
      
      * dom/Document.cpp:
      (WebCore::Document::setDomain):
      Update the security origin to one returned by copyWithDomainSetFromDOM.
      
      (WebCore::Document::initSecurityContext):
      Set the security origin to one returned by copyWithUniversalAccessGranted().
      
      * page/SecurityOrigin.cpp:
      (WebCore::SecurityOrigin::SecurityOrigin):
      Add a new constructor that takes all the member variables as parameters. This is a little unwieldy at the moment,
      but all the boolean parameters could be replaced by a bitmask of flags.
      
      (WebCore::SecurityOrigin::isolatedCopy):
      Call the new constructor.
      
      (WebCore::SecurityOrigin::copyWithDomainSetFromDOM):
      Return a new security origin with m_domainWasSetInDOM set to true and the domain updated.
      
      (WebCore::SecurityOrigin::copyWithUniversalAccessGranted):
      Return a new security origin with m_universalAccess set to true.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfff6ca2
    • andersca@apple.com's avatar
      Remove ScriptController::updateSecurityOrigin · b61156da
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115895
      
      Reviewed by Antti Koivisto.
      
      ScriptController::updateSecurityOrigin is just dead code now that the V8 bindings are gone.
      
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptController.h:
      * dom/Document.cpp:
      (WebCore::Document::setIsViewSource):
      (WebCore::Document::setDomain):
      * dom/Document.h:
      (Document):
      * dom/SecurityContext.cpp:
      (WebCore::SecurityContext::enforceSandboxFlags):
      * dom/SecurityContext.h:
      (SecurityContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b61156da
    • andersca@apple.com's avatar
      Stop including SecurityOrigin.h where unnecessary · 7e9e4116
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115897
      
      Reviewed by Antti Koivisto.
      
      Move rarely called functions out of line so headers don't have to include SecurityOrigin.h
      
      * Modules/indexeddb/IDBFactoryBackendImpl.h:
      * Modules/webdatabase/DatabaseBackendBase.cpp:
      (WebCore::DatabaseBackendBase::databaseDebugName):
      * Modules/webdatabase/DatabaseBackendBase.h:
      (DatabaseBackendBase):
      * Modules/webdatabase/DatabaseSync.h:
      * bindings/js/JSDOMWindowCustom.h:
      * html/parser/XSSAuditor.cpp:
      * loader/ThreadableLoader.cpp:
      (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
      (WebCore::ThreadableLoaderOptions::~ThreadableLoaderOptions):
      (WebCore::ThreadableLoader::create):
      * loader/ThreadableLoader.h:
      (ThreadableLoaderOptions):
      * loader/WorkerThreadableLoader.cpp:
      * workers/DedicatedWorkerContext.cpp:
      * workers/DedicatedWorkerThread.cpp:
      * workers/SharedWorkerContext.cpp:
      * workers/WorkerThread.cpp:
      * workers/WorkerThread.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e9e4116
    • commit-queue@webkit.org's avatar
      Unicode support missing from string representation of Contributors in committers.py · f8936e73
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115859
      
      Patch by Simon Pena <simon.pena@samsung.com> on 2013-05-10
      Reviewed by Darin Adler.
      
      Contributors, in committers.py, provided a string representation in __str__ which
      didn't support unicode characters, so printing a contributor would fail in that case.
      This patch implements __unicode__ and makes __str__ use it to represent a contributor.
      The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
      
      * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
      to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
      representation.
      (Contributor.__str__):
      (Contributor):
      (Contributor.__unicode__):
      * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
      a contributor with unicode characters can be represented as a string.
      (CommittersTest):
      (CommittersTest.test_contributor_encoding):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8936e73
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix GTK+ build after r149839. · 7ffcdb10
      carlosgc@webkit.org authored
      * platform/gtk/RenderThemeGtk3.cpp:
      (WebCore::gtkStyleChangedCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ffcdb10
  2. 09 May, 2013 10 commits