1. 27 Aug, 2002 6 commits
    • darin's avatar
      * force-clean-timestamp: Dave's changes require a full build. I found out the · 5b4129d2
      darin authored
      	hard way, by debugging for a while.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      i · 510de805
      rjw authored
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView mouseDown:]):
              (-[WebHTMLView mouseDragged:]):
              (-[WebHTMLView mouseMovedNotification:]):
              * WebView.subproj/WebHTMLViewPrivate.h:
              * WebView.subproj/WebHTMLViewPrivate.m:
              Fixed active link style.  Cleaned up and fixed drag initiation
              for links and images.  Dotted lines not drawing correcly, but
              other styles are applied correctly.
              * WebKit.exp:
              * History.subproj/WebHistory.h:
              * History.subproj/WebHistory.m:
              Added some constants.
              * WebCoreSupport.subproj/WebTextRendererFactory.m:
              Code to change CG caching policy.  Not enabled until
              we receive a root from CG team.
              * kwq/WebCoreBridge.h:
              Fixed constants to conform to WebKit.  These need to be shared.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Change relative positioned blocks so that they are treated as special objects and · 8dc5fa9f
      hyatt authored
      	painted last along with absolutely positioned blocks and floaters.  Note that the
      	entire special object system is fundamentally flawed, and it needs to be replaced
      	with a real layering subsystem.
      	This checkin at least gets relatively positioned divs painting correctly some of
      	the time (in the cases where the containing blocks of absolute and relative positioned
      	divs happen to be the same).  It does not, however, deal with the problem of ensuring
      	correct stacking of positioned elements with different containing blocks.
      	render_layer.h and .cpp include a new implementation (not used yet, just the beginnings)
      	of a layering subsystem that I am going to be working on over the next few days
      	that will eventually be responsible for handling event dispatching and painting and that
      	will also understand how to deal with form controls and other objects that have Cocoa
              * WebCore.pbproj/project.pbxproj:
              * khtml/rendering/render_box.cpp:
              * khtml/rendering/render_box.h:
              * khtml/rendering/render_flow.cpp:
              * khtml/rendering/render_flow.h:
              * khtml/rendering/render_layer.cpp: Added.
              * khtml/rendering/render_layer.h: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3031952 -- null-dereference in dispatchToUInt32 closing window · 7a0cc4de
      darin authored
              * khtml/ecma/kjs_window.cpp: (History::getValueProperty):
      	Use Undefined(), not Value() for an error result. Value() is pure evil.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3021018 -- Crash selecting from popup just after choosing radio button · e9782320
      darin authored
              * kwq/KWQComboBox.mm:
              (QComboBox::QComboBox): Pass the widget in when creating the cell.
              (-[KWQPopUpButtonCell initWithWidget:]): Store a widget pointer.
              (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Get to the bridge
      	and tell it to defer loading while we track the mouse.
              * kwq/KWQKHTMLPartImpl.h: Add bridgeForWidget.
              * kwq/KWQKHTMLPartImpl.mm:
              (KWQKHTMLPartImpl::nextKeyViewForWidget): Use nodeForWidget and partForNode.
              (KWQKHTMLPartImpl::bridgeForWidget): Added. Use nodeForWidget and partForNode.
              (KWQKHTMLPartImpl::partForNode): Move code here from nextKeyViewForWidget.
              (KWQKHTMLPartImpl::nodeForWidget): Move code here from nextKeyViewForWidget.
              * kwq/WebCoreBridge.h: Add defersLoading and setDefersLoading. Both are already
      	in WebKit.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3031583 -- directory.apple.com now gives "unsupported" redirect · 17fd8f40
      darin authored
              * WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:attributes:flags:]):
      	Don't create the resource handle here. It's a bit too early.
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]):
      	Create the resource handle here, now that we have a controller to get a user agent from.
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient handleWillUseUserAgent:forURL:]): Add an assert that will catch
      	any future problems of this kind.
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge defersLoading]): Added. New call for use in WebCore.
              (-[WebBridge setDefersLoading:]): Added. New call for use in WebCore.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. 26 Aug, 2002 6 commits
    • hyatt's avatar
      Fix for 3026006. Ensure that TABLES inside <div>s with align="right" · 2a24c185
      hyatt authored
      	are properly positioned.  <div align="right"> was completely
      	unimplemented.  This patch implements it for the common cases
      	(nested divs, tables within divs, and paragraphs).
              * khtml/css/html4.css:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Add machinery for deferring callbacks. Not used yet. · ff48f350
      darin authored
              * WebView.subproj/WebControllerPrivate.h: Add methods.
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebController _defersCallbacks]): Returns old state.
              (-[WebController _setDefersCallbacks:]): Changes state and calls _defersCallbacksChanged
      	on the main frame.
              * WebView.subproj/WebFramePrivate.h: Add _defersCallbacksChanged.
              * WebView.subproj/WebFramePrivate.m: (-[WebFrame _defersCallbacksChanged]):
      	Calls _defersCallbacksChanged on both data sources.
              * WebView.subproj/WebDataSourcePrivate.h: Add _defersCallbacksChanged.
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _setController:]): Call _defersCallbacksChanged if changing the controller
      	changes the state.
              (-[WebDataSource _addResourceHandle:]): Call setDefersCallbacks:YES on the new handle if
      	we are already attached to a controller that defers callbacks.
              (-[WebDataSource _defersCallbacksChanged]): Call setDefersCallbacks on all the handles, and
      	call _defersCallbacksChanged on the child frames as well.
              * WebView.subproj/WebDataSource.m: (-[WebDataSource controller]):
      	We need to know about all controller changes, so it's unacceptable to consult our
      	parent about the controller. But we already do know about it and this code was unnecessary.
      	Leave the old code around as an assert only.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      * khtml/rendering/render_list.cpp: · 4febf6d5
      darin authored
      	Make file match the original KDE more closely (no substantive change).
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      WebBrowser: · ff141680
      rjw authored
              * History.subproj/WebHistory.h:
              * History.subproj/WebHistory.m:
              (+[WebHistory webHistoryWithFile:]):
              Stage 1, set the shared history instance.  This'll move to
              WebKit soon.
              * WebView.subproj/WebView.m:
              (-[WebView setFrame:]):
              Only force display if in live resize.
              Fixed for 2883623 (visited links only).  Will change
              w/ stage 2 of history move to webkit.
              * GlobalHistory.m:
              (-[GlobalHistory awakeFromNib]):
              * WebCore.exp:
              Added WebCoreHistory
              * WebCore.pbproj/project.pbxproj:
              Added WebCoreHistory
              * kwq/KWQKHistoryProvider.mm:
              Use WebCoreHistory to determine visited link.
              * kwq/WebCoreHistory.h: Added.
              * kwq/WebCoreHistory.m: Added.
              Stage 1.  Use WebKit's WebHistory.  Writing
              of history and initialization still handled
              by Alex until stage 2.
              (+[WebCoreHistory setSharedHistory:]):
              (+[WebCoreHistory sharedHistory]):
              (-[WebCoreHistory containsURL:]):
              * kwq/KWQString.mm:
              Optimization, use strcmp when both src and dst have valid ascii.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      - Patch drawText to understand right-aligned drawing. · fb9df4c8
      hyatt authored
      	- Fixed <ul> bullets so that they position properly.
      	- Fixed bugs with horizontal and vertical positioning of
      	  <ol> bullets.
              * khtml/rendering/render_list.cpp:
              * kwq/KWQPainter.mm:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sullivan's avatar
      WebKit: · 6955e345
      sullivan authored
      	- fixed bug where dragging a separator in the Bookmarks window
      	would hit an assertion.
              * Bookmarks.subproj/WebBookmarkSeparator.m:
              (-[WebBookmarkSeparator initWithGroup:]): Removed obsolete
      	assertion that group is not nil.
              * Bookmarks.subproj/WebBookmarkLeaf.m:
              (-[WebBookmarkLeaf initWithTitle:group:]):
      	Removed a similar obsolete assertion here.
              * Bookmarks.subproj/WebBookmarkList.m:
              (-[WebBookmarkList initWithTitle:group:]):
      	Removed a similar obsolete assertion here.
      	- fixed bug where new separator would not be scrolled
      	into view if necessary.
              * BookmarksController.m:
              (-[BookmarksController _focusOnNewlyCreatedBookmark:]):
      	Scroll to reveal new item.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. 25 Aug, 2002 1 commit
    • darin's avatar
      - fixed 3032072 -- Crash on reload in DOM::DocumentImpl::~DocumentImpl [unified]() · ca9d1cdd
      darin authored
      	This was a tough one to debug.
      	Turned out to be a subtle bug in our new QConstString implementation.
              * kwq/KWQString.mm:
              (QStringData::makeAscii): Don't invalidate the Unicode buffer unless the ASCII
      	buffer is taking over the internal buffer from the Unicode. In other cases, it's
      	important not to invalidate the Unicode because it can result in the Unicode being
      	freed and re-created when unicode() is called, which is disastrous in the QConstString
      	case because we can't free the Unicode.
              (QStringData::makeUnicode): Make the corresponding change for ASCII too. In this
      	case, it's just an optimization, not a bug fix.
              (QString::insert), (QString::remove), (QString::fill), (QString::operator+=):
      	Mark the other string invalid whenever we modify either the ASCII or the Unicode
      	string. This was handled correctly for some operations before, but not all, and it
      	now matters because makeAscii and makeUnicode will now allow this state.
      	Fixed a separate QString problem; I think I may have introduced this one.
              * kwq/KWQString.mm:
              (QString::getNSString): Since by ASCII, we actually mean ISO Latin 1, we can't use
      	[NSString stringWithCString:]. Use CFStringCreateWithCString instead, pass
      	CFStringCreateWithCString as the encoding, and use autorelease. We shouldn't really
      	use the term ASCII in this class for the 8-bit-per-character buffer. Something more
      	like Latin1 would be a more accurate way to refer to it. Maybe I'll do that renaming
      	after talking to Richard about it on Monday.
      	Fixed a small storage leak.
              * khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cleanup): Added braces to
      	fix obviously-incorrect if/else grouping.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. 23 Aug, 2002 5 commits
    • darin's avatar
      WebKit: · 598f25f2
      darin authored
              * WebView.subproj/WebFrame.m: (-[WebFrame reset]): Remove unneeded call to _reset.
              * WebView.subproj/WebFramePrivate.m: (-[WebFrame _setDataSource:]): Add code that
      	removes the KHTML stuff from the frame when switching to another type of view.
      	It would be better to do this at some other level, but without this code, we end
      	up leaving the entire KHTMLView behind when we switch to a non-HTML page.
      	Debugging tool to make it easy to reproduce problems like 3021018, where
      	a page transition happens while you are holding a menu down.
              * Debug/DebugUtilities.m:
              (-[DebugUtilities createDebugMenu]): Add "Go to about:blank Soon menu item".
              (-[BrowserDocument goToAboutBlankSoon:]): Implementation.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Got the kurl-test in the Tests directory working again. · 8c6ffe7d
      darin authored
              * kwq/KWQKURL.mm: (KURL::KURL): Fixed problem where relative path resolution code
      	for "../" could eat up the host name too, treating it as part of the path.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3032058 -- Links on local developer doc pages all broken (all local files?) · e9604b12
      darin authored
              * kwq/KWQKURL.mm: (KURL::getNSURL): Re-added a workaround for CFURL bug 2908969.
      	We have to hack to make NSURL take "file:/" URLs.
              * kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrame): Add a nil check.
      	I ran into this because my frame failed to load.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      A few more KURL changes that reduce it down to background noise · 486188ee
      mjs authored
      	For me this gave another 1-2% improvement on cvs-base.
              * kwq/kdecore/kurl.h:
              * kwq/KWQKURL.mm:
              (KURL::KURL): In the relative constructor, do all work in a char
      	array for the relative path case, and leave it up to ::parse to
      	create a QString.
              (KURL::parse): Do all work in a char array, only creating a
      	QString at the end if needed. Also, take an optional pointer to
      	the QString that the char * was created from, and if the final
      	processed URL is the same as the original, assign the original
      	instead of creating a new QString.
              (KURL::setProtocol): Adjust for prase() interface change.
              (KURL::setHost): Likewise.
              (KURL::setPort): Likewise.
              (KURL::setRef): Likewise.
              (KURL::setQuery): Likewise.
              (KURL::setPath): Likewise.
              (appendEscapingBadChars): Instead of taking and returning
      	a QString like the old escapeBadChars, copy from and write into
      	existing C string buffers.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      * force-clean-timestamp: Without this, I crash on startup. · 7c4650bc
      darin authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. 22 Aug, 2002 9 commits
    • mjs's avatar
      top level: · 801d972b
      mjs authored
      	Fix test results to no longer reflect KURL or CFURL oddities that
      	we are not emulating.
              * Tests/kde/kurl-test.chk:
              * Tests/kde/kurl-test.cpp:
              (testURL): Replay mistaken n with \n.
      	Brand new KURL implementation which avoids CFURL, CFString, and
      	all that other allocation-happy goodness and instead does as much
      	work as possible with raw ASCII buffers.
      	For me this gave a ~5% performance improvement on cvs-base.
              * kwq/KWQKURL.mm:
              * kwq/kdecore/kurl.h:
              * khtml/khtml_part.cpp:
              (KHTMLPart::end): Don't call KURL::clearCaches() any more.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      * kwq/KWQButton.mm: (QButton::~QButton): Disconnect the view · 5c0d1e03
      darin authored
      	from the widget by doing setTarget:nil.
              * kwq/KWQComboBox.mm: (QComboBox::~QComboBox): Ditto.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Add vertical margins for checkboxes and radios. A later rule · fc866e87
      hyatt authored
      	in the file was overriding my earlier attempt to set up these margins.
              * khtml/css/html4.css:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      New faster char * append (actually insert) for mjs. · 2fc5cf73
      rjw authored
              * kwq/KWQString.mm:
              * kwq/qt/qstring.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      i Changed public string from #define to extern NSString. · efc60dc9
      rjw authored
              * WebKit.exp:
              * WebView.subproj/WebController.h:
              * WebView.subproj/WebController.m:
              * WebView.subproj/WebDefaultContextMenuHandler.m:
              (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
              (-[WebDefaultContextMenuHandler openNewWindowWithURL:]):
              (-[WebDefaultContextMenuHandler downloadURL:]):
              (-[WebDefaultContextMenuHandler openLinkInNewWindow:]):
              (-[WebDefaultContextMenuHandler downloadLinkToDisk:]):
              (-[WebDefaultContextMenuHandler copyLinkToClipboard:]):
              (-[WebDefaultContextMenuHandler openImageInNewWindow:]):
              (-[WebDefaultContextMenuHandler downloadImageToDisk:]):
              (-[WebDefaultContextMenuHandler copyImageToClipboard:]):
              (-[WebDefaultContextMenuHandler openFrameInNewWindow:]):
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLView _elementAtPoint:]):
              (-[WebHTMLView _continueAfterCheckingDragForEvent:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Some small QString improvements. · e4f02e0f
      darin authored
              * kwq/qt/qstring.h: Add printf attribute to sprintf member function.
              * kwq/KWQString.mm:
      	Remove extra \n characters from QSTRING_FAILURE calls. Change some
      	fprintf to QSTRING_FAILURE. Change some QSTRING_FAILURE to KWQ_ASSERT.
              (QStringData::makeAscii): Fix bug where it would update _maxAscii
      	with a new size even when it didn't allocate a new buffer.
              (QStringData::makeUnicode): Fix bug where it would update _maxUnicode
      	with a new size even when it didn't allocate a new buffer.
              (QString::utf8): Fix bug where it assumed the UTF-8 form of a string
      	has the same length as the Unicode version. Also save one allocation
      	by doing it right into the QCString.
              (QString::local8Bit): Just call utf8().
              (QString::setNum): Have all these call our sprintf.
              (QString::sprintf): Format once to get the length. Then do the second
      	format right into the string buffer. This way we don't have to do
      	any allocation at all, nor use CFString.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kocienda's avatar
      Passing the main load's attributes to the subresource loads causes · f3518160
      kocienda authored
      	breakage (most visible when we POST).
      	Right now, we just rely on flags to handle "back/forward" loads, so
      	the attributes were not actually being used.
      	A better fix needs to be put in place when the soon-to-be-done
      	attributes/flags rework is done.
              * WebCoreSupport.subproj/WebSubresourceClient.m:
              (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • vicki's avatar
      · 42949084
      vicki authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Fixed a one-click crasher that Ken and Don told me about. · 6871eacd
      darin authored
              * kwq/KWQObject.mm: (QObject::QObject): Initialize m_eventFilterObject.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  6. 21 Aug, 2002 9 commits
    • rjw's avatar
      Simple name change. Plugin -> NetscapePlugin in anticipation · 26de617a
      rjw authored
              of other plugin related API.
              Removed vestigal WebDocumentLoading.
              * Plugins.subproj/WebPlugin.h:
              * Plugins.subproj/WebPlugin.m:
              (-[WebNetscapePlugin load]):
              * Plugins.subproj/WebPluginDatabase.h:
              * Plugins.subproj/WebPluginDatabase.m:
              (+[WebNetscapePluginDatabase installedPlugins]):
              (-[WebNetscapePluginDatabase pluginForMimeType:]):
              (-[WebNetscapePluginDatabase pluginForExtension:]):
              (-[WebNetscapePluginDatabase pluginWithFilename:]):
              (-[WebNetscapePluginDatabase MIMETypes]):
              (-[WebNetscapePluginDatabase init]):
              * Plugins.subproj/WebPluginNullEventSender.h:
              * Plugins.subproj/WebPluginNullEventSender.m:
              (-[WebNetscapePluginNullEventSender initWithPluginView:]):
              (-[WebNetscapePluginNullEventSender sendNullEvents]):
              * Plugins.subproj/WebPluginStream.h:
              * Plugins.subproj/WebPluginStream.m:
              (-[WebNetscapePluginStream getFunctionPointersFromPluginView:]):
              (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:attributes:]):
              * Plugins.subproj/WebPluginView.h:
              * Plugins.subproj/WebPluginView.m:
              (-[WebNetscapePluginView initWithFrame:plugin:URL:baseURL:mime:arguments:]):
              (-[WebNetscapePluginView start]):
              (-[WebNetscapePluginView provisionalDataSourceChanged:]):
              (-[WebNetscapePluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]):
              (-[WebNetscapePluginView destroyStream:reason:]):
              * WebCoreSupport.subproj/WebViewFactory.m:
              (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]):
              (-[WebViewFactory pluginsInfo]):
              (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
              * WebView.subproj/WebController.h:
              * WebView.subproj/WebController.m:
              (+[WebController canShowMIMEType:]):
              * WebView.subproj/WebDocument.h:
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView provisionalDataSourceChanged:]):
              (-[WebHTMLView provisionalDataSourceCommitted:]):
              (-[WebHTMLView dataSourceUpdated:]):
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[NSView _web_stopIfPluginView]):
              * WebView.subproj/WebImageView.h:
              * WebView.subproj/WebTextView.h:
              * WebView.subproj/WebView.h:
              * WebView.subproj/WebViewPrivate.h:
              * WebView.subproj/WebViewPrivate.m:
              (-[WebView _makeDocumentViewForDataSource:]):
              Still need to muck with cvs server to change file names.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3021908 -- text areas should be plain text only · d878c548
      darin authored
              * kwq/KWQTextArea.mm:
              (-[KWQTextArea _createTextView]): setRichText:NO
              (-[KWQTextArea dealloc]): Release the text view so we don't leak.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      * kwq/KWQNSViewExtras.m: (-[NSClipView _KWQ_scrollRectToVisible:inView:]): · e497e7aa
      darin authored
      	Use bounds, not visibleRect. Seems to work better.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sullivan's avatar
      - commented out (with FIXME 2935687) the code that was advertising in · 17ee7fc4
      sullivan authored
      	the status bar that shift-command would open a link behind the
      	current window, since it doesn't.
              * kwq/KWQKHTMLPartImpl.mm:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Fix for two problems with password fields. · 85521099
      darin authored
      	   1) Return wasn't working.
       	   2) They were wrapping instead of scrolling.
              * kwq/KWQNSTextField.mm:
              (-[KWQNSTextField setUpTextField:]): Shared initialization, needed by both
      	the text field and the secure field. This includes the two things we needed
      	for the password text field; wiring up action properly and setScrollable:YES.
              (-[KWQNSTextField initWithFrame:]): Use setUpTextField.
      	(-[KWQNSTextField setPasswordMode:]): Use setUpTextField.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for 3015372, tables and blocks nested inside other tables · d0e5b904
      hyatt authored
      	don't center.  This fixes a lot of sites, from the forum
      	sites to the www.ve3d.com voodooextreme site.
              * khtml/html/html_tableimpl.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3027927 -- selected text fields do not cause the web view to scroll to reveal them · 0a83d42a
      darin authored
              * kwq/KWQNSTextField.mm:
              (-[KWQNSTextField becomeFirstResponder]): Call [self _KWQ_scrollFrameToVisible].
              (-[KWQSecureTextField becomeFirstResponder]): Call [self _KWQ_scrollFrameToVisible].
              * kwq/KWQNSViewExtras.h: Added. New scrolling functions.
              * kwq/KWQNSViewExtras.m: Added. New scrolling functions.
              * WebCore.pbproj/project.pbxproj: Added KWQNSViewExtras.
              * kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrame):
      	Make sure superview and position is set up properly before we try to tab to something.
              * kwq/KWQWidget.mm: (QWidget::setFocus):
      	Make sure superview and position is set up properly before we try to focus something.
      	Unrelated change.
              * kwq/KWQInvisibleButton.h:
              * kwq/KWQInvisibleButton.mm:
      	Add KWQ prefix to the name of the private Objective C class to avoid potential conflicts.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Implemented baseline alignment for form elements. We decided that this was better · 85a35cfb
      darin authored
      	than what we're currently doing. But it will look even better when the font of the
      	text field matches the font of the surrounding text, so we should consider that.
      	I also nudged the text down one pixel in popup menus, to match buttons. I think we
      	probably should suggest that this be done in Aqua by default (buttons and popup menus
      	already match in the normal size; this is the small size).
              * khtml/rendering/render_form.h: Remove some APPLE_CHANGES.
              * khtml/rendering/render_form.cpp:
              (RenderFormElement::baselinePosition): Use the widget's concept of the baseline
      	position (the new QWidget::baselinePosition function).
              (RenderButton::baselinePosition): Just call the inherited version.
              (RenderSubmitButton::baselinePosition): Remove our ifdef because we want what the
      	original code said, which was just calling the inherited version.
      	(RenderLineEdit::baselinePosition): Removed our added method since we want to just
      	call the inherited version.
              (RenderSelect::baselinePosition): Just call the inherited version for the pop up
      	menu case. For the list box, just left the old code alone until someone can take
      	a look at it.
              * kwq/qt/qwidget.h: Added new virtual baselinePosition function.
              * kwq/KWQWidget.mm: (QWidget::baselinePosition): Default for baseline is the bottom.
              * kwq/qt/qlineedit.h:
              * kwq/KWQLineEdit.mm:
              (QLineEdit::baselinePosition): Compute the baseline based on how NSTextField does it.
      	Compared to the other widgets this was easy, because the cell's drawingRectForBounds
      	gives you the place where the top of the line is. It does use defaultLineHeightForFont,
      	which is not used by other widgets, but that's no real problem.
              * kwq/qt/qbutton.h:
              * kwq/KWQButton.mm: Moved all the code that's push-button specific into QPushButton.
              * kwq/qt/qpushbutton.h:
              * kwq/KWQPushButton.mm:
              (QPushButton::QPushButton): Set the bezel style of the button.
              (QPushButton::sizeHint): Moved here from QButton.
              (QPushButton::frameGeometry): Moved here from QButton.
              (QPushButton::setFrameGeometry): Moved here from QButton.
              (QPushButton::baselinePosition): Compute the baseline based on how NSButton does it.
      	The rule for the style of button we use is "centered vertically in the available space,
      	offset by kThemePushButtonSmallTextOffset", so I had to hardcode the value of
      	kThemePushButtonSmallTextOffset; I called it VERTICAL_FUDGE_FACTOR (2).
              * kwq/qt/qcombobox.h:
              * kwq/KWQComboBox.mm:
              (-[KWQPopUpButtonCell drawInteriorWithFrame:inView:]): Custom cell class that nudges
      	the text down one pixel.
              (QComboBox::QComboBox): Attach the custom cell class.
              (QComboBox::baselinePosition): Compute the baseline based on how NSPopUpButton does it.
      	The rule for the style of pop-up button we use is "CELLOFFSET pixels down from the top",
      	so I had to hardcode the value of CELLOFFSET; I called it VERTICAL_FUDGE_FACTOR (2).
              * force-clean-timestamp: Yes, again.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Raising the layout delay from 0.75 to 1.00. This should be · ed7ecd98
      hyatt authored
      	a little more conservative and matches the value used by Gecko.
              * WebView.subproj/WebPreferences.m:
              (+[WebPreferences load]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@1888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. 20 Aug, 2002 4 commits