1. 06 Sep, 2011 40 commits
    • commit-queue@webkit.org's avatar
      Unzip initialization lists and constructors in JSCell hierarchy (5/7) · 5ab29813
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67420
      
      Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-06
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      Completed the fifth level of the refactoring to add finishCreation()
      methods to all classes within the JSCell hierarchy with non-trivial
      constructor bodies.
      
      This primarily consists of pushing the calls to finishCreation() down
      into the constructors of the subclasses of the second level of the hierarchy
      as well as pulling the finishCreation() calls out into the class's corresponding
      create() method if it has one.  Doing both simultaneously allows us to
      maintain the invariant that the finishCreation() method chain is called exactly
      once during the creation of an object, since calling it any other number of
      times (0, 2, or more) will cause an assertion failure.
      
      * API/JSCallbackConstructor.cpp:
      (JSC::JSCallbackConstructor::JSCallbackConstructor):
      * API/JSCallbackConstructor.h:
      (JSC::JSCallbackConstructor::create):
      * API/JSCallbackFunction.cpp:
      (JSC::JSCallbackFunction::JSCallbackFunction):
      (JSC::JSCallbackFunction::finishCreation):
      * API/JSCallbackFunction.h:
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * debugger/DebuggerActivation.cpp:
      * debugger/DebuggerActivation.h:
      (JSC::DebuggerActivation::create):
      * jsc.cpp:
      (GlobalObject::finishCreation):
      (GlobalObject::GlobalObject):
      * runtime/ArrayConstructor.cpp:
      (JSC::ArrayConstructor::ArrayConstructor):
      (JSC::ArrayConstructor::finishCreation):
      * runtime/ArrayConstructor.h:
      * runtime/ArrayPrototype.cpp:
      (JSC::ArrayPrototype::ArrayPrototype):
      * runtime/ArrayPrototype.h:
      (JSC::ArrayPrototype::create):
      * runtime/BooleanConstructor.cpp:
      (JSC::BooleanConstructor::BooleanConstructor):
      (JSC::BooleanConstructor::finishCreation):
      * runtime/BooleanConstructor.h:
      * runtime/BooleanObject.cpp:
      (JSC::BooleanObject::BooleanObject):
      * runtime/BooleanObject.h:
      (JSC::BooleanObject::create):
      * runtime/BooleanPrototype.cpp:
      (JSC::BooleanPrototype::BooleanPrototype):
      (JSC::BooleanPrototype::finishCreation):
      * runtime/BooleanPrototype.h:
      * runtime/DateConstructor.cpp:
      (JSC::DateConstructor::DateConstructor):
      (JSC::DateConstructor::finishCreation):
      * runtime/DateConstructor.h:
      * runtime/DateInstance.cpp:
      (JSC::DateInstance::DateInstance):
      * runtime/DateInstance.h:
      (JSC::DateInstance::create):
      * runtime/DatePrototype.cpp:
      (JSC::DatePrototype::DatePrototype):
      (JSC::DatePrototype::finishCreation):
      * runtime/DatePrototype.h:
      * runtime/Error.cpp:
      (JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
      * runtime/ErrorConstructor.cpp:
      (JSC::ErrorConstructor::ErrorConstructor):
      (JSC::ErrorConstructor::finishCreation):
      * runtime/ErrorConstructor.h:
      * runtime/ErrorPrototype.cpp:
      (JSC::ErrorPrototype::ErrorPrototype):
      * runtime/ErrorPrototype.h:
      (JSC::ErrorPrototype::create):
      * runtime/FunctionConstructor.cpp:
      (JSC::FunctionConstructor::FunctionConstructor):
      (JSC::FunctionConstructor::finishCreation):
      * runtime/FunctionConstructor.h:
      * runtime/FunctionPrototype.cpp:
      (JSC::FunctionPrototype::FunctionPrototype):
      (JSC::FunctionPrototype::finishCreation):
      * runtime/FunctionPrototype.h:
      * runtime/InternalFunction.cpp:
      (JSC::InternalFunction::InternalFunction):
      * runtime/InternalFunction.h:
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::JSActivation):
      * runtime/JSActivation.h:
      (JSC::JSActivation::create):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::create):
      (JSC::JSGlobalObject::JSGlobalObject):
      * runtime/JSONObject.cpp:
      (JSC::JSONObject::JSONObject):
      * runtime/JSONObject.h:
      (JSC::JSONObject::create):
      * runtime/JSStaticScopeObject.h:
      (JSC::JSStaticScopeObject::create):
      (JSC::JSStaticScopeObject::JSStaticScopeObject):
      * runtime/JSString.cpp:
      (JSC::StringObject::create):
      * runtime/MathObject.cpp:
      (JSC::MathObject::MathObject):
      * runtime/MathObject.h:
      (JSC::MathObject::create):
      * runtime/NativeErrorConstructor.cpp:
      (JSC::NativeErrorConstructor::NativeErrorConstructor):
      * runtime/NativeErrorConstructor.h:
      (JSC::NativeErrorConstructor::finishCreation):
      * runtime/NativeErrorPrototype.cpp:
      (JSC::NativeErrorPrototype::NativeErrorPrototype):
      (JSC::NativeErrorPrototype::finishCreation):
      * runtime/NativeErrorPrototype.h:
      * runtime/NumberConstructor.cpp:
      (JSC::NumberConstructor::NumberConstructor):
      (JSC::NumberConstructor::finishCreation):
      * runtime/NumberConstructor.h:
      * runtime/NumberObject.cpp:
      (JSC::NumberObject::NumberObject):
      * runtime/NumberObject.h:
      (JSC::NumberObject::create):
      * runtime/NumberPrototype.cpp:
      (JSC::NumberPrototype::NumberPrototype):
      (JSC::NumberPrototype::finishCreation):
      * runtime/NumberPrototype.h:
      * runtime/ObjectConstructor.cpp:
      (JSC::ObjectConstructor::ObjectConstructor):
      (JSC::ObjectConstructor::finishCreation):
      * runtime/ObjectConstructor.h:
      * runtime/RegExpConstructor.cpp:
      (JSC::RegExpConstructor::RegExpConstructor):
      (JSC::RegExpConstructor::finishCreation):
      (JSC::RegExpMatchesArray::RegExpMatchesArray):
      * runtime/RegExpConstructor.h:
      * runtime/RegExpMatchesArray.h:
      (JSC::RegExpMatchesArray::create):
      * runtime/RegExpObject.cpp:
      (JSC::RegExpObject::RegExpObject):
      * runtime/RegExpObject.h:
      (JSC::RegExpObject::create):
      * runtime/RegExpPrototype.cpp:
      (JSC::RegExpPrototype::RegExpPrototype):
      * runtime/StringConstructor.cpp:
      (JSC::StringConstructor::StringConstructor):
      (JSC::StringConstructor::finishCreation):
      * runtime/StringConstructor.h:
      * runtime/StringObject.cpp:
      (JSC::StringObject::StringObject):
      * runtime/StringObject.h:
      (JSC::StringObject::create):
      * runtime/StringObjectThatMasqueradesAsUndefined.h:
      (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
      * runtime/StringPrototype.cpp:
      (JSC::StringPrototype::StringPrototype):
      (JSC::StringPrototype::finishCreation):
      * runtime/StringPrototype.h:
      
      Source/JavaScriptGlue:
      
      Completed the fifth level of the refactoring to add finishCreation()
      methods to all classes within the JSCell hierarchy with non-trivial
      constructor bodies.
      
      This primarily consists of pushing the calls to finishCreation() down
      into the constructors of the subclasses of the second level of the hierarchy
      as well as pulling the finishCreation() calls out into the class's corresponding
      create() method if it has one.  Doing both simultaneously allows us to
      maintain the invariant that the finishCreation() method chain is called exactly
      once during the creation of an object, since calling it any other number of
      times (0, 2, or more) will cause an assertion failure.
      
      * JSRun.cpp:
      (JSGlueGlobalObject::JSGlueGlobalObject):
      
      Source/WebCore:
      
      No new tests.
      
      Completed the fifth level of the refactoring to add finishCreation()
      methods to all classes within the JSCell hierarchy with non-trivial
      constructor bodies.
      
      This primarily consists of pushing the calls to finishCreation() down
      into the constructors of the subclasses of the second level of the hierarchy
      as well as pulling the finishCreation() calls out into the class's corresponding
      create() method if it has one.  Doing both simultaneously allows us to
      maintain the invariant that the finishCreation() method chain is called exactly
      once during the creation of an object, since calling it any other number of
      times (0, 2, or more) will cause an assertion failure.
      
      * WebCore.exp.in:
      * bindings/js/JSDOMBinding.h:
      (WebCore::DOMConstructorObject::DOMConstructorObject):
      * bindings/js/JSDOMGlobalObject.cpp:
      (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
      (WebCore::JSDOMGlobalObject::finishCreation):
      * bindings/js/JSDOMGlobalObject.h:
      * bindings/js/JSDOMWindowShell.cpp:
      * bindings/js/JSDOMWindowShell.h:
      (WebCore::JSDOMWindowShell::create):
      * bindings/js/JSDOMWrapper.h:
      (WebCore::JSDOMWrapper::JSDOMWrapper):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      (WebCore::JSTestInterface::JSTestInterface):
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
      (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::JSTestObj::JSTestObj):
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
      * bridge/c/CRuntimeObject.cpp:
      (JSC::Bindings::CRuntimeObject::CRuntimeObject):
      (JSC::Bindings::CRuntimeObject::finishCreation):
      * bridge/c/CRuntimeObject.h:
      * bridge/jni/jsc/JavaRuntimeObject.cpp:
      (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
      (JSC::Bindings::JavaRuntimeObject::finishCreation):
      * bridge/jni/jsc/JavaRuntimeObject.h:
      * bridge/objc/ObjCRuntimeObject.h:
      * bridge/objc/ObjCRuntimeObject.mm:
      (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
      (JSC::Bindings::ObjCRuntimeObject::finishCreation):
      * bridge/objc/objc_runtime.h:
      (JSC::Bindings::ObjcFallbackObjectImp::create):
      * bridge/objc/objc_runtime.mm:
      (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
      * bridge/qt/qt_pixmapruntime.cpp:
      (JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
      * bridge/qt/qt_runtime.cpp:
      (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
      (JSC::Bindings::QtRuntimeMethod::finishCreation):
      * bridge/qt/qt_runtime.h:
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::RuntimeArray):
      * bridge/runtime_array.h:
      (JSC::RuntimeArray::create):
      * bridge/runtime_method.cpp:
      (JSC::RuntimeMethod::RuntimeMethod):
      (JSC::RuntimeMethod::finishCreation):
      * bridge/runtime_method.h:
      * bridge/runtime_object.cpp:
      (JSC::Bindings::RuntimeObject::RuntimeObject):
      * bridge/runtime_object.h:
      (JSC::Bindings::RuntimeObject::create):
      
      Source/WebKit/mac:
      
      Completed the fifth level of the refactoring to add finishCreation()
      methods to all classes within the JSCell hierarchy with non-trivial
      constructor bodies.
      
      This primarily consists of pushing the calls to finishCreation() down
      into the constructors of the subclasses of the second level of the hierarchy
      as well as pulling the finishCreation() calls out into the class's corresponding
      create() method if it has one.  Doing both simultaneously allows us to
      maintain the invariant that the finishCreation() method chain is called exactly
      once during the creation of an object, since calling it any other number of
      times (0, 2, or more) will cause an assertion failure.
      
      * Plugins/Hosted/ProxyRuntimeObject.h:
      * Plugins/Hosted/ProxyRuntimeObject.mm:
      (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
      (WebKit::ProxyRuntimeObject::finishCreation):
      
      Source/WebKit2:
      
      Completed the fifth level of the refactoring to add finishCreation()
      methods to all classes within the JSCell hierarchy with non-trivial
      constructor bodies.
      
      This primarily consists of pushing the calls to finishCreation() down
      into the constructors of the subclasses of the second level of the hierarchy
      as well as pulling the finishCreation() calls out into the class's corresponding
      create() method if it has one.  Doing both simultaneously allows us to
      maintain the invariant that the finishCreation() method chain is called exactly
      once during the creation of an object, since calling it any other number of
      times (0, 2, or more) will cause an assertion failure.
      
      * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
      (WebKit::JSNPMethod::JSNPMethod):
      (WebKit::JSNPMethod::finishCreation):
      * WebProcess/Plugins/Netscape/JSNPMethod.h:
      (WebKit::JSNPMethod::create):
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      (WebKit::JSNPObject::JSNPObject):
      * WebProcess/Plugins/Netscape/JSNPObject.h:
      (WebKit::JSNPObject::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ab29813
    • jamesr@google.com's avatar
      [chromium] Update chromium gpu baseline due to skia roll · 344e1970
      jamesr@google.com authored
      * platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      344e1970
    • macpherson@chromium.org's avatar
      Implement list style properties in CSSStyleApplyProperty. · 40587a9d
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67103
      
      Reviewed by Eric Seidel.
      
      No new tests / no behavioral changes.
      
      * css/CSSStyleApplyProperty.cpp:
      Add class to wrap call to CSSStyleSelector::styleImage().
      (WebCore::ApplyPropertyStyleImage::ApplyPropertyStyleImage):
      (WebCore::ApplyPropertyStyleImage::applyValue):
      (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
      Initialize handlers for list style properties.
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      Remove existing property implementations.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40587a9d
    • jamesr@google.com's avatar
      [chromium] Update various chromium baselines. · e55757db
      jamesr@google.com authored
      * platform/chromium-cg-mac-leopard/fast/css/value-list-out-of-bounds-crash-expected.png:
      * platform/chromium-cg-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png:
      * platform/chromium-mac/fast/dom/Window/window-lookup-precedence-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt.
      * platform/chromium-mac/fast/dom/wrapper-classes-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/wrapper-classes-expected.txt.
      * platform/chromium-win/svg/batik/text/textStyles-expected.png:
      * platform/chromium-win/svg/batik/text/textStyles-expected.txt:
      * platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt:
      * platform/chromium/fast/dom/wrapper-classes-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e55757db
    • fpizlo@apple.com's avatar
      Accessibility tests crashing in BasicRawSentinelNode code · a4749644
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67682
      
      Reviewed by Geoffrey Garen.
      
      A CodeBlock should ensure that no other CodeBlocks have references to it after
      it is destroyed.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::~CodeBlock):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4749644
    • commit-queue@webkit.org's avatar
      Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=67486 · 4f9ccebd
      commit-queue@webkit.org authored
      This reverts r65993 which gives wrong results for rshift
      in some corner cases (see the test).
      
      Patch by Yong Li <yoli@rim.com> on 2011-09-06
      Reviewed by Gavin Barraclough.
      
      New test: fast/js/floating-point-truncate-rshift.html
      
      * assembler/ARMAssembler.h:
      * assembler/MacroAssemblerARM.h:
      (JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
      (JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=67486
      Add a test case for branchTruncateDoubleToInt32() which is
      used in right shift optimization when the assembler
      "supportsFloatingPointTruncate".
      
      Patch by Yong Li <yoli@rim.com> on 2011-09-06
      Reviewed by Gavin Barraclough.
      
      * fast/js/floating-point-truncate-rshift-expected.txt: Added.
      * fast/js/floating-point-truncate-rshift.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f9ccebd
    • mrowe@apple.com's avatar
      Versioning. · 5c6cdf86
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c6cdf86
    • alexis.menard@openbossa.org's avatar
      [Qt] Move away from QPointer as it is slow and it has a replacement QWeakPointer. · 7f056151
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67673
      
      Reviewed by Ariya Hidayat.
      
      Source/WebCore:
      
      Move away from QPointer to QWeakPointer, it is faster.
      
      No new tests, the existing ones should cover.
      
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtInstance::~QtInstance):
      (JSC::Bindings::QtInstance::getClass):
      (JSC::Bindings::QtField::name):
      (JSC::Bindings::QtField::valueFromInstance):
      * bridge/qt/qt_instance.h:
      (JSC::Bindings::QtInstance::getObject):
      * bridge/qt/qt_runtime.h:
      * platform/qt/SharedTimerQt.cpp:
      (WebCore::SharedTimerQt::inst):
      
      Source/WebKit/qt:
      
      Move away from QPointer as Qt provides a better and faster solution : QWeakPointer.
      
      * Api/qwebframe.cpp:
      (QWebHitTestResult::linkTargetFrame):
      (QWebHitTestResult::frame):
      * Api/qwebframe_p.h:
      * Api/qwebpage.cpp:
      (QWebPagePrivate::QWebPagePrivate):
      (QWebPagePrivate::~QWebPagePrivate):
      (QWebPagePrivate::acceptNavigationRequest):
      (QWebPagePrivate::createMainFrame):
      (QWebPagePrivate::updateAction):
      (QWebPagePrivate::mouseMoveEvent):
      (QWebPagePrivate::mousePressEvent):
      (QWebPagePrivate::mouseDoubleClickEvent):
      (QWebPagePrivate::mouseTripleClickEvent):
      (QWebPagePrivate::mouseReleaseEvent):
      (QWebPage::createStandardContextMenu):
      (QWebPagePrivate::wheelEvent):
      (QWebPagePrivate::focusInEvent):
      (QWebPage::setPalette):
      (QWebPagePrivate::touchEvent):
      (QWebPage::~QWebPage):
      (QWebPage::mainFrame):
      (QWebPage::viewportSize):
      (QWebPage::preferredContentsSize):
      (QWebPage::setContentEditable):
      (QWebPage::updatePositionDependentActions):
      * Api/qwebpage_p.h:
      * Api/qwebview.cpp:
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::contextMenu):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::createFrame):
      * tests/qwebframe/tst_qwebframe.cpp:
      (tst_QWebFrame::ownership):
      * tests/qwebpage/tst_qwebpage.cpp:
      (PluginCounterPage::PluginCounterPage):
      (PluginTracerPage::createPlugin):
      (tst_QWebPage::createViewlessPlugin):
      * tests/qwebview/tst_qwebview.cpp:
      (tst_QWebView::reusePage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f056151
    • dpranke@chromium.org's avatar
      fix MockFileSystem.glob(), refactor filesystem tests · 694ee7a7
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67462
      
      Reviewed by Eric Seidel.
      
      In debugging why my proposed change for MockFileSystem.glob()
      in bug 66228 didn't work, I stumbled across two real bugs
      that cancelled each other out for the unit tests. I fixed those
      (glob shouldn't recurse into subdirs, and we weren't populating
      self.dirs from self.files properly).
      
      I have also created a "mixin" class for tests that can be shared
      between the real filesystem and the mock filesystem - MockFileSystem
      is being used enough it needs its own tests.
      
      * Scripts/webkitpy/common/system/filesystem_mock.py:
      * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
      * Scripts/webkitpy/common/system/filesystem_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      694ee7a7
    • oliver@apple.com's avatar
      Update expected results of bindings tests. · 954c00b6
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      954c00b6
    • fpizlo@apple.com's avatar
      Unreviewed build fix for r94559. · af478bbc
      fpizlo@apple.com authored
              
      Marked the relevant parameters as unused if !ENABLE(JIT), and surrounded
      new out-of-line JIT-specific method definitions with !ENABLE(JIT).
      
      * bytecode/CodeBlock.cpp:
      * runtime/Executable.cpp:
      (JSC::EvalExecutable::compileInternal):
      (JSC::ProgramExecutable::compileInternal):
      (JSC::FunctionExecutable::compileForCallInternal):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af478bbc
    • abarth@webkit.org's avatar
      editing/selection/mixed-editability-10.html is failing on the bots · 8958327d
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67683
      
      Update editing/selection/mixed-editability-10.html baselines after
      HTMLSpanElement introduction.
      
      * editing/selection/mixed-editability-10-expected.txt:
      * platform/qt/editing/selection/mixed-editability-10-expected.png: Removed.
          - This test is no longer an image test.
      * platform/qt/editing/selection/mixed-editability-10-expected.txt:
      * platform/win/editing/selection/mixed-editability-10-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8958327d
    • eric@webkit.org's avatar
      Remove window.HTMLBlockquoteElement per HTML5 (and DOM Core 1) · dd5a3fe4
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67678
      
      Reviewed by Darin Adler.
      
      This is why we can't have nice things.
      
      There was some confusion in the original DOM HTML 1 spec about
      the existence of HTMlBlockquoteElement which was clarified by
      a later errata, removing HTMLBlockquoteElement:
      http://www.w3.org/DOM/updates/REC-DOM-Level-1-19981001-errata.html
      "This interface is an error and must be ignored. The Interface HTMLQuoteElement is used for both the Q and BLOCKQUOTE elements"
      
      Le sigh.  Personally I think having a separate HTMLBlockquoteElement
      is clearer, but thats not how the web works.  Removed it and updated test results.
      
      * CMakeLists.txt:
      * CodeGenerators.pri:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/gobject/GNUmakefile.am:
      * editing/IndentOutdentCommand.cpp:
      * html/HTMLBlockquoteElement.cpp: Removed.
      * html/HTMLBlockquoteElement.h: Removed.
      * html/HTMLBlockquoteElement.idl: Removed.
      * html/HTMLElementsAllInOne.cpp:
      * html/HTMLQuoteElement.cpp:
      (WebCore::HTMLQuoteElement::HTMLQuoteElement):
      (WebCore::HTMLQuoteElement::insertedIntoDocument):
      * html/HTMLTagNames.in:
      * page/DOMWindow.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd5a3fe4
    • rniwa@webkit.org's avatar
      Rename confirmCompositionWithoutDisturbingSelection to cancelComposition · ce2a1a3d
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67569
      
      Reviewed by Antonio Gomes.
      
      Source/WebCore: 
      
      Renamed Editor::confirmCompositionWithoutDisturbingSelection to Editor::cancelComposition.
      Also renamed the shared function from confirmComposition to setComposition.
      
      * WebCore.exp.in:
      * editing/Editor.cpp:
      (WebCore::Editor::confirmComposition):
      (WebCore::Editor::cancelComposition):
      (WebCore::Editor::setComposition):
      * editing/Editor.h:
      
      Source/WebKit/chromium: 
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::unmarkText):
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::EditorClient::respondToChangedSelection):
      
      Source/WebKit/mac: 
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _updateSelectionForInputManager]):
      
      Source/WebKit/win: 
      
      * WebView.cpp:
      (WebView::resetIME):
      
      Source/WebKit2: 
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView resignFirstResponder]):
      (-[WKView _updateTextInputStateIncludingSecureInputState:]):
      * UIProcess/WebPageProxy.h:
      * UIProcess/mac/WebPageProxyMac.mm:
      (WebKit::WebPageProxy::cancelComposition):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::cancelComposition):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce2a1a3d
    • jamesr@google.com's avatar
      [chromium] Update expectations for a few tests that render oddly on xp due to r94589 · 4172e9cf
      jamesr@google.com authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4172e9cf
    • weinig@apple.com's avatar
      WebVTTTokenizer files in the wrong place in the Xcode project. · e37399ef
      weinig@apple.com authored
      * WebCore.xcodeproj/project.pbxproj:
      Move WebVTTTokenizer files so they are in the right place in the project.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e37399ef
    • crogers@google.com's avatar
      MediaElementAudioSourceNode destruction triggers ASSERTS · baa073da
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67665
      
      Reviewed by Nate Chapin.
      
      Source/WebCore:
      
      Test: webaudio/mediaelementaudiosourcenode-gc.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::setAudioSourceNode):
      * webaudio/AudioContext.cpp:
      (WebCore::AudioContext::uninitializeDispatch):
      (WebCore::AudioContext::stop):
      * webaudio/AudioContext.h:
      
      LayoutTests:
      
      * webaudio/mediaelementaudiosourcenode-gc-expected.txt: Added.
      * webaudio/mediaelementaudiosourcenode-gc.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baa073da
    • mrowe@apple.com's avatar
      Fix broken PPC build due to new dtoa library · ab4856c5
      mrowe@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67654
      
      Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-06
      Reviewed by Dan Bernstein.
      
      Added condition for PPC in the new dtoa compatibility check so that
      building won't fail.
      
      * wtf/dtoa/utils.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab4856c5
    • jamesr@google.com's avatar
      [chromium] Update pixel baselines for r94597 · cedf32e6
      jamesr@google.com authored
      * platform/chromium-cg-mac/fast/borders/border-image-scaled-expected.png: Added.
      * platform/chromium-cg-mac/fast/borders/border-image-side-reduction-expected.png: Added.
      * platform/chromium-cg-mac/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
      * platform/chromium-cg-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
      * platform/chromium-linux/fast/borders/border-image-scaled-expected.png: Added.
      * platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.png:
      * platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
      * platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
      * platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
      * platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
      * platform/chromium-win/fast/borders/border-image-longhand-expected.png: Added.
      * platform/chromium-win/fast/borders/border-image-longhand-expected.txt: Added.
      * platform/chromium-win/fast/borders/border-image-scaled-expected.png: Added.
      * platform/chromium-win/fast/borders/border-image-scaled-expected.txt: Added.
      * platform/chromium-win/fast/borders/border-image-side-reduction-expected.png: Added.
      * platform/chromium-win/fast/borders/border-image-side-reduction-expected.txt: Added.
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
      * platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
      * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cedf32e6
    • abarth@webkit.org's avatar
      [Chromium] Add WebFloatQuad.h for Android · 77afb8fe
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67573
      
      Reviewed by Darin Fisher.
      
      Android uses this wrapper of WebCore::FloatQuad in some API methods
      (which will appear in subsequent patches).
      
      * WebKit.gyp:
      * public/WebFloatQuad.h: Added.
      * src/WebFloatQuad.cpp: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77afb8fe
    • alexis.menard@openbossa.org's avatar
      [Qt] Fix API test failure after r92823 and r93001. · 425c3eb5
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67676
      
      Reviewed by Kenneth Rohde Christiansen.
      
      r92823 and r93001 make WebKit no longer produce wrapping style
      spans on copy and paste and class="Apple-style-span" anymore.
      Our expectations need to be updated.
      
      * tests/qwebpage/tst_qwebpage.cpp:
      (tst_QWebPage::cursorMovements):
      (tst_QWebPage::textSelection):
      (tst_QWebPage::findText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      425c3eb5
    • abarth@webkit.org's avatar
      [Chromium] Add didAcceptIndices to ExternalPopupMenuClient for Android · f2b42f21
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67574
      
      Reviewed by Darin Fisher.
      
      In Android, external popup menus can admit multiple selection (e.g.,
      for listboxes presented using external UI).
      
      * public/WebExternalPopupMenuClient.h:
      * src/ExternalPopupMenu.cpp:
      (WebKit::ExternalPopupMenu::didAcceptIndices):
      * src/ExternalPopupMenu.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2b42f21
    • oliver@apple.com's avatar
      An object's structure should reference the global object responsible for its creation · ee1bdc80
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67624
      
      Reviewed by Gavin Barraclough.
      
      Source/JavaScriptCore:
      
      Add a reference to a GlobalObject to Structure, and update all calls to
      Structure::create() to pass the global object that is the origin for that
      structure.  For objects where the appropriate global object isn't available
      at construction time (global object prototypes, etc), or objects that
      logically don't have a global object (strings, etc) we just pass null.
      
      This change is largely mechanical (passing a new globalObject parameter
      around).
      
      * API/JSCallbackConstructor.h:
      (JSC::JSCallbackConstructor::createStructure):
      * API/JSCallbackFunction.h:
      (JSC::JSCallbackFunction::createStructure):
      * API/JSCallbackObject.h:
      (JSC::JSCallbackObject::createStructure):
      * API/JSContextRef.cpp:
      * JavaScriptCore.exp:
      * debugger/DebuggerActivation.h:
      (JSC::DebuggerActivation::createStructure):
      * runtime/Arguments.h:
      (JSC::Arguments::createStructure):
      * runtime/ArrayConstructor.h:
      (JSC::ArrayConstructor::createStructure):
      * runtime/ArrayPrototype.h:
      (JSC::ArrayPrototype::createStructure):
      * runtime/BooleanObject.h:
      (JSC::BooleanObject::createStructure):
      * runtime/BooleanPrototype.h:
      (JSC::BooleanPrototype::createStructure):
      * runtime/DateConstructor.h:
      (JSC::DateConstructor::createStructure):
      * runtime/DateInstance.h:
      (JSC::DateInstance::createStructure):
      * runtime/DatePrototype.h:
      (JSC::DatePrototype::createStructure):
      * runtime/ErrorInstance.h:
      (JSC::ErrorInstance::createStructure):
      * runtime/ErrorPrototype.h:
      (JSC::ErrorPrototype::createStructure):
      * runtime/Executable.h:
      (JSC::ExecutableBase::createStructure):
      (JSC::NativeExecutable::createStructure):
      (JSC::EvalExecutable::createStructure):
      (JSC::ProgramExecutable::createStructure):
      (JSC::FunctionExecutable::createStructure):
      * runtime/FunctionPrototype.h:
      (JSC::FunctionPrototype::createStructure):
      * runtime/GetterSetter.h:
      (JSC::GetterSetter::createStructure):
      * runtime/InternalFunction.h:
      (JSC::InternalFunction::createStructure):
      * runtime/JSAPIValueWrapper.h:
      (JSC::JSAPIValueWrapper::createStructure):
      * runtime/JSActivation.h:
      (JSC::JSActivation::createStructure):
      * runtime/JSArray.h:
      (JSC::JSArray::createStructure):
      * runtime/JSByteArray.cpp:
      (JSC::JSByteArray::createStructure):
      * runtime/JSByteArray.h:
      * runtime/JSFunction.h:
      (JSC::JSFunction::createStructure):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::reset):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::finishCreation):
      (JSC::JSGlobalObject::createStructure):
      * runtime/JSNotAnObject.h:
      (JSC::JSNotAnObject::createStructure):
      * runtime/JSONObject.h:
      (JSC::JSONObject::createStructure):
      * runtime/JSObject.cpp:
      (JSC::JSObject::createInheritorID):
      * runtime/JSObject.h:
      (JSC::JSObject::createStructure):
      (JSC::JSNonFinalObject::createStructure):
      (JSC::JSFinalObject::createStructure):
      (JSC::createEmptyObjectStructure):
      * runtime/JSObjectWithGlobalObject.h:
      (JSC::JSObjectWithGlobalObject::createStructure):
      * runtime/JSPropertyNameIterator.h:
      (JSC::JSPropertyNameIterator::createStructure):
      * runtime/JSStaticScopeObject.h:
      (JSC::JSStaticScopeObject::createStructure):
      * runtime/JSString.h:
      (JSC::RopeBuilder::createStructure):
      * runtime/JSVariableObject.h:
      (JSC::JSVariableObject::createStructure):
      * runtime/JSWrapperObject.h:
      (JSC::JSWrapperObject::createStructure):
      * runtime/MathObject.h:
      (JSC::MathObject::createStructure):
      * runtime/NativeErrorConstructor.h:
      (JSC::NativeErrorConstructor::createStructure):
      (JSC::NativeErrorConstructor::constructorBody):
      * runtime/NumberConstructor.h:
      (JSC::NumberConstructor::createStructure):
      * runtime/NumberObject.h:
      (JSC::NumberObject::createStructure):
      * runtime/NumberPrototype.h:
      (JSC::NumberPrototype::createStructure):
      * runtime/ObjectConstructor.h:
      (JSC::ObjectConstructor::createStructure):
      * runtime/ObjectPrototype.h:
      (JSC::ObjectPrototype::createStructure):
      * runtime/RegExp.h:
      (JSC::RegExp::createStructure):
      * runtime/RegExpConstructor.h:
      (JSC::RegExpConstructor::createStructure):
      * runtime/RegExpObject.h:
      (JSC::RegExpObject::createStructure):
      * runtime/RegExpPrototype.h:
      (JSC::RegExpPrototype::createStructure):
      * runtime/ScopeChain.h:
      (JSC::ScopeChainNode::createStructure):
      * runtime/StrictEvalActivation.h:
      (JSC::StrictEvalActivation::createStructure):
      * runtime/StringConstructor.h:
      (JSC::StringConstructor::createStructure):
      * runtime/StringObject.h:
      (JSC::StringObject::createStructure):
      * runtime/StringObjectThatMasqueradesAsUndefined.h:
      (JSC::StringObjectThatMasqueradesAsUndefined::create):
      (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
      * runtime/StringPrototype.h:
      (JSC::StringPrototype::createStructure):
      * runtime/Structure.cpp:
      (JSC::Structure::Structure):
      (JSC::Structure::visitChildren):
      * runtime/Structure.h:
      (JSC::Structure::create):
      (JSC::Structure::globalObject):
      (JSC::Structure::setGlobalObject):
      * runtime/StructureChain.h:
      (JSC::StructureChain::createStructure):
      
      Source/JavaScriptGlue:
      
      Update for Structure::create() requiring a global object.
      
      * JSRun.h:
      (JSGlueGlobalObject::create):
      * UserObjectImp.h:
      (UserObjectImp::createStructure):
      
      Source/WebCore:
      
      Update calls to Structure::create() to pass the globalObject in,
      and update the CodeGenerator to generate appropriate createStructure
      methods.
      
      * bindings/js/JSAudioConstructor.h:
      (WebCore::JSAudioConstructor::createStructure):
      * bindings/js/JSDOMBinding.h:
      (WebCore::DOMConstructorObject::createStructure):
      (WebCore::getDOMStructure):
      * bindings/js/JSDOMGlobalObject.h:
      (WebCore::JSDOMGlobalObject::createStructure):
      (WebCore::getDOMConstructor):
      * bindings/js/JSDOMWindowBase.h:
      (WebCore::JSDOMWindowBase::createStructure):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::setWindow):
      * bindings/js/JSDOMWindowShell.h:
      (WebCore::JSDOMWindowShell::createStructure):
      * bindings/js/JSDOMWrapper.h:
      (WebCore::JSDOMWrapper::createStructure):
      * bindings/js/JSImageConstructor.h:
      (WebCore::JSImageConstructor::createStructure):
      * bindings/js/JSImageDataCustom.cpp:
      (WebCore::toJS):
      * bindings/js/JSOptionConstructor.h:
      (WebCore::JSOptionConstructor::createStructure):
      * bindings/js/JSWorkerContextBase.h:
      (WebCore::JSWorkerContextBase::createStructure):
      * bindings/js/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::initScript):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      (GenerateConstructorDeclaration):
      * bridge/c/CRuntimeObject.h:
      (JSC::Bindings::CRuntimeObject::createStructure):
      * bridge/c/c_instance.cpp:
      (JSC::Bindings::CRuntimeMethod::createStructure):
      * bridge/jni/jsc/JavaInstanceJSC.cpp:
      (JavaRuntimeMethod::createStructure):
      * bridge/jni/jsc/JavaRuntimeObject.h:
      (JSC::Bindings::JavaRuntimeObject::createStructure):
      * bridge/objc/ObjCRuntimeObject.h:
      (JSC::Bindings::ObjCRuntimeObject::createStructure):
      * bridge/objc/objc_instance.mm:
      (ObjCRuntimeMethod::createStructure):
      * bridge/objc/objc_runtime.h:
      (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
      * bridge/runtime_array.h:
      (JSC::RuntimeArray::createStructure):
      * bridge/runtime_method.h:
      (JSC::RuntimeMethod::createStructure):
      * bridge/runtime_object.h:
      (JSC::Bindings::RuntimeObject::createStructure):
      
      Source/WebKit/mac:
      
      Update for new Structure::create() globalObject parameter.
      
      * Plugins/Hosted/ProxyInstance.mm:
      (WebKit::ProxyRuntimeMethod::createStructure):
      * Plugins/Hosted/ProxyRuntimeObject.h:
      (WebKit::ProxyRuntimeObject::createStructure):
      
      Source/WebKit2:
      
      Update for new Structure::create globalObject parameter.
      
      * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
      (WebKit::JSNPMethod::create):
      * WebProcess/Plugins/Netscape/JSNPMethod.h:
      (WebKit::JSNPMethod::createStructure):
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      (WebKit::JSNPObject::create):
      * WebProcess/Plugins/Netscape/JSNPObject.h:
      (WebKit::JSNPObject::createStructure):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee1bdc80
    • andersca@apple.com's avatar
      Move NPAPI headers in bridge to plugins · 4d4eff0b
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67661
      
      Source/WebCore: 
      
      Reviewed by Darin Adler.
      
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      Update build systems.
      
      * bridge/npapi.h: Removed.
      * bridge/npruntime.h: Removed.
      * bridge/nptypes.h: Removed.
      * plugins/npapi.h: Copied from Source/WebCore/bridge/npapi.h.
      * plugins/npruntime.h: Copied from Source/WebCore/bridge/npruntime.h.
      * plugins/nptypes.h: Copied from Source/WebCore/bridge/nptypes.h.
      
      Tools: 
      
      Update forwarding headers.
      
      * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
      * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d4eff0b
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=67672 · 9a2d6d26
      hyatt@apple.com authored
              
      Improve background-size parsing. Make it actually dump auto values properly, and also make it omit
      auto if it is the second value. Fix the parsing to not create a value list when only a singleton value
      is specified.
      
      Reviewed by Beth Dakin.
      
      Covered well by existing tests.
      
      Source/WebCore: 
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::fillSizeToCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFillSize):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::mapFillSize):
      
      LayoutTests: 
      
      * fast/backgrounds/size/parsing-background-size-values-expected.txt:
      * fast/backgrounds/size/parsing-inherit-expected.txt:
      * fast/backgrounds/size/resources/parsing-background-size-values.js:
      * fast/backgrounds/size/resources/parsing-inherit.js:
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt:
      * fast/css/value-list-out-of-bounds-crash.html:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a2d6d26
    • hyatt@apple.com's avatar
      Fix build bustage from accidental project file addition. · a160a93c
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a160a93c
    • hyatt@apple.com's avatar
      Update some layout test results following the improved Pair parsing code that landed in r94593. · 834935b0
      hyatt@apple.com authored
      * fast/backgrounds/size/parsing-background-size-values-expected.txt:
      * fast/backgrounds/size/resources/parsing-background-size-values.js:
      * fast/reflections/reflection-computed-style-expected.txt:
      * inspector/elements/elements-panel-styles-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      834935b0
    • fpizlo@apple.com's avatar
      LayoutTests does not include a test for DFG speculation recovery of additions · 7f27edf3
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67667
      
      Reviewed by Geoffrey Garen.
      
      * fast/js/add-recovery-expected.txt: Added.
      * fast/js/add-recovery.html: Added.
      * fast/js/script-tests/add-recovery.js: Added.
      (destructiveAddForBoxedInteger):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f27edf3
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=67657 · 9095db97
      hyatt@apple.com authored
              
      Implement border-image-width. This patch stops short of converting -webkit-border-image to a shorthand.
      I'll do that in the next patch.
      
      Note that unlike the -webkit-border-image syntax, border-image-width does not actually set the border
      width values. It simply makes cuts into the border image drawing area (which for now is just the border
      box, but that will change once border-image-outset is implemented).
              
      This means we need additional storage for the slices, since they are now separate from the border widths.
              
      For backwards compatibility, -webkit-border-image will continue to set the border widths when
      border-image-width is specified in the -webkit-border-image shorthand.
      
      Reviewed by Beth Dakin.
      
      Source/WebCore: 
      
      Added new tests in fast/borders.
      
      * css/CSSBorderImageSliceValue.cpp:
      (WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue):
      (WebCore::CSSBorderImageSliceValue::cssText):
      * css/CSSBorderImageSliceValue.h:
      (WebCore::CSSBorderImageSliceValue::create):
      (WebCore::CSSBorderImageSliceValue::slices):
      Rename slices() to imageSlices() and add borderSlices() and m_borderSlices to hold the desired cuts
      for the border image drawing area. Converted the slices over to the new Quad primitive value (a RectBase
      subclass that is identical to Rect but dumps as a quad instead of a rect primitive).
      
      * css/CSSBorderImageValue.cpp:
      (WebCore::CSSBorderImageValue::CSSBorderImageValue):
      (WebCore::CSSBorderImageValue::cssText):
      * css/CSSBorderImageValue.h:
      (WebCore::CSSBorderImageValue::create):
      Make CSSBorderImageValue take the border slices during construction now.
          
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::valueForNinePieceImageSlice):
      (WebCore::valueForNinePieceImageWidth):
      (WebCore::valueForNinePieceImageRepeat):
      (WebCore::valueForNinePieceImage):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      Add support for computed style via valueForNinePieceImageWidth. Patch all of the border image properties
      to dump the most compact form possible for the property values, e.g., "stretch stretch" becomes "stretch."
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      (WebCore::CSSParser::parseReflect):
      (WebCore::BorderImageParseContext::BorderImageParseContext):
      (WebCore::BorderImageParseContext::commitImageSlice):
      (WebCore::BorderImageParseContext::commitBorderWidth):
      (WebCore::BorderImageParseContext::commitBorderImage):
      (WebCore::CSSParser::parseBorderImage):
      (WebCore::isBorderImageRepeatKeyword):
      (WebCore::CSSParser::parseBorderImageRepeat):
      (WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
      (WebCore::CSSParser::parseBorderImageSlice):
      (WebCore::BorderImageWidthParseContext::BorderImageWidthParseContext):
      (WebCore::BorderImageWidthParseContext::allowNumber):
      (WebCore::BorderImageWidthParseContext::allowFinalCommit):
      (WebCore::BorderImageWidthParseContext::top):
      (WebCore::BorderImageWidthParseContext::commitNumber):
      (WebCore::BorderImageWidthParseContext::setAllowFinalCommit):
      (WebCore::BorderImageWidthParseContext::setTop):
      (WebCore::BorderImageWidthParseContext::commitBorderImageWidth):
      (WebCore::CSSParser::parseBorderImageWidth):
      * css/CSSParser.h:
      Modify the border-image code to pass off border-image-width parsing to parseBorderImageWidth.
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::isValidCSSUnitTypeForDoubleConversion):
      (WebCore::CSSPrimitiveValue::init):
      (WebCore::CSSPrimitiveValue::cleanup):
      (WebCore::CSSPrimitiveValue::getQuadValue):
      (WebCore::CSSPrimitiveValue::cssText):
      * css/CSSPrimitiveValue.h:
      (WebCore::CSSPrimitiveValue::getQuadValue):
      Add the new Quad value to CSSPrimitiveValue.
          
      * css/CSSPropertyNames.in:
      Add the new properties for border-image-width and -webkit-mask-box-image-width.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      (WebCore::CSSStyleSelector::mapNinePieceImage):
      (WebCore::CSSStyleSelector::mapNinePieceImageSlice):
      (WebCore::CSSStyleSelector::mapNinePieceImageWidth):
      (WebCore::CSSStyleSelector::loadPendingImages):
      * css/CSSStyleSelector.h:
      Add the code to map the image width into border slices.
          
      * css/Rect.h:
      (WebCore::RectBase::top):
      (WebCore::RectBase::right):
      (WebCore::RectBase::bottom):
      (WebCore::RectBase::left):
      (WebCore::RectBase::setTop):
      (WebCore::RectBase::setRight):
      (WebCore::RectBase::setBottom):
      (WebCore::RectBase::setLeft):
      (WebCore::RectBase::RectBase):
      (WebCore::RectBase::~RectBase):
      (WebCore::Rect::create):
      (WebCore::Rect::Rect):
      (WebCore::Quad::create):
      (WebCore::Quad::Quad):
      Adding the new Quad value.
      
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::computeBorderImageSide):
      (WebCore::RenderBoxModelObject::paintNinePieceImage):
      Modify painting to treat the border slices as separate from the border widths.
              
      * rendering/style/NinePieceImage.cpp:
      (WebCore::NinePieceImage::operator==):
      * rendering/style/NinePieceImage.h:
      (WebCore::NinePieceImage::NinePieceImage):
      (WebCore::NinePieceImage::imageSlices):
      (WebCore::NinePieceImage::setImageSlices):
      (WebCore::NinePieceImage::borderSlices):
      (WebCore::NinePieceImage::setBorderSlices):
      (WebCore::NinePieceImage::copyImageSlicesFrom):
      (WebCore::NinePieceImage::copyBorderSlicesFrom):
      * rendering/style/StyleRareNonInheritedData.cpp:
      Add the border slices.
              
      (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
      * rendering/style/StyleReflection.h:
      (WebCore::StyleReflection::StyleReflection):
      Make sure masks and reflections default border-image-width to auto instead of 1, since that matches
      old behavior.
      
      LayoutTests: 
      
      * fast/borders/border-image-longhand.html: Added.
      * fast/borders/border-image-scaled.html: Added.
      * fast/borders/border-image-side-reduction.html: Added.
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-with-zoom-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
      * fast/css/large-value-csstext-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9095db97
    • tony@chromium.org's avatar
      [chromium] Check in 'build' for compiled binaries first · 700cc7b0
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67549
      
      Reviewed by Dirk Pranke.
      
      I'm working on moving the windows build output to a common location
      rather than relative to the sln file.  Because of that, we need to
      check those build locations first for DumpRenderTree.exe.
      
      * Scripts/webkitpy/layout_tests/port/chromium_win.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      700cc7b0
    • noel.gordon@gmail.com's avatar
      [chromium skia] JPEGImageEncoder: hoist constants out of the encoding loop · db43ad15
      noel.gordon@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67589
      
      Reviewed by Kenneth Russell.
      
      Change the row converter function signatures to be the same.  Call them via a function
      pointer during the encoding loop.  Minor webkit style cleanup, remove unused include.
      
      No new tests.  Covered by existing canvas 2d and 3d tests.
      canvas/philip/tests/toDataURL.jpeg.alpha.html
      fast/canvas/webgl/premultiplyalpha-test.html
      
      * platform/image-encoders/skia/JPEGImageEncoder.cpp:  Remove SkUnPreMultiply.h (not used).
      (WebCore::preMultipliedBGRAtoRGB):  Use unsigned char* instead of void* for pixels.
      (WebCore::RGBAtoRGB):  pixels & pixelCount to match the preMultipliedBGRAtoRGB() signature.
      (WebCore::encodePixels):  Move constants out of the encoding loop: use a function pointer
      to call preMultipliedBGRAtoRGB or RGBAtoRGB (now they have identical signatures), define
      and use pixelRowStride constant.
      (WebCore::JPEGImageEncoder::encode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db43ad15
    • commit-queue@webkit.org's avatar
      Allow MediaSource API to be enabled at runtime. · 7c3edf78
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67306
      
      Patch by Aaron Colwell <acolwell@chromium.org> on 2011-09-06
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      * bindings/generic/RuntimeEnabledFeatures.cpp:
      * bindings/generic/RuntimeEnabledFeatures.h:
      (WebCore::RuntimeEnabledFeatures::webkitMediaSourceEnabled):
      (WebCore::RuntimeEnabledFeatures::setWebkitMediaSourceEnabled):
      * html/HTMLMediaElement.idl:
      
      Source/WebKit/chromium:
      
      * public/WebRuntimeFeatures.h:
      * src/WebRuntimeFeatures.cpp:
      (WebKit::WebRuntimeFeatures::enableMediaSource):
      (WebKit::WebRuntimeFeatures::isMediaSourceEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c3edf78
    • reed@google.com's avatar
      [skia] never draw with GDI, so that all text can be gpu-accelerated · cb680b35
      reed@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65203
      
      Reviewed by Kenneth Russell.
      
      Source/WebCore:
      
      * platform/graphics/chromium/FontChromiumWin.cpp:
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
      (WebCore::drawGlyphsWin):
      (WebCore::Font::drawComplexText):
      * platform/graphics/chromium/UniscribeHelper.cpp:
      (WebCore::UniscribeHelper::draw):
      * platform/graphics/skia/PlatformContextSkia.cpp:
      * platform/graphics/skia/PlatformContextSkia.h:
      * platform/graphics/skia/SkiaFontWin.cpp:
      (WebCore::skiaDrawText):
      * platform/graphics/skia/SkiaFontWin.h:
      
      LayoutTests:
      
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb680b35
    • ossy@webkit.org's avatar
      [Qt][Symbian] REGRESSION[94105] DumpRenderTree.exe doesn't build on Symbian · 3874e3db
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67644
      
      Patch by Ademar de Souza Reis Jr. <ademar.reis@openbossa.org> on 2011-09-06
      Reviewed by Csaba Osztrogonác.
      
      * symbian/eabi/QtWebKitu.def: add missing entry for
      FrameLoaderClientQt::dumpProgressFinishedCallback(bool)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3874e3db
    • nduca@chromium.org's avatar
      [chromium] REGRESSION(94353): requestAnimationFrame not throttled in compositing path · 63eb66c5
      nduca@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67621
      
      CCSingleThreadProxy should not perform layout when called
      via the compositeImmediately path. Doing so makes it look
      like frame rate is unbounded.
      
      Reviewed by James Robinson.
      
      * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
      (WebCore::CCSingleThreadProxy::compositeAndReadback):
      (WebCore::CCSingleThreadProxy::compositeImmediately):
      (WebCore::CCSingleThreadProxy::commitIfNeeded):
      * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63eb66c5
    • rniwa@webkit.org's avatar
      REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on chromium · 73688cf4
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67453
      
      Reviewed by Kent Tamura.
      
      .: 
      
      Add symbols for internals.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: 
      
      Fixed the bug by updating inner text value in setSuggestedValue.
      
      Also added a suggestedValue and setSuggestedValue on window.internals for testing purposes.
      
      Test: fast/forms/suggested-value.html
      
      * WebCore.exp.in:
      * testing/Internals.cpp:
      (WebCore::Internals::suggestedValue):
      (WebCore::Internals::setSuggestedValue):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/chromium: 
      
      Chromium code incorrectly calls Node::isFocusable without updating layout, and was hitting assertions.
      Fix the assertion failure (and a potential crash) by updating layout in WebCore::isFocusable.
      
      * src/WebNode.cpp:
      (WebKit::WebNode::isFocusable):
      
      Source/WebKit2: 
      
      Add symbols for internals.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: 
      
      Added a regression test to ensure HTMLInputElement updates its inner text value when the suggested value is set.
      
      * fast/forms/suggested-value-expected.txt: Added.
      * fast/forms/suggested-value.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73688cf4
    • laszlo.1.gombos@nokia.com's avatar
      2011-09-06 Laszlo Gombos <laszlo.1.gombos@nokia.com> · c3b45ae6
      laszlo.1.gombos@nokia.com authored
              Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
              https://bugs.webkit.org/show_bug.cgi?id=66460
      
              Unreviewed, renaming tests in WK2 skiplists after r93312.
      
              * platform/win-wk2/Skipped:
              * platform/wk2/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3b45ae6
    • eric.carlson@apple.com's avatar
      load() does not reset the resource selection algorithm · d968500c
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64917
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Test: media/video-source-load.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::selectMediaResource): Reset m_nextChildNodeToConsider, update
          comments and rearrange logic to more closely match logic in spec.
      (WebCore::HTMLMediaElement::noneSupported): Update comments.
      
      LayoutTests: 
      
      * media/video-source-load-expected.txt: Added.
      * media/video-source-load.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d968500c
    • commit-queue@webkit.org's avatar
      [GTK] Use soup_session_add_feature_by_type uniformly in WebKit2. · 7c969d60
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67593
      
      Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-09-06
      Reviewed by Martin Robinson.
      
      Using soup_session_add_feature_by_type for adding all soup features
      instead of adding using GRefPtr.
      
      * WebProcess/gtk/WebProcessMainGtk.cpp:
      (WebKit::WebProcessMainGtk):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c969d60
    • inferno@chromium.org's avatar
      Style not propagated to anonymous boxes and anonymous · d0393f2c
      inferno@chromium.org authored
      inline-blocks.
      https://bugs.webkit.org/show_bug.cgi?id=67364
      
      Source/WebCore: 
      
      Reviewed by James Robinson.
      
      Share propagateStyleToAnonymousChildren with RenderBlock::styleDidChange.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::styleDidChange):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::propagateStyleToAnonymousChildren):
      * rendering/RenderObject.h:
      
      LayoutTests: 
      
      Add comments explaining what the test does.
      
      Reviewed by James Robinson.
      
      * fast/ruby/ruby-block-style-not-updated-with-before-after-content.html:
      * fast/ruby/ruby-block-style-not-updated.html:
      * fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html:
      * fast/ruby/ruby-inline-style-not-updated.html:
      * fast/table/table-before-child-style-update.html:
      * fast/table/table-row-before-child-style-update.html:
      * fast/table/table-row-style-not-updated-with-after-content.html:
      * fast/table/table-row-style-not-updated-with-before-content.html:
      * fast/table/table-style-not-updated.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0393f2c