1. 07 Jun, 2012 40 commits
    • zhajiang@rim.com's avatar
      [BlackBerry] Get rid of unused maximumLayoutSize in WebPage · 5a11df13
      zhajiang@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88574
      
      Reviewed by Rob Buis.
      Patch by Jacky Jiang <zhajiang@rim.com>
      
      PR: 164098
      maximumLayoutSize was deprecated when we made use of
      WebCore::computeViewportAttributes for
      WebPagePrivate::recomputeVirtualViewportFromViewportArguments.
      So clean it up.
      
      * Api/WebPage.cpp:
      (WebKit):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a11df13
    • ojan@chromium.org's avatar
      Chromium rebaselines after http://trac.webkit.org/changeset/119760. · 9afbac49
      ojan@chromium.org authored
      * platform/chromium-linux/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
      * platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png:
      * platform/chromium-win/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9afbac49
    • jamesr@google.com's avatar
      [chromium] Move deferral-related logic out of Canvas2DLayerChromium · 40846ff9
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=86050
      
      Reviewed by Stephen White.
      
      Source/WebCore:
      
      This removes Canvas2DLayerChromium and puts the deferral and double-buffering related logic in a new class,
      Canvas2DLayerBridge, that uses TextureLayerChromium for compositing.  The bridge is responsible for managing the
      front texture when double buffering is active, inserting the correct makeContextCurrent() and flush() calls on
      the GraphicsContext3D and SkCanvas when appropriate, and owning the lifetime of the layer.
      
      * WebCore.gypi:
      * platform/graphics/chromium/Canvas2DLayerBridge.cpp: Added.
      (WebCore):
      (AcceleratedDeviceContext):
      (WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
      (WebCore::AcceleratedDeviceContext::prepareForDraw):
      (WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
      (WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
      (WebCore::Canvas2DLayerBridge::skCanvas):
      (WebCore::Canvas2DLayerBridge::prepareTexture):
      (WebCore::Canvas2DLayerBridge::context):
      (WebCore::Canvas2DLayerBridge::layer):
      (WebCore::Canvas2DLayerBridge::contextAcquired):
      * platform/graphics/chromium/Canvas2DLayerBridge.h: Added.
      (WebCore):
      (Canvas2DLayerBridge):
      (WebCore::Canvas2DLayerBridge::create):
      * platform/graphics/chromium/Canvas2DLayerChromium.cpp: Removed.
      * platform/graphics/chromium/Canvas2DLayerChromium.h: Removed.
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      * platform/graphics/chromium/ImageBufferDataSkia.h:
      (WebCore):
      (ImageBufferData):
      * platform/graphics/chromium/TextureLayerChromium.cpp:
      (WebCore::TextureLayerChromium::willModifyTexture):
          willModifyTexture() is called whenever the texture currently owned by the TextureLayerChromium will be
          modified by a system out of the compositor's control. It makes sure that the compositor does not attempt to
          draw with the potentially-modified texture until the next commit. For canvas, this is used when threading is
          enabled and a non-deferrable drawing command is invoked from JS.
      (WebCore):
      * platform/graphics/chromium/TextureLayerChromium.h:
      (TextureLayerChromium):
      * platform/graphics/chromium/cc/CCTextureUpdater.cpp:
      (WebCore::CCTextureUpdater::hasMoreUpdates):
      (WebCore::CCTextureUpdater::update):
      (WebCore::CCTextureUpdater::clear):
      * platform/graphics/chromium/cc/CCTextureUpdater.h:
      (CCTextureUpdater):
      * platform/graphics/skia/ImageBufferSkia.cpp:
      (WebCore::createAcceleratedCanvas):
      (WebCore::ImageBuffer::~ImageBuffer):
      (WebCore::ImageBuffer::context):
      (WebCore::ImageBuffer::platformLayer):
      
      Source/WebKit/chromium:
      
      * WebKit.gypi:
      * tests/Canvas2DLayerBridgeTest.cpp: Renamed from tests/Canvas2DLayerChromiumTest
      (Canvas2DLayerBridgeTest):
      (Canvas2DLayerBridgeTest::fullLifecycleTest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40846ff9
    • paroga@webkit.org's avatar
      Unreviewed. Build fix for !ENABLE(JIT) after r119441. · a334f739
      paroga@webkit.org authored
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::privateExecute):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a334f739
    • paroga@webkit.org's avatar
      Build fix for WinCE after r113570. · 40935155
      paroga@webkit.org authored
      * Source/cmake/OptionsWinCE.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40935155
    • dpranke@chromium.org's avatar
      webkit-patch rebaseline-expectations should only rebaseline the appropriate... · 978bcd37
      dpranke@chromium.org authored
      webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
      https://bugs.webkit.org/show_bug.cgi?id=88581
      
      Reviewed by Ojan Vafai.
      
      webkit-paptch rebaseline-expectations was ignoring what the
      expected results for a test were and pulling down all the result
      files from a bot. This could lead to us pulling down old,
      incorrect .txt or .png files. With this patch we will now only
      pull down expectations of the appropriate file types (so an
      IMAGE failure will only pull the png and not the txt file).
      
      * Scripts/webkitpy/layout_tests/models/test_expectations.py:
      (has_pixel_failures):
      (suffixes_for_expectations):
      * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
      (FunctionsTest.test_suffixes_for_expectations):
      * Scripts/webkitpy/tool/commands/rebaseline.py:
      (AbstractRebaseliningCommand.__init__):
      (RebaselineExpectations._is_supported_port):
      (RebaselineExpectations._update_expectations_file):
      (RebaselineExpectations._tests_to_rebaseline):
      (RebaselineExpectations._rebaseline_port):
      * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
      (test_overrides_are_included_correctly):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      978bcd37
    • paroga@webkit.org's avatar
      Remove HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) · 52536671
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87931
      
      Reviewed by Beth Dakin.
      
      r62035 added HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) until all ports implement
      GraphicsContext::clipConvexPolygon(). All major ports define HAVE_PATH_BASED_BORDER_RADIUS_DRAWING in the
      meantime and the alternative path has unnecessary maintainace costs and even don't compile at the moment.
      
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::drawBoxSideFromPath):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::paintFocusRing):
      * rendering/RenderObject.h:
      (RenderObject):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52536671
    • tony@chromium.org's avatar
      [chromium] Unreviewed, new baselines for chromium-win after fixing · b46e3460
      tony@chromium.org authored
      scrollbar rendering in r119748.
      
      List of files omitted since it's long.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b46e3460
    • scheib@chromium.org's avatar
      Add new Pointer Lock spec events webkitpointerlockchange and webkitpointerlockerror · 13c96db0
      scheib@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88377
      
      Reviewed by Dimitri Glazkov.
      
      Part of a series of refactoring changes to update pointer lock API to
      the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
      
      New change and error events added. Follow up patches will remove
      the previous callbacks and pointerlocklost event. Tests updated
      to include the new events, and a new test added specifically for
      the new events, pointerlockchange-pointerlockerror-events.html.
      
      Source/WebCore:
      
      Test: pointer-lock/pointerlockchange-pointerlockerror-events.html
      
      * dom/Document.h:
      (Document):
      * dom/Document.idl:
      * dom/EventNames.h:
      (WebCore):
      * page/PointerLockController.cpp:
      (WebCore::PointerLockController::requestPointerLock):
      (WebCore::PointerLockController::didAcquirePointerLock):
      (WebCore::PointerLockController::didNotAcquirePointerLock):
      (WebCore::PointerLockController::didLosePointerLock):
      (WebCore::PointerLockController::enqueueEvent):
      (WebCore):
      * page/PointerLockController.h:
      (PointerLockController):
      
      LayoutTests:
      
      * pointer-lock/lock-already-locked-expected.txt:
      * pointer-lock/lock-already-locked.html:
      * pointer-lock/pointer-lock-api-expected.txt:
      * pointer-lock/pointer-lock-api.html:
      * pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt: Added.
      * pointer-lock/pointerlockchange-pointerlockerror-events.html: Added.
      * pointer-lock/pointerlocklost-event-expected.txt:
      * pointer-lock/pointerlocklost-event.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13c96db0
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r119744. · 2f94ec59
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/119744
      https://bugs.webkit.org/show_bug.cgi?id=88584
      
      Fails assertions in debug builds (Requested by jamesr_ on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07
      
      Source/WebCore:
      
      * platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
      (WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
      (WebCore::CCIOSurfaceLayerImpl::willDraw):
      
      Source/WebKit/chromium:
      
      * tests/CCLayerTreeHostImplTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f94ec59
    • jchaffraix@webkit.org's avatar
      Cache RenderLayer::isRootLayer for better performance · 3a4527f3
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88570
      
      Reviewed by Ojan Vafai.
      
      Caching covered by existing tests.
      
      RenderLayer::isRootLayer()'s answer will be the same during the RenderLayer's
      lifetime as a RenderLayer is tied to a RenderBoxModelObject. This change caches
      isRootLayer value in the constructor.
      
      On http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows
      by 100 columns table, it saves about 10% on the paint time during scrolling on
      my machine (going from 50ms to 45ms). It would expect all code paths to see some
      improvement as checking renderer()->isRenderView() was pretty common.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::RenderLayer):
      Added code to cache the result of renderer()->isRenderView() here.
      
      (WebCore::RenderLayer::stackingContext):
      (WebCore::isPositionedContainer):
      (WebCore::isFixedPositionedContainer):
      (WebCore::RenderLayer::enclosingTransformedAncestor):
      (WebCore::RenderLayer::clippingRootForPainting):
      (WebCore::shouldSuppressPaintingLayer):
      (WebCore::RenderLayer::hitTest):
      (WebCore::RenderLayer::intersectsDamageRect):
      * rendering/RenderLayer.h:
      (WebCore::RenderLayer::isStackingContext):
      Updated all the call sites to use isRootLayer() instead of renderer()->isRenderView()
      as it is faster.
      
      (WebCore::RenderLayer::isRootLayer):
      Added our caching here. Also made m_canSkipRepaintRectsUpdateOnScroll to follow
      m_isRootLayer example.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a4527f3
    • commit-queue@webkit.org's avatar
      Incorrect border rendering when border radius is above 2px. · 395e6ce5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88046
      
      Source/WebCore:
      
      Fixing findInnerVertex's logic to decide which is the better line
      to find an inner vertex, x=center point's x of a rendering box or
      y=center point's y of a rendering box.
      
      Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
      Reviewed by Simon Fraser.
      
      Test: fast/borders/border-radius-valid-border-clipping.html
      
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::findInnerVertex):
      
      LayoutTests:
      
      Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
      Reviewed by Simon Fraser.
      
      * fast/borders/border-radius-valid-border-clipping-expected.txt: Added.
      * fast/borders/border-radius-valid-border-clipping.html: Added.
      * platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      395e6ce5
    • commit-queue@webkit.org's avatar
      Source/WebCore: Should fire error event for empty 404 script · 4abf3bab
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=50589
      
      Patch by Edaena Salinas Jasso <edaena@apple.com> on 2012-06-07
      Reviewed by Brady Eidson.
      
      Tests:
      http/tests/loading/fire-error-event-empty-404-script.html
      http/tests/loading/fire-error-script-no-content-type.html
      
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::didReceiveResponse): We should check for http status
      codes here to stop depending on the response being non-empty.
      (WebCore::SubresourceLoader::didReceiveData): Moved the http status check but
      avoid messing with multipart responses.
      (WebCore::SubresourceLoader::checkForHTTPStatusCodeError): Renamed from
      errorLoadingResource for clarity.
      
      * loader/SubresourceLoader.h:
      * loader/cf/SubresourceLoaderCF.cpp:
      (WebCore::SubresourceLoader::didReceiveDataArray):
      Updated for errorLoadingResource renaming.
      
      LayoutTests: Should fire error event for empty 404 script
      https://bugs.webkit.org/show_bug.cgi?id=50589
      
      Patch by Edaena Salinas Jasso <edaena@apple.com> on 2012-06-07
      Reviewed by Brady Eidson.
      
      Based on a test by Ojan Vafai.
      
      * http/tests/loading/fire-error-event-empty-404-script-expected.txt: Added.
      * http/tests/loading/fire-error-event-empty-404-script.html: Added.
      * http/tests/loading/fire-error-event-script-no-content-type-expected.txt: Added.
      * http/tests/loading/fire-error-event-script-no-content-type.html: Added.
      * http/tests/loading/resources/404-with-empty-body-no-content-type.cgi: Added.
      * http/tests/loading/resources/404-with-empty-body.cgi: Added.
      * http/tests/resources/network-simulator.php: Fixed to no longer return 404 error
      when logging a request.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4abf3bab
    • andersca@apple.com's avatar
      Search highlight does not scroll with the content of the page, and find... · 5afd14f6
      andersca@apple.com authored
      Search highlight does not scroll with the content of the page, and find overlay doesn't work, on large-enough window
      https://bugs.webkit.org/show_bug.cgi?id=88577
      <rdar://problem/11430118>
      
      Reviewed by John Sullivan.
      
      Prevent the page overlay layer from falling into tiled mode.
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5afd14f6
    • zoltan@webkit.org's avatar
      [Qt] Qt DRT should load external resources - cleanup · 069a7288
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88568
      
      Make things more straighforward to load external URLs in DRT.
      
      Reviewed by Ryosuke Niwa.
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      069a7288
    • ojan@chromium.org's avatar
      fast/js/dfg-double-vote-fuzz.html fails on Chromium release. · cae4003c
      ojan@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cae4003c
    • commit-queue@webkit.org's avatar
      [BlackBerry] Update PlayBook's User Agent String for Web Inspector · 5c70039a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88543
      
      Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-07
      Reviewed by Antonio Gomes.
      
      We expect users to upgrade their devices so developers only need the latest UA String.
      
      No tests needed.
      
      * inspector/front-end/SettingsScreen.js:
      (WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c70039a
    • ojan@chromium.org's avatar
      Fix recent null pointer error regression in the flakiness dashboard · 3d2bb1e3
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88573
      
      Reviewed by Dirk Pranke.
      
      * TestResultServer/static-dashboards/builders.js:
      (requestBuilderList):
      * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d2bb1e3
    • shawnsingh@chromium.org's avatar
      [chromium] Remove obsolete FIXME comment about a layer sorting bug. · 694e4f3b
      shawnsingh@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88546
      
      Reviewed by James Robinson.
      
      No tests needed, only comment changed. The comment referred to a
      potential bug that actually will not occur. The W3C spec on CSS 3d
      transforms indicates that layers that do not share the same "3d
      rendering context" do not sort together, and our existing code
      sorts this way already.
      
      * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
      (WebCore::subtreeShouldRenderToSeparateSurface):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      694e4f3b
    • abarth@webkit.org's avatar
      Settings::defaultDeviceScaleFactor is redundant with Page::deviceScaleFactor · 9a476fa5
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88375
      
      Reviewed by James Robinson.
      
      .: 
      
      This symbol no longer exists.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: 
      
      This patch removes Settings::defaultDeviceScaleFactor because it is
      redundant with Page::deviceScaleFactor now that we no longer support
      target-densitydpi.  Page::deviceScaleFactor is the canonical place to
      store the device scale factor.
      
      * WebCore.exp.in:
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore):
      * page/Settings.h:
      (Settings):
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::setDeviceScaleFactor):
      
      Source/WebKit/chromium: 
      
      * public/WebSettings.h:
      (WebKit::WebSettings::setDefaultDeviceScaleFactor):
      (WebSettings):
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
      * src/WebSettingsImpl.cpp:
      (WebKit):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      * tests/WebFrameTest.cpp:
      (WebKit::TEST_F):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a476fa5
    • commit-queue@webkit.org's avatar
      IndexedDB: Error codes, phase one · f38860d6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88459
      
      Patch by Alec Flett <alecflett@chromium.org> on 2012-06-07
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      This phase gets rid of the now-deprecated NOT_ALLOWED_ERR and
      NON_TRANSIENT_ERR from earlier versions of the spec, and
      normalizes the place where TypeError should be thrown so that it's
      easier to update when the bindings change.
      
      No new tests: existing tests cover these changes and have been updated.
      
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::advance):
      (WebCore::IDBCursor::continueFunction):
      (WebCore::IDBCursor::stringToDirection):
      (WebCore::IDBCursor::directionToString):
      * Modules/indexeddb/IDBCursorBackendImpl.cpp:
      (WebCore::IDBCursorBackendImpl::update):
      (WebCore::IDBCursorBackendImpl::deleteFunction):
      * Modules/indexeddb/IDBDatabase.cpp:
      (WebCore::IDBDatabase::createObjectStore):
      (WebCore::IDBDatabase::deleteObjectStore):
      (WebCore::IDBDatabase::setVersion):
      (WebCore::IDBDatabase::transaction):
      * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
      (WebCore::IDBDatabaseBackendImpl::createObjectStore):
      (WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
      (WebCore::IDBDatabaseBackendImpl::setVersion):
      * Modules/indexeddb/IDBDatabaseException.cpp:
      (WebCore):
      * Modules/indexeddb/IDBDatabaseException.h:
      * Modules/indexeddb/IDBDatabaseException.idl:
      * Modules/indexeddb/IDBFactory.cpp:
      (WebCore::IDBFactory::open):
      (WebCore::IDBFactory::deleteDatabase):
      * Modules/indexeddb/IDBObjectStore.cpp:
      (WebCore::IDBObjectStore::index):
      * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
      (WebCore::IDBObjectStoreBackendImpl::createIndex):
      (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
      * Modules/indexeddb/IDBRequest.cpp:
      (WebCore::IDBRequest::result):
      (WebCore::IDBRequest::errorCode):
      (WebCore::IDBRequest::webkitErrorMessage):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::objectStore):
      (WebCore::IDBTransaction::stringToMode):
      (WebCore::IDBTransaction::modeToString):
      * Modules/indexeddb/IDBTransactionBackendImpl.cpp:
      (WebCore::IDBTransactionBackendImpl::objectStore):
      
      LayoutTests:
      
      * storage/indexeddb/basics-expected.txt:
      * storage/indexeddb/basics-shared-workers-expected.txt:
      * storage/indexeddb/basics-workers-expected.txt:
      * storage/indexeddb/create-and-remove-object-store-expected.txt:
      * storage/indexeddb/cursor-advance-expected.txt:
      * storage/indexeddb/cursor-update-expected.txt:
      * storage/indexeddb/database-basics-expected.txt:
      * storage/indexeddb/deleteIndex-expected.txt:
      * storage/indexeddb/resources/basics.js:
      (test):
      * storage/indexeddb/resources/create-and-remove-object-store.js:
      (testCreateAndRemove):
      (tryOnceMore):
      * storage/indexeddb/resources/cursor-advance.js:
      (testBadAdvance.advanceBadly):
      (testBadAdvance):
      * storage/indexeddb/resources/cursor-update.js:
      (keyCursor):
      * storage/indexeddb/resources/database-basics.js:
      (testClose):
      * storage/indexeddb/resources/deleteIndex.js:
      (postTwiddling):
      * storage/indexeddb/resources/transaction-after-close.js:
      (firstTransactionComplete):
      * storage/indexeddb/resources/transaction-and-objectstore-calls.js:
      (afterComplete):
      * storage/indexeddb/resources/transaction-basics.js:
      (testInvalidMode):
      * storage/indexeddb/transaction-after-close-expected.txt:
      * storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
      * storage/indexeddb/transaction-basics-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f38860d6
    • commit-queue@webkit.org's avatar
      Add Konrad Piascik to committers.py · f06b7b2f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88560
      
      Unreviewed.
      
      Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-07
      
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f06b7b2f
    • peter@chromium.org's avatar
      [Chromium] features.gypi should have the correct definitions for Android · 80a7cfff
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88533
      
      Reviewed by Adam Barth.
      
      Make all features which are enabled on Android but disabled on other platforms,
      or are disabled on Android while enabled on other platforms, conditional. This
      also means that the selection of code compiled for Android will slightly change.
      
      This change also removes the enable_viewport variable as the value of this is
      no longer respected by WebKit - it's enabled by default for all of Chromium.
      Furthermore, ENABLE_OVERFLOW_SCROLLING is now listed in features.gypi again.
      
      * features.gypi:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80a7cfff
    • tony@chromium.org's avatar
      [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom · 84093183
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77368
      
      Reviewed by Ojan Vafai.
      
      It doesn't look like we ever get a rect with width or height of 0.
      I ran css1, css2.1, fast/forms, and tables without any crashes.
      
      * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
      (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84093183
    • dpranke@chromium.org's avatar
      run-webkit-tests --lint-test-files gives an error when run on linux · 7c1872f3
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88551
      
      Reviewed by Ojan Vafai.
      
      We weren't mapping the expectations properly for the
      google-chrome ports.
      
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port.path_to_test_expectations_file):
      * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
      (TestGoogleChromePort.test_path_to_expectations):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c1872f3
    • epoger@chromium.org's avatar
      Unreviewed, rolling out r119737. · 00f8dc8c
      epoger@chromium.org authored
      http://trac.webkit.org/changeset/119737
      
      see https://bugs.webkit.org/show_bug.cgi?id=88561
      
      * css1/basic/class_as_selector-expected.txt: Removed.
      * css1/basic/containment-expected.txt: Removed.
      ...
      * platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt: Copied from LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt.
      * platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt: Copied from LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00f8dc8c
    • ojan@chromium.org's avatar
      Hopefully final chromium rebaseline for r119617. · 8b6f8ae2
      ojan@chromium.org authored
      * platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b6f8ae2
    • danakj@chromium.org's avatar
      [chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed · 76538c20
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88371
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Unit test: CCLayerTreeHostImplTest.layersFreeTextures
      
      * platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
      (WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
      (WebCore::CCIOSurfaceLayerImpl::willDraw):
      
      Source/WebKit/chromium:
      
      * tests/CCLayerTreeHostImplTest.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76538c20
    • peter@chromium.org's avatar
      Buildfix for ENABLE_OVERFLOW_SCROLLING=0 (though defined) · 6693a16c
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88564
      
      Reviewed by Adam Barth.
      
      Where ENABLE(X) mandates that X both has to be defined and evaluates to
      true as a lone preprocessor statement, there were two places in the CSS
      property and value input files where only was checked whether is has
      been defined. This also goes against other #ifdefs in those files.
      
      * css/CSSPropertyNames.in:
      * css/CSSValueKeywords.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6693a16c
    • fischman@chromium.org's avatar
      Plumb CORS attribute information from HTMLMediaElement to media players so it can be used · b148c1f6
      fischman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88349
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Test: http/tests/security/video-cross-origin-readback.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::mediaPlayerCORSMode):
      (WebCore):
      * html/HTMLMediaElement.h:
      (HTMLMediaElement):
      * html/canvas/CanvasRenderingContext.cpp:
      (WebCore::CanvasRenderingContext::wouldTaintOrigin):
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::didPassCORSAccessCheck):
      (WebCore):
      * platform/graphics/MediaPlayer.h:
      (WebCore::MediaPlayerClient::mediaPlayerCORSMode):
      (MediaPlayer):
      * platform/graphics/MediaPlayerPrivate.h:
      (WebCore::MediaPlayerPrivateInterface::didPassCORSAccessCheck):
      (MediaPlayerPrivateInterface):
      
      Source/WebKit/chromium:
      
      * public/WebMediaPlayer.h:
      (WebMediaPlayer):
      * src/AssertMatchingEnums.cpp:
      * src/WebMediaPlayerClientImpl.cpp:
      (WebKit::WebMediaPlayerClientImpl::loadInternal):
      (WebKit::WebMediaPlayerClientImpl::didPassCORSAccessCheck):
      (WebKit):
      * src/WebMediaPlayerClientImpl.h:
      (WebMediaPlayerClientImpl):
      
      LayoutTests:
      
      * http/tests/security/resources/video-cross-origin-allow.php: Added.
      * http/tests/security/video-cross-origin-readback-expected.txt: Added.
      * http/tests/security/video-cross-origin-readback.html: Added.
      * platform/efl/Skipped:
      * platform/gtk/TestExpectations:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      * platform/wk2/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b148c1f6
    • senorblanco@chromium.org's avatar
      Unreviewed; chromium test_expectations update. · 84e03163
      senorblanco@chromium.org authored
      Removing expected-to-fail results for now-passing tests.
      
      * platform/chromium-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Removed.
      * platform/chromium-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Removed.
      * platform/chromium-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Removed.
      * platform/chromium-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84e03163
    • mhahnenberg@apple.com's avatar
      Worker tear-down can re-enter JSC during GC finalization · 1bacff8f
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88449
      
      Reviewed by Geoffrey Garen.
      
      No new tests.
      
      This is the first of two patches to fix this issue with Workers.
      
      * workers/AbstractWorker.cpp:
      (WebCore::AbstractWorker::~AbstractWorker): We don't need to call onDestroyWorker() here, it
      will be called elsewhere in contextDestroyed().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bacff8f
    • jer.noble@apple.com's avatar
      sometimes all slaved videos don't start playing · 5022a398
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88553
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Test: media/media-controller-time-clamp.html
      
      Some PlatformClock classes will occasionally return times < 0 and will
      always return times slightly > duration() when playback has ended.  Clamp
      the value of currentTime() to the specified [0..duration] range.
      
      * html/MediaController.cpp:
      (MediaController::currentTime):
      
      LayoutTests:
      
      * media/media-controller-time-clamp-expected.txt: Added.
      * media/media-controller-time-clamp.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5022a398
    • ojan@chromium.org's avatar
      Mark another test as slow on Chromium Windows. · b4aadc06
      ojan@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4aadc06
    • epoger@chromium.org's avatar
      Part 1 of rebaselines for http://crbug.com/131189 · f464c58c
      epoger@chromium.org authored
      Unreviewed rebaselining.
      
      * css1/basic/class_as_selector-expected.txt: Added.
      * css1/basic/containment-expected.txt: Added.
      ...
      * platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt: Removed.
      * platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f464c58c
    • simon.fraser@apple.com's avatar
      Optimize FrameView::scrollXForFixedPosition() / scrollYForFixedPosition() · ece04673
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88475
      
      Reviewed by Sam Weinig.
      
      FrameView's scrollXForFixedPosition() and scrollYForFixedPosition()
      methods were often called together, but they do duplicate work,
      including calling into platform widget code which might be slow.
      
      Fix by converting scrollOffsetForFixedPosition() from being a wrapper
      that just calls scrollXForFixedPosition() and scrollYForFixedPosition()
      to the method that does all the work, calling just once into platform
      widget code.
      
      Changed callers to use scrollOffsetForFixedPosition() rather than make
      two separate method calls.
      
      Added ScrollView::layoutSize() and visibleSize() methods for
      convenience.
      
      Removed FrameView::scrollXForFixedPosition and FrameView::scrollYForFixedPosition
      to avoid inefficient callers in future.
      
      No new tests; refactoring only.
      
      * page/FrameView.cpp:
      (WebCore::fixedPositionScrollOffset):
      (WebCore::FrameView::scrollOffsetForFixedPosition):
      * page/FrameView.h: Removed scrollXForFixedPosition and scrollYForFixedPosition.
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::layoutSize):
      * platform/ScrollView.h:
      (WebCore::ScrollView::visibleSize):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::backgroundClipRect):
      * rendering/RenderLayer.h:
      (WebCore::ClipRect::move):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::requiresCompositingForPosition):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::computeRectForRepaint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ece04673
    • reed@google.com's avatar
      clean up suppressions around two-point-radial-gradient in skia (fix will come later) · a1cd1405
      reed@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88549
      
      Expectations change only.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1cd1405
    • ojan@chromium.org's avatar
      Update some flaky/slow expectations to better match the bots. · c7aa43cd
      ojan@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7aa43cd
    • commit-queue@webkit.org's avatar
      Incorrect rect-based hit-test result for culled-inline elements · db906cd7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85849
      
      Patch by Raymes Khoury <raymes@chromium.org> on 2012-06-07
      Reviewed by Levi Weintraub.
      
      Source/WebCore:
      
      Modified code which blindly adds culled inlines to rect-based hit-test
      results so that it only does so if the child node does not fully cover
      the hit-test region.
      
      Test: fast/dom/nodesFromRect-culled-inline.html
      
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::addNodeToRectBasedTestResult):
      
      LayoutTests:
      
      Added tests for rect-based hit-testing for the case when the child of a
      culled inline element is in the hit-test result. One of these tests is
      expected to fail due to https://bugs.webkit.org/show_bug.cgi?id=88376.
      
      * fast/dom/nodesFromRect-culled-inline-expected.txt: Added.
      * fast/dom/nodesFromRect-culled-inline.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db906cd7
    • commit-queue@webkit.org's avatar
      Source/WebCore: Make Skia backend honor requests for subpixel-positioned text. · 92e137d0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88263
      
      Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
      Reviewed by Tony Chang.
      
      Add subpixel positioning field to FontRenderStyle and rename
      subpixel rendering field.
      
      Pass setting to SkPaint in FontPlatformDataHarfBuzz and remove
      round() call when computing glyph widths in SimpleFontDataSkia.
      
      Test: platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html
      
      * platform/graphics/blackberry/skia/PlatformSupport.cpp:
      (WebCore::setFontRenderStyleDefaults):
      (WebCore::PlatformSupport::getRenderStyleForStrike):
      * platform/graphics/chromium/FontRenderStyle.h:
      (WebCore::FontRenderStyle::FontRenderStyle):
      (WebCore::FontRenderStyle::operator==):
      (FontRenderStyle):
      * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
      (WebCore):
      (WebCore::FontPlatformData::setSubpixelRendering):
      (WebCore::FontPlatformData::setSubpixelPositioning):
      (WebCore::FontPlatformData::setupPaint):
      (WebCore::FontPlatformData::querySystemForRenderStyle):
      * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
      (FontPlatformData):
      * platform/graphics/skia/SimpleFontDataSkia.cpp:
      (WebCore::SimpleFontData::platformWidthForGlyph):
      
      Source/WebKit/chromium: Add setting to enable subpixel-positioned text on Linux.
      https://bugs.webkit.org/show_bug.cgi?id=88263
      
      Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
      Reviewed by Tony Chang.
      
      Add subpixel positioning field to WebFontRenderStyle and rename
      subpixel rendering field.  Make similar changes in
      WebFontRendering.
      
      Also add global WebFontInfo::setSubpixelPositioning() to turn
      subpixel positioning on or off (there's not currently a
      well-defined way to configure subpixel positioning via FontConfig).
      
      * public/linux/WebFontInfo.h:
      (WebFontInfo):
      * public/linux/WebFontRenderStyle.h:
      * public/linux/WebFontRendering.h:
      (WebFontRendering):
      * src/linux/WebFontInfo.cpp:
      (WebKit):
      (WebKit::WebFontInfo::setSubpixelPositioning):
      (WebKit::WebFontInfo::renderStyleForStrike):
      * src/linux/WebFontRenderStyle.cpp:
      (WebKit::WebFontRenderStyle::toFontRenderStyle):
      (WebKit::WebFontRenderStyle::setDefaults):
      * src/linux/WebFontRendering.cpp:
      (WebKit::WebFontRendering::setSubpixelGlyphs):
      (WebKit):
      (WebKit::WebFontRendering::setSubpixelRendering):
      (WebKit::WebFontRendering::setSubpixelPositioning):
      
      Tools: [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
      https://bugs.webkit.org/show_bug.cgi?id=88263
      
      Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
      Reviewed by Tony Chang.
      
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (LayoutTestController::LayoutTestController):
      (LayoutTestController::reset):
      (LayoutTestController::setTextSubpixelPositioning):
      * DumpRenderTree/chromium/LayoutTestController.h:
      (LayoutTestController):
      * DumpRenderTree/chromium/fonts.conf:
      
      LayoutTests: [chromium] Add test for subpixel positioning.
      https://bugs.webkit.org/show_bug.cgi?id=88263
      
      Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
      Reviewed by Tony Chang.
      
      * platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning-expected.png: Added.
      * platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning-expected.txt: Added.
      * platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92e137d0