1. 14 Apr, 2013 1 commit
    • akling@apple.com's avatar
      Move create() methods from StylePropertySet to MutableStylePropertySet. · 1290708b
      akling@apple.com authored
      <http://webkit.org/b/114574>
      
      Reviewed by Antti Koivisto.
      
      Move the two create() methods that create MutableStylePropertySets from StylePropertySet
      to MutableStylePropertySet, and make them actually return MutableStylePropertySets.
      Switch to using {Pass,}RefPtr<MutableStylePropertySet> where appropriate to keep things building.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFontFaceValue):
      * css/DOMWindowCSS.cpp:
      (WebCore::DOMWindowCSS::supports):
      * css/ElementRuleCollector.cpp:
      (WebCore::leftToRightDeclaration):
      (WebCore::rightToLeftDeclaration):
      * css/FontLoader.cpp:
      (WebCore::FontLoader::resolveFontStyle):
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::copyPropertiesInSet):
      (WebCore::MutableStylePropertySet::create):
      * css/StylePropertySet.h:
      (StylePropertySet):
      (MutableStylePropertySet):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::resolveVariables):
      * css/WebKitCSSMatrix.cpp:
      (WebCore::WebKitCSSMatrix::setMatrixValue):
      * dom/Attr.cpp:
      (WebCore::Attr::style):
      * dom/Document.cpp:
      (WebCore::Document::createCSSStyleDeclaration):
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::ensureMutableInlineStyle):
      (WebCore::StyledElement::rebuildPresentationAttributeStyle):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::copyStyleOrCreateEmpty):
      * editing/EditingStyle.cpp:
      (WebCore::editingStyleFromComputedStyle):
      (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
      (WebCore::EditingStyle::setProperty):
      (WebCore::EditingStyle::extractAndRemoveTextDirection):
      (WebCore::styleFromMatchedRulesForElement):
      (WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
      (WebCore::EditingStyle::forceInline):
      * editing/Editor.cpp:
      (WebCore::Editor::setBaseWritingDirection):
      * editing/EditorCommand.cpp:
      (WebCore::executeApplyStyle):
      (WebCore::executeToggleStyleInList):
      (WebCore::executeApplyParagraphStyle):
      (WebCore::executeMakeTextWritingDirectionLeftToRight):
      (WebCore::executeMakeTextWritingDirectionNatural):
      (WebCore::executeMakeTextWritingDirectionRightToLeft):
      * html/HTMLTableElement.cpp:
      (WebCore::leakBorderStyle):
      (WebCore::HTMLTableElement::createSharedCellStyle):
      (WebCore::leakGroupBorderStyle):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::setFont):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyle::setPropertyText):
      (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
      * page/DragController.cpp:
      (WebCore::DragController::concludeEditDrag):
      * svg/SVGElementRareData.h:
      (WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
      * svg/SVGFontFaceElement.cpp:
      (WebCore::SVGFontFaceElement::SVGFontFaceElement):
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::getPresentationAttribute):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1290708b
  2. 08 Apr, 2013 2 commits
    • abecsi@webkit.org's avatar
      Fix the build with strict GCC 4.8 · a42ddd32
      abecsi@webkit.org authored
      Unreviewed build fix.
      
      Initialize dragImage to suppress GCC's warning about it being possibly used uninitialized,
      which results is a build failure with GCC 4.8 that sets -Werror=maybe-uninitialized.
      
      No new tests needed.
      
      * page/DragController.cpp:
      (WebCore::DragController::doImageDrag):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a42ddd32
    • carlosgc@webkit.org's avatar
      DragImage should not depend on Frame and CachedImage · baf91e99
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=21357
      
      Reviewed by Sam Weinig.
      
      Remove Frame and CachedImage dependencies from DragImage.
      
      * dom/Clipboard.h:
      (WebCore): Add forward delcaration for CacheImage since it's not
      included anymore in DragImage.h.
      * page/DragController.cpp:
      (WebCore::DragController::startDrag): Use
      Frame::dragImageForSelection() and call
      dissolveDragImageToFraction() for the returned DragImage. Pass the
      font rendering mode to createDragImageForLink, instead of a Frame
      that is only used to get the font rendering mode.
      (WebCore::DragController::doImageDrag): Get the suggested filename
      for the cached image and pass it to
      createDragImageIconForCachedImageFilename().
      * platform/DragImage.cpp:
      (WebCore::createDragImageForLink): Receive a FontRenderingMode
      instead of a Frame.
      * platform/DragImage.h:
      (WebCore): Remove createDragImageForSelection, change
      createDragImageForLink to receive a FontRenderingMode instead of a
      frame, and rename createDragImageIconForCachedImage as
      createDragImageIconForCachedImageFilename since it nows received
      the suggested filename of the cached image.
      * platform/blackberry/DragImageBlackBerry.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Adapt to API
      changes.
      * platform/efl/DragImageEfl.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Ditto.
      * platform/gtk/DragImageGtk.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Ditto.
      * platform/mac/DragImageMac.mm:
      (WebCore::dissolveDragImageToFraction): Return early if the passed
      image is NULL.
      (WebCore::createDragImageIconForCachedImageFilename): Adapt to API
      changes.
      (WebCore::createDragImageForLink): Ditto.
      * platform/qt/DragImageQt.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Ditto.
      * platform/win/DragImageWin.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Ditto.
      (WebCore::createDragImageForLink): Ditto.
      * platform/wx/DragImageWx.cpp:
      (WebCore::createDragImageIconForCachedImageFilename): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baf91e99
  3. 28 Mar, 2013 1 commit
    • falken@chromium.org's avatar
      Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl · 2113254c
      falken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113273
      
      Reviewed by Kent Tamura.
      
      Element::disabled is about form controls and Element::isEnabledFormControl
      is redundant with it, so replace them with a single function
      Element::isDisabledFormControl.
      
      Source/WebCore:
      
      No new tests, there should be no behavior change.
      
      * accessibility/AccessibilityListBox.cpp:
      (WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
      * accessibility/AccessibilityMenuList.cpp:
      (WebCore::AccessibilityMenuList::canSetFocusAttribute):
      * accessibility/AccessibilityMenuListOption.cpp:
      (WebCore::AccessibilityMenuListOption::isEnabled):
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::isEnabled):
      (WebCore::AccessibilityNodeObject::actionElement):
      (WebCore::AccessibilityNodeObject::canSetFocusAttribute):
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOne):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::canShareStyleWithControl):
      * dom/Element.cpp:
      (WebCore::Element::isDisabledFormControl):
      * dom/Element.h:
      (Element):
      (WebCore::isDisabledFormControl): Add helper function for convenience.
      (WebCore):
      * dom/EventDispatcher.cpp:
      (WebCore::EventDispatcher::dispatchSimulatedClick):
      * dom/GestureEvent.cpp:
      (WebCore::GestureEventDispatchMediator::dispatchEvent):
      * dom/MouseEvent.cpp:
      (WebCore::MouseEventDispatchMediator::dispatchEvent):
      * dom/Node.cpp:
      (WebCore::Node::handleLocalEvents):
      (WebCore::Node::willRespondToMouseMoveEvents):
      (WebCore::Node::willRespondToMouseClickEvents):
      (WebCore::Node::willRespondToTouchEvents):
      * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):
      * html/DOMFormData.cpp:
      (WebCore::DOMFormData::DOMFormData):
      * html/FileInputType.cpp:
      (WebCore::FileInputType::handleDOMActivateEvent):
      (WebCore::FileInputType::disabledAttributeChanged):
      * html/HTMLButtonElement.cpp:
      (WebCore::HTMLButtonElement::defaultEventHandler):
      (WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
      (WebCore::HTMLButtonElement::isSuccessfulSubmitButton):
      * html/HTMLCollection.cpp:
      (WebCore::isMatchingElement):
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::updateAncestorDisabledState):
      (WebCore::HTMLFormControlElement::isDisabledFormControl):
      (WebCore::HTMLFormControlElement::supportsFocus):
      * html/HTMLFormControlElement.h:
      (HTMLFormControlElement):
      (WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::isSuccessfulSubmitButton):
      (WebCore::HTMLInputElement::willRespondToMouseClickEvents):
      * html/HTMLOptGroupElement.cpp:
      (WebCore::HTMLOptGroupElement::isDisabledFormControl):
      * html/HTMLOptGroupElement.h:
      (HTMLOptGroupElement):
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::isDisabledFormControl):
      * html/HTMLOptionElement.h:
      (HTMLOptionElement):
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::nextValidIndex):
      (WebCore::HTMLSelectElement::updateListBoxSelection):
      (WebCore::HTMLSelectElement::recalcListItems):
      (WebCore::HTMLSelectElement::appendFormData):
      (WebCore::HTMLSelectElement::updateSelectedState):
      (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
      (WebCore::HTMLSelectElement::defaultEventHandler):
      (WebCore::HTMLSelectElement::optionAtIndex):
      * html/ImageInputType.cpp:
      (WebCore::ImageInputType::handleDOMActivateEvent):
      * html/ResetInputType.cpp:
      (WebCore::ResetInputType::handleDOMActivateEvent):
      * html/SubmitInputType.cpp:
      (WebCore::SubmitInputType::handleDOMActivateEvent):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::isDisabledFormControl):
      (WebCore::SliderThumbElement::defaultEventHandler):
      (WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
      (WebCore::SliderThumbElement::willRespondToMouseClickEvents):
      * html/shadow/SliderThumbElement.h:
      (SliderThumbElement):
      * html/shadow/SpinButtonElement.h:
      * html/shadow/TextFieldDecorationElement.cpp:
      (WebCore::TextFieldDecorationElement::updateImage):
      * loader/FormSubmission.cpp:
      (WebCore::FormSubmission::create):
      * page/DragController.cpp:
      (WebCore::DragController::tryDocumentDrag):
      (WebCore::DragController::concludeEditDrag):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::addFocusRingRects):
      (WebCore::RenderListBox::paintItemForeground):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemIsEnabled):
      * rendering/RenderTextControl.cpp:
      (WebCore::updateUserModifyProperty):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::isEnabled):
      * rendering/RenderThemeMac.mm:
      (WebCore::getMediaUIPartStateFlags):
      * rendering/RenderThemeMacShared.mm:
      (WebCore::RenderThemeMacShared::adjustMenuListStyle):
      (WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):
      * rendering/RenderThemeSafari.cpp:
      (WebCore::RenderThemeSafari::adjustMenuListStyle):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/CredentialTransformData.cpp:
      (WebCore::CredentialTransformData::findPasswordFormFields):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::openSelectPopup):
      
      Source/WebKit/chromium:
      
      * src/WebFormControlElement.cpp:
      (WebKit::WebFormControlElement::isEnabled):
      * src/WebOptionElement.cpp:
      (WebKit::WebOptionElement::isEnabled):
      * src/WebPasswordFormUtils.cpp:
      (WebKit::findPasswordFormFields):
      * src/WebSearchableFormData.cpp:
      (HTMLNames::findSuitableSearchInputElement):
      (HTMLNames::buildSearchString):
      
      Source/WebKit/win:
      
      * DOMHTMLClasses.cpp:
      (DOMHTMLInputElement::disabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2113254c
  4. 26 Mar, 2013 1 commit
    • hayato@chromium.org's avatar
      Allow ShadowContents in HitTests by default. · af1544e8
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113171
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      HitTestRequest is widely used in WebCore, but AllowShadowContents
      flag is not turned on by default.  In most places, we can set the
      flag on.
      
      This change makes HitTests allow shadow contents by default.
      
      To track all existing HitTests which do not allow shadow contents,
      and discourage such a HitTest in the future, I've introduced
      disallowShadowContenet flag so that callers must turn on this flag
      explicitly if they want to disallow shadow contents in their HitTests.
      
      This change should be refactoring and should not include any
      behavior changes.  After this change, we'll investigate each place
      where disallowShadowContents is used step by step and get rid of
      the flag if it is okay to remove.
      
      No new tests, no behavior change.
      
      * dom/Document.h:
      (Document):
      * dom/TreeScope.cpp:
      (WebCore::nodeFromPoint):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::contains):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      (WebCore::DragController::canProcessDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMouseDraggedEvent):
      (WebCore::EventHandler::eventMayStartDrag):
      (WebCore::EventHandler::updateSelectionForMouseDrag):
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleMouseDoubleClickEvent):
      (WebCore::EventHandler::handleMouseMoveEvent):
      (WebCore::EventHandler::handleMouseReleaseEvent):
      (WebCore::EventHandler::updateDragAndDrop):
      (WebCore::EventHandler::isInsideScrollbar):
      (WebCore::EventHandler::handleWheelEvent):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::handleGestureLongPress):
      (WebCore::EventHandler::handleGestureScrollBegin):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::sendContextMenuEventForKey):
      (WebCore::EventHandler::hoverTimerFired):
      (WebCore::EventHandler::dragSourceEndedAt):
      (WebCore::EventHandler::handleDrag):
      (WebCore::EventHandler::handleTouchEvent):
      (WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
      * page/EventHandler.h:
      (EventHandler):
      * page/FocusController.cpp:
      (WebCore::updateFocusCandidateIfNeeded):
      * page/Frame.cpp:
      (WebCore::Frame::visiblePositionForPoint):
      * page/TouchDisambiguation.cpp:
      (WebCore::findGoodTouchTargets):
      * rendering/HitTestRequest.h:
      (WebCore::HitTestRequest::disallowsShadowContent):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::addNodeToRectBasedTestResult):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
      * rendering/svg/RenderSVGResourceClipper.cpp:
      (WebCore::RenderSVGResourceClipper::hitTestClipContent):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getNodesFromRect):
      * WebKitSupport/ProximityDetector.cpp:
      (BlackBerry::WebKit::ProximityDetector::findBestPoint):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
      
      Source/WebKit/chromium:
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::visiblePositionForWindowPoint):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::isRectTopmost):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::computeBlockBounds):
      (WebKit::WebViewImpl::bestTapNode):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_hit_test_new):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebinspector.cpp:
      (webkit_web_inspector_inspect_coordinates):
      * webkit/webkitwebview.cpp:
      (prepareMouseEventForFrame):
      (webkit_web_view_get_hit_test_result):
      
      Source/WebKit/mac:
      
      * WebView/WebFrame.mm:
      (-[WebFrame elementAtPoint:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView elementAtPoint:allowShadowContent:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::hitTestContent):
      
      Source/WebKit/win:
      
      * WebView.cpp:
      (WebView::gestureNotify):
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::hitTest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::highlightPotentialActivation):
      (WebKit::WebPage::findZoomableAreaForPoint):
      (WebKit::WebPage::determinePrimarySnapshottedPlugIn):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::shouldDelayWindowOrderingEvent):
      (WebKit::WebPage::acceptsFirstMouse):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af1544e8
  5. 25 Mar, 2013 1 commit
    • tony@chromium.org's avatar
      Image alt text not included in plain-text version when copying · f2ff2775
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=11200
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Add a setting to enable copying image alt text to the clipboard and drag and drop pasteboard.
      This setting is disabled by default, so each port can enable if they want to match IE10 and
      Firefox's behavior.
      
      Test: editing/pasteboard/copy-image-with-alt-text.html
      
      * editing/Editor.cpp:
      (WebCore::Editor::cut): Explicitly ask that the selection on the pasteboard as being for the clipboard.
      (WebCore::Editor::copy): Explicitly ask that the selection on the pasteboard as being for the clipboard.
      (WebCore::Editor::selectedText): Add a private version of selectedText() that can choose between having image alt text or not.
      (WebCore::Editor::selectedTextForClipboard): Ask for image alt text if the setting is enabled.
      * editing/Editor.h:
      * editing/TextIterator.cpp:
      (WebCore::TextIterator::TextIterator): Add a bool to keep track of whether or not to emit image alt text.
      (WebCore::TextIterator::handleReplacedElement): If there's alt text, point the iterator to it.
      * editing/TextIterator.h:
      (TextIterator):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::takeFindStringFromSelection): Use the same text as on the clipboard.
      (WebCore::Editor::writeSelectionToPasteboard): Don't include image alt text since this is
      used by Services.
      (WebCore::Editor::stringSelectionForPasteboard): Don't include image alt text since this is
      used by Services.
      * page/DragController.cpp:
      (WebCore::DragController::startDrag): Use image alt text (matches Firefox).
      * page/Settings.in: Add a setting that disables image alt text by default.
      * platform/Pasteboard.h:
      * platform/blackberry/PasteboardBlackBerry.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::ClipboardChromium::writeRange): Use clipboard text when writing ranges (used by d&d).
      * platform/chromium/PasteboardChromium.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/efl/PasteboardEfl.cpp:
      (WebCore::Pasteboard::writeSelection): Update function param.
      * platform/gtk/ClipboardGtk.cpp:
      (WebCore::ClipboardGtk::writeRange): Use clipboard text when writing ranges (used by d&d).
      * platform/gtk/PasteboardGtk.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/mac/ClipboardMac.mm:
      (WebCore::ClipboardMac::writeRange): Use clipboard text when writing ranges (used by d&d).
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::getStringSelection): Use ShouldSerializeSelectedTextForClipboard to determine whether the selected
      text is for the clipboard or not.
      (WebCore::Pasteboard::writeSelectionForTypes): Pass ShouldSerializeSelectedTextForClipboard through.
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/qt/ClipboardQt.cpp:
      (WebCore::ClipboardQt::writeRange): Use clipboard text when writing ranges (used by d&d).
      * platform/qt/PasteboardQt.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/win/ClipboardWin.cpp:
      (WebCore::ClipboardWin::writeRange): Use clipboard text when writing ranges (used by d&d).
      * platform/win/PasteboardWin.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/wince/PasteboardWinCE.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * platform/wx/PasteboardWx.cpp:
      (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
      * rendering/RenderImage.h:
      (WebCore::RenderImage::altText): Add a getter for the alt text.
      
      LayoutTests:
      
      * editing/pasteboard/copy-image-with-alt-text-expected.txt: Added.
      * editing/pasteboard/copy-image-with-alt-text.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2ff2775
  6. 14 Mar, 2013 1 commit
    • inferno@chromium.org's avatar
      Replace static_casts with to* helper functions. · 9aa9e8d7
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112296
      
      Reviewed by Kentaro Hara.
      
      to* helper functions are preferred over static_cast calls since they
      help to catch bad casts easily on the testing infrastructure.
      
      Source/WebCore:
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::nodeHasRole):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::hasAttribute):
      (WebCore::AccessibilityObject::getAttribute):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::anchorElement):
      (WebCore::AccessibilityRenderObject::helpText):
      (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
      (WebCore::AccessibilityRenderObject::titleUIElement):
      (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::accessKey):
      (WebCore::AccessibilityRenderObject::setElementAttributeValue):
      (WebCore::AccessibilityRenderObject::setValue):
      (WebCore::AccessibilityRenderObject::activeDescendant):
      (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
      (WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
      (WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
      (WebCore::AccessibilityRenderObject::setAccessibleName):
      (WebCore::AccessibilityRenderObject::stringRoleForMSAA):
      * bindings/gobject/WebKitDOMBinding.cpp:
      (WebKit::createWrapper):
      * bindings/js/JSClipboardCustom.cpp:
      (WebCore::JSClipboard::setDragImage):
      * bindings/js/JSElementCustom.cpp:
      (WebCore::toJSNewlyCreated):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::createWrapperInline):
      * bindings/v8/custom/V8ClipboardCustom.cpp:
      (WebCore::V8Clipboard::setDragImageMethodCustom):
      * bindings/v8/custom/V8ElementCustom.cpp:
      (WebCore::wrap):
      * bindings/v8/custom/V8NodeCustom.cpp:
      (WebCore::wrap):
      * dom/Document.cpp:
      (WebCore::Document::importNode):
      (WebCore::Document::recalcStyle):
      (WebCore::Document::setFocusedNode):
      (WebCore::Document::updateFocusAppearanceTimerFired):
      * dom/DocumentStyleSheetCollection.cpp:
      (WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
      * dom/Element.cpp:
      (WebCore::Element::offsetParent):
      (WebCore::Element::boundsInRootViewSpace):
      (WebCore::Element::getBoundingClientRect):
      (WebCore::Element::recalcStyle):
      (WebCore::Element::computeInheritedLanguage):
      (WebCore::Element::lastElementChild):
      * dom/LiveNodeList.cpp:
      (WebCore::LiveNodeList::namedItem):
      * dom/Node.cpp:
      (WebCore::Node::dumpStatistics):
      (WebCore::Node::normalize):
      (WebCore::Node::rootEditableElement):
      (WebCore::Node::isDefaultNamespace):
      (WebCore::Node::ancestorElement):
      (WebCore::appendAttributeDesc):
      * dom/Position.cpp:
      (WebCore::Position::element):
      * dom/Range.cpp:
      (WebCore::Range::getBorderAndTextQuads):
      * dom/SelectorQuery.cpp:
      (WebCore::SelectorDataList::queryFirst):
      (WebCore::SelectorDataList::execute):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::recalcStyle):
      * dom/StaticHashSetNodeList.cpp:
      (WebCore::StaticHashSetNodeList::namedItem):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
      (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
      (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
      (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
      * editing/Editor.cpp:
      (WebCore::Editor::applyEditingStyleToBodyElement):
      * editing/FrameSelection.cpp:
      (WebCore::removingNodeRemovesPosition):
      * editing/IndentOutdentCommand.cpp:
      (WebCore::IndentOutdentCommand::outdentParagraph):
      * editing/MarkupAccumulator.cpp:
      (WebCore::MarkupAccumulator::entityMaskForText):
      (WebCore::MarkupAccumulator::appendStartMarkup):
      (WebCore::MarkupAccumulator::appendEndMarkup):
      * editing/ModifySelectionListLevel.cpp:
      (WebCore::IncreaseSelectionListLevelCommand::doApply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::haveSameTagName):
      (WebCore::handleStyleSpansBeforeInsertion):
      (WebCore::ReplaceSelectionCommand::doApply):
      * editing/SplitTextNodeContainingElementCommand.cpp:
      (WebCore::SplitTextNodeContainingElementCommand::doApply):
      * editing/TextIterator.cpp:
      (WebCore::TextIterator::advance):
      * editing/htmlediting.cpp:
      (WebCore::unsplittableElementForPosition):
      (WebCore::enclosingTableCell):
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::wrapWithNode):
      (WebCore::createMarkupInternal):
      (WebCore::createFragmentFromMarkupWithContext):
      (WebCore::isPlainTextMarkup):
      (WebCore::createFragmentFromText):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::insertAdjacentElement):
      (WebCore::contextElementForInsertion):
      * html/HTMLFormControlElement.cpp:
      (WebCore::focusPostAttach):
      (WebCore::updateFromElementCallback):
      * html/HTMLFormElement.cpp:
      (WebCore::submitElementFromEvent):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::updateDocNamedItem):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::updateSnapshotInfo):
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::addRange):
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::closestFormAncestor):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::toParentMediaElement):
      * html/shadow/TextFieldDecorationElement.h:
      (WebCore::toTextFieldDecorationElement):
      * inspector/DOMPatchSupport.cpp:
      (WebCore::DOMPatchSupport::createDigest):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::buildObjectForNode):
      (WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::inlineStyleSheetText):
      * mathml/MathMLElement.h:
      (WebCore::toMathMLElement):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      (WebCore::DragController::startDrag):
      * page/FocusController.cpp:
      (WebCore::FocusController::advanceFocusInDocumentOrder):
      * page/Frame.cpp:
      (WebCore::Frame::searchForLabelsBeforeElement):
      * page/FrameView.cpp:
      (WebCore::FrameView::updateWidget):
      * page/SpatialNavigation.cpp:
      (WebCore::rectToAbsoluteCoordinates):
      * page/animation/ImplicitAnimation.cpp:
      (WebCore::ImplicitAnimation::sendTransitionEvent):
      * page/animation/KeyframeAnimation.cpp:
      (WebCore::KeyframeAnimation::KeyframeAnimation):
      (WebCore::KeyframeAnimation::sendAnimationEvent):
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
      (WebCore::RenderThemeEfl::paintMediaMuteButton):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::buildReferenceFilter):
      * rendering/svg/RenderSVGViewportContainer.cpp:
      (WebCore::RenderSVGViewportContainer::calcViewport):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::getElementById):
      * svg/SVGUseElement.cpp:
      (WebCore::isDisallowedElement):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::buildPendingResource):
      * xml/XPathStep.cpp:
      (WebCore::XPath::nodeMatchesBasicTest):
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::XMLDocumentParser):
      (WebCore::XMLDocumentParser::parseEndElement):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      (BlackBerry::WebKit::WebPage::setNodeFocus):
      (BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
      (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
      * WebKitSupport/BackingStoreClient.cpp:
      (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::toTextControlElement):
      (BlackBerry::WebKit::DOMSupport::selectionContainerElement):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
      (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
      (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::elementForTapHighlight):
      
      Source/WebKit/chromium:
      
      * src/WebDocument.cpp:
      (WebKit::WebDocument::images):
      * src/WebElement.cpp:
      (WebKit::WebElement::operator PassRefPtr<Element>):
      * src/WebPageSerializer.cpp:
      (WebCore::retrieveResourcesForFrame):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setFocus):
      (WebKit::WebViewImpl::clearFocusedNode):
      (WebKit::WebViewImpl::scrollFocusedNodeIntoView):
      (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebview.cpp:
      (webkit_web_view_query_tooltip):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (applyAppleDictionaryApplicationQuirkNonInlinePart):
      * WebView/WebHTMLRepresentation.mm:
      (searchForLabelsBeforeElement):
      
      Source/WebKit/qt:
      
      * Api/qwebelement.cpp:
      (QWebElement::firstChild):
      (QWebElement::lastChild):
      (QWebElement::nextSibling):
      (QWebElement::previousSibling):
      (QWebElementCollection::at):
      (QWebElementCollection::toList):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebHitTestResultPrivate::elementForInnerNode):
      
      Source/WebKit/win:
      
      * WebView.cpp:
      (WebView::enterFullscreenForNode):
      
      Source/WebKit2:
      
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::elementBounds):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::containsAnyFormElements):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aa9e8d7
  7. 13 Mar, 2013 1 commit
  8. 02 Mar, 2013 1 commit
    • darin@apple.com's avatar
      Cut down the number of source files that depend on Clipboard.h · 569b13f7
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=110030
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      I am doing some work on Clipboard and it's better to recompile 50 files
      each time we touch the header instead of 700. Also cut down on includes
      of DragState.h.
      
      * WebCore.exp.in: Updated for new MouseEvent::create function.
      
      * dom/ClipboardEvent.cpp: Added include of Clipboard.h since we use it
      here and the world no longer includes it everywhere.
      
      * dom/ClipboardEvent.h: Forward declared Clipboard instead of including
      Clipboard.h. Also made some overrides private because they can be.
      
      * dom/DataTransferItem.h: Removed unneeded include of Clipboard.h.
      
      * dom/MouseEvent.cpp: Added include of Clipboard.h since we use it
      here and the world no longer includes it everywhere.
      (WebCore::MouseEvent::create): Made the create function non-inline
      since we can't compile it without including Clipboard.h and we don't
      want to include Clipboard.h in the header. This is not so commonly
      used or so hot that this needs to be inlined.
      
      * dom/MouseEvent.h: Forward declared Clipboard instead of including
      Clipboard.h. Made MouseEvent::create a non-inline function and also
      used overloading instead of default arguments, since we can't compile
      a default argument of type PassRefPtr<Clipboard> without including
      Clipboard.h.
      
      * dom/WheelEvent.cpp: Added include of Clipboard.h since we use it
      here and the world no longer includes it everywhere.
      
      * dom/WheelEvent.h: Forward declare PlatformWheelEvent since it is used
      in this header. Previously we'd get it indirectly from including a header
      that included Clipboard.h.
      
      * editing/Editor.cpp: Added include of Clipboard.h since we use it here
      and the world no longer includes it everywhere.
      
      * inspector/InspectorDebuggerAgent.cpp: Added include of CachedResource.h.
      We used to get this indirectly through Clipboard.h.
      
      * inspector/InspectorFrontendHost.cpp: Added includes of ResourceError.h
      and ResourceResponse.h. We used to get these indirectly through Clipboard.h.
      Also removed unneeded include of <wtf/RefPtr.h>.
      
      * inspector/NetworkResourcesData.cpp: Added include of CachedResource.h.
      We used to get this indirectly through Clipboard.h.
      
      * loader/PingLoader.cpp: Added include of ResourceResponse.h.
      We used to get this indirectly through Clipboard.h.
      
      * page/DragController.cpp: Added include of DragState.h.
      We used to get this indirectly through EventHandler.h
      
      * page/EventHandler.h: Forward declared DragState and Element instead of
      including DragState.h. Also added an include of LayoutPoint.h, which we
      used to get indirectly through DragState.h.
      
      Source/WebKit/chromium:
      
      * src/SharedWorkerRepository.cpp: Add include of ResourceResponse.h
      here. We used to get this indirectly through Clipboard.h.
      
      Source/WebKit/mac:
      
      * WebView/WebPDFView.mm: Add include of Clipboard.h since we use it
      here and the world no longer includes it everywhere.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      569b13f7
  9. 01 Mar, 2013 3 commits
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · fc363ce1
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=111035
      
              Reviewed by Eric Seidel.
      
              This uses a number of common unsurprising techniques. One interesting observation
              is that including CachedResource related headers is very expensive. We can usually
              get away with their Client counterparts, and with CachedResourceHandle.
      
              * page/Frame.cpp:
              * page/Frame.h:
              Don't include FrameLoader, greatly reducing include graph for most non-loader files.
              This required making Frame::init() non-inline - I'm not sure why it ever was.
      
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              Even though FrameLoader is logically on loading side of WebCore, it's included in
              too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
              largest wins. As a future improvement, we should probably convert other members
              to OwnPtrs.
      
              * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
              definition of a class it holds, but default construction does not.
      
              * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
              not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
              * loader/cache/CachedFont.h:
              * loader/cache/CachedFontClient.h: Added.
              * loader/cache/CachedRawResource.h:
              * loader/cache/CachedRawResourceClient.h: Added.
              * loader/cache/CachedSVGDocument.h:
              * loader/cache/CachedSVGDocumentClient.h: Added.
              These types were defining client types in the same headers, making it impossible
              to avoid including networking headers through CachedResource. Moved clients into
              separate files.
      
              * plugins/PluginStream.h:
              * plugins/PluginStreamClient.h: Added.
              Similar situation here.
      
              * loader/cache/CachedResourceHandle.cpp:
              * loader/cache/CachedResourceHandle.h:
              Moved functions that need to know about CachedResource to .cpp file. This is another
              huge win. Added a destructor, so that CachedResource woudn't be needed in all files
              that include CachedResourceHandle.
      
              * loader/cache/CachedSVGDocumentReference.cpp: Added.
              * loader/cache/CachedSVGDocumentReference.h:
              Moved constructor and virtual function implementations to a .cpp file - they need
              not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
              * platform/graphics/filters/FilterOperation.cpp:
              * platform/graphics/filters/FilterOperation.h:
              Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
              CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
              rendering code that it seems best to cut any ties with resources and loading.
              Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
              classes are generally harmful (due to code bloat).
      
              * plugins/PluginRequest.h: Added.
              * plugins/PluginView.h:
              Moved PluginRequest into a separate file, it was out of place in a view hierarchy
              class file.
      
              * rendering/RenderImageResource.cpp:
              * rendering/RenderImageResource.h:
              Moved definitions of virtual functions to a .cpp file. Thre is no win from having
              them inline, and now we don't need CachedImage.h in the header.
      
              * rendering/style/StyleCustomFilterProgram.cpp: Added.
              * rendering/style/StyleCustomFilterProgram.h:
              Ditto.
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * Modules/mediastream/RTCPeerConnection.cpp:
              * Modules/notifications/Notification.cpp:
              * Target.pri:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/ScriptControllerBase.cpp:
              * bindings/js/JSNodeCustom.cpp:
              * bindings/js/ScriptController.cpp:
              * bindings/js/ScriptSourceCode.h:
              * bindings/objc/DOM.mm:
              * bindings/v8/ScriptController.cpp:
              * bindings/v8/V8DOMWindowShell.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * css/CSSFontFaceSource.h:
              * css/CSSFontSelector.cpp:
              * css/WebKitCSSSVGDocumentValue.cpp:
              * css/WebKitCSSSVGDocumentValue.h:
              * dom/Clipboard.cpp:
              * dom/ContainerNode.cpp:
              * dom/DOMImplementation.cpp:
              * dom/PendingScript.h:
              * dom/ScriptElement.cpp:
              * dom/ScriptElement.h:
              * history/CachedFrame.cpp:
              * html/DOMURL.cpp:
              * html/HTMLAnchorElement.cpp:
              * html/HTMLAppletElement.cpp:
              * html/HTMLElement.cpp:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLFrameSetElement.cpp:
              * html/HTMLHtmlElement.cpp:
              * html/HTMLImageElement.cpp:
              * html/HTMLObjectElement.cpp:
              * html/HTMLPlugInElement.cpp:
              * html/ImageDocument.cpp:
              * html/ImageInputType.cpp:
              * html/MediaDocument.cpp:
              * html/PluginDocument.cpp:
              * html/canvas/WebGLRenderingContext.cpp:
              * html/parser/HTMLConstructionSite.cpp:
              * html/parser/HTMLParserOptions.cpp:
              * html/parser/HTMLScriptRunner.h:
              * html/parser/XSSAuditor.cpp:
              * html/parser/XSSAuditorDelegate.cpp:
              * inspector/InspectorDebuggerAgent.cpp:
              * inspector/InspectorFileSystemAgent.cpp:
              * inspector/InspectorFrontendHost.cpp:
              * inspector/InspectorInstrumentation.h:
              * inspector/InspectorPageAgent.cpp:
              * inspector/NetworkResourcesData.cpp:
              * inspector/NetworkResourcesData.h:
              * loader/CookieJar.cpp:
              * loader/CrossOriginAccessControl.cpp:
              * loader/CrossOriginPreflightResultCache.h:
              * loader/DocumentThreadableLoader.h:
              * loader/ImageLoader.cpp:
              * loader/ImageLoader.h:
              * loader/LinkLoader.h:
              * loader/MainResourceLoader.cpp:
              * loader/MainResourceLoader.h:
              * loader/MixedContentChecker.cpp:
              * loader/PingLoader.cpp:
              * loader/PolicyChecker.h:
              * loader/ProgressTracker.cpp:
              * loader/SubframeLoader.cpp:
              * loader/SubresourceLoader.cpp:
              * loader/TextTrackLoader.cpp:
              * loader/TextTrackLoader.h:
              * loader/ThreadableLoader.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/appcache/ApplicationCacheHost.cpp:
              * loader/archive/cf/LegacyWebArchive.cpp:
              * loader/cache/CachedFont.cpp:
              * loader/cache/CachedImage.cpp:
              * loader/cache/CachedRawResource.cpp:
              * loader/cache/CachedResource.cpp:
              * loader/cache/CachedStyleSheetClient.h:
              * loader/cache/MemoryCache.cpp:
              * loader/cache/MemoryCache.h:
              * loader/chromium/CachedRawResourceChromium.cpp:
              * loader/icon/IconController.cpp:
              * loader/icon/IconLoader.h:
              * loader/mac/ResourceLoaderMac.mm:
              * page/DOMWindowExtension.cpp:
              * page/DragController.cpp:
              * page/PerformanceNavigation.cpp:
              * page/PerformanceTiming.cpp:
              * page/PointerLockController.cpp:
              * page/Settings.cpp:
              * page/animation/CSSPropertyAnimation.cpp:
              * platform/chromium/PasteboardChromium.cpp:
              * platform/efl/ErrorsEfl.cpp:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
              * platform/gtk/ErrorsGtk.cpp:
              * platform/gtk/PasteboardGtk.cpp:
              * platform/gtk/PasteboardHelper.h:
              * platform/mac/ClipboardMac.h:
              * platform/mac/ClipboardMac.mm:
              * platform/mac/HTMLConverter.mm:
              * platform/mac/PasteboardMac.mm:
              * platform/network/AuthenticationChallengeBase.cpp:
              * platform/network/cf/CookieJarCFNet.cpp:
              * platform/network/cf/ResourceRequestCFNet.cpp:
              * platform/network/mac/CookieStorageMac.mm:
              * platform/qt/PasteboardQt.cpp:
              * plugins/DOMMimeType.cpp:
              * plugins/PluginView.cpp:
              * rendering/HitTestResult.cpp:
              * rendering/InlineFlowBox.cpp:
              * rendering/RenderBox.cpp:
              * rendering/RenderEmbeddedObject.cpp:
              * rendering/RenderImage.cpp:
              * rendering/RenderImageResourceStyleImage.cpp:
              * rendering/RenderLayer.cpp:
              * rendering/RenderLayerBacking.cpp:
              * rendering/RenderLayerFilterInfo.h:
              * rendering/RenderListItem.cpp:
              * rendering/RenderListMarker.cpp:
              * rendering/RenderSnapshottedPlugIn.cpp:
              * rendering/RenderTableCol.cpp:
              * rendering/RenderTableRow.cpp:
              * rendering/RenderTableSection.cpp:
              * rendering/style/StyleCachedShader.h:
              * svg/SVGFEImageElement.h:
              * svg/SVGFontFaceUriElement.h:
              * svg/SVGImageLoader.cpp:
              * svg/SVGUseElement.cpp:
              * svg/SVGUseElement.h:
              * svg/graphics/SVGImageCache.cpp:
              * testing/MockPagePopupDriver.cpp:
              * xml/XSLStyleSheet.h:
              * xml/XSLTProcessorLibxslt.cpp:
              * xml/parser/XMLDocumentParser.cpp:
              * xml/parser/XMLDocumentParser.h:
              * xml/parser/XMLDocumentParserLibxml2.cpp:
              Many self-evident changes - removing unnecessary header includes, adding smaller
              more local ones that are now necessary.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc363ce1
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r144422 and r144424. · 0b87a6c7
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/144422
      http://trac.webkit.org/changeset/144424
      https://bugs.webkit.org/show_bug.cgi?id=111167
      
      Caused over 20 tests to fail assertion on Chromium Win port as
      ASSERTION FAILED: m_platformRequestUpdated (Requested by
      toyoshim on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSCrossfadeValue.h:
      (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
      (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      (WebCore):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::Clipboard):
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginAccessControl.h:
      (WebCore):
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      * loader/FrameLoader.h:
      (WebCore):
      (WebCore::FrameLoader::policyChecker):
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      (WebCore):
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      (WebCore):
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      (CachedFontClient):
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      (WebCore):
      * loader/cache/CachedFontClient.h: Removed.
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedRawResource.h:
      (WebCore):
      (CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::expectedType):
      (WebCore::CachedRawResourceClient::resourceClientType):
      (WebCore::CachedRawResourceClient::dataSent):
      (WebCore::CachedRawResourceClient::responseReceived):
      (WebCore::CachedRawResourceClient::dataReceived):
      (WebCore::CachedRawResourceClient::redirectReceived):
      (WebCore::CachedRawResourceClient::dataDownloaded):
      * loader/cache/CachedRawResourceClient.h: Removed.
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      * loader/cache/CachedSVGDocument.h:
      (CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      (WebCore):
      * loader/cache/CachedSVGDocumentClient.h: Removed.
      * loader/cache/CachedSVGDocumentReference.cpp: Removed.
      * loader/cache/CachedSVGDocumentReference.h:
      (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      (WebCore):
      (MemoryCache):
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::Frame):
      (WebCore::Frame::reportMemoryUsage):
      * page/Frame.h:
      (WebCore):
      (Frame):
      (WebCore::Frame::init):
      (WebCore::Frame::loader):
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
      (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginRequest.h: Removed.
      * plugins/PluginStream.h:
      (PluginStreamClient):
      (WebCore::PluginStreamClient::~PluginStreamClient):
      (WebCore::PluginStreamClient::streamDidFinishLoading):
      (WebCore):
      * plugins/PluginStreamClient.h: Removed.
      * plugins/PluginView.cpp:
      * plugins/PluginView.h:
      (WebCore):
      (PluginRequest):
      (WebCore::PluginRequest::PluginRequest):
      (WebCore::PluginRequest::frameLoadRequest):
      (WebCore::PluginRequest::notifyData):
      (WebCore::PluginRequest::sendNotification):
      (WebCore::PluginRequest::shouldAllowPopups):
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::RenderImageResource):
      * rendering/RenderImageResource.h:
      (WebCore::RenderImageResource::image):
      (WebCore::RenderImageResource::errorOccurred):
      (WebCore::RenderImageResource::usesImageContainerSize):
      (WebCore::RenderImageResource::imageHasRelativeWidth):
      (WebCore::RenderImageResource::imageHasRelativeHeight):
      (WebCore::RenderImageResource::imageSize):
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * rendering/style/StyleCustomFilterProgram.cpp: Removed.
      * rendering/style/StyleCustomFilterProgram.h:
      (WebCore):
      (WebCore::StyleCustomFilterProgram::vertexShaderString):
      (StyleCustomFilterProgram):
      (WebCore::StyleCustomFilterProgram::fragmentShaderString):
      (WebCore::StyleCustomFilterProgram::isLoaded):
      (WebCore::StyleCustomFilterProgram::willHaveClients):
      (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
      (WebCore::StyleCustomFilterProgram::notifyFinished):
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      (SVGFontFaceUriElement):
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      
      Source/WebKit/chromium:
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      (WebCore):
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b87a6c7
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · b2f13721
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111035
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      This uses a number of common unsurprising techniques. One interesting observation
      is that including CachedResource related headers is very expensive. We can usually
      get away with their Client counterparts, and with CachedResourceHandle.
      
      * page/Frame.cpp:
      * page/Frame.h:
      Don't include FrameLoader, greatly reducing include graph for most non-loader files.
      This required making Frame::init() non-inline - I'm not sure why it ever was.
      
      * loader/FrameLoader.cpp:
      * loader/FrameLoader.h:
      Even though FrameLoader is logically on loading side of WebCore, it's included in
      too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
      largest wins. As a future improvement, we should probably convert other members
      to OwnPtrs.
      
      * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
      definition of a class it holds, but default construction does not.
      
      * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
      not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
      * loader/cache/CachedFont.h:
      * loader/cache/CachedFontClient.h: Added.
      * loader/cache/CachedRawResource.h:
      * loader/cache/CachedRawResourceClient.h: Added.
      * loader/cache/CachedSVGDocument.h:
      * loader/cache/CachedSVGDocumentClient.h: Added.
      These types were defining client types in the same headers, making it impossible
      to avoid including networking headers through CachedResource. Moved clients into
      separate files.
      
      * plugins/PluginStream.h:
      * plugins/PluginStreamClient.h: Added.
      Similar situation here.
      
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      Moved functions that need to know about CachedResource to .cpp file. This is another
      huge win. Added a destructor, so that CachedResource woudn't be needed in all files
      that include CachedResourceHandle.
      
      * loader/cache/CachedSVGDocumentReference.cpp: Added.
      * loader/cache/CachedSVGDocumentReference.h:
      Moved constructor and virtual function implementations to a .cpp file - they need
      not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
      CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
      rendering code that it seems best to cut any ties with resources and loading.
      Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
      classes are generally harmful (due to code bloat).
      
      * plugins/PluginRequest.h: Added.
      * plugins/PluginView.h:
      Moved PluginRequest into a separate file, it was out of place in a view hierarchy
      class file.
      
      * rendering/RenderImageResource.cpp:
      * rendering/RenderImageResource.h:
      Moved definitions of virtual functions to a .cpp file. Thre is no win from having
      them inline, and now we don't need CachedImage.h in the header.
      
      * rendering/style/StyleCustomFilterProgram.cpp: Added.
      * rendering/style/StyleCustomFilterProgram.h:
      Ditto.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      * dom/Clipboard.cpp:
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginView.cpp:
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      Many self-evident changes - removing unnecessary header includes, adding smaller
      more local ones that are now necessary.
      
      Source/WebKit/chromium:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2f13721
  10. 15 Feb, 2013 1 commit
    • allan.jensen@digia.com's avatar
      Simplify hitTestResultAtPoint and nodesFromRect APIs · eb0e1f9f
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95720
      
      .:
      
      Reviewed by Julien Chaffraix.
      
      Update exported symbols.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Reviewed by Julien Chaffraix.
      
      The existing API was overloaded and could be simplified by passing all the bool arguments in
      a HitTestRequest argument. This should also help clarify the call as the enum values explicitely
      state what they do.
      
      * WebCore.exp.in:
      * WebCore.order:
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      * dom/Document.h:
      (Document):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::createContextMenu):
      * page/DragController.cpp:
      (WebCore::DragController::canProcessDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
      (WebCore::EventHandler::handleTouchEvent):
      * page/EventHandler.h:
      (WebCore):
      (EventHandler):
      * page/FocusController.cpp:
      (WebCore::updateFocusCandidateIfNeeded):
      * page/Frame.cpp:
      (WebCore::Frame::visiblePositionForPoint):
      (WebCore::Frame::documentAtPoint):
      * page/TouchDisambiguation.cpp:
      (WebCore::findGoodTouchTargets):
      * rendering/HitTestRequest.h:
      (WebCore::HitTestRequest::allowsFrameScrollbars):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      
      Source/WebKit/blackberry:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::contextNode):
      (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      (BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
      (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
      
      Source/WebKit/chromium:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::characterIndexForPoint):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::isRectTopmost):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleMouseDown):
      (WebKit::WebViewImpl::computeBlockBounds):
      (WebKit::WebViewImpl::bestTouchLinkNode):
      (WebKit::WebViewImpl::hitTestResultForWindowPos):
      
      Source/WebKit/efl:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_hit_test_new):
      
      Source/WebKit/mac:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::actionDictionary):
      * WebView/WebFrame.mm:
      (-[WebFrame elementAtPoint:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView elementAtPoint:allowShadowContent:]):
      
      Source/WebKit/qt:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::hitTestContent):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::TouchAdjuster::findCandidatePointForTouch):
      (QWebPageAdapter::handleSoftwareInputPanel):
      (QWebPageAdapter::updatePositionDependentMenuActions):
      
      Source/WebKit/win:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebActionPropertyBag.cpp:
      (WebActionPropertyBag::Read):
      * WebKit.vcproj/WebKitExports.def.in:
      * WebView.cpp:
      (WebView::handleContextMenuEvent):
      (WebView::elementAtPoint):
      
      Source/WebKit/wx:
      
      Reviewed by Julien Chaffraix.
      
      Update calls to new API.
      
      * WebFrame.cpp:
      (WebKit::WebFrame::HitTest):
      
      Source/WebKit2:
      
      Reviewed by Julien Chaffraix and Maciej Stachowiak.
      
      Update calls to new API and update exported symbols.
      
      * WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
      (WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::hitTest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::handleContextMenuEvent):
      (WebKit::WebPage::highlightPotentialActivation):
      (WebKit::WebPage::findZoomableAreaForPoint):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::characterIndexForPoint):
      (WebKit::WebPage::performDictionaryLookupAtLocation):
      (WebKit::WebPage::shouldDelayWindowOrderingEvent):
      (WebKit::WebPage::acceptsFirstMouse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb0e1f9f
  11. 09 Feb, 2013 1 commit
    • mkwst@chromium.org's avatar
      Use IGNORE_EXCEPTION for initialized, but unused, ExceptionCodes. · d15dbe65
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109295
      
      Reviewed by Darin Adler.
      
      The monster patch in http://wkbug.com/108771 missed an entire class of
      ignored exceptions. It only dealt with call sites that never initialized
      the ExceptionCode variable, on the assumption that only such call sites
      would ignore the variable's value.
      
      That was a flawed assumption: a large number of sites that initialize the
      ExceptionCode to 0 ignore it regardless. This patch deals with the
      almost-as-large set of callsites that initialize the variable, pass it to
      a function, and then never touch it again.
      
      * Modules/indexeddb/IDBDatabase.cpp:
      (WebCore::IDBDatabase::forceClose):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::ariaSelectedTextRange):
      (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
      (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
      * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
      (getSelectionOffsetsForObject):
      * accessibility/atk/WebKitAccessibleUtil.cpp:
      (selectionBelongsToObject):
      * dom/Node.cpp:
      (WebCore::Node::textRects):
      * editing/DeleteButtonController.cpp:
      (WebCore::DeleteButtonController::hide):
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::styleAtSelectionStart):
      * editing/Editor.cpp:
      (WebCore::Editor::canDeleteRange):
      (WebCore::Editor::pasteAsPlainText):
      (WebCore::Editor::pasteAsFragment):
      (WebCore::Editor::shouldDeleteRange):
      (WebCore::Editor::dispatchCPPEvent):
      (WebCore::Editor::setComposition):
      (WebCore::Editor::advanceToNextMisspelling):
      (WebCore::isFrameInRange):
      * editing/EditorCommand.cpp:
      (WebCore::expandSelectionToGranularity):
      * editing/MergeIdenticalElementsCommand.cpp:
      (WebCore::MergeIdenticalElementsCommand::doApply):
      * editing/SplitElementCommand.cpp:
      (WebCore::SplitElementCommand::doUnapply):
      * editing/SplitTextNodeCommand.cpp:
      (WebCore::SplitTextNodeCommand::doApply):
      * editing/TextCheckingHelper.cpp:
      (WebCore::expandToParagraphBoundary):
      (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
      (WebCore::TextCheckingHelper::isUngrammatical):
      (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
      * editing/TextInsertionBaseCommand.cpp:
      (WebCore::dispatchBeforeTextInsertedEvent):
      (WebCore::canAppendNewLineFeedToSelection):
      * editing/TextIterator.cpp:
      (WebCore::findPlainText):
      * editing/htmlediting.cpp:
      (WebCore::extendRangeToWrappingNodes):
      (WebCore::isNodeVisiblyContainedWithin):
      * editing/visible_units.cpp:
      (WebCore::nextBoundary):
      * html/FileInputType.cpp:
      (WebCore::FileInputType::createShadowSubtree):
      * html/HTMLKeygenElement.cpp:
      (WebCore::HTMLKeygenElement::HTMLKeygenElement):
      * html/HTMLScriptElement.cpp:
      (WebCore::HTMLScriptElement::setText):
      * html/HTMLTitleElement.cpp:
      (WebCore::HTMLTitleElement::setText):
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::didCompleteLoad):
      * html/RangeInputType.cpp:
      (WebCore::RangeInputType::createShadowSubtree):
      * html/SearchInputType.cpp:
      (WebCore::SearchInputType::createShadowSubtree):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::createShadowSubtree):
      * html/track/TextTrackList.cpp:
      (TextTrackList::asyncEventTimerFired):
      * inspector/DOMPatchSupport.cpp:
      (WebCore::DOMPatchSupport::patchDocument):
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore):
      * inspector/InspectorFileSystemAgent.cpp:
      (WebCore):
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::addRange):
      * page/DragController.cpp:
      (WebCore::DragController::dispatchTextInputEventFor):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::dispatchMouseEvent):
      (WebCore::EventHandler::handleTouchEvent):
      * page/FrameActionScheduler.cpp:
      (WebCore::EventFrameAction::fire):
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
      * svg/SVGDocument.cpp:
      (WebCore::SVGDocument::dispatchZoomEvent):
      (WebCore::SVGDocument::dispatchScrollEvent):
      * svg/SVGLength.cpp:
      (WebCore::SVGLength::SVGLength):
      (WebCore::SVGLength::value):
      * xml/parser/XMLDocumentParser.cpp:
      (WebCore::XMLDocumentParser::exitText):
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::parse):
      (WebCore::XMLDocumentParser::startDocument):
      (WebCore::XMLDocumentParser::parseCharacters):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d15dbe65
  12. 08 Feb, 2013 2 commits
    • mkwst@chromium.org's avatar
      Add a new IGNORE_EXCEPTION helper to ignore ExceptionCodes when they are expected but uninteresting · 33cdf43a
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108771
      
      Reviewed by Eric Seidel.
      
      In cases where the ExceptionCode passed into a function is completely
      ignored, this patch replaces it with a new IGNORE_EXCEPTION macro. This
      makes our expectations about possible exceptions (or lack thereof)
      explicit, rather than relying on implicit assumptions about whether a
      variable is intentionally uninitialized or not. It also removes
      knowledge about the internals of ExceptionCodes (that they're currently
      ints, for instance) from code that shouldn't care, which will help with
      future refactorings.
      
      The implementation is entirely based upon ASSERT_NO_EXCEPTION, and
      shouldn't have any visible effect on the web. As long as all the
      current tests pass, we're good.
      
      * Modules/indexeddb/IDBRequest.cpp:
      (WebCore::IDBRequest::dispatchEvent):
      (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::stop):
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::processBuffer):
      * dom/Document.cpp:
      (WebCore::Document::processHttpEquiv):
      * dom/ExceptionCodePlaceholder.h:
      (WebCore):
      * dom/Node.cpp:
      (WebCore::Node::normalize):
      * dom/Text.cpp:
      (WebCore::Text::replaceWholeText):
      * editing/AlternativeTextController.cpp:
      (WebCore::AlternativeTextController::insertDictatedText):
      * editing/AppendNodeCommand.cpp:
      (WebCore::AppendNodeCommand::doApply):
      (WebCore::AppendNodeCommand::doUnapply):
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt):
      * editing/DeleteFromTextNodeCommand.cpp:
      (WebCore::DeleteFromTextNodeCommand::doUnapply):
      * editing/Editor.cpp:
      (WebCore::dispatchEditableContentChangedEvents):
      (WebCore::Editor::applyEditingStyleToElement):
      * editing/EditorCommand.cpp:
      (WebCore::executeFormatBlock):
      * editing/FormatBlockCommand.cpp:
      (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
      * editing/InsertIntoTextNodeCommand.cpp:
      (WebCore::InsertIntoTextNodeCommand::doApply):
      (WebCore::InsertIntoTextNodeCommand::doUnapply):
      * editing/InsertListCommand.cpp:
      (WebCore::InsertListCommand::doApplyForSingleParagraph):
      * editing/InsertNodeBeforeCommand.cpp:
      (WebCore::InsertNodeBeforeCommand::doApply):
      (WebCore::InsertNodeBeforeCommand::doUnapply):
      * editing/RemoveCSSPropertyCommand.cpp:
      (WebCore::RemoveCSSPropertyCommand::doApply):
      (WebCore::RemoveCSSPropertyCommand::doUnapply):
      * editing/RemoveNodeCommand.cpp:
      (WebCore::RemoveNodeCommand::doApply):
      (WebCore::RemoveNodeCommand::doUnapply):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
      * editing/TextIterator.cpp:
      (WebCore::TextIterator::getLocationAndLengthFromRange):
      * editing/WrapContentsInDummySpanCommand.cpp:
      (WebCore::WrapContentsInDummySpanCommand::executeApply):
      (WebCore::WrapContentsInDummySpanCommand::doUnapply):
      * editing/htmlediting.cpp:
      (WebCore::comparePositions):
      * editing/markup.cpp:
      (WebCore::highestAncestorToWrapMarkup):
      * html/FTPDirectoryDocument.cpp:
      (WebCore::FTPDirectoryDocumentParser::appendEntry):
      (WebCore::FTPDirectoryDocumentParser::createTDForFilename):
      (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
      (WebCore::FTPDirectoryDocumentParser::createBasicDocument):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::rewind):
      (WebCore::HTMLMediaElement::returnToRealtime):
      (WebCore::HTMLMediaElement::playInternal):
      (WebCore::HTMLMediaElement::percentLoaded):
      (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
      (WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
      (WebCore::HTMLMediaElement::applyMediaFragmentURI):
      * html/HTMLOutputElement.cpp:
      (WebCore::HTMLOutputElement::setTextContentInternal):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::remove):
      * html/HTMLTableElement.cpp:
      (WebCore::HTMLTableElement::createTHead):
      (WebCore::HTMLTableElement::deleteTHead):
      (WebCore::HTMLTableElement::createTFoot):
      (WebCore::HTMLTableElement::deleteTFoot):
      (WebCore::HTMLTableElement::createCaption):
      (WebCore::HTMLTableElement::deleteCaption):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::setDefaultValue):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocument::createDocumentStructure):
      * html/InputType.cpp:
      (WebCore::InputType::stepUpFromRenderer):
      * html/MediaController.cpp:
      (MediaController::bringElementUpToSpeed):
      (MediaController::asyncEventTimerFired):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocumentParser::createDocumentStructure):
      (WebCore::MediaDocument::replaceMediaElementTimerFired):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      * html/RangeInputType.cpp:
      (WebCore::RangeInputType::handleKeydownEvent):
      * html/TimeRanges.cpp:
      (TimeRanges::contain):
      (TimeRanges::nearest):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawImageFromRect):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::MediaControlSeekButtonElement::seekTimerFired):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::setPosition):
      (WebCore::MediaControlPanelElement::resetPosition):
      (WebCore::MediaControlStatusDisplayElement::update):
      (WebCore::MediaControlRewindButtonElement::defaultEventHandler):
      (WebCore::MediaControlTimelineElement::defaultEventHandler):
      * html/shadow/MediaControls.cpp:
      (WebCore::MediaControls::updateCurrentTimeDisplay):
      (WebCore::MediaControls::createTextTrackDisplay):
      * html/shadow/MediaControlsApple.cpp:
      (WebCore::MediaControlsApple::updateCurrentTimeDisplay):
      * html/shadow/MediaControlsBlackBerry.cpp:
      (WebCore::MediaControlEmbeddedPanelElement::setPosition):
      (WebCore::MediaControlEmbeddedPanelElement::resetPosition):
      (WebCore::MediaControlFullscreenTimelineElement::defaultEventHandler):
      (WebCore::MediaControlsBlackBerry::updateCurrentTimeDisplay):
      * html/shadow/MediaControlsChromium.cpp:
      (WebCore::MediaControlsChromium::updateCurrentTimeDisplay):
      * html/track/InbandTextTrack.cpp:
      (WebCore::InbandTextTrack::addGenericCue):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
      * inspector/InspectorHistory.cpp:
      (WebCore::InspectorHistory::markUndoableState):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::replayXHR):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::contextMenuItemSelected):
      * page/DOMWindow.cpp:
      (WebCore::didAddStorageEventListener):
      * page/DragController.cpp:
      (WebCore::documentFragmentFromDragData):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::dispatchDragEvent):
      (WebCore::EventHandler::keyEvent):
      (WebCore::EventHandler::handleTextInputEvent):
      * page/Page.cpp:
      (WebCore::Page::findStringMatchingRanges):
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintMediaSliderTrack):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::MediaPlayerPrivate::percentLoaded):
      * platform/gtk/RenderThemeGtk.cpp:
      (WebCore::RenderThemeGtk::paintMediaSliderTrack):
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::getDataSelection):
      (WebCore::documentFragmentWithImageResource):
      (WebCore::Pasteboard::documentFragment):
      * platform/mac/WebVideoFullscreenHUDWindowController.mm:
      (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
      (-[WebVideoFullscreenHUDWindowController setVolume:]):
      * platform/qt/RenderThemeQt.cpp:
      (WebCore::RenderThemeQt::paintMediaSliderTrack):
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::getRanges):
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::paintMediaSliderTrack):
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::detachTarget):
      * xml/XMLTreeViewer.cpp:
      (WebCore::XMLTreeViewer::transformDocumentToTreeView):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::XMLDocumentParser::endElementNs):
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::parseEndElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33cdf43a
    • mkwst@chromium.org's avatar
      Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro. · 4d257487
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109044
      
      Reviewed by Darin Adler.
      
      The pattern:
      
          ExceptionCode ec = 0;
          methodThatGeneratesException(ec);
          ASSERT(!ec);
      
      is more clearly and succinctly written as:
      
          methodThatGeneratesException(ASSERT_NO_EXCEPTION);
      
      This patch replaces the occurances of the former that never touch 'ec'
      again with the latter. It does the same for 'ASSERT(ec == 0);' (and, as
      a drive-by, replaces 'ASSERT(ec == 0)' with 'ASSERT(!ec)' in places
      where it does indeed matter that 'ec' get set properly.
      
      No change in behavior should result from this refactoring.
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::takeAllChildrenFrom):
      * dom/Document.cpp:
      (WebCore::Document::setTitle):
      * dom/MessagePort.cpp:
      (WebCore::MessagePort::dispatchMessages):
      (WebCore::MessagePort::disentanglePorts):
      * editing/DeleteButtonController.cpp:
      (WebCore::enclosingDeletableElement):
      (WebCore::DeleteButtonController::createDeletionUI):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      (WebCore::DeleteButtonController::show):
          Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
      * editing/EditorCommand.cpp:
      (WebCore::unionDOMRanges):
      * editing/ReplaceNodeWithSpanCommand.cpp:
      (WebCore::swapInNodePreservingAttributesAndChildren):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplacementFragment::ReplacementFragment):
      (WebCore::ReplacementFragment::removeNode):
      (WebCore::ReplacementFragment::insertNodeBefore):
      (WebCore::ReplacementFragment::insertFragmentForTestRendering):
      (WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
      (WebCore::ReplaceSelectionCommand::insertAsListItems):
      * editing/SplitTextNodeCommand.cpp:
      (WebCore::SplitTextNodeCommand::doUnapply):
      * editing/TextIterator.cpp:
      (WebCore::CharacterIterator::range):
      (WebCore::BackwardsCharacterIterator::range):
      (WebCore::TextIterator::rangeFromLocationAndLength):
      (WebCore::collapsedToBoundary):
      * editing/htmlediting.cpp:
      (WebCore::createTabSpanElement):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::fontForSelection):
      (WebCore::Editor::fontAttributesForSelectionStart):
      * editing/markup.cpp:
      (WebCore::createMarkup):
      (WebCore::trimFragment):
      (WebCore::createFragmentFromMarkupWithContext):
      (WebCore::fillContainerFromString):
      (WebCore::createFragmentFromText):
      (WebCore::createFragmentFromNodes):
      * html/ColorInputType.cpp:
      (WebCore::ColorInputType::createShadowSubtree):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      * html/HTMLOptionsCollection.cpp:
      (WebCore::HTMLOptionsCollection::add):
          Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::updatePlaceholderText):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
      (WebCore::HTMLTextFormControlElement::setInnerTextValue):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::updatePlaceholderText):
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::buildBubbleTree):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::getCookies):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::addRule):
      * loader/appcache/ApplicationCacheHost.cpp:
      (WebCore::ApplicationCacheHost::dispatchDOMEvent):
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::deleteFromDocument):
      * page/DragController.cpp:
      (WebCore::prepareClipboardForImageDrag):
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::visiblePositionForIndex):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d257487
  13. 07 Feb, 2013 2 commits
    • gavinp@chromium.org's avatar
      Unreviewed, rolling out r142118. · 0a23dbe0
      gavinp@chromium.org authored
      http://trac.webkit.org/changeset/142118
      https://bugs.webkit.org/show_bug.cgi?id=109044
      
      Broke SVG! Oh noes!
      
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::direction):
      * Modules/indexeddb/IDBObjectStore.cpp:
      (WebCore):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::mode):
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::takeAllChildrenFrom):
      * dom/Document.cpp:
      (WebCore::Document::setTitle):
      * dom/MessagePort.cpp:
      (WebCore::MessagePort::dispatchMessages):
      (WebCore::MessagePort::disentanglePorts):
      * editing/DeleteButtonController.cpp:
      (WebCore::enclosingDeletableElement):
      (WebCore::DeleteButtonController::createDeletionUI):
      (WebCore::DeleteButtonController::show):
      * editing/EditorCommand.cpp:
      (WebCore::unionDOMRanges):
      * editing/ReplaceNodeWithSpanCommand.cpp:
      (WebCore::swapInNodePreservingAttributesAndChildren):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplacementFragment::ReplacementFragment):
      (WebCore::ReplacementFragment::removeNode):
      (WebCore::ReplacementFragment::insertNodeBefore):
      (WebCore::ReplacementFragment::insertFragmentForTestRendering):
      (WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
      (WebCore::ReplaceSelectionCommand::insertAsListItems):
      * editing/SplitTextNodeCommand.cpp:
      (WebCore::SplitTextNodeCommand::doUnapply):
      * editing/TextIterator.cpp:
      (WebCore::CharacterIterator::range):
      (WebCore::BackwardsCharacterIterator::range):
      (WebCore::TextIterator::rangeFromLocationAndLength):
      (WebCore::collapsedToBoundary):
      * editing/htmlediting.cpp:
      (WebCore::createTabSpanElement):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::fontForSelection):
      (WebCore::Editor::fontAttributesForSelectionStart):
      * editing/markup.cpp:
      (WebCore::createMarkup):
      (WebCore::trimFragment):
      (WebCore::createFragmentFromMarkupWithContext):
      (WebCore::fillContainerFromString):
      (WebCore::createFragmentFromText):
      (WebCore::createFragmentFromNodes):
      * html/ColorInputType.cpp:
      (WebCore::ColorInputType::createShadowSubtree):
      * html/HTMLOptionsCollection.cpp:
      (WebCore::HTMLOptionsCollection::add):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::updatePlaceholderText):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
      (WebCore::HTMLTextFormControlElement::setInnerTextValue):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::updatePlaceholderText):
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::buildBubbleTree):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::getCookies):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::addRule):
      * loader/appcache/ApplicationCacheHost.cpp:
      (WebCore::ApplicationCacheHost::dispatchDOMEvent):
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::deleteFromDocument):
      * page/DragController.cpp:
      (WebCore::prepareClipboardForImageDrag):
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::visiblePositionForIndex):
      * rendering/style/SVGRenderStyle.h:
      (WebCore::SVGRenderStyle::initialBaselineShiftValue):
      (WebCore::SVGRenderStyle::initialKerning):
      (WebCore::SVGRenderStyle::initialStrokeDashOffset):
      (WebCore::SVGRenderStyle::initialStrokeWidth):
      * svg/SVGAnimatedLength.cpp:
      (WebCore::sharedSVGLength):
      (WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
      (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
      * svg/SVGAnimatedLengthList.cpp:
      (WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
      (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
      * svg/SVGLength.cpp:
      (WebCore::SVGLength::SVGLength):
      * svg/SVGTextContentElement.cpp:
      (WebCore::SVGTextContentElement::textLengthAnimated):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::constructQualifiedName):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a23dbe0
    • mkwst@chromium.org's avatar
      Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro. · 50f39a6e
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109044
      
      Reviewed by Darin Adler.
      
      The pattern:
      
          ExceptionCode ec = 0;
          methodThatGeneratesException(ec);
          ASSERT(!ec);
      
      is more clearly and succinctly written as:
      
          methodThatGeneratesException(ASSERT_NO_EXCEPTION);
      
      This patch replaces the occurances of the former that never touch 'ec'
      again with the latter. It does the same for 'ASSERT(ec == 0);' (and, as
      a drive-by, replaces 'ASSERT(ec == 0)' with 'ASSERT(!ec)' in places
      where it does indeed matter that 'ec' get set properly.
      
      No change in behavior should result from this refactoring.
      
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::direction):
      * Modules/indexeddb/IDBObjectStore.cpp:
      (WebCore):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::mode):
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::takeAllChildrenFrom):
      * dom/Document.cpp:
      (WebCore::Document::setTitle):
      * dom/MessagePort.cpp:
      (WebCore::MessagePort::dispatchMessages):
      (WebCore::MessagePort::disentanglePorts):
      * editing/DeleteButtonController.cpp:
      (WebCore::enclosingDeletableElement):
      (WebCore::DeleteButtonController::createDeletionUI):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      (WebCore::DeleteButtonController::show):
          Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
      * editing/EditorCommand.cpp:
      (WebCore::unionDOMRanges):
      * editing/ReplaceNodeWithSpanCommand.cpp:
      (WebCore::swapInNodePreservingAttributesAndChildren):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplacementFragment::ReplacementFragment):
      (WebCore::ReplacementFragment::removeNode):
      (WebCore::ReplacementFragment::insertNodeBefore):
      (WebCore::ReplacementFragment::insertFragmentForTestRendering):
      (WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
      (WebCore::ReplaceSelectionCommand::insertAsListItems):
      * editing/SplitTextNodeCommand.cpp:
      (WebCore::SplitTextNodeCommand::doUnapply):
      * editing/TextIterator.cpp:
      (WebCore::CharacterIterator::range):
      (WebCore::BackwardsCharacterIterator::range):
      (WebCore::TextIterator::rangeFromLocationAndLength):
      (WebCore::collapsedToBoundary):
      * editing/htmlediting.cpp:
      (WebCore::createTabSpanElement):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::fontForSelection):
      (WebCore::Editor::fontAttributesForSelectionStart):
      * editing/markup.cpp:
      (WebCore::createMarkup):
      (WebCore::trimFragment):
      (WebCore::createFragmentFromMarkupWithContext):
      (WebCore::fillContainerFromString):
      (WebCore::createFragmentFromText):
      (WebCore::createFragmentFromNodes):
      * html/ColorInputType.cpp:
      (WebCore::ColorInputType::createShadowSubtree):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      * html/HTMLOptionsCollection.cpp:
      (WebCore::HTMLOptionsCollection::add):
          Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::updatePlaceholderText):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
      (WebCore::HTMLTextFormControlElement::setInnerTextValue):
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::updatePlaceholderText):
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::buildBubbleTree):
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::getCookies):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::addRule):
      * loader/appcache/ApplicationCacheHost.cpp:
      (WebCore::ApplicationCacheHost::dispatchDOMEvent):
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::deleteFromDocument):
      * page/DragController.cpp:
      (WebCore::prepareClipboardForImageDrag):
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::visiblePositionForIndex):
      * rendering/style/SVGRenderStyle.h:
      (WebCore::SVGRenderStyle::initialBaselineShiftValue):
      (WebCore::SVGRenderStyle::initialKerning):
      (WebCore::SVGRenderStyle::initialStrokeDashOffset):
      (WebCore::SVGRenderStyle::initialStrokeWidth):
      * svg/SVGAnimatedLength.cpp:
      (WebCore::sharedSVGLength):
      (WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
      (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
      * svg/SVGAnimatedLengthList.cpp:
      (WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
      (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
      * svg/SVGLength.cpp:
      (WebCore::SVGLength::SVGLength):
      * svg/SVGTextContentElement.cpp:
      (WebCore::SVGTextContentElement::textLengthAnimated):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::constructQualifiedName):
          Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50f39a6e
  14. 23 Jan, 2013 1 commit
    • shinyak@chromium.org's avatar
      shadowAncestorNode() should be renamed to deprecatedShadowAncestorNode() · 659784bf
      shinyak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107624
      
      Reviewed by Dimitri Glazkov.
      
      Since Node::shadowAncestorNode() is deprecated, we would like to rename it to prevent from further use.
      
      Source/WebCore:
      
      No new tests, simple refactoring.
      
      * WebCore.order:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityHitTest):
      * dom/Document.cpp:
      (WebCore::Document::handleZeroPadding):
      * dom/Node.cpp:
      (WebCore::Node::deprecatedShadowAncestorNode):
      * dom/Node.h:
      (Node):
      * editing/Editor.cpp:
      (WebCore::Editor::rangeOfString):
      (WebCore::Editor::countMatchesForText):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplacementFragment::ReplacementFragment):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMouseReleaseEvent):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      * page/FocusController.cpp:
      (WebCore::clearSelectionIfNeeded):
      * platform/blackberry/RenderThemeBlackBerry.cpp:
      (WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::setToNonShadowAncestor):
      (WebCore::HitTestResult::addNodeToRectBasedTestResult):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      * WebKitSupport/FatFingers.h:
      (BlackBerry::WebKit::FatFingersResult::node):
      * WebKitSupport/InPageSearchManager.cpp:
      (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::scopeStringMatches):
      (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::inputMethodEvent):
      (QWebPageAdapter::inputMethodQuery):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      659784bf
  15. 21 Dec, 2012 1 commit
    • timothy_horton@apple.com's avatar
      PDFPlugin: Cannot drop files/URLs on PDFPlugin · 8e3ce2f3
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105516
      <rdar://problem/12729443>
      
      Reviewed by Alexey Proskuryakov.
      
      Add shouldAllowNavigationFromDrags to Plugin/PluginView/etc., which WebCore will
      consult when dragging over a PluginDocument to decide whether or not a drag may result in navigation.
      
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::shouldAllowNavigationFromDrags): Added, always returning false to keep existing behavior.
      * WebProcess/Plugins/Netscape/NetscapePlugin.h:
      (NetscapePlugin): Added.
      * WebProcess/Plugins/PDF/SimplePDFPlugin.h:
      (WebKit::SimplePDFPlugin::shouldAllowNavigationFromDrags): Added, always returning true. (Simple)PDFPlugin should
      navigate when dropped onto, just like an image or HTML document would.
      * WebProcess/Plugins/Plugin.h:
      (Plugin): Add shouldAllowNavigationFromDrags.
      * WebProcess/Plugins/PluginProxy.h: Add shouldAllowNavigationFromDrags.
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::shouldAllowNavigationFromDrags): Forward shouldAllowNavigationFromDrags to the plugin.
      * WebProcess/Plugins/PluginView.h: Add shouldAllowNavigationFromDrags.
      
      * page/DragController.cpp:
      (WebCore::DragController::operationForLoad): If we drag over a PluginDocument, check if its PluginView
      claims to support navigation resulting from a drag (only PDFPlugin will for now). If it does, allow the drag.
      * plugins/PluginViewBase.h:
      (WebCore::PluginViewBase::shouldAllowNavigationFromDrags): Add shouldAllowNavigationFromDrags.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e3ce2f3
  16. 11 Dec, 2012 1 commit
    • dpranke@chromium.org's avatar
      Switch to new PseudoElement based :before and :after · cecd9c05
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104462
      
      Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-11
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Switch to the new PseudoElement based generated content implementation
      that moves :before and :after into the DOM. This also switches to using
      the ComposedShadowTreeWalker for determining the siblings of PseudoElement's
      making the new generated content implementation support adding :before
      and :after into <input> elements.
      
      Tests: fast/css-generated-content/block-inside-inline.html
             fast/css-generated-content/box-orient.html
      
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::ComposedShadowTreeWalker::pseudoAwareNextSibling):
      (WebCore):
      (WebCore::ComposedShadowTreeWalker::pseudoAwarePreviousSibling):
      (WebCore::ComposedShadowTreeWalker::traverseParent):
      * dom/ComposedShadowTreeWalker.h:
      (ComposedShadowTreeWalker):
      * dom/Element.cpp:
      (WebCore::Element::attach):
      (WebCore::Element::recalcStyle):
      * dom/Node.cpp:
      * dom/Node.h:
      (Node):
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::nextRenderer):
      (WebCore::NodeRenderingContext::previousRenderer):
      (WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
      * dom/Position.cpp:
      (WebCore::Position::Position):
      (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
      * editing/visible_units.cpp:
      (WebCore::logicallyPreviousBox):
      (WebCore::logicallyNextBox):
      (WebCore::startPositionForLine):
      (WebCore::endPositionForLine):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::childShouldCreateRenderer):
      * page/DragController.cpp:
      (WebCore::DragController::draggableNode):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::styleDidChange):
      (WebCore::RenderBlock::splitBlocks):
      (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
      (WebCore::RenderBlock::createReplacementRunIn):
      (WebCore::RenderBlock::isSelectionRoot):
      * rendering/RenderBlock.h:
      (RenderBlock):
      * rendering/RenderButton.cpp:
      * rendering/RenderButton.h:
      (RenderButton):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::styleDidChange):
      (WebCore::RenderInline::addChildIgnoringContinuation):
      (WebCore::RenderInline::splitInlines):
      * rendering/RenderListItem.cpp:
      (WebCore::RenderListItem::updateMarkerLocation):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::createVisiblePosition):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::nonPseudoNode):
      (RenderObject):
      (WebCore::RenderObject::clearNode):
      (WebCore::RenderObject::generatingNode):
      * rendering/RenderObjectChildList.cpp:
      * rendering/RenderObjectChildList.h:
      (RenderObjectChildList):
      * rendering/RenderRubyText.cpp:
      * rendering/RenderRubyText.h:
      (RenderRubyText):
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::styleDidChange):
      * rendering/RenderTableRow.h:
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::addChild):
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::destroy):
      
      LayoutTests:
      
      Add test for block generated content inside inlines which is now supported
      properly, and also for using box-orient and reordering.
      
      before-content-continuation.html's expectations change because we now
      support block content properly.
      
      I skipped fast/css-generated-content/table-row-group-to-inline.html
      which needs a rebaseline after this this lands. Unfortunately the test
      output is still wrong because we leave an anonymous RenderTable in the
      tree, but that bug has always been there.
      
      I also skipped fast/css/empty-generated-content.html which needs rebaselines
      as we no longer create extra anonymous blocks, though the reason is not clear
      to me.
      
      * fast/css-generated-content/before-content-continuation-chain-expected.txt:
      * fast/css-generated-content/block-inside-inline-expected.html: Added.
      * fast/css-generated-content/block-inside-inline.html: Added.
      * fast/css-generated-content/box-orient-expected.html: Added.
      * fast/css-generated-content/box-orient.html: Added.
      * platform/chromium/TestExpectations:
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cecd9c05
  17. 27 Nov, 2012 2 commits
    • simonjam@chromium.org's avatar
      Consolidate FrameLoader::load() into one function taking a FrameLoadRequest · c98850bc
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102151
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      There's a FIXME that we have too many FrameLoader::load*() functions. This patch consolidates 3 into 1.
      There are still a few more load functions that will be consolidated later. Using FrameLoadRequest as
      the interface into FrameLoader will also provide a place to pass in the initiator. Finally, this matches
      the refactoring done with CachedResourceRequest and CachedResourceLoader.
      
      No new tests. No change in functionality.
      
      * WebCore.exp.in:
      * loader/FrameLoadRequest.h:
      (WebCore::FrameLoadRequest::FrameLoadRequest):
      (WebCore::FrameLoadRequest::setLockHistory): These are former arguments to load().
      (WebCore::FrameLoadRequest::lockHistory): Ditto.
      (FrameLoadRequest):
      (WebCore::FrameLoadRequest::setShouldCheckNewWindowPolicy): Ditto.
      (WebCore::FrameLoadRequest::shouldCheckNewWindowPolicy): Ditto.
      (WebCore::FrameLoadRequest::substituteData): Ditto.
      (WebCore::FrameLoadRequest::setSubstituteData): Ditto.
      (WebCore::FrameLoadRequest::hasSubstituteData): Ditto.
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::load): No change in behavior, just merged it all into one function.
      * loader/FrameLoader.h:
      (FrameLoader):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::loadRequest):
      (WebKit::WebFrameImpl::loadData):
      * src/WebSharedWorkerImpl.cpp:
      (WebKit::WebSharedWorkerImpl::initializeLoader):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (_ewk_frame_contents_set_internal):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      
      Source/WebKit/mac:
      
      * Plugins/WebPluginController.mm:
      * WebView/WebFrame.mm:
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      
      Source/WebKit/qt:
      
      * Api/qwebframe.cpp:
      (QWebFrame::QWebFrame):
      (QWebFrame::load):
      (QWebFrame::setHtml):
      (QWebFrame::setContent):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setAlternateHtml):
      (qt_dump_set_accepts_editing):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      
      Source/WebKit/wince:
      
      * WebView.cpp:
      (WebView::load):
      
      Source/WebKit/wx:
      
      * WebFrame.cpp:
      (WebKit::WebFrame::SetPageSource):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::performFrameLoadURLRequest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c98850bc
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r135786. · c022234d
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/135786
      https://bugs.webkit.org/show_bug.cgi?id=103379
      
      It made 3 plugin tests timeout on several platforms (Requested
      by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-27
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * loader/FrameLoadRequest.cpp: Removed.
      * loader/FrameLoadRequest.h:
      (WebCore::FrameLoadRequest::FrameLoadRequest):
      (FrameLoadRequest):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::load):
      * loader/FrameLoader.h:
      (FrameLoader):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::performRequest):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::loadRequest):
      (WebKit::WebFrameImpl::loadData):
      * src/WebSharedWorkerImpl.cpp:
      (WebKit::WebSharedWorkerImpl::initializeLoader):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_uri_set):
      (_ewk_frame_contents_set_internal):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      
      Source/WebKit/mac:
      
      * Plugins/WebPluginController.mm:
      * WebView/WebFrame.mm:
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      
      Source/WebKit/qt:
      
      * Api/qwebframe.cpp:
      (QWebFrame::setHtml):
      (QWebFrame::setContent):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setAlternateHtml):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::load):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      
      Source/WebKit/wince:
      
      * WebView.cpp:
      (WebView::load):
      
      Source/WebKit/wx:
      
      * WebFrame.cpp:
      (WebKit::WebFrame::SetPageSource):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::performFrameLoadURLRequest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadData):
      (WebKit::WebPage::linkClicked):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c022234d
  18. 26 Nov, 2012 1 commit
    • simonjam@chromium.org's avatar
      Consolidate FrameLoader::load() into one function taking a FrameLoadRequest · 135b0f52
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102151
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      There's a FIXME that we have too many FrameLoader::load*() functions. This patch consolidates 3 into 1.
      There are still a few more load functions that will be consolidated later. Using FrameLoadRequest as
      the interface into FrameLoader will also provide a place to pass in the initiator. Finally, this matches
      the refactoring done with CachedResourceRequest and CachedResourceLoader.
      
      No new tests. No change in functionality.
      
      * WebCore.exp.in:
      * loader/FrameLoadRequest.h:
      (WebCore::FrameLoadRequest::FrameLoadRequest):
      (WebCore::FrameLoadRequest::setLockHistory): These are former arguments to load().
      (WebCore::FrameLoadRequest::lockHistory): Ditto.
      (FrameLoadRequest):
      (WebCore::FrameLoadRequest::setShouldCheckNewWindowPolicy): Ditto.
      (WebCore::FrameLoadRequest::shouldCheckNewWindowPolicy): Ditto.
      (WebCore::FrameLoadRequest::substituteData): Ditto.
      (WebCore::FrameLoadRequest::setSubstituteData): Ditto.
      (WebCore::FrameLoadRequest::hasSubstituteData): Ditto.
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::load): No change in behavior, just merged it all into one function.
      * loader/FrameLoader.h:
      (FrameLoader):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::loadRequest):
      (WebKit::WebFrameImpl::loadData):
      * src/WebSharedWorkerImpl.cpp:
      (WebKit::WebSharedWorkerImpl::initializeLoader):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (_ewk_frame_contents_set_internal):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      
      Source/WebKit/mac:
      
      * Plugins/WebPluginController.mm:
      * WebView/WebFrame.mm:
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      
      Source/WebKit/qt:
      
      * Api/qwebframe.cpp:
      (QWebFrame::QWebFrame):
      (QWebFrame::load):
      (QWebFrame::setHtml):
      (QWebFrame::setContent):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setAlternateHtml):
      (qt_dump_set_accepts_editing):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      
      Source/WebKit/wince:
      
      * WebView.cpp:
      (WebView::load):
      
      Source/WebKit/wx:
      
      * WebFrame.cpp:
      (WebKit::WebFrame::SetPageSource):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::performFrameLoadURLRequest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      135b0f52
  19. 20 Nov, 2012 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r135295. · cee39327
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/135295
      https://bugs.webkit.org/show_bug.cgi?id=102834
      
      This patch causes assertion to some layout tests on chromium
      (Requested by jianli on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * loader/FrameLoadRequest.cpp: Removed.
      * loader/FrameLoadRequest.h:
      (WebCore::FrameLoadRequest::FrameLoadRequest):
      (FrameLoadRequest):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::load):
      * loader/FrameLoader.h:
      (FrameLoader):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::performRequest):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::loadRequest):
      (WebKit::WebFrameImpl::loadData):
      * src/WebSharedWorkerImpl.cpp:
      (WebKit::WebSharedWorkerImpl::initializeLoader):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_uri_set):
      (_ewk_frame_contents_set_internal):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      
      Source/WebKit/mac:
      
      * Plugins/WebPluginController.mm:
      * WebView/WebFrame.mm:
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      
      Source/WebKit/qt:
      
      * Api/qwebframe.cpp:
      (QWebFrame::QWebFrame):
      (QWebFrame::load):
      (QWebFrame::setHtml):
      (QWebFrame::setContent):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setAlternateHtml):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      
      Source/WebKit/wince:
      
      * WebView.cpp:
      (WebView::load):
      
      Source/WebKit/wx:
      
      * WebFrame.cpp:
      (WebKit::WebFrame::SetPageSource):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::performFrameLoadURLRequest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadData):
      (WebKit::WebPage::linkClicked):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cee39327
    • simonjam@chromium.org's avatar
      Consolidate FrameLoader::load() into one function taking a FrameLoadRequest · e0ac21db
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102151
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      There's a FIXME that we have too many FrameLoader::load*() functions. This patch consolidates 3 into 1.
      There are still a few more load functions that will be consolidated later. Using FrameLoadRequest as
      the interface into FrameLoader will also provide a place to pass in the initiator. Finally, this matches
      the refactoring done with CachedResourceRequest and CachedResourceLoader.
      
      No new tests. No change in functionality.
      
      * WebCore.exp.in:
      * loader/FrameLoadRequest.h:
      (WebCore::FrameLoadRequest::FrameLoadRequest):
      (WebCore::FrameLoadRequest::setLockHistory): These are former arguments to load().
      (WebCore::FrameLoadRequest::lockHistory): Ditto.
      (FrameLoadRequest):
      (WebCore::FrameLoadRequest::setShouldCheckNewWindowPolicy): Ditto.
      (WebCore::FrameLoadRequest::shouldCheckNewWindowPolicy): Ditto.
      (WebCore::FrameLoadRequest::substituteData): Ditto.
      (WebCore::FrameLoadRequest::setSubstituteData): Ditto.
      (WebCore::FrameLoadRequest::hasSubstituteData): Ditto.
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::load): No change in behavior, just merged it all into one function.
      * loader/FrameLoader.h:
      (FrameLoader):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::loadRequest):
      (WebKit::WebFrameImpl::loadData):
      * src/WebSharedWorkerImpl.cpp:
      (WebKit::WebSharedWorkerImpl::initializeLoader):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (_ewk_frame_contents_set_internal):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      
      Source/WebKit/mac:
      
      * Plugins/WebPluginController.mm:
      * WebView/WebFrame.mm:
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      
      Source/WebKit/qt:
      
      * Api/qwebframe.cpp:
      (QWebFrame::QWebFrame):
      (QWebFrame::load):
      (QWebFrame::setHtml):
      (QWebFrame::setContent):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setAlternateHtml):
      (qt_dump_set_accepts_editing):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      
      Source/WebKit/wince:
      
      * WebView.cpp:
      (WebView::load):
      
      Source/WebKit/wx:
      
      * WebFrame.cpp:
      (WebKit::WebFrame::SetPageSource):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::performFrameLoadURLRequest):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0ac21db
  20. 26 Oct, 2012 1 commit
    • dcheng@chromium.org's avatar
      dragover's default action should prevent drop for file drags · 98fbabba
      dcheng@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79173
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      During a file drag, we need to keep track of whether or not the document has cancelled the
      dragover action. We should only send a drop event if the dragover event was cancelled; this
      matches the behavior of the spec, as well as IE, Gecko, and Opera. The relevant sections
      from the spec are the sections pertaining to dragover and drop events at:
      http://www.whatwg.org/specs/web-apps/current-work/#drag-and-drop-processing-model
      
      Test: fast/events/only-valid-drop-targets-receive-file-drop.html
      
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      (WebCore::DragController::dragEnteredOrUpdated):
      (WebCore::DragController::tryDocumentDrag):
      * page/DragController.h:
      (DragController): Cleanup to repurpose a variable that doesn't need to be a member anymore
                        and remove the corresponding getter/setter.
      
      LayoutTests:
      
      * fast/dom/shadow/drop-event-in-shadow.html:
          Added dragover handler as required by the HTML specification.
      * fast/events/input-element-display-none-in-dragleave-crash.html:
          Added dragover handler as required by the HTML specification.
      * fast/events/only-valid-drop-targets-receive-file-drop-expected.txt: Added.
      * fast/events/only-valid-drop-targets-receive-file-drop.html: Added.
      * http/tests/security/clipboard/clipboard-file-access.html:
          Added dragover handler as required by the HTML specification.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98fbabba
  21. 17 Oct, 2012 1 commit
    • commit-queue@webkit.org's avatar
      plugins: Allow a plugin to dictate whether it can receive drag events or not. · ed2e01ec
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99355
      
      Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-17
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      When doing a drag over a plugin, ask the plugin whether it can accept
      drag/drop to decide whether drag/drop is possible or not. At present,
      plugins do not receive drag events through WebCore (i.e. various
      implementations of PluginView::handleMouseEvent ignores the
      drop-events). This change makes it possible for the ports to ask the
      plugin first to decide whether it can (or wants to) accept drag events.
      The default implementation remains the same, i.e. plugins do not receive
      drag events. For chromium, the overridden implementation uses the
      WebPlugin interface to check whether the plugin can accept drag events.
      
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::canProcessDrag):
      (WebCore):
      * html/HTMLPlugInElement.h:
      (WebCore):
      (HTMLPlugInElement):
      * page/DragController.cpp:
      (WebCore::DragController::canProcessDrag):
      * plugins/PluginViewBase.h:
      (WebCore):
      (WebCore::PluginViewBase::canProcessDrag):
      
      Source/WebKit/chromium:
      
      Introduce WebPlugin::canProcessDrag() and use that to implement PluginViewBase::canProcessDrag.
      
      * public/WebPlugin.h:
      (WebKit::WebPlugin::canProcessDrag):
      (WebPlugin):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::canProcessDrag):
      (WebKit):
      (WebKit::WebPluginContainerImpl::handleMouseEvent):
      * src/WebPluginContainerImpl.h:
      (WebPluginContainerImpl):
      
      Tools:
      
      Update the TestWebPlugin to implement the new |canProcessDrag| interface.
      
      * DumpRenderTree/chromium/TestWebPlugin.h:
      (TestWebPlugin::canProcessDrag):
      
      LayoutTests:
      
      Update test to not set contentEditable on the plugin anymore.
      
      * platform/chromium/plugins/drag-events-expected.txt:
      * platform/chromium/plugins/drag-events.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed2e01ec
  22. 12 Sep, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r127876. · 3f2c0096
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/127876
      https://bugs.webkit.org/show_bug.cgi?id=96600
      
      mouse click doesn't work for spin button if spin button in
      iframe (Requested by yosin on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-12
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * WebCore.order:
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      * dom/Document.h:
      (Document):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::createContextMenu):
      * page/DragController.cpp:
      (WebCore::DragController::canProcessDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::updateAutoscrollRenderer):
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
      (WebCore::EventHandler::handleTouchEvent):
      * page/EventHandler.h:
      (EventHandler):
      * page/FocusController.cpp:
      (WebCore::updateFocusCandidateIfNeeded):
      * page/Frame.cpp:
      (WebCore::Frame::visiblePositionForPoint):
      (WebCore::Frame::documentAtPoint):
      * page/TouchDisambiguation.cpp:
      (WebCore::findGoodTouchTargets):
      * rendering/HitTestRequest.h:
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::contextNode):
      (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      (BlackBerry::WebKit::WebPage::nodeAtPoint):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getNodesFromRect):
      (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
      
      Source/WebKit/chromium:
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::characterIndexForPoint):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::isRectTopmost):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleMouseUp):
      (WebKit::WebViewImpl::computeBlockBounds):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_hit_test_new):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::actionDictionary):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView elementAtPoint:allowShadowContent:]):
      
      Source/WebKit/qt:
      
      * Api/qwebframe.cpp:
      (QWebFrame::hitTestContent):
      * Api/qwebpage.cpp:
      (QWebPagePrivate::handleSoftwareInputPanel):
      (QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
      (QWebPage::updatePositionDependentActions):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      
      Source/WebKit/win:
      
      * WebActionPropertyBag.cpp:
      (WebActionPropertyBag::Read):
      * WebView.cpp:
      (WebView::handleContextMenuEvent):
      (WebView::elementAtPoint):
      
      Source/WebKit/wx:
      
      * WebFrame.cpp:
      (WebKit::WebFrame::HitTest):
      
      Source/WebKit2:
      
      * WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
      (WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::handleContextMenuEvent):
      (WebKit::WebPage::highlightPotentialActivation):
      (WebKit::WebPage::findZoomableAreaForPoint):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::characterIndexForPoint):
      (WebKit::WebPage::performDictionaryLookupAtLocation):
      (WebKit::WebPage::shouldDelayWindowOrderingEvent):
      (WebKit::WebPage::acceptsFirstMouse):
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f2c0096
  23. 07 Sep, 2012 1 commit
    • allan.jensen@nokia.com's avatar
      Simplify hitTestResultAtPoint and nodesFromRect APIs · 38071cdc
      allan.jensen@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95720
      
      Reviewed by Antonio Gomes.
      
      .:
      
      Update exported symbols.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      The existing API was overloaded and could be simplified by passing all the bool arguments in
      a HitTestRequest argument. This should also help clarify the call as the enum values explicitely
      state what they do.
      
      * WebCore.exp.in:
      * WebCore.order:
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      * dom/Document.h:
      (Document):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::createContextMenu):
      * page/DragController.cpp:
      (WebCore::DragController::canProcessDrag):
      (WebCore::DragController::startDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::updateAutoscrollRenderer):
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
      (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
      (WebCore::EventHandler::handleTouchEvent):
      * page/EventHandler.h:
      (EventHandler):
      * page/FocusController.cpp:
      (WebCore::updateFocusCandidateIfNeeded):
      * page/Frame.cpp:
      (WebCore::Frame::visiblePositionForPoint):
      (WebCore::Frame::documentAtPoint):
      * page/TouchDisambiguation.cpp:
      (WebCore::findGoodTouchTargets):
      * rendering/HitTestRequest.h:
      (HitTestRequest):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      
      Source/WebKit/blackberry:
      
      Update calls to new API.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::contextNode):
      (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      (BlackBerry::WebKit::WebPage::nodeAtPoint):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::getNodesFromRect):
      (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
      
      Source/WebKit/chromium:
      
      Update calls to new API.
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::characterIndexForPoint):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::isRectTopmost):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleMouseUp):
      (WebKit::WebViewImpl::computeBlockBounds):
      
      Source/WebKit/efl:
      
      Update calls to new API.
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_hit_test_new):
      
      Source/WebKit/mac:
      
      Update calls to new API.
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::actionDictionary):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView elementAtPoint:allowShadowContent:]):
      
      Source/WebKit/qt:
      
      Update calls to new API.
      
      * Api/qwebframe.cpp:
      (QWebFrame::hitTestContent):
      * Api/qwebpage.cpp:
      (QWebPagePrivate::handleSoftwareInputPanel):
      (QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
      (QWebPage::updatePositionDependentActions):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      
      Source/WebKit/win:
      
      Update calls to new API.
      
      * WebActionPropertyBag.cpp:
      (WebActionPropertyBag::Read):
      * WebView.cpp:
      (WebView::handleContextMenuEvent):
      (WebView::elementAtPoint):
      
      Source/WebKit/wx:
      
      Update calls to new API.
      
      * WebFrame.cpp:
      (WebKit::WebFrame::HitTest):
      
      Source/WebKit2:
      
      Update calls to new API and update exported symbols.
      
      * WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
      (WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::handleContextMenuEvent):
      (WebKit::WebPage::highlightPotentialActivation): Corrects the misplaced arguments while converting them.
      (WebKit::WebPage::findZoomableAreaForPoint):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::characterIndexForPoint):
      (WebKit::WebPage::performDictionaryLookupAtLocation):
      (WebKit::WebPage::shouldDelayWindowOrderingEvent):
      (WebKit::WebPage::acceptsFirstMouse):
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38071cdc
  24. 14 Aug, 2012 1 commit
    • abarth@webkit.org's avatar
      Delete Frame::domWindow() and Frame::existingDOMWindow() · b7c61160
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93990
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      These functions just call through to document()->domWindow(). This
      patch updates the callers so it's clearer what's going on.
      
      * bindings/js/JSDOMBinding.cpp:
      (WebCore::shouldAllowAccessToFrame):
      (WebCore::printErrorMessageForFrame):
      * bindings/js/JSDocumentCustom.cpp:
      (WebCore::JSDocument::location):
      (WebCore::JSDocument::setLocation):
      * bindings/js/JSEventListener.cpp:
      (WebCore::JSEventListener::handleEvent):
      * bindings/js/ScriptCachedFrameData.cpp:
      (WebCore::ScriptCachedFrameData::restore):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::createWindowShell):
      * bindings/objc/DOMAbstractView.mm:
      (core):
      * bindings/v8/NPV8Object.cpp:
      (WebCore::toV8Context):
      * bindings/v8/ScriptController.cpp:
      (WebCore::createScriptObject):
      (WebCore::ScriptController::createScriptObjectForPluginElement):
      * bindings/v8/V8DOMWindowShell.cpp:
      (WebCore::V8DOMWindowShell::initContextIfNeeded):
      * bindings/v8/V8IsolatedContext.cpp:
      (WebCore::V8IsolatedContext::V8IsolatedContext):
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::retrieveFrame):
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::V8DOMWindow::indexedPropertyGetter):
      (WebCore::V8DOMWindow::namedPropertyGetter):
      * bindings/v8/custom/V8DocumentLocationCustom.cpp:
      (WebCore::V8Document::locationAccessorGetter):
      (WebCore::V8Document::locationAccessorSetter):
      * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
      (WebCore::V8HTMLDocument::GetNamedProperty):
      * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
      (WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
      * dom/Document.cpp:
      (WebCore::printNavigationErrorMessage):
      * dom/ViewportArguments.cpp:
      (WebCore::reportViewportWarning):
      * editing/AlternativeTextController.cpp:
      (WebCore::AlternativeTextController::insertDictatedText):
      * editing/Editor.cpp:
      (WebCore::Editor::pasteAsPlainText):
      (WebCore::Editor::pasteAsFragment):
      (WebCore::Editor::setComposition):
      * history/PageCache.cpp:
      (WebCore::logCanCacheFrameDecision):
      (WebCore::PageCache::canCachePageContainingThisFrame):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::validateInteractively):
      * html/HTMLFrameOwnerElement.cpp:
      (WebCore::HTMLFrameOwnerElement::contentWindow):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      (WebCore::WebGLRenderingContext::printWarningToConsole):
      * inspector/InspectorDOMStorageAgent.cpp:
      (WebCore::InspectorDOMStorageAgent::storageId):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::checkLoadComplete):
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::begin):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::stopLoading):
      (WebCore::FrameLoader::didOpenURL):
      (WebCore::FrameLoader::checkIfDisplayInsecureContent):
      (WebCore::FrameLoader::checkIfRunInsecureContent):
      (WebCore::FrameLoader::reportLocalLoadFailed):
      (WebCore::FrameLoader::prepareForCachedPageRestore):
      (WebCore::FrameLoader::open):
      (WebCore::FrameLoader::fireBeforeUnloadEvent):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::didReceiveResponse):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::abort):
      (WebCore::ApplicationCacheGroup::didReceiveResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoading):
      (WebCore::ApplicationCacheGroup::didFail):
      (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
      (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::printAccessDeniedMessage):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::isCurrentlyDisplayedInFrame):
      (WebCore::DOMWindow::self):
      (WebCore::DOMWindow::opener):
      (WebCore::DOMWindow::parent):
      (WebCore::DOMWindow::top):
      (WebCore::DOMWindow::createWindow):
      (WebCore::DOMWindow::open):
      * page/DOMWindowProperty.cpp:
      (WebCore::DOMWindowProperty::DOMWindowProperty):
      (WebCore::DOMWindowProperty::reconnectFrameFromPageCache):
      * page/DragController.cpp:
      (WebCore::DragController::dispatchTextInputEventFor):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleTextInputEvent):
      * page/Frame.cpp:
      * page/Frame.h:
      (Frame):
      * page/Location.cpp:
      (WebCore::Location::replace):
      (WebCore::Location::reload):
      (WebCore::Location::setLocation):
      * storage/StorageEventDispatcher.cpp:
      (WebCore::StorageEventDispatcher::dispatch):
      * svg/SVGDocumentExtensions.cpp:
      (WebCore::reportMessage):
      * xml/XSLStyleSheetLibxslt.cpp:
      (WebCore::XSLStyleSheet::parseString):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::docLoaderFunc):
      * xml/XSLTProcessorQt.cpp:
      (WebCore::XSLTMessageHandler::handleMessage):
      
      Source/WebKit/blackberry: 
      
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::toOriginString):
      (WebCore::ChromeClientBlackBerry::runJavaScriptAlert):
      (WebCore::ChromeClientBlackBerry::runJavaScriptConfirm):
      (WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
      (WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
      (WebCore::ChromeClientBlackBerry::requestWebGLPermission):
      
      Source/WebKit/chromium: 
      
      * src/StorageAreaProxy.cpp:
      (WebCore::StorageAreaProxy::dispatchLocalStorageEvent):
      (WebCore::StorageAreaProxy::dispatchSessionStorageEvent):
      * src/WebDOMMessageEvent.cpp:
      (WebKit::WebDOMMessageEvent::initMessageEvent):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::performance):
      (WebKit::WebFrameImpl::addMessageToConsole):
      (WebKit::WebFrameImpl::unloadListenerCount):
      (WebKit::WebFrameImpl::addEventListener):
      (WebKit::WebFrameImpl::removeEventListener):
      (WebKit::WebFrameImpl::dispatchEvent):
      (WebKit::WebFrameImpl::dispatchMessageEventWithOriginCheck):
      (WebKit::WebFrameImpl::deliverIntent):
      * src/WebPagePopupImpl.cpp:
      (WebKit::WebPagePopupImpl::initPage):
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::pendingUnloadEventCount):
      * ewk/ewk_frame.cpp:
      (ewk_frame_intent_deliver):
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::getPendingUnloadEventCount):
      
      Source/WebKit/mac: 
      
      * WebView/WebFrame.mm:
      (-[WebFrame _pendingFrameUnloadEventCount]):
      (-[WebFrame _cacheabilityDictionary]):
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):
      
      Source/WebKit/win: 
      
      * WebFrame.cpp:
      (WebFrame::DOMWindow):
      (WebFrame::pendingFrameUnloadEventCount):
      
      Source/WebKit2: 
      
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::deliverIntent):
      (WebKit::WebFrame::pendingUnloadCount):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7c61160
  25. 03 Aug, 2012 1 commit
  26. 27 Jul, 2012 1 commit
  27. 22 Jun, 2012 1 commit
  28. 12 Jun, 2012 1 commit
    • kinuko@chromium.org's avatar
      Refactor InputType::receiveDroppedFiles to take DragData · c9b46971
      kinuko@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88860
      
      Reviewed by Kent Tamura.
      
      So that we can centralize the file paths related code into FileInputType
      and makes it easier to extract more data from DragData for
      <input type=file> (like bug 88293 for directory drag-and-drop).
      
      No new tests as this has no behavioral changes.
      
      * html/FileInputType.cpp:
      (WebCore::FileInputType::receiveDroppedFiles):
      * html/FileInputType.h:
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::receiveDroppedFiles):
      * html/HTMLInputElement.h:
      * html/InputType.cpp:
      (WebCore::InputType::receiveDroppedFiles):
      * html/InputType.h:
      * page/DragController.cpp:
      (WebCore::DragController::concludeEditDrag):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9b46971
  29. 20 May, 2012 1 commit
    • shinyak@chromium.org's avatar
      [Refactoring] Node::shadowHost() and Node::setShadowHost() can be moved to ShadowRoot. · 22a3c20d
      shinyak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86585
      
      Reviewed by Hajime Morita.
      
      Since Node::shadowHost() and Node::setShadowHost() are valid only if Node is ShadowRoot,
      they should be moved to ShadowRoot.
      
      However, Node::setParent cannot be called from ShadowRoot, we add Node::setParentOrHostNode
      to call it as Node::parentOrHostNode() calls Node::parent(). Node::setParent() is now private.
      We also add SVGElementInstance::setParentOrHostNode() to share ContainerNodeAlgorithm.
      
      No new tests, no change in behavior.
      
      * dom/Attr.cpp:
      (WebCore::Attr::createTextChild):
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::insertBeforeCommon):
      (WebCore::ContainerNode::removeBetween):
      (WebCore::ContainerNode::removeChildren):
      * dom/ContainerNodeAlgorithms.h:
      (WebCore::appendChildToContainer):
      (WebCore::Private::addChildNodesToDeletionQueue):
      * dom/ElementShadow.cpp:
      (WebCore::validateShadowRoot):
      (WebCore::ElementShadow::addShadowRoot):
      (WebCore::ElementShadow::removeAllShadowRoots):
      * dom/EventDispatcher.cpp:
      (WebCore::eventTargetRespectingSVGTargetRules):
      (WebCore::EventDispatcher::ensureEventAncestors):
      (WebCore::EventDispatcher::determineDispatchBehavior):
      * dom/EventDispatcher.h:
      (WebCore):
      (EventDispatcher):
      * dom/Node.cpp:
      (WebCore::Node::parentOrHostElement):
      * dom/Node.h:
      (Node):
      (WebCore::Node::setParentOrHostNode):
      (WebCore):
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      * dom/ShadowRoot.h:
      (WebCore::ShadowRoot::host):
      (WebCore):
      (WebCore::ShadowRoot::setHost):
      * dom/TreeScope.cpp:
      (WebCore::TreeScope::focusedNode):
      * html/shadow/ContentSelectorQuery.cpp:
      (WebCore::ContentSelectorQuery::matches):
      * page/DragController.cpp:
      (WebCore::asFileInput):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::instanceAssociatedWithShadowTreeElement):
      (WebCore::EventHandler::dispatchMouseEvent):
      * page/FocusController.cpp:
      (WebCore::FocusScope::owner):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::hasLineIfEmpty):
      * svg/SVGElementInstance.h:
      (WebCore::SVGElementInstance::setParentOrHostNode):
      (SVGElementInstance):
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::title):
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGShadowText::willRecalcTextStyle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22a3c20d
  30. 16 May, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on chromium linux · 621df958
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86236
      
      Patch by Varun Jain <varunjain@google.com> on 2012-05-16
      Reviewed by Tony Chang.
      
      .:
      
      * ManualTests/chromium/modifiers-during-drag-and-drop.html: Added.
      
      Source/WebCore:
      
      ManualTests: ManualTests/chromium/modifiers-during-drag-and-drop.html
      
      * page/DragController.cpp:
      (WebCore::createMouseEvent):
      * platform/DragData.cpp:
      (WebCore):
      (WebCore::DragData::modifierKeyState):
      * platform/DragData.h:
      (DragData):
      * platform/chromium/ChromiumDataObject.cpp:
      (WebCore::ChromiumDataObject::ChromiumDataObject):
      * platform/chromium/ChromiumDataObject.h:
      (WebCore::ChromiumDataObject::modifierKeyState):
      (WebCore::ChromiumDataObject::setModifierKeyState):
      (ChromiumDataObject):
      * platform/chromium/DragDataChromium.cpp:
      (WebCore::DragData::modifierKeyState):
      (WebCore):
      
      Source/WebKit/chromium:
      
      * public/WebView.h:
      (WebView):
      * src/WebViewImpl.cpp:
      (WebKit::webInputEventKeyStateToPlatformEventKeyState):
      (WebKit):
      (WebKit::WebViewImpl::dragTargetDragEnter):
      (WebKit::WebViewImpl::dragTargetDragOver):
      (WebKit::WebViewImpl::dragTargetDrop):
      (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
      * src/WebViewImpl.h:
      (WebViewImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      621df958
  31. 18 Apr, 2012 1 commit
  32. 12 Apr, 2012 1 commit
    • jchaffraix@webkit.org's avatar
      Reduce the use of RenderLayer outside of the rendering code · 9dbf6d18
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83728
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Test: fast/layers/scrollByLines-overflow-no-layer.html
      
      This is mostly a layering violation change. This changes reduces the number of
      RenderLayer use outside rendering/ by a third but there are still numerous uses.
      
      While auditing the different uses of RenderLayer, I found a potential crasher
      and fixed it which is why we have a test case.
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      (WebCore::Document::handleZeroPadding):
      (WebCore::nodeFromPoint):
      (WebCore::Document::prepareMouseEvent):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::contains):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMouseDraggedEvent):
      (WebCore::EventHandler::eventMayStartDrag):
      (WebCore::EventHandler::updateSelectionForMouseDrag):
      (WebCore::EventHandler::hitTestResultAtPoint):
      (WebCore::EventHandler::handleWheelEvent):
      (WebCore::EventHandler::hoverTimerFired):
      (WebCore::EventHandler::handleDrag):
      Updated these call sites to use RenderView::hitTest.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * page/FrameView.cpp:
      (WebCore::FrameView::contentsInCompositedLayer):
      (WebCore::FrameView::scrollContentsFastPath):
      Updated these call sites to use RenderObject::isComposited().
      
      * dom/Element.cpp:
      (WebCore::Element::scrollByUnits):
      Call directly RenderBox::scroll instead of calling the layer.
      This actually fixes a crasher that slipped through the cracks.
      
      * editing/visible_units.cpp:
      * html/shadow/TextControlInnerElements.cpp:
      * page/ContextMenuController.cpp:
      * page/FocusController.cpp:
      * page/Frame.cpp:
      * page/GestureTapHighlighter.cpp:
      * page/PrintContext.cpp:
      * plugins/mac/PluginViewMac.mm:
      Removed unneeded #include.
      
      * plugins/gtk/PluginViewGtk.cpp:
      * plugins/qt/PluginViewQt.cpp:
      Replaced RenderLayer.h #include with RenderObject.h as
      we use RenderObject::absoluteToLocal.
      
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::isComposited):
      * rendering/RenderObject.h:
      * rendering/RenderView.cpp:
      (WebCore::RenderView::hitTest):
      * rendering/RenderView.h:
      Added 2 new functions that pipe through the RenderLayer.
      
      LayoutTests:
      
      The test checks that calling scrollByUnit without a RenderLayer doesn't crash.
      
      * fast/layers/scrollByLines-overflow-no-layer.html: Added.
      * fast/layers/scrollByLines-overflow-no-layer-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9dbf6d18
  33. 06 Apr, 2012 1 commit