1. 29 Sep, 2009 40 commits
    • dbates@webkit.org's avatar
      2009-09-29 Daniel Bates <dbates@webkit.org> · 59ac2d39
      dbates@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=29837
              
              More tests for the XSSAuditor.
      
              * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt: Added.
              * http/tests/security/xssAuditor/embed-tag-javascript-url.html: Added.
              * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt: Added.
              * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html: Added.
              * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt: Added.
              * http/tests/security/xssAuditor/object-tag-javascript-url.html: Added.
              * http/tests/security/xssAuditor/property-escape-noquotes-expected.txt: Added.
              * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt: Added.
              * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html: Added.
              * http/tests/security/xssAuditor/property-escape-noquotes.html: Added.
              * http/tests/security/xssAuditor/property-inject-expected.txt: Added.
              * http/tests/security/xssAuditor/property-inject.html: Added.
              * http/tests/security/xssAuditor/resources/echo-head.pl: Added.
              * http/tests/security/xssAuditor/resources/echo-inner-tag.pl: Added.
              * http/tests/security/xssAuditor/resources/echo-property-noquotes.pl: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59ac2d39
    • eric@webkit.org's avatar
      2009-09-29 Enrica Casucci <enrica@apple.com> · 5fbc25ce
      eric@webkit.org authored
              Reviewed by Adele Peterson.
      
              Test case for <rdar://problem/7085453>.
      
              * editing/selection/blockquote-crash-expected.txt: Added.
              * editing/selection/blockquote-crash.html: Added.
      2009-09-29  Enrica Casucci  <enrica@apple.com>
      
              Reviewed by Adele Peterson.
      
              Reproducible crash pressing return inside quoted content
              at WebCore::BreakBlockquoteCommand::doApply.
              <rdar://problem/7085453>
              In some case, like the one provided in the test case, m_downStreamEnd
              refers to a node that gets deleted when executing the DeleteSelectionCommand.
              We shouldn't use m_downStreamEnd to recalculate the new m_endPosition when
              pruning is needed, because it may be point to a node that has been deleted, but
              rather rely on removeNode in CompositeEditCommand to update m_endPosition correctly.
      
              Test: editing/selection/blockquote-crash.html
      
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply): Added check for invalid position
              to avoid dereferencing a null node pointer.
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::mergeParagraphs): Don't reset m_endPosition
              using the value in m_downStreamEnd when it is necessary to prune the start block.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fbc25ce
    • ap@apple.com's avatar
      Reviewed by Brady Eidson. · 57df29c7
      ap@apple.com authored
              Basic authentication credentials are not sent automatically to top resources
              https://bugs.webkit.org/show_bug.cgi?id=29901
      
              No new tests - I don't want to pollute root directory of http tests to check for this rather
              minor issue.
      
              * platform/network/CredentialStorage.cpp:
              (WebCore::CredentialStorage::set): Changed to always preserve leading slash.
              (WebCore::CredentialStorage::getDefaultAuthenticationCredential): Made breaking out of the
              loop more explicit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57df29c7
    • bweinstein@apple.com's avatar
      Windows build fix. · 0d0c7d37
      bweinstein@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d0c7d37
    • pfeldman@chromium.org's avatar
      2009-09-29 Pavel Feldman <pfeldman@chromium.org> · e7245dec
      pfeldman@chromium.org authored
              Reviewed by Oliver Hunt.
      
              Web Inspector REGRESSION(r47820-r47822): Profiles aren't
              added to the inspector unless the inspector is already open
              when the profile completes.
      
              https://bugs.webkit.org/show_bug.cgi?id=29897
      
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype._populateProfiles):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7245dec
    • kenneth@webkit.org's avatar
      Rubberstamped by David Hyatt. · c7161bce
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
      Fix to logic of earlier commit 48902.
      
      When merging two if's before committing, I forgot to invert the
      bool check.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::ignoreHttpError):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7161bce
    • oliver@apple.com's avatar
      Tidy up codeblock sampler · ebd0b4c7
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29836
      
      Reviewed by Gavin Barraclough.
      
      Some rather simple refactoring of codeblock sampler so that
      it's easier for us to use it to find problems in non-jsc
      environments
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ebd0b4c7
    • senorblanco@chromium.org's avatar
      Unreviewed, build fix. · 6ad942ac
      senorblanco@chromium.org authored
      Fixing Chromium build, following r48884.
      
      [https://bugs.webkit.org/show_bug.cgi?id=29894]
      
      * bindings/v8/V8AbstractEventListener.cpp:
      (WebCore::V8AbstractEventListener::handleEvent):
      * bindings/v8/V8AbstractEventListener.h:
      * bindings/v8/V8WorkerContextEventListener.cpp:
      (WebCore::V8WorkerContextEventListener::handleEvent):
      * bindings/v8/V8WorkerContextEventListener.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ad942ac
    • eric@webkit.org's avatar
      2009-09-29 Kent Tamura <tkent@chromium.org> · d71be72a
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Update for .maxLength behavior change.
              https://bugs.webkit.org/show_bug.cgi?id=29796
      
              * fast/forms/input-maxlength-expected.txt:
              * fast/forms/input-maxlength.html:
              * fast/forms/script-tests/textarea-maxlength.js:
              * fast/forms/textarea-maxlength-expected.txt:
      2009-09-29  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              Follows HTML5's maxLength change in September 2009.
              - Change HTMLTextAreaElement.maxLength type to signed.
              - HTMLTextAreaElement.maxLength returns -1 if maxlength= attribute is missing.
              - HTMLTextAreaElement.maxLength and HTMLInputElement.maxLength
                throw INDEX_SIZE_ERR for setting negative values.
              https://bugs.webkit.org/show_bug.cgi?id=29796
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::setMaxLength):
              * html/HTMLInputElement.h:
              * html/HTMLInputElement.idl:
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
              (WebCore::HTMLTextAreaElement::maxLength):
              (WebCore::HTMLTextAreaElement::setMaxLength):
              * html/HTMLTextAreaElement.h:
              * html/HTMLTextAreaElement.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d71be72a
    • kenneth@webkit.org's avatar
      Don't rely on QNetworkReply::NetworkError codes, but · ffa55b2e
      kenneth@webkit.org authored
      on HTTP error codes instead.
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
      Reviewed by Simon Hausmann.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::ignoreHttpError):
      (WebCore::QNetworkReplyHandler::finish):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffa55b2e
    • kenneth@webkit.org's avatar
      Use const references when using Qt's foreach. · 64ef3e7f
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
      Reviewed by Simon Hausmann.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64ef3e7f
    • kenneth@webkit.org's avatar
      Fix handling of QNetworkReply errors. · 6762a927
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
      Reviewed by Simon Hausmann.
      
      In the QNetworkReplyHandler::finish() a response was sent even when
      the reply contained an error. This resulted in a sendResponseIfNeeded()
      calling didReceiveResponse on the client, leading to the destruction
      of the m_resourceHandle, discontinuing further processing in finish(),
      and thus not calling didFail on the client.
      
      Instead it continued as everything went fine, and
      FrameLoaderClientQt::dispatchDecidePolicyForMIMEType() changed the
      policy to PolicyDownload due to not being able to show the non existing
      MIMEType. As the download also obviously fails, it ended up with a
      policy change error.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyHandler::finish):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6762a927
    • dbates@webkit.org's avatar
      2009-09-29 Daniel Bates <dbates@webkit.org> · 1acb434c
      dbates@webkit.org authored
              Reviewed by Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=28902
              
              Fixes an issue where the drop effect returned by Window Dump Render Tree 
              was always DROPEFFECT_NONE (since it was hard coded to do so).
              
              This patch corrects this issue by determining the actual drop effect 
              performed by the corresponding drag-and-drop operation so that we can 
              return it.
      
              * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
              (DraggingInfo::DraggingInfo):
              (DraggingInfo::performedDropEffect): Added method.
              (DraggingInfo::setPerformedDropEffect): Added method.
              * DumpRenderTree/win/EventSender.cpp:
              (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
              Moved delete draggingInfo to UIDelegate::doDragDrop.
              * DumpRenderTree/win/UIDelegate.cpp:
              (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1acb434c
    • jorlow@chromium.org's avatar
      2009-09-29 Jeremy Orlow <jorlow@chromium.org> · 263db824
      jorlow@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Add GYP generated files to svn:ignore
              https://bugs.webkit.org/show_bug.cgi?id=29895
      
              The following files are generated by JavaScriptCore's GYP file and should be ignored:
      
              pcre.mk
              wtf.scons
              wtf.mk
              SConstruct
              wtf_config.scons
              wtf_config.mk
              pcre.scons
      
              * JavaScriptCore.gyp: Changed property svn:ignore.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      263db824
    • dglazkov@chromium.org's avatar
      2009-09-29 Dimitri Glazkov <dglazkov@chromium.org> · 39016be0
      dglazkov@chromium.org authored
              No review, rolling out r48894, because review discussion was not complete.
              http://trac.webkit.org/changeset/48894
      
              * platform/sql/SQLiteTransaction.cpp:
              (WebCore::SQLiteTransaction::begin):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39016be0
    • krit@webkit.org's avatar
      2009-09-29 Dirk Schulze <krit@webkit.org> · 42b5c8a6
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              SVG Filter feComposite implementation is missing
              [https://bugs.webkit.org/show_bug.cgi?id=28362]
      
              feComposite implementation for SVG.
      
              Test: svg/filters/feComposite.svg
      
              * platform/graphics/filters/FEComposite.cpp:
              (WebCore::arithmetic):
              (WebCore::FEComposite::apply):
      
              Tests the feComposite implementation for SVG.
      
              * platform/mac/svg/filters/feComposite-expected.checksum: Added.
              * platform/mac/svg/filters/feComposite-expected.png: Added.
              * platform/mac/svg/filters/feComposite-expected.txt: Added.
              * svg/filters/feComposite.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42b5c8a6
    • ggaren@apple.com's avatar
      Standardized an optimization for adding non-numbers. · 02c34fca
      ggaren@apple.com authored
              
      Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
      Reviewed by Sam Weinig.
      
      SunSpider says maybe a tiny speedup.
      
      * jit/JITArithmetic.cpp:
      (JSC::JIT::emit_op_add):
      (JSC::JIT::emitSlow_op_add):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02c34fca
    • eric@webkit.org's avatar
      2009-09-29 Dumitru Daniliuc <dumi@chromium.org> · 6276bb12
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Starting all read-only transactions with an explicit BEGIN
              DEFERRED command instead of BEGIN, since some ports (chromium)
              might compile their own SQLite library and set BEGIN to BEGIN
              IMMEDIATE by default; which would result in a deadlock in case of
              two concurrent read-only transactions on the same DB, and would
              unnecessarily delay other potential transactions to the same DB.
      
              https://bugs.webkit.org/show_bug.cgi?id=29729
      
              * platform/sql/SQLiteTransaction.cpp:
              (WebCore::SQLiteTransaction::begin):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6276bb12
    • dglazkov@chromium.org's avatar
      WebCore: · 5063cff9
      dglazkov@chromium.org authored
      2009-09-29  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Add support for run-time flag for 3D canvas
              https://bugs.webkit.org/show_bug.cgi?id=29826
      
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::getContext): Check page settings for
              experimental WebGL flag before returning 3D graphics context.
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Initialize new flag to false.
              (WebCore::Settings::setExperimentalWebGLEnabled):
              * page/Settings.h: Set new flag.
              (WebCore::Settings::experimentalWebGLEnabled): Return new flag.
      
      WebKit/mac:
      
      2009-09-29  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Add support for run-time flag for 3D canvas
              https://bugs.webkit.org/show_bug.cgi?id=29826
      
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Enable experimental
              WebGL flag when 3D_CANVAS is enabled in the build.
      
      WebKit/win:
      
      2009-09-29  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Add support for run-time flag for 3D canvas
              https://bugs.webkit.org/show_bug.cgi?id=29826
      
              * WebView.cpp:
              (WebView::notifyPreferencesChanged): Enable experimental WebGL
              flag when 3D_CANVAS is enabled in the build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5063cff9
    • jorlow@chromium.org's avatar
      2009-09-29 Jeremy Orlow <jorlow@chromium.org> · a9a0bc86
      jorlow@chromium.org authored
              Reviewed by Darin Fisher.
      
              Chromium needs to be able to override the way storage events are delivered - part 1
              https://bugs.webkit.org/show_bug.cgi?id=29889
      
              Chromium needs to be able to override the way storage events are delivered.
              This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be
              faster (no vtables and extra allocation) and somewhat cleaner (no dependency
              injection).  This is necessary because Chromium needs to transport events across
              a process barrier and then dispatch them without use of a Frame*.
      
              This patch should be a no-op for all ports other than Chromium.
      
              * WebCore.gypi:
              * storage/StorageEventDispatcher.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9a0bc86
    • eric@webkit.org's avatar
      2009-09-29 Shinichiro Hamaji <hamaji@chromium.org> · b5c79938
      eric@webkit.org authored
              Reviewed by David Kilzer.
      
              Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
              https://bugs.webkit.org/show_bug.cgi?id=12140
      
              Change the URLs in dumpAsText tests.
      
              * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
              * editing/deleting/delete-all-text-in-text-field-assertion.html:
              * fast/dom/Document/doc-open-while-parsing.html:
              * fast/dom/Document/document-reopen.html:
              * fast/dom/Element/setAttribute-case-insensitivity.html:
              * fast/dom/HTMLHeadElement/head-check.html:
              * fast/dom/HTMLImageElement/image-without-renderer-width-expected.txt:
              * fast/dom/HTMLImageElement/image-without-renderer-width.html:
              * fast/dom/HTMLScriptElement/script-load-events-expected.txt:
              * fast/dom/HTMLScriptElement/script-load-events.html:
              * fast/dom/clone-node-form-elements-with-attr.html:
              * fast/dom/document-dir-property-expected.txt:
              * fast/dom/document-dir-property.html:
              * fast/dom/everything-to-string.html:
              * fast/dom/generic-form-element-assert-expected.txt:
              * fast/dom/generic-form-element-assert.html:
              * fast/dom/inner-text-rtl-expected.txt:
              * fast/dom/inner-text-rtl.html:
              * fast/dom/navigator-vendorSub.html:
              * fast/dom/option-properties-expected.txt:
              * fast/dom/option-properties.html:
              * fast/dom/replace-child-siblings-expected.txt:
              * fast/dom/replace-child-siblings.html:
              * fast/dom/replace-first-child.html:
              * fast/dom/setAttribute-using-initial-input-value.html:
              * fast/dom/space-to-text.html:
              * fast/dynamic/hovered-detach-expected.txt:
              * fast/dynamic/hovered-detach.html:
              * fast/encoding/charset-koi8-u.html:
              * fast/encoding/css-charset-dom.html:
              * fast/encoding/css-charset-evil.html:
              * fast/encoding/css-charset.html:
              * fast/encoding/latin1-winlatin.html:
              * fast/encoding/mispositioned-meta.html:
              * fast/encoding/percent-escaping.html:
              * fast/encoding/pseudo-xml-2.html:
              * fast/encoding/pseudo-xml-3.html:
              * fast/encoding/pseudo-xml-4.html:
              * fast/encoding/pseudo-xml.html:
              * fast/events/init-event-null-view.html:
              * fast/events/mouseover-mouseout.html:
              * fast/events/mouseover-mouseout2.html:
              * fast/events/onload-webkit-before-webcore.html:
              * fast/forms/button-in-forms-collection.html:
              * fast/forms/document-write.html:
              * fast/forms/domstring-replace-crash-expected.txt:
              * fast/forms/domstring-replace-crash.html:
              * fast/forms/element-by-name.html:
              * fast/forms/empty-get.html:
              * fast/forms/form-data-encoding-normalization-overrun.html:
              * fast/forms/radio-button-no-change-event.html:
              * fast/forms/selected-index-assert-expected.txt:
              * fast/forms/selected-index-assert.html:
              * fast/forms/textarea-hard-linewrap-empty-expected.txt:
              * fast/forms/textarea-hard-linewrap-empty.html:
              * fast/forms/textfield-focus-out-expected.txt:
              * fast/forms/textfield-focus-out.html:
              * fast/frames/empty-frame-document-expected.txt:
              * fast/frames/empty-frame-document.html:
              * fast/frames/frame-name-reset.html:
              * fast/frames/frame-set-same-location.html:
              * fast/frames/frame-set-same-src.html:
              * fast/frames/frameElement-widthheight.html:
              * fast/frames/iframe-name-and-id-expected.txt:
              * fast/frames/iframe-name-and-id.html:
              * fast/frames/iframe-set-same-location.html:
              * fast/frames/iframe-set-same-src.html:
              * fast/frames/repaint-display-none-crash-expected.txt:
              * fast/frames/repaint-display-none-crash.html:
              * fast/js/exception-linenums-in-html-2.html:
              * fast/js/missing-title-end-tag-js.html:
              * fast/loader/link-no-URL.html:
              * fast/loader/url-strip-cr-lf-tab.html:
              * fast/overflow/generated-content-crash-expected.txt:
              * fast/overflow/generated-content-crash.html:
              * fast/parser/number-sign-in-map-name.html:
              * fast/parser/remove-current-node-parent.html:
              * fast/parser/script-after-frameset-assert.html:
              * fast/tokenizer/image-empty-crash-expected.txt:
              * fast/tokenizer/image-empty-crash.html:
              * fast/tokenizer/nested-cached-scripts-expected.txt:
              * fast/tokenizer/nested-cached-scripts.html:
              * fast/tokenizer/write-unclosed-script-expected.txt:
              * fast/tokenizer/write-unclosed-script.html:
              * fast/xsl/transformToFragment-XML-declaration.html:
              * http/tests/misc/text-refresh.html:
              * http/tests/plugins/npapi-response-headers.html:
              * http/tests/uri/utf8-path.html:
              * http/tests/xmlhttprequest/cache-override.html:
              * http/tests/xmlhttprequest/event-listener-gc-expected.txt:
              * http/tests/xmlhttprequest/event-listener-gc.html:
              * http/tests/xmlhttprequest/event-target.html:
              * http/tests/xmlhttprequest/frame-load-cancelled-abort.html:
              * http/tests/xmlhttprequest/interactive-state.html:
              * http/tests/xmlhttprequest/methods-async.html:
              * http/tests/xmlhttprequest/methods-lower-case.html:
              * http/tests/xmlhttprequest/methods.html:
              * http/tests/xmlhttprequest/post-content-type.html:
              * http/tests/xmlhttprequest/readystatechange.html:
              * http/tests/xmlhttprequest/supported-xml-content-types.html:
              * http/tests/xmlhttprequest/xhr-onunload.html:
              * http/tests/xmlhttprequest/zero-length-response.html:
              * platform/mac/fast/events/objc-event-api.html:
              * platform/mac/fast/events/objc-keyboard-event-creation.html:
              * plugins/get-empty-url.html:
              * plugins/geturl-replace-query.html:
              * plugins/invoke.html:
              * plugins/mouse-events.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5c79938
    • oliver@apple.com's avatar
      Adding file missed in previous commit. · faa287d8
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faa287d8
    • dglazkov@chromium.org's avatar
      2009-09-29 Dimitri Glazkov <dglazkov@chromium.org> · 99cd5c0a
      dglazkov@chromium.org authored
              Reviewed by Darin Fisher.
      
              [V8] Correct an issue with XMLHttpRequest attribute event listeners never being cleared.
              https://bugs.webkit.org/show_bug.cgi?id=29888
      
              Test: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-abort-readyState-shouldDispatchEvent.html
      
              * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
              (WebCore::getEventListener): Added isAttribute parameter.
              (WebCore::ACCESSOR_SETTER): Made all event listener setters create attribute listeners.
              (WebCore::CALLBACK_FUNC_DECL): Made addEventListener create object listener.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99cd5c0a
    • oliver@apple.com's avatar
      [GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images · 929f10be
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29654
      
      Patch by Martin Robinson  <martin.james.robinson@gmail.com>
      Reviewed by Eric Seidel
      
      Added an additional manual-test for this issue to the existing Gtk
      cursor image test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      929f10be
    • ap@apple.com's avatar
      Reviewed by Timothy Hatcher. · 42e47f8f
      ap@apple.com authored
              Build fix - pass a proper ScriptExecutipnContext to getEventListenerHandlerBody()
      
              * bindings/js/ScriptEventListener.cpp:
              (WebCore::getEventListenerHandlerBody):
              * bindings/js/ScriptEventListener.h:
              * bindings/v8/ScriptEventListener.cpp:
              (WebCore::getEventListenerHandlerBody):
              * bindings/v8/ScriptEventListener.h:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::buildObjectForEventListener):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42e47f8f
    • japhet@chromium.org's avatar
      2009-09-29 Nate Chapin <japhet@chromium.org> · f0ef993c
      japhet@chromium.org authored
              Reviewed by Eric Seidel.
      
              Ensure that we don't scroll lock to an anchor node after a
              user-initiated scroll, even if that scroll doesn't propagate
              all the way up to FrameView.
      
              Test: fast/events/node-event-anchor-lock.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0ef993c
    • ggaren@apple.com's avatar
      Windows build fix: export a new symbol. · bed3b5eb
      ggaren@apple.com authored
      Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bed3b5eb
    • ap@apple.com's avatar
      Reviewed by Darin Adler and Sam Weinig. · 06431f3d
      ap@apple.com authored
              Onclick not fired for an element copied with cloneContents() or cloneNode()
              https://bugs.webkit.org/show_bug.cgi?id=25130
      
              The change here is that JS event listeners don't keep a reference to a global object from
              where they were created, and instead take it as a parameter when parsing source code. Also,
              the listener creation won't fail just because it happens for an element in a frameless
              document.
              Thus, moving nodes between documents no longer results in having incorrect registered
              lazy event listeners on them.
      
              Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html
                     fast/events/attribute-listener-cloned-from-frameless-doc-context.html
                     fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
                     fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
                     fast/events/attribute-listener-extracted-from-frameless-doc-context.html
      
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject.
              (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for
              getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner.
              (WebCore::JSEventListener::markJSFunction): Don't mark the global object.
              (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext.
              (WebCore::JSEventListener::reportError): Ditto.
      
              * bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference
              to JSDOMGlobalObject.
      
              * bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener
              creation was split between this function and ScriptEventListener; moved it here, as JS
              global object can be different now.
      
              * bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL,
              which can not be determined at parsing time.
      
              * bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code
              for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests
              expect that errors are logged at document parsing time, and because I don't know what other
              side effects moving it vould have.
      
              * dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext,
              because JSC needs a global context here.
      
              * bindings/js/JSAbstractWorkerCustom.cpp:
              (WebCore::JSAbstractWorker::addEventListener):
              (WebCore::JSAbstractWorker::removeEventListener):
              * bindings/js/JSDOMApplicationCacheCustom.cpp:
              (WebCore::JSDOMApplicationCache::addEventListener):
              (WebCore::JSDOMApplicationCache::removeEventListener):
              * bindings/js/JSDOMGlobalObject.cpp:
              (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::addEventListener):
              (WebCore::JSDOMWindow::removeEventListener):
              * bindings/js/JSEventSourceCustom.cpp:
              (WebCore::JSEventSource::addEventListener):
              (WebCore::JSEventSource::removeEventListener):
              * bindings/js/JSMessagePortCustom.cpp:
              (WebCore::JSMessagePort::addEventListener):
              (WebCore::JSMessagePort::removeEventListener):
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::JSNode::addEventListener):
              (WebCore::JSNode::removeEventListener):
              * bindings/js/JSSVGElementInstanceCustom.cpp:
              (WebCore::JSSVGElementInstance::addEventListener):
              (WebCore::JSSVGElementInstance::removeEventListener):
              * bindings/js/JSWorkerContextCustom.cpp:
              (WebCore::JSWorkerContext::addEventListener):
              (WebCore::JSWorkerContext::removeEventListener):
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::addEventListener):
              (WebCore::JSXMLHttpRequest::removeEventListener):
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
              (WebCore::JSXMLHttpRequestUpload::addEventListener):
              (WebCore::JSXMLHttpRequestUpload::removeEventListener):
              * bindings/objc/ObjCEventListener.h:
              * bindings/objc/ObjCEventListener.mm:
              (WebCore::ObjCEventListener::handleEvent):
              * bindings/scripts/CodeGeneratorJS.pm:
              * dom/EventTarget.cpp:
              (WebCore::EventTarget::fireEventListeners):
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::handleEvent):
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorDOMStorageResource.cpp:
              (WebCore::InspectorDOMStorageResource::handleEvent):
              * inspector/InspectorDOMStorageResource.h:
              * loader/ImageDocument.cpp:
              (WebCore::ImageEventListener::handleEvent):
              * svg/animation/SVGSMILElement.cpp:
              (WebCore::ConditionEventListener::handleEvent):
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::reportException):
              Don't pass global object to JSEventListener::create(), which no longer needs it.
              Note that some of these functions still have an early return for null global object, which
              can probably be removed in a later patch.
              Pass ScriptExecutionContext to EventListener methods that now need it.
      
              * bindings/scripts/CodeGeneratorCOM.pm: Don't force EventTarget implementation on Node -
              it doesn't work yet (it didn't quite work before this patch, too, because it assumed that
              any object implementing EventTarget COM interface originated from WebCore).
      
              * dom/EventListener.idl: Just like in ObjC, EventListener should be a pure interface in
              COM bindings.
      
      WebKit/win:
              * DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now.
      
              * WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06431f3d
    • ggaren@apple.com's avatar
      Removed virtual destructor from JSGlobalObjectData to eliminate pointer · d4abf9cb
      ggaren@apple.com authored
      fix-ups when accessing JSGlobalObject::d.
              
      Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
      Reviewed by Sam Weinig.
      
      JavaScriptCore: 
      
      Replaced with an explicit destructor function pointer.
              
      6% speedup on bench-alloc-nonretained.js.
      
      * JavaScriptCore.exp:
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::~JSGlobalObject):
      (JSC::JSGlobalObject::destroyJSGlobalObjectData):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
      (JSC::JSGlobalObject::JSGlobalObject):
      
      JavaScriptGlue: 
      
      Replaced with an explicit destructor function pointer.
      
      * JSRun.cpp:
      (JSGlueGlobalObject::destroyData):
      * JSRun.h:
      (JSGlueGlobalObject::Data::Data):
      
      WebCore: 
      
      Replaced with an explicit destructor function pointer.
      
      * bindings/js/JSDOMGlobalObject.cpp:
      (WebCore::JSDOMGlobalObject::destroyJSDOMGlobalObjectData):
      * bindings/js/JSDOMGlobalObject.h:
      (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4abf9cb
    • kenneth@webkit.org's avatar
      The code for showing error pages when the response was · 6abc8949
      kenneth@webkit.org authored
      a 401/403/404, was not actually doing so. This patch
      fixes that.
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
      Reviewed by Simon Hausmann.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyHandler::finish):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6abc8949
    • mitz@apple.com's avatar
      Remove copying of unnecessary or nonexistent files from the ImageDiff · b5c1de62
      mitz@apple.com authored
      post-build event.
      
      Reviewed by Adam Roben.
      
      * DumpRenderTree/win/ImageDiff.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5c1de62
    • eric@webkit.org's avatar
      2009-09-29 Csaba Osztrogonac <oszi@inf.u-szeged.hu> · 8d3d5d8b
      eric@webkit.org authored
              Reviewed by David Kilzer.
      
              [Qt] Make build-webkit script work on Windows
              https://bugs.webkit.org/show_bug.cgi?id=29802
      
              * Scripts/run-webkit-tests:
              * Scripts/webkitdirs.pm:
               - Removed unnecessary -p switch for mkdir on Windows.
               - Use canonical path, which uses slashes or backslashes depends on platform.
               - isWindows() only test for Windows and not for Cyqwin.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d3d5d8b
    • ap@apple.com's avatar
      Reviewed by Brady Eidson. · 549845e7
      ap@apple.com authored
              <rdar://problem/7259965> REGRESSION: http/tests/xmlhttprequest/cross-origin-authorization.html
              is failing/crashing intermittently
              https://bugs.webkit.org/show_bug.cgi?id=29322
      
              This was caused by CStringBuffer::encodeBase64() returning a buffer that wasn't zero terminated.
              The code had other issues as well, so I removed it altogether:
              - it claimed to avoid some buffer copies, but it didn't;
              - and I don't think that base64 encoding should be part of CString interface.
      
      
      WebCore:
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::encodeBasicAuthorization): Encode username and password using Base64.h directly.
              (WebCore::ResourceHandle::start): Use encodeBasicAuthorization().
              (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto.
              (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Extended logging
              to synchronous case.
              (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
              (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
      
              * platform/network/cf/ResourceHandleCFNet.cpp: Matched Mac changes.
      
              * platform/text/CString.cpp:
              * platform/text/CString.h:
              (WebCore::CStringBuffer::create):
              (WebCore::CStringBuffer::CStringBuffer):
              Removed code that was added for Base64 in r48363.
      
      LayoutTests:
              * http/tests/xmlhttprequest/cross-origin-authorization.html: While at it, made the test
              detect more error conditions
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      549845e7
    • eric@webkit.org's avatar
      2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com> · ecc70255
      eric@webkit.org authored
              Reviewed by David Kilzer.
      
              [Qt] Assert messages prints visible in Symbian
              https://bugs.webkit.org/show_bug.cgi?id=29808
      
              Asserts use vprintf to print the messages to stderr.
              In Symbian Open C it is not possible to see stderr so
              I routed the messages to stdout instead.
      
              * wtf/Assertions.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecc70255
    • xan@webkit.org's avatar
      2009-09-29 Xan Lopez <xlopez@igalia.com> · e99dfc8b
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Do not set a non-default parent window for child widgets. We are
              just doing the same than the default path does, and on top of that
              if the widget's window changes (for example, during DnD widgets
              are usually unrealized/realized) the child widget will we left
              pointing to a dead window.
      
              For examples of crashers caused by this see
              https://bugzilla.gnome.org/show_bug.cgi?id=596397 and
              https://bugzilla.gnome.org/show_bug.cgi?id=596398
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_container_add):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e99dfc8b
    • eric@webkit.org's avatar
      2009-09-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> · 29b4afde
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Fix typo in Localizations.cpp
      
              https://bugs.webkit.org/show_bug.cgi?id=29872
      
              * platform/qt/Localizations.cpp:
              (WebCore::localizedMediaControlElementHelpText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29b4afde
    • hausmann@webkit.org's avatar
      Make the XSLT conditional in DOMWindow.idl's xsltProcessor · 7d63f8f2
      hausmann@webkit.org authored
      attribute conditional in the generated files, similar to
      r44116.
      
      Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-29
      Reviewed by Tor Arne Vestbø.
      
      * page/DOMWindow.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d63f8f2
    • zoltan@webkit.org's avatar
      2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu> · 541d94f9
      zoltan@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Fix time measurement in build-webkit after refactoring done in r48853.
      
              * Scripts/build-webkit:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      541d94f9
    • vestbo@webkit.org's avatar
      [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard. · 6fa1358e
      vestbo@webkit.org authored
      This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
      
      Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-29
      Reviewed by Tor Arne Vestbø.
      
      Done together with Renata Hodovan <renata.hodovan@stud.u-szeged.hu>
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fa1358e
    • hausmann@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=29844 · f752331f
      hausmann@webkit.org authored
      Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-09-29
      Reviewed by Simon Hausmann.
      
      QWebPage dependency autotest fix.
      
      Fix for database() autotest. All opened databases should be removed at
      end of test.
      
      * tests/qwebpage/tst_qwebpage.cpp:
      (tst_QWebPage::database):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f752331f