1. 01 Feb, 2012 40 commits
    • mhahnenberg@apple.com's avatar
      Replace JSArray destructor with finalizer · 59415ea5
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77488
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      * JavaScriptCore.exp:
      * runtime/JSArray.cpp:
      (JSC::JSArray::finalize): Added finalizer.
      (JSC::JSArray::allocateSparseMap): Factored out code for allocating new sparse maps.
      (JSC):
      (JSC::JSArray::deallocateSparseMap): Factored out code for deallocating sparse maps.
      (JSC::JSArray::enterDictionaryMode): Renamed enterSparseMode to enterDictionaryMode 
      because the old name was confusing because we could have a sparse array that never 
      called enterSparseMode.
      (JSC::JSArray::defineOwnNumericProperty):
      (JSC::JSArray::setLengthWritable):
      (JSC::JSArray::putByIndexBeyondVectorLength):
      (JSC::JSArray::setLength):
      (JSC::JSArray::pop):
      (JSC::JSArray::sort):
      (JSC::JSArray::compactForSorting):
      * runtime/JSArray.h:
      (JSArray):
      
      LayoutTests: 
      
      * fast/js/script-tests/sparse-array.js: Added code to test oscillation between 
      sparse and dense arrays.
      * fast/js/sparse-array-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59415ea5
    • rniwa@webkit.org's avatar
      Gcc build fix after r106482. · a940bf03
      rniwa@webkit.org authored
      * platform/graphics/ca/GraphicsLayerCA.h:
      (GraphicsLayerCA):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a940bf03
    • commit-queue@webkit.org's avatar
      rebaseline box-shadow-clipped-slices · 2046f4e3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77565
      
      Patch by Elliot Poger <epoger@google.com> on 2012-02-01
      Reviewed by Stephen White.
      
      * platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
      * platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2046f4e3
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=77383 · 3ab37375
      bdakin@apple.com authored
      Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
      -and corresponding-
      <rdar://problem/10709560>
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      The goal is to re-vamp didFirstVisuallyNonEmptyLayout to be more accurate. 
      This patch adds a new heuristic called didNewFirstVisuallNonEmptyLayout and 
      leaves the old one for the time being. That is temporary.
      
      The heuristic for didNewFirstVisuallNonEmptyLayout is to count relevant 
      painted RenderObjects on Page.
      * page/Page.cpp:
      (WebCore::Page::Page):
      (WebCore::Page::setPaintedObjectsCounterThreshold):
      (WebCore::Page::addRelevantRepaintedObject):
      * page/Page.h:
      (WebCore):
      (Page):
      (WebCore::Page::startCountingRepaintedObjects):
      * WebCore.exp.in:
      
      Start counting relevant painted RenderObjects on the page once the first 
      layout is complete.
      * page/FrameView.cpp:
      (WebCore::FrameView::performPostLayoutTasks):
      
      Machinery for firing didNewFirstVisuallNonEmptyLayout.
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::didNewFirstVisuallyNonEmptyLayout):
      (WebCore):
      * loader/FrameLoader.h:
      (FrameLoader):
      * loader/FrameLoaderClient.h:
      (WebCore::FrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout):
      
      These RenderObjects are the ones that this api currently consider to be 
      relevant. If their repaint rects intersect with the viewRect, then they are 
      added to the relevant objects set on the Page.
      * rendering/InlineBox.cpp:
      (WebCore::InlineBox::paint):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paint):
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::paintReplaced):
      * rendering/RenderHTMLCanvas.cpp:
      (WebCore::RenderHTMLCanvas::paintReplaced):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::paintReplaced):
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::paintReplaced):
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::paint):
      * rendering/RenderVideo.cpp:
      (WebCore::RenderVideo::paintReplaced):
      * rendering/svg/RenderSVGRoot.cpp:
      (WebCore::RenderSVGRoot::paintReplaced):
      
      Source/WebKit2: 
      
      Machinery for didNewFirstVisuallNonEmptyLayout.
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebLoaderClient.cpp:
      (WebKit::WebLoaderClient::didNewFirstVisuallyNonEmptyLayout):
      (WebKit):
      * UIProcess/WebLoaderClient.h:
      (WebLoaderClient):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::didNewFirstVisuallyNonEmptyLayout):
      (WebKit):
      * UIProcess/WebPageProxy.h:
      (WebPageProxy):
      * UIProcess/WebPageProxy.messages.in:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout):
      (WebKit):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      (WebFrameLoaderClient):
      
      This temporary API allows the client to specify the threshold for the painted 
      objects counter on Page. This is temporary.
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      (WKBundlePageSetPaintedObjectsCounterThreshold):
      * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::setPaintedObjectsCounterThreshold):
      (WebKit):
      * WebProcess/WebPage/WebPage.h:
      (WebPage):
      
      Tools: 
      
      WebKit2's WebLoaderClient has a temporary new function that must be accounted 
      for.
      * MiniBrowser/mac/BrowserWindowController.m:
      (-[BrowserWindowController awakeFromNib]):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::initialize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ab37375
    • alexis.menard@openbossa.org's avatar
      CSSStyleDeclaration.getPropertyPriority() fails for CSS shorthand properties... · a0ad1dc5
      alexis.menard@openbossa.org authored
      CSSStyleDeclaration.getPropertyPriority() fails for CSS shorthand properties with 'important' priority
      https://bugs.webkit.org/show_bug.cgi?id=49058
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      CSSMutableStyleDeclaration::getPropertyPriority was not handling shorthands properly. Shorthands are
      not part of the property list of the style so we need to query the longhands which are the one added
      in the list. Only if the longhands have equal priority the shorthand priority is known. I also renamed
      getPropertyPriority (not the CSSOM exposed method) to something more consistent with WebKit naming guidelines.
      
      Test: fast/css/shorthand-priority.html
      
      * css/CSSMutableStyleDeclaration.cpp:
      (WebCore::CSSMutableStyleDeclaration::propertyIsImportant):
      (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
      (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
      * css/CSSMutableStyleDeclaration.h:
      (CSSMutableStyleDeclaration):
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::extractAndRemoveTextDirection):
      (WebCore::EditingStyle::collapseTextDecorationProperties):
      (WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
      (WebCore::setTextDecorationProperty):
      * editing/RemoveCSSPropertyCommand.cpp:
      (WebCore::RemoveCSSPropertyCommand::doApply):
      
      Source/WebKit/qt:
      
      Update the code as getPropertyPriority has been renamed to propertyIsImportant.
      
      * Api/qwebelement.cpp:
      (QWebElement::styleProperty):
      
      LayoutTests:
      
      * fast/css/shorthand-priority-expected.txt: Added.
      * fast/css/shorthand-priority.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0ad1dc5
    • rniwa@webkit.org's avatar
      Crash in EventHandler::updateDragAndDrop · c2911183
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77569
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore: 
      
      Test: fast/events/remove-target-with-shadow-in-drag.html
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::updateDragAndDrop):
      
      LayoutTests: 
      
      * fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
      * fast/events/remove-target-with-shadow-in-drag.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2911183
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r106382. · aa320ecd
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/106382
      https://bugs.webkit.org/show_bug.cgi?id=77571
      
      Causing chromium crashes in PNGImageDecoder (Requested by
      japhet on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-01
      
      Source/WebCore:
      
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::evaluate):
      * page/Console.cpp:
      (WebCore::Console::time):
      (WebCore::Console::timeEnd):
      * platform/chromium/PlatformSupport.h:
      * platform/chromium/TraceEvent.h:
      (internal):
      (ScopeTracer):
      (WebCore::internal::ScopeTracer::ScopeTracer):
      (WebCore::internal::ScopeTracer::~ScopeTracer):
      
      Source/WebKit/chromium:
      
      * public/platform/WebKitPlatformSupport.h:
      (WebKitPlatformSupport):
      (WebKit::WebKitPlatformSupport::isTraceEventEnabled):
      (WebKit::WebKitPlatformSupport::traceEventBegin):
      (WebKit::WebKitPlatformSupport::traceEventEnd):
      * src/PlatformSupport.cpp:
      (WebCore::PlatformSupport::isTraceEventEnabled):
      (WebCore):
      (WebCore::PlatformSupport::traceEventBegin):
      (WebCore::PlatformSupport::traceEventEnd):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa320ecd
    • andersca@apple.com's avatar
      Reviewed by Darin Adler. · 7cb5af26
      andersca@apple.com authored
      Simplify the code that creates a new tile layer by getting a reference to the RetainPtr<WebTileLayer>&
      slot in the hash map and assign directly into it.
      
      * platform/graphics/ca/mac/TileCache.mm:
      (WebCore::TileCache::revalidateTiles):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cb5af26
    • andersca@apple.com's avatar
      Tile cache doesn't have an upper limit · 048a097c
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77564
      <rdar://problem/10710744>
      
      Reviewed by Darin Adler.
      
      Cache enough tiles to cover 3x the visible height and 2x the visible width of the page,
      and drop tiles that are outside that area.
      
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
      Call GraphicsLayerClient::notifySyncRequired here, which will schedule a layer flush and ensure that
      the page layout is up to date before the new tiles are painted.
      
      * platform/graphics/ca/PlatformCALayerClient.h:
      Add platformCALayerDidCreateTiles member function.
      
      * platform/graphics/ca/mac/TileCache.h:
      Update for new/removed member functions and member variables.
      
      * platform/graphics/ca/mac/TileCache.mm:
      (WebCore::TileCache::TileCache):
      Initialize the tile revalidation timer.
      
      (WebCore::TileCache::tileCacheLayerBoundsChanged):
      If we don't have any tiles at all right now, revalidate the tiles immediately. Otherwise,
      schedule the revalidation timer.
      
      (WebCore::TileCache::setNeedsDisplayInRect):
      Return early if we have no tiles.
      
      (WebCore::TileCache::visibleRectChanged):
      Schedule tile revalidation.
      
      (WebCore::TileCache::rectForTileIndex):
      New helper function that returns the bounds rect of a tile given its tile index.
      
      (WebCore::TileCache::getTileIndexRangeForRect):
      Clamp the rect to the bounds of the tile cache layer.
      
      (WebCore::TileCache::scheduleTileRevalidation):
      Schedule the revalidation timer if it hasn't already been scheduled.
      
      (WebCore::TileCache::tileRevalidationTimerFired):
      Call revalidateTiles.
      
      (WebCore::TileCache::revalidateTiles):
      Compute the tile coverage rect and remove all tiles that are outside. Create new tiles for any
      parts of the tile coverage rect that don't have tiles already.
      
      (WebCore::TileCache::tileLayerAtIndex):
      Remove invalid assertions.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      048a097c
    • dpranke@chromium.org's avatar
      TestWebKitAPI isn't being built on chromium bots any more · af584710
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77563
      
      Reviewed by Dimitri Glazkov.
      
      I accidentally dropped it in the refactoring in r105449.
      
      Source/WebKit/chromium:
      
      * All.gyp:
      
      Tools:
      
      * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af584710
    • commit-queue@webkit.org's avatar
      Fixed some lines in the date-constructor.js test. · 5dd72ec9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75892
      
      Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2012-02-01
      Reviewed by Gavin Barraclough.
      
      * fast/js/date-constructor-expected.txt:
      * fast/js/script-tests/date-constructor.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dd72ec9
    • commit-queue@webkit.org's avatar
      Source/WebCore: Add support for fixed and percent min-width on the table... · d9af3a83
      commit-queue@webkit.org authored
      Source/WebCore: Add support for fixed and percent min-width on the table element for table-layout: auto to
      match Firefox and Opera's behavior.
      
      In FixedTableLayout.cpp, the computePreferredLogicalWidths method looks like it has
      issues based on the comment: "FIXME: This entire calculation is incorrect for both
      minwidth and maxwidth." (minwidth and maxwidth refer to the preferred widths, not the
      min-width and max-width styles). I have not implemented min-width for FixedTableLayout
      in this patch since it requires some more research around that comment.
      
      min-width and max-width on the table element was discussed on the www-style list:
      http://lists.w3.org/Archives/Public/www-style/2012Jan/0684.html
      
      min-width is not implemented on <table> for table-layout: auto
      https://bugs.webkit.org/show_bug.cgi?id=76553
      
      Patch by Max Vujovic <mvujovic@adobe.com> on 2012-02-01
      Reviewed by Julien Chaffraix.
      
      Test: fast/table/min-width.html
      
      * rendering/AutoTableLayout.cpp:
      (WebCore::AutoTableLayout::computePreferredLogicalWidths):
      
          If the min or max preferred logical width is less than a fixed min width style, it is
          set to the fixed min width style. Like a percent width style, a percent min-width style
          does not affect the min or max preferred logical widths computed by the table layout
          algorithm. RenderTable's computeLogicalWidth method handles percent min-width styles.
      
          min-width for the table-layout: fixed case has been split out into this bug:
          https://bugs.webkit.org/show_bug.cgi?id=76948
      
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::computeLogicalWidth):
      
          If the RenderStyle's logical min width is defined and greater than the logical width
          calculation, this method sets the logical width to the logical min width.
      
      (WebCore::RenderTable::convertStyleWidthToComputedWidth):
      
          This new method generalizes and factors out logic from RenderTable::computeLogicalWidth
          that converted the width style to a computed value in the fixed and percent case.
          RenderTable::computeLogicalWidth now calls this method to determine the computed values
          for both the width style and the min-width style. In the future, it can also be used for
          the max-width style.
      
          Note that this method handles the special CSS table case, which requires borders and
          paddings to be included in the computed width calculation. This applies to all width
          styles, including width, min-width, and max-width. Before, this special case was handled
          in RenderTable::computeLogicalWidth.
      
      * rendering/RenderTable.h:
      
      LayoutTests: Add support for min-width on the table element.
      
      min-width is not implemented on <table> for table-layout: auto
      https://bugs.webkit.org/show_bug.cgi?id=76553
      
      Patch by Max Vujovic <mvujovic@adobe.com> on 2012-02-01
      Reviewed by Julien Chaffraix.
      
      * fast/table/min-width-css-block-table.html: Added.
      * fast/table/min-width-css-block-table-expected.txt: Added.
      * fast/table/min-width-css-inline-table.html: Added.
      * fast/table/min-width-css-inline-table-expected.txt: Added.
      * fast/table/min-width-html-block-table.html: Added.
      * fast/table/min-width-html-block-table-expected.txt: Added.
      * fast/table/min-width-html-inline-table.html: Added.
      * fast/table/min-width-html-inline-table-expected.txt: Added.
      * fast/table/script-tests/min-width-css-block-table.js: Added.
      (computeLogicalWidth):
      * fast/table/script-tests/min-width-css-inline-table.js: Added.
      (computeLogicalWidth):
      * fast/table/script-tests/min-width-helpers.js: Added.
      (runTests):
      (createTableStyle):
      (computeLogicalWidthHelper):
      (createSpan):
      * fast/table/script-tests/min-width-html-block-table.js: Added.
      (computeLogicalWidth):
      * fast/table/script-tests/min-width-html-inline-table.js: Added.
      (computeLogicalWidth):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9af3a83
    • commit-queue@webkit.org's avatar
      Refactor identifier resolution in BytecodeGenerator · 2fea740c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76285
      
      Patch by Andy Wingo <wingo@igalia.com> on 2012-02-01
      Reviewed by Geoffrey Garen.
      
      * bytecompiler/BytecodeGenerator.h:
      (JSC::ResolveResult): New class, to describe the storage
      location corresponding to an identifier in a program.
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::resolve): New function, replacing
      findScopedProperty.
      (JSC::BytecodeGenerator::resolveConstDecl): New function,
      encapsulating what ConstDeclNode::emitBytecode used to do.
      (JSC::BytecodeGenerator::emitGetStaticVar):
      (JSC::BytecodeGenerator::emitPutStaticVar): New functions,
      corresponding to the old emitGetScopedVar and emitPutScopedVar.
      (JSC::BytecodeGenerator::registerFor): Remove version that took an
      Identifier&; replaced by ResolveResult::local().
      (JSC::BytecodeGenerator::emitResolve):
      (JSC::BytecodeGenerator::emitResolveBase):
      (JSC::BytecodeGenerator::emitResolveBaseForPut):
      (JSC::BytecodeGenerator::emitResolveWithBase):
      (JSC::BytecodeGenerator::emitResolveWithThis): Change to accept a
      "resolveResult" argument.  This is more clear, and reduces the
      amount of double analysis happening at compile-time.
      * bytecompiler/NodesCodegen.cpp:
      (JSC::ResolveNode::emitBytecode):
      (JSC::EvalFunctionCallNode::emitBytecode):
      (JSC::FunctionCallResolveNode::emitBytecode):
      (JSC::PostfixResolveNode::emitBytecode):
      (JSC::DeleteResolveNode::emitBytecode):
      (JSC::TypeOfResolveNode::emitBytecode):
      (JSC::PrefixResolveNode::emitBytecode):
      (JSC::ReadModifyResolveNode::emitBytecode):
      (JSC::AssignResolveNode::emitBytecode):
      (JSC::ConstDeclNode::emitCodeSingle):
      (JSC::ForInNode::emitBytecode): Refactor to use the new
      ResolveResult structure.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fea740c
    • commit-queue@webkit.org's avatar
      [SKIA/CHROMIUM] Perform getImageData format conversions using Skia · 7eb879ce
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77553
      
      Patch by Brian Salomon <bsalomon@google.com> on 2012-02-01
      Reviewed by Stephen White.
      
      Source/WebCore:
      
      Many existing canvas tests exercise this functionality.
      
      * platform/graphics/skia/ImageBufferSkia.cpp:
      (WebCore::getImageData):
      
      LayoutTests:
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eb879ce
    • japhet@chromium.org's avatar
      Source/WebCore: preventDefault() in a mousedown in a subframe should not · 0ca3560a
      japhet@chromium.org authored
      prevent the scrollbar from handling mouse movements if the
      cursor leaves the subframe.
      https://bugs.webkit.org/show_bug.cgi?id=73097
      
      Reviewed by Darin Adler.
      
      Test: fast/events/scroll-div-with-prevent-default-in-subframe.html
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent):
      
      LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=73097.
      Test adapted from repro case provided by zacklloyd@google.com.
      
      Reviewed by Darin Adler.
      
      * fast/events/resources/subframe-with-scrollable-div.html: Added.
      * fast/events/scroll-div-with-prevent-default-in-subframe-expected.txt: Added.
      * fast/events/scroll-div-with-prevent-default-in-subframe.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ca3560a
    • hans@chromium.org's avatar
      Rename WebSpeechInputResult::set() to assign() · eb23bd92
      hans@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77540
      
      Reviewed by Darin Fisher.
      
      Source/WebKit/chromium:
      
      It was suggested in a previous code review
      (https://bugs.webkit.org/show_bug.cgi?id=77083#c5)
      that this function should be called assign().
      
      * public/WebSpeechInputResult.h:
      (WebSpeechInputResult):
      (WebKit::WebSpeechInputResult::set):
      * src/WebSpeechInputResult.cpp:
      (WebKit::WebSpeechInputResult::assign):
      
      Tools:
      
      * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
      (MockWebSpeechInputController::addMockRecognitionResult):
      (MockWebSpeechInputController::speechTaskFired):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb23bd92
    • carlosgc@webkit.org's avatar
      [GTK] WebKit1 API documentation is not generated when building with gtk-2.0 · 7bd5597c
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77542
      
      Reviewed by Martin Robinson.
      
      * gtk/generate-gtkdoc: Check first whether there's
      webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
      instead.
      (get_webkit2_options): Return just the options since the
      pkg_config_path doesn't depend on options
      (get_webkit1_options): Ditto.
      (generate_doc): Helper function to create a generator and generate
      documentation for the given pkg-config file with the given options.
      * gtk/gtkdoc.py:
      (GTKDoc.__init__): Don't use ** for args parameter, since it's
      used as a dict and never expanded.
      (PkgConfigGTKDoc.__init__): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bd5597c
    • carlosgc@webkit.org's avatar
      [GTK] API documentation is not installed even when building with --enable-gtk-doc · 1ce5767b
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77094
      
      Reviewed by Martin Robinson.
      
      * GNUmakefile.am: Add install-data-local and uninstall-local rules
      to install/uninstall WebKit1 and WebKit2 API documentation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ce5767b
    • mario@webkit.org's avatar
      [GTK] editing/inserting/4960120-2.html flaky crash · b311bdbb
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76815
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Check if the node for the first parent object not ignoring
      accessibility is null before using it. This might happen with
      certain kind of accessibility objects, such as the root one (the
      scroller containing the webArea object as its only child).
      
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (objectFocusedAndCaretOffsetUnignored): Add missing null check.
      
      LayoutTests:
      
      * platform/gtk/test_expectations.txt: Unskipping tests that
      shouldn't be crashing from now on.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b311bdbb
    • antti@apple.com's avatar
      Make CSSMappedAttributeDeclaration have CSSMutableStyleDeclaration instead of being one · 8ec6b57d
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=77545
      
      Reviewed by Andreas Kling.
      
      This is the easiest path for eliminating the last remaining subclass of CSSMutableStyleDeclaration.
              
      On negative side this increases memory use of CSSMappedAttributeDeclaration by one ptr and refcount
      (it loses the vptr) in total.
              
      This is not meant to be the end state, just an intermediate refactoring step. CSSMappedAttributeDeclaration
      should clearly be renamed too but this patch doesn't do that. It might not exist in its current form
      much longer.
      
      * css/CSSMutableStyleDeclaration.cpp:
      (WebCore::CSSMutableStyleDeclaration::setProperty):
      (WebCore::CSSMutableStyleDeclaration::merge):
      * css/CSSMutableStyleDeclaration.h:
      
          Remove protected section. No subclasses remain.        
          Rename setPropertyInternal() to setProperty(). All public methods here are internal.
              
      (CSSMutableStyleDeclaration):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseMappedAttributeValue):
      * dom/Attribute.cpp:
      (WebCore::Attribute::clone):
      * dom/Attribute.h:
      (Attribute):
      (WebCore::Attribute::decl):
      (WebCore::Attribute::mappedAttributeDeclaration):
      (WebCore::Attribute::setMappedAttributeDeclaration):
      (WebCore::Attribute::Attribute):
      * dom/CSSMappedAttributeDeclaration.cpp:
      (WebCore::CSSMappedAttributeDeclaration::setMappedImageProperty):
      (WebCore::CSSMappedAttributeDeclaration::setMappedProperty):
      (WebCore::CSSMappedAttributeDeclaration::removeMappedProperty):
      * dom/CSSMappedAttributeDeclaration.h:
      (CSSMappedAttributeDeclaration):
      (WebCore::CSSMappedAttributeDeclaration::declaration):
      (WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
              
          Make CSSMutableStyleDeclaration a member instead of the base class.
              
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::attributeChanged):
      (WebCore::StyledElement::removeCSSProperty):
      (WebCore::StyledElement::addCSSProperty):
      (WebCore::StyledElement::addCSSImageProperty):
      (WebCore::StyledElement::addCSSLength):
      (WebCore::StyledElement::addCSSColor):
      (WebCore::StyledElement::createMappedDecl):
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::getPresentationAttribute):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ec6b57d
    • commit-queue@webkit.org's avatar
      [Qt] Set all PlatformTouchPoint values possible from a QTouch event. · 5f816066
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77442
      
      Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-01
      Reviewed by Kenneth Rohde Christiansen.
      
      * platform/qt/PlatformTouchPointQt.cpp:
      (WebCore::PlatformTouchPoint::PlatformTouchPoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f816066
    • commit-queue@webkit.org's avatar
      Web Inspector: CodeGeneratorInspector.py: move type builder code to dedicated... · abdef28d
      commit-queue@webkit.org authored
      Web Inspector: CodeGeneratorInspector.py: move type builder code to dedicated InspectorTypeBuilder .h/.cpp
      https://bugs.webkit.org/show_bug.cgi?id=77471
      
      Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-01
      Reviewed by Yury Semikhatsky.
      
      Code is moved physically to other file -- generator is changed accrodingly.
      
      * inspector/CodeGeneratorInspector.py:
      (String):
      (provides):
      (typename):
      (Array):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abdef28d
    • yurys@chromium.org's avatar
      Web Inspector: debugger reports wrong sources when paused in inline script on page reload · d6b250d8
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77548
      
      Source/WebCore:
      
      V8 returns treats each script source as ending with \n, now we take
      this into account when reporting script line count to the inspector
      front-end.
      
      Reviewed by Vsevolod Vlasov.
      
      Test: inspector/debugger/pause-in-inline-script.html
      
      * bindings/js/ScriptDebugServer.cpp:
      (WebCore::ScriptDebugServer::dispatchDidParseSource):
      * bindings/v8/DebuggerScript.js:
      
      LayoutTests:
      
      Reviewed by Vsevolod Vlasov.
      
      * inspector/debugger/debugger-scripts-expected.txt:
      * inspector/debugger/pause-in-inline-script-expected.txt: Added.
      * inspector/debugger/pause-in-inline-script.html: Added.
      * platform/chromium/inspector/debugger/debugger-scripts-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6b250d8
    • commit-queue@webkit.org's avatar
      [GTK] unittests/testloading crashes · c14b6641
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77544
      
      Patch by Philippe Normand <pnormand@igalia.com> on 2012-02-01
      Reviewed by Xan Lopez.
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchDidFailLoading): Bail out
      early from dispatchDidFailLoading if the error is the result of an
      interrupted load.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c14b6641
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r106460. · 06f08926
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/106460
      https://bugs.webkit.org/show_bug.cgi?id=77552
      
      It break unit tests if WEBKIT_TESTFONTS isn't defined.
      (Requested by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-01
      
      * Scripts/webkitpy/layout_tests/port/qt.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06f08926
    • commit-queue@webkit.org's avatar
      Content element should be able to be dynamically added/removed/replaced in a shadow tree. · bcd7e04d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76611
      
      Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-01
      Reviewed by Hajime Morita
      
      Source/WebCore:
      
      When a content element is added/removed/replaced in a shadow tree, we have to recreate
      the shadow tree to recalculate inclusions of content elements. Currently we didn't recalculate it
      when content element is removed. (When added, it is recalculated.)
      This patch enables us to recalcurate the shadow tree when content element is removed.
      
      Test: fast/dom/shadow/content-element-move.html
      
      * dom/Element.cpp:
      (WebCore::Element::attach):
        If a shadow root exists, attaches shadow tree before attaching child elements.
      * dom/ShadowRoot.cpp:
        Added a flag to recalculate shadow tree.
      (WebCore::ShadowRoot::ShadowRoot):
      (WebCore::ShadowRoot::recalcShadowTreeStyle):
        Recalculates light children and shadow tree.
      (WebCore::ShadowRoot::setNeedsReattachHostChildrenAndShadow):
      (WebCore::ShadowRoot::reattachHostChildrenAndShadow):
        Detaches shadow tree and host light children, and attaches them again.
      * dom/ShadowRoot.h:
      (WebCore::ShadowRoot::clearNeedsReattachHostChildrenAndShadow):
      (WebCore::ShadowRoot::needsReattachHostChildrenAndShadow):
      * html/shadow/HTMLContentElement.cpp:
      (WebCore::HTMLContentElement::attach):
        Does not need to detach included elements, because they are not attached in ContainerNode anymore.
      (WebCore::HTMLContentElement::detach):
        When a content element detached, reattaches a shadow tree.
      
      LayoutTests:
      
      Test cases for appending/removing/replacing content element in a shadow tree.
      
      * fast/dom/shadow/content-element-move-expected.txt: Added.
      * fast/dom/shadow/content-element-move.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcd7e04d
    • peter@chromium.org's avatar
      getIntersectionList causes transforms to be recalculated in SVG · a37205fe
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77179
      
      Reviewed by Nikolas Zimmermann.
      
      Introduce a local variable to store the element's local-to-parent
      transformation matrix in, removing the need for the const_cast and
      stopping us from modifying any matrices elsewhere.
      
      Source/WebCore:
      
      Test: svg/custom/intersection-list-transforms.svg
      
      * rendering/svg/RenderSVGModelObject.cpp:
      (WebCore::getElementCTM):
      
      LayoutTests:
      
      * svg/custom/intersection-list-transforms-expected.png: Added.
      * svg/custom/intersection-list-transforms-expected.txt: Added.
      * svg/custom/intersection-list-transforms.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a37205fe
    • vsevik@chromium.org's avatar
      Web Inspector: [InspectorIndexedDB] Add tests for database names and database structure requests. · 69d492df
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77439
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Tests: http/tests/inspector/indexeddb/database-names.html
             http/tests/inspector/indexeddb/database-structure.html
      
      * inspector/front-end/IndexedDBModel.js:
      (WebInspector.IndexedDBModel.prototype.refreshDatabase):
      
      LayoutTests:
      
      * http/tests/inspector/indexeddb/database-names-expected.txt: Added.
      * http/tests/inspector/indexeddb/database-names.html: Added.
      * http/tests/inspector/indexeddb/database-structure-expected.txt: Added.
      * http/tests/inspector/indexeddb/database-structure.html: Added.
      * http/tests/inspector/indexeddb/indexeddb-test.js: Added.
      * platform/gtk/Skipped:
      * platform/mac-leopard/Skipped:
      * platform/mac-snowleopard/Skipped:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69d492df
    • vsevik@chromium.org's avatar
      Web Inspector: Scripts navigator becomes empty after "show folders" settings change. · 6f54172b
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77441
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/ScriptsNavigator.js:
      (WebInspector.ScriptsNavigator.prototype._reset):
      * inspector/front-end/utilities.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f54172b
    • commit-queue@webkit.org's avatar
      [Qt] Automatic clean build feature always do clean build with --no-webkit2 · f2650bf5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74519
      
      Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-02-01
      Reviewed by Tor Arne Vestbø.
      
      Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
      
      * qmake/mkspecs/features/features.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2650bf5
    • commit-queue@webkit.org's avatar
      [Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set · c0468a70
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77466
      
      Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-02-01
      Reviewed by Kenneth Rohde Christiansen.
      
      Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
      is set or if we should raise an error.
      
      * Scripts/webkitpy/layout_tests/port/qt.py:
      (QtPort.setup_environ_for_server):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0468a70
    • shawnsingh@chromium.org's avatar
      Fix the semantics of passing contentsVisible flag to GraphicsLayers · 976a6086
      shawnsingh@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76975
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      This patch is covered by existing tests, in particular
      compositing/visibility/layer-visible-content.html; its
      expectations are rebaselined.
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
      
      LayoutTests:
      
      * compositing/visibility/layer-visible-content-expected.txt: rebaselined expected result
      * compositing/visibility/layer-visible-content.html: fixed height so that result is platform-independent
      * platform/chromium/test_expectations.txt: removed fail expectation, it should pass now.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      976a6086
    • philn@webkit.org's avatar
      Unreviewed, GTK rebaseline after r106445 · 6c306437
      philn@webkit.org authored
      * platform/gtk/security/block-test-expected.txt:
      * platform/gtk/security/block-test-no-port-expected.txt:
      * platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c306437
    • ossy@webkit.org's avatar
      [WK2] Unreviewed gardening after r106426. · bc0a98f0
      ossy@webkit.org authored
      Skip new failing tests because of missing layoutTestController.dumpResourceResponseMIMETypes().
      https://bugs.webkit.org/show_bug.cgi?id=42543
      
      * platform/qt-wk2/Skipped: Remove a test also skipped in wk2/Skipped.
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc0a98f0
    • philn@webkit.org's avatar
      Unreviewed, another GTK build fix after r106446. · 9e3f5d1e
      philn@webkit.org authored
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      Restore webKitWebSrcGetProtocols as it was before r106446.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e3f5d1e
    • yuzo@google.com's avatar
      [Chromium] Unreviewed test expectaion change. · fafd1a32
      yuzo@google.com authored
      plugins/createScriptableObject-before-start.html is flaky on LINUX.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fafd1a32
    • ossy@webkit.org's avatar
      Implement Error.stack · 0d2b6111
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66994
      
      Unreviewed, rolling out r106407.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * interpreter/AbstractPC.cpp:
      (JSC::AbstractPC::AbstractPC):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::throwException):
      * interpreter/Interpreter.h:
      (JSC):
      (Interpreter):
      * jsc.cpp:
      (GlobalObject::finishCreation):
      * parser/Parser.h:
      (JSC::::parse):
      * runtime/CommonIdentifiers.h:
      * runtime/Error.cpp:
      (JSC::addErrorInfo):
      * runtime/Error.h:
      (JSC):
      
      LayoutTests:
      
      * fast/js/exception-properties-expected.txt:
      * fast/js/script-tests/exception-properties.js:
      * fast/js/script-tests/stack-trace.js: Removed.
      * fast/js/stack-trace-expected.txt: Removed.
      * fast/js/stack-trace.html: Removed.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d2b6111
    • yuzo@google.com's avatar
      [Chromium] Unreviewed test expectaion change. · 9a127f65
      yuzo@google.com authored
      media/controls-drag-timebar.html passes or times out on WIN and LINUX.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a127f65
    • philn@webkit.org's avatar
      Unreviewed, GTK build fix after r106446. · 21f0b9a1
      philn@webkit.org authored
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21f0b9a1
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r106432. · c0c4c872
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/106432
      https://bugs.webkit.org/show_bug.cgi?id=77529
      
      it breaks tests (Requested by shinyak on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-01
      
      Source/WebCore:
      
      * dom/Element.cpp:
      (WebCore::Element::attach):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::recalcShadowTreeStyle):
      * dom/ShadowRoot.h:
      (ShadowRoot):
      * html/shadow/HTMLContentElement.cpp:
      (WebCore::HTMLContentElement::attach):
      (WebCore::HTMLContentElement::detach):
      
      LayoutTests:
      
      * fast/dom/shadow/content-element-move-expected.txt: Removed.
      * fast/dom/shadow/content-element-move.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0c4c872