1. 04 Apr, 2011 40 commits
    • oliver@apple.com's avatar
      2011-04-01 Oliver Hunt <oliver@apple.com> · 59144210
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Make StructureChain GC allocated
              https://bugs.webkit.org/show_bug.cgi?id=56695
      
              Make StructureChain GC allocated, and make the various owners
              mark it correctly.
      
              * JavaScriptCore.exp:
              * bytecode/CodeBlock.cpp:
              (JSC::CodeBlock::dump):
              (JSC::CodeBlock::derefStructures):
              (JSC::CodeBlock::refStructures):
              (JSC::CodeBlock::markAggregate):
              * bytecode/Instruction.h:
              (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
              (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
              (JSC::PolymorphicAccessStructureList::derefStructures):
              (JSC::PolymorphicAccessStructureList::markAggregate):
              (JSC::Instruction::Instruction):
              * bytecode/StructureStubInfo.cpp:
              (JSC::StructureStubInfo::deref):
              (JSC::StructureStubInfo::markAggregate):
              * bytecode/StructureStubInfo.h:
              (JSC::StructureStubInfo::initGetByIdChain):
              (JSC::StructureStubInfo::initPutByIdTransition):
              * bytecompiler/BytecodeGenerator.cpp:
              (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
              (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
              * collector/handles/Handle.h:
              (JSC::HandleConverter::operator->):
              (JSC::HandleConverter::operator*):
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::privateExecute):
              * jit/JITOpcodes.cpp:
              (JSC::JIT::emit_op_jneq_ptr):
              * jit/JITOpcodes32_64.cpp:
              (JSC::JIT::emit_op_jneq_ptr):
              * jit/JITPropertyAccess.cpp:
              (JSC::JIT::privateCompileGetByIdChainList):
              * jit/JITPropertyAccess32_64.cpp:
              (JSC::JIT::privateCompileGetByIdChainList):
              * jit/JITStubs.cpp:
              (JSC::JITThunks::tryCachePutByID):
              (JSC::JITThunks::tryCacheGetByID):
              (JSC::getPolymorphicAccessStructureListSlot):
              (JSC::DEFINE_STUB_FUNCTION):
              * runtime/JSCell.h:
              * runtime/JSGlobalData.cpp:
              (JSC::JSGlobalData::JSGlobalData):
              * runtime/JSGlobalData.h:
              * runtime/JSGlobalObject.cpp:
              (JSC::markIfNeeded):
              * runtime/JSGlobalObject.h:
              (JSC::Structure::prototypeChain):
              * runtime/JSObject.h:
              (JSC::JSObject::putDirectInternal):
              (JSC::JSObject::markChildrenDirect):
              * runtime/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::create):
              (JSC::JSPropertyNameIterator::get):
              (JSC::JSPropertyNameIterator::markChildren):
              * runtime/JSPropertyNameIterator.h:
              (JSC::JSPropertyNameIterator::setCachedPrototypeChain):
              * runtime/JSZombie.cpp:
              (JSC::JSZombie::leakedZombieStructure):
              * runtime/JSZombie.h:
              * runtime/MarkStack.h:
              (JSC::MarkStack::append):
              * runtime/MarkedBlock.cpp:
              (JSC::MarkedBlock::sweep):
              * runtime/Structure.cpp:
              (JSC::Structure::addPropertyTransition):
              * runtime/Structure.h:
              (JSC::Structure::markAggregate):
              * runtime/StructureChain.cpp:
              (JSC::StructureChain::StructureChain):
              (JSC::StructureChain::~StructureChain):
              (JSC::StructureChain::markChildren):
              * runtime/StructureChain.h:
              (JSC::StructureChain::create):
              (JSC::StructureChain::createStructure):
              * runtime/WriteBarrier.h:
              (JSC::WriteBarrierBase::get):
              (JSC::WriteBarrierBase::operator*):
              (JSC::WriteBarrierBase::operator->):
      2011-04-01  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Make StructureChain GC allocated
              https://bugs.webkit.org/show_bug.cgi?id=56695
      
              Update for new Structure marking function
      
              * bindings/js/JSDOMGlobalObject.cpp:
              (WebCore::JSDOMGlobalObject::markChildren):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59144210
    • commit-queue@webkit.org's avatar
      2011-04-04 Chang Shu <cshu@webkit.org> · cb7a066b
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
              https://bugs.webkit.org/show_bug.cgi?id=57572
      
              Unskip passed tests.
      
              * platform/mac-wk2/Skipped:
      2011-04-04  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
              https://bugs.webkit.org/show_bug.cgi?id=57572
      
              * Shared/WebPreferencesStore.cpp:
              (WebKit::WebPreferencesStore::decode):
              (WebKit::WebPreferencesStore::overrideAllowFileAccessFromFileURLsForTestRunner):
              * Shared/WebPreferencesStore.h:
              * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
              (WKBundleSetAllowFileAccessFromFileURLs):
              * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
              * WebProcess/InjectedBundle/InjectedBundle.cpp:
              (WebKit::InjectedBundle::setAllowFileAccessFromFileURLs):
              * WebProcess/InjectedBundle/InjectedBundle.h:
      2011-04-04  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
              https://bugs.webkit.org/show_bug.cgi?id=57572
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb7a066b
    • pfeldman@chromium.org's avatar
      2011-04-04 Pavel Feldman <pfeldman@google.com> · 7d66a478
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: add support for the enumerated types in the protocol.
              https://bugs.webkit.org/show_bug.cgi?id=57761
      
              * inspector/debugger/debugger-autocontinue-on-syntax-error.html:
              * inspector/debugger/debugger-pause-on-exception.html:
      2011-04-04  Pavel Feldman  <pfeldman@google.com>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: add support for the enumerated types in the protocol.
              https://bugs.webkit.org/show_bug.cgi?id=57761
      
              * inspector/Inspector.json:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::scriptImportedImpl):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::cachedResourceTypeString):
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::setInitialScriptContent):
              (WebCore::InspectorResourceAgent::setInitialXHRContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/front-end/ScriptsPanel.js:
              * inspector/generate-inspector-idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d66a478
    • commit-queue@webkit.org's avatar
      2011-04-04 Jon Lee <jonlee@apple.com> · d2624724
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              add some directories to .gitignore (and svn:ignore) when opening projects in xcode4
              https://bugs.webkit.org/show_bug.cgi?id=57646
      
              * .gitignore: added xcode 4 related project and workspace directories that are not needed for checkin
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2624724
    • yurys@chromium.org's avatar
      2011-04-04 Yury Semikhatsky <yurys@chromium.org> · 3a661699
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: InspectorRuntimeAgent should not depend on Page
              https://bugs.webkit.org/show_bug.cgi?id=57759
      
              Descendants of InspectorRuntimeAgent should implement a method providing access to the default
              inspected state used for console evaluations.
      
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent): runtime agent is created and deleted along with other agents.
              (WebCore::InspectorAgent::setFrontend):
              * inspector/InspectorAgent.h:
              * inspector/InspectorRuntimeAgent.cpp:
              (WebCore::InspectorRuntimeAgent::create):
              (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
              (WebCore::InspectorRuntimeAgent::evaluate):
              * inspector/InspectorRuntimeAgent.h:
              (WebCore::InspectorRuntimeAgent::InspectedStateProvider::~InspectedStateProvider):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a661699
    • commit-queue@webkit.org's avatar
      2011-04-04 Keith Kyzivat <keith.kyzivat@nokia.com> · 8626901f
      commit-queue@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              [Qt] DumpRenderTree breaks compilation in some uClibc environments
              https://bugs.webkit.org/show_bug.cgi?id=57602
      
              * DumpRenderTree/qt/main.cpp:
              (get_backtrace):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8626901f
    • commit-queue@webkit.org's avatar
      2011-04-04 Yong Li <yoli@rim.com> · 072ac244
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              https://bugs.webkit.org/show_bug.cgi?id=55969
              Add a test that verifies history scroll position is restored
              when WebKit goes forward from an unreachable URL error page.
              (Error page handling is only supported by Qt DRT.)
      
              * platform/qt/fast/history/back-to-unreachable-url-then-forward-expected.txt: Added.
              * platform/qt/fast/history/back-to-unreachable-url-then-forward.html: Added.
              * platform/qt/fast/history/resources/check-scroll-position.html: Added.
      2011-04-04  Yong Li  <yoli@rim.com>
      
              Reviewed by Antonio Gomes.
      
              https://bugs.webkit.org/show_bug.cgi?id=55969
              Fix the issue that document state is not saved when
              going backward and ending up with error page.
      
              Test: platform/qt/fast/history/back-to-unreachable-url-then-forward.html
      
              (For manual test, load a non-existent html first, then load
              fast/history/resources/check-scroll-position.html, then go
              back and go forward. If it doesn't show "SUCCESS" at the bottom
              of the page, your browser has failed the test)
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::load):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      072ac244
    • kevino@webkit.org's avatar
      90622db4
    • jberlin@webkit.org's avatar
      Remove a test from the win-wk2 skipped list that does not exist. · 29f1c5ad
      jberlin@webkit.org authored
      fast/js/navigator-mimeTypes-length.html was changed and moved to plugins in r71651.
      
      * platform/win-wk2/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29f1c5ad
    • jberlin@webkit.org's avatar
      [Windows 7 WebKit2 Release Tests] 6 tests failing since being removed from the mac-wk2 · d0390ce0
      jberlin@webkit.org authored
      skipped list in r82625.
      https://bugs.webkit.org/show_bug.cgi?id=57705
      
      Unreviewed, addd win-wk2 expected results for the tests in order to get the bots green.
      
      * platform/win-wk2/editing: Added.
      * platform/win-wk2/editing/selection: Added.
      * platform/win-wk2/editing/selection/after-line-break-expected.txt: Added.
      * platform/win-wk2/editing/selection/caret-ltr-right-expected.checksum: Added.
      * platform/win-wk2/editing/selection/caret-ltr-right-expected.png: Added.
      * platform/win-wk2/editing/selection/caret-ltr-right-expected.txt: Added.
      * platform/win-wk2/editing/selection/caret-rtl-2-left-expected.checksum: Added.
      * platform/win-wk2/editing/selection/caret-rtl-2-left-expected.png: Added.
      * platform/win-wk2/editing/selection/caret-rtl-2-left-expected.txt: Added.
      * platform/win-wk2/editing/selection/drag-text-delay-expected.txt: Added.
      * platform/win-wk2/fast/repaint: Added.
      * platform/win-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
      Apparently the pixel results are similar enough to the win expected pixel results that no
      special pixel results need to be added for win-wk2.
      * platform/win-wk2/plugins/resize-from-plugin-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0390ce0
    • beidson@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=57683 · 89402bbf
      beidson@apple.com authored
      Flesh out WK2 Icon Database API
      
      Reviewed by Darin Adler.
      
      For now the new API will add a client interface where the WK1 version used NSNotifications.
      
      If we decide we'd like the granularity of specific callback functions later, 
      they can easily be added on.
      
      Project file nonsense:
      * GNUmakefile.am:
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      
      Add a WKIconDatabaseClient and some new API:
      * UIProcess/API/C/WKIconDatabase.cpp:
      (WKIconDatabaseSetIconDatabaseClient):
      (WKIconDatabaseRemoveAllIcons):
      (WKIconDatabaseCheckIntegrityBeforeOpening):
      * UIProcess/API/C/WKIconDatabase.h:
      * UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
      (WKIconDatabaseTryGetCGImageForURL): Renamed to "try" for subtle clarification.
      * UIProcess/API/C/cg/WKIconDatabaseCG.h:
      
      Implementations for the new APIs:
      * UIProcess/WebIconDatabase.cpp:
      (WebKit::WebIconDatabase::retainIconForPageURL): Remove excessive logging.
      (WebKit::WebIconDatabase::releaseIconForPageURL): Ditto.
      (WebKit::WebIconDatabase::imageForPageURL):
      (WebKit::WebIconDatabase::removeAllIcons):
      (WebKit::WebIconDatabase::checkIntegrityBeforeOpening):
      (WebKit::WebIconDatabase::initializeIconDatabaseClient):
      (WebKit::WebIconDatabase::didImportIconURLForPageURL): Dispatch a client callback,
        much like the WK1 API uses notifications.
      (WebKit::WebIconDatabase::didImportIconDataForPageURL): Ditto.
      (WebKit::WebIconDatabase::didChangeIconForPageURL): Ditto.
      (WebKit::WebIconDatabase::didRemoveAllIcons): Ditto.
      * UIProcess/WebIconDatabase.h:
      * UIProcess/WebIconDatabaseClient.cpp: Added.
      (WebKit::WebIconDatabaseClient::didChangeIconForPageURL):
      (WebKit::WebIconDatabaseClient::didRemoveAllIcons):
      * UIProcess/WebIconDatabaseClient.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89402bbf
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · e995ba0b
      podivilov@chromium.org authored
              Unreviewed, mark filesystem-reference.html as CRASH PASS on chromium.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e995ba0b
    • sergio@webkit.org's avatar
      2011-04-04 Sergio Villar Senin <svillar@igalia.com> · 58391bf8
      sergio@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Fix make distcheck for 1.4.0
              https://bugs.webkit.org/show_bug.cgi?id=57750
      
              Added a missing header file to the Makefile
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58391bf8
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · b5a82530
      podivilov@chromium.org authored
              Unreviewed, remove gradientLimit.svg and 2d.text.draw.align.end.ltr.html from test expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5a82530
    • mrobinson@webkit.org's avatar
      2011-04-04 Martin Robinson <mrobinson@igalia.com> · 28852b71
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] http/tests/plugins/post-url-file.html fails on GTK+
              https://bugs.webkit.org/show_bug.cgi?id=55826
      
              * http/tests/plugins/resources/dump-post.pl: Instead of just printing out the "keywords" parameter,
              print out the POSTDATA parameter as well. Printing "keywords" did not seem to work on the version of
              Apache/Perl/CGI that existed on my machine. According to the Perl CGI module documentation
              using 'POSTDATA' is the correct way to print the entire POSTDATA for more recent versions of the
              module.
              * platform/gtk/Skipped: Unskip the test which is now passing.
      2011-04-04  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] http/tests/plugins/post-url-file.html fails on GTK+
              https://bugs.webkit.org/show_bug.cgi?id=55826
      
              Correct the implementation of handlePostReadFile which uses GIO APIs and
              actually resizes the buffer to fit the entire size of the file data. This
              was likely leading to memory corruption until now.
      
              * plugins/gtk/PluginViewGtk.cpp:
              (WebCore::PluginView::handlePostReadFile): Fix this method.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28852b71
    • caseq@chromium.org's avatar
      2011-04-04 Andrey Kosyakov <caseq@chromium.org> · 49838218
      caseq@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [Extensions API] add notifications on panels shown/hidden
              https://bugs.webkit.org/show_bug.cgi?id=57752
      
              * http/tests/inspector/extensions-test.js:
              (initialize_ExtensionsTest.showPanel):
              * http/tests/inspector/resources/extension-main.js:
              (showPanel):
              * inspector/extensions/extensions-api-expected.txt:
              * inspector/extensions/extensions-events-expected.txt:
              * inspector/extensions/extensions-events.html:
              * inspector/extensions/extensions-expected.txt:
      
      2011-04-04  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [Extensions API] add notifications on panels shown/hidden
              https://bugs.webkit.org/show_bug.cgi?id=57752
      
              * inspector/front-end/ExtensionAPI.js:
              (WebInspector.injectedExtensionAPI.PanelImpl):
              * inspector/front-end/ExtensionServer.js:
              (WebInspector.ExtensionServer.prototype.notifyPanelShown):
              (WebInspector.ExtensionServer.prototype.notifyPanelHidden):
              * inspector/front-end/Panel.js:
              (WebInspector.Panel.prototype.show):
              (WebInspector.Panel.prototype.hide):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49838218
    • mrobinson@webkit.org's avatar
      2011-04-04 Martin Robinson <mrobinson@igalia.com> · cb204222
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [Gtk] webkit_web_view_popup_menu_handler should call SelectionController::localCaretRect
              https://bugs.webkit.org/show_bug.cgi?id=54633
      
              Remove use of legacy editing positions when positioning keyboard-driven context
              menus. Simplify the code greatly.
      
              * webkit/webkitwebview.cpp:
              (getLocationForKeyboardGeneratedContextMenu): Added this helper which calculates
              the context menu position.
              (webkit_web_view_popup_menu_handler): Simplify code preventing the menu from bumping
              into the edges of the view. Remove (0,-1) hack as it no longer seems to be important.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb204222
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · b2831f9d
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: search in resources panel is broken.
              https://bugs.webkit.org/show_bug.cgi?id=57631
      
              Search in resources panel should trigger source frame content load.
      
              * inspector/front-end/Panel.js:
              (WebInspector.Panel.prototype.jumpToNextSearchResult):
              (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
              * inspector/front-end/ResourcesPanel.js:
              * inspector/front-end/SearchController.js:
              (WebInspector.SearchController.prototype.handleShortcut):
              (WebInspector.SearchController.prototype.focusSearchField):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype.show):
              (WebInspector.SourceFrame.prototype._ensureContentLoaded):
              (WebInspector.SourceFrame.prototype.performSearch):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2831f9d
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · fe24a946
      podivilov@chromium.org authored
              Unreviewed, mark xhr-breakpoints as CRASH PASS on chromium win debug.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe24a946
    • eric@webkit.org's avatar
      2011-04-03 Eric Seidel <eric@webkit.org> · a328c178
      eric@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              Split out UnicodeBidi enum into its own header (to allow use in platform)
              https://bugs.webkit.org/show_bug.cgi?id=57722
      
              unicode-bidi is a CSS concept.  However the same concept is really needed throughout
              the bidi code in platform as well.  So I'm moving the enum to platform.
              The only part of the enum which doesn't make much sense to platform/ is "normal".
      
              * WebCore.xcodeproj/project.pbxproj:
              * css/CSSPrimitiveValueMappings.h:
              * platform/text/UnicodeBidi.h: Added.
              * rendering/style/RenderStyle.h:
              * rendering/style/RenderStyleConstants.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a328c178
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · a8628516
      podivilov@chromium.org authored
              Unreviewed, udpate chromium-linux test expectations after r82786.
      
              * platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
              * platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8628516
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · 8b3a51dc
      podivilov@chromium.org authored
              Unreviewed, add chromium-linux expectation for the new test added in r82781.
      
              * platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b3a51dc
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · 9473463d
      podivilov@chromium.org authored
              Unreviewed, rebaseline chromium-linux test expectations after r82783.
      
              * platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added.
              * platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added.
              * platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added.
              * platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added.
              * platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added.
              * platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added.
              * platform/chromium-linux/fast/html/details-open1-expected.png: Added.
              * platform/chromium-linux/fast/html/details-open2-expected.png: Added.
              * platform/chromium-linux/fast/html/details-open3-expected.png: Added.
              * platform/chromium-linux/fast/html/details-open4-expected.png: Added.
              * platform/chromium-linux/fast/html/details-open5-expected.png: Added.
              * platform/chromium-linux/fast/html/details-open6-expected.png: Added.
              * platform/chromium-linux/fast/html/details-position-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added.
              * platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added.
              * platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9473463d
    • podivilov@chromium.org's avatar
      2011-04-04 Andrey Adaikin <aandrey@google.com> · e5e2ecbe
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Highlighted search tokens would not be shown on long lines in the text viewer
              https://bugs.webkit.org/show_bug.cgi?id=57749
      
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
              (WebInspector.TextEditorMainPanel.prototype._paintLine):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5e2ecbe
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · 0bd2e62c
      podivilov@chromium.org authored
              Unreviewed, add chromium expectations for the new test added in r82781.
      
              * platform/chromium-mac-leopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
              * platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
              * platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bd2e62c
    • apavlov@chromium.org's avatar
      2011-04-04 Alexander Pavlov <apavlov@chromium.org> · 71435742
      apavlov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Incorrectly reports warning on missing/incorrect content-type for 304s
              https://bugs.webkit.org/show_bug.cgi?id=48525
      
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71435742
    • mario@webkit.org's avatar
      2011-04-04 Mario Sanchez Prada <msanchez@igalia.com> · 59c4407c
      mario@webkit.org authored
              Unreviewed. Unskipped test and added GTK-specific new baseline.
      
              * platform/gtk/Skipped: Skipped passing test.
              * platform/gtk/accessibility/aria-roles-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59c4407c
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · 0a73ec3b
      podivilov@chromium.org authored
              Unreviewed, remove chromium expectations added by mistake in r82815.
      
              * platform/chromium-linux-x86_64/fast/table/colspanMinWidth-vertical-expected.png: Removed.
              * platform/chromium-win-vista/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a73ec3b
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · b649ff21
      podivilov@chromium.org authored
              Unreviewed, delete duplicate baselines added in r82812.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b649ff21
    • apavlov@chromium.org's avatar
      2011-04-01 Alexander Pavlov <apavlov@chromium.org> · b01fe893
      apavlov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function
              https://bugs.webkit.org/show_bug.cgi?id=57632
      
              Moved the affected method onto the DOMNode.prototype as "appropriateSelectorFor".
      
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMNode.prototype.appropriateSelectorFor):
              * inspector/front-end/EventListenersSidebarPane.js:
              ():
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylesSidebarPane.prototype.addBlankSection):
              * inspector/front-end/utilities.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b01fe893
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · 11473921
      podivilov@chromium.org authored
              Unreviewed, fix bad rebaseline in r82812.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11473921
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · e87830a5
      podivilov@chromium.org authored
              Unreviewed, fix exception in rebaseline tool.
      
              * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e87830a5
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · 492e2eae
      podivilov@chromium.org authored
              Unreviewed, udpate chromium test expectations after r82786.
      
              * platform/chromium-linux-x86_64/fast/table/colspanMinWidth-vertical-expected.png: Added.
              * platform/chromium-win-vista/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
              * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
              * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
              * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      492e2eae
    • caseq@chromium.org's avatar
      2011-04-04 Andrey Kosyakov <caseq@chromium.org> · e4b548a1
      caseq@chromium.org authored
              Unreviewed. Followup to an incomplete commit in r82806.
      
              * inspector/front-end/ExtensionAPI.js:
              (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane):
              (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl):
              (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight):
              (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
              (WebInspector.injectedExtensionAPI):
              * inspector/front-end/ExtensionPanel.js:
              (WebInspector.ExtensionSidebarPane):
              (WebInspector.ExtensionSidebarPane.prototype.setPage):
              (WebInspector.ExtensionSidebarPane.prototype._setObject):
              * inspector/front-end/ExtensionServer.js:
              (WebInspector.ExtensionServer):
              (WebInspector.ExtensionServer.prototype.notifyExtensionSidebarUpdated):
              (WebInspector.ExtensionServer.prototype._onCreatePanel):
              (WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
              (WebInspector.ExtensionServer.prototype.createClientIframe):
              (WebInspector.ExtensionServer.prototype._onSetSidebarContent):
      
      2011-04-04  Andrey Kosyakov  <caseq@chromium.org>
      
              Unreviewed. Followup to an incomplete commit in r82806.
      
              * inspector/extensions/extensions.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4b548a1
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · 64b88109
      podivilov@chromium.org authored
              Unreviewed, add chromium test expectations for tests added in r82780.
      
              * platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
              * platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt: Added.
              * platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
              * platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt: Added.
              * platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
              * platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt: Added.
              * platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
              * platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64b88109
    • podivilov@chromium.org's avatar
      2011-04-04 Pavel Podivilov <podivilov@chromium.org> · e84938d4
      podivilov@chromium.org authored
              Unreviewed, rebaseline chromium tests after r82783.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e84938d4
    • yurys@chromium.org's avatar
      2011-04-04 Yury Semikhatsky <yurys@chromium.org> · 1507bbb0
      yurys@chromium.org authored
              Unreviewed. Fix Qt minimal build.
      
              * inspector/InspectorFrontendChannel.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1507bbb0
    • yurys@chromium.org's avatar
      2011-04-01 Sergey Vorobyev <sergeyvorobyev@google.com> · 19aebede
      yurys@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Separate sendMessageToFrontend function
              from InspectorClient to individual interface.
              https://bugs.webkit.org/show_bug.cgi?id=57548
      
              Refactoring - covered with existing inspector tests.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/InspectorClient.h:
              * inspector/InspectorFrontendChannel.h: Added.
              (WebCore::InspectorFrontendChannel::~InspectorFrontendChannel):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19aebede
    • thakis@chromium.org's avatar
      2011-04-04 Nico Weber <thakis@chromium.org> · 1e3c850e
      thakis@chromium.org authored
              Reviewed by Eric Seidel.
      
              Prefer a using directive over qualified names in LocalizedNumberICU.cpp
              https://bugs.webkit.org/show_bug.cgi?id=57742
      
              Requested by ap in https://bugs.webkit.org/show_bug.cgi?id=57715
      
              * platform/text/LocalizedNumberICU.cpp:
              (WebCore::createFormatterForCurrentLocale):
              (WebCore::numberFormatter):
              (WebCore::parseLocalizedNumber):
              (WebCore::formatLocalizedNumber):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e3c850e
    • podivilov@chromium.org's avatar
      2011-04-04 Andrey Adaikin <aandrey@google.com> · 7f10da74
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Breakpoints in the gutter stay static while editing the text
              https://bugs.webkit.org/show_bug.cgi?id=57616
      
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              (WebInspector.SourceFrame.prototype._saveViewerState):
              (WebInspector.SourceFrame.prototype._restoreViewerState):
              (WebInspector.SourceFrame.prototype._endEditing):
              (WebInspector.SourceFrame.prototype._lineNumberAfterEditing):
              (WebInspector.SourceFrame.prototype.addBreakpoint):
              (WebInspector.SourceFrame.prototype.removeBreakpoint):
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextViewer.prototype._syncDecorationsForLine):
              (WebInspector):
              (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
              (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
              (WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
              (WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f10da74