1. 08 Sep, 2011 1 commit
  2. 06 Sep, 2011 1 commit
    • rniwa@webkit.org's avatar
      Rename confirmCompositionWithoutDisturbingSelection to cancelComposition · ce2a1a3d
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67569
      
      Reviewed by Antonio Gomes.
      
      Source/WebCore: 
      
      Renamed Editor::confirmCompositionWithoutDisturbingSelection to Editor::cancelComposition.
      Also renamed the shared function from confirmComposition to setComposition.
      
      * WebCore.exp.in:
      * editing/Editor.cpp:
      (WebCore::Editor::confirmComposition):
      (WebCore::Editor::cancelComposition):
      (WebCore::Editor::setComposition):
      * editing/Editor.h:
      
      Source/WebKit/chromium: 
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::unmarkText):
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::EditorClient::respondToChangedSelection):
      
      Source/WebKit/mac: 
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _updateSelectionForInputManager]):
      
      Source/WebKit/win: 
      
      * WebView.cpp:
      (WebView::resetIME):
      
      Source/WebKit2: 
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView resignFirstResponder]):
      (-[WKView _updateTextInputStateIncludingSecureInputState:]):
      * UIProcess/WebPageProxy.h:
      * UIProcess/mac/WebPageProxyMac.mm:
      (WebKit::WebPageProxy::cancelComposition):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::cancelComposition):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce2a1a3d
  3. 30 Aug, 2011 3 commits
    • rniwa@webkit.org's avatar
      Unreviewed, rolling out r94142, r94144, r94145, and r94148. · fa92d361
      rniwa@webkit.org authored
      http://trac.webkit.org/changeset/94142
      http://trac.webkit.org/changeset/94144
      http://trac.webkit.org/changeset/94145
      http://trac.webkit.org/changeset/94148
      https://bugs.webkit.org/show_bug.cgi?id=67262
      
      Broke isindex element (Requested by rniwa on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-30
      
      Source/WebCore: 
      
      * WebCore.order:
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isPasswordField):
      (WebCore::AccessibilityRenderObject::isIndeterminate):
      (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
      (WebCore::AccessibilityRenderObject::isChecked):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::canShareStyleWithControl):
      (WebCore::CSSStyleSelector::adjustRenderStyle):
      (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
      (WebCore::CSSStyleSelector::applyProperty):
      * dom/CheckedRadioButtons.cpp:
      (WebCore::CheckedRadioButtons::addButton):
      (WebCore::CheckedRadioButtons::removeButton):
      * dom/Node.cpp:
      (WebCore::Node::toInputElement):
      * dom/Node.h:
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::isInPasswordField):
      * html/HTMLInputElement.h:
      (WebCore::HTMLInputElement::toInputElement):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::sliderThumbElementOf):
      (WebCore::RenderSliderThumb::layout):
      (WebCore::RenderSliderContainer::layout):
      (WebCore::SliderThumbElement::hostInput):
      (WebCore::trackLimiterElementOf):
      * html/shadow/TextControlInnerElements.cpp:
      (WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
      (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
      (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
      (WebCore::SpinButtonElement::defaultEventHandler):
      (WebCore::SpinButtonElement::repeatingTimerFired):
      (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
      (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
      * page/DragController.cpp:
      (WebCore::asFileInput):
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintThemePart):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
      (WebCore::RenderTextControlSingleLine::inputElement):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::isChecked):
      (WebCore::RenderTheme::isIndeterminate):
      
      Source/WebKit/chromium: 
      
      * src/EditorClientImpl.cpp:
      (WebKit::EditorClientImpl::textFieldDidEndEditing):
      (WebKit::EditorClientImpl::doTextFieldCommandFromEvent):
      * src/WebInputElement.cpp:
      (WebKit::toWebInputElement):
      * src/WebPasswordFormUtils.cpp:
      (WebKit::findPasswordFormFields):
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::setAutofilled):
      (DumpRenderTreeSupportGtk::setValueForUser):
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setAutofilled):
      (DumpRenderTreeSupportQt::setValueForUser):
      (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa92d361
    • rniwa@webkit.org's avatar
      GTK build fix after r94142. · e935b95a
      rniwa@webkit.org authored
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::setAutofilled):
      (DumpRenderTreeSupportGtk::setValueForUser):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e935b95a
    • commit-queue@webkit.org's avatar
      The unused ScrollView* argument can and should be removed from · d673769b
      commit-queue@webkit.org authored
      scrollRectIntoView.
      https://bugs.webkit.org/show_bug.cgi?id=67117
      
      Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-08-30
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::scrollRectIntoView):
      * page/Chrome.cpp:
      (WebCore::Chrome::scrollRectIntoView):
      * page/ChromeClient.h:
      (WebCore::ChromeClient::scrollRectIntoView):
      
      Source/WebKit/chromium:
      
      * src/WebPopupMenuImpl.cpp:
      (WebKit::WebPopupMenuImpl::scrollRectIntoView):
      * src/WebPopupMenuImpl.h:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.h:
      (WebCore::ChromeClientEfl::scrollRectIntoView):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.h:
      (WebKit::ChromeClient::scrollRectIntoView):
      
      Source/WebKit/haiku:
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      (WebCore::ChromeClientHaiku::scrollRectIntoView):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::scrollRectIntoView):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.h:
      (WebCore::ChromeClientQt::scrollRectIntoView):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.h:
      (WebChromeClient::scrollRectIntoView):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit/wx:
      
      * WebKitSupport/ChromeClientWx.h:
      (WebCore::ChromeClientWx::scrollRectIntoView):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::scrollRectIntoView):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d673769b
  4. 26 Aug, 2011 1 commit
  5. 18 Aug, 2011 3 commits
    • alex@webkit.org's avatar
      2011-08-17 Alejandro G. Castro <alex@igalia.com> · bb3aecc4
      alex@webkit.org authored
              [GTK] Fix compilation problems with deprecations in gtk+
              https://bugs.webkit.org/show_bug.cgi?id=66073
      
              Reviewed by Martin Robinson.
      
              * platform/gtk/GtkAuthenticationDialog.cpp:
              (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): Added
              gtk_box_new conditional compilation for gtk+-3.
              * platform/gtk/RenderThemeGtk3.cpp:
              (WebCore::RenderThemeGtk::adjustRepaintRect):
              (WebCore::RenderThemeGtk::paintSliderTrack):
              (WebCore::RenderThemeGtk::paintSliderThumb):
              (WebCore::RenderThemeGtk::adjustSliderThumbSize): Now we have have
              GTK_TYPE_SCALE in gtk+3.
      
      2011-08-17  Alejandro G. Castro  <alex@igalia.com>
      
              [GTK] Fix compilation problems with deprecations in gtk+
              https://bugs.webkit.org/show_bug.cgi?id=66073
      
              Reviewed by Martin Robinson.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (main): G_CONST_RETURN was deprecated
              * GtkLauncher/main.c:
              (createWindow): Added gtk_box_new conditional compilation for
              gtk+-3.
              * MiniBrowser/gtk/BrowserWindow.c:
              (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
              are just supporting gtk+-3 for WebKit2.
      
      2011-08-17  Alejandro G. Castro  <alex@igalia.com>
      
              [GTK] Fix compilation problems with deprecations in gtk+
              https://bugs.webkit.org/show_bug.cgi?id=66073
      
              Reviewed by Martin Robinson.
      
              * WebCoreSupport/FullscreenVideoController.cpp:
              (FullscreenVideoController::createHud): Added gtk_box_new
              conditional compilation for gtk+-3.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb3aecc4
    • caio.oliveira@openbossa.org's avatar
      [GTK] Change webview API tests to use "load-status" signal instead of "load-progress" · ed02805f
      caio.oliveira@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66243
      
      Reviewed by Martin Robinson.
      
      The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
      call it only when the "load-status" change.
      
      This change is important in the context of bug 28851, which aims to change the
      order in which "progress finished" and "load finished" callbacks are called. In
      this new scenario, at the progress callback the load will never be finished.
      
      * tests/testwebview.c:
      (test_webkit_web_view_grab_focus):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed02805f
    • aroben@apple.com's avatar
      Make WebCore keep track of the current device scale factor · bfeb8134
      aroben@apple.com authored
      Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
      device scale factor
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      * WebCore.exp.in: Removed Frame::deviceScaleFactorChanged, added Page::setDeviceScaleFactor.
      
      * css/MediaQueryEvaluator.cpp:
      (WebCore::device_pixel_ratioMediaFeatureEval):
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::HTMLCanvasElement):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::devicePixelRatio):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::addDashboardRegions):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::deviceScaleFactor):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::addDashboardRegions):
      Changed to get the device scale factor from Page.
      
      * loader/EmptyClients.h:
      * page/Chrome.cpp:
      * page/Chrome.h:
      * page/ChromeClient.h:
      Removed Chrome[Client]::deviceScaleFactor.
      
      * page/Frame.cpp:
      * page/Frame.h:
      Removed deviceScaleFactorChanged. Made deviceOrPageScaleFactorChanged public.
      
      * page/Page.cpp:
      (WebCore::Page::Page): Initialize m_deviceScaleFactor.
      (WebCore::Page::setDeviceScaleFactor): Added. Code came from
      Frame::deviceScaleFactorChanged.
      
      * page/Page.h: Added m_deviceScaleFactor.
      (WebCore::Page::deviceScaleFactor): Added simple getter.
      
      Source/WebKit/chromium:
      
      * src/ChromeClientImpl.cpp:
      * src/ChromeClientImpl.h:
      Removed deviceScaleFactor.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      * WebCoreSupport/ChromeClientEfl.h:
      Removed deviceScaleFactor.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      * WebCoreSupport/ChromeClientGtk.h:
      Removed deviceScaleFactor.
      
      Source/WebKit/haiku:
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      * WebCoreSupport/ChromeClientHaiku.h:
      Removed deviceScaleFactor.
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      Moved code to calculate the device scale factor from here...
      
      * WebView/WebView.mm:
      (-[WebView _deviceScaleFactor]):
      ...to here.
      
      (-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.
      
      Source/WebKit/qt:
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::QWebPagePrivate): Removed pixelRatio.
      (QWebPage::viewportAttributesForSize): Now calls Page::setDeviceScaleFactor.
      
      * Api/qwebpage_p.h: Removed pixelRatio.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      * WebCoreSupport/ChromeClientQt.h:
      Removed deviceScaleFactor.
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.cpp:
      * WebCoreSupport/WebChromeClient.h:
      Removed deviceScaleFactor.
      
      Source/WebKit/wince:
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      * WebCoreSupport/ChromeClientWinCE.h:
      Removed deviceScaleFactor.
      
      Source/WebKit/wx:
      
      * WebKitSupport/ChromeClientWx.cpp:
      * WebKitSupport/ChromeClientWx.h:
      Removed deviceScaleFactor.
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      Removed deviceScaleFactor.
      
      * WebProcess/WebPage/DrawingAreaImpl.cpp:
      (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
      (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
      (WebKit::DrawingAreaImpl::display):
      * WebProcess/WebPage/FindController.cpp:
      (WebKit::FindController::updateFindIndicator):
      (WebKit::FindController::hideFindIndicator):
      * WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
      (WebKit::LayerTreeHostCA::deviceScaleFactor):
      Changed to get the device scale factor from WebCore.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
      (WebKit::WebPage::setDeviceScaleFactor):
      * WebProcess/WebPage/WebPage.h:
      Removed m_deviceScaleFactor. We always get the scale factor from WebCore now.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfeb8134
  6. 16 Aug, 2011 1 commit
  7. 15 Aug, 2011 2 commits
    • dimich@chromium.org's avatar
      FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters · f261ddf9
      dimich@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66165
      
      Reviewed by Darin Fisher.
      
      Source/WebCore:
      
      No new tests since no change in behavior.
      The original issue is only reproducible on Chromium in multi-process mode
      and is tested there by a browsertest.
      
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::transferLoadingResourcesFromPage):
      Passing ResourceLoader* into the FrameLoaderClient notification.
      Also, fixed the bug where the same ResourceRequest was passed for all subresources.
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::transferLoadingResourceFromPage):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::dispatchTransferLoadingResourceFromPage):
      * loader/FrameLoader.h:
      * loader/FrameLoaderClient.h:
      * loader/ResourceLoadNotifier.cpp:
      (WebCore::ResourceLoadNotifier::dispatchTransferLoadingResourceFromPage):
      * loader/ResourceLoadNotifier.h:
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::init):
      * loader/ResourceLoader.h:
      (WebCore::ResourceLoader::originalRequest): Added the originalRequest() accessor that
      returns the request as it existed before redirects (but after client's will SendRequest).
      This is to be able to pass the original request for loading subresources into
      FrameLoaderClient::transferLoadingResourceFromPage, since that one is used to invoke
      assignIdentifierToInitialRequest, which needs original request.
      
      Source/WebKit/chromium:
      
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage):
      * src/FrameLoaderClientImpl.h:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::transferLoadingResourceFromPage):
      * WebCoreSupport/FrameLoaderClientEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::transferLoadingResourceFromPage):
      * WebCoreSupport/FrameLoaderClientGtk.h:
      
      Source/WebKit/haiku:
      
      * WebCoreSupport/FrameLoaderClientHaiku.cpp:
      (WebCore::FrameLoaderClientHaiku::transferLoadingResourceFromPage):
      * WebCoreSupport/FrameLoaderClientHaiku.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::transferLoadingResourceFromPage):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::transferLoadingResourceFromPage):
      * WebCoreSupport/FrameLoaderClientQt.h:
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::transferLoadingResourceFromPage):
      * WebCoreSupport/WebFrameLoaderClient.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage):
      * WebCoreSupport/FrameLoaderClientWinCE.h:
      
      Source/WebKit/wx:
      
      * WebKitSupport/FrameLoaderClientWx.cpp:
      (WebCore::FrameLoaderClientWx::transferLoadingResourceFromPage):
      * WebKitSupport/FrameLoaderClientWx.h:
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::transferLoadingResourceFromPage):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f261ddf9
    • aroben@apple.com's avatar
      Clear up scale factor terminology · 631cb90e
      aroben@apple.com authored
      WebKit by and large deals with two scale factors: one intrinsic to the device on which the
      software is running, and one that is per-Page and can be controlled via API calls. This
      patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
      code use those names. It should introduce no behavior changes.
      
      Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
      device scale factor
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
      Removed an unused member. This is unrelated to this patch.
      
      * css/MediaQueryEvaluator.cpp:
      * html/HTMLCanvasElement.cpp:
      * html/HTMLCanvasElement.h:
      * loader/EmptyClients.h:
      * page/Chrome.cpp:
      * page/Chrome.h:
      * page/ChromeClient.h:
      * page/DOMWindow.cpp:
      * page/Frame.cpp:
      * page/Frame.h:
      * platform/graphics/GraphicsLayer.cpp:
      * platform/graphics/GraphicsLayer.h:
      * platform/graphics/GraphicsLayerClient.h:
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      * rendering/RenderInline.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerBacking.h:
      * rendering/RenderLayerCompositor.cpp:
      * rendering/RenderLayerCompositor.h:
      * rendering/RenderObject.cpp:
      
      Source/WebKit/chromium:
      
      * src/ChromeClientImpl.cpp:
      * src/ChromeClientImpl.h:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      * WebCoreSupport/ChromeClientEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      * WebCoreSupport/ChromeClientGtk.h:
      
      Source/WebKit/haiku:
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      * WebCoreSupport/ChromeClientHaiku.h:
      
      Source/WebKit/mac:
      
      * Misc/WebNSControlExtras.m:
      (-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern
      AppKit scale factor terminology. (This is unrelated to the rest of the patch.)
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      * WebCoreSupport/ChromeClientQt.h:
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.cpp:
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit/wx:
      
      * WebKitSupport/ChromeClientWx.cpp:
      * WebKitSupport/ChromeClientWx.h:
      
      Source/WebKit2:
      
      * Shared/UpdateInfo.cpp:
      * Shared/UpdateInfo.h:
      * Shared/WebPageCreationParameters.cpp:
      * Shared/WebPageCreationParameters.h:
      * UIProcess/API/C/WKPage.cpp:
      * UIProcess/API/efl/PageClientImpl.cpp:
      * UIProcess/API/efl/PageClientImpl.h:
      * UIProcess/API/gtk/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      * UIProcess/BackingStore.cpp:
      * UIProcess/BackingStore.h:
      * UIProcess/DrawingAreaProxyImpl.cpp:
      * UIProcess/PageClient.h:
      * UIProcess/WebPageProxy.cpp:
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * UIProcess/WebPopupMenuProxy.h:
      * UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
      * UIProcess/gtk/WebPopupMenuProxyGtk.h:
      * UIProcess/mac/BackingStoreMac.mm:
      * UIProcess/mac/WebPageProxyMac.mm:
      * UIProcess/mac/WebPopupMenuProxyMac.h:
      * UIProcess/mac/WebPopupMenuProxyMac.mm:
      * UIProcess/qt/WebPopupMenuProxyQt.h:
      * UIProcess/win/WebPopupMenuProxyWin.h:
      * UIProcess/win/WebView.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebPage/DrawingAreaImpl.cpp:
      * WebProcess/WebPage/FindController.cpp:
      * WebProcess/WebPage/WebPage.cpp:
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
      * WebProcess/WebPage/ca/LayerTreeHostCA.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      631cb90e
  8. 11 Aug, 2011 2 commits
  9. 10 Aug, 2011 1 commit
  10. 03 Aug, 2011 3 commits
    • pfeldman@chromium.org's avatar
      Web Inspector: [Timeline] Hover on paint events and see rect outline around that area. · 781fa287
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65510
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * WebCore.order:
      * inspector/DOMNodeHighlighter.cpp:
      (WebCore::DOMNodeHighlighter::drawRectHighlight):
      * inspector/DOMNodeHighlighter.h:
      * inspector/Inspector.json:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::drawHighlight):
      * inspector/InspectorController.h:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::highlightRect):
      (WebCore::InspectorDOMAgent::hideHighlight):
      (WebCore::InspectorDOMAgent::drawHighlight):
      * inspector/InspectorDOMAgent.h:
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.FrameTreeElement.prototype.onselect):
      (WebInspector.FrameTreeElement.prototype.set hovered):
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel):
      (WebInspector.TimelinePanel.prototype._mouseOut):
      (WebInspector.TimelinePanel.prototype._mouseMove):
      (WebInspector.TimelinePanel.prototype._highlightRect):
      (WebInspector.TimelinePanel.prototype._hideRectHighlight):
      * inspector/front-end/inspector.js:
      (WebInspector.highlightDOMNode):
      
      Source/WebKit/chromium:
      
      * src/WebDevToolsAgentImpl.cpp:
      (WebKit::WebDevToolsAgentImpl::paintPageOverlay):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebview.cpp:
      (paintWebView):
      
      Source/WebKit/mac:
      
      * WebInspector/WebNodeHighlightView.mm:
      (-[WebNodeHighlightView drawRect:]):
      
      Source/WebKit/qt:
      
      * Api/qwebframe.cpp:
      (QWebFramePrivate::renderRelativeCoords):
      
      Source/WebKit/win:
      
      * WebNodeHighlight.cpp:
      (WebNodeHighlight::update):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
      (WebKit::WebInspectorClient::drawRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      781fa287
    • pfeldman@chromium.org's avatar
      Web Inspector: remove Node parameter from the InspectorClient::highlight · b0781ec8
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65549
      
      Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-08-03
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      * inspector/InspectorClient.h:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::highlight):
      * loader/EmptyClients.h:
      (WebCore::EmptyInspectorClient::highlight):
      
      Source/WebKit/chromium:
      
      * src/InspectorClientImpl.cpp:
      (WebKit::InspectorClientImpl::highlight):
      * src/InspectorClientImpl.h:
      * src/WebDevToolsAgentImpl.cpp:
      (WebKit::WebDevToolsAgentImpl::highlight):
      * src/WebDevToolsAgentImpl.h:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/InspectorClientEfl.cpp:
      (WebCore::InspectorClientEfl::highlight):
      * WebCoreSupport/InspectorClientEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/InspectorClientGtk.cpp:
      (WebKit::InspectorClient::highlight):
      * WebCoreSupport/InspectorClientGtk.h:
      
      Source/WebKit/haiku:
      
      * WebCoreSupport/InspectorClientHaiku.cpp:
      (WebCore::InspectorClientHaiku::highlight):
      * WebCoreSupport/InspectorClientHaiku.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebInspectorClient.h:
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorClient::highlight):
      * WebInspector/WebNodeHighlighter.h:
      * WebInspector/WebNodeHighlighter.mm:
      (-[WebNodeHighlighter highlight]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/InspectorClientQt.cpp:
      (WebCore::InspectorClientQt::highlight):
      * WebCoreSupport/InspectorClientQt.h:
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebInspectorClient.cpp:
      (WebInspectorClient::highlight):
      * WebCoreSupport/WebInspectorClient.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/InspectorClientWinCE.cpp:
      (WebKit::InspectorClientWinCE::highlight):
      * WebCoreSupport/InspectorClientWinCE.h:
      
      Source/WebKit/wx:
      
      * WebKitSupport/InspectorClientWx.cpp:
      (WebCore::InspectorClientWx::highlight):
      * WebKitSupport/InspectorClientWx.h:
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
      (WebKit::WebInspectorClient::highlight):
      * WebProcess/WebCoreSupport/WebInspectorClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0781ec8
    • carlosgc@webkit.org's avatar
      [GTK] Reorganize pkg-config files · eedf25ec
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65548
      
      Reviewed by Martin Robinson.
      
      .:
      
      * GNUmakefile.am: Initialize pkgconfigdir and pkgconfig_DATA which
      are common to all libraries.
      * configure.ac: Update pkg-config files.
      
      Source/JavaScriptCore:
      
      * GNUmakefile.am:
      * javascriptcoregtk.pc.in: Renamed from Source/WebKit/gtk/javascriptcoregtk.pc.in.
      
      Source/WebKit/gtk:
      
      * GNUmakefile.am: Remove javascriptcore pc file references.
      
      Source/WebKit2:
      
      * GNUmakefile.am: Rename pc file as webkit2gtk.pc.in. WebKit2
      depends on gtk3 unconditionally so we don't need to use
      WEBKITGTK_PC_NAME.
      * webkit2gtk.pc.in: Renamed from Source/WebKit2/gtk/webkit2.pc.in.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eedf25ec
  11. 30 Jul, 2011 1 commit
    • paroga@webkit.org's avatar
      Remove inclusion of MainThread.h from Threading.h · c309e0e2
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65081
      
      Reviewed by Darin Adler.
      
      Source/JavaScriptCore:
      
      Add missing and remove unneeded include statements for MainThread.
      
      * wtf/CryptographicallyRandomNumber.cpp:
      * wtf/Threading.h:
      * wtf/ThreadingPthreads.cpp:
      * wtf/text/StringStatics.cpp:
      
      Source/WebCore:
      
      Add missing include statements for MainThread.
      
      * bindings/js/DOMWrapperWorld.cpp:
      * bindings/js/JSDOMWindowBase.cpp:
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateCallbackImplementation):
      * bindings/v8/DOMDataStore.cpp:
      * bindings/v8/DOMWrapperWorld.cpp:
      * bindings/v8/V8Binding.cpp:
      * bindings/v8/V8DOMMap.cpp:
      * bindings/v8/V8DOMWrapper.h:
      * dom/EventTarget.cpp:
      * fileapi/LocalFileSystem.cpp:
      * loader/CrossOriginPreflightResultCache.cpp:
      * loader/ResourceLoadScheduler.cpp:
      * loader/WorkerThreadableLoader.cpp:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * page/DOMWindow.cpp:
      * page/History.cpp:
      * page/SecurityOrigin.cpp:
      * page/mac/EventHandlerMac.mm:
      * platform/MIMETypeRegistry.cpp:
      * platform/ThreadGlobalData.cpp:
      * platform/ThreadTimers.cpp:
      * platform/TreeShared.h:
      * platform/audio/HRTFDatabaseLoader.cpp:
      * platform/graphics/Font.cpp:
      * platform/graphics/FontFallbackList.h:
      * platform/graphics/FontFastPath.cpp:
      * platform/graphics/Image.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
      * platform/graphics/cg/ImageBufferCG.cpp:
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
      * platform/mac/LocalizedStringsMac.mm:
      * platform/mac/SharedBufferMac.mm:
      * platform/network/BlobResourceHandle.cpp:
      * platform/network/cf/DNSCFNet.cpp:
      * platform/network/cf/LoaderRunLoopCF.cpp:
      * platform/text/LocalizedNumberICU.cpp:
      * platform/text/TextEncodingRegistry.cpp:
      * platform/text/mac/LocalizedNumberMac.mm:
      * platform/win/LocalizedStringsWin.cpp:
      * storage/LocalStorageThread.cpp:
      * storage/StorageAreaImpl.cpp:
      * storage/StorageAreaSync.cpp:
      * storage/StorageNamespaceImpl.cpp:
      * storage/StorageSyncManager.cpp:
      * webaudio/AsyncAudioDecoder.cpp:
      * webaudio/AudioBufferSourceNode.cpp:
      * webaudio/AudioContext.h
      * webaudio/AudioContext.cpp:
      * webaudio/AudioNode.cpp:
      * webaudio/ConvolverNode.cpp:
      * webaudio/OfflineAudioDestinationNode.cpp:
      * webaudio/RealtimeAnalyser.cpp:
      * webaudio/WaveShaperNode.cpp:
      * websockets/WorkerThreadableWebSocketChannel.cpp:
      * workers/WorkerMessagingProxy.cpp:
      
      Source/WebKit/chromium:
      
      Add missing include statements for MainThread.
      
      * src/WebKit.cpp:
      * src/WebViewImpl.cpp:
      * tests/CCThreadTest.cpp:
      
      Source/WebKit/gtk:
      
      Add missing include statements for MainThread.
      
      * webkit/webkitglobals.cpp:
      
      Source/WebKit/mac:
      
      Add missing include statements for MainThread.
      
      * Carbon/CarbonWindowAdapter.mm:
      * History/WebBackForwardList.mm:
      * History/WebHistoryItem.mm:
      * Misc/WebElementDictionary.mm:
      * Misc/WebIconDatabase.mm:
      * Misc/WebLocalizableStrings.mm:
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      * Plugins/WebBaseNetscapePluginView.mm:
      * Plugins/WebBasePluginPackage.mm:
      * Plugins/WebNetscapePluginView.mm:
      * WebCoreSupport/WebEditorClient.mm:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      * WebView/WebArchive.mm:
      * WebView/WebDataSource.mm:
      * WebView/WebHTMLView.mm:
      * WebView/WebResource.mm:
      * WebView/WebTextIterator.mm:
      * WebView/WebView.mm:
      * WebView/WebViewData.mm:
      
      Source/WebKit/qt:
      
      Add missing include statements for MainThread.
      
      * Api/qwebpage.cpp:
      
      Source/WebKit/win:
      
      Add missing include statements for MainThread.
      
      * WebKitClassFactory.cpp:
      * WebView.cpp:
      
      Source/WebKit/wx:
      
      Add missing include statements for MainThread.
      
      * WebView.cpp:
      
      Source/WebKit2:
      
      Add missing include statements for MainThread.
      
      * PluginProcess/gtk/PluginProcessMainGtk.cpp:
      * PluginProcess/mac/PluginProcessMainMac.mm:
      * PluginProcess/qt/PluginProcessMainQt.cpp:
      * UIProcess/API/mac/WKPrintingView.mm:
      * UIProcess/Launcher/mac/ThreadLauncherMac.mm:
      * UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
      * UIProcess/Launcher/win/ThreadLauncherWin.cpp:
      * UIProcess/WebContext.cpp:
      * WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
      * WebProcess/efl/WebProcessMainEfl.cpp:
      * WebProcess/gtk/WebProcessMainGtk.cpp:
      * WebProcess/mac/KeychainItemShimMethods.mm:
      * WebProcess/mac/WebProcessMainMac.mm:
      * WebProcess/qt/WebProcessMainQt.cpp:
      * WebProcess/win/WebProcessMainWin.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c309e0e2
  12. 26 Jul, 2011 2 commits
    • abarth@webkit.org's avatar
      Add support for download='filename' attribute in anchors. · 2d422e7f
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64580
      
      Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-26
      Reviewed by Adam Barth.
      
      Source/WebCore: 
      
      The download attribute allows the author of the hyperlink to cause the
      browser to download the linked URL.  The author can also supply a
      suggested file name in the attribute value.  This feature is a recent
      addition to HTML to better support offline applications that use blob
      URLs.  Traditionally, web sites use the HTTP Content-Disposition header
      to trigger downloads, but that option isn't available when working
      offline.
      
      There is some question about whether we should initiate a download when
      we receive a DOM-created click event.  This patch does initiate the
      download, but we might revise that decision in the future as part of a
      larger change in how WebKit treats the interaction between default
      event handlers and DOM-created events.
      
      Tests: fast/dom/HTMLAnchorElement/anchor-download.html
             fast/dom/HTMLAnchorElement/anchor-nodownload.html
             fast/dom/HTMLAnchorElement/anchor-download-unset.html
             fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
      
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::defaultEventHandler):
      (WebCore::HTMLAnchorElement::handleClick):
      * html/HTMLAnchorElement.h:
      * html/HTMLAnchorElement.idl:
      * html/HTMLAttributeNames.in:
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::startDownload):
      * loader/FrameLoaderClient.h:
      
      Source/WebKit/chromium: 
      
      * features.gypi:
      * public/WebFrameClient.h:
      (WebKit::WebFrameClient::loadURLExternally):
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClientImpl::startDownload):
      * src/FrameLoaderClientImpl.h:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::startDownload):
      * WebCoreSupport/FrameLoaderClientEfl.h:
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::startDownload):
      * WebCoreSupport/FrameLoaderClientGtk.h:
      
      Source/WebKit/haiku: 
      
      * WebCoreSupport/FrameLoaderClientHaiku.cpp:
      (WebCore::FrameLoaderClientHaiku::startDownload):
      * WebCoreSupport/FrameLoaderClientHaiku.h:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::startDownload):
      * WebCoreSupport/FrameLoaderClientQt.h:
      
      Source/WebKit/win: 
      
      * WebFrame.cpp:
      (WebFrame::startDownload):
      * WebFrame.h:
      
      Source/WebKit/wince: 
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::startDownload):
      * WebCoreSupport/FrameLoaderClientWinCE.h:
      
      Source/WebKit/wx: 
      
      * WebKitSupport/FrameLoaderClientWx.cpp:
      (WebCore::FrameLoaderClientWx::startDownload):
      * WebKitSupport/FrameLoaderClientWx.h:
      
      Source/WebKit2: 
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::startDownload):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      
      Tools: 
      
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::loadURLExternally):
      * DumpRenderTree/chromium/WebViewHost.h:
      
      LayoutTests: 
      
      * fast/dom/HTMLAnchorElement/anchor-download-expected.txt: Added.
      * fast/dom/HTMLAnchorElement/anchor-download.html: Added.
      * fast/dom/HTMLAnchorElement/anchor-nodownload-expected.txt: Added.
      * fast/dom/HTMLAnchorElement/anchor-nodownload.html: Added.
      * fast/dom/HTMLAnchorElement/anchor-download-unset-expected.txt: Added.
      * fast/dom/HTMLAnchorElement/anchor-download-unset.html: Added.
      * fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt: Added.
      * fast/dom/HTMLAnchorElement/anchor-nodownload-set.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d422e7f
    • commit-queue@webkit.org's avatar
      [GTK] Remove header webkitwebviewcommon.h · f232c5d4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65177
      
      Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-07-26
      Reviewed by Martin Robinson.
      
      Source/WebKit/gtk:
      
      Move webkitwebviewcommon.h contents back to webkitwebview.h.
      
      * GNUmakefile.am: Remove webkitwebviewcommon.h
      * webkit/webkitwebview.h:
      * webkit/webkitwebviewcommon.h: Removed.
      
      Source/WebKit2:
      
      * UIProcess/API/gtk/WebKitWebView.h: Add function prototypes
      instead of including webkitwebviewcommon.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f232c5d4
  13. 25 Jul, 2011 1 commit
    • mrobinson@webkit.org's avatar
      Reviewed by Gustavo Noronha Silva. · ee95f301
      mrobinson@webkit.org authored
      [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
      https://bugs.webkit.org/show_bug.cgi?id=62252
      
      Source/WebCore:
      
      Properly handle the situation where the GtkWidget wants WebCore to draw its
      own main frame scrollbars.
      
      * platform/gtk/ScrollViewGtk.cpp:
      (WebCore::shouldCreateMainFrameScrollbar): Abstract this logic into a helper function.
      (WebCore::ScrollView::createScrollbar): Use the new helper.
      (WebCore::ScrollView::visibleContentRect): Use the new helper.
      
      Source/WebKit/gtk:
      
      Added an undocumented self-scrolling property to WebKitWebView which
      communicates to WebCore whether or not this widget is expected to draw
      its own main frame scrollbars or not.
      
      * webkit/webkitwebview.cpp: Add the self-scrolling property.
      * webkit/webkitwebviewprivate.h: Add the selfScrolling private member.
      
      Tools:
      
      Add a new subclass of WebKitWebView that overrides the size request to
      return 1 pixel by 1 pixel. This ensure that it operates properly when
      not packed into a GtkScrolledWindow. Also construct the WebKitWebView
      with self-scrolling set to true.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (webInspectorInspectWebView): Use the new SelfScrollingWebKitWebview class here.
      (createWebView): Ditto.
      (main): Pack the widget into a GtkBox instead of a GtkScrolledWindow.
      * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Added.
      (self_scrolling_webkit_web_view_class_init):
      (self_scrolling_webkit_web_view_init):
      (self_scrolling_webkit_web_view_new):
      (sizeRequestMethod):
      (getPreferredSizeMethod):
      * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Added.
      * GNUmakefile.am: Added SelfScrollingWebKitWebView files to the source list.
      
      LayoutTests:
      
      Unskip tests which are now passing and update results for tests which
      previously had incorrect results.
      
      * platform/gtk/Skipped: Unskip now-passing tests.
      * platform/gtk/fast/css/MarqueeLayoutTest-expected.png:
      * platform/gtk/fast/css/MarqueeLayoutTest-expected.txt:
      * platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
      * platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.png:
      * platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
      * platform/gtk/fast/flexbox/flex-hang-expected.png:
      * platform/gtk/fast/flexbox/flex-hang-expected.txt:
      * platform/gtk/fast/forms/search-vertical-alignment-expected.png:
      * platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
      * platform/gtk/fast/forms/searchfield-heights-expected.png:
      * platform/gtk/fast/forms/searchfield-heights-expected.txt:
      * platform/gtk/fast/forms/textfield-overflow-expected.png:
      * platform/gtk/fast/forms/textfield-overflow-expected.txt:
      * platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
      * platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
      * platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
      * platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
      * platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
      * platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
      * platform/gtk/fast/frames/inline-object-inside-frameset-expected.png: Added.
      * platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
      * platform/gtk/fast/lists/001-vertical-expected.png: Added.
      * platform/gtk/fast/lists/001-vertical-expected.txt:
      * platform/gtk/fast/multicol/float-multicol-expected.png: Added.
      * platform/gtk/fast/multicol/float-multicol-expected.txt:
      * platform/gtk/fast/multicol/table-vertical-align-expected.png: Added.
      * platform/gtk/fast/multicol/table-vertical-align-expected.txt:
      * platform/gtk/fast/table/border-collapsing/004-vertical-expected.png:
      * platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
      * platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
      * platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
      * platform/gtk/tables/mozilla/bugs/bug145572-expected.png:
      * platform/gtk/tables/mozilla/bugs/bug145572-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee95f301
  14. 19 Jul, 2011 1 commit
    • kov@webkit.org's avatar
      [GTK] Google Calendar thinks we're mobile · adab7955
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63994
      
      Patch by Gustavo Noronha Silva  <gns@gnome.org> on 2011-07-11
      Reviewed by Xan Lopez.
      
      Further special-case Google Calendar, for it thinks WebKit+Linux
      means mobile, so we also have to spoof the OS.
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::userAgent): use the new WebKitGTK+
      private API that centralizes the logic now.
      * tests/testwebsettings.c: Add tests to make sure the Google
      special-cases only apply for the expected domains and when quirks
      special-casing is enabled.
      (test_non_quirky_user_agents):
      (test_webkit_web_settings_user_agent):
      * webkit/webkitwebsettings.cpp:
      (webkitUserAgent): make it static.
      (safariUserAgent): returns a fake Safari in Mac OS X User-Agent.
      (initializeDomainsList): moved from FrameLoaderClientGtk.
      (isGoogleDomain):ditto.
      (isGoogleCalendar): ditto.
      (userAgentForURL): ditto.
      (webkitWebSettingsUserAgentForUri): centralize the whole
      user agent spoofing logic in this new private API that can be used
      by the browser to know what's going to happen for a specific URI
      and also allows our API testing.
      * webkit/webkitwebsettingsprivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adab7955
  15. 15 Jul, 2011 2 commits
    • mitz@apple.com's avatar
      REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides · bf4519a5
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64615
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::enteredFullscreen): Hide the mouse cursor immediately when
      entering full screen.
      (WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide the mouse cursor when
      hiding the HUD.
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::setCursorHiddenUntilMouseMoves): Added empty implementation.
      * page/Chrome.cpp:
      (WebCore::Chrome::setCursorHiddenUntilMouseMoves): Added. Calls through to the client.
      * page/Chrome.h:
      * page/ChromeClient.h:
      * platform/HostWindow.h:
      
      Source/WebKit/chromium: 
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.
      * src/ChromeClientImpl.h:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebCoreSupport/ChromeClientEfl.h:
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebCoreSupport/ChromeClientGtk.h:
      
      Source/WebKit/haiku: 
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      (WebCore::ChromeClientHaiku::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebCoreSupport/ChromeClientHaiku.h:
      
      Source/WebKit/mac: 
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls
      +[NSCursor setHiddenUntilMouseMoves:].
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/ChromeClientQt.h:
      (WebCore::ChromeClientQt::setCursorHiddenUntilMouseMoves): Added this stub.
      
      Source/WebKit/win: 
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/wince: 
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit/wx: 
      
      * WebKitSupport/ChromeClientWx.h:
      (WebCore::ChromeClientWx::setCursorHiddenUntilMouseMoves): Added this stub.
      
      Source/WebKit2: 
      
      * UIProcess/API/efl/PageClientImpl.cpp:
      (WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.
      * UIProcess/API/efl/PageClientImpl.h:
      * UIProcess/API/gtk/PageClientImpl.cpp:
      (WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Ditto.
      * UIProcess/API/gtk/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added. Calls +[NSCursor setHiddenUntilMouseMoves:].
      * UIProcess/PageClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves): Added. Calls through to the PageClient.
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in: Added SetCursorHiddenUntilMouseMoves message.
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Sends SetCursorHiddenUntilMouseMoves message
      to the page proxy.
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf4519a5
    • mrobinson@webkit.org's avatar
      Build fixes for WebKit2. Ensure that all generated sources are · 26c1c9a6
      mrobinson@webkit.org authored
      on nodist primaries, that they are on forward declared variables
      so that BUILT_SOURCES is calculated properly and that zlib is
      included during linking (for WOFF support).
      
      .:
      
      * GNUmakefile.am:
      * Source/autotools/webkit.m4: Include test for zlib.
      
      Source/WebKit/gtk:
      
      * GNUmakefile.am:
      
      Source/WebKit2:
      
      * GNUmakefile.am:
      
      Tools:
      
      * WebKitTestRunner/GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26c1c9a6
  16. 14 Jul, 2011 1 commit
  17. 12 Jul, 2011 1 commit
    • joepeck@webkit.org's avatar
      ApplicationCache update should not immediately fail when reaching per-origin quota · 98b3b582
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64177
      
      Reviewed by Alexey Proskuryakov.
      
      2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
      
              Include spaceNeeded information in the output dumped for appcache quota delegates.
              Add and update tests related to handling of per-origin quotas.
      
              * http/tests/appcache/origin-quota-continued-download-expected.txt: Added.
              * http/tests/appcache/origin-quota-continued-download.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download.manifest: Added.
              New test which checks that there will still be a successful cache
              when the per-origin quota is reached and increased at the end of downloading.
      
              * http/tests/appcache/origin-quota-continued-download-multiple-manifests-expected.txt: Added.
              * http/tests/appcache/origin-quota-continued-download-multiple-manifests.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-1.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-1.manifest: Added.
              * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-2.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-2.manifest: Added.
              * http/tests/appcache/resources/quota-origin-continued-download.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download.manifest: Added.
              New test which checks that the spaceNeeded appropriately lists enough space for
              multiple manifests across multiple frames for the same origin.
      
              * http/tests/appcache/resources/quota-origin-iframe-3.manifest: Fix a typo.
              * http/tests/appcache/origin-quota.html:
              Update the old test to disallow automatic increase of the quota,
              which is the default handling of DRT when reaching the quota.
      
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
              * platform/wk2/Skipped:
              Skip the test on ports that don't implement ApplicationCache per-origin quotas.
      
      2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
      
              New behavior of handling ApplicationCache per-origin quotas. Previously,
              if the quota was reached while downloading we would fail the download
              and then prompt the user for a storage increase. This required a refresh,
              a redownload of resources, and the total storage was not known so the
              process could be repeated multiple times before an acceptable quota
              was found or the user disallowed an increase.
      
              The new behavior is to complete the download of the entire appcache.
              When the cache completes downloading and it is greater than the origin
              quota, prompt the user to allow a quota increase with the known space
              needed. If the quota is increased, the cache will succeed, otherwise
              it will fail with the normal failure steps.
      
              An alternative behavior is prompting while downloading immediately
              when the origin quota is reached, however at that point the entire
              space needed is unknown and so quota increases might not be enough
              and could result in multiple prompts to the user.
      
              Tests: http/tests/appcache/origin-quota-continued-download-multiple-manifests.html
                     http/tests/appcache/origin-quota-continued-download.html
      
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
              Rename instance variable to be more clear on its intent.
      
              (WebCore::ApplicationCacheGroup::didFinishLoading):
              Check the quota limit while downloading so we can fail early
              if the user already denied a quota increase.
      
              (WebCore::ApplicationCacheGroup::didReachOriginQuota):
              Pass the space needed information to the chrome client.
      
              (WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota):
              Removed. Instead convert the callers to update state and console
              log when the per-origin quota is reached. This allows us to follow
              the normal failure steps if the quota is reached at the end of a
              download, and the alternative short path when we fail during downloading.
      
              (WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota):
              Extract to a helper function.
      
              (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
              Allow for a quota increase at the end of the download now that
              we know the space needed. Then proceed to fail or succeed
              as we normally would.
      
              * loader/appcache/ApplicationCacheStorage.h:
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::checkOriginQuota):
              (WebCore::ApplicationCacheStorage::storeNewestCache):
              Extract checking the origin quota for when an ApplicationCacheGroup
              will be replacing an ApplicationCacheGroup into a helper function.
              The helper also provides an out parameter for the space needed
              to properly fit the new cache group if it wouldn't fit.
      
              * page/ChromeClient.h:
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::reachedApplicationCacheOriginQuota):
              Add a space needed parameter when reaching the per-origin quota.
      
      2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
      
              * WebView/WebUIDelegatePrivate.h:
              * DefaultDelegates/WebDefaultUIDelegate.m:
              (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
              Update the delegate to include a space needed parameter.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::reachedApplicationCacheOriginQuota):
              Call the delegate with the new space needed information.
      
      2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
      
              * Api/qwebpage.cpp:
              * Api/qwebpage.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
              * WebCoreSupport/ChromeClientQt.h:
              Pass the spaceNeeded value through to the applicationCacheQuotaExceeded signal.
      
      2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
      
              Add layoutTestController.disallowIncreaseForApplicationCacheQuota()
              to disable the default behavior of raising the default per-origin
              quota to 5MB when reached. This allows us to test what happens
              when the quota is reached and not increased.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (disallowIncreaseForApplicationCacheQuotaCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
              (LayoutTestController::setDisallowIncreaseForApplicationCacheQuota):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
              (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
              Expose a function to prevent automatically increasing the per-origin
              quota when the quota is reached. This allows us to test what happens
              when a user would "disallow" a quota increase.
      
              * DumpRenderTree/mac/UIDelegate.mm:
              (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
              Respect the new disallowIncrease flag and dump the spaceNeeded values
              for ports that implement application cache quotas.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98b3b582
  18. 11 Jul, 2011 1 commit
  19. 08 Jul, 2011 1 commit
  20. 01 Jul, 2011 1 commit
    • joone.hur@collabora.co.uk's avatar
      2011-07-01 Joone Hur <joone.hur@collabora.co.uk> · 0e25eeaf
      joone.hur@collabora.co.uk authored
              Reviewed by Martin Robinson.
      
              [GTK] Add DeviceOrientation feature
              https://bugs.webkit.org/show_bug.cgi?id=63720
      
              Add configure option to enable/disable DeviceOrientation feature.
      
              * configure.ac:
      2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add DeviceOrientation feature
              https://bugs.webkit.org/show_bug.cgi?id=63720
      
              Add DeviceMotionClientGtk.cpp and DeviceOrientationClientGtk.cpp to WebKitGtk+ build.
      
              * GNUmakefile.am: Add DeviceMotionClientGtk.cpp, DeviceOrientationClientGtk.cpp.
      2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add DeviceOrientation feature
              https://bugs.webkit.org/show_bug.cgi?id=63720
      
              Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.
      
              * GNUmakefile.am:
              * WebCoreSupport/DeviceMotionClientGtk.cpp: Added.
              (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk):
              (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk):
              (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed):
              (WebCore::DeviceMotionClientGtk::setController):
              (WebCore::DeviceMotionClientGtk::startUpdating):
              (WebCore::DeviceMotionClientGtk::stopUpdating):
              (WebCore::DeviceMotionClientGtk::currentDeviceMotion):
              * WebCoreSupport/DeviceMotionClientGtk.h: Added.
              * WebCoreSupport/DeviceOrientationClientGtk.cpp: Added.
              (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk):
              (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk):
              (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed):
              (WebCore::DeviceOrientationClientGtk::setController):
              (WebCore::DeviceOrientationClientGtk::startUpdating):
              (WebCore::DeviceOrientationClientGtk::stopUpdating):
              (WebCore::DeviceOrientationClientGtk::lastOrientation):
              * WebCoreSupport/DeviceOrientationClientGtk.h: Added.
              * webkit/webkitwebview.cpp:
              (webkit_web_view_init):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e25eeaf
  21. 28 Jun, 2011 1 commit
    • joone.hur@collabora.co.uk's avatar
      2011-06-28 Joone Hur <joone.hur@collabora.co.uk> · 8f628103
      joone.hur@collabora.co.uk authored
              Reviewed by Martin Robinson.
      
              [GTK] Allow to build WebKitGtk+ with accelerated compositing
              https://bugs.webkit.org/show_bug.cgi?id=63404
      
              WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms
              and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.
      
              * GNUmakefile.list.am:
              * platform/graphics/clutter/GraphicsLayerClutter.cpp: Added.
              (WebCore::GraphicsLayer::create): Not implemented yet.
              (WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
              (WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
              (WebCore::GraphicsLayerClutter::setNeedsDisplay): Ditto.
              (WebCore::GraphicsLayerClutter::setNeedsDisplayInRect): Ditto.
              * platform/graphics/clutter/GraphicsLayerClutter.h: Added.
      2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Allow to build WebKitGtk+ with accelerated compositing
              https://bugs.webkit.org/show_bug.cgi?id=63404
      
              WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms
              and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::attachRootGraphicsLayer): not implemented yet.
              (WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization): Ditto.
              (WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto.
              (WebKit::ChromeClient::allowedCompositingTriggers): Ditto.
              * WebCoreSupport/ChromeClientGtk.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f628103
  22. 27 Jun, 2011 1 commit
  23. 24 Jun, 2011 1 commit
    • dominicc@chromium.org's avatar
      2011-06-24 Dominic Cooney <dominicc@chromium.org> · 958d2e44
      dominicc@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              * Source/autotools/symbols.filter: Export symbols for GTK.
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Update tests to use internals.{ensureShadowRoot, shadowRoot,
              shadowPseudoId, removeShadowRoot} instead of layoutTestController.
      
              * fast/dom/HTMLKeygenElement/keygen-expected.txt:
              * fast/dom/HTMLKeygenElement/keygen.html:
              * fast/dom/HTMLMeterElement/meter-clone-expected.txt:
              * fast/dom/HTMLMeterElement/meter-clone.html:
              * fast/dom/HTMLProgressElement/progress-clone-expected.txt:
              * fast/dom/HTMLProgressElement/progress-clone.html:
              * fast/dom/shadow/activeelement-should-be-shadowhost.html:
              * fast/dom/shadow/create-content-element.html:
              * fast/dom/shadow/gc-shadow-expected.txt:
              * fast/dom/shadow/gc-shadow.html:
              * fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: shadowRoot of non-element throws now, so verify new behavior.
              * fast/dom/shadow/layout-tests-can-access-shadow.html:
              * fast/dom/shadow/nodetype.html:
              * fast/dom/shadow/tab-order-iframe-and-shadow.html:
              * fast/events/shadow-boundary-crossing.html:
              * fast/forms/resources/common.js:
              (getValidationMessageBubbleNode):
              * fast/html/clone-keygen-expected.txt:
              * fast/html/clone-keygen.html:
              * fast/html/clone-range-expected.txt:
              * fast/html/clone-range.html:
              * fast/html/details-clone.html:
              * fullscreen/video-controls-override-expected.txt:
              * fullscreen/video-controls-override.html:
              * media/audio-controls-do-not-fade-out.html:
              * media/media-controls.js:
              (mediaControlsButtonCoordinates):
              * media/video-controls-in-media-document.html:
              * platform/win/Skipped: shadowRoot and friends now available on win.
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              * WebCore.exp.in: Exports for symbols used by WebCoreTestSupport.
              * testing/Internals.cpp: The new home of shadowRoot and friends.
              (WebCore::Internals::ensureShadowRoot):
              (WebCore::Internals::shadowRoot):
              (WebCore::Internals::removeShadowRoot):
              (WebCore::Internals::shadowPseudoId):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from Chromium API. These are not
              required any more.
      
              * public/WebElement.h:
              * src/WebElement.cpp:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow-DOM related methods from GTK DRT API. These are not
              required any more.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from Mac API. These are not
              required any more.
      
              * DOM/WebDOMOperations.mm:
              * DOM/WebDOMOperationsPrivate.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow-DOM related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow-DOM related methods from Qt DRT API. These are not
              required any more.
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from WebKit2 API. These are not
              required any more.
      
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
              * win/WebKit2.def: Re-exports for symbols used by WebCoreTestSupport.
              * win/WebKit2CFLite.def: Same for Cairo.
      2011-06-24  Dominic Cooney   <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
              removeShadowRoot from layoutTestController; these have been
              replaced by equivalents in window.internals instead.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      958d2e44
  24. 22 Jun, 2011 2 commits
    • dglazkov@chromium.org's avatar
      2011-06-20 Dimitri Glazkov <dglazkov@chromium.org> · 3c9177a1
      dglazkov@chromium.org authored
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              1) Introduce FileChooserSettings to decouple setting querying from
              FileChooser. It's a simple copyable settings object, which allows us
              to capture the settings atomically and treat them as discardable data.
      
              2) Encapsulate lifetime management of FileChooser entirely in
              FileChooserClient. It's now a "smart" client, and allows us to
              completely remove FileChooser management concerns from a FileChooserClient
              implementor.
      
              3) Change creation of FileChooser to be on-demand, only when we actually
              need to choose file.
      
              4) Rearrange calling of dispatchFormControlChangeEvent to be at the end
              of a function and remove "am-I-dead" checks that are now unnecessary.
      
              5) Clean up directory upload code a bit, and make use of FileChooserSettings
              to pass directory name.
      
              Refactoring, covered by existing tests.
      
              * WebCore.exp.in: Removed unneeded export.
              * loader/EmptyClients.h: Removed now-unneded param.
              (WebCore::EmptyChromeClient::enumerateChosenDirectory): Ditto.
              * page/Chrome.cpp:
              (WebCore::Chrome::enumerateChosenDirectory): Ditto.
              * page/Chrome.h: Ditto.
              * page/ChromeClient.h: Ditto.
              * platform/FileChooser.cpp:
              (WebCore::FileChooserClient::~FileChooserClient): Added discarding of chooser.
              (WebCore::FileChooserClient::newFileChooser): Added.
              (WebCore::FileChooserClient::discardChooser): Added.
              (WebCore::FileChooser::FileChooser): Changed to use FileChooserSettings.
              (WebCore::FileChooser::create): Ditto.
              (WebCore::FileChooser::~FileChooser): Removed unneeded code.
              (WebCore::FileChooser::chooseFiles): Changed to pass results to the client.
              * platform/FileChooser.h:
              (WebCore::FileChooser::settings): Added.
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::filenamesFromFileList): Added a helper.
              (WebCore::RenderFileUploadControl::RenderFileUploadControl): Changed to use the helper, removed
                  chooser initialization code.
              (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed disconnection code, now
                  handled in FileChooserClient.
              (WebCore::RenderFileUploadControl::filesChosen): Renamed from valueChanged, rearranged to
                  fire dispatchFormControlChangeEvent last.
              (WebCore::RenderFileUploadControl::receiveDropForDirectoryUpload): Changed to use settings.
              (WebCore::RenderFileUploadControl::click): Ditto.
              (WebCore::RenderFileUploadControl::updateFromElement): Removed now-unneeded check.
              (WebCore::RenderFileUploadControl::receiveDroppedFiles): Changed to avoid using the chooser, since
                  it is not necessary.
              (WebCore::RenderFileUploadControl::fileTextValue): Changed to use input data, not chooser data.
              * rendering/RenderFileUploadControl.h: Updated decls.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::runOpenPanel): Changed to use settings.
              (WebKit::ChromeClientImpl::enumerateChosenDirectory): Updated decls.
              * src/ChromeClientImpl.h:
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              (WebCore::ChromeClientEfl::runOpenPanel): Changed to use settings.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::runOpenPanel): Changed to use settings.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::runOpenPanel): Changed to use settings.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::runOpenPanel): Changed to use settings.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::runOpenPanel): Changed to use settings.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::runOpenPanel): Changed to use settings.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c9177a1
    • carlosgc@webkit.org's avatar
      2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com> · 8e8a78c5
      carlosgc@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Make sure libsoup password manager macro is defined before including libsoup in webkitsoupauthdialog
              https://bugs.webkit.org/show_bug.cgi?id=63124
      
              Fixes a crash when building with --enable-debug.
      
              * webkit/webkitsoupauthdialog.h: Define
              LIBSOUP_I_HAVE_READ_BUG_594377_AND_KNOW_SOUP_PASSWORD_MANAGER_MIGHT_GO_AWAY
              before including libsoup.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e8a78c5
  25. 20 Jun, 2011 3 commits
    • mrobinson@webkit.org's avatar
      2011-06-10 Martin Robinson <mrobinson@igalia.com> · 4892916a
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] webkit_web_settings_copy does not copy all settings
              https://bugs.webkit.org/show_bug.cgi?id=62424
      
              Instead of trying to keep webkit_web_settings_copy up to date with
              property additions, create the object copy by dynamically initializing
              all webkit_web_settings properties at once.
      
              * tests/testwebsettings.c:
              (test_webkit_web_settings_copy): Create a test for webkit_web_settings copy.
              (main): Run the new test.
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_copy): Dynamically initialize all properties of the copy.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4892916a
    • mrobinson@webkit.org's avatar
      2011-06-20 Martin Robinson <mrobinson@igalia.com> · eb3daffd
      mrobinson@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] Clean up unecessary boilerplate from WebKitWebSettings and make private members meet WebKit style guidelines
              https://bugs.webkit.org/show_bug.cgi?id=61972
      
              Rename all private members of WebKitWebSettings to meet WebKit style guidelines and
              put the private struct definition in webkitwebsettingsprivate.h so it can be
              accessed from webkitwebview.cpp. This cuts down on the boilerplate immensely.
      
              * webkit/webkitwebsettings.cpp: Rename private members to meet WebKit style guidelines
              and allocate the private section with new/delete. This allows for using CString and removes
              the need for manual string memory management.
              * webkit/webkitwebsettingsprivate.h: Move the private struct definition here.
              * webkit/webkitwebview.cpp: Update to reflect new struct names. Remove boilerplate
              and other very small code cleanups.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb3daffd
    • carlosgc@webkit.org's avatar
      2011-06-20 Carlos Garcia Campos <cgarcia@igalia.com> · 63e230bf
      carlosgc@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Split libWebCore into two libWebCore and libWebCoreGtk
              https://bugs.webkit.org/show_bug.cgi?id=60539
      
              libWebCore contains all the webcore files except the ones actually
              using gtk while libWebCoreGtk contains only the files using
              gtk. It allows us to build a common WebCore lib and two different
              gtk WebCore libs depending on the gtk version. In WeKit2 gtk2 is
              not supported, but the plugin process needs to be built using gtk2
              because plugins like flash still use gtk2. For WebKit2, we build
              the common libWebCore and two libWebCoreGtk, one using gtk3 and
              the other one using gtk2.
      
              * GNUmakefile.am:
              * GNUmakefile.list.am:
      2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] Split libWebCore into two libWebCore and libWebCoreGtk
              https://bugs.webkit.org/show_bug.cgi?id=60539
      
              * GNUmakefile.am: Link to libWebCoreGtk.la too.
      2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] Split libWebCore into two libWebCore and libWebCoreGtk
              https://bugs.webkit.org/show_bug.cgi?id=60539
      
              * GNUmakefile.am: Link to libWebCoreGtk.la too.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63e230bf
  26. 19 Jun, 2011 1 commit
    • dglazkov@chromium.org's avatar
      2011-06-18 Dimitri Glazkov <dglazkov@chromium.org> · b32a1efe
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              Loading an icon and choosing files have similar async nature, but completely different
              lifetimes: FileChooser should only exist when we are actually attempting to choose a file,
              not anytime we need to render an input with a proper icon.
      
              This patch introduces FileIconLoader, a separate abstraction for loading an icon, and removes
              any notion of an icon from the FileChooser.
      
              Also, the loaded icon is now stored on the RenderFileUploadControl, which better matches its
              purpose.
      
              Refactoring, covered by existing tests.
      
              * CMakeLists.txt: Added FileIconLoader to build system.
              * GNUmakefile.list.am: Ditto.
              * WebCore.exp.in: Updated.
              * WebCore.gypi: Added FileIconLoader to build system.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * loader/EmptyClients.h: Updated.
              (WebCore::EmptyChromeClient::loadIconForFiles): Renamed function to better reflect what it does.
              * page/Chrome.cpp:
              (WebCore::Chrome::loadIconForFiles): Ditto.
              * page/Chrome.h: Ditto.
              * page/ChromeClient.h: Ditto.
              * platform/FileChooser.cpp:
              (WebCore::FileChooser::FileChooser): Removed now-unnecessary bool.
              (WebCore::FileChooser::create): Removed the tangled web.
              (WebCore::FileChooser::clear): Removed icon-related code.
              (WebCore::FileChooser::chooseFiles): Ditto.
              * platform/FileChooser.h:
              * platform/FileIconLoader.cpp: Copied from Source/WebCore/platform/FileChooser.cpp.
              (WebCore::FileIconLoaderClient::~FileIconLoaderClient): Added.
              (WebCore::FileIconLoader::create): Added.
              (WebCore::FileIconLoader::disconnectClient): Added.
              (WebCore::FileIconLoader::notifyFinished): Added.
              (WebCore::FileIconLoader::FileIconLoader): Added.
              * platform/FileIconLoader.h: Copied from Source/WebCore/platform/FileChooser.cpp.
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::RenderFileUploadControl): Added new member initializations.
              (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Added FileIconLoader disconnect.s
              (WebCore::RenderFileUploadControl::requestIcon): Added a helper.
              (WebCore::RenderFileUploadControl::valueChanged): Changed to request an icon load.
              (WebCore::RenderFileUploadControl::updateRendering): Added implementation of FileIconLoaderClient func.
              (WebCore::RenderFileUploadControl::updateFromElement): Added clearing of icon.
              (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use new member directly.
              (WebCore::RenderFileUploadControl::paintObject): Ditto.
              (WebCore::RenderFileUploadControl::fileTextValue): Ditto.
              * rendering/RenderFileUploadControl.h: Updated decls.
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::loadIconForFiles): Renamed to better reflect the intent.
              * src/ChromeClientImpl.h: Ditto.
              * src/WebIconLoadingCompletionImpl.cpp:
              (WebKit::WebIconLoadingCompletionImpl::WebIconLoadingCompletionImpl): Changed to use FileIconLoader.
              (WebKit::WebIconLoadingCompletionImpl::didLoadIcon): Ditto.
              * src/WebIconLoadingCompletionImpl.h: Dito.
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              (WebCore::ChromeClientEfl::loadIconForFiles): Renamed.
              * WebCoreSupport/ChromeClientEfl.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::loadIconForFiles): Renamed.
              * WebCoreSupport/ChromeClientGtk.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              (WebCore::ChromeClientHaiku::loadIconForFiles): Renamed.
              * WebCoreSupport/ChromeClientHaiku.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::loadIconForFiles): Renamed.
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::loadIconForFiles): Renamed.
              * WebCoreSupport/ChromeClientQt.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::loadIconForFiles): Renamed.
              * WebCoreSupport/WebChromeClient.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/ChromeClientWinCE.cpp:
              (WebKit::ChromeClientWinCE::loadIconForFiles): Renamed.
              * WebCoreSupport/ChromeClientWinCE.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::chooseIconForFiles): Renamed.
              * WebKitSupport/ChromeClientWx.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::loadIconForFiles): Renamed.
              * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b32a1efe
  27. 17 Jun, 2011 1 commit
    • joone.hur@collabora.co.uk's avatar
      2011-06-17 Joone Hur <joone.hur@collabora.co.uk> · 910be159
      joone.hur@collabora.co.uk authored
              Reviewed by Martin Robinson.
      
              [GTK] Replace GdkRectangle by cairo_rectangle_int_t
              https://bugs.webkit.org/show_bug.cgi?id=60687
      
              Replace GdkRectangle by cairo_rectangle_int_t.
      
              * configure.ac: Check whether Cairo version is higher than 1.10.
      2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Replace GdkRectangle by cairo_rectangle_int_t
              https://bugs.webkit.org/show_bug.cgi?id=60687
      
              Replace GdkRectangle by cairo_rectangle_int_t.
      
              * wtf/gobject/GTypedefs.h: Replace GdkRectangle by cairo_rectangle_int_t.
      2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Replace GdkRectangle by cairo_rectangle_int_t
              https://bugs.webkit.org/show_bug.cgi?id=60687
      
              Replace GdkRectangle by cairo_rectangle_int_t.
      
              * GNUmakefile.list.am: Added IntRectCairo.cpp instead of IntRectGtk.cpp
              * platform/graphics/IntRect.h: IntRect class can be instantiated through the given cairo_rectangle_int_t
              instead of GdkRectangle.
              * platform/graphics/cairo/IntRectCairo.cpp: Add the constructor and operator for handling cairo_rectangle_int_t.
              (WebCore::IntRect::IntRect):
              (WebCore::IntRect::operator cairo_rectangle_int_t):
              * platform/graphics/gtk/IntRectGtk.cpp: Include this file only for Gtk+2.
              * platform/gtk/GtkPluginWidget.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
              (WebCore::GtkPluginWidget::invalidateRect):
      2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Replace GdkRectangle by cairo_rectangle_int_t
              https://bugs.webkit.org/show_bug.cgi?id=60687
      
              Replace GdkRectangle by cairo_rectangle_int_t.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
              (DumpRenderTreeSupportGtk::firstRectForCharacterRange):
              (DumpRenderTreeSupportGtk::rectangleForSelection):
              * WebCoreSupport/DumpRenderTreeSupportGtk.h: Ditto.
      2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Replace GdkRectangle by cairo_rectangle_int_t
              https://bugs.webkit.org/show_bug.cgi?id=60687
      
              Replace GdkRectangle by cairo_rectangle_int_t.
      
              * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
              (createBitmapContextFromWebView):
              * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
              (firstRectForCharacterRangeCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      910be159