1. 13 May, 2010 40 commits
    • mrobinson@webkit.org's avatar
      2010-05-13 Martin Robinson <mrobinson@igalia.com> · 58c93cd3
      mrobinson@webkit.org authored
              No review.
      
              [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
              https://bugs.webkit.org/show_bug.cgi?id=39101
      
              * platform/gtk/Skipped: Skip failing test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58c93cd3
    • bweinstein@apple.com's avatar
      <rdar://problem/7975410> · 31a06491
      bweinstein@apple.com authored
      Reviewed by Tim Hatcher.
      
      Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector.
      
      * Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate.
      * Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild.
      * WebView.cpp:
      (WebView::reportException): Make sure the function was called with a context from a WebView, and call
          WebCore::reportException.
      * WebView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31a06491
    • mrobinson@webkit.org's avatar
      2010-05-13 Martin Robinson <mrobinson@igalia.com> · 4d2e3422
      mrobinson@webkit.org authored
              No review. Finish adding css1 baselines for GTK+.
      
              * platform/gtk/Skipped: Unskip tests which now have baselines.
              * platform/gtk/css1/basic/class_as_selector-expected.txt:
              * platform/gtk/css1/box_properties/width-expected.txt: Added.
              * platform/gtk/css1/cascade/cascade_order-expected.txt: Added.
              * platform/gtk/css1/cascade/important-expected.txt: Added.
              * platform/gtk/css1/classification/display-expected.txt: Added.
              * platform/gtk/css1/classification/list_style-expected.txt: Added.
              * platform/gtk/css1/classification/list_style_image-expected.txt: Added.
              * platform/gtk/css1/classification/list_style_position-expected.txt: Added.
              * platform/gtk/css1/classification/list_style_type-expected.txt: Added.
              * platform/gtk/css1/classification/white_space-expected.txt: Added.
              * platform/gtk/css1/color_and_background/background-expected.txt: Added.
              * platform/gtk/css1/color_and_background/background_attachment-expected.txt: Added.
              * platform/gtk/css1/color_and_background/background_color-expected.txt: Added.
              * platform/gtk/css1/color_and_background/background_image-expected.txt: Added.
              * platform/gtk/css1/color_and_background/background_position-expected.txt: Added.
              * platform/gtk/css1/color_and_background/background_repeat-expected.txt: Added.
              * platform/gtk/css1/color_and_background/color-expected.txt: Added.
              * platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt: Added.
              * platform/gtk/css1/font_properties/font-expected.txt: Added.
              * platform/gtk/css1/font_properties/font_family-expected.txt: Added.
              * platform/gtk/css1/font_properties/font_size-expected.txt: Added.
              * platform/gtk/css1/font_properties/font_style-expected.txt: Added.
              * platform/gtk/css1/font_properties/font_variant-expected.txt: Added.
              * platform/gtk/css1/font_properties/font_weight-expected.txt: Added.
              * platform/gtk/css1/formatting_model/canvas-expected.txt: Added.
              * platform/gtk/css1/formatting_model/floating_elements-expected.txt: Added.
              * platform/gtk/css1/formatting_model/height_of_lines-expected.txt: Added.
              * platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt: Added.
              * platform/gtk/css1/formatting_model/inline_elements-expected.txt: Added.
              * platform/gtk/css1/formatting_model/replaced_elements-expected.txt: Added.
              * platform/gtk/css1/formatting_model/vertical_formatting-expected.txt: Added.
              * platform/gtk/css1/pseudo/anchor-expected.txt: Added.
              * platform/gtk/css1/pseudo/firstletter-expected.txt: Added.
              * platform/gtk/css1/pseudo/firstline-expected.txt: Added.
              * platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt: Added.
              * platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt: Added.
              * platform/gtk/css1/text_properties/letter_spacing-expected.txt: Added.
              * platform/gtk/css1/text_properties/line_height-expected.txt: Added.
              * platform/gtk/css1/text_properties/text_align-expected.txt: Added.
              * platform/gtk/css1/text_properties/text_decoration-expected.txt: Added.
              * platform/gtk/css1/text_properties/text_indent-expected.txt: Added.
              * platform/gtk/css1/text_properties/text_transform-expected.txt: Added.
              * platform/gtk/css1/text_properties/vertical_align-expected.txt: Added.
              * platform/gtk/css1/text_properties/word_spacing-expected.txt: Added.
              * platform/gtk/css1/units/color_units-expected.txt: Added.
              * platform/gtk/css1/units/length_units-expected.txt: Added.
              * platform/gtk/css1/units/percentage_units-expected.txt: Added.
              * platform/gtk/css1/units/urls-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d2e3422
    • mrobinson@webkit.org's avatar
      2010-05-13 Martin Robinson <mrobinson@igalia.com> · 1d402b2c
      mrobinson@webkit.org authored
              No review. Correcting baseline.
      
              * platform/gtk/css1/basic/class_as_selector-expected.txt: Correct baseline.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d402b2c
    • timothy@apple.com's avatar
      WebCore: Expose WebCore::reportException and WebCore::toJSDOMWindow symbols. · 2fd46610
      timothy@apple.com authored
      Reviewed by Sam Weinig.
      
      * WebCore.base.exp: Expose reportException and toJSDOMWindow.
      
      WebKit/mac: Allow reporting exceptions that occur when using JavaScriptCore APIs
      to the Web Inspector.
      
      <rdar://problem/7975410>
      
      Reviewed by Sam Weinig.
      
      * WebView/WebView.mm:
      (+[WebView _reportException:inContext:]): Call WebCore::reportException after checking
      that the global object is a DOMWindow.
      * WebView/WebViewPrivate.h: Added _reportException:inContext:.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fd46610
    • joepeck@webkit.org's avatar
      2010-05-13 Joseph Pecoraro <joepeck@webkit.org> · 62f8a12c
      joepeck@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Clearing Breakpoints Too Often
              https://bugs.webkit.org/show_bug.cgi?id=39094
      
              Minor resets should preserve both workers and breakpoints.
      
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype.reset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62f8a12c
    • hausmann@webkit.org's avatar
      Symbian build fix. · 9e139144
      hausmann@webkit.org authored
      [Qt] Updated the def file with new exports.
      
      * symbian/eabi/QtWebKitu.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e139144
    • mrobinson@webkit.org's avatar
      2010-05-13 Martin Robinson <mrobinson@igalia.com> · 05e38252
      mrobinson@webkit.org authored
              No review needed.
      
              [GTK] Some test results are one pixel different on x86_64
              https://bugs.webkit.org/show_bug.cgi?id=39022
      
              * platform/gtk/Skipped: Skipping this test because of single-pixel difference.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05e38252
    • ossy@webkit.org's avatar
      Unreviewed. · 42a9c6bb
      ossy@webkit.org authored
      [Qt] Platform specific expected file updated after r59385.
      
      Adding block elements to a block and removing them changes the height of the element.
      https://bugs.webkit.org/show_bug.cgi?id=38874
      
      * platform/qt/editing/deleting/5408255-expected.txt: updated.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42a9c6bb
    • simon.fraser@apple.com's avatar
      2010-05-13 Simon Fraser <simon.fraser@apple.com> · e38ba061
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Fix scrolling in composited iframes
              https://bugs.webkit.org/show_bug.cgi?id=39088
              <rdar://problem/7980099>
      
              When propagating compositing out of iframes, we have to update the position of the iframe content
              layers on scrolling.
      
              Test: compositing/iframes/scrolling-iframe.html
      
              * page/FrameView.cpp:
              (WebCore::FrameView::scrollPositionChanged): Call updateContentLayerScrollPosition() when scrolling.
      
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Renamed setRootPlatformLayerClippingBox() to updateContentLayerOffset().
      
              * rendering/RenderLayerCompositor.h:
              * rendering/RenderLayerCompositor.cpp: Rename m_clippingLayer to m_clipLayer to go better with m_scrollLayer.
              (WebCore::RenderLayerCompositor::updateContentLayerOffset): Renamed from setRootPlatformLayerClippingBox().
                  Set the size of the clipping layer from the FrameView now, so that scrollbars are not clipped out.
                  Update the scroll layer position too.
              (WebCore::RenderLayerCompositor::updateContentLayerScrollPosition): Set the position of the scroll layer
                  when the ScrollView is scrolled.
              (WebCore::RenderLayerCompositor::rootPlatformLayer): m_clippingLayer rename.
              (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): m_clippingLayer rename. Also create m_scrollLayer at
                  the same time as the clip layer, and clean it up as necessary.
              (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): m_clippingLayer rename, and clean up the m_scrollLayer too.
              (WebCore::RenderLayerCompositor::detachRootPlatformLayer): m_clippingLayer rename
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e38ba061
    • mrobinson@webkit.org's avatar
      2010-05-13 Martin Robinson <mrobinson@igalia.com> · 401b4643
      mrobinson@webkit.org authored
              No review. Adding baselines for many of the css1 tests. I've checked these manually.
      
              * platform/gtk/Skipped: Unskipping tests.
              * platform/gtk/css1/basic/class_as_selector-expected.txt: Added.
              * platform/gtk/css1/basic/comments-expected.txt: Added.
              * platform/gtk/css1/basic/containment-expected.txt: Added.
              * platform/gtk/css1/basic/contextual_selectors-expected.txt: Added.
              * platform/gtk/css1/basic/grouping-expected.txt: Added.
              * platform/gtk/css1/basic/id_as_selector-expected.txt: Added.
              * platform/gtk/css1/basic/inheritance-expected.txt: Added.
              * platform/gtk/css1/box_properties/acid_test-expected.txt: Added.
              * platform/gtk/css1/box_properties/border-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_bottom-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_bottom_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_bottom_width-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_color-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_color_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_left-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_left_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_left_width-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_left_width_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_right-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_right_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_right_width-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_right_width_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_style-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_style_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_top-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_top_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_top_width-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_top_width_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_width-expected.txt: Added.
              * platform/gtk/css1/box_properties/border_width_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/clear-expected.txt: Added.
              * platform/gtk/css1/box_properties/clear_float-expected.txt: Added.
              * platform/gtk/css1/box_properties/float-expected.txt: Added.
              * platform/gtk/css1/box_properties/float_elements_in_series-expected.txt: Added.
              * platform/gtk/css1/box_properties/float_margin-expected.txt: Added.
              * platform/gtk/css1/box_properties/float_on_text_elements-expected.txt: Added.
              * platform/gtk/css1/box_properties/height-expected.txt: Added.
              * platform/gtk/css1/box_properties/margin-expected.txt: Added.
              * platform/gtk/css1/box_properties/margin_bottom-expected.txt: Added.
              * platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/margin_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/margin_left-expected.txt: Added.
              * platform/gtk/css1/box_properties/margin_left_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/margin_right-expected.txt: Added.
              * platform/gtk/css1/box_properties/margin_right_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/margin_top-expected.txt: Added.
              * platform/gtk/css1/box_properties/margin_top_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/padding-expected.txt: Added.
              * platform/gtk/css1/box_properties/padding_bottom-expected.txt: Added.
              * platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/padding_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/padding_left-expected.txt: Added.
              * platform/gtk/css1/box_properties/padding_left_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/padding_right-expected.txt: Added.
              * platform/gtk/css1/box_properties/padding_right_inline-expected.txt: Added.
              * platform/gtk/css1/box_properties/padding_top-expected.txt: Added.
              * platform/gtk/css1/box_properties/padding_top_inline-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      401b4643
    • weinig@apple.com's avatar
      Follow up to: · e13007aa
      weinig@apple.com authored
      Fix for https://bugs.webkit.org/show_bug.cgi?id=38221
      Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
      Part of <rdar://problem/7921275>
      
      Reviewed by Anders Carlsson.
      
      Fix failing tests on Leopard.
      
      Initialize m_hasCachedCSSText in CSSPrimitiveValue::init methods.
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::init):
      (WebCore::CSSPrimitiveValue::cssText): Add extra assertion.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e13007aa
    • mrobinson@webkit.org's avatar
      2010-05-13 Martin Robinson <mrobinson@igalia.com> · 070791d8
      mrobinson@webkit.org authored
              No review. Rebaselining test after r59385.
      
              * platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Rebaseline
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      070791d8
    • beidson@apple.com's avatar
      Adding fast/loader/recursive-before-unload-crash-expected.html to the gtk skipped list · c848f373
      beidson@apple.com authored
      because it needs more logging in its DRT to pass:
      * platform/gtk/Skipped:
      
      Adding fast/loader/recursive-before-unload-crash-expected.html to the qt skipped list
      because it's hanging:
      * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c848f373
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · 26cc47d5
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=39089
              <rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode
      
              Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll
              investigate a more extensible solution when there are more, and we know what the
              typical restictions are.
      
              * Misc/WebNSURLExtras.mm:
              (allCharactersAllowedByTLDRules):
              (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26cc47d5
    • tkent@chromium.org's avatar
      2010-05-13 Kent Tamura <tkent@chromium.org> · 146e2184
      tkent@chromium.org authored
              Reviewed by Darin Adler.
      
              Can't submit a form with <input type=checkbox required>
              https://bugs.webkit.org/show_bug.cgi?id=39065
      
              * fast/forms/interactive-validation-required-checkbox-expected.txt: Added.
              * fast/forms/interactive-validation-required-checkbox.html: Added.
      2010-05-13  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              Can't submit a form with <input type=checkbox required>
              https://bugs.webkit.org/show_bug.cgi?id=39065
      
              Test: fast/forms/interactive-validation-required-checkbox.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::setChecked):
                Update the validity cache when a checkbox state is changed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      146e2184
    • beidson@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=38928 · 01a5a194
      beidson@apple.com authored
      Reviewed by NOBODY (Layout test fix)
      
      Add Tiger specific results for my new test.
      
      * platform/mac-tiger/fast/loader/recursive-before-unload-crash-expected.txt: Copied from fast/loader/recursive-before-unload-crash-expected.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01a5a194
    • kbr@google.com's avatar
      2010-05-13 Kenneth Russell <kbr@google.com> · 1bfaadac
      kbr@google.com authored
              Reviewed by Dimitri Glazkov.
      
              Alias WebGLArray type names to TypedArray type names
              https://bugs.webkit.org/show_bug.cgi?id=39036
      
              Exposed the existing WebGL<T>Array constructor functions on the
              DOMWindow under the naming convention in the TypedArray spec. The
              implementations will be renamed in a subsequent bug, and the
              aliases to the WebGL<T>Array type names eventually removed. Ran
              all layout tests (including WebGL) in Safari, and WebGL tests in
              Chromium.
      
              Test: revised array-unit-tests.html to test both type names.
              Revised global prototype and constructor tests to ignore new types.
      
              * bindings/generic/RuntimeEnabledFeatures.h:
              (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled):
              (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::arrayBuffer):
              (WebCore::JSDOMWindow::int8Array):
              (WebCore::JSDOMWindow::uint8Array):
              (WebCore::JSDOMWindow::int32Array):
              (WebCore::JSDOMWindow::uint32Array):
              (WebCore::JSDOMWindow::int16Array):
              (WebCore::JSDOMWindow::uint16Array):
              (WebCore::JSDOMWindow::floatArray):
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::V8DOMWindow::ArrayBufferAccessorGetter):
              (WebCore::V8DOMWindow::Int8ArrayAccessorGetter):
              (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter):
              (WebCore::V8DOMWindow::Int16ArrayAccessorGetter):
              (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter):
              (WebCore::V8DOMWindow::Int32ArrayAccessorGetter):
              (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter):
              (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
              * page/DOMWindow.idl:
      2010-05-13  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Alias WebGLArray type names to TypedArray type names
              https://bugs.webkit.org/show_bug.cgi?id=39036
      
              Exposed the existing WebGL<T>Array constructor functions on the
              DOMWindow under the naming convention in the TypedArray spec. The
              implementations will be renamed in a subsequent bug, and the
              aliases to the WebGL<T>Array type names eventually removed. Ran
              all layout tests (including WebGL) in Safari, and WebGL tests in
              Chromium.
      
              Test: revised array-unit-tests.html to test both type names.
              Revised global prototype and constructor tests to ignore new types.
      
              * fast/canvas/webgl/array-unit-tests-expected.txt:
              * fast/canvas/webgl/array-unit-tests.html:
              * fast/dom/Window/script-tests/window-property-descriptors.js:
              * fast/dom/Window/window-properties.html:
              * fast/dom/script-tests/prototype-inheritance.js:
              * fast/js/script-tests/global-constructors.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bfaadac
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=39084 · 488c3b7b
      hyatt@apple.com authored
      Reviewed by Anders Carlsson.
      
      Improve :visited style resolution to reduce its memory footprint and to make some speed adjustments and
      simplifications.
      
      (1) Tie the caching of link state on CSSStyleSelector to the element.  Just clear out the element when
      style resolution finishes for the unvisited case to avoid caching across external calls.  The internal
      calls share the cache just fine by doing this.
      
      (2) Delete the RenderStyle if the link is unvisited.  This shouldn't take long enough to make us vulnerable
      to timing attacks, and it makes sure the overall footprint stays the way it used to be for unvisited links.
      
      (3) Limit the set of properties that can be applied to :visited links to only the colors it supports.  This
      stops images from being loadable from :visited rules.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::init):
      (WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
      (WebCore::CSSStyleSelector::initElement):
      (WebCore::CSSStyleSelector::canShareStyleWithElement):
      (WebCore::CSSStyleSelector::styleForElement):
      (WebCore::CSSStyleSelector::pseudoStyleForElement):
      (WebCore::isValidVisitedLinkProperty):
      (WebCore::CSSStyleSelector::applyProperty):
      * css/CSSStyleSelector.h:
      * rendering/style/RenderStyle.cpp:
      (WebCore::colorIncludingFallback):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      488c3b7b
    • weinig@apple.com's avatar
      Fix for https://bugs.webkit.org/show_bug.cgi?id=38221 · 69bb625c
      weinig@apple.com authored
      Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
      Part of <rdar://problem/7921275>
      
      Reviewed by Darin Adler.
      
      - Use an external cache to speedup cssText for CSSPrimitiveValue instead
        of an extra member variable.
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::cssTextCache):
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::cleanup):
      (WebCore::CSSPrimitiveValue::cssText):
      * css/CSSPrimitiveValue.h:
      (WebCore::CSSPrimitiveValue::):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69bb625c
    • enrica@apple.com's avatar
      Adding block elements to a block and removing them changes the height of the element. · fefcb1d6
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=38874
      
      Reviewed by Dave Hyatt.
      
      WebCore: 
      
      The initial height of an empty editable block is different from the height of the same block after we add block elements
      and remove them.
              
      Test: editing/deleting/delete-block-contents-004.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::layoutBlock): resetting m_childrenInline flag to true when layout a block with no children.
      
      LayoutTests: 
      
      The initial height of an empty editable block is different from the height of the same block after we add block elements
      and remove them.
              
      * editing/deleting/delete-block-contents-004-expected.txt: Added.
      * editing/deleting/delete-block-contents-004.html: Added.
      The following tests results have been updated to reflect the new renderer structure.
      * editing/deleting/in-visibly-empty-root-expected.txt:
      * platform/mac/editing/deleting/5408255-expected.txt:
      * platform/mac/editing/deleting/delete-select-all-001-expected.txt:
      * platform/mac/editing/selection/4895428-1-expected.txt:
      * platform/mac/editing/selection/4895428-4-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fefcb1d6
    • beidson@apple.com's avatar
      Repro crash at www.sears.com (infinite recursion in beforeunload handler) · 7617ce77
      beidson@apple.com authored
      <rdar://problem/7965182> and https://bugs.webkit.org/show_bug.cgi?id=38928
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: fast/loader/recursive-before-unload-crash.html
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::shouldClose): Copied from Frame, with the pageDismissal flag set.
      * loader/FrameLoader.h:
      
      * page/Frame.cpp:
      (WebCore::Frame::shouldClose): Forward to the new FrameLoader::shouldClose().
      * page/Frame.h:
      (WebCore::Frame::existingDOMWindow):
      
      LayoutTests: 
      
      * fast/loader/recursive-before-unload-crash-expected.txt: Added.
      * fast/loader/recursive-before-unload-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7617ce77
    • eric@webkit.org's avatar
      2010-05-13 Sheriff Bot <webkit.review.bot@gmail.com> · 5f7c2b93
      eric@webkit.org authored
              Unreviewed, rolling out r59376.
              http://trac.webkit.org/changeset/59376
              https://bugs.webkit.org/show_bug.cgi?id=39080
      
              Broke window prototype tests (Requested by jamesr on #webkit).
      
              * fast/canvas/webgl/array-unit-tests-expected.txt:
              * fast/canvas/webgl/array-unit-tests.html:
      2010-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r59376.
              http://trac.webkit.org/changeset/59376
              https://bugs.webkit.org/show_bug.cgi?id=39080
      
              Broke window prototype tests (Requested by jamesr on #webkit).
      
              * bindings/generic/RuntimeEnabledFeatures.h:
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::webGLFloatArray):
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * page/DOMWindow.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f7c2b93
    • diegohcg@webkit.org's avatar
      2010-05-13 Diego Gonzalez <diegohcg@webkit.org> · 27f6b296
      diegohcg@webkit.org authored
          Reviewed by Kenneth Rohde Christiansen.
      
          [Qt] Improve QtLauncher user agent dialog resize
          https://bugs.webkit.org/show_bug.cgi?id=39062
      
          * QtLauncher/main.cpp:
          (LauncherWindow::showUserAgentDialog):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27f6b296
    • pfeldman@chromium.org's avatar
      2010-05-13 Pavel Feldman <pfeldman@chromium.org> · 2a0595bc
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: A disabled style property cannot be deleted.
      
              https://bugs.webkit.org/show_bug.cgi?id=39057
      
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::applyStyleText):
      
      2010-05-13  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: A disabled style property cannot be deleted.
      
              https://bugs.webkit.org/show_bug.cgi?id=39057
      
              * inspector/elements-tests.js:
              (frontend_getSelectedElementStyles):
              * inspector/styles-disable-then-delete-expected.txt: Added.
              * inspector/styles-disable-then-delete.html: Added.
              * inspector/styles-disable-then-enable.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a0595bc
    • diegohcg@webkit.org's avatar
      2010-05-11 Diego Gonzalez <diegohcg@webkit.org> · be924c47
      diegohcg@webkit.org authored
          Reviewed by Kenneth Rohde Christiansen.
      
          [Qt] tst_QWebPage::inputMethods failing on Maemo5
          https://bugs.webkit.org/show_bug.cgi?id=38685
      
          Check if the SIP (Software Input Panel) is triggered, which usually happens
          in the case of a mobile platforms, an user input form receives a mouse click.
      
          * tests/qwebpage/tst_qwebpage.cpp:
          (tst_QWebPage::inputMethods):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be924c47
    • eric@webkit.org's avatar
      2010-05-13 Eric Seidel <eric@webkit.org> · 8b84a716
      eric@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Disable compositing/iframes tests on the commit-queue as a workaround for  bug 38912
              https://bugs.webkit.org/show_bug.cgi?id=39067
      
              Fix yet another typo in my original hack.
              I also added another unit test for this fix.
      
              * Scripts/webkitpy/common/config/ports.py:
              * Scripts/webkitpy/common/config/ports_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b84a716
    • tonikitoo@webkit.org's avatar
      [Qt] REGRESSION(r58497) tst_QGraphicsWebView::crashOnViewlessWebPages() is failing · 082f7914
      tonikitoo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=38655
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-05-11
      Reviewed by Laszlo Gombos.
      
      Fix double free by moving the connect till after the resize.
      
      The bug is causes by the fact that a resize of an empty page causes a
      layout, thus deleting the qgraphicswebview before setHtml is called,
      which then deletes it again, causing a double free.
      
      * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
      (tst_QGraphicsWebView::crashOnViewlessWebPages):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      082f7914
    • tonikitoo@webkit.org's avatar
      Regression(r59152): QGraphicsPageClient is not forwarding scroll and update... · f5c877a0
      tonikitoo@webkit.org authored
      Regression(r59152): QGraphicsPageClient is not forwarding scroll and update events to view https://bugs.webkit.org/show_bug.cgi?id=39016
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-05-12
      Reviewed by Laszlo Gombos.
      
      Some forward calls got lost during the refatory.
      
      * WebCoreSupport/PageClientQt.cpp:
      (WebCore::PageClientQGraphicsWidget::scroll):
      (WebCore::PageClientQGraphicsWidget::update):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5c877a0
    • kbr@google.com's avatar
      2010-05-12 Kenneth Russell <kbr@google.com> · 1e1dd8f8
      kbr@google.com authored
              Reviewed by Dimitri Glazkov.
      
              Alias WebGLArray type names to TypedArray type names
              https://bugs.webkit.org/show_bug.cgi?id=39036
      
              Exposed the existing WebGL<T>Array constructor functions on the
              DOMWindow under the naming convention in the TypedArray spec. The
              implementations will be renamed in a subsequent bug, and the
              aliases to the WebGL<T>Array type names eventually removed. Ran
              all WebGL layout tests in Safari and Chromium.
      
              Test: revised array-unit-tests.html to test both type names.
      
              * bindings/generic/RuntimeEnabledFeatures.h:
              (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled):
              (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled):
              (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::arrayBuffer):
              (WebCore::JSDOMWindow::int8Array):
              (WebCore::JSDOMWindow::uint8Array):
              (WebCore::JSDOMWindow::int32Array):
              (WebCore::JSDOMWindow::uint32Array):
              (WebCore::JSDOMWindow::int16Array):
              (WebCore::JSDOMWindow::uint16Array):
              (WebCore::JSDOMWindow::floatArray):
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::V8DOMWindow::ArrayBufferAccessorGetter):
              (WebCore::V8DOMWindow::Int8ArrayAccessorGetter):
              (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter):
              (WebCore::V8DOMWindow::Int16ArrayAccessorGetter):
              (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter):
              (WebCore::V8DOMWindow::Int32ArrayAccessorGetter):
              (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter):
              (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
              * page/DOMWindow.idl:
      2010-05-12  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Alias WebGLArray type names to TypedArray type names
              https://bugs.webkit.org/show_bug.cgi?id=39036
      
              Exposed the existing WebGL<T>Array constructor functions on the
              DOMWindow under the naming convention in the TypedArray spec. The
              implementations will be renamed in a subsequent bug, and the
              aliases to the WebGL<T>Array type names eventually removed. Ran
              all WebGL layout tests in Safari and Chromium.
      
              Test: revised array-unit-tests.html to test both type names.
      
              * fast/canvas/webgl/array-unit-tests-expected.txt:
              * fast/canvas/webgl/array-unit-tests.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e1dd8f8
    • eric@webkit.org's avatar
      2010-05-13 Eric Seidel <eric@webkit.org> · 8f404ff0
      eric@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Disable compositing/iframes tests on the commit-queue as a workaround for  bug 38912
              https://bugs.webkit.org/show_bug.cgi?id=39067
      
              My previous (unreviewed) hack didn't actually work due to checking "mac" instead of "Mac".
              This change fixes my hack, and unit tests it.
      
              * Scripts/webkitpy/tool/mocktool.py:
               - Make it possible to make run_command log too.
              * Scripts/webkitpy/tool/steps/runtests.py:
               - Fix my hack to actually work.
              * Scripts/webkitpy/tool/steps/steps_unittest.py:
               - Test my hack (and basic RunTests behavior as well).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f404ff0
    • beidson@apple.com's avatar
      Part of <rdar://problem/7965182> and https://bugs.webkit.org/show_bug.cgi?id=38928 · 53b02e73
      beidson@apple.com authored
      Reviewed by John Sullivan.
      
      No new tests. (No change in behavior)
      
      m_unloadEventBeingDispatched was already overloaded to include both unload and pagehide events.
      In general, these are "page dismissal" events, and might also include beforeunload, so let's rename
      the flag!
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      (WebCore::FrameLoader::stopLoading):
      (WebCore::FrameLoader::loadURL):
      (WebCore::FrameLoader::loadWithDocumentLoader):
      (WebCore::FrameLoader::stopAllLoaders):
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
      (WebCore::FrameLoader::pageHidden):
      * loader/FrameLoader.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53b02e73
    • tonikitoo@webkit.org's avatar
      2010-05-13 Antonio Gomes <tonikitoo@webkit.org>, Yi Shen <yi.4.shen@nokia.com> · f3aedd15
      tonikitoo@webkit.org authored
          Reviewed by Kenneth Christiansen.
      
          [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
          https://bugs.webkit.org/show_bug.cgi?id=37759
      
          WebKit/qt:
      
          * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
          (DumpRenderTreeSupportQt::markerTextForListItem):
          (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
          * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
          WebKitTools:
      
          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
          (LayoutTestController::computedStyleIncludingVisitedInfo):
          * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
          LayoutTests:
      
          * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3aedd15
    • joepeck@webkit.org's avatar
      2010-05-13 Joseph Pecoraro <joepeck@webkit.org> · 499e43d0
      joepeck@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Event Markers should be hidden in Resource's "Size" Graph
              https://bugs.webkit.org/show_bug.cgi?id=39074
      
              Added Show / Hide event dividers functionality to the timeline grid,
              and included delegation functions in AbstractTimelinePanel.
      
              * inspector/front-end/AbstractTimelinePanel.js: delegate to the inner grid
              (WebInspector.AbstractTimelinePanel.prototype.hideEventDividers):
              (WebInspector.AbstractTimelinePanel.prototype.showEventDividers):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.populateSidebar): save a reference to the size graph item to know when its selected
              (WebInspector.ResourcesPanel.prototype._graphSelected): if the size graph is selected hide the dividers, otherwise show them
              * inspector/front-end/TimelineGrid.js:
              (WebInspector.TimelineGrid.prototype.hideEventDividers): set the container to display: none
              (WebInspector.TimelineGrid.prototype.showEventDividers): set the container to display: block
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      499e43d0
    • aroben@apple.com's avatar
      Convert status bar text to UTF-8 before logging it on Windows · 1f191872
      aroben@apple.com authored
      We were previously logging the text using printf("%S", bstr). This
      converts the UTF-16 BSTR to a multibyte string using wctomb, which
      uses the codepage for the current locale to perform the conversion.
      The conversion was failing, causing printf to bail and truncate the
      string. By converting to UTF-8 manually before logging, we avoid this
      issue (and also end up with UTF-8 output, which is what the expected
      results contain). We may have to do this in other places in DRT,
      eventually.
      
      Fixes <http://webkit.org/b/38849> REGRESSION (r59016):
      plugins/set-status.html fails on Windows
      
      Reviewed by Alexey Proskuryakov.
      
      * DumpRenderTree/win/DumpRenderTree.cpp:
      (toUTF8): Moved this here from FrameLoadDelegate. Renamed from
      BSTRtoString.
      
      * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of toUTF8.
      
      * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed BSTRtoString.
      (descriptionSuitableForTestResult): Updated for rename.
      
      * DumpRenderTree/win/UIDelegate.cpp:
      (UIDelegate::setStatusText): Convert the status bar text to UTF-8
      before logging it so that Windows won't try (and fail) to convert it
      to the current locale's codepage.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f191872
    • aroben@apple.com's avatar
      Fix typo in sunspider-compare-results.js that caused incorrect two-sample t... · 882bfcfa
      aroben@apple.com authored
      Fix typo in sunspider-compare-results.js that caused incorrect two-sample t statistics to be computed
      
      Fixes <http://webkit.org/b/38768> SunSpider computes incorrect
      two-sample t statistics
      
      Reviewed by Darin Adler.
      
      * resources/sunspider-compare-results.js:
      (sunspiderCompareResults.resultLine): Fixed the calculation of the t
      variable to match the definition of a two-sample t statistic. Looks
      like this was just a simple typo.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      882bfcfa
    • mrobinson@webkit.org's avatar
      2010-05-13 Martin Robinson <mrobinson@igalia.com> · e7ad02f9
      mrobinson@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Events tests failing
              https://bugs.webkit.org/show_bug.cgi?id=31436
      
              Unskip these two test which are now passing.
      
              * platform/gtk/Skipped: Unskip two tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7ad02f9
    • pfeldman@chromium.org's avatar
      2010-05-13 Pavel Feldman <pfeldman@chromium.org> · cfe11233
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: main inspector toolbar takes noticeable time to expand.
      
              https://bugs.webkit.org/show_bug.cgi?id=39013
      
              * src/js/DevTools.js:
              (devtools.domContentLoaded):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfe11233
    • mrobinson@webkit.org's avatar
      2010-05-13 Martin Robinson <mrobinson@igalia.com> · f7034f72
      mrobinson@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Two forms tests failing
              https://bugs.webkit.org/show_bug.cgi?id=31435
      
              Unskip passing tests.
      
              * platform/gtk/Skipped: Unskip these tests, because they are passing now.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7034f72
    • chang.shu@nokia.com's avatar
      2010-05-13 Chang Shu <chang.shu@nokia.com> · f5a3aba3
      chang.shu@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Based on the spec and Philip Taylor's test suite, strokeStyle and fillStyle attributes
              must initially have the string value #000000.
              The link to the spec:
              http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.colours.default
      
              https://bugs.webkit.org/show_bug.cgi?id=39068
      
              The complete test suite is in the process of checking in.
              https://bugs.webkit.org/show_bug.cgi?id=20553
      
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::State::State):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5a3aba3