1. 08 Apr, 2013 40 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] Update BlackBerry JavaScript API · 583f6077
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114065
      
      Patch by Jeff Rogers <jrogers@rim.com> on 2013-04-08
      Reviewed by Rob Buis.
      
      .:
      
      Internal PR 317350
      Export JSC symbols in BlackBerry build.
      
      * Source/cmake/OptionsBlackBerry.cmake:
      
      Source/WebKit:
      
      Internal PR 317350
      Remove obsolete files.
      
      * PlatformBlackBerry.cmake:
      
      Source/WebKit/blackberry:
      
      Internal PR 317350
      Add new API for determining if user gesture is being processed.
      Remove obsolete files.
      Properly expose JSC global context.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
      (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
      (BlackBerry::WebKit::WebPage::globalContext):
      (BlackBerry::WebKit::WebPage::isProcessingUserGesture):
      (WebKit):
      * Api/WebPage.h:
      * Api/WebPageClient.h:
      * Api/WebPage_p.h:
      (WebPagePrivate):
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      * WebCoreSupport/ChromeClientBlackBerry.h:
      (ChromeClientBlackBerry):
      * WebCoreSupport/ClientExtension.cpp: Removed.
      * WebCoreSupport/ClientExtension.h: Removed.
      * WebCoreSupport/ExternalExtension.cpp: Removed.
      * WebCoreSupport/ExternalExtension.h: Removed.
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      583f6077
    • benjamin@webkit.org's avatar
      Update the Mac WebKit2 TestExpectations for http/tests/canvas/canvas-slow-font-loading.html · ad84e456
      benjamin@webkit.org authored
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
      
      * platform/mac-wk2/TestExpectations: The test is flaky in release. Mark it as such.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad84e456
    • commit-queue@webkit.org's avatar
      [BlackBerry] Clean up render theme code. · df8800bd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114216
      
      Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-08
      Reviewed by Rob Buis.
      
      BlackBerry PR 323062
      
      Clean up redundant code.
      
      * platform/blackberry/RenderThemeBlackBerry.cpp:
      (WebCore):
      (WebCore::RenderThemeBlackBerry::paintSliderTrack):
      * platform/blackberry/RenderThemeBlackBerry.h:
      (RenderThemeBlackBerry):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df8800bd
    • rniwa@webkit.org's avatar
      Use port 6665 instead of 6667 since the latter doesn't seem to work well. · c75d42ef
      rniwa@webkit.org authored
      * Scripts/webkitpy/common/config/irc.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c75d42ef
    • andersca@apple.com's avatar
      Call Netscape Plugin's toString() and valueOf() instead of providing default implementation · 0cb90f97
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113139
      
      Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-04-08
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      Tests: plugins/npruntime/tostring.html
             plugins/npruntime/valueof.html
      
      * bridge/c/c_instance.cpp:
      (JSC::Bindings::CInstance::~CInstance):
      (JSC::Bindings::CInstance::invokeMethod):
      (JSC::Bindings::CInstance::invokeDefaultMethod):
      (Bindings):
      (JSC::Bindings::CInstance::invokeConstruct):
      (JSC::Bindings::CInstance::stringValue):
      (JSC::Bindings::CInstance::booleanValue):
      (JSC::Bindings::CInstance::valueOf):
      (JSC::Bindings::CInstance::toJSPrimitive):
      * bridge/c/c_instance.h:
      (CInstance):
      
      Tools:
      
      * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
      * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
      * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
      (ToStringAndValueOfObject):
      (ToStringAndValueOfObject::ToStringAndValueOfObject):
      (ScriptableObject):
      (ToStringAndValueOfObject::ScriptableObject::hasMethod):
      (ToStringAndValueOfObject::ScriptableObject::invoke):
      (ToStringAndValueOfObject::ScriptableObject::pluginTest):
      (ToStringAndValueOfObject::NPP_GetValue):
      * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
      * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
      * GNUmakefile.am:
      
      LayoutTests:
      
      * platform/qt-mac/TestExpectations:
      * platform/wk2/TestExpectations:
      * plugins/npruntime/tostring-expected.txt: Added.
      * plugins/npruntime/tostring.html: Added.
      * plugins/npruntime/valueof-expected.txt: Added.
      * plugins/npruntime/valueof.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cb90f97
    • timothy_horton@apple.com's avatar
      REGRESSION (r138858): Crash in WebCore::FrameLoader::~FrameLoader() when... · e39867bb
      timothy_horton@apple.com authored
      REGRESSION (r138858): Crash in WebCore::FrameLoader::~FrameLoader() when opening page in a background tab
      https://bugs.webkit.org/show_bug.cgi?id=109935
      <rdar://problem/13225963>
      
      Reviewed by Brady Eidson.
      
      Previously, we were deciding if a Page could go into
      the PageCache by blacklisting certain load types. Instead,
      whitelist the load types that we know can go into the cache,
      so that newly-added load types are not cached unless
      that is explicitly desired.
      
      The crash occurs when a page which is actively loading
      is put into the page cache while doing a redirect with
      FrameLoadTypeRedirectWithLockedBackForwardList (note that
      this is a redirect that was not covered in the blacklist),
      and then promptly removed from the page cache, resulting
      in resources from the redirect target (the now-active page)
      being incorrectly destroyed.
      
      No new tests, only known crash repro case is extremely
      timing dependent (and only happens in WebKit2, with tiled
      drawing, in background tabs).
      
      * history/PageCache.cpp:
      (WebCore::PageCache::canCache):
      
      Adjust a test which depended on slow-redirects going
      into the page cache (which will no longer happen)
      to instead click on a link.
      
      * fast/history/timed-refresh-in-cached-frame.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e39867bb
    • andersca@apple.com's avatar
      Fix build. · 86ec616b
      andersca@apple.com authored
      * platform/network/ResourceHandle.cpp:
      (WebCore::ResourceHandle::continueDidReceiveResponse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86ec616b
    • beidson@apple.com's avatar
      Web/Plugin process deadlock initializing async plugins. · 4979eaed
      beidson@apple.com authored
      <rdar://problem/13525232> and https://bugs.webkit.org/show_bug.cgi?id=114217
      
      Reviewed by Anders Carlsson.
      
             The "Async initialization complete" messages probably don't have to be synchronous.
      
      * PluginProcess/WebProcessConnection.cpp:
      (WebKit::WebProcessConnection::createPluginAsynchronously): Notify of initialization success/failure asynchronously.
      * WebProcess/Plugins/PluginProxy.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4979eaed
    • andersca@apple.com's avatar
      Add an async version of ResourceHandle::didReceiveResponse · ac87e20e
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114215
      
      Reviewed by Sam Weinig.
      
      Source/WebCore:
      
      In order to support converting NSURLConnections to NSURLDownloads when using the network process
      we need an async version of didReceiveResponse.
      
      * WebCore.exp.in:
      * platform/network/ResourceHandleClient.cpp:
      (WebCore::ResourceHandleClient::didReceiveResponseAsync):
      Just call continueDidReceiveResponse().
      
      * platform/network/mac/ResourceHandleMac.mm:
      (WebCore::ResourceHandle::continueWillSendRequest):
      Split up a single condition in two, making it easier to see which assertion fails.
      
      (WebCore::ResourceHandle::continueDidReceiveResponse):
      Call -[WebCoreResourceHandleAsOperationQueueDelegate continueDidReceiveResponse].
      
      (WebCore::ResourceHandle::continueShouldUseCredentialStorage):
      (WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace):
      (WebCore::ResourceHandle::continueWillCacheResponse):
      Split up a single condition in two, making it easier to see which assertion fails.
      
      * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
      * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
      (-[WebCoreResourceHandleAsOperationQueueDelegate continueDidReceiveResponse]):
      Signal the semaphore.
      
      (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
      Call didReceiveResponseAsync on the main thread and wait on the semaphore.
      
      Source/WebKit2:
      
      * NetworkProcess/NetworkResourceLoader.cpp:
      (WebKit::NetworkResourceLoader::didReceiveResponseAsync):
      Send the message and then call continueDidReceiveResponse.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac87e20e
    • commit-queue@webkit.org's avatar
      [GTK] Configure should verify ICU is installed on mingw · 58bc7339
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113645
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2013-04-08
      Reviewed by Gustavo Noronha Silva.
      
      * Source/autotools/FindDependencies.m4: When falling back to hard-coded compiler flags
      for ICU and mingw, check that headers do exist on the system and error out otherwise.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58bc7339
    • roger_fong@apple.com's avatar
      Windows build fix fix. · b28d6fee
      roger_fong@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b28d6fee
    • bdakin@apple.com's avatar
      Crash in ScrollingCoordinator::mainThreadScrollingReasons() when going back · b6eb305b
      bdakin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114214
      -and corresponding-
      <rdar://problem/13208616>
      
      Reviewed by Anders Carlsson.
      
      When a page is restoring from the page cache, the mainFrame can have a null 
      Document. So we should null-check the Document here. 
      
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6eb305b
    • roger_fong@apple.com's avatar
      Windows build fix. · 56fe78af
      roger_fong@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56fe78af
    • oliver@apple.com's avatar
      Make resolve more robust in the face of lookup misses · da4c535f
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114211
      
      Reviewed by Filip Pizlo.
      
      This simply short circuits the resolve operations in the
      event that we don't find a path to a property.  There's no
      repro case for this happening unfortunately.
      
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::LLINT_SLOW_PATH_DECL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da4c535f
    • commit-queue@webkit.org's avatar
      [GTK] Bump gnome-themes-standard to 3.6.0 · 14ddb34f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114155
      
      Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-04-08
      Reviewed by Martin Robinson.
      
      * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
      dependency of gnome-themes-standard accordingly.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14ddb34f
    • commit-queue@webkit.org's avatar
      [BlackBerry] More null checks for m_mainFrame · 6dee1028
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114172
      
      Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-04-08
      Reviewed by Rob Buis.
      
      After r147744, some unit tests were crashing on WebPage
      shutdown, because BackingStorePrivate::repaint() now uses
      pixelContentsRect() (accessing m_webPage->contentsRect())
      instead of BackingStoreClient::contentsRect(). In m_webPage,
      m_mainFrame had already been set to 0.
      
      Make us more robust against these errors by checking
      the existence of m_mainFrame more diligently.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
      (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
      (BlackBerry::WebKit::WebPagePrivate::contentsSize):
      (BlackBerry::WebKit::WebPagePrivate::absoluteVisibleOverflowSize):
      (BlackBerry::WebKit::WebPagePrivate::setViewMode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dee1028
    • levin@chromium.org's avatar
      Remove my watchlist entries. · 850fdf10
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114180
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/common/config/committers.py:
      * Scripts/webkitpy/common/config/watchlist:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      850fdf10
    • jer.noble@apple.com's avatar
      Unreviewed gardening. Remove expected results added by r147824. · 476a5f1b
      jer.noble@apple.com authored
      * platform/mac-future/accessibility/press-action-is-first-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      476a5f1b
    • abucur@adobe.com's avatar
      Simplify ContainerNode::removeChildren · 24c25908
      abucur@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113517
      
      Reviewed by Darin Adler.
      
      The patch is based on the work made by Elliott Sprehn. He kindly agreed
      for me to finalize the last bits and pieces of the fix.
      
      Source/WebCore:
      
      Simplify ContainerNode::removeChildren by merging the loops and removing
      willRemoveChildren. This removes two traversals of the children, avoids
      refing and derefing all the children once, avoids allocating a second
      NodeVector of children, and means we detach() in the same order as
      normal removal.
      
      This does mean you can get into an infinite loop with DOMNodeRemoved
      listeners by continously adding nodes but this is true in all other browsers
      and the current behavior is bad because it means you don't get notified
      of nodes added during removal (which other browsers do notify of). This
      patch removes the containerNode.html test that originally tested for this
      infinite loop and adds a new one that tests that all nodes get notified.
      
      This makes PerformanceTests/Parser/innerHTML-setter.html 2-6% faster.
      
      There's also a new test verifying ranges remain consistent if modified
      inside an mutation event handler. Without the patch it's possible to create
      a range with boundaries outside of the DOM tree.
      
      Tests: fast/dom/Range/range-remove-children-event.html
             fast/events/mutation-during-innerHTML.html
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::removeChildren):
      * dom/Document.cpp:
      * dom/Document.h: nodeChildrenWillBeRemoved is not needed any more.
      * dom/Range.cpp:
      * dom/Range.h: nodeChildrenWillBeRemoved is not needed any more.
      
      LayoutTests:
      
      Remove containerNode.html test since it was checking for an infinite
      loop when adding DOM nodes inside a DOMNodeRemoved mutation event
      handler, but we actually do want to allow an infinite loop here for
      correctness and compatability with other browsers.
      
      Also added mutation-during-innerHTML which checks that all nodes
      are notified of being removed even if they were added during the
      DOMNodeRemoved notification.
      
      There's a new test range-remove-children-event that verifies the
      ranges modified inside a mutation event handler remain consistent.
      
      * fast/dom/MutationObserver/added-out-of-order-expected.txt:
      * fast/dom/MutationObserver/added-out-of-order.html:
      * fast/dom/Range/range-remove-children-event-expected.txt: Added.
      * fast/dom/Range/range-remove-children-event.html: Added.
      * fast/dom/containerNode-expected.txt: Removed.
      * fast/dom/containerNode.html: Removed.
      * fast/events/mutation-during-innerHTML-expected.txt: Added.
      * fast/events/mutation-during-innerHTML.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24c25908
    • oliver@apple.com's avatar
      Build fix. · 0dc07c6b
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dc07c6b
    • simon.fraser@apple.com's avatar
      Remove some #includes in headers in rendering code · 40a77435
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114079
      
      Reviewed by Sam Weinig.
      
      Clean up #includes in RenderObject, RenderLayer etc.
      Moved makeMatrixRenderable() into RenderLayer.app, allowing
      the removal of a TransformationMatrix.h include.
      
      Make some RenderLayer functions that deal with filters not inline,
      to avoid including RenderLayerFilterInfo.h.
      
      * platform/graphics/GraphicsLayer.h:
      * platform/graphics/ImageOrientation.cpp:
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      * platform/graphics/qt/GraphicsContextQt.cpp:
      * platform/graphics/transforms/AffineTransform.cpp:
      * platform/graphics/transforms/AffineTransform.h:
      * rendering/RenderBoxModelObject.h:
      * rendering/RenderLayer.cpp:
      (WebCore::makeMatrixRenderable):
      (WebCore::RenderLayer::filterRenderer):
      (WebCore::RenderLayer::filterInfo):
      (WebCore::RenderLayer::ensureFilterInfo):
      (WebCore::RenderLayer::removeFilterInfoIfNeeded):
      * rendering/RenderLayer.h:
      * rendering/RenderLayerBacking.h:
      * rendering/RenderLineBoxList.h:
      * rendering/RenderObject.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40a77435
    • robert@webkit.org's avatar
      Unreviewed, rolling out r147850. · fc892827
      robert@webkit.org authored
      http://trac.webkit.org/changeset/147850
      https://bugs.webkit.org/show_bug.cgi?id=113706
      
      Changeset crossed paths with 147505, which is the same fix.
      
      Source/WebCore:
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::inlineLogicalWidth):
      
      LayoutTests:
      
      * fast/inline/inline-with-empty-inline-children-expected.txt:
      * fast/inline/inline-with-empty-inline-children.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc892827
    • ap@apple.com's avatar
      <rdar://problem/12834449> Crashes in WebSocketChannel::processFrame when processing a ping · 9729b33f
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=114178
      
              Reviewed by Brady Eidson.
      
              No test, I could never reproduce even manually.
      
              Calling enqueueRawFrame() could change incoming buffer, so a subsequent skipBuffer()
              would operate on wrong assumptions. This happened because enqueueRawFrame() actually
              tried to process the queue, and send failure sometimed clears m_buffer.
      
              Fixing this by decoupling enqueuing from sending, and making sure that skipBuffer()
              in ping frame processing case is performed at a safe time.
      
              * Modules/websockets/WebSocketChannel.cpp:
              (WebCore::WebSocketChannel::send):
              (WebCore::WebSocketChannel::startClosingHandshake):
              (WebCore::WebSocketChannel::processFrame):
              (WebCore::WebSocketChannel::enqueueTextFrame):
              (WebCore::WebSocketChannel::enqueueRawFrame):
              (WebCore::WebSocketChannel::enqueueBlobFrame):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9729b33f
    • mvujovic@adobe.com's avatar
      REGRESSION (r147502): Animations of CA filters broken · 311d1ffd
      mvujovic@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114067
      
      Reviewed by Dean Jackson.
      
      Revert r147502 [1] because it broke CA filter animations.
              
      [1]: http://trac.webkit.org/changeset/147502
      
      Source/WebCore: 
      
      * platform/graphics/IntRectExtent.h:
      (WebCore::IntRectExtent::isZero):
      (IntRectExtent):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::needsCompositingLayersRebuiltForOverflow):
      (WebCore):
      (WebCore::RenderLayer::styleChanged):
      * rendering/RenderLayer.h:
      (RenderLayer):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateFilters):
      (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
      * rendering/RenderLayerBacking.h:
      (RenderLayerBacking):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::calculateCompositedBounds):
      
      Source/WTF: 
      
      * wtf/Platform.h:
      
      LayoutTests: 
      
      * compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
      * compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
      * compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
      * compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
      * css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Removed.
      * css3/filters/composited-layer-bounds-after-sw-blur-animation.html: Removed.
      * css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Removed.
      * css3/filters/composited-layer-bounds-with-composited-blur.html: Removed.
      * css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Removed.
      * css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html: Removed.
      * css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Removed.
      * css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html: Removed.
      * css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Removed.
      * css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html: Removed.
      * css3/filters/filter-change-repaint-composited-expected.png:
      * css3/filters/filter-change-repaint-composited.html:
      * platform/qt/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      311d1ffd
    • commit-queue@webkit.org's avatar
      [BlackBerry] Force horizontal list to be horizontal scrollable. · ac437e0d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114173
      
      Patch by Iris Wu <shuwu@blackberry.com> on 2013-04-08
      Reviewed by Rob Buis.
      
      Force content to be horizontal/vertical overscrollable if it
      scrolls in horizontal/vertical way.
      
      PR 237440
      Internally Reviewed by Arvid Nilsson.
      
      * WebKitSupport/InRegionScrollableArea.cpp:
      (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac437e0d
    • commit-queue@webkit.org's avatar
      Allow KeywordLookupGenerator.py to work on Windows with Windows style line endings · 268f0cab
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63234
      
      Patch by Justin Haygood <jhaygood@reaktix.com> on 2013-04-08
      Reviewed by Oliver Hunt.
      
      * KeywordLookupGenerator.py:
      (parseKeywords):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      268f0cab
    • fpizlo@apple.com's avatar
      Source/JavaScriptCore: REGRESSION(r146669): Assertion hit in... · cf5bf39a
      fpizlo@apple.com authored
      Source/JavaScriptCore: REGRESSION(r146669): Assertion hit in JSC::DFG::SpeculativeJIT::fillSpeculateCell() running webgl tests
      https://bugs.webkit.org/show_bug.cgi?id=114129
      <rdar://problem/13594898>
      
      Reviewed by Darin Adler.
              
      The check to see if we need a cell check when simplifying a GetById or PutById needs to be hoisted to
      above where we abstractly execute the instruction, since after we abstracting execute it, it will
      seem like it no longer needs the cell check.
      
      * dfg/DFGConstantFoldingPhase.cpp:
      (JSC::DFG::ConstantFoldingPhase::foldConstants):
      
      LayoutTests: REGRESSION(r146669): Assertion hit in JSC::DFG::SpeculativeJIT::fillSpeculateCell() running webgl tests
      https://bugs.webkit.org/show_bug.cgi?id=114129 and https://bugs.webkit.org/show_bug.cgi?id=90649
      <rdar://problem/13594898> and <rdar://problem/11815727>
      
      Reviewed by Darin Adler.
              
      Unskip these tests because they give us DFG coverage and they are now passing.
      
      * platform/mac/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf5bf39a
    • jocelyn.turcotte@digia.com's avatar
      [Qt] Avoid "QFont::setPixelSize: Pixel size <= 0 (0)" · 72ea76b1
      jocelyn.turcotte@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114175
      
      Reviewed by Allan Sandfeld Jensen.
      
      QFont doesn't support a 0-size but WebCore does.
      Leave our QFont in its default state in this case to avoid the warning.
      
      * platform/graphics/qt/FontPlatformDataQt.cpp:
      (WebCore::FontPlatformData::FontPlatformData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72ea76b1
    • commit-queue@webkit.org's avatar
      Counter still gets incremented when counter-increment is set to none · 659caf7b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84985
      
      Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-04-08
      Reviewed by Darin Adler.
      
      When the counter-increment is set to none, no counters are incremented.
      
      Source/WebCore:
      
      Tests: New test cases added in fast/css/counters/counter-increment-tests.htm
      
      * css/StyleBuilder.cpp:
      (WebCore::ApplyPropertyCounter::applyValue):
      
      LayoutTests:
      
      * fast/css/counters/counter-increment-tests-expected.txt: Added new test cases.
      * fast/css/counters/counter-increment-tests.htm: Added new test cases.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      659caf7b
    • akling@apple.com's avatar
      REGRESSION(r147894): Broke WTFReportBacktrace() on Mac. · 9c8caead
      akling@apple.com authored
      <http://webkit.org/b/114174>
      
      Reviewed by Anders Carlsson.
      
      An #elif !OS(ANDROID) block was erroneously removed, turn it into an #else instead since
      that path will still be taken for OS(DARWIN).
      
      * wtf/Assertions.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c8caead
    • commit-queue@webkit.org's avatar
      Crash in WebCore::ElementRuleCollector::collectMatchingRulesForList · 76803844
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113458
      
      Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-04-08
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      A stylesheet which has been invalidated (type changed from "" or
      "text/css") was not correctly removed from the list of active
      style sheets when its children are changed.
      
      This change releases StyleElement::m_sheet in advance of calling
      DocumentStyleSheetCollection::updateActiveStyleSheets.
      
      (StyleElement::clearSheet calls CSSStyleSheet::clearOwnerNode calls
      CSSStyleSheet::didMutate calls Document::styleResolverChanged calls
      DocumentStyleSheetCollection::updateActiveStyleSheets)
      
      Test: fast/css/style-element-invalidation-crash.html
      
      * dom/StyleElement.cpp:
      (WebCore::StyleElement::clearSheet): Release m_sheet before we
        trigger an update of the active style sheets.
      
      LayoutTests:
      
      * fast/css/style-element-invalidation-crash-expected.txt: Added.
      * fast/css/style-element-invalidation-crash.html: Added.
      * fast/css/stylesheet.innerHTML-calls-didmutate.html: Removed.
      * fast/css/stylesheet.innerHTML-calls-didmutate-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76803844
    • carlosgc@webkit.org's avatar
      [GTK] Build Platform as a separate static library · e5e37553
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114164
      
      Reviewed by Martin Robinson.
      
      .:
      
      * GNUmakefile.am: Add webkit2platform_sources definition.
      
      Source/WebKit2:
      
      This way we reduce a bit the amount of files compiled twice
      because of the plugin process.
      
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * Platform/gtk/WorkQueueGtk.cpp: Remove unused header.
      * Platform/unix/SharedMemoryUnix.cpp: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5e37553
    • graouts@apple.com's avatar
      Stop skipping first part of test in LayoutTests/media/track/opera/interfaces/TextTrack/cues.html · a9db6a7b
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104255
      
      Updated test to match the one hosted by W3C which has corrected the reported error.
      
      Reviewed by Eric Carlson.
      
      * media/track/opera/interfaces/TextTrack/cues-expected.txt:
      * media/track/opera/interfaces/TextTrack/cues.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9db6a7b
    • carlosgc@webkit.org's avatar
      [GTK] DOM objects created wrapping a base class have incorrect GObject type · 0464259a
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113132
      
      Reviewed by Gustavo Noronha Silva.
      
      Source/WebCore:
      
      Some of the DOM methods can create a concrete instance of another
      object, but return a base class. GObject bindings provide custom
      kit implementations for Node, Element, Event and EvenTarget, so
      any concrete HTMLElement wrapped as an HTMLElement ends up
      wrapping the right WebCore object but in the wrong GObject type.
      This affects not only HTMLElements, but any polymorphic object
      wrapped using a base class.
      This patch changes the way objects are created, so that all
      classes have their own kit implementation, but for polymorphic
      objects the kit implementation of the base class is always
      used. The kit method of polymorphic base classes use a generic
      wrap method instead of the wrapFoo method like all other
      classes. In the static code we provide the implementation of the
      generic wrap method for every polimorphic base class, falling back
      to their wrapFoo method if the concrete object can't be used to
      wrap the object.
      Both WebKitDOMBinding and WebKitHTMLElementWrapperFactory now provide
      implementations of wrap and have been renamed to WebKitDOMPrivate
      and WebKitDOMHTMLPrivate.
      
      * bindings/gobject/GNUmakefile.am:
      * bindings/gobject/WebKitDOMBinding.cpp: Removed.
      * bindings/gobject/WebKitDOMEventTarget.cpp:
      (WebKit::kit): Moved kit implementation from WebKitDOMBinding for
      consistency with all other objects that have their own kit.
      (WebKit::core): Updated to match the core implementation fo all
      other objects.
      * bindings/gobject/WebKitDOMEventTargetPrivate.h:
      (WebCore):
      (WebKit):
      * bindings/gobject/WebKitDOMHTMLPrivate.cpp: Added.
      (WebKit): Use preprocessor macros to define and set the wrap
      functions of all HTML elements, removing a lot of boilerplate code
      and making it easier to add new wrap functions in the future.
      (WebKit::wrap):
      * bindings/gobject/WebKitDOMHTMLPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.h.
      (WebCore):
      (WebKit):
      * bindings/gobject/WebKitDOMObject.cpp:
      * bindings/gobject/WebKitDOMPrivate.cpp: Added.
      (WebKit):
      (WebKit::wrap):
      * bindings/gobject/WebKitDOMPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitDOMBinding.h.
      (WebCore):
      (WebKit):
      * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Removed.
      * bindings/scripts/CodeGeneratorGObject.pm:
      (IsBaseType): Helper function to check if a type is a base class.
      (GetBaseClass): Helper function to get the base class for a given
      parent type.
      (GenerateFunction): Remove special case for EventTarget since the
      kit prototype of EventTarget is in its private header like all
      other objects.
      (GenerateCFile): Add a kit implementation for all objects.
      (IsPolymorphic): Helper function to check if the given type is the
      base class of a polymorphic object.
      (Generate): Include the private header of the base class for
      polymorphic objects.
      (WriteData): Remove the special case for WebKitDOMNode since now
      all objects has a kit method.
      * bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
      (WebKit::kit):
      * bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
      (WebKit::kit):
      * bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
      (WebKit):
      * bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestTypedefsPrivate.h:
      (WebKit):
      
      Source/WebKit/gtk:
      
      Remove WebKitDOMBindindg.h include from several files because it's
      been renamed and it was not actually needed.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      * WebCoreSupport/EditorClientGtk.cpp:
      * webkit/webkithittestresult.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0464259a
    • abecsi@webkit.org's avatar
      Fix the build with strict GCC 4.8 · a42ddd32
      abecsi@webkit.org authored
      Unreviewed build fix.
      
      Initialize dragImage to suppress GCC's warning about it being possibly used uninitialized,
      which results is a build failure with GCC 4.8 that sets -Werror=maybe-uninitialized.
      
      No new tests needed.
      
      * page/DragController.cpp:
      (WebCore::DragController::doImageDrag):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a42ddd32
    • zandobersek@gmail.com's avatar
      Remove the unused LayoutTestSupport class · d3dafbaf
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114170
      
      Reviewed by Alexey Proskuryakov.
      
      The LayoutTestSupport class is not used by any port anywhere in the code and should be removed.
      
      No new tests - no changes in functionality.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/LayoutTestSupport.cpp: Removed.
      * platform/LayoutTestSupport.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3dafbaf
    • zandobersek@gmail.com's avatar
      Remove WebCore::(enable|disable)SecureTextInput methods · d8a93601
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114126
      
      Reviewed by Alexey Proskuryakov.
      
      Remove the enableSecureTextInput and disableSecureTextInput methods and all the codepaths leading to them.
      These were used only by the Chromium port and are as such not required anymore.
      
      No new tests - no changes in functionality.
      
      * GNUmakefile.list.am:
      * WebCore.order:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/Document.cpp:
      (WebCore::Document::Document):
      * dom/Document.h:
      (Document):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::focusedOrActiveStateChanged):
      * editing/FrameSelection.h:
      (FrameSelection):
      * html/PasswordInputType.cpp:
      * html/PasswordInputType.h:
      (PasswordInputType):
      * page/Frame.cpp:
      (WebCore::Frame::setDocument):
      * platform/SecureTextInput.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8a93601
    • jer.noble@apple.com's avatar
      Unreviewed build fix; r147892 moved an export definition out of · ed74b149
      jer.noble@apple.com authored
      a protective #ifdef, causing a link error on platforms which do
      not define that method.
      
      * WebCore.exp.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed74b149
    • oliver@apple.com's avatar
      Build fix. · a1a0ddc1
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1a0ddc1
    • commit-queue@webkit.org's avatar
      [Qt] Enable text tracks from track elements · bc3b5dd2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113522
      
      Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-08
      Reviewed by Jocelyn Turcotte.
      
      No new tests because they're already there. This just enables the feature.
      
      * Target.pri:
      * bindings/generic/RuntimeEnabledFeatures.cpp:
      (WebCore):
      * platform/qt/LocalizedStringsQt.cpp:
      (WebCore):
      (WebCore::textTrackSubtitlesText):
      (WebCore::textTrackOffText):
      (WebCore::textTrackNoLabelText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc3b5dd2