1. 17 Jan, 2011 13 commits
    • ddkilzer@apple.com's avatar
      2011-01-17 David Kilzer <ddkilzer@apple.com> · 5827990f
      ddkilzer@apple.com authored
              <http://webkit.org/b/52524> fast/dom/Range/range-clone-contents.html fails only on Windows
      
              Reviewed by Alexey Proskuryakov.
      
              * platform/win/Skipped: Removed
              fast/dom/Range/range-clone-contents.html.  It appears the
              Windows buildbots need a clean build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5827990f
    • jberlin@webkit.org's avatar
      REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when · d617a3b2
      jberlin@webkit.org authored
      navigating back to an unreachable URL
      https://bugs.webkit.org/show_bug.cgi?id=52388
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Test: http/tests/navigation/go-back-to-error-page.html
      
      * history/PageCache.cpp:
      (WebCore::PageCache::canCachePageContainingThisFrame):
      Do not cache any error pages (which we can recognize as having substitute data and/or an
      unreachableURL).
      
      Tools: 
      
      Add a third parameter (unreachableURL) to queueLoadHTMLString.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (queueLoadHTMLStringCallback):
      (LayoutTestController::queueLoadHTMLString):
      (LayoutTestController::queueLoadAlternateHTMLString):
      * DumpRenderTree/LayoutTestController.h:
      
      * DumpRenderTree/WorkQueueItem.h:
      (LoadHTMLStringItem::LoadHTMLStringItem):
      
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
      (WorkItemLoadHTMLString::run):
      (LayoutTestController::queueLoadHTMLString):
      
      * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
      (LoadHTMLStringItem::invoke):
      * DumpRenderTree/mac/WorkQueueItemMac.mm:
      (LoadHTMLStringItem::invoke):
      * DumpRenderTree/win/WorkQueueItemWin.cpp:
      (LoadHTMLStringItem::invoke):
      
      LayoutTests: 
      
      Add a test that loads an alternate HTML String for an "unreachable" URL, loads another
      page, and then goes back to the "unreachable" URL, which is now reachable.
      
      This tests two things:
      1) No assertion failure when going back to an unreachable URL.
      2) There is no page cached for the unreachable URL.
      
      * http/tests/navigation/go-back-to-error-page-expected.txt: Added.
      * http/tests/navigation/go-back-to-error-page.html: Added.
      * http/tests/navigation/resources/page-to-go-back-from.html: Added.
      * http/tests/navigation/resources/page-treated-as-unreachable.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d617a3b2
    • pfeldman@chromium.org's avatar
      2011-01-17 Pavel Feldman <pfeldman@chromium.org> · d55413b4
      pfeldman@chromium.org authored
              Not reviewed: skip flaky inspector test (will look at it tomorrow).
      
              * platform/mac-leopard/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d55413b4
    • caseq@chromium.org's avatar
      2011-01-17 Andrey Kosyakov <caseq@chromium.org> · 0b0683cc
      caseq@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
              Make resource start/finish hanlding more consistent.
              https://bugs.webkit.org/show_bug.cgi?id=52452
      
              * inspector/front-end/AuditLauncherView.js: Ignore WebSocket resources when displaying progress indicator
              (WebInspector.AuditLauncherView.prototype._resetResourceCount):
              (WebInspector.AuditLauncherView.prototype.resourceStarted):
              (WebInspector.AuditLauncherView.prototype.resourceFinished):
              * inspector/front-end/NetworkManager.js:
              (WebInspector.NetworkManager): Factor out resource start/finish logic to _startResource()/_finishResource()
              (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
              (WebInspector.NetworkManager.prototype.willSendRequest):
              (WebInspector.NetworkManager.prototype.markResourceAsCached):
              (WebInspector.NetworkManager.prototype.didReceiveResponse):
              (WebInspector.NetworkManager.prototype.didReceiveContentLength):
              (WebInspector.NetworkManager.prototype.didFinishLoading):
              (WebInspector.NetworkManager.prototype.didFailLoading):
              (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
              (WebInspector.NetworkManager.prototype.didCreateWebSocket):
              (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
              (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
              (WebInspector.NetworkManager.prototype.didCloseWebSocket):
              (WebInspector.NetworkManager.prototype._appendRedirect):
              (WebInspector.NetworkManager.prototype._startResource):
              (WebInspector.NetworkManager.prototype._finishResource):
      
      2011-01-17  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
              Added test for finished event being sent for redirected resources.
              https://bugs.webkit.org/show_bug.cgi?id=52452
      
              * http/tests/inspector/extensions-resources-redirect-expected.txt:
              * http/tests/inspector/extensions-resources-redirect.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b0683cc
    • pfeldman@chromium.org's avatar
      2011-01-17 Pavel Feldman <pfeldman@chromium.org> · 429bcf2c
      pfeldman@chromium.org authored
              Not reviewed: first timeline-network-resource flakiness.
      
              * inspector/timeline-network-resource.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      429bcf2c
    • podivilov@chromium.org's avatar
      2011-01-17 Pavel Podivilov <podivilov@chromium.org> · 126363a4
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix flaky debugger tests.
              https://bugs.webkit.org/show_bug.cgi?id=51320
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.setBreakpoint):
              * inspector/debugger-breakpoints-not-activated-on-reload.html:
              * inspector/debugger-pause-on-breakpoint-expected.txt:
              * inspector/debugger-pause-on-breakpoint.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      126363a4
    • ossy@webkit.org's avatar
      Unreviewed. · 54a5efd6
      ossy@webkit.org authored
      Add Qt specific expected results for passing CSS tests.
      Compared to Mac png files and Mac expected files.
      
      * platform/qt/Skipped: Unskip passing tests.
      * platform/qt/css1/[...]: Added.
      * platform/qt/css2.1/[...]: Added.
      * platform/qt/css3/[...]: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54a5efd6
    • rik@webkit.org's avatar
      2011-01-17 Anthony Ricaud <rik@webkit.org> · 4cfa85f5
      rik@webkit.org authored
              Reviewed by Kent Tamura.
      
              [HTML5] Revert display:none on datalist
              https://bugs.webkit.org/show_bug.cgi?id=52214
      
              * fast/forms/datalist-expected.txt:
              * fast/forms/datalist-nonoption-child-expected.txt:
              * fast/forms/datalist.html:
      2011-01-17  Anthony Ricaud  <rik@webkit.org>
      
              Reviewed by Kent Tamura.
      
              [HTML5] Revert display:none on datalist
              https://bugs.webkit.org/show_bug.cgi?id=52214
      
              * css/html.css:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cfa85f5
    • podivilov@chromium.org's avatar
      2011-01-17 Pavel Podivilov <podivilov@chromium.org> · 3dcea969
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
              https://bugs.webkit.org/show_bug.cgi?id=51738
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.showScriptSource):
              (initialize_DebuggerTest.InspectorTest._showScriptSource):
              * inspector/debugger-pause-in-eval-script-expected.txt:
              * inspector/debugger-pause-in-eval-script.html:
      2011-01-17  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
              https://bugs.webkit.org/show_bug.cgi?id=51738
      
              Extract content loading logic from SourceView and ScriptView to ContentProvider implementations.
              Pass ContentProvider in SourceFrame constructor to allow SourceFrame manage it's lazy initialization.
      
              * inspector/front-end/ScriptView.js:
              (WebInspector.ScriptView):
              (WebInspector.SourceFrameContentProviderForScript):
              (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent.didRequestSource):
              (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
              (WebInspector.SourceFrameContentProviderForScript.prototype.scripts):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._addScript):
              (WebInspector.ScriptsPanel.prototype.sourceFrameForScript):
              (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              (WebInspector.SourceFrame.prototype.set visible):
              (WebInspector.SourceFrame.prototype._createTextViewer):
              (WebInspector.SourceFrame.prototype._breakpointAdded):
              (WebInspector.SourceFrame.prototype._breakpoints):
              (WebInspector.SourceFrame.prototype._sourceIDForLine):
              (WebInspector.SourceFrame.prototype._sourceIDSet):
              (WebInspector.SourceFrameContentProvider):
              (WebInspector.SourceFrameContentProvider.prototype.requestContent):
              (WebInspector.SourceFrameContentProvider.prototype.scripts):
              * inspector/front-end/SourceView.js:
              (WebInspector.SourceView):
              (WebInspector.SourceView.prototype.show):
              (WebInspector.SourceView.prototype.resize):
              (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches):
              (WebInspector.SourceView.prototype.performSearch):
              (WebInspector.SourceView.prototype.revealLine):
              (WebInspector.SourceView.prototype.highlightLine):
              (WebInspector.SourceView.prototype._jumpToSearchResult):
              (WebInspector.SourceFrameContentProviderForResource):
              (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
              (WebInspector.SourceFrameContentProviderForResource.prototype.scripts):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dcea969
    • jknotten@chromium.org's avatar
      2011-01-17 John Knottenbelt <jknotten@chromium.org> · 390c2e34
      jknotten@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              GeolocationController should call stopUpdating on destruction
              https://bugs.webkit.org/show_bug.cgi?id=52216
      
              fast/dom/window-close-crash.html tests that we do not fail the
              assertion in the mock GeolocationClient that the GeolocationClient
              is not updating when the GeolocationController is destroyed.
      
              * fast/dom/Geolocation/resources/window-close-popup.html: Added.
              * fast/dom/Geolocation/script-tests/window-close-crash.js: Added.
              (gotPosition):
              (waitForWindowToClose):
              (failedToCreateWatch):
              * fast/dom/Geolocation/window-close-crash-expected.txt: Added.
              * fast/dom/Geolocation/window-close-crash.html: Added.
              * platform/gtk/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
      2011-01-17  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              GeolocationController should call stopUpdating on destruction
              https://bugs.webkit.org/show_bug.cgi?id=52216
      
              Test: fast/dom/Geolocation/window-close-crash.html
      
              * page/GeolocationController.cpp:
              (WebCore::GeolocationController::~GeolocationController):
      2011-01-17  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              GeolocationController should call stopUpdating on destruction
              https://bugs.webkit.org/show_bug.cgi?id=52216
      
              fast/dom/Geolocation/window-close-crash.html requires that a
              Geolocation watch be started in a secondary window. Consequently,
              we need to allow geolocation permission and provide a mock
              geolocation position for the secondary window's
              GeolocationClientMock.
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::setGeolocationPermission):
              (LayoutTestController::setMockGeolocationPosition):
              (LayoutTestController::setMockGeolocationError):
              * DumpRenderTree/chromium/TestShell.h:
              (TestShell::windowList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      390c2e34
    • loislo@chromium.org's avatar
      2011-01-14 Ilya Tikhonovsky <loislo@chromium.org> · 86cbf0cf
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Enable inspector's tests for chromium Linux.
              https://bugs.webkit.org/show_bug.cgi?id=52445
      
              * platform/chromium/inspector/timeline-network-resource-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86cbf0cf
    • commit-queue@webkit.org's avatar
      2011-01-17 Helder Correia <helder@sencha.com> · fd84b4d1
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
              https://bugs.webkit.org/show_bug.cgi?id=52556
      
              The shadow color opacity needs to be set on the shadow painter.
              Additionally, the gradient brush should be transformed.
      
              * platform/qt/Skipped: Remove test from skipped list.
      2011-01-17  Helder Correia  <helder@sencha.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
              https://bugs.webkit.org/show_bug.cgi?id=52556
      
              The shadow color opacity needs to be set on the shadow painter.
              Additionally, the gradient brush should be transformed.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::fillPath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd84b4d1
    • philn@webkit.org's avatar
      2011-01-17 Philippe Normand <pnormand@igalia.com> · 29c909d5
      philn@webkit.org authored
              Unreviewed, rolling out r75914.
              http://trac.webkit.org/changeset/75914
              https://bugs.webkit.org/show_bug.cgi?id=49177
      
              multiple crashes on GTK
      
              * platform/gtk/Skipped:
      2011-01-17  Philippe Normand  <pnormand@igalia.com>
      
              Unreviewed, rolling out r75914.
              http://trac.webkit.org/changeset/75914
              https://bugs.webkit.org/show_bug.cgi?id=49177
      
              multiple crashes on GTK
      
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::removeChild):
              (WebCore::ScrollView::wheelEvent):
              * platform/gtk/MainFrameScrollbarGtk.cpp:
              (MainFrameScrollbarGtk::attachAdjustment):
              (MainFrameScrollbarGtk::gtkValueChanged):
              * platform/gtk/ScrollViewGtk.cpp:
              (WebCore::ScrollView::platformInit):
              (WebCore::ScrollView::platformAddChild):
              (WebCore::ScrollView::platformRemoveChild):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29c909d5
  2. 16 Jan, 2011 5 commits
    • mrobinson@webkit.org's avatar
      2011-01-16 Martin Robinson <mrobinson@igalia.com> · 9229f615
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
              https://bugs.webkit.org/show_bug.cgi?id=49177
      
              * platform/gtk/Skipped: Unskip this test, as it's now passing.
      2011-01-16  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
              https://bugs.webkit.org/show_bug.cgi?id=49177
      
              * platform/ScrollView.cpp: Move the platform guards around a little. GTK+
              now shares the implementation of platformAddChild and platformRemoveChild,
              but has its own implementation of removeChild, which knows how to inform
              main frame scrollbars that they no longer control the WebCore scrollbar.
              * platform/gtk/MainFrameScrollbarGtk.cpp:
              (MainFrameScrollbarGtk::attachAdjustment): If we are attaching the same adjustment
              that we already have, bail out early. Apply the value changed signal handler
              after configuring the adjustment. We don't want our reset of the adjustment to
              stomp on WebCore values.
              (MainFrameScrollbarGtk::gtkValueChanged): Do not adjust the value if the WebCore
              state already matches ours. This prevents some unnecessary recursion
              * platform/gtk/ScrollViewGtk.cpp:
              (WebCore::ScrollView::removeChild): Added, special cases main frame scrollbars
              which need their adjustments detached.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9229f615
    • oliver@apple.com's avatar
      2011-01-16 Oliver Hunt <oliver@apple.com> · 3e7b1a63
      oliver@apple.com authored
              Reviewed by Sam Weinig.
      
              [jsfunfuzz] Parser doesn't correctly validate for-loop syntax
              https://bugs.webkit.org/show_bug.cgi?id=52516
      
              Add test for the case where a syntax error immediately follows
              multiple declarations in a for-loop initialiser.
      
              * fast/js/parser-syntax-check-expected.txt:
              * fast/js/script-tests/parser-syntax-check.js:
      2011-01-16  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Sam Weinig.
      
              [jsfunfuzz] Parser doesn't correctly validate for-loop syntax
              https://bugs.webkit.org/show_bug.cgi?id=52516
      
              Ensure that we always check for a semicolon after encountering
              multiple declarations in the initialiser portion of a for-loop.
      
              * parser/JSParser.cpp:
              (JSC::JSParser::parseForStatement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e7b1a63
    • oliver@apple.com's avatar
      2011-01-16 Oliver Hunt <oliver@apple.com> · fc1b3f8f
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Strict mode restrictions on arguments and eval usage aren't complete
              https://bugs.webkit.org/show_bug.cgi?id=52528
      
              Add a helper function to aid parse failure tests by testing both direct
              eval/global code, and nested code (so that we test the syntax checker
              mode as well)
      
              * fast/js/basic-strict-mode-expected.txt:
              * fast/js/script-tests/basic-strict-mode.js:
              (shouldBeSyntaxError):
      2011-01-16  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Strict mode restrictions on arguments and eval usage aren't complete
              https://bugs.webkit.org/show_bug.cgi?id=52528
      
              Fix a few bugs in strict mode where we incorrect allow mutation of
              arguments and eval in the parser.
      
              Alas the "optimisation" used by the syntax checker for validating
              binary and unary expressions was too aggressive: we do actually need
              a stack for operations and operands although it needn't be as complete
              as that used for the full AST builder.
      
              Also disallow assignment to arguments in all cases as allowing arguments
              to be assignable is always an error in strict mode, regardless of context.
      
              * parser/ASTBuilder.h:
              (JSC::ASTBuilder::BinaryExprContext::BinaryExprContext):
              (JSC::ASTBuilder::UnaryExprContext::UnaryExprContext):
              * parser/JSParser.cpp:
              (JSC::JSParser::parseAssignmentExpression):
              (JSC::JSParser::parseBinaryExpression):
              (JSC::JSParser::parseUnaryExpression):
              * parser/SyntaxChecker.h:
              (JSC::SyntaxChecker::BinaryExprContext::BinaryExprContext):
              (JSC::SyntaxChecker::BinaryExprContext::~BinaryExprContext):
              (JSC::SyntaxChecker::UnaryExprContext::UnaryExprContext):
              (JSC::SyntaxChecker::UnaryExprContext::~UnaryExprContext):
              (JSC::SyntaxChecker::appendBinaryExpressionInfo):
              (JSC::SyntaxChecker::operatorStackPop):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc1b3f8f
    • robert@webkit.org's avatar
      2011-01-16 Robert Hogan <robert@webkit.org> · b8633a7b
      robert@webkit.org authored
              Unreviewed, re-skip test after r75894.
      
              [Qt] plugins/keyboard-events.html fails after r72717
      
              Re-skip plugins/keyboard-events.html.
              Using XKeysymToKeycode(QX11Info::display(), ..) doesn't work on
              a headless build, such as the buildbot. So need to solve this a
              different way.
      
              https://bugs.webkit.org/show_bug.cgi?id=50050
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8633a7b
    • robert@webkit.org's avatar
      2011-01-16 Robert Hogan <robert@webkit.org> · 4f6f8d5d
      robert@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] plugins/keyboard-events.html fails after r72717
              https://bugs.webkit.org/show_bug.cgi?id=50050
      
              * platform/qt/Skipped: Unskip plugins/keyboard-events.html
      2011-01-16  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] plugins/keyboard-events.html fails after r72717
              https://bugs.webkit.org/show_bug.cgi?id=50050
      
              * plugins/qt/PluginViewQt.cpp:
              (WebCore::setXKeyEventSpecificFields): map event text to keycode
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f6f8d5d
  3. 15 Jan, 2011 7 commits
  4. 14 Jan, 2011 15 commits
    • oliver@apple.com's avatar
      2011-01-14 Oliver Hunt <oliver@apple.com> · edebdc12
      oliver@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              [jsfunfuzz] Incorrect handling of consecutive duplicate labels
              https://bugs.webkit.org/show_bug.cgi?id=52505
      
              Add a few tests of consecutive labels containing duplicates to the parser check.
      
              * fast/js/parser-syntax-check-expected.txt:
              * fast/js/script-tests/parser-syntax-check.js:
      2011-01-14  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              [jsfunfuzz] Incorrect handling of consecutive duplicate labels
              https://bugs.webkit.org/show_bug.cgi?id=52505
      
              Compare StringImpl*'s instead of Identifier*'s when looking for duplicate
              labels.
      
              * parser/JSParser.cpp:
              (JSC::JSParser::parseExpressionOrLabelStatement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edebdc12
    • dimich@chromium.org's avatar
      Not reviewed, update of Chromium test expectations. · c22dfbbb
      dimich@chromium.org authored
      Update of files affected by mass rebaseline in r75828 and r75838
      
      * platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.checksum:
      * platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png:
      * platform/chromium-mac/plugins/embed-attributes-style-expected.txt: Removed.
      * platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
      * platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c22dfbbb
    • dimich@chromium.org's avatar
      Not reviewed, update of test expectations. · 223f0eb4
      dimich@chromium.org authored
      Ignore new test fast/js/js-continue-break-restrictions.html, it fails for V8.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      223f0eb4
    • ericu@chromium.org's avatar
      2011-01-14 Eric Uhrhane <ericu@chromium.org> · bc3647f0
      ericu@chromium.org authored
              Reviewed by David Levin.
      
              Add tests for FileWriterSync
              https://bugs.webkit.org/show_bug.cgi?id=50720
      
              * fast/filesystem/resources/file-writer-sync-truncate-extend.js: Added.
              * fast/filesystem/workers/file-writer-sync-truncate-extend.html: Added.
              * fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Added.
              * fast/filesystem/resources/file-writer-sync-write-overlapped.js: Added.
              * fast/filesystem/workers/file-writer-sync-write-overlapped.html: Added.
              * fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Added.
              * fast/filesystem/resources/file-writer-utils.js:
              (assert): Make assert throw, rather than continue.
              (cleanUp): Always call finishJSTest, even without fileEntryForCleanup.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc3647f0
    • oliver@apple.com's avatar
      2011-01-14 Oliver Hunt <oliver@apple.com> · 03954a3f
      oliver@apple.com authored
              Reviewed by Stephanie Lewis.
      
              [jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
              https://bugs.webkit.org/show_bug.cgi?id=52501
      
              Add checks for correct behaviour when the strict mode token is immediately followed
              by a value that needs a temporary buffer in the lexer.
      
              * fast/js/basic-strict-mode-expected.txt:
              * fast/js/script-tests/basic-strict-mode.js:
      2011-01-14  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Stephanie Lewis.
      
              [jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
              https://bugs.webkit.org/show_bug.cgi?id=52501
      
              Clear the temporary character buffers used for reading escaped characters and
              numbers.
      
              * parser/Lexer.h:
              (JSC::Lexer::setOffset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03954a3f
    • tony@chromium.org's avatar
      2011-01-14 Tony Chang <tony@chromium.org> · 1e26d554
      tony@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              Strip NUL character when copying text on Windows
              https://bugs.webkit.org/show_bug.cgi?id=52236
      
              * editing/pasteboard/copy-null-characters-expected.txt: Added.
              * editing/pasteboard/copy-null-characters.html: Added.
      2011-01-14  Tony Chang  <tony@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Strip NUL character when copying text on Windows
              https://bugs.webkit.org/show_bug.cgi?id=52236
      
              Test: editing/pasteboard/copy-null-characters.html
      
              * editing/Editor.cpp:
              (WebCore::Editor::selectedText):
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeSelection): Use editor()->selectedText() which matches the other platforms.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e26d554
    • thakis@chromium.org's avatar
      2011-01-14 Nico Weber <thakis@chromium.org> · 198efcf7
      thakis@chromium.org authored
              Unreviewed, test expectations.
      
              Rebaseline gradient test due to updated skia. reed checked the test and
              says the new look is right and is an intentional change.
              https://bugs.webkit.org/show_bug.cgi?id=52105
      
              * platform/chromium-linux/svg/batik/paints/gradientLimit-expected.checksum:
              * platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
              * platform/chromium-win/svg/batik/paints/gradientLimit-expected.checksum:
              * platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      198efcf7
    • oliver@apple.com's avatar
      2011-01-14 Oliver Hunt <oliver@apple.com> · 1a6a9f7b
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              [jsfunfuzz] parser doesn't enforce continue restrictions correctly.
              https://bugs.webkit.org/show_bug.cgi?id=52493
      
              Add a few tests for continue to cover the cases where continue
              isn't syntactically valid.
      
              * fast/js/js-continue-break-restrictions-expected.txt: Added.
              * fast/js/js-continue-break-restrictions.html: Added.
              * fast/js/script-tests/js-continue-break-restrictions.js: Added.
      2011-01-14  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Gavin Barraclough.
      
              [jsfunfuzz] parser doesn't enforce continue restrictions correctly.
              https://bugs.webkit.org/show_bug.cgi?id=52493
      
              This patch reworks handling of break, continue and label statements
              to correctly handle all the valid and invalid cases.  Previously certain
              errors would be missed by the parser in strict mode, but the bytecode
              generator needed to handle those cases for non-strict code so nothing
              failed, it simply became non-standard behaviour.
      
              Now that we treat break and continue errors as early faults in non-strict
              mode as well that safety net has been removed so the parser bugs result in
              crashes at codegen time.
      
              * parser/JSParser.cpp:
              (JSC::JSParser::ScopeLabelInfo::ScopeLabelInfo):
              (JSC::JSParser::next):
              (JSC::JSParser::nextTokenIsColon):
              (JSC::JSParser::continueIsValid):
                  Continue is only valid in loops so we can't use breakIsValid()
              (JSC::JSParser::pushLabel):
                  We now track whether the label is for a loop (and is therefore a
                  valid target for continue.
              (JSC::JSParser::popLabel):
              (JSC::JSParser::getLabel):
                  Replace hasLabel with getLabel so that we can validate the target
                  when parsing continue statements.
              (JSC::JSParser::Scope::continueIsValid):
              (JSC::JSParser::Scope::pushLabel):
              (JSC::JSParser::Scope::getLabel):
              (JSC::JSParser::JSParser):
              (JSC::JSParser::parseBreakStatement):
              (JSC::JSParser::parseContinueStatement):
              (JSC::LabelInfo::LabelInfo):
              (JSC::JSParser::parseExpressionOrLabelStatement):
                  Consecutive labels now get handled iteratively so that we can determine
                  whether they're valid targets for continue.
              * parser/Lexer.cpp:
              (JSC::Lexer::nextTokenIsColon):
              * parser/Lexer.h:
              (JSC::Lexer::setOffset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a6a9f7b
    • mjs@apple.com's avatar
      2011-01-14 Maciej Stachowiak <mjs@apple.com> · b4fe755c
      mjs@apple.com authored
              Reviewed by Anders Carlsson.
      
              Fix a few things in the WebKit2 skipped list
              https://bugs.webkit.org/show_bug.cgi?id=52484
      
              * platform/mac-wk2/Skipped: Add/remove some tests to the WK2 skipped list.
              * editing/style/stylewithcss-without-selection.html: Fix this test to avoid
              referencing an undefined variable in the failure case.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4fe755c
    • mihaip@chromium.org's avatar
      2011-01-14 Mihai Parparita <mihaip@chromium.org> · faec159a
      mihaip@chromium.org authored
              Update the svg/ pixel expectations for the chromium-mac port.
      
              For the pixel tests that currently fail on Snow Leopard, this moves the
              current pixel results to platform/chromium-mac-leopard and adds new
              results to platform/chromium-mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/chromium-mac to platform/chromium-mac-leopard and newly added
              files in platform/chromium-mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faec159a
    • commit-queue@webkit.org's avatar
      2011-01-14 Helder Correia <helder@sencha.com> · 7240bdcc
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              Shadow is not drawn when filling a path with a gradient
              https://bugs.webkit.org/show_bug.cgi?id=51982
      
              This happens in CG and is related to bug 51869, this time to be fixed
              in GraphicsContext::fillPath(const Path& path). We need to draw the
              gradient clipped to the path on a CGLayer first, and then draw the
              layer on the GraphicsContext.
      
              * fast/canvas/canvas-fillPath-gradient-shadow-expected.txt: Added.
              * fast/canvas/canvas-fillPath-gradient-shadow.html: Added.
              * fast/canvas/script-tests/canvas-fillPath-gradient-shadow.js: Added.
              * platform/chromium/test_expectations.txt: Skipping new test since it fails.
              * platform/qt/Skipped: Ditto.
      2011-01-14  Helder Correia  <helder@sencha.com>
      
              Reviewed by Simon Fraser.
      
              Shadow is not drawn when filling a path with a gradient
              https://bugs.webkit.org/show_bug.cgi?id=51982
      
              This happens in CG and is related to bug 51869, this time to be fixed
              in GraphicsContext::fillPath(const Path& path). We need to draw the
              gradient clipped to the path on a CGLayer first, and then draw the
              layer on the GraphicsContext.
      
              Test: fast/canvas/canvas-fillPath-gradient-shadow.html
      
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::fillPath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7240bdcc
    • mihaip@chromium.org's avatar
      2011-01-14 Mihai Parparita <mihaip@chromium.org> · 3aef3213
      mihaip@chromium.org authored
              Update the pixel expectations for the chromium-mac port.
      
              For the pixel tests that currently fail on Snow Leopard, this moves the
              current pixel results to platform/chromium-mac-leopard and adds new
              results to platform/chromium-mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/chromium-mac to platform/chromium-mac-leopard and newly added
              files in platform/chromium-mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3aef3213
    • commit-queue@webkit.org's avatar
      2011-01-14 Steve Lacey <sjl@chromium.org> · df39fad0
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              Update media/video-zoom-controls.html to set the video source before initializing the test.
              https://bugs.webkit.org/show_bug.cgi?id=52461
      
              * media/video-zoom-controls.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df39fad0
    • inferno@chromium.org's avatar
      2011-01-14 Abhishek Arya <inferno@chromium.org> · e3baac1e
      inferno@chromium.org authored
              Reviewed by David Hyatt.
      
              Fix parent block calculation when trying to find top most node
              containing "this" float.
              https://bugs.webkit.org/show_bug.cgi?id=51711
      
              Replace use of containingBlock and traverse the parents directly
              to check for float existence. containingBlock can skip parents and
              jump to the RenderView directly which will cause floats to not get
              cleared from intermediate parents.
      
              Test: fast/block/float/floats-not-cleared-crash.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
      2011-01-14  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              Tests that we do not crash due to uncleared floats in parent nodes.
              https://bugs.webkit.org/show_bug.cgi?id=51711
      
              * fast/block/float/floats-not-cleared-crash-expected.txt: Added.
              * fast/block/float/floats-not-cleared-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3baac1e
    • jberlin@webkit.org's avatar
      REGRESSION (r75660): compositing/reflections/load-video-in-reflection.html crashes on Windows 7 · b544450c
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52397
      
      Unskipping tests that no longer fail on Windows 7 Release. Unreviewed.
      
      * platform/win/Skipped:
      Un-skip compositing/reflections/load-video-in-reflection.html, which appears to be fixed by
      http://trac.webkit.org/changeset/75807
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b544450c