1. 12 May, 2011 10 commits
  2. 11 May, 2011 30 commits
    • leviw@chromium.org's avatar
      2011-05-11 Levi Weintraub <leviw@chromium.org> · 5e1b7862
      leviw@chromium.org authored
              Reviewed by Eric Seidel.
      
              Rename Widget::pos()
              https://bugs.webkit.org/show_bug.cgi?id=60575
      
              Renaming Widget::pos() to the more-descriptive location().
      
              No new tests as this is a simple rename
      
              * page/FrameView.cpp:
              (WebCore::FrameView::create):
              * platform/Widget.h:
              (WebCore::Widget::location):
              (WebCore::Widget::resize):
      2011-05-11  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Rename Widget::pos()
              https://bugs.webkit.org/show_bug.cgi?id=60575
      
              Renaming Widget::pos() to the more-descriptive location().
      
              * src/WebInputEventConversion.cpp:
              (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
              (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e1b7862
    • morrita@google.com's avatar
      2011-05-10 MORITA Hajime <morrita@google.com> · 7f0dffc7
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              Crashes if the document inside iframe is removed during pasting some text into it.
              https://bugs.webkit.org/show_bug.cgi?id=60534
      
              * editing/pasteboard/paste-removing-iframe-expected.txt: Added.
              * editing/pasteboard/paste-removing-iframe.html: Added.
              * editing/pasteboard/resources/paste-removing-iframe-child.html: Added.
      2011-05-10  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Kent Tamura.
      
              Crashes if the document inside iframe is removed during pasting some text into it.
              https://bugs.webkit.org/show_bug.cgi?id=60534
      
              Added missing null check.
      
              Test: editing/pasteboard/paste-removing-iframe.html
      
              * editing/Editor.cpp:
              (WebCore::Editor::shouldChangeSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f0dffc7
    • commit-queue@webkit.org's avatar
      2011-05-11 Brian Salomon <bsalomon@google.com> · 9260236f
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              Handle case when GrContext creation fails
              https://bugs.webkit.org/show_bug.cgi?id=60410
      
              Exercised by all canvas tests when DRT is run with skia-gpu
      
              * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
              (WebCore::SharedGraphicsContext3D::grContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9260236f
    • psolanki@apple.com's avatar
      2011-05-11 Pratik Solanki <psolanki@apple.com> · f3ada36b
      psolanki@apple.com authored
              Reviewed by Andreas Kling.
      
              Remove empty class CallbackGuard
              https://bugs.webkit.org/show_bug.cgi?id=60610
      
              CallbackGuard was only ever used on Tiger and it is now an empty class. Remove all uses of it.
      
              * platform/network/mac/ResourceHandleMac.mm:
              (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
              (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]):
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
              (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
              (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]):
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
              (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
              (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
              (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
              (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
              (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3ada36b
    • commit-queue@webkit.org's avatar
      2011-05-11 Luke Macpherson <macpherson@chromium.org> · d1e17f04
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              Implement CSSPropertyMargin and CSSPropertyPadding in CSSStyleApplyProperty.
              https://bugs.webkit.org/show_bug.cgi?id=60609
      
              No new tests - refactoring only.
      
              * css/CSSStyleApplyProperty.cpp:
              (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
              Initialise CSSPropertyMargin and CSSPropertyPadding handlers.
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              Remove unused implementations.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1e17f04
    • morrita@google.com's avatar
      2011-05-11 MORITA Hajime <morrita@google.com> · 1a9ff0f0
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              Some elements in meter-styles.html are hiding its content part with non-content-area.
              https://bugs.webkit.org/show_bug.cgi?id=58149
      
              - Resized the border and padding values
              - Gave "-webkit-appearance: none" to test that is intended to be painted using shadows.
      
              * fast/dom/HTMLMeterElement/meter-styles.html:
              * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
              * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
              * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a9ff0f0
    • kevino@webkit.org's avatar
      Reviewed by Kevin Ollivier. · f2496442
      kevino@webkit.org authored
      [wx] Implement more clipping functions for wxWebKit.
              
      https://bugs.webkit.org/show_bug.cgi?id=60662
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2496442
    • commit-queue@webkit.org's avatar
      2011-05-11 Damian Kaleta <dkaleta@apple.com> · d5f7c0ab
      commit-queue@webkit.org authored
              Reviewed by Brady Eidson.
      
              Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history
              https://bugs.webkit.org/show_bug.cgi?id=60674
      
              * WebCore.exp.in: Export restoreScrollPositionAndViewState()
      2011-05-11  Damian Kaleta  <dkaleta@apple.com>
      
              Reviewed by Brady Eidson.
      
              Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history
              https://bugs.webkit.org/show_bug.cgi?id=60674
      
              * UIProcess/API/C/WKPage.cpp:
              (WKPageTryRestoreScrollPosition):
              * UIProcess/API/C/WKPage.h:
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::tryRestoreScrollPosition):
              * UIProcess/WebPageProxy.h:
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::tryRestoreScrollPosition):
              * WebProcess/WebPage/WebPage.h:
              * WebProcess/WebPage/WebPage.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5f7c0ab
    • commit-queue@webkit.org's avatar
      2011-05-11 Igor Oliveira <igor.oliveira@openbossa.org> · 1dc3a3e6
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              WebKit does not build with GCCE
              https://bugs.webkit.org/show_bug.cgi?id=60667
      
              Allow compile WebKit with GCCE
      
              * wtf/Alignment.h:
              * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1dc3a3e6
    • leviw@chromium.org's avatar
      2011-05-11 Levi Weintraub <leviw@chromium.org> · 7c155a2f
      leviw@chromium.org authored
              Reviewed by Eric Seidel.
      
              Switch paintFillLayer and its progeny to use IntRect instead of four ints
              https://bugs.webkit.org/show_bug.cgi?id=60596
      
              Changing integers passed into paintFillLayer and other derivatives to IntRects
              and IntSizes that reflect their function.
      
              No new tests since this is just refactoring.
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::paintFillLayers):
              (WebCore::InlineFlowBox::paintFillLayer):
              (WebCore::InlineFlowBox::paintBoxDecorations):
              (WebCore::InlineFlowBox::paintMask):
              * rendering/InlineFlowBox.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintRootBoxFillLayers):
              (WebCore::RenderBox::paintBoxDecorationsWithSize):
              (WebCore::RenderBox::paintMaskImages):
              (WebCore::RenderBox::paintFillLayers):
              (WebCore::RenderBox::paintFillLayer):
              * rendering/RenderBox.h:
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              * rendering/RenderBoxModelObject.h:
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::paintBoxDecorations):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::paintBoxDecorations):
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paintBackgroundsBehindCell):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c155a2f
    • abarth@webkit.org's avatar
      2011-05-11 Adam Barth <abarth@webkit.org> · 589d1c43
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Enable strict PassOwnPtr on Mac
              https://bugs.webkit.org/show_bug.cgi?id=60684
      
              This should build cleanly now.
      
              * wtf/PassOwnPtr.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      589d1c43
    • commit-queue@webkit.org's avatar
      2011-05-11 Nat Duca <nduca@chromium.org> · aeecdca9
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              [chromium] Use mapTexSubImage2D for tile uploads if available
              https://bugs.webkit.org/show_bug.cgi?id=60008
      
              * platform/graphics/chromium/LayerTilerChromium.cpp:
              (WebCore::LayerTilerChromium::LayerTilerChromium):
              (WebCore::LayerTilerChromium::update):
              (WebCore::LayerTilerChromium::updateFromPixels):
              * platform/graphics/chromium/LayerTilerChromium.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aeecdca9
    • oliver@apple.com's avatar
      2011-05-11 Oliver Hunt <oliver@apple.com> · 60de6041
      oliver@apple.com authored
              Reviewed by Darin Adler.
      
              Protect JSC from WebCore executing JS during JS wrapper finalization
              https://bugs.webkit.org/show_bug.cgi?id=60672
              <rdar://problem/9350997>
      
              Detect when we're trying to execute JS during GC and prevent the
              execution from happening.  We also assert that this isn't happening
              as it implies incorrect behaviour of an object's destructor.
      
              * JavaScriptCore.exp:
              * heap/Heap.cpp:
              * heap/Heap.h:
              (JSC::Heap::isBusy):
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::execute):
              (JSC::Interpreter::executeCall):
              (JSC::Interpreter::executeConstruct):
              * runtime/JSGlobalData.h:
              (JSC::JSGlobalData::isCollectorBusy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60de6041
    • alexis.menard@openbossa.org's avatar
      2011-05-11 Alexis Menard <alexis.menard@openbossa.org> · 818c82f1
      alexis.menard@openbossa.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Implements a disable appearance for Media Elements of Qt port.
              https://bugs.webkit.org/show_bug.cgi?id=60561
      
              Implements a disable appearance for the media controls of the Qt port
              when the media is not yet available.
      
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::mediaElementCanPlay):
              (WebCore::RenderThemeQt::getMediaControlForegroundColor):
              (WebCore::RenderThemeQt::paintMediaSliderThumb):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      818c82f1
    • tkent@chromium.org's avatar
      2011-05-11 Kent Tamura <tkent@chromium.org> · 571f6811
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              input type=email is too strict
              https://bugs.webkit.org/show_bug.cgi?id=55988
      
              * fast/forms/resources/ValidityState-typeMismatch-email.js:
              * fast/forms/ValidityState-typeMismatch-email-expected.txt:
      2011-05-11  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              input type=email is too strict
              https://bugs.webkit.org/show_bug.cgi?id=55988
      
              Follow the updated specification.
      
              * html/EmailInputType.cpp: Update the pattern to allow a domain part without periods.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      571f6811
    • cdn@chromium.org's avatar
      2011-05-11 Cris Neckar <cdn@chromium.org> · eba45b97
      cdn@chromium.org authored
              Reviewed by David Levin.
      
              Adding Cris Neckar to the Webkit Security Group site.
              https://bugs.webkit.org/show_bug.cgi?id=60668
      
              * security/security-group-members.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eba45b97
    • weinig@apple.com's avatar
      2011-05-11 Sam Weinig <sam@webkit.org> · 8b6ac572
      weinig@apple.com authored
              Reviewed by Gavin Barraclough.
      
              WebKit2 doesn't build on Mac with strict PassOwnPtr
              https://bugs.webkit.org/show_bug.cgi?id=60655
      
              * Platform/CoreIPC/HandleMessage.h:
              (CoreIPC::handleMessageDelayed):
              Add explicit adoptPtr to indicate that the constructor is taking ownership.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b6ac572
    • jpu@apple.com's avatar
      2011-05-11 Jia Pu <jpu@apple.com> · fd2014cc
      jpu@apple.com authored
              Reviewed by Darin Adler.
      
              Autocorrection persists after deleting and retyping the same word at same location.
              https://bugs.webkit.org/show_bug.cgi?id=60555
              <rdar://problem/9373915>
      
              See WebCore/ChangeLog for detail.
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac/editing/spelling/delete-autocorrected-word-2-expected.png: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-2.html: Added.
      2011-05-11  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Autocorrection persists after deleting and retyping the same word at same location.
              https://bugs.webkit.org/show_bug.cgi?id=60555
              <rdar://problem/9373915>
      
              This patch intends to alleviate the issue of repetitively applying the same autocorrection
              when user delete and retype the same word at the same location. This scenario is especially
              common when autocorrection modifies the first letter of the word.
      
              This patch consists following major changes:
              1. Added a new marker type, DeletedAutocorrection. This marker is added to the whitespace that
                 precedes a deleted autocorrection. If the user later types the same original word at after
                 this whitespace, the autocorrection will not be applied again.
              2. In DeleteSelectionCommand, added code to notify SpellingCorrectionController about the
                 autocorrection that has just been deleted.
              3. In Editor and SpellingCorrectionController, added code to apply the marker and to suppress
                 autocorrection when necessary.
              4. The change in CompositeEditCommand::replaceTextInNode is necessary for preserving markers.
                 Otherwise, we will loose the DeletedAutocorrection on the whitespace, when inserting text
                 after the whitespace.
      
              Test: platform/mac/editing/spelling/delete-autocorrected-word-2.html
      
              * dom/DocumentMarker.h: Added new marker type DeletedAutocorrection.
              (WebCore::DocumentMarker::AllMarkers::AllMarkers):
              * dom/DocumentMarkerController.cpp:
              (WebCore::DocumentMarkerController::markersInRange): Support querying multiple marker types.
              * dom/DocumentMarkerController.h:
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::replaceTextInNodeAndPreserveMarkers):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
              (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
              * editing/CompositeEditCommand.h:
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
              (WebCore::DeleteSelectionCommand::fixupWhitespace):
              (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection): Extracting
                 the original string if we are deleting an autocorrection.
              (WebCore::DeleteSelectionCommand::doApply): Notify editor about the deleted autocorrection and its position.
              * editing/DeleteSelectionCommand.h:
              * editing/Editor.cpp:
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Moved all logic of determining
                 when to suppress an autocorrection into SpellingCorrectionController.
              (WebCore::Editor::deletedAutocorrectionAtPosition):
              * editing/Editor.h:
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/SpellingCorrectionController.cpp:
              (WebCore::SpellingCorrectionController::respondToAppliedEditing):
              (WebCore::SpellingCorrectionController::deletedAutocorrectionAtPosition):
              (WebCore::SpellingCorrectionController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
              (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
              * editing/SpellingCorrectionController.h:
              (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
              * editing/visible_units.cpp:
              (WebCore::isStartOfWord):
              * editing/visible_units.h:
              * manual-tests/autocorrection/spell-checking-after-reversion.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd2014cc
    • oliver@apple.com's avatar
      2011-05-11 Oliver Hunt <oliver@apple.com> · 450024ac
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Enable gc mark validation in temporarily in release builds
              https://bugs.webkit.org/show_bug.cgi?id=60678
      
              Make it easier to turn the gc mark validation on and off, and
              temporarily turn it on for all builds.
      
              * heap/MarkStack.cpp:
              * heap/MarkStack.h:
              (JSC::MarkStack::append):
              (JSC::MarkStack::internalAppend):
              * runtime/WriteBarrier.h:
              (JSC::MarkStack::appendValues):
              * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      450024ac
    • mitz@apple.com's avatar
      <rdar://problem/9414874> Layout unnecessarily interrupts smooth scrolling at msnbc.com · 7adc5cf0
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=60677
      
      Reviewed by Darin Adler.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars): Only perform an immediate scroll, aborting any running
      animation, if the new scroll offset computed here is different from the current scroll offset.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7adc5cf0
    • tkent@chromium.org's avatar
      2011-05-11 Kent Tamura <tkent@chromium.org> · af2085d1
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              <input pattern="1|10" value="10"> doesn't work correctly.
              https://bugs.webkit.org/show_bug.cgi?id=60619
      
              Add test cases and update the result.
      
              * fast/forms/ValidityState-patternMismatch-expected.txt:
              * fast/forms/ValidityState-patternMismatch.html:
      2011-05-11  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              <input pattern="1|10" value="10"> doesn't work correctly.
              https://bugs.webkit.org/show_bug.cgi?id=60619
      
              Fixes a bug that patternMismatch returns a wrong result if
               - a whole value matches to a pattern,
               - a sub-string of the value also matches to the pattern, and
               - the sub-string matching has priority.
      
              * html/BaseTextInputType.cpp:
              (WebCore::BaseTextInputType::patternMismatch):
                Enclose the specified pattern with ^( and )$.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af2085d1
    • commit-queue@webkit.org's avatar
      2011-05-11 Zelidrag Hornung <zelidrag@chromium.org> · 6e126984
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Prevented DOMFileSystemBase from imposing file naming restrictions on
              external file systems.
      
              https://bugs.webkit.org/show_bug.cgi?id=60583
      
              There are no new tests for this change since it requires the presence
              of external file system provider which is specific to the platform host
              process. Chromium implementation will test this within its extension API
              test suite.
      
              * fileapi/DOMFileSystemBase.cpp:
              (WebCore::pathToAbsolutePath):
              (WebCore::DOMFileSystemBase::getFile):
              (WebCore::DOMFileSystemBase::getDirectory):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e126984
    • commit-queue@webkit.org's avatar
      2011-05-11 Antoine Labour <piman@chromium.org> · 7e4ad0a0
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Expose shouldBufferData to ThreadableLoaderOptions to be able to disable buffering of the
              loaded resource.
              https://bugs.webkit.org/show_bug.cgi?id=60656
      
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::loadRequest):
              Pass the shouldBufferData to the resource load scheduler, forcing it to true for the
              preflight request.
              * loader/ResourceLoadScheduler.cpp:
              (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad):
              Pass through shouldBufferData to SubresourceLoader::create
              * loader/ResourceLoadScheduler.h:
      
              * loader/SubresourceLoader.cpp:
              (WebCore::SubresourceLoader::create):
              Set shouldBufferData on the newly created loader
      
              * loader/SubresourceLoader.h:
      
              * loader/ThreadableLoader.h:
              (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
              Add shouldBufferData to the options, defaulting to true.
      2011-05-11  Antoine Labour  <piman@chromium.org>
      
              Reviewed by David Levin.
      
              Don't buffer data for resources loaded by AssociatedURLLoader.
              https://bugs.webkit.org/show_bug.cgi?id=60656
      
              * src/AssociatedURLLoader.cpp:
              (WebKit::AssociatedURLLoader::loadAsynchronously): set shouldBufferData to false in ThreadableLoaderOptions
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e4ad0a0
    • jcivelli@chromium.org's avatar
      2011-05-11 Jay Civelli <jcivelli@chromium.org> · e48e949e
      jcivelli@chromium.org authored
              Reviewed by Adam Barth.
      
              Adding a Content-Type parser. This is needed for MHTML support.
              https://bugs.webkit.org/show_bug.cgi?id=60637
      
              (WebCore::ScriptController::disableEval):
              * platform/network/ContentTypeParser.cpp: Added.
              * platform/network/ContentTypeParser.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e48e949e
    • eric@webkit.org's avatar
      2011-05-11 Eric Seidel <eric@webkit.org> · 4bf72665
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Teach validate-committer-lists how to validate committers bugzilla_email()
              https://bugs.webkit.org/show_bug.cgi?id=60651
      
              It turns out we currently have 9 committers with invalid values for their
              bugzilla_email field (meaning we don't know what email is their bugzilla account).
              "Alexander Kellett" <lypanov@mac.com>
              "Andre Boule" <aboule@apple.com>
              "Cameron McCormack" <cam@webkit.org>
              "Chris Petersen" <cpetersen@apple.com>
              "Eli Fidler" <eli@staikos.net>
              "Matt Lilek" <webkit@mattlilek.com>
              "Pierre d'Herbemont" <pdherbemont@free.fr>
              "Scott Violet" <sky@chromium.org>
              "Adam Treat" <treat@kde.org>
      
              Most of those haven't committed in a very long time, so it's not suprising
              that we haven't noticed that their bugzilla emails are bogus.
      
              * Scripts/validate-committer-lists:
              * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
              * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bf72665
    • levin@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=59561 · 011ea55e
      levin@chromium.org authored
      Switch TestWebKitAPI to GTest
      
      Patch by Dmitry Lomov <dslomov@google.com> on 2011-05-11
      Reviewed by David Levin.
      
      Fixes Makefiles and WinCairo build as well
      
      .:
      
      * Source/ThirdParty/gtest/README.WebKit:
      * Source/ThirdParty/gtest/msvc/gtest-md.vcproj:
      * Source/ThirdParty/gtest/xcode/Config/General.xcconfig:
      * Source/ThirdParty/gtest/xcode/Makefile: Added.
      
      Source/WebKit/win:
      
      * WebKit.vcproj/WebKit.sln:
      
      Tools:
      
      * Makefile:
      * Scripts/build-api-tests:
      * Scripts/run-api-tests:
      * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
      * TestWebKitAPI/Test.h:
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/TestsController.cpp:
      (TestWebKitAPI::TestsController::TestsController):
      (TestWebKitAPI::TestsController::dumpTestNames):
      (TestWebKitAPI::TestsController::runTestNamed):
      (TestWebKitAPI::TestsController::runAllTests):
      * TestWebKitAPI/TestsController.h:
      * TestWebKitAPI/mac/main.mm:
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      011ea55e
    • ademar.reis@openbossa.org's avatar
      2011-05-11 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org> · 4daa00ef
      ademar.reis@openbossa.org authored
              Reviewed by Mark Rowe.
      
              Update Qt/Nokia Security contacts
              https://bugs.webkit.org/show_bug.cgi?id=60650
      
              Ademar (me) replaced Simon as the release manager and primary security
              contact for QtWebKit. See:
              http://lists.webkit.org/mailman/private.cgi/webkit-security/2011-February/000584.html
      
              * security/security-group-members.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4daa00ef
    • jberlin@webkit.org's avatar
      [Windows WebKit2] Use cookies set in WebKit1 · fcf9f8dd
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=60274
      
      Reviewed by Steve Falkenburg.
      
      Source/WebCore: 
      
      Share the default storage session between the UI and Web Processes.
      
      * platform/network/cf/CookieStorageCFNet.cpp:
      (WebCore::defaultSessionCookieStorage):
      Keep track of the default storage session cookie storage.
      (WebCore::currentCookieStorage):
      Call defaultCookieStorage to get the default cookie storage.
      (WebCore::defaultCookieStorage):
      If there is a default storage session cookie storage, prefer that over getting the default
      cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
      without specifying a storage session will not get the cookie storage being shared by the UI
      and Web Processes.
      
      * platform/network/ResourceHandle.h:
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::willSendRequest):
      Make sure to set the current storage session on any requests used by the Web
      Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
      doing anything with the Web Process's default storage session (which is not the one shared
      with the UI Process).
      (WebCore::makeFinalRequest):
      Ditto.
      (WebCore::ResourceHandle::willSendRequest):
      Ditto.
      (WebCore::ResourceHandle::currentStorageSession):
      If there is a Private Browsing storage session, return that.
      If not, on Windows return the default storage session that is being shared with the UI
      Process and on Mac return 0.
      (WebCore::defaultCFURLStorageSession):
      (WebCore::ResourceHandle::setDefaultStorageSession):
      (WebCore::ResourceHandle::defaultStorageSession):
      
      * platform/network/cf/ResourceRequestCFNet.cpp:
      (WebCore::ResourceRequest::doUpdatePlatformRequest):
      Make sure to set the current storage session on any requests used by the Web
      Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
      doing anything with the Web Process's default storage session (which is not the one shared
      with the UI Process).
      
      Source/WebKit/win: 
      
      * WebView.cpp:
      (WebView::setCacheModel):
      Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
      
      Source/WebKit2: 
      
      Share the default storage session between the UI and Web Processes.
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::encode):
      Only encode the session parameter if it is valid.
      (WebKit::WebProcessCreationParameters::decode):
      Don't try to decode a null session data. 
      * Shared/WebProcessCreationParameters.h:
      Add a parameter for a serialized default storage session, used only on Windows.
      
      * Shared/win/WebCoreArgumentCodersWin.cpp:
      (CoreIPC::decodeResourceRequest):
      Make sure to set the current storage session on any requests used by the Web
      Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
      doing anything with the Web Process's default storage session.
      
      * UIProcess/win/WebContextWin.cpp:
      (WebKit::WebContext::platformInitializeWebProcess):
      Serialize the default storage session in the UI Process and add it to the
      WebProcessCreationParameters.
      
      * WebProcess/WebPage/win/WebPageWin.cpp:
      (WebKit::cachedResponseForURL):
      Use the cache associated with the current storage session and make sure the request has the
      current storage session set on it before doing anything with it.
      
      * WebProcess/win/WebProcessWin.cpp:
      (WebKit::WebProcess::platformSetCacheModel):
      Use the default storage session.
      (WebKit::WebProcess::platformClearResourceCaches):
      Ditto.
      (WebKit::WebProcess::platformInitializeWebProcess):
      Deserialize the default storage session passed in by the UI Process and hand it to the
      ResourceHandle.
      
      WebKitLibraries: 
      
      Take 3 after rolling out KB2465367 from my system.
      
      * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
      * win/lib/WebKitSystemInterface.lib:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcf9f8dd
    • commit-queue@webkit.org's avatar
      2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi> · d11df501
      commit-queue@webkit.org authored
              Reviewed by David Kilzer.
      
              Remove wml directory from include lists
              https://bugs.webkit.org/show_bug.cgi?id=60646
      
              Remove wml dir from CMake, Autotools and qmake build systems since WML
              was removed in r85256.
      
              No new tests since no change in functionality.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d11df501
    • commit-queue@webkit.org's avatar
      2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi> · 6c51b914
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [CMAKE] Move EFL-specific file to CMakeListsEfl.txt
              https://bugs.webkit.org/show_bug.cgi?id=60642
      
              Move file EFL-specific file to the CMakeListsEfl.txt file. This implies
              having to include CMakeLists${PORT}.txt before the ADD_CUSTOM_COMMAND
              calls, since they depend on lists that now may change inside a port
              like WebCore_USER_AGENT_STYLE_SHEETS.
      
              No new tests since no change in functionality.
      
              * CMakeLists.txt: remove css file specific to EFL port.
              * CMakeListsEfl.txt: move file here.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c51b914