GitLab

https://bugs.webkit.org/show_bug.cgi?id=113381

Reviewed by Pavel Feldman.

Source/WebCore:

Breakpoint manager now restores breakpoints on UISourceCodeAdded event.
Breakpoint manager now only resets breakpoints in debugger when source mapping is changed to/from non identity one.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._resetBreakpoints):
(WebInspector.BreakpointManager.prototype._uiSourceCodeMappingChanged):
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.get isIdentity):
* inspector/front-end/DefaultScriptMapping.js:
(WebInspector.DefaultScriptMapping.prototype.isIdentity):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.isIdentity):
* inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype.isIdentity):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.SnippetScriptMapping.prototype.isIdentity):
* inspector/front-end/SourceMapping.js:
(WebInspector.SourceMapping.prototype.isIdentity):
* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype.isIdentity):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.setSourceMapping):

LayoutTests:

* inspector/debugger/breakpoint-manager-expected.txt:
* inspector/debugger/breakpoint-manager.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats
https://bugs.webkit.org/show_bug.cgi?id=113376

Reviewed by Vsevolod Vlasov.

Fixed assertion failure in debug mode after r146975.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: FlameChart. Provide 15px padding left for the chart so developers will see the first divider with '0' title.
https://bugs.webkit.org/show_bug.cgi?id=113404

Reviewed by Pavel Feldman.

15px paddingLeft was added to the code for the chart.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
(WebInspector.FlameChart.Calculator.prototype.computePosition):
(WebInspector.FlameChart.prototype.draw):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/146864
https://bugs.webkit.org/show_bug.cgi?id=113391

causes crashes on Wk2 EFL release bot (Requested by drott on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-27

.:

* Source/cmake/OptionsEfl.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113396

Reviewed by Philippe Normand.

So far, we were using the `MAKEFLAGS' environment variable to pass the
number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
other hand, prefers to use the `jobs' variable from jhbuildrc for that.

We now behave more closely to the rest of the WebKit tools by first
checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
not set, just letting jhbuild itself figure out how many jobs to use.

* efl/jhbuildrc:
* gtk/jhbuildrc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113385

Unreviewed, EFL gardening.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-03-27

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113297

Reviewed by Alexey Proskuryakov.

Source/WebCore:

HTMLFormControlElement::readOnly is not an implementation of
'readOnly' IDL attribute. It's confusing and we don't need to
violate our naming convention.

No new tests. Just a refactoring.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isReadOnly):
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseAttribute):
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::isReadOnly):
(WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::matchesReadOnlyPseudoClass):
(WebCore::HTMLInputElement::matchesReadWritePseudoClass):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::matchesReadOnlyPseudoClass):
(WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::updateImage):
* rendering/RenderTextControl.cpp:
(WebCore::updateUserModifyProperty):
* rendering/RenderThemeMacShared.mm:
(WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):

Source/WebKit/chromium:

* src/WebFormControlElement.cpp:
(WebKit::WebFormControlElement::isReadOnly):

Source/WebKit/win:

* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::readOnly):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=112891

This patch is preparation work for removing
WorkQueue related code from TestRunnerQt and
replacing it with generic TestRunner code.

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

* API/JSStringRefQt.cpp:
(JSStringCreateWithQString):
    Adding a convenience function to create a
    JSStringRef from a QString.
* API/JSStringRefQt.h:

Tools:

* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::queueBackNavigation):
(TestRunnerQt::queueForwardNavigation):
(TestRunnerQt::queueLoadHTMLString):
(TestRunnerQt::queueReload):
(TestRunnerQt::queueLoadingScript):
(TestRunnerQt::queueNonLoadingScript):
(TestRunner::queueLoad):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
* DumpRenderTree/qt/WorkQueueItemQt.cpp:
(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(LoadAlternateHTMLStringItem::invoke):
(ReloadItem::invoke):
(ScriptItem::invoke):
(BackForwardItem::invoke):
* DumpRenderTree/qt/WorkQueueItemQt.h:
(LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
(LoadAlternateHTMLStringItem):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats
https://bugs.webkit.org/show_bug.cgi?id=113376

Reviewed by Vsevolod Vlasov.

Added missing fields to Timeline.TimelineEvent type definition in Inspector.json

* inspector/Inspector.json:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setDOMCounters):
Switched InspectorTimelineAgent to the new typed event builders.
(WebCore::InspectorTimelineAgent::setNativeHeapStatistics):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113368

Reviewed by Pavel Feldman.

Source/WebCore:

Added a missed line and a test.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._projectWillReset):

LayoutTests:

* inspector/debugger/breakpoint-manager.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113348

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
Reviewed by Vsevolod Vlasov.

No new tests.

- Append additional "<class>-start" class to the first highlighted span
and "<class>-end" class to the last highlighted span to provide a way
to set up a css classes with borders.
- Increment end column of the markup range to simulate inclusive range.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.highlightRange):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=112815

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
Reviewed by Vsevolod Vlasov.

No new tests: no change in behaviour.

- Add TextEditor.isClean and TextEditor.markClean methods
- Implement these methods in DefaultTextEditor
- Implement these methods in CodeMirrorTextEditor

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.isClean):
(WebInspector.CodeMirrorTextEditor.prototype.markClean):
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.isClean):
(WebInspector.DefaultTextEditor.prototype.markClean):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.isClean):
(WebInspector.TextEditor.prototype.markClean):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Web Inspector. rename method Timeline.Calculator.grandMinimumBoundary to Timeline.Calculator.zeroTime

No changes in behaviour.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart.Calculator.prototype.zeroTime):
(WebInspector.FlameChart.OverviewCalculator.prototype.zeroTime):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkBaseCalculator.prototype.zeroTime):
* inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.updateDividers):
(WebInspector.TimelineGrid.Calculator.prototype.zeroTime):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewCalculator.prototype.zeroTime):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineCalculator.prototype.zeroTime):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113315

Reviewed by Pavel Feldman.

Now when TimelineGrid is able to draw dividers with any offset
we could cut away paddingLeft member of Timeline.Calculator
and clear the code of TimelineGrid.

* inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.updateDividers):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelineCalculator.prototype.computePosition):
(WebInspector.TimelineCalculator.prototype.setDisplayWindow):
(WebInspector.TimelineCalculator.prototype.grandMinimumBoundary):
* inspector/front-end/inspectorCommon.css:
(.resources-dividers-label-bar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=112982

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-27
Reviewed by Noam Rosenthal.

Covered by existing WebGL tests.

Source/WebCore:

This patch adds support to pass GraphicsSurface flags during it's client creation.
This would be helpful to determine cases when blending can be disabled on client
side i.e When AlphaSupport is disabled during Graphics Surface creation.
With GLX, we rely on Window to provide us with necessary information on client side.
This might not be the case on other platforms or when not using Window on X.
This patch doesn't change original behaviour of creating GraphicsSurface client
with default flags GraphicsSurface::SupportsTextureTarget and GraphicsSurface::SupportsSharing.

* platform/graphics/texmap/TextureMapperPlatformLayer.h:
(WebCore::TextureMapperPlatformLayer::graphicsSurfaceFlags):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::createCanvasIfNeeded):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(CoordinatedGraphicsLayerState):
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceFlags):
* platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::initializeClient):

Source/WebKit2:

This patch adds support to pass GraphicsSurface flags
during it's client creation.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113275

Source/WebCore:

If a text node is distributed, its parent node for rendering and
styling might have no style. In the case, styleForText should return
default style.

Reviewed by Hajime Morrita.

Test: fast/dom/shadow/text-node-distributed-crash.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForText):
Check whether a parent node has any style or not. If not, return
default style. This is the same behavior as styleForElement.

LayoutTests:

Reviewed by Hajime Morrita.

* fast/dom/shadow/text-node-distributed-crash-expected.txt: Added.
* fast/dom/shadow/text-node-distributed-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113304

Patch by Takeshi Yoshino <tyoshino@chromium.org> on 2013-03-26
Reviewed by Kent Tamura.

socket_stream of Chromium buffers send data up to 32KiB (exact) bytes.

However, SocketStreamHandleInternal::send() method now keeps in-flight
send data not greater than m_maxPendingSendAllowed - 1 that is
32KiB - 1. This means that SocketStreamHandleInternal consumes the
buffered data in SocketStreamHandleBase by 32KiB - 1. It makes memory
copy operations unaligned unnecessarily. It should just use the
allowed size fully.

* platform/network/chromium/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::send):
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113277

Reviewed by Benjamin Poulain.

Simple patch to add a size based constructor for RefCountedArray
so that we can create an sharable array without a copy.

* wtf/RefCountedArray.h:
(RefCountedArray):
(WTF::RefCountedArray::RefCountedArray):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed rebaseline of test expectations after r146955 

* platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
* platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113171

Reviewed by Dimitri Glazkov.

Source/WebCore:

HitTestRequest is widely used in WebCore, but AllowShadowContents
flag is not turned on by default.  In most places, we can set the
flag on.

This change makes HitTests allow shadow contents by default.

To track all existing HitTests which do not allow shadow contents,
and discourage such a HitTest in the future, I've introduced
disallowShadowContenet flag so that callers must turn on this flag
explicitly if they want to disallow shadow contents in their HitTests.

This change should be refactoring and should not include any
behavior changes.  After this change, we'll investigate each place
where disallowShadowContents is used step by step and get rid of
the flag if it is okay to remove.

No new tests, no behavior change.

* dom/Document.h:
(Document):
* dom/TreeScope.cpp:
(WebCore::nodeFromPoint):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::contains):
* page/DragController.cpp:
(WebCore::elementUnderMouse):
(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::isInsideScrollbar):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureLongPress):
(WebCore::EventHandler::handleGestureScrollBegin):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
* page/EventHandler.h:
(EventHandler):
* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
* page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint):
* page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):
* rendering/HitTestRequest.h:
(WebCore::HitTestRequest::disallowsShadowContent):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::hitTestClipContent):
* testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
* WebKitSupport/ProximityDetector.cpp:
(BlackBerry::WebKit::ProximityDetector::findBestPoint):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Source/WebKit/chromium:

* src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspelledWord):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::visiblePositionForWindowPoint):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::bestTapNode):

Source/WebKit/efl:

* ewk/ewk_frame.cpp:
(ewk_frame_hit_test_new):

Source/WebKit/gtk:

* webkit/webkitwebinspector.cpp:
(webkit_web_inspector_inspect_coordinates):
* webkit/webkitwebview.cpp:
(prepareMouseEventForFrame):
(webkit_web_view_get_hit_test_result):

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame elementAtPoint:]):
* WebView/WebHTMLView.mm:
(-[WebHTMLView elementAtPoint:allowShadowContent:]):

Source/WebKit/qt:

* WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameAdapter::hitTestContent):

Source/WebKit/win:

* WebView.cpp:
(WebView::gestureNotify):

Source/WebKit2:

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::hitTest):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=112996

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-03-26
Reviewed by Rob Buis.

PR 312552
Internally Reviewed by Anthony Scian.

NavigatorContentUtilsClientBlackBerry is new'ed in WebPagePrivate::init(),
but not deleted anywhere. Fixed by creating an OwnPtr for it.
Also fixed some webkit-style errors.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
* Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113361.

Not Reviewed.

* platform/mac/TestExpectations:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Remove the WebVideoFrame, WebVideoFrameProvider, WebStreamTextureClient, and WebVideoLayer classes.
https://bugs.webkit.org/show_bug.cgi?id=112483

Reviewed by James Robinson.

Source/Platform:

These classes are no longer used, so remove them. And remove APIs
to provide them.

* Platform.gypi:
* chromium/public/WebCompositorSupport.h:
(WebKit):
* chromium/public/WebVideoFrame.h: Removed.
* chromium/public/WebVideoFrameProvider.h: Removed.
* chromium/public/WebVideoLayer.h: Removed.

Source/WebKit/chromium:

These classes are no longer used, so remove them.

* WebKit.gyp:
* public/WebMediaPlayer.h:
(WebKit):
(WebMediaPlayer):
* public/WebStreamTextureClient.h: Removed.
* public/WebVideoFrame.h: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=107539
<rdar://problem/13032692>

Reviewed by Simon Fraser.

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Update WebCoreSystemInterface.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initially move the Page out of the window if necessary;
Page defaults to in-window, which is wrong in many cases - we depend on
Page::isInWindow being accurate to decide whether WebPage::setIsInWindow is actually
a state change or not.
(WebKit::WebPage::setIsInWindow):
* WebProcess/WebProcess.cpp: Inform WebProcess when we go on/off screen.
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::pageDidMoveOnscreen): Keep track of the number of on-screen pages in this process.
(WebKit::WebProcess::pageWillMoveOffscreen): If the number of on-screen pages drops to zero,  clean up unused rendering resources.
* WebProcess/WebProcess.h:

Update WebSystemInterface.

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113137

Reviewed by Simon Fraser.

Source/WebCore: 

The current obscuration test only covers immediate children. We can find more cases by looking deeper into descendants.
        
The patch makes the test sufficiently smart to stop a heavy fully obscured gif animation on micrsoft.com.

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::animationAdvanced):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
        
    Invalidate parents to max test depth.

(WebCore::RenderBox::backgroundPaintedExtent):
        
    Background painting is pixel snapped.

(WebCore::isCandidateForOpaquenessTest):
(WebCore::RenderBox::foregroundIsKnownToBeOpaqueInRect):
        
    Separate foreground testing and make it recursive.
    Add fast bailout for common static positioned case.
    Remove maximum child count, the fast bailouts should prevent long tests.
    Add maximum depth so we know how deep we need to invalidate in styleDidChange.

(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
(WebCore):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
(WebCore):
(WebCore::RenderImage::computeBackgroundIsKnownToBeObscured):
        
* rendering/RenderImage.h:
(RenderImage):

LayoutTests: 

* fast/backgrounds/obscured-background-child-style-change-expected.html:
* fast/backgrounds/obscured-background-child-style-change.html:
* fast/repaint/obscured-background-no-repaint-expected.txt:
* fast/repaint/obscured-background-no-repaint.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113347

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-26
Reviewed by Geoffrey Garen.

The values zero and 0xffff have special values with the default HashTraits. Those values
are also valid values for UChar.

To avoid any table inconsitency, switch from UChar to uint32_t as the key type for
the WidthCache's single char map. The traits is also changed to allow zero as a normal
value.

This makes no space or time change over the previous code because:
-The struct KeyValuePair was already 64bits due to the ABI alignment restrictions on floats.
-The two hashes take the same number of instructions.

* platform/graphics/WidthCache.h:
(WidthCache):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113299

Reviewed by Kentaro Hara.

The only callsite of isDeterminate outside of HTMLProgressElement
is in StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes,
and we can replace it with Element::shouldAppearIndeterminate.

No new tests. Just a refactoring.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
Use Element::shouldAppearIndeterminate.
* html/HTMLProgressElement.h:
(HTMLProgressElement): Make isDeterminate private.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

danakj_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-26

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* wtf/ProcessID.h:
(WTF::getCurrentProcessID):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113350

Reviewed by Tony Chang.

Add histogram for source of LevelDB errors on Write in addition to
Open.

No new tests - no good way to test histogram code.

* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::histogramLevelDBError):
(WebCore):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::write):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113339

Reviewed by Tim Horton.

Source/WebCore: 

Make sure button types can return the AXRequired attribute.

Tests: platform/mac/accessibility/aria-required-popup-button.html

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests: 

* platform/mac/accessibility/aria-required-popup-button-expected.txt: Added.
* platform/mac/accessibility/aria-required-popup-button.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113356

Reviewed by Tim Horton.

* wtf/ProcessID.h:
(WTF::getCurrentProcessID):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113353
<rdar://problem/13510778>

Source/JavaScriptCore: 

Reviewed by Mark Hahnenberg and Geoffrey Garen.
        
ToString should call speculateStringObject() even if you know that it's a string object, since
it calls it to also get the watchpoint. Note that even with this change, if you do
Phantom(Check:StringObject:@a), it might get eliminated just because we proved that @a is a
string object (thereby eliminating the prototype watchpoint); that's fine since ToString is
MustGenerate and never decays to Phantom.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
(JSC::DFG::SpeculativeJIT::speculateStringObject):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):

LayoutTests: 

Reviewed by Mark Hahnenberg and Geoffrey Garen.

* fast/js/jsc-test-list:
* fast/js/dfg-phantom-base-expected.txt: Added.
* fast/js/dfg-phantom-base.html: Added.
* fast/js/dfg-to-string-toString-becomes-bad-with-check-structure-expected.txt: Added.
* fast/js/dfg-to-string-toString-becomes-bad-with-check-structure.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=113265

Reviewed by Tim Horton.

Source/WebCore:

If we detect a primary plugin that is snapshotted, we immediately restart it.
When this happens, we should also restart any other plugins that
match the same origin and type. This allows sites with a lot of
(geometrically) nearby plugins to behave as if they are a single big plugin.

Tests: plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html
       plugins/snapshotting/autoplay-similar-to-dominant.html

* WebCore.exp.in: Export mimeTypeFromURL.
* html/HTMLPlugInImageElement.cpp:
(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Use loadedMimeType helper.
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): New method, which copied the
    existing code from userDidClickSnapshot.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Move the similar plugin detection
    out into another function and call it.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Call restartSimilarPlugIns.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Use loadedMimeType helper.
* html/HTMLPlugInImageElement.h: Declaration of restartSimilarPlugIns.
(WebCore::HTMLPlugInImageElement::loadedMimeType): New helper method since this
    code was being often duplicated.

Source/WebKit2:

Remember the origin of the primary plugin, so that we can
autostart anything that is similar.

* WebProcess/WebCoreSupport/WebPlugInClient.cpp:
(WebKit::WebPlugInClient::WebPlugInClient): Keep a pointer to the WebPage.
(WebKit::WebPlugInClient::shouldAutoStartFromOrigin): Pass the page onto the process.
* WebProcess/WebCoreSupport/WebPlugInClient.h:
(WebPlugInClient): New member variable for the WebPage we were created with.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn): Remember the origin information
    for the primary plugin.
(WebKit::WebPage::matchesPrimaryPlugIn): Returns true if we're seeing something that
    looks like the primary plugin.
* WebProcess/WebPage/WebPage.h: New method matchesPrimaryPlugIn.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Check if the page thinks this is
    the primary plugin.
* WebProcess/WebProcess.h: Accept a reference to the page in shouldPlugInAutoStartFromOrigin.

LayoutTests:

Two new tests. The first has one big plugin (that should be detected as the primary)
and then a few smaller versions (which should autostart along with the primary).
The second has one big plugin, and then adds a similar one after a short delay.

* platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-after-delay-expected.txt: Added.
* platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-expected.txt: Added.
* plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html: Added.
* plugins/snapshotting/autoplay-similar-to-dominant.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=112106

Rubber stamped by Filip Pizlo.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32): Get rid of the case for constants because
we would have done constant folding anyways on a ValueToInt32.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean): Fixed a random compile error with this flag enabled.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Fix test after r146938. Since CSS Exclusions is still an experimental feature, shape-inside-on-nested-container-with-unresolved-height.html
test should enable CSS Exclusions for the testrunners first.  

* fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Set CSSExclisions enabled for DRT/WTR.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Marked compositing/rtl/rtl-iframe-* tests as ImageOnlyFailure instead of Failure.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=39889

Reviewed by Anders Carlsson.

This must be tested manually. See the issue for details.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext):
Revise the Windows implementation of the PluginView class
paintWindowedPluginIntoContext to use the containing window
position when computing the plugin's position for printing.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146941 268f45cc-cd09-0410-ab3c-d52691b4dbfc