- 15 Feb, 2011 40 commits
-
-
mihaip@chromium.org authored
Unreviewed chromium-gpu expectations update. Update expectations after tests that were unskipped by r78619 started to be run again. Most of them don't time out anymore, instead they have image and/or text diffs. Also remove flaky expectations for fast/canvas/shadow-offset-*.html, since they pass consistently now that the bug on the Chromium/V8 side (http://crbug.com/67732) has been fixed. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78628 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
http://webkit.org/b/54485ddkilzer@apple.com authored
Reviewed by Darin Adler. * WebView/WebDynamicScrollBarsView.h: * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from -inProgramaticScroll. * WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
joepeck@webkit.org authored
Reviewed by David Kilzer. Cleanup Some Potential ENABLE(INSPECTOR) Related Building Issues https://bugs.webkit.org/show_bug.cgi?id=54048 * WebCore.exp.in: moved inspector only export into ENABLE(INSPECTOR) block. * bindings/js/ScriptHeapSnapshot.h: include no longer needed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78626 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
senorblanco@chromium.org authored
Reviewed by James Robinson. [chromium] clearRect() is incorrect in accelerated 2D canvas. https://bugs.webkit.org/show_bug.cgi?id=54497 When doing GPU-Canvas2D clearRect() using the fast path (glClear()), we were not correctly converting from canvas to screen coordinates. Fixed by inverting the rectangle in Y, and changing SharedGraphicsContext3D::scissor to take glScissor-like parameters. Covered by fast/canvas/canvas-strokeRect.html. * platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::clearRect): Flip the Y coord of the rectangle passed to scissor(). * platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::scissor): * platform/graphics/gpu/SharedGraphicsContext3D.h: Give scissor() the same param types as GraphicsContext3D::scissor(). 2011-02-15 Stephen White <senorblanco@chromium.org> Reviewed by James Robinson. [chromium] Mark fast/canvas/canvas-strokeRect.html as passing on the GPU path. https://bugs.webkit.org/show_bug.cgi?id=54497 * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78625 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
jberlin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=54496 Reviewed by Darin Adler. * UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformDefaultDatabaseDirectory): Use the same logic as WebKit1's WebDatabaseManager::databasesDirectoryPath. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by Anders Carlsson, Darin Adler. Layers stick around in DrawingAreaImpl until we switch out of compositing https://bugs.webkit.org/show_bug.cgi?id=54498 When leaving compositing mode soon, remove all the child layers of the nonCompositedContent layer right away, so they don't stick around. * WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer): * WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::setRootCompositingLayer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78623 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
psolanki@apple.com authored
Move WTF_USE_CFNETWORK to Platform.h https://bugs.webkit.org/show_bug.cgi?id=54168 Reviewed by Darin Adler. * wtf/Platform.h: Define WTF_USE_CFNETWORK for Windows builds. 2011-02-15 Pratik Solanki <psolanki@apple.com> Move WTF_USE_CFNETWORK to Platform.h https://bugs.webkit.org/show_bug.cgi?id=54168 Reviewed by Darin Adler. * config.h: Remove WTF_USE_CFNETWORK. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78622 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mihaip@chromium.org authored
Unreviewed chromium-gpu expectations update. compositing/reflections/animation-inside-reflection.html and compositing/reflections/nested-reflection-animated.html are flaky on Linux too. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78621 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
kbr@google.com authored
Reviewed by Darin Fisher. Allow controlling minimum DOMTimer interval on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=54312 Implemented new method setMinimumTimerInterval in LayoutTestController for all ports. * DumpRenderTree/LayoutTestController.cpp: (setMinimumTimerIntervalCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setMinimumTimerInterval): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset): * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMinimumTimerInterval): * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMinimumTimerInterval): * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMinimumTimerInterval): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMinimumTimerInterval): 2011-02-15 Kenneth Russell <kbr@google.com> Reviewed by Darin Fisher. Allow controlling minimum DOMTimer interval on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=54312 * fast/dom/timer-increase-min-interval-and-reset-part-1-expected.txt: Added. * fast/dom/timer-increase-min-interval-and-reset-part-1.html: Added. * fast/dom/timer-increase-min-interval-and-reset-part-2-expected.txt: Added. * fast/dom/timer-increase-min-interval-and-reset-part-2.html: Added. - Chained tests (the assumption is that the run-webkit-tests harness will run them sequentially, which is a reasonably good assumption) which verify that the minimum timer interval is reset between tests. * fast/dom/timer-increase-min-interval-expected.txt: Added. * fast/dom/timer-increase-min-interval.html: Added. - Verifies that increasing the minimum timer interval causes fast timers to run slowly. * fast/dom/timer-increase-then-decrease-min-interval-expected.txt: Added. * fast/dom/timer-increase-then-decrease-min-interval.html: Added. - Verifies that decreasing the minimum timer interval causes previously slowed-down timers to be reevaluated immediately. 2011-02-15 Kenneth Russell <kbr@google.com> Reviewed by Darin Fisher. Allow controlling minimum DOMTimer interval on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=54312 * public/WebSettings.h: - Added setMinimumTimerInterval. * src/WebKit.cpp: (WebKit::initialize): - Added FIXME to remove setting of page's default timer interval. * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setMinimumTimerInterval): - Implemented new method on WebSettings. * src/WebSettingsImpl.h: 2011-02-15 Kenneth Russell <kbr@google.com> Reviewed by Darin Fisher. Allow controlling minimum DOMTimer interval on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=54312 Added needed methods to implement LayoutTestController's new setMinimumTimerInterval method. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::defaultMinimumTimerInterval): (DumpRenderTreeSupportQt::setMinimumTimerInterval): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2011-02-15 Kenneth Russell <kbr@google.com> Reviewed by Darin Fisher. Allow controlling minimum DOMTimer interval on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=54312 Added needed methods to implement LayoutTestController's new setMinimumTimerInterval method. * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::defaultMinimumTimerInterval): (DumpRenderTreeSupportGtk::setMinimumTimerInterval): * WebCoreSupport/DumpRenderTreeSupportGtk.h: 2011-02-15 Kenneth Russell <kbr@google.com> Reviewed by Darin Fisher. Allow controlling minimum DOMTimer interval on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=54312 Added needed methods to implement LayoutTestController's new setMinimumTimerInterval method. Includes whitespace-only change to WebKit.idl to trigger proper rebuild on bots; will be removed in subsequent checkin. * Interfaces/IWebViewPrivate.idl: * Interfaces/WebKit.idl: * WebView.cpp: (WebView::initWithFrame): (WebView::defaultMinimumTimerInterval): (WebView::setMinimumTimerInterval): * WebView.h: 2011-02-15 Kenneth Russell <kbr@google.com> Reviewed by Darin Fisher. Allow controlling minimum DOMTimer interval on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=54312 Added needed methods to implement LayoutTestController's new setMinimumTimerInterval method. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (+[WebView _defaultMinimumTimerInterval]): (-[WebView _setMinimumTimerInterval:]): * WebView/WebViewPrivate.h: 2011-02-15 Kenneth Russell <kbr@google.com> Reviewed by Darin Fisher. Allow controlling minimum DOMTimer interval on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=54312 Renamed DOMTimer::minTimerInterval and setMinTimerInterval to defaultMinTimerInterval and setDefaultMinTimerInterval, made them private and exposed them via Settings::defaultMinDOMTimerInterval and setDefaultMinDOMTimerInterval. Added new Settings::setMinDOMTimerInterval and minDOMTimerInterval. The storage for the minimum timer interval currently lives in the Page, though this could be moved to the Settings object if desired. The accessor methods on the Page are private and exposed to Settings by making Settings a friend, so the abstraction barrier is clear at the API level. Adjusting the interval both upward and downward may cause the fire times of the active timers on the page to be adjusted, if they would be affected by the clamping value. This is needed to reduce latency when bringing a tab to the foreground, in particular if the minimum timer interval was decreased from a very high value to a very low value. A new method, setMinimumTimerInterval, has been added to LayoutTestController, implemented in all ports of DumpRenderTree, and used in new layout tests. Ideally changing the page's minimum timer interval would affect dedicated workers, but this is too much to do in an initial patch, so a FIXME has been added. Tested with: - The new layout tests on the WebKit Mac and Chromium (Mac, Linux) DRT ports. - Hooked up the new API in Chromium and ran some simple manual tests. Tests: fast/dom/timer-increase-min-interval-and-reset-part-1.html fast/dom/timer-increase-min-interval-and-reset-part-2.html fast/dom/timer-increase-min-interval.html fast/dom/timer-increase-then-decrease-min-interval.html * WebCore.exp.in: * dom/Document.cpp: (WebCore::Document::minimumTimerInterval): * dom/Document.h: * dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::adjustMinimumTimerInterval): (WebCore::ScriptExecutionContext::minimumTimerInterval): * dom/ScriptExecutionContext.h: * page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::adjustMinimumTimerInterval): (WebCore::DOMTimer::intervalClampedToMinimum): * page/DOMTimer.h: (WebCore::DOMTimer::defaultMinTimerInterval): (WebCore::DOMTimer::setDefaultMinTimerInterval): * page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setMinimumTimerInterval): (WebCore::Page::minimumTimerInterval): * page/Page.h: * page/Settings.cpp: (WebCore::Settings::setDefaultMinDOMTimerInterval): (WebCore::Settings::defaultMinDOMTimerInterval): (WebCore::Settings::setMinDOMTimerInterval): (WebCore::Settings::minDOMTimerInterval): * page/Settings.h: * platform/Timer.h: (WebCore::TimerBase::augmentFireInterval): (WebCore::TimerBase::augmentRepeatInterval): 2011-02-15 Kenneth Russell <kbr@google.com> Reviewed by Darin Fisher. Allow controlling minimum DOMTimer interval on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=54312 * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78620 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mihaip@chromium.org authored
Unreviewed chromium-gpu baseline update. Unskip some tests that fail; we want to keep running them in case they regress in unexpected ways (e.g. they start to crash). * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78619 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Reviewed by Beth Dakin. Fix scrollbar rendering crash when rendered into a layer https://bugs.webkit.org/show_bug.cgi?id=54494 Remove code added in r78394 which was intended to find out whether a scrollbar was being rendered into a compositing layer. r78612 obviated the need for this code. * page/FrameView.h: * platform/ScrollableArea.h: * rendering/RenderLayer.cpp: * rendering/RenderLayer.h: * rendering/RenderListBox.cpp: * rendering/RenderListBox.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78618 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Let Xcode have its way with the project. * WebCore.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78617 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Fix Mac builds that don't use rubber-band scrolling by moving m_drawingIntoLayer out of the #ifdef. * platform/mac/ScrollAnimatorMac.h: * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78616 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mrobinson@webkit.org authored
Reviewed by Xan Lopez. [Freetype] Better map CSS font weight to Fontconfig font weight https://bugs.webkit.org/show_bug.cgi?id=54323 Update the results of this test, which is now passing. Also update results for all other tests which have different results now. * platform/gtk/fast/css/font-weight-1-expected.checksum: * platform/gtk/fast/css/font-weight-1-expected.png: * platform/gtk/fast/css/font-weight-1-expected.txt: 2011-02-15 Martin Robinson <mrobinson@igalia.com> Reviewed by Xan Lopez. [Freetype] Better map CSS font weight to Fontconfig font weight https://bugs.webkit.org/show_bug.cgi?id=54323 * platform/graphics/freetype/FontCacheFreeType.cpp: (WebCore::fontWeightToFontconfigWeight): Added this helper to map between CSS and Fontconfig font weights. (WebCore::FontCache::createFontPlatformData): Use the new helper instead of just deciding between bold and regular. 2011-02-15 Martin Robinson <mrobinson@igalia.com> Reviewed by Xan Lopez. [Freetype] Better map CSS font weight to Fontconfig font weight https://bugs.webkit.org/show_bug.cgi?id=54323 Add the WeightWatcher fonts to the list of sourced fonts when intializing DRT. This will allow us to pass tests that use WeightWatcher. * DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Source the WebkitWeightWatcher fonts. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78614 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mihaip@chromium.org authored
Unreviewed chromium-gpu-linux rebaseline. Check in correct expectations which should allow us to remove the PASS FAIL line for compositing/ for this platform. * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum: * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png: * platform/chromium-gpu-linux/compositing/generated-content-expected.checksum: * platform/chromium-gpu-linux/compositing/generated-content-expected.png: * platform/chromium-gpu-linux/compositing/geometry/composited-html-size-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/geometry/composited-html-size-expected.png: Added. * platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum: * platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png: * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum: * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png: * platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added. * platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.png: Added. * platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum: * platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png: * platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png: Added. * platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png: Added. * platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: * platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png: * platform/chromium-gpu-linux/compositing/reflections/animation-inside-reflection-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/animation-inside-reflection-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/compositing-change-inside-reflection-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/masked-reflection-on-composited-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-animated-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-animated-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-mask-change-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-on-overflow-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-opacity-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-opacity-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-size-change-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-size-change-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.checksum: * platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png: * platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/reflection-ordering-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/reflection-ordering-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/reflection-positioning-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/reflection-positioning-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/reflection-positioning2-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/reflection-positioning2-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/simple-composited-reflections-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/simple-composited-reflections-expected.png: Added. * platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.png: Added. * platform/chromium-gpu-linux/compositing/sibling-positioning-expected.checksum: * platform/chromium-gpu-linux/compositing/sibling-positioning-expected.png: * platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.png: Added. * platform/chromium-gpu-linux/compositing/webgl/webgl-reflection-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/webgl/webgl-reflection-expected.png: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78613 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Reviewed by Sam Weinig. Fix scrollbar rendering crash when rendered into a layer https://bugs.webkit.org/show_bug.cgi?id=54494 The scroller delegate was failing to return a layer in a case where the scroller was still rendering into a GraphicsLayer, because even though WebCore had switched out of compositing mode, the DrawingAreaImpl was still rendering into its nonCompositedContent layer. This happens when the m_exitCompositingTimer timer hasn't fired yet. The fix is to track whether we're drawing into a layer via the GraphicsContext, rather than asking about compositing layers. * platform/graphics/GraphicsContext.h: * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setIsCALayerContext): (WebCore::GraphicsContext::isCALayerContext): Getter and setter for the bit that says if we're rendering into a CALayer. * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): Store a bool for whether this context targets a layer. * platform/graphics/mac/WebLayer.mm: (drawLayerContents): Call setIsCALayerContext(true). * platform/mac/ScrollAnimatorMac.h: (WebCore::ScrollAnimatorMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorMac::isDrawingIntoLayer): New methods to get and set a flag that says when we're drawing into a layer, so that the delegate can get at this state. * platform/mac/ScrollAnimatorMac.mm: (-[ScrollbarPainterDelegate layer]): Use isDrawingIntoLayer() (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Init the flag. * platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::unregisterScrollbar): Whitespace. (WebCore::ScrollbarThemeMac::paint): Push the "isDrawingIntoLayer" state down onto ScrollAnimatorMac, getting it from the GraphicsContext. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78612 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andersca@apple.com authored
Reviewed by Sam Weinig. Add sitesWithData and clearSiteData to NetscapePluginModule https://bugs.webkit.org/show_bug.cgi?id=54492 * Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::NetscapePluginModule): (WebKit::NetscapePluginModule::pluginCreated): (WebKit::NetscapePluginModule::pluginDestroyed): (WebKit::NetscapePluginModule::sitesWithData): (WebKit::NetscapePluginModule::clearSiteData): (WebKit::NetscapePluginModule::tryGetSitesWithData): (WebKit::NetscapePluginModule::tryClearSiteData): (WebKit::NetscapePluginModule::incrementLoadCount): (WebKit::NetscapePluginModule::decrementLoadCount): * Shared/Plugins/Netscape/NetscapePluginModule.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78611 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tony@chromium.org authored
Rebaseline chromium-linux tests with menulists (select drop downs). We now match Windows w.r.t. sizes, the only difference is the background color of the menulist (in themeChromiumLinux.css). * platform/chromium-linux/editing/pasteboard/4641033-expected.checksum: * platform/chromium-linux/editing/pasteboard/4641033-expected.png: * platform/chromium-linux/editing/pasteboard/4641033-expected.txt: * platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum: * platform/chromium-linux/editing/pasteboard/4944770-1-expected.png: * platform/chromium-linux/editing/pasteboard/4944770-1-expected.txt: * platform/chromium-linux/editing/pasteboard/4944770-2-expected.checksum: * platform/chromium-linux/editing/pasteboard/4944770-2-expected.png: * platform/chromium-linux/editing/pasteboard/4944770-2-expected.txt: * platform/chromium-linux/editing/selection/caret-before-select-expected.checksum: * platform/chromium-linux/editing/selection/caret-before-select-expected.png: * platform/chromium-linux/editing/selection/caret-before-select-expected.txt: * platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.checksum: * platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.png: * platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.txt: * platform/chromium-linux/editing/selection/select-box-expected.checksum: * platform/chromium-linux/editing/selection/select-box-expected.png: * platform/chromium-linux/editing/selection/select-box-expected.txt: * platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.checksum: * platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png: * platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.txt: * platform/chromium-linux/fast/block/float/float-avoidance-expected.checksum: * platform/chromium-linux/fast/block/float/float-avoidance-expected.png: * platform/chromium-linux/fast/block/float/float-avoidance-expected.txt: * platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum: * platform/chromium-linux/fast/block/margin-collapse/103-expected.png: * platform/chromium-linux/fast/block/margin-collapse/103-expected.txt: * platform/chromium-linux/fast/forms/003-expected.checksum: * platform/chromium-linux/fast/forms/003-expected.png: * platform/chromium-linux/fast/forms/003-expected.txt: * platform/chromium-linux/fast/forms/004-expected.checksum: * platform/chromium-linux/fast/forms/004-expected.png: * platform/chromium-linux/fast/forms/004-expected.txt: * platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.checksum: * platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.png: * platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.txt: * platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.checksum: * platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.png: * platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.txt: * platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.checksum: * platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.png: * platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.txt: * platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.checksum: * platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.png: * platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.txt: * platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.checksum: * platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.png: * platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.txt: * platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.checksum: * platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.png: * platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.txt: * platform/chromium-linux/fast/forms/basic-selects-expected.checksum: * platform/chromium-linux/fast/forms/basic-selects-expected.png: * platform/chromium-linux/fast/forms/basic-selects-expected.txt: * platform/chromium-linux/fast/forms/control-clip-overflow-expected.checksum: * platform/chromium-linux/fast/forms/control-clip-overflow-expected.png: * platform/chromium-linux/fast/forms/control-clip-overflow-expected.txt: * platform/chromium-linux/fast/forms/control-restrict-line-height-expected.checksum: * platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png: * platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt: * platform/chromium-linux/fast/forms/disabled-select-change-index-expected.checksum: * platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png: * platform/chromium-linux/fast/forms/disabled-select-change-index-expected.txt: * platform/chromium-linux/fast/forms/menulist-clip-expected.checksum: * platform/chromium-linux/fast/forms/menulist-clip-expected.png: * platform/chromium-linux/fast/forms/menulist-clip-expected.txt: * platform/chromium-linux/fast/forms/menulist-deselect-update-expected.checksum: * platform/chromium-linux/fast/forms/menulist-deselect-update-expected.png: * platform/chromium-linux/fast/forms/menulist-deselect-update-expected.txt: * platform/chromium-linux/fast/forms/menulist-narrow-width-expected.checksum: * platform/chromium-linux/fast/forms/menulist-narrow-width-expected.png: * platform/chromium-linux/fast/forms/menulist-narrow-width-expected.txt: * platform/chromium-linux/fast/forms/menulist-no-overflow-expected.checksum: * platform/chromium-linux/fast/forms/menulist-no-overflow-expected.png: * platform/chromium-linux/fast/forms/menulist-no-overflow-expected.txt: * platform/chromium-linux/fast/forms/menulist-option-wrap-expected.checksum: * platform/chromium-linux/fast/forms/menulist-option-wrap-expected.png: * platform/chromium-linux/fast/forms/menulist-option-wrap-expected.txt: * platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum: * platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png: * platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.txt: Removed. * platform/chromium-linux/fast/forms/menulist-separator-painting-expected.checksum: * platform/chromium-linux/fast/forms/menulist-separator-painting-expected.png: * platform/chromium-linux/fast/forms/menulist-separator-painting-expected.txt: * platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum: * platform/chromium-linux/fast/forms/menulist-style-color-expected.png: * platform/chromium-linux/fast/forms/menulist-style-color-expected.txt: * platform/chromium-linux/fast/forms/menulist-width-change-expected.checksum: * platform/chromium-linux/fast/forms/menulist-width-change-expected.png: * platform/chromium-linux/fast/forms/menulist-width-change-expected.txt: * platform/chromium-linux/fast/forms/option-script-expected.checksum: * platform/chromium-linux/fast/forms/option-script-expected.png: * platform/chromium-linux/fast/forms/option-script-expected.txt: * platform/chromium-linux/fast/forms/option-strip-whitespace-expected.checksum: * platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png: * platform/chromium-linux/fast/forms/option-strip-whitespace-expected.txt: * platform/chromium-linux/fast/forms/option-text-clip-expected.checksum: * platform/chromium-linux/fast/forms/option-text-clip-expected.png: * platform/chromium-linux/fast/forms/option-text-clip-expected.txt: * platform/chromium-linux/fast/forms/select-align-expected.checksum: * platform/chromium-linux/fast/forms/select-align-expected.png: * platform/chromium-linux/fast/forms/select-align-expected.txt: * platform/chromium-linux/fast/forms/select-baseline-expected.checksum: * platform/chromium-linux/fast/forms/select-baseline-expected.png: * platform/chromium-linux/fast/forms/select-baseline-expected.txt: * platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.checksum: * platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png: * platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.txt: * platform/chromium-linux/fast/forms/select-disabled-appearance-expected.checksum: * platform/chromium-linux/fast/forms/select-disabled-appearance-expected.png: * platform/chromium-linux/fast/forms/select-disabled-appearance-expected.txt: * platform/chromium-linux/fast/forms/select-empty-option-height-expected.checksum: * platform/chromium-linux/fast/forms/select-empty-option-height-expected.png: * platform/chromium-linux/fast/forms/select-empty-option-height-expected.txt: * platform/chromium-linux/fast/forms/select-selected-expected.checksum: * platform/chromium-linux/fast/forms/select-selected-expected.png: * platform/chromium-linux/fast/forms/select-selected-expected.txt: * platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.checksum: * platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.png: * platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.txt: * platform/chromium-linux/fast/html/keygen-expected.checksum: * platform/chromium-linux/fast/html/keygen-expected.png: * platform/chromium-linux/fast/html/keygen-expected.txt: * platform/chromium-linux/fast/invalid/014-expected.checksum: * platform/chromium-linux/fast/invalid/014-expected.png: * platform/chromium-linux/fast/invalid/014-expected.txt: * platform/chromium-linux/fast/invalid/residual-style-expected.checksum: * platform/chromium-linux/fast/invalid/residual-style-expected.png: * platform/chromium-linux/fast/invalid/residual-style-expected.txt: * platform/chromium-linux/fast/parser/document-write-option-expected.checksum: * platform/chromium-linux/fast/parser/document-write-option-expected.png: * platform/chromium-linux/fast/parser/document-write-option-expected.txt: * platform/chromium-linux/fast/repaint/control-clip-expected.checksum: * platform/chromium-linux/fast/repaint/control-clip-expected.png: * platform/chromium-linux/fast/repaint/control-clip-expected.txt: * platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum: * platform/chromium-linux/fast/replaced/replaced-breaking-expected.png: * platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt: * platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.checksum: * platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.png: * platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt: * platform/chromium-linux/fast/replaced/three-selects-break-expected.checksum: * platform/chromium-linux/fast/replaced/three-selects-break-expected.png: * platform/chromium-linux/fast/replaced/three-selects-break-expected.txt: * platform/chromium-linux/fast/text/international/bidi-menulist-expected.checksum: * platform/chromium-linux/fast/text/international/bidi-menulist-expected.png: * platform/chromium-linux/fast/text/international/bidi-menulist-expected.txt: * platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: * platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: * platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: * platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum: * platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt: * platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.checksum: * platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt: * platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.checksum: * platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt: * platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt: * platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.checksum: * platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.txt: * platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.checksum: * platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.txt: * platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.checksum: * platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt: * platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum: * platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt: * platform/chromium-linux/tables/mozilla/core/margins-expected.checksum: * platform/chromium-linux/tables/mozilla/core/margins-expected.png: * platform/chromium-linux/tables/mozilla/core/margins-expected.txt: * platform/chromium-linux/tables/mozilla/dom/tableDom-expected.checksum: * platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png: * platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt: * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum: * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: * platform/chromium-linux/transforms/2d/zoom-menulist-expected.checksum: * platform/chromium-linux/transforms/2d/zoom-menulist-expected.png: * platform/chromium-linux/transforms/2d/zoom-menulist-expected.txt: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78610 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
weinig@apple.com authored
* Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::encodeResourceRequest): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Reversing an expectations update, that I mistakenly uploaded in r78595. * platform/gtk/Skipped: Skip this test, as the results are incorrect on GTK+. * svg/text/lengthAdjust-text-metrics-expected.txt: Restore expectations for this test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78608 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
https://bugs.webkit.org/show_bug.cgi?id=54490sfalken@apple.com authored
* platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jochen@chromium.org authored
Reviewed by Jeremy Orlow. [chromium] add WebIDBFactory::deleteDatabase method https://bugs.webkit.org/show_bug.cgi?id=54447 * public/WebIDBFactory.h: (WebKit::WebIDBFactory::open): (WebKit::WebIDBFactory::deleteDatabase): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78606 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ggaren@apple.com authored
Reviewed by Darin Adler. Moved MarkedBlock data members to the head of the block https://bugs.webkit.org/show_bug.cgi?id=54482 This allows for a variable-sized tail, to accommodate oversized blocks. SunSpider reports no change. * runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): * runtime/MarkedBlock.cpp: (JSC::MarkedBlock::destroy): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep): * runtime/MarkedBlock.h: Added missing element to the CELLS_PER_BLOCK calculation. This kind of error is why we want to migrate to the system described below. (JSC::roundUpToMultipleOf): (JSC::MarkedBlock::firstCell): (JSC::MarkedBlock::cells): (JSC::MarkedBlock::cellNumber): Use subtraction instead of masking to calculate cell number. The mask is no longer correct because the first cell is not at the head of the block. (JSC::MarkedBlock::forEach): Replaced m_cells data member with a cells() accessor. We want to use sizeof(MarkedBlock) to calculate the size of the block header, so we can't have an explicit data member to represent the block tail. Also replaced iteration from zero with iteration from startCell(), since the first N cells are now occupied by the header. * runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::reset): Replaced iteration from zero as above. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78605 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andersca@apple.com authored
Reviewed by Darin Adler. Add NPP_GetSitesWithData and NPP_URLRedirectNotify to the NPAPI headers https://bugs.webkit.org/show_bug.cgi?id=54481 We should really sync all headers with the NPAPI repository, but doing that lead to build errors so I just added what was needed. * bridge/npapi.h: Add new functions. * bridge/nptypes.h: Sync with the official NPAPI repository, adding 64-bit integer types and removing a duplicate license header. * plugins/npfunctions.h: Add new functions. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78604 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=54480 <rdar://problem/8975229> REGRESSION (WebKit2): A web page remains unresponsive for a long time after printing Nothing was painted until moving the mouse over browser chrome, deactivating the window, or taking some other drastic measure like that. * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay): Call -[NSView displayIfNeeded] after enabling autodisplay. For some reason, this makes WebCore push updates again. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78603 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
antti@apple.com authored
Crashes under CachedResourceLoader::revalidateResource Reviewed by Darin Adler. CachedResourceLoader might get deleted from under one of its methods. Try to catch a more informative crash stack. * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::CachedResourceLoader): (WebCore::CachedResourceLoader::~CachedResourceLoader): (WebCore::CachedResourceLoader::requestImage): (WebCore::CachedResourceLoader::requestUserCSSStyleSheet): (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::setAutoLoadImages): (WebCore::CachedResourceLoader::load): (WebCore::CachedResourceLoader::loadDone): (WebCore::CachedResourceLoader::preload): (WebCore::CachedResourceLoader::requestPreload): * loader/cache/CachedResourceLoader.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78602 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
dpranke@chromium.org authored
Reviewed by Tony Chang. Make new-run-webkit-tests --processes work under Windows' weird multiprocessing model. This requires us to be running a Python file that can be imported as a module, so I've modified the new-run-webkit-tests script to spawn a subprocess runing webkitpy.layout_tests.run_webkit_tests.py. I've also modified the manager_worker_broker tests because you can't pickle a nested class. This requires us to use globals to pass queues back and forth for testing, but the alternative is to pass extra arguments to start_worker() and that feels like a bad tradeoff just for testing. https://bugs.webkit.org/show_bug.cgi?id=54431 * Scripts/new-run-webkit-tests: * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78601 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
weinig@apple.com authored
Reviewed by Darin Adler. Crash loading fast/loader/empty-embed-src-attribute.html <rdar://problem/9005541> https://bugs.webkit.org/show_bug.cgi?id=54483 Add the ability to encode/decode and empty ResourceRequest. * Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::encodeResourceRequest): (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse): Add missing false check for the decode step. * Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::encodeResourceRequest): (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse): Add missing false check for the decode step. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78600 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
senorblanco@chromium.org authored
Unreviewed; new Chromium/Linux test baselines. canvas-composite.html rebaselined due to new GPU-based path drawing code. canvas-text-alignment and image-object-in-canvas rebaselined due to slight pixel differences near the scrollbar. * platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.checksum: * platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png: * platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum: * platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png: * platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.checksum: * platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78599 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tony@chromium.org authored
Unreviewed, update the version of Chromium in webkit. * DEPS: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78598 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
crogers@google.com authored
Reviewed by Alexey Proskuryakov. Fix Mutex::tryLock() on Windows to work properly with PlatformCondition::timedWait() https://bugs.webkit.org/show_bug.cgi?id=54408 * wtf/ThreadingWin.cpp: (WTF::PlatformCondition::timedWait): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78597 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andreas.kling@nokia.com authored
Reviewed by Darin Adler. Optimize Color::serialized() https://bugs.webkit.org/show_bug.cgi?id=54452 Apply the optimizations from CSSPrimitiveValue::cssText() [CSS_RGBCOLOR] to Color::serialized() - build the serialized color strings manually instead of using String::format(). * platform/graphics/Color.cpp: (WebCore::appendHexNumber): (WebCore::Color::serialized): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78596 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mrobinson@webkit.org authored
Import the last set of GTK+ baselines for SVG tests. * platform/gtk/Skipped: Unskip tests which now have results. Classify failures. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78595 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mrobinson@webkit.org authored
Add the next batch of GTK+ SVG results. * platform/gtk/Skipped: Unskip tests which now have results. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78594 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andreas.kling@nokia.com authored
Unreviewed Qt build fix after r78588. * UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Add WKPageLoaderClient::shouldGoToHistoryItem. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78593 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mario@webkit.org authored
Unreviewed, rolling out r78579. http://trac.webkit.org/changeset/78579 https://bugs.webkit.org/show_bug.cgi?id=54479 Undo wrong rebaseline for Gtk results (Requested by msanchez on #webkit). * platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78592 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Alexey Proskuryakov. XMLHttpRequest::abort() doesn't clear response data https://bugs.webkit.org/show_bug.cgi?id=54118 Properly clear all buffer data on abort, so no memory hangs around unnecessarily. No new tests because there is no observable effect except for less memory used. * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::abort): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78591 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andreas.kling@nokia.com authored
Reviewed by Darin Adler. Rename Color::name() to Color::nameForRenderTreeAsText() https://bugs.webkit.org/show_bug.cgi?id=54464 Color::name() returns the color as either #RRGGBB or #RRGGBBAA. Since the latter is not a valid CSS color, it can't be re-parsed by WebKit, and should only be used in DRT dumps. * editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles): * page/DragController.cpp: (WebCore::DragController::concludeEditDrag): * platform/graphics/Color.cpp: (WebCore::Color::nameForRenderTreeAsText): * platform/graphics/Color.h: * platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties): * platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::externalRepresentation): * rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject): * rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeRenderSVGTextBox): * svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::applyResultsToTarget): * svg/SVGColor.cpp: (WebCore::SVGColor::cssText): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78590 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
enrica@apple.com authored
<rdar://problem/8930897> https://bugs.webkit.org/show_bug.cgi?id=54477 Reviewed by Darin Adler. NSImage setFlipped is a deprecated API. We replace it with drawInRect:fromRect:operation:fraction:respectFlipped:hints. * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setDragImage): Removed call to setFlipped. * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: (WebKit::WebDragClient::startDrag): The image is now drawn with drawInRect:fromRect:operation:fraction:respectFlipped:hints. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/9002047https://bugs.webkit.org/show_bug.cgi?id=54426beidson@apple.com authored
WebFrameLoaderClient::shouldGoToHistoryItem needs implementation Reviewed by Darin Adler. Source/WebKit2: Expose HistoryItem -> ItemID mapping for the message: * WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::WebBackForwardListProxy::idForItem): * WebProcess/WebPage/WebBackForwardListProxy.h: Sync message to the UIProcess for the answer: * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::shouldGoToHistoryItem): Call out to the WebLoaderClient for the answer: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::shouldGoToBackForwardListItem): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: Call out to the client application for the answer: * UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::shouldGoToBackForwardListItem): * UIProcess/WebLoaderClient.h: Add API for the client application to listen for this: * UIProcess/API/C/WKPage.h: Tools: Add dummy implementations to keep our tools building. * MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
