1. 21 May, 2009 7 commits
    • eric@webkit.org's avatar
      2009-05-21 Eric Seidel <eric@webkit.org> · 5797165d
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Rename DragController::dragOperation() to sourceDragOperation() for clarity
              Remove unused setDragOperation()
      
              There are two times DragOperation is used.  The source specifies
              what drag operations it supports (in a mask) and the destination
              picks a subset of those as DragOperations it supports if a drop were
              to occur.  I was confused when I first saw this accessor as to which
              it meant.  It turns out that this is only used when WebKit starts a
              drag, and we keep it around so that we can provide this information
              to other Mac OS X applications when they ask.  I've renamed the method
              for clarity so the next person in this code will be less confused.
      
              No functional changes, thus no tests.
      
              * page/DragController.h:
              (WebCore::DragController::sourceDragOperation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5797165d
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · fe82566a
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=19517
              <rdar://problem/6007112> DOM modification of textArea causes Access Violation (NULL pointer?)
      
              This no longer happens with ToT, just adding a test.
      
              * fast/parser/head-parsing-19517-expected.txt: Added.
              * fast/parser/head-parsing-19517.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe82566a
    • mitz@apple.com's avatar
      Rubber-stamped by Mark Rowe. · 476886f2
      mitz@apple.com authored
              - correct a copyright header accidently reverted in r43964
      
              * WebKitSystemInterface.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      476886f2
    • mitz@apple.com's avatar
      WebCore: · b48ad77e
      mitz@apple.com authored
              Reviewed by Anders Carlsson.
      
              - WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger
                crash painting the selection on registration page of car2go.com
      
              A bug in old versions of Core Graphics causes memory corruption to occur
              when clipping under certain conditions. Make the clipping functions
              fail silently under those conditions.
      
              Test: fast/block/float/selection-gap-clip-out-tiger-crash.html
      
              * WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that,
              on Tiger, bails out if wkCGContextIsSafeToClip() returns false.
              (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip.
              (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect.
              (WebCore::GraphicsContext::fillPath): Changed to call the safe variants
              of CGContextClip, CGContextEOClip and CGContextClipToRect.
              (WebCore::GraphicsContext::strokePath): Ditto.
              (WebCore::GraphicsContext::fillRect): Ditto.
              (WebCore::GraphicsContext::clip): Ditto.
              (WebCore::GraphicsContext::clipOut): Ditto.
              (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto.
              (WebCore::GraphicsContext::clipPath): Ditto.
              (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto.
              (WebCore::GraphicsContext::strokeRect): Ditto.
              * platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
              * platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.
      
      WebKit/mac:
      
              Reviewed by Anders Carlsson.
      
              - WebKit part of <rdar://problem/6901751> REGRESSION (r35515): Tiger
                crash painting the selection on registration page of car2go.com
      
              * WebCoreSupport/WebSystemInterface.m:
              (InitWebCoreSystemInterface): Added CGContextIsSafeToClip.
      
      WebKitLibraries:
      
              Reviewed by Anders Carlsson.
      
              - WebKitSystemInterface part of <rdar://problem/6901751> REGRESSION
                (r35515): Tiger crash painting the selection on registration page of
                car2go.com
      
              * WebKitSystemInterface.h:
              * libWebKitSystemInterfaceTiger.a:
      
      LayoutTests:
      
              Reviewed by Anders Carlsson.
      
              - test for <rdar://problem/6901751> REGRESSION (r35515): Tiger crash
                painting the selection on registration page of car2go.com
      
              * fast/block/float/selection-gap-clip-out-tiger-crash-expected.txt: Added.
              * fast/block/float/selection-gap-clip-out-tiger-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b48ad77e
    • xan@webkit.org's avatar
      2009-05-21 Xan Lopez <xlopez@igalia.com> · 199d078e
      xan@webkit.org authored
              Unreviewed build fix.
      
              https://bugs.webkit.org/show_bug.cgi?id=25910
              WebkitGTK r43960 cannot compile
      
              Do not include local copy of guriescape header, which was
              removed. We now use the copy in glib.
      
              * platform/gtk/FileSystemGtk.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      199d078e
    • cwzwarich@webkit.org's avatar
      2009-05-21 Cameron Zwarich <zwarich@apple.com> · bac38192
      cwzwarich@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Bug 25912: Harden NumberPrototype.cpp by removing use of strcpy()
              <https://bugs.webkit.org/show_bug.cgi?id=25912>
      
              This causes no change on SunSpider.
      
              * runtime/NumberPrototype.cpp:
              (JSC::integerPartNoExp): replace strcpy() with memcpy(), ASSERT that the
              temporary buffer has sufficient space to store the result, and move the
              explicit null-termination closer to the memcpy() for easier visual inspection
              of the code.
              (JSC::fractionalPartToString): replace strcpy() with memcpy(), and ASSERT
              that the temporary buffer has sufficient space to store the result. There
              is no explicit null-termination because this is done by the caller. The
              same is already true for exponentialPartToString().
              (JSC::numberProtoFuncToExponential): replace strcpy() with memcpy(), explicitly
              null-terminate the result, and ASSERT that the temporary buffer has sufficient
              space to store the result.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bac38192
    • eric@webkit.org's avatar
      2009-05-21 Eric Seidel <eric@webkit.org> · 6d1ae00b
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Fix file-input-files-access which was passing for the wrong reasons.
      
              The log was pushing the drop target off screen and the drops were failing!
      
              * editing/pasteboard/file-input-files-access-expected.txt:
              * editing/pasteboard/resources/file-input-files-access.js:
              (testOrderedDraggingWithDirectory):
              (runTest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d1ae00b
  2. 20 May, 2009 33 commits