1. 05 Sep, 2012 40 commits
    • scheib@chromium.org's avatar
      webkitPointerLockElement returns null when pointer lock request is pending. · 575ba7c7
      scheib@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91186
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      Script should wait for a pointerlockchange event before detecting
      if it has acquired lock. However, if a script attempted to poll
      pointerLockElement it could be confused when lock was still pending.
      This change ensures that if lock is not yet acquired then
      pointerLockElement will return null.
      
      Test: pointer-lock/pointerlockelement-null-when-pending.html
      
      * dom/Document.cpp:
      (WebCore::Document::webkitPointerLockElement):
      * page/PointerLockController.cpp:
      (WebCore::PointerLockController::requestPointerLock):
      (WebCore::PointerLockController::elementRemoved):
      (WebCore::PointerLockController::documentDetached):
      (WebCore::PointerLockController::lockPending):
      (WebCore):
      (WebCore::PointerLockController::didAcquirePointerLock):
      (WebCore::PointerLockController::didNotAcquirePointerLock):
      (WebCore::PointerLockController::didLosePointerLock):
      (WebCore::PointerLockController::clearElement):
      * page/PointerLockController.h:
      (PointerLockController):
      
      LayoutTests:
      
      * pointer-lock/locked-element-iframe-removed-from-dom-expected.txt:
      * pointer-lock/locked-element-iframe-removed-from-dom.html:
           Updated to reflect new behavior of null returned when lock is pending.
      * pointer-lock/pointerlockelement-null-when-pending-expected.txt: Added.
      * pointer-lock/pointerlockelement-null-when-pending.html: Added.
           New test specifically for testing null return when lock is pending.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      575ba7c7
    • commit-queue@webkit.org's avatar
      [chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium · a5337aa0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95679
      
      Patch by Sami Kyostila <skyostil@chromium.org> on 2012-09-05
      Reviewed by James Robinson.
      
      Source/Platform:
      
      Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.
      
      * Platform.gypi:
      * chromium/public/WebLayer.h:
      (WebKit):
      (WebLayer):
      * chromium/public/WebLayerScrollClient.h:
      
      Source/WebCore:
      
      Implement scrollable sublayers in ScrollingCoordinatorChromium and introduce a
      WebLayerScrollClient which is notified of scroll events on its associated
      scroll layer. GraphicsLayerChromium uses it to apply scroll events targeted to
      its platform layer to a ScrollableArea, i.e., the RenderLayer corresponding to
      the scrollable element.
      
      Tests: GraphicsLayerChromiumTest.applyScrollToScrollableArea
             WebLayerTest.ScrollClient
      
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      (WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
      (WebCore::GraphicsLayerChromium::didScroll):
      (WebCore):
      * platform/graphics/chromium/GraphicsLayerChromium.h:
      (WebCore):
      (WebCore::GraphicsLayerChromium::setScrollableArea):
      (WebCore::GraphicsLayerChromium::scrollableArea):
      (GraphicsLayerChromium):
      * platform/graphics/chromium/LayerChromium.cpp:
      * platform/graphics/chromium/LayerChromium.h:
      (WebKit):
      (WebCore):
      (WebCore::LayerChromium::setLayerScrollClient):
      (LayerChromium):
      
      Source/WebKit/chromium:
      
      Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.
      
      * src/WebLayerImpl.cpp:
      (WebKit::WebLayerImpl::setMaxScrollPosition):
      (WebKit):
      (WebKit::WebLayerImpl::setScrollClient):
      (WebKit::WebLayerImpl::scrollBy):
      * src/WebLayerImpl.h:
      (WebLayerImpl):
      * tests/CCLayerTreeHostTest.cpp:
      * tests/GraphicsLayerChromiumTest.cpp:
      (MockScrollableArea):
      (WebKit):
      (WebKit::TEST_F):
      * tests/WebLayerTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5337aa0
    • commit-queue@webkit.org's avatar
      [EFL] Remove '+=' usage in String · bb322ff5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95808
      
      Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-05
      Reviewed by Benjamin Poulain.
      
      Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_source_get): Removed unnecessary strlen usage.
      
      Tools:
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (descriptionSuitableForTestResult):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb322ff5
    • vsevik@chromium.org's avatar
      Web Inspector: CodeGeneratorInspector.py: support asynchronous command implementation · bcd60459
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95649
      
      Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-09-05
      Reviewed by Yury Semikhatsky.
      
      Generator is extended to generate callback object for each asynchronous command.
      
      * inspector/CodeGeneratorInspector.py:
      (Writer.append_multiline):
      (Writer):
      (Writer.get_indent):
      (TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.ResolveData):
      (InspectorBackendDispatcherImpl):
      (CallbackBase):
      (Generator.process_event):
      (Generator):
      (Generator.EventMethodStructTemplate):
      (Generator.EventMethodStructTemplate.append_prolog):
      (Generator.EventMethodStructTemplate.append_epilog):
      (Generator.process_command):
      (Generator.CallbackMethodStructTemplate):
      (Generator.CallbackMethodStructTemplate.append_prolog):
      (Generator.CallbackMethodStructTemplate.append_epilog):
      (Generator.generate_send_method):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcd60459
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource() · 6ac95b82
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95842
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Tools:
      
      Provide proper implementation for TestRunner::pathToLocalResource()
      in EFL WKTR, identical to the one for DumpRenderTree.
      
      Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
      /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
      are found my WebKitTestRunner.
      
      * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
      (WTR::TestRunner::pathToLocalResource):
      
      LayoutTests:
      
      Unskip fast/dom/frame-loading-via-document-write.html that
      was failing due to incomplete implementation for
      TestRunner::pathToLocalResource() in EFL WKTR.
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ac95b82
    • commit-queue@webkit.org's avatar
      [BlackBerry] Do not release shared backingstore memory prematurely · c453bb35
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95841
      PR #202517
      
      Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-05
      Reviewed by George Staikos.
      
      The BackingStore memory is shared by all web pages. We should check if
      the current backingStore is active before create/release this shared memory.
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
      (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c453bb35
    • commit-queue@webkit.org's avatar
      [chromium] Unify size of popup menu for touch and non-touch. · 8ebfaef9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95606
      
      Patch by Kevin Ellis <kevers@chromium.org> on 2012-09-05
      Reviewed by Adam Barth.
      
      Use minimum height for popup menus entries regardless of whether the
      popup menu is displayed on a touch screen.  Replaces use of touch
      padding.  Height meets minimum size requirement for a low error rate
      while still looking aesthetic for non-touch.
      
      Covered by existing tests.
      
      * platform/chromium/PopupListBox.cpp:
      (WebCore::PopupListBox::getRowHeight):
      * platform/chromium/PopupMenuChromium.cpp:
      (WebCore):
      * platform/chromium/PopupMenuChromium.h:
      (PopupMenuChromium):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ebfaef9
    • mihnea@adobe.com's avatar
      [CSS Regions] Auto width is not working for Regions · 2ccb17c0
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=74135
      
      Reviewed by Julien Chaffraix.
      
      Source/WebCore:
      
      It was not possible to flow content into a region having { width: auto; } since in such case, the region width was computed to 0.
      Now, a region having auto width, will have its width computed following the rules for calculation of widths and margins
      (http://www.w3.org/TR/CSS2/visudet.html#Computing_widths_and_margins).
      For those cases in which resolving the width requires measuring of content's min/max-content values, we use the associated named flow min/max-content
      values (the same for all regions with width auto in a region chain).
      When a region has width:auto, the computation of width should be done using normal block/box sizing code, instead of replaced element code.
      Contains code contributed by Alexandru Chiculita(achicu@adobe.com).
      
      Tests: fast/regions/autowidth-abspos-regionchain.html
             fast/regions/autowidth-abspos.html
             fast/regions/autowidth-float.html
             fast/regions/autowidth-inlineblock.html
             fast/regions/autowidth-nonreplaced-abspos.html
             fast/regions/autowidth-nonreplacedblock-normalflow.html
             fast/regions/autowidth-normalflow-maxwidth.html
             fast/regions/autowidth-normalflow-minmaxwidth.html
             fast/regions/autowidth-normalflow-minwidth.html
             fast/regions/autowidth-normalflow-vertrl.html
             fast/regions/autowidth-normalflow.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computePositionedLogicalWidth): For positioned auto-width regions, skip the code path for replaced elements.
      * rendering/RenderRegion.cpp:
      (WebCore): Override min/maxPreferredLogicalWidth as they are used in the process of computing width for regions with auto width.
      As this moment, a region is still a RenderReplaced element, so this code needs to be revisited when the region will become a RenderBlock.
      Also, for min/max-width, we support only <length> values. We will extend support for other values in a following patch.
      (WebCore::RenderRegion::minPreferredLogicalWidth):
      (WebCore::RenderRegion::maxPreferredLogicalWidth):
      * rendering/RenderRegion.h:
      (RenderRegion):
      Override isInlineBlockOrInlineTable() and shouldComputeSizeAsReplaced() to ensure that computation for width auto follows the normal
      block/box sizing code.
      
      LayoutTests:
      
      It was not possible to flow content into a region having { width: auto; } since in such case, the region width was computed to 0.
      Now, a region having auto width, will have its width computed following the rules for calculation of widths and margins
      (http://www.w3.org/TR/CSS2/visudet.html#Computing_widths_and_margins).
      For those cases in which resolving the width requires measuring of content's min/max-content values, we use the associated named flow min/max-content
      values (the same for all regions with width auto in a region chain).
      
      Besides adding new tests, i have modified existing tests that were having regions with width:auto as they were failing after this patch.
      
      * fast/regions/autowidth-abspos-expected.html: Added.
      * fast/regions/autowidth-abspos-regionchain-expected.html: Added.
      * fast/regions/autowidth-abspos-regionchain.html: Added.
      * fast/regions/autowidth-abspos.html: Added.
      * fast/regions/autowidth-float-expected.html: Added.
      * fast/regions/autowidth-float.html: Added.
      * fast/regions/autowidth-inlineblock-expected.html: Added.
      * fast/regions/autowidth-inlineblock.html: Added.
      * fast/regions/autowidth-nonreplaced-abspos-expected.html: Added.
      * fast/regions/autowidth-nonreplaced-abspos.html: Added.
      * fast/regions/autowidth-nonreplacedblock-normalflow-expected.html: Added.
      * fast/regions/autowidth-nonreplacedblock-normalflow.html: Added.
      * fast/regions/autowidth-normalflow-expected.html: Added.
      * fast/regions/autowidth-normalflow-maxwidth-expected.html: Added.
      * fast/regions/autowidth-normalflow-maxwidth.html: Added.
      * fast/regions/autowidth-normalflow-minmaxwidth-expected.html: Added.
      * fast/regions/autowidth-normalflow-minmaxwidth.html: Added.
      * fast/regions/autowidth-normalflow-minwidth-expected.html: Added.
      * fast/regions/autowidth-normalflow-minwidth.html: Added.
      * fast/regions/autowidth-normalflow-vertrl-expected.html: Added.
      * fast/regions/autowidth-normalflow-vertrl.html: Added.
      * fast/regions/autowidth-normalflow.html: Added.
      * fast/regions/bottom-overflow-out-of-first-region.html:
      * fast/regions/flows-dependency-dynamic-remove.html:
      * fast/regions/flows-dependency-same-flow.html:
      * fast/regions/render-region-renderer-expected.html:
      * fast/regions/top-overflow-out-of-second-region.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ccb17c0
    • beidson@apple.com's avatar
      Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot · 65e67acb
      beidson@apple.com authored
      <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
      
      Source/WebKit2:
      
      Patch partially by Andras Becsi  <andras.becsi@nokia.com>
      
      Reviewed by Andy Estes.
      
      If a plug-in fails to initialize then the m_plugin pointer is cleared out.
      When accessing the script object it is appropriate to unconditionally null check m_plugin.
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::scriptObject): Null check m_plugin before trying to use it.
      
      Tools:
      
      Reviewed by Andy Estes.
      
      Add a plug-in that always fails to initialize:
      * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
      (NPPNewFails):
      (NPPNewFails::NPPNewFails):
      (NPPNewFails::NPP_New):
      
      Add it to all the project files:
      * DumpRenderTree/DumpRenderTree.gypi:
      * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
      * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
      * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
      
      LayoutTests:
      
      Reviewed by Andy Estes.
      
      * plugins/npp-new-fails-expected.txt: Added.
      * plugins/npp-new-fails.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65e67acb
    • commit-queue@webkit.org's avatar
      [BlackBerry] Implement number of matches and current active match index for find-on-page · 539854b0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95801
      
      Patch by Andy Chen <andchen@rim.com> on 2012-09-05
      Reviewed by Antonio Gomes.
      
      - Calculate current match index for find-on-page
      - Notify client when number of matches and current match index update.
      PR 162090 162091.
      Internally reviewed by Mike Fenton and Joe Mason
      
      * Api/WebPageClient.h:
      * WebKitSupport/InPageSearchManager.cpp:
      (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
      (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
      (InPageSearchManager::DeferredScopeStringMatches):
      (BlackBerry::WebKit::InPageSearchManager::findNextString):
      (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
      (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
      (BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
      (BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
      * WebKitSupport/InPageSearchManager.h:
      (InPageSearchManager):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      539854b0
    • loislo@chromium.org's avatar
      Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation. · 53b3ffda
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95850
      
      Reviewed by Yury Semikhatsky.
      
      I'd like to extract MemoryObjectTypes into separate classes.
      After that we will be able to move core NMI instrumentation code to WTF.
      
      Source/WebCore:
      
      * bindings/js/ScriptWrappable.h:
      (WebCore::ScriptWrappable::reportMemoryUsage):
      * bindings/v8/DOMDataStore.cpp:
      (WebCore::DOMDataStore::reportMemoryUsage):
      * bindings/v8/IntrusiveDOMWrapperMap.h:
      (WebCore::ChunkedTable::reportMemoryUsage):
      * bindings/v8/ScriptWrappable.h:
      (WebCore::ScriptWrappable::reportMemoryUsage):
      * bindings/v8/V8Binding.cpp:
      (WebCore::StringCache::reportMemoryUsage):
      * bindings/v8/V8DOMMap.h:
      * bindings/v8/V8PerIsolateData.cpp:
      (WebCore::V8PerIsolateData::reportMemoryUsage):
      * css/CSSAspectRatioValue.cpp:
      (WebCore::CSSAspectRatioValue::reportDescendantMemoryUsage):
      * css/CSSBorderImageSliceValue.cpp:
      (WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
      * css/CSSCalculationValue.cpp:
      (WebCore::CSSCalcValue::reportDescendantMemoryUsage):
      * css/CSSCanvasValue.cpp:
      (WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
      * css/CSSCharsetRule.cpp:
      (WebCore::CSSCharsetRule::reportDescendantMemoryUsage):
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):
      * css/CSSCrossfadeValue.cpp:
      (WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
      * css/CSSCursorImageValue.cpp:
      (WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
      * css/CSSFontFaceRule.cpp:
      (WebCore::CSSFontFaceRule::reportDescendantMemoryUsage):
      * css/CSSFontFaceSrcValue.cpp:
      (WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
      * css/CSSFunctionValue.cpp:
      (WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
      * css/CSSGradientValue.cpp:
      (WebCore::CSSGradientColorStop::reportMemoryUsage):
      (WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
      (WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
      (WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
      * css/CSSImageSetValue.cpp:
      (WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
      (WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
      * css/CSSImageValue.cpp:
      (WebCore::CSSImageValue::reportDescendantMemoryUsage):
      * css/CSSImportRule.cpp:
      (WebCore::CSSImportRule::reportDescendantMemoryUsage):
      * css/CSSInheritedValue.cpp:
      (WebCore::CSSInheritedValue::reportDescendantMemoryUsage):
      * css/CSSInitialValue.cpp:
      (WebCore::CSSInitialValue::reportDescendantMemoryUsage):
      * css/CSSLineBoxContainValue.cpp:
      (WebCore::CSSLineBoxContainValue::reportDescendantMemoryUsage):
      * css/CSSMediaRule.cpp:
      (WebCore::CSSMediaRule::reportDescendantMemoryUsage):
      * css/CSSPageRule.cpp:
      (WebCore::CSSPageRule::reportDescendantMemoryUsage):
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::reportMemoryUsage):
      * css/CSSReflectValue.cpp:
      (WebCore::CSSReflectValue::reportDescendantMemoryUsage):
      * css/CSSRule.cpp:
      (WebCore::CSSRule::reportBaseClassMemoryUsage):
      * css/CSSRuleList.cpp:
      (WebCore::StaticCSSRuleList::reportMemoryUsage):
      * css/CSSRuleList.h:
      * css/CSSSelectorList.cpp:
      (WebCore::CSSSelectorList::reportMemoryUsage):
      * css/CSSStyleRule.cpp:
      (WebCore::CSSStyleRule::reportDescendantMemoryUsage):
      * css/CSSStyleSheet.cpp:
      (WebCore::CSSStyleSheet::reportMemoryUsage):
      * css/CSSTimingFunctionValue.cpp:
      (WebCore::CSSLinearTimingFunctionValue::reportDescendantMemoryUsage):
      (WebCore::CSSCubicBezierTimingFunctionValue::reportDescendantMemoryUsage):
      (WebCore::CSSStepsTimingFunctionValue::reportDescendantMemoryUsage):
      * css/CSSUnicodeRangeValue.cpp:
      (WebCore::CSSUnicodeRangeValue::reportDescendantMemoryUsage):
      * css/CSSUnknownRule.h:
      (WebCore::CSSUnknownRule::reportDescendantMemoryUsage):
      * css/CSSValue.cpp:
      (WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
      * css/CSSValueList.cpp:
      (WebCore::CSSValueList::reportDescendantMemoryUsage):
      * css/CSSVariableValue.h:
      (WebCore::CSSVariableValue::reportDescendantMemoryUsage):
      * css/FontFeatureValue.cpp:
      (WebCore::FontFeatureValue::reportDescendantMemoryUsage):
      * css/FontValue.cpp:
      (WebCore::FontValue::reportDescendantMemoryUsage):
      * css/MediaList.cpp:
      (WebCore::MediaQuerySet::reportMemoryUsage):
      (WebCore::MediaList::reportMemoryUsage):
      * css/MediaQuery.cpp:
      (WebCore::MediaQuery::reportMemoryUsage):
      * css/MediaQueryExp.cpp:
      (WebCore::MediaQueryExp::reportMemoryUsage):
      * css/PropertySetCSSStyleDeclaration.cpp:
      (WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
      (WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
      (WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
      * css/ShadowValue.cpp:
      (WebCore::ShadowValue::reportDescendantMemoryUsage):
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::reportMemoryUsage):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::Features::reportMemoryUsage):
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * css/StyleRule.cpp:
      (WebCore::StyleRuleBase::reportMemoryUsage):
      (WebCore::StyleRule::reportDescendantMemoryUsage):
      (WebCore::StyleRulePage::reportDescendantMemoryUsage):
      (WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
      (WebCore::StyleRuleBlock::reportDescendantMemoryUsage):
      (WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
      (WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
      * css/StyleRuleImport.cpp:
      (WebCore::StyleRuleImport::reportDescendantMemoryUsage):
      * css/StyleSheetContents.cpp:
      (WebCore::StyleSheetContents::reportMemoryUsage):
      * css/WebKitCSSFilterValue.cpp:
      (WebCore::WebKitCSSFilterValue::reportDescendantMemoryUsage):
      * css/WebKitCSSKeyframeRule.cpp:
      (WebCore::StyleKeyframe::reportMemoryUsage):
      (WebCore::WebKitCSSKeyframeRule::reportDescendantMemoryUsage):
      * css/WebKitCSSKeyframesRule.cpp:
      (WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
      (WebCore::WebKitCSSKeyframesRule::reportDescendantMemoryUsage):
      * css/WebKitCSSMixFunctionValue.cpp:
      (WebCore::WebKitCSSMixFunctionValue::reportDescendantMemoryUsage):
      * css/WebKitCSSRegionRule.cpp:
      (WebCore::WebKitCSSRegionRule::reportDescendantMemoryUsage):
      * css/WebKitCSSSVGDocumentValue.cpp:
      (WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
      * css/WebKitCSSShaderValue.cpp:
      (WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
      * css/WebKitCSSTransformValue.cpp:
      (WebCore::WebKitCSSTransformValue::reportDescendantMemoryUsage):
      * dom/Attribute.h:
      (WebCore::Attribute::reportMemoryUsage):
      * dom/CharacterData.cpp:
      (WebCore::CharacterData::reportMemoryUsage):
      * dom/ContainerNode.h:
      (WebCore::ContainerNode::reportMemoryUsage):
      * dom/Document.cpp:
      (WebCore::Document::reportMemoryUsage):
      * dom/DocumentEventQueue.cpp:
      (WebCore::DocumentEventQueue::reportMemoryUsage):
      * dom/Element.h:
      (WebCore::Element::reportMemoryUsage):
      * dom/ElementAttributeData.cpp:
      (WebCore::ElementAttributeData::reportMemoryUsage):
      * dom/Event.cpp:
      (WebCore::Event::reportMemoryUsage):
      * dom/MemoryInstrumentation.cpp:
      (WebCore):
      * dom/MemoryInstrumentation.h:
      (WebCore):
      (GenericMemoryTypes):
      (WebCore::MemoryInstrumentation::addRootObject):
      (WebCore::MemoryObjectInfo::reportObjectInfo):
      (WebCoreMemoryTypes):
      * dom/Node.cpp:
      (WebCore::Node::reportMemoryUsage):
      * dom/QualifiedName.h:
      (WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
      (WebCore::QualifiedName::reportMemoryUsage):
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::reportMemoryUsage):
      * inspector/InspectorMemoryAgent.cpp:
      (WebCore):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::reportMemoryUsage):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::reportMemoryUsage):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::reportMemoryUsage):
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::reportMemoryUsage):
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::reportMemoryUsage):
      * loader/SubstituteData.cpp:
      (WebCore::SubstituteData::reportMemoryUsage):
      * loader/cache/CachedCSSStyleSheet.cpp:
      (WebCore::CachedCSSStyleSheet::reportMemoryUsage):
      * loader/cache/CachedFont.cpp:
      (WebCore::CachedFont::reportMemoryUsage):
      * loader/cache/CachedImage.cpp:
      (WebCore::CachedImage::reportMemoryUsage):
      * loader/cache/CachedRawResource.cpp:
      (WebCore::CachedRawResource::reportMemoryUsage):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::reportMemoryUsage):
      * loader/cache/CachedResourceHandle.cpp:
      (WebCore::CachedResourceHandleBase::reportMemoryUsage):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::reportMemoryUsage):
      * loader/cache/CachedSVGDocument.cpp:
      (WebCore::CachedSVGDocument::reportMemoryUsage):
      * loader/cache/CachedScript.cpp:
      (WebCore::CachedScript::reportMemoryUsage):
      * loader/cache/CachedShader.cpp:
      (WebCore::CachedShader::reportMemoryUsage):
      * loader/cache/CachedXSLStyleSheet.cpp:
      (WebCore::CachedXSLStyleSheet::reportMemoryUsage):
      * loader/cache/MemoryCache.cpp:
      (WebCore::MemoryCache::reportMemoryUsage):
      * page/Frame.cpp:
      (WebCore::Frame::reportMemoryUsage):
      * platform/SharedBuffer.cpp:
      (WebCore::SharedBuffer::reportMemoryUsage):
      * platform/TreeShared.h:
      (WebCore::TreeShared::reportMemoryUsage):
      * platform/graphics/BitmapImage.cpp:
      (WebCore::BitmapImage::reportMemoryUsage):
      * platform/graphics/CrossfadeGeneratedImage.cpp:
      (WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
      * platform/graphics/GeneratedImage.cpp:
      (WebCore::GeneratedImage::reportMemoryUsage):
      * platform/graphics/GeneratorGeneratedImage.cpp:
      (WebCore::GeneratorGeneratedImage::reportMemoryUsage):
      * platform/graphics/Image.cpp:
      (WebCore::Image::reportMemoryUsage):
      * platform/network/FormData.cpp:
      (WebCore::FormData::reportMemoryUsage):
      * platform/network/ResourceRequestBase.cpp:
      (WebCore::ResourceRequestBase::reportMemoryUsage):
      * platform/network/ResourceResponseBase.cpp:
      (WebCore::ResourceResponseBase::reportMemoryUsage):
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::reportMemoryUsage):
      * rendering/style/StyleRareInheritedData.cpp:
      (WebCore::StyleRareInheritedData::reportMemoryUsage):
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::reportMemoryUsage):
      * svg/SVGColor.cpp:
      (WebCore::SVGColor::reportDescendantMemoryUsage):
      * svg/SVGPaint.cpp:
      (WebCore::SVGPaint::reportDescendantMemoryUsage):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::reportMemoryUsage):
      
      Source/WebKit/chromium:
      
      * tests/MemoryInstrumentationTest.cpp:
      (WebCore::Instrumented::reportMemoryUsage):
      (WebCore::InstrumentedRefPtr::reportMemoryUsage):
      (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
      (WebCore::InstrumentedOther::reportMemoryUsage):
      (WebCore::InstrumentedDOM::reportMemoryUsage):
      (WebCore::TEST):
      (WebCore::NonVirtualInstrumented::reportMemoryUsage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53b3ffda
    • loislo@chromium.org's avatar
      Web Inspector: NMI: extract overloaded instrumentation members for WebCore... · db0e2582
      loislo@chromium.org authored
      Web Inspector: NMI: extract overloaded instrumentation members for WebCore classes from core NMI code.
      https://bugs.webkit.org/show_bug.cgi?id=95834
      
      Reviewed by Yury Semikhatsky.
      
      I'd like to remove custom instrumentation methods from MemoryInstrumentation class
      before upstreaming it to WTF. I've done it with help of MemoryInstrumentationTraits template helper.
      
      Unfortunately it is not possible to use template class because mac-ews bot reports warning: redundant redeclaration of 'something' in same scope.
      I've found that it is an old problem in gcc that is forced by -Wredundant-decls flag on the bot. See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15867
      
      * dom/MemoryInstrumentation.cpp:
      (WebCore::::addInstrumentedObject):
      (WebCore):
      * dom/MemoryInstrumentation.h:
      (WebCore):
      (MemoryInstrumentationTraits):
      (MemoryInstrumentation):
      (WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer):
      (InstrumentedPointer):
      (WebCore::MemoryInstrumentation::addObject):
      (WebCore::MemoryInstrumentation::addInstrumentedObject):
      (WebCore::MemoryInstrumentation::addRawBuffer):
      (WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedObject):
      (WebCore::MemoryInstrumentation::OwningTraits::addObject):
      (WebCore::::addInstrumentedObject):
      (WebCore::::addObject):
      (WebCore::MemoryObjectInfo::MemoryObjectInfo):
      (WebCore::MemoryObjectInfo::objectType):
      (WebCore::MemoryObjectInfo::reportObjectInfo):
      (MemoryObjectInfo):
      (WebCore::MemoryClassInfo::MemoryClassInfo):
      (MemoryClassInfo):
      (WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
      (WebCore::MemoryInstrumentation::addObjectImpl):
      (WebCore::MemoryInstrumentation::addHashMap):
      (WebCore::MemoryInstrumentation::addHashSet):
      (WebCore::MemoryInstrumentation::addInstrumentedCollection):
      (WebCore::MemoryInstrumentation::addInstrumentedMapEntries):
      (WebCore::MemoryInstrumentation::addInstrumentedMapValues):
      (WebCore::MemoryInstrumentation::addListHashSet):
      (WebCore::MemoryInstrumentation::addVector):
      * inspector/MemoryInstrumentationImpl.cpp:
      (WebCore::MemoryInstrumentationImpl::countObjectSize):
      * inspector/MemoryInstrumentationImpl.h:
      (WebCore::MemoryInstrumentationImpl::totalSize):
      (MemoryInstrumentationImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db0e2582
    • peter@chromium.org's avatar
      Unreviewed, rolling out r127590. · 2aee45ff
      peter@chromium.org authored
      http://trac.webkit.org/changeset/127590
      
      Broke the Chromium bots because of a compile error in the compositor.
      
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2aee45ff
    • peter@chromium.org's avatar
      Unreviewed. Rolled DEPS. · 93947a04
      peter@chromium.org authored
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93947a04
    • vestbo@webkit.org's avatar
      [Qt] Build fix on OS X · d51cafc6
      vestbo@webkit.org authored
      Copy/paste-error resulted in us compiling InspectorPageOverlay.h
      
      Reviewed by Ossy.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d51cafc6
    • dominik.rottsches@intel.com's avatar
      [EFL] Unreviewed gardening. · 6cc7b81c
      dominik.rottsches@intel.com authored
      Adding a platform specififc baseline after r127534.
      
      * platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cc7b81c
    • vestbo@webkit.org's avatar
      [Qt] Fix makefile race condition between derived sources and target · 6bafd2da
      vestbo@webkit.org authored
      r121966 removed too much of the old qmake logic, including the rule
      that ensured that qmake_all would not trigger dual runs of qmake --
      one of the derived sources -qmake-all rule, and one for making the
      derived sources.
      
      We now follow a similar pattern as before, by introducing a custom
      target that explicitly depends on the derived sources' qmake-all before
      doing a manual run of make. That ensures a single qmake run for the derived
      sources.
      
      https://bugs.webkit.org/show_bug.cgi?id=93847
      
      Reviewed by Csaba Osztrogonác.
      
      * qmake/mkspecs/features/functions.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bafd2da
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Provide implementation for WebFrameNetworkingContext · e2aa22e4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95826
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Remove EFL-specific and empty implementation for WebFrameNetworkingContext
      and use the existing soup implementation instead.
      
      * PlatformEfl.cmake:
      * WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Removed.
      
      LayoutTests:
      
      Unskip several cookie-related test cases for WK2 EFL
      now that WebFrameNetworkingContext is implemented.
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2aa22e4
    • dominik.rottsches@intel.com's avatar
      Unreviewed, rolling out r127573. · d8d9adfe
      dominik.rottsches@intel.com authored
      http://trac.webkit.org/changeset/127573
      https://bugs.webkit.org/show_bug.cgi?id=95844
      
      Breaks EFL Debug bot tests. (Requested by drott on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-05
      
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::themePartCacheEntryReset):
      (WebCore::RenderThemeEfl::cacheThemePartNew):
      (WebCore::RenderThemeEfl::paintThemePart):
      (WebCore::RenderThemeEfl::setThemePath):
      (WebCore::RenderThemeEfl::createCanvas):
      (WebCore::RenderThemeEfl::createEdje):
      (WebCore::RenderThemeEfl::applyPartDescriptions):
      (WebCore::RenderThemeEfl::themeChanged):
      (WebCore):
      * platform/efl/RenderThemeEfl.h:
      (RenderThemeEfl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8d9adfe
    • morrita@google.com's avatar
      ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception. · 3fb96f93
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=91704
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      This change implement ShadowRoot::cloneNode() which throws an exception.
      This also adds an overloaded version cloneNode() to ShadowRoot.idl
      which is enabled only for JavaScript instead of changing the
      signature of Node::cloneNode().
      
      Note that changing the existing signature can break GObject bindings
      compatibility.
      
      Test: fast/dom/shadow/shadowroot-clonenode.html
      
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::cloneNode):
      (WebCore):
      * dom/ShadowRoot.h:
      (ShadowRoot):
      * dom/ShadowRoot.idl:
      
      LayoutTests:
      
      * fast/dom/shadow/shadowroot-clonenode-expected.txt: Added.
      * fast/dom/shadow/shadowroot-clonenode.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fb96f93
    • hausmann@webkit.org's avatar
      e0e01c89
    • commit-queue@webkit.org's avatar
      WKTR doesn't implement dumpWillCacheResponse() · dd26b55d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94607
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Tools:
      
      Define shouldCacheResponse() callback in resource
      load client and provide implementation for
      dumpWillCacheResponse() in WebKitTestRunner.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::InjectedBundlePage):
      (WTR::InjectedBundlePage::shouldCacheResponse):
      (WTR):
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
      (InjectedBundlePage):
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::TestRunner):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (WTR::TestRunner::dumpWillCacheResponse):
      (WTR::TestRunner::shouldDumpWillCacheResponse):
      (TestRunner):
      
      LayoutTests:
      
      Unskip http/tests/misc/willCacheResponse-delegate-callback.html
      now that WebKitTestRunner implements dumpWillCacheResponse().
      
      * platform/efl-wk2/TestExpectations:
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd26b55d
    • kaustubh@motorola.com's avatar
      [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals · 478c5093
      kaustubh@motorola.com authored
      https://bugs.webkit.org/show_bug.cgi?id=92735
      
      Reviewed by Hajime Morita.
      
      .: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      Added symbols for GTK builds for corresponding APIs.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      
      Covered by existing test cases.
      
      * testing/Internals.cpp:
      (WebCore::Internals::numberOfPages):
      (WebCore):
      (WebCore::Internals::pageProperty):
      (WebCore::Internals::pageSizeAndMarginsInPixels):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/efl: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      
      Source/WebKit/gtk: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      (DumpRenderTreeSupportGtk):
      
      Source/WebKit/qt: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      Source/WebKit/win: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      Kept the function defination and declaration to keep binary compatibility for IWebFramePrivate.idl
      
      * WebFrame.cpp:
      (WebFrame::numberOfPages):
      
      Source/WebKit2: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      Add symbols for Mac Win builds for corresponding newly added APIs.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      Tools: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      
      * DumpRenderTree/TestRunner.cpp:
      (TestRunner::staticFunctions):
      * DumpRenderTree/TestRunner.h:
      (TestRunner):
      * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
      (TestRunner::addUserStyleSheet):
      * DumpRenderTree/chromium/DRTTestRunner.cpp:
      (DRTTestRunner::DRTTestRunner):
      (DRTTestRunner::hasCustomPageSizeStyle):
      * DumpRenderTree/chromium/DRTTestRunner.h:
      (DRTTestRunner):
      * DumpRenderTree/efl/TestRunnerEfl.cpp:
      * DumpRenderTree/gtk/TestRunnerGtk.cpp:
      * DumpRenderTree/mac/TestRunnerMac.mm:
      * DumpRenderTree/qt/TestRunnerQt.cpp:
      (TestRunner::evaluateScriptInIsolatedWorld):
      * DumpRenderTree/qt/TestRunnerQt.h:
      (TestRunner):
      * DumpRenderTree/win/TestRunnerWin.cpp:
      * DumpRenderTree/wx/TestRunnerWx.cpp:
      (TestRunner::abortModal):
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      LayoutTests: 
      
      Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
      Fixed test cases to use internals API instead of testRunner.
      
      * printing/numberOfPages-expected.txt:
      * printing/page-count-layout-overflow.html:
      * printing/page-count-relayout-shrink.html:
      * printing/page-count-with-one-word.html:
      * printing/page-format-data-display-none.html:
      * printing/page-format-data-expected.txt:
      * printing/page-format-data.html:
      * printing/page-rule-selection-expected.txt:
      * printing/page-rule-selection.html:
      * printing/resources/paged-media-test-utils.js:
      (numberOfPagesShouldBe):
      * printing/script-tests/numberOfPages.js:
      * printing/zoomed-document.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      478c5093
    • hausmann@webkit.org's avatar
      [Qt] Automate the use of AllInOne files in the Qt build · 193d2872
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95837
      
      Reviewed by Tor Arne Vestbø.
      
      Source/WebCore:
      
      Replace the manual use of SVGAllInOne.cpp with automated use through
      the ALL_IN_ONE_SOURCES variable. This adds a few more all-in-one sources
      to the build and leaves out some that do not compile yet due to various
      platform-dependant pre-processor macro issues.
      
      * Target.pri:
      
      Tools:
      
      New feature file that implements the all-in-one file automation by
      adding the requested all-in-one files to SOURCES and removing the files
      it includes from SOURCES.
      
      * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      193d2872
    • dominik.rottsches@intel.com's avatar
      [EFL] Unreviewed gardening after r127513 · ddb89e65
      dominik.rottsches@intel.com authored
      Marking plugin third-party storage tests as failing on EFL.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddb89e65
    • commit-queue@webkit.org's avatar
      Fix the uses of String::operator+=() for Mac · 17fbda0a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95818
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-05
      Reviewed by Dan Bernstein.
      
      Source/JavaScriptCore:
      
      * jsc.cpp:
      (functionJSCStack): Use StringBuilder to create the stack dump, it is faster
      and avoid String::operator+=().
      
      * parser/Parser.h:
      (JSC::Parser::updateErrorMessageSpecialCase):
      (JSC::Parser::updateErrorMessage):
      (JSC::Parser::updateErrorWithNameAndMessage):
      Use the String operators (and makeString) to concatenate the strings.
      
      Source/WebCore:
      
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      (WebCore::JSCSSStyleDeclaration::putDelegate):
      This is a legitimate use of String::append(), it is the only
      concatenation in this function.
      
      * loader/appcache/ManifestParser.cpp:
      (WebCore::parseManifest): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17fbda0a
    • kenneth@webkit.org's avatar
      [EFL] Fuzzy load the Edje theme for HTML forms · b05165b3
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95832
      
      Reviewed by Gyuyoung Kim.
      
      Change the theme so that it is first loaded when actually used.
      This also fixed the case that it was impossible to change theme
      a second time.
      
      Tested by current tests. API unit test coming in separate patch.
      
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::themePartCacheEntryReset):
      (WebCore::RenderThemeEfl::cacheThemePartNew):
      (WebCore::RenderThemeEfl::paintThemePart):
      (WebCore::RenderThemeEfl::setThemePath):
      (WebCore::RenderThemeEfl::edje):
      (WebCore::RenderThemeEfl::applyPartDescriptions):
      * platform/efl/RenderThemeEfl.h:
      (RenderThemeEfl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b05165b3
    • commit-queue@webkit.org's avatar
      [Blackberry] Add document url and securityOrigin to platform request. · 67491e63
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95822
      
      Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-09-05
      Reviewed by George Staikos.
      Internally Reviewed by Joe Mason.
      
      It is a webworks requirement.
      
      * platform/network/blackberry/NetworkManager.cpp:
      (WebCore::NetworkManager::startJob):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67491e63
    • loislo@chromium.org's avatar
      Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers. · f0946f26
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95739
      
      Reviewed by Yury Semikhatsky.
      
      When we go deeper into different parts of browser like skia, chromium itself etc.
      we can't use a single enum for all reported object types.
      The current idea is to use plain simple strings as ObjectType identifiers.
      In the future patches we will extract these identifiers into separate class or namespace
      and and split it between components.
      
      Source/WebCore:
      
      * dom/MemoryInstrumentation.cpp:
      (WebCore):
      * dom/MemoryInstrumentation.h:
      (MemoryInstrumentation):
      * inspector/InspectorMemoryAgent.cpp:
      (WebCore::addMemoryBlockFor):
      (WebCore):
      * inspector/MemoryInstrumentationImpl.cpp:
      (WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
      (WebCore::MemoryInstrumentationImpl::countObjectSize):
      * inspector/MemoryInstrumentationImpl.h:
      (WebCore::MemoryInstrumentationImpl::totalSize):
      (WebCore::MemoryInstrumentationImpl::reportedSizeForAllTypes):
      (MemoryInstrumentationImpl):
      
      Source/WebKit/chromium:
      
      * tests/MemoryInstrumentationTest.cpp:
      (WebCore::TEST):
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0946f26
    • paroga@webkit.org's avatar
      Build fix for WinCE after r127525. · 92f2a29a
      paroga@webkit.org authored
      * platform/graphics/wince/FontCustomPlatformData.h:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92f2a29a
    • kkristof@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · bb31bd6a
      kkristof@inf.u-szeged.hu authored
      https://bugs.webkit.org/show_bug.cgi?id=95827
      
      Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-05
      
      * platform/qt/Skipped: skip failing test after r127534.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb31bd6a
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 554c000e
      zandobersek@gmail.com authored
      Rebaselining after r126911, r127163 and r127534.
      
      Adding a platform-specific baseline for accessibility/canvas-description-and-role.html
      that's required after r127084. The baseline is currently the same as Chromium's,
      expecting 'AXCanvas' as the AXRole for the canvas element. The GTK port currently
      reports 'image' as the AXRole - this is probably not intended so the text failure
      expectation is also added for this test.
      
      * platform/gtk/TestExpectations:
      * platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
      * platform/gtk/fast/block/float/024-expected.txt:
      * platform/gtk/fast/block/margin-collapse/025-expected.txt:
      * platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
      * platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
      * platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
      * platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
      * platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
      * platform/gtk/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      554c000e
    • yosin@chromium.org's avatar
      [Tests] We should have interactive validation of required value for the "input" element · b7803c6d
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95817
      
      Reviewed by Kent Tamura.
      
      This patch adds tests for required attribute handling on form
      submission of input types. The test script is parametrized for
      input type and expected type. Each test file simply call one test
      script in common-interactive-validation-required.js.
      
      The test script checks:
        - Don't submit form when required value isn't presented.
        - Submit form when required value is presented.
      
      * fast/forms/date/date-interactive-validation-required-expected.txt: Added.
      * fast/forms/date/date-interactive-validation-required.html: Added.
      * fast/forms/datetime/datetime-interactive-validation-required-expected.txt: Added.
      * fast/forms/datetime/datetime-interactive-validation-required.html: Added.
      * fast/forms/datetimelocal/datetimelocal-interactive-validation-required-expected.txt: Added.
      * fast/forms/datetimelocal/datetimelocal-interactive-validation-required.html: Added.
      * fast/forms/month/month-interactive-validation-required-expected.txt: Added.
      * fast/forms/month/month-interactive-validation-required.html: Added.
      * fast/forms/number/number-interactive-validation-required-expected.txt: Added.
      * fast/forms/number/number-interactive-validation-required.html: Added.
      * fast/forms/resources/common-interactive-validation-required.js: Added.
      * fast/forms/time/time-interactive-validation-required-expected.txt: Added.
      * fast/forms/time/time-interactive-validation-required.html: Added.
      * fast/forms/week/week-interactive-validation-required-expected.txt: Added.
      * fast/forms/week/week-interactive-validation-required.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7803c6d
    • mikelawther@chromium.org's avatar
      Moved mac results to be the generic results, and the existing result to be the chromium · ee6f3e4f
      mikelawther@chromium.org authored
      platform result. The current result uses subpixel layout, which is not the norm.
      
      Original results were added in r127557. Mac results were added in r127560.
      
      * css3/calc/zoom-with-em-expected.txt:
      * platform/chromium/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.
      * platform/mac/css3/calc/zoom-with-em-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee6f3e4f
    • yosin@chromium.org's avatar
      Test cases for Up/Down key behavior on field which has maximum/minimum in... · c538f3fb
      yosin@chromium.org authored
      Test cases for Up/Down key behavior on field which has maximum/minimum in multiple fields time input UI
      https://bugs.webkit.org/show_bug.cgi?id=95824
      
      Reviewed by Kent Tamura.
      
      This patch adds test cases for Up/Down key behavior on field which has
      maximum/minimum value in multiple fields time input UI.
      
      This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
      ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
      
      * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Updated expectation for new test cases.
      * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Changed to add test cases for Up key behavior for "23:59:59.999" (11:59:59.999PM in UI) and Down key behavior for "01:00:00.000" (01:00:00.000 AM in UI)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c538f3fb
    • rgabor@webkit.org's avatar
      DFG JIT doesn't work properly on ARM hardfp · 909ad1bb
      rgabor@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95684
      
      Reviewed by Filip Pizlo.
      
      Add hardfp support to DFG JIT. The patch is created with the
      help of Zoltan Herczeg.
      
      Source/JavaScriptCore: 
      
      * dfg/DFGCCallHelpers.h:
      (CCallHelpers):
      (JSC::DFG::CCallHelpers::setupArguments):
      * dfg/DFGFPRInfo.h:
      (FPRInfo):
      * dfg/DFGSpeculativeJIT.h:
      (SpeculativeJIT):
      (JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
      (JSC::DFG::SpeculativeJIT::appendCallSetResult):
      
      Source/WTF: 
      
      * wtf/Platform.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      909ad1bb
    • mitz@apple.com's avatar
      Added Mac-specific expected results for a test added in r127557. The generic results are · 00bd3817
      mitz@apple.com authored
      probably from a build with subpixel layout.
      
      * platform/mac/css3/calc: Added.
      * platform/mac/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00bd3817
    • kbalazs@webkit.org's avatar
      [Qt] QRawWebViewPrivate does not initialize some members · d012b075
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95709
      
      Reviewed by Luiz Agostini.
      
      Don't miss initializing the bool flags.
      
      * UIProcess/API/qt/raw/qrawwebview.cpp:
      (QRawWebViewPrivate::QRawWebViewPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d012b075
    • keishi@webkit.org's avatar
      Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer · b8f608b0
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95681
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      We are moving calendar picker PagePopupClient to WebKit layer so ports
      can use their platform native chooser UI if they have one.
      DateTimeChooser, DateTimeChooserClient etc. will be reused when we
      implement the week picker and month picker.
      
      No new tests. No behavior change. Covered by existing calendar picker tests.
      
      * WebCore.gypi:
      * html/shadow/CalendarPickerElement.cpp:
      (WebCore::CalendarPickerElement::CalendarPickerElement):
      (WebCore::CalendarPickerElement::~CalendarPickerElement):
      (WebCore::CalendarPickerElement::didChooseValue): Called when user chose a value.
      (WebCore):
      (WebCore::CalendarPickerElement::didEndChooser): Called when chooser has ended.
      (WebCore::CalendarPickerElement::openPopup):
      (WebCore::CalendarPickerElement::closePopup):
      * html/shadow/CalendarPickerElement.h:
      (CalendarPickerElement):
      * loader/EmptyClients.cpp:
      (WebCore):
      (WebCore::EmptyChromeClient::openDateTimeChooser):
      * loader/EmptyClients.h:
      (EmptyChromeClient):
      * page/ChromeClient.h:
      (WebCore):
      (ChromeClient):
      * platform/DateTimeChooser.h:
      (WebCore):
      (DateTimeChooserParameters): Contains information needed to open the DateTimeChooser.
      (DateTimeChooser):
      (WebCore::DateTimeChooser::~DateTimeChooser):
      * platform/DateTimeChooserClient.h:
      (WebCore):
      (DateTimeChooserClient):
      (WebCore::DateTimeChooserClient::~DateTimeChooserClient):
      
      Source/WebKit/chromium:
      
      * WebKit.gyp:
      * src/ChromeClientImpl.cpp:
      (WebKit):
      (WebKit::ChromeClientImpl::openDateTimeChooser):
      * src/ChromeClientImpl.h:
      (WebCore):
      (ChromeClientImpl):
      * src/DateTimeChooserImpl.cpp: Added.
      (WebKit):
      (WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
      (WebKit::DateTimeChooserImpl::~DateTimeChooserImpl):
      (WebKit::DateTimeChooserImpl::endChooser):
      (WebKit::DateTimeChooserImpl::contentSize):
      (WebKit::DateTimeChooserImpl::writeDocument):
      (WebKit::DateTimeChooserImpl::setValueAndClosePopup):
      (WebKit::DateTimeChooserImpl::didClosePopup):
      * src/DateTimeChooserImpl.h:
      (WebCore):
      (WebKit):
      (DateTimeChooserImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8f608b0
    • mikelawther@chromium.org's avatar
      CSS3 calc: expressions with 'em' units do not zoom correctly. · f9e8a8df
      mikelawther@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95705
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Each primitive value in a CSS calc expression now has (zoom) multiplier and scale factor applied
      independently. Previously the multiplier and a single scale factor was applied to the expression
      as a whole, but this failed to account for expressions involving font relative units. This is
      because the multiplier should not be applied to font relative units.
      
      Test: css3/calc/zoom-with-em.html
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::computeLengthDouble):
      
      LayoutTests:
      
      * css3/calc/zoom-with-em-expected.txt: Added.
      * css3/calc/zoom-with-em.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9e8a8df