GitLab

        Reviewed by Darin Adler.

        commit-queue should ignore builders when landing rollouts
        https://bugs.webkit.org/show_bug.cgi?id=37051

        When we moved the "builders are red" check into the master process, we
        forgot about rollouts.  I thought we had a test covering this case, but
        looking at the test, it was a bit too loose.  I added a new test and
        introduced some new logging technology into MockTool to make the test
        tighter.

        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Nate Chapin.

        Set the close policy used by the DatabaseCloseTask in a constructor argument
        instead of hard coding it.
        https://bugs.webkit.org/show_bug.cgi?id=37037

        No new tests, new new functionality.

        * storage/Database.cpp: This callsite passes in DoNotRemoveFromDatabaseContext to retain its current behavior.
        (WebCore::Database::markAsDeletedAndClose):
        * storage/DatabaseTask.cpp:
        (WebCore::DatabaseCloseTask::DatabaseCloseTask):
        (WebCore::DatabaseCloseTask::doPerformTask):
        * storage/DatabaseTask.h:
        (WebCore::DatabaseCloseTask::create):
2010-04-02  Michael Nordman  <michaeln@google.com>

        Reviewed by Nate Chapin.

        Set the close policy used by the DatabaseCloseTask at this callsite to
        RemoveDatabaseFromContext. This restores its behavior to what it was prior to
        r56293.
        https://bugs.webkit.org/show_bug.cgi?id=37037

        * src/WebDatabase.cpp:
        (WebKit::WebDatabase::closeDatabaseImmediately):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Fraser.

        Remove an ASSERT that sometimes flakes due to time dependent animations
        https://bugs.webkit.org/show_bug.cgi?id=37048

        The outline repaint rectangle for a layer might change between two calls
        if there are animations involved, even if nothing in the DOM has actually
        changed between the calls.

        No change in behavior, no new tests.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Add two files that failed to get added in my previous patch.

        * platform/chromium/DragImageChromiumMac.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):
        * platform/chromium/DragImageChromiumSkia.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Carlson.

        Configure multi-language movies: when QuickTime has sufficiently loaded
        the movie, call into wkQTMovieSelectPreferredAlternates to select the
        movie's alternate tracks according to the user's language preferences.

        https://bugs.webkit.org/show_bug.cgi?id=36624

        * WebCore.base.exp:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: 
        (WebCore::MediaPlayerPrivate::updateStates): If the movie is sufficiently loaded,
        call wkQTMovieSelectPreferredAlternates to set up the alternate tracks.
        * platform/mac/WebCoreSystemInterface.h: Declare WKQTMovieSelectPreferredAlternates.
        * platform/mac/WebCoreSystemInterface.mm: Add WKQTMovieSelectPreferredAlternates.

2010-04-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.
        
        https://bugs.webkit.org/show_bug.cgi?id=36624

        Update WebKitSystemInterface

        * WebKitSystemInterface.h: add WKQTMovieSelectPreferredAlternates.
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

2010-04-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        https://bugs.webkit.org/show_bug.cgi?id=36624
        Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Splits RenderBlock::layoutInline into smaller functions
        https://bugs.webkit.org/show_bug.cgi?id=36921

        RenderBlock::layoutInlineChildren is 351 lines long and very difficult
        to comprehend or edit safely. This patch splits it up into a few
        slightly smaller functions.  Most of the code is now in the 241 line
        layoutRunsAndFloats() which is a slight improvement.

        Perf neutral on the page cyclers.  This doesn't introduce any function
        calls into the hottest layout paths inside layoutRunsAndFloats and
        findNextLineBreak.

        No change in behavior, no new tests.

        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutReplacedElements):
        (WebCore::RenderBlock::createLineBoxesForResolver):
        (WebCore::RenderBlock::layoutRunsAndFloats):
        (WebCore::RenderBlock::layoutInlineChildren):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [Symbian] Rebaseline Symbian def file
        https://bugs.webkit.org/show_bug.cgi?id=37038

        Switch the ordinal numbers for qtwebkit_webframe_scrollRecursively
        and QWebInspector::closeEvent to match QtWebkit 4.6 branch

        Fix the signature for qt_drt_setFrameFlatteningEnabled
        after r56718.

        Add new QtWebKit API symbols introduced not listed in the file yet.

        * symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Basic implementation using SkBitmap. Transformations are not supported
        yet. No implementation for mac.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/chromium/DragImageChromium.cpp:
        * platform/chromium/DragImageRef.h:
2010-04-02  Evan Stade  <estade@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Use the DragImageRef that the DragController passes to us.

        * public/WebViewClient.h:
        (WebKit::WebViewClient::startDragging):
        * src/DragClientImpl.cpp:
        (WebKit::DragClientImpl::startDrag):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::startDragging):
        * src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/reposit...

        Reviewed by Eric Seidel.

        [chromium] font fallback for generic fonts picks wrong font
        https://bugs.webkit.org/show_bug.cgi?id=37033

        When a page specifies the generic "monospace" font and the user's
        browser-configured monospace font doesn't exist, we previously relied
        on getLastResortFallbackFont to eventually pick a monospace font for us.

        But that doesn't quite work: WebKit first falls back to the user's
        "preferred standard font" before hitting the last resort code path.
        So if the above conditions hold but this font exists, we'll end up
        never hitting the last resort codepath.

        The fix is to allow OS-level font fallback when first attempting to
        resolve monospace.  The existing code tried to do this, but the logic
        was wrong.  We would eventually fall back to the correct font anyway
        so we didn't notice the logic was wrong.

        This code is all handling cases where particular fonts aren't installed,
        so I can't think of a way to test it; existing tests should still pass.

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::createFontPlatformData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        Clean up unused calls after changes to checkPermission and requestPermission argument lists.

        * public/WebNotificationPresenter.h:
        * src/NotificationPresenterImpl.cpp:
        (WebKit::NotificationPresenterImpl::checkPermission):
        (WebKit::NotificationPresenterImpl::requestPermission):
2010-04-02  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Adam Barth.

        Clean up unused calls after changes to checkPermission and requestPermission argument lists.

        * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
        (WebDesktopNotificationsDelegate::requestPermission):
        * WebCoreSupport/WebDesktopNotificationsDelegate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Mingw-w64 fixes for JavaScriptCore
        https://bugs.webkit.org/show_bug.cgi?id=35607

        * runtime/Collector.cpp: use the msvc code for mingw-w64 (but not mingw-w32)
        (JSC::Heap::allocateBlock):
        (JSC::Heap::freeBlockPtr):
        (JSC::currentThreadStackBase):
        (JSC::currentThreadStackBase):
        * wtf/Platform.h: added COMPILER(MINGW64) check to differentiate between mingw.org and mingw-w64 functions

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        https://bugs.webkit.org/show_bug.cgi?id=37043
        Java regression tests spam stderr about being unable to set status message

        With this change, there is still spam about "Attempt to access JavaScript from destroyed
        applet, type 9." I haven't investigated if that indicates a problem or not.

        * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]):
        Removed check for _documentView. We don't seem to care.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Carlson and Eric Seidel.

        Don't stop the playback event timer when media resource loading has suspended.
        https://bugs.webkit.org/show_bug.cgi?id=37003

        When a user agent decides to suspend media resource loading and enters the
        NETWORK_IDLE state we are supposed to only stop the progress event timer but
        keep the playback timer running.

        Test: http/tests/media/video-play-suspend.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setNetworkState): Only stop the progress event timer.

2010-04-02  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson and Eric Seidel.

        Don't stop the playback event timer when media resource loading has suspended.
        https://bugs.webkit.org/show_bug.cgi?id=37003

        When a user agent decides to suspend media resource loading and enters the
        NETWORK_IDLE state we are supposed to only...

* html/canvas/CanvasRenderingContext2D.cpp:
* html/canvas/CanvasRenderingContext2D.h:
Dashbard -> Dashboard.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=36906

Reviewed by Darin Adler.

WebCore:

* dom/CanvasSurface.cpp: Added methods for items that depended on
CanvasRenderingContext::canvas() being an HTMLElement(), so that this usage
can be dealt with in one place.
(WebCore::CanvasSurface::securityOrigin): Only used by methods that are
only run in the document context.
(WebCore::CanvasSurface::renderBox): Will likely return 0 in a worker context.
(WebCore::CanvasSurface::computedStyle): Used by setFont. Return value is TBD for
the worker context.
(WebCore::CanvasSurface::styleSelector): Ditto.
* dom/CanvasSurface.h:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext): Passing in information into
the CanvasRenderingContext2D constructor to eliminate some uses of document
inside of the CanvasRenderingContext2D class.
* html/HTMLCanvasElement.h:
(WebCore::HTMLCanvasElement::renderBox): Added to disambiguate between the
two parent class versions of the method.
(WebCore::HTMLCanvasElement::computedStyle): Ditto.
* html/canvas/CanvasRenderingContext2D.cpp: All of these changes are about
removing document usage either by using a bool that is set in the constructor or
by calling one of the new methods added to CanvasSurface.
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode):
(WebCore::CanvasRenderingContext2D::checkOrigin):
(WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/WebGLRenderingContext.cpp: Removed some duplicate includes.
(WebCore::WebGLRenderingContext::markContextChanged): Reduced calls to renderBox
 as it may become slightly more expensive in the future.
(WebCore::WebGLRenderingContext::reshape): Ditto.

LayoutTests:

* fast/canvas/script-tests/canvas-gradient-addStop-error.js: Changed the test
to create a new canvas after switching to dashboard compatiblity mode, which is
needed now that the compatibility mode is cached in the canvas.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=37039
        
Reviewed by Oliver Hunt.

Maybe a 1% speedup on iBench JS.

* JavaScriptCore.exp: New exports.

* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSNumberCell.cpp:
* runtime/JSNumberCell.h:
* runtime/JSString.cpp:
* runtime/JSString.h:
* runtime/JSValue.h:
* runtime/JSZombie.h:
(JSC::JSZombie::toThisObject): Nixed the old virtual-type implementation.

* runtime/JSObject.h:
(JSC::JSValue::toThisString):
(JSC::JSValue::toThisJSString): Added the inlined implementation.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Implement and test new framebuffer object attachment behavior.
        https://bugs.webkit.org/show_bug.cgi?id=35611

        * fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added, test framebuffer object attachment behavior.
        * fast/canvas/webgl/framebuffer-object-attachment.html: Added, framebuffer object attachment behavior.
        * fast/canvas/webgl/script-tests/gl-object-get-calls.js: DEPTH_COMPONENT is no longer a valid input, use DEPTH_COMPONENT16 instead.
        * platform/mac-snowleopard/Skipped: The bot does not support EXT_packed_depth_stencil, skip the framebuffer-object-attachment.html test.
2010-04-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Eric Seidel.

        Implement and test new framebuffer object attachment behavior.
        https://bugs.webkit.org/show_bug.cgi?id=35611

        Test: fast/canvas/webgl/framebuffer-object-attachment.html

        * html/canvas/WebGLFramebuffer.cpp: Keep track of attached stencil/depth renderbuffers in WebGLFramebuffer.
        (WebCore::WebGLFramebuffer::WebGLFramebuffer):
        (WebCore::WebGLFramebuffer::setIsAttached):
        * html/canvas/WebGLFramebuffer.h: Ditto.
        (WebCore::WebGLFramebuffer::isDepthAttached):
        (WebCore::WebGLFramebuffer::isStencilAttached):
        (WebCore::WebGLFramebuffer::isDepthStencilAttached):
        * html/canvas/WebGLRenderbuffer.cpp: Keep track of internalformat.
        (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
        * html/canvas/WebGLRenderbuffer.h: Ditto.
        (WebCore::WebGLRenderbuffer::setInternalformat):
        (WebCore::WebGLRenderbuffer::getInternalformat):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Detect stencil/depth buffer conflicts.
        (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Handling DEPTH_STENCIL case.
        (WebCore::WebGLRenderingContext::getRenderbufferParameter): Get correct WebGL internalformat.
        (WebCore::WebGLRenderingContext::renderbufferStorage): Detect illegal enums.
        * html/canvas/WebGLRenderingContext.idl: Add DEPTH_STENCIL enums.
        * platform/graphics/GraphicsContext3D.h: Add DEPTH_STENCIL enums.
        (WebCore::GraphicsContext3D::):
        * platform/graphics/mac/GraphicsContext3DMac.cpp: Map to correct DEPTH_STENCIL format.
        (WebCore::GraphicsContext3D::framebufferRenderbuffer):
        (WebCore::GraphicsContext3D::renderbufferStorage):
        (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
2010-04-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Eric Seidel.

        Implement and test new framebuffer object attachment behavior.
        https://bugs.webkit.org/show_bug.cgi?id=35611

        Test: fast/canvas/webgl/framebuffer-object-attachment.html

        * src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format.
        (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv):
        (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Adam Treat.
Patch by Antonio Gomes <tonikitoo@webkit.org>

* Api/qwebpage.cpp:
(QWebPagePrivate::mousePressEvent(QEvent* ev)):
(QWebPagePrivate::mousePressEvent(QGraphicsSceneMouseEvent* ev):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Geoffrey Garen.

        Beef up documentation for ASSERT* and CRASH macros a bit.

        https://bugs.webkit.org/show_bug.cgi?id=36527

        * wtf/Assertions.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
        https://bugs.webkit.org/show_bug.cgi?id=36908

        * fast/canvas/webgl/index-validation-expected.txt: Gathering more information about the cause of the failure.  It's not a fix, and it won't worse change the current test behavior either, i.e., it won't make it better or worse.
        * fast/canvas/webgl/script-tests/index-validation.js: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Fisher.

        The popup type (select or suggestion) is now passed to the
        WebClient::createPopupMenu() method. This is required for
        Chromium on Linux to make the select popups work correctly.
        https://bugs.webkit.org/show_bug.cgi?id=37013

        * WebKit.gyp:
        * public/WebPopupType.h: Added.
        (WebKit::):
        * public/WebViewClient.h:
        (WebKit::WebViewClient::createPopupMenu):
        * src/ChromeClientImpl.cpp:
        (WebCore::convertPopupType):
        (WebKit::ChromeClientImpl::popupOpened):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Form control state shouldn't be restored for hidden inputs.
        https://bugs.webkit.org/show_bug.cgi?id=26241

        * fast/forms/button-state-restore.html: Updated for the behavior change.
        * fast/forms/state-restore-to-non-edited-controls-expected.txt: Added.
        * fast/forms/state-restore-to-non-edited-controls.html: Added.
2010-04-02  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Form control state shouldn't be restored for hidden inputs.
        https://bugs.webkit.org/show_bug.cgi?id=26241

        To fix this issue, we don't save values if it is not changed from
        the default value.

        Updating the value IDL attribute of some controls such as
        type=hidden also updates the value content attribute, and it's
        impossible to distinguish the initial value and the current
        value. The values of such controls are not saved. It won't be a
        problem because we want to save and restore user-edited values.

        Test: fast/forms/state-restore-to-non-edited-controls.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::saveFormControlState):
          Do not save the value if it is same as the default value.
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::saveFormControlState): ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Forms with autocomplete=off should not consume saved state
        https://bugs.webkit.org/show_bug.cgi?id=36762

        * fast/forms/state-restore-to-non-autocomplete-form-expected.txt: Added.
        * fast/forms/state-restore-to-non-autocomplete-form.html: Added.
2010-04-02  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Forms with autocomplete=off should not consume saved state
        https://bugs.webkit.org/show_bug.cgi?id=36762

        Introduce Element::shouldSaveAndRestoreFormControlState() to check
        if we should save and restore control state.

        Test: fast/forms/state-restore-to-non-autocomplete-form.html

        * dom/Document.cpp:
        (WebCore::Document::formElementsState): Check shouldSaveAndRestoreFormControlState().
        * dom/Element.h:
        (WebCore::Element::shouldSaveAndRestoreFormControlState): Added. It just returns true.
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElementWithState::autoComplete):
          Added. It return autocomplete state of the form.
        (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
          Added. It returns the result of autoComplete().
        (WebCore::HTMLFormControlElementWithState::finishParsingChildren):
          Do not restore state if shouldSaveAndRestoreFormControlState() is false.
        * html/HTMLFormControlElement.h: Declare autoComplete() and overriding methods.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::autoComplete):
          Reduce code by using autoComplete() of the parent class.
        (WebCore::HTMLInputElement::saveFormControlState):
          Remove the autoComplete() check. Document::formElementsState() does equivalent check.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

sherrifbot should ensure that the rollout reason doesn't start with - (and fix webkit-patch upload).
https://bugs.webkit.org/show_bug.cgi?id=37030

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/bot/sheriff.py: Ensure that the rollout reason doesn't
  start with -.
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: A test with a rollout
  reason which starts with -.
* Scripts/webkitpy/tool/steps/createbug.py: Fix webkit-patch upload.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fixed check-webkit-style to recognize the short form of the
--verbose option, as stated in --help.

* Scripts/check-webkit-style:
  - Tweaked one line.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Avoid doing work in FrameView::scrollPositionChanged() if there are no fixed position elements
        https://bugs.webkit.org/show_bug.cgi?id=36994

        r55890 added knowledge to FrameView about whether it contains any fixed-position elements. We can
        use this to avoid updating widget positions, and compositing layer positions when possible.

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollPositionChanged):
        * page/FrameView.h:
        (WebCore::FrameView::hasFixedObjects):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rubber-stamped by Dimitri Glazkov.

        http://trac.webkit.org/changeset/57004 caused
        fast/dom/console-log-stack-overflow.html to fail for Chromium.
        Add check for empty wrappers before using them to create a hidden reference.

        * bindings/scripts/CodeGeneratorV8.pm:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed.

        [Gtk] LayoutTest feColorMatrix-value with different results over Gtk bots
        https://bugs.webkit.org/show_bug.cgi?id=37029

        Adding svg/filters/feColorMatrix-values.svg to the Gtk skip list. Opened
        the bug report from above.

        * platform/gtk/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Incorrect insertion position after typing 'ำ' (THAI CHARACTER SARA AM = 0E33)
        https://bugs.webkit.org/show_bug.cgi?id=36858

        Add failing results for Tiger to make the Tiger bot green.
        We may wish to actually fix Tiger at some point.

        * platform/mac-tiger/fast/text/multiglyph-characters-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dimitri Glazkov.

        [V8] Generalize (and generate!) the creation of hidden references
        between JS wrappers.
        
        https://bugs.webkit.org/show_bug.cgi?id=36777

        * Android.v8bindings.mk:
        * WebCore.gypi:
        * bindings/scripts/CodeGeneratorV8.pm: Generate calls to setHiddenReference() in
        attribute getters.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::setHiddenReference): Split common logic out of hidden setHiddenWindowReference
        (WebCore::V8DOMWrapper::setHiddenWindowReference): Now contains logic specific to putting a 
        hidden reference on a global object.
        (WebCore::globalObjectPrototypeIsDOMWindow): Be more thorough in the COMPILE_ASSERTs.
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object): Cleanup: Remove a duplicate if statement.
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/WrapperTypeInfo.h:
        * bindings/v8/custom/V8BarInfoCustom.cpp: Removed.
        * bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
        (WebCore::toV8):
        * bindings/v8/custom/V8DOMSelectionCustom.cpp: Removed.
        * bindings/v8/custom/V8HistoryCustom.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:
        * bindings/v8/custom/V8MessageChannelConstructor.cpp:
        (WebCore::V8MessageChannel::constructorCallback):
        * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
        (WebCore::toV8):
        * bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
        * bindings/v8/custom/V8ScreenCustom.cpp: Removed.
        * bindings/v8/custom/V8StyleSheetCustom.cpp:
        (WebCore::toV8):
        * loader/appcache/DOMApplicationCache.h:
        (WebCore::DOMApplicationCache::frame): Add frame() accessor.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Timothy Hatcher.

        Web Inspector: start editing DOM and styles on click-and-pause (part 1).

        https://bugs.webkit.org/show_bug.cgi?id=36965

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.onattach):
        (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
        (WebInspector.ElementsTreeElement.prototype.ondblclick):
        (WebInspector.ElementsTreeElement.prototype._handleClickAndPause):
        (WebInspector.ElementsTreeElement.prototype._startEditingTarget):
        (WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
        (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
        (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
        (WebInspector.StylePropertiesSection.prototype._handleSelectorClick):
        (WebInspector.StylePropertiesSection.prototype._handleSelectorClickAndPause):
        (WebInspector.StylePropertiesSection.prototype._handleSelectorDoubleClick):
        (WebInspector.StylePropertiesSection.prototype._startEditingOnMouseEvent):
        (WebInspector.StylePropertyTreeElement.prototype.onattach):
        (WebInspector.StylePropertyTreeElement.prototype):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.js:
        * inspector/front-end/treeoutline.js:
        (TreeElement.prototype._attach):
        (TreeElement.treeElementMouseDown):
        (TreeElement.prototype.selectOnMouseDown):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Add chromium suppression for http/tests/xhtmlmp since we do not support
        this feature.

        * platform/chromium/test_expectations.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed, minor build fix.

        Change the order of the member initialisation list
        in constructor to match declaration order

        * runtime/Collector.cpp:
        (JSC::Heap::Heap):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed build fix when building --no-svg.

        Build fix after r56941. Add ENABLE(SVG) guard.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Pavel Feldman.

        Implement InspectorFrontendHost::showContextMenu for Chromium.
 
        Move inspector frontend context menu code from InspectorFrontendClient to InspectorFrontendHost as it's platform independent.
 
        https://bugs.webkit.org/show_bug.cgi?id=36817

        * WebCore.Inspector.exp:
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
        * inspector/InspectorFrontendClient.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
        (WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal):
        (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
        * inspector/InspectorFrontendClientLocal.h:
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::FrontendMenuProvider::create):
        (WebCore::FrontendMenuProvider::disconnect):
        (WebCore::FrontendMenuProvider::FrontendMenuProvider):
        (WebCore::FrontendMenuProvider::~FrontendMenuProvider):
        (WebCore::FrontendMenuProvider::populateContextMenu):
        (WebCore::FrontendMenuProvider::contextMenuItemSelected):
        (WebCore::FrontendMenuProvider::contextMenuCleared):
        (WebCore::InspectorFrontendHost::InspectorFrontendHost):
        (WebCore::InspectorFrontendHost::disconnectClient):
        (WebCore::InspectorFrontendHost::showContextMenu):
        * inspector/InspectorFrontendHost.h:
        (WebCore::InspectorFrontendHost::create):

2010-04-02  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Implement InspectorFrontendClient in Chromium and remove all custom bindings for the host methods from WebDevToolsFrontendImpl. 

        https://bugs.webkit.org/show_bug.cgi?id=36817

        * WebKit.gyp:
        * src/InspectorFrontendClientImpl.cpp: Added.
        (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl):
        (WebKit::InspectorFrontendClientImpl::~InspectorFrontendClientImpl):
        (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
        (WebKit::InspectorFrontendClientImpl::frontendLoaded):
        (WebKit::InspectorFrontendClientImpl::moveWindowBy):
        (WebKit::InspectorFrontendClientImpl::localizedStringsURL):
        (WebKit::InspectorFrontendClientImpl::hiddenPanels):
        (WebKit::InspectorFrontendClientImpl::bringToFront):
        (WebKit::InspectorFrontendClientImpl::closeWindow):
        (WebKit::InspectorFrontendClientImpl::canAttachWindow):
        (WebKit::InspectorFrontendClientImpl::attachWindow):
        (WebKit::InspectorFrontendClientImpl::detachWindow):
        (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight):
        (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
        * src/InspectorFrontendClientImpl.h: Added.
        * src/WebDevToolsFrontendImpl.cpp:
        (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
        (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl):
        (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
        * src/WebDevToolsFrontendImpl.h:
        * src/js/DebuggerAgent.js:
        (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
        * src/js/DevTools.js:
        ():


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

but it fails: "NETWORK_ERR: XMLHttpRequest Exception 101: A network error occured in synchronous requests."

* platform/qt/Skipped: http/tests/xmlhttprequest/access-control-response-with-body.html skipped.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Pavel Feldman.

        WebInspector: Timeline Overview pane should support short records filtering.
        https://bugs.webkit.org/show_bug.cgi?id=37020

        * English.lproj/localizedStrings.js:
        * inspector/front-end/TimelineOverviewPane.js:
        (WebInspector.TimelineOverviewPane.prototype.update.markTimeline):
        (WebInspector.TimelineOverviewPane.prototype.update):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
        (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
        (WebInspector.TimelinePanel.prototype._refresh):
        (WebInspector.TimelinePanel.prototype._addToRecordsWindow):
        (WebInspector.TimelinePanel.FormattedRecord.prototype.isLong):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

because it passes. Compared to png file and Mac expected file.

* platform/qt/svg/custom/animation-currentColor-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56996 268f45cc-cd09-0410-ab3c-d52691b4dbfc