1. 06 Apr, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-04-06 Ryosuke Niwa <rniwa@webkit.org> · 56390f67
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
              https://bugs.webkit.org/show_bug.cgi?id=57872
      
              r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
              because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.
      
              r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
              avoiding the tab span.
      
              Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
      
              Test: editing/inserting/insert-paragraph-separator-tab-span.html
      
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
              separator into a paragraph separator.
      2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
              https://bugs.webkit.org/show_bug.cgi?id=57872
      
              Added a test insert a paragraph separator and text around tab spans. WebKit should not apply the tab span's
              style to the paragraph separator or the text.
      
              * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
              * editing/inserting/insert-paragraph-separator-tab-span.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56390f67
  2. 30 Mar, 2011 1 commit
    • inferno@chromium.org's avatar
      2011-03-30 Abhishek Arya <inferno@chromium.org> · 2da9b7ad
      inferno@chromium.org authored
              Reviewed by Simon Fraser.
      
              Tests that we do not crash when removing inline style
              from a node that is not a html element.
              https://bugs.webkit.org/show_bug.cgi?id=57348
      
              * editing/execCommand/remove-format-non-html-element-crash-expected.txt: Added.
              * editing/execCommand/remove-format-non-html-element-crash.html: Added.
      2011-03-30  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Fix wrong type assumptions in editing code. Move code
              from ASSERTs to hard checks.
              https://bugs.webkit.org/show_bug.cgi?id=57348
      
              Test: editing/execCommand/remove-format-non-html-element-crash.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::getRGBAFontColor):
              (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
              * editing/DeleteButtonController.cpp:
              (WebCore::enclosingDeletableElement):
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::textDirection):
              (WebCore::EditingStyle::prepareToApplyAt):
              * editing/Editor.cpp:
              (WebCore::Editor::textDirectionForSelection):
              * editing/FormatBlockCommand.cpp:
              (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2da9b7ad
  3. 08 Mar, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-03-08 Ryosuke Niwa <rniwa@webkit.org> · e18eb043
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              addInlineStyleIfNeeded should take EditingStyle
              https://bugs.webkit.org/show_bug.cgi?id=55950
      
              Deployed EditingStyle in addInlineStyleIfNeeded, StyleChange::StyleChange, and StyleChange::init.
              Also extracted EditingStyle::styleIsPresentInComputedStyleOfNode from removeStyleFromRunBeforeApplyingStyle.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::StyleChange::StyleChange): Takes EditingStyle instead of CSSStyleDeclaration.
              (WebCore::StyleChange::init): Ditto.
              (WebCore::ApplyStyleCommand::applyBlockStyle): Instantiates StyleChange.
              (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Calls addInlineStyleIfNeeded.
              (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls styleIsPresentInComputedStyleOfNode.
              (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls EditingStyle::mergeInlineStyleOfElement
              instead of manually merging styles.
              (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Calls addInlineStyleIfNeeded.
              (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Takes EditingStyle instead of CSSMutableStyleDeclaration.
              * editing/ApplyStyleCommand.h:
              * editing/CompositeEditCommand.h:
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode): Extracted from removeStyleFromRunBeforeApplyingStyle.
              * editing/EditingStyle.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e18eb043
  4. 07 Mar, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-03-07 Ryosuke Niwa <rniwa@webkit.org> · f9c8d307
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              selectionHasStyle and selectionStartHasStyle should use EditingStyle
              https://bugs.webkit.org/show_bug.cgi?id=55902
      
              selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
      
              * src/ContextMenuClientImpl.cpp:
              (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Calls selectionHasStyle.
      2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              selectionHasStyle and selectionStartHasStyle should use EditingStyle
              https://bugs.webkit.org/show_bug.cgi?id=55902
      
              selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
      
              * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
              (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
      2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              selectionHasStyle and selectionStartHasStyle should use EditingStyle
              https://bugs.webkit.org/show_bug.cgi?id=55902
      
              Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
              This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.
      
              Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
              to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
              call sites of these two functions.
      
              * WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports
              selectionStartHasStyle because it's not called anywhere outside of WebCore.
              * WebCore.order: Ditto.
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id
              and a property value.
              (WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
              * editing/EditingStyle.h:
              (WebCore::EditingStyle::create): Added.
              * editing/Editor.cpp:
              (WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of
              a CSSStyleDeclaration.
              (WebCore::Editor::selectionHasStyle): Ditto.
              * editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
              * editing/EditorCommand.cpp:
              (WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle.
              (WebCore::stateStyle): Ditto.
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9c8d307
  5. 01 Mar, 2011 2 commits
    • rniwa@webkit.org's avatar
      2011-03-01 Ryosuke Niwa <rniwa@webkit.org> · b249876e
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              WebKit does not merge text decorations in the typing style and the selected element properly
              https://bugs.webkit.org/show_bug.cgi?id=55349
      
              Added a test to ensure WebKit merges text decorations in the typing style and the inline style
              of the element around the caret when computing the style at the selection start.
      
              * editing/execCommand/merge-text-decoration-with-typing-style-expected.txt: Added.
              * editing/execCommand/merge-text-decoration-with-typing-style.html: Added.
              * editing/style/push-down-inline-styles-expected.txt: Rebaselined due to the change in which text decoration
              values appear.
              * editing/style/script-tests/push-down-inline-styles.js: Ditto.
      2011-03-01  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKit does not merge text decorations in the typing style and the selected element properly
              https://bugs.webkit.org/show_bug.cgi?id=55349
      
              The bug was caused by EditingStyle::mergeTypingStyle's not properly merging text decoration property.
              Fixed the bug by extracting a function from ApplyStyleCommand::pushDownInlineStyleAroundNode and
              calling it in pushDownInlineStyleAroundNode and in mergeTypingStyle.
      
              Test: editing/execCommand/merge-text-decoration-with-typing-style.html
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Takes EditingStyle*;
              calls mergeInlineStyleOfElement.
              (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls applyInlineStyleToPushDown.
              (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
              * editing/ApplyStyleCommand.h:
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::mergeTypingStyle): Added; calls mergeStyle.
              (WebCore::EditingStyle::mergeInlineStyleOfElement): Ditto.
              (WebCore::EditingStyle::mergeStyle): Extracted from applyInlineStyleToPushDown.
              * editing/EditingStyle.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b249876e
    • rniwa@webkit.org's avatar
      2011-03-01 Ryosuke Niwa <rniwa@webkit.org> · bf57284a
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
              https://bugs.webkit.org/show_bug.cgi?id=55338
      
              Deployed EditingStyle in applyInlineStyleToPushDown and removeInlineStyleFromElement.
      
              Also added a convenience function EditingStyle::setProperty, which lazily instantiates
              new CSSMutableStyleDeclaration for m_mutableStyle.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle*.
              (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Ditto.
              (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
              (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls the above three functions.
              (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownInlineStyleAroundNode.
              * editing/ApplyStyleCommand.h:
              * editing/EditingStyle.cpp:
              (WebCore::HTMLElementEquivalent::addToStyle): Takes EditingStyle*; calls EditingStyle::setProperty.
              (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
              (WebCore::EditingStyle::setProperty): Added.  This member function lazily instantiates
              new CSSMutableStyleDeclaration for m_mutableStyle.
              (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Takes EditingStyle*.
              (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Ditto.
              (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Ditto.
              * editing/EditingStyle.h: Added HTMLElementEquivalent and HTMLAttributeEquivalent as friends.
              (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Ditto.
              * editing/InsertTextCommand.cpp: Removed unnecessary includes.
              * editing/RemoveCSSPropertyCommand.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf57284a
  6. 25 Feb, 2011 2 commits
    • rniwa@webkit.org's avatar
      2011-02-25 Ryosuke Niwa <rniwa@webkit.org> · 94a9c20f
      rniwa@webkit.org authored
              Unreviewed Qt build fix; included CSSValueList.h in EditingStyle.cpp.
      
              * editing/EditingStyle.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94a9c20f
    • rniwa@webkit.org's avatar
      2011-02-25 Ryosuke Niwa <rniwa@webkit.org> · b2168a94
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Move HTMLEquivalent and its subclasses to EditingStyle
              https://bugs.webkit.org/show_bug.cgi?id=55207
      
              Moved HTMLEquivalent and its subclasses from ApplyStyleCommand to EditingStyle,
              and renamed HTMLEquivalent, HTMLEquivalentValueList, HTMLAttributeEquivalent,
              and HTMLEquivalentFontSizeAttribute to HTMLElementEquivalent, HTMLTextDecorationEquivalent,
              HTMLAttributeEquivalent, and HTMLFontSizeEquivalent respectively.
      
              Also extracted the logic to determine which element and attribute are removed
              as conflictsWithImplicitStyleOfElement, conflictsWithImplicitStyleOfAttributes,
              and extractConflictingImplicitStyleOfAttributes.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
              (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
              * editing/ApplyStyleCommand.h:
              * editing/EditingStyle.cpp:
              (WebCore::HTMLElementEquivalent::create): Moved from ApplyStyleCommand.cpp.
              (WebCore::HTMLElementEquivalent::~HTMLElementEquivalent): Ditto.
              (WebCore::HTMLElementEquivalent::matches): Ditto.
              (WebCore::HTMLElementEquivalent::hasAttribute): Ditto.
              (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Ditto.
              (WebCore::HTMLElementEquivalent::HTMLElementEquivalent): Ditto.
              (WebCore::HTMLElementEquivalent::valueIsPresentInStyle): Ditto.
              (WebCore::HTMLElementEquivalent::addToStyle): Ditto.
              (WebCore::HTMLTextDecorationEquivalent::create): Ditto.
              (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Ditto.
              (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Ditto.
              (WebCore::HTMLAttributeEquivalent::create): Ditto.
              (WebCore::HTMLAttributeEquivalent::matches): Ditto.
              (WebCore::HTMLAttributeEquivalent::hasAttribute): Ditto.
              (WebCore::HTMLAttributeEquivalent::attributeName): Ditto.
              (WebCore::HTMLAttributeEquivalent::HTMLAttributeEquivalent): Ditto.
              (WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle): Ditto.
              (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
              (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue): Ditto.
              (WebCore::HTMLFontSizeEquivalent::create): Ditto.
              (WebCore::HTMLFontSizeEquivalent::HTMLFontSizeEquivalent): Ditto.
              (WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue): Ditto.
              (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Added.
              (WebCore::htmlAttributeEquivalents): Added.
              (WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes): Added.
              (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Added.
              * editing/EditingStyle.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2168a94
  7. 22 Feb, 2011 2 commits
    • rniwa@webkit.org's avatar
      2011-02-22 Ryosuke Niwa <rniwa@webkit.org> · 19980977
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Make Editor::selectionComputedStyle return EditingStyle
              https://bugs.webkit.org/show_bug.cgi?id=54933
      
              Renamed selectionComputedStyle to selectionStartStyle and changed the return type to EditingStyle.
              It also no longer takes a boolean shouldUseFixedFontDefaultSize.
      
              Also added EditingStyle::mergeTypingStyle which replaced old editingStyleIncludingTypingStyle. This function
              doesn't extract inheritable properties prior to merge because this turned out be a bug, which was revealed
              by an existing layout test only after the code was shared with selectionStartStyle.
      
              No tests are added since this is a refactoring.
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs): Calls EditingStyle::create and EditingStyle::mergeTypingStyle.
              (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
              * editing/EditingStyle.cpp: Removed editingStyleIncludingTypingStyle.
              (WebCore::EditingStyle::mergeTypingStyle): Added.
              * editing/EditingStyle.h:
              (WebCore::EditingStyle::shouldUseFixedDefaultFontSize): Added.
              * editing/Editor.cpp:
              (WebCore::Editor::selectionStartHasStyle): Calls selectionStartStyle.
              (WebCore::Editor::selectionHasStyle): Ditto.
              (WebCore::Editor::selectionStartCSSPropertyValue): Ditto.
              (WebCore::Editor::selectionStartStyle): Renamed from selectionComputedStyle; returns EditingStyle.
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (WebCore::executeToggleStyleInList): Calls selectionStartStyle.
              * editing/InsertLineBreakCommand.cpp:
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Calls EditingStyle::create and
              EditingStyle::mergeTypingStyle.
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19980977
    • rniwa@webkit.org's avatar
      2011-02-22 Ryosuke Niwa <rniwa@webkit.org> · 84b451c8
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Deploy EditingStyle in removeInlineStyleFromElement and removeCSSStyle
              https://bugs.webkit.org/show_bug.cgi?id=54944
      
              Deployed EditingStyle in removeInlineStyleFromElement and removeCSSStyle.
      
              Also extracted EditingStyle::conflictsWithInlineStyleOfElement from ApplyStyleCommand::removeCSSStyle,
              which returns true iff the specified element has inline style that conflicts or matches the editing style.
              It also appends conflicting property IDs to the vector of property IDs if one is specified.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle): Calls removeCSSStyle.
              (WebCore::ApplyStyleCommand::applyInlineStyle): Calls shouldSplitTextElement.
              (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls removeInlineStyleFromElement.
              (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
              (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto; extracted the logic to decide properties to remove as
              conflictsWithInlineStyleOfElement.
              (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement.
              (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls removeInlineStyleFromElement.
              (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
              (WebCore::ApplyStyleCommand::shouldSplitTextElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
              * editing/ApplyStyleCommand.h:
              (WebCore::ApplyStyleCommand::shouldRemoveInlineStyleFromElement): Ditto.
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Extracted from ApplyStyleCommand::removeCSSStyle.
              * editing/EditingStyle.h:
              (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84b451c8
  8. 21 Feb, 2011 2 commits
    • rniwa@webkit.org's avatar
      2011-02-21 Ryosuke Niwa <rniwa@webkit.org> · 221a9c70
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Deploy EditingStyle more in ApplyStyleCommand and do some cleanup
              https://bugs.webkit.org/show_bug.cgi?id=54528
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::StyleChange::init): Allows style to be a null pointer.
              (WebCore::ApplyStyleCommand::applyInlineStyle): Overrides the value of text-decoration property by that of
              -webkit-text-decorations-in-effect and remove the latter property when present. This allows removeImplicitlyStyledElement
              to ignore -webkit-text-decorations-in-effect. Also uses the return value of EditingStyle::textDirection to determine
              whether or not we need to apply unicode-bidi / direction instead of directly checking the value of unicode-bidi property.
              (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
              (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Ditto.
              (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Ditto.
              (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
              (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Ditto.
              (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Ditto.
              (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto; no longer collapse text decoration properties because
              ApplyStyleCommand::applyInlineStyle already does it.
              * editing/ApplyStyleCommand.h:
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::textDirection): Exits early when m_mutableStyle is null.
              (WebCore::EditingStyle::collapseTextDecorationProperties): Extracted from ApplyStyleCommand::removeInlineStyle.
              * editing/EditingStyle.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      221a9c70
    • rniwa@webkit.org's avatar
      2011-02-17 Ryosuke Niwa <rniwa@webkit.org> · 62b16970
      rniwa@webkit.org authored
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              Done the rename. All calls to node() are replaced by calls to deprecatedNode().
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::setComposition): Check the nullity of startContainer() instead of startPosition()->node().
              (WebKit::WebViewImpl::confirmComposition): Ditto.
              (WebKit::WebViewImpl::textInputType):
              (WebKit::WebViewImpl::caretOrSelectionBounds):
      2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              Replaced the call to node() by a call to containerNode() because the returned node is
              used to determine whether or not the selected contents are editable and such a check
              must be done against the container node.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::handleKeyboardEvent):
      2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              Done the rename. All calls to node() are replaced by calls to deprecatedNode().
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_popup_menu_handler):
      2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              * WebView/WebFrame.mm:
              (-[WebFrame _smartDeleteRangeForProposedRange:]):
      2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              Replaced the call to node() by a call to containerNode() because the returned node is
              used to determine whether or not the selected contents are editable and such a check
              must be done against the container node.
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::handleKeyboardEvent):
      2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Kent Tamura.
      
              Rename Position::node() to Position::deprecatedNode()
              https://bugs.webkit.org/show_bug.cgi?id=54622
      
              Done the rename. All calls to node() are replaced by calls to deprecatedNode() except when
              calls were of the form node()->document() and node()->inDocument() in which case they were
              replaced by anchorNode()->document() and anchorNode()->inDocument() respectively.
      
              * WebCore.exp.in: Added Position::containerNode.
      
              The rest abbreviated for simplicity. Please see svn log.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62b16970
  9. 12 Feb, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-02-12 Ryosuke Niwa <rniwa@webkit.org> · 33a9ab25
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              Deploy EditingStyle in applyBlockStyle and applyInlineStyle
              https://bugs.webkit.org/show_bug.cgi?id=53911
      
              Deployed EditingStyle in ApplyStyleCommand::applyBlockStyle and ApplyStyleCommand::applyInlineStyle.
              Extracted EditingStyle::extractAndRemoveTextDirection from applyInlineStyle.
              Also added propertiesToInclude to the argument list of EditingStyle's constructor that takes Node*
              so that splitAncestorsWithUnicodeBidi can call EditingStyle::textDirection to obtain the text direction.
      
              No new tests are added since this is a refactoring.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::doApply): Passes EditingStyle* to applyBlockStyle and applyInlineStyle.
              (WebCore::ApplyStyleCommand::applyBlockStyle): Takes EditingStyle*.
              (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Changed the type of allowedDirection
              from int to WritingDirection. Uses EditingStyle's textDirection to obtain the writing direction.
              (WebCore::ApplyStyleCommand::applyInlineStyle): Takes EditingStyle*.
              (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows style to be null; exit early instead.
              (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Asserts that style is not null.
              (WebCore::ApplyStyleCommand::removeInlineStyle): Allows style to be null.
              * editing/ApplyStyleCommand.h: Includes WritingDirection.h; prototype changes.
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::EditingStyle): Added PropertiesToInclude to the argument.
              (WebCore::EditingStyle::init): Supports PropertiesToInclude.
              (WebCore::EditingStyle::extractAndRemoveTextDirection): Extracted from applyInlineStyle.
              * editing/EditingStyle.h:
              (WebCore::EditingStyle::create): Supports PropertiesToInclude.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33a9ab25
  10. 08 Jan, 2011 1 commit
  11. 05 Jan, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-01-05 Ryosuke Niwa <rniwa@webkit.org> · 809f9979
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              ApplyStyleCommand::applyRelativeFontStyleChange should take EditingStyle*
              https://bugs.webkit.org/show_bug.cgi?id=50641
      
              Modified applyRelativeFontStyleChange to take EditingStyle instead of CSSMutableStyleDeclaration.
              Also extracted the logic to obtain the font size delta from ApplyStyleCommand to EditingStyle.
              The font size delta is now stored as a member variable of EditingStyle as supposed to a property
              in CSSMutableStyleDeclration as soon as EditingStyle is instantiated.
      
              No new tests are added since this is a refactoring.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::doApply): Calls applyRelativeFontStyleChange.
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Takes EditingStyle.
              * editing/ApplyStyleCommand.h:
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::EditingStyle): Initializes m_fontSizeDelta.
              (WebCore::EditingStyle::init): Ditto.
              (WebCore::EditingStyle::extractFontSizeDelta): Extracted from applyRelativeFontStyleChange.
              (WebCore::EditingStyle::isEmpty): Takes care of m_fontSizeDelta.
              (WebCore::EditingStyle::setStyle): Calls extractFontSizeDelta.
              (WebCore::EditingStyle::overrideWithStyle): Ditto.
              (WebCore::EditingStyle::clear): Initializes m_fontSizeDelta.
              (WebCore::EditingStyle::copy): Calls extractFontSizeDelta.
              * editing/EditingStyle.h:
              (WebCore::EditingStyle::fontSizeDelta): Added.
              (WebCore::EditingStyle::hasFontSizeDelta): Added.
              * editing/Editor.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      809f9979
  12. 30 Dec, 2010 1 commit
  13. 06 Dec, 2010 1 commit
    • rniwa@webkit.org's avatar
      2010-12-06 Ryosuke Niwa <rniwa@webkit.org> · 5359dff3
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              ApplyStyleCommand should take EditingStyle instead of CSSStyleDeclaration
              https://bugs.webkit.org/show_bug.cgi?id=49938
      
              Modified ApplyStyleCommand::ApplyStyleCommand and ApplyStyleCommand::create to take EditingStyle*
              instead of CSSStyleDeclaration*. Also replaced much of code in Editor::computeAndSetTypingStyle
              by calls to EditingStyle's member functions and extracted EditingStyle::overrideWith and
              EditingStyle::extractAndRemoveBlockProperties.
      
              No new tests are added since this is a refactoring.
      
              * WebCore.exp.in: Added SelectionController::copyTypingStyle and EditingStyle::~EditingStyle.
              * css/CSSMutableStyleDeclaration.cpp: Made CSSMutableStyleDeclaration* in the argument list const.
              (WebCore::CSSMutableStyleDeclaration::merge):
              * css/CSSMutableStyleDeclaration.h:
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::ApplyStyleCommand): Takes EditingStyle* instead of CSSStyleDeclaration*.
              (WebCore::ApplyStyleCommand::doApply): Uses EditingStyle.
              * editing/ApplyStyleCommand.h: m_style is now a ref-pointer to EditingStyle instead of CSSMutableStyleDeclaration.
              (WebCore::ApplyStyleCommand::create): Takes EditingStyle* instead of CSSStyleDeclaration*.
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::applyStyle): Ditto.
              (WebCore::CompositeEditCommand::moveParagraphs): Calls applyStyle.
              (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
              * editing/CompositeEditCommand.h:
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto.
              * editing/EditCommand.cpp:
              * editing/EditCommand.h:
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::~EditingStyle): Added.
              (WebCore::EditingStyle::overrideWithStyle): Extracted from Editor::calculateTypingStyleAfterDelete.
              (WebCore::EditingStyle::copy): Added.
              (WebCore::EditingStyle::extractAndRemoveBlockProperties): Extracted from Editor::calculateTypingStyleAfterDelete.
              * editing/EditingStyle.h:
              * editing/Editor.cpp:
              (WebCore::Editor::applyStyle): Calls ApplyStyleCommand::create.
              (WebCore::Editor::applyParagraphStyle): Ditto.
              (WebCore::Editor::computeAndSetTypingStyle): Ditto.
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply): Calls applyStyle.
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::input): Ditto.
              * editing/RemoveFormatCommand.cpp:
              (WebCore::RemoveFormatCommand::doApply): Calls ApplyStyleCommand::create.
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Calls applyStyle.
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::copyTypingStyle): Moved from SelectionController.h
              * editing/SelectionController.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5359dff3
  14. 22 Nov, 2010 1 commit
    • rniwa@webkit.org's avatar
      2010-11-22 Ryosuke Niwa <rniwa@webkit.org> · e578ecd0
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              SelectionController::typingStyle() should return EditingStyle*
              https://bugs.webkit.org/show_bug.cgi?id=49813
      
              Changed the return value of SelectionController::typingStyle() to EditingStyle*.
              Also added SelectionController::copyTypingStyle() to copy the typing style
              as an instance of CSSMutableStyleDeclaration.
      
              No tests are added since this is no behavioral change.
      
              * WebView/WebFrame.mm:
              (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
      2010-11-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Tony Chang.
      
              SelectionController::typingStyle() should return EditingStyle*
              https://bugs.webkit.org/show_bug.cgi?id=49813
      
              Changed the return type of SelectionController::typingStyle to EditingStyle*.
      
              Extracted textDirection from Editor::textDirectionForSelection to hide the underlying
              CSSMutableStyleDeclaration.
      
              Also extracted the code to preserve unicode-bidi and direction CSS properties in
              InsertTextCommand::input, and moved into EditingStyle::prepareToApplyAt. ShouldPreserveWritingDirection,
              which is added to the argument list of EditingStyle::prepareToApplyAt, decides whether or not
              these two properties are preserved.
      
              Also added SelectionController::copyTypingStyle() to copy the typing style as an instance of
              CSSMutableStyleDeclaration.
      
              No new tests are added since this is a refactoring.
      
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::textDirection): Extracted from Editor::textDirectionForSelection.
              (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added a missing null check.
              (WebCore::EditingStyle::prepareToApplyAt): See above.
              (WebCore::editingStyleIncludingTypingStyle): Calls SelectionController::typingStyle.
              * editing/EditingStyle.h: Moved WritingDirection from Editor.h
              * editing/Editor.cpp:
              (WebCore::Editor::textDirectionForSelection): Calls EditingStyle::textDirection.
              (WebCore::Editor::computeAndSetTypingStyle): Calls SelectionController::typingStyle.
              (WebCore::Editor::selectionComputedStyle): Ditto.
              (WebCore::Editor::styleForSelectionStart): Ditto.
              * editing/Editor.h:
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply): Ditto.
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::input): Calls EditingStyle::prepareToApplyAt with PreserveWritingDirection.
              * editing/SelectionController.h:
              (WebCore::SelectionController::typingStyle): Returns EditingStyle* rather than CSSMutableStyleDeclaration*.
              (WebCore::SelectionController::copyTypingStyle): Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e578ecd0
  15. 21 Nov, 2010 1 commit
    • paroga@webkit.org's avatar
      2010-11-21 Patrick Gansterer <paroga@webkit.org> · f27e2eb1
      paroga@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              Use WTF_ARRAY_LENGTH in WebCore directory
              https://bugs.webkit.org/show_bug.cgi?id=49882
      
              * accessibility/AccessibilityObject.cpp:
              (WebCore::createARIARoleMap):
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::JSDOMWindowBase):
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/scripts/test/V8/V8TestObj.cpp:
              (WebCore::ConfigureV8TestObjTemplate):
              * css/CSSComputedStyleDeclaration.cpp:
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseAnimationShorthand):
              (WebCore::CSSParser::parseTransitionShorthand):
              * css/CSSPropertyLonghand.cpp:
              (WebCore::initShorthandMap):
              * dom/ExceptionCode.cpp:
              (WebCore::getExceptionCodeDescription):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
              * editing/EditingStyle.cpp:
              * editing/Editor.cpp:
              (WebCore::triStateOfStyle):
              * editing/EditorCommand.cpp:
              (WebCore::createCommandMap):
              * editing/MarkupAccumulator.cpp:
              (WebCore::appendCharactersReplacingEntities):
              * html/canvas/WebGLBuffer.cpp:
              (WebCore::WebGLBuffer::getCachedMaxIndex):
              (WebCore::WebGLBuffer::setCachedMaxIndex):
              * loader/FTPDirectoryParser.cpp:
              (WebCore::parseOneFTPLine):
              * mathml/RenderMathMLOperator.cpp:
              (WebCore::RenderMathMLOperator::updateFromElement):
              * page/animation/AnimationBase.cpp:
              (WebCore::addShorthandProperties):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::hasValidAvgCharWidth):
              * rendering/break_lines.cpp:
              * svg/SVGTransformable.cpp:
              (WebCore::parseAndSkipType):
              * svg/SVGViewSpec.cpp:
              (WebCore::SVGViewSpec::parseViewSpec):
              * svg/SVGZoomAndPan.cpp:
              (WebCore::SVGZoomAndPan::parseZoomAndPan):
              * xml/XPathFunctions.cpp:
              (WebCore::XPath::createFunctionMap):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f27e2eb1
  16. 08 Nov, 2010 1 commit
    • rniwa@webkit.org's avatar
      2010-11-08 Ryosuke Niwa <rniwa@webkit.org> · 0d96cf61
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove the remaining editing-style functions from ApplyStyleCommand
              https://bugs.webkit.org/show_bug.cgi?id=49155
      
              Replaced removeNonEditingProperties, editingStyleAtPosition, prepareEditingStyleToApplyAt,
              and removeStylesAddedByNode in ApplyStyleCommand.cpp by removeNonEditingProperties, EditingStyle::create,
              prepareToApplyAt, and removeStyleAddedByNode in EditingStyle.cpp.
      
              Also removed unnecessary header includes from various cpp files.
      
              No tests are added since this is a cleanup.
      
              * editing/ApplyStyleCommand.cpp: Removed removeNonEditingProperties, editingStyleAtPosition,
              prepareEditingStyleToApplyAt, and removeStylesAddedByNode.
              * editing/ApplyStyleCommand.h: Ditto.
              * editing/DeleteSelectionCommand.cpp: Removed removeEnclosingAnchorStyle.
              (WebCore::DeleteSelectionCommand::saveTypingStyleState): Calls removeStylesAddedByNode instead.
              * editing/EditingStyle.cpp:
              (WebCore::copyEditingProperties): Moved and renamed ApplyStyleCommand::removeNonEditingProperties.
              (WebCore::editingStyleFromComputedStyle): Calls copyEditingProperties. Changed the argument to PassRefPtr
              as supposed to a raw pointer for convenience.
              (WebCore::EditingStyle::init): Calls editingStyleFromComputedStyle.
              (WebCore::EditingStyle::removeStyleAddedByNode): Added.
              (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added.
              (WebCore::EditingStyle::removeNonEditingProperties): Added.
              (WebCore::editingStyleIncludingTypingStyle): Calls copyEditingProperties.
              * editing/EditingStyle.h: Added prototypes.
              * editing/Editor.cpp:
              (WebCore::Editor::selectionComputedStyle): Uses EditingStyle.
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Ditto.
              (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
              * editing/InsertParagraphSeparatorCommand.h:
              * editing/RemoveFormatCommand.cpp:
              (WebCore::RemoveFormatCommand::doApply): Ditto.
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::handleStyleSpansBeforeInsertion): Ditto.
              (WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
              (WebCore::ReplaceSelectionCommand::doApply): Ditto.
              (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
              * editing/ReplaceSelectionCommand.h:
              * editing/markup.cpp: Removed removeEnclosingMailBlockquoteStyle and removeDefaultStyles.
              (WebCore::createMarkup): Uses EditingStyle.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d96cf61
  17. 06 Nov, 2010 1 commit
    • rniwa@webkit.org's avatar
      2010-11-04 Ryosuke Niwa <rniwa@webkit.org> · 7e06f4ab
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Bug 46335 - Add EditingStyle
              https://bugs.webkit.org/show_bug.cgi?id=46335
      
              Added EditingStyle to WebCore/editing.  This class is intended to encapsulate getPropertiesNotIn, removeNonEditingProperties,
              editingStyleAtPosition, and prepareEditingStyleToApplyAt in ApplyStyleCommand.cpp once deployed everywhere.
              Deployed it in typing styles.
      
              No new tests are added since this is a refactoring in progress.
      
              * CMakeLists.txt: Added EditingStyle.cpp
              * GNUmakefile.am: Added EditingStyle.cpp and EditingStyle.h
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs): Calls editingStyleIncludingTypingStyle.
              (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Uses EditingStyle.
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::saveTypingStyleState): Ditto.
              (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto.
              * editing/DeleteSelectionCommand.h:
              * editing/EditingStyle.cpp: Added.
              (WebCore::editingStyleFromComputedStyle): Added.
              (WebCore::EditingStyle::EditingStyle): Added.
              (WebCore::EditingStyle::init): Added; a clone of ApplyStyleCommand::editingStyleAtPosition.
              (WebCore::EditingStyle::removeTextFillAndStrokeColorsIfNeeded): Extracted from init.
              (WebCore::EditingStyle::replaceFontSizeByKeywordIfPossible): Extracted from init.
              (WebCore::EditingStyle::isEmpty): Added.
              (WebCore::EditingStyle::setStyle): Added.
              (WebCore::EditingStyle::clear): Added.
              (WebCore::EditingStyle::removeBlockProperties): Added.
              (WebCore::EditingStyle::prepareToApplyAt): Added.
              (WebCore::editingStyleIncludingTypingStyle): Added.
              * editing/EditingStyle.h: Added.
              (WebCore::EditingStyle::create): Added.
              (WebCore::EditingStyle::style): Added.
              * editing/RemoveFormatCommand.cpp:
              (WebCore::RemoveFormatCommand::doApply): Uses EditingStyle.
              * editing/SelectionController.h:
              (WebCore::SelectionController::typingStyle): Uses EditingStyle.
              (WebCore::SelectionController::clearTypingStyle): Uses EditingStyle.
              (WebCore::SelectionController::setTypingStyle): Uses EditingStyle.
              * rendering/style/RenderStyle.h: Added EditingStyle as a friend.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e06f4ab