1. 07 Apr, 2011 4 commits
    • rniwa@webkit.org's avatar
      2011-04-07 Ryosuke Niwa <rniwa@webkit.org> · 5614540c
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
              https://bugs.webkit.org/show_bug.cgi?id=57872
      
              Added tests to ensure WebKit inserts a paragraph separator properly around tab span.
      
              * editing/inserting/insert-div-021-expected.txt: No longer duplicates span[id="test"] incorrectly.
              * editing/inserting/insert-paragraph-after-tab-span-and-text-expected.txt: Added.
              * editing/inserting/insert-paragraph-after-tab-span-and-text.html: Added.
              * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
              * editing/inserting/insert-paragraph-separator-tab-span.html: Added.
              * editing/inserting/insert-paragraph-at-end-of-line-expected.txt: No longer duplicates a[id="anchor"] incorrectly.
      2011-04-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
              https://bugs.webkit.org/show_bug.cgi?id=57872
      
              r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
              because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.
      
              r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
              avoiding the tab span.
      
              Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
              Also reverted r46914 for the general code path because re-creating node hierarchy duplicates nodes when
              we're moving nodes after the paragraph separator. Instead, we now split the tree up until the start block
              before moving the nodes.
      
              Tests: editing/inserting/insert-paragraph-after-tab-span-and-text.html
                     editing/inserting/insert-paragraph-separator-tab-span.html
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::saveTypingStyleState): Since EditingStyle's constructor avoids a tab span,
              no longer calls positionBeforeTabSpan on the position passed to EditingStyle's constructor.
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
              separator into a paragraph separator.
              * editing/htmlediting.cpp:
              (WebCore::positionOutsideTabSpan): Renamed from positionBeforeTabSpan. Also returns the position in the parent
              node after the tab span if the position was at the end of the tab span.
              * editing/htmlediting.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5614540c
    • rniwa@webkit.org's avatar
      2011-04-07 Ryosuke Niwa <rniwa@webkit.org> · 6683441a
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              dump-as-markup conversion: editing/pasteboard/paste-text-001.html and paste-text-011.html
              https://bugs.webkit.org/show_bug.cgi?id=58078
      
              Converted the tests.
      
              * editing/pasteboard/paste-text-001-expected.txt: Added.
              * editing/pasteboard/paste-text-001.html:
              * editing/pasteboard/paste-text-011-expected.txt: Added.
              * editing/pasteboard/paste-text-011.html:
              * platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-001-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-001-expected.txt: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/paste-text-001-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/gtk/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/gtk/editing/pasteboard/paste-text-011-expected.txt: Removed.
              * platform/mac-leopard/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/mac-leopard/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/mac/editing/pasteboard/paste-text-001-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/paste-text-001-expected.png: Removed.
              * platform/mac/editing/pasteboard/paste-text-001-expected.txt: Removed.
              * platform/mac/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/mac/editing/pasteboard/paste-text-011-expected.txt: Removed.
              * platform/qt/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/qt/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/qt/editing/pasteboard/paste-text-011-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6683441a
    • rniwa@webkit.org's avatar
      2011-04-07 Ryosuke Niwa <rniwa@webkit.org> · 04696f10
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              editing/inserting/6633727.html should be renamed and converted into a dump-as-markup test
              https://bugs.webkit.org/show_bug.cgi?id=58037
      
              Renamed 6633727.html to insert-paragraph-at-end-of-line.html and converted it to a dump-as-markup test.
      
              * editing/inserting/6633727-expected.txt: Removed.
              * editing/inserting/6633727.html: Removed.
              * editing/inserting/insert-paragraph-at-end-of-line-expected.txt: Added.
              * editing/inserting/insert-paragraph-at-end-of-line.html: Copied from LayoutTests/editing/inserting/6633727.html.
              * editing/inserting/script-tests/6633727.js: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04696f10
    • rniwa@webkit.org's avatar
      2011-04-07 Ryosuke Niwa <rniwa@webkit.org> · f2c5f86c
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Convert insert-div-021.html to a dump-as-markup test
              https://bugs.webkit.org/show_bug.cgi?id=58019
      
              Converted the test.
      
              * editing/inserting/insert-div-021-expected.txt: Added.
              * editing/inserting/insert-div-021.html:
              * platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum: Removed.
              * platform/chromium-linux/editing/inserting/insert-div-021-expected.png: Removed.
              * platform/chromium-win/editing/inserting/insert-div-021-expected.checksum: Removed.
              * platform/chromium-win/editing/inserting/insert-div-021-expected.png: Removed.
              * platform/chromium-win/editing/inserting/insert-div-021-expected.txt: Removed.
              * platform/gtk/editing/inserting/insert-div-021-expected.checksum: Removed.
              * platform/gtk/editing/inserting/insert-div-021-expected.png: Removed.
              * platform/gtk/editing/inserting/insert-div-021-expected.txt: Removed.
              * platform/mac/editing/inserting/insert-div-021-expected.checksum: Removed.
              * platform/mac/editing/inserting/insert-div-021-expected.png: Removed.
              * platform/mac/editing/inserting/insert-div-021-expected.txt: Removed.
              * platform/qt/editing/inserting/insert-div-021-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2c5f86c
  2. 06 Apr, 2011 4 commits
    • commit-queue@webkit.org's avatar
      2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com> · e2d84280
      commit-queue@webkit.org authored
              Unreviewed, rolling out r83039.
              http://trac.webkit.org/changeset/83039
              https://bugs.webkit.org/show_bug.cgi?id=57978
      
              introduced a new regression in conjunction to
              ReplaceSelectionCommand (Requested by rniwa on #webkit).
      
              * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Removed.
              * editing/inserting/insert-paragraph-separator-tab-span.html: Removed.
      2011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r83039.
              http://trac.webkit.org/changeset/83039
              https://bugs.webkit.org/show_bug.cgi?id=57978
      
              introduced a new regression in conjunction to
              ReplaceSelectionCommand (Requested by rniwa on #webkit).
      
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::init):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2d84280
    • abecsi@webkit.org's avatar
      2011-04-06 Andras Becsi <abecsi@webkit.org> · 1a762736
      abecsi@webkit.org authored
              Reviewed by Darin Adler.
      
              Invalid color #{predefined colorName} is accepted by the CSS parser.
              https://bugs.webkit.org/show_bug.cgi?id=15360
      
              * editing/execCommand/16049.html: Correct testcase which relies on parsing an invalid color value as valid.
              * fast/css/invalid-predefined-color-expected.txt: Added.
              * fast/css/invalid-predefined-color.html: Added.
              * fast/css/script-tests/invalid-predefined-color.js: Added.
      2011-04-06  Andras Becsi  <abecsi@webkit.org>
      
              Reviewed by Darin Adler.
      
              Invalid color #{predefined colorName} is accepted by the CSS parser.
              https://bugs.webkit.org/show_bug.cgi?id=15360
      
              Test: fast/css/invalid-predefined-color.html
      
              * css/CSSGrammar.y: Remove superfluous hexcolor production.
              * css/tokenizer.flex: A hexadecimal number should consist of [a-fA-F0-9] values ({h}).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a762736
    • rniwa@webkit.org's avatar
      2011-04-06 Ryosuke Niwa <rniwa@webkit.org> · 56390f67
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
              https://bugs.webkit.org/show_bug.cgi?id=57872
      
              r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
              because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.
      
              r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
              avoiding the tab span.
      
              Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
      
              Test: editing/inserting/insert-paragraph-separator-tab-span.html
      
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
              separator into a paragraph separator.
      2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
              https://bugs.webkit.org/show_bug.cgi?id=57872
      
              Added a test insert a paragraph separator and text around tab spans. WebKit should not apply the tab span's
              style to the paragraph separator or the text.
      
              * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
              * editing/inserting/insert-paragraph-separator-tab-span.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56390f67
    • commit-queue@webkit.org's avatar
      2011-04-06 Naoki Takano <takano.naoki@gmail.com> · f8b6b0dc
      commit-queue@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
              https://bugs.webkit.org/show_bug.cgi?id=57755
      
              * editing/execCommand/insert-line-break-onload-expected.txt: Added.
              * editing/execCommand/insert-line-break-onload.html: Added to check calling InsertLineBreak without any crash.
      2011-04-06  Naoki Takano  <takano.naoki@gmail.com>
      
              Reviewed by Ryosuke Niwa.
      
              REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
              https://bugs.webkit.org/show_bug.cgi?id=57755
      
              Test: editing/execCommand/insert-line-break-onload.html
      
              * editing/TypingCommand.cpp:
              (WebCore::canAppendNewLineFeed): Added null pointer check for rootEditableElement().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8b6b0dc
  3. 03 Apr, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-03-21 Ryosuke Niwa <rniwa@webkit.org> · 48291001
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              editing commands shouldn't run when there's no body
              https://bugs.webkit.org/show_bug.cgi?id=56771
      
              The bug was caused by WebKit's not checking the existence of root editable element
              in enabled* functions. Although isContentEditable returns true whenever we're in design mode,
              we should not run editing commands in a document without a body element editable because
              doing so results in appending a non-body element to the document node.
      
              Fixed the bug by modifying various enabled* functions to ensure we have a root editable element.
              New behavior tries to match that of Firefox except StyleWithCSS, which Firefox seems to ignore
              when there are no body element. Since StyleWithCSS is a document's state or property, we allow
              execCommand('StyleWithCSS') even in a document without a body element.
      
              WebKit's and Firefox's behaviors also deviate in insert-image-with-selecting-document.html.
              Whereas WebKit respects selection set by script and ignores execCommand, Firefox modifies
              the selection when document.write("x") is ran and successfully inserts image.
      
              Thus, empty-document-delete.html and empty-document-justify-right.html both pass on Firefox
              while empty-document-stylewithcss.html and insert-image-with-selecting-document.html both fail.
      
              Since Internet Explorer does not allow execCommand to run under design mode properly, we could
              not test its behavior.
      
              Tests: editing/editability/empty-document-delete.html
                     editing/editability/empty-document-justify-right.html
                     editing/editability/empty-document-stylewithcss.html
                     editing/execCommand/insert-image-with-selecting-document.html
      
              * editing/Editor.cpp:
              (WebCore::Editor::canEdit): Verify that the root editable element exists
              instead of just checking that selection endpoints are editable because
              selection endpoints could be document node without a body element in design mode
              and we don't want to consider such a document editable.
              (WebCore::Editor::canDelete): Ditto.
              * editing/EditorCommand.cpp:
              (WebCore::enabledInEditableText): Ditto.
              (WebCore::enabledInRichlyEditableText): Ditto.
              (WebCore::enabledDelete): Call enabledCut and enabledInEditableText instead
              of duplicating the code in order to fix the same bug.
      2011-03-21  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              editing commands shouldn't run when there's no body
              https://bugs.webkit.org/show_bug.cgi?id=56771
      
              Added tests to ensure WebKit does not crash when attempted to execute editing commands
              in an empty document. Also added a test to ensure WebKit does not crash when InsertImage
              is executed with selection endpoints being document. WebKit should ignore such attempts
              and should not crash.
      
              * editing/editability/empty-document-delete-expected.txt: Added.
              * editing/editability/empty-document-delete.html: Added.
              * editing/editability/empty-document-justify-right-expected.txt: Added.
              * editing/editability/empty-document-justify-right.html: Added.
              * editing/editability/empty-document-stylewithcss-expected.txt: Added.
              * editing/editability/empty-document-stylewithcss.html: Added.
              * editing/execCommand/insert-image-with-selecting-document-expected.txt: Added.
              * editing/execCommand/insert-image-with-selecting-document.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48291001
  4. 01 Apr, 2011 1 commit
    • darin@apple.com's avatar
      Removed some more executable bits from files that don't need them. · ee320df0
      darin@apple.com authored
      These often creep in when someone is working on Windows, which uses
      executable bits differently from Unix systems.
      
      * editing/execCommand/align-in-span.html: Removed property svn:executable.
      * editing/selection/extend-byline-withfloat.html: Removed property svn:executable.
      * fast/canvas/webgl/data-view-test.html: Removed property svn:executable.
      * fast/canvas/webgl/resources/gray-ramp-default-gamma.png: Removed property svn:executable.
      * fast/canvas/webgl/resources/gray-ramp-gamma0.1.png: Removed property svn:executable.
      * fast/canvas/webgl/resources/gray-ramp-gamma1.0.png: Removed property svn:executable.
      * fast/canvas/webgl/resources/gray-ramp-gamma2.0.png: Removed property svn:executable.
      * fast/canvas/webgl/resources/gray-ramp-gamma4.0.png: Removed property svn:executable.
      * fast/canvas/webgl/resources/gray-ramp-gamma9.0.png: Removed property svn:executable.
      * fast/canvas/webgl/resources/gray-ramp.png: Removed property svn:executable.
      * fast/canvas/webgl/resources/zero-alpha.png: Removed property svn:executable.
      * fast/css/inline-element-line-break.html: Removed property svn:executable.
      * fast/css/pseudo-element-line-break.html: Removed property svn:executable.
      * fast/dom/HTMLScriptElement/async-inline-script-expected.txt: Removed property svn:executable.
      * fast/dom/HTMLScriptElement/async-onbeforeload-expected.txt: Removed property svn:executable.
      * fast/dom/HTMLScriptElement/async-write-expected.txt: Removed property svn:executable.
      * fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Removed property svn:executable.
      * fast/events/before-unload-remove-and-add-subframe.html: Removed property svn:executable.
      * fast/events/change-frame-focus.html: Removed property svn:executable.
      * fast/files/resources/binary-file: Removed property svn:executable.
      * fast/frames/iframe-reparenting.html: Removed property svn:executable.
      * fast/frames/resources/iframe-reparenting-frame1.html: Removed property svn:executable.
      * fast/frames/resources/iframe-reparenting-frame2.html: Removed property svn:executable.
      * fast/frames/resources/iframe-reparenting-iframe-content.html: Removed property svn:executable.
      * fast/harness/resources/cached-page-1.html: Removed property svn:executable.
      * fast/harness/resources/cached-page-2.html: Removed property svn:executable.
      * fast/harness/use-page-cache.html: Removed property svn:executable.
      * fast/history/same-document-iframes-changing-fragment-expected.txt: Removed property svn:executable.
      * fast/history/same-document-iframes-changing-fragment.html: Removed property svn:executable.
      * fast/history/same-document-iframes-changing-pushstate-expected.txt: Removed property svn:executable.
      * fast/history/same-document-iframes-changing-pushstate.html: Removed property svn:executable.
      * fast/images/resources/cmyk-jpeg.jpg: Removed property svn:executable.
      * fast/inline/inline-position-top-align.html: Removed property svn:executable.
      * fast/inline/resources/gradient.png: Removed property svn:executable.
      * fast/js/script-tests/toInt32UInt32.js: Removed property svn:executable.
      * fast/lists/resources/dump-list.js: Removed property svn:executable.
      * fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed property svn:executable.
      * fast/lists/w3-css3-list-styles-alphabetic.html: Removed property svn:executable.
      * fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed property svn:executable.
      * fast/lists/w3-css3-list-styles-numeric.html: Removed property svn:executable.
      * fast/parser/remove-misnested-iframe-in-beforeload-expected.txt: Removed property svn:executable.
      * fast/parser/remove-misnested-iframe-parent-in-beforeload-expected.txt: Removed property svn:executable.
      * fast/parser/x-frame-options-detached-document-crash-expected.txt: Removed property svn:executable.
      * fast/regex/script-tests/ecma-regex-examples.js: Removed property svn:executable.
      * fast/repaint/canvas-putImageData-expected.txt: Removed property svn:executable.
      * fast/repaint/canvas-putImageData.html: Removed property svn:executable.
      * http/tests/history/redirect-302.html: Removed property svn:executable.
      * http/tests/history/redirect-303.html: Removed property svn:executable.
      * http/tests/history/redirect-307.html: Removed property svn:executable.
      * http/tests/inspector/console-test.js: Removed property svn:executable.
      * http/tests/inspector/console-xhr-logging.html: Removed property svn:executable.
      * http/tests/inspector/elements-test.js: Removed property svn:executable.
      * http/tests/inspector/extensions-resources-redirect.html: Removed property svn:executable.
      * http/tests/inspector/extensions-resources-test.js: Removed property svn:executable.
      * http/tests/inspector/network-preflight-options.html: Removed property svn:executable.
      * http/tests/inspector/network/network-size-chunked.html: Removed property svn:executable.
      * http/tests/inspector/resource-parameters.html: Removed property svn:executable.
      * http/tests/inspector/resources-test.js: Removed property svn:executable.
      * http/tests/inspector/resources/iframe-from-different-domain-data.html: Removed property svn:executable.
      * http/tests/inspector/resources/resource-form-data-receiver-iframe.html: Removed property svn:executable.
      * http/tests/misc/async-and-defer-script-expected.txt: Removed property svn:executable.
      * http/tests/misc/script-async-expected.txt: Removed property svn:executable.
      * http/tests/security/cross-origin-script-window-onerror-redirected.html: Removed property svn:executable.
      * http/tests/security/cross-origin-script-window-onerror.html: Removed property svn:executable.
      * http/tests/security/resources/cross-origin-script.txt: Removed property svn:executable.
      * inspector/audits/audits-test.js: Removed property svn:executable.
      * inspector/audits/resources/abe.png: Removed property svn:executable.
      * inspector/audits/resources/audits-script1.js: Removed property svn:executable.
      * inspector/audits/resources/audits-script2.js: Removed property svn:executable.
      * inspector/audits/resources/audits-style1.css: Removed property svn:executable.
      * inspector/console/console-assert.html: Removed property svn:executable.
      * inspector/console/console-dir.html: Removed property svn:executable.
      * inspector/console/console-dirxml.html: Removed property svn:executable.
      * inspector/console/console-format.html: Removed property svn:executable.
      * inspector/console/console-log-syntax-error.html: Removed property svn:executable.
      * inspector/console/console-nested-group.html: Removed property svn:executable.
      * inspector/console/console-substituted.html: Removed property svn:executable.
      * inspector/console/console-tests.html: Removed property svn:executable.
      * inspector/console/console-trace-in-eval.html: Removed property svn:executable.
      * inspector/console/console-trace.html: Removed property svn:executable.
      * inspector/console/console-uncaught-exception-in-eval.html: Removed property svn:executable.
      * inspector/console/console-uncaught-exception.html: Removed property svn:executable.
      * inspector/cookie-parser.html: Removed property svn:executable.
      * inspector/debugger/debugger-cyclic-ref.html: Removed property svn:executable.
      * inspector/debugger/debugger-expand-scope.html: Removed property svn:executable.
      * inspector/elements/elements-delete-inline-style-expected.txt: Removed property svn:executable.
      * inspector/elements/elements-delete-inline-style.html: Removed property svn:executable.
      * inspector/elements/elements-panel-search.html: Removed property svn:executable.
      * inspector/elements/elements-panel-structure.html: Removed property svn:executable.
      * inspector/evaluate-in-page.html: Removed property svn:executable.
      * inspector/extensions/extensions-audits-api.html: Removed property svn:executable.
      * inspector/extensions/extensions-audits.html: Removed property svn:executable.
      * inspector/extensions/extensions-eval.html: Removed property svn:executable.
      * inspector/extensions/extensions-events.html: Removed property svn:executable.
      * inspector/extensions/extensions-resources.html: Removed property svn:executable.
      * inspector/extensions/resources/abe.png: Removed property svn:executable.
      * inspector/extensions/resources/audits-style1.css: Removed property svn:executable.
      * inspector/styles/resources/styles-iframe-data.html: Removed property svn:executable.
      * inspector/styles/resources/styles-new-API-1.css: Removed property svn:executable.
      * inspector/styles/resources/styles-url-linkify-iframe.html: Removed property svn:executable.
      * inspector/styles/resources/styles-url-linkify.css: Removed property svn:executable.
      * inspector/styles/styles-disable-then-change-expected.txt: Removed property svn:executable.
      * inspector/styles/styles-disable-then-change.html: Removed property svn:executable.
      * inspector/styles/styles-iframe.html: Removed property svn:executable.
      * inspector/styles/styles-source-lines.html: Removed property svn:executable.
      * inspector/styles/styles-update-from-js-expected.txt: Removed property svn:executable.
      * inspector/styles/styles-update-from-js.html: Removed property svn:executable.
      * inspector/styles/styles-url-linkify.html: Removed property svn:executable.
      * inspector/utilities.html: Removed property svn:executable.
      * platform/chromium-linux/editing/deleting/delete-br-013-expected.checksum: Removed property svn:executable.
      * platform/chromium-linux/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Removed property svn:executable.
      * platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.checksum: Removed property svn:executable.
      * platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.png: Removed property svn:executable.
      * platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.txt: Removed property svn:executable.
      * platform/chromium-linux/fast/clip/overflow-border-radius-clip-expected.checksum: Removed property svn:executable.
      * platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.png: Removed property svn:executable.
      * platform/chromium-linux/fast/repaint/block-no-inflow-children-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/css1/text_properties/text_align-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/css1/text_properties/text_align-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/editing/selection/4397952-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/editing/selection/4397952-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.txt: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/text-security-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/css/text-security-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/dynamic/008-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/dynamic/008-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/basic-selects-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/basic-selects-expected.txt: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/button-sizes-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/button-sizes-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.txt: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/search-transformed-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/html/keygen-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/html/keygen-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.txt: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/fonts/sans-serif-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/fonts/sans-serif-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.png: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.png: Removed property svn:executable.
      * platform/chromium-mac/fast/repaint/block-no-inflow-children-expected.checksum: Removed property svn:executable.
      * platform/chromium-mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Removed property svn:executable.
      * platform/chromium-win/editing/deleting/delete-br-013-expected.checksum: Removed property svn:executable.
      * platform/chromium-win/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Removed property svn:executable.
      * platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum: Removed property svn:executable.
      * platform/chromium-win/editing/selection/range-between-block-and-inline-expected.checksum: Removed property svn:executable.
      * platform/chromium-win/editing/selection/range-between-block-and-inline-expected.png: Removed property svn:executable.
      * platform/chromium-win/editing/selection/range-between-block-and-inline-expected.txt: Removed property svn:executable.
      * platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.checksum: Removed property svn:executable.
      * platform/chromium-win/fast/repaint/block-no-inflow-children-expected.checksum: Removed property svn:executable.
      * platform/chromium-win/fast/repaint/block-no-inflow-children-expected.txt: Removed property svn:executable.
      * platform/chromium-win/fast/repaint/canvas-putImageData-expected.checksum: Removed property svn:executable.
      * platform/chromium-win/fast/repaint/canvas-putImageData-expected.png: Removed property svn:executable.
      * platform/chromium-win/platform/mac/fast/forms/input-list-button-size-expected.checksum: Removed property svn:executable.
      * platform/chromium-win/platform/qt/fast/events/event-sender-keydown-frame-expected.checksum: Removed property svn:executable.
      * platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Removed property svn:executable.
      * platform/chromium/compositing/layout-width-change.html: Removed property svn:executable.
      * platform/chromium/html5lib/runner-expected.txt: Removed property svn:executable.
      * platform/chromium/inspector/console/console-eval-global-expected.txt: Removed property svn:executable.
      * platform/chromium/inspector/console/console-object-constructor-name-expected.txt: Removed property svn:executable.
      * platform/chromium/inspector/console/console-trace-in-eval-expected.txt: Removed property svn:executable.
      * platform/chromium/inspector/console/console-uncaught-exception-expected.txt: Removed property svn:executable.
      * platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt: Removed property svn:executable.
      * platform/chromium/inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt: Removed property svn:executable.
      * platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt: Removed property svn:executable.
      * platform/chromium/test_expectations.txt: Removed property svn:executable.
      * platform/mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Removed property svn:executable.
      * platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed property svn:executable.
      * platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.png: Removed property svn:executable.
      * platform/mac-leopard/editing/selection/caret-rtl-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/editing/selection/caret-rtl-expected.png: Removed property svn:executable.
      * platform/mac-leopard/editing/selection/caret-rtl-right-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/editing/selection/caret-rtl-right-expected.png: Removed property svn:executable.
      * platform/mac-leopard/fast/forms/text-style-color-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/fast/forms/text-style-color-expected.png: Removed property svn:executable.
      * platform/mac-leopard/fast/inline/inline-box-background-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/fast/inline/inline-box-background-expected.png: Removed property svn:executable.
      * platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png: Removed property svn:executable.
      * platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png: Removed property svn:executable.
      * platform/mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/fast/multicol/shadow-breaking-expected.png: Removed property svn:executable.
      * platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.png: Removed property svn:executable.
      * platform/mac-leopard/fast/text/atsui-spacing-features-expected.checksum: Removed property svn:executable.
      * platform/mac-leopard/fast/text/atsui-spacing-features-expected.png: Removed property svn:executable.
      * platform/mac/fast/css/focus-ring-outline-color-expected.checksum: Removed property svn:executable.
      * platform/mac/fast/css/focus-ring-outline-color-expected.png: Removed property svn:executable.
      * platform/mac/fast/css/focus-ring-outline-color-expected.txt: Removed property svn:executable.
      * platform/mac/fast/css/focus-ring-outline-offset-expected.checksum: Removed property svn:executable.
      * platform/mac/fast/css/focus-ring-outline-offset-expected.png: Removed property svn:executable.
      * platform/mac/fast/css/focus-ring-outline-offset-expected.txt: Removed property svn:executable.
      * platform/mac/fast/css/focus-ring-outline-width-expected.checksum: Removed property svn:executable.
      * platform/mac/fast/css/focus-ring-outline-width-expected.png: Removed property svn:executable.
      * platform/mac/fast/css/focus-ring-outline-width-expected.txt: Removed property svn:executable.
      * platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed property svn:executable.
      * platform/win-xp/transforms/2d/hindi-rotated-expected.checksum: Removed property svn:executable.
      * platform/win-xp/transforms/2d/hindi-rotated-expected.png: Removed property svn:executable.
      * platform/win-xp/transforms/2d/hindi-rotated-expected.txt: Removed property svn:executable.
      * platform/win/accessibility/text-role-expected.txt: Removed property svn:executable.
      * platform/win/accessibility/text-role.html: Removed property svn:executable.
      * platform/win/fast/events/panScroll-nested-divs.html: Removed property svn:executable.
      * svg/custom/animate-use-crash.xhtml: Removed property svn:executable.
      * svg/filters/feColorMatrix-offset.svg: Removed property svn:executable.
      * transforms/2d/hindi-rotated.html: Removed property svn:executable.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee320df0
  5. 31 Mar, 2011 2 commits
    • xji@chromium.org's avatar
      2011-03-30 Xiaomei Ji <xji@chromium.org> · 429dd21b
      xji@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Experiment with moving caret by word in visual order.
              https://bugs.webkit.org/show_bug.cgi?id=57336
      
              * editing/selection/move-by-word-visually-expected.txt: Added.
              * editing/selection/move-by-word-visually.html: Added.
      2011-03-30  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Experiment with moving caret by word in visual order.
              https://bugs.webkit.org/show_bug.cgi?id=57336
      
              Follow Firefox's convention in Windows, 
              In LTR block, word break visually moves cursor to the left boundary of words,
              In RTL block, word break visually moves cursor to the right boundary of words.
      
              This is the 1st version of implementing "move caret by word in visual order".
              It only works in the following situation:
              1. For a LTR box in a LTR block or a RTL box in RTL block, 
              when caret is at the left boundary of the box and we are looking for 
              the word boundary in right.
              2. For a LTR or RTL box in a LTR block, when caret is at the left boundary
              of the box and we are looking for the word boundary in left and 
              previous box is a LTR box.
              3. For a LTR or RTL box in a RTL block, when the caret is at the right 
              boundary of the box and we are looking for the word boundary in right and next box is RTL box.
      
              An experimental granularity is introduced, as a side effect, functions having switch statements
              to handle those granularities have to add more one case to handle this new granularity.
              The experimental granularity is exposed though JS by '-webkit-visual-word".
      
              The overall algorithm is looping through inline boxes visually and looking
              for the visually nearest word break position. 
      
              Test: editing/selection/move-by-word-visually.html
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingRight):
              (WebCore::SelectionController::modifyExtendingForward):
              (WebCore::SelectionController::modifyMovingRight):
              (WebCore::SelectionController::modifyMovingForward):
              (WebCore::SelectionController::modifyExtendingLeft):
              (WebCore::SelectionController::modifyExtendingBackward):
              (WebCore::SelectionController::modifyMovingLeft):
              (WebCore::SelectionController::modifyMovingBackward):
              * editing/TextGranularity.h:
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
              * editing/visible_units.cpp:
              (WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
              (WebCore::wordBoundaryInBox):
              (WebCore::wordBoundaryInAdjacentBoxes):
              (WebCore::leftWordBoundary):
              (WebCore::rightWordBoundary):
              (WebCore::leftWordPosition):
              (WebCore::rightWordPosition):
              * editing/visible_units.h:
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::modify):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      429dd21b
    • kalman@chromium.org's avatar
      2011-03-31 Benjamin Kalman <kalman@chromium.org> · 4cb651d7
      kalman@chromium.org authored
              Reviewed by Ojan Vafai.
      
              DeleteSelectionCommand::removeNode tries to insert block placeholder in non-editable table cell positions
              https://bugs.webkit.org/show_bug.cgi?id=57079
      
              Add regression test.
      
              * editing/execCommand/delete-table-with-empty-contents-expected.txt: Added.
              * editing/execCommand/delete-table-with-empty-contents.html: Added.
      2011-03-31  Benjamin Kalman  <kalman@chromium.org>
      
              Reviewed by Ojan Vafai.
      
              DeleteSelectionCommand::removeNode tries to insert block placeholder in non-editable table cell positions
              https://bugs.webkit.org/show_bug.cgi?id=57079
      
              Test: editing/execCommand/delete-table-with-empty-contents.html
      
              This bug results in an ASSERT fail in CompositeEditCommand::insertNodeAt, so is only observable in debug builds
              of WebKit.
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::firstEditablePositionInNode):
              (WebCore::DeleteSelectionCommand::removeNode): Use firstEditablePositionInNode rather than firstPositionInNode
              to find anchor node for the placeholder's position, if any.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cb651d7
  6. 30 Mar, 2011 4 commits
    • mitz@apple.com's avatar
      <rdar://problem/9199518> Crash when focusing a styled editable element · 23a4e377
      mitz@apple.com authored
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Test: editing/deleting/delete-button-background-image-none.html
      
      * editing/DeleteButtonController.cpp:
      (WebCore::isDeletableElement): Check all background layers for background images.
      * rendering/style/RenderStyle.h: Removed backgroundImage() as it was only used, incorrectly,
      in the above function.
      
      LayoutTests: 
      
      * editing/deleting/delete-button-background-image-none-expected.txt: Added.
      * editing/deleting/delete-button-background-image-none.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23a4e377
    • inferno@chromium.org's avatar
      2011-03-30 Abhishek Arya <inferno@chromium.org> · 2da9b7ad
      inferno@chromium.org authored
              Reviewed by Simon Fraser.
      
              Tests that we do not crash when removing inline style
              from a node that is not a html element.
              https://bugs.webkit.org/show_bug.cgi?id=57348
      
              * editing/execCommand/remove-format-non-html-element-crash-expected.txt: Added.
              * editing/execCommand/remove-format-non-html-element-crash.html: Added.
      2011-03-30  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Fix wrong type assumptions in editing code. Move code
              from ASSERTs to hard checks.
              https://bugs.webkit.org/show_bug.cgi?id=57348
      
              Test: editing/execCommand/remove-format-non-html-element-crash.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::getRGBAFontColor):
              (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
              * editing/DeleteButtonController.cpp:
              (WebCore::enclosingDeletableElement):
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::textDirection):
              (WebCore::EditingStyle::prepareToApplyAt):
              * editing/Editor.cpp:
              (WebCore::Editor::textDirectionForSelection):
              * editing/FormatBlockCommand.cpp:
              (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2da9b7ad
    • leviw@chromium.org's avatar
      2011-03-30 Levi Weintraub <leviw@chromium.org> · 42ccdc9e
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Clicking below last line of right-to-left editable text that puts caret in the wrong place
              https://bugs.webkit.org/show_bug.cgi?id=38087
      
              Moving getLogical[Start/End]BoxWithNode to RootInlineBox and using it in positionForPointWithInlineChildren
              instead of lastLeafChild, which wasn't correct in the RTL case.
      
              Test: editing/selection/click-below-rtl-text.html
      
              * editing/visible_units.cpp:
              (WebCore::logicalStartPositionForLine): Moved to RootInlineBox.
              (WebCore::logicalEndPositionForLine): Ditto.
              * editing/visible_units.h:
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::positionForPointWithInlineChildren): Useing getLogicalEndBoxWithNode instead
              of lastLeafChild.
              * rendering/RootInlineBox.cpp:
              (WebCore::RootInlineBox::getLogicalStartBoxWithNode): Moved and refactored.
              (WebCore::RootInlineBox::getLogicalEndBoxWithNode): Ditto.
              * rendering/RootInlineBox.h:
      2011-03-30  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Clicking below last line of right-to-left editable text that puts caret in the wrong place
              https://bugs.webkit.org/show_bug.cgi?id=38087
      
              Doing the right thing when clicking below the last line box in RTL editable content.
      
              * editing/selection/click-below-rtl-text-expected.txt: Added.
              * editing/selection/click-below-rtl-text.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42ccdc9e
    • leviw@chromium.org's avatar
      2011-03-30 Levi Weintraub <leviw@chromium.org> · 6d74acca
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              BreakBlockQuoteCommand assumes all li tags have list item renderers
              https://bugs.webkit.org/show_bug.cgi?id=57253
      
              Checking that the renderers of li nodes are actually RenderListItems
              before treating them as such.
      
              * editing/execCommand/crash-breaking-blockquote-with-list.html: Added.
              * editing/execCommand/crash-breaking-blockquote-with-list-expected.txt: Added.
      2011-03-30  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              BreakBlockQuoteCommand assumes all li tags have list item renderers
              https://bugs.webkit.org/show_bug.cgi?id=57253
      
              Checking that the renderers of li nodes are actually RenderListItems
              before treating them as such.
      
              Test: editing/execCommand/crash-breaking-blockquote-with-list.html
      
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockQuoteCommand::doApply):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d74acca
  7. 29 Mar, 2011 1 commit
  8. 28 Mar, 2011 1 commit
    • adele@apple.com's avatar
      Source/WebCore: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check... · aeeb7f1e
      adele@apple.com authored
      Source/WebCore: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
      https://bugs.webkit.org/show_bug.cgi?id=57173
      
      Reviewed by Eric Seidel.
      
      Test: editing/spelling/grammar.html
      
      * WebCore.exp.in: Add symbol for new selectionStartHasMarkerFor method.
      * editing/Editor.cpp:
      (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Every use of paragraph is specific to spelling or grammar, 
       so to avoid confusion, we should explicitly use spellingParagraph or grammarParagraph.  In the case of this bug, 
       when we're consider ambiguous boundary characters (characters that could indicate word boundaries, but are used 
       in the middle of words too, like apostrophes), we should use the use the spellingParagraph since the spellingParagraph 
       is the only one operated on when this information is used.
       (WebCore::Editor::selectionStartHasMarkerFor): Changed from selectionStartHasSpellingMarkerFor so it can check for grammar as well as spelling.
      * editing/Editor.h:
      
      Source/WebKit/mac: Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
      https://bugs.webkit.org/show_bug.cgi?id=57173
      
      Reviewed by Eric Seidel.
      
      * WebView/WebFrame.mm:
      (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
      (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
      * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
      
      Tools: Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
      https://bugs.webkit.org/show_bug.cgi?id=57173
      
      Reviewed by Eric Seidel.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (hasGrammarMarkerCallback): Added.
      (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
      * DumpRenderTree/LayoutTestController.h:
      * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
      * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
      
      LayoutTests: Test for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
      https://bugs.webkit.org/show_bug.cgi?id=57173
      
      Reviewed by Eric Seidel.
      
      * editing/spelling/grammar-expected.txt: Added.
      * editing/spelling/grammar.html: Added.
      * platform/gtk/Skipped:
      * platform/mac-wk2/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aeeb7f1e
  9. 24 Mar, 2011 2 commits
    • enrica@apple.com's avatar
      Source/WebCore: Repeated copy and paste-in-place operation results in increasingly verbose HTML. · f8d20922
      enrica@apple.com authored
      <rdar://problem/8690506>
      https://bugs.webkit.org/show_bug.cgi?id=56874
              
      Reviewed by Darin Adler.
      
      When we calculate the style to apply at the insertion point we compare the initial
      style at the insertion point against the style calculated at the span we wrap the
      copied markup fragment with. We could end up with a series of unnecessary spans
      to remove the initial style that simply grow our markup.
      The consists in moving the insertion point outside any inline element that could
      affect the fragment being inserted when we are not pasting and matching the style.
      
      Test: editing/pasteboard/paste-text-with-style.html
      
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::isInlineNodeWithStyle): Added.
      (WebCore::ReplaceSelectionCommand::doApply): Added logic to change the insertion
      point according to the new rules.
      
      LayoutTests: Repeated copy and paste-in-place operation results in increasingly verbose HTML.
      <rdar://problem/8690506>
      https://bugs.webkit.org/show_bug.cgi?id=56874
      
      Reviewed by Darin Adler.
      
      * editing/pasteboard/paste-text-with-style-expected.txt: Added.
      * editing/pasteboard/paste-text-with-style.html: Added.
      The following are new results for existing tests that now produce
      a different markup.
      * platform/mac/editing/pasteboard/5065605-expected.txt:
      * platform/mac/editing/pasteboard/display-block-on-spans-expected.txt:
      * platform/mac/editing/pasteboard/paste-text-011-expected.txt:
      * platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
      * platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8d20922
    • philn@webkit.org's avatar
      2011-03-24 Philippe Normand <pnormand@igalia.com> · e75e7eb1
      philn@webkit.org authored
              Unreviewed, new GTK fast/block/lineboxcontain baselines after
              r81684 and r81608.
      
              * editing/selection/fake-drag-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/block-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/block-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/block-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/block-font-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/block-font-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/block-font-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/block-replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/block-replaced-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/font-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/font-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/font-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/font-replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/font-replaced-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/glyphs-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/glyphs-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/glyphs-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-replaced-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-replaced-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/none-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/none-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/none-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/replaced-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e75e7eb1
  10. 21 Mar, 2011 3 commits
    • dcheng@chromium.org's avatar
      2011-03-21 Daniel Cheng <dcheng@chromium.org> · d2bab328
      dcheng@chromium.org authored
              Reviewed by Tony Chang.
      
              Remove dependency on default font from data-transfer-items.html
              https://bugs.webkit.org/show_bug.cgi?id=56791
      
              * editing/pasteboard/data-transfer-items-expected.txt:
              * editing/pasteboard/data-transfer-items.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2bab328
    • dcheng@chromium.org's avatar
      2011-03-21 Daniel Cheng <dcheng@chromium.org> · 1064f047
      dcheng@chromium.org authored
              Reviewed by Tony Chang.
      
              [chromium] Implement glue between DataTransferItems and the pasteboard.
              https://bugs.webkit.org/show_bug.cgi?id=56330
      
              Update the layout test to take into account that the actual contents of the clipboard
              are exposed in a paste via DataTransferItems now.
              Also fix the flakiness in the layout test.
      
              * editing/pasteboard/data-transfer-items-expected.txt:
              * editing/pasteboard/data-transfer-items.html:
              * platform/chromium/test_expectations.txt:
      2011-03-21  Daniel Cheng  <dcheng@chromium.org>
      
              Reviewed by Tony Chang.
      
              [chromium] Implement glue between DataTransferItems and the pasteboard.
              https://bugs.webkit.org/show_bug.cgi?id=56330
      
              Support retrieving clipboard data in a paste through DataTransferItems.
      
              Test: editing/pasteboard/data-transfer-items.html
      
              * platform/chromium/ClipboardChromium.cpp:
              (WebCore::ClipboardChromium::items):
              * platform/chromium/DataTransferItemChromium.cpp:
              (WebCore::DataTransferItemChromium::createFromPasteboard):
              (WebCore::DataTransferItemChromium::create):
              (WebCore::DataTransferItemChromium::DataTransferItemChromium):
              (WebCore::DataTransferItemChromium::getAsString):
              * platform/chromium/DataTransferItemChromium.h:
              * platform/chromium/DataTransferItemsChromium.cpp:
              (WebCore::DataTransferItemsChromium::addPasteboardItem):
              * platform/chromium/DataTransferItemsChromium.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1064f047
    • tony@chromium.org's avatar
      2011-03-21 Tony Chang <tony@chromium.org> · fd0810d8
      tony@chromium.org authored
              Reviewed by Eric Seidel.
      
              Convert fake-drag into a dumpAsText test and remove 1s timeout
              https://bugs.webkit.org/show_bug.cgi?id=56674
      
              This test was added with eventSender, so there was no leapForward
              at the time.  Also convert to dumpAsText while I'm here.
      
              * editing/selection/fake-drag.html:
              * platform/chromium-linux/editing/selection/fake-drag-expected.checksum: Removed.
              * platform/chromium-linux/editing/selection/fake-drag-expected.png: Removed.
              * platform/chromium-win/editing/selection/fake-drag-expected.checksum: Removed.
              * platform/chromium-win/editing/selection/fake-drag-expected.png: Removed.
              * platform/chromium-win/editing/selection/fake-drag-expected.txt:
              * platform/gtk/editing/selection/fake-drag-expected.checksum: Removed.
              * platform/gtk/editing/selection/fake-drag-expected.png: Removed.
              * platform/gtk/editing/selection/fake-drag-expected.txt: Removed.
              * platform/mac-leopard/editing/selection/fake-drag-expected.checksum: Removed.
              * platform/mac-leopard/editing/selection/fake-drag-expected.png: Removed.
              * platform/mac/editing/selection/fake-drag-expected.checksum: Removed.
              * platform/mac/editing/selection/fake-drag-expected.png: Removed.
              * platform/mac/editing/selection/fake-drag-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd0810d8
  11. 18 Mar, 2011 2 commits
  12. 17 Mar, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-03-17 Ryosuke Niwa <rniwa@webkit.org> · c986a805
      rniwa@webkit.org authored
              Reviewed by Justin Garcia.
      
              Assert that editing does not ignore position's anchorNode if position is an offset in anchor
              https://bugs.webkit.org/show_bug.cgi?id=56027
      
              Added a test to ensure WebKit lets users edit contents inside a button element properly.
      
              * editing/execCommand/button-expected.txt: Added.
              * editing/execCommand/button.html: Added.
      2011-03-17  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Justin Garcia.
      
              Assert that editing does not ignore position's anchorNode if position is an offset in anchor
              https://bugs.webkit.org/show_bug.cgi?id=56027
      
              Added the assertion in Position::Position and Position::moveToPosition. This assertion catches
              places where we instantiate positions inside a node on which editingIgnoresContent returns true.
      
              Test: editing/execCommand/button.html
      
              * dom/Position.cpp:
              (WebCore::Position::Position): Added an assertion.
              (WebCore::Position::moveToPosition): Ditto.
              * dom/PositionIterator.cpp:
              (WebCore::PositionIterator::operator Position): Avoid creating a position immediately below
              a node whose content is ignored by editing. While this does not avoid creation of positions
              inside ignored contents completely, it works in most cases. Filed the bug 56027 to resolve
              the underlying problem. Without this change, the assertion hits in existing layout tests.
              cannot be tested directly.
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Call firstPositionInOrBeforeNode
              instead of firstPositionInNode because startNode may as well be a br element. Without this change,
              the assertion hits in existing layout tests.
              * editing/htmlediting.cpp:
              (WebCore::canHaveChildrenForEditing): button is editable so content is not ignored. Added a test
              for this.
              * editing/visible_units.cpp:
              (WebCore::previousBoundary): Added a FIXME.
              (WebCore::startPositionForLine): Because br can also have an inline text box, checking that
              startBox is an inline text box isn't an adequate to instantiate a position inside startNode.
              Call startNode->isTextNode() instead. Without this change, the assertion hits in existing layout
              tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c986a805
  13. 16 Mar, 2011 3 commits
    • rniwa@webkit.org's avatar
      2011-03-16 Ryosuke Niwa <rniwa@webkit.org> · 24bd1d35
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              Get rid of nearestMailBlockquote
              https://bugs.webkit.org/show_bug.cgi?id=56439
      
              Removed nearestMailBlockquote and replaced the calls to the function by calls
              to enclosingNodeOfType and highestEnclosingNodeOfType.
              
              Also fixed a bug in BreakBlockquoteCommand and DeleteSelectionCommand not to
              respect editing boundaries.  Added a test for the former command.
      
              Test: editing/execCommand/break-non-editable-blockquote.html
      
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply): No longer crosses editing boundary
              when looking for a Mail blockquote.
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::saveTypingStyleState): Ditto.
              (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::hasMatchingQuoteLevel):
              (WebCore::handleStyleSpansBeforeInsertion):
              (WebCore::ReplaceSelectionCommand::handleStyleSpans):
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/htmlediting.cpp:
              (WebCore::enclosingNodeOfType): Check rule upfront to improve the performance.
              (WebCore::highestEnclosingNodeOfType): Ditto; also add the missing check.
              * editing/htmlediting.h:
              (WebCore::firstPositionInOrBeforeNode): Added a null pointer check.
              (WebCore::lastPositionInOrAfterNode): Ditto.
              * editing/markup.cpp:
              (WebCore::highestAncestorToWrapMarkup):
              (WebCore::createMarkup):
      2011-03-16  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Tony Chang.
      
              Get rid of nearestMailBlockquote
              https://bugs.webkit.org/show_bug.cgi?id=56439
      
              Added a test to ensure WebKi doesn't crash when inserting newline in quoted contents,
              which is enclosed by a non-editable blockquote.
      
              * editing/execCommand/break-non-editable-blockquote-expected.txt: Added.
              * editing/execCommand/break-non-editable-blockquote.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24bd1d35
    • rniwa@webkit.org's avatar
      2011-03-16 Ryosuke Niwa <rniwa@webkit.org> · 8773632d
      rniwa@webkit.org authored
              Build fix for r81266. "expected" should appear after "mac", "unix", and "win" not before them.
      
              * editing/style/iframe-onload-crash-expected-mac.txt: Removed.
              * editing/style/iframe-onload-crash-expected-unix.txt: Removed.
              * editing/style/iframe-onload-crash-expected-win.txt: Removed.
              * editing/style/iframe-onload-crash-mac-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-mac.txt.
              * editing/style/iframe-onload-crash-unix-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-unix.txt.
              * editing/style/iframe-onload-crash-win-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-win.txt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8773632d
    • leviw@chromium.org's avatar
      2011-03-16 Levi Weintraub <leviw@chromium.org> · 14f546d2
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
              https://bugs.webkit.org/show_bug.cgi?id=56407
      
              Creating three versions of the iframe-onload-crash test to cover all editing behaviors.
      
              * editing/style/iframe-onload-crash-expected-mac.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
              * editing/style/iframe-onload-crash-expected-unix.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
              * editing/style/iframe-onload-crash-expected-win.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
              * editing/style/iframe-onload-crash-expected.txt: Removed.
              * editing/style/iframe-onload-crash-mac.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
              * editing/style/iframe-onload-crash-unix.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
              * editing/style/iframe-onload-crash-win.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
              * editing/style/iframe-onload-crash.html: Removed.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/win/Skipped:
      2011-03-15  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
              https://bugs.webkit.org/show_bug.cgi?id=56407
      
              Fixing the creation of incorrect ranges from TextIterator due to passing node/offset pairs that
              weren't parent-anchored. Also changing canHaveChildrenForEditing to properly handle nodes that
              have had children appended to them that editing wouldn't normally allow.
      
              Tests: editing/style/iframe-onload-crash-mac.html
                     editing/style/iframe-onload-crash-unix.html
                     editing/style/iframe-onload-crash-win.html
      
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::rangeFromLocationAndLength): Passing parent-anchored values to range.
              * editing/htmlediting.cpp:
              (WebCore::canHaveChildrenForEditing): Adding a condition that the nodes don't already have children
              for hr and datagrid, as you can append any node to another using javascript.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14f546d2
  14. 15 Mar, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-03-15 Ryosuke Niwa <rniwa@webkit.org> · 09f6e739
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              Crash in ReplaceSelectionCommand::doApply when inserting a node under a document node
              https://bugs.webkit.org/show_bug.cgi?id=56372
      
              The bug was caused by insertNodeAfter's calling parentElement on document's child.
              Fixed this by changing the node that AppendNodeCommand takes.
      
              There was also a bug that document node always returned false for isContentEditable
              and isContentRichlyEditable because they never overrode Node's default implementation.
              Fixed this by overriding them in Document.
      
              Test: editing/execCommand/append-node-under-document.html
      
              * dom/Document.cpp:
              (WebCore::Document::isContentEditable): Added.
              (WebCore::Document::isContentRichlyEditable): Added.
              * dom/Document.h:
              * editing/AppendNodeCommand.cpp:
              (WebCore::AppendNodeCommand::AppendNodeCommand): Takes ContainerNode instead of Element.
              * editing/AppendNodeCommand.h:
              (WebCore::AppendNodeCommand::create): Ditto.
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::appendNode): Ditto.
              (WebCore::CompositeEditCommand::insertNodeAfter): Calls parentNode instead of parentElement.
              * editing/CompositeEditCommand.h:
      2011-03-15  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Tony Chang.
      
              Crash in ReplaceSelectionCommand::doApply when inserting a node under a document node
              https://bugs.webkit.org/show_bug.cgi?id=56372
      
              Added a test to ensure WebKit does not crash when appending a node to a document
              that has only two nested iframes.
      
              * editing/execCommand/append-node-under-document-expected.txt: Added.
              * editing/execCommand/append-node-under-document.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09f6e739
  15. 14 Mar, 2011 4 commits
    • morrita@google.com's avatar
      2011-03-13 MORITA Hajime <morrita@google.com> · da878678
      morrita@google.com authored
              Reviewed by Tony Chang.
      
              Crash when dragging and dropping in a document with an invalid XHTML header
              https://bugs.webkit.org/show_bug.cgi?id=48799
      
              * editing/pasteboard/drop-file-svg.html: Added.
              * editing/pasteboard/resources/drop-file-svg.svg: Added.
      2011-03-13  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Tony Chang.
      
              Crash when dragging and dropping in a document with an invalid XHTML header
              https://bugs.webkit.org/show_bug.cgi?id=48799
      
              DragController tried to dispatch textInput event even when the
              drag destination is not the editable area.
              This change skips the event dispatching on that case.
      
              Test: editing/pasteboard/drop-file-svg.html
      
              * page/DragController.cpp:
              (WebCore::DragController::dispatchTextInputEventFor):
              (WebCore::DragController::concludeEditDrag):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da878678
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · aea439d1
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              EventHandler calls shouldChangeSelection needlessly
              https://bugs.webkit.org/show_bug.cgi?id=56324
      
              Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and
              avoided calling shouldChangeSelection and setSelection when the existing
              selection is identical to that of new selection.
      
              * page/EventHandler.cpp:
              (WebCore::setSelectionIfNeeded): Extracted.
              (WebCore::setNonDirectionalSelectionIfNeeded): Extracted.
              (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above.
              (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto.
              (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto.
              (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto.
              (WebCore::EventHandler::updateSelectionForMouseDrag): Ditto.
              (WebCore::EventHandler::handleMouseReleaseEvent): Ditto.
      2011-03-14  Anton Muhin  <antonm@chromium.org>
      
              Reviewed by Adam Barth.
      
              [v8] Rework object group building.
              https://bugs.webkit.org/show_bug.cgi?id=55399
      
              Instead of going top-down (from owner to owned elements), go up---from objects
              to their group ids.  That fits better to v8's object grouping model and guarantees
              that each wrapper belongs to the single group.
      
              Alas, this cannot be implemented for one kind of objects---CSSProperties.
      
              Part of core GC algorithm and tested extensively by exisiting layout tests.
      
              * platform/chromium/test_expectations.txt: Temporary suppress text differences.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aea439d1
    • leviw@chromium.org's avatar
      2011-03-09 Levi Weintraub <leviw@chromium.org> · 688f641f
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Deleting content directly following a button inserts an unnecessary placeholder
              https://bugs.webkit.org/show_bug.cgi?id=56053
      
              Test to ensure unnecessary placeholders aren't inserted after buttons when delete is pressed.
      
              * editing/deleting/delete-inserts-br-after-button-expected.txt: Added.
              * editing/deleting/delete-inserts-br-after-button.html: Added.
      2011-03-09  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Deleting content directly following a button inserts an unnecessary placeholder
              https://bugs.webkit.org/show_bug.cgi?id=56053
      
              Fixing a use of Node's enclosingBlockFlowElement with enclosingBlock htmlediting's
              enclosingBlock, as enclosingBlockFlowElement would return inline-block elements despite
              DeleteSelectionCommand treating them as blockflow.
      
              Test: editing/deleting/delete-inserts-br-after-button.html
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::mergeParagraphs):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      688f641f
    • rniwa@webkit.org's avatar
      2011-03-11 Ryosuke Niwa <rniwa@webkit.org> · f018c464
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              Selection uses first mousemove's localRect instead of that of mousedown
              https://bugs.webkit.org/show_bug.cgi?id=56213
      
              Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
              using the mouse coordinates of the mousedown event that started the drag.
      
              Test: editing/selection/drag-select-rapidly.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMouseDraggedEvent):
      2011-03-11  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Tony Chang.
      
              Selection uses first mousemove's localRect instead of that of mousedown
              https://bugs.webkit.org/show_bug.cgi?id=56213
      
              Added a test to ensure the selection start is computed using the mouse coordinates passed down
              to the corresponding mousedown event instead of that of the first mousemove event.
      
              The test is co-authored by Evan Martin.
      
              * editing/selection/anchor-focus2-expected.txt: Editing delegate changes.
              * editing/selection/anchor-focus3-expected.txt: Ditto.
              * editing/selection/drag-select-rapidly-expected.txt: Added.
              * editing/selection/drag-select-rapidly.html: Added.
              * platform/mac/editing/selection/drag-select-1-expected.txt: Selects the correct range of text.
              * platform/mac/editing/selection/fake-drag-expected.txt: Ditto.
              * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f018c464
  16. 11 Mar, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-03-11 Ryosuke Niwa <rniwa@webkit.org> · 5aeaf45c
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              drag-text-delay.html should be a dump as text test
              https://bugs.webkit.org/show_bug.cgi?id=56223
      
              Converted the test to a dump as text. Also reorganized the test code and added more descriptions.
      
              * editing/selection/drag-text-delay-expected.txt:
              * editing/selection/drag-text-delay.html:
              * platform/chromium-linux/editing/selection/drag-text-delay-expected.checksum: Removed.
              * platform/chromium-linux/editing/selection/drag-text-delay-expected.png: Removed.
              * platform/chromium-win/editing/selection/drag-text-delay-expected.checksum: Removed.
              * platform/chromium-win/editing/selection/drag-text-delay-expected.png: Removed.
              * platform/chromium-win/editing/selection/drag-text-delay-expected.txt: Removed.
              * platform/gtk/editing/selection/drag-text-delay-expected.checksum: Removed.
              * platform/gtk/editing/selection/drag-text-delay-expected.png: Removed.
              * platform/gtk/editing/selection/drag-text-delay-expected.txt: Removed.
              * platform/mac/editing/selection/drag-text-delay-expected.checksum: Removed.
              * platform/mac/editing/selection/drag-text-delay-expected.png: Removed.
              * platform/mac/editing/selection/drag-text-delay-expected.txt:
              * platform/win/editing/selection/drag-text-delay-expected.checksum: Removed.
              * platform/win/editing/selection/drag-text-delay-expected.png: Removed.
              * platform/win/editing/selection/drag-text-delay-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5aeaf45c
  17. 10 Mar, 2011 2 commits
    • leviw@chromium.org's avatar
      2011-03-10 Levi Weintraub <leviw@chromium.org> · 8f26e14c
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop
              https://bugs.webkit.org/show_bug.cgi?id=53409
      
              Avoiding crashes and infinite loops when listifying content with mixed-editability
      
              * editing/execCommand/insert-list-with-noneditable-content-expected.txt: Added.
              * editing/execCommand/insert-list-with-noneditable-content.html: Added.
      2011-03-10  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop
              https://bugs.webkit.org/show_bug.cgi?id=53409
      
              Fixing broken handling of mixed-editability content for InsertListCommand. Previously, if the selection
              spanned non-contenteditable regions, it would get stuck endlessly iterating the same region as the algorithm
              didn't skip the editable boundary.
      
              Test: editing/execCommand/insert-list-with-noneditable-content.html
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::cleanupAfterDeletion): Changed signature to take the destination
              position for the active editing command. Without this, there are cases when the destination happens
              to be a placeholder, and we remove it.
              (WebCore::CompositeEditCommand::moveParagraphs):
              * editing/CompositeEditCommand.h:
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApply): Added logic to the paragraph iteration loop to handle pockets of
              non-editable content in an editable context. Previously, this could cause an infinite loop.
              * editing/visible_units.cpp:
              (WebCore::startOfParagraph): Added a mode of operation where we'll jump across non-editable
              content in the same paragraph to reach the actual editable paragraph start.
              (WebCore::endOfParagraph): Ditto.
              (WebCore::startOfNextParagraph): Now uses the aforementioned non-editable content skipping mode of
              endOfParagraph.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f26e14c
    • rniwa@webkit.org's avatar
      2011-03-10 Ryosuke Niwa <rniwa@webkit.org> · 9725203f
      rniwa@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Unable to paste in input[type="text"] with last-child selector
              https://bugs.webkit.org/show_bug.cgi?id=50736
      
              Added regressions tests since this bug no longer reproduces on TOT WebKit.
      
              * editing/input/div-first-child-rule-input-expected.txt: Added.
              * editing/input/div-first-child-rule-input.html: Added.
              * editing/input/div-first-child-rule-textarea-expected.txt: Added.
              * editing/input/div-first-child-rule-textarea.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9725203f
  18. 09 Mar, 2011 1 commit
    • rniwa@webkit.org's avatar
      2011-03-09 Ryosuke Niwa <rniwa@webkit.org> · 106437ba
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
              https://bugs.webkit.org/show_bug.cgi?id=56004
      
              Added a regression test.
      
              * editing/selection/extend-by-line-in-empty-document-expected.txt: Added.
              * editing/selection/extend-by-line-in-empty-document.html: Added.
      2011-03-09  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Tony Chang.
      
              REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
              https://bugs.webkit.org/show_bug.cgi?id=56004
      
              The crash was caused by the false assumption that rootEditableElement() or documentElement()
              always return non-null pointer. Fixed the bug by adding an early exit.
      
              Test: editing/selection/extend-by-line-in-empty-document.html
      
              * editing/visible_units.cpp:
              (WebCore::previousLinePosition):
              (WebCore::nextLinePosition):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      106437ba
  19. 07 Mar, 2011 2 commits
    • dcheng@chromium.org's avatar
      2011-03-07 Daniel Cheng <dcheng@chromium.org> · d3fc3e91
      dcheng@chromium.org authored
              Reviewed by David Levin.
      
              Add support for DataTransferItems
              https://bugs.webkit.org/show_bug.cgi?id=55115
      
              Layout test to verify that the basic properties of dataTransfer.items function as expected.
      
              * editing/pasteboard/data-transfer-items-expected.txt: Added.
              * editing/pasteboard/data-transfer-items.html: Added.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2011-03-07  Daniel Cheng  <dcheng@chromium.org>
      
              Reviewed by David Levin.
      
              Add support for DataTransferItems
              https://bugs.webkit.org/show_bug.cgi?id=55115
      
              This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
              basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
              all functionality on the DataTransferItems collection has been implemented.
              This change does not actually hook up DataTransferItems to reflect the actual contents of a
              drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
              enabled via several followup patches.
      
              Test: editing/pasteboard/data-transfer-items.html
      
              * Android.mk:
              * CMakeLists.txt:
              * CodeGenerators.pri:
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/generic/RuntimeEnabledFeatures.cpp:
              * bindings/generic/RuntimeEnabledFeatures.h:
              (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
              (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
              * bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
              * dom/Clipboard.h:
              (WebCore::Clipboard::policy):
              * dom/Clipboard.idl:
              * dom/DataTransferItem.cpp: Added.
              * dom/DataTransferItem.h: Added.
              (WebCore::DataTransferItem::~DataTransferItem):
              * dom/DataTransferItem.idl: Added.
              * dom/DataTransferItems.h: Added.
              (WebCore::DataTransferItems::~DataTransferItems):
              * dom/DataTransferItems.idl: Added.
              * dom/StringCallback.cpp: Added.
              (WebCore::StringCallback::scheduleCallback):
              * dom/StringCallback.h: Added.
              (WebCore::StringCallback::~StringCallback):
              * dom/StringCallback.idl: Added.
              * platform/chromium/ClipboardChromium.cpp:
              (WebCore::ClipboardChromium::items):
              * platform/chromium/ClipboardChromium.h:
              * platform/chromium/DataTransferItemChromium.cpp: Added.
              (WebCore::DataTransferItemChromium::create):
              (WebCore::DataTransferItemChromium::DataTransferItemChromium):
              (WebCore::DataTransferItemChromium::kind):
              (WebCore::DataTransferItemChromium::type):
              (WebCore::DataTransferItemChromium::getAsString):
              * platform/chromium/DataTransferItemChromium.h: Added.
              * platform/chromium/DataTransferItemsChromium.cpp: Added.
              (WebCore::DataTransferItemsChromium::create):
              (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
              (WebCore::DataTransferItemsChromium::length):
              (WebCore::DataTransferItemsChromium::item):
              (WebCore::DataTransferItemsChromium::deleteItem):
              (WebCore::DataTransferItemsChromium::clear):
              (WebCore::DataTransferItemsChromium::add):
              * platform/chromium/DataTransferItemsChromium.h: Added.
      2011-03-07  Daniel Cheng  <dcheng@chromium.org>
      
              Reviewed by David Levin.
      
              Add support for DataTransferItems
              https://bugs.webkit.org/show_bug.cgi?id=55115
      
              Add new runtime enabled flag for data transfer items feature.
      
              * public/WebRuntimeFeatures.h:
              * src/WebRuntimeFeatures.cpp:
              (WebKit::WebRuntimeFeatures::enableDataTransferItems):
              (WebKit::WebRuntimeFeatures::isDataTransferItemsEnabled):
      2011-03-07  Daniel Cheng  <dcheng@chromium.org>
      
              Reviewed by David Levin.
      
              Add support for DataTransferItems
              https://bugs.webkit.org/show_bug.cgi?id=55115
      
              Enable data transfer items in DRT.
      
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::TestShell):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3fc3e91
    • dcheng@chromium.org's avatar
      2011-03-07 Daniel Cheng <dcheng@chromium.org> · 62500e30
      dcheng@chromium.org authored
              Reviewed by Tony Chang.
      
              Add plumbing for paste support to ChromiumDataObject::types()
              https://bugs.webkit.org/show_bug.cgi?id=55792
      
              Add a simple layout test to verify that event.clipboardData.types
              reflects the types available in a paste.
      
              * editing/pasteboard/onpaste-text-html-types-expected.txt: Added.
              * editing/pasteboard/onpaste-text-html-types.html: Added.
      2011-03-07  Daniel Cheng  <dcheng@chromium.org>
      
              Reviewed by Tony Chang.
      
              Add plumbing for paste support to ChromiumDataObject::types()
              https://bugs.webkit.org/show_bug.cgi?id=55792
      
              This is a preliminary patch to support event.dataTransfer.items. This
              adds plumbing to support retrieving the types in a paste event. It also
              moves the check for files in a drag/paste up to ClipboardChromium, since
              internal code needs to be able to differentiate between actual files in
              a drag and someone that simply decided to use "Files" as a custom type
              string.
      
              Test: editing/pasteboard/onpaste-text-html-types.html
      
              * platform/chromium/ChromiumDataObject.cpp:
              (WebCore::ChromiumDataObject::types):
              (WebCore::ChromiumDataObject::containsFilenames):
              * platform/chromium/ChromiumDataObject.h:
              * platform/chromium/ClipboardChromium.cpp:
              (WebCore::ClipboardChromium::types):
              * platform/chromium/ClipboardMimeTypes.cpp:
              * platform/chromium/ClipboardMimeTypes.h:
      2011-03-07  Daniel Cheng  <dcheng@chromium.org>
      
              Reviewed by Tony Chang.
      
              Add plumbing for paste support to ChromiumDataObject::types()
              https://bugs.webkit.org/show_bug.cgi?id=55792
      
              This requires a DEPS roll for a Chromium-side change to support DRT testing of
              event.dataTransfer.types.
      
              * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62500e30