1. 23 Jul, 2007 6 commits
    • zecke's avatar
      2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org> · 5604daf5
      zecke authored
              Reviewed by Adam.
      
              Add WebKit/gtk/Api and WebCoreSupport API to the INCLUDEPATH to allow GdkLauncher to be
              build against it.
      
              * WebKit.pri:
      
      
      WebCore:
      2007-07-22  Holger Hans Peter Freyther  <zecke@selfish.org>
      
              Reviewed by Adam.
      
              WARNING: NO TEST CASES ADDED OR CHANGED
      
              Add the WebKit/Gtk API to the buildsystem, ask qmake to create a
              pkg-config file and install headers and libraries.
      
              Start to emit signals from FrameLoaderClientGdk, hide the kit Frame
              inside the the FrameLoaderClientGdk.
      
              Move ChromeClientGdk to WebKit/gtk/WebCoreSupport
      
              * WebCore.pro:
              * loader/gdk/FrameLoaderClientGdk.cpp:
              * loader/gdk/FrameLoaderClientGdk.h:
              * platform/gdk/ChromeClientGdk.h: Removed.
              * platform/gdk/FrameGdk.cpp: Remove code not belonging here
              * platform/gdk/FrameGdk.h:
              * platform/gdk/ScrollViewGdk.cpp: The gdkDrawable won't exist at that time and it is fine
              * platform/gdk/TemporaryLinkStubs.cpp: Removed ChromeClientGdk stubs
      
      WebKit:
      2007-07-22  Holger Hans Peter Freyther  <zecke@selfish.org>
      
              Reviewed by Adam.
      
              Add the first API and partial implementation of the WebKit/Gtk port as
              of http://bugs.webkit.org/show_bug.cgi?id=14678.
      
              The delegates of WebView will be modeled as signals. Delegates like the
              WebPolicyDelegate will be implemented as signals with default handlers.
      
              Start moving files to WebKit/gtk/WebCoreSupport.
      
              * gtk: Added.
              * gtk/Api: Added.
              * gtk/Api/headers.pri: Added.
              * gtk/Api/webkitgtk-marshal.list: Added.
              * gtk/Api/webkitgtkdefines.h: Added.
              * gtk/Api/webkitgtkframe.cpp: Added.
              * gtk/Api/webkitgtkframe.h: Added.
              * gtk/Api/webkitgtkframedata.cpp: Added.
              * gtk/Api/webkitgtkframedata.h: Added.
              * gtk/Api/webkitgtkglobal.cpp: Added.
              * gtk/Api/webkitgtkglobal.h: Added.
              * gtk/Api/webkitgtknetworkrequest.cpp: Added.
              * gtk/Api/webkitgtknetworkrequest.h: Added.
              * gtk/Api/webkitgtkpage.cpp: Added.
              * gtk/Api/webkitgtkpage.h: Added.
              * gtk/Api/webkitgtkprivate.cpp: Added.
              * gtk/Api/webkitgtkprivate.h: Added.
              * gtk/Api/webkitgtksettings.cpp: Added.
              * gtk/Api/webkitgtksettings.h: Added.
              * gtk/WebCoreSupport: Added.
              * gtk/WebCoreSupport/ChromeClientGdk.cpp: Added.
              (WebCore::ChromeClientGdk::ChromeClientGdk):
              (WebCore::ChromeClientGdk::chromeDestroyed):
              (WebCore::ChromeClientGdk::windowRect):
              (WebCore::ChromeClientGdk::setWindowRect):
              (WebCore::ChromeClientGdk::pageRect):
              (WebCore::ChromeClientGdk::scaleFactor):
              (WebCore::ChromeClientGdk::focus):
              (WebCore::ChromeClientGdk::unfocus):
              (WebCore::ChromeClientGdk::createWindow):
              (WebCore::ChromeClientGdk::createModalDialog):
              (WebCore::ChromeClientGdk::show):
              (WebCore::ChromeClientGdk::canRunModal):
              (WebCore::ChromeClientGdk::runModal):
              (WebCore::ChromeClientGdk::setToolbarsVisible):
              (WebCore::ChromeClientGdk::toolbarsVisible):
              (WebCore::ChromeClientGdk::setStatusbarVisible):
              (WebCore::ChromeClientGdk::statusbarVisible):
              (WebCore::ChromeClientGdk::setScrollbarsVisible):
              (WebCore::ChromeClientGdk::scrollbarsVisible):
              (WebCore::ChromeClientGdk::setMenubarVisible):
              (WebCore::ChromeClientGdk::menubarVisible):
              (WebCore::ChromeClientGdk::setResizable):
              (WebCore::ChromeClientGdk::closeWindowSoon):
              (WebCore::ChromeClientGdk::canTakeFocus):
              (WebCore::ChromeClientGdk::takeFocus):
              (WebCore::ChromeClientGdk::canRunBeforeUnloadConfirmPanel):
              (WebCore::ChromeClientGdk::runBeforeUnloadConfirmPanel):
              (WebCore::ChromeClientGdk::addMessageToConsole):
              (WebCore::ChromeClientGdk::runJavaScriptAlert):
              (WebCore::ChromeClientGdk::runJavaScriptConfirm):
              (WebCore::ChromeClientGdk::runJavaScriptPrompt):
              (WebCore::ChromeClientGdk::setStatusbarText):
              (WebCore::ChromeClientGdk::shouldInterruptJavaScript):
              (WebCore::ChromeClientGdk::tabsToLinks):
              (WebCore::ChromeClientGdk::windowResizerRect):
              (WebCore::ChromeClientGdk::addToDirtyRegion):
              (WebCore::ChromeClientGdk::scrollBackingStore):
              (WebCore::ChromeClientGdk::updateBackingStore):
              (WebCore::ChromeClientGdk::mouseDidMoveOverElement):
              (WebCore::ChromeClientGdk::setToolTip):
              (WebCore::ChromeClientGdk::print):
              * gtk/WebCoreSupport/ChromeClientGdk.h: Added.
      
      WebKitTools:
      2007-07-22  Holger Hans Peter Freyther  <zecke@selfish.org>
      
              Reviewed by Adam.
      
              Make the GdkLauncher use the new WebKit/Gtk API. Change webkitdirs.pm to
              honor --qmakearg for the Gdk/Gtk build as well.
      
              * GdkLauncher/main.cpp: Switch to the new API
              * Scripts/webkitdirs.pm: Allow to specify --qmakearg, e.g. to control the WEBKIT_{INC,LIB}_DIR 
      
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5604daf5
    • aroben's avatar
      Implement IDOMElement::setAttribute · 2a4134de
      aroben authored
              This method was mistakenly called "setResult" in DOMCore.idl, so I
              fixed that as well.
      
              Needed for <rdar://problem/5314906>.
      
              Reviewed by Ada.
      
              * DOMCoreClasses.cpp:
              (DOMElement::setAttribute): Implemented/renamed.
              * DOMCoreClasses.h: Renamed setResult => setAttribute.
              * DOMHTMLClasses.h: Ditto.
              * Interfaces/DOMCore.idl: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a4134de
    • aliceli1's avatar
      Reviewed by Oliver Hunt. · b9549b8d
      aliceli1 authored
              Expose [WebHTMLView hasMarkedText] to 
              fix <rdar://problem/4830074> autocomplete breaks Japanese typing
      
              * WebView/WebHTMLView.mm:
              * WebView/WebHTMLViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9549b8d
    • mjs's avatar
      Reviewed by Oliver. · b3d49ea7
      mjs authored
              
              - fix remaining problems with Window shadowing
      
              * kjs/nodes.cpp:
              (VarDeclNode::evaluate): Tweak the special case a little.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3d49ea7
    • mjs's avatar
      Reviewed by Oliver. · 7a135274
      mjs authored
              
              - fix Window shadowing regressions caused by the previous commit.
      
              * kjs/nodes.cpp:
              (VarDeclNode::evaluate): Handle the case of global scope specially.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a135274
    • mjs's avatar
      Reviewed by Darin. · 9aa39314
      mjs authored
              -fixed <rdar://problem/5353293> REGRESSION (r24287): 1% i-Bench JS slowdown from JavaScript compatibility fix (14719)
              http://bugs.webkit.org/show_bug.cgi?id=14719
              
              My fix for this actually resulted in JS iBench being 1% faster than before the regression
              and the Celtic Kane benchmark being 5% faster than before the regression.
              
              * kjs/nodes.cpp:
              (VarDeclNode::handleSlowCase): factored out the slow code path to be out of line.
              (VarDeclNode::evaluate): I did a couple of things:
              (1) Don't check if the variable is already declared by looking for the property in
              the variable object, that code path was dead code.
              (2) Special-case the common case where the top of the scope and the variable object
              are the same; in that case the variable must always be in the variable object.
              (3) Don't return a jsString() of the variable name, nothing uses the return value
              from this node types evaluate method.
              * kjs/nodes.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aa39314
  2. 22 Jul, 2007 18 commits
    • mjs's avatar
      Reviewed by Adam. · b0d91b78
      mjs authored
              <rdar://problem/5353174> REGRESSION: 1% JavaScript performance regression fro Window refactoring (14717)
              http://bugs.webkit.org/show_bug.cgi?id=14717
              
              * bindings/js/kjs_window.cpp:
              * bindings/js/kjs_window.h:
              (KJS::Window::impl): inlined
              * page/DOMWindow.cpp:
              * page/DOMWindow.h:
              (WebCore::DOMWindow::frame): inlined
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0d91b78
    • weinig's avatar
      Fix typo. · 4a00425d
      weinig authored
              * fast/dom/Window/window-function-name-getter-precedence.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a00425d
    • darin's avatar
      * platform/ContextMenu.cpp: Added missing include. · 6fe96c5c
      darin authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fe96c5c
    • weinig's avatar
      LayoutTests: · f7691618
      weinig authored
              Reviewed by Darin.
      
              Test for  http://bugs.webkit.org/show_bug.cgi?id=14682
              REGRESSION(24285-24399): alerts do not appear at W3C RTL test page
      
              * fast/dom/Window/window-function-name-getter-precedence-expected.txt: Added.
              * fast/dom/Window/window-function-name-getter-precedence.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=14682
              REGRESSION(24285-24399): alerts do not appear at W3C RTL test page
      
              Test: fast/dom/Window/window-function-name-getter-precedence.html
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::customGetOwnPropertySlot): Make sure to return functions
              before the custom name getter.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7691618
    • darin's avatar
      Reviewed by Adam. · 1bffbf86
      darin authored
              - fix <rdar://problem/5353263> ContextMenuItem and ContextMenu objects leaking (seen on buildbot)
      
              * platform/ContextMenu.cpp:
              (WebCore::separatorItem): Return an auto_ptr instead of a raw pointer, since this function
              creates an object that's the caller's responsibility to delete.
              (WebCore::createAndAppendFontSubMenu): Create the context menu on the stack, not the heap,
              since setSubMenu does not take ownership, and hence the objects were leaking.
              (WebCore::createAndAppendSpellingAndGrammarSubMenu): Ditto.
              (WebCore::createAndAppendSpellingSubMenu): Ditto.
              (WebCore::createAndAppendSpeechSubMenu): Ditto.
              (WebCore::createAndAppendWritingDirectionSubMenu): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bffbf86
    • pewtermoose's avatar
      Reviewed by Adam Roben. · 5ea5fbc5
      pewtermoose authored
              Add information on getting a useful crash log on Mac and Windows.
      
              * nav.inc:
              * quality/crashlogs.html: Added.
              * quality/mac_reportbox.jpg: Added.
              * quality/mac_viewtrace.jpg: Added.
              * quality/win_installwatson.jpg: Added.
              * quality/win_watsongui.jpg: Added.
              * quality/win_watsoninstalled.jpg: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ea5fbc5
    • darin's avatar
      * DumpRenderTree/TextInputController.m: (-[TextInputController... · ad5dd56a
      darin authored
              * DumpRenderTree/TextInputController.m: (-[TextInputController interpretKeyEvents:withSender:]):
              Fix a leak by releasing the array used here.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad5dd56a
    • darin's avatar
      JavaScriptCore: · f95e7eab
      darin authored
              Reviewed by Kevin Decker.
      
              - fix <rdar://problem/5126394> REGRESSION: Crash after clicking back button in test application (13250)
                http://bugs.webkit.org/show_bug.cgi?id=13250
      
              * bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
              If the object returns 0 for _imp, convert that to "undefined", since callers
              can't cope with a JSValue of 0.
      
      WebCore:
      
              Reviewed by Kevin Decker.
      
              - fix <rdar://problem/5126394> REGRESSION: Crash after clicking back button in test application (13250)
                http://bugs.webkit.org/show_bug.cgi?id=13250
      
              * bindings/objc/WebScriptObject.mm:
              (_didExecute): Removed unnecessary check for isValid() since the _rootObject method already
              takes care of that check.
              (-[WebScriptObject _imp]): Made this return 0 if there is not a valid rootObject.
              (-[WebScriptObject _isSafeScript]): Made this always return false if there is not a valid
              rootObject, eliminating the need to check _rootObject for nil if the code is checking _isSafeScript.
              (-[WebScriptObject callWebScriptMethod:withArguments:]): Removed check of _rootObject, since it's
              immediately followed by a check of _isSafeScript. Removed awkward conversion of name from NSString *
              to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no
              arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check
              the _imp pointer. Added a second check of _isSafeScript after calling get to get the function
              object, since arbitrary changes could occur in there, including navigation to a new frame.
              This also takes care of null checking the second call to _imp.
              (-[WebScriptObject evaluateWebScript:]): Removed check of _rootObject, since it's
              immediately followed by a check of _isSafeScript. Removed awkward conversion of script from NSString *
              to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no
              arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check
              the _imp pointer.
              (-[WebScriptObject setValue:forKey:]): Removed check of _rootObject, since it's
              immediately followed by a check of _isSafeScript. Removed awkward conversion of key from NSString *
              to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no
              arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check
              the _imp pointer.
              (-[WebScriptObject valueForKey:]): Ditto.
              (-[WebScriptObject removeWebScriptKey:]): Ditto.
              (-[WebScriptObject stringRepresentation]): Removed check of _rootObject, since it's
              immediately followed by a check of _isSafeScript. Removed unnecessary local variable
              and const_cast from the call to the _imp method.
              (-[WebScriptObject webScriptValueAtIndex:]): Removed check of _rootObject, since it's
              immediately followed by a check of _isSafeScript.
              (-[WebScriptObject setWebScriptValueAtIndex:value:]): Ditto.
              (-[WebScriptObject JSObject]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f95e7eab
    • ddkilzer's avatar
      WebKitTools: · 8d398148
      ddkilzer authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=14713
                Script to update iExploder cssproperties.in file based on CSSPropertyNames.in
      
              Added script to update WebKitTools/iExploder/htdocs/cssproperties.in based on the contents
              of WebCore/css/CSSPropertyNames.in.  Also updated cssproperties.in.
      
              * Scripts/update-iexploder-cssproperties: Added.
              * iExploder/htdocs/cssproperties.in: Updated by running update-iexploder-cssproperties script.
              Added new CSS3 property section and Moved box-sizing property to it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d398148
    • oliver's avatar
      LayoutTests: · 383b6289
      oliver authored
              Reviewed by Sam.
      
              Moving input method tests to editing/input/mac
      
              * editing/input/mac: Copied from fast/events/inputmethods.
              * fast/events/inputmethods: Removed.
              * fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
              * fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Removed.
              * fast/events/inputmethods/kotoeri.js: Removed.
              * fast/events/inputmethods/logger.js: Removed.
              * win/Skipped:
      
      qt:
      
              Reviewed by Sam.
              
              Add Mac input methods to qt skip list
      
              * Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      383b6289
    • darin's avatar
      Updated reviewers. · 01ef8045
      darin authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01ef8045
    • darin's avatar
      Reviewed by Anders. · ea1a5680
      darin authored
              - speculative fix for <rdar://problem/5337500> CrashTracer: [USER] 4 crashes in Mail
                at WebCore::HTMLImageElement::isURLAttribute(WebCore::Attribute*) const
      
              * editing/markup.cpp: Added AttributeChange class.
              (WebCore::completeURLs): Changed function so that all the URL completion is done in
              a separate pass after finding all the URL attributes. This is safer, since actually
              applying an attribute change could have any arbitrary effect on the document; it's
              tricky to iterate a document while it's being modified and we don't have the checks
              here that would be needed to make that work in pathological cases.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea1a5680
    • oliver's avatar
      Reviewed by Adam. · f04e31ec
      oliver authored
              Add the input methods tests to the windows skip list 
              until we work to how to make them platform agnostic
      
              * win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f04e31ec
    • darin's avatar
      Update Bugzilla bug number in Radar bug title based on feedback from Mitz. · c2a72dbd
      darin authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2a72dbd
    • oliver's avatar
      LayoutTests: · 7129d75d
      oliver authored
              Reviewed by Darin.
      
              Initial input method test case, this tests the behaviour of the 
              enter key in our "kotoeri" engine.
      
              * fast/events/inputmethods: Added.
              * fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Added.
              * fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Added.
              * fast/events/inputmethods/kotoeri.js: Added.
              * fast/events/inputmethods/logger.js: Added.
      
      WebKitTools:
      
              Reviewed by Darin.
      
              http://bugs.webkit.org/show_bug.cgi?id=14710
      
              Add preliminary support for testing Input Method/WebKit behaviour and interaction 
              in DRT.  This provides the NSTextInput API which is most of what should be necessary
              to mimic the event sequences Input Methods trigger.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
              * DumpRenderTree/TextInputController.h:
              * DumpRenderTree/TextInputController.m:
              (-[WebHTMLView interpretKeyEvents:]):
              (+[TextInputController isSelectorExcludedFromWebScript:]):
              (+[TextInputController webScriptNameForSelector:]):
              (-[TextInputController initWithWebView:]):
              (-[TextInputController dealloc]):
              (-[TextInputController textInput]):
              (-[TextInputController setInputMethodHandler:]):
              (-[TextInputController interpretKeyEvents:withSender:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7129d75d
    • darin's avatar
      Reviewed by Adam. · 2ce0b419
      darin authored
              - fix <rdar://problem/5350604> REGRESSION: Crash in inspector controller code after
                clicking back button in test application (13250)
      
              * page/InspectorController.cpp: (WebCore::InspectorController::addScriptResource):
              Replace an assertion that was firing with some code that at least doesn't immediately crash.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ce0b419
    • darin's avatar
      * StringsNotToBeLocalized.txt: Updated for recent changes. · c41cd0dd
      darin authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c41cd0dd
    • darin's avatar
      Reviewed by Anders. · 90182d17
      darin authored
              - improve the fix for <rdar://problem/5298816> Crash redirecting message,
                in -[SharedBufferData initWithSharedBuffer:]; fixes a crash seen on the buildbot
      
              * loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): Call setDocLoader(0) on all
              the resources so they don't try to use a stale DocLoader pointer later.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90182d17
  3. 21 Jul, 2007 6 commits
  4. 20 Jul, 2007 10 commits
    • staikos's avatar
      Patch from Adam Treat to add the rest of the policy information (action type) · b8df116f
      staikos authored
      and a signal for initial layout
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8df116f
    • beidson's avatar
      WebCore: · f8cc4332
      beidson authored
              Reviewed by Adele and Andersca
      
              <rdar://problem/5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)
      
              * WebCore.exp: Export the BackForwardList c'tor so WebKit can create one explicitly
      
      WebKit:
      
              Reviewed by Adele and Andersca
      
              <rdar://problem/5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)
      
              * History/WebBackForwardList.mm:
              (-[WebBackForwardList init]): Have a default initializer that uses an empty BackFowardList not associated with a page.
      
              * WebView/WebFrame.mm:
              (kit): For clarity's sake, this should return nil, not 0
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8cc4332
    • weinig's avatar
      LayoutTests: · 243792c5
      weinig authored
              Reviewed by Beth Dakin.
      
              Tests for <rdar://problem/5351901>
              Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue
      
              * fast/css/computed-style-expected.txt:
              * fast/css/computed-style-without-renderer-expected.txt:
              * fast/css/getComputedStyle-background-position-expected.txt: Added.
              * fast/css/getComputedStyle-background-position.html: Added.
      
      WebCore:
      
              Reviewed by Beth Dakin.
      
              Fix for <rdar://problem/5351901>
              Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue
      
              - Return a space separated CSSValueList for background-position
                instead of a CSSPrimitiveValue (string type).
              - Remove the "else if (renderer)" case as it never returns a different
                value than just calling length.value().
              - Make background-position-x and background-position-y behave like
                background-position.  Fix case of initial value return 'auto' instead
                of 0.
      
              Test: fast/css/getComputedStyle-background-position.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      243792c5
    • ggaren's avatar
      Build fix for non-Mac platforms. · c70e8e46
      ggaren authored
              
              * bindings/js/GCController.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c70e8e46
    • andersca's avatar
      Reviewed by Darin. · e9916d43
      andersca authored
              If the style sheet requested is a user style sheet, don't store it in the DocLoader's resource map;
              user style sheets can outlive their doc loaders.
      
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::requestCSSStyleSheet):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9916d43
    • justing's avatar
      LayoutTests: · 44a1aead
      justing authored
              Reviewed by Darin.
              
              <rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it
      
              * editing/selection/5109817-expected.checksum: Added.
              * editing/selection/5109817-expected.png: Added.
              * editing/selection/5109817-expected.txt: Added.
              * editing/selection/5109817.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              <rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it
              
              * bridge/EditorClient.h: Removed a client method for enabling/disabling
              word selection on right clicks.
              * editing/Editor.cpp: Ditto.
              * editing/Editor.h:
              * page/EventHandler.cpp:
              (WebCore::EventHandler::sendContextMenuEvent): Select the
              word underneath the mouse regardless of whether its editable.
      
      WebKit:
      
              Reviewed by Darin.
              
              <rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm: Removed the method
              for enabling/disabling word selection on right click.
              * WebView/WebView.mm: Ditto.
              * WebView/WebViewPrivate.h: Removed the getter/setter entirely, 
              it was in a private Category for Mail, but wasn't used by Mail
              on Tiger or Leopard, they apparently implement word selection on 
              their own.
      
      win:
      
              Reviewed by Darin.
              
              <rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it
      
              * WebEditorClient.cpp: Removed the now unused selectWordBeforeMenuEvent().
              * WebEditorClient.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44a1aead
    • adachan's avatar
      2007-07-20 Ada Chan <adachan@apple.com> · 7371c368
      adachan authored
              Reviewed by Darin and Adam.
      
              <rdar://problem/5338385> Fixed infinite loop in ScrollView::scrollRectIntoViewRecursively().
              Also removed an unused local variable.
      
              * platform/win/ScrollViewWin.cpp:
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7371c368
    • antti's avatar
      LayoutTests: · 1a918cbc
      antti authored
              Reviewed by Darin.
              
              HTTP test for <rdar://problem/5305788>
              REGRESSION: Safari sometimes loads IE-specific stylesheet on www.apaema.org
              
              Test that order style sheets arrive has no impact to selection of preferred style sheet set.
      
              * http/tests/local/fail.css: Added.
              * http/tests/local/link-stylesheet-preferred-expected.txt: Added.
              * http/tests/local/link-stylesheet-preferred.html: Added.
              * http/tests/local/slow-css-pass.cgi: Added.
      
      WebCore:
      
              Reviewed by Darin.
              
              Fix <rdar://problem/5305788>
              REGRESSION: Safari sometimes loads IE-specific stylesheet on www.apaema.org
              
              Pick the preferred style sheet set based on document order even if the sheet is still loading. Previously 
              the set was chosen based on which stylesheet happened to arrive first. Just fix the problem at hand 
              and resist urge to start refactoring this function.
      
              * dom/Document.cpp:
              (WebCore::Document::recalcStyleSelector):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a918cbc
    • weinig's avatar
      LayoutTests: · ec39da16
      weinig authored
              Reviewed by Darin.
      
              Add tests for <rdar://problem/5351252>
              Computed value for -webkit-background-size and border-spacing
              should be space separated CSSValueLists.
      
              * fast/css/computed-style-expected.txt:
              * fast/css/computed-style-without-renderer-expected.txt:
              * fast/css/getComputedStyle-background-size-expected.txt: Added.
              * fast/css/getComputedStyle-background-size.html: Added.
              * fast/css/getComputedStyle-border-spacing-expected.txt: Added.
              * fast/css/getComputedStyle-border-spacing.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              Fix for <rdar://problem/5351252>
              Computed value for -webkit-background-size and border-spacing
              should be space separated CSSValueLists.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec39da16
    • ggaren's avatar
      Suggested by Darin Adler. · 211b0918
      ggaren authored
              
              Slight tweak to my last commit: changed gcController() to return a 
              reference instead of a pointer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      211b0918