1. 11 May, 2007 8 commits
  2. 10 May, 2007 32 commits
    • justing's avatar
      This tests behaves differently when it isn't run by itself because · feb20b34
      justing authored
          of a bug.  Filed it (13673) and added a workaround.
          
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      feb20b34
    • hyatt's avatar
      <rdar://problem/5015522> Bounds rectangle of unloaded images is · b79ae804
      hyatt authored
              drawn briefly while loading
              
              When the image is null and has no size, don't draw the grey
              rectangles or alt text any more.  Wait for an actual error to
              occur with the image before we start showing alt text and borders.
      
              (Images with no source set at all will continue to show alt text and
              borders immediately.)
      
              Reviewed by bradee-oh
      
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::paint):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b79ae804
    • thatcher's avatar
      LayoutTests: · 2acf17d1
      thatcher authored
              Reviewed by Darin.
      
              - repaint test and updated results for http://bugs.webkit.org/show_bug.cgi?id=13655
                Incomplete repaint when text-shadow is used in a render layer with explicit height
      
              * fast/repaint/layer-full-repaint-expected.checksum: Added.
              * fast/repaint/layer-full-repaint-expected.png: Added.
              * fast/repaint/layer-full-repaint-expected.txt: Added.
              * fast/repaint/layer-full-repaint.html: Added.
              * fast/repaint/repaint-resized-overflow-expected.checksum:
              * fast/repaint/repaint-resized-overflow-expected.png:
      
      WebCore:
      
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13655
                Incomplete repaint when text-shadow is used in a render layer with explicit height
      
              Test: fast/repaint/layer-full-repaint.html
      
              Removed custom repaint logic from RenderLayer. repaintAfterLayoutIfNeeded()
              knows how to do everything we need now. The only catch is that we cannot
              rely on its "do a full repaint if the object needs layout" behavior, since
              by the time we call it, the needs layout flag has been reset. The solution
              is to cache the need for a full repaint in the layer.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::layout): Removed call to checkForRepaintOnResize().
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::checkForRepaintOnResize): Removed.
              (WebCore::RenderLayer::RenderLayer): Replaced the m_repaintOverflowOnResize
              flag with a m_needsFullRepaint flag, which indicates that the layer needs
              to do a full repaint in the next call to updateLayerPositions().
              (WebCore::RenderLayer::updateLayerPositions): Simplified the repaint logic.
              Either call repaintAfterLayoutIfNeeded() or do a full repaint, depending on
              m_needsFullRepaint.
              * rendering/RenderLayer.h:
              (WebCore::RenderLayer::setNeedsFullRepaint):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::setNeedsLayout): Mark the layer for full repaint.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2acf17d1
    • justing's avatar
      LayoutTests: · c8c2b94f
      justing authored
              Reviewed by ggaren
      
              <rdar://problem/5195166> Incorrect proposedRange DOMRange passed to WebViewEditing delegate
      
              * editing/selection/5195166-1-expected.checksum: Added.
              * editing/selection/5195166-1-expected.png: Added.
              * editing/selection/5195166-1-expected.txt: Added.
              * editing/selection/5195166-1.html: Added.
              * editing/selection/5195166-2-expected.checksum: Added.
              * editing/selection/5195166-2-expected.png: Added.
              * editing/selection/5195166-2-expected.txt: Added.
              * editing/selection/5195166-2.html: Added.
      
      WebCore:
      
              Reviewed by ggaren
      
              <rdar://problem/5195166> Incorrect proposedRange DOMRange passed to WebViewEditing delegate
              
              In setModifyBias, we must cache the start and the end 
              because the calls to setBase and setExtent can modify 
              them (added a testcase).
              The temporary SelectionController that we use in modify() to
              produce the proposed range that will be passed to 
              shouldChangeSelectedDOMRange must have the same m_modifyBias
              as the original SelectionController, or else when the 
              modification is performed, setModifyBias can swap the base 
              and the extent incorrectly (added a testcase).
              Renamed m_modifyBias to m_lastChangeWasHorizontalExtension.
              Renamed setModifyBias to willBeModified.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::SelectionController):
              (WebCore::SelectionController::setSelection):
              (WebCore::SelectionController::willBeModified):
              (WebCore::SelectionController::modify):
              * editing/SelectionController.h:
              (WebCore::SelectionController::setLastChangeWasHorizontalExtension):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              (WebCore::EventHandler::updateSelectionForMouseDragOverPosition):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8c2b94f
    • ggaren's avatar
      WebCore: · 7b1bb91f
      ggaren authored
              Reviewed by Darin Adler.
      
              "IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness,
              in the style of WebCore::cache().
      
              * WebCore.exp:
              * history/HistoryItem.cpp: Removed retainIconInDatabase because calling
              "retain" in order to release something is really confusing and, now that
              iconDatabase() is more terse, we don't need this helper to shorten the
              syntax. (The isEmpty() check is also done by the database, so we don't 
              need it either.)
      
              (WebCore::IconDatabase::~IconDatabase): ASSERT that our destructor isn't
              called. We're a singleton, so it's confusing to have tear-down code.
      
      WebKit:
      
              Reviewed by Darin Adler.
              
              "IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b1bb91f
    • adele's avatar
      LayoutTests: · eaa0055b
      adele authored
              Reviewed by Hyatt.
      
              Test for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result
      
              * fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Added.
              * fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Added.
              * fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Added.
              * fast/overflow/scroll-nested-positioned-layer-in-overflow.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              WebCore part of fix for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result
      
              Test: fast/overflow/scroll-nested-positioned-layer-in-overflow.html
      
              Merged visibleSelectionRect into selectionRect.  selectionRect() now takes an argument to determine
              whether or not to return a rect that clips to the visible content.  This change makes all of the implementations of selectionRect
              consistent by having them all consider the repaint rect when clipping to visible content.
      
              * page/Frame.cpp:
              (WebCore::Frame::revealSelection): Call selectionRect with clipToVisibleContent = false, so we can get a rect that's not visible to reveal.
              (WebCore::Frame::selectionRect): Added clipToVisibleContent argument, and merged visibleSelectionRect into this method.
              (WebCore::Frame::setIsActive): Use selectionRect instead of visibleSelectionRect.
              * page/Frame.h:
              * page/mac/FrameMac.mm: (WebCore::Frame::selectionImage): Update layout before creating the image.  Use selectionRect instead of visibleSelectionRect.
              * page/DragController.cpp: (WebCore::dragLocForSelectionDrag): Use selectionRect instead of visibleSelectionRect.
      
              * rendering/RenderBR.h: (WebCore::RenderBR::selectionRect): Updated argument.
              * rendering/RenderBlock.h: (WebCore::RenderBlock::selectionRect): ditto.
              * rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::selectionRect): ditto.
              * rendering/RenderSVGInlineText.h: ditto.
              * rendering/RenderObject.h: 
              (WebCore::RenderObject::selectionRect): ditto.
              (WebCore::RenderObject::SelectionInfo::SelectionInfo): ditto.
              * rendering/RenderView.cpp:
              (WebCore::RenderView::selectionRect): ditto.
              (WebCore::RenderView::setSelection): ditto.
              * rendering/RenderView.h:
      
              * rendering/RenderText.h:
              * rendering/RenderText.cpp: (WebCore::RenderText::selectionRect): Only call computeAbsoluteRepaintRect when clipping to visible content.
              Otherwise, just adjust the rect to the correct position.
              * rendering/RenderListMarker.h:
              * rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRect):
                To match what we do in RenderText, if we're trying to clip to visible content, just call computeAbsoluteRepaintRect.
              * rendering/RenderReplaced.h:
              * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect): ditto.
      
              * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Check for a parent layer at the beginning, so we can try to scroll all of our parent layers 
                first, before trying to scroll the top level view.  Also, don't try to scroll overflow layers that have -webkit-line-clamp restricting the height.
                This will prevent us from revealing text hidden by the slider in Safari RSS.
      
              * WebCore.exp: Update symbols for WebKit.
      
      WebKit:
      
              Reviewed by Hyatt.
      
              WebKit part of fix for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result
      
              Updated to use selectionRect instead of visibleSelectionRect.  selectionRect() now returns the visible rect by default.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
              (-[WebHTMLView selectionImageRect]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaa0055b
    • hyatt's avatar
      Land updated continuations outline test. · c9f5b099
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9f5b099
    • hyatt's avatar
      Fix for: · 5efe33df
      hyatt authored
              <rdar://problem/5195272> REGRESSION: broke outline rings for continuations 
              with empty inline containers
              
              http://bugs.webkit.org/show_bug.cgi?id=13667
      
              Make sure to only include collapsed top/bottom margins of the block portion
              of the continuation if we know for sure that we have inline line boxes before
              and after that would prevent the collapse from going further.
      
              In plain English: the focus rings were too tall. :)
      
              Reviewed by beth
      
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::addFocusRingRects):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5efe33df
    • hyatt's avatar
      157e6224
    • hyatt's avatar
      Add layout test for pre-wrap minwidth when a newline is present. · 4ab6597b
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ab6597b
    • hyatt's avatar
      Fix for: · a91b3c27
      hyatt authored
              <rdar://problem/5067235> REGRESSION: Excessively wide table, impossible to resize
      
              The table used white-space: pre-wrap, which is supported only by WebKit.  There
              was a bug with the computation of min pref width for pre-wrap text.
      
              Reviewed by mitzpettel
      
              fast/text/white-space/pre-wrap-line-test.html
      
              * rendering/RenderText.cpp:
              (WebCore::RenderText::calcPrefWidths):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a91b3c27
    • beidson's avatar
      Reviewed by Oliver · a3c2abfd
      beidson authored
              Cleanup from my earlier Java Applet patch.  We should keep a central location to query if 
              a mime type counts as a Java Applet
      
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::containsJavaApplet): Query MimeTypeRegistry on the type
      
              * platform/MimeTypeRegistry.cpp:
              (WebCore::MimeTypeRegistry::isSupportedImageMIMEType): Update style
              (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType): Ditto
              (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType): Ditto
              (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Perform the Java Applet check
              * platform/MimeTypeRegistry.h:
      
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::updateWidget): Query MimeTypeRegistry on the type
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3c2abfd
    • bdakin's avatar
      Reviewed by Darin. · 9b7eceff
      bdakin authored
              Fix for <rdar://problem/5191941> Leopard: Adobe Acrobat 8: 
              Distiller 8 needs same check fix as 4992521
      
              * WebView/WebView.mm:
              (-[WebView _updateWebCoreSettingsFromPreferences:]): Adobe 
              Distiller needs the same quirk.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b7eceff
    • pyeh's avatar
      <rdar://problem/4720109> Sentence textMarker methods do not work well with empty lines · d965fbe3
      pyeh authored
      Add expected result for move-by-sentence-linebreak test case.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d965fbe3
    • pyeh's avatar
      <rdar://problem/4720109> Sentence textMarker methods do not work well with empty lines · 21322a9a
      pyeh authored
      Add a testcase to exercise moving insertion point forward by sentence across lines of text that 
      includes empty lines.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21322a9a
    • pyeh's avatar
      <rdar://problem/4720109> Sentence textMarker methods do not work well with empty lines · 0ce5b353
      pyeh authored
              
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]):
              (-[WebCoreAXObject doAXPreviousSentenceStartTextMarkerForTextMarker:]):
              When a marker position is given, the sentence ax methods automatically shift position by one to make sure
              not to ask for the current sentence again.  This is generally fine except when the position
              shift over an empty line break, which is should be considered a separate sentence. In this case, 
              if we used the shifted position to ask for sentence boundary, ICU parser is not given the text data
              containing the newline to correctly determine the sentence boundary.  Since the ax sentence method is 
              explicitly shifting the position to ask for sentence boundary, it should make sure not to skip over important
              character that can be a standalone sentence.
              * editing/visible_units.cpp:
              (WebCore::nextBoundary):
              When determining boundary, don't stop on a collapsed range, such as newline.  
              Just pick the next valid position to use as boundary.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ce5b353
    • lars's avatar
      Reviewed by Zack · a650076d
      lars authored
              Fix our last three test failures in the JavaScript
              tests.
      
      	Without change 21367 we would have been at 0 failures
              in javascript and layout tests now... ;-)
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a650076d
    • mjs's avatar
      LayoutTests: · 8d620d5e
      mjs authored
              Reviewed by Oliver.
              
              - new test case for:
              <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
              <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
      
              (The test case covers both scenarios.)
      
              * http/tests/misc/frame-access-during-load-expected.checksum: Added.
              * http/tests/misc/frame-access-during-load-expected.png: Added.
              * http/tests/misc/frame-access-during-load-expected.txt: Added.
              * http/tests/misc/frame-access-during-load.html: Added.
      
              - test results beneficially or harmlessly changed as a result of the above fixes
      
              * css2.1/t0801-c412-hz-box-00-b-a-expected.checksum:
              * css2.1/t0801-c412-hz-box-00-b-a-expected.png:
              * css2.1/t0801-c412-hz-box-00-b-a-expected.txt: This reflects an <object> containing
              an image now creating an image renderer.
      
              * dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt: This is updated to a slightly
              less bad failure for access to a frame that's not loaded yet.
      
              The following test results now reflect the frame removal that the test was testing:
              
              * fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum:
              * fast/dom/clientWidthAfterDocumentIsRemoved-expected.png:
              * fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
              * fast/dom/replaceChild-expected.checksum:
              * fast/dom/replaceChild-expected.png:
              * fast/dom/replaceChild-expected.txt:
      
              The following tests results now reflect empty document content for iframes that never load anything:
              
              * fast/events/focusingUnloadedFrame-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt:
      
      WebCore:
      
              Reviewed by Oliver.
      
              - WebCore part of fix for:
              <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
              <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
      
              The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
              so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.
              
              However, this caused many regressions so I had to fix the fallout.
              
              * WebCore.exp: fix symbol exports
              * bindings/js/kjs_window.cpp:
              (KJS::createNewWindow): useless "created" bool (we don't need it here)
              (KJS::WindowFunc::callAsFunction): detect if we created a new frame, because if so,
              we need to initialize the domain (can't count on it not having a document), also
              don't try to make a new document for it.
              Also, stop properly.
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector): don't count on document having a view here
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::isImageType): Ask client, to match how other <object> renderer
              decisions are made.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::FrameLoader): Initialize new data members
              (WebCore::FrameLoader::init): Do the slightly tricky sequence of steps to properly make
              an empty document with everything hooked up.
              (WebCore::FrameLoader::createWindow): Added "created" bool.
              (WebCore::FrameLoader::stopLoading): (whitespace change)
              (WebCore::FrameLoader::begin): Don't try to create an empty document.
              (WebCore::FrameLoader::finishedParsing): If creating an initial empty document, don't
              do any of this work.
              (WebCore::FrameLoader::checkCompleted): Do checkLoadComplete() as well.
              (WebCore::FrameLoader::baseURL): don't check for null document
              (WebCore::FrameLoader::baseTarget): ditto
              (WebCore::FrameLoader::completeURL): ditto
              (WebCore::FrameLoader::didTellBridgeAboutLoad): ditto
              (WebCore::FrameLoader::scheduleLocationChange): determine duringLoad differently; doc won't
              be null.
              (WebCore::FrameLoader::gotoAnchor): don't check for null document
              (WebCore::FrameLoader::canTarget): don't check for null document
              (WebCore::FrameLoader::stopForUserCancel): new method for explicit stops like window.stop().
              (WebCore::FrameLoader::transitionToCommitted): check for pre-loaded state properly
              (WebCore::FrameLoader::createEmptyDocument): removed
              (WebCore::FrameLoader::checkLoadCompleteForThisFrame): don't send delegate callbacks when making initial
              doc.
              (WebCore::FrameLoader::tokenizerProcessedData): Assume document; just checkCompleted now that it
              does checkLoadComplete.
              (WebCore::FrameLoader::receivedMainResourceError): assume document
              (WebCore::FrameLoader::saveDocumentState): Assume there's a document except during initial load
              (WebCore::FrameLoader::mainReceivedCompleteError): do checkCompleted, not checkLoadComplete
              (WebCore::FrameLoader::continueLoadWithData): assume document
              * loader/FrameLoader.h:
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::receivedError): Add more ref protection and do things in a slightly
              different order.
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::document): don't force document creation, just assert there is one.
              * page/Frame.cpp:
              (WebCore::Frame::init): Added init method.
              (WebCore::Frame::pageDestroyed): when a frame is removed, make sure to check if the parent is
              done loading.
              * page/Frame.h:
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): No need to force
              document.
              (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): ditto
              * platform/graphics/svg/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged): init the frame
              * rendering/RenderPart.cpp:
              (WebCore::RenderPart::updateWidgetPosition): If a subframe needs layout, then lay it out even
              if the bounds did not change; the content size might be wrong.
              * rendering/RenderTreeAsText.cpp:
              (WebCore::externalRepresentation): Don't crash if the frame lacks a view.
      
      WebKit:
      
              Reviewed by Oliver.
      
              - WebKit part of fix for:
              <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
              <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
      
              The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
              so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.
              
              However, this caused many regressions so I had to fix the fallout.
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::takeFocus): Avoid focus cycle problems (can happen in DumpRenderTree
              with initial empty document now).
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]): init the frame.
              (-[WebFrameBridge determineObjectFromMIMEType:URL:]): return image type when appropriate
              * WebView/WebFrame.mm:
              (-[WebFrame stopLoading]): use stopForUserCancel().
              * WebView/WebFrameView.mm:
              (-[WebFrameView _makeDocumentViewForDataSource:]): assume html when no mime type available.
              * WebView/WebView.mm:
              (-[WebView becomeFirstResponder]): Track whether we are becoming first responder from
              outside the view.
              (-[WebView _becomingFirstResponderFromOutside]): Return this value.
              * WebView/WebViewInternal.h:
      
      WebKitTools:
      
              Reviewed by Oliver.
              
              - don't clear events whenever an EventSendingController goes away, only do it at predictable times, 
              since destroying a subframe can make one go away
              
              (Discovered while fixing:
              
              <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
              <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
      
              * DumpRenderTree/DumpRenderTree.m:
              (runTest): explicitly clear saved events after every page load
              * DumpRenderTree/EventSendingController.h:
              * DumpRenderTree/EventSendingController.m:
              (-[EventSendingController dealloc]): don't clear saved events here...
              (+[EventSendingController clearSavedEvents]): do it here
              * Scripts/check-for-global-initializers:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d620d5e
    • hyatt's avatar
      Add layout test for 13654. · 13eb12b2
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13eb12b2
    • hyatt's avatar
      Fix for: · 1ec32079
      hyatt authored
              <rdar://problem/5146757> REGRESSION: div that wrapped to screen width in 
              tiger no longer wraps
              
              http://bugs.webkit.org/show_bug.cgi?id=13654
      
              Reviewed by mitz
      
              fast/text/whitespace/normal-after-nowrap-breaking.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::calcInlinePrefWidths):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ec32079
    • bdash's avatar
      2007-05-10 Mark Rowe <mrowe@apple.com> · de2e4993
      bdash authored
              Build fix for DumpRenderTree. Enable Objective-C exceptions in Release configuration.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de2e4993
    • hyatt's avatar
      Fix for: · 09a6a711
      hyatt authored
              <rdar://problem/4778099> Links with nested continuations fail to 
              paint their outlines (11255)
              
              http://bugs.webkit.org/show_bug.cgi?id=11255
      
              Fix multiple bugs with outline painting of continuations to ensure that
              all combos work (empty/full inline - block with/without margins - 
              empty/full inline).
      
              Reviewed by mitz
      
              fast/inline/continuation-outlines.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintObject):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::addFocusRingRects):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09a6a711
    • hyatt's avatar
      Add continuation outline drawing test. · 092bac33
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      092bac33
    • hyatt's avatar
      Add layout test to cover RTL overflow issue. · 0d649156
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d649156
    • hyatt's avatar
      Fix for: · 1c58a8ed
      hyatt authored
              <rdar://problem/5193529> REGRESSION: RTL Overflows scrollbar not showing 
              when they should be
              
              Fallout from fix for bug 11926.  Make sure to restrict the fix to the
              RenderView for now, since the full-blown overflow case is pretty involved.
      
              Reviewed by mitzpettel
      
              fast/overflow/unreachable-content-bug-rtl.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::lowestPosition):
              (WebCore::RenderBlock::rightmostPosition):
              (WebCore::RenderBlock::leftmostPosition):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c58a8ed
    • beidson's avatar
      LayoutTests: · 1564c5ef
      beidson authored
              Reviewed by Oliver
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=13636 and <rdar://problem/5190816>
      
              When creating the applets collection, be sure to only count Objects if they contain
              a java applet
      
              * dom/html/level2/html/AppletsCollection-expected.txt: Added.
              * dom/html/level2/html/AppletsCollection.html: Added.
      
      WebCore:
      
              Reviewed by Oliver
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=13636 and <rdar://problem/5190816>
      
              When creating the applets collection, be sure to only count Objects if they contain
              a java applet
      
              * html/HTMLCollection.cpp:
              (WebCore::HTMLCollection::traverseNextItem): Add the qualifier for Objects that 
                containsJavaApplet() must be true
      
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::containsJavaApplet): Check this Object element and inner
                nodes for any Java applets
              * html/HTMLObjectElement.h: 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1564c5ef
    • hyatt's avatar
      Fix for: · 0e9d9243
      hyatt authored
              <rdar://problem/4694859> SAP: HTML tags with overflow:hidden consume
              space on page, do not consume space in Firefox (11926)
      
              http://bugs.webkit.org/show_bug.cgi?id=11926
      
              Make sure that unreachable objects along one axis (e.g., top/left) do not
              contribute to the scrollable area in the opposite axis (e.g., right/bottom).
      
              Reviewed by olliej
      
              fast/overflow/unreachable-content-test.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::lowestPosition):
              (WebCore::RenderBlock::rightmostPosition):
              (WebCore::RenderBlock::leftmostPosition):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e9d9243
    • hyatt's avatar
      Add layout test for bug 11926. · dd3344a5
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd3344a5
    • hyatt's avatar
      Add layout test for opacity/letter-spacing bug. · bfc56adc
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfc56adc
    • hyatt's avatar
      Fix for: · 71985313
      hyatt authored
              <rdar://problem/4656825> REGRESSION: Japanese TV time table widget:
              part of the number in background has been cut off.
      
              Now that opacity uses a tight bounding box to clip, we need to make sure
              to factor spillout caused by negative letter spacing into our right
              overflow.  Latch on to the code that does this already for text-stroke
              and text-shadow.
      
              Reviewed by olliej
      
              fast/text/letter-spacing-negative-opacity.html
      
             * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71985313
    • ggaren's avatar
      LayoutTests: · 54f8e1b6
      ggaren authored
              Reviewed by Maciej Stachowiak.
              
              Tests for more fix-ups to the WebScriptObject/WebScripting APIs, related to
              <rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView 
              or WebFrame
      
              * fast/dom/wrapper-classes-expected.txt:
              * fast/dom/wrapper-classes.html: Added cases to test the wrapper classes
              for different data types sent across the JS/ObjC bridge.
              * fast/dom/wrapper-round-tripping-expected.txt: Added.
              * fast/dom/wrapper-round-tripping.html: Added. New test to verify that
              you can round-trip between a JSObjectRef and a WebScriptObject.
      
      WebCore:
      
              Reviewed by Maciej Stachowiak.
              
              More fix-ups to the WebScriptObject/WebScripting APIs, related to
              <rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView 
              or WebFrame
      
              * bindings/objc/WebScriptObject.h: Fully specified the surprising rules for
              type conversion between JavaScript and ObjC.
              * bindings/objc/WebScriptObject.mm: Added up-call accessor to WebFrame.
              This is kind of stinky, but I'm OK with it because eventually all of this
              code should move up into WebKit.
              (+[WebScriptObject scriptObjectForJSObject:frame:]):
              (-[WebScriptObject valueForKey:]):
              (-[WebScriptObject JSObject]): 
                  - Added _rootObject check because if _rootObject returns NULL it means 
                  that _imp is no longer GC protected, so it's not safe to use. 
                  - Added _isSafeScript check because that's what WebScriptObject methods
                  typically do, even though the value of doing so isn't clear to me.
              * bindings/objc/WebScriptObjectPendingPublic.h: Added WebFrame* parameter
              to -scriptObjectForJSObject:. This is required to wrap JS objects that
              are not already in the wrapper cache. It would be nice to remove this
              limitation of WebScriptObject some day.
              * page/mac/FrameMac.mm:
              (WebCore::Frame::cleanupPlatformScriptObjects): Force removal of m_windowScriptObject
              from the cache, to avoid retrieving the m_windowScriptObject from the previous
              page on a new page load. (It would be non-functional in that case.)
      
      WebKitTools:
      
              Reviewed by Maciej Stachowiak.
              
              Added support for testing ObjC/JS type bridging.
              
              Added ASSERT that -JSObject returns nil when the underlying JSObject
              is no longer GC protected.
      
              * DumpRenderTree/DumpRenderTree.m:
              (returnThisCallback):
              (returnThisClass):
              (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (+[LayoutTestController webScriptNameForSelector:]):
              (-[LayoutTestController accessStoredWebScriptObject]):
              (-[LayoutTestController testWrapperRoundTripping]):
              (-[LayoutTestController objCClassNameOf:]):
              (-[LayoutTestController objCObjectOfClass:]):
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54f8e1b6
    • lars's avatar
      Add missing test result. · 009b4d9e
      lars authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      009b4d9e