1. 30 Oct, 2010 1 commit
    • dglazkov@chromium.org's avatar
      2010-10-30 Dimitri Glazkov <dglazkov@chromium.org> · 55a42461
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
              https://bugs.webkit.org/show_bug.cgi?id=46015
      
              Tuned the test to better reflect its point: the event should indeed fire (it used to be swallowed),
              but its target should be a non-shadow node.
      
              * fast/events/shadow-boundary-crossing.html: Modified the test.
      2010-10-30  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
              https://bugs.webkit.org/show_bug.cgi?id=46015
      
              This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
              for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.
      
              This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
              appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.
      
              * Android.mk: Added EventContext, WindowEventContext files.
              * CMakeLists.txt: Ditto.
              * GNUmakefile.am: Ditto.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * dom/ContainerNode.cpp:
              (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
              * dom/EventContext.cpp: Added.
              * dom/EventContext.h: Added.
              * dom/Node.cpp:
              (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware.
              (WebCore::Node::createRendererIfNeeded): Ditto.
              (WebCore::Node::parentOrHostNode): Added new helper method.
              (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware.
              (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one.
              (WebCore::Node::eventAncestors): Refactored to collect a vector of EventContexts.
              (WebCore::Node::topEventContext): Added.
              (WebCore::eventHasListeners): Changed to use EventContexts.
              (WebCore::Node::dispatchGenericEvent): Ditto.
              * dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,
                  and changed signature of eventAncestors to use EventContexts.
              * dom/Text.cpp:
              (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
              * svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
              * svg/SVGElement.h: Ditto.
              * dom/WindowEventContext.cpp: Added.
              * dom/WindowEventContext.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55a42461
  2. 29 Oct, 2010 5 commits
    • mrowe@apple.com's avatar
      Roll out r70847 as it causes crashes when typing text in both Safari and Mail:... · 856d3c12
      mrowe@apple.com authored
      Roll out r70847 as it causes crashes when typing text in both Safari and Mail: <http://webkit.org/b/48708>.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      856d3c12
    • commit-queue@webkit.org's avatar
      2010-10-29 Kavita Kanetkar <kkanetkar@chromium.org> · 39b6c6d1
      commit-queue@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: FileSystem integration
              https://bugs.webkit.org/show_bug.cgi?id=45982
      
              Adding filesystem support for Inspector under storage tab. This fetches root paths for
              temporary and persistent filesystems and allows "reveal folder in OS" option that
              launches native file browser. Currently this feature is disabled for non-chromium platforms.
      
              * CMakeLists.txt:
              * English.lproj/localizedStrings.js:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::releaseFrontendLifetimeAgents):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::fileSystemAgent):
              * inspector/InspectorFileSystemAgent.cpp: Added.
              * inspector/InspectorFileSystemAgent.h: Added.
              * inspector/front-end/FileSystemView.js: Added.
              * inspector/front-end/Settings.js:
              * inspector/front-end/StoragePanel.js:
              (WebInspector.StoragePanel):
              (WebInspector.StoragePanel.prototype.reset):
              (WebInspector.StoragePanel.prototype.addFileSystem):
              (WebInspector.StoragePanel.prototype.showFileSystem):
              (WebInspector.StoragePanel.prototype.updateFileSystemPath):
              (WebInspector.StoragePanel.prototype.updateFileSystemError):
              (WebInspector.FileSystemTreeElement):
              (WebInspector.FileSystemTreeElement.prototype.onselect):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.css:
              (.file-system-storage-tree-item .icon):
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector.updateResource):
              (WebInspector._addFileSystemOrigin):
              (WebInspector.didGetFileSystemPath):
              (WebInspector.didGetFileSystemError):
              (WebInspector.reset):
              * platform/AsyncFileSystem.h:
              (WebCore::AsyncFileSystem::root):
              * platform/FileSystem.h:
              * platform/chromium/ChromiumBridge.h:
              * platform/chromium/FileSystemChromium.cpp:
              (WebCore::revealFolderInOS):
      2010-10-29  Kavita Kanetkar  <kkanetkar@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: FileSystem integration
              https://bugs.webkit.org/show_bug.cgi?id=45982
      
              * public/WebFileUtilities.h:
              (WebKit::WebFileUtilities::revealFolderInOS):
              * src/ChromiumBridge.cpp:
              (WebCore::ChromiumBridge::revealFolderInOS):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39b6c6d1
    • jianli@chromium.org's avatar
      Support readAsArrayBuffer in FileReader and FileReaderSync · a8c47de0
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=47691
      
      Reviewed by David Levin.
      
      WebCore:
      
      Merge the similar code in FileReader and FileReaderSync into
      FileReaderLoader.
      
      Test cases have been added to read-file-test-cases.js.
      
      * Android.jscbindings.mk:
      * CMakeLists.txt:
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/v8/custom/V8FileReaderCustom.cpp: Added.
      * fileapi/FileReader.cpp:
      (WebCore::FileReader::FileReader):
      (WebCore::FileReader::readAsArrayBuffer):
      (WebCore::FileReader::readAsBinaryString):
      (WebCore::FileReader::readAsText):
      (WebCore::FileReader::readAsDataURL):
      (WebCore::FileReader::readInternal):
      (WebCore::FileReader::doAbort):
      (WebCore::FileReader::terminate):
      (WebCore::FileReader::start):
      (WebCore::FileReader::didStartLoading):
      (WebCore::FileReader::didReceiveData):
      (WebCore::FileReader::didFinishLoading):
      (WebCore::FileReader::didFail):
      (WebCore::FileReader::fireEvent):
      (WebCore::FileReader::arrayBufferResult):
      (WebCore::FileReader::stringResult):
      * fileapi/FileReader.h:
      (WebCore::FileReader::readType):
      * fileapi/FileReader.idl:
      * fileapi/FileReaderLoader.cpp: Added.
      * fileapi/FileReaderLoader.h: Added.
      * fileapi/FileReaderLoaderClient.h: Added.
      * fileapi/FileReaderSync.cpp:
      (WebCore::FileReaderSync::FileReaderSync):
      (WebCore::FileReaderSync::readAsArrayBuffer):
      (WebCore::FileReaderSync::readAsBinaryString):
      (WebCore::FileReaderSync::readAsText):
      (WebCore::FileReaderSync::readAsDataURL):
      (WebCore::FileReaderSync::startLoading):
      * fileapi/FileReaderSync.h:
      * fileapi/FileReaderSync.idl:
      * html/canvas/ArrayBuffer.cpp:
      (WebCore::ArrayBuffer::create):
      * html/canvas/ArrayBuffer.h:
      * loader/ThreadableLoaderClient.h:
      
      LayoutTests:
      
      * fast/files/read-file-async-expected.txt:
      * fast/files/resources/read-common.js:
      (readBlobAsArrayBuffer):
      (_readBlobAsArrayBufferAsync):
      (_readBlobAsArrayBufferSync):
      (_readBlobAsBinaryStringSync):
      (_readBlobAsTextSync):
      (_readBlobAsDataURLSync):
      (logResult):
      (loaded):
      (_toString):
      (_isASCIIString):
      (_toHexadecimal):
      (_getElementAt):
      * fast/files/resources/read-file-test-cases.js:
      (testReadingNonExistentFileAsArrayBuffer):
      (testReadingEmptyFileAsArrayBuffer):
      (testReadingUTF8EncodedFileAsArrayBuffer):
      (testReadingBinaryFileAsArrayBuffer):
      (testMultipleReads):
      * fast/files/workers/resources/worker-read-file-sync.js:
      (testMultipleReadsSync):
      * fast/files/workers/worker-read-blob-sync-expected.txt:
      * fast/files/workers/worker-read-file-async-expected.txt:
      * fast/files/workers/worker-read-file-sync-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8c47de0
    • commit-queue@webkit.org's avatar
      2010-10-29 Kenichi Ishibashi <bashi@google.com> · 691d04f1
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              [HTML5] Add DOMSettableTokenList
              https://bugs.webkit.org/show_bug.cgi?id=47810
      
              * fast/dom/Window/window-properties-expected.txt: Updated expectations.
              * fast/dom/Window/window-property-descriptors-expected.txt: Updated expectations.
              * fast/dom/prototype-inheritance-2-expected.txt: Updated expectations.
              * fast/dom/prototype-inheritance-expected.txt: Updated expectations.
              * fast/js/global-constructors-expected.txt: Updated expectations.
      2010-10-29  Kenichi Ishibashi  <bashi@google.com>
      
              Reviewed by Kent Tamura.
      
              [HTML5] Add DOMSettableTokenList
              https://bugs.webkit.org/show_bug.cgi?id=47810
      
              Adds DOMSettableTokenList interface to support <output> element.
              The DOMTokenList interface was refactored since its was tightly coupled
              with HTMLElement.classList property.
      
              * Android.derived.jscbindings.mk: Added JSDOMSettableTokenList.h file.
              * Android.derived.v8bindings.mk: Added V8DOMSettableTokenList.h file.
              * Android.jscbindings.mk: Added JSDOMSettableTokenList.cpp file.
              * Android.mk: Added ClassList.cpp file.
              * CMakeLists.txt: Added DOMSettableTokenList.{cpp,idl} and ClassList.cpp files.
              * DerivedSources.cpp: Added JSDOMSettableTokenList.cpp file.
              * DerivedSources.make: Added DOMSettableTokenList entry.
              * GNUmakefile.am: Added JSDOMSettableTokenList.{h,cpp} and ClassList.{h,cpp} files.
              * WebCore.gypi: Added DOMSettableTokenList.{h,cpp,idl}, V8DOMSettableTokenListCustom.cpp and ClassList.{h,cpp} files.
              * WebCore.pri: Added DOMSettableTokenList.idl file.
              * WebCore.pro: Added V8DOMSettableTokenListCustom.cpp, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files.
              * WebCore.vcproj/WebCore.vcproj: Added JSDOMSettableTokenList.{h,cpp}, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files.
              * WebCore.xcodeproj/project.pbxproj: Added ClassList.{h,cpp}, DOMSettabletokenList.{h,cpp} and JSDOMSettableTokenList.{h,cpp}
              * bindings/gobject/GNUmakefile.am: Added WebKitDOMDOMSettableTokenList.{h,cpp} and WebKitDOMDOMSettableTokenListPrivate.cpp files.
              * bindings/scripts/CodeGeneratorJS.pm: Modified IndexGetterReturnsStrings() returns 1 for DOMSettableTokenList.
              * bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Added.
              (WebCore::V8DOMSettableTokenList::indexedPropertyGetter):
              * dom/Element.cpp: Replaced DOMTokenList to ClassList.
              (WebCore::Element::classList):
              * dom/ElementRareData.h: ditto.
              * dom/SpaceSplitString.cpp: Added add() and remove() functions.
              (WebCore::SpaceSplitStringData::add):
              (WebCore::SpaceSplitStringData::remove):
              (WebCore::SpaceSplitString::add):
              (WebCore::SpaceSplitString::remove):
              * dom/SpaceSplitString.h: Added add() and remove() functions.
              * dom/StyledElement.cpp: Replaced DOMTokenList to ClassList.
              (WebCore::StyledElement::classAttributeChanged):
              * dom/StyledElement.h: ditto.
              * html/ClassList.cpp: Added, mostly from original DOMTokenList.cpp.
              (WebCore::ClassList::ClassList):
              (WebCore::ClassList::ref):
              (WebCore::ClassList::deref):
              (WebCore::ClassList::length):
              (WebCore::ClassList::item):
              (WebCore::ClassList::contains):
              (WebCore::ClassList::containsInternal):
              (WebCore::ClassList::add):
              (WebCore::ClassList::addInternal):
              (WebCore::ClassList::remove):
              (WebCore::ClassList::removeInternal):
              (WebCore::ClassList::toggle):
              (WebCore::ClassList::toString):
              (WebCore::ClassList::reset):
              (WebCore::ClassList::classNames):
              * html/ClassList.h: Added, mostly from original DOMTokenList.h.
              (WebCore::ClassList::create):
              (WebCore::ClassList::element):
              * html/DOMSettableTokenList.cpp: Added.
              (WebCore::DOMSettableTokenList::DOMSettableTokenList):
              (WebCore::DOMSettableTokenList::~DOMSettableTokenList):
              (WebCore::DOMSettableTokenList::item):
              (WebCore::DOMSettableTokenList::contains):
              (WebCore::DOMSettableTokenList::add):
              (WebCore::DOMSettableTokenList::addInternal):
              (WebCore::DOMSettableTokenList::remove):
              (WebCore::DOMSettableTokenList::removeInternal):
              (WebCore::DOMSettableTokenList::toggle):
              (WebCore::DOMSettableTokenList::setValue):
              * html/DOMSettableTokenList.h: Added.
              (WebCore::DOMSettableTokenList::create):
              (WebCore::DOMSettableTokenList::ref):
              (WebCore::DOMSettableTokenList::deref):
              (WebCore::DOMSettableTokenList::length):
              (WebCore::DOMSettableTokenList::toString):
              (WebCore::DOMSettableTokenList::value):
              * html/DOMSettableTokenList.idl: Added.
              * html/DOMTokenList.cpp: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList.
              (WebCore::DOMTokenList::validateToken): Changed to be a static member function of DOMTokenList.
              (WebCore::DOMTokenList::addToken): Added, mostly from original DOMTokenList::addInternal().
              (WebCore::DOMTokenList::removeToken): Added, mostly from original DOMTokenList::removeInternal().
              * html/DOMTokenList.h: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList.
              (WebCore::DOMTokenList::~DOMTokenList):
              (WebCore::DOMTokenList::element):
              * page/DOMWindow.cpp: Added an entry for DOMSettableTokenList.
              * page/DOMWindow.idl: ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      691d04f1
    • morrita@google.com's avatar
      2010-10-26 MORITA Hajime <morrita@google.com> · e8fba76f
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              Refactoring: Spellchecking related static functions could form a class
              https://bugs.webkit.org/show_bug.cgi?id=48287
      
              Extracted spellcheck related static functions to TextCheckingHelper class,
              which has EditorClient and Range as its member.
      
              No new tests. Just a refactoring.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * editing/Editor.cpp:
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::isSelectionUngrammatical):
              (WebCore::Editor::guessesForUngrammaticalSelection):
              (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
              (WebCore::Editor::markMisspellingsAfterTypingToPosition):
              (WebCore::Editor::markMisspellingsOrBadGrammar):
              (WebCore::Editor::markMisspellings):
              (WebCore::Editor::markBadGrammar):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::changeBackToReplacedString):
              * editing/Editor.h:
              * editing/TextCheckingHelper.cpp: Added.
              (WebCore::TextCheckingHelper::TextCheckingHelper):
              (WebCore::TextCheckingHelper::~TextCheckingHelper):
              (WebCore::TextCheckingHelper::paragraphAlignedRange):
              (WebCore::TextCheckingHelper::findFirstMisspelling):
              (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
              (WebCore::TextCheckingHelper::findFirstGrammarDetail):
              (WebCore::TextCheckingHelper::findFirstBadGrammar):
              (WebCore::TextCheckingHelper::isUngrammatical):
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
              (WebCore::TextCheckingHelper::markAllMisspellings):
              (WebCore::TextCheckingHelper::markAllBadGrammar):
              * editing/TextCheckingHelper.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8fba76f
  3. 25 Oct, 2010 1 commit
    • tkent@chromium.org's avatar
      2010-10-25 Kent Tamura <tkent@chromium.org> · 61684f1a
      tkent@chromium.org authored
              Reviewed by Darin Adler.
      
              Refactor HTMLInputElement: Move createRender(), appendFormData(),
              saveFormControlState() and restoreFormControlState() to InputTypes.
              https://bugs.webkit.org/show_bug.cgi?id=47834
      
              This change adds BaseButtonInputType and BaseCheckableInputType. They
              are super classes of some concrete InputType classes.
      
              No new tests. Just a code refactoring.
      
              * CMakeLists.txt: Add BaseButtonInputType and BaseCheckableInputType files.
              * GNUmakefile.am: ditto.
              * WebCore.gypi: ditto.
              * WebCore.pro: ditto.
              * WebCore.vcproj/WebCore.vcproj: ditto.
              * WebCore.xcodeproj/project.pbxproj: ditto.
              * html/BaseButtonInputType.cpp: Added.
              (WebCore::BaseButtonInputType::appendFormData):
              (WebCore::BaseButtonInputType::createRenderer):
              * html/BaseButtonInputType.h: Added.
              (WebCore::BaseButtonInputType::BaseButtonInputType):
              * html/BaseCheckableInputType.cpp: Added.
              (WebCore::BaseCheckableInputType::saveFormControlState):
              (WebCore::BaseCheckableInputType::restoreFormControlState):
              (WebCore::BaseCheckableInputType::appendFormData):
              * html/BaseCheckableInputType.h: Added.
              (WebCore::BaseCheckableInputType::BaseCheckableInputType):
              * html/ButtonInputType.h: Change the super class.
              (WebCore::ButtonInputType::ButtonInputType):
              * html/CheckboxInputType.h: Change the super class.
              (WebCore::CheckboxInputType::CheckboxInputType):
              * html/FileInputType.cpp:
              (WebCore::FileInputType::appendFormData):
              (WebCore::FileInputType::createRenderer):
              * html/FileInputType.h: Change the super class.
              (WebCore::FileInputType::FileInputType):
              * html/HTMLFormControlElement.h:
                Make placeholderShouldBeVisible() public for access from TextFieldInputType.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::saveFormControlState):
              (WebCore::HTMLInputElement::restoreFormControlState):
              (WebCore::HTMLInputElement::createRenderer):
              (WebCore::HTMLInputElement::appendFormData):
              * html/HTMLInputElement.h:
                Add the following functions for ImageInputType and SubmitInputType.
              (WebCore::HTMLInputElement::xPosition):
              (WebCore::HTMLInputElement::yPosition):
              * html/HiddenInputType.cpp:
              (WebCore::HiddenInputType::createRenderer):
              * html/HiddenInputType.h:
              * html/ImageInputType.cpp:
              (WebCore::ImageInputType::isFormDataAppendable):
              (WebCore::ImageInputType::appendFormData):
              (WebCore::ImageInputType::createRenderer):
              * html/ImageInputType.h: Change the super class.
              (WebCore::ImageInputType::ImageInputType):
              * html/InputType.cpp:
              (WebCore::InputType::saveFormControlState):
              (WebCore::InputType::restoreFormControlState):
              (WebCore::InputType::isFormDataAppendable):
              (WebCore::InputType::appendFormData):
              (WebCore::InputType::createRenderer):
              * html/InputType.h:
              * html/PasswordInputType.cpp:
              (WebCore::PasswordInputType::saveFormControlState):
              (WebCore::PasswordInputType::restoreFormControlState):
              * html/PasswordInputType.h:
              * html/RadioInputType.h: Change the super class.
              (WebCore::RadioInputType::RadioInputType):
              * html/RangeInputType.cpp:
              (WebCore::RangeInputType::createRenderer):
              * html/RangeInputType.h:
              * html/ResetInputType.h:
              (WebCore::ResetInputType::ResetInputType):
              * html/SubmitInputType.cpp:
              (WebCore::SubmitInputType::appendFormData):
              * html/SubmitInputType.h: Change the super class.
              (WebCore::SubmitInputType::SubmitInputType):
              * html/TextFieldInputType.cpp:
              (WebCore::TextFieldInputType::createRenderer):
              * html/TextFieldInputType.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61684f1a
  4. 22 Oct, 2010 2 commits
    • yurys@chromium.org's avatar
      2010-10-21 Yury Semikhatsky <yurys@chromium.org> · 95859ed4
      yurys@chromium.org authored
              Unreviewed, rolling out r70298.WebKit win compilation failure.
              http://trac.webkit.org/changeset/70298
              https://bugs.webkit.org/show_bug.cgi?id=48122
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95859ed4
    • yurys@chromium.org's avatar
      2010-10-21 Yury Semikhatsky <yurys@chromium.org> · f1e6db40
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: decouple ScriptArguments from ScriptCallStack
              https://bugs.webkit.org/show_bug.cgi?id=48058
      
              ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8.
              The factory functions that allow to create ScriptCallStack from VM-specific
              objects are defined in ScriptCallStackFactory.cpp.
      
              ScriptArguments class is used for passing arguments from JS code to the native
              part.
      
              No new tests. This refactoring is covered with existing Console tests.
      
              * WebCore.gypi:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/ScriptCallFrame.cpp: Removed.
              * bindings/js/ScriptCallFrame.h: Removed.
              * bindings/js/ScriptCallStack.cpp: Removed.
              * bindings/js/ScriptCallStack.h: Removed.
              * bindings/js/ScriptCallStackFactory.cpp: Added.
              (WebCore::createScriptCallStack):
              (WebCore::createScriptArguments):
              (WebCore::ScriptCallStack::stackTrace):
              * bindings/js/ScriptCallStackFactory.h: Added.
              * bindings/js/ScriptState.h:
              (WebCore::ScriptStateProtectedPtr::get):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/ScriptCallFrame.cpp: Removed.
              * bindings/v8/ScriptCallFrame.h: Removed.
              * bindings/v8/ScriptCallStack.cpp: Removed.
              * bindings/v8/ScriptCallStack.h: Removed.
              * bindings/v8/ScriptCallStackFactory.cpp: Added.
              (WebCore::toScriptCallFrame):
              (WebCore::toScriptCallFramesVector):
              (WebCore::createScriptCallStack):
              (WebCore::createScriptArguments):
              (WebCore::ScriptCallStack::stackTrace):
              * bindings/v8/ScriptCallStackFactory.h: Added.
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
              * bindings/v8/ScriptState.h:
              (WebCore::ScriptStateProtectedPtr::get):
              * bindings/v8/V8ConsoleMessage.cpp:
              (WebCore::V8ConsoleMessage::handler):
              (WebCore::V8ConsoleMessage::dispatchNow):
              * bindings/v8/V8ConsoleMessage.h:
              * bindings/v8/custom/V8ConsoleCustom.cpp:
              (WebCore::V8Console::traceCallback):
              (WebCore::V8Console::assertCallback):
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              (WebCore::ConsoleMessage::addToFrontend):
              (WebCore::ConsoleMessage::updateRepeatCountInConsole):
              (WebCore::ConsoleMessage::isEqual):
              * inspector/ConsoleMessage.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::addMessageToConsole):
              (WebCore::InspectorController::startGroup):
              * inspector/InspectorController.h:
              * inspector/ScriptArguments.cpp: Added.
              (WebCore::ScriptArguments::ScriptArguments):
              (WebCore::ScriptArguments::~ScriptArguments):
              (WebCore::ScriptArguments::argumentAt):
              (WebCore::ScriptArguments::globalState):
              (WebCore::ScriptArguments::getFirstArgumentAsString):
              (WebCore::ScriptArguments::isEqual):
              * inspector/ScriptArguments.h: Added.
              (WebCore::ScriptArguments::argumentCount):
              * inspector/ScriptCallFrame.cpp: Added.
              (WebCore::ScriptCallFrame::ScriptCallFrame):
              (WebCore::ScriptCallFrame::~ScriptCallFrame):
              (WebCore::ScriptCallFrame::isEqual):
              (WebCore::ScriptCallFrame::buildInspectorObject):
              * inspector/ScriptCallFrame.h: Added.
              (WebCore::ScriptCallFrame::functionName):
              (WebCore::ScriptCallFrame::sourceURL):
              (WebCore::ScriptCallFrame::lineNumber):
              * inspector/ScriptCallStack.cpp: Added.
              (WebCore::ScriptCallStack::ScriptCallStack):
              (WebCore::ScriptCallStack::~ScriptCallStack):
              (WebCore::ScriptCallStack::at):
              (WebCore::ScriptCallStack::size):
              (WebCore::ScriptCallStack::isEqual):
              (WebCore::ScriptCallStack::buildInspectorObject):
              * inspector/ScriptCallStack.h: Added.
              * page/Console.cpp:
              (WebCore::Console::addMessage):
              (WebCore::Console::debug):
              (WebCore::Console::error):
              (WebCore::Console::info):
              (WebCore::Console::log):
              (WebCore::Console::dir):
              (WebCore::Console::dirxml):
              (WebCore::Console::trace):
              (WebCore::Console::assertCondition):
              (WebCore::Console::count):
              (WebCore::Console::markTimeline):
              (WebCore::Console::profile):
              (WebCore::Console::profileEnd):
              (WebCore::Console::timeEnd):
              (WebCore::Console::group):
              (WebCore::Console::groupCollapsed):
              (WebCore::Console::shouldCaptureFullStackTrace):
              (WebCore::Console::warn):
              * page/Console.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1e6db40
  5. 21 Oct, 2010 2 commits
    • yurys@chromium.org's avatar
      2010-10-21 Yury Semikhatsky <yurys@chromium.org> · afeee581
      yurys@chromium.org authored
              Unreviewed. Revert r70232. Chromium compilation failure.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afeee581
    • yurys@chromium.org's avatar
      2010-10-21 Yury Semikhatsky <yurys@chromium.org> · 59d720a3
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: decouple ScriptArguments from ScriptCallStack
              https://bugs.webkit.org/show_bug.cgi?id=48058
      
              ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8.
              The factory functions that allow to create ScriptCallStack from VM-specific
              objects are defined in ScriptCallStackFactory.cpp.
      
              ScriptArguments class is used for passing arguments from JS code to the native
              part.
      
              No new tests. This refactoring is covered with existing Console tests.
      
              * WebCore.gypi:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/ScriptCallFrame.cpp: Removed.
              * bindings/js/ScriptCallFrame.h: Removed.
              * bindings/js/ScriptCallStack.cpp: Removed.
              * bindings/js/ScriptCallStack.h: Removed.
              * bindings/js/ScriptCallStackFactory.cpp: Added.
              (WebCore::createScriptCallStack):
              (WebCore::createScriptArguments):
              (WebCore::ScriptCallStack::stackTrace):
              * bindings/js/ScriptCallStackFactory.h: Added.
              * bindings/js/ScriptState.h:
              (WebCore::ScriptStateProtectedPtr::get):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/ScriptCallFrame.cpp: Removed.
              * bindings/v8/ScriptCallFrame.h: Removed.
              * bindings/v8/ScriptCallStack.cpp: Removed.
              * bindings/v8/ScriptCallStack.h: Removed.
              * bindings/v8/ScriptCallStackFactory.cpp: Added.
              (WebCore::toScriptCallFrame):
              (WebCore::toScriptCallFramesVector):
              (WebCore::createScriptCallStack):
              (WebCore::createScriptArguments):
              (WebCore::ScriptCallStack::stackTrace):
              * bindings/v8/ScriptCallStackFactory.h: Added.
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
              * bindings/v8/ScriptState.h:
              (WebCore::ScriptStateProtectedPtr::get):
              * bindings/v8/V8ConsoleMessage.cpp:
              (WebCore::V8ConsoleMessage::handler):
              (WebCore::V8ConsoleMessage::dispatchNow):
              * bindings/v8/V8ConsoleMessage.h:
              * bindings/v8/custom/V8ConsoleCustom.cpp:
              (WebCore::V8Console::traceCallback):
              (WebCore::V8Console::assertCallback):
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::ConsoleMessage):
              (WebCore::ConsoleMessage::addToFrontend):
              (WebCore::ConsoleMessage::updateRepeatCountInConsole):
              (WebCore::ConsoleMessage::isEqual):
              * inspector/ConsoleMessage.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::addMessageToConsole):
              (WebCore::InspectorController::startGroup):
              * inspector/InspectorController.h:
              * inspector/ScriptArguments.cpp: Added.
              (WebCore::ScriptArguments::ScriptArguments):
              (WebCore::ScriptArguments::~ScriptArguments):
              (WebCore::ScriptArguments::argumentAt):
              (WebCore::ScriptArguments::globalState):
              (WebCore::ScriptArguments::getFirstArgumentAsString):
              (WebCore::ScriptArguments::isEqual):
              * inspector/ScriptArguments.h: Added.
              (WebCore::ScriptArguments::argumentCount):
              * inspector/ScriptCallFrame.cpp: Added.
              (WebCore::ScriptCallFrame::ScriptCallFrame):
              (WebCore::ScriptCallFrame::~ScriptCallFrame):
              (WebCore::ScriptCallFrame::isEqual):
              (WebCore::ScriptCallFrame::buildInspectorObject):
              * inspector/ScriptCallFrame.h: Added.
              (WebCore::ScriptCallFrame::functionName):
              (WebCore::ScriptCallFrame::sourceURL):
              (WebCore::ScriptCallFrame::lineNumber):
              * inspector/ScriptCallStack.cpp: Added.
              (WebCore::ScriptCallStack::ScriptCallStack):
              (WebCore::ScriptCallStack::~ScriptCallStack):
              (WebCore::ScriptCallStack::at):
              (WebCore::ScriptCallStack::size):
              (WebCore::ScriptCallStack::isEqual):
              (WebCore::ScriptCallStack::buildInspectorObject):
              * inspector/ScriptCallStack.h: Added.
              * page/Console.cpp:
              (WebCore::Console::addMessage):
              (WebCore::Console::debug):
              (WebCore::Console::error):
              (WebCore::Console::info):
              (WebCore::Console::log):
              (WebCore::Console::dir):
              (WebCore::Console::dirxml):
              (WebCore::Console::trace):
              (WebCore::Console::assertCondition):
              (WebCore::Console::count):
              (WebCore::Console::markTimeline):
              (WebCore::Console::profile):
              (WebCore::Console::profileEnd):
              (WebCore::Console::timeEnd):
              (WebCore::Console::group):
              (WebCore::Console::groupCollapsed):
              (WebCore::Console::shouldCaptureFullStackTrace):
              (WebCore::Console::warn):
              * page/Console.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59d720a3
  6. 20 Oct, 2010 2 commits
  7. 19 Oct, 2010 2 commits
  8. 18 Oct, 2010 2 commits
    • pfeldman@chromium.org's avatar
      2010-10-18 Pavel Feldman <pfeldman@chromium.org> · 9db33975
      pfeldman@chromium.org authored
              Reviewed by Simon Fraser.
      
              Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
              https://bugs.webkit.org/show_bug.cgi?id=46224
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/InspectorClient.cpp: Added.
              (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
              * inspector/InspectorClient.h:
              (WebCore::InspectorClient::InspectorClient):
      2010-10-18  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
              https://bugs.webkit.org/show_bug.cgi?id=46224
      
              * WebCoreSupport/WebInspectorClientCF.cpp:
              (WebInspectorClient::sendMessageToFrontend):
      2010-10-18  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
              https://bugs.webkit.org/show_bug.cgi?id=46224
      
              * WebCoreSupport/InspectorClientGtk.cpp:
              (WebKit::InspectorClient::sendMessageToFrontend):
      2010-10-18  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
              https://bugs.webkit.org/show_bug.cgi?id=46224
      
              * WebCoreSupport/InspectorClientQt.cpp:
              (WebCore::InspectorClientQt::sendMessageToFrontend):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9db33975
    • commit-queue@webkit.org's avatar
      2010-10-17 Pascal Massimino <pascal.massimino@gmail.com> · 5c2d99a5
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              Add support for WebP image decoding in ImageDecoder
              using library libwebp-decode library available from
              http://www.webmproject.org/code/
      
              https://bugs.webkit.org/show_bug.cgi?id=47512
      
              Tests: fast/images/webp-image-decoding.html
      
              * CMakeLists.txt:
                  add platform/image-decoders/webp files and directory
              * GNUmakefile.am:
                  add platform/image-decoders/webp directory
              * WebCore.gyp/WebCore.gyp:
                  add platform/image-decoders/webp directory
              * WebCore.gypi:
                  add platform/image-decoders/webp directory
              * features.gypi:
                  add WTF_USE_WEBP=1
              * platform/image-decoders/ImageDecoder.cpp:
              (WebCore::ImageDecoder::create):
                  instantiate webp decoder for file starting with 'RIFF????WEBP'
              * platform/image-decoders/webp: Added.
              * platform/image-decoders/webp/WEBPImageDecoder.cpp: Added.
              (WebCore::WEBPImageDecoder::WEBPImageDecoder):
              (WebCore::WEBPImageDecoder::~WEBPImageDecoder):
              (WebCore::WEBPImageDecoder::isSizeAvailable):
              (WebCore::WEBPImageDecoder::frameBufferAtIndex):
              (WebCore::WEBPImageDecoder::decode):
                  sub-class handling decoding of webp images
              * platform/image-decoders/webp/WEBPImageDecoder.h: Added.
              (WebCore::WEBPImageDecoder::filenameExtension):
              (WebCore::WEBPImageDecoder::supportsAlpha):
                  header for webp-decoder sub-class
      2010-10-17  Pascal Massimino  <pascal.massimino@gmail.com>
       
               Reviewed by Adam Barth.
       
               Add support for decoding WebP image
               https://bugs.webkit.org/show_bug.cgi?id=47512
       
               * DEPS:
                 - Add dependency to libwebp.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c2d99a5
  9. 15 Oct, 2010 2 commits
    • abarth@webkit.org's avatar
      2010-10-15 Adam Barth <abarth@webkit.org> · 409e717f
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Move MarkupAccumulator from markup.cpp to its own file
              https://bugs.webkit.org/show_bug.cgi?id=47734
      
              This patch moves the MarkupAccumulator class into its own file.
              There's a lot of clean up left to do, but this patch is a step in the
              right direction.
      
              No behavior change.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * editing/markup.cpp:
              (WebCore::elementCannotHaveEndTag):
              * editing/markup.h:
              * editing/MarkupAccumulator.h: Added.
              * editing/MarkupAccumulator.cpp: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      409e717f
    • loislo@chromium.org's avatar
      2010-10-14 Ilya Tikhonovsky <loislo@chromium.org> · 47c617da
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: inspector settings/properties/states management
              should be extracted into separate class.
      
              We have a lot of flags/values in InspectorController.
              Some flags are persisting into profile.
              Others are part of inspector state for frontend.
              All these flags should keep their values after navigation.
              It'd be better to extract these flags/values into separate
              class which will care about theirs lifetime.
      
              https://bugs.webkit.org/show_bug.cgi?id=47275
      
              WebCore:
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::inspectorStartsAttached):
              (WebCore::InspectorController::setInspectorStartsAttached):
              (WebCore::InspectorController::setInspectorAttachedHeight):
              (WebCore::InspectorController::inspectorAttachedHeight):
              (WebCore::InspectorController::searchingForNodeInPage):
              (WebCore::InspectorController::resourceTrackingEnabled):
              (WebCore::InspectorController::saveApplicationSettings):
              (WebCore::InspectorController::getInspectorState):
              (WebCore::InspectorController::restoreInspectorStateFromCookie):
              (WebCore::InspectorController::getSettings):
              (WebCore::InspectorController::storeLastActivePanel):
              (WebCore::InspectorController::mouseDidMoveOverElement):
              (WebCore::InspectorController::handleMousePress):
              (WebCore::InspectorController::setSearchingForNode):
              (WebCore::InspectorController::setMonitoringXHREnabled):
              (WebCore::InspectorController::showPanel):
              (WebCore::InspectorController::disconnectFrontend):
              (WebCore::InspectorController::populateScriptObjects):
              (WebCore::InspectorController::restoreDebugger):
              (WebCore::InspectorController::restoreProfiler):
              (WebCore::InspectorController::getTrackedResource):
              (WebCore::InspectorController::didLoadResourceFromMemoryCache):
              (WebCore::InspectorController::identifierForInitialRequest):
              (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
              (WebCore::InspectorController::scriptImported):
              (WebCore::InspectorController::setResourceTrackingEnabled):
              (WebCore::InspectorController::ensureSettingsLoaded):
              (WebCore::InspectorController::startTimelineProfiler):
              (WebCore::InspectorController::stopTimelineProfiler):
              (WebCore::InspectorController::enableProfiler):
              (WebCore::InspectorController::disableProfiler):
              (WebCore::InspectorController::enableDebuggerFromFrontend):
              (WebCore::InspectorController::disableDebugger):
              (WebCore::InspectorController::loadBreakpoints):
              (WebCore::InspectorController::saveBreakpoints):
              * inspector/InspectorController.h:
              * inspector/InspectorFrontendClientLocal.cpp:
              (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
              (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
              * inspector/InspectorState.cpp: Added.
              (WebCore::InspectorState::InspectorState):
              (WebCore::InspectorState::restoreFromInspectorCookie):
              (WebCore::InspectorState::generateStateObjectForFrontend):
              (WebCore::InspectorState::loadFromSettings):
              (WebCore::InspectorState::updateCookie):
              (WebCore::InspectorState::setValue):
              (WebCore::InspectorState::getBoolean):
              (WebCore::InspectorState::getString):
              (WebCore::InspectorState::getLong):
              (WebCore::InspectorState::registerBoolean):
              (WebCore::InspectorState::registerString):
              (WebCore::InspectorState::registerLong):
              (WebCore::InspectorState::Property::create):
              * inspector/InspectorState.h: Added.
              (WebCore::InspectorState::setBoolean):
              (WebCore::InspectorState::setString):
              (WebCore::InspectorState::setLong):
      
              WebKit/mac:
      
              * WebCoreSupport/WebInspectorClient.mm:
              (-[WebInspectorWindowController showWindow:]):
              (-[WebInspectorWindowController attach]):
              (-[WebInspectorWindowController detach]):
      
              WebKit/win:
      
              * WebCoreSupport/WebInspectorClient.cpp:
              (WebInspectorFrontendClient::attachWindow):
              (WebInspectorFrontendClient::detachWindow):
              (WebInspectorFrontendClient::showWindowWithoutNotifications):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47c617da
  10. 14 Oct, 2010 3 commits
  11. 13 Oct, 2010 1 commit
  12. 12 Oct, 2010 1 commit
    • zimmermann@webkit.org's avatar
      2010-10-12 Nikolas Zimmermann <nzimmermann@rim.com> · dffa3cad
      zimmermann@webkit.org authored
              Reviewed by Gavin Barraclough.
      
              Unify JSC::StringBuilder & WebCore::StringBuilder
              https://bugs.webkit.org/show_bug.cgi?id=47538
      
              Move runtime/StringBuilder.h to wtf/text/StringBuilder.h. Rename build() to toString() and return a WTF::String().
              Move the append(const JSC::UString&) method into runtime/UStringBuilder.h.
              UStringBuilder inherits from StringBuilder.h and adds append(const JSC::UString&) and UString toUString() functionality.
      
              No new code, just move code around.
      
              * GNUmakefile.am: Add wtf/text/StringBuilder.h / runtime/UStringBuilder.h. Remove runtime/StringBuilder.h.
              * JavaScriptCore.gypi: Ditto.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
              * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
              * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
              * runtime/Executable.cpp:
              (JSC::FunctionExecutable::paramString): Use UStringBuilder, instead of StringBuilder. Rename build() -> toUString().
              * runtime/FunctionConstructor.cpp:
              (JSC::constructFunction): Ditto.
              * runtime/JSGlobalObjectFunctions.cpp:
              (JSC::globalFuncUnescape): Ditto.
              * runtime/JSONObject.cpp:
              (JSC::Stringifier::stringify): Ditto.
              (JSC::Stringifier::appendQuotedString): Ditto.
              (JSC::Stringifier::appendStringifiedValue): Ditto.
              (JSC::Stringifier::startNewLine): Ditto.
              (JSC::Stringifier::Holder::appendNextProperty): Ditto.
              * runtime/LiteralParser.cpp:
              (JSC::LiteralParser::Lexer::lexString): Ditto.
              * runtime/NumberPrototype.cpp: Remove unneeded JSStringBuilder.h / StringBuilder.h include.
              * runtime/StringBuilder.h: Removed.
              * runtime/UStringBuilder.h: Added. Inherits from WTF::StringBuilder, extending it by two methods.
              (JSC::UStringBuilder::append): append(const JSC::UString&)
              (JSC::UStringBuilder::toUString):
              * wtf/text/StringBuilder.h: Copied from runtime/StringBuilder.h. Move JSC::UString parts into runtime/UStringBuilder.h
              (WTF::StringBuilder::append): Renamed m_buffer to buffer everywhere.
              (WTF::StringBuilder::isEmpty): Ditto (+ constify method). 
              (WTF::StringBuilder::reserveCapacity): Ditto.
              (WTF::StringBuilder::resize): Ditto.
              (WTF::StringBuilder::size): Ditto.
              (WTF::StringBuilder::operator[]): Ditto.
              (WTF::StringBuilder::toString): Ditto (+ renamed from build()). Returns a String, not an UString. The old build() method is now named toUString() and lives in UStringBuilder.
      2010-10-12  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Gavin Barraclough.
      
              Unify JSC::StringBuilder & WebCore::StringBuilder
              https://bugs.webkit.org/show_bug.cgi?id=47538
      
              * src/LocalizedStrings.cpp:
              (WebCore::imageTitle): Use WTF::StringBuilder.
              * src/WebEntities.cpp:
              (WebKit::WebEntities::convertEntitiesInString): Ditto.
              * src/WebPageSerializerImpl.cpp: Remove useless includes.
              (WebKit::WebPageSerializerImpl::encodeAndFlushBuffer): 
              * src/WebPageSerializerImpl.h: Use WTF::StringBuilder.
      2010-10-12  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Gavin Barraclough.
      
              Unify JSC::StringBuilder & WebCore::StringBuilder
              https://bugs.webkit.org/show_bug.cgi?id=47538
      
              JSC::StringBuilder operates on a Vector<UChar, 64> and allows to build a string based on a stream of characters in an efficient manner.
              WebCore::StringBuilder operates on a Vector<String, 16> and allows to concat an arbitary number of Strings. It's not efficient in handling single
              characters, as a String with length=1 has to be constructed for those. An analysis of the callers of WebCore::StringBuilder shows that
              most callsites actually combine Strings and single characters, so using a Vector<UChar> would be more efficient. Those who only combine large
              strings are only used for debugging purposes, so it's fine to switch them to a Vector<UChar> approach as well.
      
              Replace WebCore::StringBuilder with JSC::StringBuilder, and move it to wtf/text/StringBuilder.h into the WTF namespace.
              While I was at it remove platform/text/StringBuffer.h, as it was only including wtf/text/StringBuffer.h.
      
              No change in functionality, thus no new tests.
      
              * Android.mk: Remove platform/text/StringBuilder.* and platform/text/StringBuffer.h.
              * CMakeLists.txt: Ditto.
              * GNUmakefile.am: Ditto. 
              * WebCore.gypi: Ditto.
              * WebCore.order: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * ForwardingHeaders/runtime/StringBuilder.h: Removed.
              * ForwardingHeaders/runtime/UStringBuilder.h: Added.
              * ForwardingHeaders/wtf/text/StringBuilder.h: Added.
              * bindings/js/ScriptString.h: Don't include PlatformString.h but wtf/text/WTFString.h.
              (WebCore::ScriptString::operator+=): Use JSC::UStringBuilder instead of JSC::StringBuilder.
              * bridge/jni/JNIBridge.cpp: Use WTF::StringBuilder (+ use append(const UChar) for single characters).
              * css/MediaQuery.cpp: Ditto.
              * css/MediaQueryExp.cpp: Ditto.
              * dom/Node.cpp: Ditto.
              (WebCore::Node::appendTextContent): Manually track wheter the StringBuilder content is empty or null, the new StringBuilder doesn't differentiate between null & empty strings.
              * dom/Node.h: Remove appendTextContent definition, it's not needed to be exported, removes the need for a StringBuilder.h include or forward declaration.
              * html/DOMTokenList.cpp: Use WTF::StringBuilder.
              * inspector/InspectorResource.cpp: Remove useless StringBuffer.h include.
              * platform/android/FileSystemAndroid.cpp: Use WTF::StringBuilder.
              * platform/brew/FileSystemBrew.cpp: Ditto.
              * platform/chromium/ClipboardChromium.cpp: Ditto (+ use append(const UChar) for single characters).
              * platform/graphics/gpu/PODInterval.h: Ditto (Only used as debugging helper here, in debug builds).
              * platform/graphics/gpu/PODRedBlackTree.h: Ditto (Only used as debugging helper here, in debug builds).
              * platform/graphics/mac/GraphicsLayerCA.mm: Remove useless StringBuilder.h include.
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: Use WTF::StringBuilder, and use append(const UChar) for single characters.
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: Ditto.
              * platform/network/ProxyServer.cpp:
              (WebCore::appendProxyServerString): Use WTF::StringBuilder.
              * platform/text/StringBuffer.h: Removed.
              * platform/text/StringBuilder.cpp: Removed.
              * platform/text/StringBuilder.h: Removed.
              * plugins/DOMMimeType.cpp: Use WTF::StringBuilder.
              * svg/SVGPathParserFactory.cpp: Ditto.
              * svg/SVGPathStringBuilder.cpp: SVGPathStringBuilder used stringBuilder.toString(ConcatAddingSpacesBetweenIndividualStrings), adapt to the change, that this mode is gone now.
              (WebCore::SVGPathStringBuilder::result): Just use toString(), append a space to the end of each command, when building the string. Remove the last trailing space before building the result.
              (WebCore::SVGPathStringBuilder::moveTo):
              (WebCore::SVGPathStringBuilder::lineTo):
              (WebCore::SVGPathStringBuilder::lineToHorizontal):
              (WebCore::SVGPathStringBuilder::lineToVertical):
              (WebCore::SVGPathStringBuilder::curveToCubic):
              (WebCore::SVGPathStringBuilder::curveToCubicSmooth):
              (WebCore::SVGPathStringBuilder::curveToQuadratic):
              (WebCore::SVGPathStringBuilder::curveToQuadraticSmooth):
              (WebCore::SVGPathStringBuilder::arcTo):
              (WebCore::SVGPathStringBuilder::closePath):
              * svg/SVGPathStringBuilder.h:
              (WebCore::SVGPathStringBuilder::cleanup): StringBuilder::clear() is gone, just cleanup by assigning StringBuilder().
              * websockets/WebSocket.cpp: Use WTF::StringBuilder.
              * websockets/WebSocketHandshake.cpp: Ditto (+ use append(const UChar) for single characters).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dffa3cad
  13. 07 Oct, 2010 2 commits
    • apavlov@chromium.org's avatar
      2010-10-06 Alexander Pavlov <apavlov@chromium.org> · 8d79d7f9
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Implement handling of CSS operations in InspectorCSSAgent.
              Property toggling not implemented yet. The code is not going live.
              https://bugs.webkit.org/show_bug.cgi?id=45825
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/InspectorCSSAgent.cpp: Added.
              (WebCore::InspectorCSSAgent::buildObjectForStyle):
              (WebCore::InspectorCSSAgent::parentStyleSheet):
              (WebCore::InspectorCSSAgent::asCSSStyleRule):
              (WebCore::InspectorCSSAgent::InspectorCSSAgent):
              (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
              (WebCore::InspectorCSSAgent::reset):
              (WebCore::InspectorCSSAgent::getMatchedRulesForNode2):
              (WebCore::InspectorCSSAgent::getMatchedPseudoRulesForNode2):
              (WebCore::InspectorCSSAgent::getAttributeStylesForNode2):
              (WebCore::InspectorCSSAgent::getInlineStyleForNode2):
              (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
              (WebCore::InspectorCSSAgent::getInheritedStylesForNode2):
              (WebCore::InspectorCSSAgent::getAllStyles2):
              (WebCore::InspectorCSSAgent::getStyleSheet2):
              (WebCore::InspectorCSSAgent::setStyleSheetText2):
              (WebCore::InspectorCSSAgent::setStyleText2):
              (WebCore::InspectorCSSAgent::toggleProperty2):
              (WebCore::InspectorCSSAgent::setRuleSelector2):
              (WebCore::InspectorCSSAgent::addRule2):
              (WebCore::InspectorCSSAgent::getSupportedCSSProperties):
              (WebCore::InspectorCSSAgent::inlineStyleElement):
              (WebCore::InspectorCSSAgent::populateObjectWithStyleProperties):
              (WebCore::InspectorCSSAgent::shorthandValue):
              (WebCore::InspectorCSSAgent::shorthandPriority):
              (WebCore::InspectorCSSAgent::longhandProperties):
              (WebCore::InspectorCSSAgent::asInspectorStyleSheet):
              (WebCore::InspectorCSSAgent::elementForId):
              (WebCore::InspectorCSSAgent::bindStyleSheet):
              (WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
              (WebCore::InspectorCSSAgent::styleSheetForId):
              (WebCore::InspectorCSSAgent::detectOrigin):
              (WebCore::InspectorCSSAgent::buildArrayForRuleList):
              (WebCore::InspectorCSSAgent::buildObjectForAttributeStyles):
              (WebCore::InspectorCSSAgent::didRemoveDocument):
              (WebCore::InspectorCSSAgent::didRemoveDOMNode):
              * inspector/InspectorCSSAgent.h: Added.
              (WebCore::InspectorCSSAgent::create):
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::InspectorDOMAgent):
              (WebCore::InspectorDOMAgent::setDOMListener):
              (WebCore::InspectorDOMAgent::unbind):
              (WebCore::InspectorDOMAgent::didRemoveDOMNode):
              (WebCore::InspectorDOMAgent::getSupportedCSSProperties):
              * inspector/InspectorDOMAgent.h:
              (WebCore::InspectorDOMAgent::DOMListener::~DOMListener):
              (WebCore::InspectorDOMAgent::documents):
              * inspector/InspectorStyleSheet.cpp: Added.
              (ParsedStyleSheet::cssStyleSheet):
              (ParsedStyleSheet::text):
              (ParsedStyleSheet::hasText):
              (ParsedStyleSheet::sourceData):
              (ParsedStyleSheet::hasSourceData):
              (ParsedStyleSheet::ParsedStyleSheet):
              (ParsedStyleSheet::setText):
              (ParsedStyleSheet::setSourceData):
              (ParsedStyleSheet::ruleSourceDataAt):
              (WebCore::InspectorStyleSheet::InspectorStyleSheet):
              (WebCore::InspectorStyleSheet::~InspectorStyleSheet):
              (WebCore::InspectorStyleSheet::setText):
              (WebCore::InspectorStyleSheet::setRuleSelector):
              (WebCore::InspectorStyleSheet::addRule):
              (WebCore::InspectorStyleSheet::ruleForId):
              (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
              (WebCore::InspectorStyleSheet::buildObjectForRule):
              (WebCore::InspectorStyleSheet::buildObjectForStyle):
              (WebCore::InspectorStyleSheet::styleForId):
              (WebCore::InspectorStyleSheet::setStyleText):
              (WebCore::InspectorStyleSheet::ownerDocument):
              (WebCore::InspectorStyleSheet::ruleSourceDataFor):
              (WebCore::InspectorStyleSheet::ruleIndexByStyle):
              (WebCore::InspectorStyleSheet::ensureParsedDataReady):
              (WebCore::InspectorStyleSheet::text):
              (WebCore::InspectorStyleSheet::ensureText):
              (WebCore::InspectorStyleSheet::ensureSourceData):
              (WebCore::InspectorStyleSheet::innerSetStyleSheetText):
              (WebCore::InspectorStyleSheet::innerSetStyleText):
              (WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):
              (WebCore::InspectorStyleSheet::findPageRuleWithStyle):
              (WebCore::InspectorStyleSheet::fullRuleId):
              (WebCore::InspectorStyleSheet::revalidateStyle):
              (WebCore::InspectorStyleSheet::styleSheetText):
              (WebCore::InspectorStyleSheet::resourceStyleSheetText):
              (WebCore::InspectorStyleSheet::inlineStyleSheetText):
              (WebCore::InspectorStyleSheet::buildArrayForRuleList):
              (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
              (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
              (WebCore::InspectorStyleSheetForInlineStyle::ownerDocument):
              (WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady):
              (WebCore::InspectorStyleSheetForInlineStyle::inlineStyle):
              (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
              * inspector/InspectorStyleSheet.h: Added.
              (WebCore::InspectorStyleSheet::create):
              (WebCore::InspectorStyleSheet::id):
              (WebCore::InspectorStyleSheet::pageStyleSheet):
              (WebCore::InspectorStyleSheet::canBind):
              (WebCore::InspectorStyleSheet::fullRuleOrStyleId):
              (WebCore::InspectorStyleSheet::ruleOrStyleId):
              (WebCore::InspectorStyleSheet::fullStyleId):
              (WebCore::InspectorStyleSheetForInlineStyle::create):
              (WebCore::InspectorStyleSheetForInlineStyle::styleForId):
              (WebCore::InspectorStyleSheetForInlineStyle::ruleSourceDataFor):
              (WebCore::InspectorStyleSheetForInlineStyle::ruleIndexByStyle):
              * inspector/InspectorUtilities.cpp: Added.
              (WebCore::InspectorUtilities::resourceContentForURL):
              * inspector/InspectorUtilities.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d79d7f9
    • andreas.kling@nokia.com's avatar
      2010-10-07 Andreas Kling <kling@webkit.org> · ecf4956b
      andreas.kling@nokia.com authored
              Reviewed by Nikolas Zimmermann.
      
              Rename (and move) RenderPath to svg/RenderSVGPath
              https://bugs.webkit.org/show_bug.cgi?id=47053
      
              Also renamed RenderObject::isRenderPath() to isSVGPath()
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.order:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/RenderObject.h:
              (WebCore::RenderObject::isSVGPath):
              * rendering/RenderPath.cpp: Removed.
              * rendering/RenderPath.h: Removed.
              * rendering/RenderSVGHiddenContainer.cpp:
              * rendering/RenderSVGResourceClipper.cpp:
              (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
              (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
              (WebCore::RenderSVGResourceClipper::hitTestClipContent):
              * rendering/RenderSVGResourceContainer.cpp:
              (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
              * rendering/RenderSVGResourceSolidColor.cpp:
              (WebCore::RenderSVGResourceSolidColor::postApplyResource):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::write):
              * rendering/SVGRenderSupport.cpp:
              (WebCore::SVGRenderSupport::layoutChildren):
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::writeStyle):
              (WebCore::operator<<):
              (WebCore::write):
              * rendering/SVGRenderTreeAsText.h:
              * rendering/style/SVGRenderStyle.cpp:
              (WebCore::SVGRenderStyle::diff):
              * rendering/svg/RenderSVGPath.cpp: Copied from WebCore/rendering/RenderPath.cpp.
              (WebCore::RenderSVGPath::RenderSVGPath):
              (WebCore::RenderSVGPath::fillContains):
              (WebCore::RenderSVGPath::strokeContains):
              (WebCore::RenderSVGPath::layout):
              (WebCore::RenderSVGPath::fillAndStrokePath):
              (WebCore::RenderSVGPath::paint):
              (WebCore::RenderSVGPath::addFocusRingRects):
              (WebCore::RenderSVGPath::nodeAtFloatPoint):
              (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
              (WebCore::RenderSVGPath::updateCachedBoundaries):
              * rendering/svg/RenderSVGPath.h: Copied from WebCore/rendering/RenderPath.h.
              (WebCore::RenderSVGPath::isSVGPath):
              (WebCore::RenderSVGPath::renderName):
              (WebCore::toRenderSVGPath):
              * svg/SVGCircleElement.cpp:
              (WebCore::SVGCircleElement::svgAttributeChanged):
              * svg/SVGEllipseElement.cpp:
              (WebCore::SVGEllipseElement::svgAttributeChanged):
              * svg/SVGGradientElement.cpp:
              * svg/SVGLineElement.cpp:
              (WebCore::SVGLineElement::svgAttributeChanged):
              * svg/SVGPathElement.cpp:
              (WebCore::SVGPathElement::svgAttributeChanged):
              * svg/SVGPolyElement.cpp:
              (WebCore::SVGPolyElement::svgAttributeChanged):
              * svg/SVGRectElement.cpp:
              (WebCore::SVGRectElement::svgAttributeChanged):
              * svg/SVGStyledLocatableElement.cpp:
              * svg/SVGStyledTransformableElement.cpp:
              (WebCore::SVGStyledTransformableElement::createRenderer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecf4956b
  14. 06 Oct, 2010 1 commit
    • paroga@webkit.org's avatar
      2010-10-06 Patrick Gansterer <paroga@webkit.org> · 4ad937ae
      paroga@webkit.org authored
              Reviewed by Darin Adler.
      
              Move parseDataUrl() from CURL into own file
              https://bugs.webkit.org/show_bug.cgi?id=41462
      
              Move the data URL parsing algorithm into a new file to use it in ResourceHandleWin too.
      
              * CMakeLists.txt:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * platform/network/DataURL.cpp: Added.
              (WebCore::handleDataURL):
              * platform/network/DataURL.h: Added.
              * platform/network/curl/ResourceHandleManager.cpp:
              (WebCore::ResourceHandleManager::dispatchSynchronousJob):
              (WebCore::ResourceHandleManager::startJob):
              * platform/network/win/ResourceHandleWin.cpp:
              (WebCore::ResourceHandle::start):
              (WebCore::ResourceHandle::fileLoadTimer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ad937ae
  15. 05 Oct, 2010 1 commit
    • kinuko@chromium.org's avatar
      2010-10-05 Kinuko Yasuda <kinuko@chromium.org> · 5f6f77c3
      kinuko@chromium.org authored
              Reviewed by David Levin.
      
              Add idl and mock classes for FileSystemSync for FileSystem API
              https://bugs.webkit.org/show_bug.cgi?id=46405
      
              Added bunch of *Sync classes, plus refactored some classes:
              Added DOMFileSystemBase as a common base class for DOMFileSystem and
              DOMFileSystemSync.
              Added EntryBase as a common base class for Entry and EntrySync.
              Added DirectoryReaderBase as a common base class for DirectoryReader and
              DirectoryReaderSync.
      
              Test: fast/filesystem/workers/
      
              * CMakeLists.txt: Added new files.
              * DerivedSources.cpp: Added new files.
              * DerivedSources.make: Added new files.
              * GNUmakefile.am: Added new files.
              * WebCore.gypi: Added new files.
              * WebCore.pri: Added new files.
              * WebCore.pro: Added new files.
              * WebCore.vcproj/WebCore.vcproj: Added new files. Also removed the duplicated fileapi\FileEntry.cpp entry.
              * WebCore.xcodeproj/project.pbxproj: Added new files.
              * bindings/js/JSDirectoryEntrySyncCustom.cpp: Added.
              * bindings/js/JSEntrySyncCustom.cpp: Added.
              * bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: Added.
              * bindings/v8/custom/V8EntrySyncCustom.cpp: Added.
              * fileapi/DOMFileSystemBase.cpp: Added.
              * fileapi/DOMFileSystemBase.h: Added.
              * fileapi/DOMFileSystemSync.cpp: Added.
              * fileapi/DOMFileSystemSync.h: Added.
              * fileapi/DOMFileSystemSync.idl: Added.
              * fileapi/DirectoryEntrySync.cpp: Added.
              * fileapi/DirectoryEntrySync.h: Added.
              * fileapi/DirectoryEntrySync.idl: Added.
              * fileapi/DirectoryReaderBase.h: Added.
              * fileapi/DirectoryReaderSync.cpp: Added.
              * fileapi/DirectoryReaderSync.h: Added.
              * fileapi/DirectoryReaderSync.idl: Added.
              * fileapi/EntryArraySync.cpp: Added.
              * fileapi/EntryArraySync.h: Added.
              * fileapi/EntryArraySync.idl: Added.
              * fileapi/EntryBase.h: Added.
              * fileapi/EntrySync.cpp: Added.
              * fileapi/EntrySync.h: Added.
              * fileapi/EntrySync.idl: Added.
              * fileapi/FileEntrySync.cpp: Added.
              * fileapi/FileEntrySync.h: Added.
              * fileapi/FileEntrySync.idl: Added.
      2010-10-05  Kinuko Yasuda  <kinuko@chromium.org>
      
              Reviewed by David Levin.
      
              Add idl and mock classes for FileSystemSync for FileSystem API
              https://bugs.webkit.org/show_bug.cgi?id=46405
      
              Add small subset of tests for workers (and non-workers) that can be
              tested with the current minimal implementation.
      
              An entry method (requestFileSystemSync) is not yet exposed to the
              WorkerContext in this patch, so workers/simple-*-sync-expected.txt
              have reference errors for now.
      
              * fast/filesystem/resources/fs-worker-common.js: Added.
              * fast/filesystem/resources/fs-worker-test-post.js: Added.
              * fast/filesystem/resources/fs-worker-test-pre.js: Added.
              * fast/filesystem/resources/simple-persistent-sync.js: Added.
              * fast/filesystem/resources/simple-persistent.js: Added.
              * fast/filesystem/resources/simple-temporary-sync.js: Added.
              * fast/filesystem/resources/simple-temporary.js: Added.
              * fast/filesystem/simple-persistent-expected.txt: Added.
              * fast/filesystem/simple-persistent.html: Added.
              * fast/filesystem/simple-temporary-expected.txt: Added.
              * fast/filesystem/simple-temporary.html: Added.
              * fast/filesystem/workers/simple-persistent-expected.txt: Added.
              * fast/filesystem/workers/simple-persistent-sync-expected.txt: Added.
              * fast/filesystem/workers/simple-persistent-sync.html: Added.
              * fast/filesystem/workers/simple-persistent-sync.txt: Added.
              * fast/filesystem/workers/simple-persistent.html: Added.
              * fast/filesystem/workers/simple-temporary-expected.txt: Added.
              * fast/filesystem/workers/simple-temporary-sync-expected.txt: Added.
              * fast/filesystem/workers/simple-temporary-sync.html: Added.
              * fast/filesystem/workers/simple-temporary.html: Added.
              * fast/js/resources/fs-test-post.js: Added.
              * platform/chromium/test_expectations.txt: Added fast/filesystem/workers
              not to run them in regular test runs.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f6f77c3
  16. 04 Oct, 2010 2 commits
    • commit-queue@webkit.org's avatar
      2010-10-04 Ryuan Choi <ryuan.choi@samsung.com> · 928ccf83
      commit-queue@webkit.org authored
              Unreviewed build fix.
      
              [CMAKE] Build fix for r68901
              https://bugs.webkit.org/show_bug.cgi?id=47042
      
              Move plugins/PluginPackage.cpp
      
              No features added, so no new tests.
      
              * CMakeLists.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      928ccf83
    • abarth@webkit.org's avatar
      2010-10-04 Adam Barth <abarth@webkit.org> · 88b4e6bf
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Rename RedirectScheduler to NavigationScheduler
              https://bugs.webkit.org/show_bug.cgi?id=47037
      
              Update for name change.
      
              * src/ApplicationCacheHost.cpp:
              (WebCore::ApplicationCacheHost::selectCacheWithManifest):
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::loadJavaScriptURL):
      2010-10-04  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              Rename RedirectScheduler to NavigationScheduler
              https://bugs.webkit.org/show_bug.cgi?id=47037
      
              Update for name change.
      
              * Api/qwebpage.cpp:
              (QWebPage::triggerAction):
      2010-10-04  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              Rename RedirectScheduler to NavigationScheduler
              https://bugs.webkit.org/show_bug.cgi?id=47037
      
              This class schedules more than just redirects.  In fact, it schedules
              most kinds of navigations.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/generic/BindingDOMWindow.h:
              (WebCore::::createWindow):
              (WebCore::::open):
              * bindings/generic/BindingFrame.h:
              (WebCore::::navigateIfAllowed):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              (WebCore::createWindow):
              (WebCore::JSDOMWindow::open):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::setLocation):
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::JSLocation::reload):
              * bindings/v8/custom/V8LocationCustom.cpp:
              (WebCore::V8Location::reloadCallback):
              * dom/Document.cpp:
              (WebCore::Document::implicitClose):
              (WebCore::Document::processHttpEquiv):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setResourceTrackingEnabled):
              (WebCore::InspectorController::reloadPage):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::setDefersLoading):
              (WebCore::FrameLoader::submitForm):
              (WebCore::FrameLoader::stopLoading):
              (WebCore::FrameLoader::didOpenURL):
              (WebCore::FrameLoader::didExplicitOpen):
              (WebCore::FrameLoader::cancelAndClear):
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::receivedFirstData):
              (WebCore::FrameLoader::checkCompleted):
              (WebCore::FrameLoader::provisionalLoadStarted):
              (WebCore::FrameLoader::completed):
              (WebCore::FrameLoader::prepareForCachedPageRestore):
              * loader/FrameLoader.h:
              * loader/NavigationScheduler.cpp: Added.
              (WebCore::ScheduledNavigation::ScheduledNavigation):
              (WebCore::ScheduledNavigation::~ScheduledNavigation):
              (WebCore::ScheduledNavigation::shouldStartTimer):
              (WebCore::ScheduledNavigation::didStartTimer):
              (WebCore::ScheduledNavigation::didStopTimer):
              (WebCore::ScheduledNavigation::delay):
              (WebCore::ScheduledNavigation::lockHistory):
              (WebCore::ScheduledNavigation::lockBackForwardList):
              (WebCore::ScheduledNavigation::wasDuringLoad):
              (WebCore::ScheduledNavigation::isLocationChange):
              (WebCore::ScheduledNavigation::wasUserGesture):
              (WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
              (WebCore::ScheduledURLNavigation::fire):
              (WebCore::ScheduledURLNavigation::didStartTimer):
              (WebCore::ScheduledURLNavigation::didStopTimer):
              (WebCore::ScheduledURLNavigation::url):
              (WebCore::ScheduledURLNavigation::referrer):
              (WebCore::ScheduledRedirect::ScheduledRedirect):
              (WebCore::ScheduledRedirect::shouldStartTimer):
              (WebCore::ScheduledLocationChange::ScheduledLocationChange):
              (WebCore::ScheduledRefresh::ScheduledRefresh):
              (WebCore::ScheduledRefresh::fire):
              (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
              (WebCore::ScheduledHistoryNavigation::fire):
              (WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
              (WebCore::ScheduledFormSubmission::fire):
              (WebCore::ScheduledFormSubmission::didStartTimer):
              (WebCore::ScheduledFormSubmission::didStopTimer):
              (WebCore::NavigationScheduler::NavigationScheduler):
              (WebCore::NavigationScheduler::~NavigationScheduler):
              (WebCore::NavigationScheduler::redirectScheduledDuringLoad):
              (WebCore::NavigationScheduler::locationChangePending):
              (WebCore::NavigationScheduler::clear):
              (WebCore::NavigationScheduler::scheduleRedirect):
              (WebCore::NavigationScheduler::mustLockBackForwardList):
              (WebCore::NavigationScheduler::scheduleLocationChange):
              (WebCore::NavigationScheduler::scheduleFormSubmission):
              (WebCore::NavigationScheduler::scheduleRefresh):
              (WebCore::NavigationScheduler::scheduleHistoryNavigation):
              (WebCore::NavigationScheduler::timerFired):
              (WebCore::NavigationScheduler::schedule):
              (WebCore::NavigationScheduler::startTimer):
              (WebCore::NavigationScheduler::cancel):
              * loader/NavigationScheduler.h: Added.
              * loader/RedirectScheduler.cpp: Removed.
              * loader/RedirectScheduler.h: Removed.
              * loader/SubframeLoader.cpp:
              (WebCore::SubframeLoader::loadOrRedirectSubframe):
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::selectCache):
              * page/Frame.cpp:
              (WebCore::Frame::Frame):
              * page/Frame.h:
              (WebCore::Frame::navigationScheduler):
              * page/History.cpp:
              (WebCore::History::back):
              (WebCore::History::forward):
              (WebCore::History::go):
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::findInRequest):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88b4e6bf
  17. 03 Oct, 2010 1 commit
    • tkent@chromium.org's avatar
      2010-10-03 Kent Tamura <tkent@chromium.org> · 34b5151e
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Refactor HTMLInputElement: Move parseToDouble() and
              parseToDateComponents() to InputType.
              https://bugs.webkit.org/show_bug.cgi?id=46965
      
              Introduce BaseDateAndTimeInputType, which is a super class of
              date, datetime, datetime-local, month, time, and week types.
      
              No new tests. Just a refactoring.
      
              * Android.mk: Add BaseDateAndTimeInputType.
              * CMakeLists.txt: ditto.
              * GNUmakefile.am: ditto.
              * WebCore.gypi: ditto.
              * WebCore.pro: ditto.
              * WebCore.vcproj/WebCore.vcproj: ditto.
              * WebCore.xcodeproj/project.pbxproj: ditto.
              * html/BaseDateAndTimeInputType.cpp: Added.
              (WebCore::BaseDateAndTimeInputType::parseToDouble):
              (WebCore::BaseDateAndTimeInputType::parseToDateComponents):
              * html/BaseDateAndTimeInputType.h: Added.
              (WebCore::BaseDateAndTimeInputType::BaseDateAndTimeInputType):
              * html/DateInputType.cpp:
              (WebCore::DateInputType::parseToDateComponentsInternal):
              * html/DateInputType.h:
              (WebCore::DateInputType::DateInputType):
              * html/DateTimeInputType.cpp:
              (WebCore::DateTimeInputType::parseToDateComponentsInternal):
              * html/DateTimeInputType.h:
              (WebCore::DateTimeInputType::DateTimeInputType):
              * html/DateTimeLocalInputType.cpp:
              (WebCore::DateTimeLocalInputType::parseToDateComponentsInternal):
              * html/DateTimeLocalInputType.h:
              (WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
              * html/HTMLInputElement.cpp: Replace parseToD* calls with m_inputType->parseToD*.
              (WebCore::HTMLInputElement::typeMismatch):
              (WebCore::HTMLInputElement::rangeUnderflow):
              (WebCore::HTMLInputElement::rangeOverflow):
              (WebCore::HTMLInputElement::minimum):
              (WebCore::HTMLInputElement::maximum):
              (WebCore::HTMLInputElement::stepBase):
              (WebCore::HTMLInputElement::stepMismatch):
              (WebCore::HTMLInputElement::applyStep):
              (WebCore::HTMLInputElement::valueAsDate):
              (WebCore::HTMLInputElement::valueAsNumber):
              (WebCore::HTMLInputElement::handleKeyEventForRange):
              (WebCore::HTMLInputElement::stepUpFromRenderer):
              * html/HTMLInputElement.h:
              * html/InputType.cpp:
              (WebCore::InputType::parseToDouble):
              (WebCore::InputType::parseToDateComponents):
              * html/InputType.h:
              * html/MonthInputType.cpp:
              (WebCore::MonthInputType::parseToDouble):
              (WebCore::MonthInputType::parseToDateComponentsInternal):
              * html/MonthInputType.h:
              (WebCore::MonthInputType::MonthInputType):
              * html/NumberInputType.cpp:
              (WebCore::NumberInputType::parseToDouble):
              * html/NumberInputType.h:
              * html/RangeInputType.cpp:
              (WebCore::RangeInputType::parseToDouble):
              * html/RangeInputType.h:
              * html/TimeInputType.cpp:
              (WebCore::TimeInputType::parseToDateComponentsInternal):
              * html/TimeInputType.h:
              (WebCore::TimeInputType::TimeInputType):
              * html/WeekInputType.cpp:
              (WebCore::WeekInputType::parseToDateComponentsInternal):
              * html/WeekInputType.h:
              (WebCore::WeekInputType::WeekInputType):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34b5151e
  18. 02 Oct, 2010 1 commit
    • zimmermann@webkit.org's avatar
      2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com> · 65ac5a76
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Rewrite SVG text layout code
              https://bugs.webkit.org/show_bug.cgi?id=45532
      
              Modernize SVG text layout engine, split the layout process into three phases, so that each results can be cached (which will be done in a follow-up patch).
      
              Phase #1) - SVGTextLayoutAttributesBuilder
              ------------------------------------------
      
              Parse x/y/dx/dy/rotate values of the <text> subtree (<text x="30 40">A<tspan>B<tspan x="50">C</tspan></tspan></text>)
              This is done by SVGTextLayoutAttributesBuilder. It builds a SVGTextLayoutAttributes object for each RenderSVGInlineText renderer, and stores it there.
              Phase #1 is started from RenderSVGText::layout(), before RenderBlockLineLayout is laying out the inline children, and thus before the InlineBox tree is created.
      
              Now we know which character has an associated absolute x or y position, denoting the start of a new text chunk. Whenever we encounter a new text chunk
              RenderBlockLineLayout should create a new SVGInlineTextBox. This is very important, as BiDi reordering shouldn't happen across text chunks, as well as ligature detection.
      
              The text chunk concept is now merged right into the InlineBox tree, so we don't need to hack around the lack of that, as done for the previous years.
      
              Phase #2) - SVGTextLayoutEngine
              ------------------------------------------
      
              RenderSVGText::layout() calls RenderBlock::layoutInlineChildren() right after phase #1 ends. The InlineBox tree is created. During that process findNextLineBreak()
              decides how to split up the text into InlineTextBoxes. It has already been patched, to ask RenderSVGInlineText::characterStartsNewTextChunk(int position), whether the
              current character should go in a new SVGInlineTextBox or not. This requires that phase #1 already stored these information in the RenderSVGInlineText objects.
      
              For each <text> object a SVGRootInlineBox is created (in constructLine()) and all child boxes are added. After that SVGRootInlineBox::computePerCharacterLayoutInformation()
              is called (unlike HTML text, which splits the vertical & horizontal layout in two phases, it's just one single phase for SVG). This function invokes SVGTextLayoutEngine
              and starts phase #2 of the layout process.
      
              SVGTextLayoutEngine lays out the content of each SVGInlineTextBox either on a line or a path. It contains all the logic handling, alignment-baseline, dominant-baseline,
              letter-spacing, word-spacing, kerning, glyph-orientation-(horizontal|vertical), rotation, etc. etc.
      
              As result it generates a set of SVGTextFragment objects which are stored in each SVGInlineTextBox. Each SVGTextFragment is a portion of text that can be rendered/measured
              at once. Some examples to illustrate what's going on:
      
              <text x="20">ABCD</text>:
              - SVGInlineTextBox
                - SVGTextFragment, start 0 length 4, "ABCD" (x=20)
      
              <text x="20 100">ABCD</text>:
              - SVGInlineTextBox
                - SVGTextFragment, start 0 length 1, "A" (x=20)
              - SVGInlineTextBox
                - SVGTextFragment, start 0 length 1, "B" (x=100)
                - SVGTextFragment, start 1 length 2, "CD" (x=100 + advance_of_last)
      
              <text><textPath xlink:href="#somePath">ABCD</textPath></text>:
              - SVGInlineTextBox
                - SVGTextFragment, start 0 length 1, "A" (rotated!)
                - SVGTextFragment, start 1 length 1, "B" (rotated!)
                - SVGTextFragment, start 2 length 1, "C" (rotated!)
                - SVGTextFragment, start 3 length 1, "D" (rotated!)
      
              <text x="0 50 100">A<tspan>B</tspan>C</text>
              - SVGInlineTextBox
                - SVGTextFragment, start 0 length 1, "A" (x=0)
              - SVGInlineFlowBox
                - SVGInlineTextBox
                  - SVGTextFragment, start 0 length 1, "B" (x=50)
              - SVGInlineTextBox
                - SVGTextFragment, start 0 length 1, "C" (x=100)
      
              When painting text SVGInlineTextBox just walks its fragments and paints them. Text selection works the same.
              All text measurements (width/height etc.) have already been done in phase #2 and aren't required anymore while painting/selecting.
              This is one of the main benefits of the new text layout engine, painting & selection is cheap now, compared to the layout process.
      
              We're now doing phase #1 everytime RenderSVGText::layout() is called. This is not necessary, we only have to recompute these information
              if the x/y/dx/dy or rotate list of an element in the <text> subtree changes or the text content itself -> this will be done in a follow-up patch.
              It's likely that we'll also find ways to skip phase #2 in certain situations.
      
              Phase #3) - SVGTextChunkBuilder
              ------------------------------------------
      
              After phase #2 finished, we can post-process the text fragments. Certain operations have to be applied on a "per chunk" basis.
              text-anchor should be applied to individual text chunks, as well as textLength corrections (lengthAdjust="spacing" / lengthAdjust="spacingAndGlyphs").
      
              SVGTextChunkBuilder just walks the SVGInlineTextBox, and collects all boxes belonging to a certain chunk. For each of the chunks all fragments
              are post-processed. For instance for text-anchor="middle", all x positions of all fragments are shifted by -fragmentWidth/2 (for horizonal text).
      
              After phase #1 - #3 finished, SVGRootInlineBox::computePerCharacterLayoutInformation() utilizies the stored SVGTextFragments to lay out all child
              boxes in the InlineBox tree (setWidth/Height, etc.), the size and position of the SVGRootInlineBox and it's parent RenderSVGText object.
      
              This should give interessted readers a good summary of how the new text layout engine works.
              See LayoutTests/ChangeLog for more details on test progression.
      
              Tests: svg/custom/text-rotation.svg
                     svg/custom/text-x-dy-lists.svg
      
              * Android.mk: Add SVGTextLayoutEngine.* / SVGTextChunkBuilder.* to build. Remove SVGCharacterData.* / SVGTextChunkLayoutInfo.* / SVGTextLayoutUtilities.* from build.
              * CMakeLists.txt: Ditto.
              * GNUmakefile.am: Ditto.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * rendering/InlineBox.h:
              (WebCore::InlineBox::isSVGInlineFlowBox): Add helper function to identify SVGInlineFlowBoxes. The variants for SVGInlineTextBox etc. already exist.
              * rendering/InlineTextBox.h: Devirtualize selectionStartEnd, SVG is no longer overriding it.
              * rendering/RenderSVGAllInOne.cpp: removes
              * rendering/RenderText.cpp:
              (WebCore::RenderText::setTextInternal): Remove SVG specific hacks, moved to RenderSVGInlineText.
              * rendering/SVGCharacterData.cpp: Removed.
              * rendering/SVGCharacterData.h: Removed.
              * rendering/SVGCharacterLayoutInfo.cpp: Removed.
              * rendering/SVGCharacterLayoutInfo.h: Removed.
              * rendering/SVGRenderTreeAsText.cpp: Hack DRT output to be somewhat compatible with the current output, the plan is to change it completly after this patch.
              (WebCore::writeRenderSVGTextBox):
              (WebCore::writeSVGInlineTextBox):
              * rendering/SVGTextChunkLayoutInfo.cpp: Removed.
              * rendering/SVGTextChunkLayoutInfo.h: Removed.
              * rendering/SVGTextLayoutUtilities.cpp: Removed.
              * rendering/SVGTextLayoutUtilities.h: Removed.
              * rendering/style/RenderStyle.cpp:
              (WebCore::RenderStyle::diff): Only return immediately if SVGRenderStyle::diff produced StyleDifferenceLayout, it it's sth. else be sure to ask RenderStyle itself what to do.
              * rendering/style/SVGRenderStyle.h:
              (WebCore::SVGRenderStyle::isVerticalWritingMode): New helper method, moved from SVGTextLayoutUtilities.
              * rendering/svg/RenderSVGInlineText.cpp:
              (WebCore::applySVGWhitespaceRules): Moved from RenderText into a SVG specific place.
              (WebCore::RenderSVGInlineText::RenderSVGInlineText): Use applySVGWhitespaceRules on the incoming text.
              (WebCore::RenderSVGInlineText::styleDidChange): Only apply SVG white space rules, when using xml:space="preserve", otherwhise the constructor already handled it.
              (WebCore::RenderSVGInlineText::characterStartsNewTextChunk): Create text chunks for absolute y values as well, SVG 1.1 2nd Edition demands that.
              (WebCore::RenderSVGInlineText::positionForPoint): New function operating on all SVGInlineTextBoxes and their SVGTextFragments.
              * rendering/svg/RenderSVGInlineText.h:
              (WebCore::RenderSVGInlineText::layoutAttributes): Stores the layout attributes generated by SVGTextLayoutAttributesBuilder.
              (WebCore::toRenderSVGInlineText): New helper methods for casting.
              * rendering/svg/RenderSVGText.cpp:
              (WebCore::RenderSVGText::layout): Add comment, that SVGTextLayoutAttributesBuilder is just phase one of the layout process.
              (WebCore::RenderSVGText::positionForPoint): Simplified implementation for SVGs needs.
              * rendering/svg/RenderSVGText.h:
              * rendering/svg/SVGInlineFlowBox.cpp:
              (WebCore::SVGInlineFlowBox::paintSelectionBackground): Seperated selection background drawing from actual text rendering, to make sure selection is always in background for SVG.
              (WebCore::SVGInlineFlowBox::paint): Call computetextMatchMarkerRectForRenderer, before painting.
              (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer): New method.
              * rendering/svg/SVGInlineFlowBox.h:
              (WebCore::SVGInlineFlowBox::isSVGInlineFlowBox):
              * rendering/svg/SVGInlineTextBox.cpp: Completly rewritten, operates on SVGTextFragments, produced by the SVGTextLayoutEngine. Whole new concept, compared to the old hack.
              * rendering/svg/SVGInlineTextBox.h:
              (WebCore::SVGInlineTextBox::clearTextFragments): Only used by SVGTextLayoutEngine, to clean up previously computed fragments.
              (WebCore::SVGInlineTextBox::textFragments): Offers access to the fragments in the box.
              (WebCore::SVGInlineTextBox::startsNewTextChunk): Does this box start a new text chunk?
              (WebCore::SVGInlineTextBox::setStartsNewTextChunk): SVGTextLayoutEngine marks this box, if it starts a new text chunk.
              * rendering/svg/SVGRootInlineBox.cpp: Remove old code regarding text chunk parts.
              (WebCore::SVGRootInlineBox::paint): Selection is now painted before text, to assure it's really in the background.
              (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Use new SVGTextLayoutEngine.
              (WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes): Feed SVGTextLayoutEngine with SVGInlineTextBoxes, detect the begin/end of path layouts.
              (WebCore::SVGRootInlineBox::layoutChildBoxes): Use new isSVGInlineTextBox() helper method.
              (WebCore::SVGRootInlineBox::closestLeafChildForPosition): Simplified version for SVG.
              * rendering/svg/SVGRootInlineBox.h: Remove access to text chunks, they're now longer stored in the SVGRootInlineBox.
              * rendering/svg/SVGTextChunk.cpp: s/SVGTextChunkNew/SVGTextChunk/
              * rendering/svg/SVGTextChunk.h:
              * rendering/svg/SVGTextChunkBuilder.cpp: Added.
              * rendering/svg/SVGTextChunkBuilder.h: Added.
              * rendering/svg/SVGTextLayoutAttributes.cpp: Constify dump() method.
              * rendering/svg/SVGTextLayoutAttributes.h:
              (WebCore::SVGTextLayoutAttributes::textMetricsValues):
              * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Rewritten, consume less memory, while building the layout attributes.
              * rendering/svg/SVGTextLayoutAttributesBuilder.h:
              * rendering/svg/SVGTextLayoutEngine.cpp: Added.
              * rendering/svg/SVGTextLayoutEngine.h: Added.
              * rendering/svg/SVGTextQuery.cpp: Rewritten to deal with the new SVGTextFragment/SVGTextLayoutAttributes logic.
              * rendering/svg/SVGTextQuery.h:
      2010-10-01  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Dirk Schulze.
      
              Rewrite SVG text layout code
              https://bugs.webkit.org/show_bug.cgi?id=45532
      
              Rebaseline most SVGs containing text. The underlying concept has changed, I tried hard to maintain
              a somewhat compatible DRT output, so it doesn't require rebaselines of _all_ tests.
              The dump looks awkward now, it will always report "chunk 1", as it's hardcoded in SVGRenderTreeAsText.
              Follow up patches will change the output of text dumps completly.
      
              * platform/mac-leopard/svg/W3C-SVG-1.1/text-text-05-t-expected.checksum:
              * platform/mac-leopard/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
              * platform/mac-leopard/svg/batik/text/textOnPath-expected.checksum:
              * platform/mac-leopard/svg/batik/text/textOnPath-expected.png: baseline-shift adjustments now match Opera.
              * platform/mac-leopard/svg/batik/text/verticalTextOnPath-expected.checksum:
              * platform/mac-leopard/svg/batik/text/verticalTextOnPath-expected.png: Ditto.
              * platform/mac-leopard/svg/batik/text/xmlSpace-expected.checksum:
              * platform/mac-leopard/svg/batik/text/xmlSpace-expected.png:
              * platform/mac-leopard/svg/custom/altglyph-expected.checksum:
              * platform/mac-leopard/svg/custom/altglyph-expected.png:
              * platform/mac-leopard/svg/text/multichar-glyph-expected.checksum:
              * platform/mac-leopard/svg/text/multichar-glyph-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: No more blurry edges, size calculations fixed.
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.png: baseline-shift looks slightly different, now matches Opera.
              * platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.png: Vertical text now starts at correct origin, and is centered correctly.
              * platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.png: Ditto + baseline-shift differences.
              * platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-07-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
              * platform/mac/svg/batik/text/longTextOnPath-expected.txt:
              * platform/mac/svg/batik/text/textAnchor-expected.txt:
              * platform/mac/svg/batik/text/textAnchor2-expected.checksum:
              * platform/mac/svg/batik/text/textAnchor2-expected.png: y-position adjustments start new text chunks since SVG 1.1 2nd edition (in contrary to SVG 1.2 Tiny). Left the test as is.
              * platform/mac/svg/batik/text/textAnchor2-expected.txt:
              * platform/mac/svg/batik/text/textAnchor3-expected.txt:
              * platform/mac/svg/batik/text/textDecoration-expected.checksum:
              * platform/mac/svg/batik/text/textDecoration-expected.png: text-decoration defined on <text> paints with the paint sever defined on the <tspan>, test finally works!
              * platform/mac/svg/batik/text/textDecoration-expected.txt:
              * platform/mac/svg/batik/text/textDecoration2-expected.checksum:
              * platform/mac/svg/batik/text/textDecoration2-expected.png: Ditto.
              * platform/mac/svg/batik/text/textDecoration2-expected.txt:
              * platform/mac/svg/batik/text/textEffect-expected.checksum:
              * platform/mac/svg/batik/text/textEffect-expected.png: Just like pservers-grad-08-b.svg, no more blurry edges.
              * platform/mac/svg/batik/text/textEffect-expected.txt:
              * platform/mac/svg/batik/text/textEffect2-expected.txt:
              * platform/mac/svg/batik/text/textEffect3-expected.checksum:
              * platform/mac/svg/batik/text/textEffect3-expected.png: Ditto.
              * platform/mac/svg/batik/text/textEffect3-expected.txt:
              * platform/mac/svg/batik/text/textFeatures-expected.checksum:
              * platform/mac/svg/batik/text/textFeatures-expected.png: baseline-shift differences.
              * platform/mac/svg/batik/text/textFeatures-expected.txt:
              * platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum:
              * platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Completly fixed, now aligns properly with path, matches Opera & Batik.
              * platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
              * platform/mac/svg/batik/text/textLayout-expected.txt:
              * platform/mac/svg/batik/text/textLayout2-expected.checksum:
              * platform/mac/svg/batik/text/textLayout2-expected.png: baseline-shift differences.
              * platform/mac/svg/batik/text/textLayout2-expected.txt:
              * platform/mac/svg/batik/text/textLength-expected.txt:
              * platform/mac/svg/batik/text/textOnPath-expected.txt:
              * platform/mac/svg/batik/text/textOnPath2-expected.txt:
              * platform/mac/svg/batik/text/textOnPath3-expected.txt:
              * platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
              * platform/mac/svg/batik/text/textPCDATA-expected.txt:
              * platform/mac/svg/batik/text/textPosition-expected.txt:
              * platform/mac/svg/batik/text/textPosition2-expected.txt:
              * platform/mac/svg/batik/text/textProperties-expected.txt:
              * platform/mac/svg/batik/text/textProperties2-expected.txt:
              * platform/mac/svg/batik/text/verticalText-expected.checksum:
              * platform/mac/svg/batik/text/verticalText-expected.png:
              * platform/mac/svg/batik/text/verticalText-expected.txt:
              * platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
              * platform/mac/svg/batik/text/xmlSpace-expected.txt:
              * platform/mac/svg/carto.net/button-expected.txt:
              * platform/mac/svg/carto.net/colourpicker-expected.txt:
              * platform/mac/svg/carto.net/combobox-expected.txt:
              * platform/mac/svg/carto.net/selectionlist-expected.txt:
              * platform/mac/svg/carto.net/tabgroup-expected.txt:
              * platform/mac/svg/carto.net/textbox-expected.txt:
              * platform/mac/svg/carto.net/window-expected.txt:
              * platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt:
              * platform/mac/svg/css/text-shadow-multiple-expected.txt:
              * platform/mac/svg/custom/alignment-baseline-modes-expected.checksum:
              * platform/mac/svg/custom/alignment-baseline-modes-expected.png: central baseline now works as expected.
              * platform/mac/svg/custom/alignment-baseline-modes-expected.txt:
              * platform/mac/svg/custom/altglyph-expected.txt:
              * platform/mac/svg/custom/broken-internal-references-expected.txt:
              * platform/mac/svg/custom/container-opacity-clip-viewBox-expected.txt:
              * platform/mac/svg/custom/dominant-baseline-modes-expected.checksum:
              * platform/mac/svg/custom/dominant-baseline-modes-expected.png: ditto.
              * platform/mac/svg/custom/dominant-baseline-modes-expected.txt:
              * platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
              * platform/mac/svg/custom/glyph-transformation-with-hkern-expected.checksum:
              * platform/mac/svg/custom/glyph-transformation-with-hkern-expected.png: Kerning is now properly respected.
              * platform/mac/svg/custom/image-small-width-height-expected.txt:
              * platform/mac/svg/custom/invalid-fill-expected.txt:
              * platform/mac/svg/custom/invalid-fill-hex-expected.txt:
              * platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
              * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
              * platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
              * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
              * platform/mac/svg/custom/pattern-rotate-expected.txt:
              * platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
              * platform/mac/svg/custom/style-attribute-font-size-expected.txt:
              * platform/mac/svg/custom/text-dom-01-f-expected.txt:
              * platform/mac/svg/custom/text-letter-spacing-expected.txt:
              * platform/mac/svg/custom/text-linking-expected.txt:
              * platform/mac/svg/custom/text-rotation-expected.checksum: Added.
              * platform/mac/svg/custom/text-rotation-expected.png: Added.
              * platform/mac/svg/custom/text-rotation-expected.txt: Added.
              * platform/mac/svg/custom/text-whitespace-handling-expected.txt:
              * platform/mac/svg/custom/text-x-dx-lists-expected.txt:
              * platform/mac/svg/custom/text-x-dy-lists-expected.checksum: Added.
              * platform/mac/svg/custom/text-x-dy-lists-expected.png: Added.
              * platform/mac/svg/custom/text-x-dy-lists-expected.txt: Added.
              * platform/mac/svg/custom/text-x-override-in-tspan-child-expected.checksum:
              * platform/mac/svg/custom/text-x-override-in-tspan-child-expected.png:
              * platform/mac/svg/custom/text-x-override-in-tspan-child-expected.txt:
              * platform/mac/svg/custom/use-detach-expected.txt:
              * platform/mac/svg/filters/filter-on-filter-for-text-expected.txt:
              * platform/mac/svg/filters/filter-on-tspan-expected.txt:
              * platform/mac/svg/text/kerning-expected.txt:
              * platform/mac/svg/text/multichar-glyph-expected.txt:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.png:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.png:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.png:
              * platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
              * platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.png:
              * platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.txt:
              * platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.png:
              * platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.txt:
              * platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.png:
              * platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.txt:
              * platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
              * platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.txt:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
              * platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
              * platform/mac/svg/text/select-x-list-1-expected.checksum:
              * platform/mac/svg/text/select-x-list-1-expected.png:
              * platform/mac/svg/text/select-x-list-1-expected.txt:
              * platform/mac/svg/text/select-x-list-2-expected.checksum:
              * platform/mac/svg/text/select-x-list-2-expected.png:
              * platform/mac/svg/text/select-x-list-2-expected.txt:
              * platform/mac/svg/text/select-x-list-3-expected.checksum:
              * platform/mac/svg/text/select-x-list-3-expected.png:
              * platform/mac/svg/text/select-x-list-3-expected.txt:
              * platform/mac/svg/text/select-x-list-4-expected.checksum:
              * platform/mac/svg/text/select-x-list-4-expected.png:
              * platform/mac/svg/text/select-x-list-4-expected.txt:
              * platform/mac/svg/text/select-x-list-with-tspans-1-expected.checksum:
              * platform/mac/svg/text/select-x-list-with-tspans-1-expected.png:
              * platform/mac/svg/text/select-x-list-with-tspans-1-expected.txt:
              * platform/mac/svg/text/select-x-list-with-tspans-2-expected.checksum:
              * platform/mac/svg/text/select-x-list-with-tspans-2-expected.png:
              * platform/mac/svg/text/select-x-list-with-tspans-2-expected.txt:
              * platform/mac/svg/text/select-x-list-with-tspans-3-expected.checksum:
              * platform/mac/svg/text/select-x-list-with-tspans-3-expected.png:
              * platform/mac/svg/text/select-x-list-with-tspans-3-expected.txt:
              * platform/mac/svg/text/select-x-list-with-tspans-4-expected.checksum:
              * platform/mac/svg/text/select-x-list-with-tspans-4-expected.png:
              * platform/mac/svg/text/select-x-list-with-tspans-4-expected.txt:
              * platform/mac/svg/text/text-align-02-b-expected.checksum:
              * platform/mac/svg/text/text-align-02-b-expected.png:
              * platform/mac/svg/text/text-align-02-b-expected.txt:
              * platform/mac/svg/text/text-align-03-b-expected.txt:
              * platform/mac/svg/text/text-align-04-b-expected.checksum:
              * platform/mac/svg/text/text-align-04-b-expected.png:
              * platform/mac/svg/text/text-align-04-b-expected.txt:
              * platform/mac/svg/text/text-align-05-b-expected.checksum:
              * platform/mac/svg/text/text-align-05-b-expected.png:
              * platform/mac/svg/text/text-align-05-b-expected.txt:
              * platform/mac/svg/text/text-align-06-b-expected.checksum:
              * platform/mac/svg/text/text-align-06-b-expected.png:
              * platform/mac/svg/text/text-align-06-b-expected.txt:
              * platform/mac/svg/text/text-altglyph-01-b-expected.txt:
              * platform/mac/svg/text/text-deco-01-b-expected.checksum:
              * platform/mac/svg/text/text-deco-01-b-expected.png:
              * platform/mac/svg/text/text-deco-01-b-expected.txt:
              * platform/mac/svg/text/text-hkern-expected.checksum:
              * platform/mac/svg/text/text-hkern-expected.png: Kerning now respects text chunk boundaries.
              * platform/mac/svg/text/text-hkern-expected.txt:
              * platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
              * platform/mac/svg/text/text-path-01-b-expected.checksum:
              * platform/mac/svg/text/text-path-01-b-expected.png:
              * platform/mac/svg/text/text-path-01-b-expected.txt:
              * platform/mac/svg/text/text-spacing-01-b-expected.checksum:
              * platform/mac/svg/text/text-spacing-01-b-expected.png:
              * platform/mac/svg/text/text-spacing-01-b-expected.txt:
              * platform/mac/svg/text/text-text-01-b-expected.checksum:
              * platform/mac/svg/text/text-text-01-b-expected.png:
              * platform/mac/svg/text/text-text-01-b-expected.txt:
              * platform/mac/svg/text/text-text-04-t-expected.checksum:
              * platform/mac/svg/text/text-text-04-t-expected.png:
              * platform/mac/svg/text/text-text-04-t-expected.txt:
              * platform/mac/svg/text/text-text-05-t-expected.checksum:
              * platform/mac/svg/text/text-text-05-t-expected.png: y positions now also start text chunks, finally a progression on this test!
              * platform/mac/svg/text/text-text-05-t-expected.txt:
              * platform/mac/svg/text/text-text-06-t-expected.txt:
              * platform/mac/svg/text/text-text-07-t-expected.checksum:
              * platform/mac/svg/text/text-text-07-t-expected.png:
              * platform/mac/svg/text/text-text-07-t-expected.txt:
              * platform/mac/svg/text/text-text-08-b-expected.checksum:
              * platform/mac/svg/text/text-text-08-b-expected.png: Opacity doesn't affect selection anymore, matches all other browsers.
              * platform/mac/svg/text/text-tselect-01-b-expected.txt:
              * platform/mac/svg/text/text-tselect-02-f-expected.txt:
              * platform/mac/svg/text/text-tspan-01-b-expected.txt:
              * platform/mac/svg/text/text-vkern-expected.checksum:
              * platform/mac/svg/text/text-vkern-expected.png: Kerning now respects text chunk boundaries.
              * platform/mac/svg/text/text-vkern-expected.txt:
              * platform/mac/svg/text/textPathBoundsBug-expected.txt:
              * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
              * platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
              * platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
              * platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
              * platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
              * platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
              * platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
              * svg/batik/text/xmlSpace.svg: Fixed wrong test, now the embedded SVG Font is actually used.
              * svg/custom/altglyph.svg: Fixed wrong test, xlink namespace was wrong, xlink:href for altGlyph had no effect.
              * svg/custom/glyph-setting-d-attribute-expected.txt:
              * svg/custom/glyph-transformation-with-hkern-expected.txt:
              * svg/custom/text-rotation.svg: Added.
              * svg/custom/text-x-dy-lists.svg: Added.
              * svg/custom/text-x-override-in-tspan-child.svg: Fixed wrong test, depending on a previous bug - now matches Opera.
              * svg/text/multichar-glyph.svg: Also dump end positions of characters.
              * svg/text/resources/SelectionTestCase.js: Modify the selection test cases, to draw green lines marking the computed start & end postions of the selected characters.
              (selectRange):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65ac5a76
  19. 01 Oct, 2010 7 commits
    • rniwa@webkit.org's avatar
      2010-10-01 Ryosuke Niwa <rniwa@webkit.org> · 850699fa
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              FormatBlockCommand and IndentOutdentCommand should use the same code to iterate paragraphs
              https://bugs.webkit.org/show_bug.cgi?id=46840
      
              Added ApplyBlockElementCommand, which is an abstract class inherited by FormatBlockCommand
              and IndentOutdentCommand.  It is intended to be inherited by InsertListCommand as well.
      
              ApplyBlockElementCommand's doApply verifies the current selection and exits early
              if it's invalid or orphaned or if the current selection is outside editable region.
              It then calls formatSelection to apply the block element after which doApply restores the selection.
              formatSelection iterates through paragraphs and calls formatParagraph, a pure virtual function
              implemented by FormatBlockCommand and IndentOutdentCommand, on each paragraph.
      
              No new tests are added since this is a refactoring.
      
              * Android.mk: Added ApplyBlockElementCommand.cpp.
              * CMakeLists.txt: Ditto.
              * GNUmakefile.am: Added ApplyBlockElementCommand.cpp and ApplyBlockElementCommand.h.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * editing/ApplyBlockElementCommand.cpp: Added.
              (WebCore::countParagraphs): Moved from IndentOutdentCommand.cpp
              (WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand): Added.
              (WebCore::ApplyBlockElementCommand::doApply): Moved from IndentOutdentCommand::doApply.
              (WebCore::ApplyBlockElementCommand::formatSelection): Moved from IndentOutdentCommand::indentRegion.
              (WebCore::ApplyBlockElementCommand::createBlockElement): Added.
              (WebCore::ApplyBlockElementCommand::splitTextNodes): Moved from IndentOutdentCommand::splitTextNodes.
              * editing/ApplyBlockElementCommand.h: Added.
              * editing/EditingAllInOne.cpp:
              * editing/EditorCommand.cpp:
              (WebCore::executeFormatBlock):
              * editing/FormatBlockCommand.cpp: Removed doApply.
              (WebCore::FormatBlockCommand::FormatBlockCommand): Calls ApplyBlockElementCommand's constructor.
              (WebCore::FormatBlockCommand::formatParagraph): Renamed from doApplyForSingleParagraph.
              * editing/FormatBlockCommand.h: FormatBlockCommand inherits from ApplyBlockElementCommand.
              (WebCore::FormatBlockCommand::create): Uses QualifiedName for the tag name instead of AtomicString.
              * editing/IndentOutdentCommand.cpp: Removed doApply, indentIntoBlockquote, and splitTextNodes.
              (WebCore::IndentOutdentCommand::IndentOutdentCommand): Calls ApplyBlockElementCommand's constructor.
              (WebCore::IndentOutdentCommand::indentIntoBlockquote): The code to nullify targetBlockquote
              when the next paragraph is in a different table cell is moved to ApplyBlockElementCommand::formatSelection.
              (WebCore::IndentOutdentCommand::formatSelection): Added. Calls outdentRegion when outdenting.
              (WebCore::IndentOutdentCommand::formatParagraph): Added. Calls tryIndentingAsListItem and indentIntoBlockquote.
              * editing/IndentOutdentCommand.h: IndentOutdentCommand inherits from ApplyBlockElementCommand.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      850699fa
    • paroga@webkit.org's avatar
      2010-10-01 Patrick Gansterer <paroga@webkit.org> · d5933bd0
      paroga@webkit.org authored
              Reviewed by Anders Carlsson.
      
              [CMake] Add handling for ENABLE(NETSCAPE_PLUGIN_API)
              https://bugs.webkit.org/show_bug.cgi?id=46309
      
              * CMakeLists.txt:
              * CMakeListsEfl.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5933bd0
    • commit-queue@webkit.org's avatar
      2010-10-01 Rafael Antognolli <antognolli@profusion.mobi> · 968a2ef3
      commit-queue@webkit.org authored
              Unreviewed build fix.
      
              [CMAKE] Build fix for r68878
              https://bugs.webkit.org/show_bug.cgi?id=46985
      
              Fix name of files added to CMakeLists.txt:
              SVGTextLayoutBaseline.cpp -> SVGTextLayoutEngineBaseline.cpp
              SVGTextLayoutSpacing.cpp -> SVGTextLayoutEngineSpacing.cpp
      
              No features added, so no new tests.
      
              * CMakeLists.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      968a2ef3
    • zimmermann@webkit.org's avatar
      2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com> · 008eb8e2
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Add two new helper files for the new SVGTextLayoutEngine
              https://bugs.webkit.org/show_bug.cgi?id=46972
      
              Refactor code from SVGTextLayoutUtilities into two seperated classes.
              SVGTextLayoutUtilities will be removed, as soon as the main clss SVGTextLayoutEngine lands and gets used.
      
              Doesn't affect any functionality yet, as the new classes are not used so far.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/svg/SVGTextFragment.h:
              * rendering/svg/SVGTextLayoutEngineBaseline.cpp: Added.
              (WebCore::SVGTextLayoutEngineBaseline::SVGTextLayoutEngineBaseline):
              (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
              (WebCore::SVGTextLayoutEngineBaseline::dominantBaselineToAlignmentBaseline):
              (WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift):
              (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle):
              (WebCore::glyphOrientationIsMultiplyOf180Degrees):
              (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
              * rendering/svg/SVGTextLayoutEngineBaseline.h: Added.
              * rendering/svg/SVGTextLayoutEngineSpacing.cpp: Added.
              (WebCore::SVGTextLayoutEngineSpacing::SVGTextLayoutEngineSpacing):
              (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
              (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
              * rendering/svg/SVGTextLayoutEngineSpacing.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      008eb8e2
    • zimmermann@webkit.org's avatar
      2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com> · c3bb3bc6
      zimmermann@webkit.org authored
              Reviewed by Andreas Kling.
      
              Rename SVGTextLayoutBuilder to SVGTextLayoutAttributesBuilder
              https://bugs.webkit.org/show_bug.cgi?id=46971
      
              Doesn't affect any functionality, just moves files around.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/svg/RenderSVGText.cpp:
              (WebCore::RenderSVGText::layout): Adopt to renaming.
              * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Copied from rendering/svg/SVGTextLayoutBuilder.cpp.
              * rendering/svg/SVGTextLayoutAttributesBuilder.h: Copied from rendering/svg/SVGTextLayoutBuilder.h.
              * rendering/svg/SVGTextLayoutBuilder.cpp: Removed.
              * rendering/svg/SVGTextLayoutBuilder.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3bb3bc6
    • zimmermann@webkit.org's avatar
      2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com> · 29a27f68
      zimmermann@webkit.org authored
              Reviewed by Andreas Kling.
      
              Move SVG text related renderers into rendering/svg/
              https://bugs.webkit.org/show_bug.cgi?id=46969
      
              Doesn't affect any functionality, just moves files around.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/RenderSVGAllInOne.cpp:
              * rendering/RenderSVGInline.cpp: Removed.
              * rendering/RenderSVGInline.h: Removed.
              * rendering/RenderSVGInlineText.cpp: Removed.
              * rendering/RenderSVGInlineText.h: Removed.
              * rendering/RenderSVGTSpan.cpp: Removed.
              * rendering/RenderSVGTSpan.h: Removed.
              * rendering/RenderSVGText.cpp: Removed.
              * rendering/RenderSVGText.h: Removed.
              * rendering/RenderSVGTextPath.cpp: Removed.
              * rendering/RenderSVGTextPath.h: Removed.
              * rendering/SVGInlineFlowBox.cpp: Removed.
              * rendering/SVGInlineFlowBox.h: Removed.
              * rendering/SVGInlineTextBox.cpp: Removed.
              * rendering/SVGInlineTextBox.h: Removed.
              * rendering/SVGRootInlineBox.cpp: Removed.
              * rendering/SVGRootInlineBox.h: Removed.
              * rendering/SVGTextQuery.cpp: Removed.
              * rendering/SVGTextQuery.h: Removed.
              * rendering/svg/RenderSVGInline.cpp: Copied from rendering/RenderSVGInline.cpp.
              * rendering/svg/RenderSVGInline.h: Copied from rendering/RenderSVGInline.h.
              * rendering/svg/RenderSVGInlineText.cpp: Copied from rendering/RenderSVGInlineText.cpp.
              * rendering/svg/RenderSVGInlineText.h: Copied from rendering/RenderSVGInlineText.h.
              * rendering/svg/RenderSVGTSpan.cpp: Copied from rendering/RenderSVGTSpan.cpp.
              * rendering/svg/RenderSVGTSpan.h: Copied from rendering/RenderSVGTSpan.h.
              * rendering/svg/RenderSVGText.cpp: Copied from rendering/RenderSVGText.cpp.
              * rendering/svg/RenderSVGText.h: Copied from rendering/RenderSVGText.h.
              * rendering/svg/RenderSVGTextPath.cpp: Copied from rendering/RenderSVGTextPath.cpp.
              * rendering/svg/RenderSVGTextPath.h: Copied from rendering/RenderSVGTextPath.h.
              * rendering/svg/SVGInlineFlowBox.cpp: Copied from rendering/SVGInlineFlowBox.cpp.
              * rendering/svg/SVGInlineFlowBox.h: Copied from rendering/SVGInlineFlowBox.h.
              * rendering/svg/SVGInlineTextBox.cpp: Copied from rendering/SVGInlineTextBox.cpp.
              * rendering/svg/SVGInlineTextBox.h: Copied from rendering/SVGInlineTextBox.h.
              * rendering/svg/SVGRootInlineBox.cpp: Copied from rendering/SVGRootInlineBox.cpp.
              * rendering/svg/SVGRootInlineBox.h: Copied from rendering/SVGRootInlineBox.h.
              * rendering/svg/SVGTextQuery.cpp: Copied from rendering/SVGTextQuery.cpp.
              * rendering/svg/SVGTextQuery.h: Copied from rendering/SVGTextQuery.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29a27f68
    • zimmermann@webkit.org's avatar
      2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com> · 036d7ff4
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Add SVGTextMetrics/SVGTextFragment/SVGTextChunk primitives used by the new layout engine
              https://bugs.webkit.org/show_bug.cgi?id=46964
      
              The new SVG text layout engine will use these new classes.
              1) SVGTextMetrics is used to measure either single glyphs (which may span multiple characters, when ligatures are defined) or a range of characters.
                 
                 -> In "single glyph" mode, it returns the width/height of the glyph, the length of the glyph (> 1, when ligatures are used) and a "Glyph" object
                    describing the glyph (name of glyph, when used together with SVG Fonts and the unicode string the glyph describes).
                 -> In "range of characters" mode, it returns the width/height of the range, and its length.
      
                 All measurements are done using the regular Font::floatWidth() methods, this class just encapsulates its usage for the SVG text layout engine.
      
              2) SVGTextFragment describes a fragment of text, living in a SVGInlineTextBox, which can be measured/rendered in one shot.
                 It contains all necessary information to render the fragment (x/y/width/height, offset into characters() buffer for the first char of the fragment,
                 length, and an arbitary transformation, holding information about rotations/scale/glyph-orientation etc.)
      
                 In future the SVGTextLayoutEngine will generate SVGTextFragment objects for each SVGInlineTextBox. When painting no more measurements have to
                 be performed as SVGTextFragment contains all necessary information to render text / select text etc.
      
              3) SVGTextChunk describes a SVG text chunk, which may span multiple text boxes (and in turn text fragments).
      
                 Quotes from SVG spec:
                 Each absolute position adjustment defines a new "text chunk". Absolute position adjustments impact text layout in the following ways:
                  * Ligatures only occur when a set of characters which might map to a ligature are all in the same text chunk.
                  * Each text chunk represents a separate block of text for alignment due to "text-anchor" property values.
                  * Reordering of characters due to bidirectionality only occurs within a text chunk. Reordering does not happen across text chunks.
      
                  An absolute position adjustment occurs in the following circumstances:
                  * At the start of a <text> element
                  * At the start of each <textPath> element
                  * For each character within a <text>, <tspan>, <tref> and <altGlyph> element which has an "x" or "y" attribute value assigned to it explicitly
      
                  After the line-layout finishes, each "text chunk" is altered according to the textLength and text-anchor processing rules
                  (eg. for text-anchor="middle" moving the whole text chunk by -fragmentWidth/2, for horizontal text).
      
                  SVGTextChunk is just a simple helper class, that encapsulates measuring/altering a text chunk.
      
              Doesn't affect any tests, as these classes aren't used so far.
      
              * Android.mk: Add SVGTextMetrics.*, SVGTextFragment.h, SVGTextChunk.* to build.
              * CMakeLists.txt: Ditto.
              * GNUmakefile.am: Ditto.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * rendering/svg/SVGTextChunk.cpp: Added.
              * rendering/svg/SVGTextChunk.h: Added.
              * rendering/svg/SVGTextFragment.h: Added.
              * rendering/svg/SVGTextMetrics.cpp: Added.
              * rendering/svg/SVGTextMetrics.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      036d7ff4
  20. 30 Sep, 2010 1 commit
    • darin@apple.com's avatar
      2010-09-30 Darin Adler <darin@apple.com> · 7b7981bb
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove remaining calls to deprecatedParseURL
              https://bugs.webkit.org/show_bug.cgi?id=26599
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
              Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
      2010-09-30  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Remove remaining calls to deprecatedParseURL
              https://bugs.webkit.org/show_bug.cgi?id=26599
      
              * DOM/WebDOMOperations.mm:
              (-[DOMDocument URLWithAttributeString:]):
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::createPlugin):
              Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
      2010-09-30  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Remove remaining calls to deprecatedParseURL
              https://bugs.webkit.org/show_bug.cgi?id=26599
      
              Test: fast/replaced/object-param-spaces.html
      
              * css/CSSHelper.cpp: Removed.
              * css/CSSHelper.h: Removed deprecatedParseURL.
      
              * html/parser/HTMLParserIdioms.cpp:
              (WebCore::stripLeadingAndTrailingHTMLSpaces):
              Fixed bug where the function would turn the null string into the empty string.
              Fixed bug where the function would not strip all trailing spaces.
      
              * html/parser/CSSPreloadScanner.cpp:
              (WebCore::CSSPreloadScanner::CSSPreloadScanner): Initialize m_state
              instead of calling the reset function.
              (WebCore::CSSPreloadScanner::scan): Tweaked coding style.
              (WebCore::CSSPreloadScanner::tokenize): Use isHTMLSpace instead of
              an identical local function named isWhitespace.
              (WebCore::parseCSSStringOrURL): Added. This function does what
              deprecatedParseURL did before, and this is the only place in WebKit
              that needs it. The code implements the rules for a string or URL
              token. The real CSS parser does this with flex and the code to hook
              flex up to yacc, so the function is not needed there.
              (WebCore::CSSPreloadScanner::emitRule): Streamlined the code a bit
              and mae it call parseCSSStringOrURL.
      
              * bindings/generic/BindingSecurity.h:
              (WebCore::::allowSettingFrameSrcToJavascriptUrl):
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::allowSettingSrcToJavascriptURL):
              * bindings/js/JSHTMLFrameElementCustom.cpp:
              (WebCore::allowSettingJavascriptURL):
              * bindings/objc/DOM.mm:
              (-[DOMElement _getURLAttribute:]):
              * bindings/objc/DOMHTML.mm:
              (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
              * dom/Document.cpp:
              (WebCore::Document::processBaseElement):
              * dom/Element.cpp:
              (WebCore::isAttributeToRemove):
              (WebCore::Element::getURLAttribute):
              (WebCore::Element::getNonEmptyURLAttribute):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::defaultEventHandler):
              (WebCore::HTMLAnchorElement::parseMappedAttribute):
              (WebCore::HTMLAnchorElement::href):
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::parseMappedAttribute):
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::parseMappedAttribute):
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::parseMappedAttribute):
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::parseMappedAttribute):
              * html/HTMLImageLoader.cpp:
              (WebCore::HTMLImageLoader::sourceURI):
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::parseMappedAttribute):
              * html/HTMLMediaElement.cpp:
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::parseMappedAttribute):
              (WebCore::HTMLObjectElement::parametersForPlugin):
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::parseMappedAttribute):
              * html/HTMLTablePartElement.cpp:
              (WebCore::HTMLTablePartElement::parseMappedAttribute):
              * html/parser/HTMLPreloadScanner.cpp:
              (WebCore::HTMLNames::PreloadTask::setUrlToLoad):
              * loader/FormSubmission.cpp:
              (WebCore::FormSubmission::Attributes::parseAction):
              * platform/chromium/ClipboardChromium.cpp:
              (WebCore::ClipboardChromium::declareAndWriteDragImage):
              * platform/chromium/PasteboardChromium.cpp:
              (WebCore::Pasteboard::writeImage):
              * platform/qt/ClipboardQt.cpp:
              (WebCore::ClipboardQt::declareAndWriteDragImage):
              * platform/win/ClipboardWin.cpp:
              (WebCore::ClipboardWin::declareAndWriteDragImage):
              * rendering/HitTestResult.cpp:
              (WebCore::HitTestResult::absoluteImageURL):
              (WebCore::HitTestResult::absoluteMediaURL):
              (WebCore::HitTestResult::absoluteLinkURL):
              * svg/SVGAElement.cpp:
              (WebCore::SVGAElement::defaultEventHandler):
              * svg/SVGImageLoader.cpp:
              (WebCore::SVGImageLoader::sourceURI):
              * wml/WMLAElement.cpp:
              (WebCore::WMLAElement::defaultEventHandler):
              * wml/WMLImageLoader.cpp:
              (WebCore::WMLImageLoader::sourceURI):
              Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
      
              * WebCore.exp.in: Updated.
      
              * Android.mk: Removed CSSHelper.cpp.
              * CMakeLists.txt: Ditto.
              * GNUmakefile.am: Ditto.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
      
              * bindings/js/JSAttrCustom.cpp:
              * bindings/js/JSElementCustom.cpp:
              * bindings/v8/custom/V8ElementCustom.cpp:
              * bindings/v8/custom/V8LocationCustom.cpp:
              * css/CSSParser.cpp:
              * html/HTMLMediaElement.cpp:
              * html/HTMLVideoElement.cpp:
              * loader/ImageLoader.cpp:
              * rendering/style/RenderStyle.h:
              Removed unneeded include of CSSHelper.h.
      2010-09-30  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Remove remaining calls to deprecatedParseURL
              https://bugs.webkit.org/show_bug.cgi?id=26599
      
              * fast/replaced/object-param-spaces-expected.txt: Copied from
              LayoutTests/fast/replaced/object-param-url-control-char-expected.txt.
              * fast/replaced/object-param-spaces.html: Copied from
              LayoutTests/fast/replaced/object-param-url-control-char.html.
              * fast/replaced/object-param-url-control-char-expected.txt: Removed.
              * fast/replaced/object-param-url-control-char.html: Removed.
              Changed this test to expect HTML standard space trimming, but not the WebKit-only
              control character stripping we had historically.
      
              * fast/url/query-expected.txt: Updated to expect the test to pass.
      
              * fast/url/script-tests/segments-from-data-url.js: Changed expected result to not
              expect stripping of newline characters.
              * fast/url/script-tests/segments.js: Ditto.
              * fast/url/segments-expected.txt: Updated results.
              * fast/url/segments-from-data-url-expected.txt: Ditto.
      
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
              These tests had multiple test cases with embedded control characters. These URLs no
              longer qualify as javascript URLs, so there are no longer any unsafe JavaScript log
              messages for them. The test cases themselves need not be changed at this time.
      
              * http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
              * http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
              Updated expected results to reflect the fact that the control character is no longer
              stripped from the URL in these cases. The test is still valid, but these are not as
              interesting test cases any more since control characters do not have special handling.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b7981bb