1. 30 Oct, 2010 8 commits
    • dglazkov@chromium.org's avatar
      2010-10-30 Dimitri Glazkov <dglazkov@chromium.org> · 55a42461
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
              https://bugs.webkit.org/show_bug.cgi?id=46015
      
              Tuned the test to better reflect its point: the event should indeed fire (it used to be swallowed),
              but its target should be a non-shadow node.
      
              * fast/events/shadow-boundary-crossing.html: Modified the test.
      2010-10-30  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
              https://bugs.webkit.org/show_bug.cgi?id=46015
      
              This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
              for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.
      
              This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
              appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.
      
              * Android.mk: Added EventContext, WindowEventContext files.
              * CMakeLists.txt: Ditto.
              * GNUmakefile.am: Ditto.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * dom/ContainerNode.cpp:
              (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
              * dom/EventContext.cpp: Added.
              * dom/EventContext.h: Added.
              * dom/Node.cpp:
              (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware.
              (WebCore::Node::createRendererIfNeeded): Ditto.
              (WebCore::Node::parentOrHostNode): Added new helper method.
              (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware.
              (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one.
              (WebCore::Node::eventAncestors): Refactored to collect a vector of EventContexts.
              (WebCore::Node::topEventContext): Added.
              (WebCore::eventHasListeners): Changed to use EventContexts.
              (WebCore::Node::dispatchGenericEvent): Ditto.
              * dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,
                  and changed signature of eventAncestors to use EventContexts.
              * dom/Text.cpp:
              (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
              * svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
              * svg/SVGElement.h: Ditto.
              * dom/WindowEventContext.cpp: Added.
              * dom/WindowEventContext.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55a42461
    • xan@webkit.org's avatar
      2010-10-30 Xan Lopez <xlopez@igalia.com> · 87b1ca5d
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Use new width for height APIs in GTK+ 3.x
              https://bugs.webkit.org/show_bug.cgi?id=48709
      
              Use the new width for height APIs in GTK+ 3.x, since size-request
              is deprecated.
      
              For now we just return the same value for preferred and minimum
              width/height, which should match the 2.x behavior. Probably we
              could do something smarter for the minimum values.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_get_preferred_width): return our preferred width.
              (webkit_web_view_get_preferred_height): return our preferred height.
              (webkit_web_view_class_init): hook the new default handlers.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87b1ca5d
    • andreas.kling@nokia.com's avatar
      2010-10-30 Andreas Kling <kling@webkit.org> · 3d31fe2e
      andreas.kling@nokia.com authored
              Reviewed by Antonio Gomes.
      
              [Qt] IM: Don't manipulate selection via RenderTextControl
              https://bugs.webkit.org/show_bug.cgi?id=48700
      
              Go directly through the Frame's SelectionController instead.
      
              No new tests, this is covered by tst_QWebPage::inputMethods.
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::inputMethodEvent):
              (QWebPage::inputMethodQuery):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d31fe2e
    • andreas.kling@nokia.com's avatar
      2010-10-30 Andreas Kling <kling@webkit.org> · ada76a83
      andreas.kling@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt][WK2] Crash in drawUpdateChunkIntoBackingStore
              https://bugs.webkit.org/show_bug.cgi?id=48707
      
              UpdateChunk images have to be created using the QImage constructor
              that takes a bytesPerLine (stride) value, or the data length won't
              match UpdateChunk::size().
      
              * Shared/qt/UpdateChunk.cpp:
              (WebKit::UpdateChunk::createImage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ada76a83
    • andreas.kling@nokia.com's avatar
      2010-10-30 Andreas Kling <kling@webkit.org> · ea3a0469
      andreas.kling@nokia.com authored
              Reviewed by Antonio Gomes.
      
              [Qt] QtTestBrowser: Switching view type moves the embedded inspector
              https://bugs.webkit.org/show_bug.cgi?id=48705
      
              Reinsert the embedded inspector into the splitter after changing
              between QWebView/QGraphicsWebView.
      
              * QtTestBrowser/launcherwindow.cpp:
              (LauncherWindow::init):
              (LauncherWindow::initializeView):
              * QtTestBrowser/webinspector.h:
              (WebInspector::WebInspector):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea3a0469
    • zimmermann@webkit.org's avatar
      2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com> · f08b5ba1
      zimmermann@webkit.org authored
              Reviewed by Rob Buis.
      
              Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
              https://bugs.webkit.org/show_bug.cgi?id=48686
      
              Convert the next set of primitives to use the new SVG(Animated)PropertyTearOff concept.
      
              Tests: svg/dom/SVGAnimatedNumber.html
                     svg/dom/SVGAnimatedNumberList.html
                     svg/dom/SVGNumber.html
      
              * GNUmakefile.am: Add SVGAnimatedNumber.h / SVGAnimatedNumberList.h to build.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedNumber/SVGAnimatedNumberList as new style SVG animated properties. Remove SVGNumber from PODType hash.
              * bindings/scripts/CodeGeneratorJS.pm: Remove special SVGNumber handing, it's obsolete now.
              * bindings/scripts/CodeGeneratorObjC.pm: Add special SVGNumber handling, as it's the first of the converted dynamic SVGAnimatedProperty types that's not in WebCore namespace.
              * bindings/scripts/CodeGeneratorV8.pm: Use AvoidInclusionOfType method from CodeGenerator.pm, remove special SVGNumber handling, that's obsolete now.
              * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
              (WebCore::extractFloatValuesFromSVGNumberList): Adapt to SVGNumberList change, which is a plain Vector<float> now.
              * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedNumber/SVGAnimatedNumberList handling.
              * svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
              * svg/SVGAnimatedNumber.h: Added.
              * svg/SVGAnimatedNumber.idl: Enable StrictTypeChecking.
              * svg/SVGAnimatedNumberList.h: Added.
              * svg/SVGAnimatedNumberList.idl: Ditto.
              * svg/SVGComponentTransferFunctionElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List).
              (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
              (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
              (WebCore::SVGComponentTransferFunctionElement::transferFunction):
              * svg/SVGComponentTransferFunctionElement.h:
              * svg/SVGFEColorMatrixElement.cpp: Ditto.
              (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
              (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
              (WebCore::SVGFEColorMatrixElement::build):
              * svg/SVGFEColorMatrixElement.h:
              * svg/SVGFECompositeElement.h: Ditto.
              * svg/SVGFEConvolveMatrixElement.cpp: Ditto.
              (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement):
              (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier): Added, replacing char[] hack by a static atomic string.
              (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier): Ditto.
              (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute):
              (WebCore::SVGFEConvolveMatrixElement::build):
              * svg/SVGFEConvolveMatrixElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
              * svg/SVGFEDiffuseLightingElement.cpp: Ditto.
              (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace.
              (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
              * svg/SVGFEDiffuseLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
              * svg/SVGFEDisplacementMapElement.h: Ditto.
              * svg/SVGFEGaussianBlurElement.cpp: Ditto.
              (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Remove trailing whitespace.
              (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
              * svg/SVGFEGaussianBlurElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
              * svg/SVGFELightElement.h: Ditto.
              * svg/SVGFEMorphologyElement.cpp:
              (WebCore::SVGFEMorphologyElement::radiusXIdentifier): Added, replacing char[] hack by a static atomic string.
              (WebCore::SVGFEMorphologyElement::radiusYIdentifier): Ditto.
              * svg/SVGFEMorphologyElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
              * svg/SVGFEOffsetElement.h: Ditto.
              * svg/SVGFESpecularLightingElement.cpp:
              (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace.
              (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
              * svg/SVGFESpecularLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
              * svg/SVGFETurbulenceElement.cpp:
              (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Remove trailing whitespace.
              (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
              * svg/SVGFETurbulenceElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
              * svg/SVGFilterElement.cpp:
              (WebCore::SVGFilterElement::filterResXIdentifier): Remove trailing whitespace.
              (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
              * svg/SVGLengthList.idl: Remove leftover [SVGListProperty] marker.
              * svg/SVGMarkerElement.cpp:
              (WebCore::SVGMarkerElement::orientTypeIdentifier): Remove trailing whitespace.
              (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
              * svg/SVGNumber.idl: Remove [PODType] marker, add StrictTypeChecking.
              * svg/SVGNumberList.cpp: Convert from SVGPODList<RefPtr<SVGPODListItem<float> > > to plain Vector<float>, just like it has been done for SVGLengthList before.
              (WebCore::SVGNumberList::parse):
              (WebCore::SVGNumberList::valueAsString):
              * svg/SVGNumberList.h:
              (WebCore::SVGNumberList::SVGNumberList):
              * svg/SVGPathElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
              * svg/SVGStopElement.h: Ditto.
              * svg/SVGTextPositioningElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List).
              (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
              (WebCore::SVGTextPositioningElement::parseMappedAttribute):
              * svg/SVGTextPositioningElement.h: Ditto.
              * svg/properties/SVGPropertyTraits.h: Add SVGNumberList handling.
      
      2010-10-30  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Rob Buis.
      
              Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
              https://bugs.webkit.org/show_bug.cgi?id=48686
      
              Fix invalid tests in svg/dynamic-updates, that relied on a bug in our SVGNumberList implementation. If an item was already
              inserted in a list, and we tried to insert it somewhere else, we didn't remove it from the old list. Now that SVGNumberList
              has been switched to SVGAnimatedListPropertyTearOff, the bug is fixed, and it behaves exactly like SVGLengthList.
      
              Side effect: svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html now works as expected (dynamic update is executed)
      
              * platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum:
              * platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
              * svg/dom/SVGAnimatedNumber-expected.txt: Added.
              * svg/dom/SVGAnimatedNumber.html: Added.
              * svg/dom/SVGAnimatedNumberList-expected.txt: Added.
              * svg/dom/SVGAnimatedNumberList.html: Added.
              * svg/dom/SVGNumber-expected.txt: Added.
              * svg/dom/SVGNumber.html: Added.
              * svg/dom/script-tests/SVGAnimatedNumber.js: Added.
              * svg/dom/script-tests/SVGAnimatedNumberList.js: Added.
              * svg/dom/script-tests/SVGNumber.js: Added.
              * svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-type-prop.js: Test now works in Firefox as well.
              (executeTest): SVGNumber.value only accepts numbers, not strings, now that StrictTypeChecking is enabled.
              * svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-values-prop.js: Test now works in Firefox as well.
              (executeTest): Don't call appendItem several times with the same SVGNumber, it will be removed if it was already inserted in a list.
              * svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f08b5ba1
    • zimmermann@webkit.org's avatar
      2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com> · 0c8d61e8
      zimmermann@webkit.org authored
              Not reviewed.
      
              Update SVGFEFloodElement mac-leopard baseline, which was forgotten.
      
              * platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.checksum:
              * platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
              * platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.checksum:
              * platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c8d61e8
    • dbates@webkit.org's avatar
      2010-10-29 Daniel Bates <dbates@rim.com> · 949216b4
      dbates@webkit.org authored
              No review, rolling out 70971.
              http://trac.webkit.org/changeset/70971
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
              it caused layout tests regressions on all bots. In particular, the
              child count in a generated frame name differs after this patch. We need
              to look into this further.
      
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::name):
      
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              No review, rolling out 70971.
              http://trac.webkit.org/changeset/70971
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
              it caused layout tests regressions on all bots. In particular, the
              child count in a generated frame name differs after this patch. We need
              to look into this further.
      
              * Api/qwebframe.cpp:
              (QWebFrame::frameName):
      
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              No review, rolling out 70971.
              http://trac.webkit.org/changeset/70971
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
              it caused layout tests regressions on all bots. In particular, the
              child count in a generated frame name differs after this patch. We need
              to look into this further.
      
              * webkit/webkitwebframe.cpp:
              (webkit_web_frame_get_name):
      
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              No review, rolling out 70971.
              http://trac.webkit.org/changeset/70971
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
              it caused layout test failures on all bots. In particular, the
              child count in a generated frame name differs after this patch. We need
              to look into this further.
      
              * WebFrame.cpp:
              (WebFrame::name):
      
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              No review, rolling out 70971.
              http://trac.webkit.org/changeset/70971
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
              it caused layout test failures on all bots. In particular, the
              child count in a generated frame name differs after this patch. We need
              to look into this further.
      
              * WebView/WebFrame.mm:
              (-[WebFrame name]):
      
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              No review, rolling out 70971.
              http://trac.webkit.org/changeset/70971
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
              it caused layout test failures on all bots. In particular, the
              child count in a generated frame name differs after this patch. We need
              to look into this further.
      
              * ewk/ewk_frame.cpp:
              (ewk_frame_name_get):
      
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              No review, rolling out 70971.
              http://trac.webkit.org/changeset/70971
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
              it caused layout test failures on all bots. In particular, the
              child count in a generated frame name differs after this patch. We need
              to look into this further.
      
              Test: fast/frames/iframe-set-inner-html.html
      
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::openURL):
              (WebCore::HTMLFrameElementBase::setName):
              * html/HTMLFrameElementBase.h:
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::mainResource):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadURLIntoChildFrame):
              (WebCore::FrameLoader::commitProvisionalLoad):
              * loader/HistoryController.cpp:
              (WebCore::HistoryController::saveDocumentState):
              (WebCore::HistoryController::restoreDocumentState):
              (WebCore::HistoryController::createItem):
              (WebCore::HistoryController::currentFramesMatchItem):
              * loader/ProgressTracker.cpp:
              (WebCore::ProgressTracker::progressStarted):
              (WebCore::ProgressTracker::progressCompleted):
              * loader/archive/cf/LegacyWebArchive.cpp:
              (WebCore::LegacyWebArchive::create):
              * page/FrameTree.cpp:
              (WebCore::FrameTree::setName):
              (WebCore::FrameTree::clearName):
              (WebCore::FrameTree::uniqueChildName):
              (WebCore::FrameTree::child):
              (WebCore::FrameTree::find):
              * page/FrameTree.h:
              (WebCore::FrameTree::name):
      
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              No review, rolling out 70971.
              http://trac.webkit.org/changeset/70971
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
              it caused layout test failures on all bots. In particular, the
              child count in a generated frame name differs after this patch. We need
              to look into this further.
      
              * fast/frames/frame-element-name-expected.txt:
              * fast/frames/iframe-set-inner-html-expected.txt: Copied from LayoutTests/fast/frames/iframe-set-inner-html-expected.txt.
              * fast/frames/iframe-set-inner-html.html: Copied from LayoutTests/fast/frames/iframe-set-inner-html.html.
              * fast/frames/resources/frame-element-name-left.html:
              * fast/frames/resources/frame-element-name-right.html:
      
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              No review, rolling out 70971.
              http://trac.webkit.org/changeset/70971
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
              it caused layout test failures on all bots. In particular, the
              child count in a generated frame name differs after this patch. We need
              to look into this further.
      
              * WebProcess/WebPage/WebFrame.cpp:
              (WebKit::WebFrame::name):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      949216b4
  2. 29 Oct, 2010 32 commits
    • tonikitoo@webkit.org's avatar
      Needs a "LinuxEditingBehavior", perhaps with a better name · 525d4c70
      tonikitoo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36627
      
      Reviewed by Ojan Vafai.
      Patch by Antonio Gomes <agomes@rim.com>
      
      WebCore:
      
      Added EditingUnixBehavior editing type aim to cover the cases when
      neither Mac or Windows behaviors are appropriated.
      
      It was decided to name it Unix not Linux.
      
      No new tests. The current editing tests that involve platform specific
      bahaviors are coded so that they go through all editing behavior
      types possible. There will be a follow up bug where all of them will
      be updated to include the new editing behavior ("unix").
      
      * editing/EditingBehaviorTypes.h:
      * page/Settings.cpp:
      (WebCore::editingBehaviorTypeForPlatform):
      (WebCore::Settings::Settings):
      
      WebKit/chromium:
      
      Added the corresponding Chromium setting to WebCore's EditingUnixBehavior: EditingBehaviorUnix.
      
      * public/WebSettings.h:
      * src/AssertMatchingEnums.cpp:
      
      WebKit/gtk:
      
      Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WEBKIT_EDITING_BEHAVIOR_UNIX.
      
      * webkit/webkitwebsettings.cpp:
      (webkit_web_settings_class_init):
      * webkit/webkitwebsettings.h:
      
      WebKit/mac:
      
      Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
      
      * WebView/WebFrame.mm:
      (core):
      * WebView/WebPreferencesPrivate.h:
      
      WebKit/qt:
      
      Adding support to Qt's DRTSupport class to test the newly introduced Unix editing behavior.
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setEditingBehavior):
      
      WebKit/win:
      
      Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
      
      * Interfaces/IWebPreferences.idl:
      
      WebKitTools:
      
      Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.
      
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (LayoutTestController::setEditingBehavior):
      * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
      (LayoutTestController::setEditingBehavior):
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      (LayoutTestController::setEditingBehavior):
      * DumpRenderTree/win/LayoutTestControllerWin.cpp:
      (LayoutTestController::setEditingBehavior):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      525d4c70
    • dbates@webkit.org's avatar
      2010-10-29 Daniel Bates <dbates@rim.com> · cad5323c
      dbates@webkit.org authored
              Reviewed by Adam Barth.
      
              For unnamed frames, window.name returns a generated name
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Modified Chromium-port to use FrameTree::uniqueName().
      
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::name):
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Adam Barth.
      
              For unnamed frames, window.name returns a generated name
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Modified Qt-port to use FrameTree::uniqueName().
      
              * Api/qwebframe.cpp:
              (QWebFrame::frameName):
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Adam Barth.
      
              For unnamed frames, window.name returns a generated name
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Modified GTK-port to use FrameTree::uniqueName().
      
              * webkit/webkitwebframe.cpp:
              (webkit_web_frame_get_name):
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Adam Barth.
      
              For unnamed frames, window.name returns a generated name
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Modified Apple Windows-port to use FrameTree::uniqueName().
      
              * WebFrame.cpp:
              (WebFrame::name):
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Adam Barth.
      
              For unnamed frames, window.name returns a generated name
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Modified Mac-port to use FrameTree::uniqueName().
      
              * WebView/WebFrame.mm:
              (-[WebFrame name]):
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Adam Barth.
      
              For unnamed frames, window.name returns a generated name
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Modified EFL-port to use FrameTree::uniqueName().
      
              * ewk/ewk_frame.cpp:
              (ewk_frame_name_get):
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Adam Barth.
      
              For unnamed frames, window.name returns a generated name
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Fixes an issue where the window.name of an unnamed frame returns
              a unique generated name that is used internally to identify the
              frame. Instead, we should return an empty string as implied by
              section 5.1.6 of the HTML5 spec. (http://www.w3.org/TR/html5/browsers.html#browsing-context-names).
              This section describes that a browsing context can have no name or be
              the empty string.
      
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::openURL): Removed ASSERT for empty
              frame name since this is valid as per the HTML5 spec.
              (WebCore::HTMLFrameElementBase::setName): Removed the call to FrameTree::uniqueChildName()
              since the loader code no longer depends on the frame name being unique.
              * html/HTMLFrameElementBase.h:
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::mainResource): Use FrameTree::uniqueName().
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadURLIntoChildFrame): Ditto.
              (WebCore::FrameLoader::commitProvisionalLoad): Ditto.
              * loader/HistoryController.cpp:
              (WebCore::HistoryController::saveDocumentState): Ditto.
              (WebCore::HistoryController::restoreDocumentState): Ditto.
              (WebCore::HistoryController::createItem):
              (WebCore::HistoryController::currentFramesMatchItem): Ditto.
              * loader/ProgressTracker.cpp:
              (WebCore::ProgressTracker::progressStarted): Ditto.
              (WebCore::ProgressTracker::progressCompleted): Ditto.
              * loader/archive/cf/LegacyWebArchive.cpp:
              (WebCore::LegacyWebArchive::create): Ditto.
              * page/FrameTree.cpp:
              (WebCore::FrameTree::setName): Modified to store the DOM-specified
              name of the frame.
              (WebCore::FrameTree::clearName):
              (WebCore::FrameTree::uniqueChildName): Use FrameTree::uniqueName().
              (WebCore::FrameTree::child): Ditto.
              (WebCore::FrameTree::find): Ditto.
              * page/FrameTree.h:
              (WebCore::FrameTree::uniqueName): Added.
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Adam Barth.
      
              For unnamed frames, window.name returns a generated name
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Updated test case fast/frames/frame-element-name.html to check
              the value of window.name.
      
              * fast/frames/frame-element-name-expected.txt: Updated result.
              * fast/frames/iframe-set-inner-html-expected.txt: Removed; This test ensured
              that the generated name for an unnamed frames was unique by looking at the
              value of window.name. However, the generated name should not be exposed to
              web developers. Instead, window.name should return the empty string for
              an unnamed frame as implied by section 5.1.6 of the HTML5 spec. We should
              consider exposing a DRT method for obtaining the internal frame name (which
              may be generated) and re-implementing this test to use it.
              * fast/frames/iframe-set-inner-html.html: Removed.
              * fast/frames/resources/frame-element-name-left.html: Added test for window.name.
              * fast/frames/resources/frame-element-name-right.html: Ditto.
      2010-10-29  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Adam Barth.
      
              For unnamed frames, window.name returns a generated name
              https://bugs.webkit.org/show_bug.cgi?id=6751
      
              Modified WebKit2 to use FrameTree::uniqueName().
      
              * WebProcess/WebPage/WebFrame.cpp:
              (WebKit::WebFrame::name):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cad5323c
    • mrowe@apple.com's avatar
      Roll out r70847 as it causes crashes when typing text in both Safari and Mail:... · 856d3c12
      mrowe@apple.com authored
      Roll out r70847 as it causes crashes when typing text in both Safari and Mail: <http://webkit.org/b/48708>.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      856d3c12
    • mitz@apple.com's avatar
      Snow Leopard PowerPC build fix. · 789fc3bd
      mitz@apple.com authored
      * libWebKitSystemInterfaceSnowLeopard.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      789fc3bd
    • mitz@apple.com's avatar
      Leopard PowerPC build fix. · f48bfeca
      mitz@apple.com authored
      * libWebKitSystemInterfaceLeopard.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f48bfeca
    • jamesr@google.com's avatar
      2010-10-29 James Robinson <jamesr@chromium.org> · b790dfb5
      jamesr@google.com authored
              Update pixel expectations for Snow Leopard for tests in tables/mozilla/bugs.
      
              Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
              expectations for tests that need them.  List of files omitted due to length.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b790dfb5
    • weinig@apple.com's avatar
      Implement WebProcess::platformSetCacheModel for windows · 71df02b3
      weinig@apple.com authored
      <rdar://problem/8605796>
      https://bugs.webkit.org/show_bug.cgi?id=48703
      
      Reviewed by Simon Fraser.
      
      * WebProcess/win/WebProcessWin.cpp:
      (WebKit::memorySize):
      (WebKit::volumeFreeSize):
      (WebKit::WebProcess::platformSetCacheModel):
      Add implemenation based on the version in WebKit/win/WebView.cpp.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71df02b3
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed test expectations update. · 37ac60f3
      dimich@chromium.org authored
      Enable a few tests that were fixed in revs 70891:70949.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37ac60f3
    • andreas.kling@nokia.com's avatar
      2010-10-29 Andreas Kling <kling@webkit.org> · dde5dff0
      andreas.kling@nokia.com authored
              Reviewed by Anders Carlsson.
      
              WK2: Unbreak compilation of WebPlatformTouchPoint::decode()
      
              * Shared/WebPlatformTouchPoint.cpp:
              (WebKit::WebPlatformTouchPoint::decode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dde5dff0
    • darin@apple.com's avatar
      Try to fix build. · 9676d9e7
      darin@apple.com authored
      * page/ContextMenuController.cpp: Added include of BackForwardController.h.
      * page/DOMWindow.cpp: Ditto.
      * page/History.cpp: Ditto.
      * platform/ContextMenu.cpp: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9676d9e7
    • mrowe@apple.com's avatar
      Versioning. · 969b6626
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      969b6626
    • darin@apple.com's avatar
      More back/forward refactoring · e10e1282
      darin@apple.com authored
      Reviewed by Sam Weinig.
      
      WebCore: 
      
      * WebCore.exp.in: Updated.
      
      * GNUmakefile.am: Removed BackForwardControllerClient.h.
      * WebCore.gypi: Ditto.
      * WebCore.pro: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      
      * history/BackForwardControllerClient.h: Removed.
      
      * history/BackForwardController.cpp:
      (WebCore::BackForwardController::BackForwardController):
      Set up just m_client.
      (WebCore::BackForwardController::~BackForwardController):
      Removed call to backForwardControllerDestroyed.
      (WebCore::BackForwardController::canGoBackOrForward): Added.
      (WebCore::BackForwardController::goBackOrForward): Added.
      (WebCore::BackForwardController::goBack): Added.
      (WebCore::BackForwardController::goForward): Added.
      (WebCore::BackForwardController::addItem): Added.
      (WebCore::BackForwardController::setCurrentItem): Added.
      (WebCore::BackForwardController::count): Added.
      (WebCore::BackForwardController::backCount): Added.
      (WebCore::BackForwardController::forwardCount): Added.
      (WebCore::BackForwardController::itemAtIndex): Added.
      (WebCore::BackForwardController::isActive): Added.
      (WebCore::BackForwardController::close): Added.
      
      * history/BackForwardController.h: Added functions from Page
      and BackForwardList that should be called here instead.
      Note that BackForwardList is to be renamed BackForwardClient soon.
      
      * history/BackForwardList.h: Removed many now-unneeded
      virtual functions.
      
      * history/BackForwardListImpl.h: Moved BackForwardListClient
      in here.
      
      * history/PageCache.cpp:
      (WebCore::logCanCachePageDecision): Use backForward().
      (WebCore::PageCache::canCache): Ditto.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::transitionToCommitted): Removed unneeded
      null check of backFowardList, which is never null.
      (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Use backForward.
      (WebCore::FrameLoader::didFirstLayout): Ditto.
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto.
      (WebCore::FrameLoader::checkDidPerformFirstNavigation): Ditto.
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::goToItem): Ditto.
      (WebCore::HistoryController::updateForStandardLoad): Ditto.
      (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): Ditto.
      (WebCore::HistoryController::updateBackForwardListClippedAtTarget): Ditto.
      (WebCore::HistoryController::pushState): Ditto.
      * loader/NavigationScheduler.cpp:
      (WebCore::ScheduledHistoryNavigation::fire): Ditto.
      (WebCore::NavigationScheduler::scheduleHistoryNavigation): Ditto.
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::close): Ditto.
      * page/History.cpp:
      (WebCore::History::length): Ditto.
      
      * page/Page.cpp:
      (WebCore::Page::Page): Use more adoptPtr. Use backForwardClient instead of
      backForwardControllerClient.
      (WebCore::Page::~Page): Use backForward.
      (WebCore::Page::backForwardList): Ditto.
      (WebCore::Page::goBack): Ditto.
      (WebCore::Page::goForward): Ditto.
      (WebCore::Page::canGoBackOrForward): Ditto.
      (WebCore::Page::goBackOrForward): Ditto.
      (WebCore::Page::getHistoryLength): Ditto.
      (WebCore::Page::PageClients::PageClients): Made non-inline.
      (WebCore::Page::PageClients::~PageClients): Ditto.
      
      * page/Page.h: Made PageClients constructor and destructor non-inline.
      Added backForward function. Marked old functions as deprecated.
      
      * page/Settings.cpp:
      (WebCore::Settings::setUsesPageCache): Use backForward.
      * platform/ContextMenu.cpp:
      (WebCore::ContextMenu::populate): Ditto.
      (WebCore::ContextMenu::checkOrEnableIfNeeded): Ditto.
      * wml/WMLDoElement.cpp:
      (WebCore::WMLDoElement::defaultEventHandler): Ditto.
      * wml/WMLDocument.cpp:
      (WebCore::WMLDocument::finishedParsing): Ditto.
      * wml/WMLPageState.cpp:
      (WebCore::WMLPageState::reset): Ditto.
      (WebCore::tryAccessHistoryURLs): Ditto.
      * wml/WMLPrevElement.cpp:
      (WebCore::WMLPrevElement::executeTask): Ditto.
      
      WebKit2: 
      
      * WebKit2.pro: Removed WebBackForwardControllerClient.cpp and .h.
      * WebKit2.xcodeproj/project.pbxproj: Ditto.
      
      * WebProcess/WebCoreSupport/WebBackForwardControllerClient.cpp: Removed.
      * WebProcess/WebCoreSupport/WebBackForwardControllerClient.h: Removed.
      
      * WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:
      (WebKit::InjectedBundleBackForwardList::itemAtIndex): Use backForward.
      (WebKit::InjectedBundleBackForwardList::backListCount): Ditto.
      (WebKit::InjectedBundleBackForwardList::forwardListCount): Ditto.
      (WebKit::InjectedBundleBackForwardList::clear): Ditto.
      
      * WebProcess/WebPage/WebBackForwardListProxy.h: Added newly-needed include.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage): Set up backForwardClient.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e10e1282
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=48663 · 074b7584
      hyatt@apple.com authored
      Reviewed by Sam Weinig.
      
      Make repaint invalidation work with vertical lines.  Rewrite linesBoundingBox for RenderText and
      RenderInline to give the correct rectangle back for vertical lines.  Also patch linesVisibleOverflowBoundingBox
      to give back the correct rectangle for vertical lines.
              
      Fix bugs in the overflow accessors of InlineFlowBox when m_overflow was 0.
      
      Added fast/repaint/inline-vertical-lr-overflow.html
      
      WebCore: 
      
      * rendering/InlineBox.cpp:
      (WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
      * rendering/InlineFlowBox.h:
      (WebCore::InlineFlowBox::logicalLeftVisibleOverflow):
      (WebCore::InlineFlowBox::logicalRightVisibleOverflow):
      (WebCore::InlineFlowBox::bottomLayoutOverflow):
      (WebCore::InlineFlowBox::rightLayoutOverflow):
      (WebCore::InlineFlowBox::bottomVisualOverflow):
      (WebCore::InlineFlowBox::rightVisualOverflow):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::adjustForFlippedBlocksWritingMode):
      * rendering/RenderBox.h:
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::linesBoundingBox):
      (WebCore::RenderInline::linesVisibleOverflowBoundingBox):
      (WebCore::RenderInline::clippedOverflowRectForRepaint):
      * rendering/RenderText.cpp:
      (WebCore::RenderText::linesBoundingBox):
      
      LayoutTests: 
      
      * fast/repaint/inline-vertical-rl-overflow.html: Added.
      * platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
      * platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
      * platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
      * platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
      * platform/mac/fast/blockflow/border-vertical-lr-expected.png:
      * platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
      * platform/mac/fast/blockflow/english-lr-text-expected.txt:
      * platform/mac/fast/blockflow/english-rl-text-expected.txt:
      * platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
      * platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
      * platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Added.
      * platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Added.
      * platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
      * platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      074b7584
    • jamesr@google.com's avatar
      2010-10-29 James Robinson <jamesr@chromium.org> · 4c8cd526
      jamesr@google.com authored
              Update pixel expectations for Snow Leopard for tests in tables/mozilla/marvin.
      
              Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
              expectations for tests that need them.  List of files omitted due to length.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c8cd526
    • commit-queue@webkit.org's avatar
      2010-10-29 Mike Lawther <mikelawther@chromium.org> · 60bdea8c
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              Fix canvas/philip/tests/2d.imageData.get.source.negative
              https://bugs.webkit.org/show_bug.cgi?id=48277
      
              Remove canvas/philip/tests/2d.imageData.get.source.negative from chromium skipped.
              Also remove spurious trailing newlines from 2d.imageData.get.source.negative-expected.txt
      
              * canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
              * platform/chromium/test_expectations.txt:
      2010-10-29  Mike Lawther  <mikelawther@chromium.org>
      
              Reviewed by James Robinson.
      
              Fix canvas/philip/tests/2d.imageData.get.source.negative
              https://bugs.webkit.org/show_bug.cgi?id=48277
      
              Handle negative width/height.
              See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#pixel-manipulation
      
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::getImageData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60bdea8c
    • commit-queue@webkit.org's avatar
      2010-10-29 Kavita Kanetkar <kkanetkar@chromium.org> · 39b6c6d1
      commit-queue@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: FileSystem integration
              https://bugs.webkit.org/show_bug.cgi?id=45982
      
              Adding filesystem support for Inspector under storage tab. This fetches root paths for
              temporary and persistent filesystems and allows "reveal folder in OS" option that
              launches native file browser. Currently this feature is disabled for non-chromium platforms.
      
              * CMakeLists.txt:
              * English.lproj/localizedStrings.js:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::releaseFrontendLifetimeAgents):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::fileSystemAgent):
              * inspector/InspectorFileSystemAgent.cpp: Added.
              * inspector/InspectorFileSystemAgent.h: Added.
              * inspector/front-end/FileSystemView.js: Added.
              * inspector/front-end/Settings.js:
              * inspector/front-end/StoragePanel.js:
              (WebInspector.StoragePanel):
              (WebInspector.StoragePanel.prototype.reset):
              (WebInspector.StoragePanel.prototype.addFileSystem):
              (WebInspector.StoragePanel.prototype.showFileSystem):
              (WebInspector.StoragePanel.prototype.updateFileSystemPath):
              (WebInspector.StoragePanel.prototype.updateFileSystemError):
              (WebInspector.FileSystemTreeElement):
              (WebInspector.FileSystemTreeElement.prototype.onselect):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.css:
              (.file-system-storage-tree-item .icon):
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector.updateResource):
              (WebInspector._addFileSystemOrigin):
              (WebInspector.didGetFileSystemPath):
              (WebInspector.didGetFileSystemError):
              (WebInspector.reset):
              * platform/AsyncFileSystem.h:
              (WebCore::AsyncFileSystem::root):
              * platform/FileSystem.h:
              * platform/chromium/ChromiumBridge.h:
              * platform/chromium/FileSystemChromium.cpp:
              (WebCore::revealFolderInOS):
      2010-10-29  Kavita Kanetkar  <kkanetkar@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: FileSystem integration
              https://bugs.webkit.org/show_bug.cgi?id=45982
      
              * public/WebFileUtilities.h:
              (WebKit::WebFileUtilities::revealFolderInOS):
              * src/ChromiumBridge.cpp:
              (WebCore::ChromiumBridge::revealFolderInOS):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39b6c6d1
    • mrobinson@webkit.org's avatar
      2010-10-29 Martin Robinson <mrobinson@igalia.com> · dcfa8d3a
      mrobinson@webkit.org authored
              Build fix for GTK+ after BackForwardListImpl introduction.
      
              * webkit/webkitwebbackforwardlist.cpp:
              (webkit_web_back_forward_list_new_with_web_view):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcfa8d3a
    • aroben@apple.com's avatar
      Stop using encode/decodeBytes for WebEvent subclasses · 16a57f30
      aroben@apple.com authored
      The use of encode/decodeBytes was making these classes sensitive to
      differences in padding on different architectures (e.g., 32-bit vs.
      64-bit). By encoding each data member explicitly we remove this
      sensitivity, allowing these classes to be passed between processes
      with different padding.
      
      Fixes <http://webkit.org/b/48552> <rdar://problem/8606571> Mouse
      events never reach Flash in WebKit2 on Mac (asserts in Debug builds)
      
      Reviewed by Anders Carlsson.
      
      * Platform/CoreIPC/Arguments.h:
      (CoreIPC::Arguments8::Arguments8):
      (CoreIPC::Arguments8::encode):
      (CoreIPC::Arguments8::decode):
      (CoreIPC::In):
      (CoreIPC::Out):
      Added Arguments8, the biggest Arguments yet.
      
      * Shared/WebEvent.cpp:
      (WebKit::WebEvent::encode):
      (WebKit::WebEvent::decode):
      * Shared/WebKeyboardEvent.cpp:
      (WebKit::WebKeyboardEvent::encode):
      (WebKit::WebKeyboardEvent::decode):
      * Shared/WebMouseEvent.cpp:
      (WebKit::WebMouseEvent::encode):
      (WebKit::WebMouseEvent::decode):
      * Shared/WebPlatformTouchPoint.cpp:
      (WebKit::WebPlatformTouchPoint::encode):
      (WebKit::WebPlatformTouchPoint::decode):
      * Shared/WebTouchEvent.cpp:
      (WebKit::WebTouchEvent::encode):
      (WebKit::WebTouchEvent::decode):
      * Shared/WebWheelEvent.cpp:
      (WebKit::WebWheelEvent::encode):
      (WebKit::WebWheelEvent::decode):
      Changed all encode/decode function to use CoreIPC::In/Out to
      encode/decode data members individually.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16a57f30
    • aroben@apple.com's avatar
      Use only CoreIPC-sanctioned types in WebEvent subclasses · 5e7111c6
      aroben@apple.com authored
      Fixes <http://webkit.org//48694> WebEvent subclasses should not use
      architecture-dependent types
      
      Reviewed by Anders Carlsson.
      
      * Shared/WebEvent.h:
      (WebKit::WebEvent::type):
      (WebKit::WebMouseEvent::button):
      (WebKit::WebMouseEvent::clickCount):
      (WebKit::WebWheelEvent::granularity):
      (WebKit::WebPlatformTouchPoint::id):
      (WebKit::WebPlatformTouchPoint::state):
      Replaced enums, ints, and unsigneds with uint32_ts, int32_ts, and
      uint32_ts, respectively.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e7111c6
    • andreas.kling@nokia.com's avatar
      2010-10-29 Aaron Colwell <acolwell@chromium.org> · 6d0d3ffb
      andreas.kling@nokia.com authored
              Reviewed by David Levin.
      
              Disable media/video-canvas-alpha.html for Qt & GTK
              https://bugs.webkit.org/show_bug.cgi?id=48688
      
              * platform/gtk/Skipped:
              * platform/qt/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d0d3ffb
    • andersca@apple.com's avatar
      Generate a DelayedReply struct for sync messages marked delayed · 88152edc
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48696
      
      Reviewed by Adam Roben.
      
      * Scripts/webkit2/messages.py:
      If we encounter a sync message marked delayed, generate a DelayedReply struct with a send member funciton
      that can be used for sending the reply.
      
      * Scripts/webkit2/messages_unittest.py:
      Update expected results.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88152edc
    • jamesr@google.com's avatar
      2010-10-29 James Robinson <jamesr@chromium.org> · 0c53b80c
      jamesr@google.com authored
              Update Snow Leopard pixel baselines for tests in tables/mozilla pt 1
      
              This updates the pixel baselines in platform/mac to be valid for Snow Leopard for tests
              in tables/mozilla/collapsing_borders, /core, /dom, and /other.  Old baselines moved to
              platform/mac-leopard.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c53b80c
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed, test expectations update. · 73e6a269
      dimich@chromium.org authored
      * platform/chromium-win/editing/deleting/5390681-2-expected.checksum:
      * platform/chromium-win/editing/deleting/5390681-2-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73e6a269
    • andreas.kling@nokia.com's avatar
      2010-10-29 Andreas Kling <kling@webkit.org> · 8dad25f5
      andreas.kling@nokia.com authored
              Reviewed by Ariya Hidayat.
      
              [Qt] QWebPage's InputMethod event handling calls ShortcutOverride handler too
              https://bugs.webkit.org/show_bug.cgi?id=48692
      
              * Api/qwebpage.cpp:
              (QWebPage::event): Add missing break statement.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dad25f5
    • andreas.kling@nokia.com's avatar
      2010-10-29 Andreas Kling <kling@webkit.org> · e768bee0
      andreas.kling@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11)
              https://bugs.webkit.org/show_bug.cgi?id=48695
      
              * QtTestBrowser/launcherwindow.cpp:
              (LauncherWindow::createChrome):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e768bee0
    • andreas.kling@nokia.com's avatar
      2010-10-29 Andreas Kling <kling@webkit.org> · 01cb7f7c
      andreas.kling@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] QtTestBrowser: Fix uninitialized read in FpsTimer
              https://bugs.webkit.org/show_bug.cgi?id=48675
      
              FpsTimer::m_timer was never initialized and passed to QObject::killTimer()
              on startup with in -graphicsbased mode.
      
              * QtTestBrowser/fpstimer.cpp:
              (FpsTimer::FpsTimer):
              (FpsTimer::numFrames):
              (FpsTimer::stop):
              (FpsTimer::timerEvent):
              * QtTestBrowser/fpstimer.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01cb7f7c
    • rniwa@webkit.org's avatar
      2010-10-29 Ryosuke Niwa <rniwa@webkit.org> · 2bb4a5a5
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove RenderTextControl::setSelectionRange
              https://bugs.webkit.org/show_bug.cgi?id=47870
      
              Converted RenderTextControll::setSelectionRange to a global function.
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::inputMethodEvent): Calls setSelectionRange.
      2010-10-29  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              Remove RenderTextControl::setSelectionRange
              https://bugs.webkit.org/show_bug.cgi?id=47870
      
              Made RenderTextControl::setSelectionRange a global function.
              Removed setSelectionStart, setSelectionEnd, and select from RenderTextControl.
      
              No new tests are added since there is no behavioral change.
      
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::setSelectedTextRange): Calls setSelectedTextRange.
              * dom/InputElement.cpp:
              (WebCore::InputElement::updateSelectionRange): Ditto.
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLTextFormControlElement::setSelectionStart): Ditto.
              (WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto.
              (WebCore::HTMLTextFormControlElement::select): Ditto.
              (WebCore::HTMLTextFormControlElement::setSelectionRange): Ditto.
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::hasVisibleTextArea): Added.
              (WebCore::setSelectionRange): See above.
              * rendering/RenderTextControl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bb4a5a5
    • jamesr@google.com's avatar
      2010-10-29 James Robinson <jamesr@chromium.org> · 90bc5e8e
      jamesr@google.com authored
              Update pixel expectations for Snow Leopard for tests in tables/mozilla_expected_failures.
      
              Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
              expectations for 96 tests that need them.  List of files omitted due to length.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90bc5e8e
    • dpranke@chromium.org's avatar
      2010-10-29 Dirk Pranke <dpranke@chromium.org> · ca2190dd
      dpranke@chromium.org authored
              Reviewed by Tony Chang.
      
              new-run-webkit-tests: change TestResults to be serializable
      
              In preparation for changing new-run-webkit-tests from
              multithreaded to multiprocess, we need to make sure the data
              going between the threads is easily serialized over a socket.
      
              This change adds serialization/pickling for the TestResults and
              TestFailure objects (using cPickle).
      
              The TestFailure objects included a "has_wdiff" flag for Text
              results, but the flag wasn't being used, so I've removed it,
              simplifying the state to basically a set of enum objects with
              associated methods.
      
              https://bugs.webkit.org/show_bug.cgi?id=48616
      
              * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
              * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added.
              * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added.
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca2190dd
    • dpranke@chromium.org's avatar
      2010-10-29 Dirk Pranke <dpranke@chromium.org> · 9ee4a1a9
      dpranke@chromium.org authored
              Reviewed by Ojan Vafai.
      
              new-run-webkit-tests: need to provide separate dashboard results for GPU tests
              https://bugs.webkit.org/show_bug.cgi?id=48687
      
              Modify the steps to upload the JSON files to the dashboards so
              that the GPU tests don't conflict with the regular tests on a
              port. We do this by modifying the --builder-name parameter to
              append " - GPU", which should cause the app to treat the results
              as a completely new builder. This is a little non-obvious, but
              keeps us from having to restructure the app.
      
              * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
              * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ee4a1a9
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed test expectations update. · d99b1a5c
      dimich@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d99b1a5c
    • eric.carlson@apple.com's avatar
      2010-10-29 Eric Carlson <eric.carlson@apple.com> · 279c46fb
      eric.carlson@apple.com authored
              Reviewed by Adam Roben.
      
              Results for media test controls-drag-timebar.html are needlessly platform specific
              https://bugs.webkit.org/show_bug.cgi?id=48662
      
              * media/controls-drag-timebar-expected.txt:
              * media/controls-drag-timebar.html: Remove some of the logging to avoid timing differences
              on slower machines.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      279c46fb