GitLab

        Reviewed by Darin Adler.

        Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a
        local variable in the Interpreter.
        https://bugs.webkit.org/show_bug.cgi?id=39447

        Small speedup on SunSpider in Interpreter mode.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        * jsc.cpp:
        * wtf/Platform.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Nate Chapin.

        [chromium] Provide a way to catch exceptions thrown while interacting
        with a NPObject via WebBindings methods.
        https://bugs.webkit.org/show_bug.cgi?id=39378

        This change also includes a small bit of cleanup in V8NPObject and
        friends.  I moved code into the WebCore namespace where appropriate.
        
        In _NPN_Invoke, I also moved the call to _NPN_Evaluate outside of the
        context scope.  I did this to avoid having nested ExceptionCatcher
        objects, which is not strictly necessary, but it seemed cleaner.
        _NPN_Evaluate already takes care of creating a context scope.

        * bindings/v8/NPV8Object.cpp:
        (WebCore::v8ObjectToNPObject):
        (WebCore::npCreateV8ScriptObject):
        (_NPN_Invoke):
        (_NPN_InvokeDefault):
        (_NPN_Evaluate):
        (_NPN_EvaluateHelper):
        (_NPN_GetProperty):
        (_NPN_SetProperty):
        (_NPN_RemoveProperty):
        (_NPN_HasProperty):
        (_NPN_HasMethod):
        (_NPN_SetException):
        (_NPN_Enumerate):
        (_NPN_Construct):
        * bindings/v8/NPV8Object.h:
        * bindings/v8/V8NPObject.cpp:
        * bindings/v8/V8NPObject.h:
        * bindings/v8/V8NPUtils.cpp:
        (WebCore::convertV8ObjectToNPVariant):
        (WebCore::pushExceptionHandler):
        (WebCore::popExceptionHandler):
        (WebCore::ExceptionCatcher::ExceptionCatcher):
        (WebCore::ExceptionCatcher::~ExceptionCatcher):
        * bindings/v8/V8NPUtils.h:
        * bindings/v8/npruntime.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        editingBehavior settings needs to be set back to a reasonable default between tests
        https://bugs.webkit.org/show_bug.cgi?id=39433

        For now, hard code the default setting during reset, so that the serialized
        version of the setting stays in sync with expectations.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues): Reset editing behavior to the appropriate platform default.
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Oliver Hunt.

Presently the JIT and the interpreter have differing implementations in how
they handle storing the result of a function call back to the register file.
In both cases the op_call ( / _eval / _varargs / op_construct) opcode has an
operand indicating the VM register in which the result should be stored.
The JIT plants code after the call to store the result, so the value will be
stored as soon as the callee has returned.  In the interpreter the call
passes the return value register id into the callee via the callee callframe,
and the callee is responsible for writing the result back into its callers
register file after it has restored the parents callframe pointer, but before
returning.

Instead, move the task of writing the call result to the register file into a
new opcode (op_call_put_result), and after returning the callee should leave
the return value in a canonical location.  In the case of the interpreter,
this canonical location is a local variable in privateExecute
(functionReturnValue), in the case of the JIT this is the normal return value
registers (regT0, or regT1:regT0 in JSVALUE32_64).  op_call_put_result stores
the result from the canonical location to the registerfile.

In addition to unifying JIT & interpreter behaviour this change allows us to
remove a slot from the callframe, omit the write of the result where the
return value from the call is not used, and provides a 2% speedup on sunspider
in the interpreter.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::finalDestinationOrIgnored):
* bytecompiler/NodesCodegen.cpp:
(JSC::NewExprNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
* interpreter/CallFrame.h:
(JSC::ExecState::init):
(JSC::ExecState::noCaller):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallSetupArgs):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::emit_op_call_put_result):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::compileOpCallVarargsSetupArgs):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Steve Block.

        Ensure timers are stopped on Geolocation::disconnectFrame()
        https://bugs.webkit.org/show_bug.cgi?id=39388

        fast/dom/Geolocation/notimer-after-unload.html, plus it should be possible to re-enable Gtk LayoutTests.

        * page/Geolocation.cpp:
        (WebCore::Geolocation::disconnectFrame):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

The WebKitAPITest targets do not use the "_debug" suffix needed
by the WinCairo port.  Added Debug_Cairo target to correct this.

* WebKitAPITest/WebKitAPITest.vcproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed.

        editingBehavior settings needs to be set back to a reasonable default between tests
        https://bugs.webkit.org/show_bug.cgi?id=39433

        I forgot to revert the expected results for this test after reverting it.

        * editing/selection/extend-selection-after-double-click-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Ensures styles are up-to-date before determining selection
        https://bugs.webkit.org/show_bug.cgi?id=39389

        This adds a call to document::updateStyleIfNeeded() to
        Frame::notifyRendererOfSelectionChange(). Without this call, if there
        is a pending style update that will detach part of the DOM and the
        the selection is within that part of the DOM when
        notifyRendererOfSeletionChange is called, the rootEditableElement
        algorithm ends up walking through detached parts of the render tree.

        Test: editing/selection/focus-and-display-none.html

        * page/Frame.cpp:
        (WebCore::Frame::notifyRendererOfSelectionChange):
2010-05-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Eric Seidel.

        Tests putting focus into a textarea and setting display:none
        https://bugs.webkit.org/show_bug.cgi?id=39389

        * editing/selection/focus-and-display-none-expected.txt: Added.
        * editing/selection/focus-and-display-none.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=39329

Reviewed by Adam Roben.

Cairo does not properly deal with Windows HDCs that have been
scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and
ViewportExt setting.
(see http://bugs.freedesktop.org/show_bug.cgi?id=28161)

Instead, reset the HDC's WorldTransform to be unscaled, then
scale the cairo context to the desired scaling, and perform
the drawing operation.

* WebFrame.cpp:
(WebFrame::drawHeader): Use pre-positioned context to simplify 
  this method.
(WebFrame::drawFooter): Use pre-positioned context to simplify
  this method.
(WebFrame::spoolPage): Revise scaling logic to turn off HDC
  scaling, and scale using only Cairo.  Revert scaling at end
  so that user-defined GDI-based routines (e.g., header/footer)
  will draw in the right position.
(WebFrame::spoolPages): Identify print preview case, and
  retrieve scaling factors from preview context.  Set the
  Cairo context to use these factors during the spoolPage
  operation.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove code that fetched, but did nothing useful with, a CFDictionary in MediaPlayerPrivateQuickTimeVisualContext

I also removed the code in QTPixelBuffer that vended the dictionary.

Fixes <http://webkit.org/b/39435> <rdar://problem/8009278>
QTPixelBuffer passes CFDictionaries across the DLL boundary, which can
lead to crashes

Reviewed by Darin Adler.

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
Deleted code that fetched the attachments dictionary, which was never
used other than to pass it to CFRetain/CFRelease, which could be
enough to cause a crash due to incompatible copies of
CoreFoundation.dll.

* platform/graphics/win/QTMovieVisualContext.h: Added a now-needed
forward declaration.

* platform/graphics/win/QTPixelBuffer.cpp:
* platform/graphics/win/QTPixelBuffer.h:
Removed the now-unused attachments function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fixes <http://webkit.org/b/39432> <rdar://problem/8008992>

Reviewed by Ada Chan

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::QTCFDictionaryCreateWithDataCallback): Use a RetainPtr to
hold the CFData we allocate so it will get released when this function
is exited. Also pass kCFAllocatorNull as the bytes deallocator to
CFDataCreateWithBytesNoCopy so that CF doesn't try to deallocate the
bytes we pass to it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Ojan Vafai.

        editingBehavior settings needs to be set back to a reasonable default between tests
        https://bugs.webkit.org/show_bug.cgi?id=39433

        Revert the changes from r59840 to this test until there is a method
        in the WebKit APIs to consistently reset the editingBehavior setting
        to a reasonable default.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=39437

Reviewed by David Levin.

* dom/CrossThreadTask.h:
(WebCore::):
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask1::CrossThreadTask1):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask2::CrossThreadTask2):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask3::CrossThreadTask3):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask4::CrossThreadTask4):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask5::CrossThreadTask5):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask6::CrossThreadTask6):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask7::CrossThreadTask7):
(WebCore::CrossThreadTask8::create):
(WebCore::CrossThreadTask8::CrossThreadTask8):
(WebCore::createCallbackTask):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed. Update test expectations from chromium.

        * platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=39135

Reviewed by David Levin.

WebCore:

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/CrossThreadTask.h: Renamed from WebCore/workers/GenericWorkerTask.h.
* html/FileStreamProxy.cpp:
* loader/WorkerThreadableLoader.cpp:
* websockets/WorkerThreadableWebSocketChannel.cpp:
* workers/DefaultSharedWorkerRepository.cpp:
* workers/WorkerMessagingProxy.cpp:
* workers/WorkerScriptLoader.cpp:

WebKit/chromium:

* src/WebSharedWorkerImpl.cpp:
* src/WebWorkerBase.cpp:
* src/WebWorkerClientImpl.cpp:
* src/WebWorkerImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Mark Rowe.

* css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Jeremy Orlow.

        Provide bindings for DeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=39210

        Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.

        * Configurations/FeatureDefines.xcconfig:
2010-05-20  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Provide bindings for DeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=39210

        Adds ENABLE_DEVICE_ORIENTATION to VisualStudio project files, always disabled.

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:
2010-05-20  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Provide bindings for DeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=39210

        Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.

        * Configurations/FeatureDefines.xcconfig:
2010-05-20  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Provide bindings for DeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=39210

        Tests: fast/dom/DeviceOrientation/window-property.html
               fast/dom/Window/window-properties-on-device-orientation.html

        Adds bindings for DeviceOrientation as defined in
        http://dev.w3.org/geo/api/spec-source-orientation.html
        This is guarded by ENABLE(DEVICE_ORIENTATION) which is currently disabled on
        all platforms but Android.

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * Android.mk:
        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/v8/custom/V8EventCustom.cpp:
        (WebCore::toV8):
        * dom/DeviceOrientationEvent.cpp: Added.
        (WebCore::DeviceOrientationEvent::DeviceOrientationEvent):
        (WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
        * dom/DeviceOrientationEvent.h: Added.
        (WebCore::DeviceOrientationEvent::create):
        (WebCore::DeviceOrientationEvent::alpha):
        (WebCore::DeviceOrientationEvent::beta):
        (WebCore::DeviceOrientationEvent::gamma):
        (WebCore::DeviceOrientationEvent::isDeviceOrientationEvent):
        * dom/DeviceOrientationEvent.idl: Added.
        * dom/Event.cpp:
        (WebCore::Event::isDeviceOrientationEvent):
        * dom/Event.h:
        * dom/EventNames.h:
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
2010-05-20  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Provide bindings for DeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=39210

        Modifies existing fast/dom/Window tests to skip window.ondeviceorientation until
        it is widely supported.
        Adds new fast/dom/Window/window-properties-on-device-orientation.html to test
        type and presence of window.ondeviceorientation.
        Adds new fast/dom/DeviceOrientation directory and initial test.
        Adds all DeviceOrientation tests to all skipped lists.

        * fast/dom/DeviceOrientation: Added.
        * fast/dom/DeviceOrientation/script-tests: Added.
        * fast/dom/DeviceOrientation/script-tests/TEMPLATE.html: Added.
        * fast/dom/DeviceOrientation/script-tests/window-property.js: Added.
        (hasOnDeviceOrientationProperty):
        * fast/dom/DeviceOrientation/window-property-expected.txt: Added.
        * fast/dom/DeviceOrientation/window-property.html: Added.
        * fast/dom/Window/script-tests/window-property-descriptors.js:
        * fast/dom/Window/window-properties-on-device-orientation-expected.txt: Added.
        * fast/dom/Window/window-properties-on-device-orientation.html: Added.
        * fast/dom/Window/window-properties.html:
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

consistent with the Mac OS X platform.

Rubberstamped by Antti Koivisto.

* page/qt/EventHandlerQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed.

        Touch WebKit.idl to ensure that interfaces rebuild.

        * Interfaces/WebKit.idl: Touched.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Ojan Vafai.

        editing/selection/extend-selection-after-double-click.html crashes on the Leopard Intel release bot
        https://bugs.webkit.org/show_bug.cgi?id=39431

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setEditingBehavior):
        Prevent a double-free by not having this variable be in the auto-release pool.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Roben.

        Fix the Windows build and move new IDL declarations to the bottom of the file.

        * Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch.
        * WebPreferences.cpp:
        (WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed.

        Fix the Windows build.

        * WebView.cpp:
        (WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Ojan Vafai.

        Expose the editing behavior setting in DRT to test all editing code paths
        https://bugs.webkit.org/show_bug.cgi?id=38603

        * editing/selection/extend-selection-after-double-click.html: Use the new DRT support for changing editing behavior.
        * editing/selection/extend-selection-after-double-click-expected.txt: Update expected results to reflect both behaviors.
2010-05-20  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Ojan Vafai.

        Expose the editing behavior setting in DRT to test all editing code paths
        https://bugs.webkit.org/show_bug.cgi?id=38603

        * public/WebSettings.h:
        (WebKit::WebSettings::): Added an enum for EditingBehavior types.
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setEditingBehavior): Added.
        * src/WebSettingsImpl.h:
2010-05-20  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Ojan Vafai.
...

        Reviewed by Eric Seidel.

        [DRT/Chromium] Increase the time out value
        https://bugs.webkit.org/show_bug.cgi?id=39203

        Change the time out value of Chromium DRT to 30 seconds, which is
        the same as other ports.
        If a DRT process exits before new-run-webkit-tests detects time
        out, new-run-webkit-tests assumes the DRT process crashed.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::layoutTestTimeout):
          Change the time out value from 10 seconds to 30 seconds.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] WINSCW compile fix for qwebframe test
        https://bugs.webkit.org/show_bug.cgi?id=38722

        WINSCW cannot determine template type up the hierarchy
        to common base class.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Simon Hausmann.

When we apply the transform of the parent painter to the painter of
the transparency layer, we adopt its coordinate system, thus offset
should not be in page coordinates, but in the coordinate system of
the parent painter.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::TransparencyLayer::TransparencyLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Kenneth Rohde Christiansen.

        Remove unused "old style" private APIs

        These symbols were introduced after QtWebKit v4.6
        so no-one should be using them

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Levin.

        [chromium] Avoid crash when msttcorefonts aren't provided

        https://bugs.webkit.org/show_bug.cgi?id=39015
        http://code.google.com/p/chromium/issues/detail?id=43831

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::createFontPlatformData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt/svg/filters/feLighting-crash-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Hausmann.

        [Qt] QWebPage::inputMethodQuery() returns wrong values for Qt::ImCursorPosition, Qt::ImAnchorPosition
        https://bugs.webkit.org/show_bug.cgi?id=38779

        The earlier implementation was written with the assumption that in this scenario the
        anchor position always corresponds to the START index and that the current cursor position
        always corresponds to the END index in WebKit.

        Updated the implementation of QWebPage::inputMethodQuery(Qt::ImCursorPosition) and
        QWebPage::inputMethodQuery(Qt::ImAnchorPosition) for the case where the Editor is not in
        composition mode. In the non-composition mode, the Anchor and the Current cursor positions
        correspond to the Base and Extent position offsets in WebKit.

        Also added the auto-tests for the RIGHT to LEFT and LEFT to RIGHT selections.

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery): Now returning correct values for Qt::ImCursorPosition and
        Qt::ImAnchorPosition when the Editor is not in composition mode.
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods): Added auto-tests for RIGHT to LEFT and LEFT to RIGHT selections

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=39004

Reviewed by Dirk Schulze.

Make FELighting::apply() similar to other filters' applies
to avoid an assertion fail in putUnmultipliedImageData(),
when effectDrawingRect has negative location (x or y is less than 0).

Test: svg/filters/feLighting-crash.svg

* svg/graphics/filters/SVGFELighting.cpp:
(WebCore::FELighting::apply):

LayoutTests: In case of lighting SVG effects, a wider output rectangle
than the input image size should not cause crash.
https://bugs.webkit.org/show_bug.cgi?id=39004

Reviewed by Dirk Schulze.

* platform/mac/svg/filters/feLighting-crash-expected.checksum: Added.
* platform/mac/svg/filters/feLighting-crash-expected.png: Added.
* platform/mac/svg/filters/feLighting-crash-expected.txt: Added.
* platform/qt/svg/filters/feLighting-crash-expected.txt: Added.
* svg/filters/feLighting-crash.svg: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59832 268f45cc-cd09-0410-ab3c-d5...

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Skipping popup focus test for maemo
        https://bugs.webkit.org/show_bug.cgi?id=39314

        Skipping popup focus test for maemo in qwebframe auto test.

        The test method tst_QWebFrame::popupFocus() was testing popup focus AND input
        field focus. The input field focus has been removed from the method popupFocus()
        and a new test method named inputFieldFocus() has been added. Finally the test
        method popupFocus() has been skipped for maemo.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Marking myself as a committer.

* Scripts/webkitpy/common/config/committers.py: Add cevans@google.com.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Modified FrameLoader::urlSelected() to accept a KURL instead of a
        ResourceRequest.

        https://bugs.webkit.org/show_bug.cgi?id=39320

        Since ResourceRequest has non-explicit single-parameter constructors for
        String and KURL, urlSelected() previously accepted any of String, KURL,
        and ResourceRequest.  This revision changes urlSelected() to accept only
        a KURL to make the API tighter and easier to refactor.

        No new functionality, so no new tests.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::urlSelected):
          - Changed the public overload to accept a KURL instead of a ResourceRequest.
        * loader/FrameLoader.h:
          - Changed the public overload to accept a KURL instead of a ResourceRequest.
        * wml/WMLAElement.cpp:
        (WebCore::WMLAElement::defaultEventHandler):
          - Updated the call to urlSelected().
2010-05-20  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Eric Seidel.

        Modified FrameLoader::urlSelected() to accept a KURL instead of a
        ResourceRequest.

        https://bugs.webkit.org/show_bug.cgi?id=39320

        Since ResourceRequest has non-explicit single-parameter constructors for
        String and KURL, urlSelected() previously accepted any of String, KURL,
        and ResourceRequest.  This revision changes urlSelected() to accept only
        a KURL to make the API tighter and easier to refactor.

        * WebCoreSupport/WebContextMenuClient.cpp:
        (WebContextMenuClient::searchWithGoogle):
          - Updated the call to urlSelected().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Kent Tamura.

        2x execCommand ReadAV@NULL
        https://bugs.webkit.org/show_bug.cgi?id=35791

        This test passes if it doesn't crash.

        * editing/execCommand/35791-expected.txt: Added.
        * editing/execCommand/35791.html: Added.
2010-05-20  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        2x execCommand ReadAV@NULL
        https://bugs.webkit.org/show_bug.cgi?id=35791

        In applyBlockStyle(), a node which is referred from
        nextParagraphStart sometimes removed from the document and goes
        orphan, and that causes an assertion failed. This is because
        moveParagraphs() replaces the node with a new one with some new
        styles applied. So we re-compute nextParagraphStart in that case.

        Test: editing/execCommand/35791.html

        * dom/Position.h:
        (WebCore::Position::isOrphan):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        * editing/VisiblePosition.h:
        (WebCore::VisiblePosition::isOrphan):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=37273

Reviewed by Tor Arne Vestbo.

* QtTestBrowser/QtTestBrowser.pro: Build QtLauncher as bundle in package builds

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        PluginView contains JSC-specific code
        https://bugs.webkit.org/show_bug.cgi?id=38907

        Build fix only, no new tests.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::start):
        (WebCore::PluginView::stop):
        (WebCore::PluginView::performRequest):
        * plugins/PluginView.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        [GStreamer] enable gst support if USE_GSTREAMER macro is defined
        https://bugs.webkit.org/show_bug.cgi?id=39205

        Include gstreamer private player in the build when the
        USE_GSTREAMER macro is enabled.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::installedMediaEngines):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* Scripts/new-run-webkit-websocketserver:
 options is named parameter for factory.get().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59824 268f45cc-cd09-0410-ab3c-d52691b4dbfc