1. 05 Apr, 2010 7 commits
    • robert@webkit.org's avatar
      2010-04-05 Robert Hogan <robert@webkit.org> · 543a7f86
      robert@webkit.org authored
              Reviewed by Kenneth Rohde-Christiansen.
      
              [Qt] Fix infinite redirection loop in QNetworkReplyHandler
      
              Qt enters an infinite loop if a redirect response redirects to itself.
      
              Fixes http/tests/xmlhttprequest/connection-error-sync.html
      
              https://bugs.webkit.org/show_bug.cgi?id=37097
      
              * platform/network/qt/QNetworkReplyHandler.cpp:
              (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
      
      2010-04-05  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Kenneth Rohde-Christiansen.
      
              [Qt] Fix infinite redirection loop in QNetworkReplyHandler
      
              Unskip http/tests/xmlhttprequest/connection-error-sync.html
      
              https://bugs.webkit.org/show_bug.cgi?id=37097
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      543a7f86
    • kenneth@webkit.org's avatar
      Unreviewed layout test fix. · 137e8939
      kenneth@webkit.org authored
      Update Qt results for iframe flattening.
      
      * platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
      * platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
      * platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
      * platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      137e8939
    • yurys@chromium.org's avatar
      2010-04-05 Yury Semikhatsky <yurys@chromium.org> · 9f68e8db
      yurys@chromium.org authored
              Unreviewed, revert r57078.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f68e8db
    • dglazkov@chromium.org's avatar
      2010-04-05 Dimitri Glazkov <dglazkov@chromium.org> · d3762f6e
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Style update done due to mutation event dispatching in textarea can be
              used to corrupt the render tree.
              https://bugs.webkit.org/show_bug.cgi?id=36864
      
              Modified listbox-selection.html to correctly set the size during
              creation. Otherwise, options added to it as a menuList, resulting
              in a default selection of the first item.
      
              Added a few more tests to ensure we capture correct behavior for
              select elements and their default selection, as well as the influence
              of when layout occurs.
      
              * fast/forms/listbox-selection.html:
              * fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
              * fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
              * fast/forms/textarea-and-mutation-events.html: Added.
      2010-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Style update done due to mutation event dispatching in textarea can be
              used to corrupt the render tree.
              https://bugs.webkit.org/show_bug.cgi?id=36864
      
              Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html
                     fast/forms/select-change-popup-to-listbox-roundtrip.html
                     fast/forms/textarea-and-mutation-events.html
      
              * dom/Node.cpp:
              (WebCore::Node::dispatchGenericEvent): Removed invocation of
                  Document::updateStyleForAllDocuments
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit
                  recalc to ensure accuracy of representation, especially for
                  menuList/listBox switches.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3762f6e
    • yurys@chromium.org's avatar
      2010-04-05 Yury Semikhatsky <yurys@chromium.org> · 4a016ace
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Refactored error reporting mechanizm on Worker Global Objects.
              Unlike other event listeners which accept single argument(Event)
              onerror handler on worker global object should be a function
              accepting three arguments. This error reporting was implementedas
              EventListener::reportError method which had custom implementations
              for v8 and JSC. This patch removes EventListener::reportError and
              moves its functionality into custom bindings(V8WorkerContextErrorHandler
              and JSWorkerContextErrorHandler) that implement EventListener inerface
              for the onerror handler.
      
              This patch also makes uncaught exceptions that happen in the onerror
              listener be reported to the Worker's onerror handler.
      
              https://bugs.webkit.org/show_bug.cgi?id=36375
      
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSEventListener.cpp:
              * bindings/js/JSEventListener.h:
              * bindings/js/JSWorkerContextErrorHandler.cpp: Added.
              (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler):
              (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler):
              (WebCore::JSWorkerContextErrorHandler::handleEvent):
              * bindings/js/JSWorkerContextErrorHandler.h: Added.
              (WebCore::JSWorkerContextErrorHandler::create):
              (WebCore::createJSWorkerContextErrorHandler):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/V8WorkerContextErrorHandler.cpp: Added.
              (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler):
              (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
              * bindings/v8/V8WorkerContextErrorHandler.h: Added.
              (WebCore::V8WorkerContextErrorHandler::create):
              * bindings/v8/V8WorkerContextEventListener.cpp:
              * bindings/v8/V8WorkerContextEventListener.h:
              * dom/EventListener.h: Removed reportError method that was used only for reporting worker errors.
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::WorkerContext):
              (WebCore::WorkerContext::reportException):
      
      2010-04-05  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Test that exception which occurs in onerror handler is reported to the Worker object.
      
              https://bugs.webkit.org/show_bug.cgi?id=36375
      
              * fast/workers/worker-script-error-expected.txt:
              * fast/workers/worker-script-error.html:
              * workers/WorkerContext.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a016ace
    • robert@webkit.org's avatar
      2010-04-05 Robert Hogan <robert@webkit.org> · 3b15b4a7
      robert@webkit.org authored
              Rubber-stamped by Kenneth-Rohde Christiansen.
      
              re-login.html and re-login-async.html are now tracked in bugzilla.
      
              https://bugs.webkit.org/show_bug.cgi?id=37084
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b15b4a7
    • pfeldman@chromium.org's avatar
      2010-04-05 Pavel Feldman <pfeldman@chromium.org> · b343bdc1
      pfeldman@chromium.org authored
              Not reviewed: chromium test expectations update for the roll.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b343bdc1
  2. 04 Apr, 2010 1 commit
  3. 03 Apr, 2010 6 commits
    • jwieczorek@webkit.org's avatar
      2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org> · 850eef27
      jwieczorek@webkit.org authored
              Unreviewed.
      
              [Qt] Skip five XMLHttpRequest tests that are timing out.
      
              * platform/qt/Skipped: Add a comment on why they are failing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      850eef27
    • jwieczorek@webkit.org's avatar
      2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org> · f492b8dc
      jwieczorek@webkit.org authored
              Rubber-stamped by Daniel Bates.
      
              Fix the fast/events/popup-allowed-from-gesture-initiated-event.html test
              failure on the Qt and GTK+ ports.
      
              Refactor it to not hardcode any metrics (in order to dispatch mouse events)
              but instead calculate them from the offset* properties.
      
              * fast/events/popup-allowed-from-gesture-initiated-event.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f492b8dc
    • eric@webkit.org's avatar
      2010-04-03 yael aharon <yael.aharon@nokia.com> · 40e6ef33
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Enable HTMLProgressElement for Safari on OSX
              https://bugs.webkit.org/show_bug.cgi?id=36961
      
              * Configurations/FeatureDefines.xcconfig:
      2010-04-03  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Darin Fisher.
      
              Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
              https://bugs.webkit.org/show_bug.cgi?id=36574
      
              Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
              points causing them to throw exceptions rather than synthesize GL
              errors. Fixed the implementations to synthesize INVALID_VALUE
              rather than INVALID_OPERATION to comply to the WebGL spec. Updated
              uniform-location-expected.txt to incorporate the correct error.
              Tested in Safari and Chromium.
      
              * fast/canvas/webgl/null-uniform-location-expected.txt: Added.
              * fast/canvas/webgl/null-uniform-location.html: Added.
              * fast/canvas/webgl/script-tests/null-uniform-location.js: Added.
              (callUniformFunction):
              * fast/canvas/webgl/uniform-location-expected.txt:
      2010-04-03  yael aharon  <yael.aharon@nokia.com>
      
              Reviewed by Darin Adler.
      
              Enable HTMLProgressElement for Safari on OSX
              https://bugs.webkit.org/show_bug.cgi?id=36961
      
              * Configurations/FeatureDefines.xcconfig:
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/RenderThemeMac.h:
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
              (WebCore::RenderThemeMac::animationDurationForProgressBar):
              (WebCore::RenderThemeMac::adjustProgressBarStyle):
              (WebCore::RenderThemeMac::paintProgressBar):
      2010-04-03  yael aharon  <yael.aharon@nokia.com>
      
              Reviewed by Darin Adler.
      
              Enable HTMLProgressElement for Safari on OSX
              https://bugs.webkit.org/show_bug.cgi?id=36961
      
              * Configurations/FeatureDefines.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40e6ef33
    • eric@webkit.org's avatar
      2010-04-03 Kenneth Russell <kbr@google.com> · a4aa05f3
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
              https://bugs.webkit.org/show_bug.cgi?id=36574
      
              Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
              points causing them to throw exceptions rather than synthesize GL
              errors. Fixed the implementations to synthesize INVALID_VALUE
              rather than INVALID_OPERATION to comply to the WebGL spec. Updated
              uniform-location-expected.txt to incorporate the correct error.
              Tested in Safari and Chromium.
      
              * fast/canvas/webgl/null-uniform-location-expected.txt: Added.
              * fast/canvas/webgl/null-uniform-location.html: Added.
              * fast/canvas/webgl/script-tests/null-uniform-location.js: Added.
              (callUniformFunction):
              * fast/canvas/webgl/uniform-location-expected.txt:
      2010-04-03  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Darin Fisher.
      
              Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
              https://bugs.webkit.org/show_bug.cgi?id=36574
      
              Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
              points causing them to throw exceptions rather than synthesize GL
              errors. Fixed the implementations to synthesize INVALID_VALUE
              rather than INVALID_OPERATION to comply to the WebGL spec. Updated
              uniform-location-expected.txt to incorporate the correct error.
              Tested in Safari and Chromium.
      
              Test: fast/canvas/webgl/null-uniform-location.html
      
              * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
              (WebCore::V8WebGLRenderingContext::getUniformCallback):
              (WebCore::vertexAttribAndUniformHelperf):
              (WebCore::uniformHelperi):
              (WebCore::uniformMatrixHelper):
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::uniform1f):
              (WebCore::WebGLRenderingContext::uniform1fv):
              (WebCore::WebGLRenderingContext::uniform1i):
              (WebCore::WebGLRenderingContext::uniform1iv):
              (WebCore::WebGLRenderingContext::uniform2f):
              (WebCore::WebGLRenderingContext::uniform2fv):
              (WebCore::WebGLRenderingContext::uniform2i):
              (WebCore::WebGLRenderingContext::uniform2iv):
              (WebCore::WebGLRenderingContext::uniform3f):
              (WebCore::WebGLRenderingContext::uniform3fv):
              (WebCore::WebGLRenderingContext::uniform3i):
              (WebCore::WebGLRenderingContext::uniform3iv):
              (WebCore::WebGLRenderingContext::uniform4f):
              (WebCore::WebGLRenderingContext::uniform4fv):
              (WebCore::WebGLRenderingContext::uniform4i):
              (WebCore::WebGLRenderingContext::uniform4iv):
              (WebCore::WebGLRenderingContext::uniformMatrix2fv):
              (WebCore::WebGLRenderingContext::uniformMatrix3fv):
              (WebCore::WebGLRenderingContext::uniformMatrix4fv):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4aa05f3
    • abarth@webkit.org's avatar
      2010-04-02 Andy Estes <aestes@apple.com> · b4fefb8a
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              Tests for https://bugs.webkit.org/show_bug.cgi?id=37008.
      
              * fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
              * fast/events/popup-allowed-from-gesture-initiated-event.html: Added.
              * fast/events/popup-blocked-from-fake-button-click-expected.txt: Added.
              * fast/events/popup-blocked-from-fake-button-click.html: Added.
              * fast/events/popup-blocked-from-fake-focus-expected.txt: Added.
              * fast/events/popup-blocked-from-fake-focus.html: Added.
      2010-04-02  Andy Estes  <aestes@apple.com>
      
              Reviewed by Adam Barth.
      
              The previous mechanism for testing whether an event was due to a user
              gesture only checked the event type, not the source of the event.  This
              allowed scripts to defeat popup blocking by programatically emitting
              certain types of events.
      
              Change the user gesture detection to check for a flag that is only set
              when the event in question was generated through the platform and not
              through the DOM.
      
              https://bugs.webkit.org/show_bug.cgi?id=37008
      
              Tests: fast/events/popup-allowed-from-gesture-initiated-event.html
                     fast/events/popup-blocked-from-fake-button-click.html
                     fast/events/popup-blocked-from-fake-focus.html
      
              * Android.mk: Add UserGestureIndicator.{cpp, h}.
              * GNUmakefile.am: Same.
              * WebCore.gypi: Same.
              * WebCore.pro: Same.
              * WebCore.vcproj/WebCore.vcproj: Same.
              * WebCore.xcodeproj/project.pbxproj: Same.
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::processingUserGesture): Check the value of
              UserGesureIndicator::processingUserGesture().
              * dom/Document.cpp:
              (WebCore::Document::createEvent): Remove call to
              Event::setCreatedByDOM().
              * dom/Event.cpp:
              (WebCore::Event::Event): Remove initializers for m_createdByDOM.
              (WebCore::Event::fromUserGesture): Check the value of
              UserGestureIndicator::processingUserGesture().
              * dom/Event.h: Remove m_createdByDOM.
              * dom/UserGestureIndicator.cpp: Added.
              (WebCore::UserGestureIndicator::UserGestureIndicator): Save the previous
              value of s_processingUserGesture before setting it to true.
              (WebCore::UserGestureIndicator::~UserGestureIndicator): Restore
              s_processingUserGesture to its previous value.
              * dom/UserGestureIndicator.h: Added.
              (WebCore::UserGestureIndicator::processingUserGesture): Return the value
              of s_processingUserGesture.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent): Instantiate a
              UserGestureIndicator object on the stack to indicate a user gesture is
              being processed.
              (WebCore::EventHandler::handleMouseDoubleClickEvent): Same.
              (WebCore::EventHandler::handleMouseReleaseEvent): Same.
              (WebCore::EventHandler::keyEvent): Same.
              (WebCore::EventHandler::handleTouchEvent): Same.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4fefb8a
    • abarth@webkit.org's avatar
      2010-04-02 Adam Barth <abarth@webkit.org> · b9401be9
      abarth@webkit.org authored
              Unreviewed.
      
              REGRESSION(56394): http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html fails on Tiger
              https://bugs.webkit.org/show_bug.cgi?id=36934
      
              Attempt Alexey's solution of using a non-sniffable MIME type.
      
              * http/tests/xmlhttprequest/resources/download-with-delay.php:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9401be9
  4. 02 Apr, 2010 19 commits
    • abarth@webkit.org's avatar
      2010-04-02 Adam Barth <abarth@webkit.org> · a19484cb
      abarth@webkit.org authored
              Unreviewed.  Disabled fast/workers/worker-terminate.html because it
              randomly fails about 25% of the time.
      
              https://bugs.webkit.org/show_bug.cgi?id=36646
      
              * platform/mac/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a19484cb
    • darin@chromium.org's avatar
      2010-04-02 Darin Fisher <darin@chromium.org> · f5cb4250
      darin@chromium.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=36647
              Make replacestate-in-frame.html less insane and hopefully no longer flaky.
      
              * fast/loader/stateobjects/replacestate-in-iframe-expected.txt:
              * fast/loader/stateobjects/replacestate-in-iframe.html:
              * fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html: Added.
              * fast/loader/stateobjects/resources/replacestate-in-iframe-window.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5cb4250
    • abarth@webkit.org's avatar
      2010-04-02 Justin Schuh <jschuh@chromium.org> · 7a8fde5a
      abarth@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              XHR allows arbitrary XSRF across domains
              https://bugs.webkit.org/show_bug.cgi?id=36843
      
              Added a one-line change to prevent bypassing the XDC check on
              synchronous preflighted requests. Added layout tests to cover
              variations of this problem.
      
              * http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html: Added.
              * http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html: Added.
              * http/tests/xmlhttprequest/access-control-preflight-sync-header-denied-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html: Added.
              * http/tests/xmlhttprequest/access-control-preflight-sync-method-denied-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html: Added.
              * http/tests/xmlhttprequest/resources/access-control-preflight-denied-xsrf.php: Added.
      2010-04-02  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              XHR allows arbitrary XSRF across domains
              https://bugs.webkit.org/show_bug.cgi?id=36843
      
              Added a one-line change to prevent bypassing the XDC check on
              synchronous preflighted requests. Added layout tests to cover
              variations of this problem.
      
              Tests: http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html
                     http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html
                     http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html
                     http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html
      
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::preflightFailure):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a8fde5a
    • scherkus@chromium.org's avatar
      2010-04-02 Andrew Scherkus <scherkus@chromium.org> · e479546e
      scherkus@chromium.org authored
              Reviewed by Eric Carlson and Eric Seidel.
      
              Don't stop the playback event timer when media resource loading has suspended.
              https://bugs.webkit.org/show_bug.cgi?id=37003
      
              When a user agent decides to suspend media resource loading and enters the
              NETWORK_IDLE state we are supposed to only stop the progress event timer but
              keep the playback timer running.
      
              Test: http/tests/media/video-play-suspend.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::setNetworkState): Only stop the progress event timer.
      
      2010-04-02  Andrew Scherkus  <scherkus@chromium.org>
      
              Reviewed by Eric Carlson and Eric Seidel.
      
              Don't stop the playback event timer when media resource loading has suspended.
              https://bugs.webkit.org/show_bug.cgi?id=37003
      
              When a user agent decides to suspend media resource loading and enters the
              NETWORK_IDLE state we are supposed to only stop the progress event timer but
              keep the playback timer running.
      
              Currently Chromium is the only platform that fires the suspend event
              hence most platforms skipping this test.
      
              * http/tests/media/video-play-suspend-expected.txt: Added.
              * http/tests/media/video-play-suspend.html: Added.
              * platform/gtk/Skipped: Doesn't fire a suspend event.
              * platform/mac/Skipped: Ditto.
              * platform/win/Skipped: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e479546e
    • levin@chromium.org's avatar
      (non-generated) code should only use CanvasRenderingContext::canvas as a CanvasSurface. · 61fc3bb1
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36906
      
      Reviewed by Darin Adler.
      
      WebCore:
      
      * dom/CanvasSurface.cpp: Added methods for items that depended on
      CanvasRenderingContext::canvas() being an HTMLElement(), so that this usage
      can be dealt with in one place.
      (WebCore::CanvasSurface::securityOrigin): Only used by methods that are
      only run in the document context.
      (WebCore::CanvasSurface::renderBox): Will likely return 0 in a worker context.
      (WebCore::CanvasSurface::computedStyle): Used by setFont. Return value is TBD for
      the worker context.
      (WebCore::CanvasSurface::styleSelector): Ditto.
      * dom/CanvasSurface.h:
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::getContext): Passing in information into
      the CanvasRenderingContext2D constructor to eliminate some uses of document
      inside of the CanvasRenderingContext2D class.
      * html/HTMLCanvasElement.h:
      (WebCore::HTMLCanvasElement::renderBox): Added to disambiguate between the
      two parent class versions of the method.
      (WebCore::HTMLCanvasElement::computedStyle): Ditto.
      * html/canvas/CanvasRenderingContext2D.cpp: All of these changes are about
      removing document usage either by using a bool that is set in the constructor or
      by calling one of the new methods added to CanvasSurface.
      (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
      (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode):
      (WebCore::CanvasRenderingContext2D::checkOrigin):
      (WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
      (WebCore::CanvasRenderingContext2D::createPattern):
      (WebCore::CanvasRenderingContext2D::setFont):
      (WebCore::CanvasRenderingContext2D::drawTextInternal):
      * html/canvas/CanvasRenderingContext2D.h:
      * html/canvas/WebGLRenderingContext.cpp: Removed some duplicate includes.
      (WebCore::WebGLRenderingContext::markContextChanged): Reduced calls to renderBox
       as it may become slightly more expensive in the future.
      (WebCore::WebGLRenderingContext::reshape): Ditto.
      
      LayoutTests:
      
      * fast/canvas/script-tests/canvas-gradient-addStop-error.js: Changed the test
      to create a new canvas after switching to dashboard compatiblity mode, which is
      needed now that the compatibility mode is cached in the canvas.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61fc3bb1
    • eric@webkit.org's avatar
      2010-04-02 Zhenyao Mo <zmo@google.com> · 326c1776
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Implement and test new framebuffer object attachment behavior.
              https://bugs.webkit.org/show_bug.cgi?id=35611
      
              * fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added, test framebuffer object attachment behavior.
              * fast/canvas/webgl/framebuffer-object-attachment.html: Added, framebuffer object attachment behavior.
              * fast/canvas/webgl/script-tests/gl-object-get-calls.js: DEPTH_COMPONENT is no longer a valid input, use DEPTH_COMPONENT16 instead.
              * platform/mac-snowleopard/Skipped: The bot does not support EXT_packed_depth_stencil, skip the framebuffer-object-attachment.html test.
      2010-04-02  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Eric Seidel.
      
              Implement and test new framebuffer object attachment behavior.
              https://bugs.webkit.org/show_bug.cgi?id=35611
      
              Test: fast/canvas/webgl/framebuffer-object-attachment.html
      
              * html/canvas/WebGLFramebuffer.cpp: Keep track of attached stencil/depth renderbuffers in WebGLFramebuffer.
              (WebCore::WebGLFramebuffer::WebGLFramebuffer):
              (WebCore::WebGLFramebuffer::setIsAttached):
              * html/canvas/WebGLFramebuffer.h: Ditto.
              (WebCore::WebGLFramebuffer::isDepthAttached):
              (WebCore::WebGLFramebuffer::isStencilAttached):
              (WebCore::WebGLFramebuffer::isDepthStencilAttached):
              * html/canvas/WebGLRenderbuffer.cpp: Keep track of internalformat.
              (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
              * html/canvas/WebGLRenderbuffer.h: Ditto.
              (WebCore::WebGLRenderbuffer::setInternalformat):
              (WebCore::WebGLRenderbuffer::getInternalformat):
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Detect stencil/depth buffer conflicts.
              (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Handling DEPTH_STENCIL case.
              (WebCore::WebGLRenderingContext::getRenderbufferParameter): Get correct WebGL internalformat.
              (WebCore::WebGLRenderingContext::renderbufferStorage): Detect illegal enums.
              * html/canvas/WebGLRenderingContext.idl: Add DEPTH_STENCIL enums.
              * platform/graphics/GraphicsContext3D.h: Add DEPTH_STENCIL enums.
              (WebCore::GraphicsContext3D::):
              * platform/graphics/mac/GraphicsContext3DMac.cpp: Map to correct DEPTH_STENCIL format.
              (WebCore::GraphicsContext3D::framebufferRenderbuffer):
              (WebCore::GraphicsContext3D::renderbufferStorage):
              (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
      2010-04-02  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Eric Seidel.
      
              Implement and test new framebuffer object attachment behavior.
              https://bugs.webkit.org/show_bug.cgi?id=35611
      
              Test: fast/canvas/webgl/framebuffer-object-attachment.html
      
              * src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format.
              (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer):
              (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv):
              (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      326c1776
    • eric@webkit.org's avatar
      2010-04-02 Zhenyao Mo <zmo@google.com> · cb3569ea
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
              https://bugs.webkit.org/show_bug.cgi?id=36908
      
              * fast/canvas/webgl/index-validation-expected.txt: Gathering more information about the cause of the failure.  It's not a fix, and it won't worse change the current test behavior either, i.e., it won't make it better or worse.
              * fast/canvas/webgl/script-tests/index-validation.js: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb3569ea
    • tkent@chromium.org's avatar
      2010-04-02 Kent Tamura <tkent@chromium.org> · e98f3226
      tkent@chromium.org authored
              Reviewed by Darin Adler.
      
              Form control state shouldn't be restored for hidden inputs.
              https://bugs.webkit.org/show_bug.cgi?id=26241
      
              * fast/forms/button-state-restore.html: Updated for the behavior change.
              * fast/forms/state-restore-to-non-edited-controls-expected.txt: Added.
              * fast/forms/state-restore-to-non-edited-controls.html: Added.
      2010-04-02  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              Form control state shouldn't be restored for hidden inputs.
              https://bugs.webkit.org/show_bug.cgi?id=26241
      
              To fix this issue, we don't save values if it is not changed from
              the default value.
      
              Updating the value IDL attribute of some controls such as
              type=hidden also updates the value content attribute, and it's
              impossible to distinguish the initial value and the current
              value. The values of such controls are not saved. It won't be a
              problem because we want to save and restore user-edited values.
      
              Test: fast/forms/state-restore-to-non-edited-controls.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::saveFormControlState):
                Do not save the value if it is same as the default value.
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::saveFormControlState): ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e98f3226
    • eric@webkit.org's avatar
      2010-04-02 Kent Tamura <tkent@chromium.org> · f264f75f
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Forms with autocomplete=off should not consume saved state
              https://bugs.webkit.org/show_bug.cgi?id=36762
      
              * fast/forms/state-restore-to-non-autocomplete-form-expected.txt: Added.
              * fast/forms/state-restore-to-non-autocomplete-form.html: Added.
      2010-04-02  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              Forms with autocomplete=off should not consume saved state
              https://bugs.webkit.org/show_bug.cgi?id=36762
      
              Introduce Element::shouldSaveAndRestoreFormControlState() to check
              if we should save and restore control state.
      
              Test: fast/forms/state-restore-to-non-autocomplete-form.html
      
              * dom/Document.cpp:
              (WebCore::Document::formElementsState): Check shouldSaveAndRestoreFormControlState().
              * dom/Element.h:
              (WebCore::Element::shouldSaveAndRestoreFormControlState): Added. It just returns true.
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElementWithState::autoComplete):
                Added. It return autocomplete state of the form.
              (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
                Added. It returns the result of autoComplete().
              (WebCore::HTMLFormControlElementWithState::finishParsingChildren):
                Do not restore state if shouldSaveAndRestoreFormControlState() is false.
              * html/HTMLFormControlElement.h: Declare autoComplete() and overriding methods.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::autoComplete):
                Reduce code by using autoComplete() of the parent class.
              (WebCore::HTMLInputElement::saveFormControlState):
                Remove the autoComplete() check. Document::formElementsState() does equivalent check.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f264f75f
    • krit@webkit.org's avatar
      2010-04-02 Dirk Schulze <krit@webkit.org> · 075dd16b
      krit@webkit.org authored
              Unreviewed.
      
              [Gtk] LayoutTest feColorMatrix-value with different results over Gtk bots
              https://bugs.webkit.org/show_bug.cgi?id=37029
      
              Adding svg/filters/feColorMatrix-values.svg to the Gtk skip list. Opened
              the bug report from above.
      
              * platform/gtk/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      075dd16b
    • eric@webkit.org's avatar
      2010-04-02 Eric Seidel <eric@webkit.org> · 154a4e99
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Incorrect insertion position after typing 'ำ' (THAI CHARACTER SARA AM = 0E33)
              https://bugs.webkit.org/show_bug.cgi?id=36858
      
              Add failing results for Tiger to make the Tiger bot green.
              We may wish to actually fix Tiger at some point.
      
              * platform/mac-tiger/fast/text/multiglyph-characters-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      154a4e99
    • darin@chromium.org's avatar
      2010-04-02 Darin Fisher <darin@chromium.org> · ff5bcf60
      darin@chromium.org authored
              Add chromium suppression for http/tests/xhtmlmp since we do not support
              this feature.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff5bcf60
    • ossy@webkit.org's avatar
      [Qt] http/tests/xmlhttprequest/access-control-response-with-body.html was introduced in r56955, · 15db350a
      ossy@webkit.org authored
      but it fails: "NETWORK_ERR: XMLHttpRequest Exception 101: A network error occured in synchronous requests."
      
      * platform/qt/Skipped: http/tests/xmlhttprequest/access-control-response-with-body.html skipped.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15db350a
    • ossy@webkit.org's avatar
      [Qt] Platform specific expected file added for test introduced in r56775, · 08b6d499
      ossy@webkit.org authored
      because it passes. Compared to png file and Mac expected file.
      
      * platform/qt/svg/custom/animation-currentColor-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08b6d499
    • eric@webkit.org's avatar
      2010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com> · fc8fefee
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Accept XHTML-MP content type as XHTML content
              https://bugs.webkit.org/show_bug.cgi?id=34262
      
              Add a simple test that fails if XHTML-MP mime
              type is not accepted.
      
              * http/conf/mime.types: Register XHTML-MP mime
              type with the test server
              * http/tests/xhtmlmp: Added.
              * http/tests/xhtmlmp/xhtml-expected.txt: Added.
              * http/tests/xhtmlmp/xhtml.xhtmlmp: Added. Testcase
              with the newly registered file extension.
      2010-04-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Eric Seidel.
      
              Accept XHTML-MP content type as XHTML content
              https://bugs.webkit.org/show_bug.cgi?id=34262
      
              Enable processing XHTML-MP mime type as an XHTML document
              even if XHTML-MP support is not enabled.
      
              * platform/MIMETypeRegistry.cpp:
              (WebCore::initializeSupportedNonImageMimeTypes):
      2010-04-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Eric Seidel.
      
              Accept XHTML-MP content type as XHTML content
              https://bugs.webkit.org/show_bug.cgi?id=34262
      
              Register xhtmlmp file extension as the new type
              for XHTML-MP test content.
      
              * Scripts/run-webkit-tests:
              * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
              * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc8fefee
    • tkent@chromium.org's avatar
      2010-04-02 Kent Tamura <tkent@chromium.org> · 62b57b78
      tkent@chromium.org authored
              Unreviewed test fix.  Follow the behavior change by r56962.
      
              * editing/selection/4960137.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62b57b78
    • eric@webkit.org's avatar
      2010-04-02 Eric Seidel <eric@webkit.org> · 99cf1081
      eric@webkit.org authored
              Unreviewed, just updating expected results for passing tests.
      
              suppress image failures for now to get a clean test run w/ pixel tests enabled for new-run-webkit-tests
              https://bugs.webkit.org/show_bug.cgi?id=36620
      
              Remove several tests marked MISSING which no longer seem to be missing.
      
              * platform/mac/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99cf1081
    • abarth@webkit.org's avatar
      2010-04-02 Adam Barth <abarth@webkit.org> · 1a116dc7
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              REGRESSION(56295): http/tests/security/xssAuditor/xss-protection-parsing-01.html times out on Tiger Bot
              https://bugs.webkit.org/show_bug.cgi?id=36933
      
              Change the test design in an attempt to get this passing on Tiger.  In
              this variation, we use a POST request to work around possible caching
              issues in Tiger's CFNetwork.
      
              * http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
              * http/tests/security/xssAuditor/xss-protection-parsing-01.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a116dc7
    • eric@webkit.org's avatar
      2010-04-01 MORITA Hajime <morrita@google.com> · 34b6479d
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              setting document.title doesn't change document.title value
              https://bugs.webkit.org/show_bug.cgi?id=36802
      
              * fast/dom/Document/script-tests/title-with-multiple-children.js: Added.
              * fast/dom/Document/title-with-multiple-children-expected.txt: Added.
              * fast/dom/Document/title-with-multiple-children.html: Added.
      2010-04-01  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Darin Adler.
      
              setting document.title doesn't change document.title value
              https://bugs.webkit.org/show_bug.cgi?id=36802
      
              An entity of "value" argument on HTMLTitleElement::setTitle() could be
              Document::m_title and be changed during HTMLTitleElement::setText().
              Fix copying the argument to keep the original value.
      
              Test: fast/dom/Document/title-with-multiple-children.html
      
              * html/HTMLTitleElement.cpp:
              (WebCore::HTMLTitleElement::setText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34b6479d
  5. 01 Apr, 2010 7 commits