1. 05 Apr, 2010 22 commits
    • robert@webkit.org's avatar
      2010-04-05 Robert Hogan <robert@webkit.org> · 543a7f86
      robert@webkit.org authored
              Reviewed by Kenneth Rohde-Christiansen.
      
              [Qt] Fix infinite redirection loop in QNetworkReplyHandler
      
              Qt enters an infinite loop if a redirect response redirects to itself.
      
              Fixes http/tests/xmlhttprequest/connection-error-sync.html
      
              https://bugs.webkit.org/show_bug.cgi?id=37097
      
              * platform/network/qt/QNetworkReplyHandler.cpp:
              (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
      
      2010-04-05  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Kenneth Rohde-Christiansen.
      
              [Qt] Fix infinite redirection loop in QNetworkReplyHandler
      
              Unskip http/tests/xmlhttprequest/connection-error-sync.html
      
              https://bugs.webkit.org/show_bug.cgi?id=37097
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      543a7f86
    • ojan@chromium.org's avatar
      2010-04-05 Ojan Vafai <ojan@chromium.org> · 03d32669
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              prepare-ChangeLog should take a merge-base for which git branch to diff against.
              https://bugs.webkit.org/show_bug.cgi?id=36394
      
              * Scripts/prepare-ChangeLog:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03d32669
    • kenneth@webkit.org's avatar
      Unreviewed layout test fix. · 137e8939
      kenneth@webkit.org authored
      Update Qt results for iframe flattening.
      
      * platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
      * platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
      * platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
      * platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      137e8939
    • yurys@chromium.org's avatar
      2010-04-05 Yury Semikhatsky <yurys@chromium.org> · 9f68e8db
      yurys@chromium.org authored
              Unreviewed, revert r57078.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f68e8db
    • dglazkov@chromium.org's avatar
      2010-04-05 Dimitri Glazkov <dglazkov@chromium.org> · d3762f6e
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Style update done due to mutation event dispatching in textarea can be
              used to corrupt the render tree.
              https://bugs.webkit.org/show_bug.cgi?id=36864
      
              Modified listbox-selection.html to correctly set the size during
              creation. Otherwise, options added to it as a menuList, resulting
              in a default selection of the first item.
      
              Added a few more tests to ensure we capture correct behavior for
              select elements and their default selection, as well as the influence
              of when layout occurs.
      
              * fast/forms/listbox-selection.html:
              * fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
              * fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
              * fast/forms/textarea-and-mutation-events.html: Added.
      2010-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Style update done due to mutation event dispatching in textarea can be
              used to corrupt the render tree.
              https://bugs.webkit.org/show_bug.cgi?id=36864
      
              Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html
                     fast/forms/select-change-popup-to-listbox-roundtrip.html
                     fast/forms/textarea-and-mutation-events.html
      
              * dom/Node.cpp:
              (WebCore::Node::dispatchGenericEvent): Removed invocation of
                  Document::updateStyleForAllDocuments
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit
                  recalc to ensure accuracy of representation, especially for
                  menuList/listBox switches.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3762f6e
    • kenneth@webkit.org's avatar
      iframe flattening doesn't flatten · 508a9397
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36798
      
      Reviewed by Dave Hyatt.
      
      Fixed to the iframe flattening code so that the iframes on
      http://www.samisite.com/test-csb2nf/id43.htm are actually
      flattened.
      
      Covered by current tests.
      
      * page/FrameView.cpp: Propagate contents changes of iframes
      and subframes in framesets to the parent so that it is relayouted
      (WebCore::FrameView::setContentsSize):
      (WebCore::FrameView::adjustViewSize):
      (WebCore::FrameView::scheduleRelayout):
      * rendering/RenderPart.cpp: HTMLIFrameElement do not inherit from
      HTMLFrameElement, but HTMLFrameElementBase, correct cast. Correct
      the use of inset border values. Avoid a sometimes unnecessary
      relayout.
      (WebCore::RenderPart::layoutWithFlattening):
      * rendering/RenderPartObject.cpp: Make the calcHeight and calcWidth
      return the right values, considering scrolling and fixed width/height
      (WebCore::RenderPartObject::flattenFrame):
      (WebCore::RenderPartObject::calcHeight):
      (WebCore::RenderPartObject::calcWidth):
      (WebCore::RenderPartObject::layout):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      508a9397
    • vitalyr@chromium.org's avatar
      2010-04-05 Vitaly Repeshko <vitalyr@chromium.org> · eaf6bfb1
      vitalyr@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              [V8] Extend the set of types supported by SerializedScriptValue
              https://bugs.webkit.org/show_bug.cgi?id=37052
      
              New types include sparse arrays, Uint32, Date, and ImageData.
      
              Serialization process became more flexible. A state can either
              directly write primitive values (instead of returning them like
              iterator) or construct a new state for serializing complex values
              that will return to the current state when done.
      
              Deserialization process now avoids exposing the tags using a set
              of factory functions for complex objects instead.
      
              Internal buffer type changed to uint8_t to be independent of
              whether char is signed or not.
      
              * bindings/v8/SerializedScriptValue.cpp:
              (WebCore::):
              (WebCore::Writer::Writer):
              (WebCore::Writer::writeString):
              (WebCore::Writer::writeUint32):
              (WebCore::Writer::writeDate):
              (WebCore::Writer::writeNumber):
              (WebCore::Writer::writeImageData):
              (WebCore::Writer::writeArray):
              (WebCore::Writer::writeObject):
              (WebCore::Writer::writeSparseArray):
              (WebCore::Writer::doWriteUint32):
              (WebCore::Writer::doWriteNumber):
              (WebCore::Writer::append):
              (WebCore::Writer::fillHole):
              (WebCore::Writer::byteAt):
              (WebCore::Serializer::Serializer):
              (WebCore::Serializer::serialize):
              (WebCore::Serializer::writeArray):
              (WebCore::Serializer::writeObject):
              (WebCore::Serializer::writeSparseArray):
              (WebCore::Serializer::StateBase::StateBase):
              (WebCore::Serializer::ErrorState::ErrorState):
              (WebCore::Serializer::ErrorState::advance):
              (WebCore::Serializer::State::composite):
              (WebCore::Serializer::State::State):
              (WebCore::Serializer::ArrayState::ArrayState):
              (WebCore::Serializer::ArrayState::advance):
              (WebCore::Serializer::AbstractObjectState::AbstractObjectState):
              (WebCore::Serializer::AbstractObjectState::advance):
              (WebCore::Serializer::ObjectState::ObjectState):
              (WebCore::Serializer::ObjectState::objectDone):
              (WebCore::Serializer::SparseArrayState::SparseArrayState):
              (WebCore::Serializer::SparseArrayState::objectDone):
              (WebCore::Serializer::push):
              (WebCore::Serializer::pop):
              (WebCore::Serializer::handleError):
              (WebCore::Serializer::checkComposite):
              (WebCore::Serializer::writeString):
              (WebCore::Serializer::writeImageData):
              (WebCore::Serializer::newArrayState):
              (WebCore::Serializer::newObjectState):
              (WebCore::Serializer::doSerialize):
              (WebCore::Reader::Reader):
              (WebCore::Reader::read):
              (WebCore::Reader::readString):
              (WebCore::Reader::readUint32):
              (WebCore::Reader::readDate):
              (WebCore::Reader::readNumber):
              (WebCore::Reader::readImageData):
              (WebCore::Reader::doReadUint32):
              (WebCore::Reader::doReadNumber):
              (WebCore::Deserializer::Deserializer):
              (WebCore::Deserializer::createArray):
              (WebCore::Deserializer::createObject):
              (WebCore::Deserializer::createSparseArray):
              (WebCore::Deserializer::initializeObject):
              (WebCore::Deserializer::doDeserialize):
              (WebCore::Deserializer::stackDepth):
              (WebCore::SerializedScriptValue::deserialize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaf6bfb1
    • yurys@chromium.org's avatar
      2010-04-05 Yury Semikhatsky <yurys@chromium.org> · 4a016ace
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Refactored error reporting mechanizm on Worker Global Objects.
              Unlike other event listeners which accept single argument(Event)
              onerror handler on worker global object should be a function
              accepting three arguments. This error reporting was implementedas
              EventListener::reportError method which had custom implementations
              for v8 and JSC. This patch removes EventListener::reportError and
              moves its functionality into custom bindings(V8WorkerContextErrorHandler
              and JSWorkerContextErrorHandler) that implement EventListener inerface
              for the onerror handler.
      
              This patch also makes uncaught exceptions that happen in the onerror
              listener be reported to the Worker's onerror handler.
      
              https://bugs.webkit.org/show_bug.cgi?id=36375
      
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSEventListener.cpp:
              * bindings/js/JSEventListener.h:
              * bindings/js/JSWorkerContextErrorHandler.cpp: Added.
              (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler):
              (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler):
              (WebCore::JSWorkerContextErrorHandler::handleEvent):
              * bindings/js/JSWorkerContextErrorHandler.h: Added.
              (WebCore::JSWorkerContextErrorHandler::create):
              (WebCore::createJSWorkerContextErrorHandler):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/V8WorkerContextErrorHandler.cpp: Added.
              (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler):
              (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
              * bindings/v8/V8WorkerContextErrorHandler.h: Added.
              (WebCore::V8WorkerContextErrorHandler::create):
              * bindings/v8/V8WorkerContextEventListener.cpp:
              * bindings/v8/V8WorkerContextEventListener.h:
              * dom/EventListener.h: Removed reportError method that was used only for reporting worker errors.
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::WorkerContext):
              (WebCore::WorkerContext::reportException):
      
      2010-04-05  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Test that exception which occurs in onerror handler is reported to the Worker object.
      
              https://bugs.webkit.org/show_bug.cgi?id=36375
      
              * fast/workers/worker-script-error-expected.txt:
              * fast/workers/worker-script-error.html:
              * workers/WorkerContext.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a016ace
    • tonikitoo@webkit.org's avatar
      Fix some "explicit braces to avoid ambiguous 'else'" warnings · d83fd03d
      tonikitoo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=37088
      
      Reviewed by Darin Adler.
      Patch by Antonio Gomes (tonikitoo@webkit.org)
      
      * dom/Node.cpp:
      (WebCore::Node::dispatchGenericEvent):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d83fd03d
    • laszlo.1.gombos@nokia.com's avatar
      2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 3c67e74d
      laszlo.1.gombos@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Consolidate the definition of SKIP_STATIC_CONSTRUCTORS_ON_GCC
      
              Instead of defining and undefining it later, let's not
              define SKIP_STATIC_CONSTRUCTORS_ON_GCC for WINSCW.
      
              No new tests as there is no new functionality.
      
              * config.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c67e74d
    • robert@webkit.org's avatar
      2010-04-05 Robert Hogan <robert@webkit.org> · 3b15b4a7
      robert@webkit.org authored
              Rubber-stamped by Kenneth-Rohde Christiansen.
      
              re-login.html and re-login-async.html are now tracked in bugzilla.
      
              https://bugs.webkit.org/show_bug.cgi?id=37084
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b15b4a7
    • eric@webkit.org's avatar
      2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com> · e1321122
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] [Symbian] Remove obsolete build flags for Symbian
              https://bugs.webkit.org/show_bug.cgi?id=37083
      
              Symbian port of QtWebKit port does not use icu, so it does
              not need U_HAVE_* defines.
      
              Symbian now has inttypes.h as part of OpenC.
      
              stdio.h, limits.h and MathExtras.h are already included in
              more appropriate locations.
      
              No new tests as there is no new functionality.
      
              * config.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1321122
    • pfeldman@chromium.org's avatar
      2010-04-05 Pavel Feldman <pfeldman@chromium.org> · baa79630
      pfeldman@chromium.org authored
              Not reviewed: chromium build fix.
      
              * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
              (WebCore::V8InspectorFrontendHost::platformCallback):
              (WebCore::V8InspectorFrontendHost::portCallback):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baa79630
    • kov@webkit.org's avatar
      2010-04-05 Lucas Lommer <llommer@svn.gnome.org> · fe666c0d
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Czech translation for WebKitGtk
              https://bugs.webkit.org/show_bug.cgi?id=36879
      
              * cs.po: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe666c0d
    • kov@webkit.org's avatar
      2010-04-05 Christian Kirbach <Christian.Kirbach@googlemail.com> · 95c9095d
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Updated German translation
              https://bugs.webkit.org/show_bug.cgi?id=36453
      
              * de.po:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95c9095d
    • kov@webkit.org's avatar
      2010-04-05 Luca Ferretti <elle.uca@libero.it> · 477fe07f
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Italian translation for 1.1.90
              https://bugs.webkit.org/show_bug.cgi?id=36323
      
              * it.po:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      477fe07f
    • pfeldman@chromium.org's avatar
      2010-04-05 Pavel Feldman <pfeldman@chromium.org> · 1e19a83d
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [REGRESSION] platform detection in Chromium
              has regressed to unknown.
      
              https://bugs.webkit.org/show_bug.cgi?id=37081
      
              * bindings/js/JSInspectorFrontendHostCustom.cpp:
              (WebCore::JSInspectorFrontendHost::platform):
              (WebCore::JSInspectorFrontendHost::port):
              * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
              (WebCore::V8InspectorFrontendHost::platform):
              (WebCore::V8InspectorFrontendHost::port):
              * inspector/InspectorFrontendHost.cpp:
              * inspector/InspectorFrontendHost.h:
              * inspector/InspectorFrontendHost.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e19a83d
    • eric@webkit.org's avatar
      2010-04-05 Andrey Kosyakov <caseq@chromium.org> · 8624fd2a
      eric@webkit.org authored
              Reviewed by Yury Semikhatsky.
      
              Remove logging of successful XHR and worker's importScript()
              to inspector console
              https://bugs.webkit.org/show_bug.cgi?id=37078
      
              * bindings/js/JSWorkerContextCustom.cpp:
              (WebCore::JSWorkerContext::importScripts):
              * bindings/v8/custom/V8WorkerContextCustom.cpp:
              (WebCore::V8WorkerContext::importScriptsCallback):
              * workers/DedicatedWorkerContext.cpp:
              (WebCore::DedicatedWorkerContext::importScripts):
              * workers/DedicatedWorkerContext.h:
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::importScripts):
              * workers/WorkerContext.h:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::didFinishLoading):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8624fd2a
    • pfeldman@chromium.org's avatar
      2010-04-05 Pavel Feldman <pfeldman@chromium.org> · b343bdc1
      pfeldman@chromium.org authored
              Not reviewed: chromium test expectations update for the roll.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b343bdc1
    • eric@webkit.org's avatar
      2010-04-05 Chris Jerdonek <cjerdonek@webkit.org> · 457ce63e
      eric@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              Removed the PatchStyleErrorHandler class and incorporated its
              functionality into the DefaultStyleErrorHandler class.
      
              https://bugs.webkit.org/show_bug.cgi?id=37067
      
              * Scripts/webkitpy/style/checker.py:
                - In the StyleChecker class:
                  - Added a line_number parameter to the check_file() method.
                  - Renamed the handle_style_error parameter to
                    mock_handle_style_error to be consistent with the other mock_*
                    parameter names.
                  - Added a mock_check_file parameter to the check_patch() method
                    to facilitate unit testing the changes in this patch.
                  - Rewrote the check_patch() method with the patch-parsing logic
                    taken from the PatchStyleErrorHandler class.
      
              * Scripts/webkitpy/style/checker_unittest.py:
                - Added a StyleCheckerCheckFileBase class and sub-classed the
                  existing StyleCheckerCheckFileTest class from it.
                - Added a StyleCheckerCheckPatchTest class to unit-test the
                  rewritten check_patch() method.
                - Removed the vestigial __main__ code at the bottom of the file.
                  This is left over from when check-webkit-style was implemented
                  as a module and a wrapper module.
      
              * Scripts/webkitpy/style/error_handlers.py:
                - Added an optional line_numbers parameter to the
                  DefaultStyleErrorHandler class constructor and adjusted the
                  __call__() method as necessary.
                - Removed the PatchStyleErrorHandler class.
      
              * Scripts/webkitpy/style/error_handlers_unittest.py:
                - Removed the PatchStyleErrorHandlerTest class which unit-tested
                  the PatchStyleErrorHandler class which is being removed in this
                  patch.
                - Added a test_line_numbers() test method to the
                  DefaultStyleErrorHandlerTest class to test use of the
                  DefaultStyleErrorHandler's new line_numbers attribute.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      457ce63e
    • abarth@webkit.org's avatar
      2010-04-05 Adam Barth <abarth@webkit.org> · 3281f443
      abarth@webkit.org authored
              Unreviewed.
      
              Tighten SheriffBot's flaky test detector
              https://bugs.webkit.org/show_bug.cgi?id=37063
      
              Instead of just looking for two sequential red builds, look for two
              sequential failures of the same test.  This should reduce sheriffbot
              false positive substantially.
      
              I'm landing this change unreviewed because I've noticed SheriffBot
              triggering a lot more false positives now that we've expanded the set
              of core builders.  I've tried to take Eric's comments on Bug 37063 into
              account.  I'm happy to iterate on this patch tomorrow once Eric wakes
              up.
      
              * Scripts/webkitpy/common/net/buildbot.py:
              * Scripts/webkitpy/common/net/buildbot_unittest.py:
              * Scripts/webkitpy/tool/commands/queries.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3281f443
    • pfeldman@chromium.org's avatar
      2010-04-04 Pavel Feldman <pfeldman@chromium.org> · 32dee7a4
      pfeldman@chromium.org authored
              Not reviewed. Rolling out chromium changes r57028 and r57032
              for breaking chromium layout tests.
      
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * platform/chromium/DragImageChromium.cpp: Added.
              (WebCore::dragImageSize):
              (WebCore::deleteDragImage):
              (WebCore::scaleDragImage):
              (WebCore::dissolveDragImageToFraction):
              (WebCore::createDragImageFromImage):
              (WebCore::createDragImageIconForCachedImage):
              * platform/chromium/DragImageChromiumMac.cpp: Removed.
              * platform/chromium/DragImageChromiumSkia.cpp: Removed.
              * platform/chromium/DragImageRef.h:
              
              WebKit/chromium:
              * public/WebViewClient.h:
              (WebKit::WebViewClient::startDragging):
              * src/DragClientImpl.cpp:
              (WebKit::DragClientImpl::startDrag):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::startDragging):
              * src/WebViewImpl.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32dee7a4
  2. 04 Apr, 2010 9 commits
    • johnnyg@google.com's avatar
      2010-04-04 John Gregg <johnnyg@google.com> · 23434fe7
      johnnyg@google.com authored
              Unreviewed, add myself to the committers list.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23434fe7
    • tonikitoo@webkit.org's avatar
      Unreviewed expected results fix. · 4bea1ee8
      tonikitoo@webkit.org authored
      Patch by Antonio Gomes <tonikitoo@webkit.org>
      
      The implementation was fixed, and results were no longer valid.
      
      * fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
      * fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bea1ee8
    • tonikitoo@webkit.org's avatar
      2010-03-29 Antonio Gomes <tonikitoo@webkit.org> · 42907ccc
      tonikitoo@webkit.org authored
              Reviewed by Simon Fraser.
              Patch by Antonio Gomes <tonikitoo@webkit.org>
      
              Spatial Navigation: Initial code simplification in FocusController.cpp and SpatialNavigation.cpp
      
              WebCore::distanceInDirection method was handling much of the logic not
              strictly only related to the distance between nodes acquisition. This
              method was simplified and renamed to 'WebCore::distanceDataForNode'.
              The latter is now responsible for only getting the distance and alignment
              data, while all assignement logic previously in distanceInDirection method
              was moved place to updateFocusCandidateIfCloser.
      
              Parent document distance and alignment acquisitions, in turn, have also
              changed location: they are both got from deepFindFocusableNodeInDirection,
              and passed in a recursive call to findFocusableNodeInDirection via the
              candidateParent variable (optional parameter). In addition, the need for
              the 'focusCandidateCopy' variable in deepFindFocusableNodeInDirection method
              was removed, making the code much cleaner.
      
              No behaviour change at this point. Mostly moving code around to the place
              where it should live in.
      
              * page/FocusController.cpp:
              (WebCore::FocusController::advanceFocusDirectionally):
              (WebCore::updateFocusCandidateIfCloser):
              (WebCore::FocusController::findFocusableNodeInDirection):
              (WebCore::FocusController::deepFindFocusableNodeInDirection):
              * page/FocusController.h:
              * page/SpatialNavigation.cpp:
              (WebCore::distanceDataForNode):
              (WebCore::renderRectRelativeToRootDocument):
              * page/SpatialNavigation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42907ccc
    • eric@webkit.org's avatar
      2010-04-04 Pavel Feldman <pfeldman@chromium.org> · 0236640e
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: In the inherited styles, do not render non-inherited properties as overriden.
      
              https://bugs.webkit.org/show_bug.cgi?id=37072
      
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0236640e
    • pfeldman@chromium.org's avatar
      2010-04-04 Pavel Feldman <pfeldman@chromium.org> · 1ddf63b6
      pfeldman@chromium.org authored
              (Not reviewed).
      
              Adding images for inspector blog post. Previewed by Timothy Hatcher.
      
              * blog-files/inspector/audits_launcher.png: Added.
              * blog-files/inspector/audits_panel.png: Added.
              * blog-files/inspector/console_panel.png: Added.
              * blog-files/inspector/context_menu.png: Added.
              * blog-files/inspector/css_highlighted_line.png: Added.
              * blog-files/inspector/css_line_number_snippet.png: Added.
              * blog-files/inspector/css_line_numbers.png: Added.
              * blog-files/inspector/deactivate_breakpoints.png: Added.
              * blog-files/inspector/evaluate_on_hover.png: Added.
              * blog-files/inspector/evaluate_on_hover_2.png: Added.
              * blog-files/inspector/inherited_styles.png: Added.
              * blog-files/inspector/large_dom.png: Added.
              * blog-files/inspector/large_resources.png: Added.
              * blog-files/inspector/pseudo_elements.png: Added.
              * blog-files/inspector/redirect_headers.png: Added.
              * blog-files/inspector/redirect_headers_full.png: Added.
              * blog-files/inspector/redirects.png: Added.
              * blog-files/inspector/redirects_full.png: Added.
              * blog-files/inspector/timeline_overview.png: Added.
              * blog-files/inspector/timeline_panel.png: Added.
              * blog-files/inspector/timeline_record_details.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ddf63b6
    • robert@webkit.org's avatar
      2010-04-04 Robert Hogan <robert@webkit.org> · 674fc053
      robert@webkit.org authored
              Unreviewed, add myself to the committers list.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      674fc053
    • dumi@chromium.org's avatar
      Unreviewed, adding my IRC nickname to committers.py · f76b0a48
      dumi@chromium.org authored
      * Scripts/webkitpy/common/config/committers.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f76b0a48
    • cjerdonek@webkit.org's avatar
      2010-04-04 Chris Jerdonek <cjerdonek@webkit.org> · 95ce6725
      cjerdonek@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              Refactored check-webkit-style's option-parsing code.
      
              https://bugs.webkit.org/show_bug.cgi?id=37064
      
              * Scripts/check-webkit-style:
                - Moved the "WebKit checkout not found" check from
                  ArgumentParser.parse() to the calling code.
                - Moved the --git-commit argument validation from the calling
                  code to ArgumentParser.parse().
      
              * Scripts/webkitpy/style/checker_unittest.py:
                - Updated a unit test as necessary.
      
              * Scripts/webkitpy/style/optparser.py:
                - Renamed ArgumentParser._exit_with_help() to _parse_error()
                  and made its error_message parameter required.
                - Removed the found_checkout parameter from ArgumentParser.parse().
                - Removed the "WebKit checkout not found" check and moved it
                  to the calling code.
                - Added --git-commit argument checking.
      
              * Scripts/webkitpy/style/optparser_unittest.py:
                - Adjusted the import statements to be fully qualified.
                - Changed the ArgumentParserTest class to inherit from
                  LoggingTestCase, and updated the class as necessary.
                - Added a unit-test for the --git-commit validation.
                - Added unit tests for the --git-diff and --git-since variants
                  of --git-commit.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95ce6725
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=37068 · 4f76aacd
      barraclough@apple.com authored
      Change UString to use a 0 rep for null strings instead of a null object.
      
      Reviewed by Oliver Hunt.
      
      No performance impact.
      
      * JavaScriptCore.exp:
      * runtime/InternalFunction.cpp:
      (JSC::InternalFunction::InternalFunction):
      * runtime/JSString.h:
      (JSC::RopeBuilder::JSString):
      * runtime/UString.cpp:
      (JSC::initializeUString):
      * runtime/UString.h:
      (JSC::UString::UString):
      (JSC::UString::data):
      (JSC::UString::size):
      (JSC::UString::isNull):
      (JSC::UString::isEmpty):
      (JSC::UString::cost):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f76aacd
  3. 03 Apr, 2010 9 commits
    • eric@webkit.org's avatar
      2010-04-03 Balazs Kelemen <kb@inf.u-szeged.hu> · 494126b0
      eric@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Fix uninitalised members in CallLinkInfo and BytecodeGenerator.
      
              https://bugs.webkit.org/show_bug.cgi?id=36816
      
              * bytecode/CodeBlock.cpp:
              (JSC::CodeBlock::CodeBlock):
              * bytecode/CodeBlock.h:
              (JSC::CallLinkInfo::CallLinkInfo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      494126b0
    • jwieczorek@webkit.org's avatar
      2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org> · 850eef27
      jwieczorek@webkit.org authored
              Unreviewed.
      
              [Qt] Skip five XMLHttpRequest tests that are timing out.
      
              * platform/qt/Skipped: Add a comment on why they are failing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      850eef27
    • jwieczorek@webkit.org's avatar
      2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org> · f492b8dc
      jwieczorek@webkit.org authored
              Rubber-stamped by Daniel Bates.
      
              Fix the fast/events/popup-allowed-from-gesture-initiated-event.html test
              failure on the Qt and GTK+ ports.
      
              Refactor it to not hardcode any metrics (in order to dispatch mouse events)
              but instead calculate them from the offset* properties.
      
              * fast/events/popup-allowed-from-gesture-initiated-event.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f492b8dc
    • eric@webkit.org's avatar
      2010-04-03 yael aharon <yael.aharon@nokia.com> · 40e6ef33
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Enable HTMLProgressElement for Safari on OSX
              https://bugs.webkit.org/show_bug.cgi?id=36961
      
              * Configurations/FeatureDefines.xcconfig:
      2010-04-03  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Darin Fisher.
      
              Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
              https://bugs.webkit.org/show_bug.cgi?id=36574
      
              Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
              points causing them to throw exceptions rather than synthesize GL
              errors. Fixed the implementations to synthesize INVALID_VALUE
              rather than INVALID_OPERATION to comply to the WebGL spec. Updated
              uniform-location-expected.txt to incorporate the correct error.
              Tested in Safari and Chromium.
      
              * fast/canvas/webgl/null-uniform-location-expected.txt: Added.
              * fast/canvas/webgl/null-uniform-location.html: Added.
              * fast/canvas/webgl/script-tests/null-uniform-location.js: Added.
              (callUniformFunction):
              * fast/canvas/webgl/uniform-location-expected.txt:
      2010-04-03  yael aharon  <yael.aharon@nokia.com>
      
              Reviewed by Darin Adler.
      
              Enable HTMLProgressElement for Safari on OSX
              https://bugs.webkit.org/show_bug.cgi?id=36961
      
              * Configurations/FeatureDefines.xcconfig:
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/RenderThemeMac.h:
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
              (WebCore::RenderThemeMac::animationDurationForProgressBar):
              (WebCore::RenderThemeMac::adjustProgressBarStyle):
              (WebCore::RenderThemeMac::paintProgressBar):
      2010-04-03  yael aharon  <yael.aharon@nokia.com>
      
              Reviewed by Darin Adler.
      
              Enable HTMLProgressElement for Safari on OSX
              https://bugs.webkit.org/show_bug.cgi?id=36961
      
              * Configurations/FeatureDefines.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40e6ef33
    • jwieczorek@webkit.org's avatar
      2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org> · eacf3e1f
      jwieczorek@webkit.org authored
              Unreviewed.
      
              Fix debug build with GCC >= 4.3.
      
              * platform/graphics/GraphicsLayer.cpp: Include stdio.h explicitly.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eacf3e1f
    • eric@webkit.org's avatar
      2010-04-03 Kenneth Russell <kbr@google.com> · a4aa05f3
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
              https://bugs.webkit.org/show_bug.cgi?id=36574
      
              Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
              points causing them to throw exceptions rather than synthesize GL
              errors. Fixed the implementations to synthesize INVALID_VALUE
              rather than INVALID_OPERATION to comply to the WebGL spec. Updated
              uniform-location-expected.txt to incorporate the correct error.
              Tested in Safari and Chromium.
      
              * fast/canvas/webgl/null-uniform-location-expected.txt: Added.
              * fast/canvas/webgl/null-uniform-location.html: Added.
              * fast/canvas/webgl/script-tests/null-uniform-location.js: Added.
              (callUniformFunction):
              * fast/canvas/webgl/uniform-location-expected.txt:
      2010-04-03  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Darin Fisher.
      
              Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
              https://bugs.webkit.org/show_bug.cgi?id=36574
      
              Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
              points causing them to throw exceptions rather than synthesize GL
              errors. Fixed the implementations to synthesize INVALID_VALUE
              rather than INVALID_OPERATION to comply to the WebGL spec. Updated
              uniform-location-expected.txt to incorporate the correct error.
              Tested in Safari and Chromium.
      
              Test: fast/canvas/webgl/null-uniform-location.html
      
              * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
              (WebCore::V8WebGLRenderingContext::getUniformCallback):
              (WebCore::vertexAttribAndUniformHelperf):
              (WebCore::uniformHelperi):
              (WebCore::uniformMatrixHelper):
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::uniform1f):
              (WebCore::WebGLRenderingContext::uniform1fv):
              (WebCore::WebGLRenderingContext::uniform1i):
              (WebCore::WebGLRenderingContext::uniform1iv):
              (WebCore::WebGLRenderingContext::uniform2f):
              (WebCore::WebGLRenderingContext::uniform2fv):
              (WebCore::WebGLRenderingContext::uniform2i):
              (WebCore::WebGLRenderingContext::uniform2iv):
              (WebCore::WebGLRenderingContext::uniform3f):
              (WebCore::WebGLRenderingContext::uniform3fv):
              (WebCore::WebGLRenderingContext::uniform3i):
              (WebCore::WebGLRenderingContext::uniform3iv):
              (WebCore::WebGLRenderingContext::uniform4f):
              (WebCore::WebGLRenderingContext::uniform4fv):
              (WebCore::WebGLRenderingContext::uniform4i):
              (WebCore::WebGLRenderingContext::uniform4iv):
              (WebCore::WebGLRenderingContext::uniformMatrix2fv):
              (WebCore::WebGLRenderingContext::uniformMatrix3fv):
              (WebCore::WebGLRenderingContext::uniformMatrix4fv):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4aa05f3
    • cjerdonek@webkit.org's avatar
      The check-webkit-style script now logs an ERROR and exits when · 39f7c329
      cjerdonek@webkit.org authored
      encountering a file path that does not exist.  Previously, it failed
      silently on such paths.
      
      Reviewed by Shinichiro Hamaji.
      
      https://bugs.webkit.org/show_bug.cgi?id=36957
      
      * Scripts/webkitpy/common/system/logtesting.py:
        - Added a FIXME to rename the LoggingTestCase class to
          LoggingTestCaseBase.
      
      * Scripts/webkitpy/style/checker.py:
        - In the StyleChecker.check_file() method:
          - Added a mock_os_path_exists parameter.
          - Renamed the process_file parameter to mock_process_file.
          - Added logic to log an error and exist if the given path does
            not exist.
      
      * Scripts/webkitpy/style/checker_unittest.py:
        - Refactored the StyleCheckerCheckFileTest class slightly to
          inherit from LoggingTestCase.
        - Added a test method to unit-test the case of a file that
          does not exist.
        - Adjusted the other test methods as necessary.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39f7c329
    • abarth@webkit.org's avatar
      2010-04-03 Adam Barth <abarth@webkit.org> · e9cd7eb9
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red)
              https://bugs.webkit.org/show_bug.cgi?id=33289
      
              Add Tiger and SnowLeopard Tests to the core builders.  This is a bit of
              an experiment now that the bots are green.  Hopefully we can keep them
              on the list and have the tree stay greener.
      
              * Scripts/webkitpy/common/net/buildbot.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9cd7eb9
    • darin@chromium.org's avatar
      2010-04-03 Darin Fisher <darin@chromium.org> · 1e6727b4
      darin@chromium.org authored
              Add default implementations of WebNotificationPresenter methods to
              repair the downstream Chromium build.
      
              * public/WebNotificationPresenter.h:
              (WebKit::WebNotificationPresenter::show):
              (WebKit::WebNotificationPresenter::cancel):
              (WebKit::WebNotificationPresenter::objectDestroyed):
              (WebKit::WebNotificationPresenter::checkPermission):
              (WebKit::WebNotificationPresenter::requestPermission):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e6727b4