1. 24 May, 2007 36 commits
    • weinig's avatar
      Reviewed by Darin. · 53d51520
      weinig authored
              - http://bugs.webkit.org/show_bug.cgi?id=13823
                REGRESSION: fast/forms/select-item-background-clip.html failing pixel test
              Updated the test and the results.
              * fast/forms/select-item-background-clip-expected.checksum:
              * fast/forms/select-item-background-clip-expected.png:
              * fast/forms/select-item-background-clip-expected.txt:
              * fast/forms/select-item-background-clip.html:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      LayoutTests: · a7a7a9ca
      weinig authored
              Reviewed by Darin.
              - test for http://bugs.webkit.org/show_bug.cgi?id=13800
                REGRESSION: Moving a slider moves another unrelated slider
              * fast/forms/slider-thumb-shared-style-expected.checksum: Added.
              * fast/forms/slider-thumb-shared-style-expected.png: Added.
              * fast/forms/slider-thumb-shared-style-expected.txt: Added.
              * fast/forms/slider-thumb-shared-style.html: Added.
              Reviewed by Darin.
              - fix http://bugs.webkit.org/show_bug.cgi?id=13800
                REGRESSION: Moving a slider moves another unrelated slider
              Test: fast/forms/slider-thumb-shared-style.html
              RenderSlider mutates the thumb's style, therefore it must not be shared
              with another slider's thumb, a situation that could occur if the sliders
              themselves shared style.
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::createThumbStyle): Always use a private copy for
              the thumb style.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      LayoutTests: · 143394cc
      adele authored
              Reviewed by Darin.
              Test for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)
              * fast/history/redirect-load-no-form-restoration-expected.txt: Added.
              * fast/history/redirect-load-no-form-restoration.html: Added.
              * fast/history/resources/redirect-load.html: Added.
              Reviewed by Darin.
              Fix for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)
              Test: fast/history/redirect-load-no-form-restoration.html
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::setURL): Clear the document state when the url changes for a HistoryItem.
              (WebCore::HistoryItem::isCurrentDocument): Added. Compares the HistoryItem url to the document's url.  This might not be the best way to do this, but it works for now.
              * history/HistoryItem.h:
              * loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Only set the document (and form) state if the document is current for the history item.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      Reviewed by Darin · 2abbd43a
      weinig authored
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13855
              Port patch 666176 to JavaScriptCore
              - Renamed JSValue::downcast() to JSValue::asCell() which makes the
              function meaning cleaner. It's modeled after Harri Porten change in 
              KDE trunk.
              * kjs/collector.cpp:
              * kjs/object.h:
              * kjs/string_object.cpp:
              * kjs/value.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Update results for better whitespace handling in framesets and tables. · ce6ad918
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      LayoutTests: · 36322bd0
      weinig authored
              Reviewed by Adele.
              - test for http://bugs.webkit.org/show_bug.cgi?id=13857
                REGRESSION: onChange function applied to select element executes twice when focus is set
              * fast/forms/select-double-onchange-expected.txt: Added.
              * fast/forms/select-double-onchange.html: Added.
              Reviewed by Adele.
              - fix http://bugs.webkit.org/show_bug.cgi?id=13857
                REGRESSION: onChange function applied to select element executes twice when focus is set
              Test: fast/forms/select-double-onchange.html
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::menuListOnChange): Changed to update m_lastOnChangeIndex
              before dispatching the change event to avoid reentrancy.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Update results for better whitespace handling in framesets and tables. · 54a68e15
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Hyatt. · d51eb597
      darin authored
              - fix <rdar://problem/5226451> REGRESSION (21618): Mail block quotes
                are missing the lines on the side
              This patch fixes three problems:
              1) makes the "skip canLoad check" boolean also skip the check
                 that prevents any loads while the document is in provisional
                 state; this is the proximate cause of the bug
              * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
              Don't check the frame's state if skipCanLoadCheck is true.
              2) moves the "skip canLoad check" boolean to the Request object;
                 the old implementation would cause that flag to affect the
                 new request we served, which might not be the resource with
                 that flag set
              3) fixes error-handling code path that would leak requests
              * html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
              Pass false to the CachedImage constructor to indicate we are not making
              this object for the cache.
              * loader/Cache.cpp:
              (WebCore::createResource): Pass true to the CachedImage constructor to
              indicate we are making this object for the cache.
              (WebCore::Cache::requestResource): Add new code that assumes the object
              will already have the inCache bit set, and that will delete the object
              and return 0 if the cache is disabled and the load failed.
              * loader/CachedImage.h:
              * loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
              Added a forCache boolean parameter. Always false for the constructor
              that's only used outside the cache code, and passed in as a boolean
              for the constructor that's used both in cache and outside cache.
              * loader/CachedResource.h:
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::CachedResource): Added a forCache boolean
              parameter that determines the initial state of the m_inCache flag.
              This is needed to prevent a resource from being destroyed if an
              error occurs during the initial load.
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::requestCSSStyleSheet): Added FIXME.
              (WebCore::DocLoader::setLoadInProgress): Added null check.
              * loader/Request.h:
              * loader/Request.cpp: (WebCore::Request::Request):
              Added a shouldSkipCanLoadCheck boolean here, since we need to track
              this for each request.
              * loader/loader.h:
              * loader/loader.cpp:
              (WebCore::Loader::load): Pass the skipCanLoadCheck boolean to the
              Request constructor rather than to the servePendingRequests function.
              (WebCore::Loader::servePendingRequests): Add a loop so we can handle
              cases where the request fails immediately without leaking the request
              and thinking that we're loading forever.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Add error reporting for residual style. · 31650da6
      hyatt authored
              Reviewed by aroben
              * html/HTMLParser.cpp:
              * html/HTMLParserErrorCodes.cpp:
              * html/HTMLParserErrorCodes.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes. · 05c8711f
      darin authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Land updated tests. · 03e2b944
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • oliver's avatar
      2007-05-24 Oliver Hunt <oliver@apple.com> · fe91819f
      oliver authored
              Reviewed by Adam, Darin, and Geoff.
              Fix for <rdar://problem/5000470> REGRESSION: The IM reconvert
              function returns incorrect symbol due to inconsistent range
              domains in TSM
              Text Services Management uses ranges provided by the
              NSTextInput API to index into the string return by
              -[WebHTMLView string]. As a result some input methods
              incorrectly get their candidate text from the beginning
              of the document instead of from the input element.
              TSM prefers to query -textStorage over -string so as a
              workaround we provide an implementation of -textStorage that
              returns the content of the current text input.  TSM only ever
              queries the result of textStorage as an NSAttributedString so
              we do not need to implement a fake NSTextStorage class
              This should not cause harm to anything else as textStorage is
              actually a method on NSTextView, which we clearly are not. TSM
              only queries the method because it uses respondsToSelector to
              control behaviour.
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView textStorage]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Report <script/> as a warning instead of an error for now, since we · bb9f9aa9
      hyatt authored
              actually do close it.  (Sigh.)
              Reviewed by beth
              * html/HTMLParser.cpp:
              * html/HTMLParserErrorCodes.cpp:
              * html/HTMLParserErrorCodes.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Add error reporting for the </p> -> <p></p> quirk. · 94376177
      hyatt authored
              Add error reporting when a stray close tag is encountered with no
              corresponding open tag.
              Reviewed by adele
              * html/HTMLParser.cpp:
              * html/HTMLParser.h:
              * html/HTMLParserErrorCodes.cpp:
              * html/HTMLParserErrorCodes.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kmccullo's avatar
      Reviewed by. · 0a2e43eb
      kmccullo authored
              - Do you ever feel like Charlie Brown? *sigh*
              * fast/dom/HTMLHeadElement/resources/head-check.js:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kmccullo's avatar
      LayoutTests: · 6b1b5c2d
      kmccullo authored
              Reviewed by.
              - Rolling back change to fix the build until I have a good fix for data: urls.
              * ChangeLog:
              * fast/dom/HTMLHeadElement/resources/head-check.js:
              * fast/dom/frame-loading-via-document-write-expected.txt: Removed.
              * fast/dom/frame-loading-via-document-write.html: Removed.
              * fast/dom/resources/frame-loading-via-document-write.js: Removed.
              * fast/dom/resources/green250x50.png: Removed.
              * fast/dom/resources/success.html: Removed.
              * http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
              * http/tests/security/frame-loading-via-document-write.html: Removed.
              * http/tests/security/resources/frame-loading-via-document-write.js: Removed.
              * http/tests/security/resources/success.html: Removed.
              Reviewed by.
              - Rolling back change to fix the build until I have a good fix for data: urls.
              * ChangeLog:
              * loader/FrameLoader.cpp:
              * platform/String.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Add two more error messages to the HTMLParser. · bf85dfb9
      hyatt authored
              Report when the </br> -> <br> quirk is triggered.
              Also report whenever the broken XML self-closing tag syntax is used on
              tags that can actually have an end tag (either optional or required).
              Reviewed by aroben
              * html/HTMLParser.cpp:
              * html/HTMLParserErrorCodes.cpp:
              * html/HTMLParserErrorCodes.h:
              * html/HTMLTokenizer.cpp:
              * html/HTMLTokenizer.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      Reviewed by Anders. · b2f346f1
      weinig authored
              Rename JSHTMLFrameSetCustom.cpp to JSHTMLFrameSetElementCustom.cpp
              for consistency.
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLFrameSetCustom.cpp: Removed.
              * bindings/js/JSHTMLFrameSetElementCustom.cpp: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for <rdar://problem/5208440> (13753) · f2cfbe06
      hyatt authored
              REGRESSION: Raw text needs to be pulled outside of tables
              Reviewed by aroben
              * html/HTMLParser.cpp:
              * html/HTMLTableColElement.cpp:
              * html/HTMLTableElement.cpp:
              * html/HTMLTableRowElement.cpp:
              * html/HTMLTableSectionElement.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      LayoutTests: · 23d876c2
      adele authored
              Reviewed by Darin.
              - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13837
                Separator in new <select> widget disappears when block element with border is in document.
              * fast/forms/menulist-separator-painting-expected.checksum: Added.
              * fast/forms/menulist-separator-painting-expected.png: Added.
              * fast/forms/menulist-separator-painting-expected.txt: Added.
              * fast/forms/menulist-separator-painting.html: Added.
              Reviewed by Darin.
              - fix http://bugs.webkit.org/show_bug.cgi?id=13837
                Separator in new <select> widget disappears when block element with border is in document.
              Test: fast/forms/menulist-separator-painting.html
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::drawConvexPolygon): Changed this function to
              actually do both filling and stroking when needed, even though all existing
              callers set the stroke to none.
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintMenuListButton): Added calls to set the stroke
              style and thickness when painting the arrows and the separator.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • thatcher's avatar
      Reviewed by Sam Weinig. · e83e7f4c
      thatcher authored
              Remove the OBJC_NEW_PROPERTIES #ifdef and only export the new @property syntax.
              * bindings/objc/DOMObject.h:
              * bindings/scripts/CodeGeneratorObjC.pm:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      LayoutTests: · deaa7704
      weinig authored
              Reviewed by Anders.
              - update results to account for the new JSHTMLFrameSetElement
                that is being autogenerated and can now produce a constructor.
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/window-properties-expected.txt:
              Reviewed by Anders.
              Uncomment HTMLFramesSetElement constructor now that it exists.
              * page/DOMWindow.idl:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca's avatar
      Try fixing the buildbot build. · 964d84c8
      andersca authored
              * loader/ImageDocument.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      Reviewed by Darin. · 622da3cf
      weinig authored
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13853
              Autogenerate the JS bindings for the HTMLFrameSetElement
              * DerivedSources.make:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/JSHTMLFrameSetCustom.cpp: Added.
              * bindings/js/kjs_html.cpp:
              * bindings/js/kjs_html.h:
              * html/HTMLFrameSetElement.idl:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ddkilzer's avatar
      Remove conflict markers. · 18a9d5e4
      ddkilzer authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • zack's avatar
      Fixing check for incorrent font size - it should · 66430b86
      zack authored
      check fixed not normal.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • harrison's avatar
      Reviewed by Tim Hatcher. · 75fbbf40
      harrison authored
              <rdar://problem/5225343> REGRESSION: With View Source window opened, navigating to a different URL in the browser window results in a crash at WebCore::FrameLoader::frameHasLoaded()
              _private->loader->frameLoader() was not being nil checked.
              * WebView/WebDataSource.mm:
              (-[WebDataSource request]):
              Add nil check for _private->loader->frameLoader() 
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hausmann's avatar
      Fix multipart HTTP POSTs in the Qt port · fb27cb4e
      hausmann authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      Speculative buildbot build fix. · 25f3bcfd
      bdash authored
              * css/cssstyleselector.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • aroben's avatar
      Didn't mean to commit this · ef6005b4
      aroben authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • aroben's avatar
      Made Chrome::addMessageToConsole more flexible · 377f2797
      aroben authored
      addMessageToConsole now takes two additional parameters to specify the
      message source (HTML, JS, CSS, XML) and level (error, warning, log). To
      maintain our old behavior, all current messages were given
      JSMessageSource and ErrorMessageLevel parameters. Messages matching
      these characteristics are passed up to the ChromeClient.
      Reviewed by Hyatt.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Rework how HTML handles line numbering so that it is not fooled by · ec064cb5
      hyatt authored
              \r without a following \n and so that document.write doesn't lead
              to line numbering confusion.
              Reviewed by aroben
              * html/HTMLParser.cpp:
              * html/HTMLTokenizer.cpp:
              * html/HTMLTokenizer.h:
              * html/HTMLViewSourceDocument.cpp:
              * loader/TextDocument.cpp:
              * platform/SegmentedString.cpp:
              * platform/SegmentedString.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Update some tests that darin missed. · 735885b5
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
    • hausmann's avatar
      Share WebCoreHttp and therefore HTTP connections among multiple · 5b9e78e1
      hausmann authored
      QWebNetworkInterface instances by moving the code into
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Remove a stray alert in a testcase that I wrote a while back. · 933a2425
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. 23 May, 2007 4 commits