1. 03 Jan, 2012 34 commits
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=75140 · 535d8bb7
      barraclough@apple.com authored
      Reviewed by Sam Weinig.
      
      Simplify JSArray creation - remove ArgsList/JSValue* create methods
      (this functionality can be implemented in terms of tryCreateUninitialized).
      
      * JavaScriptCore.exp:
      * runtime/ArrayConstructor.cpp:
          - use constructArray/constructEmptyArray instead of calling JSArray::create directly
      (JSC::constructArrayWithSizeQuirk):
      * runtime/JSArray.cpp:
      * runtime/JSArray.h:
          - removed ArgsList/JSValue* create methods
      * runtime/JSGlobalObject.h:
      (JSC::constructEmptyArray):
      (JSC::constructArray):
          - changed to be implemented in terms of JSArray::tryCreateUninitialized
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      535d8bb7
    • rniwa@webkit.org's avatar
      Add a tool to analyze change logs · c333760f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72243
      
      Reviewed by Eric Seidel.
      
      Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
      in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
      for visualizing json files.
      
      Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
      where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
      generates json files, and N is the number of changelogs to parse.
      
      * Scripts/webkitpy/common/config/contributionareas.py: Added names().
      * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
      * Scripts/webkitpy/tool/commands/__init__.py:
      * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
      * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
      * Scripts/webkitpy/tool/commands/data/summary.html: Added.
      * Scripts/webkitpy/tool/steps/options.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c333760f
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=75429 · bfdffec8
      barraclough@apple.com authored
      ThrowTypeError should be a singleton object
      
      Reviewed by Sam Weinig.
      
      Source/JavaScriptCore: 
      
      Per section 13.2.3 of the spec.
      We could change setAccessorDescriptor to be able to share the global
      GetterSetter object, rather than storing the accessor functions and
      creating a new GetterSetter in defineProperty - but this won't be a
      small change to PropertyDescriptors (and would probably mean making
      GetterSetter objects immutable?) - so I'll leave that for another
      patch.
      
      * JavaScriptCore.exp:
          - don't export setAccessorDescriptor
      * runtime/Arguments.cpp:
      (JSC::Arguments::createStrictModeCallerIfNecessary):
      (JSC::Arguments::createStrictModeCalleeIfNecessary):
          - call throwTypeErrorGetterSetter instead of createTypeErrorFunction
      * runtime/Error.cpp:
      * runtime/Error.h:
          - remove createTypeErrorFunction
      * runtime/JSFunction.cpp:
      * runtime/JSFunction.h:
          - remove unused createDescriptorForThrowingProperty
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::reset):
      (JSC::JSGlobalObject::visitChildren):
          - removed m_strictModeTypeErrorFunctionStructure.
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::internalFunctionStructure):
          - removed m_strictModeTypeErrorFunctionStructure.
      * runtime/PropertyDescriptor.cpp:
      (JSC::PropertyDescriptor::setAccessorDescriptor):
          - changed to take a GetterSetter
      * runtime/PropertyDescriptor.h:
          - changed to take a GetterSetter
      
      LayoutTests: 
      
      Per section 13.2.3 of the spec.
      
      * fast/js/basic-strict-mode-expected.txt:
          - ThrowTypeError is a singleton, so cannot generate
            property-specific error messages.
      * fast/js/script-tests/strict-throw-type-error.js: Added.
      * fast/js/strict-throw-type-error-expected.txt: Added.
      * fast/js/strict-throw-type-error.html: Added.
          - added test case that ThrowTypeError is a singleton
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfdffec8
    • joepeck@webkit.org's avatar
      <http://webkit.org/b/59951> Implement Date and Time Input Value Sanitization · 0a776807
      joepeck@webkit.org authored
      Source/WebCore:
      
      Sanitize non-parsable incoming strings to the empty string.
      
      Reviewed by Kent Tamura.
      
      Covered by existing tests.
      
      * html/BaseDateAndTimeInputType.h:
      * html/BaseDateAndTimeInputType.cpp:
      (WebCore::BaseDateAndTimeInputType::sanitizeValue): check if the
      incoming string is valid. If not just return the empty string.
      
      LayoutTests:
      
      Update ValidityState typeMismatch tests for date types, since
      setting an invalid value now sanitized to the empty string.
      So, what used to be an invalid value with a typeMismatch is
      now a valid empty string and there is never a typeMismatch.
      
        - for rangeOverflow / rangeUnderflow tests update the
          test to point out when a value was sanitized.
        - for typeMismatch tests, typeMismatch can no longer
          happen for sanitized values. Change the test to output
          if the value was sanitized or not and ensure that
          we are never in a typeMismatch state. Disabled inputs
          are also sanitized when their value changes.
      
      Reviewed by Kent Tamura.
      
      * fast/forms/date/ValidityState-rangeOverflow-date-expected.txt:
      * fast/forms/date/ValidityState-rangeOverflow-date.html:
      * fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt:
      * fast/forms/date/ValidityState-rangeUnderflow-date.html:
      * fast/forms/date/ValidityState-typeMismatch-date-expected.txt:
      * fast/forms/date/ValidityState-typeMismatch-date.html:
      * fast/forms/datetime/ValidityState-rangeOverflow-datetime-expected.txt:
      * fast/forms/datetime/ValidityState-rangeOverflow-datetime.html:
      * fast/forms/datetime/ValidityState-rangeUnderflow-datetime-expected.txt:
      * fast/forms/datetime/ValidityState-rangeUnderflow-datetime.html:
      * fast/forms/datetime/ValidityState-typeMismatch-datetime-expected.txt:
      * fast/forms/datetime/ValidityState-typeMismatch-datetime.html:
      * fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt:
      * fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html:
      * fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt:
      * fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html:
      * fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal-expected.txt:
      * fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal.html:
      * fast/forms/month/ValidityState-rangeOverflow-month-expected.txt:
      * fast/forms/month/ValidityState-rangeOverflow-month.html:
      * fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt:
      * fast/forms/month/ValidityState-rangeUnderflow-month.html:
      * fast/forms/month/ValidityState-typeMismatch-month-expected.txt:
      * fast/forms/month/ValidityState-typeMismatch-month.html:
      * fast/forms/time/ValidityState-rangeOverflow-time-expected.txt:
      * fast/forms/time/ValidityState-rangeOverflow-time.html:
      * fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt:
      * fast/forms/time/ValidityState-rangeUnderflow-time.html:
      * fast/forms/time/ValidityState-typeMismatch-time-expected.txt:
      * fast/forms/time/ValidityState-typeMismatch-time.html:
      * fast/forms/week/ValidityState-rangeOverflow-week-expected.txt:
      * fast/forms/week/ValidityState-rangeOverflow-week.html:
      * fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt:
      * fast/forms/week/ValidityState-rangeUnderflow-week.html:
      * fast/forms/week/ValidityState-typeMismatch-week-expected.txt:
      * fast/forms/week/ValidityState-typeMismatch-week.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a776807
    • weinig@apple.com's avatar
      Remove unnecessary forward declaration of Function · 548c2605
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75485
      
      Reviewed by Dan Bernstein.
      
      * Platform/WorkQueue.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      548c2605
    • jchaffraix@webkit.org's avatar
      RenderLayer::backgroundClipRect should not check parent() · 7aeef9de
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73731
      
      Reviewed by Simon Fraser.
      
      Clean-up only, no expected change in behavior.
      
      * rendering/RenderLayer.cpp:
      (WebCore::backgroundClipRectForPosition): Changed RenderObject::isPositioned() to
      a check for AbsolutePosition for consistency but also as this is equivalent due to:
      - the previous check for FixedPosition.
      - RenderView, which is positioned, will never goes to this code as it has no parent().
      
      (WebCore::RenderLayer::backgroundClipRect): Removed the parent() check. While at
      it, also moved the inline initialization of |backgroundClipRect| to its own function
      and removed a |view| check as the associated ASSERT seems to never have been reached.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7aeef9de
    • ap@apple.com's avatar
      <rdar://problem/10637779> REGRESSION (r102247): Focus ring is not drawn around a button · 76428a1f
      ap@apple.com authored
              Rubber-stamped by Dan Bernstein.
      
              * platform/mac/ThemeMac.mm: (WebCore::updateStates): Flip an incorrect conditional, this code
              should run on Snow Leopard and Lion.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76428a1f
    • alexis.menard@openbossa.org's avatar
      Source/WebCore: getComputedStyle should return shorthands property with the... · d8e1f645
      alexis.menard@openbossa.org authored
      Source/WebCore: getComputedStyle should return shorthands property with the minimum number of sides possible.
      https://bugs.webkit.org/show_bug.cgi?id=75434
      
      Reviewed by Tony Chang.
      
      As stated in http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties we should
      return shorthands properties with the minimum number of sides possible.
      
      Existing tests have been updated accordingly.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      (WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
      * css/CSSComputedStyleDeclaration.h:
      
      LayoutTests: getComputedStyle should return shorthands properties with the minimum number of sides possible.
      https://bugs.webkit.org/show_bug.cgi?id=75434
      
      Reviewed by Tony Chang.
      
      As stated in http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties we should
      return shorthands properties with the minimum number of sides possible.
      
      * fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt:
      * fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html:
      * fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt:
      * fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html:
      * fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt:
      * fast/css/getComputedStyle/getComputedStyle-border-width.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8e1f645
    • aroben@apple.com's avatar
      Make Port subclasses override the operating_system method rather than setting an attribute · 2b9314be
      aroben@apple.com authored
      Without this patch, any use of Port.operating_system() within a port's __init__ method would
      return the default value ("mac"). This was confusing the version-checking logic inside
      ApplePort.__init__ on Windows.
      
      Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
      crashes on launch on Windows 7 SP1
      
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/layout_tests/port/apple.py:
      (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
      
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
      should now override the operating_system method instead.
      (Port.operating_system): Changed to always return "mac". Subclasses should override to
      return something else.
      
      * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
      (ChromiumLinuxPort.__init__):
      (ChromiumLinuxPort.operating_system):
      * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
      (ChromiumMacPort.__init__):
      (ChromiumMacPort.operating_system):
      * Scripts/webkitpy/layout_tests/port/chromium_win.py:
      (ChromiumWinPort.__init__):
      (ChromiumWinPort.operating_system):
      * Scripts/webkitpy/layout_tests/port/mac.py:
      (MacPort.__init__):
      (MacPort.operating_system):
      * Scripts/webkitpy/layout_tests/port/win.py:
      (WinPort.__init__):
      (WinPort.operating_system):
      Changed to override the operating_system method rather than setting the _operating_system
      attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
      
      * Scripts/webkitpy/layout_tests/port/qt.py:
      (QtPort.__init__):
      (QtPort._path_to_webcore_library):
      Changed to use self.operating_system() instead of self._operating_system, for consistency
      with other Port-related code.
      
      (QtPort.operating_system): Added this override of Port.operating_system that returns the
      value we determined in our __init__ method.
      
      * Scripts/webkitpy/layout_tests/port/test.py:
      (TestPort.operating_system): Added this override of Port.operating_system that returns the
      value we determined in our __init__ method.
      
      * Scripts/webkitpy/layout_tests/port/base_unittest.py:
      (PortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
      (ChromiumLinuxPortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
      (ChromiumMacPortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
      (ChromiumWinPortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
      (MacPortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
      (QtPortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/win_unittest.py:
      (WinPortTest.test_operating_system):
      Test that all ports return the expected operating system string.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b9314be
    • commit-queue@webkit.org's avatar
      [GTK] GTK+ 3 theming code does not use the GtkOrientable style class · e80b8c3a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72789
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-03
      Reviewed by Philippe Normand.
      
      No new tests. Testing GTK+ theming is quite difficult
      because no two distributions have the same set of themes.
      Current tests prevent regressions.
      
      * platform/gtk/RenderThemeGtk3.cpp:
      (WebCore::applySliderStyleContextClasses): Added this helper that
      properly handles the orientable style class.
      (WebCore::RenderThemeGtk::paintSliderTrack): Use the new helper.
      (WebCore::RenderThemeGtk::paintSliderThumb): Ditto.
      * platform/gtk/ScrollbarThemeGtk3.cpp:
      (WebCore::applyScrollbarStyleContextClasses): Added this helper that
      properly handles the orientable style class.
      (WebCore::ScrollbarThemeGtk::paintTrackBackground): Use the new helper.
      (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto.
      (WebCore::ScrollbarThemeGtk::paintThumb): Ditto.
      (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e80b8c3a
    • commit-queue@webkit.org's avatar
      NULL ptr in WebCore::SVGStyledTransformableElement::animatedLocalTransform · 8282a1d8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75227
      
      Patch by Florin Malita <fmalita@google.com> on 2012-01-03
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Test: svg/custom/webkit-transform-crash.html
      
      * svg/SVGStyledTransformableElement.cpp:
      (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
      Add a null-renderer check.
      
      LayoutTests:
      
      * svg/custom/webkit-transform-crash-expected.txt: Added.
      * svg/custom/webkit-transform-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8282a1d8
    • mitz@apple.com's avatar
      Fixed a typo in the change log · e1e2538c
      mitz@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1e2538c
    • alexis.menard@openbossa.org's avatar
      getComputedStyle for border is not implemented. · 8e973cb0
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75319
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Implement getComputedStyle for border.
      
      fast/css/getComputedStyle/getComputedStyle-border-shorthand.html was extented.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      LayoutTests:
      
      Extend existing test to cover that we return correct values.
      
      * fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt:
      * fast/css/getComputedStyle/getComputedStyle-border-shorthand.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e973cb0
    • alexis.menard@openbossa.org's avatar
      Sort the WebCore XCode project file · 38fec3dd
      alexis.menard@openbossa.org authored
      Reviewed by Dimitri Glazkov.
      
      * WebCore.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38fec3dd
    • enne@google.com's avatar
      [chromium] Set tiler bounds explicitly rather than growing them · 43e567e0
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75331
      
      Reviewed by James Robinson.
      
      Rather than only growing bounds, make the bounds on the tiler be set
      explicitly by TiledLayerChromium. This patch now properly invalidates
      regions when the bounds change.
      
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::updateBounds):
      (WebCore::TiledLayerChromium::prepareToUpdate):
      (WebCore::TiledLayerChromium::prepareToUpdateIdle):
      * platform/graphics/chromium/TiledLayerChromium.h:
      * platform/graphics/chromium/cc/CCLayerTilingData.cpp:
      (WebCore::CCLayerTilingData::setBounds):
      (WebCore::CCLayerTilingData::bounds):
      * platform/graphics/chromium/cc/CCLayerTilingData.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43e567e0
    • commit-queue@webkit.org's avatar
      [GTK] Slider thumb is not centered on the track with the unico theme · e716ea06
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72802
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-03
      Reviewed by Philippe Normand.
      
      No new tests. This only applies to certain GTK+ themes.
      Existing tests cover the default GTK+ theme.
      
      * platform/gtk/RenderThemeGtk3.cpp:
      (WebCore::RenderThemeGtk::paintSliderThumb): Do not resize the
      slider thumb by the trough border.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e716ea06
    • enne@google.com's avatar
      [chromium] Make tiled layer's tiler always exist · 3b05343a
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75329
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      TiledLayerChromium has some awkward code to handle lazily creating the
      tiler, including lots of null checks and shadowing the tile size.
      Instead, always create the tiler up front. As values change that
      invalidate all tiles, reset it rather than clear the pointer.
      
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::setIsNonCompositedContent):
      * platform/graphics/chromium/LayerChromium.h:
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::TiledLayerChromium):
      (WebCore::TiledLayerChromium::cleanupResources):
      (WebCore::TiledLayerChromium::setTileSize):
      (WebCore::TiledLayerChromium::setBorderTexelOption):
      (WebCore::TiledLayerChromium::drawsContent):
      (WebCore::TiledLayerChromium::updateCompositorResources):
      (WebCore::TiledLayerChromium::setTilingOption):
      (WebCore::TiledLayerChromium::pushPropertiesTo):
      (WebCore::TiledLayerChromium::setIsNonCompositedContent):
      (WebCore::TiledLayerChromium::invalidateRect):
      (WebCore::TiledLayerChromium::protectTileTextures):
      (WebCore::TiledLayerChromium::prepareToUpdate):
      (WebCore::TiledLayerChromium::prepareToUpdateIdle):
      (WebCore::TiledLayerChromium::needsIdlePaint):
      (WebCore::TiledLayerChromium::idlePaintRect):
      * platform/graphics/chromium/TiledLayerChromium.h:
      * platform/graphics/chromium/cc/CCLayerTilingData.cpp:
      (WebCore::CCLayerTilingData::setBorderTexelOption):
      * platform/graphics/chromium/cc/CCLayerTilingData.h:
      * platform/graphics/gpu/TilingData.cpp:
      (WebCore::TilingData::setHasBorderTexels):
      * platform/graphics/gpu/TilingData.h:
      
      Source/WebKit/chromium:
      
      Update test due to changing API. Add a test for changing border
      texel option on TilingData.
      
      * tests/TiledLayerChromiumTest.cpp:
      (WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):
      * tests/TilingDataTest.cpp:
      (WebCore::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b05343a
    • mario@webkit.org's avatar
      [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix · e2f526f0
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75474
      
      Reviewed by Philippe Normand.
      
      * Scripts/run-gtk-tests: Ignore files whose name does not start
      with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2f526f0
    • commit-queue@webkit.org's avatar
      [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser · 6bb96c95
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75472
      
      Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-03
      Reviewed by Tor Arne Vestbø.
      
      * MiniBrowser/qt/MiniBrowser.pro:
      * MiniBrowser/qt/MiniBrowser.qrc:
      * MiniBrowser/qt/qml/BrowserWindow.qml:
      * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bb96c95
    • ddkilzer@apple.com's avatar
      Add Production configuration to gtest Xcode project · 89e9dc03
      ddkilzer@apple.com authored
      <http://webkit.org/b/75153>
      
      Reviewed by Adam Roben.
      
      * gtest/README.WebKit: Updated.
      * gtest/xcode/Config/ProductionProject.xcconfig: Added.
      * gtest/xcode/gtest.xcodeproj/project.pbxproj:
      - Added Production configuration based on Release configuration.
      - Made Production the default configuration.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89e9dc03
    • commit-queue@webkit.org's avatar
      [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser · ba0bd301
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75471
      
      Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-03
      Reviewed by Tor Arne Vestbø.
      
      Add simple UI for JavaScript Alert dialogs. This patch also adds a
      simple DialogButton QML type and a Dialog QML type which will be
      reusable for other JavaScript dialogs.
      
      * MiniBrowser/qt/MiniBrowser.qrc:
      * MiniBrowser/qt/qml/AlertDialog.qml: Added.
      * MiniBrowser/qt/qml/BrowserWindow.qml:
      * MiniBrowser/qt/qml/Dialog.qml: Added.
      * MiniBrowser/qt/qml/DialogButton.qml: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba0bd301
    • commit-queue@webkit.org's avatar
      [Qt][WK2] MiniBrowser doesn't show url bar · 614c2bfd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75470
      
      Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-03
      Reviewed by Tor Arne Vestbø.
      
      * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
      on QtDeclarative (QTBUG-23422).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      614c2bfd
    • carlosgc@webkit.org's avatar
      [GTK] Simplify loader client WebKit2 GTK+ API · 49a24f0c
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74605
      
      Reviewed by Gustavo Noronha Silva.
      
      Source/WebKit2:
      
      Remove WebKitWebLoaderClient from public API keeping it as a
      private object. Loading API has been reduced to two signals in
      WebKitWebView.
      
      * GNUmakefile.am: Remove WebKitWebLoaderClientPrivate.h.
      * UIProcess/API/gtk/WebKitDefines.h: Remove forward delcarations
      that are no longer needed.
      * UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
      (didStartProvisionalLoadForFrame): Emit
      WebKitWebView::load-changed signal with Started event.
      (didReceiveServerRedirectForProvisionalLoadForFrame): Emit
      WebKitWebView::load-changed signal with Redirected event.
      (didFailProvisionalLoadWithErrorForFrame): Emit
      WebKitWebView::load-failed signal with Started event.
      (didCommitLoadForFrame): Emit WebKitWebView::load-changed signal
      with Committed event.
      (didFinishLoadForFrame): Emit WebKitWebView::load-changed signal
      with Finished event.
      (didFailLoadWithErrorForFrame): Emit WebKitWebView::load-failed
      signal with Committed event.
      (webkit_web_loader_client_init):
      (webkit_web_loader_client_class_init):
      * UIProcess/API/gtk/WebKitWebLoaderClient.h: Remove public API and
      move private API here.
      * UIProcess/API/gtk/WebKitWebLoaderClientPrivate.h: Removed.
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkitWebViewLoadFail): Default implementation of
      WebKitWebView::load-failed signal to show a custom error page.
      (webkit_web_view_class_init): Add load-changed and load-failed
      signals.
      (webkitWebViewLoadChanged): Emit WebKitWebView::load-changed with
      the given event.
      (webkitWebViewLoadFailed): Emit WebKitWebView::load-failed signal
      with the given event, failing uri and error.
      * UIProcess/API/gtk/WebKitWebView.h:
      * UIProcess/API/gtk/WebKitWebViewPrivate.h:
      * UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Remove loader
      client section.
      * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Remove loader
      client symbols.
      * UIProcess/API/gtk/docs/webkit2gtk.types: Remove
      webkit_web_loader_client_get_type.
      * UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
      (loadChangedCallback):
      (loadFailedCallback):
      (LoadTrackingTest::LoadTrackingTest):
      (LoadTrackingTest::~LoadTrackingTest):
      (LoadTrackingTest::provisionalLoadStarted):
      (LoadTrackingTest::provisionalLoadReceivedServerRedirect):
      (LoadTrackingTest::provisionalLoadFailed):
      (LoadTrackingTest::loadCommitted):
      (LoadTrackingTest::loadFinished):
      (LoadTrackingTest::loadFailed):
      * UIProcess/API/gtk/tests/LoadTrackingTest.h:
      * UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
      (testLoadingError):
      (LoadStopTrackingTest::loadCommitted):
      (LoadStopTrackingTest::loadFailed):
      (testLoadCancelled):
      * UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
      (beforeAll):
      * UIProcess/API/gtk/webkit2.h: Remove loader client header.
      * UIProcess/API/gtk/webkit2marshal.list:
      
      Tools:
      
      * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
      private API.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49a24f0c
    • haraken@chromium.org's avatar
      Unreviewed. Rebaselined run-bindings-tests results. · 895abddb
      haraken@chromium.org authored
      * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
      (WebCore::JSTestEventConstructor::destroy):
      * bindings/scripts/test/JS/JSTestEventConstructor.h:
      (WebCore::JSTestEventConstructor::releaseImplIfNotNull):
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      (WebCore::JSTestInterface::destroy):
      * bindings/scripts/test/JS/JSTestInterface.h:
      (WebCore::JSTestInterface::releaseImplIfNotNull):
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
      (WebCore::JSTestMediaQueryListListener::destroy):
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
      (WebCore::JSTestMediaQueryListListener::releaseImplIfNotNull):
      * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
      (WebCore::JSTestNamedConstructor::destroy):
      * bindings/scripts/test/JS/JSTestNamedConstructor.h:
      (WebCore::JSTestNamedConstructor::releaseImplIfNotNull):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::JSTestObj::destroy):
      * bindings/scripts/test/JS/JSTestObj.h:
      (WebCore::JSTestObj::releaseImplIfNotNull):
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      (WebCore::JSTestSerializedScriptValueInterface::destroy):
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
      (WebCore::JSTestSerializedScriptValueInterface::releaseImplIfNotNull):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      895abddb
    • carlosgc@webkit.org's avatar
      [GTK] Fix scrollbars size with GTK+ 3.x · 9705df86
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75467
      
      Reviewed by Xan Lopez.
      
      * platform/gtk/RenderThemeGtk3.cpp:
      (WebCore::getStyleContext): Add the style class for the given
      widget type to the GtkWidgetPath when creating GtkStyleContext
      objects.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9705df86
    • vestbo@webkit.org's avatar
      [Qt] Clean up detection of fontconfig · 596f8f72
      vestbo@webkit.org authored
      We decide in features.prf whether or not fontconfig is available, and
      set the HAVE_FONTCONFIG define accordingly. All leaf project files
      should use this define to decide whether or not to link against
      fontconfig, not do their own detection.
      
      We don't need to add link_pkgconfig to CONFIG in each project file,
      as we selectivly enable that configuration in defaults_post when
      needed.
      
      Reviewed by Ossy.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      596f8f72
    • alexis.menard@openbossa.org's avatar
      getComputedStyle for outline is not implemented. · 9babb3a5
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75441
      
      Reviewed by Antonio Gomes.
      
      Source/WebCore:
      
      Implement getComputedStyle for outline.
      
      Test: fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      LayoutTests:
      
      Add new tests to make sure we return the correct values.
      
      * fast/css/getComputedStyle/getComputedStyle-outline-shorthand-expected.txt: Added.
      * fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9babb3a5
    • hclam@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=75468 · b60e8e46
      hclam@chromium.org authored
      Suppress layout test failure due to a new test.
      
      Unreviewed, build fix.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b60e8e46
    • vestbo@webkit.org's avatar
      [Qt] Introduce qmake replace function for the active build config · 40be7188
      vestbo@webkit.org authored
      Reviewed by Ossy.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40be7188
    • commit-queue@webkit.org's avatar
      [Qt][WK2] tst_favIconLoad.qml crashes on debug mode · 11bf6917
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75448
      
      Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-03
      Reviewed by Kenneth Rohde Christiansen.
      
      * UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml: Loads
      "about:blank" instead of an empty url between tests to clean favicon.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11bf6917
    • carlosgc@webkit.org's avatar
      [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect() · d22b46e8
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75435
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      * platform/gtk/GtkVersioning.c:
      (getScreenCurrentDesktop):
      (getScreenWorkArea):
      (gdk_screen_get_monitor_workarea): Implement it when GTK+ < 3.3.6.
      * platform/gtk/GtkVersioning.h:
      * platform/gtk/PlatformScreenGtk.cpp:
      (WebCore::screenAvailableRect): Use
      gdk_screen_get_monitor_workarea() instead of our own
      implementation.
      
      Source/WebKit/gtk:
      
      * GNUmakefile.am: Make sure unit tests link to X11.
      
      Tools:
      
      * GNUmakefile.am: Make sure DRT links to X11.
      * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d22b46e8
    • philn@webkit.org's avatar
      [WK2][GTK] WebSettings support in MiniBrowser · 35677276
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73773
      
      Reviewed by Martin Robinson.
      
      Patch heavily inspired from the WebKit GtkLauncher to support
      command-line WebSettings. Example: --enable-fullscreen=TRUE.
      The full list of options can be consulted with --help-websettings.
      
      * MiniBrowser/gtk/main.c:
      (loadURI):
      (parseOptionEntryCallback):
      (isValidParameterType):
      (getOptionEntriesFromWebKitSettings):
      (addSettingsGroupToContext):
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35677276
    • philn@webkit.org's avatar
      [GTK] GtkLauncher settings improvements · 9ba8fd43
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75439
      
      Reviewed by Martin Robinson.
      
      * GtkLauncher/main.c:
      (filenameToURL): We can use NULL in C.
      (isValidParameterType): Utility function to filter GParamTypes
      that can be edited.
      (getOptionEntriesFromWebKitWebSettings): Avoid handling
      construct-only properties and use the isValidParameterType
      function. Makes the code a bit cleaner.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ba8fd43
    • barraclough@apple.com's avatar
      Check in fixes for jsc tests following bug #75455. · 77e25a51
      barraclough@apple.com authored
      * tests/mozilla/ecma/GlobalObject/15.1.2.2-1.js:
      * tests/mozilla/ecma/GlobalObject/15.1.2.2-2.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77e25a51
  2. 02 Jan, 2012 6 commits