1. 28 Oct, 2008 16 commits
    • cwzwarich@webkit.org's avatar
      2008-10-28 Cameron Zwarich <zwarich@apple.com> · 53173f3b
      cwzwarich@webkit.org authored
              Rubber-stamped by Sam Weinig.
      
              Create a runtime directory in JavaScriptCore and begin moving files to
              it. This is the first step towards removing the kjs directory and
              placing files in more meaningful subdirectories of JavaScriptCore.
      
              * API/JSBase.cpp:
              * API/JSCallbackConstructor.cpp:
              * API/JSCallbackConstructor.h:
              * API/JSCallbackFunction.cpp:
              * API/JSClassRef.cpp:
              * API/JSClassRef.h:
              * API/JSStringRefCF.cpp:
              * API/JSValueRef.cpp:
              * API/OpaqueJSString.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * kjs/AllInOneFile.cpp:
              * kjs/ArrayConstructor.cpp: Removed.
              * kjs/ArrayConstructor.h: Removed.
              * kjs/ArrayPrototype.cpp: Removed.
              * kjs/ArrayPrototype.h: Removed.
              * kjs/BooleanConstructor.cpp: Removed.
              * kjs/BooleanConstructor.h: Removed.
              * kjs/BooleanObject.cpp: Removed.
              * kjs/BooleanObject.h: Removed.
              * kjs/BooleanPrototype.cpp: Removed.
              * kjs/BooleanPrototype.h: Removed.
              * kjs/CallData.cpp: Removed.
              * kjs/CallData.h: Removed.
              * kjs/ClassInfo.h: Removed.
              * kjs/ConstructData.cpp: Removed.
              * kjs/ConstructData.h: Removed.
              * kjs/DateConstructor.cpp: Removed.
              * kjs/DateConstructor.h: Removed.
              * kjs/DateInstance.cpp: Removed.
              * kjs/DateInstance.h: Removed.
              * kjs/DateMath.cpp: Removed.
              * kjs/DateMath.h: Removed.
              * kjs/DatePrototype.cpp: Removed.
              * kjs/DatePrototype.h: Removed.
              * kjs/Error.cpp: Removed.
              * kjs/Error.h: Removed.
              * kjs/ErrorConstructor.cpp: Removed.
              * kjs/ErrorConstructor.h: Removed.
              * kjs/ErrorInstance.cpp: Removed.
              * kjs/ErrorInstance.h: Removed.
              * kjs/ErrorPrototype.cpp: Removed.
              * kjs/ErrorPrototype.h: Removed.
              * kjs/FunctionConstructor.cpp: Removed.
              * kjs/FunctionConstructor.h: Removed.
              * kjs/FunctionPrototype.cpp: Removed.
              * kjs/FunctionPrototype.h: Removed.
              * kjs/GlobalEvalFunction.cpp: Removed.
              * kjs/GlobalEvalFunction.h: Removed.
              * kjs/InternalFunction.cpp: Removed.
              * kjs/InternalFunction.h: Removed.
              * kjs/JSArray.cpp: Removed.
              * kjs/JSArray.h: Removed.
              * kjs/JSCell.cpp: Removed.
              * kjs/JSCell.h: Removed.
              * kjs/JSFunction.cpp: Removed.
              * kjs/JSFunction.h: Removed.
              * kjs/JSGlobalObject.cpp: Removed.
              * kjs/JSGlobalObject.h: Removed.
              * kjs/JSGlobalObjectFunctions.cpp: Removed.
              * kjs/JSGlobalObjectFunctions.h: Removed.
              * kjs/JSImmediate.cpp: Removed.
              * kjs/JSImmediate.h: Removed.
              * kjs/JSNotAnObject.cpp: Removed.
              * kjs/JSNotAnObject.h: Removed.
              * kjs/JSNumberCell.cpp: Removed.
              * kjs/JSNumberCell.h: Removed.
              * kjs/JSObject.cpp: Removed.
              * kjs/JSObject.h: Removed.
              * kjs/JSString.cpp: Removed.
              * kjs/JSString.h: Removed.
              * kjs/JSValue.cpp: Removed.
              * kjs/JSValue.h: Removed.
              * kjs/JSVariableObject.cpp: Removed.
              * kjs/JSVariableObject.h: Removed.
              * kjs/JSWrapperObject.cpp: Removed.
              * kjs/JSWrapperObject.h: Removed.
              * kjs/MathObject.cpp: Removed.
              * kjs/MathObject.h: Removed.
              * kjs/NativeErrorConstructor.cpp: Removed.
              * kjs/NativeErrorConstructor.h: Removed.
              * kjs/NativeErrorPrototype.cpp: Removed.
              * kjs/NativeErrorPrototype.h: Removed.
              * kjs/NumberConstructor.cpp: Removed.
              * kjs/NumberConstructor.h: Removed.
              * kjs/NumberObject.cpp: Removed.
              * kjs/NumberObject.h: Removed.
              * kjs/NumberPrototype.cpp: Removed.
              * kjs/NumberPrototype.h: Removed.
              * kjs/ObjectConstructor.cpp: Removed.
              * kjs/ObjectConstructor.h: Removed.
              * kjs/ObjectPrototype.cpp: Removed.
              * kjs/ObjectPrototype.h: Removed.
              * kjs/PropertyMap.cpp: Removed.
              * kjs/PropertyMap.h: Removed.
              * kjs/PropertySlot.cpp: Removed.
              * kjs/PropertySlot.h: Removed.
              * kjs/PrototypeFunction.cpp: Removed.
              * kjs/PrototypeFunction.h: Removed.
              * kjs/PutPropertySlot.h: Removed.
              * kjs/SmallStrings.cpp: Removed.
              * kjs/SmallStrings.h: Removed.
              * kjs/StringConstructor.cpp: Removed.
              * kjs/StringConstructor.h: Removed.
              * kjs/StringObject.cpp: Removed.
              * kjs/StringObject.h: Removed.
              * kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
              * kjs/StringPrototype.cpp: Removed.
              * kjs/StringPrototype.h: Removed.
              * kjs/StructureID.cpp: Removed.
              * kjs/StructureID.h: Removed.
              * kjs/completion.h:
              * kjs/interpreter.h:
              * runtime: Added.
              * runtime/ArrayConstructor.cpp: Copied from kjs/ArrayConstructor.cpp.
              * runtime/ArrayConstructor.h: Copied from kjs/ArrayConstructor.h.
              * runtime/ArrayPrototype.cpp: Copied from kjs/ArrayPrototype.cpp.
              * runtime/ArrayPrototype.h: Copied from kjs/ArrayPrototype.h.
              * runtime/BooleanConstructor.cpp: Copied from kjs/BooleanConstructor.cpp.
              * runtime/BooleanConstructor.h: Copied from kjs/BooleanConstructor.h.
              * runtime/BooleanObject.cpp: Copied from kjs/BooleanObject.cpp.
              * runtime/BooleanObject.h: Copied from kjs/BooleanObject.h.
              * runtime/BooleanPrototype.cpp: Copied from kjs/BooleanPrototype.cpp.
              * runtime/BooleanPrototype.h: Copied from kjs/BooleanPrototype.h.
              * runtime/CallData.cpp: Copied from kjs/CallData.cpp.
              * runtime/CallData.h: Copied from kjs/CallData.h.
              * runtime/ClassInfo.h: Copied from kjs/ClassInfo.h.
              * runtime/ConstructData.cpp: Copied from kjs/ConstructData.cpp.
              * runtime/ConstructData.h: Copied from kjs/ConstructData.h.
              * runtime/DateConstructor.cpp: Copied from kjs/DateConstructor.cpp.
              * runtime/DateConstructor.h: Copied from kjs/DateConstructor.h.
              * runtime/DateInstance.cpp: Copied from kjs/DateInstance.cpp.
              * runtime/DateInstance.h: Copied from kjs/DateInstance.h.
              * runtime/DateMath.cpp: Copied from kjs/DateMath.cpp.
              * runtime/DateMath.h: Copied from kjs/DateMath.h.
              * runtime/DatePrototype.cpp: Copied from kjs/DatePrototype.cpp.
              * runtime/DatePrototype.h: Copied from kjs/DatePrototype.h.
              * runtime/Error.cpp: Copied from kjs/Error.cpp.
              * runtime/Error.h: Copied from kjs/Error.h.
              * runtime/ErrorConstructor.cpp: Copied from kjs/ErrorConstructor.cpp.
              * runtime/ErrorConstructor.h: Copied from kjs/ErrorConstructor.h.
              * runtime/ErrorInstance.cpp: Copied from kjs/ErrorInstance.cpp.
              * runtime/ErrorInstance.h: Copied from kjs/ErrorInstance.h.
              * runtime/ErrorPrototype.cpp: Copied from kjs/ErrorPrototype.cpp.
              * runtime/ErrorPrototype.h: Copied from kjs/ErrorPrototype.h.
              * runtime/FunctionConstructor.cpp: Copied from kjs/FunctionConstructor.cpp.
              * runtime/FunctionConstructor.h: Copied from kjs/FunctionConstructor.h.
              * runtime/FunctionPrototype.cpp: Copied from kjs/FunctionPrototype.cpp.
              * runtime/FunctionPrototype.h: Copied from kjs/FunctionPrototype.h.
              * runtime/GlobalEvalFunction.cpp: Copied from kjs/GlobalEvalFunction.cpp.
              * runtime/GlobalEvalFunction.h: Copied from kjs/GlobalEvalFunction.h.
              * runtime/InternalFunction.cpp: Copied from kjs/InternalFunction.cpp.
              * runtime/InternalFunction.h: Copied from kjs/InternalFunction.h.
              * runtime/JSArray.cpp: Copied from kjs/JSArray.cpp.
              * runtime/JSArray.h: Copied from kjs/JSArray.h.
              * runtime/JSCell.cpp: Copied from kjs/JSCell.cpp.
              * runtime/JSCell.h: Copied from kjs/JSCell.h.
              * runtime/JSFunction.cpp: Copied from kjs/JSFunction.cpp.
              * runtime/JSFunction.h: Copied from kjs/JSFunction.h.
              * runtime/JSGlobalObject.cpp: Copied from kjs/JSGlobalObject.cpp.
              * runtime/JSGlobalObject.h: Copied from kjs/JSGlobalObject.h.
              * runtime/JSGlobalObjectFunctions.cpp: Copied from kjs/JSGlobalObjectFunctions.cpp.
              * runtime/JSGlobalObjectFunctions.h: Copied from kjs/JSGlobalObjectFunctions.h.
              * runtime/JSImmediate.cpp: Copied from kjs/JSImmediate.cpp.
              * runtime/JSImmediate.h: Copied from kjs/JSImmediate.h.
              * runtime/JSNotAnObject.cpp: Copied from kjs/JSNotAnObject.cpp.
              * runtime/JSNotAnObject.h: Copied from kjs/JSNotAnObject.h.
              * runtime/JSNumberCell.cpp: Copied from kjs/JSNumberCell.cpp.
              * runtime/JSNumberCell.h: Copied from kjs/JSNumberCell.h.
              * runtime/JSObject.cpp: Copied from kjs/JSObject.cpp.
              * runtime/JSObject.h: Copied from kjs/JSObject.h.
              * runtime/JSString.cpp: Copied from kjs/JSString.cpp.
              * runtime/JSString.h: Copied from kjs/JSString.h.
              * runtime/JSValue.cpp: Copied from kjs/JSValue.cpp.
              * runtime/JSValue.h: Copied from kjs/JSValue.h.
              * runtime/JSVariableObject.cpp: Copied from kjs/JSVariableObject.cpp.
              * runtime/JSVariableObject.h: Copied from kjs/JSVariableObject.h.
              * runtime/JSWrapperObject.cpp: Copied from kjs/JSWrapperObject.cpp.
              * runtime/JSWrapperObject.h: Copied from kjs/JSWrapperObject.h.
              * runtime/MathObject.cpp: Copied from kjs/MathObject.cpp.
              * runtime/MathObject.h: Copied from kjs/MathObject.h.
              * runtime/NativeErrorConstructor.cpp: Copied from kjs/NativeErrorConstructor.cpp.
              * runtime/NativeErrorConstructor.h: Copied from kjs/NativeErrorConstructor.h.
              * runtime/NativeErrorPrototype.cpp: Copied from kjs/NativeErrorPrototype.cpp.
              * runtime/NativeErrorPrototype.h: Copied from kjs/NativeErrorPrototype.h.
              * runtime/NumberConstructor.cpp: Copied from kjs/NumberConstructor.cpp.
              * runtime/NumberConstructor.h: Copied from kjs/NumberConstructor.h.
              * runtime/NumberObject.cpp: Copied from kjs/NumberObject.cpp.
              * runtime/NumberObject.h: Copied from kjs/NumberObject.h.
              * runtime/NumberPrototype.cpp: Copied from kjs/NumberPrototype.cpp.
              * runtime/NumberPrototype.h: Copied from kjs/NumberPrototype.h.
              * runtime/ObjectConstructor.cpp: Copied from kjs/ObjectConstructor.cpp.
              * runtime/ObjectConstructor.h: Copied from kjs/ObjectConstructor.h.
              * runtime/ObjectPrototype.cpp: Copied from kjs/ObjectPrototype.cpp.
              * runtime/ObjectPrototype.h: Copied from kjs/ObjectPrototype.h.
              * runtime/PropertyMap.cpp: Copied from kjs/PropertyMap.cpp.
              * runtime/PropertyMap.h: Copied from kjs/PropertyMap.h.
              * runtime/PropertySlot.cpp: Copied from kjs/PropertySlot.cpp.
              * runtime/PropertySlot.h: Copied from kjs/PropertySlot.h.
              * runtime/PrototypeFunction.cpp: Copied from kjs/PrototypeFunction.cpp.
              * runtime/PrototypeFunction.h: Copied from kjs/PrototypeFunction.h.
              * runtime/PutPropertySlot.h: Copied from kjs/PutPropertySlot.h.
              * runtime/SmallStrings.cpp: Copied from kjs/SmallStrings.cpp.
              * runtime/SmallStrings.h: Copied from kjs/SmallStrings.h.
              * runtime/StringConstructor.cpp: Copied from kjs/StringConstructor.cpp.
              * runtime/StringConstructor.h: Copied from kjs/StringConstructor.h.
              * runtime/StringObject.cpp: Copied from kjs/StringObject.cpp.
              * runtime/StringObject.h: Copied from kjs/StringObject.h.
              * runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from kjs/StringObjectThatMasqueradesAsUndefined.h.
              * runtime/StringPrototype.cpp: Copied from kjs/StringPrototype.cpp.
              * runtime/StringPrototype.h: Copied from kjs/StringPrototype.h.
              * runtime/StructureID.cpp: Copied from kjs/StructureID.cpp.
              * runtime/StructureID.h: Copied from kjs/StructureID.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53173f3b
    • ddkilzer@apple.com's avatar
      2008-10-28 Greg Bolsinga <bolsinga@apple.com> · 983f9390
      ddkilzer@apple.com authored
              Reviewed by David Kilzer.
      
              https://bugs.webkit.org/show_bug.cgi?id=2192
              Missing semi-colons in Geoposition.idl
      
              * page/Geoposition.idl: Add missing semi-colons
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      983f9390
    • adele@apple.com's avatar
      WebKit: · 8736600e
      adele@apple.com authored
      2008-10-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sam Weinig. 
      
              * English.lproj/Localizable.strings:
              Updated.
      
      WebKit/win:
      
      2008-10-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sam Weinig. 
      
              * English.lproj: Removed.
              * English.lproj/Localizable.strings: Removed.
              * WebKit.vcproj/WebKit.vcproj: Updated to use Localizable.strings in the top directory, to share with the Mac.
      
      WebKitTools:
      
      2008-10-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sam Weinig. 
      
              Specify which Localizable.strings to update since we don't always want to update the file in the same
              directory where we're searching for the strings to localize.
              
              * Scripts/extract-localizable-strings:
              * Scripts/update-webkit-localizable-strings:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8736600e
    • timothy@apple.com's avatar
      ef573933
    • timothy@apple.com's avatar
      Remove fast/profiler from the skipped list for Tiger since the fix · 7af3522c
      timothy@apple.com authored
              for <rdar://problem/6211578> should make things work.
      
              <rdar://problem/6316530> Profiler tests fail on Tiger
      
              Reviewed by Kevin McCullough.
      
              * platform/mac-tiger/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7af3522c
    • timothy@apple.com's avatar
      Make the JavaScript profiler opt-in, so it does not slow down JavaScript all the time. · 7dec1b92
      timothy@apple.com authored
      Make the Profiles panel in the Web Inspector have an enable screen.
      Profiling now needs to be enabled before console.profile() works.
      
      WebCore:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Make the Profiles panel in the Web Inspector have an enable screen.
              Profiling now needs to be enabled before console.profile() works.
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * English.lproj/localizedStrings.js: New strings.
              * WebCore.base.exp: New and changed exports.
              * WebCore.vcproj/WebCore.vcproj: Add the PanelEnablerView.js file.
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::supportsProfiling): Call InspectorController:profilerEnabled.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController): Initialize the m_startProfiling
              Timer to call InspectorController::startUserInitiatedProfiling.
              (WebCore::InspectorController::startUserInitiatedProfilingSoon): Start a one-shot timer
              that calls InspectorController::startUserInitiatedProfiling.
              (WebCore::InspectorController::startUserInitiatedProfiling): Recompile all JavaScript
              and enable the profiler if the profiler was not enabled.
              (WebCore::InspectorController::stopUserInitiatedProfiling): Rearrange code for readability.
              (WebCore::InspectorController::enableProfiler): Recompile all the JavaScript functions
              if the skipRecompile argument is false. Call the profilerWasEnabled script function.
              (WebCore::InspectorController::disableProfiler): Recompile all the JavaScript functions.
              Call the profilerWasEnabled script function.
              (WebCore::InspectorController::disableDebugger): Set m_attachDebuggerWhenShown to false,
              so it won't be started later.
              * inspector/InspectorController.h:
              (WebCore::InspectorController::profilerEnabled): Return enabled() && m_profilerEnabled.
              * inspector/front-end/Images/debuggingButtons.png: Remove.
              * inspector/front-end/Images/enableButtons.png: Added.
              * inspector/front-end/Images/profilesSilhouette.png: Added.
              * inspector/front-end/Images/scriptsSilhouette.png: Added.
              * inspector/front-end/PanelEnablerView.js: Added.
              (WebInspector.PanelEnablerView):
              (WebInspector.PanelEnablerView.prototype._enableButtonCicked): Fire the "enable clicked"
              event so listeners can do their thing.
              (WebInspector.PanelEnablerView.prototype._windowResized): Test if the icon should be hidden.
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel): Create the PanelEnablerView and the strings needed for it.
              (WebInspector.ProfilesPanel.prototype.get statusBarItems): Include the enableToggleButton.
              (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): Call reset and populateInterface.
              (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): Call reset.
              (WebInspector.ProfilesPanel.prototype.reset): Call _updateInterface.
              (WebInspector.ProfilesPanel.prototype.setRecordingProfile): Moved in the code, no changes.
              (WebInspector.ProfilesPanel.prototype._updateInterface): Update the toggle button and
              show/hide other buttons. Also show/hide the PanelEnablerView.
              (WebInspector.ProfilesPanel.prototype._enableProfiling): Call _toggleProfiling if not enabled.
              (WebInspector.ProfilesPanel.prototype._toggleProfiling): Call InspectorController's
              disableProfiler or enableProfiler.
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel): Replace the overlay element with a PanelEnablerView. Replace the
              debuggingButton with the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype.get statusBarItems): Replace the debuggingButton with
              the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Hide/show the pauseOnExceptionButton
              when needed. Replace the overlay element with a PanelEnablerView. Replace the debuggingButton
              with the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype._enableDebugging): Call _toggleDebugging when not enabled.
              (WebInspector.ScriptsPanel.prototype._toggleDebugging): Remove the call to _clearInterface,
              since reset is called from debuggerWasEnabled and debuggerWasDisabled.
              * inspector/front-end/View.js: Inherit from WebInspector.Object.
              * inspector/front-end/WebKit.qrc: Add the PanelEnablerView.js file.
              * inspector/front-end/inspector.css: New styles for the PanelEnablerView.
              * inspector/front-end/inspector.html: Add the PanelEnablerView.js file.
              * inspector/front-end/inspector.js:
              (WebInspector.profilerWasEnabled): Added. Calls the ProfilesPanel.
              (WebInspector.profilerWasDisabled): Ditto.
              * page/Console.cpp:
              (WebCore::Console::error): Remove null check for m_frame, since m_frame isn't used.
              (WebCore::Console::info): Ditto.
              (WebCore::Console::log): Ditto.
              (WebCore::Console::assertCondition): Ditto.
              (WebCore::Console::dirxml): Remove null check for m_frame and use this->page().
              (WebCore::Console::count): Ditto.
              (WebCore::Console::profile): Return early if InspectorController::profilerEnabled is false.
              (WebCore::Console::profileEnd): Ditto.
              (WebCore::Console::warn): Remove null check for m_frame, since m_frame isn't used.
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Remove initialization of m_didInitializeDeveloperExtrasEnabled.
              (WebCore::Settings::setDeveloperExtrasEnabled): Remove code that recompiled functions.
              Now just sets the member boolean.
              * page/Settings.h: Remove m_didInitializeDeveloperExtrasEnabled.
      
      WebKit/mac:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add WebInspector methods to enable the profiler.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * WebInspector/WebInspector.h:
              * WebInspector/WebInspector.mm:
              (-[WebInspector isJavaScriptProfilingEnabled]): Added. Calls InspectorController::profilerEnabled.
              (-[WebInspector setJavaScriptProfilingEnabled:]): Added. Call InspectorController's disableProfiler
              or enableProfiler methods.
      
      WebKit/win:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add IWebInspector methods to enable the profiler.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * WebInspector.cpp:
              (WebInspector::isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled.
              (WebInspector::setJavaScriptProfilingEnabled): Added. Call InspectorController's disableProfiler
              or enableProfiler methods.
              * WebInspector.h:
      
      WebKitTools:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add support for enabling the profiler, so the profiling tests can continue
              work now that the profiler is not always enabled.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
              * DumpRenderTree/LayoutTestController.cpp:
              (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
              (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
      
      LayoutTests:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Update profiler tests to opt-in to profiling and clean up the output.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it
              does not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * fast/profiler/anonymous-event-handler-expected.txt:
              * fast/profiler/anonymous-event-handler.html:
              * fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
              * fast/profiler/anonymous-function-called-from-different-contexts.html:
              * fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
              * fast/profiler/anonymous-function-calls-built-in-functions.html:
              * fast/profiler/anonymous-function-calls-eval-expected.txt:
              * fast/profiler/anonymous-function-calls-eval.html:
              * fast/profiler/apply-expected.txt:
              * fast/profiler/apply.html:
              * fast/profiler/built-in-function-calls-anonymous-expected.txt:
              * fast/profiler/built-in-function-calls-anonymous.html:
              * fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
              * fast/profiler/built-in-function-calls-user-defined-function.html:
              * fast/profiler/call-expected.txt:
              * fast/profiler/call-nodelist-as-function-expected.txt:
              * fast/profiler/call-nodelist-as-function.html:
              * fast/profiler/call.html:
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt:
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
              * fast/profiler/compare-multiple-profiles-expected.txt:
              * fast/profiler/compare-multiple-profiles.html:
              * fast/profiler/constructor-expected.txt:
              * fast/profiler/constructor.html:
              * fast/profiler/dead-time-expected.txt:
              * fast/profiler/dead-time.html:
              * fast/profiler/document-dot-write-expected.txt:
              * fast/profiler/document-dot-write.html:
              * fast/profiler/event-handler-expected.txt:
              * fast/profiler/event-handler.html:
              * fast/profiler/execution-context-and-eval-on-same-line-expected.txt:
              * fast/profiler/execution-context-and-eval-on-same-line.html:
              * fast/profiler/heavy-view-expected.txt:
              * fast/profiler/heavy-view.html:
              * fast/profiler/inline-event-handler-expected.txt:
              * fast/profiler/inline-event-handler.html:
              * fast/profiler/many-calls-in-the-same-scope-expected.txt:
              * fast/profiler/many-calls-in-the-same-scope.html:
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
              * fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
              * fast/profiler/multiple-and-different-scoped-function-calls.html:
              * fast/profiler/multiple-frames-expected.txt:
              * fast/profiler/multiple-frames.html:
              * fast/profiler/nested-anonymous-functon-expected.txt:
              * fast/profiler/nested-anonymous-functon.html:
              * fast/profiler/nested-start-and-stop-profiler-expected.txt:
              * fast/profiler/nested-start-and-stop-profiler.html:
              * fast/profiler/no-execution-context-expected.txt:
              * fast/profiler/no-execution-context.html:
              * fast/profiler/one-execution-context-expected.txt:
              * fast/profiler/one-execution-context.html:
              * fast/profiler/profile-calls-in-included-file-expected.txt:
              * fast/profiler/profile-calls-in-included-file.html:
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt:
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
              * fast/profiler/profiling-from-a-nested-location-expected.txt:
              * fast/profiler/profiling-from-a-nested-location.html:
              * fast/profiler/resources/profiler-test-JS-resources.js:
              (endTest): Remove some whitespace.
              (insertGivenText): Hide the output of this method, sicne it is not important to the test.
              (insertNewText): Ditto.
              (printHeavyProfilesDataWithoutTime): Output plain text an not console.log.
              (printProfilesDataWithoutTime): Ditto.
              (printProfileNodeWithoutTime): Ditto.
              * fast/profiler/simple-event-call-expected.txt:
              * fast/profiler/simple-event-call.html:
              * fast/profiler/simple-no-level-change-expected.txt:
              * fast/profiler/simple-no-level-change.html:
              * fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
              * fast/profiler/start-and-stop-profiler-multiple-times.html:
              * fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt:
              * fast/profiler/start-and-stop-profiling-in-the-same-function.html:
              * fast/profiler/start-but-dont-stop-profiling-expected.txt:
              * fast/profiler/start-but-dont-stop-profiling.html:
              * fast/profiler/stop-profiling-after-setTimeout-expected.txt:
              * fast/profiler/stop-profiling-after-setTimeout.html:
              * fast/profiler/stop-then-function-call-expected.txt:
              * fast/profiler/stop-then-function-call.html:
              * fast/profiler/throw-exception-from-eval-expected.txt:
              * fast/profiler/throw-exception-from-eval.html:
              * fast/profiler/two-execution-contexts-expected.txt:
              * fast/profiler/two-execution-contexts.html:
              * fast/profiler/user-defined-function-calls-built-in-functions-expected.txt:
              * fast/profiler/user-defined-function-calls-built-in-functions.html:
              * fast/profiler/window-dot-eval-expected.txt:
              * fast/profiler/window-dot-eval.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dec1b92
    • timothy@apple.com's avatar
      Rename a few methods related to attaching and detaching the debugger. Also... · 0a8972d0
      timothy@apple.com authored
      Rename a few methods related to attaching and detaching the debugger. Also adds stub methods for enabling and disabling the profiler.
      
      WebCore:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Rename a few methods related to attaching and detaching the debugger. Also
              adds stub methods for enabling and disabling the profiler.
      
              * Rename attachDebugger to enableDebugger.
              * Rename detachDebugger to disableDebugger.
              * Rename the debuggerAttached getter to debuggerEnabled.
              * Rename the debuggerAttached callback to debuggerWasEnabled.
              * Rename the debuggerDetached callback to debuggerWasDisabled.
      
              Reviewed by Darin Adler.
      
              * WebCore.base.exp:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::setWindowVisible):
              (WebCore::InspectorController::windowScriptObjectAvailable):
              (WebCore::InspectorController::close):
              (WebCore::InspectorController::enableProfiler):
              (WebCore::InspectorController::disableProfiler):
              (WebCore::InspectorController::enableDebugger):
              (WebCore::InspectorController::disableDebugger):
              (WebCore::InspectorController::pauseInDebugger):
              (WebCore::InspectorController::resumeDebugger):
              (WebCore::InspectorController::stepOverStatementInDebugger):
              (WebCore::InspectorController::stepIntoStatementInDebugger):
              (WebCore::InspectorController::stepOutOfFunctionInDebugger):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::profilerEnabled):
              (WebCore::InspectorController::debuggerEnabled):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
              * inspector/front-end/Object.js:
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype.get statusBarItems):
              (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
              (WebInspector.ScriptsPanel.prototype.debuggerWasDetached):
              (WebInspector.ScriptsPanel.prototype.reset):
              (WebInspector.ScriptsPanel.prototype.canShowResource):
              (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
              (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
              * inspector/front-end/View.js:
              * inspector/front-end/inspector.css:
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector.addResource):
              (WebInspector.debuggerWasEnabled):
              (WebInspector.debuggerWasDisabled):
      
      WebKit/mac:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Rename a few methods related to attaching and detaching the debugger.
      
              * Rename attachDebugger to enableDebugger.
              * Rename detachDebugger to disableDebugger.
              * Rename the debuggerAttached getter to debuggerEnabled.
      
              Reviewed by Darin Adler.
      
              * WebInspector/WebInspector.mm:
              (-[WebInspector isDebuggingJavaScript]):
              (-[WebInspector startDebuggingJavaScript:]):
              (-[WebInspector stopDebuggingJavaScript:]):
      
      WebKit/win:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Rename a few methods related to attaching and detaching the debugger.
      
              * Rename attachDebugger to enableDebugger.
              * Rename detachDebugger to disableDebugger.
              * Rename the debuggerAttached getter to debuggerEnabled.
      
              Reviewed by Darin Adler.
      
              * WebInspector.cpp:
              (WebInspector::isDebuggingJavaScript):
              (WebInspector::toggleDebuggingJavaScript):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a8972d0
    • timothy@apple.com's avatar
      Fix an exception when searching the Resources panel while there · ecd08c1e
      timothy@apple.com authored
              and resources queued to be added to the list.
      
              Reviewed by Kevin McCullough.
      
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.searchCanceled): Null check
              the _resourcesTreeElement property.
              (WebInspector.ResourcesPanel.prototype.performSearch): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecd08c1e
    • ggaren@apple.com's avatar
      2008-10-28 Geoffrey Garen <ggaren@apple.com> · 0d6be8b7
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
              
              Fixed https://bugs.webkit.org/show_bug.cgi?id=21919
              Sampler reports bogus time in op_enter during 3d-raytrace.js
              
              Fixed a bug where we would pass the incorrect Instruction* during some
              parts of CTI codegen.
      
              * VM/CTI.cpp:
              (JSC::CTI::privateCompileMainPass):
              (JSC::CTI::privateCompileSlowCases):
              * VM/SamplingTool.cpp:
              (JSC::SamplingTool::run):
              * wtf/Platform.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d6be8b7
    • kmccullough@apple.com's avatar
      2008-10-28 Kevin McCullough <kmccullough@apple.com> · c177e3d5
      kmccullough@apple.com authored
              Reviewed by Dan Bernstein.
      
              -Removed unused includes.
              Apparent .4% speedup in Sunspider
      
              * kjs/JSObject.cpp:
              * kjs/interpreter.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c177e3d5
    • simon.fraser@apple.com's avatar
      2008-10-28 Pierre-Olivier Latour <pol@apple.com> · bdbd3f77
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein
      
              Primary changes in DumpRenderTree:
              - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
              is different from regular font CG anti-aliasing) as font-smoothing settings
              depends on the display and can also be changed by the user
              - Use a new cleared buffer for each test instead of the reusing same one to
              avoid potential result corruption across tests
              - Can now receive the expected pixel hash as a suffix to the test path or
              url as "path'hash"
              - Make sure hash is computed in a endian-independent way
              - Improve the code that sets/restores the screen color profile
              - Make the code more cross-platformy with std::string goodness
              - Added an "on-screen" mode where the snapshot will take into account surfaces
              on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
              reading from the display framebuffer on 10.4. This mode is not active by
              default for performance reason, but must be explicitly activated from the test
              file using the new "testOnscreen()" JS API.
      
              Primary changes in ImageDiff:
              - Provide a new comparison algorithm that is more tolerant to "acceptable"
              failures (i.e. very small differences in font rendering, which --threshold is
              not really good at handling)
              - Generate normalized intensity-only diff images
      
              Primary changes in run-webkit-tests:
              - Take advantage of hashes for pixel tests which makes them much faster by
              minimizing image comparisons
              - Removed repaint options as these should be set from within test files using
              JS API
              - Replaced "threshold" option in  by "tolerance" expressed in percents
              - Added more logging when in "verbose" mode
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdbd3f77
    • mitz@apple.com's avatar
      2008-10-28 Pierre-Olivier Latour <pol@apple.com> · 284c073d
      mitz@apple.com authored
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=21821
      
              Ensure all baseline images are in the right location and delete the ones that aren't needed.
      
              * editing/inserting/5607069-1-expected.checksum: Removed.
              * editing/inserting/5607069-1-expected.png: Removed.
              * editing/pasteboard/paste-text-013-expected.png: Removed.
              * fast/css/invalid-percentage-property-expected.checksum: Removed.
              * fast/css/invalid-percentage-property-expected.png: Removed.
              * fast/css/text-align-expected.checksum: Removed.
              * fast/css/text-align-expected.png: Removed.
              * fast/selectors/lang-inheritance-expected.checksum: Removed.
              * fast/selectors/lang-inheritance-expected.png: Removed.
              * fast/selectors/lang-inheritance2-expected.checksum: Removed.
              * fast/selectors/lang-inheritance2-expected.png: Removed.
              * fast/selectors/lang-vs-xml-lang-expected.checksum: Removed.
              * fast/selectors/lang-vs-xml-lang-expected.png: Removed.
              * fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Removed.
              * fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Removed.
              * platform/mac/fast/css/invalid-percentage-property-expected.checksum: Copied from LayoutTests/fast/css/invalid-percentage-property-expected.checksum.
              * platform/mac/fast/css/invalid-percentage-property-expected.png: Copied from LayoutTests/fast/css/invalid-percentage-property-expected.png.
              * platform/mac/fast/css/text-align-expected.checksum: Copied from LayoutTests/fast/css/text-align-expected.checksum.
              * platform/mac/fast/css/text-align-expected.png: Copied from LayoutTests/fast/css/text-align-expected.png.
              * platform/mac/fast/selectors/lang-inheritance-expected.checksum: Copied from LayoutTests/fast/selectors/lang-inheritance-expected.checksum.
              * platform/mac/fast/selectors/lang-inheritance-expected.png: Copied from LayoutTests/fast/selectors/lang-inheritance-expected.png.
              * platform/mac/fast/selectors/lang-inheritance2-expected.checksum: Copied from LayoutTests/fast/selectors/lang-inheritance2-expected.checksum.
              * platform/mac/fast/selectors/lang-inheritance2-expected.png: Copied from LayoutTests/fast/selectors/lang-inheritance2-expected.png.
              * platform/mac/fast/selectors/lang-vs-xml-lang-expected.checksum: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-expected.checksum.
              * platform/mac/fast/selectors/lang-vs-xml-lang-expected.png: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-expected.png.
              * platform/mac/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum.
              * platform/mac/fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-xhtml-expected.png.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      284c073d
    • alp@webkit.org's avatar
      2008-10-28 Alp Toker <alp@nuanti.com> · d5cc6266
      alp@webkit.org authored
              GTK+ build fix for older versions of Pango where PANGO_VERSION_CHECK
              isn't defined.
      
              * platform/graphics/gtk/FontGtk.cpp:
              (WebCore::getDefaultPangoLayout):
              * platform/graphics/gtk/FontPlatformDataPango.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5cc6266
    • alp@webkit.org's avatar
      2008-10-28 Mike Hommey <glandium@debian.org> · 6862a8b1
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              https://bugs.webkit.org/show_bug.cgi?id=21885
              [GTK] libwebkit doesn't link against libpangoft2
      
              Add pkg-config check for pangoft2 which provides
              pango_fc_font_description_from_pattern() used in the FreeType font
              backend.
      
              * configure.ac:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6862a8b1
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · bed87e9a
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=21893
              Character set is incorrect for external scripts in XHTML pages
      
              <rdar://problem/6317451> Incorrect encoding for text in a popup at http://xpoint.ru/
      
              Test: fast/encoding/external-script-charset.xhtml
      
              Expose scriptCharset() function on all ScriptElements, and call it from XML tokenizer.
      
              * dom/ScriptElement.h:
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::XMLTokenizer::endElementNs):
              * dom/XMLTokenizerQt.cpp:
              (WebCore::XMLTokenizer::parseEndElement):
              * html/HTMLScriptElement.h:
              * svg/SVGScriptElement.cpp:
              (WebCore::SVGScriptElement::scriptCharset):
              * svg/SVGScriptElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bed87e9a
    • alp@webkit.org's avatar
      2008-10-28 Alp Toker <alp@nuanti.com> · 2ab3695d
      alp@webkit.org authored
              Include copyright license files in the autotools dist target and
              exclude unused zlib headers.
      
              Change suggested by Mike Hommey.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ab3695d
  2. 27 Oct, 2008 24 commits