1. 20 Jan, 2014 32 commits
    • zandobersek@gmail.com's avatar
      [GTK][WK2] Move the rest of GTK's WorkQueue implementation to std::function · 530f751a
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127273
      
      Reviewed by Anders Carlsson.
      
      Move to using std::function and move semantics in WorkQueue::registerSocketEventHandler
      and WorkQueue::SocketEventSource.
      
      * Platform/IPC/unix/ConnectionUnix.cpp:
      (IPC::Connection::open):
      * Platform/WorkQueue.h:
      * Platform/gtk/WorkQueueGtk.cpp:
      (WorkQueue::SocketEventSource::SocketEventSource):
      (WorkQueue::registerSocketEventHandler):
      (WorkQueue::dispatchOnSource): Use std::move instead of std::forward<T>.
      (WorkQueue::dispatch): Ditto.
      (WorkQueue::dispatchAfter): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      530f751a
    • joepeck@webkit.org's avatar
      Run clang-modernize and let it add a bunch of missing overrides in WebCore/inspector · 585b903f
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127206
      
      Reviewed by Anders Carlsson.
      
      Let clang-modernize add overrides.
      
      * inspector/DOMEditor.cpp:
      * inspector/InspectorApplicationCacheAgent.h:
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorCanvasAgent.h:
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDatabaseAgent.cpp:
      * inspector/InspectorDatabaseAgent.h:
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorHeapProfilerAgent.cpp:
      (WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
      (WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
      * inspector/InspectorHeapProfilerAgent.h:
      * inspector/InspectorHistory.cpp:
      * inspector/InspectorIndexedDBAgent.cpp:
      * inspector/InspectorIndexedDBAgent.h:
      * inspector/InspectorInputAgent.h:
      * inspector/InspectorLayerTreeAgent.h:
      * inspector/InspectorMemoryAgent.h:
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorRuntimeAgent.h:
      * inspector/InspectorStyleSheet.h:
      * inspector/InspectorTimelineAgent.h:
      * inspector/InspectorWorkerAgent.cpp:
      * inspector/InspectorWorkerAgent.h:
      * inspector/PageConsoleAgent.h:
      * inspector/PageDebuggerAgent.h:
      * inspector/PageRuntimeAgent.h:
      * inspector/WorkerConsoleAgent.h:
      * inspector/WorkerDebuggerAgent.cpp:
      * inspector/WorkerInspectorController.cpp:
      * inspector/WorkerRuntimeAgent.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      585b903f
    • zandobersek@gmail.com's avatar
      Move WebAudio source code to std::unique_ptr · 56c23bd4
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127274
      
      Reviewed by Eric Carlson.
      
      Move from using OwnPtr and PassOwnPtr to using std::unique_ptr and move semantics
      in the WebAudio module and the WebAudio code in the platform layer.
      
      * Modules/webaudio/AsyncAudioDecoder.cpp:
      * Modules/webaudio/AsyncAudioDecoder.h:
      * Modules/webaudio/AudioBasicInspectorNode.cpp:
      (WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
      * Modules/webaudio/AudioBasicProcessorNode.cpp:
      (WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
      * Modules/webaudio/AudioBasicProcessorNode.h:
      * Modules/webaudio/AudioBufferSourceNode.cpp:
      (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
      * Modules/webaudio/AudioContext.cpp:
      * Modules/webaudio/AudioContext.h:
      * Modules/webaudio/AudioDestinationNode.cpp:
      (WebCore::AudioDestinationNode::AudioDestinationNode):
      * Modules/webaudio/AudioNode.cpp:
      (WebCore::AudioNode::addInput):
      (WebCore::AudioNode::addOutput):
      (WebCore::AudioNode::checkNumberOfChannelsForInput):
      * Modules/webaudio/AudioNode.h:
      * Modules/webaudio/BiquadFilterNode.cpp:
      (WebCore::BiquadFilterNode::BiquadFilterNode):
      * Modules/webaudio/BiquadProcessor.cpp:
      (WebCore::BiquadProcessor::createKernel):
      (WebCore::BiquadProcessor::getFrequencyResponse):
      * Modules/webaudio/BiquadProcessor.h:
      * Modules/webaudio/ChannelMergerNode.cpp:
      (WebCore::ChannelMergerNode::ChannelMergerNode):
      * Modules/webaudio/ChannelSplitterNode.cpp:
      (WebCore::ChannelSplitterNode::ChannelSplitterNode):
      * Modules/webaudio/ConvolverNode.cpp:
      (WebCore::ConvolverNode::ConvolverNode):
      (WebCore::ConvolverNode::uninitialize):
      (WebCore::ConvolverNode::setBuffer):
      * Modules/webaudio/ConvolverNode.h:
      * Modules/webaudio/DefaultAudioDestinationNode.h:
      * Modules/webaudio/DelayNode.cpp:
      (WebCore::DelayNode::DelayNode):
      * Modules/webaudio/DelayProcessor.cpp:
      (WebCore::DelayProcessor::createKernel):
      * Modules/webaudio/DelayProcessor.h:
      * Modules/webaudio/DynamicsCompressorNode.cpp:
      (WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
      (WebCore::DynamicsCompressorNode::initialize):
      (WebCore::DynamicsCompressorNode::uninitialize):
      * Modules/webaudio/DynamicsCompressorNode.h:
      * Modules/webaudio/GainNode.cpp:
      (WebCore::GainNode::GainNode):
      * Modules/webaudio/MediaElementAudioSourceNode.cpp:
      (WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
      (WebCore::MediaElementAudioSourceNode::setFormat):
      * Modules/webaudio/MediaElementAudioSourceNode.h:
      * Modules/webaudio/MediaStreamAudioDestinationNode.h:
      * Modules/webaudio/MediaStreamAudioSource.cpp:
      * Modules/webaudio/MediaStreamAudioSourceNode.cpp:
      (WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
      * Modules/webaudio/MediaStreamAudioSourceNode.h:
      * Modules/webaudio/OscillatorNode.cpp:
      (WebCore::OscillatorNode::OscillatorNode):
      * Modules/webaudio/PannerNode.cpp:
      (WebCore::PannerNode::PannerNode):
      (WebCore::PannerNode::uninitialize):
      (WebCore::PannerNode::setPanningModel):
      * Modules/webaudio/PannerNode.h:
      * Modules/webaudio/PeriodicWave.cpp:
      (WebCore::PeriodicWave::createBandLimitedTables):
      * Modules/webaudio/PeriodicWave.h:
      * Modules/webaudio/RealtimeAnalyser.cpp:
      (WebCore::RealtimeAnalyser::RealtimeAnalyser):
      (WebCore::RealtimeAnalyser::setFftSize):
      * Modules/webaudio/RealtimeAnalyser.h:
      * Modules/webaudio/ScriptProcessorNode.cpp:
      (WebCore::ScriptProcessorNode::ScriptProcessorNode):
      * Modules/webaudio/WaveShaperDSPKernel.cpp:
      (WebCore::WaveShaperDSPKernel::lazyInitializeOversampling):
      * Modules/webaudio/WaveShaperDSPKernel.h:
      * Modules/webaudio/WaveShaperNode.cpp:
      (WebCore::WaveShaperNode::WaveShaperNode):
      * Modules/webaudio/WaveShaperProcessor.cpp:
      (WebCore::WaveShaperProcessor::createKernel):
      * Modules/webaudio/WaveShaperProcessor.h:
      * platform/audio/AudioBus.cpp:
      (WebCore::AudioBus::AudioBus):
      (WebCore::AudioBus::copyWithGainFrom):
      * platform/audio/AudioBus.h:
      * platform/audio/AudioChannel.cpp:
      * platform/audio/AudioChannel.h:
      (WebCore::AudioChannel::AudioChannel):
      (WebCore::AudioChannel::set):
      * platform/audio/AudioDSPKernelProcessor.h:
      * platform/audio/AudioDestination.h:
      * platform/audio/AudioResampler.cpp:
      (WebCore::AudioResampler::AudioResampler):
      (WebCore::AudioResampler::configureChannels):
      * platform/audio/AudioResampler.h:
      * platform/audio/AudioSession.h:
      * platform/audio/DynamicsCompressor.cpp:
      (WebCore::DynamicsCompressor::setNumberOfChannels):
      * platform/audio/DynamicsCompressor.h:
      * platform/audio/DynamicsCompressorKernel.cpp:
      (WebCore::DynamicsCompressorKernel::setNumberOfChannels):
      * platform/audio/DynamicsCompressorKernel.h:
      * platform/audio/FFTFrame.cpp:
      (WebCore::FFTFrame::createInterpolatedFrame):
      * platform/audio/FFTFrame.h:
      * platform/audio/HRTFDatabase.cpp:
      (WebCore::HRTFDatabase::HRTFDatabase):
      * platform/audio/HRTFDatabase.h:
      * platform/audio/HRTFDatabaseLoader.cpp:
      (WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
      (WebCore::HRTFDatabaseLoader::load):
      * platform/audio/HRTFDatabaseLoader.h:
      * platform/audio/HRTFElevation.cpp:
      (WebCore::HRTFElevation::createForSubject):
      (WebCore::HRTFElevation::createByInterpolatingSlices):
      * platform/audio/HRTFElevation.h:
      (WebCore::HRTFElevation::HRTFElevation):
      * platform/audio/HRTFKernel.cpp:
      (WebCore::HRTFKernel::HRTFKernel):
      (WebCore::HRTFKernel::createImpulseResponse):
      (WebCore::HRTFKernel::createInterpolatedKernel):
      * platform/audio/HRTFKernel.h:
      (WebCore::HRTFKernel::create):
      (WebCore::HRTFKernel::HRTFKernel):
      * platform/audio/MultiChannelResampler.cpp:
      (WebCore::MultiChannelResampler::MultiChannelResampler):
      * platform/audio/MultiChannelResampler.h:
      * platform/audio/Panner.cpp:
      (WebCore::Panner::create):
      * platform/audio/Panner.h:
      * platform/audio/Reverb.cpp:
      (WebCore::Reverb::initialize):
      * platform/audio/Reverb.h:
      * platform/audio/ReverbConvolver.h:
      * platform/audio/ReverbConvolverStage.cpp:
      (WebCore::ReverbConvolverStage::ReverbConvolverStage):
      * platform/audio/ReverbConvolverStage.h:
      * platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
      (WebCore::AudioDestination::create):
      * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
      * platform/audio/ios/AudioDestinationIOS.cpp:
      (WebCore::AudioDestination::create):
      * platform/audio/ios/AudioSessionIOS.mm:
      (WebCore::AudioSession::AudioSession):
      * platform/audio/mac/AudioDestinationMac.cpp:
      (WebCore::AudioDestination::create):
      * platform/audio/mac/AudioDestinationMac.h:
      * platform/audio/mac/AudioSessionMac.cpp:
      (WebCore::AudioSession::AudioSession):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56c23bd4
    • andersca@apple.com's avatar
      Fix build. · 2d4882d6
      andersca@apple.com authored
      * heap/BlockAllocator.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d4882d6
    • commit-queue@webkit.org's avatar
      Region based multicol: support explicit column breaks · fd8f1a2d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123993
      
      Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Merely supporting insertion of explicit (forced) column breaks in
      the region based multicol implementation is really simple: just
      hook up with what the CSS regions code is already doing.
      
      However, there is one complication: column balancing. In order to
      balance columns as nicely as possible when there are explicit
      breaks, we need to figure out between which explicit breaks the
      implicit breaks will occur (if there's room for any at all).
      
      Tests: fast/multicol/newmulticol/break-after.html
             fast/multicol/newmulticol/break-before.html
             fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html
             fast/multicol/newmulticol/breaks-2-columns-3.html
             fast/multicol/newmulticol/breaks-3-columns-3.html
             fast/multicol/newmulticol/fixed-height-fill-balance-2.html
      
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::applyBeforeBreak):
      (WebCore::RenderBlockFlow::applyAfterBreak): Use the already
      existing region breaking code when inserting breaks in region
      based multicol.
      * rendering/RenderFlowThread.h:
      * rendering/RenderMultiColumnBlock.cpp:
      (WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
      (WebCore::RenderMultiColumnBlock::relayoutForPagination): Avoid
      re-balancing if the multicol's contents were not laid out. Apart
      from being good for performance, this is now necessary because of
      how explicit breaks are implemented.
      (WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
      Detect if the contents are going to be laid out, or skipped, so
      that we can tell if we need to (re-)balance the columns
      afterwards.
      * rendering/RenderMultiColumnBlock.h:
      * rendering/RenderMultiColumnFlowThread.cpp:
      (WebCore::RenderMultiColumnFlowThread::addForcedRegionBreak):
      Locate the appropriate multi-column set and call its
      addForcedBreak().
      * rendering/RenderMultiColumnFlowThread.h:
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
      (WebCore::RenderMultiColumnSet::findRunWithTallestColumns):
      (WebCore::RenderMultiColumnSet::distributeImplicitBreaks): Figure
      out how many implicit breaks each single "content run" should
      contain. The taller the content run, the more implicit breaks.
      (WebCore::RenderMultiColumnSet::calculateBalancedHeight): This is
      now a const method that only does half of what the old
      calculateBalancedHeight() did. The rest (such as actually storing
      the new column height) is done by recalculateBalancedHeight().
      (WebCore::RenderMultiColumnSet::clearForcedBreaks): Needs to be
      called between each layout pass, to clear the list of "content
      runs".
      (WebCore::RenderMultiColumnSet::addForcedBreak): Only useful when
      columns are to be balanced. It receives explicit (forced) breaks
      and stores them as "content runs". When layout is done, we'll go
      through the list of content runs, and see where implicit breaks
      should be inserted (if there's room for any). The goal is to
      insert implicit breaks in such a way that the final columns become
      as short as possible.
      (WebCore::RenderMultiColumnSet::recalculateBalancedHeight):
      Calculates and sets a new balanced column height. This used to be
      done directly in calculateBalancedHeight(), but that method is now
      const and it now only calculates the new height and returns it.
      (WebCore::RenderMultiColumnSet::prepareForLayout):
      * rendering/RenderMultiColumnSet.h: Remove old data members
      intended for forced breaks (they were unused), and introduce a
      "content run" vector instead. A new content run is triggered by an
      explicit break. This is only used when column balancing is
      enabled. When not balanced, RenderMultiColumnSet doesn't need to
      do anything when explicit breaks are inserted.
      
      LayoutTests:
      
      * fast/multicol/newmulticol/break-after-expected.html: Added.
      * fast/multicol/newmulticol/break-after.html: Added.
      * fast/multicol/newmulticol/break-before-expected.html: Added.
      * fast/multicol/newmulticol/break-before.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3-expected.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3-no-balancing-expected.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3.html: Added.
      * fast/multicol/newmulticol/breaks-3-columns-3-expected.html: Added.
      * fast/multicol/newmulticol/breaks-3-columns-3.html: Added.
      * fast/multicol/newmulticol/fixed-height-fill-balance-2-expected.html: Added.
      * fast/multicol/newmulticol/fixed-height-fill-balance-2.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd8f1a2d
    • darin@apple.com's avatar
      Update style checker and tests to deal with override instead of OVERRIDE · 3303c76d
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127175
      
      Reviewed by Anders Carlsson.
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_braces): Use override instead of OVERRIDE.
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (CppStyleTest.test_brace_at_begin_of_line): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3303c76d
    • andersca@apple.com's avatar
      Stop using ThreadCondition in BlockAllocator · f7a788fa
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126313
      
      Reviewed by Sam Weinig.
      
      * heap/BlockAllocator.cpp:
      (JSC::BlockAllocator::~BlockAllocator):
      (JSC::BlockAllocator::waitForDuration):
      (JSC::BlockAllocator::blockFreeingThreadMain):
      * heap/BlockAllocator.h:
      (JSC::BlockAllocator::deallocate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7a788fa
    • timothy@apple.com's avatar
      Fix jumping to a text position when showing a resource. · 679d978c
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127271
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/FrameContentView.js:
      (WebInspector.FrameContentView.prototype.showSourceCode): Just use showResponse's arguments
      which already does the same logic to call revealPosition.
      * UserInterface/ResourceClusterContentView.js:
      (WebInspector.ResourceClusterContentView.prototype.restoreFromCookie): This was the bug.
      lineNumber and columnNumber need honored here. They were only honored by FrameContentView.
      * UserInterface/ResourceSidebarPanel.js:
      (WebInspector.ResourceSidebarPanel.prototype.showSourceCode): Use showContentViewForRepresentedObject
      which also accepts a cookie and handles creating the content view for us.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      679d978c
    • eric.carlson@apple.com's avatar
      Allow MediaSessionManager to restrict 'preload' behavior · 7cadf18b
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127297
      
      Reviewed by Jer Noble.
      
      Source/WebCore: 
      
      Tests: media/video-restricted-no-preload-auto.html
             media/video-restricted-no-preload-metadata.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::parseAttribute): Apply restrictions to preload attribute before
          passing to media engine.
      (WebCore::HTMLMediaElement::loadResource): Ditto.
      
      * html/HTMLMediaSession.cpp:
      (WebCore::HTMLMediaSession::effectivePreloadForElement): New, limit preload according to restrictions.
      * html/HTMLMediaSession.h:
      
      * platform/audio/MediaSessionManager.h:
      * platform/audio/ios/MediaSessionManagerIOS.mm:
      (WebCore::MediaSessionManageriOS::resetRestrictions): Limit preload to metadata only. Drive-by
          static deviceClass initialization cleanup.
      
      * testing/Internals.cpp:
      (WebCore::Internals::setMediaSessionRestrictions): Support MetadataPreloadingNotPermitted and
          AutoPreloadingNotPermitted.
      
      LayoutTests: 
      
      * media/video-restricted-no-preload-auto-expected.txt: Added.
      * media/video-restricted-no-preload-auto.html: Added.
      * media/video-restricted-no-preload-metadata-expected.txt: Added.
      * media/video-restricted-no-preload-metadata.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cadf18b
    • commit-queue@webkit.org's avatar
      Fix test expectations for css3/compositing/background-blend-mode-data-uri-svg-image.html · 5169263b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127298
      
      Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
      Reviewed by Mihnea Ovidenie.
      
      * platform/efl/TestExpectations:
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5169263b
    • ap@apple.com's avatar
      EWS should provide better information to Dashboard via JSON · 601275a7
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127265
      
      Reviewed by Ryosuke Niwa.
      
      * QueueStatusServer/app.yaml: Updated version.
      
      * QueueStatusServer/main.py:
      * QueueStatusServer/handlers/queuelengthjson.py:
      Added a way to cheaply get only the queue length, which is all the dashboard
      needs unless a popover is opened.
      
      * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
      that we will need. Changed some field names to be more meaningful. Fixed bot listing
      to understand that a bot can be reprurposed and used in a different queue.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      601275a7
    • ap@apple.com's avatar
      Make uploading results to EWS work despite robots.txt · 1d1d6804
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127296
      
      Reviewed by Ryosuke Niwa.
      
      * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
      checking robots.txt.
      
      * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
      Removed a comment saying that we would want to stop doing this. Not checking
      robots.txt is more efficient than checking it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d1d6804
    • akling@apple.com's avatar
      Let RenderImage construct its RenderImageResource. · dcf6c8f9
      akling@apple.com authored
      <https://webkit.org/b/127290>
      
      Everyone who creates a RenderImage immediately follows up with
      creating a RenderImageResource and assigning it to the image.
      
      Let the RenderImage constructor do this instead, and make the
      imageResource() accessors return references. This exposed a
      number of unnecessary null checks.
      
      Also modernized the touched code with std::unique_ptr.
      
      Reviewed by Antti Koivisto.
      
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::createElementRenderer):
      (WebCore::HTMLImageElement::didAttachRenderers):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::createElementRenderer):
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::didAttachRenderers):
      (WebCore::HTMLVideoElement::parseAttribute):
      * html/ImageInputType.cpp:
      (WebCore::ImageInputType::createInputRenderer):
      (WebCore::ImageInputType::attach):
      * loader/ImageLoader.cpp:
      (WebCore::ImageLoader::renderImageResource):
      * rendering/RenderElement.cpp:
      (WebCore::RenderElement::createFor):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::RenderImage):
      (WebCore::RenderImage::~RenderImage):
      (WebCore::RenderImage::styleDidChange):
      (WebCore::RenderImage::imageChanged):
      (WebCore::RenderImage::updateIntrinsicSizeIfNeeded):
      (WebCore::RenderImage::updateInnerContentRect):
      (WebCore::RenderImage::imageDimensionsChanged):
      (WebCore::RenderImage::notifyFinished):
      (WebCore::RenderImage::paintReplaced):
      (WebCore::RenderImage::paintIntoRect):
      (WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
      (WebCore::RenderImage::minimumReplacedHeight):
      (WebCore::RenderImage::computeIntrinsicRatioInformation):
      (WebCore::RenderImage::embeddedContentBox):
      * rendering/RenderImage.h:
      (WebCore::RenderImage::imageResource):
      (WebCore::RenderImage::cachedImage):
      * rendering/RenderImageResource.h:
      * rendering/RenderImageResourceStyleImage.h:
      * rendering/RenderMedia.cpp:
      (WebCore::RenderMedia::RenderMedia):
      * rendering/RenderSnapshottedPlugIn.cpp:
      (WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
      * rendering/RenderSnapshottedPlugIn.h:
      * rendering/RenderVideo.cpp:
      (WebCore::RenderVideo::calculateIntrinsicSize):
      * rendering/style/ContentData.cpp:
      (WebCore::ImageContentData::createContentRenderer):
      * rendering/svg/RenderSVGImage.cpp:
      (WebCore::RenderSVGImage::RenderSVGImage):
      (WebCore::RenderSVGImage::~RenderSVGImage):
      (WebCore::RenderSVGImage::updateImageViewport):
      (WebCore::RenderSVGImage::paint):
      (WebCore::RenderSVGImage::paintForeground):
      * rendering/svg/RenderSVGImage.h:
      * svg/SVGImageElement.cpp:
      (WebCore::SVGImageElement::didAttachRenderers):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcf6c8f9
    • andersca@apple.com's avatar
      Remove an unused member variable · 51fde83f
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127295
      
      Reviewed by Antti Koivisto.
      
      * wtf/MainThread.cpp:
      (WTF::FunctionWithContext::FunctionWithContext):
      (WTF::FunctionWithContext::operator == ):
      (WTF::dispatchFunctionsFromMainThread):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51fde83f
    • antti@apple.com's avatar
      Update overlay scrollbars in single pass · a9fcb2cf
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127289
      
      Reviewed by Anders Carlsson.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars):
              
          Multi-pass scrollbar resolution is only needed for traditional scrollbars. Overlay scrollbars don't affect layout.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9fcb2cf
    • andersca@apple.com's avatar
      Remove MutexTryLocker · f14652b0
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127294
      
      Reviewed by Antti Koivisto.
      
      MutexTryLocker has been replaced with std::unique_lock with std::try_to_lock everywhere now.
      
      * wtf/ThreadingPrimitives.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f14652b0
    • andersca@apple.com's avatar
      Convert GCThreadSharedData over to STL threading primitives · b9a38733
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127256
      
      Reviewed by Andreas Kling.
      
      * heap/GCThread.cpp:
      (JSC::GCThread::waitForNextPhase):
      (JSC::GCThread::gcThreadMain):
      * heap/GCThreadSharedData.cpp:
      (JSC::GCThreadSharedData::GCThreadSharedData):
      (JSC::GCThreadSharedData::~GCThreadSharedData):
      (JSC::GCThreadSharedData::startNextPhase):
      (JSC::GCThreadSharedData::endCurrentPhase):
      (JSC::GCThreadSharedData::didStartMarking):
      (JSC::GCThreadSharedData::didFinishMarking):
      * heap/GCThreadSharedData.h:
      * heap/SlotVisitor.cpp:
      (JSC::SlotVisitor::donateKnownParallel):
      (JSC::SlotVisitor::drainFromShared):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9a38733
    • jochen@chromium.org's avatar
      Never send a non-http(s) referrer header even with a referrer policy · b1560682
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127172
      
      Reviewed by Alexey Proskuryakov.
      
      This mirrors the code SecurityPolicy::shouldHideReferrer which is used
      for ReferrerPolicyDefault.
      
      No new tests, only affects an embedder that registers other schemes,
      e.g. chrome://
      
      * page/SecurityPolicy.cpp:
      (WebCore::SecurityPolicy::generateReferrerHeader):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1560682
    • commit-queue@webkit.org's avatar
      Source/WebCore: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend · 5553eb78
      commit-queue@webkit.org authored
      when having -webkit-background-blending applied. Turns out the problem was
      the blending parameter not being passed to WebCore::CrossfadeGeneratedImage::draw
      
      https://bugs.webkit.org/show_bug.cgi?id=126887
      
      Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
      Reviewed by Dirk Schulze.
      
      Test: css3/compositing/background-blend-mode-crossfade-image.html
      
      * platform/graphics/CrossfadeGeneratedImage.cpp:
      (WebCore::CrossfadeGeneratedImage::draw): set blendMode on context.
      
      LayoutTests: Reapply:
      [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
      when having -webkit-background-blending applied. Tests now use SVG rects, instead
      of circles.
      
      https://bugs.webkit.org/show_bug.cgi?id=126887
      Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
      Reviewed by Dirk Schulze.
      
      * css3/compositing/background-blend-mode-crossfade-image-expected.html:
      * css3/compositing/background-blend-mode-crossfade-image.html:
      * platform/efl/TestExpectations: Pass efl as blendMode is not implemented.
      * platform/mac/TestExpectations: Mark added test as ImageOnlyFailure due to slight differences between the result and the blending formula.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5553eb78
    • svillar@igalia.com's avatar
      [CSS Grid Layout] Simplify grid-columns-rows-get-set{-multiple}.html tests · f4409748
      svillar@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127055
      
      Reviewed by Andreas Kling.
      
      The testing code was refactored in 4 new functions that allow us
      to write each test case in a single line significantly reducing
      the amount of boilerplate and improving maintenance.
      
      * fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
      * fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
      * fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
      * fast/css-grid-layout/grid-columns-rows-get-set.html:
      * fast/css-grid-layout/named-grid-line-get-set-expected.txt:
      * fast/css-grid-layout/named-grid-line-get-set.html:
      * fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
      (testInherit):
      (testInitial):
      * fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
      * fast/css-grid-layout/resources/grid-definitions-parsing-utils.js: Added.
      (testGridDefinitionsValues):
      (testGridDefinitionsSetJSValues):
      (testNonGridDefinitionsSetJSValues):
      (checkGridDefinitionsSetJSValues): Helper function for testGridDefinitions*.
      (testGridDefinitionsSetBadJSValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4409748
    • svillar@igalia.com's avatar
      Null-pointer dereference in WebCore::CSSValue::isPrimitiveValue · 93a7060d
      svillar@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124769
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Test: fast/gradients/crash-on-no-position-separator.html
      
      The function parseFillPosition() may not return valid values for
      centerX and centerY if the input data is malformed. We need to
      check that we get a valid pair of positions before checking that
      they're actually valid primitive values in the assertions.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseRadialGradient):
      
      LayoutTests:
      
      Checks that invalid position declarations (like skiping the comma
      separator) do not make the engine crash.
      
      * fast/gradients/crash-on-no-position-separator-expected.txt: Added.
      * fast/gradients/crash-on-no-position-separator.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93a7060d
    • commit-queue@webkit.org's avatar
      Source/WebCore: Background-blend-mode doesn't work for an element with an · 567d6a9c
      commit-queue@webkit.org authored
      SVG image as background and border-style or padding set.
      The problem consisted in the drawing path using the default
      blending parameter at all times.
      https://bugs.webkit.org/show_bug.cgi?id=118894
      
      Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
      Reviewed by Dirk Schulze.
      
      Test: css3/compositing/background-blend-mode-data-uri-svg-image.html
      
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::drawPatternForContainer): Pass blendMode to Image::drawPattern.
      * svg/graphics/SVGImage.h: Add a blendMode parameter to drawPatternForContainer.
      * svg/graphics/SVGImageForContainer.cpp:
      (WebCore::SVGImageForContainer::drawPattern): Pass blendMode to drawPatternForContainer call.
      
      LayoutTests: Background-blend-mode doesn't work for an element with an
      SVG image as background and border-style or padding set.
      Tests now use rectangles instead of circles for SVGs.
      https://bugs.webkit.org/show_bug.cgi?id=118894
      
      Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
      Reviewed by Dirk Schulze.
      
      * css3/compositing/background-blend-mode-data-uri-svg-image-expected.html:
      * css3/compositing/background-blend-mode-data-uri-svg-image.html:
      * platform/efl/TestExpectations: pass tests for efl, blendMode is not implemented.
      * platform/mac/TestExpectations: marking test as ImageOnlyFailure due to slight pixel inconsistencies between the result and the formula.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      567d6a9c
    • zalan@apple.com's avatar
      Subpixel layout: setSimpleLineLayoutEnabled() produces different layout when... · 6a3975c1
      zalan@apple.com authored
      Subpixel layout: setSimpleLineLayoutEnabled() produces different layout when line position has CSS px fractions.
      https://bugs.webkit.org/show_bug.cgi?id=126892
      
      Reviewed by Antti Koivisto.
      
      SimpleLineLayout needs to copy normal linebox layout's subpixel rounding strategy to produce
      the same layout.
      
      Source/WebCore:
      
      Covered by existing tests.
      
      * rendering/SimpleLineLayoutFunctions.cpp:
      (WebCore::SimpleLineLayout::paintFlow):
      
      LayoutTests:
      
      * platform/mac/TestExpectations: Unskipping some SimpleLineLayout tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a3975c1
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 8af84ca5
      m.pakula@samsung.com authored
      Add test expectations for failing tests.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8af84ca5
    • commit-queue@webkit.org's avatar
      Col width is not honored when dynamically updated and it would make table narrower · 23564e41
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104711
      
      Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-01-20
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Increasing the table width by increasing the colgroup width
      was working but decreasing the table width by decreasing the
      colgroup width is not working.
      
      Test: fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html
      
      * rendering/RenderTableCol.cpp:
      (WebCore::RenderTableCol::styleDidChange):
      When colgroup width is defined table cell should adjust according to
      that. On decreasing colgroup width the cells maxPreferredLogicalWidth
      was still set to the earlier value. Setting the
      setPreferredLogicalWidthsDirty to true so that cells pref width is
      calculated again.
      
      LayoutTests:
      
      * fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt: Added.
      * fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html: Added.
      Added new test case to verify that table cell width decreases by
      decreasing the colgroup width.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23564e41
    • commit-queue@webkit.org's avatar
      [CoordinatedGraphics] Segmentation fault at CoordinatedGraphicsScene::clearImageBackingContents · 8897def0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125776
      
      Patch by Edit Balint <edbalint@inf.u-szeged.hu> on 2014-01-20
      Reviewed by Csaba Osztrogonác.
      
      Unexpected behavior occurs in some test cases which leads to segmentation fault.
      
      * platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
      (WebCore::CompositingCoordinator::removeImageBacking):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8897def0
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 409de739
      zandobersek@gmail.com authored
      Marked media/audio-concurrent-supported.html as flaky.
      Marked js/dom/string-replacement-outofmemory.html as slow on the release configuration as well.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      409de739
    • commit-queue@webkit.org's avatar
      Region based multicol: tall line causes taller multicol container than necessary · 883b01c5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122550
      
      Source/WebCore:
      
      Detect and report all column breaks, also when there's no pagination strut involved.
      
      This may end up becoming the overall smallest space shortage in some cases,
      so we need to report it, to avoid column height over-stretching.
      
      Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
      Reviewed by David Hyatt.
      
      Test: fast/multicol/newmulticol/balance10.html
      
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::adjustLinePositionForPagination):
      
      LayoutTests:
      
      Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
      Reviewed by David Hyatt.
      
      * fast/multicol/newmulticol/balance10-expected.txt: Added.
      * fast/multicol/newmulticol/balance10.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      883b01c5
    • zandobersek@gmail.com's avatar
      Unreviewed. Additional build fixes after r162276 and r163304. · 5e26e61e
      zandobersek@gmail.com authored
      * Platform/WorkQueue.h:
      * Platform/gtk/WorkQueueGtk.cpp:
      (WorkQueue::EventSource::EventSource):
      (WorkQueue::dispatchOnSource):
      (WorkQueue::dispatch):
      (WorkQueue::dispatchAfter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e26e61e
    • carlosgc@webkit.org's avatar
      [GLIB] GVariant floating references are not correctly handled by GRefPtr · ef8bd2da
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127246
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Do not adopt GVariant floating references, they will be converted
      to a full reference by GRefPtr.
      
      * platform/gtk/PasteboardHelper.cpp:
      (WebCore::PasteboardHelper::fillSelectionData):
      (WebCore::PasteboardHelper::fillDataObjectFromDropData):
      
      Source/WTF:
      
      GRefPtr should always use g_variant_ref_sink to deal with GVariant
      floating references. In case of full references,
      g_variant_ref_sink calls g_variant_ref, so it's safe to use it always.
      
      * wtf/gobject/GRefPtr.cpp:
      (WTF::refGPtr): Use g_variant_ref_sink().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef8bd2da
    • jinwoo7.song@samsung.com's avatar
      Use unsigned type for the size of CSSParserValueList · 4a1cd09f
      jinwoo7.song@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127211
      
      Reviewed by Andreas Kling.
      
      * css/CSSParser.cpp: Changed variable type from int to unsigned.
      (WebCore::CSSParser::parseValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a1cd09f
    • zandobersek@gmail.com's avatar
      Unreviewed GTK build fix after r162276. · ed30497c
      zandobersek@gmail.com authored
      Updating the WorkQueue implementation to use std::function and std::chrono.
      
      * Platform/WorkQueue.h:
      * Platform/gtk/WorkQueueGtk.cpp:
      (WorkQueue::dispatchOnSource):
      (WorkQueue::dispatch):
      (WorkQueue::dispatchAfter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed30497c
  2. 19 Jan, 2014 8 commits
    • ryuan.choi@samsung.com's avatar
      [EFL][WK1] Remove and refactor the APIs which use single and base keyword · bd915d30
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127214
      
      Reviewed by Gyuyoung Kim.
      
      Source/WebKit/efl:
      
      Since removed ewk_vie_tiled, we don't need to use single or base in the API name.
      Removed them and clean up the code.
      
      * ewk/ewk_view.cpp:
      (ewk_view_smart_set):
      (_ewk_view_smart_class_new):
      (ewk_view_add):
      * ewk/ewk_view.h:
      * ewk/ewk_view_private.h:
      Removed the class names and macro to distinguish single or tiled.
      * tests/UnitTestUtils/EWKTestView.cpp:
      (EWKUnitTests::EWKTestView::init):
      
      Tools:
      
      Followed the changes of API.
      
      * DumpRenderTree/efl/DumpRenderTreeView.cpp:
      (drtViewAdd):
      * EWebLauncher/main.c:
      (windowCreate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd915d30
    • eunmi15.lee@samsung.com's avatar
      [EFL][WK2] Add touch events option to MiniBrowser. · b87370e2
      eunmi15.lee@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127262
      
      Reviewed by Gyuyoung Kim.
      
      As a default, touch events are disabled and mouse events are enabled.
      If touch events option sets to true, touch events are enabled and mouse
      events are disabled.
      
      * MiniBrowser/efl/main.c:
      (window_create):
      (elm_main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b87370e2
    • jinwoo7.song@samsung.com's avatar
      Unreviewed debug build fix on EFL port after r162300. · c3ec1de9
      jinwoo7.song@samsung.com authored
      * Platform/efl/DispatchQueueWorkItemEfl.h:
      (TimerWorkItem::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3ec1de9
    • jinwoo7.song@samsung.com's avatar
      [EFL][WK2] build fix after r162276 · e9f650b3
      jinwoo7.song@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127259
      
      Reviewed by Anders Carlsson.
      
      * Platform/efl/DispatchQueueEfl.cpp:
      (DispatchQueue::performTimerWork):
      (DispatchQueue::getNextTimeOut):
      * Platform/efl/DispatchQueueWorkItemEfl.h:
      (WorkItem::create):
      (WorkItem::WorkItem):
      (TimerWorkItem::create):
      (TimerWorkItem::TimerWorkItem):
      * Platform/efl/WorkQueueEfl.cpp:
      (WorkQueue::dispatch):
      (WorkQueue::dispatchAfter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9f650b3
    • ljaehun.lim@samsung.com's avatar
      Unreviewed build fix after r162293 · fedbdbdb
      ljaehun.lim@samsung.com authored
      Fix debug build.
      
      [ 13%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o
      /source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp: In member function ‘void WebCore::HTMLTreeBuilder::processStartTagForInTable(WebCore::AtomicHTMLToken*)’:
      /source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: error: no match for ‘operator!’ in ‘!(WebCore::HTMLTreeBuilder::InsertionMode)12’
      /source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: candidate is:
      /source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: operator!(bool) <built-in>
      /source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note:   no known conversion for argument 1 from ‘WebCore::HTMLTreeBuilder::InsertionMode’ to ‘bool’
      make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o] Error 1
      make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2
      make: *** [all] Error 2
      
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processStartTagForInTable): Fix ASSERT.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fedbdbdb
    • zalan@apple.com's avatar
      Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb. · 4099471a
      zalan@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126080
      
      Reviewed by Sam Weinig.
      
      This changes the output of printing LayoutUnits to be in px but it also
      preserves the original LayoutUnit value.
      
      This will lead to lldb output like: (and it works even when subpixel is disabled)
      
      (const WebCore::LayoutRect) $0 = {
          m_location = { x = 2.25px (144), y = 1px (64)}
          m_size = { width = 13.75px (880), height = 20px (1280) }
      
      And gdb output like:
      
      m_frameRect = {
          m_location = LayoutPoint(0px (0), 0px(0)),
          m_size = LayoutSize(8px (512), 5px (320))
      }
      
      This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
      
      * gdb/webkit.py:
      (WebCoreLayoutUnitPrinter):
      (WebCoreLayoutUnitPrinter.__init__):
      (WebCoreLayoutUnitPrinter.to_string):
      (WebCoreLayoutSizePrinter):
      (WebCoreLayoutSizePrinter.__init__):
      (WebCoreLayoutSizePrinter.to_string):
      (WebCoreLayoutPointPrinter):
      (WebCoreLayoutPointPrinter.__init__):
      (WebCoreLayoutPointPrinter.to_string):
      (add_pretty_printers):
      * lldb/lldb_webkit.py:
      (__lldb_init_module):
      (WebCoreLayoutUnit_SummaryProvider):
      (WebCoreLayoutSize_SummaryProvider):
      (WebCoreLayoutPoint_SummaryProvider):
      (WebCoreLayoutUnitProvider):
      (WebCoreLayoutUnitProvider.__init__):
      (WebCoreLayoutUnitProvider.to_string):
      (WebCoreLayoutSizeProvider):
      (WebCoreLayoutSizeProvider.__init__):
      (WebCoreLayoutSizeProvider.get_width):
      (WebCoreLayoutSizeProvider.get_height):
      (WebCoreLayoutPointProvider):
      (WebCoreLayoutPointProvider.__init__):
      (WebCoreLayoutPointProvider.get_x):
      (WebCoreLayoutPointProvider.get_y):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4099471a
    • andersca@apple.com's avatar
      Stop using MutexTryLocker in WebCore · e6098d32
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127254
      
      Reviewed by Andreas Kling.
      
      Instead use std::mutex and std::unique_lock with the std::try_to_lock constructor.
      
      * Modules/webaudio/AudioBufferSourceNode.cpp:
      (WebCore::AudioBufferSourceNode::process):
      (WebCore::AudioBufferSourceNode::setBuffer):
      * Modules/webaudio/AudioBufferSourceNode.h:
      * Modules/webaudio/AudioParamTimeline.cpp:
      (WebCore::AudioParamTimeline::insertEvent):
      (WebCore::AudioParamTimeline::cancelScheduledValues):
      (WebCore::AudioParamTimeline::valueForContextTime):
      (WebCore::AudioParamTimeline::valuesForTimeRange):
      (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
      * Modules/webaudio/AudioParamTimeline.h:
      * Modules/webaudio/ConvolverNode.cpp:
      (WebCore::ConvolverNode::process):
      (WebCore::ConvolverNode::reset):
      (WebCore::ConvolverNode::setBuffer):
      * Modules/webaudio/ConvolverNode.h:
      * Modules/webaudio/MediaElementAudioSourceNode.cpp:
      (WebCore::MediaElementAudioSourceNode::setFormat):
      (WebCore::MediaElementAudioSourceNode::process):
      (WebCore::MediaElementAudioSourceNode::lock):
      (WebCore::MediaElementAudioSourceNode::unlock):
      * Modules/webaudio/MediaElementAudioSourceNode.h:
      * Modules/webaudio/MediaStreamAudioSourceNode.cpp:
      (WebCore::MediaStreamAudioSourceNode::setFormat):
      (WebCore::MediaStreamAudioSourceNode::process):
      * Modules/webaudio/MediaStreamAudioSourceNode.h:
      * Modules/webaudio/OscillatorNode.cpp:
      (WebCore::OscillatorNode::process):
      (WebCore::OscillatorNode::setPeriodicWave):
      * Modules/webaudio/OscillatorNode.h:
      * Modules/webaudio/PannerNode.cpp:
      (WebCore::PannerNode::process):
      (WebCore::PannerNode::setPanningModel):
      * Modules/webaudio/PannerNode.h:
      * Modules/webaudio/WaveShaperProcessor.cpp:
      (WebCore::WaveShaperProcessor::setCurve):
      (WebCore::WaveShaperProcessor::setOversample):
      (WebCore::WaveShaperProcessor::process):
      * Modules/webaudio/WaveShaperProcessor.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6098d32
    • berto@igalia.com's avatar
      Does not build with SVG disabled · 0ce8cf93
      berto@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127248
      
      Reviewed by Sam Weinig.
      
      Add missing #if ENABLE(SVG) guard.
      
      * dom/ElementData.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ce8cf93