1. 13 Aug, 2010 30 commits
    • steveblock@google.com's avatar
      2010-08-13 Steve Block <steveblock@google.com> · 52ca7c02
      steveblock@google.com authored
              Reviewed by Alexey Proskuryakov.
      
              Geolocation activity started after frame has been disconnected can cause crash
              https://bugs.webkit.org/show_bug.cgi?id=39879
      
              New requests started after the Frame has been disconnected are ignored. We do
              not invoke the error callback as this would allow buggy or malicious pages to
              hose the CPU. Such a page could hold a reference to a Geolocation object from
              a since closed Page and register new requests from the error callback to
              create an infinite loop.
      
              Tests: fast/dom/Geolocation/disconnected-frame-already.html
      
              * page/Geolocation.cpp:
      2010-08-13  Steve Block  <steveblock@google.com>
      
              Reviewed by Alexey Proskuryakov.
      
              Geolocation activity started after frame has been disconnected can cause crash
              https://bugs.webkit.org/show_bug.cgi?id=39879
      
              Added new tests to GTK skipped list.
      
              * fast/dom/Geolocation/disconnected-frame-already.html: Added.
              * fast/dom/Geolocation/disconnected-frame-already-expected.txt: Added.
              * fast/dom/Geolocation/script-tests/disconnected-frame-already.js: Added.
              * fast/dom/Geolocation/resources/disconnected-frame-already-inner1.html: Added.
              * fast/dom/Geolocation/resources/disconnected-frame-already-inner2.html: Added.
              * platform/gtk/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52ca7c02
    • alex@webkit.org's avatar
      2010-08-13 Alejandro G. Castro <alex@igalia.com> · fe170308
      alex@webkit.org authored
              Reviewed by Xan Lopez.
      
              We have to add the ACLOCAL_FLAGS in the env to the autogen.sh
              ACLOCAL_FLAGS variable in order to honor the value already
              defined, jhbuild uses it to pass parameters.
      
              * autogen.sh:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe170308
    • commit-queue@webkit.org's avatar
      2010-08-13 Satish Sampath <satish@chromium.org> · 27a9e297
      commit-queue@webkit.org authored
              Reviewed by Jeremy Orlow.
      
              Support for multiple speech enabled elements in same page.
              https://bugs.webkit.org/show_bug.cgi?id=43922
      
              * page/SpeechInput.cpp: Generates request ids as necessary when each speech enabled input element gets
              created/destroyed and multiplexes the listener callbacks to the appropriate input element based on the request id.
              (WebCore::SpeechInput::SpeechInput):
              (WebCore::SpeechInput::~SpeechInput):
              (WebCore::SpeechInput::registerListener):
              (WebCore::SpeechInput::unregisterListener):
              (WebCore::SpeechInput::didCompleteRecording):
              (WebCore::SpeechInput::didCompleteRecognition):
              (WebCore::SpeechInput::setRecognitionResult):
              (WebCore::SpeechInput::startRecognition):
              (WebCore::SpeechInput::stopRecording):
              (WebCore::SpeechInput::cancelRecognition):
              * page/SpeechInput.h:
              * page/SpeechInputClient.h: Now requires a one time set for the WebCore::SpeechInputListener and
              takes in a 'requestId' for all calls.
              * page/SpeechInputListener.h: Now returns the above mentioned requestId in all the listener callbacks for
              identifying which input element the event goes to.
              * platform/mock/SpeechInputClientMock.cpp:
              (WebCore::SpeechInputClientMock::SpeechInputClientMock):
              (WebCore::SpeechInputClientMock::setListener):
              (WebCore::SpeechInputClientMock::startRecognition):
              (WebCore::SpeechInputClientMock::stopRecording):
              (WebCore::SpeechInputClientMock::cancelRecognition):
              (WebCore::SpeechInputClientMock::timerFired):
              * platform/mock/SpeechInputClientMock.h:
              * rendering/TextControlInnerElements.cpp:
              (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
              (WebCore::InputFieldSpeechButtonElement::~InputFieldSpeechButtonElement):
              (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
              (WebCore::InputFieldSpeechButtonElement::speechInput):
              (WebCore::InputFieldSpeechButtonElement::didCompleteRecording):
              (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition):
              (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
              * rendering/TextControlInnerElements.h:
      2010-08-13  Satish Sampath  <satish@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              Support for multiple speech enabled elements in same page.
              https://bugs.webkit.org/show_bug.cgi?id=43922
      
              * public/WebSpeechInputController.h: Bubbles up the requestId given by webcore to the embedder.
              (WebKit::WebSpeechInputController::startRecognition):
              (WebKit::WebSpeechInputController::cancelRecognition):
              (WebKit::WebSpeechInputController::stopRecording):
              * public/WebSpeechInputListener.h: Passes down the requestId given by embedder to webcore.
              (WebKit::WebSpeechInputListener::didCompleteRecording):
              (WebKit::WebSpeechInputListener::setRecognitionResult):
              (WebKit::WebSpeechInputListener::didCompleteRecognition):
              * src/SpeechInputClientImpl.cpp:
              (WebKit::SpeechInputClientImpl::setListener):
              (WebKit::SpeechInputClientImpl::startRecognition):
              (WebKit::SpeechInputClientImpl::stopRecording):
              (WebKit::SpeechInputClientImpl::cancelRecognition):
              (WebKit::SpeechInputClientImpl::didCompleteRecording):
              (WebKit::SpeechInputClientImpl::didCompleteRecognition):
              (WebKit::SpeechInputClientImpl::setRecognitionResult):
              * src/SpeechInputClientImpl.h:
              * src/WebSpeechInputControllerMockImpl.cpp:
              (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl):
              (WebKit::WebSpeechInputControllerMockImpl::~WebSpeechInputControllerMockImpl):
              (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecording):
              (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecognition):
              (WebKit::WebSpeechInputControllerMockImpl::setRecognitionResult):
              (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
              (WebKit::WebSpeechInputControllerMockImpl::cancelRecognition):
              (WebKit::WebSpeechInputControllerMockImpl::stopRecording):
              * src/WebSpeechInputControllerMockImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27a9e297
    • ariya@webkit.org's avatar
      2010-08-13 Ariya Hidayat <ariya@sencha.com> · 5e845d41
      ariya@webkit.org authored
              Rubber-stamped by Simon Hausmann.
      
              [Qt] Outdated pixel test reference for basic-shadows.html
              https://bugs.webkit.org/show_bug.cgi?id=43952
      
              * platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
              * platform/qt/fast/box-shadow/basic-shadows-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e845d41
    • steveblock@google.com's avatar
      2010-08-13 Steve Block <steveblock@google.com> · 61cb516b
      steveblock@google.com authored
              Reviewed by Alexey Proskuryakov.
      
              Need a LayoutTest to check that pages using Geolocation are not put in the page cache
              https://bugs.webkit.org/show_bug.cgi?id=43957
      
              * fast/dom/Geolocation/no-page-cache-expected.txt: Added.
              * fast/dom/Geolocation/no-page-cache.html: Added.
              * fast/dom/Geolocation/resources/cached-page-1.html: Added.
              * fast/dom/Geolocation/resources/cached-page-2.html: Added.
              * fast/dom/Geolocation/script-tests/no-page-cache.js: Added.
              (reportPageOneOnload):
              * platform/gtk/Skipped: Added new test to GTK skipped list
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61cb516b
    • eric.carlson@apple.com's avatar
      2010-08-13 Eric Carlson <eric.carlson@apple.com> · c48c5bc4
      eric.carlson@apple.com authored
              Reviewed by David Kilzer.
      
              HTMLMediaElement::prepareForLoad should cancel current plug-in proxy media player
              https://bugs.webkit.org/show_bug.cgi?id=43923
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::prepareForLoad): Tell mediaPlayer to cancel the current load
              if it already exists.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c48c5bc4
    • senorblanco@chromium.org's avatar
      2010-08-12 Stephen White <senorblanco@chromium.org> · d7e5fff3
      senorblanco@chromium.org authored
              Reviewed by David Levin.
      
              [CHROMIUM] Use the BGRA format for canvas 2D accel upload and readbacks.
              https://bugs.webkit.org/show_bug.cgi?id=43804
      
              Use the BGRA format from GraphicsContext3D, if supported.  Also keep a
              texture around for uploads, rather than re-creating it each time.
      
              Covered by many layout tests (once we're running them).
      
              * platform/graphics/chromium/GLES2Texture.cpp:
              (WebCore::convertFormat):
              Move convertFormat() ahead of texture creation, so we can check for
              BGRA support.
              (WebCore::GLES2Texture::create):
              Use convertFormat() to determine the correct format and types to use;
              use the returned format also for internalFormat, since GLES2 insists
              they match.
              * platform/graphics/skia/PlatformContextSkia.cpp:
              (WebCore::PlatformContextSkia::setGraphicsContext3D):
              Clear the upload texture when a new context is set.
              (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
              Use m_uploadTexture instead of creating a new one each time.
              (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
              When the context supports it, use the BGRA format for readbacks
              instead of swizzling.
              * platform/graphics/skia/PlatformContextSkia.h:
              Add m_uploadTexture for consecutive uploads.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7e5fff3
    • hausmann@webkit.org's avatar
      [Qt] Introduce Maemo6 for mobile features · 202ce576
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=43969
      
      Reviewed by Ariya Hidayat.
      
      * WebKit.pri: Use maemo6 where we also use maemo5.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      202ce576
    • hausmann@webkit.org's avatar
      [Qt] Clean up mobile feature useage · 0c19b5e1
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=43968
      
      Reviewed by Ariya Hidayat.
      
      .:
      
      * WebKit.pri: Set feature defaults here for some Nokia specific mobile platforms
      
      WebCore:
      
      * WebCore.pro: Replaced use of Nokia specific platform scopes with concrete
      feature names.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c19b5e1
    • pfeldman@chromium.org's avatar
      2010-08-13 Pavel Feldman <pfeldman@chromium.org> · 7fab097c
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: rename InspectorValue::push and set to
              push{Value|Object|Array} and set{...}.
              https://bugs.webkit.org/show_bug.cgi?id=43966
      
              * bindings/js/ScriptProfile.cpp:
              (WebCore::buildInspectorObjectFor):
              * bindings/js/ScriptValue.cpp:
              (WebCore::jsToInspectorValue):
              * bindings/v8/ScriptCallStack.cpp:
              (WebCore::ScriptCallStack::stackTrace):
              * bindings/v8/ScriptProfile.cpp:
              (WebCore::buildInspectorObjectFor):
              * bindings/v8/ScriptValue.cpp:
              (WebCore::v8ToInspectorValue):
              * inspector/CodeGeneratorInspector.pm:
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::addToFrontend):
              * inspector/Inspector.idl:
              * inspector/InspectorApplicationCacheAgent.cpp:
              (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
              (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::buildArrayForCookies):
              (WebCore::InspectorController::getDOMStorageEntries):
              (WebCore::InspectorController::getProfileHeaders):
              (WebCore::InspectorController::getProfile):
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::getEventListenersForNode):
              (WebCore::InspectorDOMAgent::buildObjectForNode):
              (WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
              (WebCore::InspectorDOMAgent::getStyles):
              (WebCore::InspectorDOMAgent::getAllStyles):
              (WebCore::InspectorDOMAgent::getRuleRanges):
              (WebCore::InspectorDOMAgent::buildObjectForAttributeStyles):
              (WebCore::InspectorDOMAgent::buildArrayForCSSRules):
              (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
              (WebCore::InspectorDOMAgent::buildObjectForStyle):
              (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties):
              (WebCore::InspectorDOMAgent::buildArrayForDisabledStyleProperties):
              (WebCore::InspectorDOMAgent::buildObjectForStyleSheet):
              (WebCore::InspectorDOMAgent::buildObjectForRule):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::saveBreakpoints):
              * inspector/InspectorResource.cpp:
              (WebCore::InspectorResource::updateScriptObject):
              * inspector/InspectorStorageAgent.cpp:
              (WebCore::):
              (WebCore::InspectorStorageAgent::executeSQL):
              * inspector/InspectorTimelineAgent.cpp:
              (WebCore::InspectorTimelineAgent::pushGCEventRecords):
              (WebCore::InspectorTimelineAgent::didInstallTimer):
              (WebCore::InspectorTimelineAgent::didRemoveTimer):
              (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
              (WebCore::InspectorTimelineAgent::willSendResourceRequest):
              (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
              (WebCore::InspectorTimelineAgent::didMarkTimeline):
              (WebCore::InspectorTimelineAgent::addRecordToTimeline):
              (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
              * inspector/InspectorValues.cpp:
              (WebCore::):
              (WebCore::InspectorValue::asValue):
              (WebCore::InspectorValue::asObject):
              (WebCore::InspectorValue::asArray):
              (WebCore::InspectorObject::asObject):
              (WebCore::InspectorArray::asArray):
              * inspector/InspectorValues.h:
              (WebCore::InspectorObject::setBool):
              (WebCore::InspectorObject::setNumber):
              (WebCore::InspectorObject::setString):
              (WebCore::InspectorObject::setValue):
              (WebCore::InspectorObject::setObject):
              (WebCore::InspectorObject::setArray):
              (WebCore::InspectorArray::pushValue):
              (WebCore::InspectorArray::pushObject):
              (WebCore::InspectorArray::pushArray):
              * inspector/ScriptBreakpoint.cpp:
              (WebCore::ScriptBreakpoint::inspectorObjectFromSourceBreakpoints):
              * inspector/TimelineRecordFactory.cpp:
              (WebCore::TimelineRecordFactory::createGenericRecord):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fab097c
    • commit-queue@webkit.org's avatar
      2010-08-13 Patrick Gansterer <paroga@paroga.com> · 28b03451
      commit-queue@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              [CMake] Cleanup generator code.
              https://bugs.webkit.org/show_bug.cgi?id=39164
      
              * cmake/WebKitGenerators.cmake:
              * cmake/WebKitMacros.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28b03451
    • japhet@chromium.org's avatar
      2010-08-13 Nate Chapin <japhet@chromium.org> · 2ac8d3d5
      japhet@chromium.org authored
              Unreviewed, Chromium test_expectations.txt updates + a rebaseline
      
              * platform/chromium-linux/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ac8d3d5
    • commit-queue@webkit.org's avatar
      2010-08-13 Sheriff Bot <webkit.review.bot@gmail.com> · be956fc5
      commit-queue@webkit.org authored
              Unreviewed, rolling out r65204.
              http://trac.webkit.org/changeset/65204
              https://bugs.webkit.org/show_bug.cgi?id=43965
      
              Caused a lot of test crashes in Chromium (Requested by yutak
              on #webkit).
      
              * platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Removed.
              * platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Removed.
      2010-08-13  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r65204.
              http://trac.webkit.org/changeset/65204
              https://bugs.webkit.org/show_bug.cgi?id=43965
      
              Caused a lot of test crashes in Chromium (Requested by yutak
              on #webkit).
      
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::isInputImage):
              (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
              * dom/InputElement.h:
              * html/HTMLInputElement.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be956fc5
    • antonm@chromium.org's avatar
      2010-08-13 Anton Muhin <antonm@chromium.org> · 07d9c24f
      antonm@chromium.org authored
              Reviewed by Nate Chapin.
      
              Reapplying http://trac.webkit.org/changeset/65284 after fixed include.
      
              [v8] Create callbacks for named access of elements from document object on fly.
              https://bugs.webkit.org/show_bug.cgi?id=43725
      
              That should speed up access to methods on document as there is no need to
              consult with interceptor before invoking the method.
      
              This reapplies http://trac.webkit.org/changeset/60670 reverted with
              http://trac.webkit.org/changeset/63845.  The main difference is in treatment
              of removed named elements: we don't remove an accessor any more, but leave it.
              Therefore any accessor should be able to treat the case when there is no
              expando property.
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::namedItemAdded):
              (WebCore::ScriptController::namedItemRemoved):
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::checkDocumentWrapper):
              (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
              (WebCore::getter):
              (WebCore::V8DOMWindowShell::namedItemAdded):
              (WebCore::V8DOMWindowShell::namedItemRemoved):
              * bindings/v8/V8DOMWindowShell.h:
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::instantiateV8Object):
              * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
              (WebCore::V8HTMLDocument::WrapInShadowObject):
              (WebCore::V8HTMLDocument::GetNamedProperty):
              (WebCore::V8HTMLDocument::allAccessorSetter):
              (WebCore::toV8):
              * html/HTMLDocument.cpp:
              (WebCore::HTMLDocument::removeItemFromMap):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07d9c24f
    • yurys@chromium.org's avatar
      2010-08-13 Yury Semikhatsky <yurys@chromium.org> · d0936bf5
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: DRT sometimes crashes on debugger tests
              https://bugs.webkit.org/show_bug.cgi?id=43964
              notifyDone() should be called only when debugger already resumed all active DOM objects,
              otherwise we might accidentally call setTimeout in the inspected page and create
              a new active DOM object while their set should remain unchanged when script execution
              is paused.
      
              * inspector/debugger-cyclic-ref.html:
              * inspector/debugger-eval-while-paused.html:
              * inspector/debugger-no-nested-pause.html:
              * inspector/debugger-pause-in-eval-script.html:
              * inspector/debugger-pause-on-debugger-statement.html:
              * inspector/debugger-proto-property.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0936bf5
    • pfeldman@chromium.org's avatar
      2010-08-13 Pavel Feldman <pfeldman@chromium.org> · 157e3518
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: remove openInInspectorWindow and evaluateAndStringify from InjectedScript.
              https://bugs.webkit.org/show_bug.cgi?id=43854
      
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::openInInspectedWindow):
              * inspector/InspectorController.h:
              * inspector/front-end/ExtensionServer.js:
              (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage.callback):
              (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
              * inspector/front-end/InjectedScript.js:
              (injectedScriptConstructor):
              * inspector/front-end/InjectedScriptAccess.js:
              * inspector/front-end/InspectorBackendStub.js:
              (WebInspector.InspectorBackendStub):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      157e3518
    • ukai@chromium.org's avatar
      2010-08-13 Fumitoshi Ukai <ukai@chromium.org> · a86c8ee0
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              flaky websocket/tests/frame-length-overflow.html
              https://bugs.webkit.org/show_bug.cgi?id=43902
      
              Add m_shouldDiscardReceivedData flag to indicate it will no longer
              receive data from network.
      
              * websockets/WebSocketChannel.cpp:
              (WebCore::WebSocketChannel::WebSocketChannel):
              (WebCore::WebSocketChannel::didReceiveData):
              (WebCore::WebSocketChannel::didFail):
              (WebCore::WebSocketChannel::processBuffer):
              - when frame length overflows, we couldn't process data any more.
                clear buffer and mark m_shouldDiscardReceivedData true to make sure
                it doesn't process the same buffer again.
              * websockets/WebSocketChannel.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a86c8ee0
    • krit@webkit.org's avatar
      2010-08-13 Dirk Schulze <krit@webkit.org> · 63d61060
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              Use SVGPathByteStream to animate SVGPath
              https://bugs.webkit.org/show_bug.cgi?id=43929
      
              Use SVGPathByteStream to perform animations of Paths. SVGPathBlender blends
              the starting point to the end point according to the current progress value.
              Cleanup SVGPathSegList, by removing the unnecessary legacy blending code.
      
              No new tests because no functional changes.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * svg/SVGAllInOne.cpp:
              * svg/SVGAnimateElement.cpp:
              (WebCore::SVGAnimateElement::SVGAnimateElement):
              (WebCore::SVGAnimateElement::calculateAnimatedValue):
              (WebCore::SVGAnimateElement::calculateFromAndToValues):
              (WebCore::SVGAnimateElement::resetToBaseValue):
              (WebCore::SVGAnimateElement::applyResultsToTarget):
              * svg/SVGAnimateElement.h:
              * svg/SVGPathBlender.cpp: Added.
              (WebCore::SVGPathBlender::SVGPathBlender):
              (WebCore::SVGPathBlender::~SVGPathBlender):
              (WebCore::SVGPathBlender::blendAnimatedFloat):
              (WebCore::SVGPathBlender::blendAnimatedFloatPoint):
              (WebCore::SVGPathBlender::blendMoveToSegment):
              (WebCore::SVGPathBlender::blendLineToSegment):
              (WebCore::SVGPathBlender::blendLineToHorizontalSegment):
              (WebCore::SVGPathBlender::blendLineToVerticalSegment):
              (WebCore::SVGPathBlender::blendCurveToCubicSegment):
              (WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment):
              (WebCore::SVGPathBlender::blendCurveToQuadraticSegment):
              (WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment):
              (WebCore::SVGPathBlender::blendArcToSegment):
              (WebCore::SVGPathBlender::blendAnimatedPath):
              (WebCore::SVGPathBlender::cleanup):
              * svg/SVGPathBlender.h: Added.
              * svg/SVGPathParserFactory.cpp:
              (WebCore::globalSVGPathBlender):
              (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
              * svg/SVGPathParserFactory.h:
              * svg/SVGPathSegList.cpp:
              (WebCore::SVGPathSegList::getPathSegAtLength):
              * svg/SVGPathSegList.h:
              (WebCore::SVGPathSegList::create):
              * svg/SVGPointList.cpp:
              (WebCore::adjustAnimatedValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63d61060
    • loki@webkit.org's avatar
      Avoid increasing required alignment of target type warning on ARM · 7534a3fa
      loki@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=38045
      
      Reviewed by Gavin Barraclough.
      
      The reinterpret_cast<Type1*>([pointer to Type2]) expressions - where
      sizeof(Type1) > sizeof(Type2) - cause the following warning on ARM:
      increases required alignment of target type warnings.
      Casting the type of [pointer to Type2] object to void* bypasses the
      warning.
      
      * JavaScriptCore/assembler/ARMAssembler.cpp:
      (JSC::ARMAssembler::executableCopy):
      * JavaScriptCore/assembler/AssemblerBuffer.h:
      (JSC::AssemblerBuffer::putShortUnchecked):
      (JSC::AssemblerBuffer::putIntUnchecked):
      (JSC::AssemblerBuffer::putInt64Unchecked):
      * JavaScriptCore/interpreter/RegisterFile.h:
      (JSC::RegisterFile::RegisterFile):
      (JSC::RegisterFile::grow):
      * JavaScriptCore/jit/JITStubs.cpp:
      * JavaScriptCore/pcre/pcre_compile.cpp:
      (jsRegExpCompile):
      * JavaScriptCore/runtime/JSArray.cpp:
      (JSC::JSArray::putSlowCase):
      (JSC::JSArray::increaseVectorLength):
      (JSC::JSArray::increaseVectorPrefixLength):
      (JSC::JSArray::shiftCount):
      (JSC::JSArray::unshiftCount):
      * JavaScriptCore/wtf/FastMalloc.cpp:
      (WTF::PageHeapAllocator::New):
      (WTF::TCMalloc_Central_FreeList::Populate):
      * wtf/MD5.cpp:
      (WTF::reverseBytes):
      (WTF::MD5::addBytes):
      (WTF::MD5::checksum):
      * JavaScriptCore/wtf/StdLibExtras.h:
      (isPointerTypeAlignmentOkay):
      (reinterpret_cast_ptr):
      * JavaScriptCore/wtf/Vector.h:
      (WTF::VectorBuffer::inlineBuffer):
      * JavaScriptCore/wtf/qt/StringQt.cpp:
      (WTF::String::String):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7534a3fa
    • zimmermann@webkit.org's avatar
      2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com> · cff3134e
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Window size changes + resources on absolute sized content leads to pixelation
              https://bugs.webkit.org/show_bug.cgi?id=43921
      
              Avoid pixelation when using resources on absolute sized objects. Be sure to invalidate the used resources if window size changes.
              Otherwhise masks etc. will be scaled up and pixelate. As nice side-effect, this fixes run-webkit-tests --singly svg/W3C-SVG-1.1, which
              used to produce wrong results for the gradient tests, as the window size change from 800x600 for 480x360 (svg/W3C-SVG-1.1 specific DRT quirk)
              didn't invalidate the resources.
      
              Renamed invalidateClient -> removeClientFromCache and invalidateClients -> removeAllClientsFromCache.
              Add a boolean "markForInvalidation" parameter, that controls wheter the clients should be marked for repaint/boundaries invalidation/layout
              or wheter we only want to notify the parents that the resource changed, to avoid doing unncessary work in SVGRenderSupport::layoutChildren.
      
              Test: svg/custom/absolute-sized-content-with-resources.xhtml
      
              * rendering/RenderSVGGradientStop.cpp:
              (WebCore::RenderSVGGradientStop::styleDidChange): Don't do anything for StyleDifferenceEqual.
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::imageChanged):
              * rendering/RenderSVGResource.cpp:
              (WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
              * rendering/RenderSVGResource.h:
              * rendering/RenderSVGResourceClipper.cpp:
              (WebCore::RenderSVGResourceClipper::removeAllClientsFromCache):
              (WebCore::RenderSVGResourceClipper::removeClientFromCache):
              * rendering/RenderSVGResourceClipper.h:
              * rendering/RenderSVGResourceContainer.cpp:
              (WebCore::RenderSVGResourceContainer::layout):
              (WebCore::RenderSVGResourceContainer::idChanged):
              (WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
              (WebCore::RenderSVGResourceContainer::markClientForInvalidation):
              * rendering/RenderSVGResourceContainer.h:
              (WebCore::RenderSVGResourceContainer::):
              * rendering/RenderSVGResourceFilter.cpp:
              (WebCore::RenderSVGResourceFilter::removeAllClientsFromCache):
              (WebCore::RenderSVGResourceFilter::removeClientFromCache):
              (WebCore::RenderSVGResourceFilter::postApplyResource):
              * rendering/RenderSVGResourceFilter.h:
              * rendering/RenderSVGResourceGradient.cpp:
              (WebCore::RenderSVGResourceGradient::removeAllClientsFromCache):
              (WebCore::RenderSVGResourceGradient::removeClientFromCache):
              (WebCore::RenderSVGResourceGradient::applyResource):
              * rendering/RenderSVGResourceGradient.h:
              * rendering/RenderSVGResourceMarker.cpp:
              (WebCore::RenderSVGResourceMarker::layout):
              (WebCore::RenderSVGResourceMarker::removeAllClientsFromCache):
              (WebCore::RenderSVGResourceMarker::removeClientFromCache):
              * rendering/RenderSVGResourceMarker.h:
              * rendering/RenderSVGResourceMasker.cpp:
              (WebCore::RenderSVGResourceMasker::removeAllClientsFromCache):
              (WebCore::RenderSVGResourceMasker::removeClientFromCache):
              * rendering/RenderSVGResourceMasker.h:
              * rendering/RenderSVGResourcePattern.cpp:
              (WebCore::RenderSVGResourcePattern::removeAllClientsFromCache):
              (WebCore::RenderSVGResourcePattern::removeClientFromCache):
              (WebCore::RenderSVGResourcePattern::applyResource):
              * rendering/RenderSVGResourcePattern.h:
              * rendering/RenderSVGResourceSolidColor.h:
              (WebCore::RenderSVGResourceSolidColor::removeAllClientsFromCache):
              (WebCore::RenderSVGResourceSolidColor::removeClientFromCache):
              * rendering/SVGRenderSupport.cpp:
              (WebCore::invalidateResourcesOfChildren): Add new helper funtion recursively invalidating resources of a sub render tree.
              (WebCore::SVGRenderSupport::layoutChildren): Keep track of all objects that didn't need layout, as we still have to invalidate their resources, if window size changes.
              * rendering/SVGResources.cpp:
              (WebCore::SVGResources::removeClientFromCache):
              (WebCore::SVGResources::resourceDestroyed):
              * rendering/SVGResources.h:
              * rendering/SVGResourcesCache.cpp:
              (WebCore::SVGResourcesCache::clientLayoutChanged):
      
      2010-08-12  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Dirk Schulze.
      
              Window size changes + resources on absolute sized content leads to pixelation
              https://bugs.webkit.org/show_bug.cgi?id=43921
      
              * platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum: Added.
              * platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
              * platform/mac/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
              * svg/custom/absolute-sized-content-with-resources.xhtml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cff3134e
    • pfeldman@chromium.org's avatar
      2010-08-13 Pavel Feldman <pfeldman@chromium.org> · 75e45425
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Chromium DevTools: brush up test expectations.
              https://bugs.webkit.org/show_bug.cgi?id=43959
      
              * platform/chromium/inspector/console-dir-expected.txt: Added.
              * platform/chromium/inspector/console-format-expected.txt: Added.
              * platform/chromium/inspector/timeline-event-dispatch-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-event-dispatch-expected.txt.
              * platform/chromium/inspector/timeline-mark-timeline-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-mark-timeline-expected.txt.
              * platform/chromium/inspector/timeline-network-resource-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-network-resource-expected.txt.
              * platform/chromium/inspector/timeline-paint-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-paint-expected.txt.
              * platform/chromium/inspector/timeline-parse-html-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-parse-html-expected.txt.
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75e45425
    • commit-queue@webkit.org's avatar
      2010-08-13 Kenichi Ishibashi <bashi@google.com> · 4b9d90c0
      commit-queue@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              Add test_expectations.txt syntax checker to check-webkit-style.
              https://bugs.webkit.org/show_bug.cgi?id=43899
      
              Just utilizing layout_tests/layout_package/test_expectations.py for checking
              the syntax of test_expectations.txt.
              This change also moves tab checking class from style/checkers/text.py to
              style/checkers/common.py for sharing code.
      
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
              * Scripts/webkitpy/style/checker.py:
              * Scripts/webkitpy/style/checkers/common.py:
              * Scripts/webkitpy/style/checkers/common_unittest.py:
              * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
              * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
              * Scripts/webkitpy/style/checkers/text.py:
              * Scripts/webkitpy/style_references.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b9d90c0
    • pfeldman@chromium.org's avatar
      2010-08-13 Pavel Feldman <pfeldman@chromium.org> · 675ae0f4
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Chromium DevTools: [CRASH] Autocomplete on arrays causes crashes.
              https://bugs.webkit.org/show_bug.cgi?id=43955
      
              * bindings/v8/ScriptValue.cpp:
              (WebCore::v8ToInspectorValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      675ae0f4
    • commit-queue@webkit.org's avatar
      2010-08-13 Patrick Gansterer <paroga@paroga.com> · 29ab9d2f
      commit-queue@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              [CMake] Add missing FIND_PACKAGE(Gperf)
              https://bugs.webkit.org/show_bug.cgi?id=43937
      
              * CMakeLists.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29ab9d2f
    • barraclough@apple.com's avatar
      Unify UString::UTF8String() & String::utf8() methods, · 3158a387
      barraclough@apple.com authored
      remove UString::cost() & make atArrayIndex a free function.
      
      Reviewed by Sam Weinig
      
      JavaScriptCore: 
      
      * JavaScriptCore.exp:
      * bytecode/CodeBlock.cpp:
      (JSC::constantName):
      (JSC::idName):
      (JSC::CodeBlock::registerName):
      (JSC::regexpName):
      (JSC::printGlobalResolveInfo):
      (JSC::printStructureStubInfo):
      (JSC::CodeBlock::printStructure):
      (JSC::CodeBlock::printStructures):
      * jsc.cpp:
      (functionPrint):
      (functionDebug):
      (runInteractive):
      (fillBufferWithContentsOfFile):
      * pcre/pcre_exec.cpp:
      (Histogram::~Histogram):
      * profiler/CallIdentifier.h:
      (JSC::CallIdentifier::c_str):
      * profiler/Profile.cpp:
      (JSC::Profile::debugPrintDataSampleStyle):
      * profiler/ProfileGenerator.cpp:
      (JSC::ProfileGenerator::willExecute):
      (JSC::ProfileGenerator::didExecute):
      * profiler/ProfileNode.cpp:
      (JSC::ProfileNode::debugPrintData):
      (JSC::ProfileNode::debugPrintDataSampleStyle):
      * runtime/Arguments.cpp:
      (JSC::Arguments::getOwnPropertySlot):
      (JSC::Arguments::getOwnPropertyDescriptor):
      (JSC::Arguments::put):
      (JSC::Arguments::deleteProperty):
      * runtime/DateConversion.cpp:
      (JSC::parseDate):
      * runtime/Identifier.h:
      (JSC::Identifier::toStrictUInt32):
      * runtime/JSArray.cpp:
      (JSC::JSArray::getOwnPropertySlot):
      (JSC::JSArray::getOwnPropertyDescriptor):
      (JSC::JSArray::put):
      (JSC::JSArray::deleteProperty):
      * runtime/JSArray.h:
      (JSC::toArrayIndex):
      * runtime/JSGlobalObjectFunctions.cpp:
      (JSC::encode):
      (JSC::parseInt):
      (JSC::globalFuncJSCPrint):
      * runtime/JSString.h:
      (JSC::RopeBuilder::JSString):
      * runtime/UString.cpp:
      (JSC::UString::toDouble):
      (JSC::putUTF8Triple):
      (JSC::UString::utf8):
      * runtime/UString.h:
      (JSC::UString::~UString):
      (JSC::UString::isNull):
      (JSC::UString::isEmpty):
      (JSC::UString::impl):
      * wtf/text/WTFString.cpp:
      (WTF::String::utf8):
      * wtf/text/WTFString.h:
      (WTF::String::~String):
      (WTF::String::swap):
      (WTF::String::isNull):
      (WTF::String::isEmpty):
      (WTF::String::impl):
      (WTF::String::length):
      (WTF::String::String):
      (WTF::String::isHashTableDeletedValue):
      
      WebCore: 
      
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::getOwnPropertySlot):
      (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
      * bridge/NP_jsobject.cpp:
      (_NPN_Enumerate):
      * bridge/c/c_utility.cpp:
      (JSC::Bindings::convertValueToNPVariant):
      * bridge/jni/JNIBridge.cpp:
      (JavaParameter::JavaParameter):
      (JavaMethod::JavaMethod):
      (JavaMethod::signature):
      (JavaMethod::methodID):
      * bridge/jni/JNIBridge.h:
      (JSC::Bindings::JavaString::utf8):
      (JSC::Bindings::JavaParameter::type):
      (JSC::Bindings::JavaMethod::returnType):
      * bridge/jni/jni_jsobject.mm:
      (JavaJSObject::call):
      (JavaJSObject::eval):
      (JavaJSObject::getMember):
      (JavaJSObject::setMember):
      (JavaJSObject::removeMember):
      (JavaJSObject::convertJObjectToValue):
      * bridge/jni/jsc/JNIBridgeJSC.cpp:
      (JavaField::JavaField):
      (JavaField::valueFromInstance):
      (JavaField::setValueToInstance):
      * bridge/jni/jsc/JNIBridgeJSC.h:
      (JSC::Bindings::JavaField::type):
      * bridge/jni/jsc/JavaInstanceJSC.cpp:
      (JavaInstance::invokeMethod):
      * bridge/jni/jsc/JavaStringJSC.h:
      (JSC::Bindings::JavaStringImpl::utf8):
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::getOwnPropertySlot):
      (JSC::RuntimeArray::getOwnPropertyDescriptor):
      (JSC::RuntimeArray::put):
      
      WebKit/mac: 
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::enumerate):
      
      WebKit/wx: 
      
      * WebFrame.cpp:
      (wxWebFrame::RunScript):
      
      WebKit2: 
      
      * WebProcess/Plugins/JSNPObject.cpp:
      (WebKit::npIdentifierFromIdentifier):
      * WebProcess/Plugins/NPJSObject.cpp:
      (WebKit::NPJSObject::enumerate):
      * WebProcess/Plugins/NPRuntimeObjectMap.cpp:
      (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3158a387
    • yurys@chromium.org's avatar
      2010-08-12 Yury Semikhatsky <yurys@chromium.org> · 5ec4820e
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: allow interrupting long running JS to execute inspector command
              https://bugs.webkit.org/show_bug.cgi?id=43900
      
              * bindings/v8/ScriptDebugServer.cpp:
              (WebCore::):
              (WebCore::ScriptDebugServer::pause):
              (WebCore::ScriptDebugServer::interruptAndRun):
              (WebCore::ScriptDebugServer::runPendingTasks):
              (WebCore::ScriptDebugServer::handleV8DebugEvent):
              * bindings/v8/ScriptDebugServer.h:
              (WebCore::ScriptDebugServer::Task::~Task):
      
      2010-08-12  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: allow interrupting long running JS to execute inspector command
              https://bugs.webkit.org/show_bug.cgi?id=43900
      
              * public/WebDevToolsAgent.h:
              (WebKit::WebDevToolsAgent::MessageDescriptor::~MessageDescriptor):
              * src/WebDevToolsAgentImpl.cpp:
              (WebKit::WebDevToolsAgent::interruptAndDispatch):
              (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
              (WebKit::WebDevToolsAgent::processPendingMessages):
              * src/WebDevToolsFrontendImpl.cpp:
              (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
              * src/WebDevToolsFrontendImpl.h:
              * src/js/DevTools.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ec4820e
    • zherczeg@webkit.org's avatar
      Refactoring the fpu code generator for the ARM port · b6994145
      zherczeg@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=43842
      
      Reviewed by Gavin Barraclough.
      
      Support up to 32 double precision registers, and the
      recent VFP instruction formats. This patch is mainly
      a style change which keeps the current functionality.
      
      * assembler/ARMAssembler.h:
      (JSC::ARMRegisters::):
      (JSC::ARMAssembler::):
      (JSC::ARMAssembler::emitInst):
      (JSC::ARMAssembler::emitDoublePrecisionInst):
      (JSC::ARMAssembler::emitSinglePrecisionInst):
      (JSC::ARMAssembler::vadd_f64_r):
      (JSC::ARMAssembler::vdiv_f64_r):
      (JSC::ARMAssembler::vsub_f64_r):
      (JSC::ARMAssembler::vmul_f64_r):
      (JSC::ARMAssembler::vcmp_f64_r):
      (JSC::ARMAssembler::vsqrt_f64_r):
      (JSC::ARMAssembler::vmov_vfp_r):
      (JSC::ARMAssembler::vmov_arm_r):
      (JSC::ARMAssembler::vcvt_f64_s32_r):
      (JSC::ARMAssembler::vcvt_s32_f64_r):
      (JSC::ARMAssembler::vmrs_apsr):
      * assembler/MacroAssemblerARM.h:
      (JSC::MacroAssemblerARM::addDouble):
      (JSC::MacroAssemblerARM::divDouble):
      (JSC::MacroAssemblerARM::subDouble):
      (JSC::MacroAssemblerARM::mulDouble):
      (JSC::MacroAssemblerARM::sqrtDouble):
      (JSC::MacroAssemblerARM::convertInt32ToDouble):
      (JSC::MacroAssemblerARM::branchDouble):
      (JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6994145
    • ossy@webkit.org's avatar
      2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com> · eb7ea4be
      ossy@webkit.org authored
              Unreviewed, rolling out r65295.
              http://trac.webkit.org/changeset/65295
              https://bugs.webkit.org/show_bug.cgi?id=43950
      
              It broke 4 sputnik tests (Requested by Ossy on #webkit).
      
              * JavaScriptCore.exp:
              * bytecode/CodeBlock.cpp:
              (JSC::constantName):
              (JSC::idName):
              (JSC::CodeBlock::registerName):
              (JSC::regexpName):
              (JSC::printGlobalResolveInfo):
              (JSC::printStructureStubInfo):
              (JSC::CodeBlock::printStructure):
              (JSC::CodeBlock::printStructures):
              * jsc.cpp:
              (functionPrint):
              (functionDebug):
              (runInteractive):
              (fillBufferWithContentsOfFile):
              * pcre/pcre_exec.cpp:
              (Histogram::~Histogram):
              * profiler/CallIdentifier.h:
              (JSC::CallIdentifier::c_str):
              * profiler/Profile.cpp:
              (JSC::Profile::debugPrintDataSampleStyle):
              * profiler/ProfileGenerator.cpp:
              (JSC::ProfileGenerator::willExecute):
              (JSC::ProfileGenerator::didExecute):
              * profiler/ProfileNode.cpp:
              (JSC::ProfileNode::debugPrintData):
              (JSC::ProfileNode::debugPrintDataSampleStyle):
              * runtime/Arguments.cpp:
              (JSC::Arguments::getOwnPropertySlot):
              (JSC::Arguments::getOwnPropertyDescriptor):
              (JSC::Arguments::put):
              (JSC::Arguments::deleteProperty):
              * runtime/DateConversion.cpp:
              (JSC::parseDate):
              * runtime/Identifier.h:
              (JSC::Identifier::Identifier):
              (JSC::Identifier::toArrayIndex):
              * runtime/JSArray.cpp:
              (JSC::JSArray::getOwnPropertySlot):
              (JSC::JSArray::getOwnPropertyDescriptor):
              (JSC::JSArray::put):
              (JSC::JSArray::deleteProperty):
              * runtime/JSArray.h:
              * runtime/JSGlobalObjectFunctions.cpp:
              (JSC::encode):
              (JSC::parseInt):
              (JSC::globalFuncJSCPrint):
              * runtime/JSString.h:
              (JSC::RopeBuilder::JSString):
              * runtime/UString.cpp:
              (JSC::UString::toDouble):
              (JSC::UString::UTF8String):
              * runtime/UString.h:
              (JSC::UString::isNull):
              (JSC::UString::isEmpty):
              (JSC::UString::impl):
              (JSC::UString::cost):
              (JSC::UString::~UString):
              (JSC::UString::toArrayIndex):
              * wtf/text/WTFString.cpp:
              (WTF::String::utf8):
              * wtf/text/WTFString.h:
              (WTF::String::String):
              (WTF::String::isHashTableDeletedValue):
              (WTF::String::length):
              (WTF::String::operator[]):
              (WTF::String::isNull):
              (WTF::String::isEmpty):
              (WTF::String::impl):
      2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r65295.
              http://trac.webkit.org/changeset/65295
              https://bugs.webkit.org/show_bug.cgi?id=43950
      
              It broke 4 sputnik tests (Requested by Ossy on #webkit).
      
              * WebFrame.cpp:
              (wxWebFrame::RunScript):
      2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r65295.
              http://trac.webkit.org/changeset/65295
              https://bugs.webkit.org/show_bug.cgi?id=43950
      
              It broke 4 sputnik tests (Requested by Ossy on #webkit).
      
              * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
              (WebKit::NetscapePluginInstanceProxy::enumerate):
      2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r65295.
              http://trac.webkit.org/changeset/65295
              https://bugs.webkit.org/show_bug.cgi?id=43950
      
              It broke 4 sputnik tests (Requested by Ossy on #webkit).
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::getOwnPropertySlot):
              (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
              * bridge/NP_jsobject.cpp:
              (_NPN_Enumerate):
              * bridge/c/c_utility.cpp:
              (JSC::Bindings::convertValueToNPVariant):
              * bridge/jni/JNIBridge.cpp:
              (JavaParameter::JavaParameter):
              (JavaMethod::JavaMethod):
              (JavaMethod::signature):
              (JavaMethod::methodID):
              * bridge/jni/JNIBridge.h:
              (JSC::Bindings::JavaString::UTF8String):
              (JSC::Bindings::JavaParameter::type):
              (JSC::Bindings::JavaMethod::returnType):
              * bridge/jni/jni_jsobject.mm:
              (JavaJSObject::call):
              (JavaJSObject::eval):
              (JavaJSObject::getMember):
              (JavaJSObject::setMember):
              (JavaJSObject::removeMember):
              (JavaJSObject::convertJObjectToValue):
              * bridge/jni/jsc/JNIBridgeJSC.cpp:
              (JavaField::JavaField):
              (JavaField::valueFromInstance):
              (JavaField::setValueToInstance):
              * bridge/jni/jsc/JNIBridgeJSC.h:
              (JSC::Bindings::JavaField::type):
              * bridge/jni/jsc/JavaInstanceJSC.cpp:
              (JavaInstance::invokeMethod):
              * bridge/jni/jsc/JavaStringJSC.h:
              (JSC::Bindings::JavaStringImpl::UTF8String):
              * bridge/runtime_array.cpp:
              (JSC::RuntimeArray::getOwnPropertySlot):
              (JSC::RuntimeArray::getOwnPropertyDescriptor):
              (JSC::RuntimeArray::put):
      2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r65295.
              http://trac.webkit.org/changeset/65295
              https://bugs.webkit.org/show_bug.cgi?id=43950
      
              It broke 4 sputnik tests (Requested by Ossy on #webkit).
      
              * WebProcess/Plugins/JSNPObject.cpp:
              (WebKit::npIdentifierFromIdentifier):
              * WebProcess/Plugins/NPJSObject.cpp:
              (WebKit::NPJSObject::enumerate):
              * WebProcess/Plugins/NPRuntimeObjectMap.cpp:
              (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb7ea4be
    • pfeldman@chromium.org's avatar
      2010-08-12 Pavel Feldman <pfeldman@chromium.org> · 7fb61822
      pfeldman@chromium.org authored
              Not reviewed. Fixed typo in inspector js.
              Follow up to r65300.
      
              * inspector/front-end/inspector.js:
              (WebInspector.log.isLogAvailable):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fb61822
    • pfeldman@chromium.org's avatar
      2010-08-12 Pavel Feldman <pfeldman@chromium.org> · 5a732bd4
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Make getPrototypes return objects, not names.
              https://bugs.webkit.org/show_bug.cgi?id=43934
      
              * inspector/front-end/InjectedScript.js:
              (injectedScriptConstructor):
              (injectedScriptConstructor.):
              * inspector/front-end/PropertiesSidebarPane.js:
              (WebInspector.PropertiesSidebarPane.prototype.update.callback):
              * inspector/front-end/inspector.js:
              (WebInspector.log):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a732bd4
  2. 12 Aug, 2010 10 commits
    • jamesr@google.com's avatar
      2010-08-12 James Robinson <jamesr@chromium.org> · d91ed91f
      jamesr@google.com authored
              Unreviewed, rolling out r65284 and r65288.  Broke chromium compile.
              https://bugs.webkit.org/show_bug.cgi?id=43725
              http://trac.webkit.org/changeset/65284
              http://trac.webkit.org/changeset/65288
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::namedItemAdded):
              (WebCore::ScriptController::namedItemRemoved):
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
              * bindings/v8/V8DOMWindowShell.h:
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::instantiateV8Object):
              * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
              (WebCore::V8HTMLDocument::namedPropertyDeleter):
              (WebCore::V8HTMLDocument::namedPropertyGetter):
              (WebCore::V8HTMLDocument::indexedPropertyGetter):
              (WebCore::V8HTMLDocument::allAccessorSetter):
              (WebCore::toV8):
              * html/HTMLDocument.cpp:
              (WebCore::HTMLDocument::removeItemFromMap):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d91ed91f
    • weinig@apple.com's avatar
      Add more files to the WebKit2 skipped list. · 419ef0f8
      weinig@apple.com authored
      Reviewed by Gavin Barraclough.
      
      * platform/mac-wk2/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      419ef0f8
    • jamesr@google.com's avatar
      2010-08-12 James Robinson <jamesr@chromium.org> · a52277b9
      jamesr@google.com authored
              Unreviewed. Mark play-state.html and isindex-with-no-form.html as flaky because they are.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a52277b9
    • barraclough@apple.com's avatar
      Windows build fix. · 0fd687a6
      barraclough@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fd687a6
    • barraclough@apple.com's avatar
      Unify UString::UTF8String() & String::utf8() methods, · d22274e7
      barraclough@apple.com authored
      remove UString::cost() & make atArrayIndex a free function.
      
      Reviewed by Sam Weinig
      
      JavaScriptCore: 
      
      * JavaScriptCore.exp:
      * bytecode/CodeBlock.cpp:
      (JSC::constantName):
      (JSC::idName):
      (JSC::CodeBlock::registerName):
      (JSC::regexpName):
      (JSC::printGlobalResolveInfo):
      (JSC::printStructureStubInfo):
      (JSC::CodeBlock::printStructure):
      (JSC::CodeBlock::printStructures):
      * jsc.cpp:
      (functionPrint):
      (functionDebug):
      (runInteractive):
      (fillBufferWithContentsOfFile):
      * pcre/pcre_exec.cpp:
      (Histogram::~Histogram):
      * profiler/CallIdentifier.h:
      (JSC::CallIdentifier::c_str):
      * profiler/Profile.cpp:
      (JSC::Profile::debugPrintDataSampleStyle):
      * profiler/ProfileGenerator.cpp:
      (JSC::ProfileGenerator::willExecute):
      (JSC::ProfileGenerator::didExecute):
      * profiler/ProfileNode.cpp:
      (JSC::ProfileNode::debugPrintData):
      (JSC::ProfileNode::debugPrintDataSampleStyle):
      * runtime/Arguments.cpp:
      (JSC::Arguments::getOwnPropertySlot):
      (JSC::Arguments::getOwnPropertyDescriptor):
      (JSC::Arguments::put):
      (JSC::Arguments::deleteProperty):
      * runtime/DateConversion.cpp:
      (JSC::parseDate):
      * runtime/Identifier.h:
      (JSC::Identifier::toStrictUInt32):
      * runtime/JSArray.cpp:
      (JSC::JSArray::getOwnPropertySlot):
      (JSC::JSArray::getOwnPropertyDescriptor):
      (JSC::JSArray::put):
      (JSC::JSArray::deleteProperty):
      * runtime/JSArray.h:
      (JSC::toArrayIndex):
      * runtime/JSGlobalObjectFunctions.cpp:
      (JSC::encode):
      (JSC::parseInt):
      (JSC::globalFuncJSCPrint):
      * runtime/JSString.h:
      (JSC::RopeBuilder::JSString):
      * runtime/UString.cpp:
      (JSC::UString::toDouble):
      (JSC::putUTF8Triple):
      (JSC::UString::utf8):
      * runtime/UString.h:
      (JSC::UString::~UString):
      (JSC::UString::isNull):
      (JSC::UString::isEmpty):
      (JSC::UString::impl):
      * wtf/text/WTFString.cpp:
      (WTF::String::utf8):
      * wtf/text/WTFString.h:
      (WTF::String::~String):
      (WTF::String::swap):
      (WTF::String::isNull):
      (WTF::String::isEmpty):
      (WTF::String::impl):
      (WTF::String::length):
      (WTF::String::String):
      (WTF::String::isHashTableDeletedValue):
      
      WebCore: 
      
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::getOwnPropertySlot):
      (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
      * bridge/NP_jsobject.cpp:
      (_NPN_Enumerate):
      * bridge/c/c_utility.cpp:
      (JSC::Bindings::convertValueToNPVariant):
      * bridge/jni/JNIBridge.cpp:
      (JavaParameter::JavaParameter):
      (JavaMethod::JavaMethod):
      (JavaMethod::signature):
      (JavaMethod::methodID):
      * bridge/jni/JNIBridge.h:
      (JSC::Bindings::JavaString::utf8):
      (JSC::Bindings::JavaParameter::type):
      (JSC::Bindings::JavaMethod::returnType):
      * bridge/jni/jni_jsobject.mm:
      (JavaJSObject::call):
      (JavaJSObject::eval):
      (JavaJSObject::getMember):
      (JavaJSObject::setMember):
      (JavaJSObject::removeMember):
      (JavaJSObject::convertJObjectToValue):
      * bridge/jni/jsc/JNIBridgeJSC.cpp:
      (JavaField::JavaField):
      (JavaField::valueFromInstance):
      (JavaField::setValueToInstance):
      * bridge/jni/jsc/JNIBridgeJSC.h:
      (JSC::Bindings::JavaField::type):
      * bridge/jni/jsc/JavaInstanceJSC.cpp:
      (JavaInstance::invokeMethod):
      * bridge/jni/jsc/JavaStringJSC.h:
      (JSC::Bindings::JavaStringImpl::utf8):
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::getOwnPropertySlot):
      (JSC::RuntimeArray::getOwnPropertyDescriptor):
      (JSC::RuntimeArray::put):
      
      WebKit/mac: 
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::enumerate):
      
      WebKit/wx: 
      
      * WebFrame.cpp:
      (wxWebFrame::RunScript):
      
      WebKit2: 
      
      * WebProcess/Plugins/JSNPObject.cpp:
      (WebKit::npIdentifierFromIdentifier):
      * WebProcess/Plugins/NPJSObject.cpp:
      (WebKit::NPJSObject::enumerate):
      * WebProcess/Plugins/NPRuntimeObjectMap.cpp:
      (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d22274e7
    • jhoneycutt@apple.com's avatar
      WebKitTestRunner does not correctly resize WebView for W3C SVG tests · c8e427da
      jhoneycutt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=43945
      
      Reviewed by Sam Weinig.
      
      * WebKitTestRunner/TestInvocation.cpp:
      (WTR::sizeWebViewForCurrentTest):
      Allow for a Windows-style path.
      
      * WebKitTestRunner/win/PlatformWebViewWin.cpp:
      (WTR::PlatformWebView::resizeTo):
      Call SetWindowPos to resize the view window.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8e427da
    • jhoneycutt@apple.com's avatar
      WebKit2 needs to initialize SafariTheme · 0519163b
      jhoneycutt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=43901
      
      Reviewed by Sam Weinig.
      
      * WebProcess/win/WebProcessMainWin.cpp:
      (WebKit::initializeSafariTheme):
      Copied from old WebKit.
      (WebKit::WebProcessMain):
      If we're using SafariTheme, initialize it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0519163b
    • mjs@apple.com's avatar
      2010-08-12 Maciej Stachowiak <mjs@apple.com> · cf163dc1
      mjs@apple.com authored
              Reviewed by Sam Weinig.
      
              WebKit2 crashes when WebFrame outlives WebPage
              https://bugs.webkit.org/show_bug.cgi?id=43939
      
              * WebProcess/WebCoreSupport/WebChromeClient.h:
              (WebKit::WebChromeClient::page): Add this method, to allow
              WebFrame to retrieve its WebPage following WebCore pointers.
              * WebProcess/WebPage/WebFrame.cpp:
              (WebKit::WebFrame::WebFrame): Do not initialize m_page (it's gone).
              (WebKit::WebFrame::page): Don't use the data member, get it from
              WebCore.
              (WebKit::WebFrame::invalidate): Use method to get page() and null check.
              (WebKit::WebFrame::isMainFrame): ditto
              * WebProcess/WebPage/WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf163dc1
    • rniwa@webkit.org's avatar
      2010-08-12 Ryosuke Niwa <rniwa@webkit.org> · a60cb2e1
      rniwa@webkit.org authored
              Unreviewed, fixing the previous commit.
      
              Added PASS CRASH expectation for editing/pasteboard/smart-paste-004.html.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a60cb2e1
    • rniwa@webkit.org's avatar
      2010-08-12 Ryosuke Niwa <rniwa@webkit.org> · 717257eb
      rniwa@webkit.org authored
              Unreviewed.
      
              Added PASS CRASH expectation for editing/pasteboard/smart-paste-003.html and
              editing/pasteboard/smart-paste-004.html reported by japhet.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      717257eb