1. 05 Mar, 2007 7 commits
    • andersca's avatar
      LayoutTests: · 526c36f0
      andersca authored
              Reviewed by Adam, Darin.
      
              <rdar://problem/5025212>
              In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object
      
              * plugins/get-url-with-blank-target-expected.txt: Added.
              * plugins/get-url-with-blank-target.html: Added.
      
      WebKit:
      
              Reviewed by Adam, Darin.
       
              <rdar://problem/5025212>
              In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView loadPluginRequest:]):
              Handle the case where the web view returned from the delegate method is null. Also, send out an error notification
              in that case so we can catch it.
      
      WebKitTools:
      
              Reviewed by Adam, Darin.
      
              <rdar://problem/5025212>
              In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object
              
              Add a "getURLNotify" method to the plugin object. This lets you pass a URL, a target and a callback function
              to be run when the URL has finished (or failed) loading.
              
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              (pluginInvoke):
              (handleCallback):
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
              * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
              (NPP_URLNotify):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      526c36f0
    • sullivan's avatar
      Reviewed by Darin and Kevin D · a27db451
      sullivan authored
              - fixed <rdar://problem/5038087> Header and footer on printed page are too large after certain steps
      
              * WebView/WebView.mm:
              (-[WebView _adjustPrintingMarginsForHeaderAndFooter]):
              This method was modifying the margins in the NSPrintInfo object without any sort of check whether
              this had already been done. In some cases this can be called multiple times with the same 
              NSPrintInfo, so now we stash information in the NSPrintInfo's dictionary such that we always
              start with a fresh copy of the original margins.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a27db451
    • ap's avatar
      Remove accidentally committed tests. · 9da3f770
      ap authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9da3f770
    • ap's avatar
      Reviewed by Darin. · 9f0bd555
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=12954
              XPath relative operations are implemented incorrectly
      
      WebCore:
              * xml/XPathPredicate.cpp:
              (WebCore::XPath::NumericOp::doEvaluate):
              (WebCore::XPath::EqTestOp::compare):
              (WebCore::XPath::EqTestOp::doEvaluate):
              Reimplemented relative equality operations to match the spec.
      
              * xml/XPathPredicate.h:
              (WebCore::XPath::NumericOp::):
              (WebCore::XPath::EqTestOp::):
              Moved relative operations to EqTestOp.
      
              * xml/XPathGrammar.y:
              * xml/XPathParser.cpp:
              (WebCore::XPath::Parser::nextTokenInternal):
              (WebCore::XPath::Parser::lex):
              Adapted for the above changes.
      
      LayoutTests:
              * fast/xpath/4XPath/Core/test_boolean_expr-expected.txt: Added.
              * fast/xpath/4XPath/Core/test_boolean_expr.html: Added.
      
              * fast/xpath/4XPath/Borrowed/cz_20030217-expected.txt: Added.
              * fast/xpath/4XPath/Borrowed/cz_20030217.html: Added.
              * fast/xpath/4XPath/Borrowed/kd_20010423-expected.txt: Added.
              * fast/xpath/4XPath/Borrowed/kd_20010423.html: Added.
              * fast/xpath/4XPath/Borrowed/od_20000608-expected.txt: Added.
              * fast/xpath/4XPath/Borrowed/od_20000608.html: Added.
              * fast/xpath/4XPath/Borrowed/resources/od_20000608.xml: Added.
              * fast/xpath/4XPath/Borrowed/rs_20010831-expected.txt: Added.
              * fast/xpath/4XPath/Borrowed/rs_20010831.html: Added.
              * fast/xpath/4XPath/Borrowed/sr_20021217-expected.txt: Added.
              * fast/xpath/4XPath/Borrowed/sr_20021217.html: Added.
              Added a bunch of XPath tests that already passed.
      
              * fast/xpath/4XPath/Borrowed/namespace-nodes-expected.txt: Added.
              * fast/xpath/4XPath/Borrowed/namespace-nodes.html: Added.
              * fast/xpath/namespace-nodes-expected.txt: Removed.
              * fast/xpath/namespace-nodes.html: Removed.
              Moved a previously imported 4XPath test.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f0bd555
    • bdash's avatar
      Pesky apostrophe. · a472144c
      bdash authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a472144c
    • bdash's avatar
      2007-03-05 Mark Rowe <mrowe@apple.com> · 74158d39
      bdash authored
              Reviewed by Lars.
      
              Fix http://bugs.webkit.org/show_bug.cgi?id=12947
              Bug 12947: REGRESSION: ASSERTION FAILED: maxWidth >= 0 in StringTruncator.cpp:109 in WebCore::truncateString()
      
              Handle nil window correctly in toUserSpace and toDeviceSpace.  On Intel Mac's a message to nil that returns a
              float will return 0.0.  We use this as the divisor in calculating a scale factor, which results in NaN being
              introduced into our rect.
      
              * platform/mac/ScreenMac.mm:
              (WebCore::toUserSpace):
              (WebCore::toDeviceSpace):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74158d39
    • rwlbuis's avatar
      Reviewed by Darin. · 29bf3084
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=12868
              parts of the CSS classes in this simple SVG example are not applied
      
              Make sure the xml stylesheets are parsed in strict mode.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29bf3084
  2. 04 Mar, 2007 7 commits
    • ap's avatar
      Reviewed by Darin. · 5239c27d
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=12961
              shouldBe() should support NaN
      
              * fast/js/resources/js-test-pre.js: Make shouldBe() succeed if both sides are NaN numbers.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5239c27d
    • adele's avatar
      LayoutTests: · 7f67e935
      adele authored
              Reviewed by Darin.
      
              * fast/events/keydown-keypress-preventDefault-expected.txt: Added.
              * fast/events/keydown-keypress-preventDefault.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              Change to dispatch the keypress event during the defaultEventHandler for keydown events.  This matches IE behavior.
              This is preparation for fixing event dispatch with input methods (http://bugs.webkit.org/show_bug.cgi?id=10871)
      
              Test: fast/events/keydown-keypress-preventDefault.html
      
              * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Call the defaultKeyboardEventHandler for keydown events.
              * page/EventHandler.cpp:
              (WebCore::eventTargetNodeForDocument): Return 0 instead of false since the return type in EventTargetNode.
              (WebCore::EventHandler::keyEvent): Removed dispatch of keypress event, since this is now done in the default event handler.
              (WebCore::EventHandler::defaultKeyboardEventHandler): For keydown events, create and dispatch a keypress event.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f67e935
    • ap's avatar
      Reviewed by Nikolas Zimmermann (yay!). · d50012d0
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=12962
              4XPath tests crash on lang() function
      
              Covered by 4XPath tests, to be landed later.
      
              * platform/StringImpl.cpp:
              (WebCore::StringImpl::reverseFind): Do not crash with empty strings.
              * xml/XPathFunctions.cpp:
              (WebCore::XPath::FunLang::doEvaluate): Do not crash when an element has no
              attributes. Use a proper namespace for xml:lang (not sure where "xms" came from).
              Rewrote the algorithm for suffix removing to match the spec.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d50012d0
    • ddkilzer's avatar
      JavaScriptCore: · d708423b
      ddkilzer authored
              Reviewed by Nikolas Zimmermann.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12950
                Assertions.cpp should not #define macros that are already defined
      
              * wtf/Assertions.cpp: Don't #define WINVER and _WIN32_WINNT if they
              are already defined.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d708423b
    • andersca's avatar
      LayoutTests: · 271a2156
      andersca authored
              Reviewed by Darin.
      
              <rdar://problem/5028165> 
              http://bugs.webkit.org/show_bug.cgi?id=12915
              REGRESSION: XMLHttpRequest.abort() does not stop loading (12915)
      
              * http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.
              * http/tests/xmlhttprequest/abort-should-cancel-load.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              <rdar://problem/5028165> 
              http://bugs.webkit.org/show_bug.cgi?id=12915
              REGRESSION: XMLHttpRequest.abort() does not stop loading (12915)
              
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::stopLoading):
              Save the value of m_loading since calling FrameLoader::stopLoading could set it to false.
              
              * loader/SubresourceLoader.cpp:
              (WebCore::SubresourceLoader::didCancel):
              * loader/SubresourceLoader.h:
              Get rid of didCancel now, it's not needed anymore.
              
              * xml/xmlhttprequest.cpp:
              (WebCore::XMLHttpRequest::abort):
              Call cancel() instead of stopLoading(). Also, set m_aborted to true so the XMLHttpRequest object
              won't be dereferenced in didFail when aborting.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      271a2156
    • kjk's avatar
      WebCore: · 65a9f5ed
      kjk authored
              Reviewed by Nikolas Zimmermann.
      
              Move ScrollView stubs to ScrollViewGdk.cpp
      
              * platform/gdk/FrameGdk.h: remove comment that no longer makes sense
              * platform/gdk/ScrollViewGdk.cpp:
              (WebCore::ScrollView::addChild):
              (WebCore::ScrollView::removeChild):
              (WebCore::ScrollView::scrollPointRecursively):
              (WebCore::ScrollView::inWindow):
              (WebCore::ScrollView::wheelEvent):
              (WebCore::ScrollView::updateScrollbars):
              (WebCore::ScrollView::updateScrollInfo):
              (WebCore::ScrollView::windowToContents):
              (WebCore::ScrollView::contentsToWindow):
              (WebCore::ScrollView::scrollbarUnderMouse):
              * platform/gdk/TemporaryLinkStubs.cpp:
      
        WebKitTools:
      
              Reviewed by Nikolas Zimmermann.
      
              Load a url given on a command line in a way that also
              works for local (file://) urls.
      
              * GdkLauncher/main.cpp:
              (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65a9f5ed
    • ddkilzer's avatar
      LayoutTests: · f7ee8f9d
      ddkilzer authored
              Reviewed by Nikolas Zimmermann.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12951
                REGRESSION (r19949): LayoutTests/fast/xsl/xslt-processer.html fails
      
              Fixed spelling of "processer" to "processor" in file names.
      
              * fast/xsl/xslt-processer-expected.txt: Removed.
              * fast/xsl/xslt-processer.html: Removed.
              * fast/xsl/xslt-processor-expected.txt: Added. Results progressed after fixing
              Bugzilla Bug 12735 (<rdar://problem/4545040>).
              * fast/xsl/xslt-processor.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7ee8f9d
  3. 02 Mar, 2007 13 commits
    • kmccullo's avatar
      LayoutTests: · adfd67da
      kmccullo authored
              Reviewed by Geoff.
      
              - rdar://problem/4922454
              - This fixes a security issue by making remote referrers not able to access local
              resources, unless they register their schemes to be treated as local. The result is
              that those schemes can access local resources and cannot be accessed by remote
              referrers.
              Because this behavior is new a link-on-or-after check is made to determine if the
              app should use the older, less safe, behavior.
      
              * fast/loader/local-CSS-from-local-expected.txt: Added.
              * fast/loader/local-CSS-from-local.html: Added.
              * fast/loader/local-JavaScript-from-local-expected.txt: Added.
              * fast/loader/local-JavaScript-from-local.html: Added.
              * fast/loader/local-iFrame-source-from-local-expected.txt: Added.
              * fast/loader/local-iFrame-source-from-local.html: Added.
              * fast/loader/local-image-from-local-expected.txt: Added.
              * fast/loader/local-image-from-local.html: Added.
              * http/tests/security/local-CSS-from-remote-expected.txt: Added.
              * http/tests/security/local-CSS-from-remote.html: Added.
              * http/tests/security/local-JavaScript-from-remote-expected.txt: Added.
              * http/tests/security/local-JavaScript-from-remote.html: Added.
              * http/tests/security/local-iFrame-from-remote-expected.txt: Added.
              * http/tests/security/local-iFrame-from-remote.html: Added.
              * http/tests/security/local-image-from-remote-expected.txt: Added.
              * http/tests/security/local-image-from-remote.html: Added.
              * http/tests/security/resources/compass.jpg: Added.
              * http/tests/security/resources/cssStyle.css: Added.
              * http/tests/security/resources/localPage.html: Added.
              * http/tests/security/resources/localScript.js: Added.
      
      WebCore:
      
              Reviewed by Geoff.
      
              - rdar://problem/4922454
              - This fixes a security issue by making remote referrers not able to access local
              resources, unless they register their schemes to be treated as local. The result is
              that those schemes can access local resources and cannot be accessed by remote
              referrers.
              Because this behavior is new a link-on-or-after check is made to determine if the
              app should use the older, less safe, behavior.
      
              * WebCore.exp: added exported functions
              * bindings/objc/DOM.mm: consolodated function to base class
              (-[DOMElement image]):
              (-[DOMElement _imageTIFFRepresentation]):
              * dom/Document.cpp: Cache the document's ability to load local resources.
              (WebCore::Document::Document):
              (WebCore::Document::setURL):
              (WebCore::Document::shouldBeAllowedToLoadLocalResources):
              (WebCore::Document::stylesheetLoaded):
              * dom/Document.h: Cache the docuent's ability to load local resources.
              (WebCore::Document::getPendingSheet):
              (WebCore::Document::isAllowedToLoadLocalResources):
              * html/HTMLImageLoader.cpp: Moved functionality into base class.
              (WebCore::HTMLImageLoader::updateFromElement):
              (WebCore::HTMLImageLoader::dispatchLoadEvent):
              * html/HTMLLinkElement.cpp: Handles null returns correctly now.
              * html/HTMLTokenizer.cpp: Moved functionality into base class.
              (WebCore::HTMLTokenizer::notifyFinished):
              * ksvg2/misc/SVGImageLoader.cpp: Moved functionality into base class.
              (WebCore::SVGImageLoader::dispatchLoadEvent):
              * loader/Cache.cpp: Checks if the cached resource can be loaded.
              (WebCore::Cache::requestResource):
              * loader/CachedCSSStyleSheet.cpp: Moved functionality into base class.
              (WebCore::CachedCSSStyleSheet::ref):
              (WebCore::CachedCSSStyleSheet::error):
              * loader/CachedImage.cpp: Moved functionality into base class.
              (WebCore::CachedImage::CachedImage):
              * loader/CachedImage.h: Moved functionality into base class.
              (WebCore::CachedImage::canRender):
              * loader/CachedResource.cpp: Cache if the CachedResource should be treated as local
              (WebCore::CachedResource::CachedResource):
              * loader/CachedResource.h: Moved functionality into base class.
              (WebCore::CachedResource::errorOccurred):
              (WebCore::CachedResource::shouldTreatAsLocal):
              * loader/CachedScript.cpp: Moved functionality into base class.
              (WebCore::CachedScript::CachedScript):
              * loader/CachedScript.h: Moved functionality into base class.
              (WebCore::CachedScript::schedule):
              * loader/CachedXBLDocument.cpp: Moved functionality into base class.
              (WebCore::CachedXBLDocument::error):
              * loader/CachedXSLStyleSheet.cpp: Moved functionality into base class.
              (WebCore::CachedXSLStyleSheet::error):
              * loader/FrameLoader.cpp: See comments for each function below.
              (WebCore::FrameLoader::loadSubframe): Use new canLoad.
              (WebCore::FrameLoader::restrictAccessToLocal): return value of linked-on-or-after check.
              (WebCore::FrameLoader::setRestrictAccessToLocal): set value for linked-on-or-after check.
              (WebCore::localSchemes): Return set of schemes that are to be treated as local.
              (WebCore::FrameLoader::loadPlugin): Use new canLoad.
              (WebCore::FrameLoader::canLoad): Now multiple functions that each do the same work but some can take advantage of the cached values, if they were computed previously.
              (WebCore::FrameLoader::shouldHideReferrer): Extracted out the logic to determine if the referrer should be hidden so it is only calculated when needed.
              (WebCore::FrameLoader::loadResourceSynchronously): No longer calls canLoad to get hideReferrer info.
              (WebCore::FrameLoader::registerSchemeAsLocal): Functionality to register a scheme to be treated as local.
              (WebCore::FrameLoader::treatURLAsLocal): Given a URL this function determines if it should be treated as local.
              * loader/FrameLoader.h: Declared functions for this security fix.  See above.
              * loader/MainResourceLoader.cpp: Optized order of bools to regain performance.
              (WebCore::MainResourceLoader::continueAfterContentPolicy):
              * loader/SubresourceLoader.cpp: Now restricts remote from loading local resources.
              (WebCore::SubresourceLoader::create):
              * page/EventHandler.cpp: Moved functionality into base class.
              (WebCore::selectCursor):
              * platform/KURL.cpp: KURLs need to check all the registered schemes now.
              (WebCore::KURL::isLocalFile):
              * rendering/HitTestResult.cpp: Moved functionality into base class.
              (WebCore::HitTestResult::image):
              * rendering/RenderImage.cpp: Moved functionality into base class.
              (WebCore::RenderImage::setCachedImage):
              (WebCore::RenderImage::imageChanged):
              (WebCore::RenderImage::paint):
              (WebCore::RenderImage::layout):
              (WebCore::RenderImage::calcAspectRatioWidth):
              (WebCore::RenderImage::calcAspectRatioHeight):
              * rendering/RenderImage.h: Moved functionality into base class.
              (WebCore::RenderImage::errorOccurred):
              * rendering/RenderListItem.cpp: Moved functionality into base class.
              (WebCore::RenderListItem::setStyle):
              * rendering/RenderListMarker.cpp: Moved functionality into base class.
              (WebCore::RenderListMarker::isImage):
              * xml/xmlhttprequest.cpp: Check doc's cached value instead of determining independently.
              (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
      
      WebKit:
      
              Reviewed by Geoff.
      
              - rdar://problem/4922454
              - This fixes a security issue by making remote referrers not able to access local
              resources, unless they register their schemes to be treated as local. The result is
              that those schemes can access local resources and cannot be accessed by remote
              referrers.
              Because this behavior is new a link-on-or-after check is made to determine if the
              app should use the older, less safe, behavior.
      
              * Misc/WebKitVersionChecks.h: added linked-on-or-after check
              * Misc/WebNSAttributedStringExtras.mm: Moved functionalit into the base class.
              (fileWrapperForElement):
              * Plugins/WebNetscapePluginStream.mm: uses new canLoad functions
              * Plugins/WebPluginContainerCheck.mm: uses new canLoad functions
              (-[WebPluginContainerCheck _isForbiddenFileLoad]):
              * WebView/WebView.mm: make linked-on-or-after check and cache value, exposes SPI
              for registering a scheme as local. 
              (-[WebView _commonInitializationWithFrameName:groupName:]):
              (+[WebView registerSchemeAsLocal:]):
              * WebView/WebViewPrivate.h: exposes SPI for registering a scheme as local.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adfd67da
    • justing's avatar
      LayoutTests: · 50ed58a4
      justing authored
              Reviewed by kevin
              
              <rdar://problem/5028447>
              REGRESSION: Gmail Editor: Copied message text pastes at the wrong font size
      
              * editing/pasteboard/5028447-expected.checksum: Added.
              * editing/pasteboard/5028447-expected.png: Added.
              * editing/pasteboard/5028447-expected.txt: Added.
              * editing/pasteboard/5028447.html: Added.
      
      WebCore:
      
              Reviewed by kevin
              
              <rdar://problem/5028447>
              REGRESSION: Gmail Editor: Copied message text pastes at the wrong font size
      
              * editing/markup.cpp:
              (WebCore::createMarkup): The style of the div that holds
              a fully selected body's styles didn't include styles inherited
              from the body's ancestors.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50ed58a4
    • ggaren's avatar
      Tweaked parse-malloc-history to work with new malloc_history output format. · 90170969
      ggaren authored
              * Scripts/parse-malloc-history:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90170969
    • justing's avatar
      LayoutTests: · 73f3e7bf
      justing authored
              Reviewed by harrison
              
              <rdar://problem/4545040>
              innerHTML does not HTML-escape text nodes inside PRE elements
              <rdar://problem/5027857>
              Pasting into Mail from Safari's view-source window renders the HTML
      
              * editing/pasteboard/5027857-expected.checksum: Added.
              * editing/pasteboard/5027857-expected.png: Added.
              * editing/pasteboard/5027857-expected.txt: Added.
              * editing/pasteboard/5027857.html: Added.
      
      WebCore:
      
              Reviewed by harrison
      
              <rdar://problem/4545040>
              innerHTML does not HTML-escape text nodes inside PRE elements
              <rdar://problem/5027857>
              Pasting into Mail from Safari's view-source window renders the HTML
      
              * editing/HTMLInterchange.cpp:
              (WebCore::convertHTMLTextToInterchangeFormat): Send this function
              the node that the text comes from as a parameter.  It shouldn't convert
              '\n's to spaces/nbsps if the text is coming from text where newlines are
              preserved.
              * editing/HTMLInterchange.h:
              * editing/markup.cpp:
              (WebCore::startMarkup): Escape text inside the children of PREs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73f3e7bf
    • weinig's avatar
      WebCore: · 48b04dba
      weinig authored
              Reviewed by Anders.
      
              Try to fix the Qt build.
      
              * platform/qt/TemporaryLinkStubs.cpp: Add stubs.
              (WebCore::searchMenuNoRecentSearchesText):
              (WebCore::searchMenuRecentSearchesText):
              (WebCore::searchMenuClearRecentSearchesText):
              (WebCore::AXWebAreaText):
              (WebCore::AXLinkText):
              (WebCore::AXListMarkerText):
              (WebCore::AXImageMapText):
              (WebCore::AXHeadingText):
      
      WebKitQt:
      
              Reviewed by Anders.
      
              Try to fix the Qt build
      
              * WebCoreSupport/DragClientQt.cpp:
              (WebCore::DragClientQt::willPerformDragDestinationAction):
              (WebCore::DragClientQt::dragControllerDestroyed):
              (WebCore::DragClientQt::createDragImageForLink):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48b04dba
    • sfalken's avatar
      2007-03-02 Steve Falkenburg <sfalken@apple.com> · f7c999da
      sfalken authored
              Reviewed by Anders.
              
              Add unsigned int hash traits (matches existing unsigned long version)
      
              * wtf/HashTraits.h:
              (WTF::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7c999da
    • harrison's avatar
      Suggested by Darin. · e51acee3
      harrison authored
              A more efficient solution to rdar://4961431.
      
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject accessibilityIsIgnored]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e51acee3
    • aroben's avatar
      Reviewed by Kevin M. · 6181d058
      aroben authored
              Try to fix the Qt build.
      
              * kjs/DateMath.cpp:
              (KJS::msToGregorianDateTime): Removed unnecessary "struct" keyword.
              * kjs/DateMath.h: Moved forward declarations to the top of the file
              before they are used.
              * kjs/date_object.cpp:
              (KJS::formatLocaleDate): Changed to take a const GregorianDateTime&
              since GregorianDateTime is Noncopyable.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6181d058
    • justing's avatar
      LayoutTests: · 28a45ad1
      justing authored
              Reviewed by john
              
              <rdar://problem/5032095>
              Gmail Editor: Copied text pastes on a new line instead of current line
      
              * editing/pasteboard/5032095-expected.checksum: Added.
              * editing/pasteboard/5032095-expected.png: Added.
              * editing/pasteboard/5032095-expected.txt: Added.
              * editing/pasteboard/5032095.html: Added.
      
      WebCore:
      
              Reviewed by john
              
              <rdar://problem/5032095>
              Gmail Editor: Copied text pastes on a new line instead of current line
              
              Start merge failed to occur because positionAtStartOfInsertedContent
              had a bug.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent):
              Was failing when inserting <span><div>foo/div></span>. Return the 
              inserted content's first VisiblePosition.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28a45ad1
    • darin's avatar
      Reviewed by Kevin McCullough. · 3bb15076
      darin authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=12867
                REGRESSION: BenchJS test 7 (dates) is 220% slower than in Safari 2.0.4
      
              * kjs/DateMath.h: Marked GregorianDateTime as noncopyable, since it has a non-trivial
              destructor and not the correspoding copy constructor or assignment operator.
              Changed the GregorianDateTime constructor to use member initialization syntax.
              Fixed the destructor to use the array delete operator, since timeZone is an array.
      
              * kjs/DateMath.cpp:
              (KJS::daysInYear): Changed to call isLeapYear so the rule is not repeated twice.
              (KJS::getUTCOffset): Added caching on PLATFORM(DARWIN), since we can rely on the
              notify_check function and "com.apple.system.timezone" to let us know when the
              offset has changed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bb15076
    • hyatt's avatar
      Fix glyph map crasher. · 3b8555aa
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b8555aa
    • antti's avatar
      Reviewed by Maciej. · 86d0462e
      antti authored
              Fix for http://bugs.webkit.org/show_bug.cgi?id=12895
              REGRESSION: imagemap: pointer cursor is shown everywhere
              <rdar://problem/5028163>
       
              Image with imagemap should never itself be URLElement in hit test results. 
                     
              No layout test, cursor state can't be captured.
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::hitTest):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86d0462e
    • antti's avatar
      LayoutTests: · ac25cb4f
      antti authored
              Reviewed by Maciej.
              
              HTTP layout test for http://bugs.webkit.org/show_bug.cgi?id=12690
              REGRESSION: can not log in to bank of america with TOT webkit
              <rdar://problem/4990044>
      
              also for
              http://bugs.webkit.org/show_bug.cgi?id=12604
              http://bugs.webkit.org/show_bug.cgi?id=12020
              
              * http/tests/misc/multiple-submit-expected.txt: Added.
              * http/tests/misc/multiple-submit.html: Added.
              * http/tests/misc/resources/post-echo-and-notify-done.cgi: Added.
      
      WebCore:
      
              Reviewed by Maciej.
              
              Fix http://bugs.webkit.org/show_bug.cgi?id=12690
              REGRESSION: can not log in to bank of america with TOT webkit
              <rdar://problem/4990044>
              
              and http://bugs.webkit.org/show_bug.cgi?id=12604
              REGRESSION: After closing the "Would you like to save password" sheet, the form fails 
              to submit automatically at http://www.mac.com/WebObjects/HomePage.woa
              <rdar://problem/4871752>
              
              and http://bugs.webkit.org/show_bug.cgi?id=12020
              REGRESSION: Flickr uploading broken
              <rdar://problem/4928662>
              
              Turn protection against multiple forms submission back on. This approach is buggy 
              but it is way better than not having it at all. Not protecting against this
              breaks number of major sites.
              
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject accessibilityPerformAction:]):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
              (WebCore::FrameLoader::submitForm):
              (WebCore::FrameLoader::receivedMainResourceError):
              * loader/FrameLoader.h:
              * page/EventHandler.cpp:
              (WebCore::EventHandler::keyEvent):
              * page/Frame.cpp:
              (WebCore::Frame::setView):
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::mouseDown):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac25cb4f
  4. 01 Mar, 2007 8 commits
    • kmccullo's avatar
      LayoutTests: · 04b8e138
      kmccullo authored
              Reviewed by Adam.
      
              - Tests that the url of a document after an open is what it was before the open.
      
              * fast/loader/external-script-URL-location-expected.txt: Added.
              * fast/loader/external-script-URL-location.html: Added.
              * fast/loader/resources/external-script-URL-location.js: Added.
      
      WebCore:
      
              Reviewed by Adam.
      
              - Added the test case: external-script-URL-location.html
              - Fix an issue where the url of a document is null after an open if the document
              has no parent.
      
              * dom/Document.cpp:
              (WebCore::Document::open):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04b8e138
    • andersca's avatar
      Reviewed by Darin. · c770dced
      andersca authored
              <rdar://problem/4960250> 
              http://bugs.webkit.org/show_bug.cgi?id=11627
              REGRESSION: Reproducible crash at IMDb in WebCore::FrameLoader::stopLoadingSubframes
              
              In rare cases, we could end up calling checkLoadComplete twice for the same frame. This would cause the 
              didFailProvisionalLoad delegate method to be called twice for the same frame, and also cause the provisional document loader
              to be reset to null when other code wasn't expecting it.
              
              This regressed in revision 10904 with the fix for <rdar://problem/4184719>. The fix is to only call stopLoading on the frame
              if either the document loader is loading, or the document is still being parsed. I've verified that the bug is still fixed and
              that no leaks occur.
              
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::stopLoading):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c770dced
    • kjk's avatar
      Reviewed by Darin. · db62ec7c
      kjk authored
              Fix ARM crash due to accessing non-4-byte-aligned memory
              as 32-bit values.
      
              * platform/AtomicString.cpp:
              (WebCore::UCharBufferTranslator::equal):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db62ec7c
    • justing's avatar
      Reviewed by harrison · 9d77ca8d
      justing authored
              
              <rdar://problem/4838199>
              Integrate Mail and WebKit paste operations
              
              Provide subresources used to create the fragment as a
              convenience.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
              Update the calls to the changed method.
              (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
              Give the caller the subresources in the WebArchive and RTF cases.
              * WebView/WebHTMLViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d77ca8d
    • harrison's avatar
      Reviewed by Darin. · 10c7b5d9
      harrison authored
              <rdar://problem/5033905> Have the DOM secondary thread check raise an exception by default
      
              * platform/mac/ThreadCheck.mm:
              (WebCore::_WebCoreThreadViolationCheck):
              Initialize threadViolationIsException to true.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10c7b5d9
    • beidson's avatar
      Reviewed by Darin · 08bcbe5c
      beidson authored
              <rdar://problem/5030628> - Crash opening a new window with the
              "New windows open to the same page" pref set
      
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::HistoryItem): Set the m_subItems vector capacity correctly
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08bcbe5c
    • ap's avatar
      Reviewed by Maciej. · 409f4ae8
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=12801
              Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document
      
              Test: editing/pasteboard/createMarkup-assert.xml
      
              * editing/markup.cpp:
              (WebCore::createMarkup): Removed the assertion, because it's wrong in a non-HTML world.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      409f4ae8
    • aroben's avatar
      Reviewed by Oliver and Hyatt. · 8221a76c
      aroben authored
              Fix <rdar://problem/5024233> Crash while using Find on empty document
      
              No layout test possible, as this involves a null document.
      
              * dom/Range.cpp:
              (WebCore::rangeOfContents): Added an ASSERT.
              * page/Frame.cpp:
              (WebCore::Frame::findString): Added a null-check for document().
              (WebCore::Frame::markAllMatchesForText): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8221a76c
  5. 28 Feb, 2007 5 commits
    • oliver's avatar
      2007-02-28 Oliver Hunt <oliver@apple.com> · 9b3c3bbf
      oliver authored
              Reviewed by Maciej.
      
              Fixes <rdar://problem/5012009>
              
              When looking for a requested resource we should also check
              the set of manually added subresources if WebCore can't find it. 
      
              * WebView/WebDataSource.mm:
              (-[WebDataSource subresourceForURL:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b3c3bbf
    • thatcher's avatar
      Reviewed by Tim H. · 4380d29b
      thatcher authored
              Fixes: http://bugs.webkit.org/show_bug.cgi?id=12887
              Bug#12887: [Drosera] Add ability to close loaded files
      
              * Drosera/DebuggerDocument.h:
              * Drosera/DebuggerDocument.m:
              (-[DebuggerDocument closeCurrentFile:]): Adds delegation to call a JS script to close files
              * Drosera/Drosera.xcodeproj/project.pbxproj:
              * Drosera/English.lproj/MainMenu.nib/classes.nib: 
              * Drosera/English.lproj/MainMenu.nib/info.nib:
              * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Adds Close Current File menu item
              * Drosera/debugger.html: Changed "no files loaded" to "<No files loaded>" to match Xcode style
              * Drosera/debugger.js: Adds implementation of closeFile() to unload currently loaded file
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4380d29b
    • kjk's avatar
      Not reviewed - simple gdk build fix. · 678b6ef7
      kjk authored
              Add stubs for newly introduced localized strings.
      
              * platform/gdk/TemporaryLinkStubs.cpp:
              (WebCore::searchMenuNoRecentSearchesText):
              (WebCore::searchMenuRecentSearchesText):
              (WebCore::searchMenuClearRecentSearchesText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      678b6ef7
    • beidson's avatar
      WebCore: · fb57a0eb
      beidson authored
              Reviewed by Beth
      
              Move the Thread Safety Check functions into their own header for export to WebKit
      
              * WebCore.exp: Export the function
              * WebCore.xcodeproj/project.pbxproj: 
              * bindings/scripts/CodeGeneratorObjC.pm: Include the new header
              * platform/Logging.h: Move stuff to ThreadCheck.h
              * platform/ThreadCheck.h: Added.
              * platform/mac/LoggingMac.mm: Move stuff to ThreadCheck.mm
              * platform/mac/ThreadCheck.mm: Added.
              (WebCore::_WebCoreThreadViolationCheck):
              (WebCoreReportThreadViolation):
      
      WebKit:
      
              Reviewed by Beth
      
              Start using the Thread Safety Check implemented in WebCore for the DOM bindings in the rest of
              the WebKit API instead of the ASSERT_MAIN_THREAD() hack
      
              * History/WebBackForwardList.mm:
              (-[WebBackForwardList initWithWebCoreBackForwardList:]):
              (-[WebBackForwardList init]):
              (-[WebBackForwardList dealloc]):
              (-[WebBackForwardList finalize]):
              * History/WebHistoryItem.mm:
              (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
              (-[WebHistoryItem dealloc]):
              (-[WebHistoryItem finalize]):
              (-[WebHistoryItem copyWithZone:]):
              (-[WebHistoryItem initWithWebCoreHistoryItem:]):
              * Misc/WebIconDatabase.mm:
              (-[WebIconDatabase init]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb57a0eb
    • bdakin's avatar
      Reviewed by Brady. · a1cb81e1
      bdakin authored
              Fix for http://bugs.webkit.org/show_bug.cgi?id=12923 REGRESSION: 
              Assertion failure copying standalone image
      
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeImage): Use the CachedImage as the 
              resource. This makes more sense anyway. There is no need to null-
              check the renderer or the CachedImage since we return early if 
              there is no Image* and the HitTestResult::image() function checks 
              for these things.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1cb81e1