1. 10 Dec, 2010 3 commits
    • commit-queue@webkit.org's avatar
      2010-12-10 John Knottenbelt <jknotten@chromium.org> · 51d3357c
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              [Chromium] Implement mocks for client-based geolocation
              https://bugs.webkit.org/show_bug.cgi?id=46895
      
              * WebKit.gyp:
              * public/WebGeolocationClientMock.h: Added.
              (WebKit::WebGeolocationClientMock::~WebGeolocationClientMock):
              (WebKit::WebGeolocationClientMock::WebGeolocationClientMock):
              * src/WebGeolocationClientMock.cpp: Added.
              (WebKit::WebGeolocationClientMock::create):
              (WebKit::WebGeolocationClientMock::initialize):
              (WebKit::WebGeolocationClientMock::reset):
              (WebKit::WebGeolocationClientMock::setMockGeolocationPosition):
              (WebKit::WebGeolocationClientMock::setMockGeolocationError):
              (WebKit::WebGeolocationClientMock::setMockGeolocationPermission):
              (WebKit::WebGeolocationClientMock::resetMock):
              (WebKit::WebGeolocationClientMock::startUpdating):
              (WebKit::WebGeolocationClientMock::stopUpdating):
              (WebKit::WebGeolocationClientMock::setEnableHighAccuracy):
              (WebKit::WebGeolocationClientMock::geolocationDestroyed):
              (WebKit::WebGeolocationClientMock::setController):
              (WebKit::WebGeolocationClientMock::lastPosition):
              (WebKit::WebGeolocationClientMock::requestPermission):
              (WebKit::WebGeolocationClientMock::cancelPermissionRequest):
              * src/WebGeolocationServiceMock.cpp:
      2010-12-10  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Steve Block.
      
              [Chromium] Implement mocks for client-based geolocation
              https://bugs.webkit.org/show_bug.cgi?id=46895
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::setGeolocationPermission):
              (LayoutTestController::setMockGeolocationPosition):
              (LayoutTestController::setMockGeolocationError):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::geolocationClient):
              (WebViewHost::geolocationClientMock):
              (WebViewHost::reset):
              * DumpRenderTree/chromium/WebViewHost.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51d3357c
    • commit-queue@webkit.org's avatar
      2010-12-10 John Knottenbelt <jknotten@chromium.org> · 38560d2b
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              [chromium] Implement client based geolocation bindings
              https://bugs.webkit.org/show_bug.cgi?id=45752
      
              Implements the necessary plumbing to expose client-based geolocation in Chromium
              webkit. The plan is to remove the non-client-based geolocation code (GeolocationService*)
              in the future.
      
              * WebKit.gyp:
              * public/WebGeolocationClient.h: Added.
              (WebKit::WebGeolocationClient::~WebGeolocationClient):
              * public/WebGeolocationController.h: Added.
              (WebKit::WebGeolocationController::WebGeolocationController):
              (WebKit::WebGeolocationController::reset):
              * public/WebGeolocationError.h:
              * public/WebGeolocationPermissionRequest.h: Added.
              (WebKit::WebGeolocationPermissionRequest::WebGeolocationPermissionRequest):
              (WebKit::WebGeolocationPermissionRequest::geolocation):
              * public/WebGeolocationPermissionRequestManager.h: Added.
              (WebKit::WebGeolocationPermissionRequestManager::WebGeolocationPermissionRequestManager):
              (WebKit::WebGeolocationPermissionRequestManager::~WebGeolocationPermissionRequestManager):
              * public/WebGeolocationPosition.h:
              * public/WebViewClient.h:
              (WebKit::WebViewClient::geolocationClient):
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
              (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
              * src/GeolocationClientProxy.cpp: Added.
              (WebKit::GeolocationClientProxy::GeolocationClientProxy):
              (WebKit::GeolocationClientProxy::~GeolocationClientProxy):
              (WebKit::GeolocationClientProxy::setController):
              (WebKit::GeolocationClientProxy::geolocationDestroyed):
              (WebKit::GeolocationClientProxy::startUpdating):
              (WebKit::GeolocationClientProxy::stopUpdating):
              (WebKit::GeolocationClientProxy::setEnableHighAccuracy):
              (WebKit::GeolocationClientProxy::lastPosition):
              (WebKit::GeolocationClientProxy::requestPermission):
              (WebKit::GeolocationClientProxy::cancelPermissionRequest):
              * src/GeolocationClientProxy.h: Added.
              * src/WebGeolocationController.cpp: Added.
              (WebKit::WebGeolocationController::positionChanged):
              (WebKit::WebGeolocationController::errorOccurred):
              (WebKit::WebGeolocationController::controller):
              * src/WebGeolocationPermissionRequest.cpp: Added.
              (WebKit::WebGeolocationPermissionRequest::securityOrigin):
              (WebKit::WebGeolocationPermissionRequest::setIsAllowed):
              * src/WebGeolocationPermissionRequestManager.cpp: Added.
              (WebGeolocationPermissionRequestManager::add):
              (WebGeolocationPermissionRequestManager::remove):
              (WebGeolocationPermissionRequestManager::init):
              (WebGeolocationPermissionRequestManager::reset):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::WebViewImpl):
              * src/WebViewImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38560d2b
    • hans@chromium.org's avatar
      2010-12-10 Hans Wennborg <hans@chromium.org> · 6a1a6dfd
      hans@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Numeric keys are floats.
              https://bugs.webkit.org/show_bug.cgi?id=50674
      
              Update layout tests to use floating-point values for keys.
      
              * storage/indexeddb/keyrange-expected.txt:
              * storage/indexeddb/keyrange.html:
              Make sure creating the keys works.
              * storage/indexeddb/objectstore-cursor-expected.txt:
              * storage/indexeddb/objectstore-cursor.html:
              Make sure retrieving the keys from the DB objectstore works.
      2010-12-10  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Numeric keys are floats.
              https://bugs.webkit.org/show_bug.cgi?id=50674
      
              Use floating point to represent numeric keys,
              add version meta data to the SQLite db,
              and migrate object stores that use integers.
      
              * bindings/v8/IDBBindingUtilities.cpp:
              (WebCore::createIDBKeyFromValue):
              * bindings/v8/custom/V8IDBKeyCustom.cpp:
              (WebCore::toV8):
              * storage/IDBFactoryBackendImpl.cpp:
              (WebCore::createTables):
              (WebCore::migrateDatabase):
              (WebCore::IDBFactoryBackendImpl::open):
              * storage/IDBKey.cpp:
              (WebCore::IDBKey::IDBKey):
              (WebCore::IDBKey::fromQuery):
              (WebCore::IDBKey::bind):
              (WebCore::IDBKey::bindWithNulls):
              * storage/IDBKey.h:
              (WebCore::IDBKey::create):
              (WebCore::IDBKey::number):
      2010-12-10  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Numeric keys are floats.
              https://bugs.webkit.org/show_bug.cgi?id=50674
      
              Represent numeric keys as floating point values.
      
              * public/WebIDBKey.h:
              (WebKit::WebIDBKey::WebIDBKey):
              * src/WebIDBKey.cpp:
              (WebKit::WebIDBKey::assign):
              (WebKit::WebIDBKey::number):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a1a6dfd
  2. 09 Dec, 2010 2 commits
    • hans@chromium.org's avatar
      2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com> · c60f78d5
      hans@chromium.org authored
              Unreviewed, rolling out r73616.
              http://trac.webkit.org/changeset/73616
              https://bugs.webkit.org/show_bug.cgi?id=50772
      
              Breaks chromium win build (Requested by hwennborg on #webkit).
      
              * public/WebIDBKey.h:
              (WebKit::WebIDBKey::WebIDBKey):
              * src/WebIDBKey.cpp:
              (WebKit::WebIDBKey::assign):
              (WebKit::WebIDBKey::number):
      2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73616.
              http://trac.webkit.org/changeset/73616
              https://bugs.webkit.org/show_bug.cgi?id=50772
      
              Breaks chromium win build (Requested by hwennborg on #webkit).
      
              * bindings/v8/IDBBindingUtilities.cpp:
              (WebCore::createIDBKeyFromValue):
              * bindings/v8/custom/V8IDBKeyCustom.cpp:
              (WebCore::toV8):
              * storage/IDBFactoryBackendImpl.cpp:
              (WebCore::createTables):
              (WebCore::IDBFactoryBackendImpl::open):
              * storage/IDBKey.cpp:
              (WebCore::IDBKey::IDBKey):
              (WebCore::IDBKey::fromQuery):
              (WebCore::IDBKey::bind):
              (WebCore::IDBKey::bindWithNulls):
              * storage/IDBKey.h:
              (WebCore::IDBKey::create):
              (WebCore::IDBKey::number):
      2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73616.
              http://trac.webkit.org/changeset/73616
              https://bugs.webkit.org/show_bug.cgi?id=50772
      
              Breaks chromium win build (Requested by hwennborg on #webkit).
      
              * storage/indexeddb/index-basics-expected.txt:
              * storage/indexeddb/index-basics.html:
              * storage/indexeddb/index-cursor.html:
              * storage/indexeddb/keyrange-expected.txt:
              * storage/indexeddb/keyrange.html:
              * storage/indexeddb/objectstore-cursor.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c60f78d5
    • hans@chromium.org's avatar
      2010-12-09 Hans Wennborg <hans@chromium.org> · 976f357f
      hans@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Numeric keys are floats.
              https://bugs.webkit.org/show_bug.cgi?id=50674
      
              Update layout tests to use floating-point values for keys.
      
              * storage/indexeddb/keyrange-expected.txt:
              * storage/indexeddb/keyrange.html:
              Make sure creating the keys works.
              * storage/indexeddb/objectstore-cursor-expected.txt:
              * storage/indexeddb/objectstore-cursor.html:
              Make sure retrieving the keys from the DB objectstore works.
      2010-12-09  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Numeric keys are floats.
              https://bugs.webkit.org/show_bug.cgi?id=50674
      
              Use floating point to represent numeric keys,
              add version meta data to the SQLite db,
              and migrate object stores that use integers.
      
              * bindings/v8/IDBBindingUtilities.cpp:
              (WebCore::createIDBKeyFromValue):
              * bindings/v8/custom/V8IDBKeyCustom.cpp:
              (WebCore::toV8):
              * storage/IDBFactoryBackendImpl.cpp:
              (WebCore::createTables):
              (WebCore::migrateDatabase):
              (WebCore::IDBFactoryBackendImpl::open):
              * storage/IDBKey.cpp:
              (WebCore::IDBKey::IDBKey):
              (WebCore::IDBKey::fromQuery):
              (WebCore::IDBKey::bind):
              (WebCore::IDBKey::bindWithNulls):
              * storage/IDBKey.h:
              (WebCore::IDBKey::create):
              (WebCore::IDBKey::number):
      2010-12-09  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Numeric keys are floats.
              https://bugs.webkit.org/show_bug.cgi?id=50674
      
              Represent numeric keys as floating point values.
      
              * public/WebIDBKey.h:
              (WebKit::WebIDBKey::WebIDBKey):
              * src/WebIDBKey.cpp:
              (WebKit::WebIDBKey::assign):
              (WebKit::WebIDBKey::number):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      976f357f
  3. 08 Dec, 2010 1 commit
    • bweinstein@apple.com's avatar
      Layering Violation in ContextMenu - member variable of type HitTestResult · ff7b94c4
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50586
              
      Reviewed by John Sullivan.
      
      WebCore: 
      
      ContextMenu had a layering violation by having a member variable of type HitTestResult, because
      classes in WebCore/platform can't know about classes in WebCore.
              
      This patch moves the HitTestResult and all functions that use it out of ContextMenu into ContextMenuController.
      All of the functions that dealt with populating the ContextMenu are now in ContextMenuController, and this
      allowed us to delete the ContextMenu file, putting all of the cross-platform code that used to be it
      in ContextMenuController, and the rest of the code is in the platform-specific files.
      
      No change in behavior, no new tests.
      
      * Android.mk: Removed ContextMenu.cpp.
      * CMakeLists.txt: Ditto.
      * GNUmakefile.am: Ditto.
      * WebCore.gypi: Ditto.
      * WebCore.pro: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::ContextMenuController): Initialized m_hitTestResult to an empty HitTestResult.
      (WebCore::ContextMenuController::handleContextMenuEvent): Call populate on the ContextMenuController instead
          of the ContextMenu.
      (WebCore::ContextMenuController::createContextMenu): Fix some indination, and store the HitTestResult in a member
          variable.
      (WebCore::ContextMenuController::showContextMenu): Call addInspectElementItem on the ContextMenuController.
      (WebCore::ContextMenuController::contextMenuItemSelected): Use m_hitTestResult whenever we need a HitTestResult.
      (WebCore::ContextMenuController::appendItem): Validates the item for its state, and then appends it to the parent menu.
          This allowed us to move checkOrEnableIfNeeded from ContextMenu.
      
      These functions were all moved from ContextMenu, and changed slightly to fit in ContextMenuController.
      All calls to ContextMenu::appendItem were changed to ContextMenuController::appendItem, which takes care
      of validating the menu.
      (WebCore::separatorItem): Moved from ContextMenu.
      (WebCore::ContextMenuController::createAndAppendFontSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendSpeechSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendWritingDirectionSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendTextDirectionSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendSubstitutionsSubMenu): Ditto.
      (WebCore::ContextMenuController::createAndAppendTransformationsSubMenu): Ditto.
      (WebCore::selectionContainsPossibleWord): Ditto.
      (WebCore::ContextMenuController::populate): Ditto.
      (WebCore::ContextMenuController::addInspectElementItem): Ditto.
      (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
              
      * page/ContextMenuController.h:
      (WebCore::ContextMenuController::hitTestResult): Returns the HitTestResult of the current ContextMenu.
      
      * platform/ContextMenu.cpp: Removed.
      * platform/ContextMenu.h:
      * platform/efl/ContextMenuEfl.cpp:
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
      * platform/gtk/ContextMenuGtk.cpp:
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (WebCore::ContextMenu::appendItem): Ditto.
      * platform/haiku/ContextMenuHaiku.cpp:
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (WebCore::ContextMenu::appendItem): Ditto.
      (WebCore::ContextMenu::insertItem): Ditto.
      * platform/mac/ContextMenuMac.mm:
      (-[WebCoreMenuTarget validateMenuItem:]): Calls checkOrEnableIfNeeded on the controller instead of
          the context menu.
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
      (WebCore::ContextMenu::insertItem): Ditto.
      * platform/win/ContextMenuWin.cpp:
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (WebCore::ContextMenu::insertItem): Removed the call to checkOrEnableIfNeeded.
      * platform/wx/ContextMenuWx.cpp:
      (WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
      (ContextMenu::appendItem): Ditto.
      
      WebKit/chromium: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::selectMisspelledWord):
      (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
      
      WebKit/gtk: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * WebCoreSupport/ContextMenuClientGtk.cpp:
      (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems):
      
      WebKit/mac: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * WebCoreSupport/WebContextMenuClient.mm:
      (WebContextMenuClient::getCustomMenuFromDefaultItems):
      (WebContextMenuClient::contextMenuItemSelected):
      * WebView/WebHTMLView.mm:
      (-[WebMenuTarget validateMenuItem:]):
      
      WebKit/qt: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::createContextMenu):
      (QWebPage::updatePositionDependentActions):
      
      WebKit/win: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the 
          ContextMenuController (from the page).
      (WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.
      * WebView.cpp:
      (WebView::handleContextMenuEvent): Ditto.
      
      WebKit2: 
      
      Update users of ContextMenu and ContextMenuController to match where the new functions 
      are located.
      
      * Shared/WebContextMenuItemData.cpp:
      (WebKit::WebContextMenuItemData::WebContextMenuItemData): Remove the call to checkOrEnableItem, that call will be made when
          the ContextMenuItem is added to the ContextMenu through the ContextMenuController.
      * WebProcess/WebPage/WebContextMenu.cpp:
      (WebKit::WebContextMenu::show):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff7b94c4
  4. 07 Dec, 2010 3 commits
    • darin@apple.com's avatar
      2010-12-06 Darin Adler <darin@apple.com> · 1cf3d560
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              Pass security origin to make local file decision correctly
              https://bugs.webkit.org/show_bug.cgi?id=48603
      
              * src/ApplicationCacheHost.cpp:
              (WebCore::ApplicationCacheHost::selectCacheWithManifest): Pass security origin.
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::dispatchCreatePage): Ditto.
              (WebKit::FrameLoaderClientImpl::createFrame): Ditto.
              * src/WebPluginContainerImpl.cpp:
              (WebKit::WebPluginContainerImpl::loadFrameRequest): Ditto.
      2010-12-06  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Pass security origin to make local file decision correctly
              https://bugs.webkit.org/show_bug.cgi?id=48603
      
              * Api/qwebpage.cpp:
              (frameLoadRequest): Pass security origin.
      2010-12-06  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Pass security origin to make local file decision correctly
              https://bugs.webkit.org/show_bug.cgi?id=48603
      
              * WebCoreSupport/WebContextMenuClient.cpp:
              (WebContextMenuClient::searchWithGoogle): Pass security origin.
      2010-12-06  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Pass security origin to make local file decision correctly
              https://bugs.webkit.org/show_bug.cgi?id=48603
      
              * WebView/WebPDFView.mm:
              (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
      2010-12-06  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Pass security origin to make local file decision correctly
              https://bugs.webkit.org/show_bug.cgi?id=48603
      
              * bindings/generic/BindingDOMWindow.h:
              (WebCore::BindingDOMWindow::createWindow): Pass security origin.
              (WebCore::BindingDOMWindow::open): Ditto.
              * bindings/generic/BindingFrame.h:
              (WebCore::BindingFrame::navigateIfAllowed): Ditto.
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation): Pass security origin.
              (WebCore::createWindow): Ditto.
              (WebCore::JSDOMWindow::open): Ditto.
      
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::setLocation): Pass security origin.
      
              * dom/Document.cpp:
              (WebCore::Document::processHttpEquiv): Pass security origin.
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::openInInspectedWindow):
              Pass security origin.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::changeLocation): Added a security origin
              argument, passed through to urlSelected.
              (WebCore::FrameLoader::urlSelected): Replaced the resource request
              and frame name arguments with a frame load request arguments in one
              overload, and changed the other overload to pass in the current
              frame's document for the security origin.
              (WebCore::FrameLoader::loadFrameRequest): Moved the canDisplay
              check before the referrer computation because it no longer needs
              to look at the referrer. Replaced the call to canDisplay that
              used the target frame's security origin and the call to
              deprecatedCanDisplay with a single call to canDisplay that uses
              the requester security origin.
      
              * loader/FrameLoader.h: Updated for argument changes above.
      
              * loader/NavigationScheduler.cpp:
              (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): Added
              a security origin.
              (WebCore::ScheduledURLNavigation::fire): Pass the security origin
              in to FrameLoader::changeLocation.
              (WebCore::ScheduledURLNavigation::securityOrigin): Added.
              (WebCore::ScheduledRedirect::ScheduledRedirect): Added a security
              origin argument.
              (WebCore::ScheduledLocationChange::ScheduledLocationChange): Ditto.
              (WebCore::ScheduledRefresh::ScheduledRefresh): Ditto.
              (WebCore::ScheduledRefresh::fire): Pass the security origin in to
              FrameLoader::changeLocation.
              (WebCore::ScheduledFormSubmission::fire): Include the security
              origin when constructing form submission.
              (WebCore::NavigationScheduler::scheduleRedirect): Include the security
              origin when creating the scheduled navigation object.
              (WebCore::NavigationScheduler::scheduleLocationChange): Ditto.
              (WebCore::NavigationScheduler::scheduleRefresh): Ditto.
      
              * loader/NavigationScheduler.h: Added the security origin argument
              to scheduleLocationChange.
      
              * loader/SubframeLoader.cpp:
              (WebCore::SubframeLoader::loadOrRedirectSubframe): Pass in the security
              origin when calling scheduleLocationChange.
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::selectCache): Ditto.
      
              * page/ContextMenuController.cpp:
              (WebCore::openNewWindow): Pass in the security origin.
              (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
      
              * page/FrameLoadRequest.h: Added a security origin called the requester
              to all FrameLoadRequest objects.
      
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::findInRequest): Added the security origin.
      2010-12-06  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Pass security origin to make local file decision correctly
              https://bugs.webkit.org/show_bug.cgi?id=48603
      
              * WebProcess/Plugins/PluginView.cpp:
              (WebKit::PluginView::loadURL): Pass security origin.
              * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebKit::WebFrameLoaderClient::dispatchCreatePage): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cf3d560
    • mrobinson@webkit.org's avatar
      2010-12-07 Martin Robinson <mrobinson@igalia.com> · c289de6a
      mrobinson@webkit.org authored
              Unreviewed, rolling out r73392.
              http://trac.webkit.org/changeset/73392
              https://bugs.webkit.org/show_bug.cgi?id=50489
      
              This commit caused crashes on the GTK+ bots
      
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::executeIfJavaScriptURL):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::close):
              (WebCore::Document::lastModified):
              (WebCore::Document::finishedParsing):
              (WebCore::Document::initSecurityContext):
              (WebCore::Document::updateURLForPushOrReplaceState):
              * dom/Document.h:
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::checkStyleSheet):
              * dom/ScriptElement.cpp:
              (WebCore::ScriptElement::scriptCharset):
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::process):
              * html/MediaDocument.cpp:
              (WebCore::MediaDocument::replaceMediaElementTimerFired):
              * html/PluginDocument.cpp:
              (WebCore::PluginDocumentParser::createDocumentStructure):
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::DocumentLoader):
              (WebCore::DocumentLoader::finishedLoading):
              (WebCore::DocumentLoader::commitData):
              (WebCore::DocumentLoader::setupForReplaceByMIMEType):
              (WebCore::DocumentLoader::setFrame):
              * loader/DocumentLoader.h:
              * loader/DocumentWriter.cpp:
              (WebCore::DocumentWriter::begin):
              * loader/DocumentWriter.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::FrameLoader):
              (WebCore::FrameLoader::init):
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::receivedFirstData):
              (WebCore::FrameLoader::transitionToCommitted):
              (WebCore::FrameLoader::open):
              (WebCore::FrameLoader::finishedLoadingDocument):
              (WebCore::FrameLoader::addExtraFieldsToRequest):
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::writer):
              * loader/cache/CachedResourceLoader.cpp:
              (WebCore::CachedResourceLoader::requestPreload):
              * platform/network/FormDataBuilder.cpp:
              (WebCore::FormDataBuilder::encodingFromAcceptCharset):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged):
      2010-12-07  Martin Robinson  <mrobinson@igalia.com>
      
              Unreviewed, rolling out r73392.
              http://trac.webkit.org/changeset/73392
              https://bugs.webkit.org/show_bug.cgi?id=50489
      
              This commit caused crashes on the GTK+ bots
      
              * src/ContextMenuClientImpl.cpp:
              (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::finishedLoading):
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::encoding):
              (WebKit::WebFrameImpl::loadJavaScriptURL):
              * src/WebPageSerializerImpl.cpp:
              (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
              (WebKit::WebPageSerializerImpl::serialize):
              * src/WebSearchableFormData.cpp:
              (WebCore::GetFormEncoding):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::pageEncoding):
      2010-12-07  Martin Robinson  <mrobinson@igalia.com>
      
              Unreviewed, rolling out r73392.
              http://trac.webkit.org/changeset/73392
              https://bugs.webkit.org/show_bug.cgi?id=50489
      
              This commit caused crashes on the GTK+ bots
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::finishedLoading):
              * webkit/webkitwebview.cpp:
              (webkit_web_view_get_encoding):
      2010-12-07  Martin Robinson  <mrobinson@igalia.com>
      
              Unreviewed, rolling out r73392.
              http://trac.webkit.org/changeset/73392
              https://bugs.webkit.org/show_bug.cgi?id=50489
      
              This commit caused crashes on the GTK+ bots
      
              * WebView/WebFrame.mm:
              (-[WebFrame _canProvideDocumentSource]):
      2010-12-07  Martin Robinson  <mrobinson@igalia.com>
      
              Unreviewed, rolling out r73392.
              http://trac.webkit.org/changeset/73392
              https://bugs.webkit.org/show_bug.cgi?id=50489
      
              This commit caused crashes on the GTK+ bots
      
              * Api/qwebframe.cpp:
              (QWebFrame::setUrl):
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::finishedLoading):
      2010-12-07  Martin Robinson  <mrobinson@igalia.com>
      
              Unreviewed, rolling out r73392.
              http://trac.webkit.org/changeset/73392
              https://bugs.webkit.org/show_bug.cgi?id=50489
      
              This commit caused crashes on the GTK+ bots
      
              * WebCoreSupport/FrameLoaderClientWinCE.cpp:
              (WebKit::FrameLoaderClientWinCE::finishedLoading):
      2010-12-07  Martin Robinson  <mrobinson@igalia.com>
      
              Unreviewed, rolling out r73392.
              http://trac.webkit.org/changeset/73392
              https://bugs.webkit.org/show_bug.cgi?id=50489
      
              This commit caused crashes on the GTK+ bots
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::finishedLoading):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c289de6a
    • tkent@chromium.org's avatar
      2010-12-07 Kenichi Ishibashi <bashi@google.com> · 995765c6
      tkent@chromium.org authored
              Reviewed by Kent Tamura.
      
              Let HTMLObjectElement be a form associated element
              https://bugs.webkit.org/show_bug.cgi?id=48821
      
              Introduces FormAssociatedElement class which would be a super class
              of form assocated elements. Some of member functions and variables of
              HTMLFormControlElement are migrated into this class.
              Following the HTML5 spec, HTMLFormControlElement class and
              HTMLObjectElement class are subclasses of it for now.
      
              Test: fast/forms/form-collection-elements-order.html
      
              * Android.mk: Added FormAssociatedElement.cpp
              * CMakeLists.txt: Ditto.
              * GNUmakefile.am: Added FormAssociatedElement.{cpp,h}
              * WebCore.exp.in: Added the symbol for toHTMLElement(FormAssociatedElement*)
              * WebCore.gypi: Added FormAssociatedElement.{cpp,h}
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * dom/CheckedRadioButtons.h: Fixed class forward declaration order.
              * dom/Document.cpp:
              (WebCore::Document::registerFormElementWithFormAttribute): Modified to
              use FormAssociatedElement instead of HTMLFormControlElement
              (WebCore::Document::unregisterFormElementWithFormAttribute): Ditto.
              (WebCore::Document::resetFormElementsOwner):
              * dom/Document.h: Ditto.
              * html/DOMFormData.cpp: Ditto.
              (WebCore::DOMFormData::DOMFormData):
              * html/FormAssociatedElement.cpp: Copied and renamed from WebCore/html/HTMLFormControlElement.cpp.
              (WebCore::FormAssociatedElement::FormAssociatedElement):
              (WebCore::FormAssociatedElement::~FormAssociatedElement):
              (WebCore::FormAssociatedElement::validity):
              (WebCore::FormAssociatedElement::insertedIntoTree):
              (WebCore::FormAssociatedElement::removedFromTree):
              (WebCore::FormAssociatedElement::removeFromForm):
              (WebCore::FormAssociatedElement::resetFormOwner):
              (WebCore::FormAssociatedElement::formAttributeChanged):
              (WebCore::toHTMLElement):
              * html/FormAssociatedElement.h: Ditto.
              (WebCore::FormAssociatedElement::ref):
              (WebCore::FormAssociatedElement::deref):
              (WebCore::FormAssociatedElement::formDestroyed):
              (WebCore::FormAssociatedElement::setForm):
              * html/HTMLElement.h: Changed the access level of findFormAncestor().
              * html/HTMLFormCollection.cpp:
              (WebCore::HTMLFormCollection::item): Modified to use FormAssociatedElement
              instead of HTMLFormControlElement.
              (WebCore::HTMLFormCollection::getNamedFormItem): Ditto.
              (WebCore::HTMLFormCollection::updateNameCache): Ditto.
              * html/HTMLFormControlElement.cpp: Modified regarding with the change of class
              hierarchy.
              (WebCore::HTMLFormControlElement::HTMLFormControlElement):
              (WebCore::HTMLFormControlElement::~HTMLFormControlElement):
              (WebCore::HTMLFormControlElement::insertedIntoTree):
              (WebCore::HTMLFormControlElement::removedFromTree):
              (WebCore::HTMLFormControlElement::supportsFocus):
              (WebCore::HTMLFormControlElement::checkValidity):
              (WebCore::HTMLFormControlElement::virtualForm):
              (WebCore::HTMLFormControlElement::isDefaultButtonForForm):
              (WebCore::HTMLFormControlElement::attributeChanged):
              * html/HTMLFormControlElement.h: Ditto.
              (WebCore::HTMLFormControlElement::form):
              (WebCore::HTMLFormControlElement::disabled):
              (WebCore::HTMLFormControlElement::type):
              (WebCore::HTMLFormControlElement::refFormAssociatedElement):
              (WebCore::HTMLFormControlElement::derefFormAssociatedElement):
              * html/HTMLFormElement.cpp: Modified to use FormAssociatedElement
              instead of HTMLFormControlElement.
              (WebCore::HTMLFormElement::submitImplicitly):
              (WebCore::HTMLFormElement::validateInteractively):
              (WebCore::HTMLFormElement::submit):
              (WebCore::HTMLFormElement::reset):
              (WebCore::HTMLFormElement::formElementIndexWithFormAttribute):
              (WebCore::HTMLFormElement::formElementIndex):
              (WebCore::HTMLFormElement::registerFormElement):
              (WebCore::HTMLFormElement::removeFormElement):
              (WebCore::HTMLFormElement::defaultButton):
              (WebCore::HTMLFormElement::checkValidity):
              (WebCore::HTMLFormElement::collectUnhandledInvalidControls):
              (WebCore::HTMLFormElement::documentDidBecomeActive):
              * html/HTMLFormElement.h: Ditto.
              (WebCore::HTMLFormElement::associatedElements):
              * html/HTMLInputElement.cpp: Ditto.
              (WebCore::HTMLInputElement::updateCheckedRadioButtons):
              * html/HTMLObjectElement.cpp: Modified regarding with the change of class
              hierarchy.
              (WebCore::HTMLObjectElement::HTMLObjectElement):
              (WebCore::HTMLObjectElement::~HTMLObjectElement):
              (WebCore::HTMLObjectElement::create):
              (WebCore::HTMLObjectElement::attributeChanged):
              (WebCore::HTMLObjectElement::insertedIntoTree):
              (WebCore::HTMLObjectElement::removedFromTree):
              (WebCore::HTMLObjectElement::appendFormData):
              (WebCore::HTMLObjectElement::formControlName):
              * html/HTMLObjectElement.h: Ditto.
              (WebCore::HTMLObjectElement::form):
              (WebCore::HTMLObjectElement::isFormControlElement):
              (WebCore::HTMLObjectElement::isEnumeratable):
              (WebCore::HTMLObjectElement::refFormAssociatedElement):
              (WebCore::HTMLObjectElement::derefFormAssociatedElement):
              * html/HTMLTagNames.in: Added constructorNeedsFormElement to object tag.
              * html/ValidationMessage.cpp: Modified to use FormAssociatedElement
              instead of HTMLFormControlElement.
              (WebCore::ValidationMessage::ValidationMessage):
              (WebCore::ValidationMessage::create):
              * html/ValidationMessage.h: Ditto.
              * html/ValidityState.cpp: Ditto.
              (WebCore::ValidityState::validationMessage):
              (WebCore::ValidityState::setCustomErrorMessage):
              (WebCore::ValidityState::valueMissing):
              (WebCore::ValidityState::typeMismatch):
              (WebCore::ValidityState::patternMismatch):
              (WebCore::ValidityState::tooLong):
              (WebCore::ValidityState::rangeUnderflow):
              (WebCore::ValidityState::rangeOverflow):
              (WebCore::ValidityState::stepMismatch):
              * html/ValidityState.h: Ditto.
              (WebCore::ValidityState::create):
              (WebCore::ValidityState::ValidityState):
              * loader/FormSubmission.cpp: Ditto.
              (WebCore::FormSubmission::create):
      
      2010-12-07  Kenichi Ishibashi  <bashi@google.com>
      
              Reviewed by Kent Tamura.
      
              Let HTMLObjectElement be a form associated element
              https://bugs.webkit.org/show_bug.cgi?id=48821
      
              Modified to use FormAssociatedElement instead of HTMLFormControlElement.
      
              * src/WebFormElement.cpp: 
              (WebKit::WebFormElement::getFormControlElements): Modified to use
              FormAssociatedElement instead of HTMLFormControlElement.
              * src/WebPasswordFormUtils.cpp:
              (WebKit::findPasswordFormFields): Ditto.
              * src/WebSearchableFormData.cpp:
              (WebCore::GetButtonToActivate): Ditto.
              (WebCore::HasSuitableTextElement): Ditto.
      
      2010-12-07  Kenichi Ishibashi  <bashi@google.com>
      
              Reviewed by Kent Tamura.
      
              Let HTMLObjectElement be a form associated element
              https://bugs.webkit.org/show_bug.cgi?id=48821
      
              Modified to use FormAssociatedElement instead of HTMLFormControlElement.
      
              * WebFrame.cpp:
              (WebFrame::elementWithName): Modified to use FormAssociatedElement
              instead of HTMLFormControlElement.
              (WebFrame::controlsInForm): Ditto.
      
      2010-12-07  Kenichi Ishibashi  <bashi@google.com>
      
              Reviewed by Kent Tamura.
      
              Let HTMLObjectElement be a form associated element
              https://bugs.webkit.org/show_bug.cgi?id=48821
      
              Modified to use FormAssociatedElement instead of HTMLFormControlElement.
      
              * WebView/WebHTMLRepresentation.mm:
              (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
              FormAssociatedElement instead of HTMLFormControlElement.
              (-[WebHTMLRepresentation controlsInForm:]): Ditto.
      
      2010-12-07  Kenichi Ishibashi  <bashi@google.com>
      
              Reviewed by Kent Tamura.
      
              Let HTMLObjectElement be a form associated element
              https://bugs.webkit.org/show_bug.cgi?id=48821
      
              Adds a test to ensure the order of form.elements attribute.
              Updates two tests to check whether object elements are handled
              correctly in form.elements attribute.
      
              * fast/forms/form-attribute-expected.txt: Updated.
              * fast/forms/form-collection-elements-order-expected.txt: Added.
              * fast/forms/form-collection-elements-order.html: Added.
              * fast/forms/script-tests/form-attribute.js: Updated.
              * fast/forms/script-tests/form-collection-elements-order.js: Added.
              (checkOrder):
              * fast/forms/script-tests/form-collection-elements.js: Updated.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      995765c6
  5. 06 Dec, 2010 1 commit
    • japhet@chromium.org's avatar
      2010-12-06 Nate Chapin <japhet@chromium.org> · facaf0bc
      japhet@chromium.org authored
              Reviewed by Adam Barth.
      
              Make DocumentWriter a member of DocumentLoader
              instead of FrameLoader.
              https://bugs.webkit.org/show_bug.cgi?id=50489
      
              Refactor, no new tests.
      
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::executeIfJavaScriptURL):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::close):
              (WebCore::Document::lastModified):
              (WebCore::Document::finishedParsing):
              (WebCore::Document::initSecurityContext):
              (WebCore::Document::updateURLForPushOrReplaceState):
              * dom/Document.h:
              (WebCore::Document::setDocumentLoader):
              (WebCore::Document::loader):
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::checkStyleSheet):
              * dom/ScriptElement.cpp:
              (WebCore::ScriptElement::scriptCharset):
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::process):
              * html/MediaDocument.cpp:
              (WebCore::MediaDocument::replaceMediaElementTimerFired):
              * html/PluginDocument.cpp:
              (WebCore::PluginDocumentParser::createDocumentStructure):
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::DocumentLoader):
              (WebCore::DocumentLoader::finishedLoading):
              (WebCore::DocumentLoader::commitData):
              (WebCore::DocumentLoader::setupForReplaceByMIMEType):
              (WebCore::DocumentLoader::setFrame):
              * loader/DocumentLoader.h:
              (WebCore::DocumentLoader::writer):
              * loader/DocumentWriter.h:
              (WebCore::DocumentWriter::setFrame):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::FrameLoader):
              (WebCore::FrameLoader::init):
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::receivedFirstData):
              (WebCore::FrameLoader::transitionToCommitted):
              (WebCore::FrameLoader::open):
              (WebCore::FrameLoader::finishedLoadingDocument):
              (WebCore::FrameLoader::addExtraFieldsToRequest):
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::notifier):
              * loader/cache/CachedResourceLoader.cpp:
              (WebCore::CachedResourceLoader::requestPreload):
              * platform/network/FormDataBuilder.cpp:
              (WebCore::FormDataBuilder::encodingFromAcceptCharset):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      facaf0bc
  6. 03 Dec, 2010 4 commits
    • commit-queue@webkit.org's avatar
      2010-12-03 Sheriff Bot <webkit.review.bot@gmail.com> · ed58500a
      commit-queue@webkit.org authored
              Unreviewed, rolling out r73302.
              http://trac.webkit.org/changeset/73302
              https://bugs.webkit.org/show_bug.cgi?id=50499
      
              Causes crashes in debug LayoutTests (Requested by xan_ on
              #webkit).
      
              * platform/win/Skipped:
      2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73302.
              http://trac.webkit.org/changeset/73302
              https://bugs.webkit.org/show_bug.cgi?id=50499
      
              Causes crashes in debug LayoutTests (Requested by xan_ on
              #webkit).
      
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::renderParentObject):
              (WebCore::AccessibilityRenderObject::addChildren):
              * accessibility/AccessibilityRenderObject.h:
              * accessibility/chromium/AccessibilityObjectChromium.cpp:
              (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
      2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73302.
              http://trac.webkit.org/changeset/73302
              https://bugs.webkit.org/show_bug.cgi?id=50499
      
              Causes crashes in debug LayoutTests (Requested by xan_ on
              #webkit).
      
              * public/WebAccessibilityObject.h:
              * src/WebAccessibilityObject.cpp:
              (WebKit::WebAccessibilityObject::parentObject):
      2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73302.
              http://trac.webkit.org/changeset/73302
              https://bugs.webkit.org/show_bug.cgi?id=50499
      
              Causes crashes in debug LayoutTests (Requested by xan_ on
              #webkit).
      
              * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
              (AccessibilityUIElement::AccessibilityUIElement):
              (AccessibilityUIElement::parentElementCallback):
              * DumpRenderTree/chromium/AccessibilityUIElement.h:
              * DumpRenderTree/chromium/CppBoundClass.cpp:
              * DumpRenderTree/chromium/CppBoundClass.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed58500a
    • loislo@chromium.org's avatar
      2010-12-01 Ilya Tikhonovsky <loislo@chromium.org> · 452cc2ae
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Inspector protocol cleanup task.
      
              The patch has just small renames and adjustments for the protocol things.
              'handler' keyword in idl file was replaced with 'domain'.
              'domain' property was assigned for the each backend to frontend messages.
              At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
      
              https://bugs.webkit.org/show_bug.cgi?id=50337
      
              * inspector/CodeGeneratorInspector.pm:
              * inspector/Inspector.idl:
              * inspector/front-end/inspector.js:
              (WebInspector_syncDispatch):
      
      2010-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: Inspector protocol cleanup task.
      
              The patch has just small renames and adjustments for the protocol things.
              'handler' keyword in idl file was replaced with 'domain'.
              'domain' property was assigned for the each backend to frontend messages.
              At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
      
              https://bugs.webkit.org/show_bug.cgi?id=50337
      
              * src/WebDevToolsFrontendImpl.cpp:
              (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
      
      2010-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: Inspector protocol cleanup task.
      
              The patch has just small renames and adjustments for the protocol things.
              'handler' keyword in idl file was replaced with 'domain'.
              'domain' property was assigned for the each backend to frontend messages.
              At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
      
              https://bugs.webkit.org/show_bug.cgi?id=50337
      
              * inspector/report-API-errors-expected.txt:
              * inspector/report-API-errors.html:
              * inspector/report-protocol-errors-expected.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      452cc2ae
    • commit-queue@webkit.org's avatar
      2010-12-03 Chris Guillory <chris.guillory@google.com> · 99bc0f33
      commit-queue@webkit.org authored
              Reviewed by Chris Fleizach.
      
              Include the FrameView widget of a RenderWidget in the accessibility tree.
              https://bugs.webkit.org/show_bug.cgi?id=49106
      
              * platform/win/Skipped:
      2010-12-03  Chris Guillory  <chris.guillory@google.com>
      
              Reviewed by Chris Fleizach.
      
              Include the FrameView widget of a RenderWidget in the accessibility tree.
              https://bugs.webkit.org/show_bug.cgi?id=49106
      
              Include render widget children in the accessibility tree for not mac webkit ports.
      
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::renderParentObject):
              (WebCore::AccessibilityRenderObject::addChildren):
              (WebCore::AccessibilityRenderObject::addRenderWidgetChildren):
              * accessibility/AccessibilityRenderObject.h:
              * accessibility/chromium/AccessibilityObjectChromium.cpp:
              (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
      2010-12-03  Chris Guillory  <chris.guillory@google.com>
      
              Reviewed by Chris Fleizach.
      
              Include the FrameView widget of a RenderWidget in the accessibility tree.
              https://bugs.webkit.org/show_bug.cgi?id=49106
      
              * public/WebAccessibilityObject.h:
              * src/WebAccessibilityObject.cpp:
              (WebKit::WebAccessibilityObject::equals):
              (WebKit::WebAccessibilityObject::parentObject):
      2010-12-03  Chris Guillory  <chris.guillory@google.com>
      
              Reviewed by Chris Fleizach.
      
              Include the FrameView widget of a RenderWidget in the accessibility tree.
              https://bugs.webkit.org/show_bug.cgi?id=49106
      
              * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
              (AccessibilityUIElement::AccessibilityUIElement):
              (AccessibilityUIElement::parentElementCallback):
              (AccessibilityUIElement::isEqualCallback):
              * DumpRenderTree/chromium/AccessibilityUIElement.h:
              * DumpRenderTree/chromium/CppBoundClass.cpp:
              (CppBoundClass::getFromCppVariant):
              * DumpRenderTree/chromium/CppBoundClass.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99bc0f33
    • jorlow@chromium.org's avatar
      2010-11-29 Jeremy Orlow <jorlow@chromium.org> · 526aaff5
      jorlow@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Clean up IndexedDB 2 sided roll bits
              https://bugs.webkit.org/show_bug.cgi?id=50160
      
              * public/WebIDBDatabase.h:
              (WebKit::WebIDBDatabase::version):
              (WebKit::WebIDBDatabase::objectStoreNames):
              (WebKit::WebIDBDatabase::deleteObjectStore):
              * public/WebIDBFactory.h:
              (WebKit::WebIDBFactory::open):
              * public/WebIDBKeyRange.h:
              * public/WebIDBObjectStore.h:
              (WebKit::WebIDBObjectStore::deleteFunction):
              * src/IDBDatabaseProxy.cpp:
              * src/IDBDatabaseProxy.h:
              * src/WebIDBKeyRange.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      526aaff5
  7. 02 Dec, 2010 5 commits
  8. 01 Dec, 2010 5 commits
    • darin@apple.com's avatar
      2010-12-01 Jia Pu <jpu@apple.com> · a5f05c0a
      darin@apple.com authored
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::getGuessesForWord):
              * src/EditorClientImpl.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::getGuessesForWord):
              * WebCoreSupport/EditorClientQt.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::getGuessesForWord):
              * WebCoreSupport/EditorClientGtk.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/WebEditorClient.cpp:
              (WebEditorClient::getGuessesForWord):
              * WebCoreSupport/WebEditorClient.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebKitSupport/EditorClientWx.cpp:
              (WebCore::EditorClientWx::getGuessesForWord):
              * WebKitSupport/EditorClientWx.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              This patch is for supporting multiple correction suggestion panel on Mac OS X.
              The behavior and implementation is similar to that of reversion candiate panel.
      
              * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
      
              * WebCoreSupport/WebEditorClient.mm:  Adopted new signatures defined in base class.
                Added code to handle new multiple suggestion canidate panel type.
              (WebEditorClient::showCorrectionPanel):
              (WebEditorClient::getGuessesForWord):
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::getGuessesForWord):
              * WebCoreSupport/EditorClientHaiku.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientWinCE.cpp:
              (WebKit::EditorClientWinCE::getGuessesForWord):
              * WebCoreSupport/EditorClientWinCE.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signature defined in base class.
      
              * WebCoreSupport/EditorClientEfl.cpp:
              (WebCore::EditorClientEfl::getGuessesForWord):
              * WebCoreSupport/EditorClientEfl.h:
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Test: platform/mac/editing/spelling/delete-autocorrected-word-1.html
              Manual test: WebCore/manual-tests/autocorrection/dismiss-multiple-guesses.html
                           WebCore/manual-tests/autocorrection/select-from-multiple-guesses.html
      
              This patch is for supporting multiple correction suggestion panel on Mac OS X.
              The behavior and implementation is similar to that of reversion candiate panel.
      
              * WebCore.exp.in: Added and removed symbols.
      
              * editing/CorrectionPanelInfo.h: Added new correction panel type, PanelTypeSpellingSuggestions.
      
              * editing/Editor.cpp:
              (WebCore::markerTypesForAutocorrection): Convenient function for getting marker types to
                be added to autocorrected word.
              (WebCore::boundingBoxForRange): Convenient function for calculating the bounding box of a range.
              (WebCore::markerTypesForReplacement): Convenient function for getting marker types to
                be added to word that has been replaced by various correction panel.
              (WebCore::Editor::respondToChangedSelection): Added code to trigger timer for multiple
                suggestion panel.
              (WebCore::Editor::guessesForMisspelledSelection): Adopted new signature of EditorClient::getGuessesForWord().
              (WebCore::Editor::markMisspellingsAfterTypingToWord): Adopted new signature of applyCorrectionPanelInfo().
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
              (WebCore::Editor::correctionPanelTimerFired): Added code to handle new multiple suggestion panel.
              (WebCore::Editor::handleCorrectionPanelResult): Replaced handleRejectedCorrection(), since
                with new AppKit correction panel API, not only rejection, but also confirmation can be
                handled in callback.
              (WebCore::Editor::stopCorrectionPanelTimer): Moved the code that clears correction panel info
                from dismissCorrectionPanel() to this function to fix a bug that would occur when deleting
                autocorrected word.
              (WebCore::Editor::dismissCorrectionPanel): Ditto.
              (WebCore::Editor::applyCorrectionPanelInfo): Added code to handle new multiple suggestion panel.
      
              * editing/Editor.h: Replaced handleRejectedCorrection() with handleCorrectionPanelResult().
                Changed the signature of applyCorrectionPanelInfo() to hanlde new correction panel type.
      
              * editing/TextCheckingHelper.cpp:
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Adopted new EditorClient::getGuessesForWord().
      
              * editing/TextCheckingHelper.h: Made paragraphRange() public.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature defined in base class.
              (WebCore::EmptyEditorClient::getGuessesForWord): Ditto.
      
              * manual-tests/autocorrection/dismiss-multiple-guesses.html: Added.
      
              * manual-tests/autocorrection/select-from-multiple-guesses.html: Added.
      
              * page/EditorClient.h:  Changed showCorrectionPanel() to allow passing multiple correction
                candidates. Changed getGuessesForWord() to allow passing in contextual text for better
                correction suggestions (for those spellcheckers that utilizes such contextual information).
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt: Added.
              * platform/mac/editing/spelling/delete-autocorrected-word-1.html: Added.
      2010-12-01  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Support multiple correction candidates panel for misspelled word on Mac OS X.
              https://bugs.webkit.org/show_bug.cgi?id=50137
              <rdar://problem/8568059>
      
              Adopted new function signatures defined in base class.
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp:
              (WebKit::WebEditorClient::getGuessesForWord):
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              (WebKit::WebEditorClient::showCorrectionPanel):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5f05c0a
    • kbr@google.com's avatar
      2010-12-01 Alexey Marinichev <amarinichev@chromium.org> · e3b81f7a
      kbr@google.com authored
              Reviewed by James Robinson.
      
              [chromium] renderer does not realize hardware compositing is disabled and crashes
              https://bugs.webkit.org/show_bug.cgi?id=50264
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::setRootGraphicsLayer): repaint always
              (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): null check
              (WebKit::WebViewImpl::reallocateRenderer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3b81f7a
    • vangelis@chromium.org's avatar
      2010-11-30 Vangelis Kokkevis <vangelis@chromium.org> · 27b033fd
      vangelis@chromium.org authored
              Reviewed by Darin Fisher.
      
              Get the value of the accelerated compositing triggers from the Settings
              class.  This allows setting the triggers via command line flags.
              https://bugs.webkit.org/show_bug.cgi?id=50301
      
              * public/WebSettings.h:
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::allowedCompositingTriggers):
              * src/WebSettingsImpl.cpp:
              (WebKit::WebSettingsImpl::setAcceleratedCompositingFor3DTransformsEnabled):
              (WebKit::WebSettingsImpl::setAcceleratedCompositingForVideoEnabled):
              (WebKit::WebSettingsImpl::setAcceleratedCompositingForPluginsEnabled):
              (WebKit::WebSettingsImpl::setAcceleratedCompositingForCanvasEnabled):
              (WebKit::WebSettingsImpl::setAcceleratedCompositingForAnimationEnabled):
              * src/WebSettingsImpl.h:
      2010-11-30  Vangelis Kokkevis  <vangelis@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Adds accelerated compositing trigger flags to Settings to allow
              ports to set them via command line flags, etc.
              https://bugs.webkit.org/show_bug.cgi?id=50301
      
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setAcceleratedCompositingFor3DTransformsEnabled):
              (WebCore::Settings::setAcceleratedCompositingForVideoEnabled):
              (WebCore::Settings::setAcceleratedCompositingForPluginsEnabled):
              (WebCore::Settings::setAcceleratedCompositingForCanvasEnabled):
              (WebCore::Settings::setAcceleratedCompositingForAnimationEnabled):
              * page/Settings.h:
              (WebCore::Settings::acceleratedCompositingFor3DTransformsEnabled):
              (WebCore::Settings::acceleratedCompositingForVideoEnabled):
              (WebCore::Settings::acceleratedCompositingForPluginsEnabled):
              (WebCore::Settings::acceleratedCompositingForCanvasEnabled):
              (WebCore::Settings::acceleratedCompositingForAnimationEnabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27b033fd
    • tony@chromium.org's avatar
      2010-12-01 Tony Chang <tony@chromium.org> · adc0190f
      tony@chromium.org authored
              Unreviewed, rolling chromium deps to r67811.
      
              * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adc0190f
    • caseq@chromium.org's avatar
      2010-12-01 Andrey Kosyakov <caseq@chromium.org> · 87f43376
      caseq@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: disable cookies tab in network resource view by default, enable for chromium
              https://bugs.webkit.org/show_bug.cgi?id=50249
      
              * inspector/front-end/NetworkItemView.js:
              (WebInspector.NetworkItemView):
              (WebInspector.NetworkItemView.prototype.resize):
              * inspector/front-end/Settings.js:
      2010-12-01  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: disable cookies tab in network resource view by default, enable for chromium
              https://bugs.webkit.org/show_bug.cgi?id=50249
      
              * src/js/DevTools.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87f43376
  9. 30 Nov, 2010 5 commits
    • ojan@chromium.org's avatar
      2010-11-30 Ojan Vafai <ojan@chromium.org> · b14a2c9d
      ojan@chromium.org authored
              Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
              https://bugs.webkit.org/show_bug.cgi?id=50288
      
              2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
              Reviewed by Darin Adler.
              Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
              https://bugs.webkit.org/show_bug.cgi?id=50182
              A display-isolated URL can only be displayed (e.g., put in an iframe,
              hyperlinked to) by documents from that scheme. In a sense, this is a
              generalization of some of the protections we give file URLs, but
              instead of lumping them all together into one "local" bucket, this
              patch creates a separate bucket for each scheme.
              For a while, I tried using a separate bucket for each origin. That
              would have played nicely with what Blob URLs are trying to do, but some
              "chrome" URL pages rely on being able to display other chrome URL
              pages, even in different origins. For example, the New Tab Page shows
              thumbnails from the "thumbnail" host.
              This patch also removes a bunch of unused code. I've also propagated
              the "deprecated" status of deprecatedCanDisplay to
              deprecatedShouldTreatURLAsLocal because that method has no other
              callers and is really asking for uppercase/lowercase bugs. I dream of
              someday removing these functions.
              page/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::canDisplay):
              (WebCore::SecurityOrigin::deprecatedCanDisplay):
              platform/SchemeRegistry.cpp:
              (WebCore::displayIsolatedURLSchemes):
              (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
              (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal):
              (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
              (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated):
              (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
              platform/SchemeRegistry.h:
              2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
              Reviewed by Darin Adler.
              Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
               https://bugs.webkit.org/show_bug.cgi?id=50182
              This patch adds a Chromium API for registering schemes as
              display-isolated. In a subsequent patch, I'll change the "chrome"
              scheme in Chrome to be display isolated instead of local. That will
              prevent file URLs from linking to chrome URLs.
              public/WebSecurityPolicy.h:
              src/WebSecurityPolicy.cpp:
              (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):
      
              * page/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::canDisplay):
              (WebCore::SecurityOrigin::deprecatedCanDisplay):
              * platform/SchemeRegistry.cpp:
              (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
              (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
              (WebCore::SchemeRegistry::localURLSchemes):
              (WebCore::SchemeRegistry::shouldTreatURLAsLocal):
              (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
              * platform/SchemeRegistry.h:
      2010-11-30  Ojan Vafai  <ojan@chromium.org>
      
              Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
              https://bugs.webkit.org/show_bug.cgi?id=50288
      
              2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
              Reviewed by Darin Adler.
              Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
              https://bugs.webkit.org/show_bug.cgi?id=50182
              A display-isolated URL can only be displayed (e.g., put in an iframe,
              hyperlinked to) by documents from that scheme. In a sense, this is a
              generalization of some of the protections we give file URLs, but
              instead of lumping them all together into one "local" bucket, this
              patch creates a separate bucket for each scheme.
              For a while, I tried using a separate bucket for each origin. That
              would have played nicely with what Blob URLs are trying to do, but some
              "chrome" URL pages rely on being able to display other chrome URL
              pages, even in different origins. For example, the New Tab Page shows
              thumbnails from the "thumbnail" host.
              This patch also removes a bunch of unused code. I've also propagated
              the "deprecated" status of deprecatedCanDisplay to
              deprecatedShouldTreatURLAsLocal because that method has no other
              callers and is really asking for uppercase/lowercase bugs. I dream of
              someday removing these functions.
              2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
              Reviewed by Darin Adler.
              Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
               https://bugs.webkit.org/show_bug.cgi?id=50182
              This patch adds a Chromium API for registering schemes as
              display-isolated. In a subsequent patch, I'll change the "chrome"
              scheme in Chrome to be display isolated instead of local. That will
              prevent file URLs from linking to chrome URLs.
      
              * public/WebSecurityPolicy.h:
              * src/WebSecurityPolicy.cpp:
      2010-11-30  Ojan Vafai  <ojan@chromium.org>
      
              Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
              https://bugs.webkit.org/show_bug.cgi?id=50288
      
              2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
              Reviewed by Darin Adler.
              Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
              https://bugs.webkit.org/show_bug.cgi?id=50182
              A display-isolated URL can only be displayed (e.g., put in an iframe,
              hyperlinked to) by documents from that scheme. In a sense, this is a
              generalization of some of the protections we give file URLs, but
              instead of lumping them all together into one "local" bucket, this
              patch creates a separate bucket for each scheme.
              For a while, I tried using a separate bucket for each origin. That
              would have played nicely with what Blob URLs are trying to do, but some
              "chrome" URL pages rely on being able to display other chrome URL
              pages, even in different origins. For example, the New Tab Page shows
              thumbnails from the "thumbnail" host.
              This patch also removes a bunch of unused code. I've also propagated
              the "deprecated" status of deprecatedCanDisplay to
              deprecatedShouldTreatURLAsLocal because that method has no other
              callers and is really asking for uppercase/lowercase bugs. I dream of
              someday removing these functions.
              2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
              Reviewed by Darin Adler.
              Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
               https://bugs.webkit.org/show_bug.cgi?id=50182
              This patch adds a Chromium API for registering schemes as
              display-isolated. In a subsequent patch, I'll change the "chrome"
              scheme in Chrome to be display isolated instead of local. That will
              prevent file URLs from linking to chrome URLs.
      
              * Api/qwebsecurityorigin.cpp:
              (QWebSecurityOrigin::localSchemes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b14a2c9d
    • jamesr@google.com's avatar
      2010-11-30 James Robinson <jamesr@chromium.org> · 82ea786c
      jamesr@google.com authored
              Reviewed by Dimitri Glazkov.
      
              [chromium] Update yasm entry in DEPS to match downstream
              https://bugs.webkit.org/show_bug.cgi?id=50274
      
              http://src.chromium.org/viewvc/chrome?view=rev&revision=67540 changed the downstream DEPS rule
              for yasm to pull unconditionally rather than pulling in each deps_os.  This changes the WebKit
              chromium DEPS to match.
      
              * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82ea786c
    • vangelis@chromium.org's avatar
      2010-11-29 Vangelis Kokkevis <vangelis@chromium.org> · 1bbe613e
      vangelis@chromium.org authored
              Reviewed by Simon Fraser.
      
              Provide more fine grained control to ports over when to turn on accelerated
              compositing.
              https://bugs.webkit.org/show_bug.cgi?id=49998
      
              As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
              has now been replaced by allowedCompositingTriggers which returns a bitfield of
              all the features which can trigger the compositor.
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::allowedCompositingTriggers):
              * src/ChromeClientImpl.h:
      2010-11-29  Vangelis Kokkevis  <vangelis@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Provide more fine grained control to ports over when to turn on accelerated
              compositing.
              https://bugs.webkit.org/show_bug.cgi?id=49998
      
              As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
              has now been replaced by allowedCompositingTriggers which returns a bitfield of
              all the features which can trigger the compositor.
      
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::allowedCompositingTriggers):
              * WebCoreSupport/ChromeClientQt.h:
      2010-11-30  Vangelis Kokkevis  <vangelis@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Provide more fine grained control to ports over when to turn on 
              accelerated compositing.
              https://bugs.webkit.org/show_bug.cgi?id=49998
      
              The RenderLayerCompositor now checks with the chrome client whether
              3d transforms, video, plugins, canvas and animation require
              switching over to the composited path. Layers that overlap composited
              content will still turn into composited layers regardless of the
              setting.
      
              * css/MediaQueryEvaluator.cpp:
              (WebCore::transform_3dMediaFeatureEval):
              * page/ChromeClient.h:
              (WebCore::ChromeClient::allowedCompositingTriggers):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::canRender3DTransforms):
              (WebCore::RenderLayer::updateTransform):
              (WebCore::RenderLayer::currentTransform):
              * rendering/RenderLayer.h:
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::updateLayerTransform):
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::RenderLayerCompositor):
              (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
              (WebCore::RenderLayerCompositor::canRender3DTransforms):
              (WebCore::RenderLayerCompositor::requiresCompositingLayer):
              (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
              (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
              (WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
              (WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
              (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
              * rendering/RenderLayerCompositor.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bbe613e
    • jochen@chromium.org's avatar
      2010-11-30 Jochen Eisinger <jochen@chromium.org> · 6392a57a
      jochen@chromium.org authored
              Reviewed by Darin Fisher.
      
              [chromium] pass webframe to web frame client's cookieJar
              https://bugs.webkit.org/show_bug.cgi?id=50148
      
              * public/WebFrameClient.h:
              (WebKit::WebFrameClient::cookieJar):
              * src/ChromiumBridge.cpp:
              (WebCore::getCookieJar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6392a57a
    • jochen@chromium.org's avatar
      2010-11-29 Xan Lopez <xlopez@igalia.com> · 3ad80711
      jochen@chromium.org authored
              Reviewed by Martin Robinson.
      
              * configure.ac: bump version for 1.3.7 release.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ad80711
  10. 29 Nov, 2010 6 commits
    • abarth@webkit.org's avatar
      2010-11-29 Adam Barth <abarth@webkit.org> · d84288db
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
              https://bugs.webkit.org/show_bug.cgi?id=50182
      
              A display-isolated URL can only be displayed (e.g., put in an iframe,
              hyperlinked to) by documents from that scheme.  In a sense, this is a
              generalization of some of the protections we give file URLs, but
              instead of lumping them all together into one "local" bucket, this
              patch creates a separate bucket for each scheme.
      
              For a while, I tried using a separate bucket for each origin.  That
              would have played nicely with what Blob URLs are trying to do, but some
              "chrome" URL pages rely on being able to display other chrome URL
              pages, even in different origins.  For example, the New Tab Page shows
              thumbnails from the "thumbnail" host.
      
              This patch also removes a bunch of unused code.  I've also propagated
              the "deprecated" status of deprecatedCanDisplay to
              deprecatedShouldTreatURLAsLocal because that method has no other
              callers and is really asking for uppercase/lowercase bugs.  I dream of
              someday removing these functions.
      
              * page/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::canDisplay):
              (WebCore::SecurityOrigin::deprecatedCanDisplay):
              * platform/SchemeRegistry.cpp:
              (WebCore::displayIsolatedURLSchemes):
              (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
              (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal):
              (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
              (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated):
              (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
              * platform/SchemeRegistry.h:
      2010-11-29  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
              https://bugs.webkit.org/show_bug.cgi?id=50182
      
              This patch adds a Chromium API for registering schemes as
              display-isolated.  In a subsequent patch, I'll change the "chrome"
              scheme in Chrome to be display isolated instead of local.  That will
              prevent file URLs from linking to chrome URLs.
      
              * public/WebSecurityPolicy.h:
              * src/WebSecurityPolicy.cpp:
              (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d84288db
    • tkent@chromium.org's avatar
      [Chromium] Add substitution parameters to WebKitClient::queryLocalizedString() · 1284a733
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=50053
      
      Reviewed by Darin Fisher.
      
      * public/WebKitClient.h:
      (WebKit::WebKitClient::queryLocalizedString): Add overload functions with
        substitution string parameters, and remove the integer parameter overload.
      * src/LocalizedStrings.cpp:
      (WebCore::query): Add string parameter overloads, and remove the integer parameter overload.
      (WebCore::multipleFileUploadText): Call the string parameter query().
      (WebCore::validationMessageTooLongText): Pass the parameters to query().
      (WebCore::validationMessageRangeUnderflowText): ditto.
      (WebCore::validationMessageRangeOverflowText): ditto.
      (WebCore::validationMessageStepMismatchText): ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1284a733
    • dglazkov@chromium.org's avatar
      2010-11-29 Dimitri Glazkov <dglazkov@chromium.org> · c123c050
      dglazkov@chromium.org authored
              Remove Build directory that was erroneously added in r72103.
      
              * Build: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c123c050
    • caseq@chromium.org's avatar
      2010-11-29 Andrey Kosyakov <caseq@chromium.org> · 922c14c9
      caseq@chromium.org authored
              Reviewed by Darin Fisher.
      
              Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
              Added WebDevToolsAgent::inspect()
              https://bugs.webkit.org/show_bug.cgi?id=49727
      
              * public/WebDevToolsAgent.h:
              * src/WebDevToolsAgentImpl.cpp:
              (WebKit::WebDevToolsAgentImpl::inspectNode):
              * src/WebDevToolsAgentImpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      922c14c9
    • dglazkov@chromium.org's avatar
      2010-11-29 Dimitri Glazkov <dglazkov@chromium.org> · a55a4e03
      dglazkov@chromium.org authored
              [Chromium] Remove python_24 dependency, because it is no longer necessary.
      
              * DEPS: Removed python_24 dependency.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a55a4e03
    • commit-queue@webkit.org's avatar
      2010-11-29 Bernhard Bauer <bauerb@chromium.org> · b2e85e65
      commit-queue@webkit.org authored
              Reviewed by Jeremy Orlow.
      
              Remove databaseFileName from IDBFactoryBackendImpl
              https://bugs.webkit.org/show_bug.cgi?id=50150
      
              No new tests, since functionality is unchanged.
      
              * storage/IDBFactoryBackendImpl.cpp:
              (WebCore::openSQLiteDatabase):
              * storage/IDBFactoryBackendImpl.h:
      2010-11-29  Bernhard Bauer  <bauerb@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              Remove databaseFileName from WebIDBFactory
              https://bugs.webkit.org/show_bug.cgi?id=50150
      
              * WebKit.gyp:
              * public/WebIDBFactory.h:
              (WebKit::WebIDBFactory::open):
              * src/WebIDBFactory.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2e85e65
  11. 26 Nov, 2010 5 commits
    • andreip@google.com's avatar
      2010-11-26 Andrei Popescu <andreip@google.com> · 7e718832
      andreip@google.com authored
              Reviewed by Jeremy Orlow.
      
              IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
              https://bugs.webkit.org/show_bug.cgi?id=50113
      
              * storage/indexeddb/objectstore-basics-expected.txt:
              * storage/indexeddb/objectstore-basics.html:
              * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
              * storage/indexeddb/objectstore-removeobjectstore.html:
              * storage/indexeddb/resources/shared.js:
              (deleteAllObjectStores):
              * storage/indexeddb/transaction-basics-expected.txt:
              * storage/indexeddb/transaction-basics.html:
      
      2010-11-26  Andrei Popescu  <andreip@google.com>
      
              Reviewed by Jeremy Orlow.
      
              IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
              https://bugs.webkit.org/show_bug.cgi?id=50113
      
              Modified exisiting layout tests to cover this change.
      
              * storage/IDBDatabase.cpp:
              (WebCore::IDBDatabase::deleteObjectStore):
              * storage/IDBDatabase.h:
              * storage/IDBDatabase.idl:
              * storage/IDBDatabaseBackendImpl.cpp:
              (WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
              (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
              * storage/IDBDatabaseBackendImpl.h:
              * storage/IDBDatabaseBackendInterface.h:
              * storage/IDBObjectStore.cpp:
              (WebCore::IDBObjectStore::deleteFunction):
              (WebCore::IDBObjectStore::deleteIndex):
              * storage/IDBObjectStore.h:
              * storage/IDBObjectStore.idl:
              * storage/IDBObjectStoreBackendImpl.cpp:
              (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
              (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
              (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
              (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
              * storage/IDBObjectStoreBackendImpl.h:
              * storage/IDBObjectStoreBackendInterface.h:
      
      2010-11-26  Andrei Popescu  <andreip@google.com>
      
              Reviewed by Jeremy Orlow.
      
              IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
              https://bugs.webkit.org/show_bug.cgi?id=50113
      
              * public/WebIDBDatabase.h:
              (WebKit::WebIDBDatabase::deleteObjectStore):
              (WebKit::WebIDBDatabase::removeObjectStore):
              * public/WebIDBObjectStore.h:
              (WebKit::WebIDBObjectStore::remove):
              (WebKit::WebIDBObjectStore::deleteFunction):
              (WebKit::WebIDBObjectStore::deleteIndex):
              * src/IDBDatabaseProxy.cpp:
              (WebCore::IDBDatabaseProxy::deleteObjectStore):
              * src/IDBDatabaseProxy.h:
              * src/IDBObjectStoreProxy.cpp:
              (WebCore::IDBObjectStoreProxy::deleteFunction):
              (WebCore::IDBObjectStoreProxy::deleteIndex):
              * src/IDBObjectStoreProxy.h:
              * src/WebIDBDatabaseImpl.cpp:
              (WebKit::WebIDBDatabaseImpl::deleteObjectStore):
              * src/WebIDBDatabaseImpl.h:
              * src/WebIDBObjectStoreImpl.cpp:
              (WebKit::WebIDBObjectStoreImpl::deleteFunction):
              (WebKit::WebIDBObjectStoreImpl::deleteIndex):
              * src/WebIDBObjectStoreImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e718832
    • jorlow@chromium.org's avatar
      2010-11-26 Jeremy Orlow <jorlow@chromium.org> · 1ffedf35
      jorlow@chromium.org authored
              Reviewed by Steve Block.
      
              Make IDBKeyRange match the spec
              https://bugs.webkit.org/show_bug.cgi?id=50105
      
              Remove flags and instead add two booleans for being open.
              Change left to lower and right to upper everywhere.
      
              * storage/indexeddb/constants-expected.txt:
              * storage/indexeddb/constants.html:
              * storage/indexeddb/index-cursor.html:
              * storage/indexeddb/keyrange-expected.txt:
              * storage/indexeddb/keyrange.html:
              * storage/indexeddb/objectstore-cursor.html:
              * storage/indexeddb/open-cursor.html:
              * storage/indexeddb/tutorial.html:
      2010-11-26  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Steve Block.
      
              Make IDBKeyRange match the spec
              https://bugs.webkit.org/show_bug.cgi?id=50105
      
              Remove flags and instead add two booleans for being open.
              Change left to lower and right to upper everywhere.
      
              * storage/IDBIndexBackendImpl.cpp:
              (WebCore::IDBIndexBackendImpl::openCursorInternal):
              * storage/IDBKey.cpp:
              (WebCore::IDBKey::lowerCursorWhereFragment):
              (WebCore::IDBKey::upperCursorWhereFragment):
              * storage/IDBKey.h:
              * storage/IDBKeyRange.cpp:
              (WebCore::IDBKeyRange::IDBKeyRange):
              (WebCore::IDBKeyRange::only):
              (WebCore::IDBKeyRange::lowerBound):
              (WebCore::IDBKeyRange::upperBound):
              (WebCore::IDBKeyRange::bound):
              (WebCore::IDBKeyRange::lowerWhereClauseComparisonOperator):
              (WebCore::IDBKeyRange::upperWhereClauseComparisonOperator):
              * storage/IDBKeyRange.h:
              (WebCore::IDBKeyRange::create):
              (WebCore::IDBKeyRange::lower):
              (WebCore::IDBKeyRange::upper):
              (WebCore::IDBKeyRange::lowerOpen):
              (WebCore::IDBKeyRange::upperOpen):
              * storage/IDBKeyRange.idl:
              * storage/IDBObjectStoreBackendImpl.cpp:
              (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
      2010-11-26  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Steve Block.
      
              Make IDBKeyRange match the spec
              https://bugs.webkit.org/show_bug.cgi?id=50105
      
              Remove flags and instead add two booleans for being open.
              Change left to lower and right to upper everywhere.
      
              * public/WebIDBKeyRange.h:
              (WebKit::WebIDBKeyRange::WebIDBKeyRange):
              * src/WebIDBKeyRange.cpp:
              (WebKit::WebIDBKeyRange::assign):
              (WebKit::WebIDBKeyRange::left):
              (WebKit::WebIDBKeyRange::right):
              (WebKit::WebIDBKeyRange::lower):
              (WebKit::WebIDBKeyRange::upper):
              (WebKit::WebIDBKeyRange::lowerOpen):
              (WebKit::WebIDBKeyRange::upperOpen):
              (WebKit::WebIDBKeyRange::flags):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ffedf35
    • jorlow@chromium.org's avatar
      2010-11-25 Jeremy Orlow <jorlow@chromium.org> · b89d0c36
      jorlow@chromium.org authored
              Reviewed by Steve Block.
      
              Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
              https://bugs.webkit.org/show_bug.cgi?id=50081
      
              * storage/indexeddb/create-and-remove-object-store-expected.txt: Renamed from LayoutTests/storage/indexeddb/createAndRemoveObjectStore-expected.txt.
              * storage/indexeddb/create-and-remove-object-store.html: Renamed from LayoutTests/storage/indexeddb/createAndRemoveObjectStore.html.
              * storage/indexeddb/create-object-store-options-expected.txt:
              * storage/indexeddb/create-object-store-options.html:
              * storage/indexeddb/resources/shared.js:
              (evalAndExpectException):
              * storage/indexeddb/transaction-and-objectstore-calls-expected.txt: Added.
              * storage/indexeddb/transaction-and-objectstore-calls.html: Added.
              * storage/indexeddb/tutorial.html:
      2010-11-25  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Steve Block.
      
              Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
              https://bugs.webkit.org/show_bug.cgi?id=50081
      
              IDBDatabase.transaction should use the new optional OptionsObject way
              of taking optional paramters. Modify that object to get numbers and
              domStringLists from it. Verify that any requested resources exist and
              return an exception if not.
      
              When IDBTransaction.objectStore is called, verify that it's one of the
              requested resources. Also verify that it still exists. Plumb the
              exception code to make this work.
      
              Tests: storage/indexeddb/create-and-remove-object-store.html
                     storage/indexeddb/transaction-and-objectstore-calls.html
      
              * bindings/v8/OptionsObject.cpp:
              (WebCore::OptionsObject::getKeyInteger):
              (WebCore::OptionsObject::getKeyString):
              (WebCore::OptionsObject::getKeyDOMStringList):
              * bindings/v8/OptionsObject.h:
              * storage/IDBDatabase.cpp:
              (WebCore::IDBDatabase::createObjectStore):
              (WebCore::IDBDatabase::transaction):
              * storage/IDBDatabase.h:
              (WebCore::IDBDatabase::transaction):
              * storage/IDBDatabase.idl:
              * storage/IDBDatabaseBackendImpl.cpp:
              (WebCore::IDBDatabaseBackendImpl::transaction):
              * storage/IDBTransaction.cpp:
              (WebCore::IDBTransaction::objectStore):
              * storage/IDBTransactionBackendImpl.cpp:
              (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
              (WebCore::IDBTransactionBackendImpl::objectStore):
              * storage/IDBTransactionBackendImpl.h:
              * storage/IDBTransactionBackendInterface.h:
      2010-11-25  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Steve Block.
      
              Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
              https://bugs.webkit.org/show_bug.cgi?id=50081
      
              Plumb IDBTransaction.objectStore's exception code.
      
              * public/WebIDBTransaction.h:
              (WebKit::WebIDBTransaction::objectStore):
              * src/IDBDatabaseProxy.cpp:
              (WebCore::IDBDatabaseProxy::transaction):
              * src/IDBTransactionBackendProxy.cpp:
              (WebCore::IDBTransactionBackendProxy::objectStore):
              * src/IDBTransactionBackendProxy.h:
              * src/WebIDBDatabaseImpl.cpp:
              (WebKit::WebIDBDatabaseImpl::createObjectStore):
              (WebKit::WebIDBDatabaseImpl::transaction):
              * src/WebIDBTransactionImpl.cpp:
              (WebKit::WebIDBTransactionImpl::objectStore):
              * src/WebIDBTransactionImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b89d0c36
    • hans@chromium.org's avatar
      2010-11-26 Hans Wennborg <hans@chromium.org> · dccbdc64
      hans@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
              https://bugs.webkit.org/show_bug.cgi?id=50102
      
              Update layout tests to use the new name.
      
              * storage/indexeddb/database-basics-expected.txt:
              * storage/indexeddb/database-basics.html:
              * storage/indexeddb/database-quota-expected.txt:
              * storage/indexeddb/database-quota.html:
              * storage/indexeddb/objectstore-basics-expected.txt:
              * storage/indexeddb/objectstore-basics.html:
              * storage/indexeddb/resources/shared.js:
              (deleteAllObjectStores):
              * storage/indexeddb/transaction-basics-expected.txt:
              * storage/indexeddb/transaction-basics.html:
              * storage/indexeddb/tutorial.html:
      2010-11-26  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
              https://bugs.webkit.org/show_bug.cgi?id=50102
      
              Rename as per the spec: http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#database-interface
      
              * manual-tests/indexeddb-persists.html:
              * storage/IDBDatabase.h:
              (WebCore::IDBDatabase::objectStoreNames):
              * storage/IDBDatabase.idl:
              * storage/IDBDatabaseBackendImpl.cpp:
              (WebCore::IDBDatabaseBackendImpl::objectStoreNames):
              (WebCore::IDBDatabaseBackendImpl::setVersion):
              (WebCore::IDBDatabaseBackendImpl::transaction):
              * storage/IDBDatabaseBackendImpl.h:
              * storage/IDBDatabaseBackendInterface.h:
      2010-11-26  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
              https://bugs.webkit.org/show_bug.cgi?id=50102
      
              Rename as per the spec: http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#database-interface
      
              * public/WebIDBDatabase.h:
              (WebKit::WebIDBDatabase::objectStores):
              (WebKit::WebIDBDatabase::objectStoreNames):
              * src/IDBDatabaseProxy.cpp:
              (WebCore::IDBDatabaseProxy::objectStoreNames):
              * src/IDBDatabaseProxy.h:
              * src/WebIDBDatabaseImpl.cpp:
              (WebKit::WebIDBDatabaseImpl::objectStoreNames):
              * src/WebIDBDatabaseImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dccbdc64
    • andreip@google.com's avatar
      Remove description · 40483f54
      andreip@google.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40483f54