1. 10 Dec, 2010 40 commits
    • commit-queue@webkit.org's avatar
      2010-12-10 John Knottenbelt <jknotten@chromium.org> · 51d3357c
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              [Chromium] Implement mocks for client-based geolocation
              https://bugs.webkit.org/show_bug.cgi?id=46895
      
              * WebKit.gyp:
              * public/WebGeolocationClientMock.h: Added.
              (WebKit::WebGeolocationClientMock::~WebGeolocationClientMock):
              (WebKit::WebGeolocationClientMock::WebGeolocationClientMock):
              * src/WebGeolocationClientMock.cpp: Added.
              (WebKit::WebGeolocationClientMock::create):
              (WebKit::WebGeolocationClientMock::initialize):
              (WebKit::WebGeolocationClientMock::reset):
              (WebKit::WebGeolocationClientMock::setMockGeolocationPosition):
              (WebKit::WebGeolocationClientMock::setMockGeolocationError):
              (WebKit::WebGeolocationClientMock::setMockGeolocationPermission):
              (WebKit::WebGeolocationClientMock::resetMock):
              (WebKit::WebGeolocationClientMock::startUpdating):
              (WebKit::WebGeolocationClientMock::stopUpdating):
              (WebKit::WebGeolocationClientMock::setEnableHighAccuracy):
              (WebKit::WebGeolocationClientMock::geolocationDestroyed):
              (WebKit::WebGeolocationClientMock::setController):
              (WebKit::WebGeolocationClientMock::lastPosition):
              (WebKit::WebGeolocationClientMock::requestPermission):
              (WebKit::WebGeolocationClientMock::cancelPermissionRequest):
              * src/WebGeolocationServiceMock.cpp:
      2010-12-10  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Steve Block.
      
              [Chromium] Implement mocks for client-based geolocation
              https://bugs.webkit.org/show_bug.cgi?id=46895
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::setGeolocationPermission):
              (LayoutTestController::setMockGeolocationPosition):
              (LayoutTestController::setMockGeolocationError):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::geolocationClient):
              (WebViewHost::geolocationClientMock):
              (WebViewHost::reset):
              * DumpRenderTree/chromium/WebViewHost.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51d3357c
    • mihaip@chromium.org's avatar
      2010-12-08 Mihai Parparita <mihaip@chromium.org> · 4a1481a0
      mihaip@chromium.org authored
              Reviewed by Darin Adler.
      
              fast/canvas/canvas-getImageData-negative-source.html fails on Mac
              https://bugs.webkit.org/show_bug.cgi?id=47901
      
              Add test for rounding behavior. Remove now-passing tests from
              test_expectations.txt.
      
              * fast/canvas/canvas-getImageData-rounding-expected.txt: Added.
              * fast/canvas/canvas-getImageData-rounding.html: Added.
              * platform/chromium/test_expectations.txt:
      2010-12-08  Mihai Parparita  <mihaip@chromium.org>
      
              Reviewed by Darin Adler.
      
              fast/canvas/canvas-getImageData-negative-source.html fails on Mac
              https://bugs.webkit.org/show_bug.cgi?id=47901
      
              Test: fast/canvas/canvas-getImageData-rounding.html
      
              static_cast<unsigned> is generally not what we want in
              convertLogicalToDevice. It produces inconsistent results when compiling
              for 32-bit vs. 64-bit, and in any case we weren't getting correct
              rounding behavior for source rectangles (e.g. we should get a source rect
              of width 2 if the source X is 0.9 and the source width is 0.2, but we
              were getting only one of width 1).
      
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::convertLogicalToDevice):
              (WebCore::HTMLCanvasElement::convertToValidDeviceSize):
              * html/HTMLCanvasElement.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a1481a0
    • alex@webkit.org's avatar
      2010-12-10 Alejandro G. Castro <alex@igalia.com> · c89d952a
      alex@webkit.org authored
              Unreviewed GTK test expectation update.
      
              * http/tests/misc/dns-prefetch-control-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c89d952a
    • pkasting@chromium.org's avatar
      Unreviewed Chromium test expectation update. · d085de86
      pkasting@chromium.org authored
      * platform/chromium-gpu/test_expectations.txt:
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d085de86
    • alex@webkit.org's avatar
      2010-12-10 Alejandro G. Castro <alex@igalia.com> · 998a3df5
      alex@webkit.org authored
              Unreviewed, fixed small typo in the name of a function.
      
              * webkit/webkitwebsettings.cpp:
              (getAvailableDictionariesCallback):
              (webkit_web_settings_set_property):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      998a3df5
    • alex@webkit.org's avatar
      2010-12-09 Alejandro G. Castro <alex@igalia.com> · 26df767f
      alex@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Add hasSpellingMarker support to the DRT
              https://bugs.webkit.org/show_bug.cgi?id=50739
      
              Added a new private API function to support the spelling marker
              tests in the DRT.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      
      2010-12-10  Alejandro G. Castro  <alex@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add hasSpellingMarker support to the DRT
              https://bugs.webkit.org/show_bug.cgi?id=50739
      
              Implemented the hasSpellingMarker to support spelling tests.
      
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::hasSpellingMarker):
      
      2010-12-10  Alejandro G. Castro  <alex@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add hasSpellingMarker support to the DRT
              https://bugs.webkit.org/show_bug.cgi?id=50739
      
              Unskipped spelling tests and added a bug for the one failing,
              added results for a new ones also.
      
              * platform/gtk/Skipped:
              * platform/gtk/editing/spelling/inline_spelling_markers-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26df767f
    • alex@webkit.org's avatar
      2010-12-10 Alejandro G. Castro <alex@igalia.com> · 45662cb0
      alex@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Choose a dictionary in case there is no one defined or the
              env LANG does not propose one
              https://bugs.webkit.org/show_bug.cgi?id=50738
      
              In case no dict is set and we can not find one using the
              environment just get the first dictionary installed in the list.
      
              * webkit/webkitwebsettings.cpp:
              (getAvilableDictionariesCallback):
              (webkit_web_settings_set_property):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45662cb0
    • commit-queue@webkit.org's avatar
      2010-12-10 Hironori Bono <hbono@chromium.org> · fbb324b3
      commit-queue@webkit.org authored
              Reviewed by Ojan Vafai.
      
              [Chromium] Use libjpeg-turbo instead of libjpeg
              https://bugs.webkit.org/show_bug.cgi?id=50054
      
              This change replaces the hard-coded path to the GYP files of the JPEG
              library with a 'libjpeg_gyp_path' variable, which is added by Chromium
              r68453. (When building WebKit Chromium, this change sets its value to
              '<(chromium_src_dir)/third_party/libjpeg/libjpeg.gyp' to avoid changing
              the current behavior.)
      
              No new tests since this does not change the code at all.
      
              * WebCore.gyp/WebCore.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbb324b3
    • commit-queue@webkit.org's avatar
      2010-12-10 Joone Hur <joone@kldp.org> · 1e6a1849
      commit-queue@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
              https://bugs.webkit.org/show_bug.cgi?id=50808
      
              Unskipping the following test cases:
              userscripts/mixed-case-stylesheet.html
              userscripts/simple-stylesheet.html
              userscripts/user-style-all-frames.html
      
              * platform/gtk/Skipped:
      2010-12-10  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Gustavo Noronha Silva.
      
              Remove unnecessary variable names from DumpRenderTreeSupportGtk
              https://bugs.webkit.org/show_bug.cgi?id=50815
      
              There were some unnecessary variable names in DumpRenderTreeSupportGtk,
              so remove them.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it.
      2010-12-10  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              webkit-patch: not possible to use build-and-test with local commits
              https://bugs.webkit.org/show_bug.cgi?id=33378
      
              Make --no-clean not even check if we have local commits.
              It's unclear to me why the code was originally written this way.
              I was unable to dig up a reason from svn history.
      
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e6a1849
    • eric@webkit.org's avatar
      2010-12-10 Eric Seidel <eric@webkit.org> · 5ddfb643
      eric@webkit.org authored
              Reviewed by Ojan Vafai.
      
              webkit-patch: not possible to use build-and-test with local commits
              https://bugs.webkit.org/show_bug.cgi?id=33378
      
              Make --no-clean not even check if we have local commits.
              It's unclear to me why the code was originally written this way.
              I was unable to dig up a reason from svn history.
      
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ddfb643
    • mario@webkit.org's avatar
      2010-12-10 Mario Sanchez Prada <msanchez@igalia.com> · 8e07cd4f
      mario@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] AX: implement isEnabled in DRT
              https://bugs.webkit.org/show_bug.cgi?id=50814
      
              Unskip passing accessibility/aria-disabled.html test.
      
              * platform/gtk/Skipped: Unskip test.
      2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] AX: implement isEnabled in DRT
              https://bugs.webkit.org/show_bug.cgi?id=50814
      
              Implement AccessibilityUIElement::isEnabled() for GTK.
      
              * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
              (checkElementState): New function to refactor common code.
              (AccessibilityUIElement::isEnabled): Implement this by checking
              the current state of the AtkObject.
              (AccessibilityUIElement::isSelected): Use the new
              checkElementState function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e07cd4f
    • cmarrin@apple.com's avatar
      2010-12-10 Chris Marrin <cmarrin@apple.com> · 3aaada28
      cmarrin@apple.com authored
              Reviewed by Simon Fraser.
      
              Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
              https://bugs.webkit.org/show_bug.cgi?id=49388
      
              Got rid of the NonZeroBeginTimeFlag. Functionality is now hidden inside
              the implementation.
      
              * platform/graphics/ca/GraphicsLayerCA.cpp:
              (WebCore::GraphicsLayerCA::setAnimationOnLayer):
              * platform/graphics/ca/PlatformCAAnimation.h:
              * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
              (hasNonZeroBeginTimeFlag):
              (setNonZeroBeginTimeFlag):
              (PlatformCAAnimation::PlatformCAAnimation):
              (PlatformCAAnimation::setBeginTime):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3aaada28
    • podivilov@chromium.org's avatar
      2010-12-10 Pavel Podivilov <podivilov@chromium.org> · 036cf88c
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: eliminate SourceFrameDelegate by passing scripts to SourceFrame constructor.
              https://bugs.webkit.org/show_bug.cgi?id=50679
      
              * inspector/front-end/Script.js:
              * inspector/front-end/ScriptView.js:
              (WebInspector.ScriptView):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype.reset):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
              (WebInspector.SourceFrame.prototype._breakpointAdded):
              (WebInspector.SourceFrame.prototype._doEditLine):
              (WebInspector.SourceFrame.prototype._commitEditLine):
              (WebInspector.SourceFrame.prototype._breakpoints):
              (WebInspector.SourceFrame.prototype._sourceIDForLine):
              * inspector/front-end/SourceView.js:
              (WebInspector.SourceView):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      036cf88c
    • andreas.kling@nokia.com's avatar
      2010-12-10 Andreas Kling <kling@webkit.org> · 39078312
      andreas.kling@nokia.com authored
              Reviewed by Eric Seidel.
      
              Don't do GraphicsContext save/restore just to preserve the CompositeOperator
              https://bugs.webkit.org/show_bug.cgi?id=50070
      
              Add GraphicsContext::compositeOperation() so we don't have to do a full
              save/restore if the only context-tainting call is setCompositeOperation().
      
              GraphicsContext::setCompositeOperation() now stores the op in its state
              and calls a port-specific setPlatformCompositeOperation().
      
              No new tests, this is an optimization.
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::setCompositeOperation):
              (WebCore::GraphicsContext::compositeOperation):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/GraphicsContextPrivate.h:
              (WebCore::GraphicsContextState::GraphicsContextState):
              * platform/graphics/Image.cpp:
              (WebCore::Image::fillWithSolidColor):
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/haiku/GraphicsContextHaiku.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/mac/GraphicsContextMac.mm:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/skia/GraphicsContextSkia.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/skia/SkiaUtils.cpp:
              (WebCore::WebCoreCompositeToSkiaComposite):
              * platform/graphics/wince/GraphicsContextWinCE.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * platform/graphics/wx/GraphicsContextWx.cpp:
              (WebCore::GraphicsContext::setPlatformCompositeOperation):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              * rendering/RenderView.cpp:
              (WebCore::RenderView::paintBoxDecorations):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39078312
    • reni@webkit.org's avatar
      GraphicsContext: Merge m_common and m_data · a1db5cff
      reni@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49914
      
      Patch by Renata Hodovan <reni@webkit.org> on 2010-12-10
      Reviewed by Andreas Kling.
      
      Move data members from GraphicsContextPrivate into GraphicsContext. So GraphicsContextPlatform.h
      and m_common became unnecessary. They are removed.
      Add two methods to GraphicsContext: platformInit() and platformDestroy(), which
      make the constructor of GraphicsContext clearer.
      Besides add a getter to the private GraphicsContext::m_state member, because some inline
      functions in cairo need it.
      
      No new test is needed, because this is a refactoring.
      
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/GraphicsContext.cpp:
      (WebCore::GraphicsContext::GraphicsContext):
      (WebCore::GraphicsContext::~GraphicsContext):
      (WebCore::GraphicsContext::save):
      (WebCore::GraphicsContext::restore):
      (WebCore::GraphicsContext::setStrokeThickness):
      (WebCore::GraphicsContext::setStrokeStyle):
      (WebCore::GraphicsContext::setStrokeColor):
      (WebCore::GraphicsContext::setShadow):
      (WebCore::GraphicsContext::clearShadow):
      (WebCore::GraphicsContext::getShadow):
      (WebCore::GraphicsContext::strokeThickness):
      (WebCore::GraphicsContext::strokeStyle):
      (WebCore::GraphicsContext::strokeColor):
      (WebCore::GraphicsContext::strokeColorSpace):
      (WebCore::GraphicsContext::fillRule):
      (WebCore::GraphicsContext::setFillRule):
      (WebCore::GraphicsContext::setFillColor):
      (WebCore::GraphicsContext::fillColor):
      (WebCore::GraphicsContext::fillColorSpace):
      (WebCore::GraphicsContext::setShouldAntialias):
      (WebCore::GraphicsContext::shouldAntialias):
      (WebCore::GraphicsContext::state):
      (WebCore::GraphicsContext::setStrokePattern):
      (WebCore::GraphicsContext::setFillPattern):
      (WebCore::GraphicsContext::setStrokeGradient):
      (WebCore::GraphicsContext::setFillGradient):
      (WebCore::GraphicsContext::fillGradient):
      (WebCore::GraphicsContext::strokeGradient):
      (WebCore::GraphicsContext::fillPattern):
      (WebCore::GraphicsContext::strokePattern):
      (WebCore::GraphicsContext::setShadowsIgnoreTransforms):
      (WebCore::GraphicsContext::updatingControlTints):
      (WebCore::GraphicsContext::setUpdatingControlTints):
      (WebCore::GraphicsContext::setPaintingDisabled):
      (WebCore::GraphicsContext::paintingDisabled):
      (WebCore::GraphicsContext::textDrawingMode):
      (WebCore::GraphicsContext::setTextDrawingMode):
      * platform/graphics/GraphicsContext.h:
      (WebCore::GraphicsContextState::GraphicsContextState):
      * platform/graphics/GraphicsContextPrivate.h: Removed.
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      (WebCore::setPlatformFill):
      (WebCore::setPlatformStroke):
      (WebCore::drawPathShadow):
      (WebCore::fillCurrentCairoPath):
      (WebCore::strokeCurrentCairoPath):
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::strokePath):
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::setPlatformShadow):
      (WebCore::GraphicsContext::strokeRect):
      (WebCore::GraphicsContext::setAlpha):
      (WebCore::GraphicsContext::getAlpha):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::applyStrokePattern):
      (WebCore::GraphicsContext::applyFillPattern):
      (WebCore::GraphicsContext::drawPath):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::strokePath):
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::setPlatformShadow):
      (WebCore::GraphicsContext::strokeRect):
      * platform/graphics/haiku/GraphicsContextHaiku.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::strokePath):
      (WebCore::GraphicsContext::clip):
      (WebCore::GraphicsContext::clipOut):
      (WebCore::GraphicsContext::addInnerRoundedRectClip):
      * platform/graphics/qt/GraphicsContextQt.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::strokePath):
      (WebCore::GraphicsContext::fillRect):
      (WebCore::GraphicsContext::setPlatformShadow):
      * platform/graphics/skia/GraphicsContextSkia.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::setPlatformShadow):
      * platform/graphics/win/GraphicsContextCGWin.cpp:
      (WebCore::GraphicsContext::GraphicsContext):
      (WebCore::GraphicsContext::platformInit):
      * platform/graphics/win/GraphicsContextCairoWin.cpp:
      (WebCore::GraphicsContext::GraphicsContext):
      (WebCore::GraphicsContext::platformInit):
      * platform/graphics/wince/GraphicsContextWinCE.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      (WebCore::GraphicsContext::fillPath):
      (WebCore::GraphicsContext::fillRect):
      * platform/graphics/wx/GraphicsContextWx.cpp:
      (WebCore::GraphicsContext::platformInit):
      (WebCore::GraphicsContext::platformDestroy):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1db5cff
    • mrobinson@webkit.org's avatar
      2010-12-10 Martin Robinson <mrobinson@igalia.com> · 6f4b5c9f
      mrobinson@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              Remove unnecessary variable names from DumpRenderTreeSupportGtk
              https://bugs.webkit.org/show_bug.cgi?id=50815
      
              There were some unnecessary variable names in DumpRenderTreeSupportGtk,
              so remove them.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f4b5c9f
    • podivilov@chromium.org's avatar
      2010-12-10 Pavel Podivilov <podivilov@chromium.org> · c6c51819
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: introduce a pair of set/remove methods for each breakpoint type.
              https://bugs.webkit.org/show_bug.cgi?id=50809
      
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::setEventListenerBreakpoint):
              (WebCore::InspectorController::removeEventListenerBreakpoint):
              (WebCore::InspectorController::hasEventListenerBreakpoint):
              (WebCore::InspectorController::setXHRBreakpoint):
              (WebCore::InspectorController::removeXHRBreakpoint):
              (WebCore::InspectorController::hasXHRBreakpoint):
              (WebCore::InspectorController::clearNativeBreakpoints):
              * inspector/InspectorController.h:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::setDOMBreakpoint):
              (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
              (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
              (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
              (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
              (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
              (WebCore::InspectorDOMAgent::didRemoveDOMNode):
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
              (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
              (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.BreakpointManager):
              (WebInspector.NativeBreakpoint):
              (WebInspector.DOMBreakpoint):
              (WebInspector.EventListenerBreakpoint):
              (WebInspector.XHRBreakpoint):
              * inspector/front-end/CallStackSidebarPane.js:
              (WebInspector.CallStackSidebarPane):
              (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel.prototype.debuggerPaused):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6c51819
    • ossy@webkit.org's avatar
      Unreviewed. Remove platform specific expected files after r73720. · c19e900e
      ossy@webkit.org authored
      * platform/gtk/fast/forms/ValidityState-patternMismatch-expected.txt: Removed.
      * platform/qt/fast/forms/ValidityState-patternMismatch-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c19e900e
    • commit-queue@webkit.org's avatar
      2010-12-10 John Knottenbelt <jknotten@chromium.org> · 38560d2b
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              [chromium] Implement client based geolocation bindings
              https://bugs.webkit.org/show_bug.cgi?id=45752
      
              Implements the necessary plumbing to expose client-based geolocation in Chromium
              webkit. The plan is to remove the non-client-based geolocation code (GeolocationService*)
              in the future.
      
              * WebKit.gyp:
              * public/WebGeolocationClient.h: Added.
              (WebKit::WebGeolocationClient::~WebGeolocationClient):
              * public/WebGeolocationController.h: Added.
              (WebKit::WebGeolocationController::WebGeolocationController):
              (WebKit::WebGeolocationController::reset):
              * public/WebGeolocationError.h:
              * public/WebGeolocationPermissionRequest.h: Added.
              (WebKit::WebGeolocationPermissionRequest::WebGeolocationPermissionRequest):
              (WebKit::WebGeolocationPermissionRequest::geolocation):
              * public/WebGeolocationPermissionRequestManager.h: Added.
              (WebKit::WebGeolocationPermissionRequestManager::WebGeolocationPermissionRequestManager):
              (WebKit::WebGeolocationPermissionRequestManager::~WebGeolocationPermissionRequestManager):
              * public/WebGeolocationPosition.h:
              * public/WebViewClient.h:
              (WebKit::WebViewClient::geolocationClient):
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
              (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
              * src/GeolocationClientProxy.cpp: Added.
              (WebKit::GeolocationClientProxy::GeolocationClientProxy):
              (WebKit::GeolocationClientProxy::~GeolocationClientProxy):
              (WebKit::GeolocationClientProxy::setController):
              (WebKit::GeolocationClientProxy::geolocationDestroyed):
              (WebKit::GeolocationClientProxy::startUpdating):
              (WebKit::GeolocationClientProxy::stopUpdating):
              (WebKit::GeolocationClientProxy::setEnableHighAccuracy):
              (WebKit::GeolocationClientProxy::lastPosition):
              (WebKit::GeolocationClientProxy::requestPermission):
              (WebKit::GeolocationClientProxy::cancelPermissionRequest):
              * src/GeolocationClientProxy.h: Added.
              * src/WebGeolocationController.cpp: Added.
              (WebKit::WebGeolocationController::positionChanged):
              (WebKit::WebGeolocationController::errorOccurred):
              (WebKit::WebGeolocationController::controller):
              * src/WebGeolocationPermissionRequest.cpp: Added.
              (WebKit::WebGeolocationPermissionRequest::securityOrigin):
              (WebKit::WebGeolocationPermissionRequest::setIsAllowed):
              * src/WebGeolocationPermissionRequestManager.cpp: Added.
              (WebGeolocationPermissionRequestManager::add):
              (WebGeolocationPermissionRequestManager::remove):
              (WebGeolocationPermissionRequestManager::init):
              (WebGeolocationPermissionRequestManager::reset):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::WebViewImpl):
              * src/WebViewImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38560d2b
    • aroben@apple.com's avatar
      Windows production build fix after r72555 · a605c8fe
      aroben@apple.com authored
      * WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Use
      "$(WebKitVSPropsRedirectionDir)..\..\WebKitLibraries\win" to find the
      .vsprops files, rather than $(WebKitLibrariesDir).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a605c8fe
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Second attempt to fix the build with Qt 4.6 broken in 73710. · e825e022
      jocelyn.turcotte@nokia.com authored
      Reviewed by nobody, build fix.
      
      * platform/network/qt/QtNAMThreadSafeProxy.cpp:
      (WebCore::QtNetworkReplyThreadSafeProxy::QtNetworkReplyThreadSafeProxy):
      (WebCore::QtNetworkReplyThreadSafeProxy::localCustomRequest):
      * platform/network/qt/QtNAMThreadSafeProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e825e022
    • mario@webkit.org's avatar
      2010-12-10 Mario Sanchez Prada <msanchez@igalia.com> · 7044b94e
      mario@webkit.org authored
              Unreviewed, unskip passing accessibility tests on GTK.
      
              * platform/gtk/Skipped: Unskip passing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7044b94e
    • pfeldman@chromium.org's avatar
      2010-12-10 Pavel Feldman <pfeldman@chromium.org> · 9c0ba28c
      pfeldman@chromium.org authored
              Not reviewed. Get rid of spaces in ValidityState-patternMismatch test.
      
              * fast/forms/ValidityState-patternMismatch-expected.txt:
              * fast/forms/ValidityState-patternMismatch.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c0ba28c
    • ossy@webkit.org's avatar
      Unreviewed. Add platform specific expected files after r73715. · a7c49d2b
      ossy@webkit.org authored
      * platform/gtk/fast/forms/ValidityState-patternMismatch-expected.txt: Added.
      * platform/qt/fast/forms/ValidityState-patternMismatch-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7c49d2b
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Fix the build with Qt 4.6 broken in 73710. · 322a42e9
      jocelyn.turcotte@nokia.com authored
      Reviewed by nobody, build fix.
      
      * platform/network/qt/QtNAMThreadSafeProxy.cpp:
      (WebCore::QtNetworkReplyThreadSafeProxy::QtNetworkReplyThreadSafeProxy):
      * platform/network/qt/QtNAMThreadSafeProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      322a42e9
    • commit-queue@webkit.org's avatar
      2010-12-10 Emil Eklund <eae@chromium.org> · 43894ca9
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              Change EventHandler::dispatchMouseEvent code to use DOM traversal instead of render tree traversal
              https://bugs.webkit.org/show_bug.cgi?id=49982
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchMouseEvent):
              Walk up DOM/hosted tree rather than render tree.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43894ca9
    • jocelyn.turcotte@nokia.com's avatar
      2010-12-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> · 0a742e70
      jocelyn.turcotte@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
              https://bugs.webkit.org/show_bug.cgi?id=50750
      
              * UIProcess/API/qt/WKView.h:
              * UIProcess/API/qt/qgraphicswkview.cpp:
              (QGraphicsWKView::QGraphicsWKView):
              Change the WKPageNamespaceRef argument to QWKContext*
              * UIProcess/API/qt/qgraphicswkview.h:
              * UIProcess/API/qt/qwkcontext.cpp: Added.
              * UIProcess/API/qt/qwkcontext.h: Added.
              * UIProcess/API/qt/qwkcontext_p.h: Added.
              * UIProcess/API/qt/qwkpage.cpp:
              (QWKPagePrivate::QWKPagePrivate):
              (QWKPage::QWKPage):
              Change the WKPageNamespaceRef argument to QWKContext*
              * UIProcess/API/qt/qwkpage.h:
              * UIProcess/API/qt/qwkpage_p.h:
              * WebKit2.pro:
      2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
              https://bugs.webkit.org/show_bug.cgi?id=50750
      
              * MiniBrowser/qt/BrowserView.cpp:
              (BrowserView::BrowserView):
              * MiniBrowser/qt/BrowserView.h:
              * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
              (WTR::WebView::WebView):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a742e70
    • commit-queue@webkit.org's avatar
      2010-12-10 Dai Mikurube <dmikurube@google.com> · bd6974cf
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Refactor by merging tests for ValidityState (patternMismatch and customError)
              https://bugs.webkit.org/show_bug.cgi?id=50802
      
              * fast/forms/ValidityState-customError-expected.txt: Added.
              * fast/forms/ValidityState-customError.html: Added.
              * fast/forms/ValidityState-customError-001-expected.txt: Removed. Merged to ValidityState-customError-expected.txt.
              * fast/forms/ValidityState-customError-001.html: Removed. Merged to ValidityState-customError.html.
              * fast/forms/ValidityState-customError-002-expected.txt: Removed. Merged to ValidityState-customError-expected.txt.
              * fast/forms/ValidityState-customError-002.html: Removed. Merged to ValidityState-customError.html.
              * fast/forms/ValidityState-customError-003-expected.txt: Removed. Merged to ValidityState-customError-expected.txt.
              * fast/forms/ValidityState-customError-003.html: Removed. Merged to ValidityState-customError.html.
              * fast/forms/ValidityState-customError-004-expected.txt: Removed. Merged to ValidityState-customError-expected.txt.
              * fast/forms/ValidityState-customError-004.html: Removed. Merged to ValidityState-customError.html.
              * fast/forms/ValidityState-patternMismatch-expected.txt: Added.
              * fast/forms/ValidityState-patternMismatch.html: Added.
              * fast/forms/ValidityState-patternMismatch-001-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
              * fast/forms/ValidityState-patternMismatch-001.html: Removed. Merged to ValidityState-patternMismatch.html.
              * fast/forms/ValidityState-patternMismatch-002-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
              * fast/forms/ValidityState-patternMismatch-002.html: Removed. Merged to ValidityState-patternMismatch.html.
              * fast/forms/ValidityState-patternMismatch-003-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
              * fast/forms/ValidityState-patternMismatch-003.html: Removed. Merged to ValidityState-patternMismatch.html.
              * fast/forms/ValidityState-patternMismatch-004-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
              * fast/forms/ValidityState-patternMismatch-004.html: Removed. Merged to ValidityState-patternMismatch.html.
              * fast/forms/ValidityState-patternMismatch-005-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
              * fast/forms/ValidityState-patternMismatch-005.html: Removed. Merged to ValidityState-patternMismatch.html.
              * fast/forms/ValidityState-patternMismatch-006-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
              * fast/forms/ValidityState-patternMismatch-006.html: Removed. Merged to ValidityState-patternMismatch.html.
              * fast/forms/ValidityState-patternMismatch-007-expected.txt: Removed. Merged to ValidityState-patternMismatch-expected.txt.
              * fast/forms/ValidityState-patternMismatch-007.html: Removed. Merged to ValidityState-patternMismatch.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd6974cf
    • commit-queue@webkit.org's avatar
      2010-12-10 Joone Hur <joone@kldp.org> · 1778ddbf
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
              https://bugs.webkit.org/show_bug.cgi?id=50783
      
              Unskip the following test cases:
              printing/page-rule-selection.html
              printing/page-format-data.html
              * platform/gtk/Skipped:
      2010-12-10  Joone Hur  <joone@kldp.org>
      
              Reviewed by Eric Seidel.
      
              [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
              https://bugs.webkit.org/show_bug.cgi?id=50783
      
              This patch allows to unskip the following test cases:
              printing/page-rule-selection.html
              printing/page-format-data.html
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::pageProperty): Added.
              (DumpRenderTreeSupportGtk::isPageBoxVisible): Ditto.
              (DumpRenderTreeSupportGtk::pageSizeAndMarginsInPixels): Ditto.
              (DumpRenderTreeSupportGtk::addUserStyleSheet): Ditto.
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      2010-12-10  Joone Hur  <joone@kldp.org>
      
              Reviewed by Eric Seidel.
      
              [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
              https://bugs.webkit.org/show_bug.cgi?id=50783
      
              This patch allows to unskip the following test cases:
              printing/page-rule-selection.html
              printing/page-format-data.html
      
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::pageProperty): Added.
              (LayoutTestController::isPageBoxVisible): Ditto.
              (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
              (LayoutTestController::addUserStyleSheet): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1778ddbf
    • pfeldman@chromium.org's avatar
      2010-12-10 Pavel Feldman <pfeldman@chromium.org> · e9f9151b
      pfeldman@chromium.org authored
              Not reviewed. Updated chromium test expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9f9151b
    • jocelyn.turcotte@nokia.com's avatar
      2010-12-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> · 02a1460b
      jocelyn.turcotte@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
      
              A menu allows to switch QNAM back to the same thread.
      
              * QtTestBrowser/launcherwindow.cpp:
              (LauncherWindow::initializeView):
              (LauncherWindow::createChrome):
              (LauncherWindow::toggleThreadedQnam):
              * QtTestBrowser/launcherwindow.h:
              (WindowOptions::WindowOptions):
              * QtTestBrowser/webpage.cpp:
              (WebPage::WebPage):
              (WebPage::setQnamThreaded):
              * QtTestBrowser/webpage.h:
              (QnamThread::QnamThread):
              (QnamThread::~QnamThread):
              (QnamThread::networkAccessManager):
              (QnamThread::run):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02a1460b
    • pfeldman@chromium.org's avatar
      2010-12-10 Pavel Feldman <pfeldman@chromium.org> · 004662b8
      pfeldman@chromium.org authored
              Not reviewed. Mark inspector tests as slow in Chromium expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      004662b8
    • jocelyn.turcotte@nokia.com's avatar
      2010-12-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> · 38910f31
      jocelyn.turcotte@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Support a QNetworkAccessManager affined to a different thread.
              https://bugs.webkit.org/show_bug.cgi?id=50080
      
              This patch introduce thread safe proxy classes for QNetworkAccessManager
              and QNetworkReply.
              If run in the same thread, these objects will forward the calls with
              Qt::DirectConnection bindings, while in the other case they will use
              Qt::QueuedConnection to carry requests accross threads.
      
              This patch basically:
              - Makes sure that all access goes through these objects
              - Reorders signal connections to make sure we are connected when the
                signal comes
              - Makes sure that no QObject in the WebCore thread is a child of the
                reply which might be in a different thread.
              - Forward the data directly in QByteArrays in signals instead of collecting
                the data when the signal is handled.
      
              New test: tst_QWebPage::networkAccessManagerOnDifferentThread
      
              * WebCore.pro:
              * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
              (WebCore::MediaPlayerPrivateQt::commitLoad):
              * platform/network/qt/QNetworkReplyHandler.cpp:
              (WebCore::FormDataIODevice::FormDataIODevice):
              (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
              (WebCore::QNetworkReplyHandler::~QNetworkReplyHandler):
              (WebCore::QNetworkReplyHandler::setLoadMode):
              (WebCore::QNetworkReplyHandler::abort):
              (WebCore::QNetworkReplyHandler::release):
              (WebCore::ignoreHttpError):
              (WebCore::QNetworkReplyHandler::finish):
              (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
              (WebCore::QNetworkReplyHandler::forwardData):
              (WebCore::QNetworkReplyHandler::start):
              (WebCore::QNetworkReplyHandler::sendQueuedItems):
              * platform/network/qt/QNetworkReplyHandler.h:
              * platform/network/qt/QtNAMThreadSafeProxy.cpp: Added.
              * platform/network/qt/QtNAMThreadSafeProxy.h: Added.
              * platform/network/qt/ResourceHandleQt.cpp:
              (WebCore::ResourceHandle::willLoadFromCache):
              * platform/qt/CookieJarQt.cpp:
              (WebCore::networkAccessManager):
              (WebCore::setCookies):
              (WebCore::cookies):
              (WebCore::cookieRequestHeaderFieldValue):
              (WebCore::cookiesEnabled):
      2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Support a QNetworkAccessManager affined to a different thread.
              https://bugs.webkit.org/show_bug.cgi?id=50080
      
              This patch introduce thread safe proxy classes for QNetworkAccessManager
              and QNetworkReply.
              If run in the same thread, these objects will forward the calls with
              Qt::DirectConnection bindings, while in the other case they will use
              Qt::QueuedConnection to carry requests accross threads.
      
              This patch basically:
              - Makes sure that all access goes through these objects
              - Reorders signal connections to make sure we are connected when the
                signal comes
              - Makes sure that no QObject in the WebCore thread is a child of the
                reply which might be in a different thread.
              - Forward the data directly in QByteArrays in signals instead of collecting
                the data when the signal is handled.
      
              New test: tst_QWebPage::networkAccessManagerOnDifferentThread
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::download):
              * tests/qwebpage/tst_qwebpage.cpp:
              (QtNAMThread::QtNAMThread):
              (QtNAMThread::~QtNAMThread):
              (QtNAMThread::networkAccessManager):
              (QtNAMThread::run):
              (tst_QWebPage::networkAccessManagerOnDifferentThread):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38910f31
    • commit-queue@webkit.org's avatar
      2010-12-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com> · bd4f931d
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Flush IPC connection send buffer after each message.
      
              [Qt] [WK2] IPC messages are not sent until send buffer fills up
              https://bugs.webkit.org/show_bug.cgi?id=50667
      
              * Platform/CoreIPC/qt/ConnectionQt.cpp:
              (CoreIPC::Connection::sendOutgoingMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd4f931d
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Refactor QNetworkReplyHandler::finish() to prevent crashes. · 64ec5c94
      jocelyn.turcotte@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50761
      
      Reviewed by Kenneth Rohde Christiansen.
      
      This patch change the order to check if m_reply is null instead,
      explicitly deleting the reply before calling start() for a redirect,
      or after calling didFinishLoading()/didFail() in other cases.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyHandler::finish):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64ec5c94
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Make sure we send the response before any data. · b216401b
      jocelyn.turcotte@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50760
      
      Reviewed by Kenneth Rohde Christiansen.
      
      This patch make sure the data available flag is set before
      we call sendResponseIfNeeded.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
      (WebCore::QNetworkReplyHandler::finish):
      (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
      (WebCore::QNetworkReplyHandler::forwardData):
      (WebCore::QNetworkReplyHandler::resetState):
      * platform/network/qt/QNetworkReplyHandler.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b216401b
    • commit-queue@webkit.org's avatar
      2010-12-10 Koan-Sin Tan <koansin.tan@gmail.com> · d1f901a9
      commit-queue@webkit.org authored
              Reviewed by Dan Bernstein.
      
              Bopomofo should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp
              https://bugs.webkit.org/show_bug.cgi?id=50668
      
              No new tests. Note that, as said in the bug report discussion,
              I did have a test case for the bug. However, to show the test
              case you need some "broken" Microsoft copyrighted fonts, such
              as DFKai-SB.
      
              * platform/graphics/Font.cpp:
              (WebCore::Font::isCJKIdeograph):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1f901a9
    • philn@webkit.org's avatar
      2010-12-10 Philippe Normand <pnormand@igalia.com> · b6c117b7
      philn@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [GStreamer] un-needed methods
              https://bugs.webkit.org/show_bug.cgi?id=50805
      
              No new tests, code cleanup only.
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6c117b7
    • paroga@webkit.org's avatar
      2010-12-10 Patrick Gansterer <paroga@webkit.org> · a124a010
      paroga@webkit.org authored
              Reviewed by Eric Seidel.
      
              Cleanup StringWx.cpp
              https://bugs.webkit.org/show_bug.cgi?id=50525
      
              Use StringImpl::createUninitialized to avoid memcpy and fix style issues.
      
              * wtf/wx/StringWx.cpp:
              (WTF::String::String):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a124a010
    • mrobinson@webkit.org's avatar
      2010-12-10 Carlos Garcia Campos <cgarcia@igalia.com> · feabe044
      mrobinson@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Simplify context-menu handling code
              https://bugs.webkit.org/show_bug.cgi?id=49658
      
              * wtf/PlatformRefPtr.h:
      2010-12-10  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Simplify context-menu handling code
              https://bugs.webkit.org/show_bug.cgi?id=49658
      
              * platform/ContextMenuItem.h:
              * platform/gtk/ContextMenuGtk.cpp:
              (WebCore::ContextMenu::appendItem):
              * platform/gtk/ContextMenuItemGtk.cpp:
              (WebCore::ContextMenuItem::ContextMenuItem):
              (WebCore::ContextMenuItem::~ContextMenuItem):
              (WebCore::ContextMenuItem::releasePlatformDescription):
              (WebCore::ContextMenuItem::type):
              (WebCore::ContextMenuItem::setType):
              (WebCore::ContextMenuItem::action):
              (WebCore::ContextMenuItem::setAction):
              (WebCore::ContextMenuItem::title):
              (WebCore::ContextMenuItem::setTitle):
              (WebCore::ContextMenuItem::platformSubMenu):
              (WebCore::ContextMenuItem::setSubMenu):
              (WebCore::ContextMenuItem::setChecked):
              (WebCore::ContextMenuItem::setEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      feabe044