- 23 Dec, 2010 40 commits
-
-
darin@apple.com authored
Reviewed by Sam Weinig. WKView should not try to do asynchronous validation for selectors that are not editor commands https://bugs.webkit.org/show_bug.cgi?id=51555 * WebCore.exp.in: Added commandIsSupportedFromMenuOrKeyBinding. * editing/Editor.h: Reordered arguments in the Editor::Command constructor and the data members too so the frame is last. Added commandIsSupportedFromMenuOrKeyBinding. * editing/EditorCommand.cpp: (WebCore::supported): Removed the EditorCommandSource argument. These functions are now only used when called from DOM. (WebCore::supportedFromMenuOrKeyBinding): Ditto. (WebCore::supportedCopyCut): Ditto. (WebCore::supportedPaste): Ditto. (WebCore::enabledDismissCorrectionPanel): Changed the supported function to an enabled function. It was incorrect to say that this is "supported" only when the correction panel is up. Correct to say that it is "enabled" only then. And also probably OK to enable it even when the selection is not in editable text, as long as the panel is up. (WebCore::createCommandMap): Moved conditional commands out of the main array into a separate section at the end. (WebCore::internalCommand): Added. (WebCore::Editor::command): Changed to use the new internalCommand function and simplified by relying on the null check in the Command constructor. (WebCore::Editor::commandIsSupportedFromMenuOrKeyBinding): Added. (WebCore::Editor::Command::Command): Removed unneeded initialization of m_source, which is never looked at if m_command is 0. Added feature of passing a null command pointer to the non-default constructor. (WebCore::Editor::Command::isSupported): Changed to only call the per-command isSupported function when the command source is DOM. Accordingly that function is now called isSupportedFromDOM. 2010-12-23 Darin Adler <darin@apple.com> Reviewed by Sam Weinig. WKView should not try to do asynchronous validation for selectors that are not editor commands https://bugs.webkit.org/show_bug.cgi?id=51555 * UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Removed the special case for startSpeaking. Added call to commandIsSupportedFromMenuOrKeyBinding so we only try to do validation for commands that are supported. Tweaked comments and added some bug numbers. (-[WKView _setUserInterfaceItemState:enabled:state:]): Tweaked comment and added bug number. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mdelaney@apple.com authored
Reviewed by Simon Fraser. Incorrect layer property used noted as changed in GraphicsLayerCA::setAcceleratesDrawing https://bugs.webkit.org/show_bug.cgi?id=51560 No new tests. * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setAcceleratesDrawing): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ajwong@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=51500 Rebaseline media control layout tests due to pixel diff from r74535 * platform/chromium-linux/media/audio-controls-rendering-expected.checksum: * platform/chromium-linux/media/audio-controls-rendering-expected.png: * platform/chromium-linux/media/controls-after-reload-expected.checksum: * platform/chromium-linux/media/controls-after-reload-expected.png: * platform/chromium-linux/media/controls-strict-expected.checksum: * platform/chromium-linux/media/controls-strict-expected.png: * platform/chromium-linux/media/controls-styling-expected.checksum: * platform/chromium-linux/media/controls-styling-expected.png: * platform/chromium-linux/media/controls-without-preload-expected.checksum: * platform/chromium-linux/media/controls-without-preload-expected.png: * platform/chromium-linux/media/video-controls-rendering-expected.checksum: * platform/chromium-linux/media/video-controls-rendering-expected.png: * platform/chromium-linux/media/video-display-toggle-expected.checksum: * platform/chromium-linux/media/video-display-toggle-expected.png: * platform/chromium-linux/media/video-empty-source-expected.checksum: * platform/chromium-linux/media/video-empty-source-expected.png: * platform/chromium-linux/media/video-no-audio-expected.checksum: * platform/chromium-linux/media/video-no-audio-expected.png: * platform/chromium-linux/media/video-volume-slider-expected.checksum: * platform/chromium-linux/media/video-volume-slider-expected.png: * platform/chromium-mac/media/audio-controls-rendering-expected.checksum: * platform/chromium-mac/media/audio-controls-rendering-expected.png: * platform/chromium-mac/media/audio-controls-rendering-expected.txt: * platform/chromium-mac/media/controls-after-reload-expected.checksum: * platform/chromium-mac/media/controls-after-reload-expected.png: * platform/chromium-mac/media/controls-after-reload-expected.txt: * platform/chromium-mac/media/controls-strict-expected.checksum: * platform/chromium-mac/media/controls-strict-expected.png: * platform/chromium-mac/media/controls-strict-expected.txt: * platform/chromium-mac/media/controls-styling-expected.checksum: * platform/chromium-mac/media/controls-styling-expected.png: * platform/chromium-mac/media/controls-styling-expected.txt: * platform/chromium-mac/media/controls-without-preload-expected.checksum: * platform/chromium-mac/media/controls-without-preload-expected.png: * platform/chromium-mac/media/controls-without-preload-expected.txt: * platform/chromium-mac/media/video-display-toggle-expected.checksum: * platform/chromium-mac/media/video-display-toggle-expected.png: * platform/chromium-mac/media/video-display-toggle-expected.txt: * platform/chromium-mac/media/video-empty-source-expected.checksum: * platform/chromium-mac/media/video-empty-source-expected.png: * platform/chromium-mac/media/video-empty-source-expected.txt: * platform/chromium-mac/media/video-no-audio-expected.checksum: * platform/chromium-mac/media/video-no-audio-expected.png: * platform/chromium-mac/media/video-no-audio-expected.txt: * platform/chromium-mac/media/video-volume-slider-expected.checksum: * platform/chromium-mac/media/video-volume-slider-expected.png: * platform/chromium-mac/media/video-volume-slider-expected.txt: * platform/chromium-win/media/audio-controls-rendering-expected.checksum: * platform/chromium-win/media/audio-controls-rendering-expected.png: * platform/chromium-win/media/audio-controls-rendering-expected.txt: * platform/chromium-win/media/controls-after-reload-expected.checksum: * platform/chromium-win/media/controls-after-reload-expected.png: * platform/chromium-win/media/controls-after-reload-expected.txt: * platform/chromium-win/media/controls-strict-expected.checksum: * platform/chromium-win/media/controls-strict-expected.png: * platform/chromium-win/media/controls-strict-expected.txt: * platform/chromium-win/media/controls-styling-expected.checksum: * platform/chromium-win/media/controls-styling-expected.png: * platform/chromium-win/media/controls-styling-expected.txt: * platform/chromium-win/media/controls-without-preload-expected.checksum: * platform/chromium-win/media/controls-without-preload-expected.png: * platform/chromium-win/media/controls-without-preload-expected.txt: * platform/chromium-win/media/video-controls-rendering-expected.checksum: * platform/chromium-win/media/video-controls-rendering-expected.png: * platform/chromium-win/media/video-controls-rendering-expected.txt: * platform/chromium-win/media/video-display-toggle-expected.checksum: * platform/chromium-win/media/video-display-toggle-expected.png: * platform/chromium-win/media/video-display-toggle-expected.txt: * platform/chromium-win/media/video-empty-source-expected.checksum: * platform/chromium-win/media/video-empty-source-expected.png: * platform/chromium-win/media/video-empty-source-expected.txt: * platform/chromium-win/media/video-no-audio-expected.checksum: * platform/chromium-win/media/video-no-audio-expected.png: * platform/chromium-win/media/video-no-audio-expected.txt: * platform/chromium-win/media/video-volume-slider-expected.checksum: * platform/chromium-win/media/video-volume-slider-expected.png: * platform/chromium-win/media/video-volume-slider-expected.txt: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Andreas Kling. [Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown https://bugs.webkit.org/show_bug.cgi?id=35635 Explicitly set text/html data on QClipboard as UTF-8 and also include a <meta> tag informing the OS that the data is in UTF-8 format. * platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeSelection): 2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com> Reviewed by Andreas Kling. [Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown https://bugs.webkit.org/show_bug.cgi?id=35635 Test that QClipboard contains the charset information and unicode data after copying unicode text. * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::macCopyUnicodeToClipboard): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbr@google.com authored
Unreviewed Chromium expectations update. Suppress crashes seen on Windows with fast/canvas/webgl/canvas-test.html and fast/canvas/webgl/gl-pixelstorei.html. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/8799032weinig@apple.com authored
REGRESSION(r74436) Crash opening many pages with WebKit2 Reviewed by Anders Carlsson. * Shared/cf/ArgumentCodersCF.cpp: (CoreIPC::decode): Fix paste-o. Decode into a CFDataRef not a CFDictionaryRef when decoding CFDataRefs. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jschuh@chromium.org authored
Reviewed by Eric Seidel. CSSCursorImageValue destructor should clear referenced element. https://bugs.webkit.org/show_bug.cgi?id=51417 Calls correct method to clear image and renames method to avoid future confusion. Test: svg/css/cursor-image-replace.svg * css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue): * svg/SVGElement.cpp: (WebCore::SVGElement::cursorImageValueRemoved): * svg/SVGElement.h: 2010-12-23 Justin Schuh <jschuh@chromium.org> Reviewed by Eric Seidel. CSSCursorImageValue destructor should clear referenced element. https://bugs.webkit.org/show_bug.cgi?id=51417 * svg/css/cursor-image-replace-expected.txt: Added. * svg/css/cursor-image-replace.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbr@google.com authored
Unreviewed Chromium expectations update. Allow fast/css/box-shadow.html to fail with IMAGE as well as IMAGE+TEXT. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
* src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::didSaveToPageCache): (WebKit::FrameLoaderClientImpl::didRestoreFromPageCache): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=51546 Reviewed by Darin Adler. WebCore: - Add client functions to notify that a frame has been added or removed from the page cache. * history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): (WebCore::CachedFrame::CachedFrame): * history/CachedFrame.h: * loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didSaveToPageCache): (WebCore::EmptyFrameLoaderClient::didRestoreFromPageCache): * loader/FrameLoaderClient.h: WebKit/chromium: - Add client functions to notify that a frame has been added or removed from the page cache. * src/FrameLoaderClientImpl.cpp: (WebKit::WebFrameLoaderClientImpl::didSaveToPageCache): (WebKit::WebFrameLoaderClientImpl::didRestoreFromPageCache): * src/FrameLoaderClientImpl.h: WebKit/efl: - Add client functions to notify that a frame has been added or removed from the page cache. * WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::didSaveToPageCache): (WebCore::FrameLoaderClientEfl::didRestoreFromPageCache): * WebCoreSupport/FrameLoaderClientEfl.h: WebKit/gtk: - Add client functions to notify that a frame has been added or removed from the page cache. * WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didSaveToPageCache): (WebKit::FrameLoaderClient::didRestoreFromPageCache): * WebCoreSupport/FrameLoaderClientGtk.h: WebKit/haiku: - Add client functions to notify that a frame has been added or removed from the page cache. * WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::didSaveToPageCache): (WebCore::FrameLoaderClientHaiku::didRestoreFromPageCache): * WebCoreSupport/FrameLoaderClientHaiku.h: WebKit/mac: - Add client functions to notify that a frame has been added or removed from the page cache. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didSaveToPageCache): (WebFrameLoaderClient::didRestoreFromPageCache): WebKit/qt: - Add client functions to notify that a frame has been added or removed from the page cache. * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didSaveToPageCache): (WebCore::FrameLoaderClientQt::didRestoreFromPageCache): * WebCoreSupport/FrameLoaderClientQt.h: WebKit/win: - Add client functions to notify that a frame has been added or removed from the page cache. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didSaveToPageCache): (WebFrameLoaderClient::didRestoreFromPageCache): * WebCoreSupport/WebFrameLoaderClient.h: WebKit/wince: - Add client functions to notify that a frame has been added or removed from the page cache. * WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::didSaveToPageCache): (WebKit::FrameLoaderClientWinCE::didRestoreFromPageCache): * WebCoreSupport/FrameLoaderClientWinCE.h: WebKit/wx: - Add client functions to notify that a frame has been added or removed from the page cache. * WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::didSaveToPageCache): (WebCore::FrameLoaderClientWx::didRestoreFromPageCache): * WebKitSupport/FrameLoaderClientWx.h: WebKit2: * UIProcess/API/C/WKFrame.cpp: (WKFrameCopyChildFrames): * UIProcess/API/C/WKFrame.h: Add API to get the child frames of a frame. * UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::WebFrameProxy): (WebKit::WebFrameProxy::disconnect): (WebKit::WebFrameProxy::appendChild): (WebKit::WebFrameProxy::removeChild): (WebKit::WebFrameProxy::isDescendantOf): (WebKit::WebFrameProxy::dumpFrameTree): (WebKit::WebFrameProxy::didRemoveFromHierarchy): (WebKit::WebFrameProxy::childFrames): * UIProcess/WebFrameProxy.h: (WebKit::WebFrameProxy::parentFrame): Add getter. (WebKit::WebFrameProxy::nextSibling): Add getter. (WebKit::WebFrameProxy::previousSibling): Add getter. (WebKit::WebFrameProxy::firstChild): Add getter. (WebKit::WebFrameProxy::lastChild): Add getter. Make frames keep track of their subframes. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCreateSubframe): Use the now passed parentID to insert the frame into the hierarchy (WebKit::WebPageProxy::didSaveFrameToPageCache): When a frame is added to the page cache, remove it from the hierarchy. (WebKit::WebPageProxy::didRestoreFrameFromPageCache): When a frame is restored from the page cache, add it back to the hierarchy. (WebKit::WebPageProxy::didRemoveFrameFromHierarchy): Detached frames should also be removed from the hierarchy. * UIProcess/WebPageProxy.h: Add new declarations for didSaveFrameToPageCache and didRestoreFrameFromPageCache. * UIProcess/WebPageProxy.messages.in: Add messages for DidSaveFrameToPageCache and DidRestoreFrameFromPageCache. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::savePlatformDataToCachedFrame): (WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame): Remove notImplemented, there is no work we need to do here. (WebKit::WebFrameLoaderClient::didSaveToPageCache): (WebKit::WebFrameLoaderClient::didRestoreFromPageCache): Send message to UIProcess to indicate this happened. * WebProcess/WebCoreSupport/WebFrameLoaderClient.h: * WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::createSubframe): Send parent frameID in addition to our own in the message to UIProcess. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mdelaney@apple.com authored
Reviewed by Simon Fraser. Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces This patch also changes USE_IOSURFACE to instead follow USE(IOSURFACE) https://bugs.webkit.org/show_bug.cgi?id=51279 * html/HTMLCanvasElement.cpp: For IOSurface, use setNeedsStyleRecalc * html/canvas/CanvasRenderingContext2D.cpp: Use new flag * platform/graphics/ImageBuffer.h: Use new flag * platform/graphics/cg/ImageBufferCG.cpp: Use new flag 2010-12-22 Matthew Delaney <mdelaney@apple.com> Reviewed by Simon Fraser. Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces https://bugs.webkit.org/show_bug.cgi?id=51279 * platform/mac-snowleopard/platform/mac/compositing: Added. * platform/mac-snowleopard/platform/mac/compositing/canvas: Added. * platform/mac-snowleopard/platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added. * platform/mac/compositing/canvas: Added. * platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added. * platform/mac/compositing/canvas/accelerated-canvas-compositing.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Sam Weinig. New popup windows open disproportionately big https://bugs.webkit.org/show_bug.cgi?id=51547 <rdar://problem/8637029> * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::createNewPage): Pass the correct size back to the UI process. * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::pageRect): Implement this and return the size of the page. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
enne@google.com authored
Reviewed by Kenneth Russell. [chromium] Tile root layer of the compositor. https://bugs.webkit.org/show_bug.cgi?id=49947 Refactor root layer update and drawing from LayerRendererChromium into LayerTilerChromium. The root layer is now drawn as multiple tiles rather than as one single large texture. Scrollbars are now drawn separately rather than as part of the root layer. Test: LayoutTests/compositing/ * WebCore.gypi: * page/FrameView.cpp: (WebCore::FrameView::repaintContentRectangle): * platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::setClipsRepaints): * platform/ScrollView.h: (WebCore::ScrollView::clipsRepaints): * platform/graphics/chromium/LayerChromium.h: * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::useShader): (WebCore::LayerRendererChromium::verticalScrollbarRect): (WebCore::LayerRendererChromium::horizontalScrollbarRect): (WebCore::LayerRendererChromium::invalidateRootLayerRect): (WebCore::LayerRendererChromium::updateAndDrawRootLayer): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::setRootLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects): * platform/graphics/chromium/LayerRendererChromium.h: * platform/graphics/chromium/LayerTilerChromium.cpp: Added. (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::~LayerTilerChromium): (WebCore::LayerTilerChromium::layerRendererContext): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::createTile): (WebCore::LayerTilerChromium::invalidateTiles): (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::contentRectToLayerRect): (WebCore::LayerTilerChromium::layerRectToContentRect): (WebCore::LayerTilerChromium::tileIndex): (WebCore::LayerTilerChromium::tileContentRect): (WebCore::LayerTilerChromium::tileLayerRect): (WebCore::LayerTilerChromium::invalidateRect): (WebCore::LayerTilerChromium::invalidateEntireLayer): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::setLayerPosition): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::resizeLayer): (WebCore::LayerTilerChromium::growLayerToContain): (WebCore::LayerTilerChromium::Tile::~Tile): (WebCore::LayerTilerChromium::Tile::releaseTextureId): * platform/graphics/chromium/LayerTilerChromium.h: Added. (WebCore::LayerTilerChromium::Tile::Tile): (WebCore::LayerTilerChromium::Tile::textureId): (WebCore::LayerTilerChromium::Tile::dirty): (WebCore::LayerTilerChromium::Tile::clearDirty): (WebCore::LayerTilerChromium::layerRenderer): 2010-12-20 Adrienne Walker <enne@google.com> Reviewed by Kenneth Russell. [chromium] Tile root layer of the compositor. https://bugs.webkit.org/show_bug.cgi?id=49947 Refactor root layer logic out of WebViewImpl and into LayerTilerChromium. The painting is now done through an interface rather than directly in WebViewImpl. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollRootLayerRect): (WebKit::WebViewImpl::invalidateRootLayerRect): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImplTilePaintInterface::WebViewImplTilePaintInterface): (WebKit::WebViewImplTilePaintInterface::paint): (WebKit::WebViewImplScrollbarPaintInterface::WebViewImplScrollbarPaintInterface): (WebKit::WebViewImplScrollbarPaintInterface::paint): (WebKit::WebViewImpl::doComposite): * src/WebViewImpl.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbr@google.com authored
Unreviewed Chromium expectations update. Fix incorrect syntax for fast/css/box-shadow.html suppression and state that fast/events/touch/touch-target.html may timeout. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Reviewed by Eric Seidel. Editor.h doesn't need to include SelectionController.h https://bugs.webkit.org/show_bug.cgi?id=51441 Renamed SelectionController::EDirection to SelectionDirection. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeCommand): 2010-12-22 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Eric Seidel. Editor.h doesn't need to include SelectionController.h https://bugs.webkit.org/show_bug.cgi?id=51441 Renamed SelectionController::EDirection to SelectionDirection. * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent): 2010-12-22 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Eric Seidel. Editor.h doesn't need to include SelectionController.h https://bugs.webkit.org/show_bug.cgi?id=51441 Renamed SelectionController::EDirection to SelectionDirection. * WebView/WebFrame.mm: (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]): Takes SelectionDirection instead of SelectionController::EDirection. * WebView/WebFrameInternal.h: * WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController. 2010-12-22 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Eric Seidel. Editor.h doesn't need to include SelectionController.h https://bugs.webkit.org/show_bug.cgi?id=51441 Renamed SelectionController::EDirection to SelectionDirection. * WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent): 2010-12-22 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Eric Seidel. Editor.h doesn't need to include SelectionController.h https://bugs.webkit.org/show_bug.cgi?id=51441 Renamed SelectionController::EDirection to SelectionDirection. * WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::handleEditingKeyboardEvent): 2010-12-22 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Eric Seidel. Editor.h doesn't need to include SelectionController.h https://bugs.webkit.org/show_bug.cgi?id=51441 Renamed SelectionController::EDirection to SelectionDirection. * WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::handleEditingKeyboardEvent): 2010-12-22 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Eric Seidel. Editor.h doesn't need to include SelectionController.h https://bugs.webkit.org/show_bug.cgi?id=51441 Removed #include <Selection.h> from Editor.h. Also extracted WritingDirection.h from EditingStyle.h and renamed SelectionController::EDirection to SelectionDirection and moved its declaration from SelectionController.h to VisibleSelection.h * WebCore.exp.in: Signature changes. * WebCore.xcodeproj/project.pbxproj: Added WritingDirection.h * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): Change due to SelectionDirection. * editing/EditingStyle.h: Removed WritingDirection and included WritingDirection.h * editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): Change due to SelectionDirection. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto. (WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto. * editing/Editor.h: Removed SelectionController.h; added DocumentMarker.h, Timer.h, VisibleSelection.h and WritingDirection.h; forward declared CSSMutableStyleDeclaration. * editing/EditorCommand.cpp: (WebCore::executeDeleteBackward): Change due to SelectionDirection. (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto. (WebCore::executeDeleteForward): Ditto. (WebCore::executeDeleteToBeginningOfLine): Ditto. (WebCore::executeDeleteToBeginningOfParagraph): Ditto. (WebCore::executeDeleteToEndOfLine): Ditto. (WebCore::executeDeleteToEndOfParagraph): Ditto. (WebCore::executeDeleteWordBackward): Ditto. (WebCore::executeDeleteWordForward): Ditto. (WebCore::executeForwardDelete): Ditto. (WebCore::executeMoveBackward): Ditto. (WebCore::executeMoveBackwardAndModifySelection): Ditto. (WebCore::executeMoveDown): Ditto. (WebCore::executeMoveDownAndModifySelection): Ditto. (WebCore::executeMoveForward): Ditto. (WebCore::executeMoveForwardAndModifySelection): Ditto. (WebCore::executeMoveLeft): Ditto. (WebCore::executeMoveLeftAndModifySelection): Ditto. (WebCore::executeMoveRight): Ditto. (WebCore::executeMoveRightAndModifySelection): Ditto. (WebCore::executeMoveToBeginningOfDocument): Ditto. (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): Ditto. (WebCore::executeMoveToBeginningOfLine): Ditto. (WebCore::executeMoveToBeginningOfLineAndModifySelection): Ditto. (WebCore::executeMoveToBeginningOfParagraph): Ditto. (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): Ditto. (WebCore::executeMoveToBeginningOfSentence): Ditto. (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): Ditto. (WebCore::executeMoveToEndOfDocument): Ditto. (WebCore::executeMoveToEndOfDocumentAndModifySelection): Ditto. (WebCore::executeMoveToEndOfSentence): Ditto. (WebCore::executeMoveToEndOfSentenceAndModifySelection): Ditto. (WebCore::executeMoveToEndOfLine): Ditto. (WebCore::executeMoveToEndOfLineAndModifySelection): Ditto. (WebCore::executeMoveToEndOfParagraph): Ditto. (WebCore::executeMoveToEndOfParagraphAndModifySelection): Ditto. (WebCore::executeMoveParagraphBackwardAndModifySelection): Ditto. (WebCore::executeMoveParagraphForwardAndModifySelection): Ditto. (WebCore::executeMoveUp): Ditto. (WebCore::executeMoveUpAndModifySelection): Ditto. (WebCore::executeMoveWordBackward): Ditto. (WebCore::executeMoveWordBackwardAndModifySelection): Ditto. (WebCore::executeMoveWordForward): Ditto. (WebCore::executeMoveWordForwardAndModifySelection): Ditto. (WebCore::executeMoveWordLeft): Ditto. (WebCore::executeMoveWordLeftAndModifySelection): Ditto. (WebCore::executeMoveWordRight): Ditto. (WebCore::executeMoveWordRightAndModifySelection): Ditto. (WebCore::executeMoveToLeftEndOfLine): Ditto. (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Ditto. (WebCore::executeMoveToRightEndOfLine): Ditto. (WebCore::executeMoveToRightEndOfLineAndModifySelection): Ditto. * editing/SelectionController.cpp: (WebCore::SelectionController::willBeModified): Takes SelectionDirection instead of EDirection. (WebCore::SelectionController::modify): Ditto. * editing/SelectionController.h: Change due to SelectionDirection. * editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Ditto. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. * editing/VisibleSelection.h: Added SelectionDirection, renamed and moved from EDirection in SelectionController.h * editing/WritingDirection.h: Added. * page/DOMSelection.cpp: (WebCore::DOMSelection::modify): Change due to SelectionDirection. (WebCore::DOMSelection::deleteFromDocument): Ditto. * page/EventHandler.cpp: (WebCore::EventHandler::handleKeyboardSelectionMovement): Ditto. * page/Frame.h: Includes SelectionController.h. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
lforschler@apple.com authored
Reviewed by Darin Adler. Bug 51537 - iexploder needs cleanup * iExploder/htdocs: Removed. * iExploder/htdocs/config.rb: Removed. * iExploder/htdocs/cssproperties.in: Removed. * iExploder/htdocs/cssvalues.in: Removed. * iExploder/htdocs/htmlattrs.in: Removed. * iExploder/htdocs/htmltags.in: Removed. * iExploder/htdocs/htmlvalues.in: Removed. * iExploder/htdocs/iexploder.cgi: Removed. * iExploder/htdocs/iexploder.rb: Removed. * iExploder/htdocs/index.html: Removed. * iExploder/htdocs/webserver.rb: Removed. * iExploder/iexploder-1.7.2/output: Removed. * iExploder/tools: Removed. * iExploder/tools/lasthit.rb: Removed. * iExploder/tools/osx_last_crash.rb: Removed. * iExploder/tools/showtest.rb: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by John Sullivan. Nothing happens clicking "launch live player" on live.cnn.com https://bugs.webkit.org/show_bug.cgi?id=51540 <rdar://problem/8791086> Implement NPN_PushPopupsEnabledState/NPN_PopPopupsEnabledState. * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_PushPopupsEnabledState): Call NetscapePlugin::pushPopupsEnabledState. (WebKit::NPN_PopPopupsEnabledState): Call NetscapePlugin::popPopupsEnabledState. * WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::pushPopupsEnabledState): Append the boolean to the vector. (WebKit::NetscapePlugin::popPopupsEnabledState): Remove the last boolean from the vector. (WebKit::NetscapePlugin::allowPopups): Return the last boolean from the vector. * WebProcess/Plugins/Netscape/NetscapePlugin.h: * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performJavaScriptURLRequest): Update the "allowPopupsFromPlugin" state. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Darin Adler. Move V8 to WebCore's implementation of showModalDialog https://bugs.webkit.org/show_bug.cgi?id=51527 This code is basically verbatim translation from the JavaScriptCore bindings. The only intentional difference is in the world selection for the dialog's frame. I suspect JavaScriptCore's bindings have a subtle bug there. In this patch, I also remove a bunch of now-unneeded code in the generic bindings. * bindings/generic/BindingDOMWindow.h: * bindings/js/JSDOMWindowCustom.cpp: (WebCore::DialogHandler::dialogCreated): (WebCore::setUpDialog): * bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::DialogHandler::DialogHandler): (WebCore::DialogHandler::dialogCreated): (WebCore::DialogHandler::returnValue): (WebCore::setUpDialog): (WebCore::V8DOMWindow::showModalDialogCallback): (WebCore::V8DOMWindow::openCallback): * bindings/v8/specialization/V8BindingDOMWindow.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Reviewed by Joseph Pecoraro. Web Inspector: Can't backspace from CSS value to CSS key field https://bugs.webkit.org/show_bug.cgi?id=51476 * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Russell. [chromium] Add asserts to test for contiguous-pixel Skia bitmaps. https://bugs.webkit.org/show_bug.cgi?id=51186 No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated. * platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty): * platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData): 2010-12-23 W. James MacLean <wjmaclean@chromium.org> Reviewed by Kenneth Russell. [chromium] Add asserts to test for contiguous-pixel Skia bitmaps. https://bugs.webkit.org/show_bug.cgi?id=51186 Add asserts to detect if assumptions (about contiguous pixels in Skia bitmaps) are violated. * src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
fast/profiler/throw-exception-from-eval-expected.html in order to get the Windows XP Debug test bot green again. Unreviewed. https://bugs.webkit.org/show_bug.cgi?id=49801 * platform/win-xp/fast/profiler: Added. * platform/win-xp/fast/profiler/throw-exception-from-eval-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [EFL] Make 'single' the default backing store in EWebLauncher https://bugs.webkit.org/show_bug.cgi?id=51534 'single' is the simplest backing store and the one intended to be the default in the test browser. By mistake the tiled backing store was left as default in r72617. * EWebLauncher/main.c: (browserCreate): ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Add a 'hasSelection' function to QWebView and QWebPage. https://bugs.webkit.org/show_bug.cgi?id=48722 This is a convenience API that optimizes the case where checking for the presence of selected content and accessing the selected content are two separate actions in the client. See comment #12 in the above bug report link for details. * Api/qwebpage.cpp: (QWebPage::hasSelection): * Api/qwebpage.h: * Api/qwebview.cpp: (QWebView::hasSelection): * Api/qwebview.h: * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textSelection): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jeremy@chromium.org authored
Unreviewed new Chromium baselines and test expectations update. * platform/chromium-linux/fast/layers/video-layer-expected.checksum: * platform/chromium-linux/fast/layers/video-layer-expected.png: * platform/chromium-mac/fast/layers/video-layer-expected.checksum: * platform/chromium-mac/fast/layers/video-layer-expected.png: * platform/chromium-mac/fast/layers/video-layer-expected.txt: * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/chromium-win/fast/layers/video-layer-expected.checksum: * platform/chromium-win/fast/layers/video-layer-expected.png: * platform/chromium-win/fast/layers/video-layer-expected.txt: * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [EFL] Fix ContextMenu removal https://bugs.webkit.org/show_bug.cgi?id=51530 Fix ContextMenu removal In r74207 the support for ContextMenu was removed from EFL while the code is being ported to the new CROSS_PLATFORM_MENUS due to build breakage. However there were some missing removals in the shutdown logic that introduced a bug, leading to a segmentation fault when ContexController was destroyed. The best way to effectively disable the ContextMenu is to conditionally compile the meaningful stuff by surrounding with "#if ENABLE(CONTEXT_MENUS)" and then disabling it in CMake. * cmake/OptionsEfl.cmake: Disable ContextMenu and don't pretend we implement CROSS_PLATFORM_MENUS yet. 2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi> Reviewed by Kenneth Rohde Christiansen. [EFL] Fix ContextMenu removal https://bugs.webkit.org/show_bug.cgi?id=51530 Fix ContextMenu removal In r74207 the support for ContextMenu was removed from EFL while the code is being ported to the new CROSS_PLATFORM_MENUS due to build breakage. However there were some missing removals in the shutdown logic that introduced a bug, leading to a segmentation fault when ContexController was destroyed. The best way to effectively disable the ContextMenu is to conditionally compile the meaningful stuff by surrounding with "#if ENABLE(CONTEXT_MENUS)" and then disabling it in CMake. * ewk/ewk_contextmenu.cpp: surround need parts with #if ENABLE(CONTEXT_MENUS). (ewk_context_menu_destroy): ditto. (ewk_context_menu_item_select): ditto. * ewk/ewk_private.h: ditto. * ewk/ewk_view.cpp: ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Fix check by undefined macro https://bugs.webkit.org/show_bug.cgi?id=51531 Fix check by undefined macro When building EFL port with libsoup, BUILDING_GTK__ is not defined, leading to warnings during compile. We actually have to use an #ifdef instead of an #if. No change in functionality so no new tests. * platform/network/soup/cache/webkit/soup-cache.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [EFL] Clean warnings in Tiled Backing Store https://bugs.webkit.org/show_bug.cgi?id=51529 Tiled backing store in EFL was giving the following warnings that are gone now: - Static function defined but not used; - Comparison between signed and unsigned integer expressions; * ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_smart_calculate): * ewk/ewk_tiled_matrix.c: (_ewk_tile_matrix_slicer_setup): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Steve Block. TouchEvents does not support multi-touch on a page with multiple touch targets https://bugs.webkit.org/show_bug.cgi?id=51258 * fast/events/touch/multi-touch-grouped-targets-expected.txt: Added. * fast/events/touch/multi-touch-grouped-targets.html: Added. * fast/events/touch/script-tests/multi-touch-grouped-targets.js: Added. (declareTouchHandler.return.shouldBe): (declareTouchHandler): (touchEndHandler): Added new test that ensures both test targets receive events when hit by multiple touch points from the same platform event. * fast/events/touch/script-tests/touch-target-limited.js: (declareTouchStart.return.touchStartHandler): (declareTouchStart): (declareTouchMove.return.touchMoveHandler): (declareTouchMove): * fast/events/touch/script-tests/touch-target.js: (declareTouchStart.return.touchStartHandler): (declareTouchStart): (declareTouchMove.return.touchMoveHandler): (declareTouchMove): * fast/events/touch/touch-target-expected.txt: * fast/events/touch/touch-target-limited-expected.txt: Updated & rebaselined existing tests to reflect new expectations. 2010-12-23 Jonathan Dixon <joth@chromium.org> Reviewed by Steve Block. TouchEvents does not support multi-touch on a page with multiple touch targets https://bugs.webkit.org/show_bug.cgi?id=51258 Test: fast/events/touch/multi-touch-grouped-targets.html * page/EventHandler.cpp: (WebCore::eventNameForTouchPointState): (WebCore::EventHandler::handleTouchEvent): Redesigned event handler to ensure all event targets involved in a given multitouch event get the appropriate event(s) fired. * platform/PlatformTouchPoint.h: Added end-stop marker for State enum. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround https://bugs.webkit.org/show_bug.cgi?id=51533 There's no point in concatenating env("HOME") with "blah", so remove option from EWebLauncher. * EWebLauncher/main.c: (main): ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Reviewed by Xan Lopez. [GTK] media/audio-data-url.html fails since r75504 https://bugs.webkit.org/show_bug.cgi?id=51525 Make the GStreamer media-player advertize 3gpp mime-types as supported if the 3gp caps are in the typefind factories. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jeremy@chromium.org authored
Unreviewed test expectations update. Fix duplicate expectation warning for media/video-controls-rendering.html introduced in r74535. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
to InputTypes. https://bugs.webkit.org/show_bug.cgi?id=51093 Reviewed by Dimitri Glazkov. Move BeforeTextInserted and Wheel event handling, event forwarding to renderers, and the isindex form submission quirk code to InputTypes. Also, change the return types of InputType event handlers from 'bool' to 'void'. We use Event::defaultHandled() to decide whether event handling should be stopped. No new tests because this is just a refactoring. * html/BaseButtonInputType.cpp: bool->void changes (WebCore::BaseButtonInputType::handleKeydownEvent): (WebCore::BaseButtonInputType::handleKeypressEvent): (WebCore::BaseButtonInputType::handleKeyupEvent): * html/BaseButtonInputType.h: ditto. * html/BaseCheckableInputType.cpp: ditto. (WebCore::BaseCheckableInputType::handleKeydownEvent): (WebCore::BaseCheckableInputType::handleKeypressEvent): * html/BaseCheckableInputType.h: ditto. * html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::handleKeydownEvent): ditto. (WebCore::BaseDateAndTimeInputType::handleWheelEvent): Just calls handleWheelEventForSpinButton(). * html/BaseDateAndTimeInputType.h: bool->void change and handleWhellEvent() addition. * html/CheckboxInputType.cpp: bool->void change (WebCore::CheckboxInputType::handleKeyupEvent): * html/CheckboxInputType.h: ditto. * html/FileInputType.cpp: ditto. (WebCore::FileInputType::handleDOMActivateEvent): * html/FileInputType.h: ditto. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): - Change return-value handling of InputType event handlers - Move out beforeTextInserted/wheel event handling and isindex form quirk. * html/HTMLInputElement.h: (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): Added so that InputType can call InputElement::handleBeforeTextInsertedEvent(). * html/ImageInputType.cpp: bool->void change (WebCore::ImageInputType::handleDOMActivateEvent): * html/ImageInputType.h: ditto. * html/InputType.cpp: ditto. (WebCore::InputType::handleClickEvent): (WebCore::InputType::handleDOMActivateEvent): (WebCore::InputType::handleKeydownEvent): (WebCore::InputType::handleKeypressEvent): (WebCore::InputType::handleKeyupEvent): (WebCore::InputType::handleBeforeTextInsertedEvent): (WebCore::InputType::handleWheelEvent): Added default implementation. (WebCore::InputType::forwardEvent): ditto. (WebCore::InputType::formForSubmission): ditto. * html/InputType.h: * html/IsIndexInputType.cpp: (WebCore::IsIndexInputType::formForSubmission): Moved from HTMLInputElement.cpp. * html/IsIndexInputType.h: * html/NumberInputType.cpp: (WebCore::isNumberCharacter): Moved from HTMLInputElement.cpp. (WebCore::NumberInputType::handleKeydownEvent): bool->void change. (WebCore::NumberInputType::handleBeforeTextInsertedEvent): Moved from HTMInputElement.cpp. (WebCore::NumberInputType::handleWheelEvent): Added. Just calls handleWheelEventForSpinButton(). * html/NumberInputType.h: * html/RadioInputType.cpp: bool->void changes. (WebCore::RadioInputType::handleClickEvent): (WebCore::RadioInputType::handleKeydownEvent): (WebCore::RadioInputType::handleKeyupEvent): * html/RadioInputType.h: * html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): ditto. (WebCore::RangeInputType::forwardEvent): Moved from HTMLInputElement.cpp. * html/RangeInputType.h: * html/ResetInputType.cpp: bool->void change. (WebCore::ResetInputType::handleDOMActivateEvent): * html/ResetInputType.h: ditto. * html/SubmitInputType.cpp: ditto. (WebCore::SubmitInputType::handleDOMActivateEvent): * html/SubmitInputType.h: ditto. * html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::handleKeydownEvent): bool->void change. (WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto. (WebCore::TextFieldInputType::handleWheelEventForSpinButton): Moved from HTMLInputElement.cpp. (WebCore::TextFieldInputType::forwardEvent): ditto. * html/TextFieldInputType.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Reviewed by Joseph Pecoraro. Web Inspector: After scrolling new property value and cancelling, removed property remains active in page style https://bugs.webkit.org/show_bug.cgi?id=51390 * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt/fast/dom/Window/window-properties-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. QT linux has RTL line movement bug that causes editing/selection/extend-to-line-boundary.html to fail https://bugs.webkit.org/show_bug.cgi?id=51514 Add different baseline to editing/selection/extend-to-line-boundary.html for qt-linux that takes into account the RTL bug. * platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
Another attempt. * http/tests/local/slow-css-pass.cgi: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
Reviewed by Eric Seidel. Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug). Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT. I just discovered that we have two additional GC runs per each WebViewHost. Test_shell had no such calls. These gc runs eat 15% of cpu time. https://bugs.webkit.org/show_bug.cgi?id=51479 * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::~WebViewHost): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
Flaky Test: http/tests/local/stylesheet-and-script-load-order-media-print.html Try to fix flakiness. * http/tests/local/slow-css-pass.cgi: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
Unreviewed build warning fix. [EFL] Remove warning messages during the webkit efl compiling https://bugs.webkit.org/show_bug.cgi?id=51520 Remove build warning messages. * ewk/ewk_view.cpp: (_ewk_view_smart_show): (_ewk_view_smart_hide): * ewk/ewk_view.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Adam Barth. [chromium] Reduce canvas.toDataURL("image/png") run-time costs 300% https://bugs.webkit.org/show_bug.cgi?id=51455 Chromium uses the libpng compression defaults. Good compression results, but at much larger run-time cost compared to other browsers. Chrome is 2 times slower than Mozilla 3.6.12 and 3-4 times slower than Safari 5.0.3. libpng has supported alternative compression methods for some time, they better meet the dual goals of good compression and run-time cost for the on-line case, and are well-documented. Here use Huffman encoding. It's 2-20% faster than other encodings (Z_RLE, Z_FILTERED) and the compressed size is within 1% of the Safari 5.0.3 result independent of image size. No change in behaviour, so no new tests. * platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::PNGImageEncoder::encode): Apply Huffman image encoding. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-