- 12 Jan, 2003 2 commits
-
-
darin authored
- fixed a bunch of places where KHTML did !x == y instead of !(x == y) or x != y. * khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule): * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): * khtml/misc/loader.cpp: (Cache::requestImage), (Cache::requestStyleSheet): * khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): Changed !x == y to x != y. In each case, there's a reason that this does not create any problem in practice, which is why we didn't rush to get this in for beta 1. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fixed 3144789 -- reproducible crash in KHTMLParser::freeBlock on a page at www.library.arizona.edu * khtml/html/htmlparser.cpp: (KHTMLParser::finished): Call freeBlock here rather than waiting until the parser is destroyed. This fixes the bug because when the parser is destroyed, the document is already destroyed, so we have a dangling current pointer to an already-destroyed node. - fixed 3142024 -- crash/hang/assert on java.sun.com in HTMLTokenizer The bug was caused by an erroneous clicked signal that was being emitted by QListBox at just the wrong time. * kwq/KWQListBox.h: Added _changingSelection boolean. * kwq/KWQListBox.mm: (QListBox::QListBox): Set _changingSelection to false. (QListBox::setSelected): Set _changingSelection to true. (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Only emit the "clicked" signal if _changingSelection is false. * khtml/html/htmltokenizer.h: Add debug-only boolean inWrite. * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer): Set inWrite to false. (HTMLTokenizer::write): Set inWrite to true. (HTMLTokenizer::~HTMLTokenizer): Assert that inWrite is not true. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 11 Jan, 2003 2 commits
-
-
darin authored
- fixed 3144479 -- put TITLE from links in status bar * WebKit.exp: Add _WebElementLinkTitleKey and also sort this file. * WebCoreSupport.subproj/WebImageRenderer.m: Need to touch a file to get the above to have any effect, so update the copyright date here. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fixed 3136944 -- mouseover feedback over non-mapped part of image map claims link to current page * kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Change code so we won't call completeURL and complete a null ATTR_HREF (which is distinct from an empty ATTR_HREF). Did a similar cleanup on the image code. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 10 Jan, 2003 1 commit
-
-
darin authored
* JavaScriptCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove CFHumanReadableCopyright, remove NSPrincipalClass. * English.lproj/InfoPlist.strings: Updated to match above changes. WebFoundation: * WebFoundation.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove NSHumanReadableCopyright, remove NSPrincipalClass. * English.lproj/InfoPlist.strings: Update to match above. WebCore: * WebCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove NSHumanReadableCopyright, remove NSPrincipalClass, remove SKIP_INSTALL that was in the Info plist instead of project settings. * English.lproj/InfoPlist.strings: Update to match above. WebKit: * WebKit.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile, bump marketing version to 0.8.1 and version to 52u to keep up with the branch, remove CFHumanReadableCopyright, remove NSPrincipalClass. * English.lproj/InfoPlist.strings: Updated to match above changes. WebBrowser: * WebBrowser.pbproj/project.pbxproj: Add 2003 to copyright, bump versions to 0.8.1 and 52u to keep up with the branch. * English.lproj/InfoPlist.strings: Update to match above. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 09 Jan, 2003 11 commits
-
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
Reviewed by Maciej. * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes. WebBrowser: Reviewed by Maciej. * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes. * English.lproj/Localizable.strings: Regenerate. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rjw authored
rendering optimizations. Don't bypass the tiling code path if the image needs to be rendered out-of-phase. Reviewed by hyatt. * WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer tileInRect:fromPoint:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- second pass on 3143332 - we still need a test case to be sure this is right * Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Check for "/". Also report the failure instead of just hanging on forever. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fixed 3143332 -- if path returned is empty string (or "." or "..") it will trash the /tmp symlink * Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Check for empty string, ".", and "..", and don't create files by those names. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
trey authored
3143294 - need short-term bulletproofing of download code against bad filenames We protect against a download location that is not an absolute path. Reviewed by Darin * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): Bail on download if we don't have a abs path to write to. WebBrowser: 3143294 - need short-term bulletproofing of download code against bad filenames We protect against slashes and leading periods, as well as handling empty filenames. Reviewed by Darin * BrowserWebController.m: (-[BrowserWebController saveFilenameForResponse:andRequest:]): Check results of [response filename] carefully git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs authored
- fixed Radar 3143013 - hang trying to load spiny.com/software * khtml/rendering/render_table.cpp: (RenderTable::layoutRows): Check for the render root as a loop termination condition, to avoid an infinite loop for an absolute but non-fixed table cell. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
not be applied when in strict mode. Fixes diveintomark.org's navigation bar on the front page (issue #2 on his list). Reviewed by darin and maciej * khtml/css/html4.css: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
cells encountered inside stray content cause the stray content to close so that the rows and cells can be part of the table. This fixes the versiontracker bug. #3142319. Reviewed by darin. * khtml/html/htmlparser.cpp: (KHTMLParser::reset): (isTableRelatedTag): (KHTMLParser::insertNode): (KHTMLParser::popOneBlock): * khtml/html/htmlparser.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
trey authored
We add checks for various error cases that could combine to cause this problem. While we never got a reproducible case, we are confident that this is the only file removal done in the download code, and its ability to wreak havoc has been clipped. Reviewed by Richard. * Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler cleanUpAfterFailure]): Only nuke the partial download if in fact we created a new download file. Never nuke a directory. (-[WebDownloadHandler createFileIfNecessary]): Don't add "." to the foo-1 filenames we generate if the original filename doesn't have any extension. * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): If the policyDelegate gives us a nil filename, just stop the whole load, instead of trying to overwrite the user's home directory. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
Fixing issue #3 on diveintomark.org's list, which actually involved merging calcAbsoluteVertical to KHTML's trunk and then fixing a math error in the bottom computation. Reviewed by NOBODY (OOPS!). * khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): * khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteVertical): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 08 Jan, 2003 6 commits
-
-
cblu authored
Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html Reviewed by dave. * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): call [_bridge frameRequiredForMIMEType:] to determine if we should create a plug-in view or iframe * kwq/WebCoreBridge.h: add frameRequiredForMIMEType: WebKit: Fixed: 3111432 - Support OBJECT tags with type text/plain or text/html Reviewed by dave. * WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameRequiredForMIMEType:]): added, returns YES for non-plug-in views git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
trey authored
We need to remove the entry from the KHTML image cache when a load has an error, so it will be reloaded next time we try. Reviewed by Darin, * khtml/misc/loader.cpp: (Loader::slotFinished): Remove cache entry on job error. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fixed 96/72 dpi snafu; no need to do something different for AppKit, because it always uses pixel sizes, not font size * khtml/css/css_valueimpl.cpp: * khtml/css/css_valueimpl.h: * khtml/css/cssstyleselector.cpp: * kwq/KWQPaintDeviceMetrics.mm: Rolled out change from 2002-12-05 - a cut at implementing heretofore unimplemented QTextStream classes * kwq/KWQTextStream.h: * kwq/KWQTextStream.mm: First cut implementation. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cblu authored
Reviewed by darin. * Plugins.subproj/WebBaseNetscapePluginView.m: Don't throttle plug-in when in an active window. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sheridan authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sheridan authored
Note that I am not using "Alexander" in the tag name any more (RIP Great Alex) and that I did not rev the marketing version. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 05 Jan, 2003 6 commits
-
-
mjs authored
Reviewed by no one cause I'm just changing copyright strings. * JavaScriptCore.pbproj/project.pbxproj: Added non-Apple copyrights to copyright strings. * English.lproj/InfoPlist.strings: Likewise. WebCore: Reviewed by no one cause I'm just changing copyright strings. * WebCore.pbproj/project.pbxproj: Added non-Apple copyrights to copyright strings. * English.lproj/InfoPlist.strings: Likewise. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
* JavaScriptCore.pbproj/project.pbxproj: Fix "Apple Compupter" typo. Remove unneeded CFBundleLongVersionString we don't use anywhere else. WebFoundation: * WebFoundation.pbproj/project.pbxproj: Fix "Apple Compupter" typo. WebCore: * Resources/Info.plist: Fix "Apple Compupter" typo. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 04 Jan, 2003 2 commits
-
-
trey authored
When processing an assignment to document.location, allow items to be added to history. This parallels the existing treatment of window.location.href. Reviewed by Richard, Darin * khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::putValue): Pass false for lockHistory arg of scheduleRedirection() git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rjw authored
was a logging printf. Back out that change. Reviewed by me. * khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 03 Jan, 2003 8 commits
-
-
rjw authored
Reviewed by gramps. * WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]): * WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rjw authored
with < 2 parameters. Reviewed by darin. * khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): * khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rjw authored
Fixed 3138743, 3138678, and 3138854. Removed the RenderText widths cache, replaced it with a much simply monospace character cache. Should be much faster for covered cases too! Also fixed buffer overrun problem causing the crash in 3138854. Reviewed by darin. * khtml/rendering/font.cpp: (Font::isFixedPitch): * khtml/rendering/font.h: * khtml/rendering/render_text.cpp: (TextSlave::checkSelectionPoint): (RenderText::RenderText): (RenderText::setStyle): (RenderText::~RenderText): (RenderText::shouldUseMonospaceCache): (RenderText::cacheWidths): (RenderText::widthFromCache): (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth): (RenderText::setText): (RenderText::width): * khtml/rendering/render_text.h: * kwq/KWQFont.h: * kwq/KWQFont.mm: (QFont::isFixedPitch): * kwq/WebCoreTextRendererFactory.h: * kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory isFontFixedPitch:]): WebKit: Support for fixes to 3138743, 3138678. Added isFontFixedPitch used to determine if font is fixed pitch. Makes use of appkit private _isFakeFixedPitch (detects courier and monoca). Updated our fakey test to use the appkit's version. Reviewed by darin. * WebCoreSupport.subproj/WebTextRenderer.m: * WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory isFontFixedPitch:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fixed leak of WebIconLoader observed using leaks tool * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Tell the icon loader to stop loading. Add a FIXME asking why we had to do this to fix the leak. (-[WebDataSource _loadIcon]): Add an assertion. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sullivan authored
Reviewed by Darin, OK'ed by Don. * khtml/xml/dom_docimpl.cpp: (DocumentImpl::setTitle): Check for nil view or nil part before dereferencing. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
look for a fixed height on the containing block. Reviewed by darin * khtml/rendering/render_table.cpp: (RenderTable::layoutRows): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rjw authored
on the page's scrollview. A layout would occur indirectly as a result of reflectScrolledClipView: being called when the document view was set. The khtmlpart/khtmlview/WebHTMLView would be out of sync at this point and a layout would have unintended and incorrect side effects. Reviewed by Darin (and tested by John). * WebView.subproj/WebDynamicScrollBarsView.h: * WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): * WebView.subproj/WebViewPrivate.m: (-[WebView _setDocumentView:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fixed 3138213 -- browser hangs trying to open Apple travel site * kjs/date_object.cpp: (timetUsingCF): Check for very-negative year numbers too. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 02 Jan, 2003 2 commits
-
-
kocienda authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kocienda authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-