1. 12 Jan, 2003 2 commits
    • darin's avatar
      Reviewed by Dave. · 50560aa1
      darin authored
      	- fixed a bunch of places where KHTML did !x == y instead of !(x == y) or x != y.
              * khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule):
              * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
              * khtml/misc/loader.cpp: (Cache::requestImage), (Cache::requestStyleSheet):
              * khtml/rendering/render_flow.cpp: (RenderFlow::setStyle):
      	Changed !x == y to x != y. In each case, there's a reason that this does not create
      	any problem in practice, which is why we didn't rush to get this in for beta 1.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by John. · 895eae19
      darin authored
      	- fixed 3144789 -- reproducible crash in KHTMLParser::freeBlock on a page at www.library.arizona.edu
              * khtml/html/htmlparser.cpp: (KHTMLParser::finished): Call freeBlock here rather than
      	waiting until the parser is destroyed. This fixes the bug because when the parser is
              destroyed, the document is already destroyed, so we have a dangling current pointer to an
      	already-destroyed node.
      	- fixed 3142024 -- crash/hang/assert on java.sun.com in HTMLTokenizer
      	The bug was caused by an erroneous clicked signal that was being emitted by
      	QListBox at just the wrong time.
              * kwq/KWQListBox.h: Added _changingSelection boolean.
              * kwq/KWQListBox.mm: (QListBox::QListBox): Set _changingSelection to false.
              (QListBox::setSelected): Set _changingSelection to true.
              (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Only emit the "clicked"
      	signal if _changingSelection is false.
              * khtml/html/htmltokenizer.h: Add debug-only boolean inWrite.
              * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer): Set inWrite to false.
      	(HTMLTokenizer::write): Set inWrite to true.
      	(HTMLTokenizer::~HTMLTokenizer): Assert that inWrite is not true.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. 11 Jan, 2003 2 commits
    • darin's avatar
      Reviewed by John. · ffe35f4f
      darin authored
      	- fixed 3144479 -- put TITLE from links in status bar
              * WebKit.exp: Add _WebElementLinkTitleKey and also sort this file.
              * WebCoreSupport.subproj/WebImageRenderer.m: Need to touch a file to get the above
      	to have any effect, so update the copyright date here.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Dave. · c935e41a
      darin authored
      	- fixed 3136944 -- mouseover feedback over non-mapped part of image map claims
      	link to current page
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
      	Change code so we won't call completeURL and complete a null ATTR_HREF (which is distinct
      	from an empty ATTR_HREF). Did a similar cleanup on the image code.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. 10 Jan, 2003 1 commit
    • darin's avatar
      JavaScriptCore: · 33188225
      darin authored
              * JavaScriptCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove CFHumanReadableCopyright, remove NSPrincipalClass.
              * English.lproj/InfoPlist.strings: Updated to match above changes.
              * WebFoundation.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove NSHumanReadableCopyright, remove NSPrincipalClass.
              * English.lproj/InfoPlist.strings: Update to match above.
              * WebCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove NSHumanReadableCopyright, remove NSPrincipalClass, remove SKIP_INSTALL
      	that was in the Info plist instead of project settings.
              * English.lproj/InfoPlist.strings: Update to match above.
              * WebKit.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove CFHumanReadableCopyright, remove NSPrincipalClass.
              * English.lproj/InfoPlist.strings: Updated to match above changes.
              * WebBrowser.pbproj/project.pbxproj: Add 2003 to copyright, bump versions
      	to 0.8.1 and 52u to keep up with the branch.
              * English.lproj/InfoPlist.strings: Update to match above.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. 09 Jan, 2003 11 commits
    • darin's avatar
      Lets call this 51u, not 50u. · adb2832b
      darin authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebKit: · 066636cc
      darin authored
              Reviewed by Maciej.
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
              Reviewed by Maciej.
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
              * English.lproj/Localizable.strings: Regenerate.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      Fixed 3143361. This was a regression introduced with some image · a48249a4
      rjw authored
              rendering optimizations.  Don't bypass the tiling code path if
              the image needs to be rendered out-of-phase.
              Reviewed by hyatt.
              * WebCoreSupport.subproj/WebImageRenderer.m:
              (-[WebImageRenderer tileInRect:fromPoint:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Chris. · 7b10f2ff
      darin authored
      	- second pass on 3143332 - we still need a test case to be sure this is right
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
      	Check for "/". Also report the failure instead of just hanging on forever.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Richard. · 88b01630
      darin authored
              - fixed 3143332 -- if path returned is empty string (or "." or "..") it will trash the /tmp symlink
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
              Check for empty string, ".", and "..", and don't create files by those names.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • trey's avatar
      WebKit: · 38b5508b
      trey authored
      	3143294 - need short-term bulletproofing of download code against bad filenames
      	We protect against a download location that is not an absolute path.
              Reviewed by Darin
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient continueAfterContentPolicy:response:]):
      	Bail on download if we don't have a abs path to write to.
      	3143294 - need short-term bulletproofing of download code against bad filenames
      	We protect against slashes and leading periods, as well as handling empty filenames.
              Reviewed by Darin
              * BrowserWebController.m:
              (-[BrowserWebController saveFilenameForResponse:andRequest:]):
      	Check results of [response filename] carefully
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      Reviewed by Dave. · 3de55bfc
      mjs authored
      	- fixed Radar 3143013 - hang trying to load spiny.com/software
              * khtml/rendering/render_table.cpp:
              (RenderTable::layoutRows): Check for the render root as a loop
      	termination condition, to avoid an infinite loop for an absolute
      	but non-fixed table cell.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      The "flow-mode" quirk for lists is just that - a quirk, and should · f5cec5e3
      hyatt authored
      	not be applied when in strict mode.
      	Fixes diveintomark.org's navigation bar on the front page (issue #2
      	on his list).
              Reviewed by darin and maciej
              * khtml/css/html4.css:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Finish the KONQBLOCK removal and make sure that table rows and · 6d17fb2b
      hyatt authored
      	cells encountered inside stray content cause the stray content to
      	close so that the rows and cells can be part of the table.
      	This fixes the versiontracker bug.  #3142319.
              Reviewed by darin.
              * khtml/html/htmlparser.cpp:
              * khtml/html/htmlparser.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • trey's avatar
      3142201 - home directory nuked during power download session · 66177e0b
      trey authored
      	We add checks for various error cases that could combine to cause this problem.  While we
      	never got a reproducible case, we are confident that this is the only file removal done
      	in the download code, and its ability to wreak havoc has been clipped.
              Reviewed by Richard.
              * Downloads.subproj/WebDownloadHandler.m:
              (-[WebDownloadHandler cleanUpAfterFailure]):  Only nuke the partial download if in fact we created
      	a new download file.  Never nuke a directory.
              (-[WebDownloadHandler createFileIfNecessary]):  Don't add "." to the foo-1 filenames we generate
      	if the original filename doesn't have any extension.
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient continueAfterContentPolicy:response:]):
      	If the policyDelegate gives us a nil filename, just stop the whole load, instead of trying to
      	overwrite the user's home directory.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Revert the redundancy that dirk noticed. · 5066da21
      hyatt authored
      	Fixing issue #3 on diveintomark.org's list, which actually involved
      	merging calcAbsoluteVertical to KHTML's trunk and then fixing
      	a math error in the bottom computation.
              Reviewed by NOBODY (OOPS!).
              * khtml/html/html_baseimpl.cpp:
              * khtml/rendering/render_box.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. 08 Jan, 2003 6 commits
  6. 05 Jan, 2003 6 commits
  7. 04 Jan, 2003 2 commits
  8. 03 Jan, 2003 8 commits
    • rjw's avatar
      Fixed 3139129. Added application/xhtml+xml to list of supported type. · aa9061c7
      rjw authored
              Reviewed by gramps.
              * WebView.subproj/WebDataSourcePrivate.m:
              (+[WebDataSource _repTypes]):
              * WebView.subproj/WebViewPrivate.m:
              (+[WebView _viewTypes]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      Fix for 3138425. Don't open a new window when document.open() is called · 5f65a093
      rjw authored
              with < 2 parameters.
              Reviewed by darin.
              * khtml/ecma/kjs_html.cpp:
              * khtml/ecma/kjs_window.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      WebCore: · b026936c
      rjw authored
              Fixed 3138743, 3138678, and 3138854.  Removed the RenderText
              widths cache, replaced it with a much simply monospace character
              cache.  Should be much faster for covered cases too!  Also fixed
              buffer overrun problem causing the crash in 3138854.
              Reviewed by darin.
              * khtml/rendering/font.cpp:
              * khtml/rendering/font.h:
              * khtml/rendering/render_text.cpp:
              * khtml/rendering/render_text.h:
              * kwq/KWQFont.h:
              * kwq/KWQFont.mm:
              * kwq/WebCoreTextRendererFactory.h:
              * kwq/WebCoreTextRendererFactory.m:
              (-[WebCoreTextRendererFactory isFontFixedPitch:]):
              Support for fixes to 3138743, 3138678.  Added
              isFontFixedPitch used to determine if font is fixed
              pitch.  Makes use of appkit private _isFakeFixedPitch
              (detects courier and monoca).  Updated our fakey test
              to use the appkit's version.
              Reviewed by darin.
              * WebCoreSupport.subproj/WebTextRenderer.m:
              * WebCoreSupport.subproj/WebTextRendererFactory.m:
              (-[WebTextRendererFactory isFontFixedPitch:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Chris. · 4d497e95
      darin authored
      	- fixed leak of WebIconLoader observed using leaks tool
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSourcePrivate dealloc]): Tell the icon loader to stop loading.
      	Add a FIXME asking why we had to do this to fix the leak.
              (-[WebDataSource _loadIcon]): Add an assertion.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sullivan's avatar
      - fixed 3138673 -- reproducible crash in JavaScript · 70d94889
      sullivan authored
              Reviewed by Darin, OK'ed by Don.
              * khtml/xml/dom_docimpl.cpp:
      	Check for nil view or nil part before dereferencing.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for percentage table heights. A check was missing to · 7c6e5520
      hyatt authored
      	look for a fixed height on the containing block.
              Reviewed by darin
              * khtml/rendering/render_table.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      Fix to 3131226. Don't force a layout when the document view is set · 595f51b4
      rjw authored
              on the page's scrollview.  A layout would occur indirectly as a result
              of reflectScrolledClipView: being called when the document view
              was set.  The khtmlpart/khtmlview/WebHTMLView would be out of sync
              at this point and a layout would have unintended and incorrect
              side effects.
              Reviewed by Darin (and tested by John).
              * WebView.subproj/WebDynamicScrollBarsView.h:
              * WebView.subproj/WebDynamicScrollBarsView.m:
              (-[WebDynamicScrollBarsView updateScrollers]):
              * WebView.subproj/WebViewPrivate.m:
              (-[WebView _setDocumentView:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Maciej. · 94e6d75e
      darin authored
      	- fixed 3138213 -- browser hangs trying to open Apple travel site
              * kjs/date_object.cpp: (timetUsingCF): Check for very-negative year numbers too.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  9. 02 Jan, 2003 2 commits