- 30 Aug, 2012 40 commits
-
-
ggaren@apple.com authored
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
wangxianzhu@chromium.org authored
[Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests https://bugs.webkit.org/show_bug.cgi?id=95400 Reviewed by Dirk Pranke. WebGL is not enabled and should be skipped on Android (http://crbug.com/135877). * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.skipped_layout_tests): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=95501 Reviewed by Filip Pizlo. ../JavaScriptCore: This patch removes ScopeChainNode, and moves all the data and related functions that used to be in ScopeChainNode into JSScope. Most of this patch is mechanical changes to use a JSScope* where we used to use a ScopeChainNode*. I've only specifically commented about items that were non-mechanical. * runtime/Completion.cpp: (JSC::evaluate): * runtime/Completion.h: Don't require an explicit scope chain argument when evaluating code. Clients never wanted anything other than the global scope, and other arbitrary scopes probably wouldn't work correctly, anyway. * runtime/JSScope.cpp: * runtime/JSScope.h: (JSC::JSScope::JSScope): JSScope now requires the data we used to pass to ScopeChainNode, so it can link itself into the scope chain correctly. * runtime/JSWithScope.h: (JSC::JSWithScope::create): (JSC::JSWithScope::JSWithScope): JSWithScope gets an extra constructor for specifically supplying your own scope chain. The DOM needs this interface for setting up the scope chain for certain event handlers. Other clients always just push the JSWithScope to the head of the current scope chain. ../WebCore: Mechanical changes to update for JSC interface changes. ../WebKit/mac: Mechanical change to update for JSC interface change. ../WebKit/qt: Mechanical change to update for JSC interface change. * Api/qwebelement.cpp: (QWebElement::evaluateJavaScript): ../WebKit2: Mechanical changes to update for JSC interface change. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=95499 Unreviewed. One more fix to avoid trying to run the empty string. * Scripts/webkitdirs.pm: (buildAutotoolsProject): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pdr@google.com authored
fast/css/font-weight-1.html stopped failing for IMAGE+TEXT and started failing for just IMAGE. * platform/chromium/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=95482. Patch by Mark Lam <mark.lam@apple.com> on 2012-08-30 Reviewed by Filip Pizlo. Source/JavaScriptCore: Refining / disambiguating between #ifdefs and adding some. For example, ENABLE(JIT) is conflated with ENABLE(LLINT) in some places. Also, we need to add ENABLE(COMPUTED_GOTO_OPCODES) to indicate that we want interpreted opcodes to use COMPUTED GOTOs apart from ENABLE(LLINT) and ENABLE(COMPUTED_GOTO_CLASSIC_INTERPRETER). Also cleaned up #ifdefs in certain places which were previously incorrect. * bytecode/CodeBlock.cpp: (JSC): (JSC::CodeBlock::bytecodeOffset): * bytecode/CodeBlock.h: (CodeBlock): * bytecode/Opcode.h: (JSC::padOpcodeName): * config.h: * dfg/DFGOperations.cpp: * interpreter/AbstractPC.cpp: (JSC::AbstractPC::AbstractPC): * interpreter/CallFrame.h: (ExecState): * interpreter/Interpreter.cpp: (JSC::Interpreter::~Interpreter): (JSC::Interpreter::initialize): (JSC::Interpreter::isOpcode): (JSC::Interpreter::unwindCallFrame): (JSC::getLineNumberForCallFrame): (JSC::getCallerInfo): (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::privateExecute): * interpreter/Interpreter.h: (JSC::Interpreter::getOpcode): (JSC::Interpreter::getOpcodeID): (Interpreter): * jit/HostCallReturnValue.h: * jit/JITCode.h: (JITCode): * jit/JITExceptions.cpp: * jit/JITExceptions.h: * jit/JSInterfaceJIT.h: * llint/LLIntData.h: (JSC::LLInt::getOpcode): * llint/LLIntEntrypoints.cpp: (JSC::LLInt::getFunctionEntrypoint): (JSC::LLInt::getEvalEntrypoint): (JSC::LLInt::getProgramEntrypoint): * llint/LLIntOffsetsExtractor.cpp: (JSC::LLIntOffsetsExtractor::dummy): * llint/LLIntSlowPaths.cpp: (LLInt): * runtime/JSGlobalData.cpp: (JSC): Source/WTF: * wtf/Platform.h: Added ENABLE(COMPUTED_GOTO_OPCODES). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
http://trac.webkit.org/changeset/127171 https://bugs.webkit.org/show_bug.cgi?id=95505 testRunner does not need dumpWebNotificationCallbacks(). (Requested by jonlee on #webkit). Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-30 Source/WebKit/mac: * WebKit.exp: Tools: * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner): (TestRunner::staticFunctions): * DumpRenderTree/TestRunner.h: (TestRunner): * DumpRenderTree/mac/MockWebNotificationProvider.mm: (-[MockWebNotificationProvider webView:didShowNotification:]): (-[MockWebNotificationProvider webView:didClickNotification:]): (-[MockWebNotificationProvider webView:didCloseNotifications:]): * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=95483 Unreviewed gardening. It was removed by mistake on r127152. But now I'm moving the tests to TestExpectations since we want to get rid of Skipped. Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-30 * platform/efl/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tony@chromium.org authored
* platform/chromium/TestExpectations: Mark the test as flaky (passes on Linux and sporadically on Win). * platform/efl/TestExpectations: Remove since the test is passing. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=91214 Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-08-30 Reviewed by Kenneth Rohde Christiansen. .: Set WebMemorySampler feature on in EFL port. * Source/cmake/OptionsEfl.cmake: * Source/cmake/WebKitFeatures.cmake: * Source/cmakeconfig.h.cmake: Source/JavaScriptCore: WebMemorySampler collects Javascript stack and JIT memory usage in globalMemoryStatistics. * PlatformEfl.cmake: Source/WebKit2: Add WebMemorySampler feature to EFL port. WebMemorySampler records memory usage of WebProcess and UI Process and also it records application memory status in real time. Included items on the result are JIT, JS heap, fastmalloc bytes and application memory info from /proc/process_id/statm. * PlatformEfl.cmake: * Shared/linux/WebMemorySamplerLinux.cpp: Added. (WebKit): (ApplicationMemoryStats): (WebKit::nextToken): (WebKit::appendKeyValuePair): (WebKit::sampleMemoryAllocatedForApplication): (WebKit::WebMemorySampler::processName): (WebKit::WebMemorySampler::sampleWebKit): (WebKit::WebMemorySampler::sendMemoryPressureEvent): * UIProcess/API/efl/ewk_context.cpp: (_Ewk_Context::_Ewk_Context): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
* Platform.gypi: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
psolanki@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=95242 Reviewed by Benjamin Poulain. Source/WebCore: Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts to a function pointer with right types when calling objc_msgSend and an IMP method directly. No new tests because no functional changes. * page/mac/EventHandlerMac.mm: (WebCore::selfRetainingNSScrollViewScrollWheel): * platform/mac/WebCoreObjCExtras.mm: (deallocCallback): Source/WebKit/mac: Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts to a function pointer with right types when calling objc_msgSend and an IMP method directly. * WebCoreSupport/WebCachedFramePlatformData.h: (WebCachedFramePlatformData::clear): * WebCoreSupport/WebDeviceOrientationClient.mm: (WebDeviceOrientationClient::getProvider): * WebView/WebDelegateImplementationCaching.mm: (CallDelegate): (CallDelegateReturningBoolean): (CallResourceLoadDelegateReturningBoolean): (CallFormDelegate): (CallFormDelegateReturningBoolean): * WebView/WebHTMLView.mm: (setCursor): (setNeedsDisplayInRect): Source/WebKit2: Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts to a function pointer with right types when calling objc_msgSend and an IMP method directly. * UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewScrollView_scrollWheel): Source/WTF: Add new templates wtfObjcMsgSend and wtfCallIMP that do the appropriate casts to correctly typed function pointers before calling objc_msgSend and IMP methods directly. * wtf/Functional.h: (WTF::R): Use wtfObjcMsgSend. * wtf/ObjcRuntimeExtras.h: Added. (wtfObjcMsgSend): (wtfCallIMP): Tools: Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts to a function pointer with right types when calling objc_msgSend and an IMP method directly. * DumpRenderTree/mac/DumpRenderTree.mm: (drt_NSFontManager_availableFontFamilies): * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::wtr_NSFontManager_availableFontFamilies): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=80394 Mark fast/block/float/024.hml as an expected text failure on Mac, not both an image and text failure, since the bots are only seeing it as a text failure. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benjamin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=95271 Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-30 Reviewed by Geoffrey Garen. Source/JavaScriptCore: Having JSC::UString and WTF::String increase the complexity of working on WebKit, and add useless conversions in the bindings. It also cause some code bloat. The performance advantages of UString have been ported over in previous patches. This patch is the last step: getting rid of UString. In addition to the simplified code, this also reduce the binary size by 15kb on x86_64. * API/OpaqueJSString.cpp: (OpaqueJSString::ustring): * runtime/Identifier.h: (JSC::Identifier::ustring): To avoid changing everything at once, the function named ustring() were kept as is. They will be renamed in a follow up patch. * runtime/JSString.h: (JSC::JSString::string): (JSC::JSValue::toWTFString): (JSC::inlineJSValueNotStringtoString): (JSC::JSValue::toWTFStringInline): Since JSValue::toString() already exist (and return the JSString), the direct accessor is renamed to ::toWTFString(). We may change ::string() to ::jsString() and ::toWTFString() to ::toString() in the future. * runtime/StringPrototype.cpp: (JSC::substituteBackreferencesSlow): Replace the use of UString::getCharacters<>() by String::getCharactersWithUpconvert<>(). Source/WebCore: Update the code to use String instead of UString. On x86_64, this reduces the binary size by 22kb. Since it is no longer possible to differenciate JSC::jsString() and WebCore::jsString() by the input types, WebCore::jsString() is renated to WebCore::jsStringWithCache(). Since the cache is using a PtrHash, JSC::jsString() is used in place of the old WebCore::jsString() when the string is generated locally. This is because the cache can never match in those cases. Source/WebKit/blackberry: Replace UString by String. * WebCoreSupport/ClientExtension.cpp: * WebCoreSupport/PagePopupBlackBerry.cpp: (WebCore::PagePopupBlackBerry::installDomFunction): Source/WebKit/efl: Replace UString by String. * WebCoreSupport/DumpRenderTreeSupportEfl.cpp: (DumpRenderTreeSupportEfl::sendWebIntentResponse): * ewk/ewk_frame.cpp: (ewk_frame_script_execute): Source/WebKit/gtk: Replace UString by String. * gdom/ConvertToGCharPrivate.h: (copyAsGchar): Source/WebKit/mac: Get rid of UString, replace it by String, and simplify the code when possible. On x86_64, this reduces the binary size by 7kb. * Plugins/Hosted/NetscapePluginHostProxy.mm: (identifierFromIdentifierRep): * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState): * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyRuntimeMethod::create): (WebKit::ProxyRuntimeMethod::finishCreation): (WebKit::ProxyInstance::getPropertyNames): (WebKit::ProxyInstance::methodsNamed): (WebKit::ProxyInstance::fieldNamed): * WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame functionName]): (-[WebScriptCallFrame evaluateWebScript:]): * WebView/WebScriptDebugger.h: (WTF): (JSC): (WebScriptDebugger): * WebView/WebScriptDebugger.mm: (toNSURL): (WebScriptDebugger::sourceParsed): * WebView/WebView.mm: (aeDescFromJSValue): Source/WebKit/qt: Replace UString by String. * Api/qwebelement.cpp: (QWebElement::evaluateJavaScript): Source/WebKit/win: Replace UString by String. * WebFrame.cpp: (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): * WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString): Source/WebKit/wx: Update the #includes to use the correct types. * WebFrame.cpp: * WebView.cpp: Source/WebKit2: Update to code to switch from UString to String. * WebProcess/Plugins/Netscape/JSNPMethod.cpp: (WebKit::JSNPMethod::finishCreation): * WebProcess/Plugins/Netscape/JSNPMethod.h: (WebKit::JSNPMethod::create): (JSNPMethod): * WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::npIdentifierFromIdentifier): * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::evaluate): (WebKit::NPRuntimeObjectMap::moveGlobalExceptionToExecState): Source/WTF: * wtf/Platform.h: Useless edit to force a full build. This is needed for some bots for some reason. * wtf/text/WTFString.h: Export a symbol that was exported on UString and needed in WebCore. Add String::getCharactersWithUpconvert<>(), which is similar to String::getCharacters<>() but with the same behaviors as UString::getCharacters<>(). String::getCharactersWithUpconvert<>() is useful when manipulating multiple strings, it allow writting code using 16bits characters if any of the input String is not 8bit. Tools: Get rid of UString. * DumpRenderTree/efl/WorkQueueItemEfl.cpp: * gdb/webkit.py: (WTFStringPrinter.to_string): (JSCIdentifierPrinter.to_string): (JSCJSStringPrinter.to_string): (add_pretty_printers): Websites/webkit.org: Update the coding style to avoid mentioning a class that no longer exist. * coding/coding-style.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=95495 Reviewed by Ojan Vafai. This is a follow-on to bug 95370 that adds in support for platform/wk2/TestExpectations and platform/{mac,win}-$version/TestExpectations. * Scripts/webkitpy/layout_tests/port/apple.py: (ApplePort.expectations_files): * Scripts/webkitpy/layout_tests/port/base.py: (Port._skipped_file_search_paths): * Scripts/webkitpy/layout_tests/port/mac_unittest.py: (MacTest.test_expectations_files): * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: (MockDRTPortTest.make_port): * Scripts/webkitpy/layout_tests/port/win_unittest.py: (WinPortTest.test_expectations_files): LayoutTests: Remove uses of ClassInfo in StrictEq and CompareEq in the DFG https://bugs.webkit.org/show_bug.cgi?id=93401 Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2012-08-24 Reviewed by Filip Pizlo. New test to make sure the DFG watchpoint works correctly for these cases. * fast/js/document-all-triggers-masquerades-watchpoint-expected.txt: Added. * fast/js/document-all-triggers-masquerades-watchpoint.html: Added. * fast/js/script-tests/document-all-triggers-masquerades-watchpoint.js: Added. (f): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=93401 Reviewed by Filip Pizlo. Source/JavaScriptCore: Another incremental step in removing the dependence on ClassInfo pointers in object headers. * bytecode/SpeculatedType.h: (JSC::isCellOrOtherSpeculation): (JSC): * dfg/DFGAbstractState.cpp: Updated the CFA to reflect the changes to the backend. (JSC::DFG::AbstractState::execute): * dfg/DFGNode.h: (Node): (JSC::DFG::Node::shouldSpeculateString): Added this new function since it was conspicuously absent. (JSC::DFG::Node::shouldSpeculateNonStringCellOrOther): Also add this function for use in the CFA. * dfg/DFGSpeculativeJIT.cpp: Refactored how we handle CompareEq and CompareStrictEq in the DFG. We now just check for Strings by comparing the object's Structure to the global Structure for strings. We only check for MasqueradesAsUndefined if the watchpoint has fired. These changes allow us to remove our uses of the ClassInfo pointer for compiling these nodes. (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality): (JSC::DFG::SpeculativeJIT::compilePeepHoleBranch): (JSC::DFG::SpeculativeJIT::compare): (JSC::DFG::SpeculativeJIT::compileStrictEq): * dfg/DFGSpeculativeJIT.h: (SpeculativeJIT): * dfg/DFGSpeculativeJIT32_64.cpp: Same changes for 32 bit as for 64 bit. (JSC::DFG::SpeculativeJIT::compileObjectEquality): (JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality): (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compileObjectEquality): (JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality): (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality): LayoutTests: New test to make sure the DFG watchpoint works correctly for these cases. * fast/js/document-all-triggers-masquerades-watchpoint-expected.txt: Added. * fast/js/document-all-triggers-masquerades-watchpoint.html: Added. * fast/js/script-tests/document-all-triggers-masquerades-watchpoint.js: Added. (f): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pdr@google.com authored
These tests need an image rebaseline for win to match the linux results. * platform/chromium-win-xp/fast/block/margin-collapse: Removed. * platform/chromium-win/fast/block/float/024-expected.png: * platform/chromium-win/fast/block/margin-collapse/empty-clear-blocks-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
Unreviewed, build fix. This adds empty placeholder files so new-run-webkit-tests doesn't get upset if they're missing. * platform/mac-wk2/TestExpectations: Added. * platform/win-wk2/TestExpectations: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yoli@rim.com authored
https://bugs.webkit.org/show_bug.cgi?id=94810 Reviewed by Benjamin Poulain. Only tested on BlackBerry. So it is wrapped with PLATFORM(BLACKBERRY) in the mean time. Use realloc to shrink buffer when inline buffer isn't involved and and canMoveWithMemcpy is true. When running the test code attached to the bug, it gives 30-45% performance boost for the large blocks (Every test cycle includes an extra pair of malloc/free, so the boost on shrinkToFit() is even bigger) Performance impact on small blocks is not noticeable. (Tested on BlackBerry) * wtf/Vector.h: (WTF::VectorBufferBase::shouldReallocateBuffer): (VectorBufferBase): (WTF::VectorBufferBase::reallocateBuffer): (VectorBuffer): (WTF::VectorBuffer::shouldReallocateBuffer): (WTF::VectorBuffer::reallocateBuffer): (WTF::VectorBuffer::inlineBuffer): (WTF::::shrinkCapacity): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yoli@rim.com authored
https://bugs.webkit.org/show_bug.cgi?id=95469 Reviewed by Rob Buis. RIM PR# 200595. Share most code with USE(CF) and implement timer-related methods for PLATFORM(BLACKBERRY). * heap/IncrementalSweeper.cpp: (JSC): (JSC::IncrementalSweeper::IncrementalSweeper): (JSC::IncrementalSweeper::create): (JSC::IncrementalSweeper::scheduleTimer): (JSC::IncrementalSweeper::cancelTimer): (JSC::IncrementalSweeper::doSweep): * heap/IncrementalSweeper.h: (IncrementalSweeper): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=95366 Remove the failing test expectations in platform/mac, since this is showing up as passing on all the mac bots. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zhajiang@rim.com authored
https://bugs.webkit.org/show_bug.cgi?id=95492 Reviewed by Yong Li. Patch by Jacky Jiang <zhajiang@rim.com> PR: 200724 Hold the JSLock for the current thread before we call toRef to avoid the ASSERT failure. * Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::executeJavaScript): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pdr@google.com authored
These tests just needed platform-specific results. * platform/chromium-mac-snowleopard/fast/dom/shadow/shadowdom-for-textarea-complex-shadow-expected.png: Added. * platform/chromium-mac/fast/dom/shadow: Added. * platform/chromium-mac/fast/dom/shadow/shadowdom-for-textarea-complex-shadow-expected.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=95387 Reviewed by Ojan Vafai. Check to make sure that Executive.run_in_parallel() requires a non-empty list of commands to execute; passing an empty list seems surely like a programming error. * Scripts/webkitpy/common/system/executive.py: (Executive.run_in_parallel): * Scripts/webkitpy/common/system/executive_unittest.py: (ExecutiveTest.test_run_in_parallel_assert_nonempty): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=94746 Reviewed by Ojan Vafai. Add an assertion to diff_image() to check that we are passing tolerance=0 explicitly when diffing ref test results. * Scripts/webkitpy/layout_tests/port/test.py: (TestPort.diff_image): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=95484. Patch by Mark Lam <mark.lam@apple.com> on 2012-08-30 Reviewed by Filip Pizlo. * interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rwlbuis@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=95377 Reviewed by Antonio Gomes. .: Change WEBKIT_SET_EXTRA_COMPILER_FLAGS so it has an option to suppress C++ warnings. * Source/cmake/WebKitHelpers.cmake: Source/WebCore: Compile ANGLE sources in a static library, and make sure the compile flags suppress warnings. * CMakeLists.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pdr@google.com authored
These tests are awaiting a rebaseline after r127168 but have the wrong modifiers on them. They are failing for Image but have Image+Text. Updating to fix that. * platform/chromium/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
victor@rosedu.org authored
https://bugs.webkit.org/show_bug.cgi?id=89167 Reviewed by Eric Carlson. Source/WebCore: Fix for rendering tracks when snap-to-lines not set. No new tests. Removed from TestExpectations existing test. * html/track/TextTrackCue.cpp: (WebCore::TextTrackCue::TextTrackCue): (WebCore::TextTrackCue::calculateDisplayParameters): Updated the place where m_computedLinePosition is determined. LayoutTests: Removed possible flaky test from TestExceptations. * platform/chromium/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=95401 Reviewed by Dirk Pranke. If use_libcc_for_compositor is set, these tests are being compiled and run elsewhere. * WebKit.gyp: * WebKit.gypi: * WebKitUnitTests.gyp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=95370 Reviewed by Ojan Vafai. Adds support for mac-wk2 and win-wk2 to expectations_files() for the apple mac and apple win ports. * Scripts/webkitpy/layout_tests/port/apple.py: (ApplePort.expectations_files): * Scripts/webkitpy/layout_tests/port/mac_unittest.py: (MacTest.test_expectations_files): * Scripts/webkitpy/layout_tests/port/win_unittest.py: (WinTest.test_expectations_files): * Scripts/webkitpy/layout_tests/port/port_testcase.py: (PortTestCase.test_expectations_files): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
achicu@adobe.com authored
[CSS Shaders] Update css3/filters/custom/effect-custom-transform-parameters.html to remove anti-aliasing issues https://bugs.webkit.org/show_bug.cgi?id=95407 Reviewed by Dean Jackson. The initial test had a white border to prevent anti-aliasing effects, but that doesn't seem to help on some platforms. Removed the border in this patch. * css3/filters/custom/effect-custom-transform-parameters-expected.html: * css3/filters/custom/effect-custom-transform-parameters.html: * platform/mac-lion/TestExpectations: Un-skipping the test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=95040 Reviewed by Darin Fisher. Source/Platform: Adds a WebCompositorSupport interface as a tear-off of PlatformSupport so the embedder can handle provide implementations of compositor interfaces. Adds a new WebPassOwnPtr<> type for use when the caller of an API must take ownership of the provided parameter. * Platform.gypi: * chromium/public/Platform.h: (WebKit): (WebKit::Platform::compositorSupport): (Platform): * chromium/public/WebCompositorSupport.h: Added. (WebKit): (WebCompositorSupport): (WebKit::WebCompositorSupport::~WebCompositorSupport): Source/WebCore: Uses WebCompositorSupport interfaces where appropriate to construct compositor types. * platform/graphics/chromium/AnimationTranslationUtil.cpp: (WebCore::createWebAnimation): * platform/graphics/chromium/Canvas2DLayerBridge.cpp: (WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge): * platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBufferPrivate::DrawingBufferPrivate): * platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::setContentsTo): (WebCore::GraphicsLayerChromium::addAnimation): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): Source/WebKit/chromium: * src/LinkHighlight.cpp: (WebKit::LinkHighlight::LinkHighlight): (WebKit::LinkHighlight::startHighlightAnimation): * src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::readyStateChanged): * src/WebMediaPlayerClientImpl.h: (WebKit): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setBackingTextureId): (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): * src/WebPluginContainerImpl.h: (WebKit): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jonlee@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=95232 <rdar://problem/12190776> Reviewed by Alexey Proskuryakov. Source/WebKit/mac: * WebKit.exp: Export WebNotification class. Tools: Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called. * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner): (dumpWebNotificationCallbacksCallback): (TestRunner::staticFunctions): * DumpRenderTree/TestRunner.h: (TestRunner): (TestRunner::dumpWebNotificationCallbacks): (TestRunner::setDumpWebNotificationCallbacks): * DumpRenderTree/mac/MockWebNotificationProvider.mm: (-[WebNotification _drt_descriptionSuitableForTestResult]): (-[MockWebNotificationProvider webView:didShowNotification:]): (-[MockWebNotificationProvider webView:didClickNotification:]): (-[MockWebNotificationProvider webView:didCloseNotifications:]): * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=95470 Reviewed by Darin Adler. * WebCore.gypi: Added BitmapImageCG.cpp. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * platform/graphics/cg/BitmapImageCG.cpp: Copied from Source/WebCore/platform/graphics/cg/ImageCG.cpp then deleted Image function implementations. * platform/graphics/cg/ImageCG.cpp: Deleted BitmapImage and FrameData function implementations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pdr@google.com authored
The Mac 10.6 results are slightly different--decoding about 10% less of the image. After some discussion with Adam Barth we determined to rebaseline these. * platform/chromium-mac-snowleopard/http/tests/images: Added. * platform/chromium-mac-snowleopard/http/tests/images/webp-partial-load-expected.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
victor@rosedu.org authored
https://bugs.webkit.org/show_bug.cgi?id=95395 Reviewed by Eric Carlson. Source/WebCore: The actual Chromium resource for the CC button was not used by the Chromium theme. Existing track rendering tests will be rebaselined and contain the new CC button. * rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaClosedCaptionsButton): Added for proper painting of the resource. (WebCore): (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Changed to call paintMediaClosedCaptionsButton when the control is the CC button. * rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintMediaToggleClosedCaptionsButton): Implemented proper behaviour. (WebCore): * rendering/RenderThemeChromiumSkia.h: (RenderThemeChromiumSkia): LayoutTests: No new tests, the existing ones will need to be rebaselined and include the CC button. * platform/chromium/TestExpectations: Marked tests failing accordingly for rebaselining. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=95418 Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-08-30 Reviewed by Filip Pizlo. There is a build warning '-Wsign-compare' on findArgumentPositionForLocal() in DFGByteCodeParser.cpp. For removing this warning, casting statement is added explicitly. * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::findArgumentPositionForLocal): (JSC::DFG::ByteCodeParser::findArgumentPosition): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
http/tests/security/MessagePort/event-listener-context.html, usually attributed to later tests. https://bugs.webkit.org/show_bug.cgi?id=94458 fast/events/message-port-constructor-for-deleted-document.html also asserts in MessagePort::contextDestroyed, and it is usually attributed to later tests as well. Skip it. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tommyw@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=95198 Reviewed by Adam Barth. Source/Platform: Adds WebMediaConstraints. * Platform.gypi: * chromium/public/WebMediaConstraints.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h. (WebCore): (WebKit): (WebMediaConstraints): (WebKit::WebMediaConstraints::WebMediaConstraints): (WebKit::WebMediaConstraints::~WebMediaConstraints): (WebKit::WebMediaConstraints::operator=): * chromium/public/WebRTCPeerConnectionHandler.h: (WebKit): (WebRTCPeerConnectionHandler): Source/WebCore: This introduces MediaConstraints together with relevant infrastructure, a chromium mock and LayoutTests. Patch covered by expanded existing tests. * CMakeLists.txt: * GNUmakefile.list.am: * Modules/mediastream/MediaConstraintsImpl.cpp: Added. (WebCore): (WebCore::MediaConstraintsImpl::create): (WebCore::MediaConstraintsImpl::initialize): (WebCore::MediaConstraintsImpl::~MediaConstraintsImpl): (WebCore::MediaConstraintsImpl::getMandatoryConstraintNames): (WebCore::MediaConstraintsImpl::getOptionalConstraintNames): (WebCore::MediaConstraintsImpl::getMandatoryConstraintValue): (WebCore::MediaConstraintsImpl::getOptionalConstraintValue): * Modules/mediastream/MediaConstraintsImpl.h: Copied from Source/WebCore/platform/mediastream/RTCPeerConnectionHandler.h. (WebCore): (MediaConstraintsImpl): (WebCore::MediaConstraintsImpl::MediaConstraintsImpl): * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::create): (WebCore::RTCPeerConnection::RTCPeerConnection): * Modules/mediastream/RTCPeerConnection.h: (WebCore): (RTCPeerConnection): * WebCore.gypi: * bindings/js/Dictionary.cpp: (WebCore::Dictionary::getOwnPropertyNames): (WebCore): * bindings/js/Dictionary.h: (Dictionary): * bindings/v8/Dictionary.cpp: (WebCore::Dictionary::getOwnPropertyNames): (WebCore): * bindings/v8/Dictionary.h: (Dictionary): * platform/chromium/support/WebMediaConstraints.cpp: Copied from Source/WebCore/platform/mediastream/RTCPeerConnectionHandler.cpp. (WebKit): (WebKit::WebMediaConstraints::WebMediaConstraints): (WebKit::WebMediaConstraints::assign): (WebKit::WebMediaConstraints::reset): (WebKit::WebMediaConstraints::isNull): (WebKit::WebMediaConstraints::getMandatoryConstraintNames): (WebKit::WebMediaConstraints::getOptionalConstraintNames): (WebKit::WebMediaConstraints::getMandatoryConstraintValue): (WebKit::WebMediaConstraints::getOptionalConstraintValue): * platform/mediastream/MediaConstraints.h: Copied from Source/WebCore/platform/mediastream/RTCPeerConnectionHandler.h. (WebCore): (MediaConstraints): (WebCore::MediaConstraints::~MediaConstraints): (WebCore::MediaConstraints::MediaConstraints): * platform/mediastream/RTCPeerConnectionHandler.cpp: (RTCPeerConnectionHandlerDummy): (WebCore::RTCPeerConnectionHandlerDummy::initialize): * platform/mediastream/RTCPeerConnectionHandler.h: (WebCore): (RTCPeerConnectionHandler): * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp: (WebCore::RTCPeerConnectionHandlerChromium::initialize): * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h: (RTCPeerConnectionHandlerChromium): Tools: Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality. * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler): (isSupportedConstraint): (isValidConstraint): (MockWebRTCPeerConnectionHandler::initialize): * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: (MockWebRTCPeerConnectionHandler): LayoutTests: * fast/mediastream/RTCPeerConnection-expected.txt: * fast/mediastream/RTCPeerConnection.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-