1. 01 Jul, 2013 22 commits
    • jochen@chromium.org's avatar
      Remove support for consumable user gestures · 4f58f490
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118247
      
      Reviewed by Geoffrey Garen.
      
      Source/WebCore:
      
      The features was not enabled on any port, and is meanwhile broken, so we
      should delete it.
      
      No new tests, just deleting dead code.
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::increment):
      (WebCore::AccessibilityNodeObject::decrement):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::press):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeScript):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::executeScriptInWorld):
      * dom/UserGestureIndicator.cpp:
      (WebCore::isDefinite):
      (WebCore::UserGestureIndicator::UserGestureIndicator):
      (WebCore::UserGestureIndicator::~UserGestureIndicator):
      * dom/UserGestureIndicator.h:
      (WebCore::UserGestureIndicator::processingUserGesture):
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::openInNewTab):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::FrontendMenuProvider::contextMenuItemSelected):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::navigate):
      * loader/NavigationScheduler.cpp:
      (WebCore::ScheduledURLNavigation::fire):
      (WebCore::ScheduledURLNavigation::didStartTimer):
      (WebCore::ScheduledRedirect::fire):
      (WebCore::ScheduledRefresh::fire):
      (WebCore::ScheduledHistoryNavigation::fire):
      (WebCore::ScheduledFormSubmission::fire):
      (WebCore::ScheduledFormSubmission::didStartTimer):
      * page/DOMTimer.cpp:
      (WebCore::DOMTimer::DOMTimer):
      (WebCore::DOMTimer::fired):
      * page/DOMTimer.h:
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::showModalDialog):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::clear):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleMouseReleaseEvent):
      * page/EventHandler.h:
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::toggleMediaFullscreenState):
      (WebCore::HitTestResult::enterFullscreenForVideo):
      
      Source/WebKit/blackberry:
      
      * WebKitSupport/NotificationManager.cpp:
      (BlackBerry::WebKit::NotificationManager::notificationClicked):
      
      Source/WebKit/mac:
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::evaluate):
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView sendEvent:isDrawRect:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      (WebCore::NotificationPresenterClientQt::notificationClicked):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::searchWithGoogle):
      
      Source/WebKit2:
      
      * WebProcess/Notifications/WebNotificationManager.cpp:
      (WebKit::WebNotificationManager::didClickNotification):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::performFrameLoadURLRequest):
      (WebKit::PluginView::evaluate):
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f58f490
    • benjamin@webkit.org's avatar
      Add screenshot of the inspector color picker for the blog · 655b3126
      benjamin@webkit.org authored
      * blog-files/last-week-in-webkit: Added.
      * blog-files/last-week-in-webkit/Inspector_color_picker.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      655b3126
    • commit-queue@webkit.org's avatar
      Add Support for mspace element · 4496a299
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115610
      
      Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-01
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      This patch adds basic support for the MathML mspace element. This is
      important to let people control spacing of mathematical formulas.
      Attributes width, height and depth are implemented. For the moment,
      only nonnegative width are accepted.
      
      * CMakeLists.txt: add references to the RenderMathMLSpace files.
      * GNUmakefile.list.am: ditto.
      * Target.pri: ditto.
      * WebCore.vcxproj/WebCore.vcxproj: ditto.
      * WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
      * WebCore.xcodeproj/project.pbxproj: ditto.
      * css/mathml.css:
      (mtable[columnlines="dashed"] > mtr > mtd + mtd): remove the obsolete linebreaking rule.
      * mathml/MathMLTextElement.cpp:
      (WebCore::MathMLTextElement::createRenderer): map mspaceTag to RenderMathMLSpace.
      * mathml/mathattrs.in: add width, height and depth attributes
      * mathml/mathtags.in: add mspace element
      * rendering/mathml/RenderMathMLBlock.cpp:
      (WebCore::parseMathMLLength): fix int to float conversion.
      * rendering/mathml/RenderMathMLBlock.h: declare isRenderMathMLSpace.
      (WebCore::RenderMathMLBlock::isRenderMathMLSpace):
      * rendering/mathml/RenderMathMLSpace.cpp: Added.
      (WebCore::RenderMathMLSpace::RenderMathMLSpace):
      (WebCore::RenderMathMLSpace::isChildAllowed):
      (WebCore::RenderMathMLSpace::computePreferredLogicalWidths):
      (WebCore::RenderMathMLSpace::updateFromElement):
      (WebCore::RenderMathMLSpace::updateLogicalWidth):
      (WebCore::RenderMathMLSpace::updateLogicalHeight):
      (WebCore::RenderMathMLSpace::layout):
      (WebCore::RenderMathMLSpace::styleDidChange):
      (WebCore::RenderMathMLSpace::firstLineBoxBaseline):
      * rendering/mathml/RenderMathMLSpace.h: Added.
      (WebCore::RenderMathMLSpace::isRenderMathMLSpace):
      (WebCore::RenderMathMLSpace::renderName):
      (WebCore::toRenderMathMLSpace):
      
      LayoutTests:
      
      Add a reftest for the mspace element (width, height and depth) and
      the parsing of MathML lengths. Import a reftest from Gecko to check
      positive namedspace values.
      
      * mathml/presentation/mspace-expected.html: Added.
      * mathml/presentation/mspace-units-expected.html: Added.
      * mathml/presentation/mspace-units.html: Added.
      * mathml/presentation/mspace.html: Added.
      * mathml/presentation/positive-namedspace-expected.html: Added.
      * mathml/presentation/positive-namedspace.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4496a299
    • jer.noble@apple.com's avatar
      Audio in apps which embed WebViews is corrupted. · de0138ed
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118163
      
      Reviewed by Maciej Stachowiak.
      
      Source/WebCore:
      
      Add a preference, which defaults to off, which controls whether the
      AudioSessionManager will switch to a large audio buffer setting for
      power-savings during <video> playback.
      
      * WebCore.exp.in:
      * page/Settings.cpp:
      (WebCore::Settings::setLowPowerVideoAudioBufferSizeEnabled): Added.  Simple setter.
      * page/Settings.h:
      (WebCore::Settings::lowPowerVideoAudioBufferSizeEnabled): Added.  Simple getter.
      * platform/audio/mac/AudioSessionManagerMac.cpp:
      (AudioSessionManager::updateSessionState): Only set the large audio buffer
          size if lowPowerVideoAudioBufferSize is enabled.
      
      Source/WebKit/mac:
      
      Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit clients.
      
      * WebView/WebPreferenceKeysPrivate.h:
      * WebView/WebPreferences.mm:
      (+[WebPreferences initialize]):
      (-[WebPreferences lowPowerVideoAudioBufferSizeEnabled]):
      (-[WebPreferences setLowPowerVideoAudioBufferSizeEnabled:]):
      * WebView/WebPreferencesPrivate.h:
      * WebView/WebView.mm:
      (-[WebView _preferencesChanged:]):
      
      Source/WebKit2:
      
      Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit2 clients.
      
      * Shared/WebPreferencesStore.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de0138ed
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed correction to DEBUG_ALL target. Target was undefining... · de224e8f
      bfulgham@apple.com authored
      [Windows] Unreviewed correction to DEBUG_ALL target.  Target was undefining DEBUG_ALL and DEBUG_INTERNAL,
      which prevented proper build operation.
      
      * win/tools/vsprops/debugsuffix.props: We should DEFINE (not UNDEFINE) the DEBUG_ALL and DEBUG_INTERNAL
      macros when building with 'debugsuffix' target.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de224e8f
    • commit-queue@webkit.org's avatar
      [ATK] Leak: leaks in WebKitAccessibleInterfaceText · fe5107fb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118248
      
      Fixed memory leaks.
      
      Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-01
      Reviewed by Christophe Dumez.
      
      * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
      (getPangoLayoutForAtk):
      (webkitAccessibleTextGetText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe5107fb
    • roger_fong@apple.com's avatar
      Unreviewed. Make WebCore.make copy over QTMovieWin DLL's and PDB's. · 6f785829
      roger_fong@apple.com authored
      <rdar://problem/14321403>
      
      * WebCore.vcxproj/WebCore.make:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f785829
    • weinig@apple.com's avatar
      WKPageLoadDataWithUserData neglects to set the base URL that is passed in · 92958b8b
      weinig@apple.com authored
      <rdar://problem/14306784>
      https://bugs.webkit.org/show_bug.cgi?id=118256
      
      Reviewed by Anders Carlsson.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::loadData):
      Pass the baseURL, not blankURL(), and remove an unnecessary multiplication by sizeof(uint8_t) which is always 1.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92958b8b
    • commit-queue@webkit.org's avatar
      [Curl] WebDownload init method is not implemented. · c90a99ad
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118241
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
      Reviewed by Brent Fulgham.
      
      The WebDownload::init() method called when a normal load is changed to a download
      because of a decision by the policy delegate, is not implemented for Curl.
      
      * WebDownloadCurl.cpp:
      (WebDownload::init): Implement init() method.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c90a99ad
    • commit-queue@webkit.org's avatar
      [Win] Crash when scrolling page with images. · 9aaa3d43
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117832
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
      Reviewed by Brent Fulgham.
      
      Avoid access violation by returning early from method if image frame doesn't have pixel data.
      
      * platform/image-decoders/ImageDecoder.h:
      (WebCore::ImageFrame::hasPixelData): Added method to check if frame has pixel data.
      * platform/image-decoders/gif/GIFImageDecoder.cpp:
      (WebCore::GIFImageDecoder::haveDecodedRow): Early return if frame doesn't have pixel data.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aaa3d43
    • commit-queue@webkit.org's avatar
      Avoid calling RenderLayerBacking::resetContentsRect() if possible · 02d22164
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118217
      
      Patch by Noam Rosenthal <noam@webkit.org> on 2013-07-01
      Reviewed by Simon Fraser.
      
      Call resetContentsRect() only if the layer has a contentsLayer.
      Otherwise the contentsRect is redundant for the GraphicsLayer.
      
      No new tests - optimization only. This is covered by plenty of existing
      tests in webgl/ and compositing/.
      
      * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
      (WebCore::GraphicsLayerTextureMapper::hasContentsLayer):
      * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
          Added hasContentsLayer calls for TextureMapper/CoordinatedGraphics
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02d22164
    • commit-queue@webkit.org's avatar
      [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR · 50c9da25
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117249
      
      Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2013-07-01
      Reviewed by Brent Fulgham.
      
      Finish converting all use cases of WEBKITOUTPUTDIR to
      WEBKIT_OUTPUTDIR, which seems to be preferred these days.
      
      * DumpRenderTree/efl/FontManagement.cpp:
      (getCustomBuildDir):
      (getPlatformFontsPath):
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (getOutputDir):
      * Scripts/webkitdirs.pm:
      (determineBaseProductDir):
      (usesPerConfigurationBuildDirectory):
      * Scripts/webkitpy/port/base.py:
      (Port.to.setup_environ_for_server):
      * Scripts/webkitpy/port/driver.py:
      (Driver._setup_environ_for_driver):
      * Scripts/webkitpy/port/gtk.py:
      (GtkPort.setup_environ_for_server):
      * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
      (WTR::getOutputDir):
      * jhbuild/jhbuildutils.py:
      (get_dependencies_path):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50c9da25
    • ossy@webkit.org's avatar
      Fix cast-align warnings in JavaScriptCore/heap/HandleBlockInlines.h · 918ee237
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118242
      
      Reviewed by Mark Hahnenberg.
      
      * heap/HandleBlockInlines.h:
      (JSC::HandleBlock::nodes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      918ee237
    • rafael.lobo@openbossa.org's avatar
      Unreviewed change of my email address. · 74e2f0b8
      rafael.lobo@openbossa.org authored
      * Scripts/webkitpy/common/config/contributors.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74e2f0b8
    • timothy_horton@apple.com's avatar
    • allan.jensen@digia.com's avatar
      [Qt] Avoid creating a QWindow for offscreen GraphicsContext3D · e7f8d071
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118244
      
      Reviewed by Noam Rosenthal.
      
      In Qt 5.0 we had to create invisible windows, but in Qt 5.1
      we can now create specific offscreen surfaces.
      
      * platform/graphics/qt/GraphicsContext3DQt.cpp:
      (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7f8d071
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Skipping unsupported tests. · b9e0328a
      kadam@inf.u-szeged.hu authored
      Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-01
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9e0328a
    • allan.jensen@digia.com's avatar
      [Qt] Remove long unused Qt4 forward definitions · 95d9d486
      allan.jensen@digia.com authored
      Unreviewed cleanu-up.
      
      * platform/graphics/GraphicsContext3D.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95d9d486
    • antti@apple.com's avatar
      Use DeferrableOneShotTimer for deleting decoded data · dae1be26
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118150
      
      Reviewed by Andreas Kling.
      
      Adam Barth pointed out that the virtual function for overriding the default delay doesn't work
      as expected from base class constructor.
      
      * loader/cache/CachedResource.cpp:
      (WebCore::deadDecodedDataDeletionIntervalForResourceType):
      (WebCore::CachedResource::CachedResource):
              
          Use static function instead of calling a virtual.
      
      * loader/cache/CachedResource.h:
      * loader/cache/CachedScript.cpp:
      * loader/cache/CachedScript.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dae1be26
    • kangil.han@samsung.com's avatar
      Adopt toHTMLTextAreaElement for code cleanup · b5a972ab
      kangil.han@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118226
      
      Reviewed by Andreas Kling.
      
      To enhance readability, this patch adopts toHTMLTextAreaElement.
      This also helps out to reduce duplicated use of static_cast.
      
      Source/WebCore:
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::determineAccessibilityRole):
      (WebCore::AccessibilityNodeObject::isNativeTextControl):
      (WebCore::AccessibilityNodeObject::isReadOnly):
      (WebCore::AccessibilityNodeObject::text):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::setValue):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::adjustRenderStyle):
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::appendText):
      * html/HTMLFormControlElement.cpp:
      (WebCore::shouldAutofocus):
      * html/HTMLTextAreaElement.h:
      (WebCore::toHTMLTextAreaElement):
      * page/FocusController.cpp:
      (WebCore::clearSelectionIfNeeded):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::isContentEditable):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::sizesLogicalWidthToFitContent):
      * rendering/RenderTextControlMultiLine.cpp:
      (WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
      (WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth):
      (WebCore::RenderTextControlMultiLine::computeControlLogicalHeight):
      * testing/Internals.cpp:
      (WebCore::Internals::wasLastChangeUserEdit):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::isTextInputElement):
      (BlackBerry::WebKit::DOMSupport::inputElementText):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::elementType):
      (BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::textDidChangeInTextArea):
      
      Source/WebKit/win:
      
      * DOMCoreClasses.cpp:
      (DOMElement::createInstance):
      * DOMHTMLClasses.cpp:
      (DOMHTMLTextAreaElement::form):
      (DOMHTMLTextAreaElement::value):
      (DOMHTMLTextAreaElement::setValue):
      (DOMHTMLTextAreaElement::select):
      (DOMHTMLTextAreaElement::isUserEdited):
      
      Source/WebKit2:
      
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
      * WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
      (WebKit::PDFPluginTextAnnotation::createAnnotationElement):
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::textDidChangeInTextArea):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::containsAnyFormControls):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5a972ab
    • commit-queue@webkit.org's avatar
      Add missing string headers that are used when LOG_DISABLED is 0. · 964a08ce
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118227
      
      Patch by Kwang Yul Seo <skyul@company100.net> on 2013-07-01
      Reviewed by Andreas Kling.
      
      Build fix for LOG_DISABLED=0.
      
      No new tests, no behavior change.
      
      * html/track/InbandTextTrack.cpp:
      * rendering/RenderLayerCompositor.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      964a08ce
    • commit-queue@webkit.org's avatar
      [GTK] Use PassOwnPtr for the returned value of createBackingStore · 0dcdaf3e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118230
      
      Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-07-01
      Reviewed by Andreas Kling.
      
      It would be better that createBackingStore returns PassOwnPtr instread of OwnPtr
      to keep compatibility with c++0x.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::createBackingStore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dcdaf3e
  2. 30 Jun, 2013 1 commit
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. Rebaselining whatever can be rebaselined and adding... · 31e07023
      zandobersek@gmail.com authored
      Unreviewed GTK gardening. Rebaselining whatever can be rebaselined and adding failure expectations for other current failures.
      
      * platform/gtk-wk1/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/gtk/editing/selection/user-select-all-image-with-single-click-expected.txt: Added.
      * platform/gtk/editing/selection/user-select-all-with-single-click-expected.txt: Added.
      * platform/gtk/fast/events/ondragenter-expected.txt: Added.
      * platform/gtk/fast/js/global-constructors-attributes-expected.txt:
      * platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31e07023
  3. 29 Jun, 2013 9 commits
    • simon.fraser@apple.com's avatar
      Avoid calling into Objective-C every time we get the scrollbar width · a8c53e88
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118216
      
      Reviewed by Geoffrey Garen.
      
      Profiling shows that calling Scrollbar::isOverlayScrollbar() is somewhat
      expensive, because it calls down into Objective-C. Fix by caching in
      ScrollbarThemeMac whether we're using overlay scrollbars. We update this
      cache on creation, and when preferences change; ScrollAnimatorMac::updateScrollerStyle()
      is the function that gets called when the user changes the setting in System Preferences.
      
      * platform/ScrollbarTheme.h:
      (WebCore::ScrollbarTheme::usesOverlayScrollbarsChanged):
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::updateScrollerStyle):
      * platform/mac/ScrollbarThemeMac.h:
      * platform/mac/ScrollbarThemeMac.mm:
      (WebCore::ScrollbarThemeMac::preferencesChanged):
      (WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
      (WebCore::ScrollbarThemeMac::usesOverlayScrollbarsChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8c53e88
    • simon.fraser@apple.com's avatar
      Avoid calling isSimpleContainerCompositingLayer() an extra time · 9ca8cf76
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118218
      
      Reviewed by Tim Horton.
      
      containsPaintedContent() called isSimpleContainerCompositingLayer(), which
      is not particularly cheap. But the caller already has this information,
      so pass it in.
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateDrawsContent):
      (WebCore::RenderLayerBacking::containsPaintedContent):
      * rendering/RenderLayerBacking.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ca8cf76
    • simon.fraser@apple.com's avatar
      Avoid doing work in RenderBox::outlineBoundsForRepaint() when the repaintContainer is this · b2b9c418
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118215
      
      Reviewed by Tim Horton.
      
      When the RenderGeometryMap code path was added, RenderBox::outlineBoundsForRepaint()
      actually got slower if no coordinate mapping was needed. So avoid doing work when
      we can, including avoiding the FloatQuad construction.
      
      Speeds up scrolling overflow:scroll areas with large numbers of layer children.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::outlineBoundsForRepaint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2b9c418
    • kangil.han@samsung.com's avatar
      Adopt is/toHTMLOptGroupElement for code cleanup · 41d50db0
      kangil.han@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118213
      
      Reviewed by Andreas Kling.
      
      To enhance readability, this patch adopts is/toHTMLOptGroupElement.
      This also helps out to reduce duplicated use of static_cast.
      
      Source/WebCore:
      
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::isEnabled):
      (WebCore::AccessibilityListBoxOption::stringValue):
      (WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOne):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::canShareStyleWithElement):
      * html/HTMLOptGroupElement.h:
      (WebCore::isHTMLOptGroupElement):
      (WebCore::toHTMLOptGroupElement):
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
      (WebCore::HTMLOptionElement::isDisabledFormControl):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::childShouldCreateRenderer):
      (WebCore::HTMLSelectElement::recalcListItems):
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::hasImpliedEndTag):
      * html/parser/HTMLElementStack.cpp:
      (WebCore::HTMLNames::isSelectScopeMarker):
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processStartTag):
      (WebCore::HTMLTreeBuilder::processEndTag):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::updateFromElement):
      (WebCore::RenderListBox::paintItemForeground):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemText):
      (WebCore::RenderMenuList::itemIsEnabled):
      (WebCore::RenderMenuList::itemIsLabel):
      
      Source/WebKit/blackberry:
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::openSelectPopup):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41d50db0
    • commit-queue@webkit.org's avatar
      Build fix for unguarded SVGGraphicsElement · 5902fb39
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118214
      
      Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-06-29
      Reviewed by Christophe Dumez.
      
      Add the SVG condition to SVGGraphicsElement.idl
      
      No new tests required since no functionality changed.
      
      * svg/SVGGraphicsElement.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5902fb39
    • akling@apple.com's avatar
      Follow-up to r152206: also update HashFlags8BitBuffer in the LLInt. · 29e2db27
      akling@apple.com authored
      * llint/LowLevelInterpreter.asm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29e2db27
    • kangil.han@samsung.com's avatar
      Adopt is/toHTMLOptionElement for code cleanup · 5dc8b8ca
      kangil.han@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118212
      
      Reviewed by Andreas Kling.
      
      To enhance readability, this patch adopts is/toHTMLOptionElement.
      This also helps out to reduce duplicated use of static_cast.
      
      Source/WebCore:
      
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::isSelected):
      (WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
      (WebCore::AccessibilityListBoxOption::stringValue):
      (WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
      * accessibility/AccessibilityMenuListOption.cpp:
      (WebCore::AccessibilityMenuListOption::setElement):
      (WebCore::AccessibilityMenuListOption::isEnabled):
      (WebCore::AccessibilityMenuListOption::isSelected):
      (WebCore::AccessibilityMenuListOption::setSelected):
      (WebCore::AccessibilityMenuListOption::stringValue):
      * accessibility/AccessibilityMenuListPopup.cpp:
      (WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityHitTest):
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOne):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::canShareStyleWithElement):
      * html/HTMLCollection.cpp:
      (WebCore::isMatchingElement):
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::index):
      * html/HTMLOptionElement.h:
      (WebCore::isHTMLOptionElement):
      (WebCore::toHTMLOptionElement):
      * html/HTMLOptionsCollection.cpp:
      (WebCore::HTMLOptionsCollection::add):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
      (WebCore::HTMLSelectElement::value):
      (WebCore::HTMLSelectElement::setValue):
      (WebCore::HTMLSelectElement::childShouldCreateRenderer):
      (WebCore::HTMLSelectElement::nextValidIndex):
      (WebCore::HTMLSelectElement::saveLastSelection):
      (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
      (WebCore::HTMLSelectElement::updateListBoxSelection):
      (WebCore::HTMLSelectElement::listBoxOnChange):
      (WebCore::HTMLSelectElement::recalcListItems):
      (WebCore::HTMLSelectElement::selectedIndex):
      (WebCore::HTMLSelectElement::selectOption):
      (WebCore::HTMLSelectElement::optionToListIndex):
      (WebCore::HTMLSelectElement::listToOptionIndex):
      (WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
      (WebCore::HTMLSelectElement::saveFormControlState):
      (WebCore::HTMLSelectElement::searchOptionsForValue):
      (WebCore::HTMLSelectElement::restoreFormControlState):
      (WebCore::HTMLSelectElement::appendFormData):
      (WebCore::HTMLSelectElement::reset):
      (WebCore::HTMLSelectElement::updateSelectedState):
      (WebCore::HTMLSelectElement::lastSelectedListIndex):
      (WebCore::HTMLSelectElement::optionAtIndex):
      (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
      (WebCore::HTMLSelectElement::length):
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::hasImpliedEndTag):
      * html/parser/HTMLElementStack.cpp:
      (WebCore::HTMLNames::isSelectScopeMarker):
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processStartTagForInBody):
      (WebCore::HTMLTreeBuilder::processStartTag):
      (WebCore::HTMLTreeBuilder::processEndTag):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::updateFromElement):
      (WebCore::RenderListBox::addFocusRingRects):
      (WebCore::RenderListBox::paintItemForeground):
      (WebCore::RenderListBox::paintItemBackground):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::updateOptionsWidth):
      (WebCore::RenderMenuList::setTextFromOption):
      (WebCore::RenderMenuList::itemText):
      (WebCore::RenderMenuList::itemIsEnabled):
      (WebCore::RenderMenuList::itemIsSelected):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::paintSliderTicks):
      
      Source/WebKit/blackberry:
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
      (BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
      (BlackBerry::WebKit::InputHandler::openSelectPopup):
      (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
      * WebKitSupport/SelectPopupClient.cpp:
      (BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
      
      Source/WebKit/win:
      
      * DOMCoreClasses.cpp:
      (DOMElement::createInstance):
      * DOMHTMLClasses.cpp:
      (DOMHTMLOptionElement::text):
      (DOMHTMLOptionElement::label):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dc8b8ca
    • carlosgc@webkit.org's avatar
      REGRESSION(151586): multipart/x-mixed-replace images are broken · c081e1a6
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118169
      
      Reviewed by Alexey Proskuryakov.
      
      When loading multipart content the resource data will change as
      the next part is loaded, so we need to make a copy of the data
      before sending it to the resource.
      
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::didReceiveResponse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c081e1a6
    • akling@apple.com's avatar
      Un-crashify JSC tests on debug bots after Anders had his way with StringImpl. · 1a1fba72
      akling@apple.com authored
      * llint/LLIntData.cpp:
      (JSC::LLInt::Data::performAssertions):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a1fba72
  4. 28 Jun, 2013 8 commits
    • akling@apple.com's avatar
      Fix Windows builds after deprecatedCharactersWithNullTermination() removal. · ce072e95
      akling@apple.com authored
      Source/WebKit2:
      
      * Platform/CoreIPC/win/ConnectionWin.cpp:
      (CoreIPC::Connection::createServerAndClientIdentifiers):
      
      Tools:
      
      * DumpRenderTree/win/DumpRenderTree.cpp:
      (addFontFallbackIfPresent):
      (removeFontFallbackIfPresent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce072e95
    • eric.carlson@apple.com's avatar
      [Mac] adopt new AVFoundation caption API · ed94dcbd
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118207
      
      Reviewed by Dean Jackson.
      
      No new tests, I was not able to come up with a reliable layout test.
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::flushCues): New, call currentTrack->resetCueValues().
      (-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]): New delegate method.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed94dcbd
    • kangil.han@samsung.com's avatar
      Adopt is/toHTMLImageElement for code cleanup · 2489e830
      kangil.han@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118182
      
      Reviewed by Andreas Kling.
      
      To enhance readability, this patch adopts is/toHTMLImageElement.
      This also helps out to reduce duplicated use of static_cast.
      
      Source/WebCore:
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::isNativeImage):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::url):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::isReachableFromDOM):
      * bridge/qt/qt_pixmapruntime.cpp:
      (JSC::Bindings::assignToHTMLImageElement):
      (JSC::Bindings::QtPixmapRuntime::toQt):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::setDragImage):
      * dom/Node.cpp:
      (WebCore::Node::enclosingLinkEventParentOrSelf):
      * editing/Editor.cpp:
      (WebCore::imageElementFromImageDocument):
      * html/HTMLAnchorElement.cpp:
      (WebCore::appendServerMapMousePosition):
      * html/HTMLImageElement.h:
      (WebCore::isHTMLImageElement):
      (WebCore::toHTMLImageElement):
      * html/HTMLMapElement.cpp:
      (WebCore::HTMLMapElement::imageElement):
      * html/HTMLNameCollection.cpp:
      (WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
      (WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch):
      (WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
      (WebCore::DocumentNameCollection::nodeMatches):
      * page/DragController.cpp:
      (WebCore::DragController::draggableElement):
      * page/PageSerializer.cpp:
      (WebCore::PageSerializer::serializeFrame):
      * platform/gtk/PasteboardGtk.cpp:
      (WebCore::getURLForImageNode):
      * platform/mac/HTMLConverter.mm:
      (+[WebHTMLConverter editingAttributedStringFromRange:]):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::altDisplayString):
      (WebCore::HitTestResult::absoluteImageURL):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::paintIntoRect):
      (WebCore::RenderImage::imageMap):
      (WebCore::RenderImage::updateAltText):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::shouldRespectImageOrientation):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
      (BlackBerry::WebKit::WebPage::blockZoom):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::isElementClickable):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2489e830
    • barraclough@apple.com's avatar
      PageThrottler::shouldThrottleTimers is wrong. · 15177c1e
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118210
      
      Reviewed by Anders Carlson.
      
      m_throttleState == PageNotThrottledState
          -> page NOT throttled, so should NOT throttle timers
      m_throttleState != PageNotThrottledState
          -> page NOT NOT throttled, so should throttle timers
      
      This needs cleaning up, but for now, 1 character fix.
      
      * page/PageThrottler.h:
      (WebCore::PageThrottler::shouldThrottleTimers):
          == -> !=
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15177c1e
    • andersca@apple.com's avatar
      Remove String::deprecatedCharactersWithNullTermination() and related code · 71d37b52
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118211
      
      Reviewed by Benjamin Poulain.
      
      Source/JavaScriptCore:
      
      * API/JSStringRef.cpp:
      (JSStringCreateWithCharactersNoCopy):
      Update call to StringImpl::createWithoutCopying.
      
      Source/WTF:
      
      Remove String::deprecatedCharactersWithNullTermination, StringImpl::createWithTerminatingNullCharacter
      and the s_hashFlagHasTerminatingNullCharacter flag. We no longer care about whether strings have a
      terminating null character.
      
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::createFromLiteral):
      (WTF::StringImpl::createWithoutCopying):
      (WTF::StringImpl::getData16SlowCase):
      (WTF::StringImpl::sizeInBytes):
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::StringImpl):
      (WTF::StringImpl::createFromLiteral):
      (WTF::StringImpl::isolatedCopy):
      * wtf/text/WTFString.cpp:
      * wtf/text/WTFString.h:
      
      Tools:
      
      Remove all hasTerminatingNullCharacter() checks.
      
      * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WTF/WTFString.cpp:
      (TestWebKitAPI::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71d37b52
    • dino@apple.com's avatar
      Update Apple System fonts in auto-complete · e460d251
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118205
      <rdar://problem/14308488>
      
      Reviewed by Joseph Pecoraro.
      
      Update for the new Apple System font names, and remove some invalid entries.
      
      * UserInterface/CSSKeywordCompletions.js: General cleanup. Note that
      "apple-system-short-caption2" looks like it was accidentally omitted. It wasn't :)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e460d251
    • commit-queue@webkit.org's avatar
      Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required' · 72c92def
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118122
      
      Patch by James Craig <james@cookiecrook.com> on 2013-06-28
      Reviewed by Timothy Hatcher.
      
      Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
      so that screen readers will not indicate a bogus :required/:invalid state to the user.
      Minor cosmetic difference blocked by http://webkit.org/b/118162
      
      * UserInterface/FilterBar.css:
      (.filter-bar > input[type="search"]:focus):
      (.filter-bar > input[type="search"]:not(:placeholder-shown)):
      * UserInterface/FilterBar.js:
      (WebInspector.FilterBar):
      * UserInterface/ResourceSidebarPanel.js:
      (WebInspector.ResourceSidebarPanel):
      * UserInterface/SearchBar.css:
      (.search-bar > input[type="search"]:focus):
      (.search-bar > input[type="search"]:not(:placeholder-shown)):
      * UserInterface/SearchBar.js:
      (WebInspector.SearchBar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72c92def
    • rniwa@webkit.org's avatar
      An element with -webkit-user-select: all should be selected on single click · a06d16c9
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117864
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Set m_mouseDownMayStartSelect true even when the node cannot start selection
      if the node was inside an element with -webkit-user-select: all.
      
      Test: editing/selection/user-select-all-with-single-click.html
      
      * page/EventHandler.cpp:
      (WebCore::canMouseDownStartSelect):
      
      LayoutTests: 
      
      Add tests for single clicking on an element with user-select: all.
      We select the entire element regardless of whether the user had clicked on text or an image
      to be consistent even though Firefox requires a double click on the latter case.
      
      * editing/selection/user-select-all-with-image-single-click-expected.txt: Added.
      * editing/selection/user-select-all-with-image-single-click.html: Added.
      * editing/selection/user-select-all-with-single-click-expected.txt: Added.
      * editing/selection/user-select-all-with-single-click.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a06d16c9