GitLab

https://bugs.webkit.org/show_bug.cgi?id=94717

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2012-09-04
Reviewed by Hajime Morita.

Source/WebCore:

It's possible for a frame element that has been removed from the document
to retain an active child frame. This inconsistent state may become a source
of security vulnerabilities.

The patch adds a global HashSet to store the nodes currently processed by
ChildFrameDisconnector. Insertion into these nodes' subtrees is not allowed until
the processing is complete.

Also, the ChildFrameDisconnector call in removeChild(ren) is now immediately
followed by the actual removal.

Test: fast/frames/out-of-document-iframe-has-child-frame.html

* dom/ContainerNode.cpp:
(WebCore::willRemoveChildren): Move the ChildFrameDisconnector call out of a loop.
(WebCore::ContainerNode::removeChild): Rearrange some event firing code.
(WebCore::ContainerNode::removeChildren): Ditto.
* dom/ContainerNodeAlgorithms.cpp:
(WebCore::ChildFrameDisconnector::collectDescendant): Pass a new parameter to collectDescendant(Node*).
* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(ChildFrameDisconnector): Maintain a list of nodes that have an active ChildFrameDisconnector.
(WebCore::ChildFrameDisconnector::~ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::rootNodes):
(WebCore::ChildFrameDisconnector::collectDescendant): Add ShouldIncludeRoot parameter.
(WebCore::ChildFrameDisconnector::nodeHasDisconnector):
(WebCore):
* dom/Node.cpp:
(WebCore::checkAcceptChild): Reject a parent node if it or one of its parents has an active ChildFrameDisconnector.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check if an element is still in the document.

LayoutTests:

* fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
* fast/frames/out-of-document-iframe-has-child-frame.html: Added.
* fast/innerHTML/innerHTML-iframe-expected.txt:
* platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
* platform/chromium/fast/innerHTML: Added.
* platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

It fails on both Windows and Mac: https://bugs.webkit.org/show_bug.cgi?id=94374.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/win/fast/text/international/text-spliced-font-expected.txt:
* platform/win/fast/writing-mode/border-vertical-lr-expected.txt:
* platform/win/fast/writing-mode/japanese-lr-selection-expected.txt:
* platform/win/fast/writing-mode/japanese-lr-text-expected.txt:
* platform/win/fast/writing-mode/japanese-rl-selection-expected.txt:
* platform/win/fast/writing-mode/japanese-rl-text-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove chromium/public/WebOfferAnswerRequest.h from Platform.gypi,
which was added in r127501, but doesn't exist. Unreviewed.

* Platform.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95702

Reviewed by Beth Dakin.

Source/WebCore:

Move utf8Buffer() to SharedBuffer.h/cpp
Move numGraphemeClusters() and numCharactersInGraphemeClusters() to TextBreakIterator.h/cpp

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Update projects.

* platform/text/TextAllInOne.cpp:
Add TextBreakIterator.cpp.

* editing/Editor.h:
Forward declare SharedBuffer, now that PlatformString.h doesn't.

* html/InputType.cpp:
#include TextBreakIterator.h.

* loader/appcache/ApplicationCacheStorage.h:
Replace inclusion of PlatformString.h with WTFString.h and forward declare SharedBuffer.

* platform/LocalizedStrings.cpp:
Replace inclusion of PlatformString.h with TextBreakIterator.h

* platform/SharedBuffer.cpp:
* platform/SharedBuffer.h:
Move utf8Buffer() here.

* platform/text/PlatformString.h:
Remove everything except the #include of WTFString.h.

* platform/text/TextBreakIterator.cpp: Renamed from Source/WebCore/platform/text/String.cpp.
(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):
* platform/text/TextBreakIterator.h:
Move numGraphemeClusters() and numCharactersInGraphemeClusters() here.

Source/WebKit2:

* UIProcess/WebPageProxy.h:
Forward declare SharedBuffer.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95776

Reviewed by Simon Fraser.

.:

* ManualTests/select-menu-list-wrongly-positioned.html: Added.

Source/WebCore:

r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.

Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since introduced in http://trac.webkit.org/changeset/126865.
Test added to skip list.

https://bugs.webkit.org/show_bug.cgi?id=95795

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95777

Reviewed by Tony Chang.

IDBRequests are kept alive as long as they may fire events, which includes
if the associated IDBCursor object can be advanced. When the transaction
is finished the IDBCursor is notified which in turn tells the IDBRequest
that the cursor won't be the source of more events. However, if this occurs
and no further events fire the IDBRequest doesn't clear it's "has pending
activity flag". Clear the flag on the notification if the request is
otherwise complete.

No new tests - ActiveDOMObjects and leaks are persnickety.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::finishCursor):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=93870

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-04
Reviewed by Dirk Schulze.

Source/WebCore:

Add expressions for the aforementioned blend modes. The expressions are lifted directly
from the CSS Compositing and Blending spec [1]. WebKit adds these blending expressions to
the author's shader.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal

Test: css3/filters/custom/custom-filter-blend-modes.html

* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::blendFunctionString):

LayoutTests:

Add test to check that the DOM element texture blends correctly with the css_MixColor
variable from the author's shader for each blend mode.

* css3/filters/custom/custom-filter-blend-modes-expected.html: Added.
* css3/filters/custom/custom-filter-blend-modes.html: Added.
* css3/filters/resources/mix-color.fs: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/127503
https://bugs.webkit.org/show_bug.cgi?id=95788

broke some tests (fast/js/dfg-negative-array-index, fast/js
/dfg-put-by-val-setter-then-get-by-val) (Requested by thorton
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-04

* bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95783

Reviewed by Antonio Gomes.

Use the correct enum values.

* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::cachingStrategy):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95779

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-09-04
Reviewed by Eric Seidel.

Changes indenting for Event.h to match style guidelines for namespaces

* dom/Event.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=94888

Reviewed by Brady Eidson.

Source/WebCore:

Added functions for discerning if a plugin should be able to access its storage in its current origin.

Tests: http/tests/security/cross-origin-plugin-allowed.html
       http/tests/security/cross-origin-plugin.html

* WebCore.exp.in: Export FrameTree::top and SecurityOrigin::canAccessStorage
* page/SecurityOrigin.h: Added canAccessPluginStorage
(WebCore::SecurityOrigin::canAccessPluginStorage):

Source/WebKit2:

Plugins that are in a third-party context should be put into private browsing mode so their storage is temporary.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::isPrivateBrowsingEnabled): Put the plugin into private browsing mode if it is in a third-party context.
(WebKit::PluginView::privateBrowsingStateChanged): Make sure a plugin doesn't leave private browsing mode if it's in a third-party context.

LayoutTests:

Created tests for plugins in a third party and first party context when third-party blocking is on and off.

* http/tests/security/cross-origin-plugin-allowed-expected.txt: Added.
* http/tests/security/cross-origin-plugin-allowed.html: Added.
* http/tests/security/cross-origin-plugin-expected.txt: Added.
* http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt: Added.
* http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html: Added.
* http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
* http/tests/security/cross-origin-plugin-private-browsing-toggled.html: Added.
* http/tests/security/cross-origin-plugin.html: Added.
* http/tests/security/resources/cross-origin-iframe-for-plugin.html: Added.
* http/tests/security/resources/cross-origin-iframe-for-plugin-async.html: Added.
* platform/mac-wk2/http/tests/security/cross-origin-plugin-expected.txt: Added.
* platform/mac-wk2/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95770

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._log_error): Added to replace original _log.error().
(ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
(ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
(ChromiumAndroidDriver._push_executable):
(ChromiumAndroidDriver._push_fonts):
(ChromiumAndroidDriver._push_test_resources):
(ChromiumAndroidDriver._run_adb_command):
(ChromiumAndroidDriver._get_last_stacktrace):
(ChromiumAndroidDriver._get_crash_log):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver._start_once.deadlock_detector):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidDriverTest.test_get_crash_log):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Rebaseline Windows expected results for accessibility\canvas-description-and-role-expected.txt.
One of the results in the test now passes.

* platform/win/accessibility/canvas-description-and-role-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium-android/TestExpectations:
* platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95632

Reviewed by Abhishek Arya.

Source/WebCore:

Don't add floats to the floating object set of blocks that avoid floats. There's no point in doing that
and they will never get cleared out during relayout.

Tests: fast/css/intruding-floats-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloatsIfNeeded):

LayoutTests:

* fast/css/intruding-floats-crash-expected.txt: Added.
* fast/css/intruding-floats-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95706

Source/WebCore: 

Reviewed by Abhishek Arya.

Pass the length of string literals to CSSParser static functions equal() and 
equalIgnoringCase() so that checks won't access out of bounds memory.

Added test fast/css/crash-comparing-equal.html.

* css/CSSParser.cpp:
(WebCore::equal): Use template to retrieve the length of string literal.
(WebCore::equalIgnoringCase): Ditto.
(WebCore::CSSParser::parseDashboardRegions): Use const char[] instead of const char*

LayoutTests: 

Added test from duplicate defect https://bugs.webkit.org/show_bug.cgi?id=95634.

Reviewed by Abhishek Arya.

* fast/css/crash-comparing-equal-expected.txt: Added.
* fast/css/crash-comparing-equal.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95742

Reviewed by Eric Seidel.

git commands run from scm/git.py are sometimes run with cwd set to the
checkout_root and other times with whatever directory was the default cwd.
Instead all these should run with the checkout root set as the cwd
(except where we explicitly need a different path)

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git._run_git):
(Git.find_checkout_root):
(Git.discard_local_commits):
(Git.local_commits):
(Git.working_directory_is_clean):
(Git.clean_working_directory):
(Git.add_list):
(Git.delete_list):
(Git.exists):
(Git._current_branch):
(Git._changes_files_for_commit):
(Git.revisions_changing_file):
(Git.svn_revision):
(Git._run_git_svn_find_rev):
(Git.contents_at_revision):
(Git.diff_for_file):
(Git.show_head):
(Git.committer_email_for_revision):
(Git.apply_reverse_diff):
(Git.revert_files):
(Git.commit_with_message):
(Git._commit_on_branch):
(Git.svn_commit_log):
(Git.last_svn_commit_log):
(Git.svn_blame):
(Git._branch_ref_exists):
(Git.delete_branch):
(Git.remote_merge_base):
(Git.commit_locally_with_message):
(Git.push_local_commits_to_server):
(Git.commit_ids_from_commitish_arguments):
(Git.commit_message_for_local_commit):
(Git.files_changed_summary_for_commit):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed gardening. meda/video-controls-captions.html fails on Windows after it was introduced in http://trac.webkit.org/changeset/127035.
https://bugs.webkit.org/show_bug.cgi?id=95428

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95633

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-04
Reviewed by Geoffrey Garen.

This patch improve the use of strings in the JSC runtime.

The initialization of Identifier is left for future patches.

The improvements are the following:
-5% faster to raise one of the modified exception.
-3 times faster to execute Boolean::toString()

Most of the changes are just about using the new methods
for string literals.

With the changes, the binary on x86_64 gets 176 bytes smaller.

* API/JSCallbackObjectFunctions.h:
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):
* API/JSContextRef.cpp:
(JSContextCreateBacktrace):
* API/JSObjectRef.cpp:
(JSObjectMakeFunctionWithCallback):
* bytecode/CodeBlock.cpp:
(JSC::valueToSourceString):
(JSC::CodeBlock::nameForRegister):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::addStackTraceIfNecessary):
* runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
* runtime/ArrayPrototype.cpp:
(JSC::shift):
(JSC::unshift):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
* runtime/BooleanPrototype.cpp:
(JSC::booleanProtoFuncToString): Instead of instanciating new strings, reuse the
keywords available in SmallStrings. Avoiding the creation of the JSString and StringImpl
makes the method significantly faster.

* runtime/DateConversion.cpp:
(JSC::formatDateTime):
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::formateDateInstance):
(JSC::dateProtoFuncToISOString):
Change the way we use snprintf() for clarity and performance.

Instead of allocating one extra byte to put a zero "just in case", we use the size returned
by snprintf().
To prevent any overflow from a programming mistake, we explicitely test for overflow and
return an empty string.

(JSC::dateProtoFuncToJSON):
* runtime/Error.cpp:
(JSC::createNotEnoughArgumentsError):
(JSC::throwTypeError):
(JSC::throwSyntaxError):
* runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::create):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::finishCreation):
(JSC::errorProtoFuncToString):
Using a null String is correct because (8) uses jsString(), (9) tests for a length of 0.

* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
(JSC::createStackOverflowError):
(JSC::createOutOfMemoryError):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::FunctionExecutable::paramString):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::create):
Using a null String for the name is correct because InternalFunction uses jsString()
to create the name value.

* runtime/InternalFunction.cpp:
(JSC::InternalFunction::finishCreation):
There is no need to create an empty string for a null string, jsString() handle both
cases as empty JSString.

* runtime/JSArray.cpp:
(JSC::reject):
(JSC::SparseArrayValueMap::put):
(JSC::JSArray::put):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
* runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation): Same issue as InternalFunction::finishCreation.

(JSC::JSFunction::callerGetter):
(JSC::JSFunction::defineOwnProperty):
* runtime/JSGlobalData.cpp:
(JSC::enableAssembler): Use CFSTR() instead of CFStringCreateWithCString().
CFStringCreateWithCString() copy the content and may choose to decode the data.
CFSTR() is much more efficient.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
JSFunction uses jsString() to create the name, we can use null strings instead
of creating empty strings.

(JSC::JSGlobalObject::createThrowTypeError): ditto.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEval):
* runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::defaultValue):
(JSC::JSObject::hasInstance):
(JSC::JSObject::defineOwnProperty):
* runtime/JSString.cpp:
Return an empty JSString to avoid the creation of a temporary empty String.

(JSC::JSRopeString::getIndexSlowCase):
* runtime/JSString.h:
(JSC): Remove the versions of jsNontrivialString() taking a char*. All the callers
have been replaced by calls using ASCIILiteral.

* runtime/JSValue.cpp:
(JSC::JSValue::putToPrimitive):
* runtime/LiteralParser.cpp:
(JSC::::Lexer::lex):
(JSC::::Lexer::lexString):
(JSC::::Lexer::lexNumber):
(JSC::::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::getErrorMessage):
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
(JSC::objectConstructorIsExtensible):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncToString):
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
* runtime/RegExpObject.cpp:
(JSC::reject):
(JSC::regExpObjectSource):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
* runtime/StringObject.cpp:
(JSC::StringObject::defineOwnProperty):
* runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95717

Reviewed by Oliver Hunt.

Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!

* bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
https://bugs.webkit.org/show_bug.cgi?id=95778
PR #202252

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Arvid Nilsson.

Upstream has switch away from using the parent scroll layer's bounds origin
in order to translate contents of all its child layers. Instead now, it directly
sets the scroll position of the child scrollable contents layer.

Source/WebCore:

No new tests, since it is a catch-up with upstreaming code.

Source/WebCore:
* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::updateAnimations):
* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerOverride::LayerOverride):
(LayerOverride):
* platform/graphics/blackberry/LayerData.h:
(LayerData):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::updateLayersRecursive):
* platform/graphics/blackberry/LayerWebKitThread.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Source/WebKit/blackberry:

Source/WebKit/blackberry:
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

No new tests, since it is a catch-up with upstreaming code.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95734

Reviewed by Adam Barth.

Source/Platform:

* Platform.gypi:
* chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
* chromium/public/WebRTCSessionDescriptionDescriptor.h: Added.
(WebCore):
(WebKit):
(WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::~WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::operator=):
(WebKit::WebRTCSessionDescriptionDescriptor::isNull):
* chromium/public/WebRTCSessionDescriptionRequest.h: Added.
(WebCore):
(WebKit):
(WebRTCSessionDescriptionRequest):
(ExtraData):
(WebKit::WebRTCSessionDescriptionRequest::ExtraData::~ExtraData):
(WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::~WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::operator=):
(WebKit::WebRTCSessionDescriptionRequest::isNull):

Source/WebCore:

createOffer sends a request to the platform implementer requesting it to gather up all candidates.
This can take some time, therefore the request is async.

Test: fast/mediastream/RTCPeerConnection-createOffer.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/RTCErrorCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
(WebCore):
(RTCErrorCallback):
(WebCore::RTCErrorCallback::~RTCErrorCallback):
* Modules/mediastream/RTCErrorCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createOffer):
(WebCore):
* Modules/mediastream/RTCPeerConnection.h:
(WebCore):
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCSessionDescriptionCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
(WebCore):
(RTCSessionDescriptionCallback):
(WebCore::RTCSessionDescriptionCallback::~RTCSessionDescriptionCallback):
* Modules/mediastream/RTCSessionDescriptionCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
* Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp: Added.
(WebCore):
(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::stop):
(WebCore::RTCSessionDescriptionRequestImpl::clear):
* Modules/mediastream/RTCSessionDescriptionRequestImpl.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
(WebCore):
(RTCSessionDescriptionRequestImpl):
* WebCore.gypi:
* platform/chromium/support/WebRTCSessionDescriptionDescriptor.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.
(WebKit):
(WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::assign):
(WebKit::WebRTCSessionDescriptionDescriptor::reset):
(WebKit::WebRTCSessionDescriptionDescriptor::operator WTF::PassRefPtr<WebCore::RTCSessionDescriptionDescriptor>):
(WebKit::WebRTCSessionDescriptionDescriptor::initialize):
(WebKit::WebRTCSessionDescriptionDescriptor::type):
(WebKit::WebRTCSessionDescriptionDescriptor::setType):
(WebKit::WebRTCSessionDescriptionDescriptor::sdp):
(WebKit::WebRTCSessionDescriptionDescriptor::setSDP):
* platform/chromium/support/WebRTCSessionDescriptionRequest.cpp: Added.
(WebKit):
(WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::assign):
(WebKit::WebRTCSessionDescriptionRequest::reset):
(WebKit::WebRTCSessionDescriptionRequest::requestSucceeded):
(WebKit::WebRTCSessionDescriptionRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCSessionDescriptionRequest::extraData):
(WebKit::WebRTCSessionDescriptionRequest::setExtraData):
* platform/mediastream/RTCPeerConnectionHandler.cpp:
(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::createOffer):
(WebCore):
* platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
* platform/mediastream/RTCSessionDescriptionDescriptor.h:
(WebCore::RTCSessionDescriptionDescriptor::type):
(WebCore::RTCSessionDescriptionDescriptor::sdp):
* platform/mediastream/RTCSessionDescriptionRequest.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
(WebCore):
(RTCSessionDescriptionRequest):
(ExtraData):
(WebCore::RTCSessionDescriptionRequest::ExtraData::~ExtraData):
(WebCore::RTCSessionDescriptionRequest::~RTCSessionDescriptionRequest):
(WebCore::RTCSessionDescriptionRequest::extraData):
(WebCore::RTCSessionDescriptionRequest::setExtraData):
(WebCore::RTCSessionDescriptionRequest::RTCSessionDescriptionRequest):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::createOffer):
(WebCore):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):

Tools:

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::createOffer):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::taskList):
(SuccessCallbackTask):
(FailureCallbackTask):

LayoutTests:

* fast/mediastream/RTCPeerConnection-createOffer-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-createOffer.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

an assertion failure in Document::updateStyleIfNeeded().

Source/WebCore: 

* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests: 

* inspector/styles/protocol-css-regions-commands-expected.txt:
* inspector/styles/protocol-css-regions-commands.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95754

Reviewed by Dave Hyatt.

Source/WebCore:

It's possible to have a renderer with position:fixed or sticky style,
but no layer, for example a RenderScrollBarPart. Don't register such
renderers with the FrameView.

Moved the code that registers/unregisters with the FrameView from
styleWillChange() to styleDidChange(), since in the latter case
we can check if we have a RenderLayer. Only register renderers with layers.
We always unregister, which required removing an assertion in
FrameView::removeFixedObject(), and replacing it with a null check of m_fixedObjects.

Test: fast/css/remove-fixed-resizer-crash.html

* page/FrameView.cpp:
(WebCore::FrameView::removeFixedObject):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleWillChange):
(WebCore::RenderBoxModelObject::styleDidChange):

LayoutTests:

Testcase with a position:fixed resizer and scrolling.

* fast/css/remove-fixed-resizer-crash-expected.txt: Added.
* fast/css/remove-fixed-resizer-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95755

Reviewed by Alexey Proskuryakov.

Adding a property to check whether this ResourceError was raised due to a timeout.
This is preparatory work for bug 74802. In order to implement XHR2 timeout functionality,
I need to identify some layers up whether the original network problem has been a timeout.

No new tests, no change in behavior yet.

* platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::copy): Copying new member.
(WebCore::ResourceErrorBase::compare): Comparing new member.
* platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::setIsTimeout): New setter.
(WebCore::ResourceErrorBase::isTimeout): New getter.
(ResourceErrorBase),
(WebCore::ResourceErrorBase::ResourceErrorBase): Adding m_isTimeout member.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95529

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-09-04
Reviewed by Adam Barth.

Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it.

* public/WebViewClient.h:
(WebKit::WebViewClient::didTapMultipleTargets):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
* tests/WebFrameTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95771

Reviewed by Rob Buis.

Simply delete the arrays at function exit.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/win/accessibility/canvas-description-and-role-expected.txt: Removed property svn:executable.
* platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed property svn:executable.
* platform/win/fast/css/image-resolution/image-resolution-expected.txt: Removed property svn:executable.
* platform/win/fast/css/image-set-setting-expected.txt: Removed property svn:executable.
* platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Removed property svn:executable.
* platform/win/fast/css/variables/build-supports-variables-expected.txt: Removed property svn:executable.
* platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Removed property svn:executable.
* platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Removed property svn:executable.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95766

Reviewed by Rob Buis.

Passing the frame status through will allow the client to make better
decisions about how to act on the onload.

* Api/WebPageClient.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95768

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95741

Patch by Pekka Vuorela <pvuorela@iki.fi> on 2012-09-04
Reviewed by Simon Hausmann.

Adapt from deprecated QInputMethod::visible() to isVisible().

* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::setInputPanelVisible):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95769

Reviewed by NOBODY (OOPS!).

Also remove WTF prefixes.

* Api/DumpRenderTreeClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95721

Reviewed by Adam Barth.

Source/Platform:

Adding the signaling to the WebKit interface.

* chromium/public/WebMediaStreamCenter.h:
(WebKit::WebMediaStreamCenter::didAddMediaStreamTrack):
(WebKit::WebMediaStreamCenter::didRemoveMediaStreamTrack):

Source/WebCore:

This allows the platform implementor to throw an NOT_SUPPORTED_ERR exception if it doesn support these methods.

Patch covered by expanded existing test.

* Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):
* platform/mediastream/MediaStreamCenter.h:
(MediaStreamCenter):
* platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
(WebCore::MediaStreamCenterBlackBerry::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterBlackBerry::didRemoveMediaStreamTrack):
* platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
(MediaStreamCenterBlackBerry):
* platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenterChromium::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::didRemoveMediaStreamTrack):
* platform/mediastream/chromium/MediaStreamCenterChromium.h:
(MediaStreamCenterChromium):
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
(WebCore::MediaStreamCenterGStreamer::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterGStreamer::didRemoveMediaStreamTrack):
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
(MediaStreamCenterGStreamer):

Tools:

* DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
(MockWebMediaStreamCenter::didAddMediaStreamTrack):
(MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
* DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
(MockWebMediaStreamCenter):

LayoutTests:

* fast/mediastream/MediaStreamTrackList.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95737

Reviewed by Eric Seidel.

Add WTF_MAKE_FAST_ALLOCATED macro to the following class declarations because these are instantiated by operator new.

Source/JavaScriptCore:

* wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.

* heap/MachineStackMarker.cpp:
(MachineThreads::Thread): Thread is instantiated at heap/MachineStackMarker.cpp:196.
* jit/ExecutableAllocatorFixedVMPool.cpp:
(FixedVMPoolExecutableAllocator): FixedVMPoolExecutableAllocator is instantiated at jit/ExecutableAllocatorFixedVMPool.cpp:111
* parser/SourceProviderCache.h:
(SourceProviderCache): SourceProviderCache is instantiated at parser/SourceProvider.h:49.
* parser/SourceProviderCacheItem.h:
(SourceProviderCacheItem): SourceProviderCacheItem is instantiated at parser/Parser.cpp:843.
* runtime/GCActivityCallback.h:
(GCActivityCallback): GCActivityCallback is instantiated at runtime/GCActivityCallback.h:96.
* tools/CodeProfile.h:
(CodeProfile): CodeProfile is instantiated at JavaScriptCore/tools/CodeProfiling.cpp:140.

Source/WTF:

* wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
* wtf/MediaTime.h: MediaTime is instantiated at wtf/MediaTime.cpp:288.
* wtf/MetaAllocator.h:
(MetaAllocatorTracker): MetaAllocatorTracker is instantiated at JavaScriptCore/tools/CodeProfiling.cpp:120.
* wtf/ThreadingPthreads.cpp:
(PthreadState): PthreadState is instantiated at wtf/ThreadingPthreads.cpp:165.
* wtf/text/AtomicString.cpp:
(AtomicStringTable): AtomicStringTable is instantiated at wtf/text/AtomicString.cpp:43.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95740

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Added sanity check to be sure we have a render object prior to seeing if
said object is an anonymous block.

Testing via unit test because a non-flaky layout test crasher could not
be found.

* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Sanity check for render object added.

Source/WebKit/gtk:

Updated unit test.

* tests/testatk.c:
(testWebkitAtkComboBox): Added checks that the menu popup in a combo box
has 0 links and, more importantly, that checking doesn't result in a crash.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95626

Patch by Tony Chang <tony@chromium.org> on 2012-09-04
Reviewed by Dirk Pranke.

When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.

* Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(test_test_status_line): Test for _test_status_line.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127482 268f45cc-cd09-0410-ab3c-d52691b4dbfc