1. 24 Feb, 2012 10 commits
    • ddkilzer@apple.com's avatar
      Use xcrun to find compiler paths for Generate Derived Sources build phase script · 4e8d565a
      ddkilzer@apple.com authored
      <http://webkit.org/b/79512>
      
      Reviewed by Dan Bernstein.
      
      * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
      (Generate Derived Sources): Use xcrun to find the path to the
      compiler since that works on both iOS and OS X.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e8d565a
    • jamesr@google.com's avatar
      Create a watchlist for ScrollingCoordinator changes · 227397f0
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=79511
      
      Reviewed by Anders Carlsson.
      
      * Scripts/webkitpy/common/config/watchlist:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      227397f0
    • commit-queue@webkit.org's avatar
      [EFL][DRT] Implement setValueForUser and setAutofilled. · 168fbb88
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79237
      
      Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-02-24
      Reviewed by Andreas Kling.
      
      Source/WebKit:
      
      Adds the main directory of WebKit's source to find headers of JavaScriptCore.
      
      * PlatformEfl.cmake:
      
      Source/WebKit/efl:
      
      Adds missing implementation setValueForUser and setAutofilled to EFL's DumpRenderTreeSupport.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::setValueForUser):
      (DumpRenderTreeSupportEfl::setAutofilled):
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      
      Tools:
      
      Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
      Those implementations are related with input fields and allow to pass following tests:
      fast/forms/onchange-setvalueforuser.html
      fast/forms/input-autofilled.html
      fast/forms/reset-autofilled.html
      
      * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
      (LayoutTestController::setValueForUser):
      (LayoutTestController::setAutofilled):
      
      LayoutTests:
      
      Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
      Those implementations are related with input fields and allow to pass following tests:
      fast/forms/onchange-setvalueforuser.html
      fast/forms/input-autofilled.html
      fast/forms/reset-autofilled.html
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      168fbb88
    • zoltan@webkit.org's avatar
      [Qt] Allow to use WebCore imagedecoders · cdb61061
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=32410
      
      Source/WebCore:
      
      Add ENABLE(QT_IMAGE_DECODER) guards around Qt imagedecoders and set it to default.
      By passing ENABLE_QT_IMAGE_DECODER=0 define to the build system, WebKit will build
      with WebCore's imagedecoders.
      
      I added NO_RETURN attribute and PLATFORM(QT) conditionals to 2 functions of PNG and
      JPEG decoders to avoid compiler warnings because in Qt-port we treat warning as errors (-Werror).
      
      I'm continuing the refactoring of this area and try to use Qt imagedecoders only in
      cases when WebCore doesn't support the image format.
      
      Reviewed by Simon Hausmann.
      
      No behavior change, no need new tests.
      
      * Target.pri:
      * WebCore.pri:
      * platform/MIMETypeRegistry.cpp:
      (WebCore::initializeSupportedImageMIMETypes):
      (WebCore::initializeSupportedImageMIMETypesForEncoding):
      * platform/image-decoders/ImageDecoder.h:
      (WebCore::ImageFrame::getAddr):
      (ImageFrame):
      * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
      NO_RETURN has been added to a function to avoid warning message.
      * platform/image-decoders/png/PNGImageDecoder.cpp:
      NO_RETURN has been added to a function to avoid warning message.
      (WebCore):
      * platform/image-decoders/qt/ImageFrameQt.cpp:
      (WebCore):
      (WebCore::ImageFrame::asNewNativeImage):
      
      Tools:
      
      Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
      
      Reviewed by Simon Hausmann.
      
      * qmake/mkspecs/features/features.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdb61061
    • kbalazs@webkit.org's avatar
      [Qt] Add Qt5 way to force 96 DPI for tests · 49f42257
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79364
      
      Reviewed by Simon Hausmann.
      
      * DumpRenderTree/qt/main.cpp:
      (main):
      * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
      (WTR::activateFonts):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49f42257
    • carlosgc@webkit.org's avatar
      [GTK] MiniBrowser should reload the view then the reload button is clicked · 6c7b62b5
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79472
      
      Reviewed by Philippe Normand.
      
      * MiniBrowser/gtk/BrowserWindow.c:
      (reloadCallback): Call webkit_web_view_reload().
      (browser_window_init): Connect reload item clicked even to
      reloadCallback instead of activateUriEntryCallback.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c7b62b5
    • haraken@chromium.org's avatar
      Add performance tests for DOM attribute getters and setters · 0b2c275c
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79208
      
      Reviewed by Ryosuke Niwa.
      
      PerformanceTests:
      
      This patch adds performance micro-benchmarks for DOM attribute
      getters and setters. We selected DOM attributes from HTMLElement,
      Element and Node which will most impact on the DOM performance
      in the real Web and which have different call-paths from another
      DOM attribute.
      
      The perf test result in my local Chromium/Linux environment is as follows:
      median= 14967.0 ms, stdev= 85.2385476178 ms, min= 14861.0 ms, max= 15155.0 ms
      
      If we run the test with DumpRenderTree, we can get the following test results:
      Info: [HTMLElement.id] avg=65.76ms, median=65.00ms, stdev=2.14ms, min=63, max=70
      Info: [HTMLElement.title] avg=64.05ms, median=63.00ms, stdev=1.50ms, min=63, max=67
      Info: [HTMLElement.lang] avg=64.19ms, median=63.00ms, stdev=1.82ms, min=62, max=67
      Info: [HTMLElement.dir] avg=64.10ms, median=63.00ms, stdev=1.72ms, min=62, max=68
      Info: [HTMLElement.className] avg=63.33ms, median=63.00ms, stdev=0.89ms, min=63, max=67
      Info: [HTMLElement.classList] avg=1946.00ms, median=1945.00ms, stdev=38.22ms, min=1921, max=2110
      Info: [HTMLElement.tabIndex] avg=83.52ms, median=80.00ms, stdev=6.00ms, min=79, max=94
      Info: [HTMLElement.draggable] avg=78.14ms, median=81.00ms, stdev=3.51ms, min=74, max=82
      Info: [HTMLElement.webkitdropzone] avg=64.33ms, median=63.00ms, stdev=1.98ms, min=63, max=68
      Info: [HTMLElement.hidden] avg=65.57ms, median=64.00ms, stdev=3.27ms, min=63, max=71
      Info: [HTMLElement.accessKey] avg=64.43ms, median=63.00ms, stdev=2.11ms, min=62, max=68
      Info: [HTMLElement.children] avg=130.76ms, median=128.00ms, stdev=9.75ms, min=109, max=143
      Info: [HTMLElement.isContentEditable] avg=74.29ms, median=75.00ms, stdev=2.00ms, min=71, max=77
      Info: [HTMLElement.spellcheck] avg=79.52ms, median=80.00ms, stdev=2.52ms, min=76, max=82
      Info: [HTMLElement.innerHTML] avg=279.05ms, median=279.00ms, stdev=1.96ms, min=276, max=283
      Info: [HTMLElement.innerText] avg=204.14ms, median=203.00ms, stdev=2.95ms, min=200, max=210
      Info: [HTMLElement.outerHTML] avg=1544.10ms, median=1546.00ms, stdev=15.56ms, min=1514, max=1568
      Info: [HTMLElement.outerText] avg=216.05ms, median=207.00ms, stdev=18.19ms, min=201, max=247
      Info: [HTMLElement.contentEditable] avg=334.24ms, median=323.00ms, stdev=36.06ms, min=318, max=446
      Info: [HTMLElement.id="foo"] avg=53.19ms, median=53.00ms, stdev=1.76ms, min=52, max=58
      Info: [HTMLElement.title="foo"] avg=63.14ms, median=63.00ms, stdev=0.35ms, min=63, max=64
      Info: [HTMLElement.lang="foo"] avg=60.86ms, median=61.00ms, stdev=0.56ms, min=60, max=62
      Info: [HTMLElement.dir="foo"] avg=53.57ms, median=54.00ms, stdev=0.58ms, min=53, max=55
      Info: [HTMLElement.className="foo"] avg=64.52ms, median=64.00ms, stdev=0.91ms, min=63, max=66
      Info: [HTMLElement.tabIndex="foo"] avg=367.86ms, median=369.00ms, stdev=8.06ms, min=352, max=380
      Info: [HTMLElement.draggable="foo"] avg=79.43ms, median=79.00ms, stdev=0.58ms, min=79, max=81
      Info: [HTMLElement.webkitdropzone="foo"] avg=62.14ms, median=62.00ms, stdev=0.35ms, min=62, max=63
      Info: [HTMLElement.hidden="foo"] avg=61.67ms, median=62.00ms, stdev=0.71ms, min=61, max=64
      Info: [HTMLElement.accessKey="foo"] avg=61.86ms, median=62.00ms, stdev=0.56ms, min=61, max=63
      Info: [HTMLElement.spellcheck="foo"] avg=79.57ms, median=80.00ms, stdev=0.58ms, min=78, max=80
      Info: [HTMLElement.innerHTML="foo"] avg=1176.67ms, median=1169.00ms, stdev=26.60ms, min=1146, max=1246
      Info: [HTMLElement.innerText="foo"] avg=51.62ms, median=52.00ms, stdev=0.72ms, min=50, max=53
      Info: [Element.tagName] avg=79.52ms, median=80.00ms, stdev=1.05ms, min=78, max=81
      Info: [Element.style] avg=126.19ms, median=126.00ms, stdev=10.40ms, min=104, max=161
      Info: [Element.offsetLeft] avg=98.95ms, median=104.00ms, stdev=4.01ms, min=100, max=99
      Info: [Element.clientLeft] avg=98.33ms, median=102.00ms, stdev=2.59ms, min=100, max=99
      Info: [Element.scrollLeft] avg=103.29ms, median=96.00ms, stdev=15.63ms, min=100, max=97
      Info: [Element.dataset] avg=2448.62ms, median=2441.00ms, stdev=20.43ms, min=2426, max=2503
      Info: [Element.firstElementChild] avg=58.71ms, median=58.00ms, stdev=2.37ms, min=57, max=65
      Info: [Element.lastElementChild] avg=56.33ms, median=55.00ms, stdev=1.83ms, min=54, max=59
      Info: [Element.previousElementSibling] avg=52.95ms, median=52.00ms, stdev=1.70ms, min=52, max=57
      Info: [Element.nextElementSibling] avg=58.48ms, median=58.00ms, stdev=1.79ms, min=57, max=63
      Info: [Element.childElementCount] avg=64.57ms, median=64.00ms, stdev=1.81ms, min=63, max=71
      Info: [Element.onload] avg=98.38ms, median=98.00ms, stdev=0.49ms, min=98, max=99
      Info: [Element.scrollLeft="foo"] avg=95.24ms, median=95.00ms, stdev=0.92ms, min=94, max=98
      Info: [Element.onload="foo"] avg=67.14ms, median=67.00ms, stdev=0.56ms, min=66, max=68
      Info: [Node.nodeName] avg=76.29ms, median=76.00ms, stdev=0.63ms, min=75, max=77
      Info: [Node.nodeType] avg=53.05ms, median=52.00ms, stdev=2.61ms, min=52, max=61
      Info: [Node.parentNode] avg=53.52ms, median=53.00ms, stdev=1.22ms, min=52, max=56
      Info: [Node.childNodes] avg=118.33ms, median=123.00ms, stdev=8.85ms, min=107, max=129
      Info: [Node.firstChild] avg=53.62ms, median=53.00ms, stdev=1.13ms, min=51, max=55
      Info: [Node.lastChild] avg=53.14ms, median=53.00ms, stdev=1.21ms, min=52, max=55
      Info: [Node.previousSibling] avg=51.86ms, median=51.00ms, stdev=1.55ms, min=50, max=54
      Info: [Node.nextSibling] avg=52.86ms, median=54.00ms, stdev=1.81ms, min=50, max=55
      Info: [Node.attributes] avg=2027.71ms, median=2026.00ms, stdev=10.48ms, min=2010, max=2051
      Info: [Node.ownerDocument] avg=152.14ms, median=152.00ms, stdev=1.73ms, min=149, max=155
      Info: [Node.namespaceURI] avg=60.86ms, median=59.00ms, stdev=3.85ms, min=56, max=66
      Info: [Node.localName] avg=60.00ms, median=59.00ms, stdev=2.71ms, min=57, max=66
      Info: [Node.baseURI] avg=671.10ms, median=668.00ms, stdev=10.66ms, min=659, max=706
      Info: [Node.parentElement] avg=55.05ms, median=56.00ms, stdev=2.15ms, min=52, max=58
      Info: [Node.nodeValue] avg=61.24ms, median=60.00ms, stdev=2.56ms, min=59, max=68
      Info: [Node.prefix] avg=60.90ms, median=58.00ms, stdev=4.26ms, min=57, max=68
      Info: [Node.textContent] avg=149.71ms, median=149.00ms, stdev=1.12ms, min=148, max=152
      Info: [Node.nodeValue="foo"] avg=23.62ms, median=23.00ms, stdev=0.72ms, min=23, max=25
      Info: [Node.prefix="foo"] avg=49.57ms, median=49.00ms, stdev=0.73ms, min=49, max=51
      Info: [Node.textContent="foo"] avg=145.81ms, median=140.00ms, stdev=17.43ms, min=138, max=199
      
      * Bindings/dom_attributes.html: Added.
      * resources/runner.js:
      (PerfTestRunner.info):
      
      Tools:
      
      We want to allow perf tests to output info messages
      that do not affect the test results. To accomplish this,
      this patch modifies perftestsrunner.py so that it ignores
      a line that starts from "Info:".
      
      * Scripts/webkitpy/performance_tests/perftestsrunner.py:
      (PerfTestsRunner):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b2c275c
    • commit-queue@webkit.org's avatar
      [BlackBerry] Enable requestAnimationFrame · c147536c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79408
      
      Source/JavaScriptCore:
      
      Use timer implementation of requestAnimationFrame on BlackBerry.
      
      Patch by Andrew Lo <anlo@rim.com> on 2012-02-24
      Reviewed by Rob Buis.
      
      * wtf/Platform.h:
      
      Tools:
      
      Enable requestAnimationFrame for BlackBerry.
      
      Patch by Andrew Lo <anlo@rim.com> on 2012-02-24
      Reviewed by Rob Buis.
      
      * Scripts/build-webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c147536c
    • abarth@webkit.org's avatar
      style-queue tries to apply the patch twice · 6cd15aff
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79459
      
      Reviewed by Eric Seidel.
      
      Previously, we applied the patch using both apply-patch and
      check-style.  This patch introduces a check-style-local to mirror the
      apply-watchlist-local, which operates on the current working diff.
      
      This patch also cleans up some other bugs I found by running the queue
      locally for a while.  The queue still prints out a slightly
      less-than-ideal message on the bugs when it find an error, but it's ok
      for now.  We'll need to iterate a bit.
      
      * Scripts/webkitpy/tool/bot/stylequeuetask.py:
      (StyleQueueTask.validate):
      (StyleQueueTask._check_style):
      * Scripts/webkitpy/tool/commands/download.py:
      (CheckStyleLocal):
      * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
      (EarlyWarningSytemTest._default_expected_stderr):
      (EarlyWarningSytemTest._test_testing_ews):
      * Scripts/webkitpy/tool/commands/queues.py:
      (AbstractReviewQueue.handle_script_error):
      (StyleQueue.review_patch):
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      * Scripts/webkitpy/tool/commands/queuestest.py:
      (QueuesTest.assert_queue_outputs):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cd15aff
    • abarth@webkit.org's avatar
      should_proceed_with_work_item is unused and can be removed · a6851017
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79416
      
      Reviewed by Eric Seidel.
      
      We used to use this function to check whether the tree is red.  Now, we
      don't use external measures of whether to proceed with work items.
      Instead, we analyze them with the idea in mind that the tree might be
      red.
      
      * Scripts/webkitpy/tool/bot/queueengine.py:
      (QueueEngineDelegate.next_work_item):
      (QueueEngine.run):
      * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
      (LoggingDelegate):
      (LoggingDelegate.next_work_item):
      (RaisingDelegate.process_work_item):
      (QueueEngineTest.test_terminating_error):
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      (AbstractEarlyWarningSystem.__init__):
      * Scripts/webkitpy/tool/commands/queues.py:
      (AbstractQueue.next_work_item):
      (FeederQueue.next_work_item):
      (CommitQueue.next_work_item):
      (AbstractReviewQueue.next_work_item):
      (StyleQueue.__init__):
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      (FeederQueueTest.test_feeder_queue):
      (CommitQueueTest.test_commit_queue):
      (test_commit_queue_failure):
      (test_commit_queue_failure_with_failing_tests):
      (test_rollout):
      (test_rollout_lands):
      (StyleQueueTest.test_style_queue_with_style_exception):
      (test_style_queue_with_watch_list_exception):
      * Scripts/webkitpy/tool/commands/queuestest.py:
      (QueuesTest.assert_queue_outputs):
      * Scripts/webkitpy/tool/commands/sheriffbot.py:
      (SheriffBot.next_work_item):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6851017
  2. 23 Feb, 2012 15 commits
    • enne@google.com's avatar
      Unreviewed, add Stephen Chenney to committers.py as a contributor. · 42a97679
      enne@google.com authored
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42a97679
    • abarth@webkit.org's avatar
      style-queue logs bogus messages to the QueueStatusServer · a5e4288f
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79424
      
      Reviewed by Eric Seidel.
      
      Copy/paste error.
      
      * Scripts/webkitpy/tool/bot/stylequeuetask.py:
      (StyleQueueTask._check_style):
      (StyleQueueTask._apply_watch_list):
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5e4288f
    • eric@webkit.org's avatar
      Use self._filesystem in more places in the SCM classes · 8f382f0d
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79415
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
      (SCMDetectorTest.test_detect_scm_system):
      * Scripts/webkitpy/common/checkout/scm/git.py:
      (Git.find_checkout_root):
      (Git.to_object_name):
      * Scripts/webkitpy/common/checkout/scm/scm.py:
      (SCM.__init__):
      (SCM.in_working_directory):
      * Scripts/webkitpy/common/checkout/scm/svn.py:
      (SVN.find_uuid):
      (SVN.find_checkout_root):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f382f0d
    • enne@google.com's avatar
      Unreviewed, rolling out r108685. · 5c7cd8f0
      enne@google.com authored
      http://trac.webkit.org/changeset/108685
      https://bugs.webkit.org/show_bug.cgi?id=79414
      
      Broke Chromium builds (Requested by enne on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23
      
      Source/WebCore:
      
      * Target.pri:
      * WebCore.pri:
      * platform/MIMETypeRegistry.cpp:
      (WebCore::initializeSupportedImageMIMETypes):
      (WebCore::initializeSupportedImageMIMETypesForEncoding):
      * platform/image-decoders/ImageDecoder.h:
      (WebCore::ImageFrame::getAddr):
      (ImageFrame):
      * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
      * platform/image-decoders/png/PNGImageDecoder.cpp:
      (WebCore):
      * platform/image-decoders/qt/ImageFrameQt.cpp:
      
      Tools:
      
      * qmake/mkspecs/features/features.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c7cd8f0
    • abarth@webkit.org's avatar
      style-queue shouldn't spam bugs if it fails to update its working copy · 6ffd4b65
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79412
      
      Reviewed by Eric Seidel.
      
      This patch moves style-queue over to the new PatchAnalysisTask
      infrastructure, which is smarter about retrying patches when update
      fails.
      
      * Scripts/webkitpy/common/system/executive_mock.py:
      (MockExecutive.run_and_throw_if_fail):
      * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
      * Scripts/webkitpy/tool/bot/patchanalysistask.py:
      (UnableToApplyPatch):
      (UnableToApplyPatch.__init__):
      (PatchAnalysisTask.__init__):
      * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
      (StyleQueueTaskDelegate):
      (StyleQueueTaskDelegate.parent_command):
      (StyleQueueTask):
      (StyleQueueTask.validate):
      (StyleQueueTask._check_style):
      (StyleQueueTask._apply_watch_list):
      (StyleQueueTask.run):
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      * Scripts/webkitpy/tool/commands/queues.py:
      (StyleQueue):
      (StyleQueue.should_proceed_with_work_item):
      (StyleQueue.review_patch):
      (StyleQueue.run_command):
      (StyleQueue.command_passed):
      (StyleQueue.command_failed):
      (StyleQueue.expected_failures):
      (StyleQueue.refetch_patch):
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      (StyleQueueTest.test_style_queue_with_style_exception):
      (test_style_queue_with_watch_list_exception):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ffd4b65
    • zoltan@webkit.org's avatar
      [Qt] Allow to use WebCore imagedecoders · 3e7e2a34
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=32410
      
      Source/WebCore:
      
      Add ENABLE(QT_IMAGE_DECODER) guards around Qt imagedecoders and set it to default.
      By passing ENABLE_QT_IMAGE_DECODER=0 define to the build system WebKit will build
      with WebCore's imagedecoders.
      
      I added NO_RETURN attribute to 2 functions of PNG and JPEG decoders to avoid compiler warnings
      because in Qt-port we treat warning as errors (-Werror).
      
      I'm continuing the refactoring of this area and try to use Qt imagedecoders only in
      cases when WebCore doesn't support the image format.
      
      Reviewed by Simon Hausmann.
      
      No behavior change, no need new tests.
      
      * Target.pri:
      * WebCore.pri:
      * platform/MIMETypeRegistry.cpp:
      (WebCore::initializeSupportedImageMIMETypes):
      (WebCore::initializeSupportedImageMIMETypesForEncoding):
      * platform/image-decoders/ImageDecoder.h:
      (WebCore::ImageFrame::getAddr):
      (ImageFrame):
      * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
      NO_RETURN has been added to a function to avoid warning message.
      * platform/image-decoders/png/PNGImageDecoder.cpp:
      NO_RETURN has been added to a function to avoid warning message.
      (WebCore):
      * platform/image-decoders/qt/ImageFrameQt.cpp:
      (WebCore):
      (WebCore::ImageFrame::asNewNativeImage):
      
      Tools:
      
      Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
      
      Reviewed by Simon Hausmann.
      
      * qmake/mkspecs/features/features.prf:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e7e2a34
    • eric@webkit.org's avatar
      Remove old broken find_checkout_root tests now that find_checkout_root is gone · 1e39bcfe
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79405
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
      (SCMDetectorTest):
      (SCMDetectorTest.test_find_checkout_root):
      * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
      (SVNTestRepository.tear_down):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e39bcfe
    • commit-queue@webkit.org's avatar
      [Qt][WK2] Implement proxy authentication dialog. · d4f332ff
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79350
      
      Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-23
      Reviewed by Simon Hausmann.
      
      * MiniBrowser/qt/MiniBrowser.qrc:
      * MiniBrowser/qt/qml/BrowserWindow.qml:
      * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4f332ff
    • kevino@webkit.org's avatar
      49cdbee8
    • hausmann@webkit.org's avatar
      [Qt] Add support for touch cancellation · e443c49d
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79348
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Map Qt touch cancel events to the WebCore equivalent.
      
      No new tests, unskipped existing test for Qt 5.
      
      * platform/PlatformTouchPoint.h:
      (PlatformTouchPoint):
      * platform/qt/PlatformTouchEventQt.cpp:
      (WebCore::PlatformTouchEvent::PlatformTouchEvent):
      * platform/qt/PlatformTouchPointQt.cpp:
      (WebCore::PlatformTouchPoint::PlatformTouchPoint):
      
      Source/WebKit/qt:
      
      Forward incoming touch cancellation events to the WebCore
      event handler.
      
      * Api/qgraphicswebview.cpp:
      (QGraphicsWebView::sceneEvent):
      * Api/qwebpage.cpp:
      (QWebPage::event):
      * Api/qwebview.cpp:
      (QWebView::event):
      
      Source/WebKit2:
      
      Convert and forward incoming touch cancellation events
      to the web process.
      
      * Shared/qt/WebEventFactoryQt.cpp:
      (WebKit::webEventTypeForEvent):
      (WebKit::WebEventFactory::createWebTouchEvent):
      * UIProcess/API/qt/qquickwebview.cpp:
      (QQuickWebView::event):
      * UIProcess/qt/QtWebPageEventHandler.cpp:
      (QtWebPageEventHandler::handleEvent):
      
      Tools:
      
      Added straight-forward touch cancellation event sending to Qt WK1 DRT
      and WK2 WTR.
      
      * DumpRenderTree/qt/EventSenderQt.cpp:
      (EventSender::touchCancel):
      (EventSender::cancelTouchPoint):
      * DumpRenderTree/qt/EventSenderQt.h:
      (EventSender):
      * WebKitTestRunner/EventSenderProxy.h:
      (EventSenderProxy):
      * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
      * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
      (WTR::EventSendingController::touchCancel):
      (WTR):
      (WTR::EventSendingController::cancelTouchPoint):
      * WebKitTestRunner/InjectedBundle/EventSendingController.h:
      (EventSendingController):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
      * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
      (WTR::EventSenderProxy::touchCancel):
      (WTR):
      (WTR::EventSenderProxy::cancelTouchPoint):
      
      LayoutTests:
      
      Moved touch cancel event layout tests from general skip list to the
      Qt 4 specific one. The Qt 5 version we depend on has QEvent::TouchCancel, which
      is all we need in order to implement touch cancellation in DRT/WTR.
      
      * platform/qt-4.8/Skipped:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e443c49d
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r108626. · d8fb62e9
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/108626
      https://bugs.webkit.org/show_bug.cgi?id=79370
      
      broke qt-wk2 bot, somehow the workaround does not work on the
      bot (Requested by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23
      
      * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
      (WTR::WrapperWindow::handleStatusChanged):
      (WTR::PlatformWebView::resizeTo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8fb62e9
    • commit-queue@webkit.org's avatar
      [GTK] DRT doesn't support scheduleAsynchronousKeyDown. · 2e8aa8c5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78481
      
      Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-23
      Reviewed by Gustavo Noronha Silva.
      
      Source/WebKit/gtk:
      
      Added a new API to deliver all mutations explicitly.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      (DumpRenderTreeSupportGtk):
      
      Tools:
      
      Extracted shareable code from keyDownCallback and then added createKeyPressEvent
      to create gdk press key event.
      Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
      and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
      
      * DumpRenderTree/gtk/EventSender.cpp:
      (scheduleAsynchronousClickCallback):
      (createKeyPressEvent):
      (sendKeyDown):
      (keyDownCallback):
      (sendAsynchronousKeyDown):
      (scheduleAsynchronousKeyDownCallback):
      
      LayoutTests:
      
      Removed following skipped tests.
      fast/mutation/end-of-task-delivery.html
      fast/mutation/inline-event-listener.html
      
      * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e8aa8c5
    • kbalazs@webkit.org's avatar
      [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests · 67c1ce17
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76546
      
      Reviewed by Simon Hausmann.
      
      Co-authored with Simon Hausmann.
      
      Revert the workaround introduced in r107868 and reintroduce
      the qml binding so we can test the code path that we are more
      interested in. The reason that it did not work before is that
      we don't have an active platform window which we now workaround
      by propagating the resize through QWindowSystemInterface.
      
      * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
      (WTR::WrapperWindow::handleStatusChanged):
      (WTR::PlatformWebView::resizeTo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67c1ce17
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r108577. · 8a203f10
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/108577
      https://bugs.webkit.org/show_bug.cgi?id=79359
      
      It doesn't work as expected (Requested by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23
      
      Tools:
      
      * DumpRenderTree/qt/EventSenderQt.cpp:
      (EventSender::postEvent):
      * DumpRenderTree/qt/EventSenderQt.h:
      (EventSender):
      
      LayoutTests:
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a203f10
    • philn@webkit.org's avatar
      [GTK] FullScreen signals · aa195ed3
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76181
      
      Reviewed by Martin Robinson.
      
      Source/WebKit/gtk:
      
      Added entering-fullscreen and leaving-fullscreen signals, meant to
      be used by the user agent to be notified when an element requests
      full screen display and when the full screen display is to be
      disabled.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::supportsFullScreenForElement):
      (WebKit::onFullscreenGtkKeyPressEvent):
      (WebKit::ChromeClient::cancelFullScreen):
      (WebKit::ChromeClient::enterFullScreenForElement):
      (WebKit::ChromeClient::exitFullScreenForElement):
      * WebCoreSupport/ChromeClientGtk.h:
      * tests/testwebview.c:
      * webkit/webkitwebview.cpp:
      (webkit_web_view_real_entering_fullscreen):
      (webkit_web_view_real_leaving_fullscreen):
      (webkit_web_view_class_init):
      * webkit/webkitwebview.h:
      
      Tools:
      
      Use the two new entering/leaving fullscreen signals to hide/show
      the tool bar, the status bar and ask the user's permission before
      entering fullscreen.
      
      * GtkLauncher/main.c:
      (webViewFullscreenMessageWindowClose):
      (webViewWindowStateEvent):
      (hide_widget):
      (show_widget):
      (webViewEnteringFullScreen):
      (webViewLeavingFullScreen):
      (createBrowser):
      (createWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa195ed3
  3. 22 Feb, 2012 15 commits
    • commit-queue@webkit.org's avatar
      [EFL] Fix to launch the EWebLauncher using the script, run-launcher. · 0301c488
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79076
      
      Patch by Dongwoo Im <dw.im@samsung.com> on 2012-02-22
      Reviewed by Andreas Kling.
      
      * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
      (builtDylibPathForName):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0301c488
    • commit-queue@webkit.org's avatar
      [Qt] Add eventSender.gestureTap · 51155fce
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66173
      
      Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-22
      Reviewed by Kenneth Rohde Christiansen.
      
      Tools:
      
      * DumpRenderTree/qt/EventSenderQt.cpp:
      (EventSender::gestureTap):
      * DumpRenderTree/qt/EventSenderQt.h:
      
      LayoutTests:
      
      Unskip gestureTap test.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51155fce
    • beidson@apple.com's avatar
      <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279 · 25e7463c
      beidson@apple.com authored
      Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
      
      Reviewed by NOBODY (OOPS!).
      
      Source/WebKit2:
      
      Anytime the WebProcess sends a sync message up to the UI Process a hang can ensue.
      
      In the case of shouldGoToBackForwardListItem it seems many clients want a back/forward
      notification but don't actually want to make a policy decision.
      
      Making it an asynchronous notification instead of a synchronous policy call will remove the
      possibility of a hang here.
      
      If clients later decide it is important to have a policy here we should implement a form of
      shouldGoToBackForwardListItem in the bundle loader client.
      
      Add a notification "willGoToBackForwardListItem" to the WKPageLoaderClient:
      * UIProcess/API/C/WKPage.h:
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::initializeLoaderClient): Tell the WebProcess whether it should be
        sending the shouldGoToBackForwardListItem or willGoToBackForwardListItem form of this message.
      (WebKit::WebPageProxy::shouldGoToBackForwardListItem):
      (WebKit::WebPageProxy::willGoToBackForwardListItem):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in: Add an asynchronous WillGoToBackForwardListItem message
      
      Store a flag in the WebProcess - Sent from the UIProcess - to tell the FrameLoaderClient which form
      of the callback should be used:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
      * WebProcess/WebPage/WebPage.h:
      (WebKit::WebPage::willGoToBackForwardItemCallbackEnabled):
      (WebKit::WebPage::setWillGoToBackForwardItemCallbackEnabled):
      * WebProcess/WebPage/WebPage.messages.in:
      
      * UIProcess/WebLoaderClient.cpp:
      (WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Only consider calling this for
        version 0 clients.
      (WebKit::WebLoaderClient::willGoToBackForwardListItem): Later clients get this callback.
      * UIProcess/WebLoaderClient.h:
      (WebLoaderClient):
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::shouldGoToHistoryItem): Send either the synchronous "should" message
        or the asynchronous "will" message depending on which the WebProcess was last told that the
        UIProcess expects. There is an edge case where the wrong one might be sent because the WebProcess
        hasn't received the message about a change in the WKPageLoaderClient yet but that's probably okay;
        It seems unlikely that a UIProcess client would ever rapidly change between v0 and other versions
        of the loader client and the UIProcess of WebKit2 is equipped to handle that case if it comes up.
      
      Tools:
      
      Update our tools to the new form of the PageLoadClient.
      
      * MiniBrowser/mac/BrowserWindowController.m:
      (-[BrowserWindowController awakeFromNib]):
      
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::initialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25e7463c
    • dbates@webkit.org's avatar
      new-run-webkit-tests shouldn't restore Safari state on Lion when showing results · 9cb18d80
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79277
      
      Reviewed by Adam Barth.
      
      Pass command line argument no-saved-state to run-safari to disable Safari
      state restoration for the session on OS 10.7.
      
      * Scripts/webkitpy/layout_tests/port/mac.py:
      (MacPort.show_results_html_file):
      * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
      (test_show_results_html_file):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cb18d80
    • commit-queue@webkit.org's avatar
      Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7 · 0006b6f5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77759
      
      Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-22
      Reviewed by Tony Chang.
      
      Fixes build with gcc 4.7.
      
      r100432 added the include only for ANDROID; this changes the ifdef to
      also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
      longer implicitly includes unistd.h from standard headers and other
      unix platforms are likely to get gcc 4.7 as well in the future.
      
      * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0006b6f5
    • philn@webkit.org's avatar
      Unreviewed, rolling out r108522. · cbaeee60
      philn@webkit.org authored
      http://trac.webkit.org/changeset/108522
      https://bugs.webkit.org/show_bug.cgi?id=76181
      
      Broke 4 fullscreen tests on GTK.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::supportsFullScreenForElement):
      (WebKit::ChromeClient::enterFullScreenForElement):
      (WebKit::ChromeClient::exitFullScreenForElement):
      * WebCoreSupport/ChromeClientGtk.h:
      (ChromeClient):
      * tests/testwebview.c:
      * webkit/webkitwebview.cpp:
      (webkit_web_view_class_init):
      * webkit/webkitwebview.h:
      (_WebKitWebViewClass):
      
      Tools:
      
      * GtkLauncher/main.c:
      (createBrowser):
      (createWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbaeee60
    • philn@webkit.org's avatar
      [GTK] FullScreen signals · d8c9cc22
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76181
      
      Reviewed by Martin Robinson.
      
      Source/WebKit/gtk:
      
      Added entering-fullscreen and leaving-fullscreen signals, meant to
      be used by the user agent to be notified when an element requests
      full screen display and when the full screen display is to be
      disabled.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::supportsFullScreenForElement):
      (WebKit::onFullscreenGtkKeyPressEvent):
      (WebKit::ChromeClient::cancelFullScreen):
      (WebKit::ChromeClient::enterFullScreenForElement):
      (WebKit::ChromeClient::exitFullScreenForElement):
      * WebCoreSupport/ChromeClientGtk.h:
      * tests/testwebview.c:
      * webkit/webkitwebview.cpp:
      (webkit_web_view_real_entering_fullscreen):
      (webkit_web_view_real_leaving_fullscreen):
      (webkit_web_view_class_init):
      * webkit/webkitwebview.h:
      
      Tools:
      
      Use the two new entering/leaving fullscreen signals to hide/show
      the tool bar, the status bar and ask the user's permission before
      entering fullscreen.
      
      * GtkLauncher/main.c:
      (webViewFullscreenMessageWindowClose):
      (webViewWindowStateEvent):
      (hide_widget):
      (show_widget):
      (webViewEnteringFullScreen):
      (webViewLeavingFullScreen):
      (createBrowser):
      (createWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8c9cc22
    • commit-queue@webkit.org's avatar
      Update Linux ChromiumOS builders in flakiness dashboard. · 70c0ffc8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79238
      
      Patch by Rob Flack <flackr@chromium.org> on 2012-02-22
      Reviewed by Ojan Vafai.
      
      * TestResultServer/static-dashboards/builders.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70c0ffc8
    • dpranke@chromium.org's avatar
      webkitpy: test_function_length_check_definition_huge_lines is slow · 39f777c2
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79185
      
      Reviewed by Adam Barth.
      
      This test takes ~3 seconds to run, apparently because we're
      running a test on a 10,000 line function :). Dropping the
      function length to 640 still exercises the code path and
      provides a 10x speedup.
      
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (CppStyleTest):
      (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39f777c2
    • dpranke@chromium.org's avatar
      webkitpy: speed up FileLockTest.test_lock_lifecycle · 6f4b3aaf
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79189
      
      Reviewed by Adam Barth.
      
      The unit test had a second lock trying to acquire a
      lock already held, and a hard-coded timeout of one second.
      I have changed the timeouts to a tenth of a second (which
      is probably still fine) and changed the hard-spin on
      the lock to a slow-spin every hundredth of a second.
      
      * Scripts/webkitpy/common/system/file_lock.py:
      (FileLock.acquire_lock):
      * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
      (FileLockTest.setUp):
      (FileLockTest.test_stuck_lock):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f4b3aaf
    • rgabor@webkit.org's avatar
      build-webkit should use environment variable at number of CPU · 71345017
      rgabor@webkit.org authored
      detection on all platform
      https://bugs.webkit.org/show_bug.cgi?id=79227
      
      Reviewed by Martin Robinson.
      
      * Scripts/webkitdirs.pm:
      (determineNumberOfCPUs):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71345017
    • mihnea@adobe.com's avatar
      [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail · df05b2eb
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=78960
      
      Reviewed by Csaba Osztrogonác.
      
      Source/WebKit/qt:
      
      * Api/qwebsettings.cpp:
      (QWebSettingsPrivate::apply):
      (QWebSettings::QWebSettings):
      * Api/qwebsettings.h:
      
      Tools:
      
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::overridePreference):
      
      LayoutTests:
      
      * fast/repaint/japanese-rl-selection-repaint-in-regions.html:
      * fast/repaint/line-flow-with-floats-in-regions.html:
      * fast/repaint/overflow-flipped-writing-mode-block-in-regions.html:
      * fast/repaint/region-painting-invalidation.html:
      * fast/repaint/region-painting-via-layout.html:
      * platform/qt/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df05b2eb
    • commit-queue@webkit.org's avatar
      [chromium] Build WebKit with MEDIA_STREAM disabled. · 56e4128f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79214
      
      Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-22
      Reviewed by Kent Tamura.
      
      Source/WebKit/chromium:
      
      * src/UserMediaClientImpl.h:
      
      Tools:
      
      * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
      * DumpRenderTree/chromium/WebUserMediaClientMock.h:
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::createMediaPlayer):
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56e4128f
    • zeno.albisser@nokia.com's avatar
      [Qt][WK2][Mac] WebKitTestRunner does not build with clang. · 8383461e
      zeno.albisser@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=79124
      
      WebKitTestRunnerPrefix.h should also be included
      when building with clang.
      
      Reviewed by Kenneth Rohde Christiansen.
      
      * WebKitTestRunner/Target.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8383461e
    • rolandsteiner@chromium.org's avatar
      <style scoped>: Add runtime-flag · bf3276c7
      rolandsteiner@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79074
      
      Source/WebCore:
      
      Added runtime-flag.
      Query runtime flag when (un)registering a <style scoped> element, and when determineing a style sheet's scope.
      
      Reviewed by Dimitri Glazkov.
      
      No new tests. (no change in functionality)
      
      * bindings/generic/RuntimeEnabledFeatures.cpp:
      (WebCore):
      * bindings/generic/RuntimeEnabledFeatures.h:
      (RuntimeEnabledFeatures):
      (WebCore::RuntimeEnabledFeatures::styleScopedEnabled):
      (WebCore::RuntimeEnabledFeatures::setStyleScopedEnabled):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::determineScopingElement):
      * html/HTMLStyleElement.cpp:
      (WebCore::HTMLStyleElement::registerWithScopingNode):
      (WebCore::HTMLStyleElement::unregisterWithScopingNode):
      * html/HTMLStyleElement.idl:
      
      Source/WebKit/chromium:
      
      Added a runtime-flag.
      Enable default STYLE_SCOPED compile-time flag for Chromium.
      
      Reviewed by Dimitri Glazkov.
      
      * features.gypi: enable STYLE_SCOPED
      * public/WebRuntimeFeatures.h:
      (WebRuntimeFeatures):
      * src/WebRuntimeFeatures.cpp:
      (WebKit::WebRuntimeFeatures::enableStyleScoped):
      (WebKit):
      (WebKit::WebRuntimeFeatures::isStyleScopedEnabled):
      
      Tools:
      
      Enable the runtime-flag for DRT.
      
      Reviewed by Dimitri Glazkov.
      
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::TestShell):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf3276c7