- 17 Feb, 2012 40 commits
-
-
mhahnenberg@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=78573 Reviewed by Geoffrey Garen. Renamed anything with "Bump" in the name to have "Copied" instead. * CMakeLists.txt: * GNUmakefile.list.am: * JavaScriptCore.gypi: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: * JavaScriptCore.xcodeproj/project.pbxproj: * Target.pri: * heap/BumpBlock.h: Removed. * heap/BumpSpace.cpp: Removed. * heap/BumpSpace.h: Removed. * heap/BumpSpaceInlineMethods.h: Removed. * heap/ConservativeRoots.cpp: (JSC::ConservativeRoots::ConservativeRoots): (JSC::ConservativeRoots::genericAddPointer): * heap/ConservativeRoots.h: (ConservativeRoots): * heap/CopiedBlock.h: Added. (JSC): (CopiedBlock): (JSC::CopiedBlock::CopiedBlock): * heap/CopiedSpace.cpp: Added. (JSC): (JSC::CopiedSpace::tryAllocateSlowCase): * heap/CopiedSpace.h: Added. (JSC): (CopiedSpace): (JSC::CopiedSpace::isInCopyPhase): (JSC::CopiedSpace::totalMemoryAllocated): (JSC::CopiedSpace::totalMemoryUtilized): * heap/CopiedSpaceInlineMethods.h: Added. (JSC): (JSC::CopiedSpace::CopiedSpace): (JSC::CopiedSpace::init): (JSC::CopiedSpace::contains): (JSC::CopiedSpace::pin): (JSC::CopiedSpace::startedCopying): (JSC::CopiedSpace::doneCopying): (JSC::CopiedSpace::doneFillingBlock): (JSC::CopiedSpace::recycleBlock): (JSC::CopiedSpace::getFreshBlock): (JSC::CopiedSpace::borrowBlock): (JSC::CopiedSpace::addNewBlock): (JSC::CopiedSpace::allocateNewBlock): (JSC::CopiedSpace::fitsInBlock): (JSC::CopiedSpace::fitsInCurrentBlock): (JSC::CopiedSpace::tryAllocate): (JSC::CopiedSpace::tryAllocateOversize): (JSC::CopiedSpace::allocateFromBlock): (JSC::CopiedSpace::tryReallocate): (JSC::CopiedSpace::tryReallocateOversize): (JSC::CopiedSpace::isOversize): (JSC::CopiedSpace::isPinned): (JSC::CopiedSpace::oversizeBlockFor): (JSC::CopiedSpace::blockFor): * heap/Heap.cpp: * heap/Heap.h: (JSC): (Heap): * heap/MarkStack.cpp: (JSC::MarkStackThreadSharedData::MarkStackThreadSharedData): (JSC::SlotVisitor::drainFromShared): (JSC::SlotVisitor::startCopying): (JSC::SlotVisitor::allocateNewSpace): (JSC::SlotVisitor::doneCopying): * heap/MarkStack.h: (MarkStackThreadSharedData): * heap/SlotVisitor.h: (SlotVisitor): * runtime/JSArray.cpp: * runtime/JSObject.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=78915 Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an == (TestWebKitAPI::decidePolicyForNewWindowAction): ditto git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78898 Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-02-17 Reviewed by Adam Barth. * fast/js/script-tests/date-constructor.js: toSTring to toString git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78826 Reviewed by Gustavo Noronha Silva. Instead of using a WebCore timer, which can be starved by GdkEvents, use a raw GLib timer with GDK_PRIORITY_EVENTS to drive AC updates. This prevents dragging from blocking rendering. * WebCoreSupport/AcceleratedCompositingContext.h: (AcceleratedCompositingContext): Store a GLib source tag instead of a WebCore timer. * WebCoreSupport/AcceleratedCompositingContextClutter.cpp: (WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext): (WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext): Remove the timer upon destruction. (WebKit::syncLayersTimeoutCallback): Added this callback for the GLib timer. (WebKit::AcceleratedCompositingContext::markForSync): Use a GLib timer. (WebKit::AcceleratedCompositingContext::syncLayersTimeout): Ditto. * WebCoreSupport/AcceleratedCompositingContextGL.cpp: (WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext): (WebKit::AcceleratedCompositingContext::~AcceleratedCompositingContext): Remove the timer upon destruction. (WebKit::syncLayersTimeoutCallback): Added this callback for the GLib timer. (WebKit::AcceleratedCompositingContext::markForSync): Use a GLib timer. (WebKit::AcceleratedCompositingContext::syncLayersTimeout): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihnea@adobe.com authored
https://bugs.webkit.org/show_bug.cgi?id=78880 Reviewed by David Hyatt. Source/WebCore: Test: fast/regions/webkit-named-flow-overflow.html * dom/WebKitNamedFlow.cpp: (WebCore::WebKitNamedFlow::WebKitNamedFlow): (WebCore::WebKitNamedFlow::overflow): (WebCore): * dom/WebKitNamedFlow.h: (WebCore): (WebCore::WebKitNamedFlow::create): (WebKitNamedFlow): * dom/WebKitNamedFlow.idl: * rendering/RenderFlowThread.cpp: (WebCore::RenderFlowThread::RenderFlowThread): (WebCore::RenderFlowThread::ensureNamedFlow): (WebCore::RenderFlowThread::computeOverflowStateForRegions): * rendering/RenderFlowThread.h: LayoutTests: * fast/regions/resources/helper.js: (testContentToRegionsMapping): * fast/regions/resources/region-style.css: * fast/regions/webkit-named-flow-overflow-expected.txt: Added. * fast/regions/webkit-named-flow-overflow.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78772 As per the spec http://dev.w3.org/csswg/css3-flexbox/#flex-wrap0, flex-wrap:nowrap should be changed to flex-wrap:none. Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-17 Reviewed by Ojan Vafai. Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFlexWrap): * css/CSSValueKeywords.in: * rendering/style/RenderStyle.h: * rendering/style/RenderStyleConstants.h: LayoutTests: * css3/flexbox/css-properties-expected.txt: * css3/flexbox/script-tests/css-properties.js: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt: * platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
enrica@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=78768 Reviewed by Darin Adler. Source/WebCore: No new tests. No behavior change. * WebCore.exp.in: Added new exported method of the PlatformPasteboard class. * platform/DragData.h: (WebCore::DragData::pasteboardName): Added pasteboardName and removed pasteboard. * platform/PasteboardStrategy.h: Added color() method. * platform/PlatformPasteboard.h: Ditto. * platform/mac/ClipboardMac.mm: (WebCore::Clipboard::create): Changed to use pasteboardName() method. * platform/mac/DragDataMac.mm: All the methods below have been changed to use pasteboardName and the pasteboardStrategy() methods. (WebCore::DragData::DragData): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsFiles): (WebCore::DragData::numberOfFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::asURL): (WebCore::DragData::asFragment): * platform/mac/PlatformPasteboardMac.mm: (WebCore::PlatformPasteboard::color): Added implementation of the color() method. Source/WebKit/mac: * WebCoreSupport/WebPlatformStrategies.h: Added color() method. * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::color): Source/WebKit2: * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added color() method. (WebKit::WebPlatformStrategies::color): * WebProcess/WebCoreSupport/WebPlatformStrategies.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
japhet@chromium.org authored
[Chromium mac] Cursors and background images disappear. https://bugs.webkit.org/show_bug.cgi?id=78834 The issue occurs because a CachedImage sees that it has no clients and decide it is safe to purge its m_data buffer. However, StyleCachedImage is holding a CachedResourceHandle to the CachedImage, and it can still add a client later. If it does so, the CachedImage says everything is loaded but has no data. Reviewed by Adam Barth. No new tests, since the known repros have resisted reduction. Tested manually with chrome.angrybirds.com, redfin.com and a couple of other sites. * rendering/style/StyleCachedImage.cpp: * rendering/style/StyleCachedImage.h: Ensure the underlying CachedImage has a client for the lifetime of the StyleCachedImage and doesn't purge its buffer. Call addClient(this) in the constructor and removeClient(this) in the destructor, then ignore all cache callbacks. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78022 Patch by Scott Graham <scottmg@chromium.org> on 2012-02-17 Reviewed by Darin Fisher. Add #pragma pack around definition of shared memory structures to avoid differences across compilers and platforms. Add COMPILE_ASSERT to verify expected size. * public/platform/WebGamepad.h: (WebKit): * public/platform/WebGamepads.h: (WebKit): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=7180 Reviewed by David Hyatt. Source/WebCore: Tests: fast/table/table-switch-cell-position-bad-layout-expected.html fast/table/table-switch-cell-position-bad-layout.html This patch implements cell's anonymous wrapper removal at detach time. Trimming the render tree when we remove objects from it would be more complex to generalize as several objects override the behavior to do their own clean-ups. This would also open more potential for programming errors. This change is limited to table cells' as a simple step towards fixing bug 52123 and more generally eliminate some anonymous wrappers from the tree at detach time. * dom/Node.cpp: (WebCore::Node::detach): Patched detach to call destroyAndCleanupAnonymousWrappers. The Document does not need to clean up any anonymous wrappers on detach. * rendering/RenderObject.cpp: (WebCore::RenderObject::destroyAndCleanupAnonymousWrappers): Added this method to wrap destroy() call and trim the render tree. To avoid slowing down detach in some cases, added a fast path. * rendering/RenderObject.h: Added destroyAndCleanupAnonymousWrappers. LayoutTests: * fast/table/table-switch-cell-position-bad-layout-expected.html: Added. * fast/table/table-switch-cell-position-bad-layout.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rwlbuis@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=64839 Reviewed by Antti Koivisto. Source/WebCore: Reset the style declaration when rmeoving the font-face element from the document. Test: svg/custom/font-face-move.svg * svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::removedFromDocument): LayoutTests: * svg/custom/font-face-move-expected.txt: Added. * svg/custom/font-face-move.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78911 Reviewed by Xan Lopez. Source/WebCore: No new tests. These are just fixes for warnings. * page/GestureTapHighlighter.cpp: Avoid using potentially signed operations on a size_t type. Use size_t for iterating over members of a vector. * platform/graphics/texmap/TextureMapperBackingStore.cpp: Use size_t where necessary. (WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded): Ditto. * platform/graphics/texmap/TextureMapperLayer.cpp: Ditto. (WebCore::TextureMapperLayer::computeTransformsRecursive): Ditto. (WebCore::TextureMapperLayer::paintSelfAndChildren): Ditto. (WebCore::TextureMapperLayer::intermediateSurfaceRect): Ditto. Source/WebKit2: * UIProcess/API/gtk/WebKitLoaderClient.cpp: (attachLoaderClientToView): Initialize a new member of the loader client struct. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78885 Reviewed by Adam Barth. Added unit tests for models.py. Also renamed modelFromNumericId to model_from_numeric_id and moved set_persitent_cache and get_persistent_cache from controller to PersistentCache.set_cache and PersistentCahce.set_cache respectively. * Websites/webkit-perf.appspot.com/controller.py: (cache_manifest): (CachedManifestHandler.get): (cache_dashboard): (CachedDashboardHandler.get): (cache_runs): (CachedRunsHandler.get): * Websites/webkit-perf.appspot.com/create_handler.py: (CreateHandler._create_builder): (CreateHandler._create_builder.execute): * Websites/webkit-perf.appspot.com/models.py: (create_in_transaction_with_numeric_id_holder): (model_from_numeric_id): (Builder): (Builder.create): (Builder.update_password): (Builder._hashed_password): (TestResult.key_name): (ReportLog.get_value): (ReportLog._integer_in_payload): (ReportLog): (ReportLog.timestamp): (PersistentCache): (PersistentCache.set_cache): (PersistentCache.set_cache.execute): (PersistentCache.get_cache): * Websites/webkit-perf.appspot.com/models_unittest.py: Added. (HelperTests): (HelperTests.setUp): (HelperTests.tearDown): (HelperTests._assert_there_is_exactly_one_id_holder_and_matches): (HelperTests.test_create_in_transaction_with_numeric_id_holder): (HelperTests.test_create_in_transaction_with_numeric_id_holder.execute): (HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder): (HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder.execute): (HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder): (HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder.execute): (HelperTests.test_delete_model_with_numeric_id_holder): (HelperTests.test_delete_model_with_numeric_id_holder.execute): (HelperTests.test_model_from_numeric_id): (HelperTests.test_model_from_numeric_id.execute): (BuilderTests): (BuilderTests.setUp): (BuilderTests.tearDown): (BuilderTests.test_create): (BuilderTests.test_update_password): (BuilderTests.test_hashed_password): (BuilderTests.test_authenticate): (ReportLog): (ReportLog.setUp): (ReportLog.tearDown): (ReportLog._create_log_with_payload): (ReportLog.test_parsed_payload): (ReportLog.test_get_value): (ReportLog.test_results): (ReportLog.test_builder): (ReportLog.test_build_number): (ReportLog.test_webkit_revision): (ReportLog.chromium_revision): (PersistentCacheTests): (PersistentCacheTests.setUp): (PersistentCacheTests.tearDown): (PersistentCacheTests._assert_persistent_cache): (PersistentCacheTests.test_set): (PersistentCacheTests.test_get): * Websites/webkit-perf.appspot.com/runs_handler.py: (RunsHandler.post): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76720 Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-17 Reviewed by James Robinson. Source/WebCore: CCVideoLayerImpl no longer handles drawing itself, but produces a list of CCVideoDrawQuads. These quads are then drawn by LayerRendererChromium. CCLayerImpl::willDraw(LayerRendererChromium*) is called directly before appendQuads. CCLayerImpl::didDraw() is called directly after all drawing has been completed. CCLayerImpl::draw has been removed. willDraw and didDraw are used to handle interaction with the VideoFrameProvider in CCVideoLayerImpl. willDraw gets a frame from the VideoFrameProvider, and didDraw returns it. A unit test has been added: CCLayerTreeHostImplTest.didDrawCalledOnAllLayers. This test ensures that CCLayerImpl::didDraw() is called on all layers, including layers on different render surfaces. As this was a refactor, no other tests were added. * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawYUV): (WebCore): (WebCore::LayerRendererChromium::drawSingleTextureVideoQuad): (WebCore::LayerRendererChromium::drawRGBA): (WebCore::LayerRendererChromium::drawNativeTexture): (WebCore::LayerRendererChromium::copyFrameToTextures): (WebCore::LayerRendererChromium::copyPlaneToTexture): (WebCore::LayerRendererChromium::drawVideoQuad): * platform/graphics/chromium/LayerRendererChromium.h: (LayerRendererChromium): * platform/graphics/chromium/cc/CCLayerImpl.cpp: * platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::didDraw): (CCLayerImpl): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::calculateRenderPasses): (WebCore::CCLayerTreeHostImpl::drawLayers): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: (CCLayerTreeHostImpl): * platform/graphics/chromium/cc/CCVideoDrawQuad.cpp: (WebCore::CCVideoDrawQuad::create): (WebCore::CCVideoDrawQuad::CCVideoDrawQuad): * platform/graphics/chromium/cc/CCVideoDrawQuad.h: (CCVideoDrawQuad): (WebCore::CCVideoDrawQuad::textures): (WebCore::CCVideoDrawQuad::frame): (WebCore::CCVideoDrawQuad::format): * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::willDraw): (WebCore::CCVideoLayerImpl::appendQuads): (WebCore::CCVideoLayerImpl::didDraw): (WebCore::CCVideoLayerImpl::computeVisibleSize): * platform/graphics/chromium/cc/CCVideoLayerImpl.h: (CCVideoLayerImpl): (WebCore::CCVideoLayerImpl::providerMutex): (WebCore::CCVideoLayerImpl::provider): (Texture): Source/WebKit/chromium: CCLayerTreeHostImplTest.didDrawCalledOnAllLayers ensures that CCLayerImpl::didDraw() is called on all layers, including layers on different render surfaces. * tests/CCLayerTreeHostImplTest.cpp: (DidDrawCheckLayer): (WebKit::DidDrawCheckLayer::create): (WebKit::DidDrawCheckLayer::didDraw): (WebKit::DidDrawCheckLayer::didDrawCalled): (WebKit::DidDrawCheckLayer::DidDrawCheckLayer): (WebKit): (WebKit::TEST_F): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78823 Reviewed by Gustavo Noronha Silva. * UIProcess/API/gtk/WebKitPrintOperation.cpp: (webkitPrintOperationRunDialogUnix): Enable scale option in print dialog. * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: (WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize manual scale to 1. (WebKit::WebPrintOperationGtk::rotatePageIfNeeded): Renamed and moved the needs rotate check here as an early return. (WebKit::WebPrintOperationGtk::prepareContextToDraw): Scale the page according to the manual scale factor. (WebKit::WebPrintOperationGtk::renderPage): Move rotatePage to prepareContextToDraw. * WebProcess/WebPage/gtk/WebPrintOperationGtk.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
peter@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78865 Reviewed by Eric Seidel. Android will be re-using the TestShellLinux.cpp file. I already added this r104033, but it seems to have gotten lost in the recent refactorings. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78805 Reviewed by Gustavo Noronha Silva. * UIProcess/API/gtk/WebKitPrintOperation.cpp: (webkitPrintOperationRunDialogUnix): Enable multiple copies and collate options in print dialog. * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: (WebKit::PrintPagesData::PrintPagesData): Initialize number of collated and uncolated copies done and total. (WebKit::PrintPagesData::collatedCopiesLeft): Helper function that returns the number of collated copies left to do. (WebKit::PrintPagesData::uncollatedCopiesLeft): Helper function that returns the number of uncollated copies left to do. (WebKit::PrintPagesData::copiesLeft): Helper function that returns the number of collated or uncollated copies left to do. (WebKit::PrintPagesData::incrementPageSequence): Do not finish the print if there are uncollated copies left, and do not increment sheet number if there are collated copies left. (WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize m_manualCopies to 1 and m_manualCollateCopies to false. * WebProcess/WebPage/gtk/WebPrintOperationGtk.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug27038-1-expected.png: * platform/chromium-mac-leopard/tables/mozilla/bugs/bug27038-2-expected.png: * platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.png: * platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.txt: Added. * platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.png: * platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.txt: Added. * platform/chromium-win-vista/tables/mozilla/bugs: Removed. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
* fast/borders/border-mixed-alpha-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-mixed-alpha-expected.txt. * fast/borders/only-one-border-with-width-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/only-one-border-with-width-expected.txt. * platform/chromium-mac-snowleopard/fast/borders/border-mixed-alpha-expected.png: * platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-expected.png: * platform/chromium-mac-snowleopard/fast/borders/only-one-border-with-width-expected.png: Added. * platform/chromium-mac-snowleopard/fast/css/color-leakage-expected.png: Added. * platform/chromium-win/fast/borders/border-mixed-alpha-expected.png: * platform/chromium-win/fast/borders/mixed-border-styles-expected.png: * platform/chromium-win/fast/borders/only-one-border-with-width-expected.png: Copied from LayoutTests/platform/chromium-win/fast/css/color-leakage-expected.png. * platform/chromium-win/fast/css/color-leakage-expected.png: * platform/mac/fast/borders/border-mixed-alpha-expected.txt: Removed. * platform/mac/fast/borders/only-one-border-with-width-expected.txt: Removed. * platform/qt/fast/borders/border-mixed-alpha-expected.txt: Removed. * platform/qt/fast/borders/only-one-border-with-width-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78799 Reviewed by Gustavo Noronha Silva. * UIProcess/API/gtk/WebKitPrintOperation.cpp: (webkitPrintOperationRunDialogUnix): Enable printing in reverse order option in print dialog. * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: (WebKit::PrintPagesData::PrintPagesData): Initialize sheetNumber and lastPagePosition depending on whether printing is in reverse order or not. (WebKit::PrintPagesData::incrementPageSequence): Use a negative increment step when printing in reverse order. Fix page incrementing when printing only odd/even pages broken in previous commit due to merge conflicts. (WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize reverse printing to false. * WebProcess/WebPage/gtk/WebPrintOperationGtk.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78793 Reviewed by Gustavo Noronha Silva. * UIProcess/API/gtk/WebKitPrintOperation.cpp: (webkitPrintOperationRunDialogUnix): Enable print odd/even pages option in print dialog. * WebProcess/WebPage/gtk/WebPrintOperationGtk.h: * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: (WebKit::PrintPagesData::PrintPagesData): Add lastPagePosition and initialize it depending on the page set. (WebKit::PrintPagesData::incrementPageSequence): Use 2 step increment when printing only odd/even pages. (WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize m_manualPageSet to GTK_PAGE_SET_ALL. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77639 Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-17 Reviewed by Nikolas Zimmermann. Source/WebCore: Fix a SVG crash in Release builds, although it still crashes in Debug builds. The crash occurred when an SVG use element attempted to reference a style element while the file contained an error causing the error banner to display. The fix is to prevent SVGUseElement from recalculating style during tree building and return immediately when style is recalculated and the tree is building. Test: svg/custom/use-referencing-style-crash.svg * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::willRecalcStyle): Return false if the tree is being built. (WebCore::SVGUseElement::didRecalcStyle): Check and return if the tree is being built and we are not yet ready for style update. LayoutTests: Fix a SVG crash in Release builds, although it still crashes in Debug builds. This test is to verify no crash in Release builds, while expectations/Skipped are added for Debug builds. Bug 77764 tracks the Debug fix. * platform/chromium/test_expectations.txt: * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: * svg/custom/use-referencing-style-crash-expected.txt: Added. * svg/custom/use-referencing-style-crash.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
http://trac.webkit.org/changeset/108077 https://bugs.webkit.org/show_bug.cgi?id=78390 it broke compilation. * inspector/CodeGeneratorInspector.py: * inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getFunctionDetails): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::wrapCallFrames): * inspector/InjectedScript.h: (InjectedScript): * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::getFunctionDetails): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames): (WebCore::InspectorDebuggerAgent::didParseSource): * inspector/InspectorDebuggerAgent.h: (InspectorDebuggerAgent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
chrome.dll!WebCore::SVGTRefElement::updateReferencedText ReadAV@NULL (e85cb8e140071fa7790cad215b0109dc) https://bugs.webkit.org/show_bug.cgi?id=74858 Patch by Florin Malita <fmalita@google.com> on 2012-02-17 Reviewed by Nikolas Zimmermann. Source/WebCore: Tests: svg/custom/tref-remove-target-crash-expected.svg svg/custom/tref-remove-target-crash.svg Add a DOMNodeRemovedFromDocumentEvent listener to detect when the target element is removed. Upon removal, cleanup all listeners and re-activate the pending resource to attach if the referenced ID is added at a later time programmatically. Also move the DOMSubtreeModifiedEvent listener from the parent to the target element to simplify the implementation and reduce the scope. * svg/SVGTRefElement.cpp: (WebCore::TargetListener::create): (WebCore::TargetListener::cast): (WebCore::TargetListener::clear): (WebCore::TargetListener::TargetListener): (WebCore::TargetListener::operator==): (WebCore::TargetListener::handleEvent): (WebCore::SVGTRefElement::detachTarget): (WebCore::SVGTRefElement::buildPendingResource): * svg/SVGTRefElement.h: LayoutTests: * svg/custom/tref-remove-target-crash-expected.svg: Added. * svg/custom/tref-remove-target-crash.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
* inspector/CodeGeneratorInspector.py: (RawTypes.Any.generate_validate_method): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78715 Reviewed by Gustavo Noronha Silva. * UIProcess/API/gtk/WebKitPrintOperation.cpp: (webkitPrintOperationRunDialogUnix): Enable multiple pages per sheet options in print dialog. * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: (WebKit::PrintPagesData::PrintPagesData): Initialize sheetNumber and numberOfSheets. Move pagePosition to WebPrintOperationGtk. (WebKit::PrintPagesData::incrementPageSequence): Increment current sheet and page position. (WebKit::WebPrintOperationGtk::WebPrintOperationGtk): (WebKit::WebPrintOperationGtk::currentPageIsFirstPageOfSheet): Helper function to check whether current pages is the first one of the current sheet. (WebKit::WebPrintOperationGtk::currentPageIsLastPageOfSheet): Helper function to check whether current pages is the last one of the current sheet. (WebKit::WebPrintOperationGtk::getRowsAndColumnsOfPagesPerSheet): Returns the number of rows and columns of pages per sheet. (WebKit::WebPrintOperationGtk::getPositionOfPageInSheet): Returns the row and column number of the current page in the current sheet. (WebKit::WebPrintOperationGtk::prepareContextToDraw): Translate, scale and rotate accordingly to render every page in the right place of the sheet. (WebKit::WebPrintOperationGtk::renderPage): Call prepareContextToDraw() before drawing the page. * WebProcess/WebPage/gtk/WebPrintOperationGtk.h: (WebKit::WebPrintOperationGtk::setNumberOfPagesToPrint): (WebKit::WebPrintOperationGtk::pagePosition): (WebKit::WebPrintOperationGtk::setPagePosition): (WebKit::WebPrintOperationGtk::numberUp): (WebKit::WebPrintOperationGtk::numberUpLayout): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=63176 Reviewed by Dan Bernstein. The non-radiused border drawing code would use a transparency layer when drawing any one or more borders with alpha colors. However, we only need to use a transparency layer when there is a corner join between the borders being rendered with any one color, so add a utility function includesAdjacentEdges() that can tell us that, and use it to avoid making extraneous transparency layers. Optimization only, no new tests. * rendering/RenderBoxModelObject.cpp: (WebCore::includesAdjacentEdges): (WebCore): (WebCore::RenderBoxModelObject::paintTranslucentBorderSides): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Not reviewed: Qt minimal build fix. * inspector/InjectedScript.h: (WebCore): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78390 Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-17 Reviewed by Vsevolod Vlasov. Client code is switched to TypeBuilder. * inspector/CodeGeneratorInspector.py: * inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getFunctionDetails): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::wrapCallFrames): * inspector/InjectedScript.h: (InjectedScript): * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::getFunctionDetails): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames): (WebCore::InspectorDebuggerAgent::didParseSource): * inspector/InspectorDebuggerAgent.h: (InspectorDebuggerAgent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78896 Reviewed by Vsevolod Vlasov. * inspector/front-end/Spectrum.js: (WebInspector.Spectrum.prototype.get visible): (WebInspector.Spectrum.prototype.toggle): (WebInspector.Spectrum.prototype.show): * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertyTreeElement.prototype.updateTitle.): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=78895 Reviewed by Vsevolod Vlasov. Source/WebCore: Tests: inspector/elements/perform-undo-undo.html inspector/styles/perform-undo-perform-of-mergable-action.html * inspector/InspectorHistory.cpp: (WebCore::InspectorHistory::perform): LayoutTests: * inspector/elements/perform-undo-undo-expected.txt: Added. * inspector/elements/perform-undo-undo.html: Added. * inspector/styles/perform-undo-perform-of-mergable-action-expected.txt: Added. * inspector/styles/perform-undo-perform-of-mergable-action.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
http://trac.webkit.org/changeset/108071 https://bugs.webkit.org/show_bug.cgi?id=77155 chromium-mac compilation failed Source/WebCore: * platform/graphics/chromium/Extensions3DChromium.h: Source/WebKit/chromium: * public/platform/WebGraphicsContext3D.h: (WebGraphicsContext3D): * src/Extensions3DChromium.cpp: * src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::~GraphicsContext3D): * src/GraphicsContext3DPrivate.h: (WebCore): * tests/FakeWebGraphicsContext3D.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
* platform/gtk/Skipped: * platform/gtk/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
* platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=77155 Patch by Michal Mocny <mmocny@google.com> on 2012-02-17 Reviewed by James Robinson. Source/WebCore: * platform/graphics/chromium/Extensions3DChromium.h: (GpuMemoryAllocationChangedCallbackCHROMIUM): (WebCore::Extensions3DChromium::GpuMemoryAllocationChangedCallbackCHROMIUM::~GpuMemoryAllocationChangedCallbackCHROMIUM): (Extensions3DChromium): Source/WebKit/chromium: * public/platform/WebGraphicsContext3D.h: (WebGraphicsMemoryAllocationChangedCallbackCHROMIUM): (WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::~WebGraphicsMemoryAllocationChangedCallbackCHROMIUM): (WebGraphicsContext3D): (WebKit::WebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM): * src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM): (WebCore): * src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::~GraphicsContext3D): (GraphicsContext3DMemoryAllocationChangedCallbackAdapter): (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter): (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter): (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged): (WebCore): (WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM): * src/GraphicsContext3DPrivate.h: (WebCore): * tests/FakeWebGraphicsContext3D.h: (WebKit::FakeWebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM): (FakeWebGraphicsContext3D): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kubo@profusion.mobi authored
SVN r107973 moved some libsoup feature initialization code to WebCore, but only changed the GTK+ bits in WebKit. * ewk/ewk_main.cpp: (_ewk_init_body): Do not initialize the content sniffer and the decoder here, the initialization is now done in WebCore. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78893 Reviewed by Gustavo Noronha Silva. And it's not emitted anynmore when the print dialog has been cancelled. Since it's not possible to know whether the print dialog was cancelled or not, the enum WebKitPrintOperationResponse has been added, with Print and Cancel values, and it's used as return value of webkit_print_operation_run_dialog(). * UIProcess/API/gtk/WebKitPrintOperation.cpp: (webkit_print_operation_class_init): Rename done as finished. (webkitPrintOperationRunDialogUnix): Return a WebKitPrintOperationResponse instead of bool. (webkitPrintOperationRunDialogWin32): Ditto. (drawPagesForPrintingCompleted): Emit finished instead of done. (webkitPrintOperationRunDialogForFrame): Do not emit finished if the dialog was cancelled and return a WebKitPrintOperationResponse. (webkit_print_operation_run_dialog): Return WebKitPrintOperationResponse. * UIProcess/API/gtk/WebKitPrintOperation.h: Add WebKitPrintOperationResponse enum. * UIProcess/API/gtk/WebKitPrintOperationPrivate.h: * UIProcess/API/gtk/WebKitWebView.cpp: (webkitWebViewPrintFrame): Check whether the dialog has been cancelled or not and connect to finish when the print operation is in progress to release the print operation object when printing finishes. * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add WebKitPrintOperationResponse symbol. * UIProcess/API/gtk/tests/TestPrinting.cpp: (testPrintOperationPrintFinished): Use finished instead of done. (testPrintOperationPrint): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=76536 Reviewed by Gustavo Noronha Silva. * UIProcess/API/gtk/WebKitPrintOperation.cpp: (webkitPrintOperationPrintPagesForFrame): Helper function to call WebPageProxy::drawPagesForPrinting using the given GtkPrintSettings and GtkPageSetup. (webkitPrintOperationRunDialogForFrame): Use webkitPrintOperationPrintPagesForFrame(). (webkit_print_operation_print): Print directly using current GtkPrintSettings and GtkPageSetup without showing the print dialog. * UIProcess/API/gtk/WebKitPrintOperation.h: * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols. * UIProcess/API/gtk/tests/GNUmakefile.am: * UIProcess/API/gtk/tests/TestPrinting.cpp: (testPrintOperationPrintLoadChanged): (testPrintOperationPrintDone): (testPrintOperationPrintPrinter): (testPrintOperationPrint): (beforeAll): (afterAll): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kubo@profusion.mobi authored
SHARED_CORE=ON after r107820. RunLoopEfl.cpp has not been upstreamed yet, and building only RunLoop.cpp created an .so with some missing, unimplemented symbols. The BlackBerry port seems to be in the same situation. The best solution for now is to build RunLoop.cpp only on the WinCE port. * CMakeLists.txt: Remove RunLoop.cpp from the list of files to build. * PlatformWinCE.cmake: Add RunLoop.cpp to the list of files to build. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kubo@profusion.mobi authored
r107518. The EFL EWS bot doesn't enable that flag, so the breakage was not spotted earlier. * ewk/ewk_view.cpp: (_Ewk_View_Private_Data): (_ewk_view_priv_new): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-