1. 04 May, 2013 18 commits
  2. 03 May, 2013 22 commits
    • commit-queue@webkit.org's avatar
      incorrect repainting when a table has a transform · a37e3568
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109867
      
      Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-05-03
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Disable LayoutState when table, tableRow or tableSection render
      objects have transforms or reflections.
      
      Tests: fast/repaint/reflection-table-layout.html
             fast/repaint/transform-table-layout.html
      
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::layout):
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::layout):
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::layout):
      (WebCore::RenderTableSection::layoutRows):
      
      LayoutTests:
      
      Create tests that resize an element inside a display: table element.
      Compare to a reference html file where the element has a static size.
      In the first test, the table like element has a transform. In the
      second, it has a reflection.
      
      * fast/repaint/reflection-table-layout-expected.html: Added.
      * fast/repaint/reflection-table-layout.html: Added.
      * fast/repaint/transform-table-layout-expected.html: Added.
      * fast/repaint/transform-table-layout.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a37e3568
    • antti@apple.com's avatar
      Remove concept of younger and older shadow trees · 5da311eb
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115570
      
      Reviewed by Andreas Kling.
      
      Source/WebCore: 
      
      Younger and older shadow trees are an obscure corner of the Shadow DOM spec.
              
      Support only one shadow tree per element. This simplifies many things. 
      
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::ComposedShadowTreeWalker::traverseChild):
      (WebCore::ComposedShadowTreeWalker::traverseSiblingInCurrentTree):
      (WebCore):
      (WebCore::ComposedShadowTreeWalker::traverseParent):
      (WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
      (WebCore::ComposedShadowTreeWalker::traverseParentBackToShadowRootOrHost):
      * dom/ComposedShadowTreeWalker.h:
      (WebCore::ComposedShadowTreeWalker::assertPrecondition):
      (ComposedShadowTreeWalker):
      * dom/ContainerNodeAlgorithms.cpp:
      (WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
      (WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
      (WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
      (WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):
      (WebCore::ChildFrameDisconnector::collectFrameOwners):
      (WebCore::assertConnectedSubrameCountIsConsistent):
      * dom/Document.cpp:
      (WebCore::Document::buildAccessKeyMap):
      * dom/Element.cpp:
      (WebCore::Element::authorShadowRoot):
      (WebCore::Element::userAgentShadowRoot):
      (WebCore::Element::ensureUserAgentShadowRoot):
      * dom/Element.h:
      (Element):
      (WebCore::Element::hasAuthorShadowRoot):
      * dom/Element.idl:
      * dom/ElementShadow.cpp:
      (WebCore::ElementShadow::addShadowRoot):
              
      Allow only one ShadowRoot per ElementShadow. Remove linked list handling.
              
      (WebCore::ElementShadow::removeAllShadowRoots):
      (WebCore::ElementShadow::attach):
      (WebCore::ElementShadow::detach):
      (WebCore::ElementShadow::childNeedsStyleRecalc):
      (WebCore::ElementShadow::needsStyleRecalc):
      (WebCore::ElementShadow::recalcStyle):
      (WebCore::ElementShadow::removeAllEventListeners):
      * dom/ElementShadow.h:
      (WebCore::ElementShadow::shadowRoot):
      (ElementShadow):
      (WebCore::ElementShadow::host):
      (WebCore::Node::shadowRoot):
      (WebCore):
      * dom/Node.cpp:
      (WebCore):
      (WebCore::Node::showNodePathForThis):
      (WebCore::traverseTreeAndMark):
      (WebCore::showSubTreeAcrossFrame):
      * dom/Node.h:
      (Node):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::insertedInto):
      * dom/ShadowRoot.h:
      (ShadowRoot):
              
          Remove LinkedList base.
              
      * dom/TreeScopeAdopter.cpp:
      (WebCore::TreeScopeAdopter::moveTreeToNewScope):
      (WebCore::TreeScopeAdopter::moveTreeToNewDocument):
      * html/shadow/ContentDistributor.cpp:
      (WebCore::ContentDistributor::distribute):
      (WebCore::ContentDistributor::invalidate):
      (WebCore::ContentDistributor::ensureSelectFeatureSet):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::unbind):
      (WebCore::InspectorDOMAgent::buildObjectForNode):
      * page/FocusController.cpp:
      (WebCore::FocusNavigationScope::FocusNavigationScope):
      (WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost):
      * rendering/RenderFileUploadControl.cpp:
      (WebCore::RenderFileUploadControl::uploadButton):
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::updateReferencedText):
      (WebCore::SVGTRefElement::detachTarget):
      * svg/SVGUseElement.cpp:
      (WebCore::SVGUseElement::clearResourceReferences):
      (WebCore::SVGUseElement::buildShadowAndInstanceTree):
      (WebCore::SVGUseElement::buildShadowTree):
      * testing/Internals.cpp:
      (WebCore::Internals::ensureShadowRoot):
      (WebCore::Internals::shadowRoot):
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      LayoutTests: 
      
      * editing/text-iterator/basic-iteration-expected.txt:
      * editing/text-iterator/script-tests/basic-iteration.js:
      (addShadowTreeWithDivElement):
      * fast/forms/resources/common-spinbutton-change-and-input-events.js:
      (testSpinButtonChangeAndInputEvents):
      * fast/forms/resources/common-spinbutton-click-in-iframe.js:
      (getSpinButton):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5da311eb
    • commit-queue@webkit.org's avatar
      SunSpider 1.0: 3d-morph: use epsilon to check result · 163ba616
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115553
      
      Patch by Cosmin Truta <ctruta@blackberry.com> on 2013-05-03
      Reviewed by George Staikos.
      
      SunSpider/3d-morph should be more lenient in validating its results, since they depend on Math.sin, which isn't formally specified.
      
      * tests/sunspider-1.0/3d-morph.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      163ba616
    • commit-queue@webkit.org's avatar
      Create a script to import W3C tests · b2edd305
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111513
      
      Patch by Rebecca Hauck <rhauck@adobe.com> on 2013-05-03
      Reviewed by Dirk Pranke.
      
      Script to automate the import of W3C tests into WebKit.
      For the full description of how it works, see the comments
      at the top of test_importer.py.
      
      * Scripts/import-w3c-tests: Added.
      * Scripts/webkitpy/w3c/__init__.py: Added.
      * Scripts/webkitpy/w3c/test_converter.py: Added.
      (TestConverter):
      (TestConverter.__init__):
      (TestConverter.load_prefixed_prop_list):
      (TestConverter.load_file):
      (TestConverter.convert_for_webkit):
      (TestConverter.convert_testharness_paths):
      (TestConverter.convert_prefixed_properties):
      (TestConverter.scrub_unprefixed_props):
      (TestConverter.replace_tag):
      * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
      (TestConverterTest):
      (TestConverterTest.testLoadPrefixedPropList):
      (TestConverterTest.test_convertForWebkitNothingToConvert):
      (test_convertForWebkitHarnessOnly):
      (test_convertForWebkitPropsOnly):
      (test_convertForWebkitHarnessAndProps):
      (test_convertTestHarnessPaths):
      (test_convertPrefixedProperties):
      (verifyTestHarnessPaths):
      (verifyPrefixedProperties):
      (generateTestContent):
      * Scripts/webkitpy/w3c/test_importer.py: Added.
      (main):
      (parse_args):
      (validate_import_directory):
      (TestImporter):
      (TestImporter.__init__):
      (TestImporter.do_import):
      (TestImporter.get_changeset):
      (TestImporter.scan_source_directory):
      (TestImporter.import_tests):
      (TestImporter.setup_destination_directory):
      (TestImporter.get_test_status):
      (TestImporter.remove_deleted_files):
      (TestImporter.write_import_log):
      * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
      (TestImporterTest):
      (TestImporterTest.test_ImportDirWithNoTests):
      * Scripts/webkitpy/w3c/test_parser.py: Added.
      (TestParser):
      (TestParser.__init__):
      (TestParser.load_file):
      (TestParser.analyze_test):
      (TestParser.get_reftests):
      (TestParser.is_jstest):
      (TestParser.get_support_files):
      * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
      (TestParserTest):
      (TestParserTest.test_analyzeTestReftestOneMatch):
      (test_analyzeTestReftestMultipleMatches):
      (test_analyzeTestReftestMatchAndMismatch):
      (test_analyzeTestReftestWithRefSupportFiles):
      (test_analyzeJSTest):
      (test_analyzePixelTestAllTrue):
      (test_analyzePixelTestAllFalse):
      (test_analyzeNonHTMLFile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2edd305
    • mrobinson@webkit.org's avatar
      Simplify the #ifdefs in GraphicsContext3D.h · 1cc115d3
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115568
      
      Reviewed by Daniel Bates.
      
      * platform/graphics/GraphicsContext3D.h:
      (GraphicsContext3D): Combine #ifdefs paths that have a common
      implementation. This reduces the #ifdef paths from many to just three.
      * platform/graphics/cairo/GraphicsContext3DCairo.cpp:
      (WebCore::GraphicsContext3D::platformTexture): Move the implementation
      here to simplify the header.
      * platform/graphics/efl/GraphicsContext3DEfl.cpp:
      (WebCore::GraphicsContext3D::platformTexture): Ditto.
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cc115d3
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json. · bee0a95a
      ch.dumez@sisa.samsung.com authored
      * Scripts/webkitpy/common/config/contributors.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bee0a95a
    • commit-queue@webkit.org's avatar
      [Qt] Build with --video-track fails because String(AtomicString) is ambiguous · 2b174fec
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115551
      
      Patch by Brendan Long <b.long@cablelabs.com> on 2013-05-03
      Reviewed by Benjamin Poulain.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::configureTextTrackGroup):
      Change String(textTrack->kind()) to textTrack->kind().string(), and same thing with language.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b174fec
    • commit-queue@webkit.org's avatar
      [GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because... · bed9e9ac
      commit-queue@webkit.org authored
      [GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category
      https://bugs.webkit.org/show_bug.cgi?id=115575
      
      Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-05-03
      Reviewed by Philippe Normand.
      
      No new tests needed.
      
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      Using extern debug category.
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
      Declaring debug category as not static.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bed9e9ac
    • zhajiang@rim.com's avatar
      [BlackBerry] Page rendering scale is changed after go back and forward · 798989fe
      zhajiang@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115573
      
      Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-05-03.
      Reviewed by Rob Buis.
      Internally reviewed by Jeff Rogers.
      
      PR: 326886
      When navigating back from page A with viewport to page B without
      viewport, we didn't call setViewMode(); therefore, we didn't change
      the fixed layout size which was set by page A. In that case, WebCore
      would just pick up page A's fixed layout size to layout page B which
      caused this issue.
      Expecting zoomToInitialScaleOnLoad() or other functions to setViewMode()
      later is not a good way, because zoomToInitialScaleOnLoad() has never
      been called in this case. So we should always call setViewMode() to set
      fixed layout size when a new page is committed.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setLoadState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      798989fe
    • bfulgham@webkit.org's avatar
      [WinCairo] Unreviewed VS2010 Build Correction. · bc007772
      bfulgham@webkit.org authored
      * WebCore.vcxproj/WebCore.vcxproj: Exclude CG-only
      SubimageCacheWithTimer.cpp from WinCairo build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc007772
    • commit-queue@webkit.org's avatar
      [Cairo] Anti-aliasing should not be always disabled for lines · bb84f89c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109535
      
      Patch by Viatcheslav Ostapenko <viatchslav.o@samsung.com> on 2013-05-03
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Don't disable antialiasing for text lines because it produces ugly picture if
      page is scaled.
      
      Test: fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html
      
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      (WebCore::drawLineOnCairoContext):
      
      LayoutTests:
      
      Add pixel test with scaled text lines.
      
      * fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html: Added.
      * platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.png: Added.
      * platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb84f89c
    • dbates@webkit.org's avatar
      Remove unnecessary include HTMLNames.h from RenderThemeGtk.cpp · e398dc69
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115571
      
      Reviewed by Martin Robinson.
      
      * platform/gtk/RenderThemeGtk.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e398dc69
    • ap@apple.com's avatar
      [Mac] setMetadataURL incorrectly treats path bytes as Latin-1 · ff0af585
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115557
      
      Reviewed by Sam Weinig.
      
      * platform/mac/FileSystemMac.mm: (WebCore::setMetaData): Use the correct constructor.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff0af585
    • timothy_horton@apple.com's avatar
      PDFPlugin: Changes being made to active annotation aren't saved when the PDF is exported · 90ae9289
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115544
      <rdar://problem/13801789>
      
      Reviewed by Alexey Proskuryakov.
      
      Commit changes to the active annotation (if there is one) before
      returning the live PDF data, so that said changes are represented
      in the exported or printed output.
      
      * WebProcess/Plugins/PDF/PDFPlugin.h: Override liveData.
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      (WebKit::PDFPlugin::liveData): Commit the active annotation if there is one.
      * WebProcess/Plugins/PDF/SimplePDFPlugin.h:
      (SimplePDFPlugin): Make liveData virtual.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90ae9289
    • timothy_horton@apple.com's avatar
      Web process crashes at WebPage::determinePrimarySnapshottedPlugInTimerFired + 8 · cf8bae9f
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115056
      <rdar://problem/13719543>
      
      Reviewed by Simon Fraser.
      
      Null-check m_page. In theory, we shouldn't get here, because we stop
      the timer at the only point where m_page is cleared, but crash logs say
      we're still crashing here.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::determinePrimarySnapshottedPlugInTimerFired):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf8bae9f
    • timothy_horton@apple.com's avatar
      Remove some "what" comments from FindController · 3dd475c4
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115546
      
      Reviewed by Andreas Kling.
      
      * WebProcess/WebPage/FindController.cpp:
      (WebKit::FindController::countStringMatches):
      (WebKit::FindController::updateFindUIAfterPageScroll):
      (WebKit::FindController::willMoveToWebPage):
      (WebKit::FindController::mouseEvent):
      Remove or reword some comments.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dd475c4
    • abucur@adobe.com's avatar
      Move pixelSnappedLayoutOverflowRect and maxLayoutOverflow from RenderBox · 21a3632e
      abucur@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115550
      
      Reviewed by Simon Fraser.
      
      The patch moves pixelSnappedLayoutOverflowRect and maxLayoutOverflow out
      of RenderBox somewhere logically closer to their usage place.
      
      pixelSnappedLayoutOverflowRect - moved to RenderView because it's called only
      for RenderView at this moment.
      There are other places when the overflow rect is pixel snapped but only after
      the rect is adjusted for writing modes or inflated.
      
      maxLayoutOverflow - moved to RenderTreeAsText.cpp as a static function because
      it's used only there.
      
      Tests: no new functional change.
      
      * rendering/RenderBox.h: The functions declarations are removed.
      * rendering/RenderTreeAsText.cpp:
      (WebCore::maxLayoutOverflow):
      * rendering/RenderView.h:
      (WebCore::RenderView::pixelSnappedLayoutOverflowRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21a3632e
    • akling@apple.com's avatar
      StyleResolver: Have "list of matched rules" API vend internal types instead of CSSOM wrappers. · 82a4c88e
      akling@apple.com authored
      <http://webkit.org/b/115563>
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Change styleRulesForElement() and pseudoStyleRulesForElement() to return Vectors of StyleRuleBase
      instead of CSSRuleLists. This defers instantiating CSSOM wrappers until they're actually needed
      for exposure to web API.
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::getMatchedCSSRules):
      
          Create a StaticCSSRuleList and populate it with CSSOM wrappers for the matched rules.
          This is the one place where we expose this functionality to the web.
      
      * css/ElementRuleCollector.h:
      * css/ElementRuleCollector.cpp:
      (WebCore::ElementRuleCollector::matchedRuleList):
      (WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
      
          Collect internal StyleRuleBase pointers here instead of creating wrappers.
      
      * css/StyleResolver.h:
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::styleRulesForElement):
      (WebCore::StyleResolver::pseudoStyleRulesForElement):
      
          Vend said pointers.
      
      * editing/EditingStyle.cpp:
      (WebCore::styleFromMatchedRulesForElement):
      
          Dodge CSSOM wrapper instantiation (Woop woop!)
      
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::buildObjectForRule):
      
          Split buildObjectForRule() into two versions, one for CSSStyleRule and one for StyleRule.
          The CSSStyleRule one doesn't need a special path for parent-less rules, since those always
          come in through the StyleRule interface instead. This factoring can be improved further
          after this change.
      
      (WebCore::InspectorCSSAgent::getMatchedStylesForNode):
      (WebCore::InspectorCSSAgent::buildArrayForRuleList):
      (WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
      
          Tweaked for changes in StyleResolver API.
      
      Source/WebKit/qt:
      
      * Api/qwebelement.cpp:
      (QWebElement::styleProperty):
      
          Tweaked for changes in StyleResolver API.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82a4c88e
    • ap@apple.com's avatar
      REGRESSION (r145042): Downloading a file sometimes results in could not create · 6640a0b2
      ap@apple.com authored
              a sandbox extension Console message and file stays as a .download file
              https://bugs.webkit.org/show_bug.cgi?id=115559
              <rdar://problem/13785101>
      
              Reviewed by Sam Weinig.
      
              CString is evil, it has two lengths which can be different - specifically, fileSystemRepresentation()
              creates a string with maximum possible buffer size. This was confusing resolveSymlinksInPath().
      
              * platform/cf/FileSystemCF.cpp: (WebCore::fileSystemRepresentation):
              Change fileSystemRepresentation to be less surprising. Really, we should rip apart
              CString and update callers to use better defined semantics, but this is the one function
              that repeatedly causes problems in practice.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6640a0b2
    • akling@apple.com's avatar
      CSSRule style declarations getters shouldn't be const. · ca809842
      akling@apple.com authored
      <http://webkit.org/b/115572>
      
      Reviewed by Antti Koivisto.
      
      Accessing the CSSStyleDeclaration for a CSSRule is a potentially mutating operation,
      and should not be const.
      
      * css/CSSFontFaceRule.cpp:
      (WebCore::CSSFontFaceRule::style):
      * css/CSSFontFaceRule.h:
      * css/CSSPageRule.cpp:
      (WebCore::CSSPageRule::style):
      * css/CSSPageRule.h:
      * css/CSSStyleRule.cpp:
      (WebCore::CSSStyleRule::style):
      * css/CSSStyleRule.h:
      (CSSStyleRule):
      * css/WebKitCSSFilterRule.cpp:
      (WebCore::WebKitCSSFilterRule::style):
      * css/WebKitCSSFilterRule.h:
      * css/WebKitCSSKeyframeRule.cpp:
      (WebCore::WebKitCSSKeyframeRule::style):
      * css/WebKitCSSKeyframeRule.h:
      (WebKitCSSKeyframeRule):
      * css/WebKitCSSViewportRule.cpp:
      (WebCore::WebKitCSSViewportRule::style):
      * css/WebKitCSSViewportRule.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca809842
    • akling@apple.com's avatar
      Use NotNull tag for placement new in WebCore. · 148e8cb8
      akling@apple.com authored
      <http://webkit.org/b/115569>
      
      Reviewed by Antti Koivisto.
      
      Avoid emitting null checks where we use placement new to construct objects into safe locations.
      
      * css/StylePropertySet.cpp:
      (WebCore::ImmutableStylePropertySet::create):
      * dom/Element.cpp:
      (WebCore::ShareableElementData::createWithAttributes):
      (WebCore::ShareableElementData::ShareableElementData):
      (WebCore::UniqueElementData::makeShareableCopy):
      * dom/QualifiedName.cpp:
      (WebCore::QualifiedName::init):
      (WebCore::createQualifiedName):
      * dom/make_names.pl:
      (printNamesCppFile):
      * platform/ThreadGlobalData.h:
      (WebCore::threadGlobalData):
      * platform/graphics/GlyphPage.h:
      (WebCore::GlyphPage::createForMixedFontData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      148e8cb8
    • akling@apple.com's avatar
      Simplify CSSSelectorList creation/adoption. · dbd85dd7
      akling@apple.com authored
      <http://webkit.org/b/106649>
      
      Reviewed by Antti Koivisto.
      
      Remove the optimization that special-cased construction of CSSSelectorLists with a single entry.
      This is in preparation for changing the way we store the selector lists on style rules.
      
      * css/CSSParser.h:
      * css/CSSSelector.h:
      
          Remove move(PassOwnPtr<CSSSelector> from, CSSSelector* to), inlining it into
          CSSSelectorList::adoptSelectorVector instead.
      
      * css/CSSSelectorList.cpp:
      (WebCore::CSSSelectorList::CSSSelectorList):
      (WebCore::CSSSelectorList::deleteSelectors):
      
          Handle all selector list lengths the same way.
      
      (WebCore::CSSSelectorList::adoptSelectorVector):
      
          Merge move() from CSSSelector.h into this code since it was the only call site.
          Also some minor readability cleanups.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbd85dd7