1. 21 Jan, 2014 8 commits
    • timothy@apple.com's avatar
      Start fleshing out the Overview Timeline view. · 4e24b669
      timothy@apple.com authored
      This gets the overview populating in the Timeline sidebar. The graph side is still empty.
      
      https://bugs.webkit.org/show_bug.cgi?id=124005
      
      Reviewed by Joseph Pecoraro.
      
      * Localizations/en.lproj/localizedStrings.js: Updated.
      * UserInterface/Frame.js:
      (WebInspector.Frame.prototype.addResource):
      * UserInterface/Images/TimelineRecordAnimation.svg: Added.
      * UserInterface/Images/TimelineRecordEvent.svg: Added.
      * UserInterface/Images/TimelineRecordLayout.svg: Added.
      * UserInterface/Images/TimelineRecordPaint.svg: Added.
      * UserInterface/Images/TimelineRecordScriptEvaluated.svg: Added.
      * UserInterface/Images/TimelineRecordStyle.svg: Added.
      * UserInterface/Images/TimelineRecordTimer.svg: Added.
      * UserInterface/Main.html:
      * UserInterface/OverviewTimelineView.js: Added.
      (WebInspector.OverviewTimelineView):
      (WebInspector.OverviewTimelineView.prototype.get navigationSidebarTreeOutlineLabel):
      (WebInspector.OverviewTimelineView.prototype._childFrameWasAdded):
      (WebInspector.OverviewTimelineView.prototype._mainResourceDidChange):
      (WebInspector.OverviewTimelineView.prototype._provisionalResourceWasAdded):
      (WebInspector.OverviewTimelineView.prototype._resourceWasAdded):
      (WebInspector.OverviewTimelineView.prototype._compareTreeElementsByDetails):
      (WebInspector.OverviewTimelineView.prototype._compareTreeElementsByStartTime):
      (WebInspector.OverviewTimelineView.prototype._insertTreeElement):
      (WebInspector.OverviewTimelineView.prototype._addResourceToTreeIfNeeded):
      (WebInspector.OverviewTimelineView.prototype._sourceCodeTimelineAdded):
      (WebInspector.OverviewTimelineView.prototype._treeElementSelected):
      * UserInterface/SourceCodeTimelineTreeElement.js: Added.
      (WebInspector.SourceCodeTimelineTreeElement):
      (WebInspector.SourceCodeTimelineTreeElement.prototype.get sourceCodeTimeline):
      * UserInterface/TimelineContentView.js:
      (WebInspector.TimelineContentView.createPathComponent):
      (WebInspector.TimelineContentView):
      (WebInspector.TimelineContentView.prototype.showOverviewTimelineView):
      (WebInspector.TimelineContentView.prototype.showTimelineView):
      (WebInspector.TimelineContentView.prototype.get supportsSplitContentBrowser):
      (WebInspector.TimelineContentView.prototype.get selectionPathComponents):
      (WebInspector.TimelineContentView.prototype._pathComponentSelected):
      (WebInspector.TimelineContentView.prototype._showTimelineView):
      (WebInspector.TimelineContentView.prototype._recordingReset):
      * UserInterface/TimelineIcons.css:
      (.style-record .icon): Added.
      (.layout-record .icon): Added.
      (.paint-record .icon): Added.
      (.evaluated-record .icon): Added.
      (.event-record .icon): Added.
      (.timer-record .icon): Added.
      (.animation-record .icon): Added.
      * UserInterface/TimelineView.css: Added.
      (.timeline-view):
      * UserInterface/TimelineView.js: Added.
      (WebInspector.TimelineView):
      (WebInspector.TimelineView.prototype.get navigationSidebarTreeOutline):
      (WebInspector.TimelineView.prototype.get navigationSidebarTreeOutlineLabel):
      (WebInspector.TimelineView.prototype.reset):
      (WebInspector.TimelineView.prototype.shown):
      (WebInspector.TimelineView.prototype.hidden):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e24b669
    • timothy@apple.com's avatar
      Start fleshing out the new TimelineSidebarPanel and TimelineContentView. · fe816eba
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124003
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/ContentView.js:
      (WebInspector.ContentView):
      (WebInspector.ContentView.isViewable):
      * UserInterface/FrameContentView.js:
      * UserInterface/Images/CloseTimeline.png: Added.
      * UserInterface/Images/CloseTimeline@2x.png: Added.
      * UserInterface/Images/ColorsLarge.png: Added.
      * UserInterface/Images/ColorsLarge@2x.png: Added.
      * UserInterface/Images/NetworkLarge.png: Added.
      * UserInterface/Images/NetworkLarge@2x.png: Added.
      * UserInterface/Images/ScriptLarge.png: Added.
      * UserInterface/Images/ScriptLarge@2x.png: Added.
      * UserInterface/Main.html:
      * UserInterface/Main.js:
      (WebInspector.sidebarPanelForRepresentedObject):
      (WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
      * UserInterface/NavigationSidebarPanel.js:
      (WebInspector.NavigationSidebarPanel.prototype.showDefaultContentView):
      * UserInterface/ResourceClusterContentView.js:
      * UserInterface/TimelineContentView.css: Added.
      (.content-view.timeline > .view-container):
      * UserInterface/TimelineContentView.js: Added.
      (WebInspector.TimelineContentView):
      * UserInterface/TimelineIcons.css: Renamed from Source/WebInspectorUI/UserInterface/InstrumentIcons.css.
      (.network-icon.large .icon): Added.
      (.colors-icon.large .icon): Added.
      (.script-icon.large .icon): Added.
      * UserInterface/TimelineSidebarPanel.css:
      (.sidebar > .panel.timeline > .navigation-bar):
      (.sidebar > .panel.timeline > .title-bar):
      (.sidebar > .panel.timeline > .title-bar.timelines):
      (.sidebar > .panel.timeline > .title-bar.timeline-events):
      (.sidebar > .panel.timeline > .timelines-content):
      (.sidebar > .panel.timeline > .timelines-content .close-button):
      (.sidebar > .panel.timeline > .timelines-content li.item.selected .close-button):
      (.sidebar > .panel.timeline > .timelines-content .close-button:active):
      (.sidebar > .panel.timeline > .content):
      * UserInterface/TimelineSidebarPanel.js:
      (WebInspector.TimelineSidebarPanel.createTimelineTreeElement):
      (WebInspector.TimelineSidebarPanel):
      (WebInspector.TimelineSidebarPanel.prototype.showDefaultContentView):
      (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject):
      (WebInspector.TimelineSidebarPanel.prototype.get contentTreeOutlineLabel):
      (WebInspector.TimelineSidebarPanel.prototype.set contentTreeOutlineLabel):
      (WebInspector.TimelineSidebarPanel.prototype.showTimelineOverview):
      (WebInspector.TimelineSidebarPanel.prototype.showTimelineView):
      (WebInspector.TimelineSidebarPanel.prototype._timelinesTreeElementSelected):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe816eba
    • timothy@apple.com's avatar
      Correctly track time bounds of WebInspector.Timeline and WebInspector.TimelineRecording. · de77591f
      timothy@apple.com authored
      The startTime and endTime were not correct when Network timeline needed to be taken into
      account (due to its dynamic loading nature.) This creates a network Timeline for the purposes
      of tracking the ResourceTimelineRecords and getting accurate start and end times.
      
      Also changes the way TimelineRecord tracks the inactive portion of time, needed for later
      work on the timeline graphs.
      
      https://bugs.webkit.org/show_bug.cgi?id=126676
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/ResourceTimelineRecord.js:
      (WebInspector.ResourceTimelineRecord.prototype.get updatesDynamically):
      (WebInspector.ResourceTimelineRecord.prototype.get usesActiveStartTime):
      (WebInspector.ResourceTimelineRecord.prototype.get startTime):
      (WebInspector.ResourceTimelineRecord.prototype.get activeStartTime):
      (WebInspector.ResourceTimelineRecord.prototype.get endTime):
      * UserInterface/Timeline.js:
      (WebInspector.Timeline):
      (WebInspector.Timeline.prototype.get startTime):
      (WebInspector.Timeline.prototype.get endTime):
      (WebInspector.Timeline.prototype.addRecord):
      (WebInspector.Timeline.prototype._updateTimesIfNeeded):
      (WebInspector.Timeline.prototype._recordUpdated):
      * UserInterface/TimelineRecord.js:
      (WebInspector.TimelineRecord.prototype.get startTime):
      (WebInspector.TimelineRecord.prototype.get activeStartTime):
      (WebInspector.TimelineRecord.prototype.get endTime):
      (WebInspector.TimelineRecord.prototype.get inactiveDuration):
      (WebInspector.TimelineRecord.prototype.get activeDuration):
      (WebInspector.TimelineRecord.prototype.get updatesDynamically):
      (WebInspector.TimelineRecord.prototype.get usesActiveStartTime):
      * UserInterface/TimelineRecording.js:
      (WebInspector.TimelineRecording.prototype._timelineTimesUpdated):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de77591f
    • timothy@apple.com's avatar
      Implement TimelineRecording and per-call-site timelines. · 650bc7c5
      timothy@apple.com authored
      Keep track of timeline records per global timeline and per source code location.
      This will be used to display them in the UI in later patches.
      
      https://bugs.webkit.org/show_bug.cgi?id=123367
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/Main.html:
      * UserInterface/SourceCodeTimeline.js: Added.
      (WebInspector.SourceCodeTimeline):
      (WebInspector.SourceCodeTimeline.prototype.get sourceCode):
      (WebInspector.SourceCodeTimeline.prototype.get sourceCodeLocation):
      (WebInspector.SourceCodeTimeline.prototype.get recordType):
      (WebInspector.SourceCodeTimeline.prototype.get recordEventType):
      * UserInterface/Timeline.js: Added.
      (WebInspector.Timeline):
      (WebInspector.Timeline.prototype.get records):
      (WebInspector.Timeline.prototype.addRecord):
      * UserInterface/TimelineRecording.js:
      (WebInspector.TimelineRecording):
      (WebInspector.TimelineRecording.prototype.get timelines): Added.
      (WebInspector.TimelineRecording.prototype.sourceCodeTimelinesForSourceCode): Added.
      (WebInspector.TimelineRecording.prototype.addEventMarker): Implemented.
      (WebInspector.TimelineRecording.prototype.addRecord): Implemented.
      (WebInspector.TimelineRecording.prototype._keyForRecord): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      650bc7c5
    • timothy@apple.com's avatar
      Add support for multiple Timeline recordings. · bde56d6d
      timothy@apple.com authored
      We also don't explicitly add ResourceTimelineRecords anymore. These will be tracked automatically in a later patch.
      
      https://bugs.webkit.org/show_bug.cgi?id=123366
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/DashboardManager.js:
      (WebInspector.DashboardManager.prototype._mainResourceDidChange): Check for currentRecording.
      * UserInterface/InspectorFrontendAPI.js:
      (InspectorFrontendAPI.isTimelineProfilingEnabled): Check for currentRecording.
      * UserInterface/Main.html:
      * UserInterface/TimelineManager.js:
      (WebInspector.TimelineManager):
      (WebInspector.TimelineManager.prototype.get currentRecording): Added.
      (WebInspector.TimelineManager.prototype.startRecording): Make a new recording and push it onto the recording array.
      Add the current recording to the event.
      (WebInspector.TimelineManager.prototype.stopRecording): Add the current recording to the event.
      (WebInspector.TimelineManager.prototype.eventRecorded.processRecord): Check for currentRecording. Add the markers
      to the current recording.
      (WebInspector.TimelineManager.prototype._addRecord): Add the record to the current recording.
      (WebInspector.TimelineManager.prototype._startAutoRecording): Clean up. Don't add ResourceTimelineRecord. Clear recordings.
      (WebInspector.TimelineManager.prototype._stopAutoRecordingSoon): Check for _currentRecording.
      (WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout): Ditto.
      (WebInspector.TimelineManager.prototype._mainResourceDidChange): Don't add ResourceTimelineRecord anymore.
      (WebInspector.TimelineManager.prototype._resourceWasAdded): Removed.
      * UserInterface/TimelineRecording.js: Added.
      (WebInspector.TimelineRecording): Added.
      (WebInspector.TimelineRecording.prototype.addEventMarker): Added.
      (WebInspector.TimelineRecording.prototype.addRecord): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bde56d6d
    • timothy@apple.com's avatar
      Track callFrames and sourceCodeLocation per TimelineRecord. · d002bcf3
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123359
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/LayoutTimelineRecord.js:
      (WebInspector.LayoutTimelineRecord): Pass callFrames and sourceCodeLocation to superclass.
      * UserInterface/ScriptTimelineRecord.js:
      (WebInspector.ScriptTimelineRecord): Pass callFrames and sourceCodeLocation to superclass.
      * UserInterface/TimelineManager.js:
      (WebInspector.TimelineManager.prototype.eventRecorded.processRecord): Add "Payload" suffix to better track what is a protocol object.
      Pass the callFrames and sourceCodeLocation to all the new TimelineRecords.
      (WebInspector.TimelineManager.prototype.eventRecorded): Add "Payload" suffix.
      * UserInterface/TimelineRecord.js:
      (WebInspector.TimelineRecord):
      (WebInspector.TimelineRecord.prototype.get callFrames): Added.
      (WebInspector.TimelineRecord.prototype.get initiatorCallFrame): Added.
      (WebInspector.TimelineRecord.prototype.get sourceCodeLocation): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d002bcf3
    • timothy@apple.com's avatar
      Change how the load and content ready event timestamps are tracked. · fd0f9339
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123356
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/DashboardManager.js:
      (WebInspector.DashboardManager.prototype._updateTime): Use the timestamps on the main frame.
      * UserInterface/Frame.js:
      (WebInspector.Frame):
      (WebInspector.Frame.prototype.get domContentReadyEventTimestamp): Added.
      (WebInspector.Frame.prototype.get loadEventTimestamp): Added.
      (WebInspector.Frame.prototype.markDOMContentReadyEvent): Added.
      (WebInspector.Frame.prototype.markLoadEvent): Added.
      * UserInterface/TimelineManager.js:
      (WebInspector.TimelineManager.prototype.eventRecorded.processRecord): Use markLoadEvent and markDOMContentReadyEvent.
      Do it for all frames, not just the main frame.
      (WebInspector.TimelineManager.prototype.pageDidLoad): Call markLoadEvent on the Frame.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd0f9339
    • timothy@apple.com's avatar
      Remove a lot of the current Timelines code to make room for a new implementation. · 3d837ef6
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123368
      
      Reviewed by Joseph Pecoraro.
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/ContentView.js:
      (WebInspector.ContentView):
      (WebInspector.ContentView.isViewable):
      * UserInterface/DashboardView.js:
      (WebInspector.DashboardView.prototype._networkItemWasClicked):
      * UserInterface/InspectorFrontendAPI.js:
      (InspectorFrontendAPI.setTimelineProfilingEnabled):
      (InspectorFrontendAPI.stopProfilingJavaScript):
      * UserInterface/InstrumentSidebarPanel.js: Removed.
      * UserInterface/Main.html:
      * UserInterface/Main.js:
      (WebInspector.contentLoaded):
      (WebInspector.sidebarPanelForRepresentedObject):
      (WebInspector.openURL):
      * UserInterface/Object.js:
      (WebInspector.Object.addEventListener):
      * UserInterface/TimelineManager.js:
      (WebInspector.TimelineManager):
      (WebInspector.TimelineManager.prototype.startRecording):
      (WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
      (WebInspector.TimelineManager.prototype.eventRecorded):
      (WebInspector.TimelineManager.prototype.objectForCookie):
      (WebInspector.TimelineManager.prototype._addRecord):
      * UserInterface/TimelinesObject.js: Removed.
      * UserInterface/TimelineOverview.css: Removed.
      * UserInterface/TimelineOverview.js: Removed.
      * UserInterface/TimelineSidebarPanel.css: Added.
      * UserInterface/TimelineSidebarPanel.js: Added.
      (WebInspector.TimelineSidebarPanel):
      * UserInterface/TimelinesContentView.css: Removed.
      * UserInterface/TimelinesContentView.js: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d837ef6
  2. 20 Jan, 2014 1 commit
    • timothy@apple.com's avatar
      Fix jumping to a text position when showing a resource. · 679d978c
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127271
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/FrameContentView.js:
      (WebInspector.FrameContentView.prototype.showSourceCode): Just use showResponse's arguments
      which already does the same logic to call revealPosition.
      * UserInterface/ResourceClusterContentView.js:
      (WebInspector.ResourceClusterContentView.prototype.restoreFromCookie): This was the bug.
      lineNumber and columnNumber need honored here. They were only honored by FrameContentView.
      * UserInterface/ResourceSidebarPanel.js:
      (WebInspector.ResourceSidebarPanel.prototype.showSourceCode): Use showContentViewForRepresentedObject
      which also accepts a cookie and handles creating the content view for us.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      679d978c
  3. 16 Jan, 2014 3 commits
  4. 15 Jan, 2014 2 commits
    • bburg@apple.com's avatar
      Web Inspector: capture probe samples on the backend · 18911405
      bburg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126668
      
      Reviewed by Joseph Pecoraro.
      
      Source/JavaScriptCore:
      
      Add the 'probe' breakpoint action to the protocol. Change the setBreakpoint
      commands to return a list of assigned breakpoint action identifiers
      Add a type for breakpoint action identifiers. Add an event for sending
      captured probe samples to the inspector frontend.
      
      * inspector/protocol/Debugger.json:
      
      Source/WebCore:
      
      Test: inspector-protocol/debugger/setProbe-multiple-actions.html
      
      Add the probe breakpoint action type. A probe action
      evaluates an expression on the script call frame, and
      the result is aggregated on a per-probe basis. Each
      evaluated expression result is called a probe sample.
      
      * bindings/js/ScriptDebugServer.cpp:
      (WebCore::ScriptDebugServer::evaluateBreakpointAction): Teach
      the debug server to evaluate a probe.
      
      (WebCore::ScriptDebugServer::dispatchDidSampleProbe): Added.
      (WebCore::ScriptDebugServer::handleBreakpointHit): Increment a hit count.
      (WebCore::ScriptDebugServer::getActionsForBreakpoint):
      * bindings/js/ScriptDebugServer.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::objectGroupForBreakpointAction): Added. Create an object
      group for each breakpoint action. Currently only probes make objects.
      (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
      (WebCore::InspectorDebuggerAgent::disable):
      (WebCore::InspectorDebuggerAgent::enable): Remove stale comment.
      (WebCore::breakpointActionTypeForString): Add new case.
      (WebCore::InspectorDebuggerAgent::breakpointActionsFromProtocol): Make
      this a member function instead of a static function, so it can increment
      the breakpoint action identifier counter.
      (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): Propagate the
      assigned breakpoint action identifiers.
      (WebCore::InspectorDebuggerAgent::setBreakpoint): Propagate the
      assigned breakpoint action identifiers.
      (WebCore::InspectorDebuggerAgent::removeBreakpoint): Release object
      groups for any actions that were associated with the removed breakpoint.
      (WebCore::InspectorDebuggerAgent::didSampleProbe): Added.
      (WebCore::InspectorDebuggerAgent::clearResolvedBreakpointState): Renamed from clear().
      (WebCore::InspectorDebuggerAgent::didClearGlobalObject): Renamed from reset().
      * inspector/InspectorDebuggerAgent.h:
      * inspector/PageDebuggerAgent.cpp:
      (WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):
      * inspector/ScriptBreakpoint.h:
      (WebCore::ScriptBreakpointAction::ScriptBreakpointAction): Add identifier member.
      * inspector/ScriptDebugListener.h:
      
      Source/WebInspectorUI:
      
      * UserInterface/InspectorJSBackendCommands.js: Add probe enumeration value.
      
      LayoutTests:
      
      Add protocol tests for setting and hitting the probe breakpoint action type.
      
      * inspector-protocol/debugger/setBreakpoint-actions-expected.txt:
      * inspector-protocol/debugger/setBreakpoint-actions.html:
      * inspector-protocol/debugger/setProbe-multiple-actions-expected.txt: Added.
      * inspector-protocol/debugger/setProbe-multiple-actions.html: Added.
      * inspector-protocol/resources/probe-helper.js: Added.
      (ProbeHelper.simplifiedProbeSample):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18911405
    • akling@apple.com's avatar
      Remove the CSS selector profiler. · 6f601c10
      akling@apple.com authored
      <https://webkit.org/b/127039>
      
      Source/WebCore:
      
      The selector profiler was painting a mostly fictional picture of what
      selectors we were spending time on. It never really grokked the fast
      path selectors, nor did it understand recent additions like the extra
      cascading pass or the selector JIT.
      
      Somewhat ironically, this may end up making some selectors run faster
      since it removes a number of brances in hot code.
      
      Reviewed by Sam Weinig.
      
      * css/ElementRuleCollector.cpp:
      (WebCore::ElementRuleCollector::collectMatchingRulesForList):
      * css/ElementRuleCollector.h:
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/protocol/CSS.json:
      
      Source/WebInspectorUI:
      
      Purge selector profiler code from the new Web Inspector UI.
      
      Reviewed by Sam Weinig.
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/CSSSelectorProfileObject.js: Removed.
      * UserInterface/CSSSelectorProfileType.js: Removed.
      * UserInterface/CSSSelectorProfileView.js: Removed.
      * UserInterface/ContentView.js:
      (WebInspector.ContentView):
      (WebInspector.ContentView.isViewable):
      * UserInterface/InspectorWebBackendCommands.js:
      * UserInterface/InstrumentSidebarPanel.js:
      (WebInspector.InstrumentSidebarPanel):
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedOver):
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedDown):
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphClicked):
      (WebInspector.InstrumentSidebarPanel.prototype._profileTypeWasSelected):
      (WebInspector.InstrumentSidebarPanel.prototype._profilesCleared):
      * UserInterface/Main.html:
      * UserInterface/ProfileManager.js:
      (WebInspector.ProfileManager):
      (WebInspector.ProfileManager.prototype.initialize):
      (WebInspector.ProfileManager.prototype._checkForInterruptions):
      (WebInspector.ProfileManager.prototype._attemptToResumeProfiling):
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f601c10
  5. 13 Jan, 2014 1 commit
  6. 10 Jan, 2014 7 commits
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove unimplemented or static ScriptDebugServer features · 6b3fa793
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126784
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-10
      Reviewed by Timothy Hatcher.
      
      Source/JavaScriptCore:
      
      * inspector/protocol/Debugger.json:
      
      Source/WebCore:
      
      These features are unimplemented in the backend, and unused by the
      current frontend. Most deal with features that were supported by v8
      and are as yet unimplemented by JSC. If we decide to add such features
      we can reimplement without conforming to an old implementation.
      
      * bindings/js/ScriptDebugServer.cpp:
      * bindings/js/ScriptDebugServer.h:
      * bindings/js/ScriptProfiler.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::disable):
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::reload):
      (WebCore::InspectorPageAgent::frameNavigated):
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      * inspector/InspectorProfilerAgent.h:
      * inspector/PageDebuggerAgent.cpp:
      (WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):
      * inspector/protocol/Page.json:
      * inspector/protocol/Profiler.json:
      
      Source/WebInspectorUI:
      
      * UserInterface/InspectorJSBackendCommands.js:
      * UserInterface/InspectorWebBackendCommands.js:
      * UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
      * UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
      * Versions/Inspector-iOS-6.0.json:
      * Versions/Inspector-iOS-7.0.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b3fa793
    • timothy@apple.com's avatar
      Web Inspector: support negative numbers in secondsToString and bytesToString. · 9abd2c35
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125708
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/Utilities.js:
      (Number.secondsToString): Use Math.abs in the size checks.
      (Number.bytesToString): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9abd2c35
    • bburg@apple.com's avatar
      Web Inspector: cycle clicked breakpoints between enabled, auto-continue, and disabled · 2637715e
      bburg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126669
      
      Reviewed by Joseph Pecoraro.
      
      It's time-consuming to change a breakpoint's auto-continue setting through the
      breakpoint editor popup. This patch enables the user to toggle between enabled,
      auto-continue, and disabled by clicking on the breakpoint wedge in the sidebar
      tree and in the source text editor gutter. The auto-continue option is only
      cycled when the breakpoint has associated actions.
      
      Clean up the breakpoint editor dialog so it hides irrelevant options when
      no breakpoint actions have been added.
      
      Automatically unset auto-continue when the last breakpoint action is removed.
      
      Rename the delegate textEditorBreakpointToggled to textEditorBreakpointClicked, since
      the behavior of the click depends on breakpoint state not available in the text editor.
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/Breakpoint.js:
      (WebInspector.Breakpoint.prototype.cycleToNextMode): Added.
      (WebInspector.Breakpoint.prototype.toggleAutoContinue): Added.
      (WebInspector.Breakpoint.prototype.appendContextMenuItems): Add auto-continue options.
      (WebInspector.Breakpoint.prototype.removeAction):
      
      (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
      (WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked):
      (WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView):
      (WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView):
      (WebInspector.Breakpoint.prototype.willDismissPopover):
      * UserInterface/BreakpointTreeElement.css:
      (.item.breakpoint .status > .status-image.auto-continue):
      (.item.breakpoint .status > .status-image.disabled):
      * UserInterface/BreakpointTreeElement.js:
      (WebInspector.BreakpointTreeElement):
      (WebInspector.BreakpointTreeElement.prototype.onenter):
      (WebInspector.BreakpointTreeElement.prototype.onspace):
      (WebInspector.BreakpointTreeElement.prototype._updateStatus):
      (WebInspector.BreakpointTreeElement.prototype._breakpointLocationDidChange):
      (WebInspector.BreakpointTreeElement.prototype._statusImageElementClicked):
      * UserInterface/SourceCodeTextEditor.js:
      (WebInspector.SourceCodeTextEditor):
      (WebInspector.SourceCodeTextEditor.prototype.close):
      (WebInspector.SourceCodeTextEditor.prototype._breakpointInfoForBreakpoint):
      (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointClicked):
      * UserInterface/TextEditor.css:
      (.text-editor > .CodeMirror .breakpoint-auto-continue:not(.breakpoint-disabled) .CodeMirror-linenumber::before):
      * UserInterface/TextEditor.js:
      (WebInspector.TextEditor.prototype._setBreakpointStylesOnLine.updateStyles):
      (WebInspector.TextEditor.prototype._setBreakpointStylesOnLine):
      (WebInspector.TextEditor.prototype.updateStyles):
      (WebInspector.TextEditor.prototype._removeBreakpointFromLineAndColumn):
      (WebInspector.TextEditor.prototype._documentMouseUp):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2637715e
    • timothy@apple.com's avatar
      Clean up some areas of TreeOutline. · 3117564d
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123924
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/TreeOutline.js:
      (TreeOutline.prototype.appendChild): Don't force create _childrenListNode, it will be created
      when the tree element is expanded. Only attach if _childrenListNode already exists.
      (TreeOutline.prototype.insertChild): Ditto.
      (TreeOutline.prototype.getCachedTreeElement): Check the value of __treeElementIdentifier
      not just the existence of the property. It should never be null/undefined/0, but be safe.
      (TreeOutline.prototype.findTreeElement): Null check isAncestor, it isn't required.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3117564d
    • timothy@apple.com's avatar
      Fix an exception in WebInspector.Color. · 272d98b6
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126765
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/Color.js:
      (WebInspector.Color.fromString): Check hasOwnPrperty before using the nickname color array.
      (WebInspector.Color.prototype._toNicknameString): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      272d98b6
    • commit-queue@webkit.org's avatar
      [CSS Blending] Log blending as a layer creation reason in the WI · 8996b5b1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126159
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-10
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      * inspector/InspectorLayerTreeAgent.cpp:
      (WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
      * inspector/protocol/LayerTree.json:
      
      Source/WebInspectorUI:
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/LayerTreeSidebarPanel.js:
      (WebInspector.LayerTreeSidebarPanel.prototype._populateListOfCompositingReasons):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8996b5b1
    • commit-queue@webkit.org's avatar
      Add missing function stub in InspectorFrontendHostStub.js · 1582e3d3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126745
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-10
      Reviewed by Timothy Hatcher.
      
      * UserInterface/InspectorFrontendHostStub.js:
      (.WebInspector.InspectorFrontendHostStub.prototype.debuggableType):
      The function debuggableType() was added to InspectorFrontendHost.idl and InspectorFrontendHost.cpp
      in r160887, but not to InspectorFrontendHostStub.js.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1582e3d3
  7. 09 Jan, 2014 1 commit
    • seokju@webkit.org's avatar
      Web Inspector: Remove unused overriding protocols. · cb8504d4
      seokju@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126630
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      No new tests, No change in behavior.
      
      Remove unused overriding protocols as these are not used anymore in Frontned.
      -Page.setGeolocationOverride
      -Page.clearGeolocationOverride
      -Page.canOverrideGeolocation
      -Page.setDeviceOrientationOverride
      -Page.clearDeviceOrientationOverride
      -Page.canOverrideGeolocation
      -Network.setUserAgentOverride
      
      * Modules/geolocation/GeolocationController.cpp:
      (WebCore::GeolocationController::GeolocationController):
      (WebCore::GeolocationController::create):
      (WebCore::GeolocationController::positionChanged):
      (WebCore::provideGeolocationTo):
      * Modules/geolocation/GeolocationController.h:
      * dom/DeviceOrientationController.cpp:
      (WebCore::DeviceOrientationController::DeviceOrientationController):
      (WebCore::DeviceOrientationController::create):
      (WebCore::DeviceOrientationController::didChangeDeviceOrientation):
      (WebCore::provideDeviceOrientationTo):
      * dom/DeviceOrientationController.h:
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::InspectorPageAgent):
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::disable):
      * inspector/InspectorResourceAgent.h:
      * inspector/protocol/Network.json:
      * inspector/protocol/Page.json:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::userAgent):
      
      Source/WebInspectorUI:
      
      Update InspectorWebBackendCommands.js after removing unused overriding protocols.
      
      * UserInterface/InspectorWebBackendCommands.js:
      * UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
      * UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
      * Versions/Inspector-iOS-6.0.json:
      * Versions/Inspector-iOS-7.0.json:
      
      LayoutTests:
      
      * http/tests/inspector/extensions-useragent-expected.txt: Removed.
      * http/tests/inspector/extensions-useragent.html: Removed.
      * inspector/device-orientation-success-expected.txt: Removed.
      * inspector/device-orientation-success.html: Removed.
      * inspector/geolocation-error-expected.txt: Removed.
      * inspector/geolocation-error.html: Removed.
      * inspector/geolocation-success-expected.txt: Removed.
      * inspector/geolocation-success.html: Removed.
      * inspector/geolocation-watchPosition-expected.txt: Removed.
      * inspector/geolocation-watchPosition.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb8504d4
  8. 07 Jan, 2014 3 commits
    • commit-queue@webkit.org's avatar
      Web Inspector: Typo "clipboarPrefixString" · 7834dece
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126595
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-07
      Reviewed by Sam Weinig.
      
      * UserInterface/ConsoleCommandResult.js:
      (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
      (WebInspector.ConsoleCommandResult.prototype.get clipboardPrefixString):
      * UserInterface/ConsoleMessageImpl.js:
      (WebInspector.ConsoleMessageImpl.prototype.get clipboardPrefixString):
      (WebInspector.ConsoleMessageImpl.prototype.toClipboardString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7834dece
    • seokju@webkit.org's avatar
      Web Inspector: Remove canOverrideDeviceMetrics and setDeviceMetricsOverride from protocol · 5b14c407
      seokju@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126149
      
      Reviewed by Joseph Pecoraro.
      
      Source/WebCore:
      
      No new tests, No changes in behavior.
      
      These are not used anywhere in WebInspectorUI.
      So, it removes unused Protocols and APIs.
      
      * inspector/InspectorClient.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::InspectorPageAgent):
      (WebCore::InspectorPageAgent::disable):
      * inspector/InspectorPageAgent.h:
      * inspector/protocol/Page.json:
      
      Source/WebInspectorUI:
      
      * UserInterface/InspectorWebBackendCommands.js: Remove unused codes.
      * UserInterface/Legacy/6.0/InspectorWebBackendCommands.js: Ditto.
      * UserInterface/Legacy/7.0/InspectorWebBackendCommands.js: Ditto.
      * Versions/Inspector-iOS-6.0.json: Ditto.
      * Versions/Inspector-iOS-7.0.json: Ditto.
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/InspectorClientBlackBerry.cpp: Remove dead codes.
      * WebCoreSupport/InspectorClientBlackBerry.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b14c407
    • seokju@webkit.org's avatar
      Web Inspector: Remove support for FileSystem in Frontend. · 4dc4a12e
      seokju@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126369
      
      Reviewed by Joseph Pecoraro.
      
      Source/WebCore:
      
      No new tests, No change in behavior.
      
      Remove leftover codes from protocol after r156692.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * GNUmakefile.am:
      * inspector/InspectorFrontendClient.h:
      * inspector/InspectorFrontendClientLocal.h:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorFrontendHost.h:
      * inspector/InspectorFrontendHost.idl:
      * inspector/protocol/FileSystem.json: Removed.
      
      Source/WebInspectorUI:
      
      Update InspectorWebBackendCommands after removing 'FileSystem' domain.
      
      * UserInterface/InspectorWebBackendCommands.js:
      * UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
      * UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
      * Versions/Inspector-iOS-6.0.json:
      * Versions/Inspector-iOS-7.0.json:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4dc4a12e
  9. 06 Jan, 2014 2 commits
  10. 23 Dec, 2013 1 commit
  11. 20 Dec, 2013 4 commits
    • commit-queue@webkit.org's avatar
      Web Inspector: Frontend Error when selecting Database folder in Resources Sidebar · a62349b1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126029
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-12-19
      Reviewed by Timothy Hatcher.
      
      Treat the DatabaseHostTreeElement tree element like a folder. It pretty much
      is a folder, but inherits from StorageTreeElement to share some code there.
      
      * UserInterface/ResourceSidebarPanel.js:
      (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a62349b1
    • lforschler@apple.com's avatar
      Versioning. · 93e9b5a4
      lforschler@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93e9b5a4
    • commit-queue@webkit.org's avatar
      Web Inspector: Uncaught Exception: NavigationSidebarPanel.js: TypeError:... · 8ed466b6
      commit-queue@webkit.org authored
      Web Inspector: Uncaught Exception: NavigationSidebarPanel.js: TypeError: undefined is not a function
      https://bugs.webkit.org/show_bug.cgi?id=126018
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-12-19
      Reviewed by Timothy Hatcher.
      
      ERROR: TypeError: undefined is not a function (evaluating 'representedObject.saveIdentityToCookie(candidateObjectCookie)')
      
      There are some TreeElements (Folders, and the special Databases Folder)
      which do not have a represented object, and would throw an exception
      when trying to use saveIdentityToCookie.
      
      We should always provide a saveIdentityToCookie when possible. So just
      blacklist the tree element types we know do not have representedObjects,
      and where we don't want to save identity. This will continue to throw
      exceptions in the future for tree elements that don't have the save
      function implemented, but should.
      
      Note that even if a TreeElement is constructed with a null represented
      object, it becomes an empty object (representedObject || {}).
      
      * UserInterface/NavigationSidebarPanel.js:
      (WebInspector.NavigationSidebarPanel.prototype.saveStateToCookie):
      (WebInspector.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject):
      (WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
      (WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ed466b6
    • commit-queue@webkit.org's avatar
      Web Inspector: Add InspectorFrontendHost.debuggableType to let the frontend... · ba1f050d
      commit-queue@webkit.org authored
      Web Inspector: Add InspectorFrontendHost.debuggableType to let the frontend know it's backend is JavaScript or Web
      https://bugs.webkit.org/show_bug.cgi?id=126016
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-12-19
      Reviewed by Timothy Hatcher.
      
      Source/JavaScriptCore:
      
      * inspector/remote/RemoteInspector.mm:
      (Inspector::RemoteInspector::listingForDebuggable):
      * inspector/remote/RemoteInspectorConstants.h:
      Include a debuggable type identifier in the debuggable listing,
      so the remote frontend can know if it is debugging a Web Page
      or JS Context.
      
      Source/WebCore:
      
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::InspectorFrontendHost::debuggableType):
      * inspector/InspectorFrontendHost.h:
      * inspector/InspectorFrontendHost.idl:
      Expose the debuggableType to the frontend. In WebCore it is always a "web" type.
      
      Source/WebInspectorUI:
      
      * UserInterface/LoadInspectorBackendCommands.js:
      If the debuggable target is "web" load both JS and Web backend commands.
      Otherwise, we only load the default, js backend commands.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba1f050d
  12. 16 Dec, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Fixed Win64 build on VS2013. · b638e272
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125753
      
      Patch by Alex Christensen <achristensen@webkit.org> on 2013-12-16
      Reviewed by Brent Fulgham.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
      * JavaScriptCore.vcxproj/jsc/jsc.vcxproj:
      * JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
      * JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
      Added correct PlatformToolset for 64-bit builds.
      
      Source/ThirdParty/ANGLE:
      
      * ANGLE.vcxproj/libGLESv2.vcxproj:
      * ANGLE.vcxproj/preprocessor.vcxproj:
      * ANGLE.vcxproj/translator_common.vcxproj:
      * ANGLE.vcxproj/translator_glsl.vcxproj:
      * ANGLE.vcxproj/translator_hlsl.vcxproj:
      Added correct PlatformToolset for 64-bit builds.
      
      Source/WebCore:
      
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCoreTestSupport.vcxproj:
      Added correct PlatformToolset for 64-bit builds.
      
      Source/WebInspectorUI:
      
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
      Added 64-bit configuration.
      
      Source/WebKit:
      
      * WebKit.vcxproj/WebKit.sln:
      Use new 64-bit WebInspectorUI configurations.
      * WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
      * WebKit.vcxproj/WebKit/WebKit.vcxproj:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
      Added correct PlatformToolset for 64-bit builds.
      
      Source/WTF:
      
      * WTF.vcxproj/WTF.vcxproj:
      Added correct PlatformToolset for 64-bit builds.
      
      Tools:
      
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
      * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
      * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
      * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
      * win/record-memory/record-memory.vcxproj:
      Added correct PlatformToolset for 64-bit builds.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b638e272
  13. 14 Dec, 2013 2 commits
    • joepeck@webkit.org's avatar
      Web Inspector: Move Inspector and Debugger protocol domains into JavaScriptCore · 4591f9bc
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125707
      
      Reviewed by Timothy Hatcher.
      
      Source/JavaScriptCore:
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * GNUmakefile.am:
      * inspector/protocol/Debugger.json: Renamed from Source/WebCore/inspector/protocol/Debugger.json.
      * inspector/protocol/GenericTypes.json: Added.
      * inspector/protocol/InspectorDomain.json: Renamed from Source/WebCore/inspector/protocol/InspectorDomain.json.
      Add new files to inspector generation.
      
      * inspector/scripts/CodeGeneratorInspector.py:
      (Generator.go):
      Only build TypeBuilder output if the domain only has types. Avoid
      backend/frontend dispatchers and backend commands.
      
      (TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
      (format_setter_value_expression):
      (Generator.process_command):
      (Generator.generate_send_method):
      * inspector/scripts/CodeGeneratorInspectorStrings.py:
      Export and name the get{JS,Web}EnumConstant function.
      
      Source/WebCore:
      
        - Switch TypeBuilder::Page::SearchMatch to TypeBuilder::GenericTypes::SearchMatch
          which comes from InspectorJSTypeBuilders.
        - Remove domains that moved to JavaScriptCore.
      
      No new tests, this only moves code around. There are no functional changes.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * GNUmakefile.am:
      Add new files.
      
      * inspector/ContentSearchUtils.cpp:
      (WebCore::ContentSearchUtils::buildObjectForSearchMatch):
      (WebCore::ContentSearchUtils::searchInTextByLines):
      * inspector/ContentSearchUtils.h:
      * inspector/InspectorAgent.cpp:
      * inspector/InspectorAgent.h:
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::searchInResource):
      * inspector/InspectorPageAgent.h:
      * inspector/protocol/Page.json:
      Update includes and type builder type names.
      
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::breakpointActionTypeForString):
      (WebCore::InspectorDebuggerAgent::searchInContent):
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
      Use the new getEnum function names.
      
      Source/WebInspectorUI:
      
      * UserInterface/InspectorJSBackendCommands.js:
      * UserInterface/InspectorWebBackendCommands.js:
      Regenerate now that domains have moved around.
      
      LayoutTests:
      
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      (InspectorTest.checkForError):
      Since having a protocol error is likely wrong, make the output
      for it as detailed as possible.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4591f9bc
    • commit-queue@webkit.org's avatar
      Web Inspector: Exception: TypeError: undefined is not a function (evaluating 'marker.find()') · 21a0fdaa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125724
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-12-13
      Reviewed by Darin Adler.
      
      * UserInterface/CSSStyleDeclarationTextEditor.js:
      (WebInspector.CSSStyleDeclarationTextEditor.prototype.):
      (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
      The callback changed to returning WebInspector.TextMarkers, however
      this class expected a raw CodeMirror marker. Since this class knows
      about CodeMirror and expects to access these markers later go
      directly to the CodeMirror marker.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21a0fdaa
  14. 13 Dec, 2013 3 commits
    • joepeck@webkit.org's avatar
      Web Inspector: Add Inspector Code Generation to JavaScriptCore for Runtime Domain · 8be4912d
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125595
      
      Reviewed by Timothy Hatcher.
      
      * GNUmakefile.am:
      
      Source/JavaScriptCore:
      
        - Move CodeGeneration scripts from WebCore into JavaScriptCore/inspector/scripts
        - For ports that build WebKit frameworks separately, export the scripts as PrivateHeaders
        - Update CodeGeneratorInspector.py in a few ways:
          - output dynamic filenames, so JavaScriptCore generates InspectorJSFoo.* and WebCore generates InspectorWebFoo.*
          - take in more then one protocol JSON file. The first contains domains to generate, the others are dependencies
            that are generated elsewhere that we can depend on for Types.
        - Add DerivedSources build step to generate the Inspector Interfaces
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      * JavaScriptCore.vcxproj/copy-files.cmd:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      Add scripts and code generation.
      
      * inspector/protocol/Runtime.json: Renamed from Source/WebCore/inspector/protocol/Runtime.json.
      Move protocol file into JavaScriptCore so its types will be generated in JavaScriptCore.
      
      * inspector/scripts/CodeGeneratorInspector.py: Renamed from Source/WebCore/inspector/CodeGeneratorInspector.py.
      Updates to the script as listed above.
      
      * inspector/scripts/CodeGeneratorInspectorStrings.py: Renamed from Source/WebCore/inspector/CodeGeneratorInspectorStrings.py.
      * inspector/scripts/generate-combined-inspector-json.py: Renamed from Source/WebCore/inspector/Scripts/generate-combined-inspector-json.py.
      Moved from WebCore into JavaScriptCore for code generation.
      
      Source/WebCore:
      
        - CodeGeneration changed to output Frontend and Backend dispatchers
          in namespace Inspector. So update all the agent's appropriately.
        - Update Derived Sources code generation to use the Scripts that had
          moved to JavaScriptCore. Some ports just use JSC/inspector/scripts
          directly, but others have to use the Scripts exported by JSC
          in JavaScriptCore's PrivateHeaders.
        - Add ForwardingHeaders for the files generated in JavaScriptCore.
        - Update the names of Inspector DerivedSources files, since they
          were renamed to InspectorWeb*.
      
      No new tests, this only moves code around. There are no functional changes.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * ForwardingHeaders/inspector/InspectorJSBackendDispatchers.h: Added.
      * ForwardingHeaders/inspector/InspectorJSFrontendDispatchers.h: Added.
      * ForwardingHeaders/inspector/InspectorJSTypeBuilders.h: Added.
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.vcxproj/build-generated-files.sh:
      * WebCore.xcodeproj/project.pbxproj:
      Remove files, rename files, update code generation.
      
      * make-generated-sources.sh:
      Update this standalone developer script to fill in the new InspectorScripts variable.
      
      * inspector/ConsoleMessage.h:
      * inspector/InjectedScriptHost.cpp:
      * inspector/InspectorAgent.cpp:
      * inspector/InspectorAgent.h:
      * inspector/InspectorApplicationCacheAgent.cpp:
      * inspector/InspectorApplicationCacheAgent.h:
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorCanvasAgent.cpp:
      * inspector/InspectorCanvasAgent.h:
      * inspector/InspectorConsoleAgent.cpp:
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorController.cpp:
      * inspector/InspectorDOMAgent.cpp:
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorDOMDebuggerAgent.cpp:
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorDOMStorageAgent.cpp:
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDatabaseAgent.cpp:
      * inspector/InspectorDatabaseAgent.h:
      * inspector/InspectorDatabaseResource.cpp:
      * inspector/InspectorDatabaseResource.h:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorFrontendClientLocal.cpp:
      * inspector/InspectorHeapProfilerAgent.h:
      * inspector/InspectorIndexedDBAgent.cpp:
      * inspector/InspectorIndexedDBAgent.h:
      * inspector/InspectorInputAgent.h:
      * inspector/InspectorLayerTreeAgent.cpp:
      * inspector/InspectorLayerTreeAgent.h:
      * inspector/InspectorMemoryAgent.cpp:
      * inspector/InspectorMemoryAgent.h:
      * inspector/InspectorPageAgent.cpp:
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorRuntimeAgent.h:
      * inspector/InspectorTimelineAgent.cpp:
      * inspector/InspectorTimelineAgent.h:
      * inspector/InspectorWorkerAgent.cpp:
      * inspector/InspectorWorkerAgent.h:
      * inspector/PageRuntimeAgent.h:
      * inspector/ScriptCallFrame.cpp:
      * inspector/WorkerInspectorController.cpp:
      * inspector/WorkerRuntimeAgent.h:
      Updates header names and class namespace changes.
      
      Source/WebInspectorUI:
      
      * Scripts/copy-user-interface-resources.sh:
      Copy all the different backend commands files.
      
      * Scripts/update-InspectorBackendCommands.rb:
      Update with respect to new script location and new file names.
      
      * WebInspectorUI.xcodeproj/project.pbxproj:
      Remove Inputs and Outputs of build phase, which were wrong.
      Now this build phase always runs, and not by accident.
      
      * UserInterface/InspectorJSBackendCommands.js: Added.
      * UserInterface/InspectorWebBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/InspectorBackendCommands.js.
      * UserInterface/Legacy/6.0/InspectorWebBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorBackendCommands.js.
      * UserInterface/Legacy/7.0/InspectorWebBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorBackendCommands.js.
      * UserInterface/LoadInspectorBackendCommands.js:
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
      
      LayoutTests:
      
      * http/tests/inspector-protocol/resources/InspectorTest.js:
      (InspectorTest.importInspectorScripts):
      Update for the new backend commands files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8be4912d
    • graouts@apple.com's avatar
      Web Inspector: provide an abstraction for CodeMirror's TextMarker · e69d304a
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125695
      
      Reviewed by Timothy Hatcher.
      
      Introduce a new WebInspector.TextMarker class which is used by code with CodeMirror knowledge
      to return information related to text markers to objects that should have no direct knowledge
      of CodeMirror. Start using this class in TextEditor and SourceCodeTextEditor to remove the
      last remaining pieces of CodeMirror knowledge added to SourceCodeTextEditor to fix
      https://webkit.org/b/124364.
      
      * UserInterface/CodeMirrorAdditions.js:
      Stop using __markedColor to identify a color marker and instead use the type on the matching
      WebInspector.TextMarker. Additionally, create a WebInspector.TextMarker with type
      WebInspector.TextMarker.Type.Color in createColorMarkers().
      
      * UserInterface/CodeMirrorColorEditingController.js:
      (WebInspector.CodeMirrorColorEditingController):
      Use a WebInspector.TextRange to track the edited range and obtain it directly from the
      WebInspector.TextMaker used to instantiate the object. We also use the new "text" public
      property to create the color.
      
      (WebInspector.CodeMirrorColorEditingController.prototype.set color):
      Simply assing the serialized color to the new "text" public property.
      
      (WebInspector.CodeMirrorColorEditingController.prototype.get text):
      (WebInspector.CodeMirrorColorEditingController.prototype.set text):
      New public property to set get and set the text for the edited range, automatically updating
      the range upon setting to a new text.
      
      (WebInspector.CodeMirrorColorEditingController.prototype.presentHoverMenu):
      Obtain the bounds directly from the WebInspector.TextMarker object.
      
      * UserInterface/CodeMirrorTokenTrackingController.js:
      (WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
      Since we're now tracking the hoveredMarker as a WebInspector.TextMarker, get the CodeMirror
      TextMarker from that object to check if it's contained within the text markers at the
      hovered position.
      
      * UserInterface/Main.html:
      Add the new TextMarker class source.
      
      * UserInterface/SourceCodeTextEditor.js:
      (WebInspector.SourceCodeTextEditor.prototype._hasColorMarkers):
      Use the WebInspector.TextMarker type to identify a given text marker is marking a color.
      
      (WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerNewHighlightCandidate):
      Use the renamed markersAtPosition() method from TextEditor.
      
      (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedMarkedExpression):
      Use the WebInspector.TextMarker type to identify a given text marker is marking a color.
      
      (WebInspector.SourceCodeTextEditor.prototype.colorEditingControllerDidFinishEditing):
      Since the CodeMirrorColorEditingController is now using a WebInspector.TextRange for its range,
      update to use a WebInspector.TextRange API to get the range's start line.
      
      * UserInterface/TextEditor.js:
      (WebInspector.TextEditor.prototype.get markers):
      Return WebInspector.TextMarker objects instead of CodeMirror TextRange objects.
      
      (WebInspector.TextEditor.prototype.markersAtPosition):
      Rename method to a better name instead of using the CodeMirror-influenced name. Also, return
      WebInspector.TextMarker objects instead of CodeMirror TextRange objects.
      
      * UserInterface/TextMarker.js: Added.
      (WebInspector.TextMarker):
      Create a WebInspector.TextMarker with a CodeMirror TextMarker and an optional type.
      
      (WebInspector.TextMarker.textMarkerForCodeMirrorTextMarker):
      Static method to either obtain the existing WebInspector.TextMarker for a given CodeMirror
      TextMarker, or create a new WebInspector.TextMarker.
      
      (WebInspector.TextMarker.prototype.get codeMirrorTextMarker):
      Public property to access the CodeMirror TextMarker objects for classes that have direct
      knowledge of CodeMirror.
      
      (WebInspector.TextMarker.prototype.get type):
      Public property to access the type used to create this text marker.
      
      (WebInspector.TextMarker.prototype.get range):
      (WebInspector.TextMarker.prototype.get bounds):
      Public properties allowing easy access to generally useful information related to marked text.
      
      (WebInspector.TextMarker.prototype.clear):
      Wrapper for the CodeMirror TextMarker clear() method.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e69d304a
    • bfulgham@apple.com's avatar
      [Win] Switch WebKit solution to Visual Studio 2013 · 0d3ee590
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125192
      
      Reviewed by Anders Carlsson.
      
      Source/JavaScriptCore: 
      
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Update for VS2013
      * JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
      Ditto
      * JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Ditto
      * JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj: Ditto
      * JavaScriptCore.vcxproj/testapi/testapi.vcxproj: Ditto
      
      Source/ThirdParty: 
      
      * gtest/msvc/gtest-md.vcxproj: Update for VS2013
      
      Source/WebCore: 
      
      * WebCore.vcxproj/WebCore.vcxproj: Update for VS2013
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto
      * WebCore.vcxproj/WebCoreTestSupport.vcxproj: Ditto
      
      Source/WebInspectorUI: 
      
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Update for VS2013
      
      Source/WebKit: 
      
      * WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Update for VS2013
      * WebKit.vcxproj/WebKit.sln: Ditto
      * WebKit.vcxproj/WebKit/WebKit.vcxproj: Ditto
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj: Ditto
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Ditto
      
      Source/WTF: 
      
      * WTF.vcxproj/WTF.vcxproj: Update for VS2013
      * WTF.vcxproj/WTF.vcxproj.filters: Ditto
      
      Tools: 
      
      Project files must reference vs12_xp for 32-bit builds. 
      
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
      Update for VS2013
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
      Ditto
      * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
      Ditto
      * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
      Ditto
      * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
      Ditto
      * Scripts/webkitdirs.pm:
      (visualStudioInstallDir): Specify VS2013
      (visualStudioVersion): Ditto.
      (setupAppleWinEnv): Use VS2013 in messages
      (setupCygwinEnv): Ditto
      * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
      Update for VS2013
      * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
      Ditto
      * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
      Ditto
      * win/record-memory/record-memory.vcxproj:
      Ditto
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d3ee590
  15. 12 Dec, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Web Inspector: ES6: JavaScript syntax highlighting and recognition of for..of · c9ff3b34
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122868
      
      Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-12
      Reviewed by Timothy Hatcher.
      
      Update to CodeMirror 3.20 including javascript ES6 updates.
      
      * Tools/PrettyPrinting/codemirror.css:
      * Tools/PrettyPrinting/codemirror.js: Minor local change due to error from jsmin.py
      * Tools/PrettyPrinting/css.js:
      * Tools/PrettyPrinting/javascript.js:
      * UserInterface/External/CodeMirror/codemirror.css:
      * UserInterface/External/CodeMirror/codemirror.js: Minor local change due to error from jsmin.py
      * UserInterface/External/CodeMirror/coffeescript.js:
      * UserInterface/External/CodeMirror/css.js:
      * UserInterface/External/CodeMirror/htmlmixed.js:
      * UserInterface/External/CodeMirror/javascript.js:
      * UserInterface/External/CodeMirror/less.js:
      * UserInterface/External/CodeMirror/matchbrackets.js:
      * UserInterface/External/CodeMirror/placeholder.js:
      * UserInterface/External/CodeMirror/runmode.js:
      * UserInterface/External/CodeMirror/searchcursor.js:
      * UserInterface/External/CodeMirror/sql.js:
      * UserInterface/External/CodeMirror/xml.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9ff3b34