Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 24 Mar, 2009 18 commits
  3. 23 Mar, 2009 22 commits
    • bolsinga@apple.com's avatar
      2009-03-23 Greg Bolsinga <bolsinga@apple.com> · 506ffc8e
      bolsinga@apple.com authored 
              Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=24771
        
        DOMTimeStamps are based upon 1970.

        * platform/mac/GeolocationServiceMac.mm:
        (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      506ffc8e
    • eric@webkit.org's avatar
      Build fix, no review. · 1b38b2e5
      eric@webkit.org authored 
              * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createVisiblePosition): change .container to .isNotNull()

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b38b2e5
    • slewis@apple.com's avatar
      2009-03-23 Stephanie <slewis@apple.com> · 0424ca5d
      slewis@apple.com authored 
              Fix root build.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0424ca5d
    • eric@webkit.org's avatar
      Reviewed by Darin Adler. · 0f8de539
      eric@webkit.org authored 
              Rename Position::container to m_anchorNode and make it private
        https://bugs.webkit.org/show_bug.cgi?id=24760

        More code cleanup for Position.

        Change all uses of m_container to node()
        Eventually most uses of node() should change to anchorNode() to designate
        that it's the node the Position is anchored to, but not necessarily the
        container of the position (it could be the before/after neighbor).

        Remove any code which sets m_container, and change it to use a new
        Position::moveToPosition function which takes a node and offset.
        It never makes sense to change the node and leave the offset.

        * dom/Position.h:
        (WebCore::Position::Position):
        (WebCore::Position::clear):
        (WebCore::Position::anchorNode):
        (WebCore::Position::node):
        (WebCore::Position::moveToPosition):
        (WebCore::Position::moveToOffset):
        (WebCore::Position::isNull):
        (WebCore::Position::isNotNull):
        (WebCore::operator==):
        * dom/Range.cpp:
        (WebCore::Range::create):
        (WebCore::Range::compareBoundaryPoints):
        * dom/RangeBoundaryPoint.h:
        (WebCore::RangeBoundaryPoint::container):
        (WebCore::RangeBoundaryPoint::set):
        (WebCore::RangeBoundaryPoint::setOffset):
        (WebCore::RangeBoundaryPoint::setToChild):
        (WebCore::RangeBoundaryPoint::setToStart):
        (WebCore::RangeBoundaryPoint::setToEnd):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f8de539
    • eric@webkit.org's avatar
      Reviewed by David Hyatt. · 4732c307
      eric@webkit.org authored 
              document.write() should be able to make a document strict mode
        https://bugs.webkit.org/show_bug.cgi?id=24336

        Remove an implicit write of "<html>" on the first document.write call
        this was added as part of a KDE import http://trac.webkit.org/changeset/798
        with no layout test or explanation.  I can't think of any reason why
        an implicit <html> write is necessary (or correct), so I'm removing it and
        adding a test for the correct behavior.  The parser will add any necessary
        HTMLHTMLElements during the write() anyway.

        Our behavior is now tested by fast/dom/Document/document-write-doctype
        and matches IE, FF fails this new test.  Mozilla bug filed:
        https://bugzilla.mozilla.org/show_bug.cgi?id=483908

        * dom/Document.cpp:
        (WebCore::Document::write):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4732c307
    • oliver@apple.com's avatar
      Fix className() for API defined class · dad21980
      oliver@apple.com authored 
      Reviewed by Cameron Zwarich

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dad21980
    • weinig@apple.com's avatar
      WebCore: · 376bdde3
      weinig@apple.com authored 
      2009-03-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/6140966>
        Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/CrossOriginPreflightResultCache.cpp:
        (WebCore::CrossOriginPreflightResultCache::empty):
        * loader/CrossOriginPreflightResultCache.h:

WebKit/mac:

2009-03-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/6140966>
        Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache

        * Misc/WebCache.mm:
        (+[WebCache empty]):

WebKit/win:

2009-03-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/6140966>
        Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache

        * WebCache.cpp:
        (WebCache::empty): Also add application cache emptying to match the mac.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      376bdde3
    • darin@apple.com's avatar
      Tweak comment. · 334c76a4
      darin@apple.com authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      334c76a4
    • darin@apple.com's avatar
      WebCore: · 3b117c53
      darin@apple.com authored 
      2009-03-23  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        Bug 24726: hit testing doesn't work right when the click is on anonymous content
        https://bugs.webkit.org/show_bug.cgi?id=24726
        rdar://problem/6696992

        Test: editing/selection/hit-test-anonymous.html

        * rendering/RenderBR.cpp:
        (WebCore::RenderBR::positionForPoint): Call createVisiblePosition instead of
        creating a VisiblePosition directly. It will handle finding non-anonymous
        content nearby if node() is 0.
        * rendering/RenderBlock.cpp:
        (WebCore::positionForPointRespectingEditingBoundaries): Ditto.
        (WebCore::positionForPointWithInlineChildren): Ditto.
        (WebCore::RenderBlock::positionForPoint): Ditto.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::positionForPoint): Ditto.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::positionForPoint): Ditto.
        (WebCore::RenderObject::createVisiblePosition): Added.
        * rendering/RenderObject.h: Added createVisiblePosition.
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::positionForPoint): Call createVisiblePosition.
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::positionForPoint): Ditto.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::positionForPoint): Ditto.

LayoutTests:

2009-03-23  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        Bug 24726: hit testing doesn't work right when the click is on anonymous content
        https://bugs.webkit.org/show_bug.cgi?id=24726
        rdar://problem/6696992

        * editing/selection/hit-test-anonymous-expected.txt: Added.
        * editing/selection/hit-test-anonymous.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b117c53
    • slewis@apple.com's avatar
      2009-03-23 Stephanie Lewis <slewis@apple.com> · c769d6e6
      slewis@apple.com authored 
              Reviewed by Mark Rowe.

        Add production configuration for creating roots of WebKitTools.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c769d6e6
    • adele@apple.com's avatar
      2009-03-23 Adele Peterson <adele@apple.com> · 3ef133d1
      adele@apple.com authored 
              Reviewed by Darin Adler & Dave Hyatt.

        Fix for <rdar://problem/6621310> REGRESSION(35185): Apple Travel HTML emails missing some style after Safari 4 upgrade

        Leopard Mail doesn't expect <style> to be in the body.  This change reverts back to the old behavior of
        moving <style> to <head> for that version of Mail.

        * html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ef133d1
    • adele@apple.com's avatar
      WebCore: · 955818b6
      adele@apple.com authored 
      2009-03-23  Adele Peterson  <adele@apple.com>

        Reviewed by Mark Rowe & Dave Hyatt.

        Merge some of the individual Mail quirks into two settings that we can check for future quirks.

        * WebCore.base.exp:
        * dom/Document.cpp:
        (WebCore::disableRangeMutation):
        (WebCore::Document::nodeChildrenChanged):
        (WebCore::Document::nodeWillBeRemoved):
        (WebCore::Document::textInserted):
        (WebCore::Document::textRemoved):
        (WebCore::Document::textNodesMerged):
        (WebCore::Document::textNodeSplit):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setNeedsLeopardMailQuirks):
        (WebCore::Settings::setNeedsTigerMailQuirks):
        * page/Settings.h:
        (WebCore::Settings::needsLeopardMailQuirks):
        (WebCore::Settings::needsTigerMailQuirks):

WebKit/mac:

2009-03-23  Adele Peterson  <adele@apple.com>

        Reviewed by Mark Rowe & Dave Hyatt.

        Merge some of the individual Mail quirks into two settings that we can check for future quirks.

        * WebView/WebView.mm:
        (runningLeopardMail):
        (runningTigerMail):
        (-[WebView _preferencesChangedNotification:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      955818b6
    • oliver@apple.com's avatar
      Make testapi run as part of the standard JavaScriptCore tests. · 36109270
      oliver@apple.com authored 
      Reviewed by Geoff Garen.

We only run testapi on the mac as currently windows webkit doesn't
place all the necessary files for testapi, and we also test the
JSC/CF APIs as well.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36109270
    • adachan@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=24762 · 2ad6513d
      adachan@apple.com authored 
              Support text-indent in <option> elements on windows platform.

        Reviewed by Adele Peterson.

        * css/themeWin.css:
        * platform/PopupMenuStyle.h: We don't honor font specified on <option> elements right now.  Make this
        explicit via windows themed default stylesheet.
        (WebCore::PopupMenuStyle::PopupMenuStyle): Also store text-indent and text-direction.
        (WebCore::PopupMenuStyle::textIndent):
        (WebCore::PopupMenuStyle::textDirection):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::paint): Adjust the text's x-coordinate if text-indent is supported for options and 
        text-indent is specified with LTR direction.
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::updateOptionsWidth): Take text-indent into account if theme supports text-indent for options.
        (WebCore::RenderMenuList::itemStyle): Use new PopupMenuStyle constructor on windows.
        (WebCore::RenderMenuList::menuStyle): Ditto.
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::menuStyle): Ditto.
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::popupOptionSupportsTextIndent): Added.  Default is false since we are only supporting it in windows for now.
        * rendering/RenderThemeWin.h:
        (WebCore::RenderThemeWin::popupOptionSupportsTextIndent): Returns true for windows.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ad6513d
    • weinig@apple.com's avatar
      2009-03-23 Sam Weinig <sam@webkit.org> · 459fb8f9
      weinig@apple.com authored 
              Reviewed by Anders Carlsson.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24699
        REGRESSION: Java Applets broken
        <rdar://problem/6707494>

        Fix loading Java applets without a codeBase. Only pass the base (up to the
        the last path component) of the baseURL to the plug-in.

        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::createRenderer):
        * platform/KURL.cpp:
        (WebCore::KURL::baseAsString):
        * platform/KURL.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      459fb8f9
    • darin@apple.com's avatar
      2009-03-23 Darin Adler <darin@apple.com> · 46d2daef
      darin@apple.com authored 
              Reviewed by Sam Weinig.

        * platform/KURL.h: Removed now-incorrect comments.
        None of the parts include the separator characters any more, now that
        query doesn't include the "?", so the comments explaining which do and do
        not are no-longer helpful.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46d2daef
    • levin@chromium.org's avatar
      2009-03-23 David Levin <levin@chromium.org> · 928d4e88
      levin@chromium.org authored 
              Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24764

        Renamed files V8NodeFilter -> V8NodeFilterCondition to reflect
        class names.  Also fixed some headers that got mangled in search/replace
        operations.

        No change in behavior, so no test.

        * bindings/v8/V8NodeFilter.h: Removed.
        * bindings/v8/V8NodeFilterCondition.cpp: Renamed from WebCore/bindings/v8/V8NodeFilter.cpp.
        * bindings/v8/V8NodeFilterCondition.h: Added.
        * bindings/v8/custom/V8ClipboardCustom.cpp:
        * bindings/v8/custom/V8DocumentCustom.cpp:
        * bindings/v8/custom/V8ElementCustom.cpp:
        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
        * bindings/v8/custom/V8NavigatorCustom.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      928d4e88
    • darin@chromium.org's avatar
      2009-03-23 Darin Fisher <darin@chromium.org> · 89ace7bb
      darin@chromium.org authored 
              Reviewed by Antti Koivisto.

        https://bugs.webkit.org/show_bug.cgi?id=24741

        Adds a unique across-browser-sessions identifier to FormData, which may
        be used by ResourceHandle as a secondary cache key to enable cached
        form submissions.

        At issue: two otherwise identical form submissions may result in
        completely independent responses, which may each be appropriate to
        store and reuse from cache.

        * html/HTMLFormElement.cpp: Added call to FormData::setIdentifier so that
        we only enable cached form submissions for those generated by HTML.  This
        way we do not bother with POSTs generated by XMLHttpRequest.
        (WebCore::generateFormDataIdentifier):
        (WebCore::HTMLFormElement::createFormData):
        * platform/network/FormData.cpp: Initialize m_identifier to 0, which means
        the unspecified identifier.  So by default there is no identifier and
        nothing changes.
        (WebCore::FormData::FormData):
        * platform/network/FormData.h: Added m_identifier with setter and getter.
        (WebCore::FormData::setIdentifier):
        (WebCore::FormData::identifier):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89ace7bb
    • simon.fraser@apple.com's avatar
      2009-03-23 Simon Fraser <simon.fraser@apple.com> · 50582696
      simon.fraser@apple.com authored 
              Reviewed by Antti Koivisto

        https://bugs.webkit.org/show_bug.cgi?id=24733

        Fix media controller with full-page zoom. Previously, the media controller
        shadow nodes never saw style changes on the RenderMedia, so did not respond
        to zooming at all. Now, we update the style on the shadow renderers
        whenever RenderMedia gets a style change. Also fix the video thumb in
        the theme to be scaled properly.

        Test: media/video-controls-zoomed.html

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlShadowRootElement::updateStyle):
        (WebCore::MediaTextDisplayElement::MediaTextDisplayElement):
        (WebCore::MediaTextDisplayElement::updateStyle):
        (WebCore::MediaControlInputElement::MediaControlInputElement):
        (WebCore::MediaControlInputElement::updateStyle):
        * rendering/MediaControlElements.h:
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::styleDidChange):
        * rendering/RenderMedia.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustSliderThumbSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50582696
    • darin@chromium.org's avatar
      2009-03-23 Mike Belshe <mike@belshe.com> · 39175c66
      darin@chromium.org authored 
              Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24739

        Rework StringImpl::create methods to try to allocate a single buffer
        rather than allocating both the StringImpl class and a separate data
        buffer.

        * platform/text/StringImpl.cpp:
        * platform/text/StringImpl.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39175c66
    • darin@apple.com's avatar
      2009-03-23 Darin Adler <darin@apple.com> · b58403a1
      darin@apple.com authored 
              Reviewed by Antti Koivisto.

        Based on a patch by Nico Weber <nicolasweber@gmx.de>

        Bug 24755: LayoutTests/http/tests/misc/url-in-utf16le.html regression
        https://bugs.webkit.org/show_bug.cgi?id=24755

        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::isUTF7Encoding): Added. Checks if the current encoding
        is UTF7 without loading extended codecs.
        (WebCore::TextEncoding::encodingForFormSubmission): Use isUTF7Encoding() instead
        of comparing with UTF7Encoding(). Eliminate the explicit check of
        noExtendedTextEncodingNameUsed() because that's now handled by the functions
        that this function calls instead.

        * platform/text/TextEncoding.h: Added isUTF7Encoding function.
        Also tweaked formatting a bit.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b58403a1
    • pkasting@chromium.org's avatar
      2009-03-20 Peter Kasting <pkasting@google.com> · fb3555d6
      pkasting@chromium.org authored 
              Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24720
        RenderThemeChromium should draw something for Slider parts instead of
        dropping them on the floor.

        * platform/chromium/ChromiumBridge.h:
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
        (WebCore::RenderThemeChromiumWin::paintSliderTrack):
        (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
        (WebCore::RenderThemeChromiumWin::getThemeData):
        * rendering/RenderThemeChromiumWin.h:
        (WebCore::RenderThemeChromiumWin::paintSliderThumb):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb3555d6