1. 02 Oct, 2011 11 commits
    • barraclough@apple.com's avatar
      Bug 67455 - Different regular expression result · 4d838411
      barraclough@apple.com authored
      Reviewed by Darin Adler.
              
      Fix a regression introduced in r72140. A return was added to the backtracking loop for
      backtrackParentheses with QuantifierNonGreedy, so it always returns after one iteration.
      This is incorrect. The additional return should only trigger to force an early return if
      an error has occured.
      
      Source/JavaScriptCore: 
      
      * yarr/YarrInterpreter.cpp:
      (JSC::Yarr::Interpreter::matchParentheses):
          - Simplify some nested if else logic.
      (JSC::Yarr::Interpreter::backtrackParentheses):
          - Simplify some nested if else logic.
          - Only return early from backtrackParentheses on success/error, not on failure.
      
      LayoutTests: 
      
      * fast/regex/parentheses-expected.txt:
      * fast/regex/script-tests/parentheses.js:
          - Added test cases from bug.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d838411
    • ap@apple.com's avatar
      REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode · df3d1492
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68542
      
      Reviewed by Mark Rowe.
      
      * WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df3d1492
    • commit-queue@webkit.org's avatar
      [Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch. · 89aa83e1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69223
      
      Source/WebCore:
      
      Add a missing import (NSWindow.h) in WebVideoFullscreenHUDWindowController.
      Add a missing include path and a missing objective source file to WebCore.pro.
      
      Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
      Reviewed by Noam Rosenthal.
      
      No new tests, build fix.
      
      * WebCore.pro:
      * platform/mac/WebVideoFullscreenHUDWindowController.h:
      
      Source/WebKit2:
      
      After the merge of the Qt5 refactor branch, networking stuff has been
      extracted into a separate library. The qmlplugin needs to link to that
      library to get QNetworkReply defined.
      
      Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
      Reviewed by Noam Rosenthal.
      
      * UIProcess/API/qt/qmlplugin/qmlplugin.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89aa83e1
    • jchaffraix@webkit.org's avatar
      Remove an unused member in RenderTable::ColumnStruct · 82473e12
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69119
      
      Reviewed by Darin Adler.
      
      No test as there should be no change in behavior.
      
      The member was added several years ago and its users were removed or changed. The code would
      need a refactoring but this would be tricky to get right. This change just removes the member
      to reap the short-term benefits.
      
      * rendering/RenderTable.h:
      (WebCore::RenderTable::ColumnStruct::ColumnStruct): Remove anything associated with m_width.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82473e12
    • abarth@webkit.org's avatar
      Remove temporary baselines after http://trac.webkit.org/changeset/96470. · d75db805
      abarth@webkit.org authored
      * platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
      * platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
      * platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
      * platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
      * platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
      * platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
      * platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
      * platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
      * platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
      * platform/chromium-win-vista/svg/css: Removed.
      * platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
      * platform/chromium-win-xp/svg/css: Removed.
      * platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
      * platform/chromium-win/svg/filters/filter-clip-expected.txt: Removed.
      * platform/chromium/svg/filters: Removed.
      * platform/chromium/svg/filters/filter-clip-expected.txt: Removed.
      * platform/gtk/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
      * platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
      * platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
      * svg/css/circle-in-mask-with-shadow-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d75db805
    • abarth@webkit.org's avatar
      Clean up obsolete code in gardeningserver.py related to · ed96e6ba
      abarth@webkit.org authored
      STATIC_FILE_NAMES.  Rather than serve the UI via the Python HTTP
      server, we just serve it off the filesystem directly.
      
      We had planned to serve the UI off build.webkit.org, but that server is
      somewhat slow.  We'll probably serve the UI of some web server, but
      we'll need to work that out later.
      
      * Scripts/webkitpy/tool/commands/gardenomatic.py:
      * Scripts/webkitpy/tool/servers/gardeningserver.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed96e6ba
    • abarth@webkit.org's avatar
      Rip out half-backed garden-o-matic features in preparation for wider use · f05e533f
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69226
      
      This patch rips out a bunch of half-baked features and cleans up a
      bunch of small nits with the core set of features.  We're going to ask
      more folks to start using the tool, and having a bunch of half-baked
      features around is distracting.  We can add these features back under a
      flag and interate on them after we've got the core functionality
      nailed.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f05e533f
    • abarth@webkit.org's avatar
      Update baseline and expectations after http://trac.webkit.org/changeset/96470 · 46c3acce
      abarth@webkit.org authored
      * platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-expected.png:
      * platform/chromium-cg-mac-leopard/svg/custom/mask-colorspace-expected.png: Removed.
      * platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
      * platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
      * platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.png:
      * platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Added.
      * platform/chromium-cg-mac/svg/custom/mask-colorspace-expected.png: Added.
      * platform/chromium-cg-mac/svg/custom/mask-with-all-units-expected.png: Added.
      * platform/chromium-cg-mac/svg/filters/filter-clip-expected.png: Added.
      * platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
      * platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
      * platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
      * platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
      * platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
      * platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
      * platform/chromium-linux/svg/custom/mask-colorspace-expected.png:
      * platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
      * platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
      * platform/chromium-mac/svg/custom/mask-colorspace-expected.png:
      * platform/chromium-mac/svg/filters/filter-clip-expected.png:
      * platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
      * platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
      * platform/chromium-win-vista/svg/css: Added.
      * platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
      * platform/chromium-win-xp/svg/css: Added.
      * platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
      * platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
      * platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
      * platform/chromium-win/svg/custom/mask-colorspace-expected.png:
      * platform/chromium-win/svg/filters/filter-clip-expected.txt: Added.
      * platform/chromium/svg/filters: Added.
      * platform/chromium/svg/filters/filter-clip-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
      * platform/gtk/svg/custom/mask-with-all-units-expected.txt: Removed.
      * platform/gtk/svg/filters/filter-clip-expected.txt: Removed.
      * platform/mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
      * platform/mac/svg/custom/mask-with-all-units-expected.txt: Removed.
      * platform/mac/svg/filters/filter-clip-expected.txt: Removed.
      * platform/qt/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
      * platform/qt/svg/custom/mask-with-all-units-expected.txt: Removed.
      * platform/qt/svg/filters/filter-clip-expected.txt: Removed.
      * svg/custom/grayscale-gradient-mask-expected.txt: Added.
      * svg/custom/mask-with-all-units-expected.txt: Added.
      * svg/filters/filter-clip-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46c3acce
    • mitz@apple.com's avatar
      REGRESSION (r95502): Assertion failure in... · 00196f2b
      mitz@apple.com authored
      REGRESSION (r95502): Assertion failure in CSSPrimitiveValue::computeLengthDouble() when media query specifies unit-less length
      https://bugs.webkit.org/show_bug.cgi?id=68760
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore: 
      
      Test: fast/media/invalid-lengths.html
      
      Made length-comparison media queries accept only length values. In compatibility mode, numbers
      are allowed as well, and they are interpreted as pixels.
      
      * css/MediaQueryEvaluator.cpp:
      (WebCore::computeLength): Added this helper function.
      (WebCore::device_heightMediaFeatureEval): Changed to use computeLength().
      (WebCore::device_widthMediaFeatureEval): Ditto.
      (WebCore::heightMediaFeatureEval): Ditto.
      (WebCore::widthMediaFeatureEval): Ditto.
      
      LayoutTests: 
      
      * fast/media/invalid-lengths-expected.txt: Added.
      * fast/media/invalid-lengths.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00196f2b
    • krit@webkit.org's avatar
      SVG Mask should take 'color-interpolation' into account to determine the color... · ac4e098e
      krit@webkit.org authored
      SVG Mask should take 'color-interpolation' into account to determine the color space of the mask image
      https://bugs.webkit.org/show_bug.cgi?id=69076
      
      Source/WebCore: 
      
      Reviewed by Simon Fraser.
              
      SVG Masks should take 'color-interpolation' into account to determine the color space of the mask image.
      The behavior was changed in SVG 1.1 SE. The color space of the mask image gets defined by the computed value of the
      'color-interpolation' property. This will switch the default color space from linearRGB to sRGB for mask images and
      is a performance improvement for platforms without native support for linearRGB color space. The
      color space transformation can be avoided.
      
      Test: svg/custom/grayscale-gradient-mask-2.svg
      
      * rendering/svg/RenderSVGResourceMasker.cpp:
      (WebCore::RenderSVGResourceMasker::applyResource):
      (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
      * rendering/svg/RenderSVGResourceMasker.h:
      
      LayoutTests: 
      
      Reviewed by Simon Fraser.
              
      Added a new test case to check the behavior of SVG Masks on different values for the 'color-interpolation' property.
      Since the default color space of the mask image changes from linearRGB to sRGB, a test needed an update.
      
      * platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
      * platform/mac/svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
      * platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
      * platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
      * svg/custom/grayscale-gradient-mask-2.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac4e098e
    • abarth@webkit.org's avatar
      Tweak expectations for leopard some more. · 32b6cccd
      abarth@webkit.org authored
      * platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Removed.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32b6cccd
  2. 01 Oct, 2011 14 commits
  3. 30 Sep, 2011 15 commits
    • enne@google.com's avatar
      [chromium] Track separate scroll deltas on the compositor thread · 18158b20
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69034
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Test: new tests in CCLayerTreeHostImplTest/CCLayerTreeHostTest
      
      Track scroll deltas and maximum scrolls on LayerChromium/CCLayerImpl.
      The CCLayerImpl tree is now able to adjust these scroll deltas
      independent of the main thread. To push them back to the main thread,
      CCLayerTreeHostImpl collects them all and then bakes them into the
      scroll position during a begin frame and commit call. This allows new
      deltas to be collected while the scroll position containing the old
      delta and the old scroll position will be overwritten during the next
      commit.
      
      Only the main frame is supported right now for pushing this scroll
      delta back into the authoritative WebKit source to keep both sides in
      sync.
      
      Move tilingTransform() to the impl tree because drawTransform() is now
      updated using scroll deltas and so the results from calculating draw
      transforms needs to be dynamic so that children are updated properly.
      
      Also, exposed DebugScopedSetImplThread public because it's used in a
      few places.
      
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::pushPropertiesTo):
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore::LayerChromium::maxScrollPosition):
      (WebCore::LayerChromium::setMaxScrollPosition):
      (WebCore::LayerChromium::scrollDelta):
      (WebCore::LayerChromium::scrollable):
      * platform/graphics/chromium/NonCompositedContentHost.cpp:
      (WebCore::NonCompositedContentHost::setViewport):
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::pushPropertiesTo):
      * platform/graphics/chromium/TiledLayerChromium.h:
      * platform/graphics/chromium/cc/CCLayerImpl.cpp:
      (WebCore::CCLayerImpl::scrollBy):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore::CCLayerImpl::maxScrollPosition):
      (WebCore::CCLayerImpl::setMaxScrollPosition):
      (WebCore::CCLayerImpl::scrollDelta):
      (WebCore::CCLayerImpl::setScrollDelta):
      (WebCore::CCLayerImpl::scrollable):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::applyScrollDeltas):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
      (WebCore::calculateDrawTransformsAndVisibilityInternal):
      * platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::scrollRootLayer):
      (WebCore::CCLayerTreeHostImpl::processScrollDeltas):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      * platform/graphics/chromium/cc/CCProxy.h:
      * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
      (WebCore::CCSingleThreadProxy::start):
      (WebCore::CCSingleThreadProxy::context):
      (WebCore::CCSingleThreadProxy::finishAllRendering):
      (WebCore::CCSingleThreadProxy::initializeLayerRenderer):
      (WebCore::CCSingleThreadProxy::setNeedsCommit):
      (WebCore::CCSingleThreadProxy::stop):
      (WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
      (WebCore::CCSingleThreadProxy::commitIfNeeded):
      (WebCore::CCSingleThreadProxy::doComposite):
      * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
      (WebCore::DebugScopedSetImplThread::DebugScopedSetImplThread):
      (WebCore::DebugScopedSetImplThread::~DebugScopedSetImplThread):
      * platform/graphics/chromium/cc/CCThreadProxy.cpp:
      (WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
      (WebCore::CCThreadProxy::beginFrameAndCommit):
      * platform/graphics/chromium/cc/CCThreadProxy.h:
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
      (WebCore::CCTiledLayerImpl::tilingTransform):
      (WebCore::CCTiledLayerImpl::draw):
      * platform/graphics/chromium/cc/CCTiledLayerImpl.h:
      
      Source/WebKit/chromium:
      
      Add testing support for scroll deltas on layers.
      
      * WebKit.gypi:
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::applyScrollDelta):
      * src/WebViewImpl.h:
      * tests/CCLayerTreeHostImplTest.cpp: Added.
      (WebCore::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
      (WebCore::CCLayerTreeHostImplTest::expectClearedScrollDeltasRecursive):
      (WebCore::CCLayerTreeHostImplTest::expectContains):
      (WebCore::TEST_F):
      * tests/CCLayerTreeHostTest.cpp:
      (WTF::TestHooks::applyScrollDelta):
      (WTF::MockLayerTreeHostClient::applyScrollDelta):
      (WTF::CCLayerTreeHostTest::runTest):
      (WTF::CCLayerTreeHostTest::doBeginTest):
      (WTF::CCLayerTreeHostTestThreadOnly::runTest):
      (WTF::CCLayerTreeHostTestScrollSimple::CCLayerTreeHostTestScrollSimple):
      (WTF::CCLayerTreeHostTestScrollSimple::beginTest):
      (WTF::CCLayerTreeHostTestScrollSimple::beginCommitOnCCThread):
      (WTF::CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
      (WTF::CCLayerTreeHostTestScrollSimple::applyScrollDelta):
      (WTF::CCLayerTreeHostTestScrollSimple::afterTest):
      (WTF::TEST_F):
      (WTF::CCLayerTreeHostTestScrollMultipleRedraw::CCLayerTreeHostTestScrollMultipleRedraw):
      (WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
      (WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginCommitOnCCThread):
      (WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
      (WTF::CCLayerTreeHostTestScrollMultipleRedraw::applyScrollDelta):
      (WTF::CCLayerTreeHostTestScrollMultipleRedraw::afterTest):
      * tests/TreeSynchronizerTest.cpp:
      (WebCore::TEST):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18158b20
    • dbates@webkit.org's avatar
      2011-09-30 Daniel Bates <dbates@webkit.org> · d710332b
      dbates@webkit.org authored
              Attempt to fix the Apple Windows and WinCairo Debug builds after
              <http://trac.webkit.org/changeset/96446> (https://bugs.webkit.org/show_bug.cgi?id=69203).
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove the symbol
              ?toStrictThisObject@JSObject@JSC@@UBE?AVJSValue@2@PAVExecState@2@@Z since the
              corresponding function, JSValue::toStrictThisObject(), was removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d710332b
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=69202 · 0f060230
      hyatt@apple.com authored
              
      [CSS3 Regions] Make positioned objects use the first region as the ICB when it
      is their containing block. Make sure static distance computations take into
      account the current region as well.
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      Added new tests in fast/regions.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::adjustPositionedBlock):
      * rendering/RenderBlock.h:
      (WebCore::RenderBlock::startOffsetForContent):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
      (WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
      (WebCore::computeInlineStaticDistance):
      (WebCore::computeLogicalLeftPositionedOffset):
      (WebCore::computeLogicalTopPositionedOffset):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
      (WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
      (WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
      * rendering/RenderFlowThread.h:
      
      LayoutTests: 
      
      * fast/regions/positioned-objects-block-static-in-regions.html: Added.
      * fast/regions/positioned-objects-block-static-in-rtl-regions.html: Added.
      * fast/regions/positioned-objects-in-regions.html: Added.
      * fast/regions/positioned-objects-in-rtl-regions.html: Added.
      * fast/regions/positioned-objects-inline-static-in-regions.html: Added.
      * fast/regions/positioned-objects-inline-static-in-rtl-regions.html: Added.
      * fast/regions/positioned-objects-perpendicular-flows-in-regions.html: Added.
      * platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.png: Added.
      * platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Added.
      * platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Added.
      * platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Added.
      * platform/mac/fast/regions/positioned-objects-in-regions-expected.png: Added.
      * platform/mac/fast/regions/positioned-objects-in-regions-expected.txt: Added.
      * platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.png: Added.
      * platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.txt: Added.
      * platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.png: Added.
      * platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt: Added.
      * platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.png: Added.
      * platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt: Added.
      * platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.png: Added.
      * platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f060230
    • commit-queue@webkit.org's avatar
      DFG operation results are not set correctly in JSVALUE32_64 DFG JIT · 206d9f15
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69126
      
      Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-30
      Reviewed by Gavin Barraclough.
      
      The setupResults routine has the bug of reversing the source and destination.
      Also some other trivial (but stupid) bugs need to be fixed in JSVALUE32_64 DFG JIT.
      
      * dfg/DFGJITCodeGenerator.h:
      (JSC::DFG::setupTwoStubArgs):
      (JSC::DFG::setupResults):
      * dfg/DFGJITCodeGenerator32_64.cpp:
      (JSC::DFG::JITCodeGenerator::fillJSValue):
      (JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
      (JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      206d9f15
    • commit-queue@webkit.org's avatar
      Adding unit tests for LayerChromium. Emphasis on verifying · 44bd4c71
      commit-queue@webkit.org authored
      behavior of notifySyncRequired callback and tree manipulations.
      https://bugs.webkit.org/show_bug.cgi?id=68572
      
      Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-30
      Reviewed by James Robinson.
      
      * WebKit.gypi:
      * tests/LayerChromiumTest.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44bd4c71
    • commit-queue@webkit.org's avatar
      Implement currentColor support for CSS gradients · a4e2a27c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58730
      
      Patch by David Barr <davidbarr@chromium.org> on 2011-09-30
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Allow currentColor as a CSS3 gradient color-stop.
      
      Test: fast/css/linear-gradient-currentcolor.html
      
      * css/CSSGradientValue.cpp:
      (WebCore::CSSGradientValue::isCacheable): Make currentColor uncacheable since the
      background image may be invalidated if currentColor is used as a gradient stop and
      the value of the 'color' property changes.
      * css/CSSParser.cpp:
      (WebCore::parseGradientColorOrKeyword): Accept the currentColor keyword.
      * rendering/style/StyleGeneratedImage.cpp:
      (WebCore::StyleGeneratedImage::image): Initialize document styleSelector so that
      currentColor may be computed for a StyleGeneratedImage.
      
      LayoutTests:
      
      * fast/css/linear-gradient-currentcolor-expected.txt: Added.
      * fast/css/linear-gradient-currentcolor.html: Added.
      * platform/chromium/test_expectations.txt:
      * platform/mac/fast/css/linear-gradient-currentcolor-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4e2a27c
    • dbates@webkit.org's avatar
      Cleanup: Extract code to launch a Mac WebKit application into a common function · 570be9f3
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68662
      
      Reviewed by Adam Roben.
      
      Extracts common code to launch a WebKit application on Mac OS X into a function
      so that we can remove duplicate code.
      
      * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
      * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
      (runMacWebKitApp): Added.
      (runSafari): Modified to use webkitdirs::runMacWebKitApp().
      (runMiniBrowser): Ditto.
      (runWebKitTestRunner): Ditto.
      (runTestWebKitAPI): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      570be9f3
    • abarth@webkit.org's avatar
      Update baseline for this test on Leopard. · 8d56f3b7
      abarth@webkit.org authored
      * platform/chromium-cg-mac-leopard/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d56f3b7
    • barraclough@apple.com's avatar
      Remove toStrictThisObject, toThisString, toThisJSString · 4d5e46b5
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69203
      
      Rubber stamped by Sam Weinig
      
      These are no longer used.
      
      ../JavaScriptCore: 
      
      * JavaScriptCore.exp:
      * runtime/JSActivation.cpp:
      * runtime/JSActivation.h:
      * runtime/JSObject.cpp:
      * runtime/JSObject.h:
      * runtime/JSStaticScopeObject.cpp:
      * runtime/JSStaticScopeObject.h:
      * runtime/JSValue.h:
      * runtime/StrictEvalActivation.cpp:
      * runtime/StrictEvalActivation.h:
      
      ../WebCore: 
      
      * bindings/js/JSDOMWindowBase.cpp:
      * bindings/js/JSDOMWindowBase.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d5e46b5
    • abarth@webkit.org's avatar
      Remove ASSERT introduced in http://trac.webkit.org/changeset/96427 · 808b1ca0
      abarth@webkit.org authored
      which is triggering all over the place.
      
      Sorting this out is covered in this bug:
      https://bugs.webkit.org/show_bug.cgi?id=69200
      
      * rendering/RenderView.cpp:
      (WebCore::RenderView::layout):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      808b1ca0
    • levin@chromium.org's avatar
      watchlist: Add webkit-patch command to run watchlist. · c063ddfc
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68973
      
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/common/host.py: Exposed the watch_list.
      * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
      the cc and messages as sorted lists. To allow for deterministic ordering.
      * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
      * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
      that it will be exposed as a command by webkit-patch.
      * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
      * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
      * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
      * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
      * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
      * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
      * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
      * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c063ddfc
    • fpizlo@apple.com's avatar
      DFG does not speculate aggressively enough on put_by_id · d7113640
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=69114
      
      Reviewed by Oliver Hunt.
      
      This adds new nodes along with optimizations for those nodes:
              
      GetPropertyStorage: CheckStructure used to do both the structure
      check and retrieve the storage pointer. Now CheckStructure just
      checks the structure, and GetPropertyStorage retrieves the
      storage pointer.
              
      PutStructure: Changes the structure, and has the expected store
      to load optimization with CheckStructure.
              
      PutByOffset: Directly sets the value. Has store to load
      optimization with GetByOffset.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::cellConstant):
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGGraph.cpp:
      (JSC::DFG::Graph::dump):
      * dfg/DFGJITCodeGenerator.cpp:
      (JSC::DFG::JITCodeGenerator::writeBarrier):
      * dfg/DFGJITCodeGenerator.h:
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasStructure):
      (JSC::DFG::Node::hasStorageAccessData):
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNodePredictions):
      (JSC::DFG::Propagator::impureCSE):
      (JSC::DFG::Propagator::checkStructureLoadElimination):
      (JSC::DFG::Propagator::getByOffsetLoadElimination):
      (JSC::DFG::Propagator::getPropertyStorageLoadElimination):
      (JSC::DFG::Propagator::eliminate):
      (JSC::DFG::Propagator::performNodeCSE):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7113640
    • abarth@webkit.org's avatar
      Unreviewed, rolling out r96426. · ea04bf36
      abarth@webkit.org authored
      http://trac.webkit.org/changeset/96426
      https://bugs.webkit.org/show_bug.cgi?id=69199
      
      Broke a zillion image results on Chromium Skia Mac (Requested
      by abarth|gardener on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-30
      
      * platform/graphics/skia/GraphicsContextSkia.cpp:
      (WebCore::getFocusRingOutset):
      (WebCore::GraphicsContext::drawFocusRing):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea04bf36
    • levin@chromium.org's avatar
      watchlist: Add a way to detect a net increase or decrease of a pattern (in a file). · c54fdfe1
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69031
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
      a comment to explain something important about the email addresses, and
      a comment to let emacs know to treat the file as a python file.
      * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
      Detects increases or decreases in a pattern.
      * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
      * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
      Added unit tests for watchlist which has "more" or "less".
      * Scripts/webkitpy/common/watchlist/watchlistparser.py:
      Added support for "more" or "less".
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c54fdfe1
    • isherman@chromium.org's avatar
      Fix assertion failure in XSS Auditor · 4f8a985c
      isherman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69050
      https://code.google.com/p/chromium/issues/detail?id=97346
      
      Reviewed by Daniel Bates.
      
      Source/WebCore:
      
      Test: fast/forms/xss-auditor-doesnt-crash.html
      
      * html/parser/XSSAuditor.cpp:
      (WebCore::XSSAuditor::init): Don't try to decode the HTML body if it is empty.
      
      LayoutTests:
      
      * fast/forms/xss-auditor-doesnt-crash-expected.txt: Added.
      * fast/forms/xss-auditor-doesnt-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f8a985c