1. 13 Mar, 2010 2 commits
    • cjerdonek@webkit.org's avatar
      Changed test-webkitpy so that messages logged as a side-effect · 4d775c83
      cjerdonek@webkit.org authored
      of unit-testing code do not get displayed to the screen.  These
      messages clutter up the unit test results if not filtered out.
      
      Reviewed by Adam Barth.
      
      https://bugs.webkit.org/show_bug.cgi?id=35835
      
      * Scripts/test-webkitpy:
        - Adjusted the configure_logging() method to filter out any
          log messages from webkitpy.
        - Also added an INFO message stating that most console logging
          is getting suppressed.
      
      * Scripts/webkitpy/init/versioning.py:
        - Added a log parameter to the check_version() method.
      
      * Scripts/webkitpy/init/versioning_unittest.py:
        - Qualified a call to check_version() with the parameter names.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d775c83
    • cjerdonek@webkit.org's avatar
      The test-webkitpy script now warns the user if the script is · 477e780e
      cjerdonek@webkit.org authored
      being run using a Python version different from the minimum
      version the webkitpy package was meant to support.
      
      Reviewed by Adam Barth.
      
      https://bugs.webkit.org/show_bug.cgi?id=35788
      
      Warning developers if their Python version is too low will help
      them understand why test-webkitpy is failing.  Secondly, warning
      developers if their Python version is higher than the minimum will
      help them understand that their changes may not be okay for the
      minimum supported version, even if test-webkitpy is passing.
      
      * Scripts/test-webkitpy:
        - Moved the "from ..._unittest import *" lines to the new
          file Scripts/webkitpy/unittests.py.  This will allow the
          version-check warning to be displayed even if an error occurs
          while interpreting (i.e. importing) the unit test code.
        - Added configure_logging() to configur logging for test-webkitpy.
        - Added an init() method to configure logging and check the
          current Python version.
      
      * Scripts/webkitpy/init/unittests.py: Added.
        - Added a file to import all unit test modules in the
          webkitpy.init package.
      
      * Scripts/webkitpy/init/versioning.py: Added.
        - Added a _MINIMUM_SUPPORTED_PYTHON_VERSION variable and set
          it equal to 2.5.
        - Added a compare_version() method to compare the current Python
          version against a target version.
        - Added a check_version() method to check the current Python
          version against the current minimum supported version, and to
          log a warning message if the check fails.
      
      * Scripts/webkitpy/init/versioning_unittest.py: Added.
        - Added unit tests for the functions in versioning.py.
      
      * Scripts/webkitpy/style/unittests.py:
        - Fixed/updated a code comment.
      
      * Scripts/webkitpy/unittests.py: Added.
        - Moved the "from ..._unittest import *" lines from test-webkitpy.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      477e780e