1. 30 Sep, 2013 30 commits
  2. 29 Sep, 2013 10 commits
    • gyuyoung.kim@samsung.com's avatar
      Generate toCSSFooValue() for CSSCanvasValue · 160f135c
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122058
      
      Reviewed by Antti Koivisto.
      
      Generate toCSSFooValue() for CSSCanvasValue, and use it.
      This type cast function will help to detect bad-casts.
      isCanvasValue() is added in order to generate toCSSCanvasValue.
      
      No new tests, no behavior change.
      
      * css/CSSCanvasValue.h:
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::image):
      (WebCore::CSSImageGeneratorValue::fixedSize):
      (WebCore::CSSImageGeneratorValue::loadSubimages):
      * css/CSSValue.cpp:
      (WebCore::CSSValue::destroy):
      * css/CSSValue.h:
      (WebCore::CSSValue::isCanvasValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      160f135c
    • darin@apple.com's avatar
      Take some Xcode advice about turning on additional warnings in ANGLE and gtest · 7010becb
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122087
      
      Reviewed by Mark Rowe.
      
      Source/ThirdParty:
      
      * gtest/xcode/Config/General.xcconfig: Added some warnings that Xcode 5 suggested.
      
      Source/ThirdParty/ANGLE:
      
      * Configurations/Base.xcconfig: Add some of the warnings that Xcode 5 suggested.
      * src/compiler/preprocessor/Tokenizer.l: Defined YY_NO_INPUT so we don't compile
      an unused function and get a warning.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7010becb
    • mrowe@apple.com's avatar
      Fix the Lion build. · cd657cfb
      mrowe@apple.com authored
      Ensure that C++ and Objective-C++ files build with the right compiler flags.
      
      Source/WebCore:
      
      * Configurations/WebCore.xcconfig:
      
      Source/WebKit/mac:
      
      * Configurations/WebKit.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/BaseTarget.xcconfig:
      
      Tools:
      
      * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
      * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd657cfb
    • gyuyoung.kim@samsung.com's avatar
      Generate toCSSFooValue() for CSSLineBoxContainValue · c43751f7
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122054
      
      Reviewed by Darin Adler.
      
      As a step to use toCSSFooValue, toCSSLineBoxContainValue is generated by using
      CSS_VALUE_TYPE_CASTS. To use it, isCSSLineBoxContainValue() is changed to
      isLineBoxContatinValue(). Unnecessary local variable is removed by this patch.
      
      No new tests, no behavior changes.
      
      * css/CSSLineBoxContainValue.h:
      * css/CSSValue.cpp:
      (WebCore::CSSValue::destroy):
      * css/CSSValue.h:
      (WebCore::CSSValue::isLineBoxContainValue):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::applyProperty):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c43751f7
    • gyuyoung.kim@samsung.com's avatar
      Generate toCSSCrossfadeValue() instead of using manual function · 146b3b7b
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122057
      
      Reviewed by Antti Koivisto.
      
      Generated toCSSFooValue() supports more plenty functions rather than
      to use manual cast function.
      
      No new tests, no behavior changes.
      
      * css/CSSCrossfadeValue.h:
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::image):
      (WebCore::CSSImageGeneratorValue::fixedSize):
      (WebCore::CSSImageGeneratorValue::loadSubimages):
      * css/CSSValue.cpp:
      (WebCore::CSSValue::destroy):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      146b3b7b
    • gyuyoung.kim@samsung.com's avatar
      Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue · b8296662
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122056
      
      Reviewed by Antti Koivisto.
      
      Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue, and use it.
      This type cast function will help to detect bad-casts.
      
      No new tests, no behavior changes.
      
      * css/CSSFilterImageValue.h:
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::image):
      (WebCore::CSSImageGeneratorValue::fixedSize):
      (WebCore::CSSImageGeneratorValue::loadSubimages):
      * css/CSSInitialValue.h:
      * css/CSSValue.cpp:
      (WebCore::CSSValue::destroy):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::generatedOrPendingFromValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8296662
    • darin@apple.com's avatar
      Fix crashes caused by my recent attempt at a Windows build fix. · 9608d966
      darin@apple.com authored
              * bindings/js/WebCoreTypedArrayController.cpp:
              (WebCore::WebCoreTypedArrayController::toJS): Added back the prefix for the call to
              WebCore::toJS, otherwise this function just calls itself infinitely recursively.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9608d966
    • weinig@apple.com's avatar
      Fix the build. · af9a6b13
      weinig@apple.com authored
      * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
      (WebKit::NPRuntimeObjectMap::evaluate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af9a6b13
    • weinig@apple.com's avatar
      Cleanup PageThrottler and PageConsole a bit · f2ead0f7
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122085
      
      Reviewed by Anders Carlsson.
      
      * html/HTMLMediaElement.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::completed):
      * loader/FrameLoader.h:
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
      (WebCore::SubresourceLoader::didFinishLoading):
      (WebCore::SubresourceLoader::didFail):
      (WebCore::SubresourceLoader::willCancel):
      * loader/SubresourceLoader.h:
      Store the PageActivityAssertionToken as a std::unique_ptr.
      
      * page/Page.cpp:
      (WebCore::Page::Page):
      Use createOwned and pass this by reference for the PageThrottler and PageConsole.
      (WebCore::Page::~Page):
      Remove unnecessary clearing of an OwnPtr that is about to be destroyed.
      * page/Page.h:
      Make m_pageThrottler const and return it as a reference.
      
      * page/PageActivityAssertionToken.cpp:
      (WebCore::PageActivityAssertionToken::PageActivityAssertionToken):
      (WebCore::PageActivityAssertionToken::~PageActivityAssertionToken):
      * page/PageActivityAssertionToken.h:
      Take the PageThrottler by reference in the constructor. It is never null.
      
      * page/PageConsole.cpp:
      (WebCore::PageConsole::PageConsole):
      (WebCore::PageConsole::~PageConsole):
      (WebCore::PageConsole::addMessage):
      * page/PageConsole.h:
      Pass and store the Page as a reference and remove an extraneous null check. Remove
      the create function.
      
      * page/PageThrottler.cpp:
      (WebCore::PageThrottler::PageThrottler):
      (WebCore::PageThrottler::~PageThrottler):
      (WebCore::PageThrottler::createActivityToken):
      (WebCore::PageThrottler::throttlePage):
      (WebCore::PageThrottler::unthrottlePage):
      (WebCore::PageThrottler::addActivityToken):
      (WebCore::PageThrottler::removeActivityToken):
      * page/PageThrottler.h:
      Pass and store the Page as a reference. Move the creation of PageActivityAssertionToken here
      to aid encapsulation.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2ead0f7
    • akling@apple.com's avatar
      Pass VM instead of JSGlobalObject to function constructors. · 59875529
      akling@apple.com authored
      <https://webkit.org/b/122082>
      
      Reviewed by Darin Adler.
      
      Functions don't need anything from the global object during their
      construction and only use it to get to the VM. Reduce loads by
      simply passing the VM around instead.
      
      This patch is mostly mechanical, I just changed the signature of
      InternalFunction and worked my way from there until it built.
      
      JSC release binary size -= 4840 bytes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59875529