1. 04 Dec, 2007 6 commits
    • aroben@apple.com's avatar
      Make the implementation of Frame::setNeedsReapplyStyles cross-platform · 4cfcb8ae
      aroben@apple.com authored
       WebCore:
      
               Make the implementation of Frame::setNeedsReapplyStyles cross-platform
      
               Reviewed by Hyatt.
      
               No change in functionality.
      
               * page/Frame.cpp:
               (WebCore::Frame::setNeedsReapplyStyles): Added. Invalidates the
               FrameView so that FrameView::layout will be called, which ends up
               calling reapplyStyles.
               (WebCore::Frame::needsReapplyStyles): Added.
               (WebCore::Frame::reapplyStyles): Renamed from reparseConfiguration.
               (WebCore::FramePrivate::FramePrivate):
               * page/Frame.h:
               * page/FramePrivate.h: Added new boolean member.
               * page/FrameView.cpp:
               (WebCore::FrameView::layout): Call Frame::reapplyStyles if needed.
               (WebCore::FrameView::needsLayout): Say that we need layout if the
               Frame needs styles reapplied.
               * page/mac/WebCoreFrameBridge.h: Removed setNeedsReapplyStyles.
               * page/mac/WebCoreFrameBridge.mm:
               (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): Updated for
               rename.
      
               * bridge/win/FrameWin.cpp: Removed Frame::setNeedsReapplyStyles.
               * page/gtk/FrameGtk.cpp: Ditto.
               * page/mac/FrameMac.mm: Ditto.
               * page/qt/FrameQt.cpp: Ditto.
               * platform/wx/TemporaryLinkStubs.cpp: Ditto.
      
       WebKit/mac:
      
               Remove -[WebFrameBridge setNeedsReapplyStyles]
      
               This functionality is now WebCore's responsibility.
      
               Reviewed by Hyatt.
      
               * WebCoreSupport/WebFrameBridge.mm:
               * WebKit.order:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cfcb8ae
    • sullivan@apple.com's avatar
      Reviewed by Darin · 0360ec27
      sullivan@apple.com authored
              
              Added deleteOrigin: SPI, which isn't fully implemented
      
              * Storage/WebDatabaseManagerPrivate.h:
              * Storage/WebDatabaseManager.mm:
              (-[WebDatabaseManager deleteOrigin:]):
              just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0360ec27
    • timothy@apple.com's avatar
      Reviewed by Mark Rowe. · 85ed11c1
      timothy@apple.com authored
              Remove a check for early versions of Leopard CFNetwork now that
              Leopard has shipped.
      
              * Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX.
              * WebView/WebView.mm:
              (+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85ed11c1
    • kdecker@apple.com's avatar
      2007-12-04 Kevin Decker <kdecker@apple.com> · 4e81115b
      kdecker@apple.com authored
              Reviewed by Darin.
      
              Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
      
              This fix is exactly the same as chageset 28359 with the exception of an added early return in
              updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.
              
              The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
              only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with 
              Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context 
              regardless of whether or not it actually needs to draw. 
              
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned
              down an ASSERT that was too strict. 
              (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins
              which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow()
              function. Also tweaked a comment and added an early return if the plug-in can't draw.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e81115b
    • darin@apple.com's avatar
      WebCore: · 89c61adc
      darin@apple.com authored
              Reviewed by Kevin Decker.
      
              - added an assertion for a situation that leads to a Safari assertion:
                a commit that is not followed by a load completion
      
              - removed some unneeded FrameLoader stuff -- maybe some day we'll get this
                class cut down to size
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::FrameLoader): Added boolean for assertion.
              (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Added code to assert
              that we already sent a commit before sending a complete.
              (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Call
              client directly instead of indirecting through a function.
              (WebCore::FrameLoader::loadItem): Ditto.
              (WebCore::FrameLoader::goToItem): Ditto.
              (WebCore::FrameLoader::addHistoryForCurrentLocation): Get the private browsing
              state from Settings instead of FrameLoaderClient. Also call client directly
              instead of indirecting through a function.
              (WebCore::FrameLoader::updateHistoryForReload): Call client directly instead
              of indirecting through a function.
              (WebCore::FrameLoader::dispatchDidCommitLoad): Added code to assert
              that we did not yet send a commit and set the flag that will be used to check
              that we don't do this twice in a row without an intervening completion call.
      
              * loader/FrameLoader.h: Added a boolean for the assertion. Removed six
              now-unneeded functions.
      
              * loader/FrameLoaderClient.h: Removed now-unneeded privateBrowsingEnabled function.
      
              * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse): Get
              the private browsing state from Settings instead of FrameLoaderClient.
      
              * svg/graphics/SVGImageEmptyClients.h: Removed obsolete privateBrowsingEnabled.
      
      WebKit/gtk:
      
              Reviewed by Kevin Decker.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp: Removed obsolete privateBrowsingEnabled.
              * WebCoreSupport/FrameLoaderClientGtk.h: Ditto.
      
      WebKit/mac:
      
              Reviewed by Kevin Decker.
      
              * WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
              * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
              * WebKit.order: Ditto.
      
      WebKit/qt:
      
              Reviewed by Kevin Decker.
      
              * WebCoreSupport/FrameLoaderClientQt.cpp: Removed obsolete privateBrowsingEnabled.
              * WebCoreSupport/FrameLoaderClientQt.h: Ditto.
      
      WebKit/win:
      
              Reviewed by Kevin Decker.
      
              * WebFrame.cpp: Removed obsolete privateBrowsingEnabled.
              * WebFrame.h: Ditto.
      
      WebKit/wx:
      
              Reviewed by Kevin Decker.
      
              * WebKitSupport/FrameLoaderClientWx.cpp: Removed obsolete privateBrowsingEnabled.
              * WebKitSupport/FrameLoaderClientWx.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89c61adc
    • mrowe@apple.com's avatar
      Roll out r28359 as it causes serious problems with tabbed browsing in Safari... · f81c15cf
      mrowe@apple.com authored
      Roll out r28359 as it causes serious problems with tabbed browsing in Safari when viewing pages containing plugins (<rdar://problem/5627529>).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f81c15cf
  2. 03 Dec, 2007 5 commits
    • mitz@apple.com's avatar
      WebCore: · fe1e11ac
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
      
              Test: fast/events/resize-subframe.html
      
              * page/FrameView.cpp:
              (WebCore::FrameViewPrivate::FrameViewPrivate): Added a timer used when
              deferring tasks that need to be done after layout.
              (WebCore::FrameViewPrivate::reset):
              (WebCore::FrameView::~FrameView):
              (WebCore::FrameView::layout): Moved the updating of widget positions,
              loading plug-ins and sending events queued up during layout into
              performPostLayoutTasks(). performPostLayoutTasks() is called after
              layout unless the layout was triggered by a previous layout's post-
              layout tasks. In the latter case, performPostLayoutTasks() is scheduled
              to run later.
              (WebCore::FrameView::performPostLayoutTasks): Performs work that needs
              to be done after layout but which can result in arbitrary code
              execution and therefore may re-invalidate the layout. This includes
              updating widget positions, loading plug-ins, and dispatching layout-
              related DOM events (scroll, overflow and resize).
              (WebCore::FrameView::postLayoutTimerFired):
              (WebCore::FrameView::dispatchScheduledEvents):
              * page/FrameView.h:
              * page/mac/WebCoreFrameBridge.h:
              * page/mac/WebCoreFrameBridge.mm: Removed -sendResizeEvent since this
              is handled by FrameView now.
      
      WebKit/gtk:
      
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
      
              * WebView/webkitwebview.cpp: Remove the call to sendResizeEvent() since
              FrameView sends it now.
      
      WebKit/mac:
      
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code
              that checked if the view had resized and sent the resize event, since
              FrameView sends resize events now.
              * WebView/WebHTMLViewInternal.h:
      
      WebKit/win:
      
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
      
              * WebView.cpp:
              (WebViewWndProc): Removed call to sendResizeEvent() since FrameView
              sends them now.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test for <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
      
              * fast/events/resize-subframe-expected.txt: Added.
              * fast/events/resize-subframe.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe1e11ac
    • timothy@apple.com's avatar
      Reviewed by Darin. · d840c27d
      timothy@apple.com authored
              Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
              to return a pointer to the implementation struct instead of a copy of the struct. This changes
              all of the callers to dereference the pointer to access the struct fields.
      
              * Plugins/WebNullPluginView.mm:
              (-[WebNullPluginView reportFailure]):
              * WebCoreSupport/WebFrameBridge.mm:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
              (WebFrameLoaderClient::assignIdentifierToInitialRequest):
              (WebFrameLoaderClient::dispatchWillSendRequest):
              (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
              (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
              (WebFrameLoaderClient::dispatchDidReceiveResponse):
              (WebFrameLoaderClient::willCacheResponse):
              (WebFrameLoaderClient::dispatchDidReceiveContentLength):
              (WebFrameLoaderClient::dispatchDidFinishLoading):
              (WebFrameLoaderClient::dispatchDidFailLoading):
              (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
              (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
              (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
              (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
              (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
              (WebFrameLoaderClient::dispatchWillClose):
              (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
              (WebFrameLoaderClient::dispatchDidReceiveTitle):
              (WebFrameLoaderClient::dispatchDidCommitLoad):
              (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
              (WebFrameLoaderClient::dispatchDidFailLoad):
              (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
              (WebFrameLoaderClient::dispatchDidFinishLoad):
              (WebFrameLoaderClient::dispatchDidFirstLayout):
              * WebView/WebView.mm:
              (WebViewGetResourceLoadDelegateImplementations):
              (WebViewGetFrameLoadDelegateImplementations):
              (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
              * WebView/WebViewInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d840c27d
    • timothy@apple.com's avatar
      Reviewed by Brady Eidson. · 697e8b13
      timothy@apple.com authored
              <rdar://problem/5539913> 188 crashes in WebViewGetFrameLoadDelegateImplementations
              <rdar://problem/5586095> CrashTracer: [USER] 5000+ crashes in Safari and Dashboard in dispatchDidFailLoading
              <rdar://problem/5607081> CrashTracer: [USER] 2150 crashes in Safari at com.apple.WebKit:
              WebViewGetResourceLoadDelegateImplementations + 28
      
              * WebView/WebView.mm:
              (-[WebView _cacheResourceLoadDelegateImplementations]): If the delegate is nil, bzero the
              implementation cache. This just prevents us from calling getMethod() multiple times just to zero.
              (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.
              (WebViewGetResourceLoadDelegateImplementations): Return a zeroed implementations struct
              if the WebView is nil. This fixes the crashes.
              (WebViewGetFrameLoadDelegateImplementations): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      697e8b13
    • kdecker@apple.com's avatar
      i Reviewed by Darin. · f8995e14
      kdecker@apple.com authored
              Fixed: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
      
              The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would only call into the NPP_SetWindow()
              function when we tell the plug-in to draw. This created havoc with Flash because Flash expects the browser to call NPP_SetWindow()
              and provide a valid graphics context regardless of whether or not it actually needs to draw. 
              
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned down an ASSERT that was too strict. 
              (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins which would sometimes 
              altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow() function.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8995e14
    • ggaren@apple.com's avatar
      JavaScriptCore: · 66bf8cbb
      ggaren@apple.com authored
              Reviewed by Eric Seidel.
      
              Second step in refactoring JSGlobalObject: moved virtual functions from
              Interpreter to JSGlobalObject.
              
              Layout and JS tests pass. SunSpider reports a .7% speedup -- don't 
              believe his lies.
      
      JavaScriptGlue:
      
              Reviewed by Eric Seidel.
      
              Updated to match the JavaScriptCore change to move virtual methods from
              Interpreter to JSGlobalObject.
              
              * JSRun.cpp:
              * JSRun.h:
              * JSValueWrapper.cpp:
              (getThreadGlobalExecState):
              * JavaScriptGlue.cpp:
              (JSRunCopyGlobalObject):
              (JSRunEvaluate):
      
      WebCore:
      
              Reviewed by Eric Seidel.
      
              Updated to match the JavaScriptCore change to move virtual methods from
              Interpreter to JSGlobalObject.
              
              Moved virtual ScriptInterpreter functions to Window.
      
      WebKit/mac:
      
              Reviewed by Eric Seidel.
      
              Updated to match the JavaScriptCore change to move virtual methods from
              Interpreter to JSGlobalObject.
      
              * WebView/WebFrame.mm:
              (-[WebFrame globalContext]): Use the toRef function instead of manually
              casting.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66bf8cbb
  3. 02 Dec, 2007 1 commit
  4. 30 Nov, 2007 3 commits
  5. 29 Nov, 2007 4 commits
    • andersca@apple.com's avatar
      Reviewed by John. · 5d1ba5e3
      andersca@apple.com authored
              Rename WebKitShrinksStandaloneImagesToFitKey to WebKitShrinksStandaloneImagesToFit.
              
              This is safe to do because the preference is off by default and Safari 3, which is the only client that turns it on,
              is using the setter and not messing around with NSUserDefaults.
              
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.m:
              (+[WebPreferences initialize]):
              (-[WebPreferences shrinksStandaloneImagesToFit]):
              (-[WebPreferences setShrinksStandaloneImagesToFit:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d1ba5e3
    • beidson@apple.com's avatar
      WebCore: · 4bc8aaf8
      beidson@apple.com authored
              Reviewed by Anders
      
              Support for <rdar://problem/5556381> and <rdar://problem/5556379>
      
              The Database feature in the engine needs to support delegate calls for policy decisions and
              also provide notifications when origins and databases change their state.
      
              This patch also polishes off the missing features of the management API
      
              * page/Chrome.cpp: Implement the two UIDelegate methods
              (WebCore::Chrome::requestQuotaIncreaseForNewDatabase): Ask for more space to create a new database if it won't fit
              (WebCore::Chrome::requestQuotaIncreaseForDatabaseOperation): Ask for more space to complete an in-progress operation
              * page/Chrome.h:
              * page/ChromeClient.h:
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForNewDatabase):
              (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForDatabaseOperation):
      
              * storage/Database.cpp:
              (WebCore::Database::openDatabase): Check to see if this database can be opened - the quota must be high 
                enough and if it isn't, the UIDelegate should have a change to bump the quota.
                Also update the UI-relevant details (display name and estimated size) upon successful opening of the database
      
              * storage/DatabaseDetails.h: Remove the version parameter as it is a programatic detail of a
                site database and is not important to API clients
              (WebCore::DatabaseDetails::DatabaseDetails):
              (WebCore::DatabaseDetails::isValid):
              (WebCore::DatabaseDetails::name):
      
              * storage/DatabaseTracker.cpp:
              (WebCore::DatabaseTracker::openTrackerDatabase): Tweaked the schema here - there was a horrible bug with the old schema that would
                prevent you from having two databases of the same name from two different origins.  Also simplify the origin-management schema
              (WebCore::DatabaseTracker::canEstablishDatabase): Added.  Does some estimated size vs quota checks, and asks the UI delegate for 
                more space if necessary
              (WebCore::DatabaseTracker::hasEntryForOrigin):
              (WebCore::DatabaseTracker::establishEntryForOrigin): Establishes a tracker entry for the given origin with the current default quota
                Also notifies the client of the new origin
              (WebCore::DatabaseTracker::setDatabaseDetails): Update the display name and estimated size for the given database
              (WebCore::DatabaseTracker::fullPathForDatabase): Tweak to add the ability to get the path without creating it - for management purposes
              (WebCore::DatabaseTracker::populateOrigins): Populate origins from the Origins table instead of the Databases table
              (WebCore::DatabaseTracker::origins):
              (WebCore::DatabaseTracker::detailsForNameAndOrigin): For API management
              (WebCore::DatabaseTracker::usageForDatabase):
              (WebCore::DatabaseTracker::usageForOrigin):
              (WebCore::DatabaseTracker::quotaForOrigin):
              (WebCore::DatabaseTracker::setQuota): Notify the client
              (WebCore::DatabaseTracker::addDatabase): Notify the client 
              (WebCore::DatabaseTracker::deleteAllDatabases):
              (WebCore::DatabaseTracker::deleteDatabasesWithOrigin):
              (WebCore::DatabaseTracker::deleteDatabase):
              (WebCore::DatabaseTracker::deleteDatabaseFile):
              * storage/DatabaseTracker.h:
      
      WebKit/gtk:
      
              Keep it building with new client method
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase):
              (WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
              * WebCoreSupport/ChromeClientGtk.h:
      
      WebKit/mac:
      
              Reviewed by Anders
      
              Support for <rdar://problem/5556381> and <rdar://problem/5556379>
      
              Hook up UI Delegate calls for the database engine feature and other small tweaks
      
              * Storage/WebDatabaseManager.mm:
              (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
              (-[WebDatabaseManager deleteDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
              * Storage/WebDatabaseManagerPrivate.h:
      
              * Storage/WebDatabaseTrackerClient.h:
              * Storage/WebDatabaseTrackerClient.mm:
              (WebDatabaseTrackerClient::dispatchDidModifyDatabase): Renamed databaseName parameter to databaseIdentifier for clarity
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::requestQuotaIncreaseForNewDatabase): Call through to the UI Delegate
              (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Ditto
      
              * WebView/WebUIDelegatePrivate.h: Added the two UI Delegate methods
      
              * WebView/WebView.mm:
              (CallDelegateReturningUnsignedLongLong):
              (CallUIDelegateReturningUnsignedLongLong):
              * WebView/WebViewInternal.h:
      
      WebKit/qt:
      
              Keep it building with new client method
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::requestQuotaIncreaseForNewDatabase):
              (WebCore::ChromeClientQt::requestQuotaIncreaseForDatabaseOperation):
              * WebCoreSupport/ChromeClientQt.h:
      
      WebKit/win:
      
              Keep it building with new client method
      
              * WebChromeClient.cpp:
              (ChromeClient::requestQuotaIncreaseForNewDatabase):
              (ChromeClient::requestQuotaIncreaseForDatabaseOperation):
              * WebChromeClient.h:
      
      WebKit/wx:
      
              Keep it building with new client method
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClient::requestQuotaIncreaseForNewDatabase):
              (WebCore::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
              * WebKitSupport/ChromeClientWx.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bc8aaf8
    • kmccullough@apple.com's avatar
      Reviewed by Sam. · 31da3fbc
      kmccullough@apple.com authored
              - Added recursive runloop guards.
      
              * DefaultDelegates/WebScriptDebugServer.m:
              (-[WebScriptDebugServer suspendProcessIfPaused]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31da3fbc
    • mrowe@apple.com's avatar
      Fix an assertion failure seen on the layout tests, and when closing the window... · eff993e4
      mrowe@apple.com authored
      Fix an assertion failure seen on the layout tests, and when closing the window after visiting <http://www.coudal.com/losalamos/>.
      
      Reviewed by Oliver Hunt.
      
      * Plugins/WebBaseNetscapePluginStream.mm:
      (-[WebBaseNetscapePluginStream _destroyStream]): Unlink the file and close the file
      descriptor even when the stream is being destroyed without the load completing. This
      avoids leaking the path and file descriptor, and leaving the temporary file on disk.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eff993e4
  6. 28 Nov, 2007 2 commits
    • adele@apple.com's avatar
      Reviewed by Darin. · e6126a63
      adele@apple.com authored
              Fix for <rdar://problem/5524216> CrashTracer: [USER] 496 crashes in Safari at com.apple.WebCore: WebCore::Frame::eventHandler const + 6
      
              The CrashTracer shows a variety of crashes in different methods (including keyDown and keyUp). This change adds nil checks for the frame in 
              WebHTMLView to prevent future problems in other methods as well.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
              (-[WebHTMLView keyDown:]):
              (-[WebHTMLView keyUp:]):
              (-[WebHTMLView flagsChanged:]):
              (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
              (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
              (-[WebHTMLView checkSpelling:]):
              (-[WebHTMLView showGuessPanel:]):
              (-[WebHTMLView indent:]):
              (-[WebHTMLView outdent:]):
              (-[WebHTMLView paste:]):
              (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
              (-[WebHTMLView insertText:]):
              (-[WebHTMLView selectionTextRects]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6126a63
    • mitz@apple.com's avatar
      Reviewed by Maciej Stachowiak. · 08d5b62b
      mitz@apple.com authored
              - fix <rdar://problem/5596160> fast/events/objc-event-api.html fails when run alone (or first)
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver
              because addMouseMovedObserver returns early if the dataSource
              is not nil. But if the dataSource is already set (which happens when
              a WebHTMLView is being reused) then addMouseMovedObserver must not
              be called again.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08d5b62b
  7. 27 Nov, 2007 3 commits
    • andersca@apple.com's avatar
      Reviewed by Brady. · b23a84fb
      andersca@apple.com authored
              * Storage/WebDatabaseManager.mm:
              * Storage/WebDatabaseManagerPrivate.h:
              * Storage/WebDatabaseTrackerClient.mm:
              (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
              (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
              * Storage/WebSecurityOrigin.mm:
              (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
              * Storage/WebSecurityOriginInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b23a84fb
    • andersca@apple.com's avatar
      Reviewed by Darin, landed by Anders. · 44e28217
      andersca@apple.com authored
              Fixed: <rdar://problem/4610818> CrashTracer: 1533 crashes in Safari at com.macromedia.Flash Player.plugin: native_ShockwaveFlash_TCallLabel + 271131
      
              The problem was that some Leopard users were still inadvertently using the old Flash 8 plug-in, even though Leopard
              shipped with Flash 9. To avoid loading an older version of a plug-in when a newer version is installed, the plug-in
              database will compare bundle versions and always load the latest version.
      
              * Plugins/WebBasePluginPackage.h:
              * Plugins/WebBasePluginPackage.m:
              (-[WebBasePluginPackage versionNumber]): New method. CFBundleGetVersionNumber doesn't work with all possible versioning schemes,
              but we think for now it's good enough for us.
              * Plugins/WebPluginDatabase.m:
              (considerCandidate): Added a C utility function which compares the current plug-in against a candidate plug-in's version number.
              If both plug-ins have the same bundle ID and the candiate is newer, the current plug-in becomes the candidate.
              (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Calls the new considerCandidate() function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44e28217
    • timothy@apple.com's avatar
      WebCore: · bf423a1b
      timothy@apple.com authored
              Reviewed by Dave Hyatt.
      
              <rdar://problem/5569233> Add the ability to disable author and user CSS styles
      
              * WebCore.base.exp: Add the Settings::setAuthorAndUserStylesEnabled symbol.
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector): Add a new matchAuthorAndUserStyles parameter.
              (WebCore::CSSStyleSelector::styleForElement): Check m_matchAuthorAndUserStyles before
              matching user and author rules.
              (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto.
              (WebCore::CSSStyleSelector::styleRulesForElement): Ditto.
              * css/CSSStyleSelector.h: Add m_matchAuthorAndUserStyles and new constructor parameter.
              * dom/Document.cpp:
              (WebCore::Document::Document): Pass Settings::authorAndUserStylesEnabled to the CSSStyleSelector.
              (WebCore::Document::recalcStyleSelector): Skip collecting the author stylesheets if
              Settings::authorAndUserStylesEnabled is false, and pass that to the CSSStyleSelector.
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Initialize m_authorAndUserStylesEnabled to true.
              (WebCore::Settings::setAuthorAndUserStylesEnabled): Recalc style in all the frames
              when the setting changes.
              * page/Settings.h: Add m_authorAndUserStylesEnabled.
              (WebCore::Settings::authorAndUserStylesEnabled): Return m_authorAndUserStylesEnabled.
      
      WebKit/mac:
      
              Reviewed by Dave Hyatt.
      
              <rdar://problem/5569233> Add the ability to disable author and user CSS styles
      
              * WebView/WebPreferenceKeysPrivate.h: Define WebKitRespectStandardStyleKeyEquivalentsPreferenceKey.
              * WebView/WebPreferences.m:
              (+[WebPreferences initialize]): Default WebKitRespectStandardStyleKeyEquivalentsPreferenceKey to YES.
              (-[WebPreferences authorAndUserStylesEnabled]): Return the setting's BOOL value.
              (-[WebPreferences setAuthorAndUserStylesEnabled:]): Set the setting's BOOL value.
              * WebView/WebPreferencesPrivate.h: Add authorAndUserStylesEnabled and setAuthorAndUserStylesEnabled:.
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings::authorAndUserStylesEnabled.
      
      WebKitTools:
      
              Reviewed by Dave Hyatt.
      
              <rdar://problem/5569233> Add the ability to disable author and user CSS styles
              
              Add support for disabling author and user styles for testing.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
              * DumpRenderTree/LayoutTestController.cpp:
              (setAuthorAndUserStylesEnabledCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setAuthorAndUserStylesEnabled):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setAuthorAndUserStylesEnabled):
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              Test for: <rdar://problem/5569233> Add the ability to disable author and user CSS styles
      
              * fast/css/disabled-author-styles.html: Added.
              * platform/mac/fast/css/disabled-author-styles-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf423a1b
  8. 26 Nov, 2007 4 commits
    • beidson@apple.com's avatar
      WebCore: · 2dbe1211
      beidson@apple.com authored
              Reviewed by Mark Rowe
      
              Allow setting the default storage quota per database origin
      
              * WebCore.base.exp:
      
              * page/Settings.cpp:
              (WebCore::Settings::setDefaultDatabaseOriginQuota):
              (WebCore::Settings::defaultDatabaseOriginQuota):
              * page/Settings.h:
      
              * storage/DatabaseTracker.cpp:
              (WebCore::DatabaseTracker::DatabaseTracker):
              (WebCore::DatabaseTracker::setDefaultOriginQuota):
              (WebCore::DatabaseTracker::defaultOriginQuota):
              * storage/DatabaseTracker.h:
      
      WebKit/mac:
      
              Reviewed by Mark Rowe
      
              Provide API for setting the default storage quota per database origin
      
              * Misc/WebNSDictionaryExtras.h:
              * Misc/WebNSDictionaryExtras.m:
              (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Helper for UINT64 preferences
      
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.m:
              (-[WebPreferences _unsignedLongLongValueForKey:]): Helper for UINT64 prefs
              (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto
              (-[WebPreferences defaultDatabaseQuota]):
              (-[WebPreferences setDefaultDatabaseQuota:]):
              * WebView/WebPreferencesPrivate.h:
      
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Set the WebCore Settings version of the default storage pref
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dbe1211
    • darin@apple.com's avatar
      Reviewed by Adele. · 3975cfd5
      darin@apple.com authored
              - some middle-mouse-button-related fixes
      
              These don't affect Safari since it maps the middle mouse button to the command key,
              but that might not always be the case for future versions.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView otherMouseDown:]): Pass through middle mouse down events to WebCore.
              (-[WebHTMLView otherMouseDragged:]): Ditto, for drag events.
              (-[WebHTMLView otherMouseUp:]): Ditto, for up events.
      
              * WebView/WebPolicyDelegate.h: Fixed inaccurate documentation of WebActionButtonKey.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3975cfd5
    • andersca@apple.com's avatar
      Reviewed by Brady. · 7ab6de56
      andersca@apple.com authored
              Get rid of the WebSecurityOriginPrivate object and store 
              the WebCore::SecurityOriginData pointer in the _private field of
              the WebSecurityOrigin object instead.
              
              * Storage/WebDatabaseManager.mm:
              (-[WebDatabaseManager databasesWithOrigin:]):
              (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
              (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
              (-[WebDatabaseManager deleteDatabase:withOrigin:]):
              * Storage/WebSecurityOrigin.mm:
              (-[WebSecurityOrigin initWithProtocol:domain:port:]):
              (-[WebSecurityOrigin protocol]):
              (-[WebSecurityOrigin domain]):
              (-[WebSecurityOrigin port]):
              (-[WebSecurityOrigin usage]):
              (-[WebSecurityOrigin quota]):
              (-[WebSecurityOrigin setQuota:]):
              (-[WebSecurityOrigin dealloc]):
              (-[WebSecurityOrigin finalize]):
              (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
              (-[WebSecurityOrigin _core]):
              * Storage/WebSecurityOriginInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ab6de56
    • timothy@apple.com's avatar
      WebCore: · c6bedafa
      timothy@apple.com authored
              Reviewed by Adam Roben.
      
              Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
              http://bugs.webkit.org/show_bug.cgi?id=16137
      
              On Leopard the toolbar background will be transparent, to allow the
              window background to show through the transparent WebView. The 
              search results divs needed to move inside the "main" div, so they
              would be clipped and not show where the toolbar is.
      
              * page/InspectorController.cpp:
              (WebCore::platform): Return a string for which platform we are.
              (WebCore::InspectorController::windowScriptObjectAvailable):
              Define the platform function on the JavaScript class.
              * page/inspector/Panel.js: Add panels to the panels div.
              * page/inspector/inspector.css: On the Leopard platform make
              the toolbar background transparent so the window background shows.
              * page/inspector/inspector.html: Add a panels div and move search
              result divs inside the main div.
              * page/inspector/inspector.js: Tweak the resize code to acount for
              the search results divs moving inside the main div.
      
      WebKit/mac:
      
              Reviewed by Adam Roben.
      
              Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
              http://bugs.webkit.org/show_bug.cgi?id=16137
      
              Create the Web Inspector window with the textured style. Set the content border
              thickness for the top of the window or the height of the toolbar. Also make the
              window's bottom corners square, since a normal textured window normally has
              rounded bottom corners.
      
              * WebCoreSupport/WebInspectorClient.mm:
              (-[WebInspectorWindowController window]):
      
      WebKitLibraries:
      
              Reviewed by Adam Roben.
      
              Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
              http://bugs.webkit.org/show_bug.cgi?id=16137
      
              Add a new function to make bottom window corners square for textured windows.
      
              * WebKitSystemInterface.h:
              * libWebKitSystemInterfaceTiger.a:
              * libWebKitSystemInterfaceLeopard.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6bedafa
  9. 24 Nov, 2007 2 commits
  10. 23 Nov, 2007 1 commit
  11. 22 Nov, 2007 1 commit
    • mitz@apple.com's avatar
      WebCore: · 8476cbd0
      mitz@apple.com authored
              Reviewed by Antti Koivisto.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=15811
                WebKit plug-ins can re-enter WebKit under attach()
                <rdar://problem/5577978>
      
              Defer plug-in loading until after attach and recalcStyle using the
              post-attach callback mechanism. Netscape plug-ins are still loaded only
              after layout.
      
              * dom/ContainerNode.cpp:
              Made NodeCallbackQueue elements retain the Node because callbacks might
              delete nodes that are in the callback queue.
              (WebCore::ContainerNode::suspendPostAttachCallbacks): Added. Needed to
              prevent post-attach callbacks from being dispatched under recalcStyle().
              (WebCore::ContainerNode::resumePostAttachCallbacks): Ditto.
              (WebCore::ContainerNode::dispatchPostAttachCallbacks): Factored out from
              attach().
              (WebCore::ContainerNode::attach):
              * dom/ContainerNode.h:
              * dom/Document.cpp:
              (WebCore::Document::recalcStyle): Added calls to
              suspendPostAttachCallbacks() and resumePostAttachCallbacks().
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::HTMLEmbedElement):
              (WebCore::HTMLEmbedElement::attach): Changed to queue the widget update
              for post-attach.
              (WebCore::HTMLEmbedElement::updateWidget): Added. Called by the
              post-attach callback.
              * html/HTMLEmbedElement.h: Added an m_needWidgetUpdate member needed to
              prevent a double update if another plug-in's post-attach updateWidget()
              triggers a layout which updates the widget before this plug-in's
              post-attach callback is invoked.
              (WebCore::HTMLEmbedElement::setNeedWidgetUpdate): Added a setter for
              m_needWidgetUpdate.
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::attach): Changed to queue the widget update
              for post-attach.
              (WebCore::HTMLObjectElement::updateWidget): Added. Called by the
              post-attach callback.
              * html/HTMLObjectElement.h:
              (WebCore::HTMLObjectElement::setNeedWidgetUpdate): Added a setter for
              m_needWidgetUpdate.
              * html/HTMLPlugInElement.cpp:
              (WebCore::HTMLPlugInElement::updateWidgetCallback): Added.
              * html/HTMLPlugInElement.h:
              (WebCore::HTMLPlugInElement::updateWidget):
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::updateWidget): Added calls to
              setNeedWidgetUpdate(false) so that if this method is called from
              FrameView::layout() during post-attach dispatch of another plug-in,
              it will not be called again when this plug-in's post-attach callback
              is dispatched.
              * rendering/RenderPartObject.h:
              (WebCore::RenderPartObject::updateWidget) Renamed argument to match
              the method definition.
      
      WebKit/mac:
      
              Reviewed by Antti Koivisto.
      
              - http://bugs.webkit.org/show_bug.cgi?id=15811
                WebKit plug-ins can re-enter WebKit under attach()
                <rdar://problem/5577978>
      
              * Plugins/WebNullPluginView.mm:
              (-[WebNullPluginView viewDidMoveToWindow]): Removed workaround for the
              above bug that added as part of fixing
              <http://bugs.webkit.org/show_bug.cgi?id=15804>.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8476cbd0
  12. 21 Nov, 2007 2 commits
  13. 19 Nov, 2007 1 commit
    • beidson@apple.com's avatar
      WebCore: · 0b996016
      beidson@apple.com authored
              Reviewed by Maciej
      
              Stub out the WebCore parts of the WebKit API
      
              * WebCore.base.exp:
              * WebCore.xcodeproj/project.pbxproj:
      
              * storage/DatabaseDetails.h: Added.  Simple container for vitals on a specific database
              (WebCore::DatabaseDetails::DatabaseDetails::DatabaseDetails):
              (WebCore::DatabaseDetails::DatabaseDetails):
              (WebCore::DatabaseDetails::isValid):
              (WebCore::DatabaseDetails::name):
              (WebCore::DatabaseDetails::version):
              (WebCore::DatabaseDetails::displayName):
              (WebCore::DatabaseDetails::expectedUsage):
              (WebCore::DatabaseDetails::currentUsage):
      
              * storage/DatabaseTracker.cpp:  Added various methods for API usage
              (WebCore::DatabaseTracker::detailsForNameAndOrigin):
              (WebCore::DatabaseTracker::usageForOrigin):
              (WebCore::DatabaseTracker::quotaForOrigin):
              (WebCore::DatabaseTracker::setQuota):
              * storage/DatabaseTracker.h:
      
      WebKit:
      
              Reviewed by Maciej
      
              * WebKit.xcodeproj/project.pbxproj: Sorted!
      
      WebKit/mac:
      
              Reviewed by Maciej
      
              Finished hooking up the WebKit API for database management.
              Most of the API is actually implemented in WebCore and some of those methods might
              only be stubs for now.
      
              * Storage/WebDatabaseManager.mm:
              (-[WebDatabaseManager origins]): Call through to the WebCore tracker and construct an API result
              (-[WebDatabaseManager databasesWithOrigin:]): Ditto
              (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Ditto
      
              * Storage/WebSecurityOrigin.mm:
              (-[WebSecurityOrigin usage]): Call through to WebCore
              (-[WebSecurityOrigin quota]): Ditto
              (-[WebSecurityOrigin setQuota:]): Ditto
              (-[WebSecurityOrigin _core]): Get WebCore version of this object
              * Storage/WebSecurityOriginInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b996016
  14. 17 Nov, 2007 2 commits
    • timothy@apple.com's avatar
      WebCore: · 11650fd3
      timothy@apple.com authored
              Reviewed by Mark Rowe.
      
              Bug 13470: i18n: The Web Inspector is not localizable
              http://bugs.webkit.org/show_bug.cgi?id=13470
      
              Add support for localization to the Web Inspector. Clients need to
              implement localizedStringsURL() to return the URL of the
              InspectorLocalizedStrings.js that best matches the user's language.
      
              * English.lproj: Added.
              * English.lproj/InspectorLocalizedStrings.js: Added.
              * WebCore.xcodeproj/project.pbxproj: Add InspectorLocalizedStrings.js.
              * page/InspectorClient.h: Add localizedStringsURL.
              * page/InspectorController.cpp: Add localizedStringsURL that calls
                the client. Also added a version exposed to JavaScript.
              * page/InspectorController.h: Add localizedStringsURL.
              * page/inspector/ConsolePanel.js: Call WebInspector.UIString
                for user visible strings.
              * page/inspector/DatabasePanel.js: Ditto.
              * page/inspector/DocumentPanel.js: Ditto.
              * page/inspector/ImagePanel.js: Ditto.
              * page/inspector/MetricsSidebarPane.js: Ditto.
              * page/inspector/NetworkPanel.js: Ditto.
              * page/inspector/Panel.js: Ditto.
              * page/inspector/PropertiesSidebarPane.js: Ditto.
              * page/inspector/Resource.js: Ditto.
              * page/inspector/ResourceCategory.js: Ditto.
              * page/inspector/SourcePanel.js: Ditto.
              * page/inspector/StylesSidebarPane.js: Ditto.
              * page/inspector/inspector.css: Use pre-wrap so database errors can use \n.
              * page/inspector/inspector.html: Remove some user visible strings.
              * page/inspector/inspector.js: Added WebInspector.UIString and call
                WebInspector.UIString for user visible strings. Some code needed to be 
                moved to WebInspector.loaded to use UIString after the localized strings
                get loaded.
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyFrameLoaderClient::redirectDataToPlugin): Remove WebCore:: prefix.
              (WebCore::SVGEmptyInspectorClient::createPage): Ditto.
              (WebCore::SVGEmptyInspectorClient::localizedStringsURL): Add empty stub.
              (WebCore::SVGEmptyInspectorClient::highlight): Remove WebCore:: prefix.
              (WebCore::SVGEmptyInspectorClient::inspectedURLChanged): Ditto.
      
      WebKit:
      
              Reviewed by Mark Rowe.
      
              Bug 13470: i18n: The Web Inspector is not localizable
              http://bugs.webkit.org/show_bug.cgi?id=13470
      
              Update the localized strings and the file encoding of WebInspectorClient.mm.
      
              * English.lproj/Localizable.strings:
              * StringsNotToBeLocalized.txt:
              * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/gtk:
      
              Reviewed by Mark Rowe.
      
              Bug 13470: i18n: The Web Inspector is not localizable
              http://bugs.webkit.org/show_bug.cgi?id=13470
      
              * WebCoreSupport/InspectorClientGtk.cpp:
              (WebKit::InspectorClient::localizedStringsURL): Empty stub.
              * WebCoreSupport/InspectorClientGtk.h: Add localizedStringsURL.
      
      WebKit/mac:
      
              Reviewed by Mark Rowe.
      
              Bug 13470: i18n: The Web Inspector is not localizable
              http://bugs.webkit.org/show_bug.cgi?id=13470
      
              Implement the localizedStringsURL() client method to return the
              localized URL of InspectorLocalizedStrings.js in WebCore.
      
              * WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
              * WebCoreSupport/WebInspectorClient.mm:
              (WebInspectorClient::localizedStringsURL): Added.
              (WebInspectorClient::updateWindowTitle): Localized the window title.
              (-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore.
              (-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.
      
      WebKit/qt:
      
              Reviewed by Mark Rowe.
      
              Bug 13470: i18n: The Web Inspector is not localizable
              http://bugs.webkit.org/show_bug.cgi?id=13470
      
              * WebCoreSupport/InspectorClientQt.cpp:
              (WebCore::InspectorClientQt::localizedStringsURL): Empty stub.
              * WebCoreSupport/InspectorClientQt.h: Added localizedStringsURL.
      
      WebKit/win:
      
              Reviewed by Mark Rowe.
      
              Bug 13470: i18n: The Web Inspector is not localizable
              http://bugs.webkit.org/show_bug.cgi?id=13470
      
              * English.lproj/Localizable.strings: Updated.
              * WebInspectorClient.cpp:
              (WebInspectorClient::localizedStringsURL): Empty stub.
              * WebInspectorClient.h: Added localizedStringsURL.
      
      WebKit/wx:
      
              Reviewed by Mark Rowe.
      
              Bug 13470: i18n: The Web Inspector is not localizable
              http://bugs.webkit.org/show_bug.cgi?id=13470
      
              * WebKitSupport/InspectorClientWx.cpp:
              (WebCore::InspectorClientWx::localizedStringsURL): Empty stub.
              * WebKitSupport/InspectorClientWx.h: Added localizedStringsURL.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11650fd3
    • ap@webkit.org's avatar
      Reviewed by Darin. · fa4fbed0
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=15969
              Eliminate Editor::deleteRange()
      
              No change in functionality.
      
      WebCore:
              * editing/CompositeEditCommand.h: Removed unimplemented deleteKeyPressed().
      
              * editing/Editor.cpp:
              (WebCore::Editor::deleteWithDirection):
              (WebCore::Editor::cut):
              (WebCore::Editor::performDelete):
              * editing/Editor.h:
              Moved relevant Editor::deleteRange() functionality to its callers.
              Removed deleteSelectionWithSmartDelete(void), which was more confusing than helpful
              in my opinion.
      
              * editing/mac/EditorMac.mm:
              (WebCore::initializeKillRingIfNeeded):
              (WebCore::Editor::addToKillRing):
              (WebCore::Editor::yank):
              (WebCore::Editor::yankAndSelect):
              (WebCore::Editor::setMark):
              (WebCore::unionDOMRanges):
              (WebCore::Editor::deleteToMark):
              (WebCore::Editor::selectToMark):
              (WebCore::Editor::swapWithMark):
              Pushed kill ring handling down from WebCore.
      
              * page/mac/WebCoreFrameBridge.h:
              * page/mac/WebCoreFrameBridge.mm:
              Removed setMarkDOMRange (the corresponding getter is still needed).
      
              * WebCore.base.exp: No longer need to export Editor::deleteRange() and Editor::insertTextWithoutSendingTextEvent().
              Export the new kill ring functions.
      
      WebKit:
              * WebView/WebHTMLView.mm:
              (+[WebHTMLView initialize]):
              (-[WebHTMLView yank:]):
              (-[WebHTMLView yankAndSelect:]):
              (-[WebHTMLView setMark:]):
              (-[WebHTMLView deleteToMark:]):
              (-[WebHTMLView selectToMark:]):
              (-[WebHTMLView swapWithMark:]):
              Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa4fbed0
  15. 16 Nov, 2007 3 commits
    • mrowe@apple.com's avatar
      7b0d32cd
    • sullivan@apple.com's avatar
      Reviewed by Brady · 4581215a
      sullivan@apple.com authored
              * WebKit.exp:
              Exported some new database-related symbols
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4581215a
    • beidson@apple.com's avatar
      WebKit/mac: · 47f26516
      beidson@apple.com authored
              Reviewed by John
      
              Database management API tweaks
      
              Fleshed out "WebSecurityOrigin" to be the API object representing an origin.  This relieves some
              burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself
      
              Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
              the WebKit tree?
      
              * Misc/WebSecurityOrigin.mm: Removed.
              * Misc/WebSecurityOriginInternal.h: Removed.
              * Misc/WebSecurityOriginPrivate.h: Removed.
      
              * Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
              * Storage/WebDatabaseManagerPrivate.h:
      
              * Storage/WebSecurityOrigin.mm: Added.
              (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
              (-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]):
              (-[WebSecurityOriginPrivate finalize]):
              (-[WebSecurityOriginPrivate dealloc]):
              (-[WebSecurityOrigin initWithProtocol:domain:]):
              (-[WebSecurityOrigin initWithProtocol:domain:port:]):
              (-[WebSecurityOrigin protocol]):
              (-[WebSecurityOrigin domain]):
              (-[WebSecurityOrigin port]):
              (-[WebSecurityOrigin usage]):
              (-[WebSecurityOrigin quota]):
              (-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself
              (-[WebSecurityOrigin dealloc]):
              (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
              * Storage/WebSecurityOriginInternal.h: Added.
              * Storage/WebSecurityOriginPrivate.h: Added.
      
      WebKit:
      
              Reviewed by John
      
              Database management API tweaks
      
              * WebKit.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47f26516