- 04 Dec, 2007 26 commits
-
-
aroben@apple.com authored
WebCore: Make the implementation of Frame::setNeedsReapplyStyles cross-platform Reviewed by Hyatt. No change in functionality. * page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): Added. Invalidates the FrameView so that FrameView::layout will be called, which ends up calling reapplyStyles. (WebCore::Frame::needsReapplyStyles): Added. (WebCore::Frame::reapplyStyles): Renamed from reparseConfiguration. (WebCore::FramePrivate::FramePrivate): * page/Frame.h: * page/FramePrivate.h: Added new boolean member. * page/FrameView.cpp: (WebCore::FrameView::layout): Call Frame::reapplyStyles if needed. (WebCore::FrameView::needsLayout): Say that we need layout if the Frame needs styles reapplied. * page/mac/WebCoreFrameBridge.h: Removed setNeedsReapplyStyles. * page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): Updated for rename. * bridge/win/FrameWin.cpp: Removed Frame::setNeedsReapplyStyles. * page/gtk/FrameGtk.cpp: Ditto. * page/mac/FrameMac.mm: Ditto. * page/qt/FrameQt.cpp: Ditto. * platform/wx/TemporaryLinkStubs.cpp: Ditto. WebKit/mac: Remove -[WebFrameBridge setNeedsReapplyStyles] This functionality is now WebCore's responsibility. Reviewed by Hyatt. * WebCoreSupport/WebFrameBridge.mm: * WebKit.order: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Prospective Win DRT build fix. * DumpRenderTree/DumpRenderTree.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
Pass intrinsic size to the base class. * rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jhoneycutt@apple.com authored
Reviewed by Ollie. Don't crash if our JavaPlugin DLL can't be found * WebFrame.cpp: (WebFrame::createJavaAppletWidget): Added null check git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sullivan@apple.com authored
Added deleteOrigin: SPI, which isn't fully implemented * Storage/WebDatabaseManagerPrivate.h: * Storage/WebDatabaseManager.mm: (-[WebDatabaseManager deleteOrigin:]): just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele@apple.com authored
Fix for <rdar://problem/5578209> REGRESSION: Crash in WebCore::DeprecatedValueListImpl::Private::copyList when going back on zoomerang.com/survey * loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation): When the new url is exactly the same as the old url, don't treat it like a fragment navigation, since its going to cause a reload. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
Remove a check for early versions of Leopard CFNetwork now that Leopard has shipped. * Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX. * WebView/WebView.mm: (+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kdecker@apple.com authored
Reviewed by Darin. Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang This fix is exactly the same as chageset 28359 with the exception of an added early return in updateAndSetWindow to cover the additional case of when a plug-in isn't drawable. The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context regardless of whether or not it actually needs to draw. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned down an ASSERT that was too strict. (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow() function. Also tweaked a comment and added an early return if the plug-in can't draw. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
Reviewed by Kevin Decker. - added an assertion for a situation that leads to a Safari assertion: a commit that is not followed by a load completion - removed some unneeded FrameLoader stuff -- maybe some day we'll get this class cut down to size * loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): Added boolean for assertion. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Added code to assert that we already sent a commit before sending a complete. (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Call client directly instead of indirecting through a function. (WebCore::FrameLoader::loadItem): Ditto. (WebCore::FrameLoader::goToItem): Ditto. (WebCore::FrameLoader::addHistoryForCurrentLocation): Get the private browsing state from Settings instead of FrameLoaderClient. Also call client directly instead of indirecting through a function. (WebCore::FrameLoader::updateHistoryForReload): Call client directly instead of indirecting through a function. (WebCore::FrameLoader::dispatchDidCommitLoad): Added code to assert that we did not yet send a commit and set the flag that will be used to check that we don't do this twice in a row without an intervening completion call. * loader/FrameLoader.h: Added a boolean for the assertion. Removed six now-unneeded functions. * loader/FrameLoaderClient.h: Removed now-unneeded privateBrowsingEnabled function. * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse): Get the private browsing state from Settings instead of FrameLoaderClient. * svg/graphics/SVGImageEmptyClients.h: Removed obsolete privateBrowsingEnabled. WebKit/gtk: Reviewed by Kevin Decker. * WebCoreSupport/FrameLoaderClientGtk.cpp: Removed obsolete privateBrowsingEnabled. * WebCoreSupport/FrameLoaderClientGtk.h: Ditto. WebKit/mac: Reviewed by Kevin Decker. * WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled. * WebCoreSupport/WebFrameLoaderClient.mm: Ditto. * WebKit.order: Ditto. WebKit/qt: Reviewed by Kevin Decker. * WebCoreSupport/FrameLoaderClientQt.cpp: Removed obsolete privateBrowsingEnabled. * WebCoreSupport/FrameLoaderClientQt.h: Ditto. WebKit/win: Reviewed by Kevin Decker. * WebFrame.cpp: Removed obsolete privateBrowsingEnabled. * WebFrame.h: Ditto. WebKit/wx: Reviewed by Kevin Decker. * WebKitSupport/FrameLoaderClientWx.cpp: Removed obsolete privateBrowsingEnabled. * WebKitSupport/FrameLoaderClientWx.h: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
Reviewed by Adele. Fix <rdar://problem/5624802> Controller displays outside of <video> element when width and height aren't specified - Explicitly adjust size of the controls tree root. - Switch RenderMedia base class back to RenderReplaced. It is easier to manage the shadow tree by hand. This also allows better code sharing with other replaced element classes. - Move duplicated layout and painting code from subclasses up to RenderReplaced. Test: media/video-controls-rendering.html * rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced): * rendering/RenderHTMLCanvas.h: Share code. * rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::minimumReplacedHeight): * rendering/RenderImage.h: Share code. * rendering/RenderMedia.cpp: (WebCore::RenderMediaControlShadowRoot::RenderMediaControlShadowRoot): (WebCore::RenderMediaControlShadowRoot::setParent): Add a subclass just to get through encapsulation to use setParent(). (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): Move initialization to the constructor. (WebCore::RenderMedia::RenderMedia): (WebCore::RenderMedia::~RenderMedia): (WebCore::RenderMedia::layout): Resize and layout the controller root by hand. (WebCore::RenderMedia::firstChild): (WebCore::RenderMedia::lastChild): (WebCore::RenderMedia::removeChild): Support one child renderer for controls. (WebCore::RenderMedia::createControlsShadowRoot): * rendering/RenderMedia.h: (WebCore::RenderMedia::isMedia): Switch base class to RenderReplaced, delete the now unnecessary stuff. * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): (WebCore::RenderReplaced::paint): * rendering/RenderReplaced.h: (WebCore::RenderReplaced::minimumReplacedHeight): (WebCore::RenderReplaced::paintReplaced): Share code. * rendering/RenderVideo.cpp: (WebCore::RenderVideo::videoSizeChanged): Simplify, just request relayout. (WebCore::RenderVideo::paintReplaced): (WebCore::RenderVideo::layout): * rendering/RenderVideo.h: Share code. LayoutTests: Reviewed by Adele. Test for <rdar://problem/5624802> Controller displays outside of <video> element when width and height aren't specified * media/remove-from-document.html: Improve coverage by doing relayout before finishing. * media/video-controls-rendering.html: Added. * platform/mac/media/video-controls-rendering-expected.checksum: Added. * platform/mac/media/video-controls-rendering-expected.png: Added. * platform/mac/media/video-controls-rendering-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Reviewed by Alp Toker. * WebCore.pro: fix build of webkit-marshal by building the functions into a separate .cpp file instead of including them in the header. This way we can use the marshallers from more than one file without using bad hacks. Add the generated sources directory to DEPENDPATH. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
Reviewed by Geoff. - fix first part of http://bugs.webkit.org/show_bug.cgi?id=16220 <rdar://problem/5625221> Crash opening www.news.com (CNet) Test: fast/js/regexp-overflow.html * pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Add room for the additional BRA/KET that was generated in the compile code but not taken into account here. LayoutTests: Reviewed by Geoff. - test for first part of http://bugs.webkit.org/show_bug.cgi?id=16220 <rdar://problem/5625221> Crash opening www.news.com (CNet) * fast/js/regexp-overflow-expected.txt: Updated. * fast/js/resources/regexp-overflow.js: Added test cases. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
* WebScriptCallFrame.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Reviewed by Mark Rowe. Link to Planet WebKit. * nav.inc: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Reviewed by Alp Toker. http://bugs.webkit.org/show_bug.cgi?id=16145 [gtk] Implement media support in GTK backend This implements the media tags of HTML5 on the GTK+ port based on the Mac port. Media tests pass although some tests required a small modifications: As per the HTML5 spec, the loading of the clip should start only after all script are done. But in the case of the tests, the loading starts before some callbacks get registered. This has been discussed with Antti Koivisto, and the tests should be updated. There is only one known issue: one time in 10 tries, loading a buffered clip will never end buffering. The buffering will stall at 97% for no apparent reasons. Reloading the page usually works around the problem. On the GStreamer side, some codecs don't return correct values, therefore they make the tests fail. For instance H.264 will make the video-end test fail. This should be fixed in GStreamer 0.10.15. This version displays video in a pop up window. A place holder is drawn on the page where the video should appear. By default, it is turned off in WebCore.pro until GStreamer/X detection issues are sorted out. * WebCore.pro: Disable video for now * platform/Logging.cpp: (WebCore::): * platform/Logging.h: Added a logging level for Media stuff * platform/graphics/Movie.cpp: * platform/graphics/gtk/MoviePrivateGStreamer.cpp: Added. (WebCore::moviePrivateErrorCallback): (WebCore::moviePrivateEOSCallback): (WebCore::moviePrivateStateCallback): (WebCore::moviePrivateBufferingCallback): (WebCore::moviePrivateWindowIDCallback): (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::~MoviePrivate): (WebCore::MoviePrivate::load): (WebCore::MoviePrivate::play): (WebCore::MoviePrivate::pause): (WebCore::MoviePrivate::duration): (WebCore::MoviePrivate::currentTime): (WebCore::MoviePrivate::seek): (WebCore::MoviePrivate::setEndTime): (WebCore::MoviePrivate::addCuePoint): (WebCore::MoviePrivate::removeCuePoint): (WebCore::MoviePrivate::clearCuePoints): (WebCore::MoviePrivate::startCuePointTimerIfNeeded): (WebCore::MoviePrivate::cancelSeek): (WebCore::MoviePrivate::cuePointTimerFired): (WebCore::MoviePrivate::paused): (WebCore::MoviePrivate::seeking): (WebCore::MoviePrivate::naturalSize): (WebCore::MoviePrivate::hasVideo): (WebCore::MoviePrivate::setVolume): (WebCore::MoviePrivate::setMuted): (WebCore::MoviePrivate::setRate): (WebCore::MoviePrivate::dataRate): (WebCore::MoviePrivate::networkState): (WebCore::MoviePrivate::readyState): (WebCore::MoviePrivate::maxTimeBuffered): (WebCore::MoviePrivate::maxTimeSeekable): (WebCore::MoviePrivate::maxTimeLoaded): (WebCore::MoviePrivate::bytesLoaded): (WebCore::MoviePrivate::totalBytesKnown): (WebCore::MoviePrivate::totalBytes): (WebCore::MoviePrivate::cancelLoad): (WebCore::MoviePrivate::updateStates): (WebCore::MoviePrivate::loadStateChanged): (WebCore::MoviePrivate::rateChanged): (WebCore::MoviePrivate::sizeChanged): (WebCore::MoviePrivate::timeChanged): (WebCore::MoviePrivate::volumeChanged): (WebCore::MoviePrivate::didEnd): (WebCore::MoviePrivate::loadingFailed): (WebCore::MoviePrivate::setRect): (WebCore::MoviePrivate::setVisible): (WebCore::MoviePrivate::paint): (WebCore::MoviePrivate::getSupportedTypes): (WebCore::MoviePrivate::createGSTPlayBin): * platform/graphics/gtk/MoviePrivateGStreamer.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Reviewed by Alp Toker. Fix a regression in key press propagation in r28386. Fix indentation (was off by two spaces). * WebView/webkitwebview.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zecke@webkit.org authored
WebCore/ChangeLog: 2007-12-04 Holger Hans Peter Freyther <holger.freyther@trolltech.com> Reviewed by Simon. * Implement the InspectorClient for the Qt port * It does not support highlighting of nodes yet * Use QRC to open the internal page. The important thing is the '/' in the URL to make WebCore::Document::completeURL behave the way we want. * To make the InspectorClient work we will have to mark qrc as secure. * WebCore.pro: * loader/FrameLoader.cpp: (WebCore::localSchemes): * page/inspector/WebKit.qrc: Added. WebKit/qt: 2007-12-04 Holger Hans Peter Freyther <holger.freyther@trolltech.com> Reviewed by Simon. * Implement the InspectorClient for the Qt port * It does not support highlighting of nodes yet * Use QRC to open the internal page. The important thing is the '/' in the URL to make WebCore::Document::completeURL behave the way we want. * To make the InspectorClient work we will have to mark qrc as secure. * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): * Api/qwebpage.h: * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::hideEvent): (WebCore::InspectorClientQt::InspectorClientQt): (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::createPage): (WebCore::InspectorClientQt::localizedStringsURL): (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow): (WebCore::InspectorClientQt::attachWindow): (WebCore::InspectorClientQt::detachWindow): * WebCoreSupport/InspectorClientQt.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Reviewed by Alp Toker. http://bugs.webkit.org/show_bug.cgi?id=15911 [GTK] Use GtkBindingSet to make key bindings user-configurable This patch doesn't cover the full range of bindings, only the ones that seem obviously correct and have clear public API. * WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress): do not handle clipboard operations and select-all * WebView/webkitwebview.cpp: add cut, copy, paste and select-all signals and allow binding sets (issue #15911 and #16144) * WebView/webkitwebview.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Fix a clobbered copyright header. * DumpRenderTree/gtk/DumpRenderTree.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Reviewed by Alp Toker. http://bugs.webkit.org/show_bug.cgi?id=15561 GTK port needs DumpRenderTree implementation Start work on the GTK+ DRT. This does not work yet, and there are a few lingering style issues (nothing major) but this patch has been stuck in the bug tracker for too long already. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrowe@apple.com authored
Roll out r28359 as it causes serious problems with tabbed browsing in Safari when viewing pages containing plugins (<rdar://problem/5627529>). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Rubber stamped by Mark Rowe. Remove two unused variables to silence warnings. * html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pewtermoose@webkit.org authored
Make the bullets lickable. * wwwroot/planetwebkit.css: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pewtermoose@webkit.org authored
Make it sexy with awesome icon and tweaks from Tim. * templates/index.html.tmpl: * wwwroot/ie.css: Added. * wwwroot/images/ie-nav-blue.png: Added. * wwwroot/planetwebkit.css: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 03 Dec, 2007 14 commits
-
-
ddkilzer@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
and remove the dependance on CoreFoundation by using WTF::HashSet. Reviewed by Geoff and Oliver. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added. * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added. * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added. * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h. * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed. * DumpRenderTree/mac/JavaScriptThreading.h: Removed. * DumpRenderTree/pthreads: Added. * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp. (javaScriptThreads): (runJavaScriptThread): (startJavaScriptThreads): (stopJavaScriptThreads): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
Reviewed by Darin Adler. * Drosera/debugger.js: Fixed javascript error where document property should have been used instead of contentDocument in switchFunction that was breaking the select symbol dropdown menu. This is because window.frames will return a Window object and not a frame object like the author was originally expecting. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
Reviewed by Darin Adler. - fix <rdar://problem/5134044> fast/frames/frame-src-attribute.html fails on Windows * platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleWidth): Do not return negative values. (WebCore::ScrollView::visibleHeight): Ditto. LayoutTests: Reviewed by Darin Adler. - remove passing test * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
Reviewed by Dave Hyatt. - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame Test: fast/events/resize-subframe.html * page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added a timer used when deferring tasks that need to be done after layout. (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::layout): Moved the updating of widget positions, loading plug-ins and sending events queued up during layout into performPostLayoutTasks(). performPostLayoutTasks() is called after layout unless the layout was triggered by a previous layout's post- layout tasks. In the latter case, performPostLayoutTasks() is scheduled to run later. (WebCore::FrameView::performPostLayoutTasks): Performs work that needs to be done after layout but which can result in arbitrary code execution and therefore may re-invalidate the layout. This includes updating widget positions, loading plug-ins, and dispatching layout- related DOM events (scroll, overflow and resize). (WebCore::FrameView::postLayoutTimerFired): (WebCore::FrameView::dispatchScheduledEvents): * page/FrameView.h: * page/mac/WebCoreFrameBridge.h: * page/mac/WebCoreFrameBridge.mm: Removed -sendResizeEvent since this is handled by FrameView now. WebKit/gtk: Reviewed by Dave Hyatt. - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame * WebView/webkitwebview.cpp: Remove the call to sendResizeEvent() since FrameView sends it now. WebKit/mac: Reviewed by Dave Hyatt. - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame * WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code that checked if the view had resized and sent the resize event, since FrameView sends resize events now. * WebView/WebHTMLViewInternal.h: WebKit/win: Reviewed by Dave Hyatt. - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame * WebView.cpp: (WebViewWndProc): Removed call to sendResizeEvent() since FrameView sends them now. LayoutTests: Reviewed by Dave Hyatt. - test for <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame * fast/events/resize-subframe-expected.txt: Added. * fast/events/resize-subframe.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
Reviewed by Geoff. - fix http://bugs.webkit.org/show_bug.cgi?id=15618 <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618) Test: fast/js/recursion-limit-equal.html * kjs/operations.cpp: (KJS::equal): Check the exception from toPrimitive. LayoutTests: Reviewed by Geoff. - test for http://bugs.webkit.org/show_bug.cgi?id=15618 <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618) * fast/js/recursion-limit-equal-expected.txt: Added. * fast/js/recursion-limit-equal.html: Added. * fast/js/resources/recursion-limit-equal.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kmccullough@apple.com authored
Reviewed by Adam. - <rdar://5618942> Drosera: Console window does not process everything correctly. - <rdar://5619005> Drosera: could be sped up by moving the WebScriptScope stuff into the WebScriptCallFrame. - Now the console can correctly process objects and does not receive notifications from JavaScriptCore about the JavaScript in Drosera's own process. * Interfaces/IWebScriptCallFrame.idl: Moved the variable lookup functions from WebScriptScope to here. * Interfaces/WebKit.idl: Removed WebScriptScope. * WebKit.vcproj/Interfaces.vcproj: Ditto. * WebKit.vcproj/WebKit.vcproj: Ditto. * WebKit.vcproj/WebKitGUID.vcproj: Ditto. * WebScriptCallFrame.cpp: Moved WebScriptScope functionality into here. (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Now returns a string value for things that are not strings. (WebScriptCallFrame::variableNames): Moved from WebScriptScope. (WebScriptCallFrame::valueForVariable): Moved from WebScriptScope. (WebScriptCallFrame::jsValueToString): Helper functions that converts any JSValue to a String. * WebScriptCallFrame.h: Moved WebScriptScope functionality into here. * WebScriptDebugger.cpp: Added nested guards so that Drosera does not receive notifications about JavaScript that Drosera is running just the JavaScript WebKit is running. (WebScriptDebugger::WebScriptDebugger): (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception): * WebScriptDebugger.h: Ditto. * WebScriptScope.cpp: Removed. * WebScriptScope.h: Removed. WebKitTools: Reviewed by Adam. - <rdar://5618942> Drosera: Console window does not process everything correctly. - <rdar://5619005> Drosera: could be sped up by moving the WebScriptScope stuff into the WebScriptCallFrame. - Now the console can correctly process objects and does not receive notifications from JavaScriptCore about the JavaScript in Drosera's own process. * Drosera/win/DebuggerDocumentPlatform.cpp: (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
* bindings/npruntime.cpp: (_NPN_GetIntIdentifier): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
slewis@apple.com authored
* Scripts/check-for-global-initializers: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
Reviewed by Darin Adler. - fix an ASSERT when getIntIdentifier is called with 0 or -1 * bindings/npruntime.cpp: (_NPN_GetIntIdentifier): We cannot use the hashmap for 0 and -1 since they are the empty value and the deleted value. Instead, keep the identifiers for those two integers in a static array. WebKitTools: Reviewed by Darin Adler. - added a testGetIntIdentifier() method to TestNetscapePlugIn * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): LayoutTests: Reviewed by Darin Adler. - added a test of the behavior of getIntIdentifier with the integers 0 and -1 * plugins/getintidentifier-special-values-expected.txt: Added. * plugins/getintidentifier-special-values.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations to return a pointer to the implementation struct instead of a copy of the struct. This changes all of the callers to dereference the pointer to access the struct fields. * Plugins/WebNullPluginView.mm: (-[WebNullPluginView reportFailure]): * WebCoreSupport/WebFrameBridge.mm: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::willCacheResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): * WebView/WebView.mm: (WebViewGetResourceLoadDelegateImplementations): (WebViewGetFrameLoadDelegateImplementations): (-[WebView _dispatchDidReceiveIconFromWebFrame:]): * WebView/WebViewInternal.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rwlbuis@webkit.org authored
http://bugs.webkit.org/show_bug.cgi?id=15767 Text decorations do not respect "visibility" property Only paint decorations if visibility is "visible". git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-